⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jun 29, 2014:

11:36 PM Changeset in webkit [170578] by psolanki@apple.com
  • 4 edits in trunk/Source/WebCore

Create NSURLRequest lazily when USE(CFNETWORK) is enabled
​https://bugs.webkit.org/show_bug.cgi?id=134441

Reviewed by Sam Weinig.

No new tests. Should be covered by exsting tests.

  • platform/network/cf/ResourceRequest.h:

(WebCore::ResourceRequest::ResourceRequest):

  • platform/network/cf/ResourceRequestCFNet.cpp:

(WebCore::ResourceRequest::doUpdatePlatformRequest):
(WebCore::ResourceRequest::doUpdatePlatformHTTPBody):
(WebCore::ResourceRequest::setStorageSession):

  • platform/network/cocoa/ResourceRequestCocoa.mm:

(WebCore::ResourceRequest::nsURLRequest):

9:43 PM Changeset in webkit [170577] by ryuan.choi@samsung.com
  • 2 edits
    2 deletes in trunk/Source/WebCore

[EFL] Remove netscape plugin implementation from WebCore
​https://bugs.webkit.org/show_bug.cgi?id=134438

Reviewed by Gyuyoung Kim.

Because WebKit1/Efl was dropped, PluginPackageEfl.cpp and PluginViewEfl.cpp are not necessary.

  • PlatformEfl.cmake:
  • plugins/efl/PluginPackageEfl.cpp: Removed.
  • plugins/efl/PluginViewEfl.cpp: Removed.
  • plugins/x11/PluginViewX11.cpp: Removed.

This file is to share common code between WebKit1/Efl and WebKit1/GTk.
Now, both ports are dropped WebKit1 support and the GTK port already removed the related files at r167016.

9:07 PM Changeset in webkit [170576] by yoav@yoav.ws
  • 30 edits
    19 adds in trunk

Add support for HTMLImageElement's sizes attribute
​https://bugs.webkit.org/show_bug.cgi?id=133620

Reviewed by Dean Jackson.

.:
Added an ENABLE_PICTURE_SIZES compile flag.

  • Source/cmake/WebKitFeatures.cmake:
  • Source/cmakeconfig.h.cmake:

Source/JavaScriptCore:
Added an ENABLE_PICTURE_SIZES compile flag.

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:
Tests: fast/dom/HTMLImageElement/sizes/image-sizes-1x.html

fast/dom/HTMLImageElement/sizes/image-sizes-2x.html
fast/dom/HTMLImageElement/sizes/image-sizes-js-change.html
fast/dom/HTMLImageElement/sizes/image-sizes-js-innerhtml.html
http/tests/loading/sizes/preload-image-sizes-2x.html
http/tests/loading/sizes/preload-image-sizes.html

This patch adds support for HTMLImageElement's sizes attribute and the
related srcset extended syntax as defined in
​http://picture.responsiveimages.org/.
This sizes attribute syntax is added to the CSSGrammar and parsed by
the CSSParser.
The SourceSizeList class is generated by the parser, and used to get
the final source size.
HTMLImageElement and HTMLPreloadScanner send this value to
HTMLSrcsetParser.
HTMLSrcsetParser uses this value in order to pick the right resource.

  • CMakeLists.txt: Added css/SourceSizeList.cpp.
  • Configurations/FeatureDefines.xcconfig: Added the PICTURE_SIZES flag.
  • WebCore.vcxproj/WebCore.vcxproj: Added css/SourceSizeList.*.
  • WebCore.vcxproj/WebCore.vcxproj.filters: Added css/SourceSizeList.*.
  • WebCore.xcodeproj/project.pbxproj: Added css/SourceSizeList.*.
  • css/CSSGrammar.y.in: Added 4 grammar rules that define a Media condition,

Source size list, Source size length and source size.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseSizesAttribute): Parse the sizes attribute.
(WebCore::CSSParser::detectAtToken): Set the token to SIZESATTR.

  • css/CSSParser.h:
  • css/SourceSizeList.cpp: Added. Defined the SourceSize and SourceSizeList classes.

(WebCore::SourceSize::match):
(WebCore::computeLength):
(WebCore::defaultValue):
(WebCore::SourceSize::length):
(WebCore::SourceSizeList::parseSizesAttribute):
(WebCore::SourceSizeList::getEffectiveSize):

  • css/SourceSizeList.h: Added.

(WebCore::SourceSize::SourceSize):
(WebCore::SourceSizeList::append):

  • html/HTMLImageElement.cpp: Integrated sizes attribute parsing and added currentSrc.

(WebCore::HTMLImageElement::setBestFitURLAndDPRFromImageCandidate):
(WebCore::HTMLImageElement::parseAttribute):
(WebCore::HTMLImageElement::currentSrc):

  • html/HTMLImageElement.h:
  • html/HTMLImageElement.idl:
  • html/parser/HTMLDocumentParser.cpp: Added information required for sizes parsing to

HTMLPreloadScanner calls.
(WebCore::HTMLDocumentParser::pumpTokenizer):
(WebCore::HTMLDocumentParser::insert):
(WebCore::HTMLDocumentParser::append):
(WebCore::HTMLDocumentParser::appendCurrentInputStreamToPreloadScannerAndScan):

  • html/parser/HTMLPreloadScanner.cpp: Integrated sizes attribute parsing.

(WebCore::TokenPreloadScanner::StartTagScanner::processAttributes):
(WebCore::TokenPreloadScanner::StartTagScanner::processAttribute):
(WebCore::TokenPreloadScanner::scan):
(WebCore::HTMLPreloadScanner::scan):

  • html/parser/HTMLPreloadScanner.h:
  • html/parser/HTMLSrcsetParser.cpp: Added 'w' descriptor parsing sizes based normalization.

(WebCore::parseDescriptors):
(WebCore::pickBestImageCandidate):
(WebCore::bestFitSourceForImageAttributes):

  • html/parser/HTMLSrcsetParser.h:

Source/WebKit/mac:
Added an ENABLE_PICTURE_SIZES compile flag.

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:
Added an ENABLE_PICTURE_SIZES compile flag.

  • Configurations/FeatureDefines.xcconfig:

Tools:
Added an ENABLE_PICTURE_SIZES compile flag.

  • Scripts/webkitperl/FeatureList.pm:

LayoutTests:
These layout tests check that the sizes attribute and the related
srcset syntax are well supported, that the right resource is displayed,
that the currentSrc attribute is well supported and also that the right
resource is preloaded.

  • fast/dom/HTMLImageElement/resources/currentSrcHelper.js: Added.

(fileName):
(currentSrcFileName):

  • fast/dom/HTMLImageElement/resources/image-set-4x.png: Added.
  • fast/dom/HTMLImageElement/sizes/image-sizes-1x-expected.txt: Added.
  • fast/dom/HTMLImageElement/sizes/image-sizes-1x.html: Added.
  • fast/dom/HTMLImageElement/sizes/image-sizes-2x-expected.txt: Added.
  • fast/dom/HTMLImageElement/sizes/image-sizes-2x.html: Added.
  • fast/dom/HTMLImageElement/sizes/image-sizes-js-change-expected.txt: Added.
  • fast/dom/HTMLImageElement/sizes/image-sizes-js-change.html: Added.
  • fast/dom/HTMLImageElement/sizes/image-sizes-js-innerhtml-expected.txt: Added.
  • fast/dom/HTMLImageElement/sizes/image-sizes-js-innerhtml.html: Added.
  • http/tests/loading/sizes/preload-image-sizes-2x-expected.txt: Added.
  • http/tests/loading/sizes/preload-image-sizes-2x.html: Added.
  • http/tests/loading/sizes/preload-image-sizes-expected.txt: Added.
  • http/tests/loading/sizes/preload-image-sizes.html: Added.
2:51 PM Changeset in webkit [170575] by akling@apple.com
  • 4 edits in trunk/Source/WebCore

No need to lazily initialize ResourceResponse internals when accessing timing data.
<​https://webkit.org/b/134437>
<rdar://problem/17499876>

When building with ENABLE(WEB_TIMING), the last thing that would happen when
serializing a ResourceResponse in the network process is that we'd retrieve
the ResourceLoadTiming to encode it as part of the response. Doing so would
trigger the lazy instantiation of ResourceResponse's internal data structures.

Since timing data is not actually lazily instantiated, we can just not do that.

This shaves off ~550ms of network process main thread time on PLT, reducing
response latency by not doing unnecessary stuff before letting the web process
look at the downloaded data.

Reviewed by Gavin Barraclough.

  • WebCore.exp.in:
  • platform/network/ResourceResponseBase.cpp:

(WebCore::ResourceResponseBase::adopt):
(WebCore::ResourceResponseBase::resourceLoadTiming): Deleted.
(WebCore::ResourceResponseBase::setResourceLoadTiming): Deleted.

  • platform/network/ResourceResponseBase.h:

(WebCore::ResourceResponseBase::resourceLoadTiming):

1:59 PM Changeset in webkit [170574] by psolanki@apple.com
  • 4 edits
    1 copy
    2 adds in trunk/Source/WebCore

Refactor ResourceRequest into Cocoa and iOS specific files
​https://bugs.webkit.org/show_bug.cgi?id=134430

Reviewed by Andreas Kling.

No new tests because no functional changes.

  • WebCore.xcodeproj/project.pbxproj:
  • platform/network/cf/ResourceRequestCFNet.cpp:

(WebCore::ResourceRequest::applyWebArchiveHackForMail): Deleted.

  • platform/network/cocoa/ResourceRequestCocoa.mm: Copied from Source/WebCore/platform/network/mac/ResourceRequestMac.mm.

(WebCore::ResourceRequest::nsURLRequest):
(WebCore::ResourceRequest::cfURLRequest):
(WebCore::ResourceRequest::doUpdateResourceRequest):
(WebCore::ResourceRequest::doUpdateResourceHTTPBody):
(WebCore::ResourceRequest::doUpdatePlatformRequest):
(WebCore::ResourceRequest::doUpdatePlatformHTTPBody):
(WebCore::ResourceRequest::updateFromDelegatePreservingOldProperties):
(WebCore::ResourceRequest::applyWebArchiveHackForMail):
(WebCore::ResourceRequest::setStorageSession):

  • platform/network/ios/ResourceRequestIOS.mm: Added.

(WebCore::ResourceRequest::useQuickLookResourceCachingQuirks):
(WebCore::ResourceRequest::ResourceRequest):
(WebCore::ResourceRequest::updateNSURLRequest):

  • platform/network/mac/ResourceRequestMac.mm:

(WebCore::initQuickLookResourceCachingQuirks):
(WebCore::ResourceRequest::useQuickLookResourceCachingQuirks):
(WebCore::ResourceRequest::ResourceRequest):
(WebCore::ResourceRequest::updateNSURLRequest):
(WebCore::ResourceRequest::applyWebArchiveHackForMail):
(WebCore::ResourceRequest::nsURLRequest): Deleted.
(WebCore::ResourceRequest::cfURLRequest): Deleted.
(WebCore::ResourceRequest::doUpdateResourceRequest): Deleted.
(WebCore::ResourceRequest::doUpdateResourceHTTPBody): Deleted.
(WebCore::ResourceRequest::doUpdatePlatformRequest): Deleted.
(WebCore::ResourceRequest::doUpdatePlatformHTTPBody): Deleted.
(WebCore::ResourceRequest::updateFromDelegatePreservingOldProperties): Deleted.
(WebCore::ResourceRequest::setStorageSession): Deleted.

10:10 AM Changeset in webkit [170573] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

TextCodecICU::encode turns the whole string as yen signs if there is any backslash in it
​https://bugs.webkit.org/show_bug.cgi?id=133678

Patch by Youenn Fablet <​youenn.fablet@crf.canon.fr> on 2014-06-29
Reviewed by Alexey Proskuryakov.

Source/WebCore:
Test: fast/encoding/backslash-encoding-jp.html

  • platform/text/TextCodecICU.cpp:

(WebCore::TextCodecICU::encode): fixed the copy of characters other than backslash.

LayoutTests:

  • fast/encoding/backslash-encoding-jp-expected.txt: Added.
  • fast/encoding/backslash-encoding-jp.html: Added.
8:27 AM BuildingQtOnWindows edited by mhazadmanesh2009@gmail.com
small "typo" (diff)
8:18 AM BuildingQtOnWindows edited by mhazadmanesh2009@gmail.com
Added the SQLite dependency information, added some notes and a bit … (diff)

Jun 28, 2014:

7:44 PM Changeset in webkit [170572] by dino@apple.com
  • 2 edits in trunk/Source/WebCore

[iOS] Pinching into a video (fullscreen gesture) leaves page zoomed in
​https://bugs.webkit.org/show_bug.cgi?id=134433
<rdar://problem/16630794>

Reviewed by Eric Carlson.

Detect the number of target touches (those directly on the
video element) and disable the page zoom if it looks
like the user is trying to trigger fullscreen.

  • Modules/mediacontrols/mediaControlsiOS.js:

(ControllerIOS.prototype.handleBaseGestureStart): If we are seeing
two touches in this video element, don't trigger fullscreen. The
exception is if we haven't yet started playback.
(ControllerIOS.prototype.handleBaseGestureChange): Don't allow fullscreen
if we haven't started playback (iOS 7 behaviour).
(ControllerIOS.prototype.handleWrapperTouchStart): Keep track of the
number of targetted touches.

4:49 PM Changeset in webkit [170571] by fpizlo@apple.com
  • 17 edits in branches/ftlopt/Source/JavaScriptCore

[ftlopt] Reduce the GC's influence on optimization decisions
​https://bugs.webkit.org/show_bug.cgi?id=134427

Reviewed by Oliver Hunt.

This is a slight speed-up on some platforms, that arises from a bunch of fixes that I made
while trying to make the GC keep more structures alive
(​https://bugs.webkit.org/show_bug.cgi?id=128072).

The fixes are, roughly:

  • If the GC clears an inline cache, then this no longer causes the IC to be forever polymorphic.


  • If we exit in inlined code into a function that tries to OSR enter, then we jettison sooner.


  • Some variables being uninitialized led to rage-recompilations.


This is a pretty strong step in the direction of keeping more Structures alive and not
blowing away code just because a Structure died. But, it seems like there is still a slight
speed-up to be had from blowing away code that references dead Structures.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dumpAssumingJITType):
(JSC::shouldMarkTransition):
(JSC::CodeBlock::propagateTransitions):
(JSC::CodeBlock::determineLiveness):

  • bytecode/GetByIdStatus.cpp:

(JSC::GetByIdStatus::computeForStubInfo):

  • bytecode/PutByIdStatus.cpp:

(JSC::PutByIdStatus::computeForStubInfo):

  • dfg/DFGCapabilities.cpp:

(JSC::DFG::isSupportedForInlining):
(JSC::DFG::mightInlineFunctionForCall):
(JSC::DFG::mightInlineFunctionForClosureCall):
(JSC::DFG::mightInlineFunctionForConstruct):

  • dfg/DFGCapabilities.h:
  • dfg/DFGCommonData.h:
  • dfg/DFGDesiredWeakReferences.cpp:

(JSC::DFG::DesiredWeakReferences::reallyAdd):

  • dfg/DFGOSREntry.cpp:

(JSC::DFG::prepareOSREntry):

  • dfg/DFGOSRExitCompilerCommon.cpp:

(JSC::DFG::handleExitCounts):

  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:
  • ftl/FTLForOSREntryJITCode.cpp:

(JSC::FTL::ForOSREntryJITCode::ForOSREntryJITCode): These variables being uninitialized is benign in terms of correctness but can sometimes cause rage-recompilations. For some reason it took this patch to reveal this.

  • ftl/FTLOSREntry.cpp:

(JSC::FTL::prepareOSREntry):

  • runtime/Executable.cpp:

(JSC::ExecutableBase::destroy):
(JSC::NativeExecutable::destroy):
(JSC::ScriptExecutable::ScriptExecutable):
(JSC::ScriptExecutable::destroy):
(JSC::ScriptExecutable::installCode):
(JSC::EvalExecutable::EvalExecutable):
(JSC::ProgramExecutable::ProgramExecutable):

  • runtime/Executable.h:

(JSC::ScriptExecutable::setDidTryToEnterInLoop):
(JSC::ScriptExecutable::didTryToEnterInLoop):
(JSC::ScriptExecutable::addressOfDidTryToEnterInLoop):
(JSC::ScriptExecutable::ScriptExecutable): Deleted.

  • runtime/StructureInlines.h:

(JSC::Structure::storedPrototypeObject):
(JSC::Structure::storedPrototypeStructure):

3:39 PM Changeset in webkit [170570] by timothy_horton@apple.com
  • 10 edits in trunk/Source/WebKit2

[iOS][WK2] PDFs never load inline again after the Web process crashes
​https://bugs.webkit.org/show_bug.cgi?id=134432
<rdar://problem/17484205>

Reviewed by Dan Bernstein.

After a crash, the WebPage never gets mimeTypesWithCustomContentProviders filled back in.

  • Shared/WebPageCreationParameters.cpp:

(WebKit::WebPageCreationParameters::encode):
(WebKit::WebPageCreationParameters::decode):

  • Shared/WebPageCreationParameters.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::creationParameters):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):
Add mimeTypesWithCustomContentProviders to WebPageCreationParameters.

  • UIProcess/Cocoa/WKWebViewContentProviderRegistry.h:
  • UIProcess/Cocoa/WKWebViewContentProviderRegistry.mm:

(-[WKWebViewContentProviderRegistry addPage:]):
We don't need to send the MIME types across when a page is added, because it already got them in its creation parameters.

(-[WKWebViewContentProviderRegistry removePage:]):
(-[WKWebViewContentProviderRegistry _mimeTypesWithCustomContentProviders]):
Return a vector of all registered MIME types.

  • UIProcess/ios/PageClientImplIOS.h:
  • UIProcess/ios/PageClientImplIOS.mm:

(WebKit::PageClientImpl::mimeTypesWithCustomContentProviders):

  • UIProcess/PageClient.h:

Add (iOS only for now) mimeTypesWithCustomContentProviders to PageClient.

3:31 PM Changeset in webkit [170569] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit2

REGRESSION: WebPageProxy::attributedSubstringForCharacterRangeAsync never calls its callback function
​https://bugs.webkit.org/show_bug.cgi?id=134429

Reviewed by Tim Horton.

  • UIProcess/mac/WebPageProxyMac.mm:

(WebKit::WebPageProxy::attributedSubstringForCharacterRangeAsync):

7:50 AM Changeset in webkit [170568] by Simon Fraser
  • 7 edits in trunk/Source

[iOS WK2] position:fixed inside accelerated overflow:scroll is jumpy
​https://bugs.webkit.org/show_bug.cgi?id=134426
<rdar://problem/17474523>

Reviewed by Tim Horton.

After committing a new layer tree (with possibly stale position:fixed layer
positions), we need the scrolling tree to update those positions based on
the current scroll offset.

Source/WebCore:
Give ScrollingTreeScrollingNode an implementation of updateLayersAfterAncestorChange()
which is required to update fixed/sticky child nodes.

  • WebCore.exp.in:
  • page/scrolling/ScrollingTreeScrollingNode.cpp:

(WebCore::ScrollingTreeScrollingNode::updateLayersAfterAncestorChange):

  • page/scrolling/ScrollingTreeScrollingNode.h:

Source/WebKit2:
To achieve that, implement ScrollingTreeOverflowScrollingNodeIOS::updateLayersAfterAncestorChange()
and have it add to the cumulative delta the difference between the last committed scroll
position and the current scroll position.

Also make sure that ScrollingTreeOverflowScrollingNodeIOS doesn't call back to scrollViewDidScroll()
when we're updating its scroll position inside a scrolling tree commit.

  • UIProcess/Scrolling/ios/ScrollingTreeOverflowScrollingNodeIOS.h:
  • UIProcess/Scrolling/ios/ScrollingTreeOverflowScrollingNodeIOS.mm:

(WebKit::ScrollingTreeOverflowScrollingNodeIOS::ScrollingTreeOverflowScrollingNodeIOS):
(WebKit::ScrollingTreeOverflowScrollingNodeIOS::updateAfterChildren):
(WebKit::ScrollingTreeOverflowScrollingNodeIOS::updateLayersAfterAncestorChange):
(WebKit::ScrollingTreeOverflowScrollingNodeIOS::scrollViewDidScroll):

2:06 AM Changeset in webkit [170567] by commit-queue@webkit.org
  • 11 edits in trunk/Source/WebCore

[GTK] Use public getter/setter in GObject DOM bindings properties implementation.
​https://bugs.webkit.org/show_bug.cgi?id=134390.

Patch by Juan A. Suarez Romero <​jasuarez@igalia.com> and Carlos Garcia Campos <​cgarcia@igalia.com> on 2014-06-28
Reviewed by Carlos Garcia Campos.

The current GObject DOM bindings generator is duplicating code when
implementing the get/set_property methods and the public
getters/setters, instead of making one invoking the other.

This commit changes this behaviour so the code is not duplicated,
making it easier to maintain.

No new tests needed.

  • bindings/scripts/CodeGeneratorGObject.pm:

(GenerateProperty):
(GenerateProperties):
(WriteData):
(GetCoreObject): Deleted.

  • bindings/scripts/test/GObject/WebKitDOMTestActiveDOMObject.cpp:

(webkit_dom_test_active_dom_object_get_property):

  • bindings/scripts/test/GObject/WebKitDOMTestEventConstructor.cpp:

(webkit_dom_test_event_constructor_get_property):

  • bindings/scripts/test/GObject/WebKitDOMTestException.cpp:

(webkit_dom_test_exception_get_property):

  • bindings/scripts/test/GObject/WebKitDOMTestInterface.cpp:

(webkit_dom_test_interface_set_property):
(webkit_dom_test_interface_get_property):

  • bindings/scripts/test/GObject/WebKitDOMTestNondeterministic.cpp:

(webkit_dom_test_nondeterministic_set_property):
(webkit_dom_test_nondeterministic_get_property):

  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:

(webkit_dom_test_obj_set_property):
(webkit_dom_test_obj_get_property):

  • bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.cpp:

(webkit_dom_test_serialized_script_value_interface_get_property):

  • bindings/scripts/test/GObject/WebKitDOMTestTypedefs.cpp:

(webkit_dom_test_typedefs_set_property):
(webkit_dom_test_typedefs_get_property):

  • bindings/scripts/test/GObject/WebKitDOMattribute.cpp:

(webkit_dom_test_exception_get_property):
(webkit_dom_attribute_get_property):

1:44 AM Changeset in webkit [170566] by stavila@adobe.com
  • 3 edits
    2 adds in trunk

[New Multicolumn] Elements with rounded corners and overflow:hidden do not properly clip their content
​https://bugs.webkit.org/show_bug.cgi?id=133941

Reviewed by Darin Adler.

Source/WebCore:
When having a multicol element inside an element with overflow:hidden and border-radius,
the fragments representing the columns need to have the border radius set also, to ensure
proper clipping.

Test: fast/multicol/newmulticol/multicol-clip-rounded-corners.html

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::collectFragments):

LayoutTests:
Added test for multicol element inside an element with overflow:hidden and border radius.

  • fast/multicol/newmulticol/multicol-clip-rounded-corners-expected.html: Added.
  • fast/multicol/newmulticol/multicol-clip-rounded-corners.html: Added.
Note: See TracTimeline for information about the timeline view.