Timeline
Jun 30, 2014:
- 9:16 PM Changeset in webkit [170630] by
-
- 7 edits in trunk/Source
Unreviewed, rolling out r170605.
https://bugs.webkit.org/show_bug.cgi?id=134484
The changes cause crashes on ARM64 (Requested by benjaminp on
#webkit).
Reverted changeset:
"Reduce dynamic memory allocation in css jit."
https://bugs.webkit.org/show_bug.cgi?id=134416
http://trac.webkit.org/changeset/170605
- 8:12 PM Changeset in webkit [170629] by
-
- 2 edits in trunk/Source/WebKit2
[iOS][WK2] The long press gesture recognizers should not block the pinch gesture
https://bugs.webkit.org/show_bug.cgi?id=134477
<rdar://problem/17514936>
Reviewed by Tim Horton.
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView gestureRecognizer:canPreventGestureRecognizer:]):
- 7:19 PM Changeset in webkit [170628] by
-
- 8 edits21 adds in branches/ftlopt
Merge r169121 from trunk.
2014-05-19 Mark Hahnenberg <mhahnenberg@apple.com>
JSArray::shiftCountWith* could be more efficient
https://bugs.webkit.org/show_bug.cgi?id=133011
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
Our current implementations of shiftCountWithAnyIndexingType and shiftCountWithArrayStorage
are scared of the presence of any holes in the array. We can mitigate this somewhat by enabling
them to correctly handle holes, thus avoiding the slowest of slow paths in most cases.
- runtime/ArrayStorage.h: (JSC::ArrayStorage::indexingHeader): (JSC::ArrayStorage::length): (JSC::ArrayStorage::hasHoles):
- runtime/IndexingHeader.h: (JSC::IndexingHeader::publicLength): (JSC::IndexingHeader::from):
- runtime/JSArray.cpp: (JSC::JSArray::shiftCountWithArrayStorage): (JSC::JSArray::shiftCountWithAnyIndexingType): (JSC::JSArray::unshiftCountWithArrayStorage):
- runtime/JSArray.h: (JSC::JSArray::shiftCountForShift): (JSC::JSArray::shiftCountForSplice): (JSC::JSArray::shiftCount):
- runtime/Structure.cpp: (JSC::Structure::holesRequireSpecialBehavior):
- runtime/Structure.h:
LayoutTests:
Added a performance regression test which tests the contiguous shift case. We're ~85% faster
on this microbenchmark with this patch.
Also added a bunch of tests for each permutation of contiguous/array storage with no holes, holes,
and holes that require special behavior (e.g. indexed properties in the prototype chain).
- js/array-storage-splice-holes-expected.txt: Added.
- js/array-storage-splice-holes-require-special-behavior-expected.txt: Added.
- js/array-storage-splice-holes-require-special-behavior.html: Added.
- js/array-storage-splice-holes.html: Added.
- js/array-storage-splice-no-holes-expected.txt: Added.
- js/array-storage-splice-no-holes.html: Added.
- js/contiguous-splice-holes-expected.txt: Added.
- js/contiguous-splice-holes-require-special-behavior-expected.txt: Added.
- js/contiguous-splice-holes-require-special-behavior.html: Added.
- js/contiguous-splice-holes.html: Added.
- js/contiguous-splice-no-holes-expected.txt: Added.
- js/contiguous-splice-no-holes.html: Added.
- js/regress/array-splice-contiguous-expected.txt: Added.
- js/regress/array-splice-contiguous.html: Added.
- js/regress/script-tests/array-splice-contiguous.js: Added. (foo):
- js/script-tests/array-storage-splice-holes-require-special-behavior.js: Added.
- js/script-tests/array-storage-splice-holes.js: Added.
- js/script-tests/array-storage-splice-no-holes.js: Added.
- js/script-tests/contiguous-splice-holes-require-special-behavior.js: Added.
- js/script-tests/contiguous-splice-holes.js: Added.
- js/script-tests/contiguous-splice-no-holes.js: Added.
- 6:40 PM Changeset in webkit [170627] by
-
- 3 edits in trunk/Source/WebKit2
Add WebPageProxy::restoreFromState
https://bugs.webkit.org/show_bug.cgi?id=134480
Reviewed by Tim Horton.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::restoreFromState):
- UIProcess/WebPageProxy.h:
- 6:29 PM Changeset in webkit [170626] by
-
- 4 edits in trunk/Source/WebKit2
Add a function to restore a WebBackForwardList object from a BackForwardListState object
https://bugs.webkit.org/show_bug.cgi?id=134478
Reviewed by Tim Horton.
- UIProcess/WebBackForwardList.cpp:
(WebKit::generateWebBackForwardItemID):
(WebKit::WebBackForwardList::restoreFromState):
- UIProcess/WebBackForwardList.h:
- UIProcess/cf/WebBackForwardListCF.cpp:
(WebKit::generateWebBackForwardItemID): Deleted.
- 6:06 PM Changeset in webkit [170625] by
-
- 10 edits in trunk/Source
Change the AddBackForwardItem message to take a page state object
https://bugs.webkit.org/show_bug.cgi?id=134475
Reviewed by Andreas Kling.
Source/WebCore:
- WebCore.exp.in:
Source/WebKit2:
- Scripts/webkit2/messages.py:
(struct_or_class):
(headers_for_type):
- Shared/WebBackForwardListItem.cpp:
(WebKit::WebBackForwardListItem::create):
(WebKit::WebBackForwardListItem::WebBackForwardListItem):
- Shared/WebBackForwardListItem.h:
(WebKit::WebBackForwardListItem::setPageState):
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::addBackForwardItem):
- UIProcess/WebProcessProxy.h:
- UIProcess/WebProcessProxy.messages.in:
- WebProcess/WebPage/WebBackForwardListProxy.cpp:
(WebKit::updateBackForwardItem):
- 5:50 PM Changeset in webkit [170624] by
-
- 3 edits in trunk/Source/WebKit2
[WK2] Add a flatter find-in-page current match indicator style
https://bugs.webkit.org/show_bug.cgi?id=134434
<rdar://problem/16225673>
Reviewed by Simon Fraser.
- UIProcess/FindIndicator.cpp:
(WebKit::findIndicatorsForTextRectsOverlap):
(WebKit::FindIndicator::frameRect):
(WebKit::flatHighlightColor):
(WebKit::flatRimShadowColor):
(WebKit::flatDropShadowColor):
(WebKit::FindIndicator::draw):
Add a flatter find indicator, with a bigger shadow.
- WebProcess/WebPage/FindController.cpp:
(WebKit::FindController::updateFindUIAfterPageScroll):
(WebKit::FindController::getFindIndicatorBitmapAndRect):
(WebKit::FindController::hideFindIndicator):
(WebKit::FindController::drawRect):
Don't paint a shadow behind the secondary matches if we're using the new style.
- 5:45 PM Changeset in webkit [170623] by
-
- 3 edits in trunk/Tools
[iOS] GSFontAddCGFont is deprecated and we use it in DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=134133
Reviewed by Simon Fraser.
Replace it with CTFontManagerRegisterGraphicsFont
- DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
- DumpRenderTree/mac/DumpRenderTree.mm:
(activateFontIOS):
- 5:42 PM Changeset in webkit [170622] by
-
- 2 edits in trunk/Source/WebKit2
[iOS][WK2] Improve double-tap-to-scroll on image documents
https://bugs.webkit.org/show_bug.cgi?id=134474
<rdar://problem/17496778>
Reviewed by Enrica Casucci.
On image document, we were always rendering the center of the image as the origin, which broke
double tap to scroll.
This patch improves on this in two ways:
1) If the hit testing already got the image, only change the type to replaced (to get the right
scaling behavior for images since the type is block on iOS's image document).
2) If the hit testing is outside the image, only center the axis that is not in the image.
This way, we "fix" the component that is not valid, and keep the vali component.
This works great for viewing comics on iPad.
- WebProcess/WebPage/ViewGestureGeometryCollector.cpp:
(WebKit::ViewGestureGeometryCollector::collectGeometryForSmartMagnificationGesture):
- 5:38 PM Changeset in webkit [170621] by
-
- 2 edits in trunk/Source/WebCore
[iOS][WK2] Do not put tap highlight on images that are not in links, and on applet/embed/object
https://bugs.webkit.org/show_bug.cgi?id=134471
<rdar://problem/17513542>
Reviewed by Enrica Casucci.
UIKit has some special code to avoid tap highlight on certain type of object. This is not very flexible
since the page has no way of overriding that behavior.
This patch implement the same feature by changing the default stylesheet. The tap highlight is disabled
by default for those object, and enabled for images that are in a link.
- css/html.css:
(applet, embed, object, img):
(:-webkit-any-link img):
- 5:27 PM Changeset in webkit [170620] by
-
- 2 edits in trunk/Source/WebKit2
REGRESSION (WK2): Weird selection behavior on autos.yahoo.com, en.wikipedia.org.
https://bugs.webkit.org/show_bug.cgi?id=134466
<rdar://problem/16817263>
Reviewed by Benjamin Poulain.
Avoid selecting blocks across frame boundaries and skip non-selectable
blocks. If the only block we find is almost the same height as the
visible area, we should not select at all.
This patch also fixes the logic to compute the next block when
shrinking the selection. When calculating the new range after shrinking,
we should not include the block that corresponds to the current handle position.
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::rangeForWebSelectionAtPosition):
(WebKit::WebPage::expandedRangeFromHandle):
(WebKit::WebPage::contractedRangeFromHandle):
(WebKit::WebPage::updateSelectionWithTouches):
- 5:17 PM Changeset in webkit [170619] by
-
- 3 edits4 adds in trunk
All Indic text is rendered as boxes on iOS
https://bugs.webkit.org/show_bug.cgi?id=134464
Reviewed by Simon Fraser.
Source/WebCore:
I made a typo in r170207.
Test: fast/text/indic.html
- platform/graphics/ios/FontCacheIOS.mm:
(WebCore::languageSpecificFallbackFont):
LayoutTests:
Simply draw some indic text and test that against currently good metric values.
- fast/text/indic.html: Added
- platform/ios-sim/fast/text/indic-expected.txt: Added.
- platform/mac/fast/text/indic-expected.txt: Added.
- platform/mac/fast/text/indic-expected.png: Added.
- 5:14 PM Changeset in webkit [170618] by
-
- 2 edits in trunk/Source/WebCore
[iOS] languageSpecificFallbackFont() is not consistent
https://bugs.webkit.org/show_bug.cgi?id=134473
Reviewed by Darin Adler.
It can use "<" throughout the function as well as keeping the fallthrough behavior consistent.
No tests because there is no behavior change.
- platform/graphics/ios/FontCacheIOS.mm:
(WebCore::languageSpecificFallbackFont):
- 5:11 PM Changeset in webkit [170617] by
-
- 2 edits in trunk/Source/WebCore
[Win] Unreviewed gardening.
- WebCore.vcxproj/WebCore.vcxproj: Do not compile JSFileException
and JSFileReaderSync multiple times.
- 5:04 PM Changeset in webkit [170616] by
-
- 2 edits in trunk/Source/WebCore
Avoid copying function object in lambda function in ScrollingThread::dispatchBarrier(); actually use move semantics
https://bugs.webkit.org/show_bug.cgi?id=134470
Reviewed by Anders Carlsson.
Currently we always copy construct the captured std::function object when calling callOnMainThread()
in the lambda function created in ScrollingThread::dispatchBarrier() because captured variables are
const in a lambda expression's body by default. That is, the std::function object is captured as const.
Instead, we should mark this lambda expression as mutable so the captured std::function object is
non-const and hence we can use move semantics when passing it to callOnMainThread().
- page/scrolling/ScrollingThread.cpp:
(WebCore::ScrollingThread::dispatchBarrier):
- 5:00 PM Changeset in webkit [170615] by
-
- 2 edits in trunk/Source/WTF
Make TransformIterator::TransformIterator() take rvalue references
https://bugs.webkit.org/show_bug.cgi?id=134468
Reviewed by Darin Adler.
It's unnecessary to support TransformIterator::TransformIterator() taking const lvalue references
as we only call it with rvalues. As a side benefit, we can use move semantics to initialize the
members of TransformIterator.
- wtf/IteratorAdaptors.h:
(WTF::TransformIterator::TransformIterator): Make constructor take arguments as rvalue references.
(WTF::makeTransformIterator): Substitute std::move() for std::forward().
- 4:39 PM Changeset in webkit [170614] by
-
- 5 edits in trunk/Source/WebKit2
WebBackForwardListItem should not store back-forward data
https://bugs.webkit.org/show_bug.cgi?id=134469
Reviewed by Darin Adler.
Change WebBackForwardListItem::backForwardData to encode the main frame state lazily,
and change WebBackForwardListItem::setBackForwardData to decode it into the main frame state.
- Shared/WebBackForwardListItem.cpp:
(WebKit::WebBackForwardListItem::backForwardData):
(WebKit::WebBackForwardListItem::setBackForwardData):
(WebKit::WebBackForwardListItem::encode):
- Shared/WebBackForwardListItem.h:
(WebKit::WebBackForwardListItem::backForwardData): Deleted.
- UIProcess/cf/WebBackForwardListCF.cpp:
(WebKit::WebBackForwardList::createCFDictionaryRepresentation):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::restoreSession):
- 4:26 PM Changeset in webkit [170613] by
-
- 3 edits in trunk/Source/WebKit2
WebBackForwardListItems should hold on to PageState objects
https://bugs.webkit.org/show_bug.cgi?id=134467
Reviewed by Darin Adler.
- Shared/WebBackForwardListItem.cpp:
(WebKit::WebBackForwardListItem::WebBackForwardListItem):
(WebKit::WebBackForwardListItem::encode):
- Shared/WebBackForwardListItem.h:
(WebKit::WebBackForwardListItem::setOriginalURL):
(WebKit::WebBackForwardListItem::originalURL):
(WebKit::WebBackForwardListItem::setURL):
(WebKit::WebBackForwardListItem::url):
(WebKit::WebBackForwardListItem::setTitle):
(WebKit::WebBackForwardListItem::title):
- 4:24 PM Changeset in webkit [170612] by
-
- 2 edits in trunk/Source/WebKit2
Add a missing semicolon in WKContentViewInteraction
- UIProcess/ios/WKContentViewInteraction.mm:
(nsSizeForTapHighlightBorderRadius):
I messed up this when fixing the patch on landing.
- 4:05 PM Changeset in webkit [170611] by
-
- 6 edits in trunk/Source
Adopt the legacy session decoding inside WebPage::restoreSession for now
https://bugs.webkit.org/show_bug.cgi?id=134465
Reviewed by Sam Weinig.
Source/WebCore:
- WebCore.exp.in:
Source/WebKit2:
- UIProcess/mac/LegacySessionStateCoding.cpp:
(WebKit::decodeLegacySessionHistoryEntryData):
- UIProcess/mac/LegacySessionStateCoding.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::restoreSession):
- 3:58 PM Changeset in webkit [170610] by
-
- 2 edits in trunk/Source/WebKit2
[iOS WK2] Don't crash on status bar tap with overflow scroll views
https://bugs.webkit.org/show_bug.cgi?id=134459
Reviewed by Tim Horton.
The tiled scrolling indicator parents UIViews under CALayers, but that causes
those views to miss -willMoveToWindow:nil notifications on teardown. This can leave
deleted UIScrollViews in UIKit's "scroll to top" list.
Fix by not making UIScrollViews in the debug layer tree host.
- UIProcess/ios/RemoteLayerTreeHostIOS.mm:
(WebKit::RemoteLayerTreeHost::createLayer):
- 3:52 PM Changeset in webkit [170609] by
-
- 4 edits in trunk/Source/WebCore
Unreviewed, rolling out r170578.
https://bugs.webkit.org/show_bug.cgi?id=134462
causes assertions loading nytimes.com on iOS (Requested by
smfr on #webkit).
Reverted changeset:
"Create NSURLRequest lazily when USE(CFNETWORK) is enabled"
https://bugs.webkit.org/show_bug.cgi?id=134441
http://trac.webkit.org/changeset/170578
- 3:51 PM Changeset in webkit [170608] by
-
- 10 edits in trunk/Source/WebKit2
Restrict network process sandbox
https://bugs.webkit.org/show_bug.cgi?id=134360
Reviewed by Sam Weinig.
Add more restrictions to the network process sandbox.
- NetworkProcess/cocoa/NetworkProcessCocoa.mm: (WebKit::NetworkProcess::platformInitializeNetworkProcessCocoa):
Always use the cache directory provided in the initialization parameters,
and make sure we consume the cookie directory extension.
- Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb:
Make the sandbox profile much more restrictive.
- Shared/Network/NetworkProcessCreationParameters.cpp: (WebKit::NetworkProcessCreationParameters::encode): (WebKit::NetworkProcessCreationParameters::decode):
- Shared/Network/NetworkProcessCreationParameters.h:
The network process now requires an extension to access
its cookie storage.
- Shared/mac/SandboxUtilities.cpp: (WebKit::pathForProcessContainer):
- Shared/mac/SandboxUtilities.h:
We need to be able to get hold of our container so
that we can get the correct cookie storage directory.
- UIProcess/WebContext.cpp: (WebKit::WebContext::ensureNetworkProcess):
We have to pass in the an extension for the cookie storage directory when
initalising the network process
- UIProcess/mac/WebContextMac.mm: (WebKit::WebContext::platformDefaultCookieStorageDirectory):
Make sure we provide the correct location on IOS
- WebProcess/cocoa/WebProcessCocoa.mm: (WebKit::WebProcess::platformInitializeWebProcess):
Consume the cookie storage extension
- 3:50 PM Changeset in webkit [170607] by
-
- 2 edits in trunk/Source/WebKit2
[iOS WK2] Turn off scrollsToTop on overflow UIScrollViews
https://bugs.webkit.org/show_bug.cgi?id=134456
Reviewed by Tim Horton.
Set scrollsToTop to NO on our UIScrollViews created for overflow scrolling, since
we don't have a good strategy for when to allow it, and doing so would also require
some smarts in the main UIScrollView.
- UIProcess/Scrolling/ios/ScrollingTreeOverflowScrollingNodeIOS.mm:
(WebKit::ScrollingTreeOverflowScrollingNodeIOS::updateAfterChildren):
- 3:50 PM Changeset in webkit [170606] by
-
- 2 edits in trunk/Source/WebKit2
REGRESSION (Okemo): The contextual menu on tap and hold does not cancel the other gestures.
https://bugs.webkit.org/show_bug.cgi?id=134463
<rdar://problem/17388907>
Reviewed by Benjamin Poulain.
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _longPressRecognized:]):
- 3:48 PM Changeset in webkit [170605] by
-
- 7 edits in trunk/Source
Reduce dynamic memory allocation in css jit.
https://bugs.webkit.org/show_bug.cgi?id=134416
Reviewed by Benjamin Poulain.
Source/WebCore:
- cssjit/FunctionCall.h:
(WebCore::FunctionCall::FunctionCall):
(WebCore::FunctionCall::saveAllocatedCallerSavedRegisters):
- cssjit/RegisterAllocator.h:
- cssjit/SelectorCompiler.cpp:
(WebCore::SelectorCompiler::addPseudoClassType):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generatePrologue):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateSelectorChecker):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementIsNthChild):
Use inlineCapacity template parameter to reduce malloc calls.
I use 16 and 32 as the inline capacity for non-register related vectors because that
is probably big enough for the selector compiler, and if it is not then a malloc
call will not be significant because the selector is very complex.
- cssjit/StackAllocator.h:
(WebCore::StackAllocator::push):
Pass a vector of stack references to match calls to pop and to avoid a call to appendVector.
Source/WTF:
- wtf/Deque.h:
Added inlineCapacity optional template parameter.
- 3:22 PM Changeset in webkit [170604] by
-
- 2 edits in branches/ftlopt/Source/JavaScriptCore
CodeBlock::stronglyVisitWeakReferences should mark DFG::CommonData::weakStructureReferences
https://bugs.webkit.org/show_bug.cgi?id=134455
Reviewed by Geoffrey Garen.
Otherwise we get hanging pointers which can cause us to die later.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::stronglyVisitWeakReferences):
- 3:14 PM Changeset in webkit [170603] by
-
- 2 edits in trunk/Source/WebKit2
Implement the last pieces of encodeFrameStateNode
https://bugs.webkit.org/show_bug.cgi?id=134460
Reviewed by Andreas Kling.
- UIProcess/mac/LegacySessionStateCoding.cpp:
(WebKit::HistoryEntryDataEncoder::operator<<):
(WebKit::isValidEnum):
(WebKit::encodeFormDataElement):
(WebKit::encodeFormData):
(WebKit::encodeFrameStateNode):
- 3:13 PM Changeset in webkit [170602] by
-
- 3 edits in trunk/LayoutTests
js/script-tests/function-apply-many-args.js fails on ARM
https://bugs.webkit.org/show_bug.cgi?id=126588
Reviewed by Mark Lam.
Removed three test cases that fail on some platforms and pass on others due
to stack size. Other test cases cover what will fit on a stack or what will
throw an out of stack exception.
- js/function-apply-many-args-expected.txt:
- js/script-tests/function-apply-many-args.js:
- 3:12 PM Changeset in webkit [170601] by
-
- 6 edits in trunk
Add option to run-jsc-stress-testes to filter out tests that use large heaps
https://bugs.webkit.org/show_bug.cgi?id=134458
Reviewed by Filip Pizlo.
Source/JavaScriptCore:
Added test to skip js1_5/Regress/regress-159334.js when testing on a memory limited device.
- tests/mozilla/mozilla-tests.yaml:
Tools:
Added new --memory-limited to filter out tests that have large heap usage.
Such tests are either tagged with @largeHeap or logic is added to their .yaml file.
- Scripts/run-jsc-stress-tests:
LayoutTests:
- js/regress/script-tests/lots-of-fields.js: Added @largeHeap tag to skip when
running on a memoryLimited device.
- 3:10 PM Changeset in webkit [170600] by
-
- 5 edits in trunk/Source/WebKit2
[iOS][WK2] Move tap highlight to the inverseScaleRootView
https://bugs.webkit.org/show_bug.cgi?id=134424
<rdar://problem/17480880>
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-06-30
Reviewed by Tim Horton.
Enrica introduced the inverseScaleRootView that is a dynamic version of _highlightRootView.
This patch moves the tap highlight from its own inverse root to inverseScaleRootView. This provides better handling
of scale, better behavior on crash, and remove one extra view from the hierarchy.
The code is pretty much the same, just moved around. Some of the changes:
Now the code needs to handle repainting live when the view scale. To do that, _showTapHighlightXXX was split in two:
-_showTapHighlight to setup the view.
-_updateTapHighlight to update the view based on the current scale.
Since the view updates live on scaling, we need to recompute the coordinates for each update. To do that, the _potentialTapHighlightInformation
was generalized to handle all cases of highlight.
Since we can no longer test for the nullity of _potentialTapHighlightInformation,
a new attribute is introduced for that: _hasTapHighlightForPotentialTap.
The last bit of change concern reentering the tap highlight. This becomes quite simple:
1) _isTapHighlightIDValid is updated before the animation starts
so that it can be set again during an animation.
2) The animation checks the "finished" flags before removing the view from its superview
to avoid breaking the new animation.
- UIProcess/API/Cocoa/WKWebView.mm:
(withinEpsilon): Deleted.
- UIProcess/ios/WKContentView.mm:
(-[WKContentView didUpdateVisibleRect:unobscuredRect:unobscuredRectInScrollViewCoordinates:scale:minimumScale:inStableState:isChangingObscuredInsetsInteractively:]):
Make _updateUnscaledView conditional to scale changes, that thing isn't cheap!
- UIProcess/ios/WKContentViewInteraction.h:
(withinEpsilon):
Move withinEpsilon() from WKContentView to use it from both classes.
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView cleanupInteraction]):
(-[WKContentView _updateUnscaledView]):
(-[WKContentView _updateTapHighlight]):
(-[WKContentView _showTapHighlight]):
(-[WKContentView _didGetTapHighlightForRequest:color:quads:topLeftRadius:topRightRadius:bottomLeftRadius:bottomRightRadius:]):
(-[WKContentView _cancelInteraction]):
(-[WKContentView _finishInteraction]):
(-[WKContentView _singleTapDidReset:]):
(-[WKContentView _singleTapCommited:]):
(-[WKContentView _showTapHighlightWithColor:quads:topLeftRadius:topRightRadius:bottomLeftRadius:bottomRightRadius:]): Deleted.
- 2:53 PM Changeset in webkit [170599] by
-
- 5 edits in trunk/Source
Add code for encoding legacy session history entries
https://bugs.webkit.org/show_bug.cgi?id=134452
Reviewed by Andreas Kling.
Source/WebKit2:
- UIProcess/mac/LegacySessionStateCoding.cpp:
(WebKit::HistoryEntryDataEncoder::HistoryEntryDataEncoder):
(WebKit::HistoryEntryDataEncoder::operator<<):
(WebKit::HistoryEntryDataEncoder::finishEncoding):
(WebKit::HistoryEntryDataEncoder::encodeArithmeticType):
(WebKit::HistoryEntryDataEncoder::encodeFixedLengthData):
(WebKit::HistoryEntryDataEncoder::grow):
(WebKit::HistoryEntryDataEncoder::growCapacity):
(WebKit::encodeFrameStateNode):
(WebKit::encodeLegacySessionHistoryEntryData):
(WebKit::decodeSessionHistoryEntryData):
(WebKit::decodeLegacySessionHistoryEntryData):
- UIProcess/mac/LegacySessionStateCoding.h:
Source/WTF:
- wtf/MallocPtr.h:
(WTF::MallocPtr::malloc):
(WTF::MallocPtr::realloc):
- 2:25 PM Changeset in webkit [170598] by
-
- 3 edits in trunk/Source/WebCore
Use non-thumb registers in armv7 css jit.
https://bugs.webkit.org/show_bug.cgi?id=134450
Reviewed by Geoff Garen.
- cssjit/RegisterAllocator.h:
(WebCore::RegisterAllocator::isValidRegister):
(WebCore::RegisterAllocator::isCallerSavedRegister):
Use additional general purpose registers.
- cssjit/SelectorCompiler.cpp:
(WebCore::SelectorCompiler::SelectorCodeGenerator::compile):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateSelectorChecker):
Always succeed when compiling css selectors.
- 2:21 PM Changeset in webkit [170597] by
-
- 5 edits2 adds in trunk
Tiles on bottom of screen are not always allocated when necessary
https://bugs.webkit.org/show_bug.cgi?id=134272
Reviewed by Simon Fraser.
Source/WebCore:
The initial visibleRect is in the coordinate of the root layer, so its origin
is at the top left of the view. The initial rect we were using doesn't
include the contents inset, so it was too short, which was causing tiles near
the bottom of the screen to not always be allocated if the tile threshold was
close to the bottom of the view. Instead, we want to include the contents
inset size so the visible rect includes the entire view.
GraphicsLayerCA::recursiveCommitChanges() takes care of mapping and cropping
the visible rect into the tiled layer's coordinate system, at which point it
is used for visible tile logic.
Test: platform/mac-wk2/tiled-drawing/visible-rect-content-inset.html
- platform/graphics/ca/TileCoverageMap.cpp:
(WebCore::TileCoverageMap::update):
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::flushPendingLayerChanges):
LayoutTests:
Apply a content inset, then dump visible rects.
- platform/mac-wk2/tiled-drawing/visible-rect-content-inset-expected.txt: Added.
- platform/mac-wk2/tiled-drawing/visible-rect-content-inset.html: Added.
- compositing/visible-rect/iframe-no-layers.html: For WK2, the size of the visibleRect
includes the size of the border of the iframe. In order to elliminate platform
differences, set this border to 0.
- 1:57 PM Changeset in webkit [170596] by
-
- 2 edits in trunk/Tools
DRT in iOS sim crashes while loading fonts
https://bugs.webkit.org/show_bug.cgi?id=134451
Reviewed by Geoffrey Garen.
The magic linker symbols had the same name, and were therefore being unified
to a single font file. Then, adding the same file twice was failing.
- DumpRenderTree/mac/DumpRenderTree.mm:
(activateFontsIOS):
- 12:01 PM Changeset in webkit [170595] by
-
- 3 edits in trunk/Source/WebCore
[Win] Unreviewed project gardening.
- WebCore.vcxproj/WebCore.vcxproj: Clean up path information so
files appear in appropriate places in project view.
- WebCore.vcxproj/WebCore.vcxproj.filters: Ditto.
- 11:48 AM Changeset in webkit [170594] by
-
- 4 edits in trunk/Source/JavaScriptCore
Avoid copying closed variables vector; actually use move semantics
Rubber-stamped by Oliver Hunt.
Currently we always copy the closed variables vector passed by Parser::closedVariables()
to ProgramNode::setClosedVariables() because these member functions return and take a const
rvalue reference, respectively. Instead, these member functions should take an return a non-
constant rvalue reference so that we actually move the closed variables vector from the Parser
object to the Node object.
- parser/Nodes.cpp:
(JSC::ProgramNode::setClosedVariables): Remove const qualifier for argument.
- parser/Nodes.h:
(JSC::ScopeNode::setClosedVariables): Ditto.
- parser/Parser.h:
(JSC::Parser::closedVariables): Remove const qualifier on return type.
(JSC::parse): Remove extraneous call to std::move(). Calling std::move() is unnecessary here
because Parser::closedVariables() returns an rvalue reference.
- 11:27 AM Changeset in webkit [170593] by
-
- 2 edits in tags/Safari-538.43.40/Source/WebKit2
Merged r170569. <rdar://problem/17500555>
- 11:24 AM Changeset in webkit [170592] by
-
- 2 edits in tags/Safari-538.43.40/Source/WebCore
Merged r170533. <rdar://problem/16801069>
- 11:22 AM Changeset in webkit [170591] by
-
- 2 edits in trunk/LayoutTests
Reduce memory required for js/typedarray-zero-size.js
https://bugs.webkit.org/show_bug.cgi?id=134448
Reviewed by Mark Hahnenberg.
Reduce the loop count from 10000 to 4000 to further reduce memory requirements
on older devices.
- js/script-tests/typedarray-zero-size.js:
- 11:06 AM Changeset in webkit [170590] by
-
- 5 edits in trunk/Source/WebCore
Remove redundant repaintCompositedLayers() parameter and its dependencies.
https://bugs.webkit.org/show_bug.cgi?id=134431
Reviewed by Darin Adler.
No change in functionality.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::convertToPixelSnappedLayerCoords): Deleted.
(WebCore::RenderLayer::convertToLayerCoords): Deleted.
- rendering/RenderLayer.h:
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::repaintCompositedLayers):
(WebCore::RenderLayerCompositor::recursiveRepaintLayer):
- rendering/RenderLayerCompositor.h:
- 10:57 AM Changeset in webkit [170589] by
-
- 10 edits1 copy in trunk/Source/JavaScriptCore
JSContext Inspection: Provide a way to use a non-Main RunLoop for Inspector JavaScript Evaluations
https://bugs.webkit.org/show_bug.cgi?id=134371
Reviewed by Timothy Hatcher.
- API/JSContextPrivate.h:
- API/JSContext.mm:
(-[JSContext _debuggerRunLoop]):
(-[JSContext _setDebuggerRunLoop:]):
Private API for setting the CFRunLoop for a debugger to evaluate in.
- API/JSContextRefInternal.h: Added.
- API/JSContextRef.cpp:
(JSGlobalContextGetDebuggerRunLoop):
(JSGlobalContextSetDebuggerRunLoop):
Internal API for setting a CFRunLoop on a JSContextRef.
Set this on the debuggable.
- inspector/remote/RemoteInspectorDebuggable.h:
- inspector/remote/RemoteInspectorDebuggableConnection.h:
(Inspector::RemoteInspectorBlock::RemoteInspectorBlock):
(Inspector::RemoteInspectorBlock::~RemoteInspectorBlock):
(Inspector::RemoteInspectorBlock::operator=):
(Inspector::RemoteInspectorBlock::operator()):
Moved into the header.
- runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::inspectorDebuggable):
Lets store the RunLoop on the debuggable instead of this core
platform agnostic class, so expose the debuggable.
- inspector/remote/RemoteInspectorDebuggableConnection.mm:
(Inspector::RemoteInspectorHandleRunSourceGlobal):
(Inspector::RemoteInspectorQueueTaskOnGlobalQueue):
(Inspector::RemoteInspectorInitializeGlobalQueue):
Rename the global functions for clarity.
(Inspector::RemoteInspectorHandleRunSourceWithInfo):
Handler for private run loops.
(Inspector::RemoteInspectorDebuggableConnection::RemoteInspectorDebuggableConnection):
(Inspector::RemoteInspectorDebuggableConnection::~RemoteInspectorDebuggableConnection):
(Inspector::RemoteInspectorDebuggableConnection::dispatchAsyncOnDebuggable):
(Inspector::RemoteInspectorDebuggableConnection::setupRunLoop):
(Inspector::RemoteInspectorDebuggableConnection::teardownRunLoop):
(Inspector::RemoteInspectorDebuggableConnection::queueTaskOnPrivateRunLoop):
Setup and teardown and use private run loop sources if the debuggable needs it.
- 10:42 AM Changeset in webkit [170588] by
-
- 5 edits in tags/Safari-538.43.40/Source
Versioning.
- 10:39 AM Changeset in webkit [170587] by
-
- 1 copy in tags/Safari-538.43.40
New Tag.
- 10:37 AM Changeset in webkit [170586] by
-
- 2 edits in trunk/LayoutTests
Reduce memory required for js/typedarray-zero-size.js
https://bugs.webkit.org/show_bug.cgi?id=134448
Reviewed by Darin Adler.
Making the loop count down reduces memory usage from ~190MB to ~22MB while
still testing the original issue.
- js/script-tests/typedarray-zero-size.js:
- 9:59 AM Changeset in webkit [170585] by
-
- 11 edits in trunk/Source/WebCore
Remove webkit prefix from pointer lock.
https://bugs.webkit.org/show_bug.cgi?id=134312
Patch by Alex Christensen <achristensen@webkit.org> on 2014-06-30
Reviewed by Dean Jackson.
- dom/Document.cpp:
(WebCore::Document::exitPointerLock):
(WebCore::Document::pointerLockElement):
(WebCore::Document::webkitExitPointerLock): Deleted.
(WebCore::Document::webkitPointerLockElement): Deleted.
- dom/Document.h:
- dom/Document.idl:
- dom/Element.cpp:
(WebCore::Element::requestPointerLock):
(WebCore::Element::webkitRequestPointerLock): Deleted.
- dom/Element.h:
- dom/Element.idl:
- dom/EventNames.h:
- dom/MouseEvent.idl:
- dom/MouseRelatedEvent.h:
(WebCore::MouseRelatedEvent::movementX):
(WebCore::MouseRelatedEvent::movementY):
(WebCore::MouseRelatedEvent::webkitMovementX): Deleted.
(WebCore::MouseRelatedEvent::webkitMovementY): Deleted.
- page/PointerLockController.cpp:
(WebCore::PointerLockController::PointerLockController):
Initialize all data members.
(WebCore::PointerLockController::requestPointerLock):
(WebCore::PointerLockController::didAcquirePointerLock):
(WebCore::PointerLockController::didNotAcquirePointerLock):
(WebCore::PointerLockController::didLosePointerLock):
- 8:13 AM Changeset in webkit [170584] by
-
- 2 edits in trunk/Source/WebCore
U16_IS_SURROGATE should not be called with a UChar32
https://bugs.webkit.org/show_bug.cgi?id=134440
Reviewed by Darin Adler.
No new tests because there is no behavior change.
- platform/graphics/mac/ComplexTextController.cpp:
(WebCore::advanceByCombiningCharacterSequence):
- 7:48 AM Changeset in webkit [170583] by
-
- 3 edits in trunk/Source/JavaScriptCore
Add missing ENABLE(DFG_JIT) guards
https://bugs.webkit.org/show_bug.cgi?id=134444
Patch by Tibor Meszaros <tmeszaros.u-szeged@partner.samsung.com> on 2014-06-30
Reviewed by Darin Adler.
- dfg/DFGFunctionWhitelist.cpp:
- dfg/DFGFunctionWhitelist.h:
- 7:45 AM Changeset in webkit [170582] by
-
- 3 edits in trunk/Tools
Remove Qt cruft from webkitpy
https://bugs.webkit.org/show_bug.cgi?id=134445
Patch by Tibor Meszaros <tmeszaros.u-szeged@partner.samsung.com> on 2014-06-30
Reviewed by Csaba Osztrogonác.
- Scripts/webkitpy/common/config/ports.py:
(DeprecatedPort.port):
(QtPort): Deleted.
(QtPort.build_webkit_command): Deleted.
(QtPort.run_webkit_tests_command): Deleted.
(QtWK2Port): Deleted.
(QtWK2Port.build_webkit_command): Deleted.
(QtWK2Port.run_webkit_tests_command): Deleted.
- Scripts/webkitpy/common/config/ports_unittest.py:
(DeprecatedPortTest): Deleted.
(DeprecatedPortTest.test_qt_port): Deleted.
(DeprecatedPortTest.test_qt_wk2_port): Deleted.
- 1:46 AM Changeset in webkit [170581] by
-
- 5 edits in trunk/Source/WebCore
[EFL] Remove m_evasObject from Widget
https://bugs.webkit.org/show_bug.cgi?id=134442
Reviewed by Gyuyoung Kim.
Since WebKit1/EFL was dropped, we don't need to keep the m_evasObject
in the Widget.cpp because it's not used for WebKit2/Efl.
- platform/Widget.h:
(WebCore::Widget::evasObject): Deleted.
- platform/efl/ScrollbarEfl.cpp:
Removed WebKit1/Efl specific code which uses m_evasObject.
It will be a dummy until WebKit2/Efl support proper scrollbar implementation.
(WebCore::ScrollbarEfl::ScrollbarEfl):
(WebCore::ScrollbarEfl::~ScrollbarEfl):
(WebCore::ScrollbarEfl::setParent):
(WebCore::ScrollbarEfl::frameRectsChanged):
(WebCore::ScrollbarEfl::invalidate):
(ScrollbarEfl::ScrollbarEfl): Deleted.
(ScrollbarEfl::~ScrollbarEfl): Deleted.
(scrollbarEflEdjeMessage): Deleted.
(ScrollbarEfl::setParent): Deleted.
(ScrollbarEfl::updateThumbPosition): Deleted.
(ScrollbarEfl::updateThumbProportion): Deleted.
(ScrollbarEfl::updateThumbPositionAndProportion): Deleted.
(ScrollbarEfl::frameRectsChanged): Deleted.
(ScrollbarEfl::invalidate): Deleted.
- platform/efl/ScrollbarEfl.h:
Removed unnecessary methods. In addition, applied final, override keyword.
(WebCore::ScrollbarEfl::handleMouseMoveEvent): Deleted.
(WebCore::ScrollbarEfl::handleMouseOutEvent): Deleted.
(WebCore::ScrollbarEfl::handleMousePressEvent): Deleted.
(WebCore::ScrollbarEfl::handleMouseReleaseEvent): Deleted.
- platform/efl/WidgetEfl.cpp:
(WebCore::Widget::Widget):
(WebCore::Widget::setEvasObject): Deleted.
- 1:35 AM Changeset in webkit [170580] by
-
- 3 edits in trunk/Source/WebCore
Fix deprecated warning with bison 3
https://bugs.webkit.org/show_bug.cgi?id=133791
Patch by Eva Balazsfalvi <evab.u-szeged@partner.samsung.com> on 2014-06-30
Reviewed by Csaba Osztrogonác.
No new tests because no functional changes.
- css/CSSGrammar.y.in:
- xml/XPathGrammar.y:
- 1:32 AM Changeset in webkit [170579] by
-
- 3 edits in trunk/Source/WebCore
Remove HarfBuzzShaper::setDrawRange()
https://bugs.webkit.org/show_bug.cgi?id=134243
Reviewed by Gyuyoung Kim.
setDrawRange() is not used anywhere. Remove it.
And m_fromIndex and m_toIndex are changed by only setDrawRange().
So remove them too and use the default values instead of them.
No new tests, no behavior changes.
- platform/graphics/harfbuzz/HarfBuzzShaper.cpp:
(WebCore::HarfBuzzShaper::HarfBuzzShaper):
(WebCore::HarfBuzzShaper::fillGlyphBufferFromHarfBuzzRun):
currentCharacterIndex is unsigned, always greater than 0. Clean up if statements.
(WebCore::HarfBuzzShaper::setDrawRange): Deleted.
- platform/graphics/harfbuzz/HarfBuzzShaper.h:
Jun 29, 2014:
- 11:36 PM Changeset in webkit [170578] by
-
- 4 edits in trunk/Source/WebCore
Create NSURLRequest lazily when USE(CFNETWORK) is enabled
https://bugs.webkit.org/show_bug.cgi?id=134441
Reviewed by Sam Weinig.
No new tests. Should be covered by exsting tests.
- platform/network/cf/ResourceRequest.h:
(WebCore::ResourceRequest::ResourceRequest):
- platform/network/cf/ResourceRequestCFNet.cpp:
(WebCore::ResourceRequest::doUpdatePlatformRequest):
(WebCore::ResourceRequest::doUpdatePlatformHTTPBody):
(WebCore::ResourceRequest::setStorageSession):
- platform/network/cocoa/ResourceRequestCocoa.mm:
(WebCore::ResourceRequest::nsURLRequest):
- 9:43 PM Changeset in webkit [170577] by
-
- 2 edits2 deletes in trunk/Source/WebCore
[EFL] Remove netscape plugin implementation from WebCore
https://bugs.webkit.org/show_bug.cgi?id=134438
Reviewed by Gyuyoung Kim.
Because WebKit1/Efl was dropped, PluginPackageEfl.cpp and PluginViewEfl.cpp are not necessary.
- PlatformEfl.cmake:
- plugins/efl/PluginPackageEfl.cpp: Removed.
- plugins/efl/PluginViewEfl.cpp: Removed.
- plugins/x11/PluginViewX11.cpp: Removed.
This file is to share common code between WebKit1/Efl and WebKit1/GTk.
Now, both ports are dropped WebKit1 support and the GTK port already removed the related files at r167016.
- 9:07 PM Changeset in webkit [170576] by
-
- 30 edits19 adds in trunk
Add support for HTMLImageElement's sizes attribute
https://bugs.webkit.org/show_bug.cgi?id=133620
Reviewed by Dean Jackson.
.:
Added an ENABLE_PICTURE_SIZES compile flag.
- Source/cmake/WebKitFeatures.cmake:
- Source/cmakeconfig.h.cmake:
Source/JavaScriptCore:
Added an ENABLE_PICTURE_SIZES compile flag.
- Configurations/FeatureDefines.xcconfig:
Source/WebCore:
Tests: fast/dom/HTMLImageElement/sizes/image-sizes-1x.html
fast/dom/HTMLImageElement/sizes/image-sizes-2x.html
fast/dom/HTMLImageElement/sizes/image-sizes-js-change.html
fast/dom/HTMLImageElement/sizes/image-sizes-js-innerhtml.html
http/tests/loading/sizes/preload-image-sizes-2x.html
http/tests/loading/sizes/preload-image-sizes.html
This patch adds support for HTMLImageElement's sizes attribute and the
related srcset extended syntax as defined in
http://picture.responsiveimages.org/.
This sizes attribute syntax is added to the CSSGrammar and parsed by
the CSSParser.
The SourceSizeList class is generated by the parser, and used to get
the final source size.
HTMLImageElement and HTMLPreloadScanner send this value to
HTMLSrcsetParser.
HTMLSrcsetParser uses this value in order to pick the right resource.
- CMakeLists.txt: Added css/SourceSizeList.cpp.
- Configurations/FeatureDefines.xcconfig: Added the PICTURE_SIZES flag.
- WebCore.vcxproj/WebCore.vcxproj: Added css/SourceSizeList.*.
- WebCore.vcxproj/WebCore.vcxproj.filters: Added css/SourceSizeList.*.
- WebCore.xcodeproj/project.pbxproj: Added css/SourceSizeList.*.
- css/CSSGrammar.y.in: Added 4 grammar rules that define a Media condition,
Source size list, Source size length and source size.
- css/CSSParser.cpp:
(WebCore::CSSParser::parseSizesAttribute): Parse the sizes attribute.
(WebCore::CSSParser::detectAtToken): Set the token to SIZESATTR.
- css/CSSParser.h:
- css/SourceSizeList.cpp: Added. Defined the SourceSize and SourceSizeList classes.
(WebCore::SourceSize::match):
(WebCore::computeLength):
(WebCore::defaultValue):
(WebCore::SourceSize::length):
(WebCore::SourceSizeList::parseSizesAttribute):
(WebCore::SourceSizeList::getEffectiveSize):
- css/SourceSizeList.h: Added.
(WebCore::SourceSize::SourceSize):
(WebCore::SourceSizeList::append):
- html/HTMLImageElement.cpp: Integrated sizes attribute parsing and added currentSrc.
(WebCore::HTMLImageElement::setBestFitURLAndDPRFromImageCandidate):
(WebCore::HTMLImageElement::parseAttribute):
(WebCore::HTMLImageElement::currentSrc):
- html/HTMLImageElement.h:
- html/HTMLImageElement.idl:
- html/parser/HTMLDocumentParser.cpp: Added information required for sizes parsing to
HTMLPreloadScanner calls.
(WebCore::HTMLDocumentParser::pumpTokenizer):
(WebCore::HTMLDocumentParser::insert):
(WebCore::HTMLDocumentParser::append):
(WebCore::HTMLDocumentParser::appendCurrentInputStreamToPreloadScannerAndScan):
- html/parser/HTMLPreloadScanner.cpp: Integrated sizes attribute parsing.
(WebCore::TokenPreloadScanner::StartTagScanner::processAttributes):
(WebCore::TokenPreloadScanner::StartTagScanner::processAttribute):
(WebCore::TokenPreloadScanner::scan):
(WebCore::HTMLPreloadScanner::scan):
- html/parser/HTMLPreloadScanner.h:
- html/parser/HTMLSrcsetParser.cpp: Added 'w' descriptor parsing sizes based normalization.
(WebCore::parseDescriptors):
(WebCore::pickBestImageCandidate):
(WebCore::bestFitSourceForImageAttributes):
- html/parser/HTMLSrcsetParser.h:
Source/WebKit/mac:
Added an ENABLE_PICTURE_SIZES compile flag.
- Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
Added an ENABLE_PICTURE_SIZES compile flag.
- Configurations/FeatureDefines.xcconfig:
Tools:
Added an ENABLE_PICTURE_SIZES compile flag.
- Scripts/webkitperl/FeatureList.pm:
LayoutTests:
These layout tests check that the sizes attribute and the related
srcset syntax are well supported, that the right resource is displayed,
that the currentSrc attribute is well supported and also that the right
resource is preloaded.
- fast/dom/HTMLImageElement/resources/currentSrcHelper.js: Added.
(fileName):
(currentSrcFileName):
- fast/dom/HTMLImageElement/resources/image-set-4x.png: Added.
- fast/dom/HTMLImageElement/sizes/image-sizes-1x-expected.txt: Added.
- fast/dom/HTMLImageElement/sizes/image-sizes-1x.html: Added.
- fast/dom/HTMLImageElement/sizes/image-sizes-2x-expected.txt: Added.
- fast/dom/HTMLImageElement/sizes/image-sizes-2x.html: Added.
- fast/dom/HTMLImageElement/sizes/image-sizes-js-change-expected.txt: Added.
- fast/dom/HTMLImageElement/sizes/image-sizes-js-change.html: Added.
- fast/dom/HTMLImageElement/sizes/image-sizes-js-innerhtml-expected.txt: Added.
- fast/dom/HTMLImageElement/sizes/image-sizes-js-innerhtml.html: Added.
- http/tests/loading/sizes/preload-image-sizes-2x-expected.txt: Added.
- http/tests/loading/sizes/preload-image-sizes-2x.html: Added.
- http/tests/loading/sizes/preload-image-sizes-expected.txt: Added.
- http/tests/loading/sizes/preload-image-sizes.html: Added.
- 2:51 PM Changeset in webkit [170575] by
-
- 4 edits in trunk/Source/WebCore
No need to lazily initialize ResourceResponse internals when accessing timing data.
<https://webkit.org/b/134437>
<rdar://problem/17499876>
When building with ENABLE(WEB_TIMING), the last thing that would happen when
serializing a ResourceResponse in the network process is that we'd retrieve
the ResourceLoadTiming to encode it as part of the response. Doing so would
trigger the lazy instantiation of ResourceResponse's internal data structures.
Since timing data is not actually lazily instantiated, we can just not do that.
This shaves off ~550ms of network process main thread time on PLT, reducing
response latency by not doing unnecessary stuff before letting the web process
look at the downloaded data.
Reviewed by Gavin Barraclough.
- WebCore.exp.in:
- platform/network/ResourceResponseBase.cpp:
(WebCore::ResourceResponseBase::adopt):
(WebCore::ResourceResponseBase::resourceLoadTiming): Deleted.
(WebCore::ResourceResponseBase::setResourceLoadTiming): Deleted.
- platform/network/ResourceResponseBase.h:
(WebCore::ResourceResponseBase::resourceLoadTiming):
- 1:59 PM Changeset in webkit [170574] by
-
- 4 edits1 copy2 adds in trunk/Source/WebCore
Refactor ResourceRequest into Cocoa and iOS specific files
https://bugs.webkit.org/show_bug.cgi?id=134430
Reviewed by Andreas Kling.
No new tests because no functional changes.
- WebCore.xcodeproj/project.pbxproj:
- platform/network/cf/ResourceRequestCFNet.cpp:
(WebCore::ResourceRequest::applyWebArchiveHackForMail): Deleted.
- platform/network/cocoa/ResourceRequestCocoa.mm: Copied from Source/WebCore/platform/network/mac/ResourceRequestMac.mm.
(WebCore::ResourceRequest::nsURLRequest):
(WebCore::ResourceRequest::cfURLRequest):
(WebCore::ResourceRequest::doUpdateResourceRequest):
(WebCore::ResourceRequest::doUpdateResourceHTTPBody):
(WebCore::ResourceRequest::doUpdatePlatformRequest):
(WebCore::ResourceRequest::doUpdatePlatformHTTPBody):
(WebCore::ResourceRequest::updateFromDelegatePreservingOldProperties):
(WebCore::ResourceRequest::applyWebArchiveHackForMail):
(WebCore::ResourceRequest::setStorageSession):
- platform/network/ios/ResourceRequestIOS.mm: Added.
(WebCore::ResourceRequest::useQuickLookResourceCachingQuirks):
(WebCore::ResourceRequest::ResourceRequest):
(WebCore::ResourceRequest::updateNSURLRequest):
- platform/network/mac/ResourceRequestMac.mm:
(WebCore::initQuickLookResourceCachingQuirks):
(WebCore::ResourceRequest::useQuickLookResourceCachingQuirks):
(WebCore::ResourceRequest::ResourceRequest):
(WebCore::ResourceRequest::updateNSURLRequest):
(WebCore::ResourceRequest::applyWebArchiveHackForMail):
(WebCore::ResourceRequest::nsURLRequest): Deleted.
(WebCore::ResourceRequest::cfURLRequest): Deleted.
(WebCore::ResourceRequest::doUpdateResourceRequest): Deleted.
(WebCore::ResourceRequest::doUpdateResourceHTTPBody): Deleted.
(WebCore::ResourceRequest::doUpdatePlatformRequest): Deleted.
(WebCore::ResourceRequest::doUpdatePlatformHTTPBody): Deleted.
(WebCore::ResourceRequest::updateFromDelegatePreservingOldProperties): Deleted.
(WebCore::ResourceRequest::setStorageSession): Deleted.
- 10:10 AM Changeset in webkit [170573] by
-
- 3 edits2 adds in trunk
TextCodecICU::encode turns the whole string as yen signs if there is any backslash in it
https://bugs.webkit.org/show_bug.cgi?id=133678
Patch by Youenn Fablet <youenn.fablet@crf.canon.fr> on 2014-06-29
Reviewed by Alexey Proskuryakov.
Source/WebCore:
Test: fast/encoding/backslash-encoding-jp.html
- platform/text/TextCodecICU.cpp:
(WebCore::TextCodecICU::encode): fixed the copy of characters other than backslash.
LayoutTests:
- fast/encoding/backslash-encoding-jp-expected.txt: Added.
- fast/encoding/backslash-encoding-jp.html: Added.
- 8:27 AM BuildingQtOnWindows edited by
- small "typo" (diff)
- 8:18 AM BuildingQtOnWindows edited by
- Added the SQLite dependency information, added some notes and a bit … (diff)
