Timeline
Jul 5, 2014:
- 5:03 PM Changeset in webkit [170827] by
-
- 2 edits in trunk/Source/WebCore
[iOS] MediaDocument should set a viewport
https://bugs.webkit.org/show_bug.cgi?id=134658
<rdar://problem/17552339>
Reviewed by Zalan Bujtas.
A MediaDocument should fill the viewport, so set its
initial-scale to 1 and make it non-zoomable.
- html/MediaDocument.cpp:
(WebCore::MediaDocumentParser::createDocumentStructure): Create
a <head> element and a <meta> element with a 1:1 viewport.
- 10:56 AM Changeset in webkit [170826] by
-
- 4 edits in trunk/Source/WebCore
Unreviewed, rolling out r170825.
https://bugs.webkit.org/show_bug.cgi?id=134653
broke debug builds (Requested by kling on #webkit).
Reverted changeset:
"Generate isMathMLFoo() toMathMLFoo() by using NODE_TYPE_CASTS
macro and generateTypeHelpers"
https://bugs.webkit.org/show_bug.cgi?id=134647
http://trac.webkit.org/changeset/170825
- 10:36 AM Changeset in webkit [170825] by
-
- 4 edits in trunk/Source/WebCore
Generate isMathMLFoo() toMathMLFoo() by using NODE_TYPE_CASTS macro and generateTypeHelpers
https://bugs.webkit.org/show_bug.cgi?id=134647
Reviewed by Andreas Kling.
Use type cast macro and generation tag for isFoo() and toFoo() in some MathML classes.
No new tests, no behavior change.
- mathml/MathMLElement.h: Place MathMLElementTypeHelpers.h to the bottom of the
file so that functions from that file can use the Element|Node classes and other things defined in this file.
(WebCore::isMathMLElement): Deleted.
- mathml/MathMLMencloseElement.h:
(WebCore::toMathMLMencloseElement): Deleted.
- mathml/mathtags.in:
- 3:29 AM Changeset in webkit [170824] by
-
- 2 edits in trunk/Tools
[EFL] Add libgeoclue-dev to Tools/efl/install-dependencies.
https://bugs.webkit.org/show_bug.cgi?id=134648
Patch by KwangHyuk Kim <hyuki.kim@samsung.com> on 2014-07-05
Reviewed by Gyuyoung Kim.
As Geoclue is enabled for EFL, libgeoclue-dev is also added to Tools/efl/install-dependencies.
- efl/install-dependencies:
Jul 4, 2014:
- 11:33 PM Changeset in webkit [170823] by
-
- 8 edits in trunk
[EFL] Support Geolocation
https://bugs.webkit.org/show_bug.cgi?id=134439
Reviewed by Antonio Gomes.
.:
- Source/cmake/OptionsEfl.cmake: Turn on ENABLE_GEOLOCATION.
Source/WebCore:
Add geoclue files in order to enable geolocation for EFL port.
- PlatformEfl.cmake:
Tools:
- Scripts/webkitperl/FeatureList.pm: Enable geolocation for EFL port.
LayoutTests:
- platform/efl/TestExpectations: Unskip geolocation tests.
- 10:25 PM Changeset in webkit [170822] by
-
- 4 edits in trunk/Source/WebCore
CSS JIT: compile :in-range and :out-of-range
https://bugs.webkit.org/show_bug.cgi?id=134639
Reviewed by Andreas Kling.
The pseudo class :in-range and :out-of-range are trivial non-inlined selectors.
- css/SelectorChecker.cpp:
(WebCore::SelectorChecker::checkOne):
- css/SelectorCheckerTestFunctions.h:
(WebCore::isInRange):
(WebCore::isOutOfRange):
- cssjit/SelectorCompiler.cpp:
(WebCore::SelectorCompiler::addPseudoClassType):
- 9:43 PM Changeset in webkit [170821] by
-
- 2 edits in branches/ftlopt/Source/JavaScriptCore
Merge trunk r169595.
2014-06-04 Filip Pizlo <fpizlo@apple.com>
DFG::Safepoint::begin() should set m_didCallBegin before releasing the rightToRun lock, because otherwise, Safepoint::checkLivenessAndVisitChildren() may assert due to a race
https://bugs.webkit.org/show_bug.cgi?id=133525
<rdar://problem/16790296>
Reviewed by Oliver Hunt.
- dfg/DFGSafepoint.cpp: (JSC::DFG::Safepoint::begin):
- 9:28 PM Changeset in webkit [170820] by
-
- 2 edits in trunk/Tools
[EFL][WK2] Enhance the Minibrowser to show selected/highlighted text in search bar, if any.
https://bugs.webkit.org/show_bug.cgi?id=134485
Patch by Shivakumar JM <shiva.jm@samsung.com> on 2014-07-04
Reviewed by Gyuyoung Kim.
Use script_execute_callback to get selected/highlighted text and show in search bar.
- MiniBrowser/efl/main.c:
(script_execute_callback):
(on_key_down):
- 9:13 PM Changeset in webkit [170819] by
-
- 2 edits in branches/ftlopt/Source/JavaScriptCore
[ftlopt][REGRESSION] debug tests fail because PutByIdDirect is now implemented in terms of In
https://bugs.webkit.org/show_bug.cgi?id=134642
Rubber stamped by Andreas Kling.
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileNode):
- 8:36 PM Changeset in webkit [170818] by
-
- 10 edits in trunk/Source
Fast path for jsStringWithCache() when asked for the same string repeatedly.
<https://webkit.org/b/134635>
Source/JavaScriptCore:
Also moved the whole thing from WebCore to JavaScriptCore since it
makes more sense here, and inline the lightweight checks, leaving only
the hashmap stuff out of line.
Reviewed by Darin Adler.
- runtime/JSString.cpp:
(JSC::jsStringWithCacheSlowCase):
- runtime/JSString.h:
(JSC::jsStringWithCache):
- runtime/VM.h:
Source/WebCore:
Reviewed by Darin Adler.
- WebCore.exp.in:
- bindings/js/JSDOMBinding.cpp:
(WebCore::jsStringWithCache): Deleted.
- bindings/js/JSDOMBinding.h:
(WebCore::JSValueTraits<String>::arrayJSValue):
(WebCore::jsStringWithCache): Deleted.
- bridge/c/c_utility.cpp:
(JSC::Bindings::convertNPVariantToValue):
- loader/cache/CachedResourceHandle.h:
- 8:03 PM Changeset in webkit [170817] by
-
- 3 edits2 adds in trunk
Subpixel rendering: ebay.com rotating billboard on the main page has cut off buttons.
https://bugs.webkit.org/show_bug.cgi?id=134636
<rdar://problem/17529112>
Reviewed by Darin Adler.
Missing pixel snapping when clipping the transparency layer for BackgroundBleedUseTransparencyLayer.
Clipping needs to take the same snapping strategy as the rest of the painting code.
Source/WebCore:
Test: fast/borders/border-radius-on-subpixel-position-non-hidpi.html
- rendering/RenderBox.cpp:
(WebCore::RenderBox::paintBoxDecorations):
LayoutTests:
- fast/borders/border-radius-on-subpixel-position-non-hidpi-expected.html: Added.
- fast/borders/border-radius-on-subpixel-position-non-hidpi.html: Added.
- 6:29 PM Changeset in webkit [170816] by
-
- 4 edits in trunk/Source/WebCore
QualifiedName should use RefPtr<QualifiedNameImpl> internally.
<https://webkit.org/b/132796>
We were not inlining ~QualifiedName() and it was showing up in some
profiles (over 1% on dom-attr.html.)
This patch modernizes QualifiedName a bit by using RefPtr to store
the QualifiedNameImpl instead of doing manual ref() and deref()
in out-of-line functions.
Reviewed by Darin Adler.
- WebCore.exp.in:
- dom/QualifiedName.cpp:
(WebCore::QNameComponentsTranslator::translate):
(WebCore::QualifiedName::QualifiedName):
(WebCore::QualifiedName::~QualifiedName): Deleted.
(WebCore::QualifiedName::deref): Deleted.
- dom/QualifiedName.h:
(WebCore::QualifiedName::QualifiedNameImpl::create):
(WebCore::QualifiedName::QualifiedName):
(WebCore::QualifiedName::isHashTableDeletedValue):
(WebCore::QualifiedName::~QualifiedName):
(WebCore::QualifiedName::operator=):
(WebCore::QualifiedName::impl):
(WebCore::QualifiedName::ref): Deleted.
- 4:03 PM Changeset in webkit [170815] by
-
- 2 edits in trunk/Source/WebCore
[iOS] [Media] Prevent page zoom if it started in the video element
https://bugs.webkit.org/show_bug.cgi?id=134640
<rdar://problem/16630794>
Reviewed by Sam Weinig.
In r170572 I attempted to prevent the page zoom from happening
when the user was attempting to fullscreen the video. That fix was
not complete, because it relied on the touchstart event being
sent before a gesture event. It turns out this doesn't always happen,
so we need to apply the same check in the gesture event - if the
gesture began with two fingers on the media, don't do a page zoom.
The exception is zooming out, if you've managed to make the video
cover the entire screen (also, the pinch-out-of-fullscreen gesture
does not get handled by WebKit).
- Modules/mediacontrols/mediaControlsiOS.js:
(ControllerIOS.prototype.handleBaseGestureChange): Add a check to
make sure our pinch didn't start in the video element.
- 3:27 PM Changeset in webkit [170814] by
-
- 3 edits in trunk/Source/WebKit2
[EFL][WK2]Fix build break in EFL WK2
https://bugs.webkit.org/show_bug.cgi?id=134629
Unreviewed build fix.
Patch by Rohit Kumar <kumar.rohit@samsung.com> on 2014-07-04
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedDrawingArea.cpp:
(WebKit::CoordinatedDrawingArea::scheduleCompositingLayerFlushImmediately):
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedDrawingArea.h:
- 3:26 PM Changeset in webkit [170813] by
-
- 5 edits in trunk/Source/WebCore
[CoordinatedGraphics] Use the C++11 syntax to clean-up for loops
https://bugs.webkit.org/show_bug.cgi?id=134594
Patch by Hunseop Jeong <Hunseop Jeong> on 2014-07-04
Reviewed by Darin Adler.
Convert a couple of loops to range-based for
No change in functionality, no new tests.
- platform/graphics/TiledBackingStore.cpp:
(WebCore::TiledBackingStore::updateTileBuffers):
(WebCore::TiledBackingStore::resizeEdgeTiles):
(WebCore::TiledBackingStore::setKeepRect):
- platform/graphics/texmap/coordinated/CompositingCoordinator.cpp:
(WebCore::CompositingCoordinator::~CompositingCoordinator):
(WebCore::CompositingCoordinator::flushPendingImageBackingChanges):
(WebCore::CompositingCoordinator::setVisibleContentsRect):
(WebCore::CompositingCoordinator::purgeBackingStores):
- platform/graphics/texmap/coordinated/CoordinatedBackingStore.cpp:
(WebCore::CoordinatedBackingStore::removeAllTiles):
(WebCore::CoordinatedBackingStore::paintToTextureMapper):
(WebCore::CoordinatedBackingStore::drawBorder):
(WebCore::CoordinatedBackingStore::drawRepaintCounter):
(WebCore::CoordinatedBackingStore::commitTileOperations):
- platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.cpp:
(WebCore::CoordinatedGraphicsScene::adjustPositionForFixedLayers):
(WebCore::CoordinatedGraphicsScene::commitPendingBackingStoreOperations):
- 2:54 PM Changeset in webkit [170812] by
-
- 2 edits in trunk/Tools
Build fix after r170811.
- MiniBrowser/mac/WK2BrowserWindowController.m:
(-[WK2BrowserWindowController reload:]):
- 2:00 PM Changeset in webkit [170811] by
-
- 3 edits in trunk/Source/WebKit2
[Cocoa] -[WKWebView _reload] is unused
https://bugs.webkit.org/show_bug.cgi?id=134638
Reviewed by Sam Weinig.
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _reload]): Deleted.
- UIProcess/API/Cocoa/WKWebViewPrivate.h:
- 1:49 PM Changeset in webkit [170810] by
-
- 2 edits in trunk/Source/WebKit2
[WK2] Take TopContentInset into account when sending dictionary lookup point to PluginView
https://bugs.webkit.org/show_bug.cgi?id=134624
<rdar://problem/17222041>
Reviewed by Sam Weinig.
- WebProcess/Plugins/PDF/PDFPlugin.mm:
(WebKit::PDFPlugin::performDictionaryLookupAtLocation):
Perform the same coordinate conversion we use for mouse events, which happens
to take the top content inset into account.
- 12:54 PM Changeset in webkit [170809] by
-
- 6 edits in trunk/Source/WebCore
CTTE: ScriptElement always has a HTTPScriptElement or SVGScriptElement.
<https://webkit.org/b/134637>
Have ScriptElement store the pointer to the more specific subclass
element as a reference. Also made the constructor protected since
nobody should instantiate ScriptElement directly.
Reviewed by Antti Koivisto.
- dom/ScriptElement.cpp:
(WebCore::ScriptElement::ScriptElement):
(WebCore::ScriptElement::childrenChanged):
(WebCore::ScriptElement::dispatchErrorEvent):
(WebCore::ScriptElement::prepareScript):
(WebCore::ScriptElement::requestScript):
(WebCore::ScriptElement::executeScript):
(WebCore::ScriptElement::notifyFinished):
(WebCore::ScriptElement::ignoresLoadRequest):
(WebCore::ScriptElement::scriptContent):
- dom/ScriptElement.h:
(WebCore::ScriptElement::element):
- dom/ScriptRunner.cpp:
(WebCore::ScriptRunner::queueScriptForExecution):
- html/HTMLScriptElement.cpp:
(WebCore::HTMLScriptElement::HTMLScriptElement):
- svg/SVGScriptElement.cpp:
(WebCore::SVGScriptElement::SVGScriptElement):
- 12:12 PM Changeset in webkit [170808] by
-
- 10 edits in trunk
input type=range element should only fire change events after committing a value
https://bugs.webkit.org/show_bug.cgi?id=134545
Patch by Julien Quint <pom@graougraou.com> on 2014-07-04
Reviewed by Dean Jackson.
Source/WebCore:
A "change" event was fired every time the slider thumb element was dragged
by the user. The "change" event is now fired only after the thumb
element has stopped moving; previously, both "input" and "change" events
where dispatched while changes were being made. This new behavior is
consistent with the specification (cf.
http://www.whatwg.org/specs/web-apps/current-work/multipage/common-input-element-attributes.html#event-input-change),
as well as other implementations such as Firefox and Chrome.
- Modules/mediacontrols/mediaControlsApple.js:
(Controller.prototype.createControls): Listen to the "input" event
rather than the "change" event for the timeline control in order to
keep track of value changes when the user is dragging the thumb.
- accessibility/AccessibilitySlider.cpp:
(WebCore::AccessibilitySlider::setValue): Dispatch "change" event while
setting the new value rather than dispatching later, since setting the
value now clears the change flag.
- html/RangeInputType.cpp:
(WebCore::RangeInputType::setValue): Update the text value of the
control in the case when no event is to be dispatched, so that this
value can be checked the next time a "change" event dispatch is
requested.
- html/shadow/SliderThumbElement.cpp:
(WebCore::SliderThumbElement::setPositionFromPoint): Removed the
dispatch of the "change" event, and no longer track the text value of
the element as a result of dispatching a "change" event.
(WebCore::SliderThumbElement::stopDragging): Dispatch the "change" event
on completing the drag.
LayoutTests:
Two existing tests are updated to count "input" events as well as
"change" events. The tests now verify that "change" is only fired once
after every slider drag completes, whereas "input" may be fired more
than once.
- fast/forms/range/range-drag-expected.txt:
- fast/forms/range/range-drag-when-toggled-disabled-expected.txt:
- fast/forms/range/range-drag-when-toggled-disabled.html:
- fast/forms/range/range-drag.html:
- 11:07 AM Changeset in webkit [170807] by
-
- 4 edits in trunk/Source/WebCore
CTTE: ApplicationCacheHost always has a DocumentLoader.
<https://webkit.org/b/b/128435>
Have ApplicationCacheHost store the backpointer to its owning
DocumentLoader as a reference.
Reviewed by Sam Weinig.
- loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::DocumentLoader):
(WebCore::DocumentLoader::startLoadingMainResource):
- loader/appcache/ApplicationCacheHost.cpp:
(WebCore::ApplicationCacheHost::ApplicationCacheHost):
(WebCore::ApplicationCacheHost::~ApplicationCacheHost):
(WebCore::ApplicationCacheHost::selectCacheWithoutManifest):
(WebCore::ApplicationCacheHost::selectCacheWithManifest):
(WebCore::ApplicationCacheHost::maybeLoadMainResource):
(WebCore::ApplicationCacheHost::maybeLoadFallbackForMainResponse):
(WebCore::ApplicationCacheHost::maybeLoadFallbackForMainError):
(WebCore::ApplicationCacheHost::failedLoadingMainResource):
(WebCore::ApplicationCacheHost::finishedLoadingMainResource):
(WebCore::ApplicationCacheHost::maybeLoadResource):
(WebCore::ApplicationCacheHost::maybeLoadFallbackForError):
(WebCore::ApplicationCacheHost::maybeLoadSynchronously):
(WebCore::ApplicationCacheHost::notifyDOMApplicationCache):
(WebCore::ApplicationCacheHost::stopDeferringEvents):
(WebCore::ApplicationCacheHost::scheduleLoadFallbackResourceFromApplicationCache):
(WebCore::ApplicationCacheHost::update):
(WebCore::ApplicationCacheHost::swapCache):
(WebCore::ApplicationCacheHost::abort):
(WebCore::ApplicationCacheHost::isApplicationCacheEnabled):
- loader/appcache/ApplicationCacheHost.h:
(WebCore::ApplicationCacheHost::documentLoader): Deleted.
- 8:31 AM Changeset in webkit [170806] by
-
- 17 edits1 add in trunk/LayoutTests
buildAccessibilityTree() needs to be removed from individual layout tests
https://bugs.webkit.org/show_bug.cgi?id=95286
Reviewed by Chris Fleizach.
Extracted two functions to 'dump' and 'touch' the accessibility
hierarchies out of different layout tests and into a single file,
living in LayoutTests/resources/accessibility-helper.js
- resources/accessibility-helper.js: Added.
(dumpAccessibilityTree): New, based on buildAccessibilityTree()
for the cases where it was used to actually 'dump' it into the output.
(touchAccessibilityTree): Same, but for the cases where we don't
want to dump the accessibility tree, just to make sure is generated.
Updated affected layout tests to use the newly added helper functions.
- accessibility/adjacent-continuations-cause-assertion-failure.html: Updated.
- accessibility/children-changed-sends-notification.html: Ditto.
- accessibility/deleting-iframe-destroys-axcache.html: Ditto.
- accessibility/div-within-anchors-causes-crash.html: Ditto.
- accessibility/first-letter-text-transform-causes-crash.html: Ditto.
- accessibility/image-map-update-parent-crash.html: Ditto.
- accessibility/table-with-empty-thead-causes-crash.html: Ditto.
- platform/efl/accessibility/media-emits-object-replacement.html: Ditto.
- platform/gtk/accessibility/entry-and-password.html: Ditto.
- platform/gtk/accessibility/media-emits-object-replacement.html: Ditto.
- platform/gtk/accessibility/replaced-objects-in-anonymous-blocks.html: Ditto.
Updated Mac specific expectations not to print the "End of test" element.
- platform/mac-wk2/accessibility/deleting-iframe-destroys-axcache-expected.txt: Updated.
- platform/mac/accessibility/adjacent-continuations-cause-assertion-failure-expected.txt: Ditto.
- platform/mac/accessibility/deleting-iframe-destroys-axcache-expected.txt: Ditto.
- platform/mac/accessibility/div-within-anchors-causes-crash-expected.txt: Ditto.
- 6:55 AM Changeset in webkit [170805] by
-
- 3 edits2 adds in trunk
REGRESSION(r159345): Lines are clipped between pages when printing web content from Safari
https://bugs.webkit.org/show_bug.cgi?id=134633
Source/WebCore:
<rdar://problem/17088936>
Reviewed by Zalan Bujtas.
Test: printing/simple-lines-break.html
- rendering/SimpleLineLayout.cpp:
(WebCore::SimpleLineLayout::canUseFor):
Disable simple lines if global pagination is enabled.
Printing does not currently use flow threads which we already test for.
LayoutTests:
Reviewed by Zalan Bujtas.
- printing/simple-lines-break-expected.html: Added.
- printing/simple-lines-break.html: Added.
- 4:19 AM Changeset in webkit [170804] by
-
- 3 edits in releases/WebKitGTK/webkit-2.4/Source/WebKit2
Merge r170707 - [GTK] WebKitVersion.h should be shared between UI and Web Process APIs
https://bugs.webkit.org/show_bug.cgi?id=134538
Reviewed by Martin Robinson.
To be able to check current version from web extensions too.
- UIProcess/API/gtk/WebKitVersion.h.in: Allow to include WebKitVersion.h also from webkit-web-extension.h.
- WebProcess/InjectedBundle/API/gtk/webkit-web-extension.h: Include WebKitVersion.h.
- 3:46 AM Changeset in webkit [170803] by
-
- 7 edits in releases/WebKitGTK/webkit-2.4
Merge r163519 - Remove the WTF_COMPILER_SUPPORTS_CXX_GENERALIZED_INITIALIZERS macro
https://bugs.webkit.org/show_bug.cgi?id=128267
Reviewed by Andreas Kling.
Source/WTF:
Remove the WTF_COMPILER_SUPPORTS_CXX_GENERALIZED_INITIALIZERS macro that was manually defined for compilers
that support the C++11 initializer lists. The feature is well supported in Clang, MSVC and also GCC. It
was actually already used unguarded in HashSet.
- wtf/Compiler.h:
- wtf/HashMap.h:
(WTF::HashMap::HashMap):
- wtf/Vector.h:
(WTF::Vector::Vector):
Tools:
Remove the COMPILER_SUPPORTS(CXX_GENERALIZED_INITIALIZERS) as the underlying macro is also
being removed since the feature is supported by all the compilers the project approves.
- TestWebKitAPI/Tests/WTF/HashMap.cpp:
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/WTF/Vector.cpp:
(TestWebKitAPI::TEST):
- 3:33 AM Changeset in webkit [170802] by
-
- 2 edits in trunk/Tools
Typo in watchlist config means four specific people get Cc'd on everything
https://bugs.webkit.org/show_bug.cgi?id=134626
Reviewed by Gyuyoung Kim.
- Scripts/webkitpy/common/config/watchlist:
Remove leading pipe, which meant that this rule matched everything!
- 2:58 AM Changeset in webkit [170801] by
-
- 3 edits in trunk/Source/WebKit2
2014-07-04 Philippe Normand <pnormand@igalia.com>
Unreviewed, GTK WK2 build fix after r170787.
- WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::DrawingAreaImpl::scheduleCompositingLayerFlushImmediately):
- WebProcess/WebPage/DrawingAreaImpl.h:
- 1:55 AM WebKitGTK/2.4.x edited by
- (diff)
- 1:55 AM Changeset in webkit [170800] by
-
- 3 edits in releases/WebKitGTK/webkit-2.4/Source/WebCore
Merge r170526 - [GTK] 8tracks.com triggers annoying pop-up window/installation of "About protocol source plugin" (GStreamer?)
https://bugs.webkit.org/show_bug.cgi?id=133605
Reviewed by Carlos Garcia Campos.
Don't attempt to load blank URLs with the GStreamer media
player. Those URLs trigger the codec installer which is useless in
this scenario. This patch also renames some of the variables of
the ::load method, as suggested by Carlos.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::~MediaPlayerPrivateGStreamer):
Check video-sink validity before disconnecting its signal handlers.
(WebCore::MediaPlayerPrivateGStreamer::load): Don't load blank
URLs (about:blank).
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
(WebCore::MediaPlayerPrivateGStreamerBase::~MediaPlayerPrivateGStreamerBase):
Disconnect repaint handler only if it's valid.
- 1:50 AM Changeset in webkit [170799] by
-
- 7 edits in trunk/Source
Source/WebCore: Unreviewed. Fixing the build after r170795.
Mac didn't like that change as it seems to properly typedef long long to int64_t.
That's not the case on 64-bit Linux (for some reason), so I'm changing the type of
the two long long variables in FormDataElement to int64_t to avoid any further trouble.
- platform/network/FormData.h:
Source/WebKit2: Unreviewed. Reverting the bad changes introduced in r170795.
- Platform/IPC/ArgumentDecoder.cpp:
(IPC::ArgumentDecoder::decode): Deleted.
- Platform/IPC/ArgumentDecoder.h:
- Platform/IPC/ArgumentEncoder.cpp:
(IPC::ArgumentEncoder::encode): Deleted.
- Platform/IPC/ArgumentEncoder.h:
- 1:48 AM Changeset in webkit [170798] by
-
- 2 edits in releases/WebKitGTK/webkit-2.4/Source/WebCore
Merge r169896 - [GTK] fails to build with --disable-webgl --disable-accelerated-compositing
https://bugs.webkit.org/show_bug.cgi?id=131267
Reviewed by Philippe Normand.
Add missing headers needed for Float32Array::create().
- Modules/webaudio/AudioBuffer.cpp:
- 1:48 AM WebKitGTK/2.4.x edited by
- (diff)
- 1:38 AM Changeset in webkit [170797] by
-
- 2 edits in releases/WebKitGTK/webkit-2.4/Source/WebCore
Merge r169935 - [GTK] GLContextEGL.cpp: conflicting declaration 'typedef ptrdiff_t GLintptr'
https://bugs.webkit.org/show_bug.cgi?id=133550
Reviewed by Gustavo Noronha Silva.
Cairo includes some definitions from GLX that conflict with the
ones provided by our GLES2 headers (GLintptr, GLsizeiptr).
Since GLContextEGL doesn't use any GLX functions we can safely
disable the inclusion of those functions in that source file.
- platform/graphics/egl/GLContextEGL.cpp:
- 1:36 AM WebKitGTK/2.4.x edited by
- (diff)
- 1:28 AM Changeset in webkit [170796] by
-
- 2 edits in releases/WebKitGTK/webkit-2.4/Tools
Merge r169768 - [GTK][gtkdoc] remove -Wcast-align
https://bugs.webkit.org/show_bug.cgi?id=133640
Apparently gcc warns that GParamSpec is not castable to
GParamSpecInt64/GParamSpecUInt64/GParamSpecDouble due they are 64bit, even
though ARM hackers claim that those only need 4byte alignment. As long as gcc
behaves that way, this warning is not very useful, also they break the Debian
packaging.
This patch appends the compiler flag -Wno-align-cast for the gtkdoc
scanner compilation, thus the compiler ignores the previous
-Waling-cast flag.
Reviewed by Martin Robinson.
- gtk/generate-gtkdoc:
(get_generator_for_config):
- 1:27 AM WebKitGTK/2.4.x edited by
- (diff)
- 1:24 AM WebKitGTK/2.4.x edited by
- (diff)
- 1:23 AM Changeset in webkit [170795] by
-
- 5 edits in trunk/Source/WebKit2
Unreviewed. Fixing the build for ports on 64-bit Linux.
Add IPC encoding and decoding overloads for the long long type, needed
after r170755 started encoding and decoding long long variables in
FormDataElement.
- Platform/IPC/ArgumentDecoder.cpp:
(IPC::ArgumentDecoder::decode):
- Platform/IPC/ArgumentDecoder.h:
- Platform/IPC/ArgumentEncoder.cpp:
(IPC::ArgumentEncoder::encode):
- Platform/IPC/ArgumentEncoder.h:
- 1:09 AM Changeset in webkit [170794] by
-
- 3 edits in releases/WebKitGTK/webkit-2.4/Source/JavaScriptCore
[GTK] [Stable] Crash while playing a video
https://bugs.webkit.org/show_bug.cgi?id=133940
Unreviewed. Rolling out r160688.
- jit/CCallHelpers.h:
- jit/Repatch.cpp:
(JSC::generateProtoChainAccessStub):
(JSC::tryBuildGetByIDList):
- 12:55 AM Changeset in webkit [170793] by
-
- 5 edits in releases/WebKitGTK/webkit-2.4
Merge r170359 - Source/WebCore: [ATK] Don't ignore links rendered as blocks.
https://bugs.webkit.org/show_bug.cgi?id=130941
Patch by Jarek Czekalski <Jarek Czekalski> on 2014-06-24
Reviewed by Mario Sanchez Prada.
- /m/usr/src/webkit-trunk/Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
(WebCore::AccessibilityObject::objectFocusedAndCaretOffsetUnignored): Don't ignore links
when they are renderered with display:block.
LayoutTests: [ATK] Extended the test for accessibility of text inside "span" block in "a" block
with the tests for caret movements in these cases.
https://bugs.webkit.org/show_bug.cgi?id=130941
Patch by Jarek Czekalski <Jarek Czekalski> on 2014-06-24
Reviewed by Mario Sanchez Prada.
- platform/gtk/accessibility/text-in-span-block-in-a-block-expected.txt:
- platform/gtk/accessibility/text-in-span-block-in-a-block.html:
Added testing for text-caret-moved signal. Added one more "a" element to the set.
- 12:55 AM WebKitGTK/2.4.x edited by
- (diff)
- 12:50 AM Changeset in webkit [170792] by
-
- 3 edits2 adds in releases/WebKitGTK/webkit-2.4
Merge r169936 - Source/WebCore: [ATK] Fix text inside "span" block in "a" block was not accessible.
https://bugs.webkit.org/show_bug.cgi?id=132349
Patch by Jarek Czekalski <Jarek Czekalski> on 2014-06-13
Reviewed by Mario Sanchez Prada.
- accessibility/atk/WebKitAccessibleWrapperAtk.cpp: Add link role to the list of roles whose objects always expose atk_text interface.
LayoutTests: [ATK] Add test for accessibility of text inside "span" block in "a" block.
https://bugs.webkit.org/show_bug.cgi?id=132349
Patch by Jarek Czekalski <Jarek Czekalski> on 2014-06-13
Reviewed by Mario Sanchez Prada.
- platform/gtk/accessibility/text-in-span-block-in-a-block-expected.txt: Added.
- platform/gtk/accessibility/text-in-span-block-in-a-block.html: Added.
- 12:48 AM WebKitGTK/2.4.x edited by
- (diff)
- 12:43 AM Changeset in webkit [170791] by
-
- 10 edits6 adds in releases/WebKitGTK/webkit-2.4
Merge r169483 - Tools: [ATK] Added new accessibility signal: text-caret-moved.
Make AccessibilityUIElement.setSelectedTextRange work
as atk_text_set_caret_offset when given offset == 0.
https://bugs.webkit.org/show_bug.cgi?id=132527
Patch by Jarek Czekalski <Jarek Czekalski> on 2014-05-30
Reviewed by Mario Sanchez Prada.
text-caret-moved signal in accessibilityController is needed to
implement tests from Tools/TestWebKitAPI/Tests/WebKitGtk/testatk.c
as LayoutTests. Add the signal to the controller.
- WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
- WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
- WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
- WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
- WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
(setSelectedTextRange): Change return type to bool.
- WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
(setSelectedTextRange): Call atk_text_set_caret_offset and return bool.
- WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
(axObjectEventListener): Add notification name AXTextCaretMoved, allow
for extra arguments passed to handler and use it for text-caret-moved offset.
(WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks):
Connect callback to new listener for ATK:AtkText:text-caret-moved.
Refactor so that failures be reported.
Initialize atk interfaces before trying to connect to them, see
https://bugzilla.gnome.org/show_bug.cgi?id=729922
(WTR::AccessibilityNotificationHandler::disconnectAccessibilityCallbacks):
Simplify code by using a vector in place of dozen variables.
- DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
Comment about not synchronizing with accessibilityController.
LayoutTests: [ATK] Convert caret offset tests from testatk.c.
https://bugs.webkit.org/show_bug.cgi?id=132527
Patch by Jarek Czekalski <Jarek Czekalski> on 2014-05-30
Reviewed by Mario Sanchez Prada.
The tests are replicated from testatk.c file, functions
testWebkitAtkCaretOffsets()
testWebkitAtkCaretOffsetsAndExtranousWhiteSpaces()
The file was present in webkit1. Removed from trunk in r166977, so
the last version was
https://trac.webkit.org/browser/trunk/Tools/TestWebKitAPI/Tests/WebKitGtk/testatk.c?rev=166976
What could not be verified in the same way:
- Whether element implements ATK_TEXT. If setCaretOffset
succeeds, it confirms that element is text as well. But in cases
when setCaretOffset must fail I see no way to confirm it is text
element.
- Whether position is correct through a call to
atk_text_get_caret_offset. text-caret-moved signal value is
tested instead.
Anyway these cases don't look crucial, so they are skipped.
- platform/gtk/resources/atk-helpers.js: Added.
(setCaretOffset): Added.
- platform/gtk/accessibility/caret-offsets-and-extraneous-white-spaces-expected.txt: Added.
- platform/gtk/accessibility/caret-offsets-and-extraneous-white-spaces.html: Added.
- platform/gtk/accessibility/caret-offsets-expected.txt: Added.
- platform/gtk/accessibility/caret-offsets.html: Added.
- 12:43 AM WebKitGTK/2.4.x edited by
- (diff)
- 12:26 AM Changeset in webkit [170790] by
-
- 19 edits in releases/WebKitGTK/webkit-2.4/Source/WebKit2
Merge r170423 - [GTK] Windowed plugins visibility doesn't work
https://bugs.webkit.org/show_bug.cgi?id=131487
Reviewed by Anders Carlsson.
Implement plugins visibility changes and add a new message to
notify the UI process when a windowed plugin is shown/hidden to
show/hide the plugin widget.
- PluginProcess/PluginControllerProxy.cpp:
(WebKit::PluginControllerProxy::visibilityDidChange): Add
implementation to notify the plugin about visibility change.
(WebKit::PluginControllerProxy::windowedPluginVisibilityDidChange):
Send WindowedPluginVisibilityDidChange to the plugin proxy.
- PluginProcess/PluginControllerProxy.h:
- PluginProcess/PluginControllerProxy.messages.in: Add VisibilityDidChange message.
- UIProcess/WebPageProxy.h: Add windowedPluginVisibilityDidChange
to handle WindowedPluginVisibilityDidChange message.
- UIProcess/WebPageProxy.messages.in: Add WindowedPluginVisibilityDidChange message.
- UIProcess/efl/WebPageProxyEfl.cpp:
(WebKit::WebPageProxy::windowedPluginVisibilityDidChange):
- UIProcess/gtk/WebPageProxyGtk.cpp:
(WebKit::WebPageProxy::createPluginContainer): Do not show the
plugins by default.
(WebKit::WebPageProxy::windowedPluginVisibilityDidChange): Show or hide the plugin widget.
- WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::NetscapePlugin): Initialize m_isVisible.
(WebKit::NetscapePlugin::visibilityDidChange): Add visible parameter and save it in m_isVisible
member, calling platformVisibilityDidChange() only when it has actually changed.
- WebProcess/Plugins/Netscape/NetscapePlugin.h:
- WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:
(WebKit::NetscapePlugin::platformVisibilityDidChange): Notify the controller about visibility change.
- WebProcess/Plugins/PDF/PDFPlugin.h:
- WebProcess/Plugins/Plugin.h:
- WebProcess/Plugins/PluginController.h:
- WebProcess/Plugins/PluginProxy.cpp:
(WebKit::PluginProxy::visibilityDidChange): Send VisibilityDidChange message to the plugin controller proxy.
(WebKit::PluginProxy::windowedPluginVisibilityDidChange): Notify the controller about visibility change.
- WebProcess/Plugins/PluginProxy.h:
- WebProcess/Plugins/PluginProxy.messages.in: Add WindowedPluginVisibilityDidChange message.
- WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::didInitializePlugin): Also call viewVisibilityDidChange() when the plugin is initialized.
(WebKit::PluginView::setParentVisible): Override this Widget method to update the plugin visibility when parent
widget is shown/hidden.
(WebKit::PluginView::viewVisibilityDidChange): Pass visible parameter to visibilityDidChange().
(WebKit::PluginView::windowedPluginVisibilityDidChange): Send WindowedPluginVisibilityDidChange message to the UI process.
- WebProcess/Plugins/PluginView.h:
- 12:26 AM WebKitGTK/2.4.x edited by
- (diff)
- 12:16 AM Changeset in webkit [170789] by
-
- 2 edits in releases/WebKitGTK/webkit-2.4/Source/WebKit2
Merge r170633 - [GTK] Annotations for WebResource.get_data produce wrong signature in Vala binding
https://bugs.webkit.org/show_bug.cgi?id=134476
Patch by Evan Nemerson <evan@nemerson.com> on 2014-07-01
Reviewed by Carlos Garcia Campos.
- UIProcess/API/gtk/WebKitWebResource.cpp: Add array length and
element-type annotations to return value of webkit_web_resource_get_data_finish().
- 12:14 AM WebKitGTK/2.4.x edited by
- (diff)
- 12:13 AM Changeset in webkit [170788] by
-
- 2 edits in releases/WebKitGTK/webkit-2.4/Source/ThirdParty/ANGLE
[GTK] [Stable] Crash in TSymbolTableLevel::~TSymbolTableLevel with GCC 4.9
https://bugs.webkit.org/show_bug.cgi?id=134593
Unreviewed. Backported from Mozilla by Mike Hommey <mh+mozilla@glandium.org>
https://bugzilla.mozilla.org/show_bug.cgi?id=1025576
https://code.google.com/p/angleproject/issues/detail?id=651
- src/compiler/SymbolTable.cpp:
(TSymbolTableLevel::~TSymbolTableLevel):
- 12:10 AM Changeset in webkit [170787] by
-
- 9 edits in trunk/Source/WebKit2
[iOS][WK2] Black web view after un-suspending process
https://bugs.webkit.org/show_bug.cgi?id=134623
<rdar://problem/17513223>
Reviewed by Simon Fraser.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::viewStateDidChange):
Add an argument to viewStateDidChange that allows callers (-[WKContentView _applicationWillEnterForeground:])
to force us to wait for a synchronous reply from the Web process after performing a view state change.
(WebKit::WebPageProxy::dispatchViewStateChange):
Move the has-been-in-window-and-now-is-newly-in-window check into dispatchViewStateChange.
Adjust the logic surrounding going into/out of window by factoring out the IsInWindow-did-change check, for clarity.
- UIProcess/WebPageProxy.h:
- UIProcess/ios/WKContentView.mm:
(-[WKContentView _applicationWillEnterForeground:]):
As previously mentioned, wait for a reply when foregrounding.
- WebProcess/WebPage/DrawingArea.h:
- WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h:
- WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:
(WebKit::RemoteLayerTreeDrawingArea::scheduleCompositingLayerFlushImmediately):
(WebKit::RemoteLayerTreeDrawingArea::scheduleCompositingLayerFlush):
(WebKit::RemoteLayerTreeDrawingArea::viewStateDidChange):
Make sure to schedule a commit immediately if the UI process is waiting for a reply.
Previously we assumed that a commit would be scheduled anyway because we would have to reparent the
layer tree, but that doesn't happen in the suspension-without-unparenting case. Also, we want to skip
all throttling in this case.
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::scheduleCompositingLayerFlushImmediately):
