⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jul 9, 2014:

11:35 PM Changeset in webkit [170959] by bshafiei@apple.com
  • 2 edits in tags/Safari-538.45.1/Source/WebKit2

Merged r170948. <rdar://problem/17616971>

11:14 PM Changeset in webkit [170958] by psolanki@apple.com
  • 5 edits in trunk/Source/WebKit2

Buffer CSS and JS resources in network process before sending over to web process
​https://bugs.webkit.org/show_bug.cgi?id=134560
<rdar://problem/16737186>

Reviewed by Antti Koivisto.

For CSS and JS resources, ask the network process to buffer the entire resource instead of
sending it to web process in chunks since the web process can't do anything with a partial
css or js file.

  • NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::NetworkResourceLoader::NetworkResourceLoader):

  • Shared/Network/NetworkResourceLoadParameters.cpp:

(WebKit::NetworkResourceLoadParameters::NetworkResourceLoadParameters):
(WebKit::NetworkResourceLoadParameters::encode):
(WebKit::NetworkResourceLoadParameters::decode):

  • Shared/Network/NetworkResourceLoadParameters.h:
  • WebProcess/Network/WebResourceLoadScheduler.cpp:

(WebKit::WebResourceLoadScheduler::scheduleLoad):

11:08 PM Changeset in webkit [170957] by beidson@apple.com
  • 5 edits in trunk/Source/WebCore

Fire connected/disconnected events for Gamepads.
​https://bugs.webkit.org/show_bug.cgi?id=134386

Reviewed by Dean Jackson.

No new tests (No effect in a currently tested config)

  • Modules/gamepad/GamepadManager.cpp:

(WebCore::navigatorGamepadFromDOMWindow): Handling converting a possibly-null Navigator into

a possibly null NavigatorGamepad.

(WebCore::GamepadManager::platformGamepadConnected): Notify blind Navigator/DOMWindows of all

previously attached Gamepads, then notify everybody of this new gamepad.

(WebCore::GamepadManager::platformGamepadDisconnected): Handle dispatching the disconnected

event to all registered DOMWindows.

(WebCore::GamepadManager::platformGamepadInputActivity): Notify blind Navigator/DOMWindows of all

attached Gamepads.

(WebCore::GamepadManager::makeGamepadVisible): Handles notifying setting up a new gamepads

with all NavigatorGamepads as well as dispatching the connected even to DOMWindows.

(WebCore::GamepadManager::registerDOMWindow):
(WebCore::GamepadManager::unregisterDOMWindow):
(WebCore::GamepadManager::makeGamepadsVisibileToBlindNavigators): Deleted.

  • Modules/gamepad/GamepadManager.h:
  • Modules/gamepad/NavigatorGamepad.cpp:

(WebCore::NavigatorGamepad::gamepadAtIndex):

  • Modules/gamepad/NavigatorGamepad.h:
10:59 PM Changeset in webkit [170956] by bshafiei@apple.com
  • 5 edits in tags/Safari-538.45.1/Source

Versioning.

10:47 PM Changeset in webkit [170955] by bshafiei@apple.com
  • 1 copy in tags/Safari-538.45.1

New tag.

10:32 PM Changeset in webkit [170954] by Brent Fulgham
  • 2 edits in trunk/WebKitLibraries

[Win] Unreviewed build fix.

Build bots don't have a three-part default version string,
breaking pattern matching. Handle this case.

  • win/tools/scripts/auto-version.pl:
10:06 PM Changeset in webkit [170953] by benjamin@webkit.org
  • 10 edits in trunk/Source

[iOS][WK2] Disable text quantization while actively changing the page's scale factor
​https://bugs.webkit.org/show_bug.cgi?id=134781

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2014-07-09
Reviewed by Tim Horton and Myles C. Maxfield.

Source/WebCore:
Query the chrome client to setup quantization on each layers.

  • page/ChromeClient.h:

(WebCore::ChromeClient::hasStablePageScaleFactor):

  • platform/graphics/mac/FontMac.mm:

(WebCore::Font::drawGlyphs):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::setupFontSubpixelQuantization):

Source/WebKit2:
While zooming a page, text quantization causes glyphs to "move" in order to get to the closest
boundary for the current scale factor.

We do not want this to happen while dynamically changing the scale factor because the effect
is visible. To avoid this, we disable text quantization if the page's scale factor changes
in response to a non-stable contentRect update.

  • WebProcess/WebCoreSupport/WebChromeClient.h:
  • WebProcess/WebCoreSupport/ios/WebChromeClientIOS.mm:

(WebKit::WebChromeClient::hasStablePageScaleFactor):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):

  • WebProcess/WebPage/WebPage.h:

(WebKit::WebPage::hasStablePageScaleFactor):

  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::updateVisibleContentRects):

9:38 PM Changeset in webkit [170952] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[iOS] Use UIAlertController API in WKFileUploadPanel instead of SPI
​https://bugs.webkit.org/show_bug.cgi?id=134777

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-07-09
Reviewed by Sam Weinig.

  • UIProcess/ios/forms/WKFileUploadPanel.mm:

(-[WKFileUploadPanel _showMediaSourceSelectionSheet]):

9:13 PM Changeset in webkit [170951] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit2

[EFL][WK2] Add new Public API in ewk_download_job.h to get size of the data already downloaded.
​https://bugs.webkit.org/show_bug.cgi?id=134759

Patch by Shivakumar JM <​shiva.jm@samsung.com> on 2014-07-09
Reviewed by Gyuyoung Kim.

Add new API in ewk_download_job.h to get size of the data already downloaded.

  • UIProcess/API/efl/ewk_download_job.cpp:

(ewk_download_job_received_data_length_get):
(EwkDownloadJob::receivedData):

  • UIProcess/API/efl/ewk_download_job.h:
  • UIProcess/API/efl/ewk_download_job_private.h:
  • UIProcess/API/efl/tests/test_ewk2_download_job.cpp:

(EWK2DownloadJobTest::on_download_requested):
(EWK2DownloadJobTest::on_download_finished):

9:11 PM Changeset in webkit [170950] by benjamin@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

Use 16bits instructions for push/pop on ARMv7 when possible
​https://bugs.webkit.org/show_bug.cgi?id=134753

Reviewed by Geoffrey Garen.

The patch r170839 mixed the code for push/pop pair and single push/pop.
That part was reverted in r170909.

This patch puts the code back but specialized for single push/pop.

  • assembler/ARMv7Assembler.h:

(JSC::ARMv7Assembler::pop):
(JSC::ARMv7Assembler::push):

  • assembler/MacroAssemblerARMv7.h:

(JSC::MacroAssemblerARMv7::pop):
(JSC::MacroAssemblerARMv7::push):

8:11 PM Changeset in webkit [170949] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[Curl] Cache entry invalidated too early.
​https://bugs.webkit.org/show_bug.cgi?id=134681

Patch by ​peavo@outlook.com <​peavo@outlook.com> on 2014-07-09
Reviewed by Alex Christensen.

When a cache entry has expired, it is invalidated when a request for the corresponding url is started.
This is too early, since the resource is possibly not modified (even though it has expired),
and the server might respond with a 304 (not modified) response.
When we then receive a 304 response, the cache entry is deleted, and we have no cached response/data to provide.
This can be solved by not invalidating the entry when a request for that url is started,
but instead invalidate when a 200 OK response is received (which means the resource has been modified).

  • platform/network/curl/CurlCacheManager.cpp:

(WebCore::CurlCacheManager::isCached): Avoid invalidating cache entry when it has expired, wait until we know the server response.

  • platform/network/curl/CurlCacheManager.h: Added const modifier.
7:18 PM Changeset in webkit [170948] by enrica@apple.com
  • 2 edits in trunk/Source/WebKit2

REGRESSION(r170858): Safari freezes upon making a search on a website (yelp.com).
​https://bugs.webkit.org/show_bug.cgi?id=134791
<rdar://problem/17616971>

Reviewed by Benjamin Poulain.

After r170858 we notify the keyboard too often about
the changed selection. This patch removes the notification
until we find a better way to do it that doesn't cause
deadlocks.

  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _selectionWillChange]):
(-[WKContentView _selectionChanged]):

6:42 PM Changeset in webkit [170947] by mmaxfield@apple.com
  • 37 edits in trunk/Source/WebCore

Revert r170413 and r170390
​https://bugs.webkit.org/show_bug.cgi?id=134741

Reviewed by Benjamin Poulain.

These patches caused a variety of failures. I'm going to break them up into
smaller chunks and commit them separately at some point in the future.

Requesting a review from Ben Poulain because there were some conflicts with
r170561 in InlineTextBox.cpp and InlineTextBox.h.

  • WebCore.exp.in:
  • platform/graphics/Font.cpp:

(WebCore::Font::drawText):
(WebCore::Font::drawEmphasisMarks):
(WebCore::Font::adjustSelectionRectForText):
(WebCore::computeUnderlineType):

  • platform/graphics/Font.h:
  • platform/graphics/FontFastPath.cpp:

(WebCore::Font::getGlyphsAndAdvancesForSimpleText):
(WebCore::Font::drawSimpleText):
(WebCore::Font::drawEmphasisMarksForSimpleText):
(WebCore::Font::drawGlyphBuffer):
(WebCore::Font::drawEmphasisMarks):
(WebCore::Font::adjustSelectionRectForSimpleText):

  • platform/graphics/GlyphBuffer.h:

(WebCore::GlyphBuffer::size):
(WebCore::GlyphBuffer::glyphs):
(WebCore::GlyphBuffer::advances):
(WebCore::GlyphBuffer::fontDataAt):
(WebCore::GlyphBuffer::advanceAt):
(WebCore::GlyphBuffer::offsetAt):
(WebCore::GlyphBuffer::reverse):
(WebCore::GlyphBuffer::offsetInString):
(WebCore::GlyphBuffer::swap):

  • platform/graphics/GraphicsContext.cpp:
  • platform/graphics/Latin1TextIterator.h:

(WebCore::Latin1TextIterator::Latin1TextIterator):
(WebCore::Latin1TextIterator::currentCharacter):

  • platform/graphics/SimpleFontData.h:
  • platform/graphics/SurrogatePairAwareTextIterator.cpp:

(WebCore::SurrogatePairAwareTextIterator::SurrogatePairAwareTextIterator):

  • platform/graphics/SurrogatePairAwareTextIterator.h:

(WebCore::SurrogatePairAwareTextIterator::currentCharacter):

  • platform/graphics/TextRun.h:

(WebCore::TextRun::length):
(WebCore::TextRun::charactersLength):

  • platform/graphics/WidthIterator.cpp:

(WebCore::WidthIterator::glyphDataForCharacter):
(WebCore::applyFontTransforms):
(WebCore::WidthIterator::advanceInternal):
(WebCore::WidthIterator::advance):
(WebCore::WidthIterator::advanceOneCharacter):

  • platform/graphics/WidthIterator.h:
  • platform/graphics/cairo/FontCairo.cpp:

(WebCore::Font::drawGlyphs):

  • platform/graphics/cairo/FontCairoHarfbuzzNG.cpp:

(WebCore::Font::drawComplexText):
(WebCore::Font::drawEmphasisMarksForComplexText):
(WebCore::Font::adjustSelectionRectForComplexText):

  • platform/graphics/harfbuzz/HarfBuzzShaper.cpp:

(WebCore::HarfBuzzShaper::setNormalizedBuffer):

  • platform/graphics/mac/FontComplexTextMac.cpp:

(WebCore::Font::adjustSelectionRectForComplexText):
(WebCore::Font::getGlyphsAndAdvancesForComplexText):
(WebCore::Font::drawComplexText):
(WebCore::Font::drawEmphasisMarksForComplexText):

  • platform/graphics/mac/FontMac.mm:

(WebCore::Font::drawGlyphs):

  • platform/graphics/win/FontCGWin.cpp:

(WebCore::Font::drawGlyphs):

  • platform/graphics/win/FontWin.cpp:

(WebCore::Font::adjustSelectionRectForComplexText):
(WebCore::Font::getGlyphsAndAdvancesForComplexText):
(WebCore::Font::drawComplexText):
(WebCore::Font::drawEmphasisMarksForComplexText):

  • platform/graphics/wince/FontWinCE.cpp:

(WebCore::Font::drawGlyphs):
(WebCore::Font::drawComplexText):
(WebCore::Font::drawEmphasisMarksForComplexText):
(WebCore::Font::selectionRectForComplexText):

  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::isSelected):
(WebCore::InlineTextBox::selectionState):
(WebCore::InlineTextBox::localSelectionRect):
(WebCore::InlineTextBox::paint):
(WebCore::InlineTextBox::selectionStartEnd):
(WebCore::InlineTextBox::paintSelection):
(WebCore::InlineTextBox::paintCompositionBackground):
(WebCore::InlineTextBox::paintDocumentMarker):
(WebCore::InlineTextBox::paintTextMatchMarker):
(WebCore::InlineTextBox::computeRectForReplacementMarker):
(WebCore::InlineTextBox::paintCompositionUnderline):
(WebCore::InlineTextBox::positionForOffset):
(WebCore::InlineTextBox::constructTextRun):

  • rendering/InlineTextBox.h:

(WebCore::InlineTextBox::truncation):

  • rendering/RenderCombineText.cpp:

(WebCore::RenderCombineText::getStringToRender):

  • rendering/RenderCombineText.h:
  • rendering/RenderTextLineBoxes.cpp:

(WebCore::ellipsisRectForBox):

  • rendering/svg/SVGInlineFlowBox.cpp:

(WebCore::SVGInlineFlowBox::computeTextMatchMarkerRectForRenderer):

  • rendering/svg/SVGInlineTextBox.cpp:

(WebCore::SVGInlineTextBox::positionForOffset):
(WebCore::SVGInlineTextBox::localSelectionRect):
(WebCore::SVGInlineTextBox::paintSelectionBackground):
(WebCore::SVGInlineTextBox::mapStartEndPositionsIntoFragmentCoordinates):
(WebCore::SVGInlineTextBox::paintText):

  • rendering/svg/SVGInlineTextBox.h:
  • rendering/svg/SVGTextMetricsBuilder.cpp:

(WebCore::SVGTextMetricsBuilder::currentCharacterStartsSurrogatePair):
(WebCore::SVGTextMetricsBuilder::advance):

  • rendering/svg/SVGTextQuery.cpp:

(WebCore::SVGTextQuery::mapStartEndPositionsIntoFragmentCoordinates):
(WebCore::SVGTextQuery::modifyStartEndPositionsRespectingLigatures):
(WebCore::SVGTextQuery::subStringLengthCallback):
(WebCore::SVGTextQuery::startPositionOfCharacterCallback):
(WebCore::SVGTextQuery::endPositionOfCharacterCallback):
(WebCore::SVGTextQuery::rotationOfCharacterCallback):
(WebCore::SVGTextQuery::extentOfCharacterCallback):
(WebCore::SVGTextQuery::characterNumberAtPositionCallback):

  • rendering/svg/SVGTextQuery.h:
  • rendering/svg/SVGTextRunRenderingContext.cpp:

(WebCore::SVGGlyphToPathTranslator::SVGGlyphToPathTranslator):
(WebCore::SVGTextRunRenderingContext::glyphDataForCharacter):

  • rendering/svg/SVGTextRunRenderingContext.h:
  • svg/SVGFontData.cpp:

(WebCore::SVGFontData::applySVGGlyphSelection):

  • svg/SVGFontData.h:
6:13 PM Changeset in webkit [170946] by jpfau@apple.com
  • 4 edits in trunk

Fix flaky loading tests
​https://bugs.webkit.org/show_bug.cgi?id=133696

Reviewed by Ryosuke Niwa.

Source/WebCore:
In some cases, the Frame may be destroyed while the loader is
initializing. Make sure we don't delete it too early.

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::init):

LayoutTests:

  • platform/wk2/TestExpectations: Unskip no-longer failing tests
6:05 PM Changeset in webkit [170945] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Safari showing blank pages
​https://bugs.webkit.org/show_bug.cgi?id=134790
<rdar://problem/17617166>

Reviewed by Simon Fraser.

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView initWithFrame:configuration:]):
Make sure to add the content view to the scroll view.

6:01 PM Changeset in webkit [170944] by Simon Fraser
  • 4 edits in trunk/Source/WebCore

Make IndirectCompositingReason an enum class
​https://bugs.webkit.org/show_bug.cgi?id=134789

Reviewed by Tim Horton.

Make RenderLayer::IndirectCompositingReason an enum class, and change some code
in RenderLayerCompositor::reasonsForCompositing() to use a switch.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::RenderLayer):

  • rendering/RenderLayer.h:
  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::computeCompositingRequirements):
(WebCore::RenderLayerCompositor::requiresOwnBackingStore):
(WebCore::RenderLayerCompositor::reasonsForCompositing):
(WebCore::RenderLayerCompositor::requiresCompositingForIndirectReason):

5:50 PM Changeset in webkit [170943] by andersca@apple.com
  • 4 edits in trunk/Source/WebKit2

Closed web views should never create new web processes
​https://bugs.webkit.org/show_bug.cgi?id=134787
<rdar://problem/16892526>

Reviewed by Simon Fraser.

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView loadHTMLString:baseURL:]):
(-[WKWebView reload]):
(-[WKWebView reloadFromOrigin]):
Return nil if the returned navigation ID is 0.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::reattachToWebProcess):
Assert that the page is not closed.

(WebKit::WebPageProxy::reattachToWebProcessWithItem):
(WebKit::WebPageProxy::loadRequest):
(WebKit::WebPageProxy::loadFile):
(WebKit::WebPageProxy::loadData):
(WebKit::WebPageProxy::loadHTMLString):
(WebKit::WebPageProxy::loadAlternateHTMLString):
(WebKit::WebPageProxy::loadPlainTextString):
(WebKit::WebPageProxy::loadWebArchiveData):
Add early returns if the page is closed.

  • UIProcess/WebPageProxy.h:
5:29 PM Changeset in webkit [170942] by ryuan.choi@samsung.com
  • 10 edits in trunk/LayoutTests

[EFL] gardening after r170868
​https://bugs.webkit.org/show_bug.cgi?id=134717

Unreviewed, EFL gardening.

Four tests have been rebaselined, and disable the gamepad tests

Patch by Hunseop Jeong <Hunseop Jeong> on 2014-07-09

  • platform/efl/TestExpectations: Disable the gamepad tests
  • platform/efl/fast/text/atsui-multiple-renderers-expected.png:
  • platform/efl/fast/text/atsui-multiple-renderers-expected.txt:
  • platform/efl/fast/text/complex-text-opacity-expected.png:
  • platform/efl/fast/text/complex-text-opacity-expected.txt:
  • platform/efl/fast/text/midword-break-before-surrogate-pair-expected.png:
  • platform/efl/fast/text/midword-break-before-surrogate-pair-expected.txt:
  • platform/efl/transforms/2d/hindi-rotated-expected.png:
  • platform/efl/transforms/2d/hindi-rotated-expected.txt:
5:25 PM Changeset in webkit [170941] by jer.noble@apple.com
  • 2 edits in trunk/LayoutTests

[MSE] http/tests/media/media-source/mediasource-closed.html is failing.
​https://bugs.webkit.org/show_bug.cgi?id=134775

Reviewed by Eric Carlson.

Update the test to use isNaN rather than Number.isNaN.

  • http/tests/media/media-source/mediasource-closed.html:
5:24 PM Changeset in webkit [170940] by Brent Fulgham
  • 3 edits in trunk/WebKitLibraries

[Win] Unreviewed gardening.

  • win/tools/scripts/auto-version.pl: Protect against

malformed paths (trailing backslashes).

  • win/tools/scripts/feature-defines.pl: Make sure result

has an EOL character.

5:22 PM Changeset in webkit [170939] by Brent Fulgham
  • 2 edits in trunk/Source/WTF

[Win] Unreviewed build fix after r170930.

  • WTF.vcxproj/copy-files.cmd: Include cf files in

post-build copy operation.

5:18 PM Changeset in webkit [170938] by psolanki@apple.com
  • 5 edits in trunk/Source/WebCore

Make SharedBuffer::append(SharedBuffer*) be smarter about CFData and data arrays
​https://bugs.webkit.org/show_bug.cgi?id=134731

Reviewed by Antti Koivisto.

If the target SharedBuffer has a CFDataRef or a data array then we can simply retain that
CFDataRef or data array elements in the SharedBuffer being appended to. This avoids
unnecessary copying.

No new tests because no functional changes.

  • platform/SharedBuffer.cpp:

(WebCore::SharedBuffer::append):
(WebCore::SharedBuffer::maybeAppendPlatformData):

  • platform/SharedBuffer.h:
  • platform/cf/SharedBufferCF.cpp:

(WebCore::SharedBuffer::maybeAppendPlatformData):
(WebCore::SharedBuffer::maybeAppendDataArray):

  • platform/soup/SharedBufferSoup.cpp:

(WebCore::SharedBuffer::maybeAppendPlatformData):

4:48 PM Changeset in webkit [170937] by Brent Fulgham
  • 42 edits
    8 moves in trunk

[Win] Remove uses of 'bash' in build system
​https://bugs.webkit.org/show_bug.cgi?id=134782
<rdar://problem/17615533>

Reviewed by Dean Jackson.

Remove uses of 'bash' by replacing Windows-specific bash scripts
with Perl equivalents.

Source/JavaScriptCore:

  • JavaScriptCore.vcxproj/JavaScriptCoreGenerated.make:
  • JavaScriptCore.vcxproj/JavaScriptCoreGenerated.vcxproj:
  • JavaScriptCore.vcxproj/JavaScriptCoreGenerated.vcxproj.filters:
  • JavaScriptCore.vcxproj/JavaScriptCorePreBuild.cmd:
  • JavaScriptCore.vcxproj/LLInt/LLIntAssembly/LLIntAssembly.make:
  • JavaScriptCore.vcxproj/LLInt/LLIntAssembly/LLIntAssembly.vcxproj:
  • JavaScriptCore.vcxproj/LLInt/LLIntAssembly/build-LLIntAssembly.pl: Copied from Source/JavaScriptCore/JavaScriptCore.vcxproj/LLInt/LLIntAssembly/build-LLIntAssembly.sh.
  • JavaScriptCore.vcxproj/LLInt/LLIntAssembly/build-LLIntAssembly.sh: Removed.
  • JavaScriptCore.vcxproj/LLInt/LLIntDesiredOffsets/LLIntDesiredOffsets.make:
  • JavaScriptCore.vcxproj/LLInt/LLIntDesiredOffsets/LLIntDesiredOffsets.vcxproj:
  • JavaScriptCore.vcxproj/LLInt/LLIntDesiredOffsets/build-LLIntDesiredOffsets.pl: Copied from Source/JavaScriptCore/JavaScriptCore.vcxproj/LLInt/LLIntDesiredOffsets/build-LLIntDesiredOffsets.sh.
  • JavaScriptCore.vcxproj/LLInt/LLIntDesiredOffsets/build-LLIntDesiredOffsets.sh: Removed.
  • JavaScriptCore.vcxproj/build-generated-files.pl: Copied from Source/JavaScriptCore/JavaScriptCore.vcxproj/build-generated-files.sh.
  • JavaScriptCore.vcxproj/build-generated-files.sh: Removed.
  • JavaScriptCore.vcxproj/jsc/jscPreBuild.cmd:
  • JavaScriptCore.vcxproj/testRegExp/testRegExpPreBuild.cmd:
  • JavaScriptCore.vcxproj/testapi/testapiPreBuild.cmd:

Source/WebCore:

  • WebCore.vcxproj/WebCoreGenerated.make:
  • WebCore.vcxproj/WebCoreGenerated.vcxproj:
  • WebCore.vcxproj/WebCoreGenerated.vcxproj.filters:
  • WebCore.vcxproj/WebCorePreBuild.cmd:
  • WebCore.vcxproj/build-generated-files.pl: Copied from Source/WebCore/WebCore.vcxproj/build-generated-files.sh.
  • WebCore.vcxproj/build-generated-files.sh: Removed.
  • WebCore.vcxproj/migrate-scripts.pl: Copied from Source/WebCore/WebCore.vcxproj/migrate-scripts.sh.
  • WebCore.vcxproj/migrate-scripts.sh: Removed.

Source/WebInspectorUI:

  • WebInspectorUI.vcxproj/WebInspectorUI.make:
  • WebInspectorUI.vcxproj/WebInspectorUI.vcxproj:
  • WebInspectorUI.vcxproj/WebInspectorUI.vcxproj.filters:
  • WebInspectorUI.vcxproj/build-webinspectorui.pl: Copied from Source/WebInspectorUI/WebInspectorUI.vcxproj/build-webinspectorui.sh.
  • WebInspectorUI.vcxproj/build-webinspectorui.sh: Removed.

Source/WebKit:

  • WebKit.vcxproj/Interfaces/FixMIDLHeaders.pl:
  • WebKit.vcxproj/Interfaces/InterfacesPreBuild.cmd:
  • WebKit.vcxproj/WebKit/WebKitPreBuild.cmd:
  • WebKit.vcxproj/WebKit/WebKitVersion.cmd:
  • WebKit.vcxproj/WebKitExportGenerator/WebKitExportGeneratorBuildCmd.cmd:
  • WebKit.vcxproj/WebKitExportGenerator/WebKitExportGeneratorPreBuild.cmd:
  • WebKit.vcxproj/WebKitGUID/WebKitGUIDPreBuild.cmd:

Source/WTF:

  • WTF.vcxproj/WTFGenerated.make:
  • WTF.vcxproj/WTFGenerated.vcxproj:
  • WTF.vcxproj/WTFGenerated.vcxproj.filters:
  • WTF.vcxproj/WTFPreBuild.cmd:
  • WTF.vcxproj/build-generated-files.pl: Copied from Source/WTF/WTF.vcxproj/build-generated-files.sh.
  • WTF.vcxproj/build-generated-files.sh: Removed.

Tools:

  • DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreePreBuild.cmd:
  • DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffPreBuild.cmd:
  • DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginPreBuild.cmd:
  • TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIPreBuild.cmd:
  • WinLauncher/WinLauncher.vcxproj/WinLauncherLibPreBuild.cmd:
  • WinLauncher/WinLauncher.vcxproj/WinLauncherPreBuild.cmd:

WebKitLibraries:

  • win/tools/scripts/feature-defines.pl: Copied from WebKitLibraries/win/tools/scripts/feature-defines.sh.
  • win/tools/scripts/feature-defines.sh: Removed.
3:33 PM Changeset in webkit [170936] by Lucas Forschler
  • 4 edits in tags/Safari-538.45/Source

Merged r170924. <rdar://problem/16167838>

3:06 PM Changeset in webkit [170935] by andersca@apple.com
  • 4 edits in trunk/Source

Support transparent WKWebViews
​https://bugs.webkit.org/show_bug.cgi?id=134779
<rdar://problem/17351058>

Reviewed by Tim Horton.

Source/WebCore:
Schedule rebuilding the compositing layers if a FrameView's transparency changes.

  • page/FrameView.cpp:

(WebCore::FrameView::setTransparent):

Source/WebKit2:

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView initWithFrame:configuration:]):
Call _updateScrollViewBackground instead of setting the background color.

(contentZoomScale):
Use dot notation.

(scrollViewBackgroundColor):
Helper function that returns the scroll view background color.
If the web view isn't opaque, we want the scroll view to be transparent.

(-[WKWebView _updateScrollViewBackground]):
Call scrollViewBackgroundColor.

(-[WKWebView setOpaque:]):
Call WebPageProxy::setDrawsBackground and update the scroll view background.

(-[WKWebView setBackgroundColor:]):
Call setBackgroundColor on the content view.

2:58 PM Changeset in webkit [170934] by aestes@apple.com
  • 2 edits in trunk/Source/WebKit2

[iOS] WebKit can crash under QuickLookDocumentData::encode() when viewing a QuickLook preview
​https://bugs.webkit.org/show_bug.cgi?id=134780

Reviewed by Tim Horton.

Don't use CFDataCreateWithBytesNoCopy() when we can't guarantee the lifetime of the copied-from DataReference
will match or exceed that of the CFDataRef. Copy the data instead.

  • WebProcess/Network/WebResourceLoader.cpp:

(WebKit::WebResourceLoader::didReceiveData):

2:56 PM Changeset in webkit [170933] by jfernandez@igalia.com
  • 9 edits in trunk

CSS canvas color parsing accepts invalid color identifiers
​https://bugs.webkit.org/show_bug.cgi?id=134661

Reviewed by Benjamin Poulain.

Source/WebCore:
Current implementation of the CSSParser::parseSystemColor assumes
that if a valid cssValueKeywordID is got then it has to be a valid
color. Such assumption is wrong and lead to many bugs and layout
test failures.

The parseSystemFunction determines now whether the parsed color is
valid or not.

Addtionally, a new method has been added to share the logic of
determining whether a CSSValueID is a valid primitive values for
colors or not. Generally, we should avoid passing invalid color
identifiers to the theming API.

No new tests, but added additional cases to the
canvas-color-serialization.html, test-setting-canvas-color and
rgb-color-parse test.

  • css/CSSParser.cpp:

(WebCore::validPrimitiveValueColor): Added.
(WebCore::parseColorValue):
(WebCore::CSSParser::parseSystemColor):

LayoutTests:
The parseSystemFunction determines now whether the parsed color is
valid or not.

The rgb-color-parser covers css style color parsing cases, which
already provide coverage for invalid color identifiers. I've added
a few more, though.

  • fast/canvas/canvas-color-serialization-expected.txt:
  • fast/canvas/script-tests/canvas-color-serialization.js:
  • fast/css/test-setting-canvas-color-expected.txt:
  • fast/css/test-setting-canvas-color.html:
  • svg/dom/rgb-color-parser-expected.txt:
  • svg/dom/rgb-color-parser.html:
2:37 PM Changeset in webkit [170932] by jer.noble@apple.com
  • 8 edits in trunk

Source/WebCore: [MSE] http/tests/media/media-source/mediasource-remove.html is failing
​https://bugs.webkit.org/show_bug.cgi?id=134768

Reviewed by Eric Carlson.

Fix multiple bugs causing mediasource-remove.html to fail:

Separate out setDuration() into setDurationInternal() so that steps which require
us to run the "duration change algorithm" don't bail out if the SoureBuffer is
inside updating().

  • Modules/mediasource/MediaSource.cpp:

(WebCore::MediaSource::setDuration):
(WebCore::MediaSource::setDurationInternal):

  • Modules/mediasource/MediaSource.h:
  • Modules/mediasource/SourceBuffer.cpp:

(WebCore::SourceBuffer::sourceBufferPrivateDidReceiveInitializationSegment):
(WebCore::SourceBuffer::sourceBufferPrivateDidReceiveSample):

When removing coded frames, do so starting from the first sample in the range in
decode order, so that frames dependant on removed frames are themselves removed. Add
a convenience method in SampleMap findSampleWithPresentationTime(), and rename
findSampleAfterPresentationTime() to findSampleOnOrAfterPresentationTime() to correctly
reflect what the method does, and simplify its implementation by searching the map's keys
directly.

  • Modules/mediasource/SampleMap.cpp:

(WebCore::PresentationOrderSampleMap::findSampleWithPresentationTime):
(WebCore::PresentationOrderSampleMap::findSampleOnOrAfterPresentationTime):
(WebCore::DecodeOrderSampleMap::findSyncSampleAfterPresentationTime):
(WebCore::PresentationOrderSampleMap::findSampleAfterPresentationTime): Deleted.

  • Modules/mediasource/SampleMap.h:
  • Modules/mediasource/SourceBuffer.cpp:

(WebCore::decodeTimeComparator):
(WebCore::SourceBuffer::removeCodedFrames):

Throw the correct exception (INVALID_STATE_ERR) from SourceBuffer::remove().

  • Modules/mediasource/SourceBuffer.cpp:

(WebCore::SourceBuffer::remove):

LayoutTests: [MSE] http/tests/media/media-source/mediasource-remove.html is failing.
​https://bugs.webkit.org/show_bug.cgi?id=134768

Reviewed by Eric Carlson.

Update mediasource-remove.html with the correct locations of sync-samples.

  • http/tests/media/media-source/mediasource-remove.html:
2:36 PM Changeset in webkit [170931] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebKit/mac

REGRESSION(r167770): Cannot login in Evernote Safari extension
​https://bugs.webkit.org/show_bug.cgi?id=134776

Reviewed by Enrica Casucci.

Unfortunately, NSWindowDidBecomeKeyNotification does not notify us when a popover becomes key
so we need to keep using the SPI (_windowChangedKeyState) I removed in r167770.

  • WebView/WebView.mm:

(-[WebView _windowChangedKeyState]):

2:19 PM Changeset in webkit [170930] by psolanki@apple.com
  • 9 edits in trunk/Source/WebCore

Add SharedBuffer::wrapCFDataArray() and use it
​https://bugs.webkit.org/show_bug.cgi?id=134733

Reviewed by Antti Koivisto.

No new tests. Should be covered by existing tests.

  • platform/SharedBuffer.h:
  • platform/cf/SharedBufferCF.cpp:

(WebCore::SharedBuffer::wrapCFDataArray):
(WebCore::SharedBuffer::SharedBuffer):

  • platform/network/ResourceHandle.h:
  • platform/network/cf/ResourceHandleCFNet.cpp:

(WebCore::ResourceHandle::handleDataArray): Deleted.

  • platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:

(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::didReceiveDataArray):

  • platform/network/cf/SynchronousResourceHandleCFURLConnectionDelegate.cpp:

(WebCore::SynchronousResourceHandleCFURLConnectionDelegate::didReceiveDataArray):

  • platform/network/mac/WebCoreResourceHandleAsDelegate.mm:

(-[WebCoreResourceHandleAsDelegate connection:didReceiveDataArray:]):

  • platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.mm:

(-[WebCoreResourceHandleAsOperationQueueDelegate connection:didReceiveDataArray:]):

2:16 PM Changeset in webkit [170929] by fpizlo@apple.com
  • 5 edits in branches/ftlopt/Source/JavaScriptCore

[ftlopt] Move Flush(SetLocal) store elimination to StrengthReductionPhase
​https://bugs.webkit.org/show_bug.cgi?id=134739

Reviewed by Mark Hahnenberg.

I'm going to streamline CSE around clobberize() as part of
​https://bugs.webkit.org/show_bug.cgi?id=134677, and so Flush(SetLocal) store
elimination wouldn't belong in CSE anymore. It doesn't quite belong anywhere, which
means that it belongs in StrengthReductionPhase, since that's intended to be our
dumping ground.

To do this I had to add some missing smarts to clobberize(). Previously clobberize()
could play a bit loose with reads of Variables because it wasn't used for store
elimination. The main client of read() was LICM, but it would only use it to
determine hoistability and anything that did a write() was not hoistable - so, we had
benign (but still wrong) missing read() calls in places that did write()s. This fixes
a bunch of those cases.

  • dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::performNodeCSE):
(JSC::DFG::CSEPhase::setLocalStoreElimination): Deleted.

  • dfg/DFGClobberize.cpp:

(JSC::DFG::accessesOverlap):

  • dfg/DFGClobberize.h:

(JSC::DFG::clobberize): Make clobberize() smart enough for detecting when this store elimination would be sound.

  • dfg/DFGStrengthReductionPhase.cpp:

(JSC::DFG::StrengthReductionPhase::handleNode): Implement the store elimination in terms of clobberize().

1:55 PM Changeset in webkit [170928] by psolanki@apple.com
  • 7 edits in trunk/Source

Move resource buffering from SynchronousNetworkLoaderClient to NetworkResourceLoader
​https://bugs.webkit.org/show_bug.cgi?id=134732

Reviewed by Darin Adler.

Source/WebCore:
No new tests because no functional changes.

  • WebCore.exp.in:

Source/WebKit2:
Buffer the resource in NetworkResourceLoader instead of SynchronousNetworkLoaderClient. This
is in preparation for bug 134560 where we will be supporting JS and CSS resource buffering
that uses AsynchronousNetworkLoaderClient.

  • NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::NetworkResourceLoader::NetworkResourceLoader):
(WebKit::NetworkResourceLoader::didReceiveBuffer):
(WebKit::NetworkResourceLoader::didFinishLoading):

  • NetworkProcess/NetworkResourceLoader.h:

(WebKit::NetworkResourceLoader::bufferedData):

  • NetworkProcess/SynchronousNetworkLoaderClient.cpp:

(WebKit::SynchronousNetworkLoaderClient::didReceiveBuffer):
(WebKit::SynchronousNetworkLoaderClient::didFinishLoading):
(WebKit::SynchronousNetworkLoaderClient::didFail):
(WebKit::SynchronousNetworkLoaderClient::sendDelayedReply):

  • NetworkProcess/SynchronousNetworkLoaderClient.h:
1:52 PM Changeset in webkit [170927] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebCore

Fix the !USE(IOSURFACE) build.

  • WebCore.exp.in:
12:47 PM Changeset in webkit [170926] by benjamin@webkit.org
  • 5 edits in trunk/Source/WebKit2

[iOS][WK2] subviews of the unscaled view drift out during CA animations
​https://bugs.webkit.org/show_bug.cgi?id=134751

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2014-07-09
Reviewed by Enrica Casucci.

It is not possible to animate the WKContentView and the inverse view in such a way
that the combined matrix remain the identity for every frame of the animation.

This patch solves the issue by moving the unscaled view as a sibling of WKContentView
instead of a child so that we do not need to update two scales simultaneously.

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView initWithFrame:configuration:]):
(-[WKWebView _processDidExit]):
(-[WKWebView _dynamicViewportUpdateChangedTargetToScale:position:]):
Set the z scale to 1 or no coordinate transform will work with this view.

(-[WKWebView _beginAnimatedResizeWithUpdates:]):
(-[WKWebView _endAnimatedResize]):

  • UIProcess/ios/WKContentView.mm:

(-[WKContentView didUpdateVisibleRect:unobscuredRect:unobscuredRectInScrollViewCoordinates:scale:minimumScale:inStableState:isChangingObscuredInsetsInteractively:]):

  • UIProcess/ios/WKContentViewInteraction.h:
  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView setupInteraction]):
Since we need to observe changes inside the animation block, the code now use KVO to observe changes of scale.

(-[WKContentView cleanupInteraction]):
(-[WKContentView unscaledView]):
(-[WKContentView inverseScale]):
(-[WKContentView observeValueForKeyPath:ofObject:change:context:]):
We update the utility views as usual. The extra bits here are to deal with views coming in during an animation.

If a new utility view comes in during a scaling animation, we do not want to start a new animation with the same curve
to end up at the right place. To avoid any issue, we just hide the view until the animation is finished.

(-[WKContentView hitTest:withEvent:]):
(-[WKContentView _showTapHighlight]):
(-[WKContentView _updateUnscaledView]): Deleted.

12:31 PM Changeset in webkit [170925] by timothy_horton@apple.com
  • 8 edits in trunk/Source

Use IOSurface ViewSnapshots everywhere on Mac, remove JPEG encoding path
​https://bugs.webkit.org/show_bug.cgi?id=134773

Reviewed by Anders Carlsson.

  • UIProcess/API/mac/WKView.mm:

(-[WKView _takeViewSnapshot]):

  • UIProcess/mac/ViewSnapshotStore.h:
  • UIProcess/mac/ViewSnapshotStore.mm:

(WebKit::ViewSnapshotStore::ViewSnapshotStore):
(WebKit::ViewSnapshotStore::~ViewSnapshotStore):
(WebKit::ViewSnapshotStore::recordSnapshot):
(WebKit::ViewSnapshot::clearImage):
(WebKit::ViewSnapshot::asLayerContents):
(WebKit::createIOSurfaceFromImage): Deleted.
(WebKit::compressImageAsJPEG): Deleted.
(WebKit::ViewSnapshotStore::reduceSnapshotMemoryCost): Deleted.
(WebKit::ViewSnapshotStore::didCompressSnapshot): Deleted.
Remove all ViewSnapshot(Store) code related to JPEG-encoded snapshots.
Remove the "image" member on ViewSnapshot; Mac will always start out with an IOSurface instead.
Adopt WebCore::IOSurface::createFromImage to make that happen.
Add a comment noting that if a snapshot comes back empty, we should throw it away completely.

  • WebCore.exp.in:
  • platform/graphics/cocoa/IOSurface.h:
  • platform/graphics/cocoa/IOSurface.mm:

(IOSurface::createFromImage):
Move make-an-IOSurface-from-a-CGImageRef into WebCore::IOSurface.

12:11 PM Changeset in webkit [170924] by enrica@apple.com
  • 4 edits in trunk/Source

Implement Editor::fontAttributesForSelectionStart() or iOS.
​https://bugs.webkit.org/show_bug.cgi?id=134771
<rdar://problem/16167838>

Reviewed by Ryosuke Niwa.

Source/WebCore:
Implement for iOS the equivalent function we have for OS X.

  • editing/ios/EditorIOS.mm:

(WebCore::Editor::fontAttributesForSelectionStart):

Source/WebKit/mac:

  • WebView/WebViewPrivate.h:
12:10 PM Changeset in webkit [170923] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

RemoteLayerBackingStore::ensureBackingStore should ensure that the entire backing store gets redrawn
​https://bugs.webkit.org/show_bug.cgi?id=134772

Reviewed by Tim Horton.

  • Shared/mac/RemoteLayerBackingStore.h:

(WebKit::RemoteLayerBackingStore::Buffer::operator bool):

  • Shared/mac/RemoteLayerBackingStore.mm:

(WebKit::RemoteLayerBackingStore::ensureBackingStore):

11:05 AM Changeset in webkit [170922] by Brent Fulgham
  • 22 edits in trunk

[Win] Remove use of 'grep' in build steps
​https://bugs.webkit.org/show_bug.cgi?id=134770
<rdar://problem/17608783>

Reviewed by Tim Horton.

Replace uses of the grep command in Windows builds with the equivalent
Perl program.

Source/JavaScriptCore:

Source/WebCore:

  • WebCore.vcxproj/WebCoreGenerated.make:
  • WebCore.vcxproj/WebCorePreBuild.cmd:
  • platform/graphics/avfoundation/cf/WebCoreAVCFResourceLoader.cpp:

(WebCore::WebCoreAVCFResourceLoader::notifyFinished):

Source/WebKit:

  • WebKit.vcxproj/Interfaces/InterfacesPreBuild.cmd:
  • WebKit.vcxproj/WebKit/WebKitPreBuild.cmd:
  • WebKit.vcxproj/WebKitExportGenerator/WebKitExportGeneratorPreBuild.cmd:
  • WebKit.vcxproj/WebKitGUID/WebKitGUIDPreBuild.cmd:

Source/WTF:

  • WTF.vcxproj/WTFPreBuild.cmd:

Tools:

  • DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreePreBuild.cmd:
  • DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffPreBuild.cmd:
  • DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginPreBuild.cmd:
  • TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIPreBuild.cmd:
  • WinLauncher/WinLauncher.vcxproj/WinLauncherLibPreBuild.cmd:
  • WinLauncher/WinLauncher.vcxproj/WinLauncherPreBuild.cmd:
10:49 AM Changeset in webkit [170921] by achristensen@apple.com
  • 7 edits in trunk/Source/WebCore

Added css jit profiler, disabled by default.
​https://bugs.webkit.org/show_bug.cgi?id=134695

Reviewed by Benjamin Poulain.

  • css/ElementRuleCollector.cpp:

(WebCore::ElementRuleCollector::ruleMatches):
Tell the RuleData when its compiled selector is used.

  • css/RuleSet.cpp:

(WebCore::RuleData::RuleData):
Initialize the compiled selector use count to 0.

  • css/RuleSet.h:

(WebCore::RuleData::~RuleData):
(WebCore::RuleData::compiledSelectorUsed):
Count and log the number of times a compiled selector is used.

  • cssjit/SelectorCompiler.h:

Added option for CSS_SELECTOR_JIT_PROFILING set to 0 by default.

  • dom/SelectorQuery.cpp:

(WebCore::SelectorDataList::executeCompiledSimpleSelectorChecker):
(WebCore::SelectorDataList::execute):
Tell the SelectorData when its compiled selector is used.

  • dom/SelectorQuery.h:

(WebCore::SelectorDataList::SelectorData::SelectorData):
(WebCore::SelectorDataList::SelectorData::~SelectorData):
(WebCore::SelectorDataList::SelectorData::compiledSelectorUsed):
Count and log the number of times a compiled selector is used.

10:17 AM Changeset in webkit [170920] by eric.carlson@apple.com
  • 8 edits in trunk/Source/WebCore

[iOS] caption size is sometimes incorrect in fullscreen
​https://bugs.webkit.org/show_bug.cgi?id=134740

Reviewed by Jer Noble.

Captions on iOS are displayed in fullscreen with a TextTrackRepresentation object. Because
the fullscreen video presentation is controlled by code in the UI process running on the
UI thread, WebCore is notified of changes to fullscreen state asynchronously. This resulted
in the TextTrackRepresentation object being created and/or destroyed too late some of the
time, which caused us to sometimes display captions incorrectly. Fix this by setting up and
tearing down the TextTrackRepresentation object when WebCore's 'webkitfullscreenchange'
event fires.

  • Modules/mediacontrols/MediaControlsHost.cpp:

(WebCore::MediaControlsHost::enteredFullscreen): Notify text track container.
(WebCore::MediaControlsHost::exitedFullscreen): Ditto.

  • Modules/mediacontrols/MediaControlsHost.h:
  • Modules/mediacontrols/MediaControlsHost.idl:
  • Modules/mediacontrols/mediaControlsApple.js:

(Controller.prototype.handleFullscreenChange): Notify host of fullscreen change.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::requiresTextTrackRepresentation): Only return true when in

fullscreen.

(WebCore::HTMLMediaElement::setVideoFullscreenLayer): Call updateTextTrackDisplay.

  • html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlTextTrackContainerElement::MediaControlTextTrackContainerElement): Initialize

m_updateTextTrackRepresentationStyle to false.

(WebCore::MediaControlTextTrackContainerElement::updateDisplay): Move logic for creating

TextTrackRepresentation to updateTextTrackRepresentation.

(WebCore::MediaControlTextTrackContainerElement::updateActiveCuesFontSize): New, split out of updateTimerFired.
(WebCore::MediaControlTextTrackContainerElement::updateTimerFired): Move code to force immediate

font size change to updateActiveCuesFontSize.

(WebCore::MediaControlTextTrackContainerElement::updateTextTrackRepresentation): New, update

text track representation, creating first if necessary.

(WebCore::MediaControlTextTrackContainerElement::clearTextTrackRepresentation): Add an early

return if we don't have a text track representation.

(WebCore::MediaControlTextTrackContainerElement::updateStyleForTextTrackRepresentation): Early

return if there is nothing to be done.

(WebCore::MediaControlTextTrackContainerElement::enteredFullscreen): Force a caption update

if there are visible captions.

(WebCore::MediaControlTextTrackContainerElement::updateSizes): Set m_updateTextTrackRepresentationStyle

to true.

(WebCore::MediaControlTextTrackContainerElement::textTrackRepresentationBoundsChanged): Force a

caption update if there are visible captions.

  • html/shadow/MediaControlElements.h:
10:12 AM Changeset in webkit [170919] by Antti Koivisto
  • 2 edits in trunk/LayoutTests

fast/dom/HTMLImageElement/sizes/image-sizes-js-change.html is failing in some bots
​https://bugs.webkit.org/show_bug.cgi?id=134769

9:31 AM WebKitGTK/KeepingTheTreeGreen edited by clopez@igalia.com
(diff)
9:30 AM WebKitGTK/KeepingTheTreeGreen edited by clopez@igalia.com
(diff)
9:29 AM Changeset in webkit [170918] by jer.noble@apple.com
  • 7 edits in trunk

[MSE] http/tests/media/media-source/mediasource-endofstream-invaliderror.html is failing.
​https://bugs.webkit.org/show_bug.cgi?id=134413

Reviewed by Eric Carlson.

Source/WebCore:
Update MediaSource.endOfStream() to take an optional enum instead of an optional String.

  • Modules/mediasource/MediaSource.cpp:

(WebCore::MediaSource::endOfStream):

  • Modules/mediasource/MediaSource.h:
  • Modules/mediasource/MediaSource.idl:

LayoutTests:
Fix an inadevntant editing error in mediasource-endofstream-invaliderror.html, and fix missing
whitespace at the end of http/tests/media/media-source/mediasource-endofstream-invaliderror-expected.txt.

  • http/tests/media/media-source/mediasource-endofstream-invaliderror-expected.txt:
  • http/tests/media/media-source/mediasource-endofstream-invaliderror.html:
8:58 AM WebKitGTK/2.2.x edited by vjaquez@igalia.com
add another patch proposal (diff)
8:49 AM Changeset in webkit [170917] by Vineet
  • 1 edit in trunk/Tools/Scripts/webkitpy/common/config/contributors.json

Unreviewed, update my list of email addresses.

6:54 AM Changeset in webkit [170916] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

[GTK] Unreviewed GTK gardening.

Patch by Carlos Alberto Lopez Perez <​clopez@igalia.com> on 2014-07-09

  • platform/gtk/TestExpectations: Report and mark new failing and flaky tests. Adjust some tests expectations.
  • platform/gtk/css1/formatting_model/inline_elements-expected.txt: Rebaseline after r170875.
2:12 AM Changeset in webkit [170915] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Unreviewed, rolling out r170889.
​https://bugs.webkit.org/show_bug.cgi?id=134754

This patch is wrong (Requested by philn on #webkit).

Reverted changeset:

"[GTK] Gstreamer missing from the install-dependencies script"
​https://bugs.webkit.org/show_bug.cgi?id=134727
​http://trac.webkit.org/changeset/170889

2:12 AM WebKitGTK/KeepingTheTreeGreen edited by clopez@igalia.com
(diff)
12:29 AM Changeset in webkit [170914] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[EFL] Fix crash caused by invalid cursor image.
​https://bugs.webkit.org/show_bug.cgi?id=134663

Patch by KwangHyuk Kim <​hyuki.kim@samsung.com> on 2014-07-09
Reviewed by Gyuyoung Kim.

Remove calling of updateCursor since the custom cursor image is invalid once a mouse is out of the webview.

  • UIProcess/API/efl/EwkView.cpp:

(EwkViewEventHandler<EVAS_CALLBACK_MOUSE_IN>::handleEvent):

12:01 AM Changeset in webkit [170913] by Lucas Forschler
  • 5 edits in trunk/Source

Versioning.

Jul 8, 2014:

11:52 PM Changeset in webkit [170912] by Lucas Forschler
  • 1 copy in tags/Safari-538.45

New Tag.

11:50 PM Changeset in webkit [170911] by beidson@apple.com
  • 6 edits in trunk/Source/WebCore

DOMWindows should register themselves with the GamepadManager when they have event listeners
​https://bugs.webkit.org/show_bug.cgi?id=134669

Reviewed by Dean Jackson.

No new tests (No effect in a currently tested config)

By having DOMWindows register with the GamepadManager when they have/don’t have gamepad event
listeners, we accomplish two things:
1 - It’s simple for GamepadManager to dispatch gamepad events directly to the DOMWindows interested.
2 - We know when to start monitoring for gamepad connections.

  • Modules/gamepad/GamepadManager.cpp:

(WebCore::GamepadManager::GamepadManager):
(WebCore::GamepadManager::registerNavigator):
(WebCore::GamepadManager::unregisterNavigator):
(WebCore::GamepadManager::registerDOMWindow):
(WebCore::GamepadManager::unregisterDOMWindow):
(WebCore::GamepadManager::maybeStartMonitoringGamepads): Start monitoring gamepads if there are any

registered DOMWindows or NavigatorGamepads, and we aren’t already monitoring them.

(WebCore::GamepadManager::maybeStopMonitoringGamepads): Stop monitoring gamepads if there aren’t any

registered DOMWindows or NavigatorGameads, and we have been monitoring them before now.

  • Modules/gamepad/GamepadManager.h:
  • dom/EventNames.h:

(WebCore::EventNames::isGamepadEventType):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::DOMWindow):
(WebCore::DOMWindow::~DOMWindow): If registered for gamepad events, unregister now.
(WebCore::DOMWindow::incrementGamepadEventListenerCount): If this is the first gamepad event

listener, register with the GamepadManager now.

(WebCore::DOMWindow::decrementGamepadEventListenerCount): If this was the last gamepad event

listener, unregister from the GamepadManager now.

(WebCore::DOMWindow::addEventListener):
(WebCore::DOMWindow::removeEventListener):

  • page/DOMWindow.h:
10:56 PM Changeset in webkit [170910] by commit-queue@webkit.org
  • 5 edits in trunk

.: [EFL] Support Encrypted Media Extensions.
​https://bugs.webkit.org/show_bug.cgi?id=134750

Patch by Sun-woo Nam <​sunny.nam@samsung.com> on 2014-07-08
Reviewed by Gyuyoung Kim.

Webkit needs to play encrypted media contents when media player
is played by Media source extensions and normal video procedure.

  • Source/cmake/OptionsEfl.cmake: Turn on ENABLE_ENCRYPTED_MEDIA_V2

Source/WebCore: [EFL] Fix the build break when ENABLE_ENCRYPTED_MEDIA_V2 is turned on.
​https://bugs.webkit.org/show_bug.cgi?id=134750

Patch by Sun-woo Nam <​sunny.nam@samsung.com> on 2014-07-08
Reviewed by Gyuyoung Kim.

When turning ENABLE_ENCRYPTED_MEDIA_V2 on, build break occurs.
Some source files need to be included in CMakeLists.txt file for build.
And wrap the included header file which is built only on mac and wince.

  • CMakeLists.txt:
  • Modules/encryptedmedia/CDMPrivateMediaPlayer.cpp:
10:13 PM Changeset in webkit [170909] by benjamin@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

Restore the assertion changed with 170839

  • assembler/ARMv7Assembler.h:

(JSC::ARMv7Assembler::pop):
(JSC::ARMv7Assembler::push):
Revert the Assembler part of 170839. The assertions do not match both encoding.

I'll add specific version of push and pop instead.

9:53 PM Changeset in webkit [170908] by eric.carlson@apple.com
  • 2 edits in trunk/Source/WebCore

[iOS] user caption preferences not applied
​https://bugs.webkit.org/show_bug.cgi?id=134599

Reviewed by Sam Weinig.

  • page/CaptionUserPreferences.cpp:

(WebCore::CaptionUserPreferences::updateCaptionStyleSheetOveride): All Pages in a PageGroup
do not necessarily use the same PageUserContentController, so apply and remove caption user
the style sheet directly to each page rather than to the page group.

8:00 PM Changeset in webkit [170907] by fpizlo@apple.com
  • 7 edits
    2 adds in branches/ftlopt/Source/JavaScriptCore

[ftlopt] Phantom simplification should be in its own phase
​https://bugs.webkit.org/show_bug.cgi?id=134742

Reviewed by Geoffrey Garen.

This moves Phantom simplification out of CSE, which greatly simplifies CSE and gives it
more focus. Also this finally adds a phase that removes empty Phantoms. We sort of had
this in CPSRethreading, but that phase runs too infrequently and doesn't run at all for
SSA.

  • CMakeLists.txt:
  • JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • dfg/DFGAdjacencyList.h:
  • dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::run):
(JSC::DFG::CSEPhase::setReplacement):
(JSC::DFG::CSEPhase::eliminate):
(JSC::DFG::CSEPhase::performNodeCSE):
(JSC::DFG::CSEPhase::eliminateIrrelevantPhantomChildren): Deleted.

  • dfg/DFGPhantomRemovalPhase.cpp: Added.

(JSC::DFG::PhantomRemovalPhase::PhantomRemovalPhase):
(JSC::DFG::PhantomRemovalPhase::run):
(JSC::DFG::performCleanUp):

  • dfg/DFGPhantomRemovalPhase.h: Added.
  • dfg/DFGPlan.cpp:

(JSC::DFG::Plan::compileInThreadImpl):

5:51 PM Changeset in webkit [170906] by commit-queue@webkit.org
  • 7 edits in trunk/Source/WebCore

Unreviewed, rolling out r170894.
​https://bugs.webkit.org/show_bug.cgi?id=134749

"It broke the build on mountainlion release 32bit" (Requested
by mmirman on #webkit).

Reverted changeset:

"Added css jit profiler, disabled by default."
​https://bugs.webkit.org/show_bug.cgi?id=134695
​http://trac.webkit.org/changeset/170894

5:01 PM Changeset in webkit [170905] by Brent Fulgham
  • 4 edits
    1 add
    1 delete in trunk

[Win] Implement auto-version as a Perl program
​https://bugs.webkit.org/show_bug.cgi?id=134745
<rdar://problem/17597801>

Reviewed by David Kilzer.

Source/WebKit:
Modify build commands to use new Perl version of the
auto-version script.

  • WebKit.vcxproj/Interfaces/InterfacesPreBuild.cmd:
  • WebKit.vcxproj/WebKit/WebKitPreBuild.cmd:

WebKitLibraries:
Translate the auto-version.sh bash script into an equivalent
Perl script.

  • win/tools/scripts/auto-version.pl: Added.
  • win/tools/scripts/auto-version.sh: Removed.
4:58 PM Changeset in webkit [170904] by Bem Jones-Bey
  • 2 edits in trunk/Websites/webkit.org

Update policy for Inactive Committer and Reviewer status
​https://bugs.webkit.org/show_bug.cgi?id=134403

Reviewed by Nico Weber.

  • coding/commit-review-policy.html:
4:31 PM Changeset in webkit [170903] by jhoneycutt@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

RemoteInspector::shared() should not call WTF::initializeMainThread()
<​https://bugs.webkit.org/show_bug.cgi?id=134747>
<rdar://problem/17161482>

Reviewed by Joseph Pecoraro.

  • inspector/remote/RemoteInspector.mm:

(Inspector::RemoteInspector::shared):
Don't call WTF::initializeMainThread(). WTF threading is initialized by
JSC::initializeThreading().

4:17 PM Changeset in webkit [170902] by timothy_horton@apple.com
  • 10 edits in trunk/Source/WebKit2

Remove WebBackForwardListItems when their owning page goes away
​https://bugs.webkit.org/show_bug.cgi?id=134709
<rdar://problem/17584645>

Reviewed by Dan Bernstein.

  • Shared/WebBackForwardListItem.cpp:

(WebKit::WebBackForwardListItem::create):
(WebKit::WebBackForwardListItem::WebBackForwardListItem):

  • Shared/WebBackForwardListItem.h:

(WebKit::WebBackForwardListItem::pageID):
Add the associated PageID to the WebBackForwardListItem.

  • UIProcess/WebBackForwardList.cpp:

(WebKit::WebBackForwardList::restoreFromState):
Push the current PageID onto the WebBackForwardListItem.

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::removeWebPage):
Remove all of the WebBackForwardListItems from m_backForwardListItemMap when
the page they are associated with is removed.

(WebKit::WebProcessProxy::addBackForwardItem):
Push the PageID from the WebProcess onto the WebBackForwardListItem.

  • UIProcess/WebProcessProxy.h:
  • UIProcess/WebProcessProxy.messages.in:
  • WebProcess/WebPage/WebBackForwardListProxy.cpp:

(WebKit::idToHistoryItemMap):
(WebKit::historyItemToIDMap):
(WebKit::updateBackForwardItem):
(WebKit::WebBackForwardListProxy::addItemFromUIProcess):
(WebKit::WK2NotifyHistoryItemChanged):
(WebKit::WebBackForwardListProxy::idForItem):
(WebKit::WebBackForwardListProxy::addItem):
(WebKit::WebBackForwardListProxy::goToItem):
(WebKit::WebBackForwardListProxy::close):

  • WebProcess/WebPage/WebBackForwardListProxy.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::restoreSession):
Keep track of the PageID that back-forward items were created by.
Pass the PageID along when registering WebBackForwardListItems.

4:11 PM Changeset in webkit [170901] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

WebVideoFullscreenInterfaceAVKit should lazily create m_playerController.
​https://bugs.webkit.org/show_bug.cgi?id=134706

Patch by Jeremy Jones <​jeremyj@apple.com> on 2014-07-08
Reviewed by Simon Fraser.

  • platform/ios/WebVideoFullscreenInterfaceAVKit.mm:

(WebVideoFullscreenInterfaceAVKit::setWebVideoFullscreenModel):
Don't set the delegate if m_playerController isn't created.

3:54 PM Changeset in webkit [170900] by Brian Burg
  • 2 edits in trunk/Tools

resolve-ChangeLogs fails when WebKit repository is a git submodule
​https://bugs.webkit.org/show_bug.cgi?id=134734

Reviewed by David Kilzer.

When using resolve-ChangeLogs in a WebKit git repository with a
non-default arrangement of GIT_DIR and GIT_WORK_TREE, incorrect
paths are computed and the script fails mysteriously.

We were naively computing GIT_WORK_TREE as being one level above
GIT_DIR, but this is not the case for submodules or a manually
configured GIT_WORK_TREE or GIT_DIR location.

  • Scripts/VCSUtils.pm:

(gitTreeDirectory): Added. Find the equivalent of GIT_WORK_TREE.
(determineVCSRoot): Calculate the working tree root directly.

3:42 PM Changeset in webkit [170899] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Debugger popovers should not dismiss when mousing over them
​https://bugs.webkit.org/show_bug.cgi?id=134687

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-07-08
Reviewed by David Kilzer.

  • UserInterface/Views/SourceCodeTextEditor.js:

(WebInspector.SourceCodeTextEditor.prototype._trackPopoverEvents):
Actually install the listeners in the set. Regression from code refactoring in r165052.

3:36 PM Changeset in webkit [170898] by akling@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

VM::lastCachedString should be a Strong, not a Weak.
<​https://webkit.org/b/134746>

Using Weak<JSString> for this regressed some of our bindings perf tests
due to Weak having to allocate a new WeakImpl every time the last cached
string changed. Make it a Strong instead should make that problem go away.

Reviewed by Geoffrey Garen.

  • runtime/JSString.cpp:

(JSC::jsStringWithCacheSlowCase):

  • runtime/VM.h:
3:36 PM Changeset in webkit [170897] by commit-queue@webkit.org
  • 39 edits in trunk/LayoutTests

Remove webkit prefix from pointer lock tests.
​https://bugs.webkit.org/show_bug.cgi?id=134744

Patch by Alex Christensen <​achristensen@webkit.org> on 2014-07-08
Reviewed by Brady Eidson.

  • http/tests/pointer-lock/iframe-sandboxed-allow-pointer-lock-expected.txt:
  • http/tests/pointer-lock/iframe-sandboxed-allow-pointer-lock.html:
  • http/tests/pointer-lock/iframe-sandboxed-expected.txt:
  • http/tests/pointer-lock/iframe-sandboxed-nested-allow-pointer-lock-expected.txt:
  • http/tests/pointer-lock/iframe-sandboxed-nested-allow-pointer-lock.html:
  • http/tests/pointer-lock/iframe-sandboxed-nested-disallow-then-allow-pointer-lock-expected.txt:
  • http/tests/pointer-lock/iframe-sandboxed-nested-disallow-then-allow-pointer-lock.html:
  • http/tests/pointer-lock/iframe-sandboxed.html:
  • http/tests/pointer-lock/pointerlockelement-different-origin-expected.txt:
  • http/tests/pointer-lock/pointerlockelement-different-origin.html:
  • http/tests/pointer-lock/pointerlockelement-same-origin-expected.txt:
  • http/tests/pointer-lock/pointerlockelement-same-origin.html:
  • http/tests/pointer-lock/requestPointerLock-can-not-transfer-between-documents-expected.txt:
  • http/tests/pointer-lock/requestPointerLock-can-not-transfer-between-documents.html:
  • http/tests/resources/pointer-lock/iframe-common.js:

(document.onpointerlockchange):
(document.onpointerlockerror):
(document.onwebkitpointerlockchange): Deleted.
(document.onwebkitpointerlockerror): Deleted.

  • http/tests/resources/pointer-lock/pointer-lock-test-harness.js:

(expectOnlyChangeEvent):
(expectOnlyErrorEvent):
(expectNoEvents):

  • pointer-lock/bug90391-move-then-window-open-crash-expected.txt:
  • pointer-lock/bug90391-move-then-window-open-crash.html:
  • pointer-lock/lock-already-locked-expected.txt:
  • pointer-lock/lock-already-locked.html:
  • pointer-lock/lock-element-not-in-dom-expected.txt:
  • pointer-lock/lock-element-not-in-dom.html:
  • pointer-lock/locked-element-iframe-removed-from-dom-expected.txt:
  • pointer-lock/locked-element-iframe-removed-from-dom.html:
  • pointer-lock/locked-element-removed-from-dom-expected.txt:
  • pointer-lock/locked-element-removed-from-dom.html:
  • pointer-lock/mouse-event-api-expected.txt:
  • pointer-lock/mouse-event-api.html:
  • pointer-lock/mouse-event-delivery-expected.txt:
  • pointer-lock/mouse-event-delivery.html:
  • pointer-lock/pointer-lock-api-expected.txt:
  • pointer-lock/pointer-lock-api.html:
  • pointer-lock/pointerlockchange-event-on-lock-lost-expected.txt:
  • pointer-lock/pointerlockchange-event-on-lock-lost.html:
  • pointer-lock/pointerlockchange-pointerlockerror-events-expected.txt:
  • pointer-lock/pointerlockchange-pointerlockerror-events.html:
  • pointer-lock/pointerlockelement-null-when-pending-expected.txt:
  • pointer-lock/pointerlockelement-null-when-pending.html:

Remove webkit prefix on pointer lock functions and events.
This should have been done in r170585.

3:24 PM Changeset in webkit [170896] by timothy_horton@apple.com
  • 10 edits in trunk

[WK2] Expose a few drawing/compositing settings on WKPreferences(Private)
​https://bugs.webkit.org/show_bug.cgi?id=134645

Reviewed by Dan Bernstein.

  • UIProcess/API/Cocoa/WKPreferences.mm:

(-[WKPreferences _compositingBordersVisible]):
(-[WKPreferences _setCompositingBordersVisible:]):
(-[WKPreferences _compositingRepaintCountersVisible]):
(-[WKPreferences _setCompositingRepaintCountersVisible:]):
(-[WKPreferences _tiledScrollingIndicatorVisible]):
(-[WKPreferences _setTiledScrollingIndicatorVisible:]):

  • UIProcess/API/Cocoa/WKPreferencesPrivate.h:

Expose layer borders, repaint counters, and the tiled scrolling indicator on WKPreferences, as SPI.

  • WebView/WebPreferences.mm:

(-[WebPreferences setSubpixelCSSOMElementMetricsEnabled:]):
Remove an extra unnecessary space.

  • MiniBrowser/mac/BrowserWindowController.h:
  • MiniBrowser/mac/MainMenu.xib:

Add menu items for layer borders and the tiled scrolling indicator.

  • MiniBrowser/mac/WK1BrowserWindowController.m:

(-[WK1BrowserWindowController validateMenuItem:]):
(-[WK1BrowserWindowController layerBordersAreVisible]):
(-[WK1BrowserWindowController toggleLayerBordersVisibility:]):
Add getters/setters/validators for layer borders.

  • MiniBrowser/mac/WK2BrowserWindowController.m:

(-[WK2BrowserWindowController awakeFromNib]):
(-[WK2BrowserWindowController validateMenuItem:]):
(-[WK2BrowserWindowController layerBordersAreVisible]):
(-[WK2BrowserWindowController toggleLayerBordersVisibility:]):
(-[WK2BrowserWindowController tiledScrollingIndicatorIsVisible]):
(-[WK2BrowserWindowController toggleTiledScrollingIndicatorVisibility:]):
Add getters/setters/validators for layer borders and the tiled scrolling indicator.

(-[WK2BrowserWindowController isSubpixelCSSOMElementMetricsEnabled]): Deleted.
(-[WK2BrowserWindowController toggleSubpixelCSSOMElementMetricsEnabled:]): Deleted.
Remove the WebKit2 version of the subpixel metrics pref, because it doesn't work, because
nothing in WebKit2 reads this default, and there is no WebKit2 API for adjusting this preference.

3:10 PM Changeset in webkit [170895] by Bem Jones-Bey
  • 3 edits
    5 adds in trunk

Ensure we compute the height of replaced elements to 'auto' when appropriate.
​https://bugs.webkit.org/show_bug.cgi?id=134700

Reviewed by David Hyatt.

Source/WebCore:
This fixes two issues:

1) If a replaced element has a percentage height specified then its
height should compute to 'auto' when its containing block does not
have a height 'specified explicitly'. We were taking this to mean when
its containing block's specified height value is 'auto' - in fact it
means when the containing block's computed height is auto.

2) Top and bottom on the containing block should only affect the
height of the block if that block has absolute or fixed position.

This brings us into line with IE, Firefox, and Chrome.

This is a port of Blink patches by Rob Hogan and David Vest.

Tests: css2.1/20110323/height-percentage-005.htm

fast/css/replaced-element-ignore-top-bottom.html

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::hasAutoHeightOrContainingBlockWithAutoHeight):

LayoutTests:

  • css2.1/20110323/height-percentage-005-expected.html: Added.
  • css2.1/20110323/height-percentage-005.htm: Added.
  • css2.1/20110323/support/black96x96.png: Added.
  • fast/css/replaced-element-ignore-top-bottom-expected.txt: Added.
  • fast/css/replaced-element-ignore-top-bottom.html: Added.
2:47 PM Changeset in webkit [170894] by commit-queue@webkit.org
  • 7 edits in trunk/Source/WebCore

Added css jit profiler, disabled by default.
​https://bugs.webkit.org/show_bug.cgi?id=134695

Patch by Alex Christensen <​achristensen@webkit.org> on 2014-07-08
Reviewed by Benjamin Poulain.

  • css/ElementRuleCollector.cpp:

(WebCore::ElementRuleCollector::ruleMatches):
Tell the RuleData when its compiled selector is used.

  • css/RuleSet.cpp:

(WebCore::RuleData::RuleData):
Initialize the compiled selector use count to 0.

  • css/RuleSet.h:

(WebCore::RuleData::~RuleData):
(WebCore::RuleData::compiledSelectorUsed):
Count and log the number of times a compiled selector is used.

  • cssjit/SelectorCompiler.h:

Added option for CSS_SELECTOR_JIT_PROFILING set to 0 by default.

  • dom/SelectorQuery.cpp:

(WebCore::SelectorDataList::executeCompiledSimpleSelectorChecker):
(WebCore::SelectorDataList::execute):
Tell the SelectorData when its compiled selector is used.

  • dom/SelectorQuery.h:

(WebCore::SelectorDataList::SelectorData::SelectorData):
(WebCore::SelectorDataList::SelectorData::~SelectorData):
(WebCore::SelectorDataList::SelectorData::compiledSelectorUsed):
Count and log the number of times a compiled selector is used.

12:27 PM Changeset in webkit [170893] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit2

WKProcessPoolConfigurationPrivate's maximumProcessCount property has no effect
​https://bugs.webkit.org/show_bug.cgi?id=134711

Reviewed by Dan Bernstein.

  • UIProcess/API/Cocoa/WKProcessPool.mm:

(-[WKProcessPool _initWithConfiguration:]):
Respect the maximumProcessCount.
Currently the default limit is UINT_MAX; if maximumProcessCount = 0 (the default), we'll use that limit.

11:45 AM Changeset in webkit [170892] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Steps towards CMake on Windows.
​https://bugs.webkit.org/show_bug.cgi?id=134716

Patch by Alex Christensen <​achristensen@webkit.org> on 2014-07-08
Reviewed by Martin Robinson.

  • CMakeLists.txt:

Added AppleWin and WinCairo to list of CMake ports.

  • Source/cmake/OptionsAppleWin.cmake: Added.
  • Source/cmake/OptionsWinCairo.cmake: Added.
  • Source/cmake/OptionsWindows.cmake:

Windows needs to use the system malloc. Other options to come.

10:53 AM Changeset in webkit [170891] by commit-queue@webkit.org
  • 25 edits
    7 adds in trunk

[GTK] Move user style sheet API out of WebKitWebViewGroup
​https://bugs.webkit.org/show_bug.cgi?id=134551

Patch by Adrian Perez de Castro <Adrian Perez de Castro> on 2014-07-08
Reviewed by Carlos Garcia Campos.

Source/WebKit2:

  • PlatformGTK.cmake: Include the new source files in the build.
  • UIProcess/API/C/gtk/WKView.cpp:

(WKViewCreate):
Adapt to the additional webkitWebViewBaseCreateWebPage() parameter.

  • UIProcess/API/gtk/WebKitUserContent.cpp: Added.

(toUserContentInjectedFrames):
(toUserStyleLevel):
(toStringVector):
(_WebKitUserStyleSheet::_WebKitUserStyleSheet):
(webkit_user_style_sheet_ref):
(webkit_user_style_sheet_unref):
(webkit_user_style_sheet_new):
(webkitWebKitUserStyleSheetToUserStyleSheet):

  • UIProcess/API/gtk/WebKitUserContent.h: Added.
  • UIProcess/API/gtk/WebKitUserContentManager.cpp: Added.

(_WebKitUserContentManagerPrivate::_WebKitUserContentManagerPrivate):
(webkit_user_content_manager_class_init):
(webkit_user_content_manager_new):
(webkit_user_content_manager_add_style_sheet):
(webkit_user_content_manager_remove_all_style_sheets):
(webkitUserContentManagerGetUserContentControllerProxy):

  • UIProcess/API/gtk/WebKitUserContentManager.h: Added.
  • UIProcess/API/gtk/WebKitUserContentManagerPrivate.h: Added.
  • UIProcess/API/gtk/WebKitUserContentPrivate.h: Added.
  • UIProcess/API/gtk/WebKitWebContext.cpp:

(webkitWebContextCreatePageForWebView): Add a new parameter to allow
passing the WebKitUserContentManager that the web view will use.

  • UIProcess/API/gtk/WebKitWebContextPrivate.h: Ditto.
  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkitWebViewConstructed): Added handling of the
"user-content-manager" property on construction.
(webkitWebViewSetProperty): Added support for the
"user-content-manager" property.
(webkitWebViewGetProperty): Added support for the
"user-content-manager" property.
(webkit_web_view_class_init): Added the "user-content-manager"
property definition to the WebKitWebView class.
(webkit_web_view_new_with_related_view): Made related views share
the same WebKitUserContentManager used by the view they are
related to.
(webkit_web_view_new_with_user_content_manager): Added.
(webkit_web_view_get_user_content_manager): Added.

  • UIProcess/API/gtk/WebKitWebView.h: Add new API methods.
  • UIProcess/API/gtk/WebKitWebViewBase.cpp:

(webkitWebViewBaseCreate): Added a parameter to pass the user
content manager.
(webkitWebViewBaseCreateWebPage): Added a parameter to pass the user
content manager.

  • UIProcess/API/gtk/WebKitWebViewBasePrivate.h: Ditto.
  • UIProcess/API/gtk/WebKitWebViewGroup.cpp: Removed the bits related

to user style sheet support from WebKitWebViewGroup.
(webkit_web_view_group_set_settings):
(toAPIArray): Deleted.
(webkit_web_view_group_add_user_style_sheet): Deleted.
(webkit_web_view_group_remove_all_user_style_sheets): Deleted.

  • UIProcess/API/gtk/WebKitWebViewGroup.h: Deleted the API methods

for user style sheet handling.

  • UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Added the new API

functions and types, and removed the methods which are no longer
available in WebKitWebViewGroup.

  • UIProcess/API/gtk/webkit2.h: Add the new headers.
  • UIProcess/UserContent/WebUserContentControllerProxy.cpp: Added

methods to add and remove user style sheets, alike those used for
user scripts.
(WebKit::WebUserContentControllerProxy::addProcess):
(WebKit::WebUserContentControllerProxy::addUserStyleSheet):
(WebKit::WebUserContentControllerProxy::removeAllUserStyleSheets):

  • UIProcess/UserContent/WebUserContentControllerProxy.h: Ditto.
  • UIProcess/gtk/WebInspectorProxyGtk.cpp:

(WebKit::WebInspectorProxy::platformCreateInspectorPage):
Adapt to the additional webkitWebViewBaseCreateWebPage() parameter.

  • WebProcess/UserContent/WebUserContentController.cpp: Added methods

to add and remove user style sheets, alike those used for user scripts.
(WebKit::WebUserContentController::addUserStyleSheets):
(WebKit::WebUserContentController::removeAllUserStyleSheets):

  • WebProcess/UserContent/WebUserContentController.h: Ditto.
  • WebProcess/UserContent/WebUserContentController.messages.in:

Ditto.

Tools:
Removes testing user style sheet injection from
TestWebKitWebViewGroup and moves that into a new
TestWebKitUserContentManager, adapting the existing tests to the new
API. Also, it contains a new test case for
webkit_web_view_new_with_user_content_manager().

  • TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
  • TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp: Added.

(UserContentManagerTest::UserContentManagerTest):
(testWebViewNewWithUserContentManager):
(isStyleSheetInjectedForURLAtPath):
(fillURLListFromPaths):
(removeOldInjectedStyleSheetsAndResetLists):
(testUserContentManagerInjectedStyleSheet):
(serverCallback):
(beforeAll):
(afterAll):

  • TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebViewGroup.cpp:

(beforeAll):
(afterAll):
(isStyleSheetInjectedForURLAtPath): Deleted.
(fillURLListFromPaths): Deleted.
(removeOldInjectedStyleSheetsAndResetLists): Deleted.
(testWebViewGroupInjectedStyleSheet): Deleted.
(serverCallback): Deleted.

  • TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:

(WebViewTest::WebViewTest):

  • TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
10:50 AM Layout Test Protocol edited by dfarler@apple.com
(diff)
10:50 AM Changeset in webkit [170890] by fpizlo@apple.com
  • 9 edits in branches/ftlopt/Source/JavaScriptCore

[ftlopt] Get rid of Node::misc by moving the fields out of the union so that you can use replacement and owner simultaneously
​https://bugs.webkit.org/show_bug.cgi?id=134730

Reviewed by Mark Lam.

This will allow for a better GCSE implementation.

  • dfg/DFGCPSRethreadingPhase.cpp:

(JSC::DFG::CPSRethreadingPhase::canonicalizeGetLocalFor):

  • dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::setReplacement):

  • dfg/DFGEdgeDominates.h:

(JSC::DFG::EdgeDominates::operator()):

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::clearReplacements):
(JSC::DFG::Graph::initializeNodeOwners):

  • dfg/DFGGraph.h:

(JSC::DFG::Graph::performSubstitutionForEdge):

  • dfg/DFGLICMPhase.cpp:

(JSC::DFG::LICMPhase::attemptHoist):

  • dfg/DFGNode.h:

(JSC::DFG::Node::Node):

  • dfg/DFGSSAConversionPhase.cpp:

(JSC::DFG::SSAConversionPhase::run):

10:49 AM Layout Test Protocol edited by dfarler@apple.com
(diff)
10:43 AM Layout Test Protocol edited by dfarler@apple.com
(diff)
10:33 AM Changeset in webkit [170889] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[GTK] Gstreamer missing from the install-dependencies script
​https://bugs.webkit.org/show_bug.cgi?id=134727

Patch by Ziran Sun <​ziran.sun@samsung.com> on 2014-07-08
Reviewed by Mario Sanchez Prada.

Added missing gstreamer dependencies for debian based systems.

  • gtk/install-dependencies: Added 2 dependencies for apt-get.
10:26 AM Layout Test Protocol edited by dfarler@apple.com
(diff)
10:25 AM Layout Test Protocol edited by dfarler@apple.com
(diff)
10:03 AM Layout Test Protocol edited by dfarler@apple.com
(diff)
10:01 AM Layout Test Protocol created by dfarler@apple.com
9:41 AM Changeset in webkit [170888] by mmaxfield@apple.com
  • 2 edits in trunk/Tools

Add myself to the watchlist for text-related files
​https://bugs.webkit.org/show_bug.cgi?id=134707

Reviewed by Timothy Horton.

  • Scripts/webkitpy/common/config/watchlist:
9:34 AM Changeset in webkit [170887] by zandobersek@gmail.com
  • 2 edits in trunk/Source/WebKit2

[GTK] Guard uses of RedirectedXCompositeWindow in WebKitWebViewBase with PLATFORM(X11)
​https://bugs.webkit.org/show_bug.cgi?id=133871

Reviewed by Martin Robinson.

Guard uses of the RedirectedXCompositeWindow object in WebKitWebViewBase with the
PLATFORM(X11) build guard. This is required to properly support building the GTK
port only for the Wayland target.

  • UIProcess/API/gtk/WebKitWebViewBase.cpp:

(webkitWebViewBaseConstructed):
(webkitWebViewRenderAcceleratedCompositingResults):
(resizeWebKitWebViewBaseFromAllocation):
(webkitWebViewBaseUpdatePreferences):
(webkitWebViewBaseCreateWebPage):

8:26 AM Changeset in webkit [170886] by Carlos Garcia Campos
  • 1 copy in releases/WebKitGTK/webkit-2.4.4

Tagging the WebKitGTK+ 2.4.4 release

8:20 AM Changeset in webkit [170885] by Carlos Garcia Campos
  • 1 edit
    1 add in trunk/Source/WebCore

Unreviewed. Fix GObject DOM bindings API breaks test after r170700.

Add missing WebKitDOMXPathNSResolver.symbols that I forgot to add
in r170700.

  • bindings/gobject/WebKitDOMXPathNSResolver.symbols: Added.
5:08 AM Changeset in webkit [170884] by Carlos Garcia Campos
  • 4 edits in releases/WebKitGTK/webkit-2.4

Unreviewed. Update NEWS and Versions.m4 for 2.4.4 release.

.:

  • Source/autotools/Versions.m4: Bump version numbers.

Source/WebKit/gtk:

  • NEWS: Added release notes for 2.4.4.
5:06 AM Changeset in webkit [170883] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.4/Source/WebCore

Unreviewed. Fix make distcheck.

  • GNUmakefile.am:
2:40 AM Changeset in webkit [170882] by Carlos Garcia Campos
  • 9 edits in releases/WebKitGTK/webkit-2.4

[GTK][Stable] Google Maps doesn't work with Version/X in the user agent
​https://bugs.webkit.org/show_bug.cgi?id=134631

Reviewed by Sergio Villar Senin.

Source/WebCore:

Because of the JSC version used in stable branch, when the
Version/X string is present in the user agent, google maps uses
JavaScript API that we don't support. Move the google domain quirks
from WebKit1 to WebCore and add a quirk for google maps.

  • platform/gtk/UserAgentGtk.cpp:

(WebCore::googleDomains):
(WebCore::otherGoogleDomains):
(WebCore::isGoogleDomain): Returns whether the given host is a
known google domain
(WebCore::buildUserAgentString): Do not include the Version/X
string in the user agent if the ShouldNotIncludeSafariVersion
quirk is present.
(WebCore::standardUserAgentForURL): Add RequiresStandardUserAgent
quirk for any google doamin and ShouldNotIncludeSafariVersion for
Google Maps.

Source/WebKit/gtk:

Remove user agent quirks for google domains, since they are now
implemented in WebCore.

  • WebCoreSupport/FrameLoaderClientGtk.cpp:

(WebKit::FrameLoaderClient::userAgent): Pass the WebCore::URL
const reference to webkitWebSettingsUserAgentForURI().

  • webkit/webkitwebsettings.cpp:

(webkitWebSettingsUserAgentForURI): Use
WebCore::standardUserAgentForURL() when site specific quirks are enabled.

  • webkit/webkitwebsettingsprivate.h:

Tools:

Move user agent quirks tests from WebKit1 to WebCore.

  • TestWebKitAPI/Tests/WebCore/gtk/UserAgentQuirks.cpp:

(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebKitGtk/testwebsettings.c:

(test_webkit_web_settings_user_agent):

2:24 AM Changeset in webkit [170881] by commit-queue@webkit.org
  • 4 edits in trunk

Add option to specify output file location in sunspider.
​https://bugs.webkit.org/show_bug.cgi?id=134339

Patch by Gergo Balogh <​gbalogh.u-szeged@partner.samsung.com> on 2014-07-08
Reviewed by Darin Adler.

PerformanceTests/SunSpider:

  • sunspider:

Tools:

  • Scripts/run-sunspider:
Note: See TracTimeline for information about the timeline view.