Context Navigation

← Previous Period
Next Period →

Timeline

Jul 14, 2014:

8:04 PM Changeset in webkit [171101] by akling@apple.com

2 edits in trunk/Source/WebKit2

[iOS] Don't progressively re-render tiles while pinch-zooming under memory pressure.
<https://webkit.org/b/134915>

When we're under memory pressure, the last thing we want to be doing is
creating gratuitous new IOSurfaces. Just wait for the gesture to end before
rendering at the new scale.

Reviewed by Tim Horton.

WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::updateVisibleContentRects):

7:55 PM Changeset in webkit [171100] by Alan Bujtas

3 edits
2 adds in trunk

Subpixel rendering: Zero sized compositing container's content positioned off by one device pixel.
https://bugs.webkit.org/show_bug.cgi?id=134903

Reviewed by Simon Fraser.

The compositing layer boundaries are calculated using its renderer()'s and the renderer()'s
descendants' bounds. However when the renderer() is zero sized, its bounds are omitted.
In such cases, when the child content has offset from the renderer(), the subpixel adjustment
of the compositing layer becomes negative (-meaning that the compositing layer is to the right/bottom
direction from its renderer()). Remove fabs() to be able to express such direction.

Source/WebCore:
Test: compositing/hidpi-compositing-layer-with-zero-sized-container.html

rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateGeometry):

LayoutTests:

compositing/hidpi-compositing-layer-with-zero-sized-container-expected.html: Added.
compositing/hidpi-compositing-layer-with-zero-sized-container.html: Added.

7:15 PM Changeset in webkit [171099] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Fix crash on WebVideoFullscreenManagerProxy construction.
https://bugs.webkit.org/show_bug.cgi?id=134909

Unreviewed fix crash from r171089

Remove unnecessary dispatch to main queue since it can happen during construction.

Patch by Jeremy Jones <jeremyj@apple.com> on 2014-07-14

platform/ios/WebVideoFullscreenInterfaceAVKit.mm:

(WebVideoFullscreenInterfaceAVKit::setWebVideoFullscreenModel): remove dispatch_async

6:52 PM Changeset in webkit [171098] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit2

[Cocoa] _WKRemoteObjectInterface leaks NSString ivar
https://bugs.webkit.org/show_bug.cgi?id=134914

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-07-14
Reviewed by Simon Fraser.

Release our copied NSString in dealloc.

Shared/API/Cocoa/_WKRemoteObjectInterface.mm:

(-[_WKRemoteObjectInterface dealloc]):

6:37 PM Changeset in webkit [171097] by dino@apple.com

1 edit
4 adds in trunk/LayoutTests

Provide some large JPEG images with EXIF orientation for subsampling tests
https://bugs.webkit.org/show_bug.cgi?id=134847

Reviewed by Sam Weinig.

Four images (either 3000x2000 or 2000x3000) that each have EXIF rotation
attributes that should render with an arrow pointing UP. The
orientation-rotate-0.jpg should always render correctly, even if EXIF
rotation is ignored. The others are variations on that image that were
saved in rotated form, then reverted to the correct orientation via EXIF.

fast/canvas/resources/orientation-rotate-0.jpg: Added.
fast/canvas/resources/orientation-rotate-180.jpg: Added.
fast/canvas/resources/orientation-rotate-90-ccw.jpg: Added.
fast/canvas/resources/orientation-rotate-90-cw.jpg: Added.

5:41 PM Changeset in webkit [171096] by fpizlo@apple.com

29 edits
19 adds in trunk/Source/JavaScriptCore

Allow for Int52Rep to see things other than Int32, and make this testable
https://bugs.webkit.org/show_bug.cgi?id=134873
<rdar://problem/17641915>

Reviewed by Geoffrey Garen and Mark Hahnenberg.

A major premise of our type inference is that prediction propagation can say whatever it
wants and we'll still have valid IR after Fixup. This previously didn't work with Int52s.
We required some kind of agreement between prediction propagation and fixup over which
data flow paths were Int52 and which weren't.

It turns out that we basically had such an agreement, with the exception of code that was
unreachable due to ForceOSRExit. Then, fixup and prediction propagation would disagree. It
might be nice to fix that bug - but it's only in the case of Int52 that such a thing would
be a bug! Normally, we allow sloppiness in prediction propagation.

This patch allows us to be sloppy with Int52 prediction propagation by giving Int52Rep the
ability to see inputs other than Int32. This fixes the particular ForceOSRExit bug (see
int52-force-osr-exit-path.js for the reduced test case). To make sure that the newly
empowered Int52Rep is actually correct - in case we end up using it on paths other than
ForceOSRExit - this patch introduces an internal intrinsic called fiatInt52() that forces
us to attempt Int52 conversion on the input. This patch adds a bunch of tests that stress
this intrinsic. This means that we're now stressing Int52Rep more so than ever before!

Note that it would still be a bug for prediction propagation to ever cause us to create an
Int52Rep node for a non-Int32 input. But, this will now be a performance bug, rather than
a crash bug.

dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

dfg/DFGAbstractValue.cpp:

(JSC::DFG::AbstractValue::fixTypeForRepresentation):

dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleIntrinsic):

dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):
(JSC::DFG::FixupPhase::injectTypeConversionsForEdge):

dfg/DFGGraph.h:

(JSC::DFG::Graph::isMachineIntConstant):

dfg/DFGNode.h:

(JSC::DFG::Node::isMachineIntConstant):

dfg/DFGNodeType.h:
dfg/DFGOperations.cpp:
dfg/DFGOperations.h:
dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):

dfg/DFGSafeToExecute.h:

(JSC::DFG::SafeToExecuteEdge::operator()):
(JSC::DFG::safeToExecute):

dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::speculate):

dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::callOperation):

dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):
(JSC::DFG::SpeculativeJIT::convertMachineInt):
(JSC::DFG::SpeculativeJIT::speculateMachineInt):
(JSC::DFG::SpeculativeJIT::speculateDoubleRepMachineInt):

dfg/DFGStrengthReductionPhase.cpp:

(JSC::DFG::StrengthReductionPhase::handleNode):

dfg/DFGUseKind.cpp:

(WTF::printInternal):

dfg/DFGUseKind.h:

(JSC::DFG::typeFilterFor):
(JSC::DFG::isNumerical):
(JSC::DFG::isDouble):

dfg/DFGValidate.cpp:

(JSC::DFG::Validate::validate):

ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

ftl/FTLIntrinsicRepository.h:
ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileInt52Rep):
(JSC::FTL::LowerDFGToLLVM::doubleToInt32):
(JSC::FTL::LowerDFGToLLVM::jsValueToDouble):
(JSC::FTL::LowerDFGToLLVM::jsValueToStrictInt52):
(JSC::FTL::LowerDFGToLLVM::doubleToStrictInt52):
(JSC::FTL::LowerDFGToLLVM::speculate):
(JSC::FTL::LowerDFGToLLVM::speculateMachineInt):
(JSC::FTL::LowerDFGToLLVM::speculateDoubleRepMachineInt):

jit/JITOperations.h:
jsc.cpp:

(GlobalObject::finishCreation):
(functionIdentity):

runtime/Intrinsic.h:
runtime/JSCJSValue.h:
runtime/JSCJSValueInlines.h:

(JSC::tryConvertToInt52):
(JSC::isInt52):
(JSC::JSValue::isMachineInt):

tests/stress/dead-fiat-double-to-int52-then-exit-not-int52.js: Added.

(foo):

tests/stress/dead-fiat-double-to-int52.js: Added.

(foo):

tests/stress/dead-fiat-int32-to-int52.js: Added.

(foo):

tests/stress/dead-fiat-value-to-int52-double-path.js: Added.

(foo):
(bar):

tests/stress/dead-fiat-value-to-int52-then-exit-not-double.js: Added.

(foo):
(bar):

tests/stress/dead-fiat-value-to-int52-then-exit-not-int52.js: Added.

(foo):
(bar):

tests/stress/dead-fiat-value-to-int52.js: Added.

(foo):
(bar):

tests/stress/fiat-double-to-int52-then-exit-not-int52.js: Added.

(foo):

tests/stress/fiat-double-to-int52-then-fail-to-fold.js: Added.

(foo):

tests/stress/fiat-double-to-int52-then-fold.js: Added.

(foo):

tests/stress/fiat-double-to-int52.js: Added.

(foo):

tests/stress/fiat-int32-to-int52.js: Added.

(foo):

tests/stress/fiat-value-to-int52-double-path.js: Added.

(foo):
(bar):

tests/stress/fiat-value-to-int52-then-exit-not-double.js: Added.

(foo):
(bar):

tests/stress/fiat-value-to-int52-then-exit-not-int52.js: Added.

(foo):
(bar):

tests/stress/fiat-value-to-int52-then-fail-to-fold.js: Added.

(foo):

tests/stress/fiat-value-to-int52-then-fold.js: Added.

(foo):

tests/stress/fiat-value-to-int52.js: Added.

(foo):
(bar):

tests/stress/int52-force-osr-exit-path.js: Added.

(foo):

5:14 PM Changeset in webkit [171095] by dino@apple.com

2 edits in trunk/Source/WebKit2

[PlugIns] Check for a non-null snapshot image before trying to decode it
https://bugs.webkit.org/show_bug.cgi?id=134913
<rdar://problem/17606033>

Reviewed by Tim Horton.

Changeset r169820 introduced a bug where we could examine the pixels of
an image (looking for solid colors) before checking if the image actually
existed.

I added a null check, and moved the code around a bit to avoid checking
for existence three times.

WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::pluginSnapshotTimerFired): Check that snapshotImage exists
before trying to look at it.

5:14 PM Changeset in webkit [171094] by dbates@webkit.org

2 edits
6 adds in trunk

[iOS] Add tests to ensure CSS :active and :hover are applied when processing touch events
https://bugs.webkit.org/show_bug.cgi?id=134905
<rdar://problem/16602779>

Reviewed by Simon Fraser.

.:
Add a manual test to ensure that styles for CSS pseudo-class :hover aren't temporarily cleared
on the tapped element when processing a touchend as a result of finger pressing and releasing
on the same element that is initially positioned outside the visible content area.

ManualTests/ios/touchstart-touchend-on-same-element-should-not-clear-hover.html: Added.

LayoutTests:
Upstream tests by Andreas Kling for <rdar://problem/14324231>.

Add a DRT test to ensure that we apply the style for the CSS pseudo-class :active when
processing touch events.

platform/iphone-simulator/fast/events/ontouchstart-active-selector-expected.txt: Added.
platform/iphone-simulator/fast/events/ontouchstart-active-selector.html: Added.

5:09 PM Changeset in webkit [171093] by andersca@apple.com

2 edits in trunk/Source/WebKit2

Fix 32-bit build.

UIProcess/Cocoa/SessionStateCoding.mm:

(WebKit::encodeSessionState):

4:59 PM Changeset in webkit [171092] by mhahnenberg@apple.com

4 edits
1 add in trunk/Source/JavaScriptCore

Flattening dictionaries with oversize backing stores can cause crashes
https://bugs.webkit.org/show_bug.cgi?id=134906

Reviewed by Filip Pizlo.

The collector expects any pointers into CopiedSpace passed to copyLater are within 32 KB
of the CopiedBlock header. This was always the case except for when flattening a dictionary
caused the size of the Butterfly to decrease. This was equivalent to moving the base of the
Butterfly to higher addresses. If the object was reduced sufficiently in size, the base
would no longer be within the first 32 KB of the CopiedBlock and the next collection would
choke on the Butterfly pointer.

This patch fixes this issue by detect this situation during flattening and memmove-ing
the Butterfly down to where the old base was.

runtime/JSObject.cpp:

(JSC::JSObject::shiftButterflyAfterFlattening):

runtime/JSObject.h:

(JSC::JSObject::butterflyPreCapacity):
(JSC::JSObject::butterflyTotalSize):

runtime/Structure.cpp:

(JSC::Structure::flattenDictionaryStructure):

tests/stress/flatten-oversize-dictionary-object.js: Added.

(foo):

4:35 PM Changeset in webkit [171091] by andersca@apple.com

2 edits in trunk/Source/WebKit2

Use the legacy session coder for encoding/decoding session state
https://bugs.webkit.org/show_bug.cgi?id=134910

Reviewed by Beth Dakin.

UIProcess/Cocoa/SessionStateCoding.mm:

(WebKit::encodeSessionState):
(WebKit::decodeSessionState):

4:13 PM Changeset in webkit [171090] by oliver@apple.com

2 edits in trunk/Source/WebKit2

Restrict network process to remote connections
https://bugs.webkit.org/show_bug.cgi?id=134908

Reviewed by Geoffrey Garen.

Further restrict network client

Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb:

3:32 PM Changeset in webkit [171089] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

WebVideoFullscreenInterfaceAVKit should only call the UI from main thread.
https://bugs.webkit.org/show_bug.cgi?id=134890

Patch by Jeremy Jones <jeremyj@apple.com> on 2014-07-14
Reviewed by Eric Carlson.

dispatch_async to the main thread before setting properties that would affect the UI.

platform/ios/WebVideoFullscreenInterfaceAVKit.mm:

(WebVideoFullscreenInterfaceAVKit::setWebVideoFullscreenModel): wrap in call to dispatch_async
(WebVideoFullscreenInterfaceAVKit::setDuration): ditto
(WebVideoFullscreenInterfaceAVKit::setCurrentTime): ditto
(WebVideoFullscreenInterfaceAVKit::setRate): ditto
(WebVideoFullscreenInterfaceAVKit::setVideoDimensions): ditto
(WebVideoFullscreenInterfaceAVKit::setSeekableRanges): ditto
(WebVideoFullscreenInterfaceAVKit::setAudioMediaSelectionOptions): ditto
(WebVideoFullscreenInterfaceAVKit::setLegibleMediaSelectionOptions): ditto
(WebVideoFullscreenInterfaceAVKit::setExternalPlayback): ditto

3:22 PM Changeset in webkit [171088] by dbates@webkit.org

3 edits in trunk/Tools

check-webkit-style should apply C++ rules to Objective-C++ files
https://bugs.webkit.org/show_bug.cgi?id=134884

Reviewed by Joseph Pecoraro.

Fixes an issue where check-webkit-style doesn't apply applicable C++ rules to
Objective-C++ files.

Currently check-webkit-style doesn't apply the following rules to Objective-C++
files: build/using_std, runtime/max_min_macros, runtime/wtf_move, readability/null.
Instead, we should teach check-webkit-style to apply these rules because, as
its name implies, an Objective-C++ file may contain C++ code.

Scripts/webkitpy/style/checkers/cpp.py:

(_FileState.init): Add instance variable _is_objective_cpp to track whether a file has
extension mm (i.e. an Objective-C++ file).
(_FileState.is_objective_c_or_objective_cpp): Added; returns true if the file
has extension m or mm or if the file has extension h and contains Objective-C directives.
(check_for_null): No change in behavior; don't apply rule to Objective-C++ file.
(check_identifier_name_in_declaration): Substitute _FileState.is_objective_c_or_objective_cpp() for
_FileState.is_c_or_objective_c()

Scripts/webkitpy/style/checkers/cpp_unittest.py:

(WebKitStyleTest.test_null_false_zero): Added test case for Objective-C++ file.
(WebKitStyleTest.test_max_macro): Add test case for Objective-C and Objective-C++ file.
(WebKitStyleTest.test_min_macro): Ditto.
(WebKitStyleTest.test_wtf_move): Add test case for Objective-C++ file.

3:00 PM Changeset in webkit [171087] by timothy_horton@apple.com

2 edits in trunk/Source/WebKit2

ASSERT(isMainThread()) under OneShotDisplayLinkHandler
https://bugs.webkit.org/show_bug.cgi?id=134900

Reviewed by Simon Fraser.

UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.mm:

(-[OneShotDisplayLinkHandler displayLinkFired:]):
isMainThread means the Web thread sometimes.

2:57 PM Changeset in webkit [171086] by timothy_horton@apple.com

3 edits in trunk/Source/WebKit2

Fix the build.

UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _frameOrBoundsChanged]):
(-[WKWebView _beginAnimatedResizeWithUpdates:]):

UIProcess/API/ios/WKViewIOS.mm:

(-[WKView _frameOrBoundsChanged]):

2:42 PM Changeset in webkit [171085] by Lucas Forschler

10 edits in tags/Safari-538.46.2/Source/WebKit2

Merged r171057. <rdar://problem/17295636>

2:37 PM Changeset in webkit [171084] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit2

[UNIX] Log error description when failing to create shared memory file.
https://bugs.webkit.org/show_bug.cgi?id=134892

Patch by Carlos Alberto Lopez Perez <clopez@igalia.com> on 2014-07-14
Reviewed by Darin Adler.

Platform/unix/SharedMemoryUnix.cpp:

(WebKit::SharedMemory::create): Print the string describing the error number (errno).

2:29 PM Changeset in webkit [171083] by commit-queue@webkit.org

3 edits in trunk/Source/WebCore

Fix the !ENABLE(FILTERS) && !ENABLE(CSS_FILTERS) build after r167497
https://bugs.webkit.org/show_bug.cgi?id=134679

Patch by Tibor Meszaros <tmeszaros.u-szeged@partner.samsung.com> on 2014-07-14
Reviewed by Darin Adler.

html/ImageData.cpp:
platform/graphics/cairo/ImageBufferCairo.cpp:

2:23 PM Changeset in webkit [171082] by Manuel Rego Casasnovas

14 edits
2 adds in trunk

[CSS Grid Layout] Support sparse in auto-placement algorithm
https://bugs.webkit.org/show_bug.cgi?id=134544

Reviewed by Sergio Villar Senin.

Source/WebCore:
This patch implements sparse mode for auto-placement algorithm, which is
the default mode in the new grid-auto-flow syntax. It keeps track of the
auto-placement cursor in
RenderGrid::placeAutoMajorAxisItemsOnGrid() and updates it accordingly
when auto-positioned items are placed.
If we're in dense mode it resets the cursor after each item (which keeps
the old behavior that was using dense mode by default).

GridIterator has been adapted to look for empty areas from a given
position in both directions.

Test: fast/css-grid-layout/grid-auto-flow-sparse.html

rendering/RenderGrid.cpp:

(WebCore::RenderGrid::GridIterator::GridIterator): Modify constructor to
add an optional argument for the varying index. This allows to look for
empty areas in both axis.
(WebCore::RenderGrid::placeAutoMajorAxisItemsOnGrid): Defined the
auto-placement cursor and rested after each item if we're in dense mode.
(WebCore::RenderGrid::placeAutoMajorAxisItemOnGrid): Use auto-placement
cursor to look for empty areas from the last auto-positioned item
placed.

rendering/RenderGrid.h: Modify placeAutoMajorAxisItemOnGrid() header

to receive the auto-placement cursor.

LayoutTests:
Test cases have been adapted accordingly, adding new cases to cover both
sparse and dense options.

fast/css-grid-layout/grid-auto-flow-resolution-expected.txt:
fast/css-grid-layout/grid-auto-flow-resolution.html:
fast/css-grid-layout/grid-auto-flow-sparse-expected.txt: Added.
fast/css-grid-layout/grid-auto-flow-sparse.html: Added.
fast/css-grid-layout/grid-container-change-named-grid-lines-recompute-child.html:
fast/css-grid-layout/grid-item-auto-placement-automatic-span-expected.txt:
fast/css-grid-layout/grid-item-auto-placement-automatic-span.html:
fast/css-grid-layout/grid-item-auto-placement-definite-span-expected.txt:
fast/css-grid-layout/grid-item-auto-placement-definite-span.html:
fast/css-grid-layout/grid-item-removal-auto-placement-update.html:
fast/css-grid-layout/named-grid-lines-with-named-grid-areas-resolution.html:
fast/css-grid-layout/resources/grid.css:

(.autoRowAutoColumnSpanning2):
(.autoRowSpanning2AutoColumn):
(.autoRowSpanning2AutoColumnSpanning3):
(.autoRowSpanning3AutoColumnSpanning2):
(.gridAutoFlowColumnDense):
(.gridAutoFlowRowDense):

2:22 PM Changeset in webkit [171081] by Brent Fulgham

8 edits in trunk/Source/WebCore

[iOS] Some videos play as inline audio-only content
https://bugs.webkit.org/show_bug.cgi?id=134898.
<rdar://problem/17629379>

Reviewed by Eric Carlson.

Add a new 'presentationType' accessor that indicates if the media
element is playing in 'audio' mode. This can happen if a video
element plays an HLS stream that starts off in audio-only mode.

html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::presentationType): Added.

html/HTMLMediaElement.h:
platform/audio/MediaSession.cpp:

(WebCore::MediaSession::presentationType): Added.

platform/audio/MediaSession.h:
platform/audio/MediaSessionManager.cpp:

(WebCore::MediaSessionManager::sessionRestrictsInlineVideoPlayback):
Use the presentationType, rather than the mediaType to control
inline playback behavior.

platform/audio/ios/AudioDestinationIOS.h:

(WebCore::AudioDestinationMac::presentationType): Add presentationType.

platform/audio/mac/AudioDestinationMac.h:

(WebCore::AudioDestinationMac::presentationType): Ditto.

2:07 PM Changeset in webkit [171080] by benjamin@webkit.org

5 edits in trunk/Source/WebKit2

[iOS][WK2] On rotation, RemoteLayerTreeDrawingArea renders one extra frame at the wrong orientation
https://bugs.webkit.org/show_bug.cgi?id=134875

Reviewed by Tim Horton.

On animated resize, the size of the DrawingAreaProxy was changed before the layout parameters were
changed. This in turn caused the WebProcess's DrawingArea to flush the layer tree while still
at the wrong orientation.

This patch fixes the issue by making a special case for animated resize:
-While starting animated resize, _frameOrBoundsChanged can be called several times in response to

the API's client changing the WKWebView. In that case, we do not update the drawing area.

-After the "updateBlock" is executed and the size have been changed, the dynamic viewport update

is computed, the dynamicViewportSizeUpdate is sent to the WebProcess, followed by the message
DrawingArea::updateGeometry(). Since both messages are asynchronous, they are received in that
order, and the updateGeometry() is always done after the viewport configuration has been updated.

UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _frameOrBoundsChanged]):
(-[WKWebView _beginAnimatedResizeWithUpdates:]):

UIProcess/ios/WKContentView.h:
UIProcess/ios/WKContentView.mm:

(-[WKContentView setMinimumSize:]): Deleted.

2:06 PM Changeset in webkit [171079] by Lucas Forschler

5 edits in tags/Safari-538.46.2/Source

Versioning.

2:02 PM Changeset in webkit [171078] by benjamin@webkit.org

3 edits in trunk/Source/WebKit2

[iOS][WK2] Fix withinEpsilon()
https://bugs.webkit.org/show_bug.cgi?id=134798

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-07-14
Reviewed by Darin Adler.

Move the function back to WKWebView, it is no longer needed in WKContentView.

Use the real types as input to properly verify that the two inputs are within
a small value of the 32bit floating point.

The epsilon we use is always on 32 bits float because we want to avoid doing work for changes
that would not make any difference on float.

The source of those small changes comes from the fact UIProcess does a lot of processing
on CGFloat, which are double on 64bits architecture, while the WebProcess use 32bits floating point
for scale. When we are getting updates from the WebProcess, we should ignore any small differences
caused by the computations done with less precision.

UIProcess/API/Cocoa/WKWebView.mm:

(withinEpsilon):

UIProcess/ios/WKContentViewInteraction.h:

(withinEpsilon): Deleted.

2:01 PM Changeset in webkit [171077] by Lucas Forschler

1 copy in tags/Safari-538.46.2

New Tag.

1:55 PM Changeset in webkit [171076] by benjamin@webkit.org

4 edits in trunk/Source/JavaScriptCore

Remove some dead code from FTLJITFinalizer
https://bugs.webkit.org/show_bug.cgi?id=134874

Reviewed by Geoffrey Garen.

Not sure what that code was for...but it does not do anything :)

ftl/FTLJITFinalizer.cpp:

(JSC::FTL::JITFinalizer::finalizeFunction):
The pointer of the label is computed but never used.

ftl/FTLJITFinalizer.h:
ftl/FTLLink.cpp:

(JSC::FTL::link):
The label is never set to anything.

1:12 PM Changeset in webkit [171075] by betravis@adobe.com

10 edits in trunk

[Feature Queries] Enable Feature Queries on Mac
https://bugs.webkit.org/show_bug.cgi?id=134404

Reviewed by Antti Koivisto.

Source/JavaScriptCore:
Enable Feature Queries on Mac and resume running the
feature tests.

Configurations/FeatureDefines.xcconfig: Turn on

ENABLE_CSS3_CONDITIONAL_RULES.

Source/WebCore:
Enable Feature Queries on Mac and resume running the
feature tests.

Configurations/FeatureDefines.xcconfig: Turn on

ENABLE_CSS3_CONDITIONAL_RULES.

Source/WebKit/mac:
Enable Feature Queries on Mac and resume running the
feature tests.

Configurations/FeatureDefines.xcconfig: Turn on

ENABLE_CSS3_CONDITIONAL_RULES.

Source/WebKit2:
Enable Feature Queries on Mac and resume running the
feature tests.

Configurations/FeatureDefines.xcconfig: Turn on

ENABLE_CSS3_CONDITIONAL_RULES.

LayoutTests:
Resume running the Feature Queries tests on Mac.

platform/mac/TestExpectations: Unskip the tests.

12:51 PM Changeset in webkit [171074] by hyatt@apple.com

3 edits in trunk/Source/WebCore

<rdar://problem/17305458> Cannot interact with video controls in ePubs
Bug 134836 - [New Multicolumn] Crawl to check for compositing between us and the enclosingPaginationLayer
https://bugs.webkit.org/show_bug.cgi?id=134836

Reviewed by Dean Jackson.

The paginatedAndComposited bit being set in updateLayerPositions just didn't work, since compositing states
can change without triggering that function. This patch just gets rid of the bit and does a crawl every time
to check. This ensures that changes in compositing states don't necessitate any changes in pagination,
since the lookup will always check the current compositing state.

The new function that does this check is hasCompositedLayerInEnclosingPaginationChain.

I have been unable to reproduce this issue, and this is therefore a purely speculative fix. I have no test
case to provide because of this.

rendering/RenderLayer.cpp:

(WebCore::RenderLayer::RenderLayer):
(WebCore::RenderLayer::updateLayerPositions):
(WebCore::RenderLayer::hasCompositedLayerInEnclosingPaginationChain):
(WebCore::RenderLayer::updatePagination):

rendering/RenderLayer.h:

12:15 PM Changeset in webkit [171073] by Alan Bujtas

4 edits in trunk/Source/WebCore

Move composite bounds calculation to RenderLayerBacking.
https://bugs.webkit.org/show_bug.cgi?id=134864

Reviewed by Darin Adler.

No change in functionality.

rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateCompositedBounds):

rendering/RenderLayerCompositor.cpp: it was just proxying the calculateLayerBounds()

to the RenderLayer.
(WebCore::RenderLayerCompositor::calculateCompositedBounds): Deleted.

rendering/RenderLayerCompositor.h:

12:14 PM Changeset in webkit [171072] by andersca@apple.com

6 edits in trunk

Make shouldKeepCurrentBackForwardListItemInList part of WKPageLoaderClientV5 to avoid breaking ABI
https://bugs.webkit.org/show_bug.cgi?id=134889

Reviewed by Beth Dakin.

Source/WebKit2:

UIProcess/API/C/WKPage.cpp:
UIProcess/API/C/WKPageLoaderClient.h:

Tools:
Bump loader version number to 5.

TestWebKitAPI/Tests/WebKit2/ShouldKeepCurrentBackForwardListItemInList.cpp:

(TestWebKitAPI::setPageLoaderClient):

WebKitTestRunner/TestController.cpp:

(WTR::TestController::createWebViewWithOptions):

11:54 AM Changeset in webkit [171071] by timothy_horton@apple.com

2 edits in trunk/Source/WebCore

Fix the build.

platform/audio/MediaSessionManager.h:

11:31 AM Changeset in webkit [171070] by mitz@apple.com

2 edits in trunk/Source/WebKit2

REGRESSION (r171045): Reproducible crash on navigation in PageClientImpl::willRecordNavigationSnapshot
https://bugs.webkit.org/show_bug.cgi?id=134887

Reviewed by Tim Horton.

UIProcess/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::navigationGestureDidBegin): nil-check m_webView. It can be nil when
the client is using WKView directly.
(WebKit::PageClientImpl::navigationGestureWillEnd): Ditto.
(WebKit::PageClientImpl::navigationGestureDidEnd): Ditto.
(WebKit::PageClientImpl::willRecordNavigationSnapshot): Ditto.

11:17 AM Changeset in webkit [171069] by eric.carlson@apple.com

16 edits
1 delete in trunk/Source

[Mac] don't enable low power audio mode on external output devices
https://bugs.webkit.org/show_bug.cgi?id=134877

Reviewed by Sam Weinig.

Source/WebCore:
No new tests, this deals with changes to the audio hardware at runtime.

WebCore.xcodeproj/project.pbxproj: Remove AudioSessionListener.h.
WebCore.vcxproj/WebCore.vcxproj: Ditto.

platform/audio/AudioHardwareListener.cpp:

(WebCore::AudioHardwareListener::AudioHardwareListener): Initialize m_outputDeviceSupportsLowPowerMode

to true on iOS.

platform/audio/AudioHardwareListener.h:

(WebCore::AudioHardwareListener::outputDeviceSupportsLowPowerMode): New accessor.
(WebCore::AudioHardwareListener::setHardwareActivity): New setter for derived classes.
(WebCore::AudioHardwareListener::setOutputDeviceSupportsLowPowerMode): Ditto.

Remove AudioSessionListener interface, it wasn't being used.

platform/audio/AudioSession.cpp:

(WebCore::AudioSession::addListener): Deleted.
(WebCore::AudioSession::removeListener): Deleted.
(WebCore::AudioSession::beganAudioInterruption): Deleted.
(WebCore::AudioSession::endedAudioInterruption): Deleted.

platform/audio/AudioSession.h:
platform/audio/AudioSessionListener.h: Removed.

platform/audio/MediaSessionManager.cpp:

(WebCore::MediaSessionManager::addSession): Allocate the AudioHardwareListener if necessary.
(WebCore::MediaSessionManager::removeSession): Free the AudioHardwareListener if necessary.
(WebCore::MediaSessionManager::audioOutputDeviceChanged): AudioHardwareListener client interface

called when the output device changes, call updateSessionState to make sure we are using
the correct buffer size.

platform/audio/MediaSessionManager.h:

platform/audio/ios/AudioDestinationIOS.h:
platform/audio/ios/AudioSessionIOS.mm:

(WebCore::AudioSessionPrivate::AudioSessionPrivate): Drive-by cleanup, remove ObjC helper object

that was used to listen for OS notifications, it is no longer used.

(SOFT_LINK_POINTER): Deleted.
(-[WebAudioSessionHelper initWithCallback:]): Deleted.
(-[WebAudioSessionHelper dealloc]): Deleted.
(-[WebAudioSessionHelper interruption:]): Deleted.

platform/audio/mac/AudioHardwareListenerMac.cpp:

(WebCore::currentDeviceSupportsLowPowerBufferSize): New, return true only if using build-in

transport device.

(WebCore::processIsRunningPropertyDescriptor): Return reference to static AudioObjectPropertyAddress

for kAudioHardwarePropertyProcessIsRunning instead of declaring one in every method
that needs one.

(WebCore::outputDevicePropertyDescriptor): Return reference to static AudioObjectPropertyAddress

for kAudioHardwarePropertyDefaultOutputDevice.

(WebCore::AudioHardwareListenerMac::AudioHardwareListenerMac): Restructure and add audio object

listener for default output device.

(WebCore::AudioHardwareListenerMac::~AudioHardwareListenerMac): *Remove* listener audio object

property listener instead of *Adding* a new one. Remove new listener.

(WebCore::AudioHardwareListenerMac::propertyChanged): Enumerate the properties that changed,

call appropriate method.

(WebCore::AudioHardwareListenerMac::processIsRunningChanged): Renamed from setHardwareActive,

cleanup.

(WebCore::AudioHardwareListenerMac::outputDeviceChanged): New, call client.audioHardwareOutputDeviceChanged.
(WebCore::AudioHardwareListenerMac::setHardwareActive): Deleted, renamed processIsRunningChanged.

platform/audio/mac/AudioHardwareListenerMac.h:

platform/audio/mac/MediaSessionManagerMac.cpp:

(MediaSessionManager::updateSessionState): Only set the output buffer size to 4K when hardware

supports it.

Source/WebKit2:

PluginProcess/PluginProcess.h: Add an empty implementation of

AudioHardwareListener::audioOutputDeviceChanged.

11:11 AM Changeset in webkit [171068] by timothy_horton@apple.com

3 edits in trunk/Source/WebKit2

[iOS] Throttle painting using a UI-process-side CADisplayLink
https://bugs.webkit.org/show_bug.cgi?id=134879
<rdar://problem/17641699>

Reviewed by Simon Fraser.

Just waiting for CA to commit is insufficient to actually throttle to 60fps,
because nothing will block the main runloop from spinning.

Instead, listen to a CADisplayLink, and send didUpdate to the WebProcess
the first time it fires after we commit. This is not a guarantee that
our content is on the screen, but we don't have any way to make that guarantee yet.

This will throttle painting, rAF, etc. to the display refresh rate.

UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.h:
UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.mm:

(-[OneShotDisplayLinkHandler initWithDrawingAreaProxy:]):
(-[OneShotDisplayLinkHandler dealloc]):
(-[OneShotDisplayLinkHandler displayLinkFired:]):
(-[OneShotDisplayLinkHandler invalidate]):
(-[OneShotDisplayLinkHandler schedule]):
(WebKit::RemoteLayerTreeDrawingAreaProxy::RemoteLayerTreeDrawingAreaProxy):
(WebKit::RemoteLayerTreeDrawingAreaProxy::~RemoteLayerTreeDrawingAreaProxy):
(WebKit::RemoteLayerTreeDrawingAreaProxy::commitLayerTree):
(WebKit::RemoteLayerTreeDrawingAreaProxy::didRefreshDisplay):
(WebKit::RemoteLayerTreeDrawingAreaProxy::coreAnimationDidCommitLayers): Deleted.

10:16 AM Changeset in webkit [171067] by Bruno de Oliveira Abinader

3 edits
2 adds in trunk/LayoutTests

[css3-text] Add editing test for CSS3 Text Decoration properties
https://bugs.webkit.org/show_bug.cgi?id=120114

Reviewed by Darin Adler.

Adds editing layout test to verify that CSS3 Text Decoration properties
are being properly propagated.

editing/pasteboard/insert-text-decoration-expected.txt: Added.
editing/pasteboard/insert-text-decoration.html: Added.
platform/mac/TestExpectations: Skip while CSS3_TEXT is disabled by default.
platform/win/TestExpectations: Skip while CSS3_TEXT is disabled by default.

9:17 AM Changeset in webkit [171066] by mitz@apple.com

6 edits in trunk/Source/WebKit2

<rdar://problem/17657391> [iOS] Networking process writes persistent credentials to the keychain
https://bugs.webkit.org/show_bug.cgi?id=134878

Reviewed by Sam Weinig.

Route CFNetwork’s calls to Security API through to the UI process.

NetworkProcess/ios/NetworkProcessIOS.mm:

(WebKit::NetworkProcess::platformInitializeNetworkProcess): Initialize SecItemShim.

Shared/mac/SecItemShim.cpp:

(WebKit::SecItemShim::initialize): On iOS, rather than using a shim library, supply
CFNetwork with alternate functions to call.

Shared/mac/SecItemShim.messages.in: Removed #if !PLATFORM(IOS).
UIProcess/mac/SecItemShimProxy.messages.in: Ditto.

config.h: Define ENABLE_SEC_ITEM_SHIM to 1 on iOS as well.

9:16 AM Changeset in webkit [171065] by dbates@webkit.org

3 edits in trunk/Tools

Teach check-webkit-style to suggest WTF::move() when it sees std::move()
https://bugs.webkit.org/show_bug.cgi?id=134620

Reviewed by Joseph Pecoraro.

Scripts/webkitpy/style/checkers/cpp.py:

(check_max_min_macros): Fix up comment so that it reads well.
(check_wtf_move): Added.
(check_style): Modified to call check_wtf_move().
(CppChecker): Add category "runtime/wtf_move".

Scripts/webkitpy/style/checkers/cpp_unittest.py:

(WebKitStyleTest.test_wtf_move): Added.

3:56 AM Changeset in webkit [171064] by jinwoo7.song@samsung.com

22 edits
3 adds in trunk/LayoutTests

[EFL] Unreviewed EFL gardening.

Rebaseline tests after r170418 and r170433.

platform/efl/fast/regions/repaint/japanese-rl-selection-repaint-in-regions-expected.png: Added. Rebaseline after r170418.
platform/efl/fast/regions/repaint/japanese-rl-selection-repaint-in-regions-expected.txt: Rebaseline after r170418.
platform/efl/fast/text/decorations-with-text-combine-expected.png: Rebaseline after r170418.
platform/efl/fast/text/decorations-with-text-combine-expected.txt: Rebaseline after r170418.
platform/efl/fast/text/emphasis-vertical-expected.png: Rebaseline after r170418.
platform/efl/fast/text/emphasis-vertical-expected.txt: Rebaseline after r170418.
platform/efl/fast/text/international/002-expected.png: Rebaseline after r170418.
platform/efl/fast/text/international/002-expected.txt: Rebaseline after r170418.
platform/efl/fast/text/international/text-combine-image-test-expected.png: Rebaseline after r170418.
platform/efl/fast/text/international/text-combine-image-test-expected.txt: Rebaseline after r170418.
platform/efl/fast/text/international/wrap-CJK-001-expected.png: Rebaseline after r170418.
platform/efl/fast/writing-mode/border-vertical-lr-expected.png: Rebaseline after r170418.
platform/efl/fast/writing-mode/border-vertical-lr-expected.txt: Rebaseline after r170418.
platform/efl/fast/writing-mode/japanese-lr-selection-expected.png: Rebaseline after r170418.
platform/efl/fast/writing-mode/japanese-lr-selection-expected.txt: Rebaseline after r170418.
platform/efl/fast/writing-mode/japanese-lr-text-expected.png: Rebaseline after r170418.
platform/efl/fast/writing-mode/japanese-lr-text-expected.txt: Rebaseline after r170418.
platform/efl/fast/writing-mode/japanese-rl-selection-expected.png: Rebaseline after r170418.
platform/efl/fast/writing-mode/japanese-rl-selection-expected.txt: Rebaseline after r170418.
platform/efl/fast/writing-mode/japanese-rl-text-expected.png: Rebaseline after r170418.
platform/efl/fast/writing-mode/japanese-rl-text-expected.txt: Rebaseline after r170418.
platform/efl/svg/W3C-SVG-1.1/filters-blend-01-b-expected.png: Rebaseline after r170433.
platform/efl/svg/W3C-SVG-1.1/filters-blend-01-b-expected.txt: Added. Rebaseline after r170433.
platform/efl/svg/filters/feBlend-all-blendmodes-expected.txt: Added. Rebaseline after r170433.

3:25 AM Changeset in webkit [171063] by jinwoo7.song@samsung.com

2 edits in trunk/LayoutTests

[EFL] Unreviewed EFL gardening.

Remove failure expectations for tests that have been passing after r168350, r169309 and r169620.

platform/efl/TestExpectations:

3:07 AM Changeset in webkit [171062] by jinwoo7.song@samsung.com

3 edits in trunk/LayoutTests

[EFL] Unreviewed EFL gardening.

platform/efl/css1/formatting_model/inline_elements-expected.png: Rebaseline after r170875.
platform/efl/css1/formatting_model/inline_elements-expected.txt: Rebaseline after r170875.

12:19 AM Changeset in webkit [171061] by mitz@apple.com

1 edit in trunk/Source/WebKit2/ChangeLog

Added Radar link to the last ChangeLog entry

12:18 AM Changeset in webkit [171060] by mitz@apple.com

4 edits in trunk/Source/WebKit2

NetworkProcess sometimes hangs under copyDefaultCredentialForProtectionSpace
https://bugs.webkit.org/show_bug.cgi?id=134666

Reviewed by Tim Horton.

A SecItem may have an attribute whose value is a SecAccessControlRef, which is not supported
by ArgumentCodersCF. In debug builds, trying to encode a CFDictionary containing a value of
unsupprted type causes an assertion to fail, but in release builds encoding succeeds, and
only decoding fails, in this case silently, simply not delivering the
SecItemShim::secItemResponse message.

The fix is to teach ArgumentCodersCF about SecAccessControlRef.

Shared/cf/ArgumentCodersCF.cpp:

(IPC::typeFromCFTypeRef): Check for the SecAccessControlRef type.
(IPC::encode): Encode the SecAccessControl serialized into CFData.
(IPC::decode): Deserialize a SecAccessControl from the decoded CFData.

Shared/cf/ArgumentCodersCF.h:
config.h: Defined HAVE_SEC_ACCESS_CONTROL.

Jul 13, 2014:

2:51 PM Changeset in webkit [171059] by benjamin@webkit.org

5 edits in trunk/Source/WebCore

Remove SelectorCheckerFastPath from the style resolution algorithm
https://bugs.webkit.org/show_bug.cgi?id=134866

Reviewed by Antti Koivisto.

SelectorCheckerFastPath is now pure overhead because it can almost never match
if the CSS JIT was unable to compile.

css/ElementRuleCollector.cpp:

(WebCore::ElementRuleCollector::ruleMatches):
The "pre-filter" behind fastCheckableSelector had two parts:
1) Filtering the pseudoID.
2) Filtering on the rule hash.

The first part has been generalized (RuleDatacanMatchPseudoElement())
and moved to collectMatchingRulesForList().

(WebCore::ElementRuleCollector::collectMatchingRulesForList):

css/RuleSet.cpp:

(WebCore::selectorCanMatchPseudoElement):
(WebCore::RuleData::RuleData):
(WebCore::RuleSet::addRegionRule):
(WebCore::RuleSet::addRulesFromSheet):

css/RuleSet.h:

(WebCore::RuleData::canMatchPseudoElement):
(WebCore::RuleData::hasFastCheckableSelector): Deleted.

css/StyleResolver.cpp:

2:46 PM Changeset in webkit [171058] by benjamin@webkit.org

2 edits in trunk/Source/WebCore

Remove an useless check from SelectorChecker
https://bugs.webkit.org/show_bug.cgi?id=134868

Reviewed by Darin Adler.

css/SelectorChecker.cpp:

(WebCore::SelectorChecker::matchRecursively):
The condition of this if() branch can never be met for the mode "QueryingRules".

The next condition in that if() is "dynamicPseudo != NOPSEUDO", which implies
a pseudo element was matched prior to the current context/simple selector.
This cannot happen with QueryingRules, since we never match pseudo elements for
SelectorQuery.

12:39 PM Changeset in webkit [171057] by mitz@apple.com

10 edits in trunk/Source/WebKit2

<rdar://problem/17295636> [Cocoa] Include element snapshot in _WKActivatedElementInfo
https://bugs.webkit.org/show_bug.cgi?id=134872

Reviewed by Sam Weinig.

Shared/InteractionInformationAtPosition.cpp:

(WebKit::InteractionInformationAtPosition::encode): Encode the image if there is one.
(WebKit::InteractionInformationAtPosition::decode): Decode the image if there is one.

Shared/InteractionInformationAtPosition.h: Added an image member to the struct.

UIProcess/API/Cocoa/_WKActivatedElementInfo.h: Exposed the boundingRect property and added

an image property.

UIProcess/API/Cocoa/_WKActivatedElementInfo.mm:

(-[_WKActivatedElementInfo _initWithType:URL:location:title:rect:image:]): Added an image
parameter, which is stored in a new ivar.
(-[_WKActivatedElementInfo image]): Added this getter, which converts the ShareableBitmap
into a cached Cocoa image and returns it.

UIProcess/API/Cocoa/_WKActivatedElementInfoInternal.h: Added image parameter to the

initializer, removed _boundingRect property declaration from here.

UIProcess/ios/WKActionSheetAssistant.mm:

(-[WKActionSheetAssistant showImageSheet]): Pass the image from the position information
into the _WKActivatedElementInfo initializer.
(-[WKActionSheetAssistant showLinkSheet]): Ditto.

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::snapshotNode): Added.

WebProcess/WebPage/WebPage.h:

WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::getPositionInformation): If the element is a link or an image, store a
snapshot of it in the image member of the InteractionInformationAtPosition.

11:55 AM Changeset in webkit [171056] by bshafiei@apple.com

5 edits in tags/Safari-538.43.42/Source

Versioning.

11:54 AM Changeset in webkit [171055] by bshafiei@apple.com

1 copy in tags/Safari-538.43.42

New tag.

11:39 AM Changeset in webkit [171054] by bshafiei@apple.com

5 edits in tags/Safari-538.43.41/Source

Versioning.

11:36 AM Changeset in webkit [171053] by bshafiei@apple.com

1 copy in tags/Safari-538.43.41

New tag.

10:26 AM Changeset in webkit [171052] by fpizlo@apple.com

2 edits in branches/ftlopt/Source/JavaScriptCore

Unreviewed, revert unintended change in r171051.

dfg/DFGCSEPhase.cpp:

10:18 AM Changeset in webkit [171051] by fpizlo@apple.com

4 edits in branches/ftlopt/Source

Merge trunk r171049.

2014-07-13 Filip Pizlo <fpizlo@apple.com>

HashMap should have removeIf()
https://bugs.webkit.org/show_bug.cgi?id=134870

Reviewed by Sam Weinig.

Expose a new HashMap method, called removeIf(), which allows you to do an efficient
pass over the map and remove a bunch of things at once. This is used by DFG GCSE as
part of https://bugs.webkit.org/show_bug.cgi?id=134677.

wtf/HashMap.h: (WTF::X>::removeIf):
wtf/HashTable.h: (WTF::KeyTraits>::removeIf):

10:09 AM Changeset in webkit [171050] by mitz@apple.com

3 edits in trunk/Source/WebKit2

[Cocoa] Clean up session state API a little
https://bugs.webkit.org/show_bug.cgi?id=134871

Reviewed by Darin Adler.

UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _sessionState]):
(-[WKWebView _restoreFromSessionState:]): Deleted.

UIProcess/API/Cocoa/WKWebViewPrivate.h:

10:03 AM Changeset in webkit [171049] by fpizlo@apple.com

3 edits in trunk/Source/WTF

HashMap should have removeIf()
https://bugs.webkit.org/show_bug.cgi?id=134870

Reviewed by Sam Weinig.

Expose a new HashMap method, called removeIf(), which allows you to do an efficient
pass over the map and remove a bunch of things at once. This is used by DFG GCSE as
part of https://bugs.webkit.org/show_bug.cgi?id=134677.