⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jul 15, 2014:

11:04 PM Changeset in webkit [171139] by ryuan.choi@samsung.com
  • 2 edits in trunk

[CMAKE] ENABLE_ENCRYPTED_MEDIA_V2 should depend on ENABLE_VIDEO
​https://bugs.webkit.org/show_bug.cgi?id=134963

Reviewed by Gyuyoung Kim.

ENCRYPTED_MEDIA_V2 requires VIDEO enabled.

  • Source/cmake/WebKitFeatures.cmake: Added the dependency for ENABLE_ENCRYPTED_MEDIA_V2.
9:44 PM Changeset in webkit [171138] by Yusuke Suzuki
  • 7 edits in trunk/Source/WebCore

CSS: Generalize CSS First Letter treatment
​https://bugs.webkit.org/show_bug.cgi?id=134936

Reviewed by Benjamin Poulain.

first-letter pseudo element rule is handled differently from the other rules
such as first-line. This patch removes this special handling in SelectorChecker
and handles it in RulesFeatureSet.

  • css/RuleFeature.cpp:

(WebCore::RuleFeatureSet::collectFeaturesFromSelector):
(WebCore::RuleFeatureSet::add):
(WebCore::RuleFeatureSet::clear):

  • css/RuleFeature.h:

(WebCore::RuleFeatureSet::RuleFeatureSet):

  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::matchRecursively):

  • css/StyleResolver.h:

(WebCore::StyleResolver::usesFirstLetterRules):

  • dom/DocumentStyleSheetCollection.cpp:

(WebCore::DocumentStyleSheetCollection::combineCSSFeatureFlags):
(WebCore::DocumentStyleSheetCollection::resetCSSFeatureFlags):

  • dom/DocumentStyleSheetCollection.h:

(WebCore::DocumentStyleSheetCollection::setUsesFirstLetterRules): Deleted.

9:33 PM Changeset in webkit [171137] by ryuan.choi@samsung.com
  • 2 edits in trunk/Tools

[EFL] Remove EFL WK1 directory from the checker.py
​https://bugs.webkit.org/show_bug.cgi?id=134954

Reviewed by Gyuyoung Kim.

  • Scripts/webkitpy/style/checker.py:
9:31 PM Changeset in webkit [171136] by clopez@igalia.com
  • 2 edits in trunk/Tools

Adding myself to contributors.json breaks a webkitpy test
​https://bugs.webkit.org/show_bug.cgi?id=134958

Reviewed by Ryosuke Niwa.

  • Scripts/webkitpy/tool/bot/irc_command_unittest.py:

(IRCCommandTest.test_whois): Be more specific and include also the
first name when asking for the whois of Xan in the unit test.

8:56 PM Changeset in webkit [171135] by benjamin@webkit.org
  • 2 edits in trunk/Source/WebKit2

Fix r171124

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2014-07-15

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _scrollToContentOffset:]):
On landing, I changed the min/max branches to shrunkTo/expandedTo, but the return value
of those was ignored.

8:07 PM Changeset in webkit [171134] by jonowells@apple.com
  • 25 edits
    2 copies in trunk/Source/WebInspectorUI

Web Inspector: Modernize UI styles and better sync with platform styles
​https://bugs.webkit.org/show_bug.cgi?id=134846

Reviewed by Timothy Hatcher.

Updated styles to better match the OS UI design. Updated the forward/back button.
Moved several rules to selectors that support older OS designs. Added global platform
data to support this patch.

  • UserInterface/Images/BackArrow.svg: Added.
  • UserInterface/Images/BackArrowLegacy.svg: Copied from Source/WebInspectorUI/UserInterface/Images/BackArrow.svg.
  • UserInterface/Images/ForwardArrow.svg: Added.
  • UserInterface/Images/ForwardArrowLegacy.svg: Copied from Source/WebInspectorUI/UserInterface/Images/ForwardArrow.svg.
  • UserInterface/Base/ImageUtilities.js: Updated image version

(.generateImage.generateModernImage):
(.generateImage.generateLegacyImage):
(.generateImage):
Updated image generation to support modern look. Updated versioning scheme and version.

  • UserInterface/Base/Main.js:

(WebInspector.loaded):
(WebInspector.contentLoaded.WebInspector.Platform.version.toString):
(WebInspector.contentLoaded.WebInspector.Platform.toString):
(WebInspector.contentLoaded):
Added global platform information.

  • UserInterface/Views/ContentBrowser.js:

(WebInspector.ContentBrowser):
Updated back and forward buttons.

  • UserInterface/Views/FindBanner.js:

(WebInspector.FindBanner.prototype._generateButtonsGlyphsIfNeeded):
Updated images for the find banner.

  • WebInspectorUI.vcxproj/WebInspectorUI.vcxproj:
  • WebInspectorUI.vcxproj/WebInspectorUI.vcxproj.filters:

Added new images.

  • UserInterface/Views/ButtonToolbarItem.css:

(.toolbar .item.button > .label):
(body.mac-platform.legacy .toolbar .item.button > .label):

  • UserInterface/Views/CSSStyleDeclarationSection.css:

(.style-declaration-section):
(body.mac-platform.legacy .style-declaration-section):
(body.mac-platform.legacy .style-declaration-section + .style-declaration-section):
(.style-declaration-section.last-in-group):
(body.mac-platform.legacy .style-declaration-section.last-in-group):
(.style-declaration-section.last-in-group + .style-declaration-section):
(body.mac-platform.legacy .style-declaration-section.last-in-group + .style-declaration-section):
(body.mac-platform.legacy .style-declaration-section.last-in-group + .style-declaration-section:last-child):
(.style-declaration-section + .style-declaration-section): Deleted.
(.style-declaration-section.last-in-group + .style-declaration-section:last-child): Deleted.

  • UserInterface/Views/CSSStyleDetailsSidebarPanel.css:

(.sidebar > .panel.details.css-style > .content > .pseudo-classes):

  • UserInterface/Views/DOMTreeOutline.css:

(.dom-tree-outline li.hovered:not(.selected) .selection):
(body.mac-platform.legacy .dom-tree-outline li.hovered:not(.selected) .selection):
(.dom-tree-outline li.elements-drag-over .selection):
(body.mac-platform.legacy .dom-tree-outline li.elements-drag-over .selection):
(.dom-tree-outline:focus li.selected .selection):
(body.mac-platform.legacy .dom-tree-outline:focus li.selected .selection):

  • UserInterface/Views/DashboardContainerView.css:

(.toolbar .dashboard-container):
(body.mac-platform.legacy .toolbar .dashboard-container):
(body.window-inactive .toolbar .dashboard-container):
(body.mac-platform.legacy.window-inactive .toolbar .dashboard-container):
(.toolbar .dashboard):
(body.window-inactive .toolbar .dashboard):
(body.mac-platform.legacy.window-inactive .toolbar .dashboard):

  • UserInterface/Views/DataGrid.css:

(.data-grid th):
(body.mac-platform.legacy .data-grid th):
(.data-grid tr.selected):
(body.mac-platform.legacy .data-grid tr.selected):
(.data-grid:focus tr.selected):
(body.mac-platform.legacy .data-grid:focus tr.selected):

  • UserInterface/Views/DetailsSection.css:

(.details-section):
(body.mac-platform.legacy .details-section):
(.details-section .details-section):
(body.mac-platform.legacy .details-section .details-section):
(.details-section .details-section:last-child):
(.details-section .details-section:first-child):
(.details-section > .header):
(body.mac-platform.legacy .details-section > .header):
(.details-section .details-section > .header):
(body.mac-platform.mountain-lion .details-section .details-section > .header):
(.details-section .details-section.collaspsed > .header):
(.details-section.computed-style-properties:not(.collapsed) > .header):
(body.mac-platform.legacy .details-section.computed-style-properties:not(.collapsed) > .header):
(.details-section > .content > .group):
(body.mac-platform.legacy .details-section > .content > .group):
(.details-section > .content > .group:last-child):
(.details-section > .content > .group:nth-child(even)):
(body.mac-platform.legacy .details-section > .content > .group:nth-child(even)):
(body.mac-platform.legacy .details-section > .content > .group:last-child > .row.simple:last-child > *):
(.details-section > .content > .group:last-child > .row.simple:last-child > *): Deleted.

  • UserInterface/Views/FilterBar.css:

(.filter-bar > input[type="search"]):
(body.mac-platform.legacy .filter-bar > input[type="search"]):

  • UserInterface/Views/NavigationSidebarPanel.css:

(.navigation-sidebar-panel-content-tree-outline .item.selected):
(body.mac-platform.legacy .navigation-sidebar-panel-content-tree-outline .item.selected):
(.navigation-sidebar-panel-content-tree-outline:focus .item.selected):
(body.mac-platform.legacy .navigation-sidebar-panel-content-tree-outline:focus .item.selected):
(body.window-inactive .navigation-sidebar-panel-content-tree-outline .item.selected):
(body.mac-platform.legacy.window-inactive .navigation-sidebar-panel-content-tree-outline .item.selected):

  • UserInterface/Views/RadioButtonNavigationItem.css:

(.navigation-bar .item.radio.button.text-only.selected):
(body.mac-platform.legacy .navigation-bar .item.radio.button.text-only.selected):

  • UserInterface/Views/RulesStyleDetailsPanel.css:

(.sidebar > .panel.details.css-style .rules .label + .style-declaration-section):
(body.mac-platform.legacy .sidebar > .panel.details.css-style .rules .label + .style-declaration-section):
(.sidebar > .panel.details.css-style .rules .new-rule):
(body.mac-platform.legacy .sidebar > .panel.details.css-style .rules .new-rule):
(.sidebar > .panel.details.css-style .rules .new-rule + .style-declaration-section):
(body.mac-platform.legacy .sidebar > .panel.details.css-style .rules .new-rule + .style-declaration-section):

  • UserInterface/Views/ScopeBar.css:

(.scope-bar > li):
(body.mac-platform.legacy .scope-bar > li):
(.scope-bar > li.selected):
(body.mac-platform.legacy .scope-bar > li.selected):

  • UserInterface/Views/SearchBar.css:

(.search-bar > input[type="search"]):
(body.mac-platform.legacy .search-bar > input[type="search"]):

  • UserInterface/Views/Sidebar.css:

(.sidebar):
(body.mac-platform.legacy .sidebar):
(body.mac-platform.legacy.window-inactive .sidebar):
(body.mac-platform.legacy .sidebar.right):
(body.window-inactive .sidebar): Deleted.
(.sidebar.right): Deleted.

  • UserInterface/Views/TimelineSidebarPanel.css:

(.sidebar > .panel.navigation.timeline > .title-bar):
(body.mac-platform.legacy .sidebar > .panel.navigation.timeline > .title-bar):
Style updates for new look and feel.

8:06 PM Changeset in webkit [171133] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

Fix non-iOS builds.

  • rendering/RenderBox.cpp:

(WebCore::shouldAppyContainersClipAndOffset):

7:58 PM Changeset in webkit [171132] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

[iOS] Fix touches inside accelerated overflow:scroll
​https://bugs.webkit.org/show_bug.cgi?id=134961
<rdar://problem/16088789>

Reviewed by Benjamin Poulain.

When individual elements inside an overflow:scroll with -webkit-overflow-scrolling: touch
had touch event listeners, we would fail to take the scroll offset into account when
building the touch event region, causing touches on those elements to fail after scrolling.

Touch event region building uses RenderObject::absoluteClippedOverflowRect(), and that
code path tries to fix up repaint rects to work correctly in composited overflow:scroll.
However, that broke the touch region computation.

Fix by only ignoring the scroll offset for calls to computeRectForRepaint() which
have a non-null repaintContainer (which indicates that we're doing a repaint in the
compositing layer), and for which the repaintContainer is the containing block
which is using composited scrolling. This restores correct behavior to the event region
code which always calls this with a null repaintContainer.

  • rendering/RenderBox.cpp:

(WebCore::shouldAppyContainersClipAndOffset):
(WebCore::RenderBox::computeRectForRepaint):

7:26 PM Changeset in webkit [171131] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WTF

Unreviewed, rolling out r171107.
​https://bugs.webkit.org/show_bug.cgi?id=134959

This was not the problem! (Requested by kling on #webkit).

Reverted changeset:

"Revert: Run the FastMalloc scavenger thread on iOS as well."
​https://bugs.webkit.org/show_bug.cgi?id=134927
​http://trac.webkit.org/changeset/171107

6:40 PM Changeset in webkit [171130] by achristensen@apple.com
  • 2 edits in trunk/Websites/webkit.org

Make css jit benchmark work on IE11.
​https://bugs.webkit.org/show_bug.cgi?id=134956

Reviewed by Benjamin Poulain.

  • blog-files/css-jit-introduction/html5-single-page-microbenchmark.html:

Remove an iframe which caused IE11 to try to open content as a URL.

6:29 PM Changeset in webkit [171129] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit2

WKWebView’s FormClient::willSubmitForm should use CompletionHandlerCallChecker
​https://bugs.webkit.org/show_bug.cgi?id=134951

Reviewed by Tim Horton.

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _setFormDelegate:]):

5:53 PM Changeset in webkit [171128] by bshafiei@apple.com
  • 2 edits in tags/Safari-538.46.3/Source/WebCore

Merged r171099. <rdar://problem/16917699>

5:51 PM Changeset in webkit [171127] by bshafiei@apple.com
  • 2 edits in tags/Safari-538.46.3/Source/WebCore

Merged r171089. <rdar://problem/16917699>

5:47 PM Changeset in webkit [171126] by bshafiei@apple.com
  • 5 edits in tags/Safari-538.46.3/Source

Versioning.

5:43 PM Changeset in webkit [171125] by bshafiei@apple.com
  • 1 copy in tags/Safari-538.46.3

New tag.

5:14 PM Changeset in webkit [171124] by benjamin@webkit.org
  • 4 edits in trunk/Source/WebKit2

[iOS][WK2] Scrolling request from the scrolling tree must be limited to offsets in the document
​https://bugs.webkit.org/show_bug.cgi?id=134952
<rdar://problem/17647116>

Reviewed by Enrica Casucci.

When we received a scroll request, we were taking that offset directly to set the UIScrollView
scroll position. This is a problem if a page request scrolling to an invalid position, we were
still doing it.

This patch limits the position to be inside the document.

-- Why not limit the scroll offset in the WebProcess when we receive the scroll request? --

Some pages rely on the page scale factor changing instantly, because that is how it worked
on WebKit1.

On WebKit2, the WebProcess cannot know the valid range because the obscured insets are changing
dynamically, and the page scale factor can change in response to WebProcess events (the focus
changing for example). To make the page works, the WebProcess does not restrict the scroll position.

In that architecture, the UIProcess has to sanitize the input, which was not done before this patch.

-- Why not use changeContentOffsetBoundedInValidRange()?

The scroll offset as seen by the page is relative to the unobscured rect. While the position used
for history item is a visual position. All we need in this case is a position in the view.

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _scrollToContentOffset:]):

  • UIProcess/WebPageProxy.h:
  • UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::resendLastVisibleContentRects):

4:59 PM Changeset in webkit [171123] by benjamin@webkit.org
  • 8 edits in trunk/Source/JavaScriptCore

Reduce the overhead of updating the AssemblerBuffer
​https://bugs.webkit.org/show_bug.cgi?id=134659

Reviewed by Gavin Barraclough.

In r164548, the linker was changed to allow the LinkBuffer to survive its MacroAssembler.
That feature is useful for JSC to get offsets inside a linked buffer in order to jump directly
there.

On ARM, we use branch compaction and we need to keep the "compaction offset" somewher to be able
to get the real address of a lable. That is done by reusing the memory of AssemblerData.

To share the memory between LinkBuffer and the Assembler, r164548 moved the AssemblerData into
a ref-counted object. Unfortunately, the extra complexity related to the new AssemblerData was enough
to make clang give up a bunch of optimizations.

This patch solve (some of) the problems by making AssemblerBuffer and AssemblerData super low overhead structures.
In particular, the grow() function becomes 8 Thumb instructions, which is easily inlined everywhere it is used.

Instead of sharing ownership between the Assembler and LinkBuffer, LinkBuffer now takes full ownership of
the AssemblerData. I feel this is also safer since LinkBuffer is reusing the AssemblerData is a very
specific way that would make it unusable for the Assembler.

-- Technical details --

From LinkBuffer, we don't want to ever access the Assembler after releasing its buffer (or writting anything
into it really). This was obviously already the case, but that was hard to prove from LinkBuffer::copyCompactAndLinkCode().
To make this easier to work with, I changed all the assembler specific function to be static. This way we know
exactly what code access the Assembler instance. The code that does access the instance is then moved
at the beginning, before we modify anything.

The function recordLinkOffsets() that was on the MacroAssembler and copied in Assembler was moved directly
to LinkBuffer. This make the modification of AssemblerData completely explicit, and that code is specific
to LinkBuffer anyway (see LinkBuffer::executableOffsetFor()).

-- Perf impact --

This does not put us exactly at before r164548 due to the missing inline buffer. Still, it is very close.
On ARMv7, this reduces the time spent in Assembler by half. On the CSS JIT, this reduces the compilation
time by ~20%.

I could not measure any difference on x86_64.

  • assembler/ARM64Assembler.h:

(JSC::ARM64Assembler::jumpSizeDelta):
(JSC::ARM64Assembler::canCompact):
(JSC::ARM64Assembler::computeJumpType):
(JSC::ARM64Assembler::link):
(JSC::ARM64Assembler::recordLinkOffsets): Deleted.

  • assembler/ARMv7Assembler.h:

(JSC::ARMv7Assembler::ifThenElseConditionBit):
(JSC::ARMv7Assembler::ifThenElse):
(JSC::ARMv7Assembler::jumpSizeDelta):
(JSC::ARMv7Assembler::canCompact):
(JSC::ARMv7Assembler::computeJumpType):
(JSC::ARMv7Assembler::link):
(JSC::ARMv7Assembler::linkJumpT1):
(JSC::ARMv7Assembler::linkJumpT3):
(JSC::ARMv7Assembler::linkConditionalJumpT4):
(JSC::ARMv7Assembler::linkConditionalBX):
(JSC::ARMv7Assembler::recordLinkOffsets): Deleted.

  • assembler/AssemblerBuffer.h:

(JSC::AssemblerData::AssemblerData):
(JSC::AssemblerData::operator=):
(JSC::AssemblerData::~AssemblerData):
(JSC::AssemblerData::buffer):
(JSC::AssemblerData::capacity):
(JSC::AssemblerData::grow):
(JSC::AssemblerBuffer::AssemblerBuffer):
(JSC::AssemblerBuffer::isAvailable):
(JSC::AssemblerBuffer::data):
(JSC::AssemblerBuffer::releaseAssemblerData):
(JSC::AssemblerBuffer::putIntegral):
(JSC::AssemblerBuffer::putIntegralUnchecked):
(JSC::AssemblerBuffer::append):
(JSC::AssemblerBuffer::grow):
(JSC::AssemblerBuffer::~AssemblerBuffer): Deleted.
(JSC::AssemblerBuffer::storage): Deleted.

  • assembler/LinkBuffer.cpp:

(JSC::recordLinkOffsets):
(JSC::LinkBuffer::copyCompactAndLinkCode):

  • assembler/LinkBuffer.h:

(JSC::LinkBuffer::LinkBuffer):
(JSC::LinkBuffer::executableOffsetFor):

  • assembler/MacroAssemblerARM64.h:

(JSC::MacroAssemblerARM64::canCompact):
(JSC::MacroAssemblerARM64::computeJumpType):
(JSC::MacroAssemblerARM64::jumpSizeDelta):
(JSC::MacroAssemblerARM64::link):
(JSC::MacroAssemblerARM64::recordLinkOffsets): Deleted.

  • assembler/MacroAssemblerARMv7.h:

(JSC::MacroAssemblerARMv7::canCompact):
(JSC::MacroAssemblerARMv7::computeJumpType):
(JSC::MacroAssemblerARMv7::jumpSizeDelta):
(JSC::MacroAssemblerARMv7::link):
(JSC::MacroAssemblerARMv7::recordLinkOffsets): Deleted.

4:12 PM Changeset in webkit [171122] by Lucas Forschler
  • 5 edits in tags/Safari-538.46.40/Source

Versioning.

3:55 PM Changeset in webkit [171121] by Lucas Forschler
  • 1 copy in tags/Safari-538.46.40

New Tag.

3:51 PM Changeset in webkit [171120] by mmaxfield@apple.com
  • 2 edits in trunk/Source/WebKit/mac

[OSX] [WK1] Crash when exiting fullscreen
​https://bugs.webkit.org/show_bug.cgi?id=134943

Reviewed by Dean Jackson.

AppKit doesn't remove a view from the Key View Loop when removing it from its superview.

This codepath is already "tested" in fullscreen/full-screen-cancel.html, but because of our
testing infrastructure, the broken codepath doesn't actually get hit in DRT. Therefore,
there is no test.

  • WebView/WebFullScreenController.mm:

(-[WebFullScreenController enterFullScreen:]):

3:25 PM Changeset in webkit [171119] by Simon Fraser
  • 9 edits in trunk/Source/WebCore

[iOS] Fix issues drawing subsampled image elements and CSS images
​https://bugs.webkit.org/show_bug.cgi?id=134944
<rdar://problem/17634095>

Reviewed by Dean Jackson.

After r170675 it is important for BitmapImage::draw() to be given a srcRect computed
using the original size of the image, not the subsampled size.

So fix various code paths that end up in image drawing to use the originalSize(),
which requires giving Image a virtual function that just returns size(), and hence has
a FloatSize return value.

Tested by setting a very low subsampling threshold and browsing various sites.

A better longterm fix will happen via bug 134916.

  • platform/graphics/BitmapImage.cpp:

(WebCore::BitmapImage::originalSize):

  • platform/graphics/BitmapImage.h:
  • platform/graphics/GraphicsContext.cpp:

(WebCore::GraphicsContext::drawImage):

  • platform/graphics/Image.cpp:

(WebCore::Image::drawTiled):
(WebCore::Image::computeIntrinsicDimensions):

  • platform/graphics/Image.h:

(WebCore::Image::originalSize):

  • platform/graphics/cg/BitmapImageCG.cpp:

(WebCore::BitmapImage::BitmapImage): Just use m_size for initializing the other members.
(WebCore::BitmapImage::draw):

  • platform/graphics/cg/GraphicsContext3DCG.cpp:

(WebCore::GraphicsContext3D::ImageExtractor::extractImage):

  • platform/graphics/cg/ImageCG.cpp:

(WebCore::Image::drawPattern):

2:32 PM Changeset in webkit [171118] by Lucas Forschler
  • 5 edits in trunk/Source

Versioning.

2:26 PM Changeset in webkit [171117] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit2

Dispatch top content inset changes immediately if synchronously waiting for view state changes
​https://bugs.webkit.org/show_bug.cgi?id=134942
<rdar://problem/17666800>

Reviewed by Simon Fraser.

  • UIProcess/API/mac/WKView.mm:

(-[WKView endDeferringViewInWindowChanges]):
(-[WKView endDeferringViewInWindowChangesSync]):
(-[WKView _dispatchSetTopContentInset]):
(-[WKView _setTopContentInset:]):
Send top content inset changes immediately before sync-waiting for new tiles from the Web Process.
This will ensure that the incoming contents have the right top content inset, and we don't
flash between the wrong inset and the right one.

2:17 PM Changeset in webkit [171116] by Brent Fulgham
  • 3 edits in trunk/Source/WebCore

[Win] Unreviewed build fix after r171069.

Add missing AudioHardwareListener implementation on Windows.

  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
2:05 PM Changeset in webkit [171115] by mhahnenberg@apple.com
  • 10 edits in trunk/Source/JavaScriptCore

Stores to PropertyTable use the Structure as the owner
​https://bugs.webkit.org/show_bug.cgi?id=134595

Reviewed by Darin Adler.

Since PropertyTable is the object that does the marking of these references, it should be the owner.

Also removed some unused parameters to other methods that historically used the Structure as the owner.

  • runtime/JSPropertyNameIterator.h:

(JSC::StructureRareData::setEnumerationCache):

  • runtime/ObjectPrototype.cpp:

(JSC::objectProtoFuncToString):

  • runtime/PropertyMapHashTable.h:

(JSC::PropertyTable::copy):

  • runtime/PropertyTable.cpp:

(JSC::PropertyTable::clone):
(JSC::PropertyTable::PropertyTable):

  • runtime/Structure.cpp:

(JSC::Structure::Structure):
(JSC::Structure::materializePropertyMap):
(JSC::Structure::addPropertyTransition):
(JSC::Structure::changePrototypeTransition):
(JSC::Structure::despecifyFunctionTransition):
(JSC::Structure::attributeChangeTransition):
(JSC::Structure::toDictionaryTransition):
(JSC::Structure::preventExtensionsTransition):
(JSC::Structure::takePropertyTableOrCloneIfPinned):
(JSC::Structure::nonPropertyTransition):
(JSC::Structure::copyPropertyTable):
(JSC::Structure::copyPropertyTableForPinning):
(JSC::Structure::putSpecificValue):

  • runtime/Structure.h:

(JSC::Structure::setObjectToStringValue):
(JSC::Structure::setPreviousID):

  • runtime/StructureInlines.h:

(JSC::Structure::setEnumerationCache):

  • runtime/StructureRareData.h:
  • runtime/StructureRareDataInlines.h:

(JSC::StructureRareData::setPreviousID):
(JSC::StructureRareData::setObjectToStringValue):

1:52 PM Changeset in webkit [171114] by enrica@apple.com
  • 2 edits in trunk/Source/WebKit2

REGRESSION(WK2 iOS): Safari hangs when switching focus from a field using the Tab key.
​https://bugs.webkit.org/show_bug.cgi?id=134934
<rdar://problem/17224638>

Reviewed by Tim Horton.

  • UIProcess/ios/WKContentViewInteraction.mm:


Tab and back tab should be handled as special keys that have
a command associated. The command specifies for each key the relevant
action. This patch implements the commands property to create the association
between key and command and the relevant actions that will execute the same
code executed when the used taps on the < > buttons in the accessory bar.

(-[WKContentView keyCommands]):
(-[WKContentView _nextAccessoryTab:]):
(-[WKContentView _prevAccessoryTab:]):

1:31 PM Changeset in webkit [171113] by oliver@apple.com
  • 2 edits in trunk/Source/WebKit2

More tidying of the webcontent sandbox profile
​https://bugs.webkit.org/show_bug.cgi?id=134938

Reviewed by Alexey Proskuryakov.

Remove some excessive abilities from the profile and make
the required ones explicit.

  • Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
12:41 PM Changeset in webkit [171112] by bshafiei@apple.com
  • 2 edits in tags/Safari-538.46.1.1/Source/WebCore

Merged r171099. <rdar://problem/16917699>

12:38 PM Changeset in webkit [171111] by bshafiei@apple.com
  • 2 edits in tags/Safari-538.46.1.1/Source/WebCore

Merged r171089. <rdar://problem/16917699>

12:30 PM Changeset in webkit [171110] by bshafiei@apple.com
  • 5 edits in tags/Safari-538.46.1.1/Source

Versioning.

12:27 PM Changeset in webkit [171109] by bshafiei@apple.com
  • 1 copy in tags/Safari-538.46.1.1

New tag.

12:11 PM Changeset in webkit [171108] by mhahnenberg@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

ScriptExecutable::forEachCodeBlock can dereference null CodeBlocks
​https://bugs.webkit.org/show_bug.cgi?id=134928

Reviewed by Andreas Kling.

  • bytecode/CodeBlock.h:

(JSC::ScriptExecutable::forEachCodeBlock): Check for null CodeBlocks before calling forEachRelatedCodeBlock.

11:34 AM Changeset in webkit [171107] by akling@apple.com
  • 2 edits in trunk/Source/WTF

Revert: Run the FastMalloc scavenger thread on iOS as well.
<​https://webkit.org/b/134927>
<rdar://problem/17485079>

This appears to be the cause of some elusive crashes, and since I don't
have a way to reproduce them, let's just go back to not running the
scavenger thread on iOS.

Reviewed by Antti Koivisto.

  • wtf/FastMalloc.cpp:
8:48 AM Changeset in webkit [171106] by fpizlo@apple.com
  • 21 edits
    13 adds in branches/ftlopt

[ftlopt] DFG should be able to do GCSE in SSA and this should be unified with the CSE in CPS, and both of these things should use abstract heaps for reasoning about effects
​https://bugs.webkit.org/show_bug.cgi?id=134677

Reviewed by Sam Weinig.

Source/JavaScriptCore:

This removes the old local CSE phase, which was based on manually written backward-search
rules for all of the different kinds of things we cared about, and adds a new local/global
CSE (local for CPS and global for SSA) that leaves the node semantics almost entirely up to
clobberize(). Thus, the CSE phase itself just worries about the algorithms and data
structures used for storing sets of available values. This results in a large reduction in
code size in CSEPhase.cpp while greatly increasing the phase's power (since it now does
global CSE) and reducing compile time (since local CSE is now rewritten to use smarter data
structures). Even though LLVM was already running GVN, the extra GCSE at DFG IR level means
that this is a significant (~0.7%) throughput improvement.

This work is based on the concept of "def" to clobberize(). If clobberize() calls def(), it
means that the node being analyzed makes available some value in some DFG node, and that
future attempts to compute that value can simply use that node. In other words, it
establishes an available value mapping of the form value=>node. There are two kinds of
values that can be passed to def():

PureValue. This captures everything needed to determine whether two pure nodes - nodes that

neither read nor write, and produce a value that is a CSE candidate - are identical. It
carries the NodeType, an AdjacencyList, and one word of meta-data. The meta-data is
usually used for things like the arithmetic mode or constant pointer. Passing a
PureValue to def() means that the node produces a value that is valid anywhere that the
node dominates.


HeapLocation. This describes a location in the heap that could be written to or read from.

Both stores and loads can def() a HeapLocation. HeapLocation carries around an abstract
heap that both serves as part of the "name" of the heap location (together with the
other fields of HeapLocation) and also tells us what write()'s to watch for. If someone
write()'s to an abstract heap that overlaps the heap associated with the HeapLocation,
then it means that the values for that location are no longer available.


This approach is sufficiently clever that the CSEPhase itself can focus on the mechanism of
tracking the PureValue=>node and HeapLocation=>node maps, without having to worry about
interpreting the semantics of different DFG node types - that is now almost entirely in
clobberize(). The only things we special-case inside CSEPhase are the Identity node, which
CSE is traditionally responsible for eliminating even though it has nothing to do with CSE,
and the LocalCSE rule for turning PutByVal into PutByValAlias.

This is a slight Octane, SunSpider, and Kraken speed-up - all somewhere arond 0.7% . It's
not a bigger win because LLVM was already giving us most of what we needed in its GVN.
Also, the SunSpider speed-up isn't from GCSE as much as it's a clean-up of local CSE - that
is no longer O(n2). Basically this is purely good: it reduces the amount of LLVM IR we
generate, it removes the old CSE's heap modeling (which was a constant source of bugs), and
it improves both the quality of the code we generate and the speed with which we generate
it. Also, any future optimizations that depend on GCSE will now be easier to implement.

During the development of this patch I also rationalized some other stuff, like Graph's
ordered traversals - we now have preorder and postorder rather than just "depth first".

  • CMakeLists.txt:
  • JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • dfg/DFGAbstractHeap.h:
  • dfg/DFGAdjacencyList.h:

(JSC::DFG::AdjacencyList::hash):
(JSC::DFG::AdjacencyList::operator==):

  • dfg/DFGBasicBlock.h:
  • dfg/DFGCSEPhase.cpp:

(JSC::DFG::performLocalCSE):
(JSC::DFG::performGlobalCSE):
(JSC::DFG::CSEPhase::CSEPhase): Deleted.
(JSC::DFG::CSEPhase::run): Deleted.
(JSC::DFG::CSEPhase::endIndexForPureCSE): Deleted.
(JSC::DFG::CSEPhase::pureCSE): Deleted.
(JSC::DFG::CSEPhase::constantCSE): Deleted.
(JSC::DFG::CSEPhase::constantStoragePointerCSE): Deleted.
(JSC::DFG::CSEPhase::getCalleeLoadElimination): Deleted.
(JSC::DFG::CSEPhase::getArrayLengthElimination): Deleted.
(JSC::DFG::CSEPhase::globalVarLoadElimination): Deleted.
(JSC::DFG::CSEPhase::scopedVarLoadElimination): Deleted.
(JSC::DFG::CSEPhase::varInjectionWatchpointElimination): Deleted.
(JSC::DFG::CSEPhase::getByValLoadElimination): Deleted.
(JSC::DFG::CSEPhase::checkFunctionElimination): Deleted.
(JSC::DFG::CSEPhase::checkExecutableElimination): Deleted.
(JSC::DFG::CSEPhase::checkStructureElimination): Deleted.
(JSC::DFG::CSEPhase::structureTransitionWatchpointElimination): Deleted.
(JSC::DFG::CSEPhase::getByOffsetLoadElimination): Deleted.
(JSC::DFG::CSEPhase::getGetterSetterByOffsetLoadElimination): Deleted.
(JSC::DFG::CSEPhase::getPropertyStorageLoadElimination): Deleted.
(JSC::DFG::CSEPhase::checkArrayElimination): Deleted.
(JSC::DFG::CSEPhase::getIndexedPropertyStorageLoadElimination): Deleted.
(JSC::DFG::CSEPhase::getInternalFieldLoadElimination): Deleted.
(JSC::DFG::CSEPhase::getMyScopeLoadElimination): Deleted.
(JSC::DFG::CSEPhase::getLocalLoadElimination): Deleted.
(JSC::DFG::CSEPhase::invalidationPointElimination): Deleted.
(JSC::DFG::CSEPhase::setReplacement): Deleted.
(JSC::DFG::CSEPhase::eliminate): Deleted.
(JSC::DFG::CSEPhase::performNodeCSE): Deleted.
(JSC::DFG::CSEPhase::performBlockCSE): Deleted.
(JSC::DFG::performCSE): Deleted.

  • dfg/DFGCSEPhase.h:
  • dfg/DFGClobberSet.cpp:

(JSC::DFG::addReads):
(JSC::DFG::addWrites):
(JSC::DFG::addReadsAndWrites):
(JSC::DFG::readsOverlap):
(JSC::DFG::writesOverlap):

  • dfg/DFGClobberize.cpp:

(JSC::DFG::doesWrites):
(JSC::DFG::accessesOverlap):
(JSC::DFG::writesOverlap):

  • dfg/DFGClobberize.h:

(JSC::DFG::clobberize):
(JSC::DFG::NoOpClobberize::operator()):
(JSC::DFG::CheckClobberize::operator()):
(JSC::DFG::ReadMethodClobberize::ReadMethodClobberize):
(JSC::DFG::ReadMethodClobberize::operator()):
(JSC::DFG::WriteMethodClobberize::WriteMethodClobberize):
(JSC::DFG::WriteMethodClobberize::operator()):
(JSC::DFG::DefMethodClobberize::DefMethodClobberize):
(JSC::DFG::DefMethodClobberize::operator()):

  • dfg/DFGDCEPhase.cpp:

(JSC::DFG::DCEPhase::run):
(JSC::DFG::DCEPhase::fixupBlock):

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::getBlocksInPreOrder):
(JSC::DFG::Graph::getBlocksInPostOrder):
(JSC::DFG::Graph::addForDepthFirstSort): Deleted.
(JSC::DFG::Graph::getBlocksInDepthFirstOrder): Deleted.

  • dfg/DFGGraph.h:
  • dfg/DFGHeapLocation.cpp: Added.

(JSC::DFG::HeapLocation::dump):
(WTF::printInternal):

  • dfg/DFGHeapLocation.h: Added.

(JSC::DFG::HeapLocation::HeapLocation):
(JSC::DFG::HeapLocation::operator!):
(JSC::DFG::HeapLocation::kind):
(JSC::DFG::HeapLocation::heap):
(JSC::DFG::HeapLocation::base):
(JSC::DFG::HeapLocation::index):
(JSC::DFG::HeapLocation::hash):
(JSC::DFG::HeapLocation::operator==):
(JSC::DFG::HeapLocation::isHashTableDeletedValue):
(JSC::DFG::HeapLocationHash::hash):
(JSC::DFG::HeapLocationHash::equal):

  • dfg/DFGLICMPhase.cpp:

(JSC::DFG::LICMPhase::run):

  • dfg/DFGNode.h:

(JSC::DFG::Node::replaceWith):
(JSC::DFG::Node::convertToPhantomUnchecked): Deleted.

  • dfg/DFGPlan.cpp:

(JSC::DFG::Plan::compileInThreadImpl):

  • dfg/DFGPureValue.cpp: Added.

(JSC::DFG::PureValue::dump):

  • dfg/DFGPureValue.h: Added.

(JSC::DFG::PureValue::PureValue):
(JSC::DFG::PureValue::operator!):
(JSC::DFG::PureValue::op):
(JSC::DFG::PureValue::children):
(JSC::DFG::PureValue::info):
(JSC::DFG::PureValue::hash):
(JSC::DFG::PureValue::operator==):
(JSC::DFG::PureValue::isHashTableDeletedValue):
(JSC::DFG::PureValueHash::hash):
(JSC::DFG::PureValueHash::equal):

  • dfg/DFGSSAConversionPhase.cpp:

(JSC::DFG::SSAConversionPhase::run):

  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::lower):

LayoutTests:

  • js/regress/gcse-expected.txt: Added.
  • js/regress/gcse-poly-get-expected.txt: Added.
  • js/regress/gcse-poly-get-less-obvious-expected.txt: Added.
  • js/regress/gcse-poly-get-less-obvious.html: Added.
  • js/regress/gcse-poly-get.html: Added.
  • js/regress/gcse.html: Added.
  • js/regress/script-tests/gcse-poly-get-less-obvious.js: Added.
  • js/regress/script-tests/gcse-poly-get.js: Added.
  • js/regress/script-tests/gcse.js: Added.
7:59 AM Changeset in webkit [171105] by Antti Koivisto
  • 3 edits
    2 adds in trunk

REGRESSION (r155957): Invalid cast in WebCore::RenderNamedFlowThread::getRanges
​https://bugs.webkit.org/show_bug.cgi?id=134888

Reviewed by Mihnea Ovidenie.

Source/WebCore:
Test: fast/regions/flowthread-getranges-box-cast.html

  • rendering/RenderNamedFlowThread.cpp:

(WebCore::RenderNamedFlowThread::getRanges): Test the type before casting.

LayoutTests:

  • fast/regions/flowthread-getranges-box-cast-expected.txt: Added.
  • fast/regions/flowthread-getranges-box-cast.html: Added.
3:49 AM Changeset in webkit [171104] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Buildfix if LLINT_SLOW_PATH_TRACING is enabled
​https://bugs.webkit.org/show_bug.cgi?id=133790

Patch by Eva Balazsfalvi <​evab.u-szeged@partner.samsung.com> on 2014-07-15
Reviewed by Mark Lam.

  • llint/LLIntSlowPaths.cpp:

(JSC::LLInt::LLINT_SLOW_PATH_DECL):

2:34 AM Changeset in webkit [171103] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[GTK] Update GObject DOM bindings symbols file after r171014.
​https://bugs.webkit.org/show_bug.cgi?id=134907

Patch by Carlos Alberto Lopez Perez <​clopez@igalia.com> on 2014-07-15
Reviewed by Philippe Normand.

  • bindings/gobject/webkitdom.symbols: Update to the current API.
2:15 AM Changeset in webkit [171102] by Manuel Rego Casasnovas
  • 2 edits in trunk/Source/WebCore

Unreviwed fix wrong indentation from r171082.

  • rendering/RenderGrid.cpp:

(WebCore::RenderGrid::placeAutoMajorAxisItemOnGrid):

Jul 14, 2014:

8:04 PM Changeset in webkit [171101] by akling@apple.com
  • 2 edits in trunk/Source/WebKit2

[iOS] Don't progressively re-render tiles while pinch-zooming under memory pressure.
<​https://webkit.org/b/134915>

When we're under memory pressure, the last thing we want to be doing is
creating gratuitous new IOSurfaces. Just wait for the gesture to end before
rendering at the new scale.

Reviewed by Tim Horton.

  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::updateVisibleContentRects):

7:55 PM Changeset in webkit [171100] by Alan Bujtas
  • 3 edits
    2 adds in trunk

Subpixel rendering: Zero sized compositing container's content positioned off by one device pixel.
​https://bugs.webkit.org/show_bug.cgi?id=134903

Reviewed by Simon Fraser.

The compositing layer boundaries are calculated using its renderer()'s and the renderer()'s
descendants' bounds. However when the renderer() is zero sized, its bounds are omitted.
In such cases, when the child content has offset from the renderer(), the subpixel adjustment
of the compositing layer becomes negative (-meaning that the compositing layer is to the right/bottom
direction from its renderer()). Remove fabs() to be able to express such direction.

Source/WebCore:
Test: compositing/hidpi-compositing-layer-with-zero-sized-container.html

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateGeometry):

LayoutTests:

  • compositing/hidpi-compositing-layer-with-zero-sized-container-expected.html: Added.
  • compositing/hidpi-compositing-layer-with-zero-sized-container.html: Added.
7:15 PM Changeset in webkit [171099] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix crash on WebVideoFullscreenManagerProxy construction.
​https://bugs.webkit.org/show_bug.cgi?id=134909

Unreviewed fix crash from r171089

Remove unnecessary dispatch to main queue since it can happen during construction.

Patch by Jeremy Jones <​jeremyj@apple.com> on 2014-07-14

  • platform/ios/WebVideoFullscreenInterfaceAVKit.mm:

(WebVideoFullscreenInterfaceAVKit::setWebVideoFullscreenModel): remove dispatch_async

6:52 PM Changeset in webkit [171098] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Cocoa] _WKRemoteObjectInterface leaks NSString ivar
​https://bugs.webkit.org/show_bug.cgi?id=134914

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-07-14
Reviewed by Simon Fraser.

Release our copied NSString in dealloc.

  • Shared/API/Cocoa/_WKRemoteObjectInterface.mm:

(-[_WKRemoteObjectInterface dealloc]):

6:37 PM Changeset in webkit [171097] by dino@apple.com
  • 1 edit
    4 adds in trunk/LayoutTests

Provide some large JPEG images with EXIF orientation for subsampling tests
​https://bugs.webkit.org/show_bug.cgi?id=134847

Reviewed by Sam Weinig.

Four images (either 3000x2000 or 2000x3000) that each have EXIF rotation
attributes that should render with an arrow pointing UP. The
orientation-rotate-0.jpg should always render correctly, even if EXIF
rotation is ignored. The others are variations on that image that were
saved in rotated form, then reverted to the correct orientation via EXIF.

  • fast/canvas/resources/orientation-rotate-0.jpg: Added.
  • fast/canvas/resources/orientation-rotate-180.jpg: Added.
  • fast/canvas/resources/orientation-rotate-90-ccw.jpg: Added.
  • fast/canvas/resources/orientation-rotate-90-cw.jpg: Added.
5:41 PM Changeset in webkit [171096] by fpizlo@apple.com
  • 29 edits
    19 adds in trunk/Source/JavaScriptCore

Allow for Int52Rep to see things other than Int32, and make this testable
​https://bugs.webkit.org/show_bug.cgi?id=134873
<rdar://problem/17641915>

Reviewed by Geoffrey Garen and Mark Hahnenberg.

A major premise of our type inference is that prediction propagation can say whatever it
wants and we'll still have valid IR after Fixup. This previously didn't work with Int52s.
We required some kind of agreement between prediction propagation and fixup over which
data flow paths were Int52 and which weren't.

It turns out that we basically had such an agreement, with the exception of code that was
unreachable due to ForceOSRExit. Then, fixup and prediction propagation would disagree. It
might be nice to fix that bug - but it's only in the case of Int52 that such a thing would
be a bug! Normally, we allow sloppiness in prediction propagation.

This patch allows us to be sloppy with Int52 prediction propagation by giving Int52Rep the
ability to see inputs other than Int32. This fixes the particular ForceOSRExit bug (see
int52-force-osr-exit-path.js for the reduced test case). To make sure that the newly
empowered Int52Rep is actually correct - in case we end up using it on paths other than
ForceOSRExit - this patch introduces an internal intrinsic called fiatInt52() that forces
us to attempt Int52 conversion on the input. This patch adds a bunch of tests that stress
this intrinsic. This means that we're now stressing Int52Rep more so than ever before!

Note that it would still be a bug for prediction propagation to ever cause us to create an
Int52Rep node for a non-Int32 input. But, this will now be a performance bug, rather than
a crash bug.

  • dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

  • dfg/DFGAbstractValue.cpp:

(JSC::DFG::AbstractValue::fixTypeForRepresentation):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleIntrinsic):

  • dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):
(JSC::DFG::FixupPhase::injectTypeConversionsForEdge):

  • dfg/DFGGraph.h:

(JSC::DFG::Graph::isMachineIntConstant):

  • dfg/DFGNode.h:

(JSC::DFG::Node::isMachineIntConstant):

  • dfg/DFGNodeType.h:
  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:
  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):

  • dfg/DFGSafeToExecute.h:

(JSC::DFG::SafeToExecuteEdge::operator()):
(JSC::DFG::safeToExecute):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::speculate):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::callOperation):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):
(JSC::DFG::SpeculativeJIT::convertMachineInt):
(JSC::DFG::SpeculativeJIT::speculateMachineInt):
(JSC::DFG::SpeculativeJIT::speculateDoubleRepMachineInt):

  • dfg/DFGStrengthReductionPhase.cpp:

(JSC::DFG::StrengthReductionPhase::handleNode):

  • dfg/DFGUseKind.cpp:

(WTF::printInternal):

  • dfg/DFGUseKind.h:

(JSC::DFG::typeFilterFor):
(JSC::DFG::isNumerical):
(JSC::DFG::isDouble):

  • dfg/DFGValidate.cpp:

(JSC::DFG::Validate::validate):

  • ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

  • ftl/FTLIntrinsicRepository.h:
  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileInt52Rep):
(JSC::FTL::LowerDFGToLLVM::doubleToInt32):
(JSC::FTL::LowerDFGToLLVM::jsValueToDouble):
(JSC::FTL::LowerDFGToLLVM::jsValueToStrictInt52):
(JSC::FTL::LowerDFGToLLVM::doubleToStrictInt52):
(JSC::FTL::LowerDFGToLLVM::speculate):
(JSC::FTL::LowerDFGToLLVM::speculateMachineInt):
(JSC::FTL::LowerDFGToLLVM::speculateDoubleRepMachineInt):

  • jit/JITOperations.h:
  • jsc.cpp:

(GlobalObject::finishCreation):
(functionIdentity):

  • runtime/Intrinsic.h:
  • runtime/JSCJSValue.h:
  • runtime/JSCJSValueInlines.h:

(JSC::tryConvertToInt52):
(JSC::isInt52):
(JSC::JSValue::isMachineInt):

  • tests/stress/dead-fiat-double-to-int52-then-exit-not-int52.js: Added.

(foo):

  • tests/stress/dead-fiat-double-to-int52.js: Added.

(foo):

  • tests/stress/dead-fiat-int32-to-int52.js: Added.

(foo):

  • tests/stress/dead-fiat-value-to-int52-double-path.js: Added.

(foo):
(bar):

  • tests/stress/dead-fiat-value-to-int52-then-exit-not-double.js: Added.

(foo):
(bar):

  • tests/stress/dead-fiat-value-to-int52-then-exit-not-int52.js: Added.

(foo):
(bar):

  • tests/stress/dead-fiat-value-to-int52.js: Added.

(foo):
(bar):

  • tests/stress/fiat-double-to-int52-then-exit-not-int52.js: Added.

(foo):

  • tests/stress/fiat-double-to-int52-then-fail-to-fold.js: Added.

(foo):

  • tests/stress/fiat-double-to-int52-then-fold.js: Added.

(foo):

  • tests/stress/fiat-double-to-int52.js: Added.

(foo):

  • tests/stress/fiat-int32-to-int52.js: Added.

(foo):

  • tests/stress/fiat-value-to-int52-double-path.js: Added.

(foo):
(bar):

  • tests/stress/fiat-value-to-int52-then-exit-not-double.js: Added.

(foo):
(bar):

  • tests/stress/fiat-value-to-int52-then-exit-not-int52.js: Added.

(foo):
(bar):

  • tests/stress/fiat-value-to-int52-then-fail-to-fold.js: Added.

(foo):

  • tests/stress/fiat-value-to-int52-then-fold.js: Added.

(foo):

  • tests/stress/fiat-value-to-int52.js: Added.

(foo):
(bar):

  • tests/stress/int52-force-osr-exit-path.js: Added.

(foo):

5:14 PM Changeset in webkit [171095] by dino@apple.com
  • 2 edits in trunk/Source/WebKit2

[PlugIns] Check for a non-null snapshot image before trying to decode it
​https://bugs.webkit.org/show_bug.cgi?id=134913
<rdar://problem/17606033>

Reviewed by Tim Horton.

Changeset r169820 introduced a bug where we could examine the pixels of
an image (looking for solid colors) before checking if the image actually
existed.

I added a null check, and moved the code around a bit to avoid checking
for existence three times.

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::pluginSnapshotTimerFired): Check that snapshotImage exists
before trying to look at it.

5:14 PM Changeset in webkit [171094] by dbates@webkit.org
  • 2 edits
    6 adds in trunk

[iOS] Add tests to ensure CSS :active and :hover are applied when processing touch events
​https://bugs.webkit.org/show_bug.cgi?id=134905
<rdar://problem/16602779>

Reviewed by Simon Fraser.

.:
Add a manual test to ensure that styles for CSS pseudo-class :hover aren't temporarily cleared
on the tapped element when processing a touchend as a result of finger pressing and releasing
on the same element that is initially positioned outside the visible content area.

  • ManualTests/ios/touchstart-touchend-on-same-element-should-not-clear-hover.html: Added.

LayoutTests:
Upstream tests by Andreas Kling for <rdar://problem/14324231>.

Add a DRT test to ensure that we apply the style for the CSS pseudo-class :active when
processing touch events.

  • platform/iphone-simulator/fast/events/ontouchstart-active-selector-expected.txt: Added.
  • platform/iphone-simulator/fast/events/ontouchstart-active-selector.html: Added.
5:09 PM Changeset in webkit [171093] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix 32-bit build.

  • UIProcess/Cocoa/SessionStateCoding.mm:

(WebKit::encodeSessionState):

4:59 PM Changeset in webkit [171092] by mhahnenberg@apple.com
  • 4 edits
    1 add in trunk/Source/JavaScriptCore

Flattening dictionaries with oversize backing stores can cause crashes
​https://bugs.webkit.org/show_bug.cgi?id=134906

Reviewed by Filip Pizlo.

The collector expects any pointers into CopiedSpace passed to copyLater are within 32 KB
of the CopiedBlock header. This was always the case except for when flattening a dictionary
caused the size of the Butterfly to decrease. This was equivalent to moving the base of the
Butterfly to higher addresses. If the object was reduced sufficiently in size, the base
would no longer be within the first 32 KB of the CopiedBlock and the next collection would
choke on the Butterfly pointer.

This patch fixes this issue by detect this situation during flattening and memmove-ing
the Butterfly down to where the old base was.

  • runtime/JSObject.cpp:

(JSC::JSObject::shiftButterflyAfterFlattening):

  • runtime/JSObject.h:

(JSC::JSObject::butterflyPreCapacity):
(JSC::JSObject::butterflyTotalSize):

  • runtime/Structure.cpp:

(JSC::Structure::flattenDictionaryStructure):

  • tests/stress/flatten-oversize-dictionary-object.js: Added.

(foo):

4:35 PM Changeset in webkit [171091] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Use the legacy session coder for encoding/decoding session state
​https://bugs.webkit.org/show_bug.cgi?id=134910

Reviewed by Beth Dakin.

  • UIProcess/Cocoa/SessionStateCoding.mm:

(WebKit::encodeSessionState):
(WebKit::decodeSessionState):

4:13 PM Changeset in webkit [171090] by oliver@apple.com
  • 2 edits in trunk/Source/WebKit2

Restrict network process to remote connections
​https://bugs.webkit.org/show_bug.cgi?id=134908

Reviewed by Geoffrey Garen.

Further restrict network client

  • Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb:
3:32 PM Changeset in webkit [171089] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

WebVideoFullscreenInterfaceAVKit should only call the UI from main thread.
​https://bugs.webkit.org/show_bug.cgi?id=134890

Patch by Jeremy Jones <​jeremyj@apple.com> on 2014-07-14
Reviewed by Eric Carlson.

dispatch_async to the main thread before setting properties that would affect the UI.

  • platform/ios/WebVideoFullscreenInterfaceAVKit.mm:

(WebVideoFullscreenInterfaceAVKit::setWebVideoFullscreenModel): wrap in call to dispatch_async
(WebVideoFullscreenInterfaceAVKit::setDuration): ditto
(WebVideoFullscreenInterfaceAVKit::setCurrentTime): ditto
(WebVideoFullscreenInterfaceAVKit::setRate): ditto
(WebVideoFullscreenInterfaceAVKit::setVideoDimensions): ditto
(WebVideoFullscreenInterfaceAVKit::setSeekableRanges): ditto
(WebVideoFullscreenInterfaceAVKit::setAudioMediaSelectionOptions): ditto
(WebVideoFullscreenInterfaceAVKit::setLegibleMediaSelectionOptions): ditto
(WebVideoFullscreenInterfaceAVKit::setExternalPlayback): ditto

3:22 PM Changeset in webkit [171088] by dbates@webkit.org
  • 3 edits in trunk/Tools

check-webkit-style should apply C++ rules to Objective-C++ files
​https://bugs.webkit.org/show_bug.cgi?id=134884

Reviewed by Joseph Pecoraro.

Fixes an issue where check-webkit-style doesn't apply applicable C++ rules to
Objective-C++ files.

Currently check-webkit-style doesn't apply the following rules to Objective-C++
files: build/using_std, runtime/max_min_macros, runtime/wtf_move, readability/null.
Instead, we should teach check-webkit-style to apply these rules because, as
its name implies, an Objective-C++ file may contain C++ code.

  • Scripts/webkitpy/style/checkers/cpp.py:

(_FileState.init): Add instance variable _is_objective_cpp to track whether a file has
extension mm (i.e. an Objective-C++ file).
(_FileState.is_objective_c_or_objective_cpp): Added; returns true if the file
has extension m or mm or if the file has extension h and contains Objective-C directives.
(check_for_null): No change in behavior; don't apply rule to Objective-C++ file.
(check_identifier_name_in_declaration): Substitute _FileState.is_objective_c_or_objective_cpp() for
_FileState.is_c_or_objective_c()

  • Scripts/webkitpy/style/checkers/cpp_unittest.py:

(WebKitStyleTest.test_null_false_zero): Added test case for Objective-C++ file.
(WebKitStyleTest.test_max_macro): Add test case for Objective-C and Objective-C++ file.
(WebKitStyleTest.test_min_macro): Ditto.
(WebKitStyleTest.test_wtf_move): Add test case for Objective-C++ file.

3:00 PM Changeset in webkit [171087] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit2

ASSERT(isMainThread()) under OneShotDisplayLinkHandler
​https://bugs.webkit.org/show_bug.cgi?id=134900

Reviewed by Simon Fraser.

  • UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.mm:

(-[OneShotDisplayLinkHandler displayLinkFired:]):
isMainThread means the Web thread sometimes.

2:57 PM Changeset in webkit [171086] by timothy_horton@apple.com
  • 3 edits in trunk/Source/WebKit2

Fix the build.

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _frameOrBoundsChanged]):
(-[WKWebView _beginAnimatedResizeWithUpdates:]):

  • UIProcess/API/ios/WKViewIOS.mm:

(-[WKView _frameOrBoundsChanged]):

2:42 PM Changeset in webkit [171085] by Lucas Forschler
  • 10 edits in tags/Safari-538.46.2/Source/WebKit2

Merged r171057. <rdar://problem/17295636>

2:37 PM Changeset in webkit [171084] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[UNIX] Log error description when failing to create shared memory file.
​https://bugs.webkit.org/show_bug.cgi?id=134892

Patch by Carlos Alberto Lopez Perez <​clopez@igalia.com> on 2014-07-14
Reviewed by Darin Adler.

  • Platform/unix/SharedMemoryUnix.cpp:

(WebKit::SharedMemory::create): Print the string describing the error number (errno).

2:29 PM Changeset in webkit [171083] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Fix the !ENABLE(FILTERS) && !ENABLE(CSS_FILTERS) build after r167497
​https://bugs.webkit.org/show_bug.cgi?id=134679

Patch by Tibor Meszaros <​tmeszaros.u-szeged@partner.samsung.com> on 2014-07-14
Reviewed by Darin Adler.

  • html/ImageData.cpp:
  • platform/graphics/cairo/ImageBufferCairo.cpp:
2:23 PM Changeset in webkit [171082] by Manuel Rego Casasnovas
  • 14 edits
    2 adds in trunk

[CSS Grid Layout] Support sparse in auto-placement algorithm
​https://bugs.webkit.org/show_bug.cgi?id=134544

Reviewed by Sergio Villar Senin.

Source/WebCore:
This patch implements sparse mode for auto-placement algorithm, which is
the default mode in the new grid-auto-flow syntax. It keeps track of the
auto-placement cursor in
RenderGrid::placeAutoMajorAxisItemsOnGrid() and updates it accordingly
when auto-positioned items are placed.
If we're in dense mode it resets the cursor after each item (which keeps
the old behavior that was using dense mode by default).

GridIterator has been adapted to look for empty areas from a given
position in both directions.

Test: fast/css-grid-layout/grid-auto-flow-sparse.html

  • rendering/RenderGrid.cpp:

(WebCore::RenderGrid::GridIterator::GridIterator): Modify constructor to
add an optional argument for the varying index. This allows to look for
empty areas in both axis.
(WebCore::RenderGrid::placeAutoMajorAxisItemsOnGrid): Defined the
auto-placement cursor and rested after each item if we're in dense mode.
(WebCore::RenderGrid::placeAutoMajorAxisItemOnGrid): Use auto-placement
cursor to look for empty areas from the last auto-positioned item
placed.

  • rendering/RenderGrid.h: Modify placeAutoMajorAxisItemOnGrid() header

to receive the auto-placement cursor.

LayoutTests:
Test cases have been adapted accordingly, adding new cases to cover both
sparse and dense options.

  • fast/css-grid-layout/grid-auto-flow-resolution-expected.txt:
  • fast/css-grid-layout/grid-auto-flow-resolution.html:
  • fast/css-grid-layout/grid-auto-flow-sparse-expected.txt: Added.
  • fast/css-grid-layout/grid-auto-flow-sparse.html: Added.
  • fast/css-grid-layout/grid-container-change-named-grid-lines-recompute-child.html:
  • fast/css-grid-layout/grid-item-auto-placement-automatic-span-expected.txt:
  • fast/css-grid-layout/grid-item-auto-placement-automatic-span.html:
  • fast/css-grid-layout/grid-item-auto-placement-definite-span-expected.txt:
  • fast/css-grid-layout/grid-item-auto-placement-definite-span.html:
  • fast/css-grid-layout/grid-item-removal-auto-placement-update.html:
  • fast/css-grid-layout/named-grid-lines-with-named-grid-areas-resolution.html:
  • fast/css-grid-layout/resources/grid.css:

(.autoRowAutoColumnSpanning2):
(.autoRowSpanning2AutoColumn):
(.autoRowSpanning2AutoColumnSpanning3):
(.autoRowSpanning3AutoColumnSpanning2):
(.gridAutoFlowColumnDense):
(.gridAutoFlowRowDense):

2:22 PM Changeset in webkit [171081] by Brent Fulgham
  • 8 edits in trunk/Source/WebCore

[iOS] Some videos play as inline audio-only content
​https://bugs.webkit.org/show_bug.cgi?id=134898.
<rdar://problem/17629379>

Reviewed by Eric Carlson.

Add a new 'presentationType' accessor that indicates if the media
element is playing in 'audio' mode. This can happen if a video
element plays an HLS stream that starts off in audio-only mode.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::presentationType): Added.

  • html/HTMLMediaElement.h:
  • platform/audio/MediaSession.cpp:

(WebCore::MediaSession::presentationType): Added.

  • platform/audio/MediaSession.h:
  • platform/audio/MediaSessionManager.cpp:

(WebCore::MediaSessionManager::sessionRestrictsInlineVideoPlayback):
Use the presentationType, rather than the mediaType to control
inline playback behavior.

  • platform/audio/ios/AudioDestinationIOS.h:

(WebCore::AudioDestinationMac::presentationType): Add presentationType.

  • platform/audio/mac/AudioDestinationMac.h:

(WebCore::AudioDestinationMac::presentationType): Ditto.

2:07 PM Changeset in webkit [171080] by benjamin@webkit.org
  • 5 edits in trunk/Source/WebKit2

[iOS][WK2] On rotation, RemoteLayerTreeDrawingArea renders one extra frame at the wrong orientation
​https://bugs.webkit.org/show_bug.cgi?id=134875

Reviewed by Tim Horton.

On animated resize, the size of the DrawingAreaProxy was changed before the layout parameters were
changed. This in turn caused the WebProcess's DrawingArea to flush the layer tree while still
at the wrong orientation.

This patch fixes the issue by making a special case for animated resize:
-While starting animated resize, _frameOrBoundsChanged can be called several times in response to

the API's client changing the WKWebView. In that case, we do not update the drawing area.

-After the "updateBlock" is executed and the size have been changed, the dynamic viewport update

is computed, the dynamicViewportSizeUpdate is sent to the WebProcess, followed by the message
DrawingArea::updateGeometry(). Since both messages are asynchronous, they are received in that
order, and the updateGeometry() is always done after the viewport configuration has been updated.

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _frameOrBoundsChanged]):
(-[WKWebView _beginAnimatedResizeWithUpdates:]):

  • UIProcess/ios/WKContentView.h:
  • UIProcess/ios/WKContentView.mm:

(-[WKContentView setMinimumSize:]): Deleted.

2:06 PM Changeset in webkit [171079] by Lucas Forschler
  • 5 edits in tags/Safari-538.46.2/Source

Versioning.

2:02 PM Changeset in webkit [171078] by benjamin@webkit.org
  • 3 edits in trunk/Source/WebKit2

[iOS][WK2] Fix withinEpsilon()
​https://bugs.webkit.org/show_bug.cgi?id=134798

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2014-07-14
Reviewed by Darin Adler.

Move the function back to WKWebView, it is no longer needed in WKContentView.

Use the real types as input to properly verify that the two inputs are within
a small value of the 32bit floating point.

The epsilon we use is always on 32 bits float because we want to avoid doing work for changes
that would not make any difference on float.

The source of those small changes comes from the fact UIProcess does a lot of processing
on CGFloat, which are double on 64bits architecture, while the WebProcess use 32bits floating point
for scale. When we are getting updates from the WebProcess, we should ignore any small differences
caused by the computations done with less precision.

  • UIProcess/API/Cocoa/WKWebView.mm:

(withinEpsilon):

  • UIProcess/ios/WKContentViewInteraction.h:

(withinEpsilon): Deleted.

2:01 PM Changeset in webkit [171077] by Lucas Forschler
  • 1 copy in tags/Safari-538.46.2

New Tag.

1:55 PM Changeset in webkit [171076] by benjamin@webkit.org
  • 4 edits in trunk/Source/JavaScriptCore

Remove some dead code from FTLJITFinalizer
​https://bugs.webkit.org/show_bug.cgi?id=134874

Reviewed by Geoffrey Garen.

Not sure what that code was for...but it does not do anything :)

  • ftl/FTLJITFinalizer.cpp:

(JSC::FTL::JITFinalizer::finalizeFunction):
The pointer of the label is computed but never used.

  • ftl/FTLJITFinalizer.h:
  • ftl/FTLLink.cpp:

(JSC::FTL::link):
The label is never set to anything.

1:12 PM Changeset in webkit [171075] by betravis@adobe.com
  • 10 edits in trunk

[Feature Queries] Enable Feature Queries on Mac
​https://bugs.webkit.org/show_bug.cgi?id=134404

Reviewed by Antti Koivisto.

Source/JavaScriptCore:
Enable Feature Queries on Mac and resume running the
feature tests.

  • Configurations/FeatureDefines.xcconfig: Turn on

ENABLE_CSS3_CONDITIONAL_RULES.

Source/WebCore:
Enable Feature Queries on Mac and resume running the
feature tests.

  • Configurations/FeatureDefines.xcconfig: Turn on

ENABLE_CSS3_CONDITIONAL_RULES.

Source/WebKit/mac:
Enable Feature Queries on Mac and resume running the
feature tests.

  • Configurations/FeatureDefines.xcconfig: Turn on

ENABLE_CSS3_CONDITIONAL_RULES.

Source/WebKit2:
Enable Feature Queries on Mac and resume running the
feature tests.

  • Configurations/FeatureDefines.xcconfig: Turn on

ENABLE_CSS3_CONDITIONAL_RULES.

LayoutTests:
Resume running the Feature Queries tests on Mac.

  • platform/mac/TestExpectations: Unskip the tests.
12:51 PM Changeset in webkit [171074] by hyatt@apple.com
  • 3 edits in trunk/Source/WebCore

<rdar://problem/17305458> Cannot interact with video controls in ePubs
Bug 134836 - [New Multicolumn] Crawl to check for compositing between us and the enclosingPaginationLayer
​https://bugs.webkit.org/show_bug.cgi?id=134836

Reviewed by Dean Jackson.

The paginatedAndComposited bit being set in updateLayerPositions just didn't work, since compositing states
can change without triggering that function. This patch just gets rid of the bit and does a crawl every time
to check. This ensures that changes in compositing states don't necessitate any changes in pagination,
since the lookup will always check the current compositing state.

The new function that does this check is hasCompositedLayerInEnclosingPaginationChain.

I have been unable to reproduce this issue, and this is therefore a purely speculative fix. I have no test
case to provide because of this.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::RenderLayer):
(WebCore::RenderLayer::updateLayerPositions):
(WebCore::RenderLayer::hasCompositedLayerInEnclosingPaginationChain):
(WebCore::RenderLayer::updatePagination):

  • rendering/RenderLayer.h:
12:15 PM Changeset in webkit [171073] by Alan Bujtas
  • 4 edits in trunk/Source/WebCore

Move composite bounds calculation to RenderLayerBacking.
​https://bugs.webkit.org/show_bug.cgi?id=134864

Reviewed by Darin Adler.

No change in functionality.

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateCompositedBounds):

  • rendering/RenderLayerCompositor.cpp: it was just proxying the calculateLayerBounds()

to the RenderLayer.
(WebCore::RenderLayerCompositor::calculateCompositedBounds): Deleted.

  • rendering/RenderLayerCompositor.h:
12:14 PM Changeset in webkit [171072] by andersca@apple.com
  • 6 edits in trunk

Make shouldKeepCurrentBackForwardListItemInList part of WKPageLoaderClientV5 to avoid breaking ABI
​https://bugs.webkit.org/show_bug.cgi?id=134889

Reviewed by Beth Dakin.

Source/WebKit2:

  • UIProcess/API/C/WKPage.cpp:
  • UIProcess/API/C/WKPageLoaderClient.h:

Tools:
Bump loader version number to 5.

  • TestWebKitAPI/Tests/WebKit2/ShouldKeepCurrentBackForwardListItemInList.cpp:

(TestWebKitAPI::setPageLoaderClient):

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::createWebViewWithOptions):

11:54 AM Changeset in webkit [171071] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebCore

Fix the build.

  • platform/audio/MediaSessionManager.h:
11:31 AM Changeset in webkit [171070] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit2

REGRESSION (r171045): Reproducible crash on navigation in PageClientImpl::willRecordNavigationSnapshot
​https://bugs.webkit.org/show_bug.cgi?id=134887

Reviewed by Tim Horton.

  • UIProcess/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::navigationGestureDidBegin): nil-check m_webView. It can be nil when
the client is using WKView directly.
(WebKit::PageClientImpl::navigationGestureWillEnd): Ditto.
(WebKit::PageClientImpl::navigationGestureDidEnd): Ditto.
(WebKit::PageClientImpl::willRecordNavigationSnapshot): Ditto.

11:17 AM Changeset in webkit [171069] by eric.carlson@apple.com
  • 16 edits
    1 delete in trunk/Source

[Mac] don't enable low power audio mode on external output devices
​https://bugs.webkit.org/show_bug.cgi?id=134877

Reviewed by Sam Weinig.

Source/WebCore:
No new tests, this deals with changes to the audio hardware at runtime.

  • WebCore.xcodeproj/project.pbxproj: Remove AudioSessionListener.h.
  • WebCore.vcxproj/WebCore.vcxproj: Ditto.
  • platform/audio/AudioHardwareListener.cpp:

(WebCore::AudioHardwareListener::AudioHardwareListener): Initialize m_outputDeviceSupportsLowPowerMode

to true on iOS.

  • platform/audio/AudioHardwareListener.h:

(WebCore::AudioHardwareListener::outputDeviceSupportsLowPowerMode): New accessor.
(WebCore::AudioHardwareListener::setHardwareActivity): New setter for derived classes.
(WebCore::AudioHardwareListener::setOutputDeviceSupportsLowPowerMode): Ditto.

Remove AudioSessionListener interface, it wasn't being used.

  • platform/audio/AudioSession.cpp:

(WebCore::AudioSession::addListener): Deleted.
(WebCore::AudioSession::removeListener): Deleted.
(WebCore::AudioSession::beganAudioInterruption): Deleted.
(WebCore::AudioSession::endedAudioInterruption): Deleted.

  • platform/audio/AudioSession.h:
  • platform/audio/AudioSessionListener.h: Removed.
  • platform/audio/MediaSessionManager.cpp:

(WebCore::MediaSessionManager::addSession): Allocate the AudioHardwareListener if necessary.
(WebCore::MediaSessionManager::removeSession): Free the AudioHardwareListener if necessary.
(WebCore::MediaSessionManager::audioOutputDeviceChanged): AudioHardwareListener client interface

called when the output device changes, call updateSessionState to make sure we are using
the correct buffer size.

  • platform/audio/MediaSessionManager.h:
  • platform/audio/ios/AudioDestinationIOS.h:
  • platform/audio/ios/AudioSessionIOS.mm:

(WebCore::AudioSessionPrivate::AudioSessionPrivate): Drive-by cleanup, remove ObjC helper object

that was used to listen for OS notifications, it is no longer used.

(SOFT_LINK_POINTER): Deleted.
(-[WebAudioSessionHelper initWithCallback:]): Deleted.
(-[WebAudioSessionHelper dealloc]): Deleted.
(-[WebAudioSessionHelper interruption:]): Deleted.

  • platform/audio/mac/AudioHardwareListenerMac.cpp:

(WebCore::currentDeviceSupportsLowPowerBufferSize): New, return true only if using build-in

transport device.

(WebCore::processIsRunningPropertyDescriptor): Return reference to static AudioObjectPropertyAddress

for kAudioHardwarePropertyProcessIsRunning instead of declaring one in every method
that needs one.

(WebCore::outputDevicePropertyDescriptor): Return reference to static AudioObjectPropertyAddress

for kAudioHardwarePropertyDefaultOutputDevice.

(WebCore::AudioHardwareListenerMac::AudioHardwareListenerMac): Restructure and add audio object

listener for default output device.

(WebCore::AudioHardwareListenerMac::~AudioHardwareListenerMac): *Remove* listener audio object

property listener instead of *Adding* a new one. Remove new listener.

(WebCore::AudioHardwareListenerMac::propertyChanged): Enumerate the properties that changed,

call appropriate method.

(WebCore::AudioHardwareListenerMac::processIsRunningChanged): Renamed from setHardwareActive,

cleanup.

(WebCore::AudioHardwareListenerMac::outputDeviceChanged): New, call client.audioHardwareOutputDeviceChanged.
(WebCore::AudioHardwareListenerMac::setHardwareActive): Deleted, renamed processIsRunningChanged.

  • platform/audio/mac/AudioHardwareListenerMac.h:
  • platform/audio/mac/MediaSessionManagerMac.cpp:

(MediaSessionManager::updateSessionState): Only set the output buffer size to 4K when hardware

supports it.

Source/WebKit2:

  • PluginProcess/PluginProcess.h: Add an empty implementation of

AudioHardwareListener::audioOutputDeviceChanged.

11:11 AM Changeset in webkit [171068] by timothy_horton@apple.com
  • 3 edits in trunk/Source/WebKit2

[iOS] Throttle painting using a UI-process-side CADisplayLink
​https://bugs.webkit.org/show_bug.cgi?id=134879
<rdar://problem/17641699>

Reviewed by Simon Fraser.

Just waiting for CA to commit is insufficient to actually throttle to 60fps,
because nothing will block the main runloop from spinning.

Instead, listen to a CADisplayLink, and send didUpdate to the WebProcess
the first time it fires after we commit. This is not a guarantee that
our content is on the screen, but we don't have any way to make that guarantee yet.

This will throttle painting, rAF, etc. to the display refresh rate.

  • UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.h:
  • UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.mm:

(-[OneShotDisplayLinkHandler initWithDrawingAreaProxy:]):
(-[OneShotDisplayLinkHandler dealloc]):
(-[OneShotDisplayLinkHandler displayLinkFired:]):
(-[OneShotDisplayLinkHandler invalidate]):
(-[OneShotDisplayLinkHandler schedule]):
(WebKit::RemoteLayerTreeDrawingAreaProxy::RemoteLayerTreeDrawingAreaProxy):
(WebKit::RemoteLayerTreeDrawingAreaProxy::~RemoteLayerTreeDrawingAreaProxy):
(WebKit::RemoteLayerTreeDrawingAreaProxy::commitLayerTree):
(WebKit::RemoteLayerTreeDrawingAreaProxy::didRefreshDisplay):
(WebKit::RemoteLayerTreeDrawingAreaProxy::coreAnimationDidCommitLayers): Deleted.

10:16 AM Changeset in webkit [171067] by Bruno de Oliveira Abinader
  • 3 edits
    2 adds in trunk/LayoutTests

[css3-text] Add editing test for CSS3 Text Decoration properties
​https://bugs.webkit.org/show_bug.cgi?id=120114

Reviewed by Darin Adler.

Adds editing layout test to verify that CSS3 Text Decoration properties
are being properly propagated.

  • editing/pasteboard/insert-text-decoration-expected.txt: Added.
  • editing/pasteboard/insert-text-decoration.html: Added.
  • platform/mac/TestExpectations: Skip while CSS3_TEXT is disabled by default.
  • platform/win/TestExpectations: Skip while CSS3_TEXT is disabled by default.
9:17 AM Changeset in webkit [171066] by mitz@apple.com
  • 6 edits in trunk/Source/WebKit2

<rdar://problem/17657391> [iOS] Networking process writes persistent credentials to the keychain
​https://bugs.webkit.org/show_bug.cgi?id=134878

Reviewed by Sam Weinig.

Route CFNetwork’s calls to Security API through to the UI process.

  • NetworkProcess/ios/NetworkProcessIOS.mm:

(WebKit::NetworkProcess::platformInitializeNetworkProcess): Initialize SecItemShim.

  • Shared/mac/SecItemShim.cpp:

(WebKit::SecItemShim::initialize): On iOS, rather than using a shim library, supply
CFNetwork with alternate functions to call.

  • Shared/mac/SecItemShim.messages.in: Removed #if !PLATFORM(IOS).
  • UIProcess/mac/SecItemShimProxy.messages.in: Ditto.
  • config.h: Define ENABLE_SEC_ITEM_SHIM to 1 on iOS as well.
9:16 AM Changeset in webkit [171065] by dbates@webkit.org
  • 3 edits in trunk/Tools

Teach check-webkit-style to suggest WTF::move() when it sees std::move()
​https://bugs.webkit.org/show_bug.cgi?id=134620

Reviewed by Joseph Pecoraro.

  • Scripts/webkitpy/style/checkers/cpp.py:

(check_max_min_macros): Fix up comment so that it reads well.
(check_wtf_move): Added.
(check_style): Modified to call check_wtf_move().
(CppChecker): Add category "runtime/wtf_move".

  • Scripts/webkitpy/style/checkers/cpp_unittest.py:

(WebKitStyleTest.test_wtf_move): Added.

3:56 AM Changeset in webkit [171064] by jinwoo7.song@samsung.com
  • 22 edits
    3 adds in trunk/LayoutTests

[EFL] Unreviewed EFL gardening.

Rebaseline tests after r170418 and r170433.

  • platform/efl/fast/regions/repaint/japanese-rl-selection-repaint-in-regions-expected.png: Added. Rebaseline after r170418.
  • platform/efl/fast/regions/repaint/japanese-rl-selection-repaint-in-regions-expected.txt: Rebaseline after r170418.
  • platform/efl/fast/text/decorations-with-text-combine-expected.png: Rebaseline after r170418.
  • platform/efl/fast/text/decorations-with-text-combine-expected.txt: Rebaseline after r170418.
  • platform/efl/fast/text/emphasis-vertical-expected.png: Rebaseline after r170418.
  • platform/efl/fast/text/emphasis-vertical-expected.txt: Rebaseline after r170418.
  • platform/efl/fast/text/international/002-expected.png: Rebaseline after r170418.
  • platform/efl/fast/text/international/002-expected.txt: Rebaseline after r170418.
  • platform/efl/fast/text/international/text-combine-image-test-expected.png: Rebaseline after r170418.
  • platform/efl/fast/text/international/text-combine-image-test-expected.txt: Rebaseline after r170418.
  • platform/efl/fast/text/international/wrap-CJK-001-expected.png: Rebaseline after r170418.
  • platform/efl/fast/writing-mode/border-vertical-lr-expected.png: Rebaseline after r170418.
  • platform/efl/fast/writing-mode/border-vertical-lr-expected.txt: Rebaseline after r170418.
  • platform/efl/fast/writing-mode/japanese-lr-selection-expected.png: Rebaseline after r170418.
  • platform/efl/fast/writing-mode/japanese-lr-selection-expected.txt: Rebaseline after r170418.
  • platform/efl/fast/writing-mode/japanese-lr-text-expected.png: Rebaseline after r170418.
  • platform/efl/fast/writing-mode/japanese-lr-text-expected.txt: Rebaseline after r170418.
  • platform/efl/fast/writing-mode/japanese-rl-selection-expected.png: Rebaseline after r170418.
  • platform/efl/fast/writing-mode/japanese-rl-selection-expected.txt: Rebaseline after r170418.
  • platform/efl/fast/writing-mode/japanese-rl-text-expected.png: Rebaseline after r170418.
  • platform/efl/fast/writing-mode/japanese-rl-text-expected.txt: Rebaseline after r170418.
  • platform/efl/svg/W3C-SVG-1.1/filters-blend-01-b-expected.png: Rebaseline after r170433.
  • platform/efl/svg/W3C-SVG-1.1/filters-blend-01-b-expected.txt: Added. Rebaseline after r170433.
  • platform/efl/svg/filters/feBlend-all-blendmodes-expected.txt: Added. Rebaseline after r170433.
3:25 AM Changeset in webkit [171063] by jinwoo7.song@samsung.com
  • 2 edits in trunk/LayoutTests

[EFL] Unreviewed EFL gardening.

Remove failure expectations for tests that have been passing after r168350, r169309 and r169620.

  • platform/efl/TestExpectations:
3:07 AM Changeset in webkit [171062] by jinwoo7.song@samsung.com
  • 3 edits in trunk/LayoutTests

[EFL] Unreviewed EFL gardening.

  • platform/efl/css1/formatting_model/inline_elements-expected.png: Rebaseline after r170875.
  • platform/efl/css1/formatting_model/inline_elements-expected.txt: Rebaseline after r170875.
12:19 AM Changeset in webkit [171061] by mitz@apple.com
  • 1 edit in trunk/Source/WebKit2/ChangeLog

Added Radar link to the last ChangeLog entry

12:18 AM Changeset in webkit [171060] by mitz@apple.com
  • 4 edits in trunk/Source/WebKit2

NetworkProcess sometimes hangs under copyDefaultCredentialForProtectionSpace
​https://bugs.webkit.org/show_bug.cgi?id=134666

Reviewed by Tim Horton.

A SecItem may have an attribute whose value is a SecAccessControlRef, which is not supported
by ArgumentCodersCF. In debug builds, trying to encode a CFDictionary containing a value of
unsupprted type causes an assertion to fail, but in release builds encoding succeeds, and
only decoding fails, in this case silently, simply not delivering the
SecItemShim::secItemResponse message.

The fix is to teach ArgumentCodersCF about SecAccessControlRef.

  • Shared/cf/ArgumentCodersCF.cpp:

(IPC::typeFromCFTypeRef): Check for the SecAccessControlRef type.
(IPC::encode): Encode the SecAccessControl serialized into CFData.
(IPC::decode): Deserialize a SecAccessControl from the decoded CFData.

  • Shared/cf/ArgumentCodersCF.h:
  • config.h: Defined HAVE_SEC_ACCESS_CONTROL.
Note: See TracTimeline for information about the timeline view.