Timeline
Jul 16, 2014:
- 9:07 PM Changeset in webkit [171172] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: TextContentView calls the wrong super function in shown()
https://bugs.webkit.org/show_bug.cgi?id=135001
Patch by Saam Barati <sbarati@apple.com> on 2014-07-16
Reviewed by Timothy Hatcher.
TextContentView calls ResourceContentView.shown instead of ContentView.shown.
It should call ContentView.shown because ContentView is its prototype.
- UserInterface/Views/TextContentView.js:
(WebInspector.TextContentView.prototype.shown):
- 8:31 PM Changeset in webkit [171171] by
-
- 3 edits in trunk/Source/WebKit2
Reintroduce the SPI _websiteDataURLForContainerWithURL: that was removed in r171160
https://bugs.webkit.org/show_bug.cgi?id=134984
Reviewed by David Kilzer.
- UIProcess/API/Cocoa/WKProcessPool.mm:
(+[WKProcessPool _websiteDataURLForContainerWithURL:]):
- UIProcess/API/Cocoa/WKProcessPoolPrivate.h:
- 8:04 PM Changeset in webkit [171170] by
-
- 5 edits in trunk/Source
Versioning.
- 7:52 PM Changeset in webkit [171169] by
-
- 3 edits1 add in trunk/LayoutTests
[GTK] Unreviewed GTK gardening.
- platform/gtk/TestExpectations: Report and mark new failures. Update some expectations.
- platform/gtk/http/tests/w3c/webperf/approved/navigation-timing/html/test_timing_xserver_redirect-expected.txt: Rebaseline after r171033.
- platform/gtk/svg/W3C-SVG-1.1/shapes-rect-02-t-expected.txt: Added. Rebaseline after r171046.
- 7:50 PM Changeset in webkit [171168] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening. Skip some text track tests that fail only on release wk1 builds.
- platform/mac-wk1/TestExpectations:
- 7:31 PM WebKitGTK/KeepingTheTreeGreen edited by
- (diff)
- 7:28 PM WebKitGTK/KeepingTheTreeGreen edited by
- (diff)
- 7:26 PM Changeset in webkit [171167] by
-
- 6 edits in trunk
A test that hangs at cleanup stage confuses webkitpy hugely
https://bugs.webkit.org/show_bug.cgi?id=122475
<rdar://problem/17184354>
Reviewed by Anders Carlsson.
Source/WebKit2:
Reset m_pageLoadState when the process exits cleanly - otherwise messages from a
new process for the same WebPageProxy would hit assertions.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::processDidCrash):
(WebKit::WebPageProxy::resetStateAfterProcessExited):
Tools:
Terminate WebContent process if it freezes between tests. Ideally, we should report
this somehow, but this is better than blaming the wrong test.
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::terminateWebContentProcess):
- WebKitTestRunner/TestController.h:
- WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::invoke):
- 6:59 PM Changeset in webkit [171166] by
-
- 2 edits in trunk/LayoutTests
Unreviewed. Skip in-band text track test on Mountain Lion.
- platform/mac/TestExpectations:
In-band text tracks not supported on ML.
- 6:47 PM Changeset in webkit [171165] by
-
- 3 edits2 adds in trunk
Subpixel rendering: Adjust cliprect with devicePixelFractionFromRenderer() before painting.
https://bugs.webkit.org/show_bug.cgi?id=134950
<rdar://problem/17617994>
Reviewed by Simon Fraser.
The cliprect coming from the graphics layer needs to be adjusted with the subpixel gap
from renderer. This is symmetric with the offsetting we do, when the dirty rect is sent off to the GraphicsLayer.
It puts us back to the correct coordinating system for intersecting with renderers.
Source/WebCore:
Test: compositing/hidpi-compositing-layer-with-tile-layers-on-subpixel-position.html
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::beginTransparencyLayers):
(WebCore::RenderLayer::clipToRect):
LayoutTests:
- compositing/hidpi-compositing-layer-with-tile-layers-on-subpixel-position-expected.html: Added.
- compositing/hidpi-compositing-layer-with-tile-layers-on-subpixel-position.html: Added.
- 6:38 PM Changeset in webkit [171164] by
-
- 4 edits in trunk/Source
[iOS] Update order file paths for WebKit and WebKit2
<http://webkit.org/b/134993>
<rdar://problem/17557776>
Reviewed by Darin Adler.
Source/WebKit/mac:
- Configurations/Base.xcconfig: Rename WebKit.order to
WebKitLegacy.order.
Source/WebKit2:
- Configurations/Base.xcconfig: Add order file for iOS
named WebKit.order.
- 6:10 PM Changeset in webkit [171163] by
-
- 2 edits in trunk/Source/WebCore
Fix a typo noticed by Darin.
- rendering/RenderBox.cpp:
(WebCore::shouldApplyContainersClipAndOffset):
(WebCore::RenderBox::computeRectForRepaint):
(WebCore::shouldAppyContainersClipAndOffset): Deleted.
- 6:04 PM Changeset in webkit [171162] by
-
- 2 edits in trunk/Source/WebCore
Improve showTree() logging
https://bugs.webkit.org/show_bug.cgi?id=134997
Reviewed by Tim Horton.
Have the debug showTree(), which dumps the Node/Element tree, show which nodes need
style recalc, and print element renderers.
- dom/Node.cpp:
(WebCore::Node::showNode):
- 6:04 PM Changeset in webkit [171161] by
-
- 3 edits in trunk/Source/WebCore
[iOS] Expose the points on WebEventRegion
https://bugs.webkit.org/show_bug.cgi?id=134978
Reviewed by Tim Horton.
Expose WebEventRegion's points so that UIKit can get at them.
- page/ios/WebEventRegion.h:
- page/ios/WebEventRegion.mm:
(-[WebEventRegion p1]):
(-[WebEventRegion p2]):
(-[WebEventRegion p3]):
(-[WebEventRegion p4]):
- 5:20 PM Changeset in webkit [171160] by
-
- 13 edits in trunk/Source
Add WebSecurityOrigin "webSecurityOriginFromDatabaseIdentifier" SPI and change _websiteDataURLForContainerWithURL: SPI
Source/WebCore:
https://bugs.webkit.org/show_bug.cgi?id=134984
Reviewed by Dan Bernstein.
- WebCore.exp.in:
- page/SecurityOrigin.cpp:
(WebCore::SecurityOrigin::maybeCreateFromDatabaseIdentifier): Add a form of createFromDatabaseIdentifier
that can fail and return a nullptr.
(WebCore::SecurityOrigin::createFromDatabaseIdentifier): Use maybeCreateFromDatabaseIdentifier before creating
the empty origin.
- page/SecurityOrigin.h:
Source/WebKit/mac:
<rdar://problem/17454712> and https://bugs.webkit.org/show_bug.cgi?id=134984
Reviewed by Dan Bernstein.
- WebCoreSupport/WebSecurityOrigin.mm:
(+[WebSecurityOrigin webSecurityOriginFromDatabaseIdentifier:]): Added.
(-[WebSecurityOrigin initWithURL:]): Update using RefPtr API to avoid a ref().
- WebCoreSupport/WebSecurityOriginPrivate.h:
Source/WebKit2:
<rdar://problem/17454712> and https://bugs.webkit.org/show_bug.cgi?id=134984
Reviewed by Dan Bernstein.
Change _websiteDataURLForContainerWithURL: SPI to include an optional bundle identifier argument:
- UIProcess/API/Cocoa/WKProcessPool.mm:
(+[WKProcessPool _websiteDataURLForContainerWithURL:bundleIdentifierIfNotInContainer:]):
(+[WKProcessPool _websiteDataURLForContainerWithURL:]): Deleted.
- UIProcess/API/Cocoa/WKProcessPoolPrivate.h:
Add a big shiny comment in a few key places:
- DatabaseProcess/DatabaseProcess.cpp:
(WebKit::DatabaseProcess::initializeDatabaseProcess):
- DatabaseProcess/IndexedDB/UniqueIDBDatabase.cpp:
(WebKit::UniqueIDBDatabase::UniqueIDBDatabase):
- UIProcess/WebContext.cpp:
(WebKit::WebContext::applyPlatformSpecificConfigurationDefaults):
(WebKit::WebContext::ensureDatabaseProcess):
- 5:00 PM Changeset in webkit [171159] by
-
- 3 edits in trunk/Source/WebKit2
REGRESSION (iOS WebKit2): Cannot scroll while dragging a selection.
https://bugs.webkit.org/show_bug.cgi?id=134992
<rdar://problem/17528020>
Reviewed by Benjamin Poulain.
This patch exposes the scroller and the visible content rect so that
UIKit can implement autoscroll when dragging the selections.
It also changes that way we do hit testing to allow hit test outside
the clipping region and fixes the way we compute the selection rectangle
for the block selection, ensuring that we consider also non text elements
like images.
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView scroller]):
(-[WKContentView visibleRect]):
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::selectionBoxForRange):
(WebKit::WebPage::rangeForWebSelectionAtPosition):
(WebKit::WebPage::rangeForBlockAtPoint):
(WebKit::WebPage::expandedRangeFromHandle):
(WebKit::WebPage::contractedRangeFromHandle):
(WebKit::WebPage::computeExpandAndShrinkThresholdsForHandle):
(WebKit::WebPage::changeBlockSelection):
- 4:34 PM Changeset in webkit [171158] by
-
- 6 edits5 adds3 deletes in trunk
Captions container should not clip content.
https://bugs.webkit.org/show_bug.cgi?id=134840.
<rdar://problem/14553608>.
Reviewed by Simon Fraser.
Tests: media/track/track-in-band-subtitles-too-large.html
media/track/track-long-word-container-sizing.html
- Modules/mediacontrols/mediaControlsApple.css:
(video::-webkit-media-text-track-container):
Set word break property of WebCTT cues to normal to make it consistent with in-band cues.
- html/track/TextTrackCueGeneric.cpp:
(WebCore::TextTrackCueGenericBoxElement::applyCSSProperties):
Set -webkit-min-content on min-width/min-height property of the text track display.
- html/track/VTTCue.cpp:
(WebCore::VTTCueBox::applyCSSProperties):
Do the same for WebVTT cues.
- media/track/track-cue-rendering-snap-to-lines-not-set-expected.txt: Rebaseline.
- media/track/captions-webvtt/long-word-small-track-display.vtt: Added.
- media/track/track-in-band-subtitles-too-large-expected.txt: Added.
- media/track/track-in-band-subtitles-too-large.html: Added.
- media/track/track-long-word-container-sizing-expected.txt: Added.
- media/track/track-long-word-container-sizing.html: Added.
We no longer break in the middle of a word, this test is no longer useful.
- media/track/captions-webvtt/long-word.vtt: Removed.
- media/track/track-word-breaking-expected.txt: Removed.
- media/track/track-word-breaking.html: Removed.
- 4:11 PM Changeset in webkit [171157] by
-
- 3 edits in trunk/Source/WebCore
[Mac] replace AVPlayerItem on the main thread
https://bugs.webkit.org/show_bug.cgi?id=134983
Reviewed by Jer Noble.
No new tests, this fixes a problem with a thread configuration not present in the
test environment.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::setAVPlayerItem): New, when called off of
the main thread, dispatch to the main thread before setting AVPlayerItem.
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayer): Call setAVPlayerItem.
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerItem): Ditto.
(WebCore::MediaPlayerPrivateAVFoundationObjC::setShouldBufferData): Ditto.
- 4:08 PM Changeset in webkit [171156] by
-
- 2 edits in trunk/Source/WebKit2
<rdar://problem/17669097> REGRESSION (r170155): Sandbox violations using a wrong
CFNetwork cache path in WebContent process
Rubber-stamped by Sam Weinig.
Before r170155, we incorrectly checked usesNetworkProcess(), which always returns
false at this point in initialization sequence. But we did the right thing, as we
always need to set the cache path, even when network process is used for most loading.
- WebProcess/cocoa/WebProcessCocoa.mm: (WebKit::WebProcess::platformInitializeWebProcess):
- 3:36 PM Changeset in webkit [171155] by
-
- 2 edits in trunk/Source/WebKit2
Dispatch top content inset changes immediately if synchronously waiting for view state changes
https://bugs.webkit.org/show_bug.cgi?id=134942
<rdar://problem/17666800>
Reviewed by Simon Fraser.
- UIProcess/API/mac/WKView.mm:
(-[WKView _dispatchSetTopContentInset]):
(-[WKView _setTopContentInset:]):
Move the check from _setTopContentInset: to _dispatchSetTopContentInset
that ensures that we only send the message if the top content inset changed.
- 3:26 PM Changeset in webkit [171154] by
-
- 14 edits in trunk/Source/WebKit2
[iOS][WK2] Synchronize the dynamic viewport updates with their layer tree commit
https://bugs.webkit.org/show_bug.cgi?id=134965
Related to <rdar://problem/17082607>
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-07-16
Reviewed by Tim Horton.
Dynamic viewport update relies on the _resizeAnimationTransformAdjustments being applied
to the page at the new size during the transition.
Because of the races between the LayerTree Commit and DynamicViewportSizeUpdate, the transform
can be applied to the wrong set of tiles.
This is mostly a problem for unresponsive WebProcess or when the synchronization is done
immediately.
There is at least one more case that is not handled: if synchronizeDynamicViewportUpdate()
completely fails to get the new page, the UIProcess is in a somewhat messy state.
I will look into that separately than the layer tree synchronization.
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _didCommitLayerTree:]):
(-[WKWebView _dynamicViewportUpdateChangedTargetToScale:position:nextValidLayerTreeTransactionID:]):
(-[WKWebView _dynamicViewportUpdateChangedTargetToScale:position:]): Deleted.
- UIProcess/API/Cocoa/WKWebViewInternal.h:
- UIProcess/PageClient.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::resetState):
- UIProcess/WebPageProxy.h:
- UIProcess/ios/PageClientImplIOS.h:
- UIProcess/ios/PageClientImplIOS.mm:
(WebKit::PageClientImpl::dynamicViewportUpdateChangedTarget):
- UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::WebPageProxy::dynamicViewportSizeUpdate):
(WebKit::WebPageProxy::synchronizeDynamicViewportUpdate):
(WebKit::WebPageProxy::didCommitLayerTree):
(WebKit::WebPageProxy::dynamicViewportUpdateChangedTarget):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
(WebKit::WebPage::didCommitLoad):
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in:
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::synchronizeDynamicViewportUpdate):
(WebKit::WebPage::updateVisibleContentRects):
- WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h:
(WebKit::RemoteLayerTreeDrawingArea::nextTransactionID):
(WebKit::RemoteLayerTreeDrawingArea::currentTransactionID): Deleted.
- 2:33 PM Changeset in webkit [171153] by
-
- 3 edits in branches/ftlopt/Source/JavaScriptCore
[ftlopt] Constant fold GetGetter and GetSetter if the GetterSetter is a constant
https://bugs.webkit.org/show_bug.cgi?id=134962
Reviewed by Oliver Hunt.
This removes yet another steady-state-throughput implication of using getters and setters:
if your accessor call is monomorphic then you'll just get a structure check, nothing more.
No more loads to get to the GetterSetter object or the accessor function object.
- dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):
- runtime/GetterSetter.h:
(JSC::GetterSetter::getterConcurrently):
(JSC::GetterSetter::setGetter):
(JSC::GetterSetter::setterConcurrently):
(JSC::GetterSetter::setSetter):
- 2:31 PM Changeset in webkit [171152] by
-
- 3 edits in branches/ftlopt/Source/JavaScriptCore
[ftlopt] Identity replacement in CSE shouldn't create a Phantom over the Identity's children
https://bugs.webkit.org/show_bug.cgi?id=134893
Reviewed by Oliver Hunt.
Replace Identity with Check instead of Phantom. Phantom means that the child of the
Identity should be unconditionally live. The liveness semantics of Identity are such that
if the parents of Identity are live then the child is live. Removing the Identity entirely
preserves such liveness semantics. So, the only thing that should be left behind is the
type check on the child, which is what Check means: do the check but don't keep the child
alive if the check isn't needed.
- dfg/DFGCSEPhase.cpp:
- dfg/DFGNode.h:
(JSC::DFG::Node::convertToCheck):
- 1:51 PM Changeset in webkit [171151] by
-
- 5 edits in trunk/Source/WebCore
[MSE] http/tests/media/media-source/mediasource-buffered.html is flakey
https://bugs.webkit.org/show_bug.cgi?id=134949
Reviewed by Eric Carlson.
Depending on which SourceBuffer is successfully parsed first, the order of activeSourceBuffers
may change from run to run, breaking the http/tests/media/media-source/mediasource-buffered.html
test. Make the order of activeSourceBuffers the same as (a subset of) sourceBuffers, by replacing
calls to activeSourceBuffers->add() and with a new call to regenerateActiveSourceBuffers(), which
swaps the contents of the SourceBufferList with a new, ordered Vector.
- Modules/mediasource/MediaSource.cpp:
(WebCore::MediaSource::addSourceBuffer):
(WebCore::MediaSource::sourceBufferDidChangeAcitveState):
(WebCore::MediaSource::regenerateActiveSourceBuffers):
- Modules/mediasource/MediaSource.h:
- Modules/mediasource/SourceBufferList.cpp:
(WebCore::SourceBufferList::swap):
- Modules/mediasource/SourceBufferList.h:
- 1:31 PM Changeset in webkit [171150] by
-
- 5 edits10 deletes in trunk
CSP: Drop 'script-nonce' directive.
https://bugs.webkit.org/show_bug.cgi?id=134926
Reviewed by Darin Adler.
Source/WebCore:
This patch drops the outdated 'script-nonce' Content Security
Policy directive. It was removed from the spec, and replaced in
CSP2 with a new 'script-src' syntax. We should implement that
instead.
Until then, removing the outdated syntax will ensure that no one
ends up relying on it in WebKit's implementation.
This should have limited web-visible impact, as the feature is
behind the CSP_NEXT flag, which is not enabled by default.
- dom/ScriptElement.cpp:
(WebCore::ScriptElement::requestScript):
(WebCore::ScriptElement::executeScript):
- page/ContentSecurityPolicy.cpp:
(WebCore::CSPDirectiveList::allowJavaScriptURLs):
(WebCore::CSPDirectiveList::allowInlineEventHandlers):
(WebCore::CSPDirectiveList::addDirective):
(WebCore::NonceDirective::NonceDirective): Deleted.
(WebCore::NonceDirective::allows): Deleted.
(WebCore::NonceDirective::parse): Deleted.
(WebCore::CSPDirectiveList::checkNonce): Deleted.
(WebCore::CSPDirectiveList::checkNonceAndReportViolation): Deleted.
(WebCore::CSPDirectiveList::allowScriptNonce): Deleted.
(WebCore::isAllowedByAllWithNonce): Deleted.
(WebCore::ContentSecurityPolicy::allowScriptNonce): Deleted.
(WebCore::ContentSecurityPolicy::reportInvalidNonce): Deleted.
- page/ContentSecurityPolicy.h:
LayoutTests:
Dropping the nonce tests, as we're removing the functionality.
- http/tests/security/contentSecurityPolicy/1.1/scriptnonce-allowed-expected.txt: Removed.
- http/tests/security/contentSecurityPolicy/1.1/scriptnonce-allowed.html: Removed.
- http/tests/security/contentSecurityPolicy/1.1/scriptnonce-blocked-expected.txt: Removed.
- http/tests/security/contentSecurityPolicy/1.1/scriptnonce-blocked.html: Removed.
- http/tests/security/contentSecurityPolicy/1.1/scriptnonce-invalidnonce-expected.txt: Removed.
- http/tests/security/contentSecurityPolicy/1.1/scriptnonce-invalidnonce.html: Removed.
- http/tests/security/contentSecurityPolicy/1.1/scriptnonce-scriptsrc-blocked-expected.txt: Removed.
- http/tests/security/contentSecurityPolicy/1.1/scriptnonce-scriptsrc-blocked.html: Removed.
- http/tests/security/contentSecurityPolicy/1.1/scriptnonce-separators-allowed-expected.txt: Removed.
- http/tests/security/contentSecurityPolicy/1.1/scriptnonce-separators-allowed.html: Removed.
- 12:10 PM Changeset in webkit [171149] by
-
- 3 edits in trunk/Source/WebCore
REGRESSION(r171069) 75% repro crash in WebCore::AudioHardwareListenerMac::processIsRunningChanged()
https://bugs.webkit.org/show_bug.cgi?id=134986
Reviewed by Eric Carlson.
Add a WeakPtrFactory to AudioHardwareListenerMac, so that if CoreAudio calls our block after
being unregistered, we can bail early instead of calling into a deleted object.
- platform/audio/mac/AudioHardwareListenerMac.cpp:
(WebCore::AudioHardwareListenerMac::AudioHardwareListenerMac):
- platform/audio/mac/AudioHardwareListenerMac.h:
- 11:05 AM Changeset in webkit [171148] by
-
- 5 edits in trunk
[MSE] REGRESSION(r171033): ASSERT in WebCore::MediaSource::onReadyStateChange()
https://bugs.webkit.org/show_bug.cgi?id=134941
Reviewed by Eric Carlson.
Source/WebCore:
Only do our modified-order change of the readyState if the error parameter is empty,
as that's the only case where a duration change will cause an inadvertant readyState
change.
- Modules/mediasource/MediaSource.cpp:
(WebCore::MediaSource::streamEndedWithError):
LayoutTests:
Update media/media-source/media-source-end-of-stream.html to use an empty parameter, rather
than an empty string parameter, to endOfStream().
- media/media-source/media-source-end-of-stream-expected.txt:
- media/media-source/media-source-end-of-stream.html:
- 9:51 AM WebKitGTK/KeepingTheTreeGreen edited by
- (diff)
- 9:42 AM Changeset in webkit [171147] by
-
- 3 edits in trunk/Source/WebCore
Remove svn:executable property erroneously added in <http://trac.webkit.org/changeset/171144> somehow.
- ChangeLog: Removed property svn:executable.
- svg/SVGSVGElement.h: Removed property svn:executable.
- svg/animation/SVGSMILElement.h: Removed property svn:executable.
- 9:33 AM Changeset in webkit [171146] by
-
- 2 edits in trunk/Source/WebKit2
REGRESSION (r170653): Web Content service’s Info.plist has wrong format
https://bugs.webkit.org/show_bug.cgi?id=134973
Reviewed by Alexey Proskuryakov.
- WebKit2.xcodeproj/project.pbxproj: Updated the Add CFBundle Localization Info.plist Key
script build phases to convert Info.plist back to binary format if the
PLIST_FILE_OUTPUT_FORMAT build setting requires it.
- 8:38 AM Changeset in webkit [171145] by
-
- 2 edits in trunk/Source/WebCore
Substitute CGRectZero for NSZeroRect in -[DOMNode hrefFrame].
Rubber-stamped by Zalan Bujtas.
The method -[DOMNode hrefFrame] returns a CGRect. So, when we don't have a renderer
we should return CGRectZero instead of a NSZeroRect.
- bindings/objc/DOM.mm:
(-[DOMNode hrefFrame]): Also, fix up some code style issues.
- 8:03 AM Changeset in webkit [171144] by
-
- 3 edits in trunk/Source/WebCore
mutable pointers from const methods, timeContainer().
https://bugs.webkit.org/show_bug.cgi?id=134757
Patch by Jeongeun Kim <je_julie.kim@samsung.com> on 2014-07-16
Reviewed by Alexey Proskuryakov.
Avoid return mutable pointers from const methods.
No new tests, no behavior change.
- svg/SVGSVGElement.h:
- svg/animation/SVGSMILElement.h:
(WebCore::SVGSMILElement::timeContainer):
- 7:47 AM WebKitGTK/KeepingTheTreeGreen edited by
- (diff)
- 5:24 AM Changeset in webkit [171143] by
-
- 11 edits3 adds in trunk/LayoutTests
[EFL] Unreviewed EFL gardening.
Rebaseline tests after r168575, r170138 and r170418.
- platform/efl/fast/dynamic/text-combine-expected.png: Rebaseline after r170418.
- platform/efl/fast/dynamic/text-combine-expected.txt: Rebaseline after r170418.
- platform/efl/fast/forms/control-restrict-line-height-expected.png: Rebaseline after r168575.
- platform/efl/fast/forms/control-restrict-line-height-expected.txt: Rebaseline after r168575.
- platform/efl/fast/forms/placeholder-position-expected.png: Rebaseline after r168575.
- platform/efl/fast/forms/placeholder-position-expected.txt: Rebaseline after r168575.
- platform/efl/fast/repaint/japanese-rl-selection-clear-expected.png: Rebaseline after r170418.
- platform/efl/fast/repaint/japanese-rl-selection-clear-expected.txt: Added. Rebaseline after r170418.
- platform/efl/fast/repaint/japanese-rl-selection-repaint-expected.png: Rebaseline after r170418.
- platform/efl/fast/repaint/japanese-rl-selection-repaint-expected.txt: Added. Rebaseline after r170418.
- platform/efl/fast/text/international/wrap-CJK-001-expected.txt: Added. Rebaseline after r170418.
- platform/efl/fast/writing-mode/Kusa-Makura-background-canvas-expected.png: Rebaseline after r170418.
- platform/efl/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt: Rebaseline after r170418.
- 4:20 AM Changeset in webkit [171142] by
-
- 2 edits in trunk/Tools
Change style check path with EFL WK2's path in checker_unittest.py
https://bugs.webkit.org/show_bug.cgi?id=134967
Reviewed by Csaba Osztrogonác.
- Scripts/webkitpy/style/checker_unittest.py: Change ewk_view.h path.
(GlobalVariablesTest.test_path_rules_specifier):
- 3:26 AM Changeset in webkit [171141] by
-
- 2 edits in trunk/Tools
Unreviewed. Added myself to the list of committers.
- Scripts/webkitpy/common/config/contributors.json:
- 2:48 AM Changeset in webkit [171140] by
-
- 3 edits in trunk/LayoutTests
[EFL] Unreviewed EFL gardening after r170138.
- platform/efl/accessibility/image-map2-expected.txt: Updated.
- platform/efl/inspector-protocol/dom/getAccessibilityPropertiesForNode-expected.txt: Updated.
Jul 15, 2014:
- 11:04 PM Changeset in webkit [171139] by
-
- 2 edits in trunk
[CMAKE] ENABLE_ENCRYPTED_MEDIA_V2 should depend on ENABLE_VIDEO
https://bugs.webkit.org/show_bug.cgi?id=134963
Reviewed by Gyuyoung Kim.
ENCRYPTED_MEDIA_V2 requires VIDEO enabled.
- Source/cmake/WebKitFeatures.cmake: Added the dependency for ENABLE_ENCRYPTED_MEDIA_V2.
- 9:44 PM Changeset in webkit [171138] by
-
- 7 edits in trunk/Source/WebCore
CSS: Generalize CSS First Letter treatment
https://bugs.webkit.org/show_bug.cgi?id=134936
Reviewed by Benjamin Poulain.
first-letter pseudo element rule is handled differently from the other rules
such as first-line. This patch removes this special handling in SelectorChecker
and handles it in RulesFeatureSet.
- css/RuleFeature.cpp:
(WebCore::RuleFeatureSet::collectFeaturesFromSelector):
(WebCore::RuleFeatureSet::add):
(WebCore::RuleFeatureSet::clear):
- css/RuleFeature.h:
(WebCore::RuleFeatureSet::RuleFeatureSet):
- css/SelectorChecker.cpp:
(WebCore::SelectorChecker::matchRecursively):
- css/StyleResolver.h:
(WebCore::StyleResolver::usesFirstLetterRules):
- dom/DocumentStyleSheetCollection.cpp:
(WebCore::DocumentStyleSheetCollection::combineCSSFeatureFlags):
(WebCore::DocumentStyleSheetCollection::resetCSSFeatureFlags):
- dom/DocumentStyleSheetCollection.h:
(WebCore::DocumentStyleSheetCollection::setUsesFirstLetterRules): Deleted.
- 9:33 PM Changeset in webkit [171137] by
-
- 2 edits in trunk/Tools
[EFL] Remove EFL WK1 directory from the checker.py
https://bugs.webkit.org/show_bug.cgi?id=134954
Reviewed by Gyuyoung Kim.
- Scripts/webkitpy/style/checker.py:
- 9:31 PM Changeset in webkit [171136] by
-
- 2 edits in trunk/Tools
Adding myself to contributors.json breaks a webkitpy test
https://bugs.webkit.org/show_bug.cgi?id=134958
Reviewed by Ryosuke Niwa.
- Scripts/webkitpy/tool/bot/irc_command_unittest.py:
(IRCCommandTest.test_whois): Be more specific and include also the
first name when asking for the whois of Xan in the unit test.
- 8:56 PM Changeset in webkit [171135] by
-
- 2 edits in trunk/Source/WebKit2
Fix r171124
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-07-15
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _scrollToContentOffset:]):
On landing, I changed the min/max branches to shrunkTo/expandedTo, but the return value
of those was ignored.
- 8:07 PM Changeset in webkit [171134] by
-
- 25 edits2 copies in trunk/Source/WebInspectorUI
Web Inspector: Modernize UI styles and better sync with platform styles
https://bugs.webkit.org/show_bug.cgi?id=134846
Reviewed by Timothy Hatcher.
Updated styles to better match the OS UI design. Updated the forward/back button.
Moved several rules to selectors that support older OS designs. Added global platform
data to support this patch.
- UserInterface/Images/BackArrow.svg: Added.
- UserInterface/Images/BackArrowLegacy.svg: Copied from Source/WebInspectorUI/UserInterface/Images/BackArrow.svg.
- UserInterface/Images/ForwardArrow.svg: Added.
- UserInterface/Images/ForwardArrowLegacy.svg: Copied from Source/WebInspectorUI/UserInterface/Images/ForwardArrow.svg.
- UserInterface/Base/ImageUtilities.js: Updated image version
(.generateImage.generateModernImage):
(.generateImage.generateLegacyImage):
(.generateImage):
Updated image generation to support modern look. Updated versioning scheme and version.
- UserInterface/Base/Main.js:
(WebInspector.loaded):
(WebInspector.contentLoaded.WebInspector.Platform.version.toString):
(WebInspector.contentLoaded.WebInspector.Platform.toString):
(WebInspector.contentLoaded):
Added global platform information.
- UserInterface/Views/ContentBrowser.js:
(WebInspector.ContentBrowser):
Updated back and forward buttons.
- UserInterface/Views/FindBanner.js:
(WebInspector.FindBanner.prototype._generateButtonsGlyphsIfNeeded):
Updated images for the find banner.
- WebInspectorUI.vcxproj/WebInspectorUI.vcxproj:
- WebInspectorUI.vcxproj/WebInspectorUI.vcxproj.filters:
Added new images.
- UserInterface/Views/ButtonToolbarItem.css:
(.toolbar .item.button > .label):
(body.mac-platform.legacy .toolbar .item.button > .label):
- UserInterface/Views/CSSStyleDeclarationSection.css:
(.style-declaration-section):
(body.mac-platform.legacy .style-declaration-section):
(body.mac-platform.legacy .style-declaration-section + .style-declaration-section):
(.style-declaration-section.last-in-group):
(body.mac-platform.legacy .style-declaration-section.last-in-group):
(.style-declaration-section.last-in-group + .style-declaration-section):
(body.mac-platform.legacy .style-declaration-section.last-in-group + .style-declaration-section):
(body.mac-platform.legacy .style-declaration-section.last-in-group + .style-declaration-section:last-child):
(.style-declaration-section + .style-declaration-section): Deleted.
(.style-declaration-section.last-in-group + .style-declaration-section:last-child): Deleted.
- UserInterface/Views/CSSStyleDetailsSidebarPanel.css:
(.sidebar > .panel.details.css-style > .content > .pseudo-classes):
- UserInterface/Views/DOMTreeOutline.css:
(.dom-tree-outline li.hovered:not(.selected) .selection):
(body.mac-platform.legacy .dom-tree-outline li.hovered:not(.selected) .selection):
(.dom-tree-outline li.elements-drag-over .selection):
(body.mac-platform.legacy .dom-tree-outline li.elements-drag-over .selection):
(.dom-tree-outline:focus li.selected .selection):
(body.mac-platform.legacy .dom-tree-outline:focus li.selected .selection):
- UserInterface/Views/DashboardContainerView.css:
(.toolbar .dashboard-container):
(body.mac-platform.legacy .toolbar .dashboard-container):
(body.window-inactive .toolbar .dashboard-container):
(body.mac-platform.legacy.window-inactive .toolbar .dashboard-container):
(.toolbar .dashboard):
(body.window-inactive .toolbar .dashboard):
(body.mac-platform.legacy.window-inactive .toolbar .dashboard):
- UserInterface/Views/DataGrid.css:
(.data-grid th):
(body.mac-platform.legacy .data-grid th):
(.data-grid tr.selected):
(body.mac-platform.legacy .data-grid tr.selected):
(.data-grid:focus tr.selected):
(body.mac-platform.legacy .data-grid:focus tr.selected):
- UserInterface/Views/DetailsSection.css:
(.details-section):
(body.mac-platform.legacy .details-section):
(.details-section .details-section):
(body.mac-platform.legacy .details-section .details-section):
(.details-section .details-section:last-child):
(.details-section .details-section:first-child):
(.details-section > .header):
(body.mac-platform.legacy .details-section > .header):
(.details-section .details-section > .header):
(body.mac-platform.mountain-lion .details-section .details-section > .header):
(.details-section .details-section.collaspsed > .header):
(.details-section.computed-style-properties:not(.collapsed) > .header):
(body.mac-platform.legacy .details-section.computed-style-properties:not(.collapsed) > .header):
(.details-section > .content > .group):
(body.mac-platform.legacy .details-section > .content > .group):
(.details-section > .content > .group:last-child):
(.details-section > .content > .group:nth-child(even)):
(body.mac-platform.legacy .details-section > .content > .group:nth-child(even)):
(body.mac-platform.legacy .details-section > .content > .group:last-child > .row.simple:last-child > *):
(.details-section > .content > .group:last-child > .row.simple:last-child > *): Deleted.
- UserInterface/Views/FilterBar.css:
(.filter-bar > input[type="search"]):
(body.mac-platform.legacy .filter-bar > input[type="search"]):
- UserInterface/Views/NavigationSidebarPanel.css:
(.navigation-sidebar-panel-content-tree-outline .item.selected):
(body.mac-platform.legacy .navigation-sidebar-panel-content-tree-outline .item.selected):
(.navigation-sidebar-panel-content-tree-outline:focus .item.selected):
(body.mac-platform.legacy .navigation-sidebar-panel-content-tree-outline:focus .item.selected):
(body.window-inactive .navigation-sidebar-panel-content-tree-outline .item.selected):
(body.mac-platform.legacy.window-inactive .navigation-sidebar-panel-content-tree-outline .item.selected):
- UserInterface/Views/RadioButtonNavigationItem.css:
(.navigation-bar .item.radio.button.text-only.selected):
(body.mac-platform.legacy .navigation-bar .item.radio.button.text-only.selected):
- UserInterface/Views/RulesStyleDetailsPanel.css:
(.sidebar > .panel.details.css-style .rules .label + .style-declaration-section):
(body.mac-platform.legacy .sidebar > .panel.details.css-style .rules .label + .style-declaration-section):
(.sidebar > .panel.details.css-style .rules .new-rule):
(body.mac-platform.legacy .sidebar > .panel.details.css-style .rules .new-rule):
(.sidebar > .panel.details.css-style .rules .new-rule + .style-declaration-section):
(body.mac-platform.legacy .sidebar > .panel.details.css-style .rules .new-rule + .style-declaration-section):
- UserInterface/Views/ScopeBar.css:
(.scope-bar > li):
(body.mac-platform.legacy .scope-bar > li):
(.scope-bar > li.selected):
(body.mac-platform.legacy .scope-bar > li.selected):
- UserInterface/Views/SearchBar.css:
(.search-bar > input[type="search"]):
(body.mac-platform.legacy .search-bar > input[type="search"]):
- UserInterface/Views/Sidebar.css:
(.sidebar):
(body.mac-platform.legacy .sidebar):
(body.mac-platform.legacy.window-inactive .sidebar):
(body.mac-platform.legacy .sidebar.right):
(body.window-inactive .sidebar): Deleted.
(.sidebar.right): Deleted.
- UserInterface/Views/TimelineSidebarPanel.css:
(.sidebar > .panel.navigation.timeline > .title-bar):
(body.mac-platform.legacy .sidebar > .panel.navigation.timeline > .title-bar):
Style updates for new look and feel.
- 8:06 PM Changeset in webkit [171133] by
-
- 2 edits in trunk/Source/WebCore
Fix non-iOS builds.
- rendering/RenderBox.cpp:
(WebCore::shouldAppyContainersClipAndOffset):
- 7:58 PM Changeset in webkit [171132] by
-
- 2 edits in trunk/Source/WebCore
[iOS] Fix touches inside accelerated overflow:scroll
https://bugs.webkit.org/show_bug.cgi?id=134961
<rdar://problem/16088789>
Reviewed by Benjamin Poulain.
When individual elements inside an overflow:scroll with -webkit-overflow-scrolling: touch
had touch event listeners, we would fail to take the scroll offset into account when
building the touch event region, causing touches on those elements to fail after scrolling.
Touch event region building uses RenderObject::absoluteClippedOverflowRect(), and that
code path tries to fix up repaint rects to work correctly in composited overflow:scroll.
However, that broke the touch region computation.
Fix by only ignoring the scroll offset for calls to computeRectForRepaint() which
have a non-null repaintContainer (which indicates that we're doing a repaint in the
compositing layer), and for which the repaintContainer is the containing block
which is using composited scrolling. This restores correct behavior to the event region
code which always calls this with a null repaintContainer.
- rendering/RenderBox.cpp:
(WebCore::shouldAppyContainersClipAndOffset):
(WebCore::RenderBox::computeRectForRepaint):
- 7:26 PM Changeset in webkit [171131] by
-
- 2 edits in trunk/Source/WTF
Unreviewed, rolling out r171107.
https://bugs.webkit.org/show_bug.cgi?id=134959
This was not the problem! (Requested by kling on #webkit).
Reverted changeset:
"Revert: Run the FastMalloc scavenger thread on iOS as well."
https://bugs.webkit.org/show_bug.cgi?id=134927
http://trac.webkit.org/changeset/171107
- 6:40 PM Changeset in webkit [171130] by
-
- 2 edits in trunk/Websites/webkit.org
Make css jit benchmark work on IE11.
https://bugs.webkit.org/show_bug.cgi?id=134956
Reviewed by Benjamin Poulain.
- blog-files/css-jit-introduction/html5-single-page-microbenchmark.html:
Remove an iframe which caused IE11 to try to open content as a URL.
- 6:29 PM Changeset in webkit [171129] by
-
- 2 edits in trunk/Source/WebKit2
WKWebView’s FormClient::willSubmitForm should use CompletionHandlerCallChecker
https://bugs.webkit.org/show_bug.cgi?id=134951
Reviewed by Tim Horton.
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _setFormDelegate:]):
- 5:53 PM Changeset in webkit [171128] by
-
- 2 edits in tags/Safari-538.46.3/Source/WebCore
Merged r171099. <rdar://problem/16917699>
- 5:51 PM Changeset in webkit [171127] by
-
- 2 edits in tags/Safari-538.46.3/Source/WebCore
Merged r171089. <rdar://problem/16917699>
- 5:47 PM Changeset in webkit [171126] by
-
- 5 edits in tags/Safari-538.46.3/Source
Versioning.
- 5:43 PM Changeset in webkit [171125] by
-
- 1 copy in tags/Safari-538.46.3
New tag.
- 5:14 PM Changeset in webkit [171124] by
-
- 4 edits in trunk/Source/WebKit2
[iOS][WK2] Scrolling request from the scrolling tree must be limited to offsets in the document
https://bugs.webkit.org/show_bug.cgi?id=134952
<rdar://problem/17647116>
Reviewed by Enrica Casucci.
When we received a scroll request, we were taking that offset directly to set the UIScrollView
scroll position. This is a problem if a page request scrolling to an invalid position, we were
still doing it.
This patch limits the position to be inside the document.
-- Why not limit the scroll offset in the WebProcess when we receive the scroll request? --
Some pages rely on the page scale factor changing instantly, because that is how it worked
on WebKit1.
On WebKit2, the WebProcess cannot know the valid range because the obscured insets are changing
dynamically, and the page scale factor can change in response to WebProcess events (the focus
changing for example). To make the page works, the WebProcess does not restrict the scroll position.
In that architecture, the UIProcess has to sanitize the input, which was not done before this patch.
-- Why not use changeContentOffsetBoundedInValidRange()?
The scroll offset as seen by the page is relative to the unobscured rect. While the position used
for history item is a visual position. All we need in this case is a position in the view.
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _scrollToContentOffset:]):
- UIProcess/WebPageProxy.h:
- UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::WebPageProxy::resendLastVisibleContentRects):
- 4:59 PM Changeset in webkit [171123] by
-
- 8 edits in trunk/Source/JavaScriptCore
Reduce the overhead of updating the AssemblerBuffer
https://bugs.webkit.org/show_bug.cgi?id=134659
Reviewed by Gavin Barraclough.
In r164548, the linker was changed to allow the LinkBuffer to survive its MacroAssembler.
That feature is useful for JSC to get offsets inside a linked buffer in order to jump directly
there.
On ARM, we use branch compaction and we need to keep the "compaction offset" somewher to be able
to get the real address of a lable. That is done by reusing the memory of AssemblerData.
To share the memory between LinkBuffer and the Assembler, r164548 moved the AssemblerData into
a ref-counted object. Unfortunately, the extra complexity related to the new AssemblerData was enough
to make clang give up a bunch of optimizations.
This patch solve (some of) the problems by making AssemblerBuffer and AssemblerData super low overhead structures.
In particular, the grow() function becomes 8 Thumb instructions, which is easily inlined everywhere it is used.
Instead of sharing ownership between the Assembler and LinkBuffer, LinkBuffer now takes full ownership of
the AssemblerData. I feel this is also safer since LinkBuffer is reusing the AssemblerData is a very
specific way that would make it unusable for the Assembler.
-- Technical details --
From LinkBuffer, we don't want to ever access the Assembler after releasing its buffer (or writting anything
into it really). This was obviously already the case, but that was hard to prove from LinkBuffer::copyCompactAndLinkCode().
To make this easier to work with, I changed all the assembler specific function to be static. This way we know
exactly what code access the Assembler instance. The code that does access the instance is then moved
at the beginning, before we modify anything.
The function recordLinkOffsets() that was on the MacroAssembler and copied in Assembler was moved directly
to LinkBuffer. This make the modification of AssemblerData completely explicit, and that code is specific
to LinkBuffer anyway (see LinkBuffer::executableOffsetFor()).
-- Perf impact --
This does not put us exactly at before r164548 due to the missing inline buffer. Still, it is very close.
On ARMv7, this reduces the time spent in Assembler by half. On the CSS JIT, this reduces the compilation
time by ~20%.
I could not measure any difference on x86_64.
- assembler/ARM64Assembler.h:
(JSC::ARM64Assembler::jumpSizeDelta):
(JSC::ARM64Assembler::canCompact):
(JSC::ARM64Assembler::computeJumpType):
(JSC::ARM64Assembler::link):
(JSC::ARM64Assembler::recordLinkOffsets): Deleted.
- assembler/ARMv7Assembler.h:
(JSC::ARMv7Assembler::ifThenElseConditionBit):
(JSC::ARMv7Assembler::ifThenElse):
(JSC::ARMv7Assembler::jumpSizeDelta):
(JSC::ARMv7Assembler::canCompact):
(JSC::ARMv7Assembler::computeJumpType):
(JSC::ARMv7Assembler::link):
(JSC::ARMv7Assembler::linkJumpT1):
(JSC::ARMv7Assembler::linkJumpT3):
(JSC::ARMv7Assembler::linkConditionalJumpT4):
(JSC::ARMv7Assembler::linkConditionalBX):
(JSC::ARMv7Assembler::recordLinkOffsets): Deleted.
- assembler/AssemblerBuffer.h:
(JSC::AssemblerData::AssemblerData):
(JSC::AssemblerData::operator=):
(JSC::AssemblerData::~AssemblerData):
(JSC::AssemblerData::buffer):
(JSC::AssemblerData::capacity):
(JSC::AssemblerData::grow):
(JSC::AssemblerBuffer::AssemblerBuffer):
(JSC::AssemblerBuffer::isAvailable):
(JSC::AssemblerBuffer::data):
(JSC::AssemblerBuffer::releaseAssemblerData):
(JSC::AssemblerBuffer::putIntegral):
(JSC::AssemblerBuffer::putIntegralUnchecked):
(JSC::AssemblerBuffer::append):
(JSC::AssemblerBuffer::grow):
(JSC::AssemblerBuffer::~AssemblerBuffer): Deleted.
(JSC::AssemblerBuffer::storage): Deleted.
- assembler/LinkBuffer.cpp:
(JSC::recordLinkOffsets):
(JSC::LinkBuffer::copyCompactAndLinkCode):
- assembler/LinkBuffer.h:
(JSC::LinkBuffer::LinkBuffer):
(JSC::LinkBuffer::executableOffsetFor):
- assembler/MacroAssemblerARM64.h:
(JSC::MacroAssemblerARM64::canCompact):
(JSC::MacroAssemblerARM64::computeJumpType):
(JSC::MacroAssemblerARM64::jumpSizeDelta):
(JSC::MacroAssemblerARM64::link):
(JSC::MacroAssemblerARM64::recordLinkOffsets): Deleted.
- assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::canCompact):
(JSC::MacroAssemblerARMv7::computeJumpType):
(JSC::MacroAssemblerARMv7::jumpSizeDelta):
(JSC::MacroAssemblerARMv7::link):
(JSC::MacroAssemblerARMv7::recordLinkOffsets): Deleted.
- 4:12 PM Changeset in webkit [171122] by
-
- 5 edits in tags/Safari-538.46.40/Source
Versioning.
- 3:55 PM Changeset in webkit [171121] by
-
- 1 copy in tags/Safari-538.46.40
New Tag.
- 3:51 PM Changeset in webkit [171120] by
-
- 2 edits in trunk/Source/WebKit/mac
[OSX] [WK1] Crash when exiting fullscreen
https://bugs.webkit.org/show_bug.cgi?id=134943
Reviewed by Dean Jackson.
AppKit doesn't remove a view from the Key View Loop when removing it from its superview.
This codepath is already "tested" in fullscreen/full-screen-cancel.html, but because of our
testing infrastructure, the broken codepath doesn't actually get hit in DRT. Therefore,
there is no test.
- WebView/WebFullScreenController.mm:
(-[WebFullScreenController enterFullScreen:]):
- 3:25 PM Changeset in webkit [171119] by
-
- 9 edits in trunk/Source/WebCore
[iOS] Fix issues drawing subsampled image elements and CSS images
https://bugs.webkit.org/show_bug.cgi?id=134944
<rdar://problem/17634095>
Reviewed by Dean Jackson.
After r170675 it is important for BitmapImage::draw() to be given a srcRect computed
using the original size of the image, not the subsampled size.
So fix various code paths that end up in image drawing to use the originalSize(),
which requires giving Image a virtual function that just returns size(), and hence has
a FloatSize return value.
Tested by setting a very low subsampling threshold and browsing various sites.
A better longterm fix will happen via bug 134916.
- platform/graphics/BitmapImage.cpp:
(WebCore::BitmapImage::originalSize):
- platform/graphics/BitmapImage.h:
- platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContext::drawImage):
- platform/graphics/Image.cpp:
(WebCore::Image::drawTiled):
(WebCore::Image::computeIntrinsicDimensions):
- platform/graphics/Image.h:
(WebCore::Image::originalSize):
- platform/graphics/cg/BitmapImageCG.cpp:
(WebCore::BitmapImage::BitmapImage): Just use m_size for initializing the other members.
(WebCore::BitmapImage::draw):
- platform/graphics/cg/GraphicsContext3DCG.cpp:
(WebCore::GraphicsContext3D::ImageExtractor::extractImage):
- platform/graphics/cg/ImageCG.cpp:
(WebCore::Image::drawPattern):
- 2:32 PM Changeset in webkit [171118] by
-
- 5 edits in trunk/Source
Versioning.
- 2:26 PM Changeset in webkit [171117] by
-
- 2 edits in trunk/Source/WebKit2
Dispatch top content inset changes immediately if synchronously waiting for view state changes
https://bugs.webkit.org/show_bug.cgi?id=134942
<rdar://problem/17666800>
Reviewed by Simon Fraser.
- UIProcess/API/mac/WKView.mm:
(-[WKView endDeferringViewInWindowChanges]):
(-[WKView endDeferringViewInWindowChangesSync]):
(-[WKView _dispatchSetTopContentInset]):
(-[WKView _setTopContentInset:]):
Send top content inset changes immediately before sync-waiting for new tiles from the Web Process.
This will ensure that the incoming contents have the right top content inset, and we don't
flash between the wrong inset and the right one.
- 2:17 PM Changeset in webkit [171116] by
-
- 3 edits in trunk/Source/WebCore
[Win] Unreviewed build fix after r171069.
Add missing AudioHardwareListener implementation on Windows.
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- 2:05 PM Changeset in webkit [171115] by
-
- 10 edits in trunk/Source/JavaScriptCore
Stores to PropertyTable use the Structure as the owner
https://bugs.webkit.org/show_bug.cgi?id=134595
Reviewed by Darin Adler.
Since PropertyTable is the object that does the marking of these references, it should be the owner.
Also removed some unused parameters to other methods that historically used the Structure as the owner.
- runtime/JSPropertyNameIterator.h:
(JSC::StructureRareData::setEnumerationCache):
- runtime/ObjectPrototype.cpp:
(JSC::objectProtoFuncToString):
- runtime/PropertyMapHashTable.h:
(JSC::PropertyTable::copy):
- runtime/PropertyTable.cpp:
(JSC::PropertyTable::clone):
(JSC::PropertyTable::PropertyTable):
- runtime/Structure.cpp:
(JSC::Structure::Structure):
(JSC::Structure::materializePropertyMap):
(JSC::Structure::addPropertyTransition):
(JSC::Structure::changePrototypeTransition):
(JSC::Structure::despecifyFunctionTransition):
(JSC::Structure::attributeChangeTransition):
(JSC::Structure::toDictionaryTransition):
(JSC::Structure::preventExtensionsTransition):
(JSC::Structure::takePropertyTableOrCloneIfPinned):
(JSC::Structure::nonPropertyTransition):
(JSC::Structure::copyPropertyTable):
(JSC::Structure::copyPropertyTableForPinning):
(JSC::Structure::putSpecificValue):
- runtime/Structure.h:
(JSC::Structure::setObjectToStringValue):
(JSC::Structure::setPreviousID):
- runtime/StructureInlines.h:
(JSC::Structure::setEnumerationCache):
- runtime/StructureRareData.h:
- runtime/StructureRareDataInlines.h:
(JSC::StructureRareData::setPreviousID):
(JSC::StructureRareData::setObjectToStringValue):
- 1:52 PM Changeset in webkit [171114] by
-
- 2 edits in trunk/Source/WebKit2
REGRESSION(WK2 iOS): Safari hangs when switching focus from a field using the Tab key.
https://bugs.webkit.org/show_bug.cgi?id=134934
<rdar://problem/17224638>
Reviewed by Tim Horton.
- UIProcess/ios/WKContentViewInteraction.mm:
Tab and back tab should be handled as special keys that have
a command associated. The command specifies for each key the relevant
action. This patch implements the commands property to create the association
between key and command and the relevant actions that will execute the same
code executed when the used taps on the < > buttons in the accessory bar.
(-[WKContentView keyCommands]):
(-[WKContentView _nextAccessoryTab:]):
(-[WKContentView _prevAccessoryTab:]):
- 1:31 PM Changeset in webkit [171113] by
-
- 2 edits in trunk/Source/WebKit2
More tidying of the webcontent sandbox profile
https://bugs.webkit.org/show_bug.cgi?id=134938
Reviewed by Alexey Proskuryakov.
Remove some excessive abilities from the profile and make
the required ones explicit.
- Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
- 12:41 PM Changeset in webkit [171112] by
-
- 2 edits in tags/Safari-538.46.1.1/Source/WebCore
Merged r171099. <rdar://problem/16917699>
- 12:38 PM Changeset in webkit [171111] by
-
- 2 edits in tags/Safari-538.46.1.1/Source/WebCore
Merged r171089. <rdar://problem/16917699>
- 12:30 PM Changeset in webkit [171110] by
-
- 5 edits in tags/Safari-538.46.1.1/Source
Versioning.
- 12:27 PM Changeset in webkit [171109] by
-
- 1 copy in tags/Safari-538.46.1.1
New tag.
- 12:11 PM Changeset in webkit [171108] by
-
- 2 edits in trunk/Source/JavaScriptCore
ScriptExecutable::forEachCodeBlock can dereference null CodeBlocks
https://bugs.webkit.org/show_bug.cgi?id=134928
Reviewed by Andreas Kling.
- bytecode/CodeBlock.h:
(JSC::ScriptExecutable::forEachCodeBlock): Check for null CodeBlocks before calling forEachRelatedCodeBlock.
- 11:34 AM Changeset in webkit [171107] by
-
- 2 edits in trunk/Source/WTF
Revert: Run the FastMalloc scavenger thread on iOS as well.
<https://webkit.org/b/134927>
<rdar://problem/17485079>
This appears to be the cause of some elusive crashes, and since I don't
have a way to reproduce them, let's just go back to not running the
scavenger thread on iOS.
Reviewed by Antti Koivisto.
- wtf/FastMalloc.cpp:
- 8:48 AM Changeset in webkit [171106] by
-
- 21 edits13 adds in branches/ftlopt
[ftlopt] DFG should be able to do GCSE in SSA and this should be unified with the CSE in CPS, and both of these things should use abstract heaps for reasoning about effects
https://bugs.webkit.org/show_bug.cgi?id=134677
Reviewed by Sam Weinig.
Source/JavaScriptCore:
This removes the old local CSE phase, which was based on manually written backward-search
rules for all of the different kinds of things we cared about, and adds a new local/global
CSE (local for CPS and global for SSA) that leaves the node semantics almost entirely up to
clobberize(). Thus, the CSE phase itself just worries about the algorithms and data
structures used for storing sets of available values. This results in a large reduction in
code size in CSEPhase.cpp while greatly increasing the phase's power (since it now does
global CSE) and reducing compile time (since local CSE is now rewritten to use smarter data
structures). Even though LLVM was already running GVN, the extra GCSE at DFG IR level means
that this is a significant (~0.7%) throughput improvement.
This work is based on the concept of "def" to clobberize(). If clobberize() calls def(), it
means that the node being analyzed makes available some value in some DFG node, and that
future attempts to compute that value can simply use that node. In other words, it
establishes an available value mapping of the form value=>node. There are two kinds of
values that can be passed to def():
PureValue. This captures everything needed to determine whether two pure nodes - nodes that
neither read nor write, and produce a value that is a CSE candidate - are identical. It
carries the NodeType, an AdjacencyList, and one word of meta-data. The meta-data is
usually used for things like the arithmetic mode or constant pointer. Passing a
PureValue to def() means that the node produces a value that is valid anywhere that the
node dominates.
HeapLocation. This describes a location in the heap that could be written to or read from.
Both stores and loads can def() a HeapLocation. HeapLocation carries around an abstract
heap that both serves as part of the "name" of the heap location (together with the
other fields of HeapLocation) and also tells us what write()'s to watch for. If someone
write()'s to an abstract heap that overlaps the heap associated with the HeapLocation,
then it means that the values for that location are no longer available.
This approach is sufficiently clever that the CSEPhase itself can focus on the mechanism of
tracking the PureValue=>node and HeapLocation=>node maps, without having to worry about
interpreting the semantics of different DFG node types - that is now almost entirely in
clobberize(). The only things we special-case inside CSEPhase are the Identity node, which
CSE is traditionally responsible for eliminating even though it has nothing to do with CSE,
and the LocalCSE rule for turning PutByVal into PutByValAlias.
This is a slight Octane, SunSpider, and Kraken speed-up - all somewhere arond 0.7% . It's
not a bigger win because LLVM was already giving us most of what we needed in its GVN.
Also, the SunSpider speed-up isn't from GCSE as much as it's a clean-up of local CSE - that
is no longer O(n2). Basically this is purely good: it reduces the amount of LLVM IR we
generate, it removes the old CSE's heap modeling (which was a constant source of bugs), and
it improves both the quality of the code we generate and the speed with which we generate
it. Also, any future optimizations that depend on GCSE will now be easier to implement.
During the development of this patch I also rationalized some other stuff, like Graph's
ordered traversals - we now have preorder and postorder rather than just "depth first".
- CMakeLists.txt:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
- JavaScriptCore.xcodeproj/project.pbxproj:
- dfg/DFGAbstractHeap.h:
- dfg/DFGAdjacencyList.h:
(JSC::DFG::AdjacencyList::hash):
(JSC::DFG::AdjacencyList::operator==):
- dfg/DFGBasicBlock.h:
- dfg/DFGCSEPhase.cpp:
(JSC::DFG::performLocalCSE):
(JSC::DFG::performGlobalCSE):
(JSC::DFG::CSEPhase::CSEPhase): Deleted.
(JSC::DFG::CSEPhase::run): Deleted.
(JSC::DFG::CSEPhase::endIndexForPureCSE): Deleted.
(JSC::DFG::CSEPhase::pureCSE): Deleted.
(JSC::DFG::CSEPhase::constantCSE): Deleted.
(JSC::DFG::CSEPhase::constantStoragePointerCSE): Deleted.
(JSC::DFG::CSEPhase::getCalleeLoadElimination): Deleted.
(JSC::DFG::CSEPhase::getArrayLengthElimination): Deleted.
(JSC::DFG::CSEPhase::globalVarLoadElimination): Deleted.
(JSC::DFG::CSEPhase::scopedVarLoadElimination): Deleted.
(JSC::DFG::CSEPhase::varInjectionWatchpointElimination): Deleted.
(JSC::DFG::CSEPhase::getByValLoadElimination): Deleted.
(JSC::DFG::CSEPhase::checkFunctionElimination): Deleted.
(JSC::DFG::CSEPhase::checkExecutableElimination): Deleted.
(JSC::DFG::CSEPhase::checkStructureElimination): Deleted.
(JSC::DFG::CSEPhase::structureTransitionWatchpointElimination): Deleted.
(JSC::DFG::CSEPhase::getByOffsetLoadElimination): Deleted.
(JSC::DFG::CSEPhase::getGetterSetterByOffsetLoadElimination): Deleted.
(JSC::DFG::CSEPhase::getPropertyStorageLoadElimination): Deleted.
(JSC::DFG::CSEPhase::checkArrayElimination): Deleted.
(JSC::DFG::CSEPhase::getIndexedPropertyStorageLoadElimination): Deleted.
(JSC::DFG::CSEPhase::getInternalFieldLoadElimination): Deleted.
(JSC::DFG::CSEPhase::getMyScopeLoadElimination): Deleted.
(JSC::DFG::CSEPhase::getLocalLoadElimination): Deleted.
(JSC::DFG::CSEPhase::invalidationPointElimination): Deleted.
(JSC::DFG::CSEPhase::setReplacement): Deleted.
(JSC::DFG::CSEPhase::eliminate): Deleted.
(JSC::DFG::CSEPhase::performNodeCSE): Deleted.
(JSC::DFG::CSEPhase::performBlockCSE): Deleted.
(JSC::DFG::performCSE): Deleted.
- dfg/DFGCSEPhase.h:
- dfg/DFGClobberSet.cpp:
(JSC::DFG::addReads):
(JSC::DFG::addWrites):
(JSC::DFG::addReadsAndWrites):
(JSC::DFG::readsOverlap):
(JSC::DFG::writesOverlap):
- dfg/DFGClobberize.cpp:
(JSC::DFG::doesWrites):
(JSC::DFG::accessesOverlap):
(JSC::DFG::writesOverlap):
- dfg/DFGClobberize.h:
(JSC::DFG::clobberize):
(JSC::DFG::NoOpClobberize::operator()):
(JSC::DFG::CheckClobberize::operator()):
(JSC::DFG::ReadMethodClobberize::ReadMethodClobberize):
(JSC::DFG::ReadMethodClobberize::operator()):
(JSC::DFG::WriteMethodClobberize::WriteMethodClobberize):
(JSC::DFG::WriteMethodClobberize::operator()):
(JSC::DFG::DefMethodClobberize::DefMethodClobberize):
(JSC::DFG::DefMethodClobberize::operator()):
- dfg/DFGDCEPhase.cpp:
(JSC::DFG::DCEPhase::run):
(JSC::DFG::DCEPhase::fixupBlock):
- dfg/DFGGraph.cpp:
(JSC::DFG::Graph::getBlocksInPreOrder):
(JSC::DFG::Graph::getBlocksInPostOrder):
(JSC::DFG::Graph::addForDepthFirstSort): Deleted.
(JSC::DFG::Graph::getBlocksInDepthFirstOrder): Deleted.
- dfg/DFGGraph.h:
- dfg/DFGHeapLocation.cpp: Added.
(JSC::DFG::HeapLocation::dump):
(WTF::printInternal):
- dfg/DFGHeapLocation.h: Added.
(JSC::DFG::HeapLocation::HeapLocation):
(JSC::DFG::HeapLocation::operator!):
(JSC::DFG::HeapLocation::kind):
(JSC::DFG::HeapLocation::heap):
(JSC::DFG::HeapLocation::base):
(JSC::DFG::HeapLocation::index):
(JSC::DFG::HeapLocation::hash):
(JSC::DFG::HeapLocation::operator==):
(JSC::DFG::HeapLocation::isHashTableDeletedValue):
(JSC::DFG::HeapLocationHash::hash):
(JSC::DFG::HeapLocationHash::equal):
- dfg/DFGLICMPhase.cpp:
(JSC::DFG::LICMPhase::run):
- dfg/DFGNode.h:
(JSC::DFG::Node::replaceWith):
(JSC::DFG::Node::convertToPhantomUnchecked): Deleted.
- dfg/DFGPlan.cpp:
(JSC::DFG::Plan::compileInThreadImpl):
- dfg/DFGPureValue.cpp: Added.
(JSC::DFG::PureValue::dump):
- dfg/DFGPureValue.h: Added.
(JSC::DFG::PureValue::PureValue):
(JSC::DFG::PureValue::operator!):
(JSC::DFG::PureValue::op):
(JSC::DFG::PureValue::children):
(JSC::DFG::PureValue::info):
(JSC::DFG::PureValue::hash):
(JSC::DFG::PureValue::operator==):
(JSC::DFG::PureValue::isHashTableDeletedValue):
(JSC::DFG::PureValueHash::hash):
(JSC::DFG::PureValueHash::equal):
- dfg/DFGSSAConversionPhase.cpp:
(JSC::DFG::SSAConversionPhase::run):
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::lower):
LayoutTests:
- js/regress/gcse-expected.txt: Added.
- js/regress/gcse-poly-get-expected.txt: Added.
- js/regress/gcse-poly-get-less-obvious-expected.txt: Added.
- js/regress/gcse-poly-get-less-obvious.html: Added.
- js/regress/gcse-poly-get.html: Added.
- js/regress/gcse.html: Added.
- js/regress/script-tests/gcse-poly-get-less-obvious.js: Added.
- js/regress/script-tests/gcse-poly-get.js: Added.
- js/regress/script-tests/gcse.js: Added.
- 7:59 AM Changeset in webkit [171105] by
-
- 3 edits2 adds in trunk
REGRESSION (r155957): Invalid cast in WebCore::RenderNamedFlowThread::getRanges
https://bugs.webkit.org/show_bug.cgi?id=134888
Reviewed by Mihnea Ovidenie.
Source/WebCore:
Test: fast/regions/flowthread-getranges-box-cast.html
- rendering/RenderNamedFlowThread.cpp:
(WebCore::RenderNamedFlowThread::getRanges): Test the type before casting.
LayoutTests:
- fast/regions/flowthread-getranges-box-cast-expected.txt: Added.
- fast/regions/flowthread-getranges-box-cast.html: Added.
- 3:49 AM Changeset in webkit [171104] by
-
- 2 edits in trunk/Source/JavaScriptCore
Buildfix if LLINT_SLOW_PATH_TRACING is enabled
https://bugs.webkit.org/show_bug.cgi?id=133790
Patch by Eva Balazsfalvi <evab.u-szeged@partner.samsung.com> on 2014-07-15
Reviewed by Mark Lam.
- llint/LLIntSlowPaths.cpp:
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
- 2:34 AM Changeset in webkit [171103] by
-
- 2 edits in trunk/Source/WebCore
[GTK] Update GObject DOM bindings symbols file after r171014.
https://bugs.webkit.org/show_bug.cgi?id=134907
Patch by Carlos Alberto Lopez Perez <clopez@igalia.com> on 2014-07-15
Reviewed by Philippe Normand.
- bindings/gobject/webkitdom.symbols: Update to the current API.
- 2:15 AM Changeset in webkit [171102] by
-
- 2 edits in trunk/Source/WebCore
Unreviwed fix wrong indentation from r171082.
- rendering/RenderGrid.cpp:
(WebCore::RenderGrid::placeAutoMajorAxisItemOnGrid):
