Context Navigation

Perl 5.18 introduced hash randomization. This results in the iteration order of hashes being different
from one run to the next. To ensure identical output we can iterate over the hash keys in sorted order.

Reviewed by Alexey Proskuryakov.

bindings/scripts/StaticString.pm:

(GenerateStrings):
(GenerateStringAsserts):

dom/make_names.pl:

9:24 AM WebKitGTK/KeepingTheTreeGreen edited by clopez@igalia.com

(diff)

9:16 AM Changeset in webkit [171263] by clopez@igalia.com

2 edits in trunk/LayoutTests

[GTK] Unreviewed GTK gardening.

platform/gtk/TestExpectations: Report and mark new failures. Update some expectations.

3:10 AM Changeset in webkit [171262] by zandobersek@gmail.com

2 edits in trunk/Source/WTF

[WTF] Add the move constructor, move assignment operator for HashTable
https://bugs.webkit.org/show_bug.cgi?id=130772

Reviewed by Darin Adler.

HashTable has both copy constructor and copy assignment operator, meaning that the move constructor
and move assignment operator are implicitly deleted. This patch defines both to avoid unnecessary
copies when moves can be performed.

wtf/HashTable.h:

(WTF::KeyTraits>::HashTable):

3:08 AM Changeset in webkit [171261] by zandobersek@gmail.com

2 edits in trunk/Source/WebCore

Document::unregisterNodeListforInvalidation() and Document::unregisterCollection() have incorrect assertions
https://bugs.webkit.org/show_bug.cgi?id=134869

Reviewed by Darin Adler.

Both methods should assert that the relevant HashMap is either empty if invalidation originates
from Document::invalidateNodeListAndCollectionCaches() or acutally contains the element that is
being invalidated. In the first case the HashMap is empty because its entries were moved out in
the Document::invalidateNodeListAndCollectionCaches().

This was exposed by r170995 (later rolled out in r170999) which introduced move constructor and
move assignment operators for HashTable. The assertions in the titular methods won't be passing
until r170995 relands.

dom/Document.cpp:

(WebCore::Document::unregisterNodeListForInvalidation):

3:02 AM Changeset in webkit [171260] by zandobersek@gmail.com

4 edits in trunk/Source/WebKit2

Consistently use uint64_t as the handle parameter type for the SetAcceleratedCompositingWindowId message
https://bugs.webkit.org/show_bug.cgi?id=135047

Reviewed by Darin Adler.

UIProcess' WebPageProxy is handling this parameter as an uint64_t, it should be handled as such
in WebProcess as well.

WebProcess/WebPage/WebPage.h:
WebProcess/WebPage/WebPage.messages.in: Also changed the parameter name to match other places.
WebProcess/WebPage/gtk/WebPageGtk.cpp:

(WebKit::WebPage::setAcceleratedCompositingWindowId):

Jul 18, 2014:

10:25 PM Changeset in webkit [171259] by eric.carlson@apple.com

2 edits in trunk/Source/WebCore

[iOS] ignore requests to set volume
https://bugs.webkit.org/show_bug.cgi?id=135081

Reviewed by Jer Noble.

platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::setVolume): Do nothing on iOS.

9:59 PM Changeset in webkit [171258] by rniwa@webkit.org

2 edits in trunk/Websites/perf.webkit.org

Perf dashboard shouldn't show the full git hash
https://bugs.webkit.org/show_bug.cgi?id=135083

Reviewed by Benjamin Poulain.

Detect Git/Mercurial hash by checking the length.

If it's a hash, use the first 8 characters in the label
while retaining the full length to be used in hyperlinks.

public/js/helper-classes.js:

(.this.formattedRevisions):
(TestBuild):

6:30 PM Changeset in webkit [171257] by oliver@apple.com

2 edits in trunk/Source/WebKit2

We don't provide an extension to the temp file used for uploads
https://bugs.webkit.org/show_bug.cgi?id=135079

Reviewed by Sam Weinig.

Make sure didChooseFilesForOpenPanelWithDisplayStringAndIcon vends
extensions for the files passed to the content process.

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didChooseFilesForOpenPanelWithDisplayStringAndIcon):

5:52 PM Changeset in webkit [171256] by timothy_horton@apple.com

2 edits in trunk/Source/WebKit2

ASSERTion failures in ViewGestureController indicating that we're copying WebBackForwardList
https://bugs.webkit.org/show_bug.cgi?id=135080
<rdar://problem/17734714>

Reviewed by Sam Weinig.

UIProcess/ios/ViewGestureControllerIOS.mm:

(WebKit::ViewGestureController::beginSwipeGesture):
(WebKit::ViewGestureController::canSwipeInDirection):

5:51 PM Changeset in webkit [171255] by weinig@apple.com

2 edits in trunk/Tools

Revert accidental commit to MiniBrowser to make everything layer backed.

MiniBrowser/mac/BrowserWindowController.m:

(-[BrowserWindowController windowDidLoad]):

5:47 PM Changeset in webkit [171254] by dburkart@apple.com

3 edits
2 copies in branches/safari-537.78-branch

Merge r169318.

5:21 PM Changeset in webkit [171253] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit2

_WKActivatedElementInfo.title should fallback to innerText if the link doesn't have title attribute.
https://bugs.webkit.org/show_bug.cgi?id=135077

When populate InteractionInformationAtPosition's title value, use a link element's innerText if it
doesn't have title attribute.

Patch by Yongjun Zhang <yongjun_zhang@apple.com> on 2014-07-18
Reviewed by Dan Bernstein.

WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::getPositionInformation):

5:19 PM Changeset in webkit [171252] by aestes@apple.com

25 edits in trunk/Source

[iOS] Tapping "Allow Website" on a restricted page does not bring up the keypad
https://bugs.webkit.org/show_bug.cgi?id=135072
<rdar://problem/17528188>

Reviewed by David Kilzer.

Source/WebCore:
No new tests. Content filtering is not testable from WebKit.

WebCore.exp.in: Exported necessary ContentFilter symbols.
loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::finishedLoading): Called FrameLoaderClient::contentFilterDidBlockLoad().
(WebCore::DocumentLoader::responseReceived): Created a new ContentFilter.
(WebCore::DocumentLoader::dataReceived): Called FrameLoaderClient::contentFilterDidBlockLoad().
(WebCore::DocumentLoader::setContentFilterForBlockedLoad): Deleted.
(WebCore::DocumentLoader::handleContentFilterRequest): Deleted.

loader/DocumentLoader.h:
loader/FrameLoaderClient.h:

(WebCore::FrameLoaderClient::contentFilterDidBlockLoad):

loader/PolicyChecker.cpp:

(WebCore::PolicyChecker::checkNavigationPolicy): Removed the check for unblock navigations, as this is now
handled at the WebKit layer.

platform/ContentFilter.h: ContentFilter no longer needs to be RefCounted, so made various changes in order to

make it compatible with unique_ptr.

platform/ios/ContentFilterIOS.mm:

(WebCore::scheme): Changed from a public member function to a static inline free function.
(WebCore::ContentFilter::handleUnblockRequestAndDispatchIfSuccessful): Renamed from requestUnblockAndDispatchIfSuccessful.

platform/mac/ContentFilterMac.mm:

(WebCore::ContentFilter::ContentFilter): Added a default constructor for use during message decoding.
(WebCore::ContentFilter::addData): Removed calls to ref() and deref(). These were never actually needed since
we were dispatching the block synchronously.
(WebCore::ContentFilter::finishedAddingData): Ditto.
(WebCore::ContentFilter::encode): Encoded m_platformContentFilter to the NSKeyedArchiver if it conforms to NSSecureCoding.
(WebCore::ContentFilter::decode): Decoded m_platformContentFilter from the NSKeyedUnarchiver if it conforms to NSSecureCoding.
(WebCore::ContentFilter::create): Deleted.

Source/WebKit/mac:

WebCoreSupport/WebFrameLoaderClient.h: Override contentFilterDidBlockLoad().
WebCoreSupport/WebFrameLoaderClient.mm:

(WebFrameLoaderClient::dispatchDidStartProvisionalLoad): Reset contentFilterForBlockedLoad to nullptr.
(WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction): Check if this is navigation represents an
unblock request and ignore if so.

WebView/WebFrame.mm:

(-[WebFrame _contentFilterDidHandleNavigationAction:]): Called ContentFilter::handleUnblockRequestAndDispatchIfSuccessful().
If the unblock is successful, reload the main frame.

WebView/WebFrameInternal.h:

Source/WebKit2:

Shared/WebCoreArgumentCoders.h: Declared an ArgumentCoder for WebCore::ContentFilter.
Shared/mac/WebCoreArgumentCodersMac.mm:

(IPC::ArgumentCoder<ContentFilter>::encode): Encoded the ContentFilter using a NSKeyedArchiver.
(IPC::ArgumentCoder<ContentFilter>::decode): Decoded the ContentFilter using a NSKeyedUnarchiver.

UIProcess/Cocoa/WebPageProxyCocoa.mm:

(WebKit::WebPageProxy::contentFilterDidBlockLoadForFrame): Called WebFrameProxy::setContentFilterForBlockedLoad().

UIProcess/WebFrameProxy.cpp:

(WebKit::WebFrameProxy::didStartProvisionalLoad): Reset m_contentFilterForBlockedLoad to nullptr.
(WebKit::WebFrameProxy::contentFilterDidHandleNavigationAction): Called ContentFilter::handleUnblockRequestAndDispatchIfSuccessful().
If the unblock is successful, reload the WebPageProxy.

UIProcess/WebFrameProxy.h:

(WebKit::WebFrameProxy::setContentFilterForBlockedLoad):

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::decidePolicyForNavigationAction): Check if this is navigation represents an unblock
request and ignore if so.

UIProcess/WebPageProxy.h:
UIProcess/WebPageProxy.messages.in: Defined ContentFilterDidBlockLoadForFrame.
WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::contentFilterDidBlockLoad): Sent ContentFilterDidBlockLoadForFrame to the WebPageProxy.

WebProcess/WebCoreSupport/WebFrameLoaderClient.h:

5:11 PM Changeset in webkit [171251] by dburkart@apple.com

2 edits in branches/safari-537.78-branch/Source/JavaScriptCore

Merge patch for <rdar://problem/16589513>

5:00 PM Changeset in webkit [171250] by Simon Fraser

5 edits
3 adds in trunk

[iOS WK2] position:fixed in iframes with programmatic scroll could end up in the wrong place
https://bugs.webkit.org/show_bug.cgi?id=135078

Source/WebCore:
<rdar://problem/17401823>

Reviewed by Tim Horton.

When the UI-side scrolling tree receives a requested scroll position update, it scrolls
the node (e.g. a frame) then traverses child nodes to update them, e.g. for fixed position.
However, we would always use a viewport rect for the main document (from the scrolling tree),
which is not appropriate for subframes. Subframes should just use their own visible
rect to position fixed children.

Test: platform/mac-wk2/tiled-drawing/scrolling/frames/fixed-inside-frame.html

page/scrolling/ios/ScrollingTreeFrameScrollingNodeIOS.mm:

(WebCore::ScrollingTreeFrameScrollingNodeIOS::updateChildNodesAfterScroll):

Source/WebKit2:
<rdar://problem/17401823>

Reviewed by Tim Horton.

Fix the logging of requested scroll position and frame scale factor.

Shared/Scrolling/RemoteScrollingCoordinatorTransaction.cpp:

(WebKit::RemoteScrollingTreeTextStream::dump):

LayoutTests:

Reviewed by Tim Horton.

Test with position:fixed inside an iframe that scrolls programmatically.

platform/mac-wk2/tiled-drawing/scrolling/frames/fixed-inside-frame-expected.txt: Added.
platform/mac-wk2/tiled-drawing/scrolling/frames/fixed-inside-frame.html: Added.
platform/mac-wk2/tiled-drawing/scrolling/frames/resources/autoscrolling-frame-with-fixed.html: Added.

4:57 PM Changeset in webkit [171249] by jhoneycutt@apple.com

1 edit
1 add in trunk

Add a manual test for r135044

<https://bugs.webkit.org/show_bug.cgi?id=135044>

Rubber-stamped by Andy Estes.

ManualTests/ios/typing-in-field-that-clears-on-keyup.html: Added.

3:50 PM Changeset in webkit [171248] by Lucas Forschler

2 edits in tags/Safari-538.46.41/Source/WebCore

Merged r171215. <rdar://problem/17721209>

3:39 PM Changeset in webkit [171247] by dburkart@apple.com

8 edits in trunk

Add a new 'analyze' target to the makefile. This will make use of a new
'PATH_TO_SCAN_BUILD' which, if set will wrap xcodebuild in the clang
static analyzer.
https://bugs.webkit.org/show_bug.cgi?id=135057
<rdar://problem/10193187>

Reviewed by David Kilzer.

Makefile:
Makefile.shared:
Source/Makefile:

3:24 PM Changeset in webkit [171246] by Beth Dakin

3 edits in trunk/Source/WebCore

Fixed position elements are misplaced when a WK1 view has contentInsets set
https://bugs.webkit.org/show_bug.cgi?id=135031
-and corresponding-
<rdar://problem/17682335>

Reviewed by Tim Horton.

[NSScrollView documentVisibleRect] includes content that is within the inset-area
of a view, but WebCore is interested in the content that is fully visible, so we
need to factor the inset sizes out of this rect.

Implement contract() to avoid the awkwardness of calling expand() with negative
values.

platform/graphics/IntSize.h:

(WebCore::IntSize::contract):

Factor out insets

platform/mac/ScrollViewMac.mm:

(WebCore::ScrollView::platformVisibleContentRect):
(WebCore::ScrollView::platformVisibleContentSize):

3:08 PM Changeset in webkit [171245] by fpizlo@apple.com

2 edits in trunk/Tools

Fix EFL+GTK.

Scripts/run-jsc-stress-tests:

2:30 PM Changeset in webkit [171244] by Lucas Forschler

2 edits in tags/Safari-538.46.41/Source/WebCore

Rollout r171236. <rdar://problem/17721209>

2:26 PM Changeset in webkit [171243] by Lucas Forschler

5 edits in tags/Safari-538.46.41/Source

Versioning.

1:58 PM Changeset in webkit [171242] by ap@apple.com

2 edits in trunk/LayoutTests

media/video-seek-with-negative-playback.html is flaky on Mac
https://bugs.webkit.org/show_bug.cgi?id=135071

platform/mac/TestExpectations: Marked it as such.

1:54 PM Changeset in webkit [171241] by fpizlo@apple.com

5 edits in trunk

Exception fuzzing should work on iOS
https://bugs.webkit.org/show_bug.cgi?id=135070

Reviewed by Mark Hahnenberg.

Source/JavaScriptCore:

tests/exceptionFuzz.yaml:

Tools:

Scripts/jsc-stress-test-helpers/js-exception-fuzz:

(fail):

Scripts/run-jsc-stress-tests:

1:50 PM Changeset in webkit [171240] by commit-queue@webkit.org

3 edits in trunk/Source/WebKit2

[Cocoa] Use RetainPtr in _WKRemoteObjectInterface
https://bugs.webkit.org/show_bug.cgi?id=135062

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-07-18
Reviewed by Anders Carlsson.

Switch to RetainPtr instead of manual memory management of ivars.

Shared/API/Cocoa/_WKRemoteObjectInterface.h:
Shared/API/Cocoa/_WKRemoteObjectInterface.mm:

(-[_WKRemoteObjectInterface initWithProtocol:identifier:]):
(-[_WKRemoteObjectInterface identifier]):
(-[_WKRemoteObjectInterface description]):
(-[_WKRemoteObjectInterface dealloc]): Deleted.

1:34 PM Changeset in webkit [171239] by timothy_horton@apple.com

15 edits in trunk/Source

Take navigation snapshots whenever the current back-forward item is going to change
https://bugs.webkit.org/show_bug.cgi?id=135058
<rdar://problem/17464515>

Reviewed by Dan Bernstein.

Instead of trying to have the UI process figure out when to take navigation snapshots by itself,
snapshot whenever the Web process says that the current back-forward item is going to change.
This fixes snapshotting timing with pushState, and lets us bottleneck snapshotting down to
just two places instead of 5.

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::goForward):
(WebKit::WebPageProxy::goBack):
(WebKit::WebPageProxy::goToBackForwardItem):
(WebKit::WebPageProxy::didStartProvisionalLoadForFrame):
We no longer need to special-case taking navigation snapshots
when the UI process changes the back forward item or upon
didStartProvisionalLoadForFrame, because we'll always snapshot
in willChangeCurrentHistoryItem in all of these cases.

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::willChangeCurrentHistoryItem):

UIProcess/WebPageProxy.h:
UIProcess/WebPageProxy.messages.in:

Add willChangeCurrentHistoryItem message, which comes from the Web process.
When it arrives, take a navigation snapshot.

UIProcess/ios/ViewGestureControllerIOS.mm:

(WebKit::ViewGestureController::beginSwipeGesture):
Take the pre-swipe navigation snapshot before telling WebPageProxy that we're doing a swipe,
so that it doesn't bail from taking the snapshot because we have a snapshot up.

(WebKit::ViewGestureController::endSwipeGesture):
We no longer need to explicitly disable snapshotting while navigating, because
we will avoid taking the snapshot if there's a snapshot being displayed.

UIProcess/mac/ViewGestureControllerMac.mm:

(WebKit::ViewGestureController::~ViewGestureController):
Remove the snapshot if it's still up when ViewGestureController is destroyed.
The Mac version of ViewGestureController is destroyed on Web process crashes
because it is a message receiver, so it is not guaranteed to have the same
lifetime as the WebPageProxy and friends.

(WebKit::ViewGestureController::trackSwipeGesture):
Make use of recordNavigationSnapshot.

(WebKit::ViewGestureController::endSwipeGesture):
Ditto from the Mac version.

UIProcess/mac/ViewSnapshotStore.h:

(WebKit::ViewSnapshotStore::disableSnapshotting): Deleted.
(WebKit::ViewSnapshotStore::enableSnapshotting): Deleted.

UIProcess/mac/ViewSnapshotStore.mm:

(WebKit::ViewSnapshotStore::ViewSnapshotStore):
(WebKit::ViewSnapshotStore::recordSnapshot):
Remove the snapshot disabling mechanism and bail from snapshotting if we're
showing a snapshot, as mentioned above.

WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::willChangeCurrentHistoryItem):

WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::willChangeCurrentHistoryItem):

WebProcess/WebPage/WebPage.h:

Proxy willChangeCurrentHistoryItem from HistoryController to the UI process.

loader/HistoryController.cpp:

(WebCore::HistoryController::updateForCommit):
(WebCore::HistoryController::recursiveUpdateForCommit):
(WebCore::HistoryController::recursiveUpdateForSameDocumentNavigation):
(WebCore::HistoryController::createItem):
Use setCurrentItem instead of duplicating the contents of it inside each of these functions.

(WebCore::HistoryController::setCurrentItem):
(WebCore::HistoryController::replaceCurrentItem):
When setting or replacing the current item, let the FrameLoaderClient know that we're going
to change which history item is "current".

loader/FrameLoaderClient.h:

(WebCore::FrameLoaderClient::willChangeCurrentHistoryItem): Added.

12:41 PM Changeset in webkit [171238] by fpizlo@apple.com

2 edits in trunk/Tools

run-jsc-stress-tests should be able to run helper-based tests in remote mode
https://bugs.webkit.org/show_bug.cgi?id=135064

Reviewed by Mark Hahnenberg.

Scripts/run-jsc-stress-tests:

12:29 PM Changeset in webkit [171237] by fpizlo@apple.com

2 edits in trunk/Tools

run-jsc-stress-tests: rename $copy to $doNotMessWithVMPath
https://bugs.webkit.org/show_bug.cgi?id=135061

Rubber stamped by Mark Hahnenberg.

Scripts/run-jsc-stress-tests:

12:17 PM Changeset in webkit [171236] by Lucas Forschler

2 edits in tags/Safari-538.46.41/Source/WebCore

Merged r171215. <rdar://problem/17721209>

12:15 PM Changeset in webkit [171235] by bshafiei@apple.com

2 edits in branches/safari-600.1-branch/Source/WebKit2

Merged r171209. <rdar://problem/17720696>

12:13 PM Changeset in webkit [171234] by bshafiei@apple.com

2 edits in tags/Safari-600.1.1.1/Source/WebKit2

Merged r171209. <rdar://problem/17720696>

12:13 PM Changeset in webkit [171233] by fpizlo@apple.com

2 edits in trunk/Tools

Refactor run-jsc-stress-tests VM copying code to remove some abstractions
https://bugs.webkit.org/show_bug.cgi?id=135059

Reviewed by Mark Lam.

This is meant to make it easier for me to extend the copying functionality to copy things other than
the framework.

Scripts/run-jsc-stress-tests:

12:08 PM Changeset in webkit [171232] by bshafiei@apple.com

5 edits in tags/Safari-600.1.1.1/Source

Versioning.

11:58 AM Changeset in webkit [171231] by bshafiei@apple.com

1 copy in tags/Safari-600.1.1.1

New tag.

11:55 AM Changeset in webkit [171230] by Lucas Forschler

5 edits in tags/Safari-538.46.41/Source

Versioning.

11:50 AM Changeset in webkit [171229] by Lucas Forschler

1 copy in tags/Safari-538.46.41

New Tag.

11:41 AM Changeset in webkit [171228] by fpizlo@apple.com

4 edits in trunk

Fix cloop build.

Source/JavaScriptCore:

jsc.cpp:

(jscmain):

Tools:

Scripts/jsc-stress-test-helpers/js-exception-fuzz:

11:20 AM Changeset in webkit [171227] by timothy@apple.com

3 edits in trunk/Source/WebInspectorUI

Revert r169735 since it broke Timeline, and fix bug 129696 in a more targeted way.

REGRESSION (r169735): Web Inspector: Timeline tree outline missing data until collapse-expand.
https://bugs.webkit.org/show_bug.cgi?id=134845

Reviewed by Joseph Pecoraro.

UserInterface/Views/DOMTreeElement.js:

(WebInspector.DOMTreeElement.prototype.adjustCollapsedRange): Use button isteand of assuming
item.listItemElement will be ready to use. The listItemElement node is lazily created.

UserInterface/Views/TreeOutline.js:

(TreeOutline.prototype.appendChild): Don't attach unless _childrenListNode exists.
(TreeOutline.prototype.insertChild): Ditto.

11:01 AM Changeset in webkit [171226] by Alan Bujtas

2 edits in trunk/LayoutTests

Add timeout for transition end. Speculative layout test fix.

fast/layers/no-clipping-overflow-hidden-added-after-transform.html:

10:21 AM Changeset in webkit [171225] by jhoneycutt@apple.com

2 edits in trunk/Source/WebKit2

REGRESSION: Crash when typing into text field that clears itself on iOS

<https://bugs.webkit.org/show_bug.cgi?id=135044>
<rdar://problem/17640443>

Reviewed by Darin Adler.

WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::requestAutocorrectionData):
wordRangeFromPosition() returns null in some cases; null check range
before dereferencing it. Moved some variable declarations around to
better match our style.

10:14 AM Changeset in webkit [171224] by commit-queue@webkit.org

3 edits in trunk/Source/WebCore

Unreviewed, rolling out r171207.
https://bugs.webkit.org/show_bug.cgi?id=135056

Broke multiple tests on Yosemite (Requested by ap on #webkit).

Reverted changeset:

"Fixed position elements are misplaced when a WK1 view has
contentInsets set"
https://bugs.webkit.org/show_bug.cgi?id=135031
http://trac.webkit.org/changeset/171207

10:01 AM Changeset in webkit [171223] by mario@webkit.org

2 edits in trunk/LayoutTests

[GTK] Unreviewed gardening. Removing failure expectations for tests now passing.

platform/gtk/TestExpectations: Removed failure expectations.

9:53 AM Changeset in webkit [171222] by commit-queue@webkit.org

9 edits
2 deletes in trunk

Unreviewed, rolling out r171218.
https://bugs.webkit.org/show_bug.cgi?id=135055

Made fast/dom/HTMLObjectElement/beforeload-set-text-
crash.xhtml crash (Requested by ap on #webkit).

Reverted changeset:

"REGRESSION (r169105): Crash in selection"
https://bugs.webkit.org/show_bug.cgi?id=134303
http://trac.webkit.org/changeset/171218

8:23 AM Changeset in webkit [171221] by mario@webkit.org

2 edits in trunk/LayoutTests

[GTK] Unreviewed GTK gardening. Tests passing after SVN r171001

platform/gtk/TestExpectations: Removed tests that are now passing.

7:37 AM WebKitGTK/KeepingTheTreeGreen edited by clopez@igalia.com

(diff)

7:12 AM Changeset in webkit [171220] by commit-queue@webkit.org

2 edits in trunk/Tools

Fix -vverbose option in sort-export-file script.

https://bugs.webkit.org/show_bug.cgi?id=135043

Patch by Renato Nagy <nagy.renato@stud.u-szeged.hu> on 2014-07-18
Reviewed by Tim Horton.

-vverbose option does not work. Option added to getOptionsResult.

Scripts/sort-export-file:

6:41 AM Changeset in webkit [171219] by timothy_horton@apple.com

6 edits in trunk/Source/WebKit2

[WK2] Provide a mechanism to grab the back-forward list for gesture navigation purposes from another WKWebView
https://bugs.webkit.org/show_bug.cgi?id=134999
<rdar://problem/17238025>

Reviewed by Sam Weinig.

In some cases, clients may need to throw a WKWebView with no back-forward list over
another WKWebView, and want to participate in gesture swipe as if they were actually
the page being overlaid.

UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView setAllowsBackForwardNavigationGestures:]):

UIProcess/API/Cocoa/WKWebViewConfiguration.mm:

(-[WKWebViewConfiguration copyWithZone:]):
(-[WKWebViewConfiguration _alternateWebViewForNavigationGestures]):
(-[WKWebViewConfiguration _setAlternateWebViewForNavigationGestures:]):

UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h:

Keep an "alternate" WKWebView "for navigation gestures", which ViewGestureController
will use as the real source of back-forward items, and the destination of the swipe navigation.
All swipe delegate callbacks will also fire from the alternate view, because it owns the items
and will be doing the navigation.

UIProcess/ios/ViewGestureControllerIOS.mm:

(WebKit::ViewGestureController::setAlternateBackForwardListSourceView):
(WebKit::ViewGestureController::beginSwipeGesture):
Send navigationGestureDidBegin via the alternate view's WebPageProxy if it exists.
Record a new snapshot on the current page, but copy it to the alternate view if necessary,
so that when swiping forward from the alternate view, it will have the "right" snapshot.
Get the target back forward item from the alternate view.
Send navigationGestureWillEnd via the alternate view's WebPageProxy if it exists.

(WebKit::ViewGestureController::canSwipeInDirection):
Determine if we can swipe in a direction by looking at the alternate view's back-forward list if necessary.

(WebKit::ViewGestureController::endSwipeGesture):
Send navigationGestureDidEnd via the alternate view's WebPageProxy if it exists.
Perform the navigation on the alternate view if necessary.

(WebKit::ViewGestureController::removeSwipeSnapshot):
Send navigationGestureSnapshotWasRemoved via the alternate view's WebPageProxy if it exists.

UIProcess/mac/ViewGestureController.h:

2:50 AM Changeset in webkit [171218] by krit@webkit.org

9 edits
2 adds in trunk

REGRESSION (r169105): Crash in selection
https://bugs.webkit.org/show_bug.cgi?id=134303

Patch by Radu Stavila <stavila@adobe.com> on 2014-07-18
Reviewed by Ryosuke Niwa.

Source/WebCore:
When splitting the selection between different subtrees, all subtrees must have their selection cleared before
starting to apply the new selection. Otherwise, when selecting objects in a named flow thread and going up
its containing block chain, we can end up in the view's selection root, which has not yet been updated and so
we get inconsistent data.

To achieve this goal, the selection update was split into a "clear" and an "apply" method. The updateSelectionForSubtrees
method first iterates through all subtrees and performs the "clear" method and then starts all over again
and performs the "apply" method.

Also, the selectionStart/End members in RenderView have been renamed to fix problems caused by the fact that
RenderView inherits SelectionSubtreeRoot, which also has the same selectionStart/End members.

Test: fast/regions/selection/crash-deselect.html

WebCore.xcodeproj/project.pbxproj:
rendering/RenderBlock.cpp:

(WebCore::RenderBlock::isSelectionRoot):

rendering/RenderSelectionInfo.h:
rendering/RenderView.cpp:

(WebCore::RenderView::RenderView):
(WebCore::RenderView::setSelection): Renamed m_selectionStart/End to m_unsplitSelectionStart/End
(WebCore::RenderView::splitSelectionBetweenSubtrees):
(WebCore::RenderView::updateSelectionForSubtrees): Added, clears and re-applies selection for all selection subtrees.
(WebCore::RenderView::clearSubtreeSelection): Added, clears selection and returns previously selected information.
(WebCore::RenderView::applySubtreeSelection): Added, updates the selection status of all objects inside the selection tree, compares old and new data and repaints accordingly.
(WebCore::RenderView::getSelection): Renamed m_selectionStart/End to m_unsplitSelectionStart/End
(WebCore::RenderView::setSubtreeSelection): Deleted.

rendering/RenderView.h:
rendering/SelectionSubtreeRoot.cpp:

(WebCore::SelectionSubtreeRoot::SelectionSubtreeRoot):

rendering/SelectionSubtreeRoot.h:

(WebCore::SelectionSubtreeRoot::OldSelectionData::OldSelectionData):

LayoutTests:
Added test for the crash that occurred in some cases when selecting.

fast/regions/selection/crash-deselect-expected.txt: Added.
fast/regions/selection/crash-deselect.html: Added.

12:13 AM Changeset in webkit [171217] by fpizlo@apple.com

2 edits in trunk/Tools

Really remove dependency on ShellQuote.

Scripts/jsc-stress-test-helpers/js-exception-fuzz:

12:11 AM Changeset in webkit [171216] by fpizlo@apple.com

3 edits in trunk/Tools

Unreviewed, fix build for platforms that don't have ShellQuote.

Scripts/jsc-stress-test-helpers/js-exception-fuzz: Take a single argument that has the whole command string.
Scripts/run-jsc-stress-tests: Do the escaping in Ruby.

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed