Timeline
Jul 20, 2014:
- 11:16 PM Changeset in webkit [171292] by
-
- 3 edits in trunk/Source/WebCore
Unreviewed Fix test crashes when cloning video layer since r171286
https://bugs.webkit.org/show_bug.cgi?id=135112
Unreviewed. Fix crashing tests by conditionalizing inline video layer change.
compositing/video/video-reflection.html [ Crash ]
media/video-layer-crash.html [ Crash ]
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h: add conditional
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm: ditto
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerLayer): ditto
(WebCore::MediaPlayerPrivateAVFoundationObjC::destroyVideoLayer): ditto
(WebCore::MediaPlayerPrivateAVFoundationObjC::platformLayer): ditto
- 10:36 PM Changeset in webkit [171291] by
-
- 3 edits in trunk/Source/WebKit2
Fix warnings caused by unused parameter.
https://bugs.webkit.org/show_bug.cgi?id=134975
Patch by KwangHyuk Kim <hyuki.kim@samsung.com> on 2014-07-20
Reviewed by Gyuyoung Kim.
Fix warnings on EwkView.cpp and LegacySessionStateCodingNone.cpp that are caused by unused parameter data.
- UIProcess/API/efl/EwkView.cpp:
(EwkViewEventHandler<EVAS_CALLBACK_MOUSE_IN>::handleEvent):
- UIProcess/LegacySessionStateCodingNone.cpp:
(WebKit::decodeLegacySessionState):
- 10:34 PM Changeset in webkit [171290] by
-
- 3 edits in trunk/Tools
[EFL] Enable mpg123 feature for gst-plugin-bad.
https://bugs.webkit.org/show_bug.cgi?id=135016
Patch by KwangHyuk Kim <hyuki.kim@samsung.com> on 2014-07-20
Reviewed by Laszlo Gombos.
enable-mpg123 feature is added to jhbuild in order to support playback of mp3 format.
- efl/install-dependencies:
- efl/jhbuild.modules:
- 9:30 PM Changeset in webkit [171289] by
-
- 2 edits in trunk/Source/WebCore
Reduce the chances of a race condition when sharing SharedBuffer
https://bugs.webkit.org/show_bug.cgi?id=135060
<rdar://problem/17729444>
Reviewed by Darin Adler.
We currently pass a SharedBuffer wrapped in WebCoreSharedBufferData to ImageIO for image
decoding. This is not thread safe since ImageIO will access this buffer on a separate
thread. We access SharedBuffer::buffer() on the other thread which resizes the Vector
m_buffer if m_size is greater than the vector size. Since the code in SharedBuffer::append()
sets m_size before appending the data to the buffer, m_size is out of sync with the m_buffer
size for the entire duration of the Vector append which could be doing a lot of copying if
the resource is large. While this change does not fix the race condition, we can at least
reduce the chances of SharedBuffer::buffer() calling resize() by setting m_size after the
cector has finished appending.
No new tests because no functional changes.
- platform/SharedBuffer.cpp:
(WebCore::SharedBuffer::append):
- 8:08 PM Changeset in webkit [171288] by
-
- 17 edits in trunk/Source
Disable ff/rw based on canPlayFastForward and canPlayFastRewind.
https://bugs.webkit.org/show_bug.cgi?id=134894
Patch by Jeremy Jones <jeremyj@apple.com> on 2014-07-20
Reviewed by Darin Adler.
Source/WebCore:
- WebCore.exp.in: add symbol for canPlayFastReverse
- html/HTMLMediaElement.cpp: Add two new accessors
(WebCore::HTMLMediaElement::nextScanRate): possibly limit scanRate
(WebCore::HTMLMediaElement::canPlayFastForward): added
(WebCore::HTMLMediaElement::canPlayFastReverse): added
- html/HTMLMediaElement.h: declare two new methods
- platform/graphics/MediaPlayer.cpp: Plumb through two new accessors
(WebCore::MediaPlayer::maxFastForwardRate): added
(WebCore::MediaPlayer::minFastReverseRate): added
- platform/graphics/MediaPlayer.h: Declare new methods
- platform/graphics/MediaPlayerPrivate.h: Added two new methods.
(WebCore::MediaPlayerPrivateInterface::maxFastForwardRate): added
(WebCore::MediaPlayerPrivateInterface::minFastReverseRate): added
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h: member to cache ff/rw enabled state
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayer): observe on item canPlayFastForward canPlayFastReverse
(WebCore::MediaPlayerPrivateAVFoundationObjC::canPlayFastForwardDidChange): added
(WebCore::MediaPlayerPrivateAVFoundationObjC::canPlayFastReverseDidChange): added
(WebCore::itemKVOProperties): observe canPlayFastForward canPlayFastRewind
(-[WebCoreAVFMovieObserver observeValueForKeyPath:ofObject:change:context:]): ditto
- platform/ios/WebVideoFullscreenInterface.h: add new method
- platform/ios/WebVideoFullscreenInterfaceAVKit.h: ditto
- platform/ios/WebVideoFullscreenInterfaceAVKit.mm: ditto
(WebVideoFullscreenInterfaceAVKit::setCanPlayFastReverse): Set value on WebAVPlayerController.
(-[WebAVPlayerController canScanBackward]): Deleted.
(+[WebAVPlayerController keyPathsForValuesAffectingCanScanBackward]): Deleted.
- platform/ios/WebVideoFullscreenModelMediaElement.mm:
(WebVideoFullscreenModelMediaElement::updateForEventName): update canPlayFastReverse.
Source/WebKit2:
Add setCanPlayFastReverse
- UIProcess/ios/WebVideoFullscreenManagerProxy.messages.in: ditto
- WebProcess/ios/WebVideoFullscreenManager.h: ditto
- WebProcess/ios/WebVideoFullscreenManager.mm: ditto
(WebKit::WebVideoFullscreenManager::setCanPlayFastReverse): ditto
- 7:34 PM Changeset in webkit [171287] by
-
- 2 edits in trunk/Source/WebCore
HTMLMediaElement should registerWithDocument on iOS
https://bugs.webkit.org/show_bug.cgi?id=135084
<rdar://problem/17702531>
Reviewed by Andreas Kling.
Otherwise it won't know when the visibility changes!
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::registerWithDocument):
(WebCore::HTMLMediaElement::unregisterWithDocument):
- 7:30 PM Changeset in webkit [171286] by
-
- 10 edits in trunk/Source
Decrease flicker when enter and exit fullscreen.
https://bugs.webkit.org/show_bug.cgi?id=134919
Patch by Jeremy Jones <jeremyj@apple.com> on 2014-07-20
Reviewed by Simon Fraser.
Source/WebCore:
Put AVPlayerLayer in a container layer so moving it between inline and fullscreen
is as easy as adding and removing it from a containter layer; no need to do a layout.
Make sure fullscreen layers are transparent before moving moving the AVPlayerLayer
between inline and fullscreen so you don't briefly see the empty fullscreen layers.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::platformLayer): remove fullscreen special case.
(WebCore::HTMLMediaElement::setVideoFullscreenLayer): no need to recalc style
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h: add inline container layer
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
add WebVideoContainerLayer to contain AVPlayerLayer and keep layout correct.
(-[WebVideoContainerLayer setBounds:]): forward setbounds to set child frame.
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerLayer): create the video container layer
(WebCore::MediaPlayerPrivateAVFoundationObjC::destroyVideoLayer): destroy the video container layer
(WebCore::MediaPlayerPrivateAVFoundationObjC::platformLayer): use container layer instead of video layer
(WebCore::MediaPlayerPrivateAVFoundationObjC::setVideoFullscreenLayer): use transactions to prevent unwanted animation.
(WebCore::MediaPlayerPrivateAVFoundationObjC::setVideoFullscreenFrame): ditto
- platform/graphics/ca/mac/PlatformCALayerMac.mm:
(PlatformCALayerMac::layerTypeForPlatformLayer): WebVideoContainerLayer is a kind of AVPlayerLayer
- platform/ios/WebVideoFullscreenControllerAVKit.mm:
(-[WebVideoFullscreenController didCleanupFullscreen]): remove video fullscreen layer first
- platform/ios/WebVideoFullscreenInterfaceAVKit.mm:
(WebVideoFullscreenInterfaceAVKit::setupFullscreen): make background transparent during transition.
dispatch_async to allow CATransaction to complete before calling didSetupFullscreen()
Source/WebKit2:
Change the sequence of tear down and use transparency to prevent flicker when entering and exiting fullscreen.
- UIProcess/ios/WebVideoFullscreenManagerProxy.mm: wait to remove layerHost until didCleanupFullscreen
(WebKit::WebVideoFullscreenManagerProxy::didExitFullscreen): removed from here
(WebKit::WebVideoFullscreenManagerProxy::didCleanupFullscreen): added here
- WebProcess/ios/WebVideoFullscreenManager.mm:
(WebKit::WebVideoFullscreenManager::didSetupFullscreen): use transparent background during transition
- 7:19 PM Changeset in webkit [171285] by
-
- 17 edits in trunk/Source/WebCore
Move ExceptionCodeDescription.h into the files that actually need it
https://bugs.webkit.org/show_bug.cgi?id=134968
Reviewed by Darin Adler.
No new tests because no functional changes.
- Modules/indexeddb/IDBDatabaseException.cpp:
- Modules/webdatabase/SQLException.cpp:
- bindings/js/JSDOMBinding.cpp:
- bindings/objc/ExceptionHandlers.mm:
- bindings/scripts/CodeGeneratorGObject.pm:
(Generate):
- dom/DOMCoreException.cpp:
- dom/EventException.cpp:
- dom/ExceptionBase.cpp:
- dom/ExceptionCode.h:
- dom/RangeException.cpp:
- fileapi/FileException.cpp:
- inspector/DOMEditor.cpp:
- inspector/InspectorDOMAgent.cpp:
- svg/SVGException.cpp:
- xml/XMLHttpRequestException.cpp:
- xml/XPathException.cpp:
- 5:34 PM Changeset in webkit [171284] by
-
- 4 edits1 add in trunk
Source/WebCore: <rdar://problems/17742611> -[_WKActivatedElementInfo image] is often empty
https://bugs.webkit.org/show_bug.cgi?id=135107
Reviewed by Sam Weinig.
Test: TestWebKitAPI/Tests/mac/RenderedImageFromDOMNode.mm
- page/FrameView.cpp:
(WebCore::FrameView::paintContents): To work around http://webkit.org/b/135106, replace the
paint root with its nearest ancestor that isn’t an inline with culled line boxes, if needed.
Tools: Test for <rdar://problems/17742611> -[_WKActivatedElementInfo image] is often empty
https://bugs.webkit.org/show_bug.cgi?id=135107
Reviewed by Sam Weinig.
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/mac/RenderedImageFromDOMNode.mm: Added.
(-[RenderedImageFromDOMNodeFrameLoadDelegate webView:didFinishLoadForFrame:]):
(TestWebKitAPI::TEST):
- 1:11 PM Changeset in webkit [171283] by
-
- 4 edits in trunk/Source/WebCore
Crashes seen in wheel event handling
https://bugs.webkit.org/show_bug.cgi?id=135102
Reviewed by Beth Dakin.
Speculative fix based on guesses about what could be crashing.
The crash seems to be calling ref on an event target, and my guess is that this
has something to do with latching.
- page/EventHandler.cpp:
(WebCore::EventHandler::platformPrepareForWheelEvents): Updated argument types.
(WebCore::EventHandler::handleWheelEvent): Refactored a little and made some local
variables use RefPtr instead of raw pointers. Also added some comments.
- page/EventHandler.h: Changed argument types to RefPtr.
- page/mac/EventHandlerMac.mm:
(WebCore::EventHandler::platformPrepareForWheelEvents): Updated argument types.
Also added a FIXME.
- 11:33 AM WikiStart edited by
- (diff)
- 11:31 AM JavaScriptCore edited by
- (diff)
- 11:27 AM FTLJIT edited by
- (diff)
- 11:00 AM Changeset in webkit [171282] by
-
- 2 edits in trunk/Source/WebCore
Print layerIDs in GraphicsLayer dumps
https://bugs.webkit.org/show_bug.cgi?id=135100
Reviewed by Darin Adler.
When calling showGraphicsLayerTree() from the debugger, it's useful to show
layerIDs so they can be correlated with remote layer tree transactions. So
when dumping with debug info, dump the primary layer ID.
- platform/graphics/GraphicsLayer.cpp:
(WebCore::GraphicsLayer::dumpProperties):
- 9:49 AM Changeset in webkit [171281] by
-
- 1 edit in trunk/Source/WebKit2/ChangeLog
Updated Radar link
- 9:48 AM Changeset in webkit [171280] by
-
- 2 edits in trunk/Source/WebKit2
<rdar://problem/17739804> REGRESSION (r171057): Crash in WebPage::getPositionInformation()
https://bugs.webkit.org/show_bug.cgi?id=135099
Reviewed by David Kilzer.
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::getPositionInformation): Added a null check.
- 9:45 AM Changeset in webkit [171279] by
-
- 2 edits in trunk/Source/WebCore
[iOS] ignore requests to set volume
https://bugs.webkit.org/show_bug.cgi?id=135081
Applied post-review comments from Darin Adler.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::setVolume): Don't include unreachable
code on iOS.
- 9:16 AM Changeset in webkit [171278] by
-
- 7 edits in trunk
ES6: Implement Math.sign()
https://bugs.webkit.org/show_bug.cgi?id=134980
Patch by Diego Pino Garcia <Diego Pino Garcia> on 2014-07-20
Reviewed by Darin Adler.
Source/JavaScriptCore:
- runtime/MathObject.cpp:
(JSC::MathObject::finishCreation):
(JSC::mathProtoFuncSign):
LayoutTests:
- js/script-tests/Object-getOwnPropertyNames.js:
- js/script-tests/math.js:
- 8:08 AM Changeset in webkit [171277] by
-
- 2 edits in trunk/Tools
Checker: Value stored to 'kernResult' is never read (LayoutTestHelper.m:164)
<http://webkit.org/b/135096>
Reviewed by Alexey Proskuryakov.
- DumpRenderTree/mac/LayoutTestHelper.m:
(lockDownDiscreteGraphics): Check the return values of
IOServiceOpen() and IOObjectRelease(), and log if not
KERN_SUCCESS.
Jul 19, 2014:
- 9:32 PM Changeset in webkit [171276] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: TextContentView calls wrong prototype function in the hidden() function
https://bugs.webkit.org/show_bug.cgi?id=135097
Patch by Saam Barati <sbarati@apple.com> on 2014-07-19
Reviewed by Timothy Hatcher.
Corollary bug to: https://bugs.webkit.org/show_bug.cgi?id=135001
- UserInterface/Views/TextContentView.js:
(WebInspector.TextContentView.prototype.hidden):
- 5:04 PM Changeset in webkit [171275] by
-
- 3 edits in branches/safari-537.78-branch
Merged r170946. <rdar://problem/17684656>
- 4:59 PM Changeset in webkit [171274] by
-
- 3 edits in branches/safari-537.78-branch
Merged r170135. <rdar://problem/17684651>
- 4:31 PM Changeset in webkit [171273] by
-
- 3 edits1 copy in branches/safari-537.78-branch/Source/WebKit2
Merged r169448. <rdar://problem/17684663>
- 4:19 PM Changeset in webkit [171272] by
-
- 2 edits in branches/safari-537.78-branch/Source/WebCore
Merged r170513. <rdar://problem/17684622>
- 4:07 PM Changeset in webkit [171271] by
-
- 3 edits in branches/safari-537.78-branch/Source/WebCore
Merged r170028. <rdar://problem/17689801>
- 4:03 PM Changeset in webkit [171270] by
-
- 2 edits in branches/safari-537.78-branch/Source/WebCore
Merged r170026. <rdar://problem/17689834>
- 4:00 PM Changeset in webkit [171269] by
-
- 3 edits3 copies in branches/safari-537.78-branch
Merged r169849. <rdar://problem/17684636>
- 3:56 PM Changeset in webkit [171268] by
-
- 3 edits2 copies in branches/safari-537.78-branch
Merged r169848. <rdar://problem/17684630>
- 3:50 PM Changeset in webkit [171267] by
-
- 2 edits in branches/safari-537.78-branch/Source/WebKit2
Merged r169757. <rdar://problem/17684670>
- 3:48 PM Changeset in webkit [171266] by
-
- 2 edits in branches/safari-537.78-branch/Source/WebCore
Merged r169726. <rdar://problem/17684616>
- 1:15 PM Changeset in webkit [171265] by
-
- 2 edits in trunk/Tools
Update.
- Scripts/webkitpy/common/config/watchlist:
- 11:07 AM Changeset in webkit [171264] by
-
- 3 edits in trunk/Source/WebCore
<https://webkit.org/b/135085> Ensure that make_names.pl generates the same result when run multiple times.
Perl 5.18 introduced hash randomization. This results in the iteration order of hashes being different
from one run to the next. To ensure identical output we can iterate over the hash keys in sorted order.
Reviewed by Alexey Proskuryakov.
- bindings/scripts/StaticString.pm:
(GenerateStrings):
(GenerateStringAsserts):
- dom/make_names.pl:
- 9:24 AM WebKitGTK/KeepingTheTreeGreen edited by
- (diff)
- 9:16 AM Changeset in webkit [171263] by
-
- 2 edits in trunk/LayoutTests
[GTK] Unreviewed GTK gardening.
- platform/gtk/TestExpectations: Report and mark new failures. Update some expectations.
- 3:10 AM Changeset in webkit [171262] by
-
- 2 edits in trunk/Source/WTF
[WTF] Add the move constructor, move assignment operator for HashTable
https://bugs.webkit.org/show_bug.cgi?id=130772
Reviewed by Darin Adler.
HashTable has both copy constructor and copy assignment operator, meaning that the move constructor
and move assignment operator are implicitly deleted. This patch defines both to avoid unnecessary
copies when moves can be performed.
- wtf/HashTable.h:
(WTF::KeyTraits>::HashTable):
- 3:08 AM Changeset in webkit [171261] by
-
- 2 edits in trunk/Source/WebCore
Document::unregisterNodeListforInvalidation() and Document::unregisterCollection() have incorrect assertions
https://bugs.webkit.org/show_bug.cgi?id=134869
Reviewed by Darin Adler.
Both methods should assert that the relevant HashMap is either empty if invalidation originates
from Document::invalidateNodeListAndCollectionCaches() or acutally contains the element that is
being invalidated. In the first case the HashMap is empty because its entries were moved out in
the Document::invalidateNodeListAndCollectionCaches().
This was exposed by r170995 (later rolled out in r170999) which introduced move constructor and
move assignment operators for HashTable. The assertions in the titular methods won't be passing
until r170995 relands.
- dom/Document.cpp:
(WebCore::Document::unregisterNodeListForInvalidation):
- 3:02 AM Changeset in webkit [171260] by
-
- 4 edits in trunk/Source/WebKit2
Consistently use uint64_t as the handle parameter type for the SetAcceleratedCompositingWindowId message
https://bugs.webkit.org/show_bug.cgi?id=135047
Reviewed by Darin Adler.
UIProcess' WebPageProxy is handling this parameter as an uint64_t, it should be handled as such
in WebProcess as well.
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in: Also changed the parameter name to match other places.
- WebProcess/WebPage/gtk/WebPageGtk.cpp:
(WebKit::WebPage::setAcceleratedCompositingWindowId):
