Timeline



Jul 30, 2014:

11:51 PM Changeset in webkit [171843] by akling@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Speculative Windows build fix.

Try to dllimport the dllexported global object HashTable.

  • jsc.cpp:
  • testRegExp.cpp:
11:17 PM Changeset in webkit [171842] by Lucas Forschler
  • 5 edits in branches/safari-600.1-branch/Source

Versioning.

11:06 PM Changeset in webkit [171841] by Lucas Forschler
  • 1 copy in tags/Safari-600.1.6

New Tag.

10:49 PM Changeset in webkit [171840] by Lucas Forschler
  • 10 edits
    2 copies in branches/safari-600.1-branch

Merged r171825.

10:40 PM Changeset in webkit [171839] by Lucas Forschler
  • 2 edits in branches/safari-600.1-branch/Source/WebCore

Merged r171802. <rdar://problem/17199364>

10:38 PM Changeset in webkit [171838] by akling@apple.com
  • 10 edits in trunk/Source

PropertyName's internal string is always atomic.
<​https://webkit.org/b/135451>

Source/JavaScriptCore:
Now that we've merged the JSC::Identifier and WTF::AtomicString tables,
we know that any string that's an Identifier is guaranteed to be atomic.

A PropertyName can be either an Identifier or a PrivateName, and the
private names are also guaranteed to be atomic internally.

Make PropertyName vend AtomicStringImpl* instead of StringImpl*.

Reviewed by Benjamin Poulain.

  • runtime/PropertyName.h:

(JSC::PropertyName::PropertyName):
(JSC::PropertyName::uid):
(JSC::PropertyName::publicName):

Source/WebCore:
Use PropertyName::publicName() directly instead of taking the slow route
through AtomicString::findStringWithHash().

These strings are always atomic, and findStringWithHash() would trudge
through a full hash lookup just to discover that indeed, they are!

Reviewed by Benjamin Poulain.

  • bindings/js/JSDOMBinding.cpp:

(WebCore::findAtomicString): Deleted.

  • bindings/js/JSDOMBinding.h:
  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::namedItemGetter):
(WebCore::JSDOMWindow::getOwnPropertySlot):
(WebCore::JSDOMWindow::getOwnPropertySlotByIndex):

  • bindings/js/JSHTMLDocumentCustom.cpp:

(WebCore::JSHTMLDocument::canGetItemsForName):
(WebCore::JSHTMLDocument::nameGetter):

Source/WTF:
Remove AtomicString::findStringWithHash() since nobody uses it anymore.

Reviewed by Benjamin Poulain.

  • wtf/text/AtomicString.cpp:

(WTF::findString): Deleted.
(WTF::AtomicString::findStringWithHash): Deleted.

  • wtf/text/AtomicString.h:
8:36 PM Changeset in webkit [171837] by Lucas Forschler
  • 2 edits in branches/safari-600.1-branch/Source/WebKit2

Merged r171829. <rdar://problem/17824833>

8:19 PM Changeset in webkit [171836] by benjamin@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

Add a layout test for Geolocation's request queueing for hidden pages
​https://bugs.webkit.org/show_bug.cgi?id=135402

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2014-07-30
Reviewed by Zalan Bujtas.

Sam added the queueing feature in r171188. This patch adds a layout test
for the simplest case.

  • fast/dom/Geolocation/requestQueuingForHiddenPage-expected.txt: Added.
  • fast/dom/Geolocation/requestQueuingForHiddenPage.html: Added.
8:18 PM Changeset in webkit [171835] by benjamin@webkit.org
  • 2 edits in trunk/Source/WebCore

ElementRuleCollector: group the shadow tree code
​https://bugs.webkit.org/show_bug.cgi?id=135410

Reviewed by Andreas Kling.

  • css/ElementRuleCollector.cpp:

(WebCore::ElementRuleCollector::collectMatchingRules):
Little cleanup: group the shadow tree rule collection in the same block.

8:17 PM Changeset in webkit [171834] by benjamin@webkit.org
  • 3 edits in trunk/Source/WebCore

Cleanup DetailsMarkerControl
​https://bugs.webkit.org/show_bug.cgi?id=135429

Reviewed by Andreas Kling.

Remove the override of shadowPseudoId(). This is a simple type of shadowId,
it should use the generic pseudo() path.

Move DetailsMarkerControl::create() out-of-line. One could justify inlining the constructor,
inlining the ::create() function has little value.

  • html/shadow/DetailsMarkerControl.cpp:

(WebCore::DetailsMarkerControl::create):
(WebCore::DetailsMarkerControl::DetailsMarkerControl):
(WebCore::DetailsMarkerControl::rendererIsNeeded):
(WebCore::DetailsMarkerControl::shadowPseudoId): Deleted.
(WebCore::DetailsMarkerControl::summaryElement): Deleted.

  • html/shadow/DetailsMarkerControl.h:

(WebCore::DetailsMarkerControl::create): Deleted.

8:16 PM Changeset in webkit [171833] by benjamin@webkit.org
  • 3 edits in trunk/Source/WebCore

Remove UploadButtonElement::shadowPseudoId()
​https://bugs.webkit.org/show_bug.cgi?id=135435

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2014-07-30
Reviewed by Andreas Kling.

Use the generic pseudo() path instead of a custom shadowPseudoId().

  • html/FileInputType.cpp:

(WebCore::UploadButtonElement::create):
(WebCore::UploadButtonElement::createForMultiple):
(WebCore::UploadButtonElement::UploadButtonElement):
Set the type in the common constructor instead of the call sites.
(WebCore::UploadButtonElement::shadowPseudoId): Deleted.

  • html/FileInputType.h:
8:16 PM Changeset in webkit [171832] by benjamin@webkit.org
  • 3 edits in trunk/Source/WebCore

Remove SpinButtonElement::shadowPseudoId
​https://bugs.webkit.org/show_bug.cgi?id=135436

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2014-07-30
Reviewed by Andreas Kling.

Use the generic pseudo.

  • html/shadow/SpinButtonElement.cpp:

(WebCore::SpinButtonElement::SpinButtonElement):
(WebCore::SpinButtonElement::shadowPseudoId): Deleted.

  • html/shadow/SpinButtonElement.h:
8:15 PM Changeset in webkit [171831] by benjamin@webkit.org
  • 3 edits in trunk/Source/WebCore

Clean up YouTubeEmbedShadowElement
​https://bugs.webkit.org/show_bug.cgi?id=135437

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2014-07-30
Reviewed by Andreas Kling.

  • html/shadow/YouTubeEmbedShadowElement.cpp:

(WebCore::YouTubeEmbedShadowElement::YouTubeEmbedShadowElement):
(WebCore::YouTubeEmbedShadowElement::pluginElement): Deleted.
This is unused in WebCore.

(WebCore::YouTubeEmbedShadowElement::shadowPseudoId): Deleted.
Use the generic pseudo path instead of a custom shadowPseudoId.

  • html/shadow/YouTubeEmbedShadowElement.h:
8:14 PM Changeset in webkit [171830] by benjamin@webkit.org
  • 3 edits in trunk/Source/WebCore

Remove shadowPseudoId() from InputFieldSpeechButtonElement and SearchFieldCancelButtonElement
​https://bugs.webkit.org/show_bug.cgi?id=135438

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2014-07-30
Reviewed by Andreas Kling.

Use the generic path.

  • html/shadow/TextControlInnerElements.cpp:

(WebCore::SearchFieldCancelButtonElement::SearchFieldCancelButtonElement):
(WebCore::InputFieldSpeechButtonElement::InputFieldSpeechButtonElement):
(WebCore::SearchFieldCancelButtonElement::shadowPseudoId): Deleted.
(WebCore::InputFieldSpeechButtonElement::shadowPseudoId): Deleted.

  • html/shadow/TextControlInnerElements.h:
7:19 PM Changeset in webkit [171829] by enrica@apple.com
  • 2 edits in trunk/Source/WebKit2

REGRESSION (WK2 iOS): Inline editing for Chinese and Japanese keyboards does not work in Safari.
​https://bugs.webkit.org/show_bug.cgi?id=135449
<rdar://problem/17824833>

Reviewed by Benjamin Poulain.

The WebProcess sends the notification that the gesture modified the phrase boundary,
but the flag was not being converted properly, therefore we failed to notify
the text input system that a change had occurred.

  • UIProcess/ios/WKContentViewInteraction.mm:

(toUIWKSelectionFlags):

6:48 PM Changeset in webkit [171828] by bshafiei@apple.com
  • 5 edits in tags/Safari-600.1.3.41/Source

Versioning.

6:46 PM Changeset in webkit [171827] by bshafiei@apple.com
  • 1 copy in tags/Safari-600.1.3.41

New tag.

6:13 PM Changeset in webkit [171826] by aestes@apple.com
  • 25 edits in trunk/Source

USE(CONTENT_FILTERING) should be ENABLE(CONTENT_FILTERING)
​https://bugs.webkit.org/show_bug.cgi?id=135439

Reviewed by Tim Horton.

We now support two different platform content filters, and will soon support a mock content filter (as part of
webkit.org/b/128858). This makes content filtering a feature of WebKit, not just an adoption of a third-party
library. ENABLE() is the correct macro to use for such a feature.

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

  • Configurations/FeatureDefines.xcconfig:
  • WebCore.exp.in:
  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::finishedLoading):
(WebCore::DocumentLoader::responseReceived):
(WebCore::DocumentLoader::commitData):
(WebCore::DocumentLoader::dataReceived):

  • loader/DocumentLoader.h:
  • loader/FrameLoaderClient.h:
  • platform/ContentFilter.h:
  • platform/ios/ContentFilterIOS.mm:
  • platform/mac/ContentFilterMac.mm:

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:
  • Shared/WebCoreArgumentCoders.h:
  • UIProcess/WebFrameProxy.cpp:

(WebKit::WebFrameProxy::didStartProvisionalLoad):

  • UIProcess/WebFrameProxy.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::decidePolicyForNavigationAction):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.h:

Source/WTF:

  • wtf/Platform.h:
3:54 PM Changeset in webkit [171825] by matthew_hanson@apple.com
  • 10 edits
    1 copy
    2 adds in tags/Safari-600.1.2.4

Merge r171798. <rdar://problem/17849033>

3:26 PM Changeset in webkit [171824] by akling@apple.com
  • 226 edits
    2 deletes in trunk/Source

Static hash tables no longer need to be coupled with a VM.
<​https://webkit.org/b/135421>

Source/JavaScriptCore:
Now that the static hash tables are using char instead of StringImpl,
it's no longer necessary to make them per-VM.

This patch removes the hook in ClassInfo for providing your own static
hash table getter. Everyone now uses ClassInfo::staticPropHashTable.
Most of this patch is tweaking ClassInfo construction sites to pass one
less null pointer.

Also simplified Lookup.h to stop requiring ExecState/VM to access the
static hash tables.

Reviewed by Geoffrey Garen.

  • API/JSAPIWrapperObject.mm:
  • API/JSCallbackConstructor.cpp:
  • API/JSCallbackFunction.cpp:
  • API/JSCallbackObject.cpp:
  • API/ObjCCallbackFunction.mm:
  • bytecode/UnlinkedCodeBlock.cpp:
  • create_hash_table:
  • debugger/DebuggerScope.cpp:
  • inspector/JSInjectedScriptHost.cpp:
  • inspector/JSInjectedScriptHostPrototype.cpp:
  • inspector/JSJavaScriptCallFrame.cpp:
  • inspector/JSJavaScriptCallFramePrototype.cpp:
  • interpreter/CallFrame.h:

(JSC::ExecState::arrayConstructorTable): Deleted.
(JSC::ExecState::arrayPrototypeTable): Deleted.
(JSC::ExecState::booleanPrototypeTable): Deleted.
(JSC::ExecState::dataViewTable): Deleted.
(JSC::ExecState::dateTable): Deleted.
(JSC::ExecState::dateConstructorTable): Deleted.
(JSC::ExecState::errorPrototypeTable): Deleted.
(JSC::ExecState::globalObjectTable): Deleted.
(JSC::ExecState::jsonTable): Deleted.
(JSC::ExecState::numberConstructorTable): Deleted.
(JSC::ExecState::numberPrototypeTable): Deleted.
(JSC::ExecState::objectConstructorTable): Deleted.
(JSC::ExecState::privateNamePrototypeTable): Deleted.
(JSC::ExecState::regExpTable): Deleted.
(JSC::ExecState::regExpConstructorTable): Deleted.
(JSC::ExecState::regExpPrototypeTable): Deleted.
(JSC::ExecState::stringConstructorTable): Deleted.
(JSC::ExecState::promisePrototypeTable): Deleted.
(JSC::ExecState::promiseConstructorTable): Deleted.

  • jsc.cpp:
  • parser/Lexer.h:

(JSC::Keywords::isKeyword):
(JSC::Keywords::getKeyword):

  • runtime/Arguments.cpp:
  • runtime/ArgumentsIteratorConstructor.cpp:
  • runtime/ArgumentsIteratorPrototype.cpp:
  • runtime/ArrayBufferNeuteringWatchpoint.cpp:
  • runtime/ArrayConstructor.cpp:

(JSC::ArrayConstructor::getOwnPropertySlot):

  • runtime/ArrayIteratorConstructor.cpp:
  • runtime/ArrayIteratorPrototype.cpp:
  • runtime/ArrayPrototype.cpp:

(JSC::ArrayPrototype::getOwnPropertySlot):

  • runtime/BooleanConstructor.cpp:
  • runtime/BooleanObject.cpp:
  • runtime/BooleanPrototype.cpp:

(JSC::BooleanPrototype::getOwnPropertySlot):

  • runtime/ClassInfo.h:

(JSC::ClassInfo::hasStaticProperties):
(JSC::ClassInfo::propHashTable): Deleted.

  • runtime/ConsolePrototype.cpp:
  • runtime/CustomGetterSetter.cpp:
  • runtime/DateConstructor.cpp:

(JSC::DateConstructor::getOwnPropertySlot):

  • runtime/DateInstance.cpp:
  • runtime/DatePrototype.cpp:

(JSC::DatePrototype::getOwnPropertySlot):

  • runtime/Error.cpp:
  • runtime/ErrorConstructor.cpp:
  • runtime/ErrorInstance.cpp:
  • runtime/ErrorPrototype.cpp:

(JSC::ErrorPrototype::getOwnPropertySlot):

  • runtime/ExceptionHelpers.cpp:
  • runtime/Executable.cpp:
  • runtime/FunctionConstructor.cpp:
  • runtime/FunctionPrototype.cpp:
  • runtime/GetterSetter.cpp:
  • runtime/InternalFunction.cpp:
  • runtime/JSAPIValueWrapper.cpp:
  • runtime/JSActivation.cpp:
  • runtime/JSArgumentsIterator.cpp:
  • runtime/JSArray.cpp:
  • runtime/JSArrayBuffer.cpp:
  • runtime/JSArrayBufferConstructor.cpp:
  • runtime/JSArrayBufferPrototype.cpp:
  • runtime/JSArrayBufferView.cpp:
  • runtime/JSArrayIterator.cpp:
  • runtime/JSBoundFunction.cpp:
  • runtime/JSConsole.cpp:
  • runtime/JSDataView.cpp:
  • runtime/JSDataViewPrototype.cpp:

(JSC::JSDataViewPrototype::getOwnPropertySlot):

  • runtime/JSFunction.cpp:
  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::getOwnPropertySlot):

  • runtime/JSMap.cpp:
  • runtime/JSMapIterator.cpp:
  • runtime/JSNameScope.cpp:
  • runtime/JSNotAnObject.cpp:
  • runtime/JSONObject.cpp:

(JSC::JSONObject::getOwnPropertySlot):

  • runtime/JSObject.cpp:

(JSC::getClassPropertyNames):
(JSC::JSObject::put):
(JSC::JSObject::deleteProperty):
(JSC::JSObject::findPropertyHashEntry):
(JSC::JSObject::reifyStaticFunctionsForDelete):

  • runtime/JSObject.h:
  • runtime/JSPromise.cpp:
  • runtime/JSPromiseConstructor.cpp:

(JSC::JSPromiseConstructor::getOwnPropertySlot):

  • runtime/JSPromiseDeferred.cpp:
  • runtime/JSPromisePrototype.cpp:

(JSC::JSPromisePrototype::getOwnPropertySlot):

  • runtime/JSPromiseReaction.cpp:
  • runtime/JSPropertyNameIterator.cpp:
  • runtime/JSProxy.cpp:
  • runtime/JSSet.cpp:
  • runtime/JSSetIterator.cpp:
  • runtime/JSString.cpp:
  • runtime/JSTypedArrayConstructors.cpp:
  • runtime/JSTypedArrayPrototypes.cpp:
  • runtime/JSTypedArrays.cpp:
  • runtime/JSVariableObject.cpp:
  • runtime/JSWeakMap.cpp:
  • runtime/JSWithScope.cpp:
  • runtime/Lookup.cpp:

(JSC::HashTable::createTable):

  • runtime/Lookup.h:

(JSC::HashTable::initializeIfNeeded):
(JSC::HashTable::entry):
(JSC::HashTable::begin):
(JSC::HashTable::end):
(JSC::getStaticPropertySlot):
(JSC::getStaticFunctionSlot):
(JSC::getStaticValueSlot):
(JSC::lookupPut):

  • runtime/MapConstructor.cpp:
  • runtime/MapData.cpp:
  • runtime/MapIteratorConstructor.cpp:
  • runtime/MapIteratorPrototype.cpp:
  • runtime/MapPrototype.cpp:
  • runtime/MathObject.cpp:
  • runtime/NameConstructor.cpp:
  • runtime/NameInstance.cpp:
  • runtime/NamePrototype.cpp:

(JSC::NamePrototype::getOwnPropertySlot):

  • runtime/NativeErrorConstructor.cpp:
  • runtime/NumberConstructor.cpp:

(JSC::NumberConstructor::getOwnPropertySlot):

  • runtime/NumberObject.cpp:
  • runtime/NumberPrototype.cpp:

(JSC::NumberPrototype::getOwnPropertySlot):

  • runtime/ObjectConstructor.cpp:

(JSC::ObjectConstructor::getOwnPropertySlot):

  • runtime/ObjectPrototype.cpp:
  • runtime/PropertyTable.cpp:
  • runtime/RegExp.cpp:
  • runtime/RegExpConstructor.cpp:

(JSC::RegExpConstructor::getOwnPropertySlot):

  • runtime/RegExpMatchesArray.cpp:
  • runtime/RegExpObject.cpp:

(JSC::RegExpObject::getOwnPropertySlot):

  • runtime/RegExpPrototype.cpp:

(JSC::RegExpPrototype::getOwnPropertySlot):

  • runtime/SetConstructor.cpp:
  • runtime/SetIteratorConstructor.cpp:
  • runtime/SetIteratorPrototype.cpp:
  • runtime/SetPrototype.cpp:
  • runtime/SparseArrayValueMap.cpp:
  • runtime/StrictEvalActivation.cpp:
  • runtime/StringConstructor.cpp:

(JSC::StringConstructor::getOwnPropertySlot):

  • runtime/StringObject.cpp:
  • runtime/StringPrototype.cpp:
  • runtime/Structure.cpp:

(JSC::Structure::Structure):
(JSC::Structure::freezeTransition):
(JSC::ClassInfo::hasStaticSetterOrReadonlyProperties):

  • runtime/StructureChain.cpp:
  • runtime/StructureRareData.cpp:
  • runtime/SymbolTable.cpp:
  • runtime/VM.cpp:

(JSC::VM::VM):
(JSC::VM::~VM):

  • runtime/VM.h:
  • runtime/WeakMapConstructor.cpp:
  • runtime/WeakMapData.cpp:
  • runtime/WeakMapPrototype.cpp:
  • testRegExp.cpp:

Source/WebCore:
Update for JSC::ClassInfo changes.

Remove the JSNoStaticTables mode for IDL code generation, which was used to
ensure that each VM had its own unique copy of certain static tables.
This was used for interfaces that could be used in workers, and now there's
no need to manually annotate these things anymore.

Also remove the DOMObjectHashTableMap class that was only used for this.

Reviewed by Geoffrey Garen.

  • Modules/indexeddb/IDBAny.idl:
  • Modules/indexeddb/IDBCursor.idl:
  • Modules/indexeddb/IDBCursorWithValue.idl:
  • Modules/indexeddb/IDBDatabase.idl:
  • Modules/indexeddb/IDBFactory.idl:
  • Modules/indexeddb/IDBIndex.idl:
  • Modules/indexeddb/IDBKeyRange.idl:
  • Modules/indexeddb/IDBObjectStore.idl:
  • Modules/indexeddb/IDBOpenDBRequest.idl:
  • Modules/indexeddb/IDBRequest.idl:
  • Modules/indexeddb/IDBTransaction.idl:
  • Modules/indexeddb/IDBVersionChangeEvent.idl:
  • Modules/webdatabase/Database.idl:
  • Modules/webdatabase/DatabaseSync.idl:
  • Modules/webdatabase/SQLError.idl:
  • Modules/webdatabase/SQLException.idl:
  • Modules/webdatabase/SQLResultSet.idl:
  • Modules/webdatabase/SQLResultSetRowList.idl:
  • Modules/webdatabase/SQLTransaction.idl:
  • Modules/webdatabase/SQLTransactionSync.idl:
  • Modules/websockets/CloseEvent.idl:
  • Modules/websockets/WebSocket.idl:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/DOMObjectHashTableMap.cpp: Removed.
  • bindings/js/DOMObjectHashTableMap.h: Removed.
  • bindings/js/JSDOMBinding.cpp:

(WebCore::getHashTableForGlobalData): Deleted.

  • bindings/js/JSDOMBinding.h:

(WebCore::getStaticValueSlotEntryWithoutCaching):

  • bindings/js/JSDOMGlobalObject.cpp:
  • bindings/js/JSDOMWindowBase.cpp:
  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::getOwnPropertySlot):
(WebCore::JSDOMWindow::put):

  • bindings/js/JSDOMWindowShell.cpp:
  • bindings/js/JSImageConstructor.cpp:
  • bindings/js/JSLocationCustom.cpp:

(WebCore::JSLocation::putDelegate):

  • bindings/js/JSStorageCustom.cpp:

(WebCore::JSStorage::deleteProperty):
(WebCore::JSStorage::putDelegate):

  • bindings/js/JSWorkerGlobalScopeBase.cpp:
  • bindings/js/WebCoreJSClientData.h:
  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateGetOwnPropertySlotBody):
(GenerateImplementation):
(GenerateConstructorHelperMethods):
(hashTableAccessor): Deleted.
(prototypeHashTableAccessor): Deleted.
(constructorHashTableAccessor): Deleted.

  • bindings/scripts/IDLAttributes.txt:
  • bridge/c/CRuntimeObject.cpp:
  • bridge/c/c_instance.cpp:
  • bridge/objc/ObjCRuntimeObject.mm:
  • bridge/objc/objc_instance.mm:
  • bridge/objc/objc_runtime.mm:
  • bridge/runtime_array.cpp:
  • bridge/runtime_method.cpp:
  • bridge/runtime_object.cpp:
  • crypto/CryptoKey.idl:
  • css/CSSFontFaceLoadEvent.idl:
  • dom/DOMCoreException.idl:
  • dom/DOMStringList.idl:
  • dom/ErrorEvent.idl:
  • dom/Event.idl:
  • dom/EventException.idl:
  • dom/EventListener.idl:
  • dom/MessageChannel.idl:
  • dom/MessageEvent.idl:
  • dom/MessagePort.idl:
  • dom/ProgressEvent.idl:
  • fileapi/Blob.idl:
  • fileapi/File.idl:
  • fileapi/FileError.idl:
  • fileapi/FileException.idl:
  • fileapi/FileList.idl:
  • fileapi/FileReader.idl:
  • fileapi/FileReaderSync.idl:
  • html/DOMURL.idl:
  • page/EventSource.idl:
  • page/WorkerNavigator.idl:
  • workers/DedicatedWorkerGlobalScope.idl:
  • workers/SharedWorkerGlobalScope.idl:
  • workers/WorkerGlobalScope.idl:
  • workers/WorkerLocation.idl:
  • xml/XMLHttpRequest.idl:
  • xml/XMLHttpRequestException.idl:
  • xml/XMLHttpRequestProgressEvent.idl:
  • xml/XMLHttpRequestUpload.idl:

Source/WebKit/mac:
Reviewed by Geoffrey Garen.

  • Plugins/Hosted/ProxyInstance.mm:
  • Plugins/Hosted/ProxyRuntimeObject.mm:

Source/WebKit2:
Reviewed by Geoffrey Garen.

  • WebProcess/Plugins/Netscape/JSNPMethod.cpp:
  • WebProcess/Plugins/Netscape/JSNPObject.cpp:
3:20 PM Changeset in webkit [171823] by Lucas Forschler
  • 5 edits in branches/safari-537.78-branch/Source

Versioning.

3:19 PM Changeset in webkit [171822] by Lucas Forschler
  • 1 copy in tags/Safari-537.78.2

New Tag.

3:05 PM Changeset in webkit [171821] by matthew_hanson@apple.com
  • 5 edits in tags/Safari-600.1.2.4/Source

Versioning.

2:53 PM Changeset in webkit [171820] by matthew_hanson@apple.com
  • 1 copy in tags/Safari-600.1.2.4

New Tag.

2:46 PM Changeset in webkit [171819] by Brian Burg
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: ProbeSetDetailsSection should not create live location links for unresolved breakpoints
​https://bugs.webkit.org/show_bug.cgi?id=135367

Reviewed by Timothy Hatcher.

Regenerate the source code link whenever the breakpoint resolved status changes. If it is
resolved, then we can create a live location link that respects source maps.

  • UserInterface/Views/ProbeSetDetailsSection.js:

(WebInspector.ProbeSetDetailsSection):
(WebInspector.ProbeSetDetailsSection.prototype._updateLinkElement): Added.
(WebInspector.ProbeSetDetailsSection.prototype._probeSetPositionTextOrLink): Deleted.

2:34 PM Changeset in webkit [171818] by rniwa@webkit.org
  • 2 edits in trunk/Websites/perf.webkit.org

Merging platforms mixes baselines and targets into reported data
​https://bugs.webkit.org/show_bug.cgi?id=135260

Reviewed by Geoffrey Garen.

Make sure two test configurations we're merging are of the same type (e.g. baseline, target, current).
Otherwise, we'll erroneously mix up runs for baseline, target, and current (reported values).

  • public/admin/platforms.php:
2:28 PM Changeset in webkit [171817] by psolanki@apple.com
  • 1 edit
    2 moves in trunk/LayoutTests

Move iphone-simulator test results landed in r171094 to the correct directory.

  • platform/ios-sim/fast/events/ontouchstart-active-selector-expected.txt: Renamed from LayoutTests/platform/iphone-simulator/fast/events/ontouchstart-active-selector-expected.txt.
  • platform/ios-sim/fast/events/ontouchstart-active-selector.html: Renamed from LayoutTests/platform/iphone-simulator/fast/events/ontouchstart-active-selector.html.
2:03 PM Changeset in webkit [171816] by mitz@apple.com
  • 5 edits
    2 deletes in trunk/Source/WebKit2

Get rid of the WKNSURLProtectionSpace wrapper
​https://bugs.webkit.org/show_bug.cgi?id=135425

Reviewed by Sam Weinig.

  • Shared/Cocoa/APIObject.mm:

(API::Object::newObject): Don’t allocate WKNSURLProtectionSpace wrappers.

  • Shared/Cocoa/WKNSURLProtectionSpace.h: Removed.
  • Shared/Cocoa/WKNSURLProtectionSpace.mm: Removed.
  • UIProcess/API/Cocoa/WKBrowsingContextController.mm:

(canAuthenticateAgainstProtectionSpaceInFrame): Get the NSURLProtectionSpace from the
WebCore::ProtectionSpace in the WebProtectionSpace.

  • UIProcess/Cocoa/NavigationState.mm:

(WebKit::NavigationState::LoaderClient::canAuthenticateAgainstProtectionSpaceInFrame): Ditto.

  • WebKit2.xcodeproj/project.pbxproj: Removed references to removed files.
1:55 PM Changeset in webkit [171815] by Lucas Forschler
  • 5 edits in branches/safari-537.78-branch/Source

Fix Versioning.

1:45 PM Changeset in webkit [171814] by Lucas Forschler
  • 7 edits
    1 copy in branches/safari-600.1-branch/Source/WebInspectorUI

Merged r171790. <rdar://problem/17848962>

1:44 PM Changeset in webkit [171813] by Lucas Forschler
  • 2 edits in branches/safari-600.1-branch/Source/WebInspectorUI

Merged r171787. <rdar://problem/17852395>

1:40 PM Changeset in webkit [171812] by Lucas Forschler
  • 3 edits in branches/safari-600.1-branch/Source/WebInspectorUI

Merged r171786. <rdar://problem/17852407>

1:36 PM Changeset in webkit [171811] by Lucas Forschler
  • 3 edits
    2 copies in branches/safari-600.1-branch

Merged r171785. <rdar://problem/17851910>

1:33 PM Changeset in webkit [171810] by Lucas Forschler
  • 6 edits in branches/safari-600.1-branch/Source/WebInspectorUI

Merged r171783. <rdar://problem/17848773>

1:31 PM Changeset in webkit [171809] by Lucas Forschler
  • 2 edits in branches/safari-600.1-branch/Source/WebCore

Merged r171766. <rdar://problem/17824645>

1:29 PM Changeset in webkit [171808] by Lucas Forschler
  • 11 edits in branches/safari-600.1-branch/Source

Merged r171749. <rdar://problem/15917314>

1:26 PM Changeset in webkit [171807] by Lucas Forschler
  • 8 edits
    2 copies in branches/safari-600.1-branch

Merged r171718. <rdar://problem/17824793>

1:15 PM Changeset in webkit [171806] by matthew_hanson@apple.com
  • 5 edits in branches/safari-600.1.4-branch/Source

Versioning.

1:13 PM Changeset in webkit [171805] by matthew_hanson@apple.com
  • 1 copy in tags/Safari-600.1.4.1

New Tag.

12:56 PM Changeset in webkit [171804] by matthew_hanson@apple.com
  • 2 edits in branches/safari-600.1.4-branch/Source/WebCore

Merge r171766. <rdar://problem/17824645>

12:50 PM Changeset in webkit [171803] by matthew_hanson@apple.com
  • 2 edits in branches/safari-600.1.4-branch/Source/WebCore

Merge r171702. <rdar://problem/16828238>

12:40 PM Changeset in webkit [171802] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

<rdar://problem/17199364> [Mac] Popup button arrows appear on the left, underlapping text, when the UI layout direction is right-to-left
​https://bugs.webkit.org/show_bug.cgi?id=135426

Reviewed by Dean Jackson.

No test, because the UI layout direction in the test harness is always left-to-right.

  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::popupButton): Forced the user interface layout direction of the
NSPopUpButtonCell to left-to-right. Added a FIXME about how we could make this vary based on
the direction of the <select>, though that would require additional changes elsewhere.

11:56 AM Changeset in webkit [171801] by mitz@apple.com
  • 25 edits in trunk/Source

Source/WebCore: Made Credential hold onto an NSURLCredential when needed.
Work towards fixing ​https://bugs.webkit.org/show_bug.cgi?id=135327

Reviewed by Alexey Proskuryakov.

No change in functionality.

  • WebCore.exp.in: Updated.
  • platform/network/Credential.h: Removed definition of CERTIFICATE_CREDENTIALS_SUPPORTED,

which is not used anymore.

  • platform/network/CredentialBase.h:

(WebCore::CredentialBase::encodingRequiresPlatformData): Added a base implementation that
returns false.

  • platform/network/cf/AuthenticationCF.cpp:

Changed to use the Credential constructor that takes an CFURLCredential, and the new
cfCredential member function. Made the createCF and core functions Windows-only and
therefore removed the CERTIFICATE_CREDENTIALS_SUPPORTED code from them.

  • platform/network/cf/AuthenticationCF.h:
  • platform/network/cf/CredentialStorageCFNet.cpp:

(WebCore::CredentialStorage::getFromPersistentStorage): Changed to construct a Credential
from a CFURLCredential.
(WebCore::CredentialStorage::saveToPersistentStorage): Changed to use the new cfCredential
member function.

  • platform/network/cf/ResourceHandleCFNet.cpp:

(WebCore::ResourceHandle::didReceiveAuthenticationChallenge): Ditto to both.
(WebCore::ResourceHandle::receivedCredential): Ditto.

  • platform/network/cocoa/CredentialCocoa.h:

Replaced the m_identity, m_certificates and m_type member variables with an m_nsCredential
one holding onto an NSURLCredential. Declared constructors from and getters for
NSURLCredential and CFURLCredentialRef.
(WebCore::Credential::encodingRequiresPlatformData): Override that checks the
NSURLCredential if necessary.

  • platform/network/cocoa/CredentialCocoa.mm:

(WebCore::toNSURLCredentialPersistence): New helper function.
(WebCore::toCredentialPersistence): Ditto.
(WebCore::Credential::Credential): Defined constructors to create or take an
NSURLCredential.
(WebCore::Credential::cfCredential): Added.
(WebCore::Credential::nsCredential): Added. Returns nil for the empty credential.
(WebCore::Credential::isEmpty): Changed to check m_nsCredential.
(WebCore::Credential::platformCompare): Changed to compare m_nsCredential if needed.
(WebCore::Credential::encodingRequiresPlatformData): Returns true if the credential is not
a user and a password.

  • platform/network/mac/AuthenticationMac.h: Removed mac and core functions for Credential.
  • platform/network/mac/AuthenticationMac.mm:

(-[WebCoreAuthenticationClientAsChallengeSender useCredential:forAuthenticationChallenge:]):
Changed to use Credential constructor that takes an NSURLCredential.
(WebCore::AuthenticationChallenge::AuthenticationChallenge): Ditto. Also use the
nsCredential getter.

  • platform/network/mac/CredentialStorageMac.mm:

(WebCore::CredentialStorage::getFromPersistentStorage): Use new Credential constructor.

  • platform/network/mac/ResourceHandleMac.mm:

(WebCore::ResourceHandle::didReceiveAuthenticationChallenge): Ditto. Also use the
nsCredential getter.
(WebCore::ResourceHandle::receivedCredential): Ditto.

Source/WebKit/mac: Updated for changes to the WebCore::Credential API.
Work towards fixing ​https://bugs.webkit.org/show_bug.cgi?id=135327

Reviewed by Alexey Proskuryakov.

  • Misc/WebDownload.mm:

(-[WebDownloadInternal download:didReceiveAuthenticationChallenge:]): Use new nsCredential
getter.

  • Plugins/WebBaseNetscapePluginView.mm:

(WebKit::getAuthenticationInfo): Ditto.

Source/WebKit2: Updated for changes to the WebCore::Credential API.
Work towards fixing ​https://bugs.webkit.org/show_bug.cgi?id=135327

Reviewed by Alexey Proskuryakov.

  • Shared/Downloads/mac/DownloadMac.mm:

(WebKit::Download::receivedCredential):Use new Credential::nsCredential getter.

  • Shared/WebCoreArgumentCoders.cpp:

(IPC::ArgumentCoder<Credential>::encode): If encoding the credential requires encoding the
platform data, do that.
(IPC::ArgumentCoder<Credential>::decode): If platform data was encoded, decode it.

  • Shared/WebCoreArgumentCoders.h:
  • Shared/mac/WebCoreArgumentCodersMac.mm:

(IPC::ArgumentCoder<Credential>::encodePlatformData): Archive the NSURLCredential.
(IPC::ArgumentCoder<Credential>::decodePlatformData): Unarchive it.

  • UIProcess/API/Cocoa/WKNSURLAuthenticationChallenge.mm:

(-[WKNSURLAuthenticationChallengeSender useCredential:forAuthenticationChallenge:]): Use
Credential constructor that takes an NSURLCredential.

  • UIProcess/Cocoa/NavigationState.mm:

(WebKit::NavigationState::LoaderClient::didReceiveAuthenticationChallengeInFrame): Ditto.

9:49 AM Changeset in webkit [171800] by dfarler@apple.com
  • 1 edit
    15 adds in trunk/Tools

iOS Simulator LayoutTestRelay
​https://bugs.webkit.org/show_bug.cgi?id=135269

Reviewed by David Kilzer.

  • LayoutTestRelay/Configurations/Base.xcconfig: Added.
  • LayoutTestRelay/Configurations/DebugRelease.xcconfig: Added.
  • LayoutTestRelay/LayoutTestRelay.xcodeproj/project.pbxproj: Added.
  • LayoutTestRelay/LayoutTestRelay/LTPipeRelay.h: Added.
  • LayoutTestRelay/LayoutTestRelay/LTPipeRelay.m: Added.

(-[LTPipeRelay inPipePath]):
(-[LTPipeRelay outPipePath]):
(-[LTPipeRelay errorPipePath]):
(-[LTPipeRelay outputStream]):
(-[LTPipeRelay initWithPrefix:]):
(-[LTPipeRelay setup]):
(-[LTPipeRelay tearDown]):
(-[LTPipeRelay connect]):
(-[LTPipeRelay disconnect]):
(-[LTPipeRelay createFIFOs]):
(-[LTPipeRelay destroyFIFOs]):
(-[LTPipeRelay relayStream:]):
(-[LTPipeRelay stream:handleEvent:]):

  • LayoutTestRelay/LayoutTestRelay/LTRelay.h: Added.
  • LayoutTestRelay/LayoutTestRelay/LTRelayController.h: Added.
  • LayoutTestRelay/LayoutTestRelay/LTRelayController.m: Added.

(-[LTRelayController uniqueAppPath]):
(-[LTRelayController uniqueAppURL]):
(-[LTRelayController uniqueAppIdentifier]):
(-[LTRelayController processName]):
(-[LTRelayController initWithDevice:productDir:appPath:identifierSuffix:dumpToolArguments:]):
(-[LTRelayController readFileHandle:]):
(-[LTRelayController receivedStandardOutputData:]):
(-[LTRelayController receivedStandardErrorData:]):
(-[LTRelayController disconnected]):
(-[LTRelayController connected]):
(-[LTRelayController crashWithMessage:]):
(-[LTRelayController launchSimulator]):
(-[LTRelayController bootDevice]):
(-[LTRelayController createUniqueApp]):
(-[LTRelayController killApp]):
(-[LTRelayController launchApp]):
(-[LTRelayController start]):

  • LayoutTestRelay/LayoutTestRelay/main.m: Added.

(usage):
(getTestingSimDevice):
(getRequiredStringArgument):
(getRemainderArguments):
(main):

  • LayoutTestRelay/Makefile: Added.
  • Tools/Scripts/build-layouttestrelay: Added.
9:35 AM Changeset in webkit [171799] by svillar@igalia.com
  • 3 edits in trunk/Source/WebCore

[GTK] Build depends on OpenGL ES
​https://bugs.webkit.org/show_bug.cgi?id=135289

Reviewed by Martin Robinson.

Guard the OpenGL ES code with USE(OPENGL_ES_2).

  • platform/graphics/opengl/Extensions3DOpenGLES.cpp:
  • platform/graphics/opengl/Extensions3DOpenGLES.h:
9:35 AM Changeset in webkit [171798] by Brent Fulgham
  • 11 edits
    1 add in trunk

[Win] Modify version numbering scheme to support 5-tuple versions
​https://bugs.webkit.org/show_bug.cgi?id=135400
<rdar://problem/17849033>

Reviewed by David Kilzer.

Source/JavaScriptCore:

new version-stamp.pl script to version JavaScriptCore.dll.

Source/WebKit:

  • WebKit.vcxproj/WebKit/WebKitPostBuild.cmd: Use the new

version-stamp.pl script to version JavaScriptCore.dll.

Source/WTF:

  • WTF.vcxproj/WTFPostBuild.cmd: Use new version-stamp.pl script

to version WTF.dll.

  • WTF.vcxproj/WTFPreBuild.cmd: Make sure we have created the

appropriate version resource during builds.

Tools:
Update test cases to recognize that we can only support Major
values from 0-65535, Minor values from 0-64, Tiny values from 0-999,
Micro values from 0-64, and Nano values from 0-999.

  • Scripts/webkitperl/auto-version_unittest/autoVersionTests.pl: Update

test expectations for physical limits.

WebKitLibraries:
Revise the auto-version.pl script so that it generates a set of packed
version tuples that allow us to map 5-tuple versions into something
that will work with Windows' 3-tuple version structure.

  • win/tools/scripts/auto-version.pl:

(packTwoValues): Added,
(splitVersion): Revised to return packed combination of minor-tiny and
micro-nano to be used as "MINOR" and "TINY" portion of version.
(splitBuildMajorVersion): Deleted.

  • win/tools/scripts/version-stamp.pl: Added.
9:23 AM Changeset in webkit [171797] by stavila@adobe.com
  • 4 edits in trunk/Source/WebCore

Member name collision in RenderView and SelectionSubtreeRoot
​https://bugs.webkit.org/show_bug.cgi?id=135233

Reviewed by Mihnea Ovidenie.

The selectionStart/End members in RenderView have been renamed to fix confusion caused by the fact that
RenderView inherits SelectionSubtreeRoot, which also has the same selectionStart/End members.

No new tests required, no new functionality.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::isSelectionRoot):

  • rendering/RenderView.cpp:

(WebCore::RenderView::RenderView):
(WebCore::RenderView::setSelection):
(WebCore::RenderView::getSelection):

  • rendering/RenderView.h:
3:52 AM Changeset in webkit [171796] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit2

[GTK] REGRESSION(r171742): Test /webkit2/WebKitWebView/disallow-modal-dialogs fails
​https://bugs.webkit.org/show_bug.cgi?id=135412

Reviewed by Philippe Normand.

The problem is that WebPageProxy::setUIClient() calls
setCanRunModal() with the value of m_uiClient->canRunModal() which
is always true for us. We override that manually by calling
setCanRunModal() depending on the WebKitSettings. In r171742,
webkitWebViewUpdateSettings(), the method that overrides
setCanRunModal(), was moved before attachUIClientToView(), so the
value set by WebPageProxy::setUIClient() is the last one and takes
precedence. We need to make sure webkitWebViewUpdateSettings() is
always called after attachUIClientToView().

  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkitWebViewConstructed): Move webkitWebViewUpdateSettings()
call after attachUIClientToView() and add a comment to not forget
about it again.

12:47 AM Changeset in webkit [171795] by zandobersek@gmail.com
  • 3 edits in trunk/Source/WebCore

[TexMap] Move TextureMapperLayer::textureMapper() definition into the header
​https://bugs.webkit.org/show_bug.cgi?id=135384

Reviewed by Martin Robinson.

Move the definitions of TextureMapperLayer::textureMapper() and TextureMapperLayer::rootLayer()
into the TextureMapperLayer header. This makes both functions inline-able, removing unnecessary
calling overhead in GraphicsLayerTextureMapper::flushCompositingState() and
GraphicsLayerTextureMapper::updateBackingStoreIfNeeded().

TextureMapperLayer::rootLayer() now also returns a reference.

  • platform/graphics/texmap/TextureMapperLayer.cpp:

(WebCore::TextureMapperLayer::~TextureMapperLayer):
(WebCore::TextureMapperLayer::rootLayer): Deleted.
(WebCore::TextureMapperLayer::textureMapper): Deleted.

  • platform/graphics/texmap/TextureMapperLayer.h:

(WebCore::TextureMapperLayer::textureMapper):
(WebCore::TextureMapperLayer::rootLayer):

12:47 AM Changeset in webkit [171794] by Carlos Garcia Campos
  • 2 edits in trunk/Tools

[GTK] GLib tests fail with recent GTK+ due to runtime warning about deprecated properties
​https://bugs.webkit.org/show_bug.cgi?id=135411

Reviewed by Sergio Villar Senin.

Recent versions of GTK+ now warn at runtime when a deprecated
property or signal is used. A diagnostic mode was added that is
enabled by default, but that can be disabled by setting
G_ENABLE_DIAGNOSTIC=0. Runtime warnings are considered test
failures by gtester, so we need to run the tests with the
diganostic mode disabled.

  • TestWebKitAPI/gtk/WebKit2Gtk/TestMain.cpp:

(main):

12:45 AM Changeset in webkit [171793] by zandobersek@gmail.com
  • 2 edits in trunk

[CMake] Bump the minimum required version
​https://bugs.webkit.org/show_bug.cgi?id=135382

Reviewed by Gyuyoung Kim.

  • CMakeLists.txt: Bump the minimum required version to 2.8.11 after

we introduced usage of target_include_directories().

12:06 AM Changeset in webkit [171792] by Carlos Garcia Campos
  • 11 edits
    3 deletes in trunk

[GTK] Remove WebKitCertificateInfo from WebKit2GTK+ API
​https://bugs.webkit.org/show_bug.cgi?id=134830

Reviewed by Gustavo Noronha Silva.

Source/WebKit2:
It was added to make the API more convenient but it has ended up
making it more complicated. WebKitWebView::load-failed-with-tls-errors
now receives a GTlsCertificate + GTlsCertificateFlags and
webkit_web_context_allow_tls_certificate_for_host() receives a GTlsCertificate
since the errors are not actually needed. This makes the API more
consistent with the existing method webkit_web_view_get_tls_info().

  • PlatformGTK.cmake: Remove files from compilation.
  • UIProcess/API/gtk/WebKitCertificateInfo.cpp: Removed.
  • UIProcess/API/gtk/WebKitCertificateInfo.h: Removed.
  • UIProcess/API/gtk/WebKitCertificateInfoPrivate.h: Removed.
  • UIProcess/API/gtk/WebKitWebContext.cpp:

(webkit_web_context_allow_tls_certificate_for_host):

  • UIProcess/API/gtk/WebKitWebContext.h:
  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkit_web_view_class_init):
(webkitWebViewLoadFailedWithTLSErrors):

  • UIProcess/API/gtk/WebKitWebView.h:
  • UIProcess/API/gtk/docs/webkit2gtk-docs.sgml:
  • UIProcess/API/gtk/docs/webkit2gtk-sections.txt:
  • UIProcess/API/gtk/webkit2.h:

Tools:
Update the SSL test for the API changes.

  • TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:

(testLoadFailedWithTLSErrors):

Jul 29, 2014:

11:16 PM Changeset in webkit [171791] by jinwoo7.song@samsung.com
  • 10 edits in trunk/LayoutTests

[EFL] Unreviewed EFL gardening. Rebaseline tests after r170418.

  • platform/efl/mathml/opentype/horizontal-expected.txt:
  • platform/efl/mathml/opentype/horizontal-munderover-expected.txt:
  • platform/efl/mathml/opentype/large-operators-expected.txt:
  • platform/efl/mathml/opentype/vertical-expected.txt:
  • platform/efl/mathml/presentation/menclose-notation-default-longdiv-expected.txt:
  • platform/efl/mathml/presentation/mo-stretch-expected.png:
  • platform/efl/mathml/presentation/mo-stretch-expected.txt:
  • platform/efl/mathml/presentation/roots-expected.png:
  • platform/efl/mathml/presentation/roots-expected.txt:
10:42 PM Changeset in webkit [171790] by commit-queue@webkit.org
  • 7 edits
    1 add in trunk/Source/WebInspectorUI

Web Inspector: 80% of time during recording is spent creating source code locations for profile nodes
​https://bugs.webkit.org/show_bug.cgi?id=135399

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-07-29
Reviewed by Timothy Hatcher.

Profiling the inspector while recording a timeline, a significant amount of
time was spent creating SourceCodeLocation objects for profiling information
and call frames. A lot of this data was eagerly being processed, even though
it would not immediately be presentable to the user.

This makes two significant changes. We create a LazySourceCodeLocation class
which does as little as possible until display information is requested. We
also lazily convert the profiler payload data to a Profile object, so the
processing is only done if you drill into the Script specific timeline.

This results in a significant performance improvement in the overview view.

  • UserInterface/Controllers/TimelineManager.js:

(WebInspector.TimelineManager.prototype.eventRecorded.processRecord):
(WebInspector.TimelineManager.prototype.eventRecorded):
(WebInspector.TimelineManager.prototype._callFramesFromPayload.createCallFrame):
(WebInspector.TimelineManager.prototype._callFramesFromPayload):
(WebInspector.TimelineManager.prototype._profileFromPayload.profileNodeFromPayload): Deleted.
(WebInspector.TimelineManager.prototype._profileFromPayload.profileNodeCallFromPayload): Deleted.
(WebInspector.TimelineManager.prototype._profileFromPayload): Deleted.
Do not eagerly process profile payloads. Instead pass the payload to ScriptTimelineRecords.
Likewise create callframes with lazy source code locations to do the minimum amount of work.

  • UserInterface/Models/ScriptTimelineRecord.js:

(WebInspector.ScriptTimelineRecord):
(WebInspector.ScriptTimelineRecord.prototype.get profile):
(WebInspector.ScriptTimelineRecord.prototype._initializeProfileFromPayload.profileNodeFromPayload):
(WebInspector.ScriptTimelineRecord.prototype._initializeProfileFromPayload.profileNodeCallFromPayload):
(WebInspector.ScriptTimelineRecord.prototype._initializeProfileFromPayload):
Only when the profile is asked do we process the profiler payload information.
This defer the processing until at least the user drills into the Script timeline.

  • UserInterface/Main.html:

Add the new class and ensure SourceCodeLocation is available beforehand.

  • UserInterface/Models/LazySourceCodeLocation.js: Added.

(WebInspector.LazySourceCodeLocation):
(WebInspector.LazySourceCodeLocation.prototype.isEqual):
(WebInspector.LazySourceCodeLocation.prototype.get sourceCode):
(WebInspector.LazySourceCodeLocation.prototype.set sourceCode):
(WebInspector.LazySourceCodeLocation.prototype.get formattedLineNumber):
(WebInspector.LazySourceCodeLocation.prototype.get formattedColumnNumber):
(WebInspector.LazySourceCodeLocation.prototype.formattedPosition):
(WebInspector.LazySourceCodeLocation.prototype.hasFormattedLocation):
(WebInspector.LazySourceCodeLocation.prototype.hasDifferentDisplayLocation):
(WebInspector.LazySourceCodeLocation.prototype.resolveMappedLocation):
(WebInspector.LazySourceCodeLocation.prototype._lazyInitialization):
Only when display information is requested will we perform extra processing.
For basic information we do not need to check for formatted (pretty-printed) info.

  • UserInterface/Models/SourceCode.js:

(WebInspector.SourceCode.prototype.createLazySourceCodeLocation):
Provide an explict create function for lazy source codes.

  • UserInterface/Models/SourceCodeLocation.js:

(WebInspector.SourceCodeLocation.prototype.set sourceCode):
(WebInspector.SourceCodeLocation.prototype.get displaySourceCode):
(WebInspector.SourceCodeLocation.prototype.get displayLineNumber):
(WebInspector.SourceCodeLocation.prototype.get displayColumnNumber):
(WebInspector.SourceCodeLocation.prototype.hasMappedLocation):
(WebInspector.SourceCodeLocation.prototype.setSourceCode):
(WebInspector.SourceCodeLocation.prototype.resolveMappedLocation):
(WebInspector.SourceCodeLocation.prototype._makeChangeAndDispatchChangeEventIfNeeded):
(WebInspector.SourceCodeLocation.prototype._resolveMappedLocation): Deleted.
Include two protected functions which LazySourceCodeLocation overrides.

9:49 PM Changeset in webkit [171789] by dfarler@apple.com
  • 5 edits
    1 add in trunk/Tools

Add knowledge of the iOS Simulator to webkitpy
​http://bugs.webkit.org/show_bug.cgi?id=133963

Reviewed by Simon Fraser.

  • Scripts/webkitdirs.pm:

(argumentsForConfiguration): Add --ios-sim*

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:

--runtime and --device-type args added.

  • Scripts/webkitpy/port/base.py:
  • Scripts/webkitpy/port/driver.py: Add simulator driver.

(IOSSimulatorDriver): Added.

  • Scripts/webkitpy/port/factory.py: Add simulator platform.
  • Scripts/webkitpy/port/ios.py: Added.
9:26 PM Changeset in webkit [171788] by jinwoo7.song@samsung.com
  • 2 edits in trunk/Source/WebKit2

[EFL] Do not initialize g_type system explicitly in the ewk_init()
​https://bugs.webkit.org/show_bug.cgi?id=135407

Reviewed by Gyuyoung Kim.

EFL build requires glib version 2.38 but g_type_init() has been deprecated
since version 2.36. As the type system is initialized automatically since
version 2.36, we do not need to call g_type_init() in the ewk_init().

​https://developer.gnome.org/gobject/unstable/gobject-Type-Information.html#g-type-init

  • UIProcess/API/efl/ewk_main.cpp:

(ewk_init):

9:17 PM Changeset in webkit [171787] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Only compute full ProfileNode times if needed - Legacy Profiler
​https://bugs.webkit.org/show_bug.cgi?id=135406

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-07-29
Reviewed by Timothy Hatcher.

Full ProfileNode times are only used by the Legacy Profiler. The new profile
information in the Scripts Timelines currently never uses the pass. We should
avoid calculating it if we never use it.

  • UserInterface/Models/ProfileNode.js:

(WebInspector.ProfileNode.prototype.get startTime):
(WebInspector.ProfileNode.prototype.get endTime):
(WebInspector.ProfileNode.prototype.get selfTime):
(WebInspector.ProfileNode.prototype.get totalTime):
(WebInspector.ProfileNode.prototype.establishRelationships):
(WebInspector.ProfileNode.prototype._computeTotalTimes):

9:00 PM Changeset in webkit [171786] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebInspectorUI

Web Inspector: Reduce forced layouts in TimelineOverview
​https://bugs.webkit.org/show_bug.cgi?id=135405

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-07-29
Reviewed by Timothy Hatcher.

Remove another forced layout. The scroll container won't
change size unless the ContentView itself resized. Make the
distinction between a layout update due to a resize and
normal events (scale changes, etc) and only calculate
element sizes then.

  • UserInterface/Views/TimelineContentView.js:

(WebInspector.TimelineContentView.prototype.updateLayout):

  • UserInterface/Views/TimelineOverview.js:

(WebInspector.TimelineOverview):
(WebInspector.TimelineOverview.prototype.get visibleDuration):
(WebInspector.TimelineOverview.prototype.updateLayoutForResize):

8:51 PM Changeset in webkit [171785] by akling@apple.com
  • 3 edits
    2 adds in trunk

Crash when using 'em' units to specify font-size inside animation keyframe.
<​https://webkit.org/b/135395>
<rdar://problem/17851910>

Source/WebCore:
We'd forgotten to initialize the "parent style" when resolving keyframe
styles, and this led to a crash in length conversion where the code
assumes a parent style will be present.

To keep this fix minimal, simply make the "parent style" a clone of the
base element style.

Reviewed by Simon Fraser.

Test: fast/animation/keyframe-with-font-size-in-em-units.html

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::styleForKeyframe):

LayoutTests:
Add a reduced test case to cover this bug.

Reviewed by Simon Fraser.

  • fast/animation/keyframe-with-font-size-in-em-units-expected.txt: Added.
  • fast/animation/keyframe-with-font-size-in-em-units.html: Added.
8:48 PM Changeset in webkit [171784] by Brian Burg
  • 3 edits in trunk/Source/WebInspectorUI

Web Inspector: breakpoints are always speculatively resolved when restored from local storage
​https://bugs.webkit.org/show_bug.cgi?id=135396

Reviewed by Timothy Hatcher.

A longstanding quirk/optimization in the frontend is that we immediately set a breakpoint
as resolved if the breakpoint was successfully set in the backend. This ensures that clicking in
the gutter immediately produces a resolved breakpoint with only one round-trip.

However, not all breakpoints should be speculatively resolved, because the corresponding resource
may not be loaded yet. This situation causes problems for code that assumes a resolved breakpoint
also has a valid sourceCodeLocation.sourceCode.

  • UserInterface/Controllers/DebuggerManager.js:

(WebInspector.DebuggerManager.restoreBreakpointsSoon): Don't leak the variable to global scope.
(WebInspector.DebuggerManager):
(WebInspector.DebuggerManager.prototype.speculativelyResolveBreakpoint):
(WebInspector.DebuggerManager.prototype.addBreakpoint): Speculatively resolve here if requested
using the success callback passed to _setBreakpoint.

(WebInspector.DebuggerManager.prototype.didSetBreakpoint): Emit simulated
Debugger.breakpointResolved events since they are only sent by the backend when a script is parsed.

(WebInspector.DebuggerManager.prototype._setBreakpoint):

  • UserInterface/Views/SourceCodeTextEditor.js:

(WebInspector.SourceCodeTextEditor.prototype.textEditorBreakpointAdded): Request speculative resolve.

5:30 PM Changeset in webkit [171783] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebInspectorUI

Web Inspector: Eliminate more forced layouts during timeline recordings
​https://bugs.webkit.org/show_bug.cgi?id=135397

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-07-29
Reviewed by Timothy Hatcher.

Instead of computing the secondsPerPixel in each overview graph,
we can ask the overview view itself which has a cached value.
The computation used to force a layout, now it doesn't need to.

  • UserInterface/Views/LayoutTimelineOverviewGraph.js:
  • UserInterface/Views/NetworkTimelineOverviewGraph.js:
  • UserInterface/Views/ScriptTimelineOverviewGraph.js:
  • UserInterface/Views/TimelineOverview.js:

(WebInspector.TimelineOverview):

  • UserInterface/Views/TimelineOverviewGraph.js:

(WebInspector.TimelineOverviewGraph):
(WebInspector.TimelineOverviewGraph.prototype.get timelineOverview):
(WebInspector.TimelineOverviewGraph.prototype.set timelineOverview):

5:17 PM Changeset in webkit [171782] by enrica@apple.com
  • 2 edits in trunk/Source/WebKit2

REGRESSION [WebKit2 iOS]: Cannot add shortcut to user dictionary from non editable content.
​https://bugs.webkit.org/show_bug.cgi?id=135392
<rdar://problem/17760073>

Reviewed by Benjamin Poulain.

Adding a shortcut to the user dictionary needs to be available in non editable content too.

  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _addShortcut:]):

5:15 PM Changeset in webkit [171781] by Lucas Forschler
  • 5 edits in tags/Safari-600.1.3.40/Source

Versioning.

5:11 PM Changeset in webkit [171780] by Lucas Forschler
  • 1 copy in tags/Safari-600.1.3.40

New Tag.

4:23 PM Changeset in webkit [171779] by bshafiei@apple.com
  • 5 edits
    9 copies in tags/Safari-600.1.3.3

Merged r171661. <rdar://problem/17315237>

4:16 PM Changeset in webkit [171778] by bshafiei@apple.com
  • 7 edits in tags/Safari-600.1.3.3/Source

Merged r171647. <rdar://problem/17315168>

4:08 PM Changeset in webkit [171777] by bshafiei@apple.com
  • 5 edits in tags/Safari-600.1.3.3/Source

Versioning.

4:05 PM Changeset in webkit [171776] by bshafiei@apple.com
  • 1 copy in tags/Safari-600.1.3.3

New tag.

4:01 PM Changeset in webkit [171775] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit2

WKPDFView paints rotated pages squished
​https://bugs.webkit.org/show_bug.cgi?id=135401
<rdar://problem/17173916>

Reviewed by Simon Fraser.

  • UIProcess/ios/WKPDFView.mm:

(-[WKPDFView _computePageAndDocumentFrames]):
[page size] returns the crop box's size, ignoring rotation.
[page cropBoxAccountForRotation] respects rotation, but otherwise returns the same size.
UIPDFPageView will respect rotation when painting, so we
should make sure that it is given an aspect ratio that also
respects rotation, so that the page isn't squished.

3:52 PM Changeset in webkit [171774] by Lucas Forschler
  • 5 edits in branches/safari-600.1-branch/Source

Versioning.

3:46 PM Changeset in webkit [171773] by matthew_hanson@apple.com
  • 3 edits
    4 deletes in branches/safari-600.1.4-branch

r171675. <rdar://problem/17826572>

3:41 PM Changeset in webkit [171772] by ap@apple.com
  • 5 edits in trunk

fast/borders/border-radius-on-subpixel-position-non-hidpi.html fails on Retina machines
​https://bugs.webkit.org/show_bug.cgi?id=135398

Reviewed by Zalan Bujtas.

Tools:

  • WebKitTestRunner/TestController.cpp: (WTR::TestController::updateWindowScaleForTest):

"hidpi-" should be at the start. This allows "hidpi-" in both file and directory names.

  • DumpRenderTree/mac/DumpRenderTree.mm: (changeWindowScaleIfNeeded): Same fix.

For some reason, I wasn't seeing this test fail on WK1 even without the fix, not
sure why.

LayoutTests:

  • platform/mac-wk2/TestExpectations: Let's try to unskip the test, maybe this was

the actual reason for it to appear failing?

3:41 PM Changeset in webkit [171771] by Lucas Forschler
  • 1 copy in tags/Safari-600.1.5

New Tag.

3:40 PM Changeset in webkit [171770] by matthew_hanson@apple.com
  • 2 edits in branches/safari-600.1.4-branch/Source/WebCore

Rollout r171702. <rdar://problem/16828238>

3:38 PM Changeset in webkit [171769] by matthew_hanson@apple.com
  • 2 edits in branches/safari-600.1.4-branch/Source/WebCore

Rollout r171703. <rdar://problem/17833422>

3:35 PM Changeset in webkit [171768] by matthew_hanson@apple.com
  • 5 edits in branches/safari-600.1.4-branch/Source/WebCore

Rollout r171708. <rdar://problem/17844894>

2:49 PM Changeset in webkit [171767] by mmirman@apple.com
  • 3 edits in branches/ftlopt/Source/JavaScriptCore

[ftlopt] Added SkipTopScope coverage to FTL

2:41 PM Changeset in webkit [171766] by psolanki@apple.com
  • 2 edits in trunk/Source/WebCore

[iOS] REGRESSION(r171526): PDF documents fail to load in WebKit1 with disk image caching enabled
​https://bugs.webkit.org/show_bug.cgi?id=135359
<rdar://problem/17824645>

Reviewed by Darin Adler.

r171526 broke the case where we have a memory mapped file from the DiskImageCache in the
SharedBuffer. In such a case, m_buffer is empty and createCFData() returned an
WebCoreSharedBufferData with an empty buffer.

Fix this by taking the easy route of bringing back the old code for the disk image cache
file backed case. In the long run we probably want to remove the iOS specific disk image
cache anyway.

Review also uncovered another bug in r171526 where we were balancing an Objective-C alloc
with a CFRelease which is incorrect when running under GC. Fix that by using adoptNS along
with adoptCF which is what the code did before.

No new tests because the bug only occurs on device and we can't run tests on device yet.

  • platform/mac/SharedBufferMac.mm:

(-[WebCoreSharedBufferData initWithDiskImageSharedBuffer:]):
(-[WebCoreSharedBufferData length]):
(-[WebCoreSharedBufferData bytes]):
(WebCore::SharedBuffer::createCFData):

2:25 PM Changeset in webkit [171765] by Lucas Forschler
  • 5 edits in branches/safari-600.1-branch/Source/WebKit2

Merged r171748. <rdar://problem/17356958>

2:03 PM Changeset in webkit [171764] by matthew_hanson@apple.com
  • 2 edits in branches/safari-600.1.4-branch/Source/WebCore

Merge r171711. <rdar://problem/17756281>

2:03 PM Changeset in webkit [171763] by mhahnenberg@apple.com
  • 7 edits in branches/ftlopt/Source/JavaScriptCore

Support for-in in the FTL
​https://bugs.webkit.org/show_bug.cgi?id=134140

Reviewed by Filip Pizlo.

  • dfg/DFGSSALoweringPhase.cpp:

(JSC::DFG::SSALoweringPhase::handleNode):

  • ftl/FTLAbstractHeapRepository.cpp:
  • ftl/FTLAbstractHeapRepository.h:
  • ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

  • ftl/FTLIntrinsicRepository.h:
  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileHasIndexedProperty):
(JSC::FTL::LowerDFGToLLVM::compileHasGenericProperty):
(JSC::FTL::LowerDFGToLLVM::compileHasStructureProperty):
(JSC::FTL::LowerDFGToLLVM::compileGetDirectPname):
(JSC::FTL::LowerDFGToLLVM::compileGetEnumerableLength):
(JSC::FTL::LowerDFGToLLVM::compileGetStructurePropertyEnumerator):
(JSC::FTL::LowerDFGToLLVM::compileGetGenericPropertyEnumerator):
(JSC::FTL::LowerDFGToLLVM::compileGetEnumeratorPname):
(JSC::FTL::LowerDFGToLLVM::compileToIndexString):

2:00 PM Changeset in webkit [171762] by matthew_hanson@apple.com
  • 2 edits in branches/safari-600.1.4-branch/Source/WebKit2

Merge r171709. rdar://problem/16988887>

1:59 PM Changeset in webkit [171761] by matthew_hanson@apple.com
  • 5 edits in branches/safari-600.1.4-branch/Source/WebCore

Merge r171708. <rdar://problem/17844894>

1:57 PM Changeset in webkit [171760] by matthew_hanson@apple.com
  • 2 edits in branches/safari-600.1.4-branch/Source/WebCore

Merge r171703. <rdar://problem/17833422>

1:56 PM Changeset in webkit [171759] by matthew_hanson@apple.com
  • 2 edits in branches/safari-600.1.4-branch/Source/WebCore

Merge r171702. <rdar://problem/16828238>

1:54 PM Changeset in webkit [171758] by matthew_hanson@apple.com
  • 5 edits in branches/safari-600.1.4-branch/Source/WebCore

Merge r171700. <rdar://problem/17844901>

1:36 PM Changeset in webkit [171757] by matthew_hanson@apple.com
  • 2 edits
    2 copies in branches/safari-600.1.4-branch/Source/JavaScriptCore

Merge r171689. <rdar://problem/17844890>

1:33 PM Changeset in webkit [171756] by ap@apple.com
  • 2 edits in trunk/Tools

PPT: run-webkit-tests doesn't upload crash logs to bots
​https://bugs.webkit.org/show_bug.cgi?id=135391

Reviewed by Joseph Pecoraro.

  • WebKitTestRunner/TestController.cpp: (WTR::TestController::processDidCrash):

Not a fix to be proud of, but better than not having it work at all.

1:32 PM Changeset in webkit [171755] by matthew_hanson@apple.com
  • 2 edits in branches/safari-600.1.4-branch/Source/JavaScriptCore

Merge r171688. <rdar://problem/17364180>

1:26 PM Changeset in webkit [171754] by matthew_hanson@apple.com
  • 3 edits
    4 copies in branches/safari-600.1.4-branch

Merge r171675. <rdar://problem/17826572>

1:08 PM Changeset in webkit [171753] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebKit2

URTBF for !ENABLE(DATABASE_PROCESS) platforms.

  • WebProcess/OriginData/WebOriginDataManager.cpp:

(WebKit::WebOriginDataManager::getOrigins):
(WebKit::WebOriginDataManager::deleteEntriesForOrigin):
(WebKit::WebOriginDataManager::deleteEntriesModifiedBetweenDates):
(WebKit::WebOriginDataManager::deleteAllEntries):

12:34 PM Changeset in webkit [171752] by benjamin@webkit.org
  • 3 edits in trunk/Source/WebCore

VisitedLinkState::determineLinkState should take a reference
​https://bugs.webkit.org/show_bug.cgi?id=135375

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2014-07-29
Reviewed by Sam Weinig.

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::State::initElement):

  • dom/VisitedLinkState.h:

(WebCore::VisitedLinkState::determineLinkState):

12:00 PM Changeset in webkit [171751] by matthew_hanson@apple.com
  • 5 edits in branches/safari-600.1.4-branch/Source

Versioning.

11:57 AM Changeset in webkit [171750] by matthew_hanson@apple.com
  • 1 copy in branches/safari-600.1.4-branch

New Branch.

10:37 AM Changeset in webkit [171749] by beidson@apple.com
  • 11 edits in trunk/Source

Make WKOriginDataManager actually operate on IndexedDatabases.
​https://bugs.webkit.org/show_bug.cgi?id=135346

Reviewed by Sam Weinig (and David Kilzer and Alex Christensen)

Source/WebCore:

  • WebCore.exp.in:

Source/WebKit2:

  • DatabaseProcess/DatabaseProcess.cpp:

(WebKit::DatabaseProcess::DatabaseProcess):
(WebKit::DatabaseProcess::getIndexedDatabaseOrigins):
(WebKit::DatabaseProcess::doGetIndexedDatabaseOrigins):
(WebKit::removeAllDatabasesForOriginPath): Utility to delete all database files for the given origin path

that have been modified between the given dates.

(WebKit::DatabaseProcess::deleteIndexedDatabaseEntriesForOrigin):
(WebKit::DatabaseProcess::doDeleteIndexedDatabaseEntriesForOrigin):
(WebKit::DatabaseProcess::deleteIndexedDatabaseEntriesModifiedBetweenDates):
(WebKit::DatabaseProcess::doDeleteIndexedDatabaseEntriesModifiedBetweenDates):
(WebKit::DatabaseProcess::deleteAllIndexedDatabaseEntries):
(WebKit::DatabaseProcess::doDeleteAllIndexedDatabaseEntries):

  • DatabaseProcess/DatabaseProcess.h:
  • Shared/WebCrossThreadCopier.cpp:

(WebCore::SecurityOriginData>::copy):

  • Shared/WebCrossThreadCopier.h:
  • UIProcess/WebOriginDataManagerProxy.cpp:

(WebKit::WebOriginDataManagerProxy::getOrigins):
(WebKit::WebOriginDataManagerProxy::didGetOrigins):
(WebKit::WebOriginDataManagerProxy::deleteEntriesForOrigin):
(WebKit::WebOriginDataManagerProxy::deleteEntriesModifiedBetweenDates):
(WebKit::WebOriginDataManagerProxy::deleteAllEntries):

  • WebProcess/OriginData/WebOriginDataManager.cpp:

(WebKit::WebOriginDataManager::getOrigins): Pipe IDB requests through to the DatabaseProcess.
(WebKit::WebOriginDataManager::deleteEntriesForOrigin): Ditto.
(WebKit::WebOriginDataManager::deleteEntriesModifiedBetweenDates): Ditto.
(WebKit::WebOriginDataManager::deleteAllEntries): Ditto.

10:23 AM Changeset in webkit [171748] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit2

Unreviewed, rolling out r171704.
​https://bugs.webkit.org/show_bug.cgi?id=135389

Broke two IndexedDB tests (Requested by ap on #webkit).

Reverted changeset:

"IDB transactions never reset if the Web Process ends before
cleaning up"
​https://bugs.webkit.org/show_bug.cgi?id=135218
​http://trac.webkit.org/changeset/171704

9:40 AM Changeset in webkit [171747] by mitz@apple.com
  • 7 edits
    2 adds in trunk/Source/WebCore

Moved the Cocoa-specific parts of CredentialBase into a Cocoa-specific Credential class.
Work towards fixing ​https://bugs.webkit.org/show_bug.cgi?id=135327

Reviewed by Alexey Proskuryakov.

No change in functionality.

  • WebCore.exp.in: Updated for functions moved in the class hierarchy.
  • WebCore.xcodeproj/project.pbxproj: Added CredentialCocoa.{h,mm}.
  • platform/network/Credential.h: For Cocoa, include CredentialCocoa.h instead of the generic

class.
(WebCore::Credential::Credential): Removed #if CERTIFICATE_CREDENTIALS_SUPPORTED code.

  • platform/network/CredentialBase.cpp:

(WebCore::CredentialBase::CredentialBase): Changed to use emptyString instead of "", removed
#if CERTIFICATE_CREDENTIALS_SUPPORTED code.
(WebCore::CredentialBase::isEmpty): Ditto.
(WebCore::CredentialBase::compare): Renamed operator== to this, removed
#if CERTIFICATE_CREDENTIALS_SUPPORTED code, but changed the end to call platformCompare.
(WebCore::CredentialBase::identity): Deleted.
(WebCore::CredentialBase::certificates): Deleted.
(WebCore::CredentialBase::type): Deleted.

  • platform/network/CredentialBase.h: Removed #if CERTIFICATE_CREDENTIALS_SUPPORTED members.

(WebCore::CredentialBase::platformCompare): Added a base implementation that returns true.
(WebCore::operator==): Changed to use CredentialBase::compare.

  • platform/network/cocoa/CredentialCocoa.h: Added.

(WebCore::Credential::Credential):

  • platform/network/cocoa/CredentialCocoa.mm: Added.

(WebCore::Credential::Credential): Moved the constructor that takes an identity and
certificates here.
(WebCore::Credential::isEmpty): Moved here.
(WebCore::Credential::identity): Ditto.
(WebCore::Credential::certificates): Ditto.
(WebCore::Credential::type): Ditto.
(WebCore::Credential::platformCompare): Moved the code that compares client-certificate
credentials here.

  • platform/network/mac/AuthenticationMac.mm:

(WebCore::mac): Removed #if CERTIFICATE_CREDENTIALS_SUPPORTED guards in this Cocoa-only
file.
(WebCore::core): Ditto.

8:47 AM Changeset in webkit [171746] by dbates@webkit.org
  • 11 edits in trunk/Source

Use WTF::move() instead of std::move() to help ensure move semantics
​https://bugs.webkit.org/show_bug.cgi?id=135351

Reviewed by Alexey Proskuryakov.

Source/JavaScriptCore:

  • bytecode/GetByIdStatus.cpp:

(JSC::GetByIdStatus::computeForStubInfo):

  • bytecode/GetByIdVariant.cpp:

(JSC::GetByIdVariant::GetByIdVariant):

Source/WebCore:

  • page/CaptionUserPreferences.cpp:

(WebCore::CaptionUserPreferences::updateCaptionStyleSheetOveride):

Source/WebKit2:

  • UIProcess/API/Cocoa/_WKSessionState.mm:

(-[_WKSessionState _initWithSessionState:]):

  • UIProcess/API/gtk/WebKitUserContent.cpp:

(toStringVector): Remove use of std::move(). It's unnecessary to call std::move() on an rvalue.

  • WebProcess/WebPage/mac/ServicesOverlayController.mm:

(WebKit::ServicesOverlayController::mouseEvent):

Source/WTF:

  • wtf/HashTable.h:

(WTF::KeyTraits>::HashTable):

8:11 AM Changeset in webkit [171745] by mihnea@adobe.com
  • 3 edits
    2 adds in trunk

[CSSRegions] Assertion failure hit testing a region-based multicolumn in a region
​https://bugs.webkit.org/show_bug.cgi?id=135385

Reviewed by Andrei Bucur.

Source/WebCore:
When a region-based multicolumn element is displayed and hit tested in a region,
we have to disable the named flow region information not only for painting,
but also for hit-testing. This is a follow-up for ​https://bugs.webkit.org/show_bug.cgi?id=132121,
which provided the fix for painting.

Test: fast/regions/assert-hit-test-multicol-in-region.html

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::hitTestLayer):

LayoutTests:

  • fast/regions/assert-hit-test-multicol-in-region-expected.txt: Added.
  • fast/regions/assert-hit-test-multicol-in-region.html: Added.
7:51 AM Changeset in webkit [171744] by Alan Bujtas
  • 8 edits
    1 add in trunk/Source/WebCore

Cleanup RenderSelectionInfoBase/RenderSelectionInfo/RenderBlockSelectionInfo.
​https://bugs.webkit.org/show_bug.cgi?id=135326

Reviewed by Darin Adler.

  1. Move implementation to RenderSelectInfo.cpp
  2. RenderSelectionInfoBase/RenderSelectionInfo/RenderBlockSelectionInfo take Render* reference.
  3. Remove unused functions.
  4. Add RenderSelectionInfoBase::repaintRectangle()

No change in behavior.

  • WebCore.xcodeproj/project.pbxproj:
  • rendering/RenderSelectionInfo.cpp: Added.

(WebCore::RenderSelectionInfoBase::RenderSelectionInfoBase):
(WebCore::RenderSelectionInfoBase::repaintRectangle):
(WebCore::RenderSelectionInfo::RenderSelectionInfo):
(WebCore::RenderSelectionInfo::repaint):
(WebCore::RenderBlockSelectionInfo::RenderBlockSelectionInfo):
(WebCore::RenderBlockSelectionInfo::repaint):

  • rendering/RenderSelectionInfo.h:

(WebCore::RenderSelectionInfo::collectedSelectionRects):
(WebCore::RenderSelectionInfoBase::RenderSelectionInfoBase): Deleted.
(WebCore::RenderSelectionInfoBase::object): Deleted.
(WebCore::RenderSelectionInfo::RenderSelectionInfo): Deleted.
(WebCore::RenderSelectionInfo::repaint): Deleted.
(WebCore::RenderSelectionInfo::rects): Deleted.
(WebCore::RenderBlockSelectionInfo::RenderBlockSelectionInfo): Deleted.
(WebCore::RenderBlockSelectionInfo::repaint): Deleted.
(WebCore::RenderBlockSelectionInfo::block): Deleted.

  • rendering/RenderView.cpp:

(WebCore::RenderView::subtreeSelectionBounds):
(WebCore::RenderView::repaintSubtreeSelection):
(WebCore::RenderView::clearSubtreeSelection):
(WebCore::RenderView::applySubtreeSelection):

7:35 AM Changeset in webkit [171743] by psolanki@apple.com
  • 20 edits in trunk/Source

Get SharedBuffer.h out of ResourceBuffer.h (and a few other places)
​https://bugs.webkit.org/show_bug.cgi?id=131782

Original patch by Tim Horton.
Reviewed by Darin Adler.

Source/WebCore:
No new tests because no functional changes.

  • Modules/indexeddb/IDBCallbacks.h:
  • Modules/indexeddb/IDBCursorBackend.h:
  • loader/ios/DiskImageCacheIOS.h:

Forward declare SharedBuffer in headers.

  • Modules/indexeddb/IDBRequest.cpp:
  • loader/cache/CachedImage.cpp:
  • loader/icon/IconLoader.cpp:
  • loader/ios/DiskImageCacheIOS.mm:
  • loader/cache/MemoryCache.cpp:
  • loader/mac/ResourceBuffer.mm:

Include SharedBuffer.h in implementation files.

  • Modules/notifications/Notification.h:
  • loader/appcache/ApplicationCacheGroup.h:

Remove unnecessary includes.

  • loader/ResourceBuffer.cpp:

(WebCore::ResourceBuffer::adoptSharedBuffer):

  • loader/ResourceBuffer.h:

Out-of-line adoptSharedBuffer so that the PassRefPtr doesn't require including SharedBuffer.h.

  • platform/graphics/opentype/OpenTypeMathData.cpp:
  • platform/graphics/opentype/OpenTypeMathData.h:

Out-of-line destructor to avoid requiring SharedBuffer.h for the RefPtr.
Forward-declare SharedBuffer in the header, include in implementation.

Source/WebKit2:

  • NetworkProcess/NetworkResourceLoader.cpp:
  • WebProcess/Network/NetworkProcessConnection.cpp:

Include SharedBuffer.h in implementation files.

  • WebProcess/InjectedBundle/InjectedBundlePageEditorClient.h:

Un-indent namespace and remove SharedBuffer forward-declaration.

5:42 AM Changeset in webkit [171742] by commit-queue@webkit.org
  • 18 edits
    4 deletes in trunk

[GTK] Remove WebKitWebViewGroup from WebKit2 GTK+ API
​https://bugs.webkit.org/show_bug.cgi?id=133729

Patch by Adrian Perez de Castro <Adrian Perez de Castro> on 2014-07-29
Reviewed by Carlos Garcia Campos.

Removes WebKitWebViewGroup, effectively reverting the changes
introduced by r149117. The motivation for WebKitWebViewGroup
was using the user style sheet injection API, which has been
moved into WebKitUserContentManager, rendering it unneeded.

Source/WebKit2:

  • PlatformGTK.cmake: Remove WebKitWebViewGroup source files

from the build.

  • UIProcess/API/C/gtk/WKView.cpp:

(WKViewCreate): Accomodate for changes in the signature of
webkitWebViewBaseCreate().

  • UIProcess/API/gtk/WebKitSettings.cpp: Update API documentation.
  • UIProcess/API/gtk/WebKitWebContext.cpp: Remove the default web

view group from WebKitWebContext.
(webkitWebContextCreatePageForWebView): Allow passing a
WebPreferences object at construction.
(webkitWebContextGetDefaultWebViewGroup): Deleted.

  • UIProcess/API/gtk/WebKitWebContextPrivate.h: Ditto.
  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkitWebViewUpdateSettings): Use WebPageProxy::setPreferences()
directly. Handle the case when webkit_web_view_set_settings()
is called on construction by doing an early-return.
(webkitWebViewConstructed): Call webkitWebViewUpdateSettings()
after creating the internal WebPageProxy object.
(webkitWebViewSetProperty): Removed "group" property, added
"settings" property.
(webkitWebViewGetProperty): Ditto.
(webkitWebViewDispose): Do not disconnect signal handler for
the (now unexistant) WebKitWebViewGroup.
(webkit_web_view_class_init): Removed "group" property, added
"settings" property.
(webkitWebViewHandleAuthenticationChallenge): Access the
WebKitWebSettings directly.
(webkit_web_view_new_with_related_view): Make new views share
settings with their related view.
(webkit_web_view_new_with_settings): Added.
(webkit_web_view_set_settings): Access the settings directly in
the WebKitWebView.
(webkit_web_view_get_settings): Ditto.
(webkit_web_view_set_zoom_level): Ditto.
(webkit_web_view_get_zoom_level): Ditto.
(webkitWebViewSettingsChanged): Deleted.
(webkitWebViewDisconnectSettingsChangedSignalHandler): Deleted.
(webkit_web_view_new_with_group): Deleted.
(webkit_web_view_get_group): Deleted.

  • UIProcess/API/gtk/WebKitWebView.h: Removed API methods related

to WebKitWebViewGroup.

  • UIProcess/API/gtk/WebKitWebViewBase.cpp:

(webkitWebViewBaseCreate): Allow passing a WebPreferences object
for constructing the WebPageProxy.
(webkitWebViewBaseUpdatePreferences): Instead of going through
the page group, use WebPageProxy::preferences() directly.
(webkitWebViewBaseCreateWebPage): Allow passing a WebPreferences
object for constructing the WebPageProxy.

  • UIProcess/API/gtk/WebKitWebViewBasePrivate.h: Update the

prototypes of the internal functions.

  • UIProcess/API/gtk/WebKitWebViewGroup.cpp: Removed.
  • UIProcess/API/gtk/WebKitWebViewGroup.h: Removed.
  • UIProcess/API/gtk/WebKitWebViewGroupPrivate.h: Removed.
  • UIProcess/API/gtk/docs/webkit2gtk-docs.sgml: Change public API

bits in the documentation.

  • UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Ditto.
  • UIProcess/API/gtk/docs/webkit2gtk.types: Ditto.
  • UIProcess/API/gtk/webkit2.h: Removed WebKitWebViewGroup.h header.
  • UIProcess/gtk/WebInspectorProxyGtk.cpp:

(WebKit::WebInspectorProxy::platformCreateInspectorPage):
Accomodate for changes in the signature of
webkitWebViewBaseCreate().

Tools:

  • TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: Remove tests

for WebKitWebViewGroup.

  • TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:

(testWebViewSettings):
Restore the assertions that check that settings objects are
released. Add test for webkit_web_view_new_with_settings().

  • TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebViewGroup.cpp: Removed.
4:41 AM Changeset in webkit [171741] by commit-queue@webkit.org
  • 3 edits in trunk

[EFL][GTK] Remove ACCELERATED_COMPOSITING compile flag
​https://bugs.webkit.org/show_bug.cgi?id=135376

Patch by Hunseop Jeong <Hunseop Jeong> on 2014-07-29
Reviewed by Gyuyoung Kim.

ACCELERATED_COMPOSITING was changed to the mandatory code after r163079.

  • Source/cmake/OptionsEfl.cmake:
  • Source/cmake/OptionsGTK.cmake:
4:35 AM Changeset in webkit [171740] by Carlos Garcia Campos
  • 12 edits in trunk

Implement webkit_web_view_load_string() in WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=134735

Reviewed by Sergio Villar Senin.

Source/WebKit2:
Add webkit_web_view_load_bytes() that receives a GBytes to load
random data in the web view using the given MIME-Type, encoding
and base URL.

  • UIProcess/API/gtk/WebKitWebView.cpp:

(releaseGBytes):
(webkit_web_view_load_bytes):

  • UIProcess/API/gtk/WebKitWebView.h:
  • UIProcess/API/gtk/docs/webkit2gtk-docs.sgml:
  • UIProcess/API/gtk/docs/webkit2gtk-sections.txt:

Tools:
Add /webkit2/WebKitWebView/load-bytes test case and simplify
TestDOMXPathNSResolver by using webkit_web_view_load_bytes()
instead of a soup server just to sent the Content-type header.

  • TestWebKitAPI/Tests/WebKit2Gtk/TestDOMXPathNSResolver.cpp:

(testWebKitDOMXPathNSResolverNative):
(testWebKitDOMXPathNSResolverCustom):
(beforeAll):
(afterAll):
(serverCallback): Deleted.

  • TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:

(testLoadBytes):
(beforeAll):

  • TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp:

(LoadTrackingTest::loadBytes):

  • TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.h:
  • TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:

(WebViewTest::loadBytes):

  • TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
1:52 AM Changeset in webkit [171739] by Lucas Forschler
  • 3 edits in branches/safari-600.1-branch/Source/WebInspectorUI

Merged r171721. <rdar://problem/17836658>

1:50 AM Changeset in webkit [171738] by Lucas Forschler
  • 5 edits in branches/safari-600.1-branch/Source/WebInspectorUI

Merged r171720. <rdar://problem/17838230>

1:49 AM Changeset in webkit [171737] by Lucas Forschler
  • 2 edits in branches/safari-600.1-branch/Source/WebInspectorUI

Merged r171716. <rdar://problem/17835401>

1:47 AM Changeset in webkit [171736] by Lucas Forschler
  • 2 edits in branches/safari-600.1-branch/Source/WebCore

Merged r171711. <rdar://problem/17756281>

1:45 AM Changeset in webkit [171735] by Lucas Forschler
  • 2 edits in branches/safari-600.1-branch/Source/WebKit2

Merged r171709. <rdar://problem/16988887>

1:41 AM Changeset in webkit [171734] by Lucas Forschler
  • 5 edits in branches/safari-600.1-branch/Source/WebCore

Merged r171708. <rdar://problem/17768371>

1:38 AM Changeset in webkit [171733] by Lucas Forschler
  • 3 edits in branches/safari-600.1-branch/Source/WebKit2

Merged r171706. <rdar://problem/17295639>

1:36 AM Changeset in webkit [171732] by Lucas Forschler
  • 5 edits in branches/safari-600.1-branch/Source/WebKit2

Merged r171704. <rdar://problem/17356958>

1:34 AM Changeset in webkit [171731] by Lucas Forschler
  • 2 edits in branches/safari-600.1-branch/Source/WebCore

Merged r171703. <rdar://problem/17833422>

1:32 AM Changeset in webkit [171730] by Lucas Forschler
  • 2 edits in branches/safari-600.1-branch/Source/WebCore

Merged r171702. <rdar://problem/16828238>

1:29 AM Changeset in webkit [171729] by Lucas Forschler
  • 5 edits in branches/safari-600.1-branch/Source/WebCore

Merged r171700. <rdar://problem/15317278>

1:27 AM Changeset in webkit [171728] by Lucas Forschler
  • 2 edits
    2 copies in branches/safari-600.1-branch/Source/JavaScriptCore

Merged r171689. <rdar://problem/17509889>

1:23 AM Changeset in webkit [171727] by Lucas Forschler
  • 2 edits in branches/safari-600.1-branch/Source/JavaScriptCore

Merged r171688. <rdar://problem/17364180>

1:18 AM Changeset in webkit [171726] by Lucas Forschler
  • 3 edits
    4 copies in branches/safari-600.1-branch

Merged r171675. <rdar://problem/17826572>

1:12 AM Changeset in webkit [171725] by zandobersek@gmail.com
  • 3 edits in trunk/Source/WebCore

[TexMap] GraphicsLayerTextureMapper::addAnimation() box size parameter should be FloatSize
​https://bugs.webkit.org/show_bug.cgi?id=135237

Reviewed by Martin Robinson.

  • platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:

(WebCore::GraphicsLayerTextureMapper::addAnimation):

  • platform/graphics/texmap/GraphicsLayerTextureMapper.h: The boxSize parameter of the

addAnimation() method must be of the same type as the parameter in the base class
declaration -- a const FloatSize reference. Only then is the base virtual method
actually overriden.

12:52 AM Changeset in webkit [171724] by ryuan.choi@samsung.com
  • 4 edits in trunk/Source/WebKit2

[EFL] Alpha value of ewk_view_bg_color_set is not working
​https://bugs.webkit.org/show_bug.cgi?id=135333

Reviewed by Gyuyoung Kim.

evas_object_image_alpha_set should be called for the transparent evas object.

  • UIProcess/API/efl/EwkView.cpp:

(EwkView::handleEvasObjectColorSet):
(EwkView::setBackgroundColor): Checked the alpha value of object and called evas_object_image_alpha_set.

  • UIProcess/API/efl/EwkView.h:
  • UIProcess/API/efl/ewk_view.cpp:

(ewk_view_bg_color_set): Moved the logic to EwkView.

Note: See TracTimeline for information about the timeline view.