Timeline

Jul 31, 2014:

10:02 PM EFLWebKit edited by ryuan.choi@samsung.com

(diff)

10:00 PM Changeset in webkit [171909] by ryuan.choi@samsung.com

• 2 edits in trunk

[EFL] Bump ewebkit version to 1.11
​https://bugs.webkit.org/show_bug.cgi?id=135487

Reviewed by Gyuyoung Kim.

• Source/cmake/OptionsEfl.cmake: Bump version numbers.

9:07 PM Changeset in webkit [171908] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: "Stop Recording" button feels unresponsive, recording takes a long time to stop
​https://bugs.webkit.org/show_bug.cgi?id=135490

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-07-31
Reviewed by Timothy Hatcher.

• UserInterface/Controllers/TimelineManager.js:

(WebInspector.TimelineManager.prototype.stopCapturing):
Immediately stop the recording without waiting for an event from the backend.
This makes the Web Inspector UI feel responsive to the user stopping the recording.
This also matches behavior before r171195.

8:42 PM Changeset in webkit [171907] by benjamin@webkit.org

• 6 edits in trunk/Source/WebCore

Remove shadowPseudoId() override from the shadow media controls
​https://bugs.webkit.org/show_bug.cgi?id=135474

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2014-07-31
Reviewed by Eric Carlson.

Small cleanup.

• html/shadow/MediaControlElementTypes.h:
• html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlPanelElement::MediaControlPanelElement):
(WebCore::MediaControlPanelEnclosureElement::MediaControlPanelEnclosureElement):
(WebCore::MediaControlOverlayEnclosureElement::MediaControlOverlayEnclosureElement):
(WebCore::MediaControlTimelineContainerElement::MediaControlTimelineContainerElement):
(WebCore::MediaControlVolumeSliderContainerElement::MediaControlVolumeSliderContainerElement):
(WebCore::MediaControlStatusDisplayElement::MediaControlStatusDisplayElement):
(WebCore::MediaControlPanelMuteButtonElement::MediaControlPanelMuteButtonElement):
(WebCore::MediaControlVolumeSliderMuteButtonElement::MediaControlVolumeSliderMuteButtonElement):
(WebCore::MediaControlPlayButtonElement::MediaControlPlayButtonElement):
(WebCore::MediaControlOverlayPlayButtonElement::MediaControlOverlayPlayButtonElement):
(WebCore::MediaControlSeekForwardButtonElement::MediaControlSeekForwardButtonElement):
(WebCore::MediaControlSeekBackButtonElement::MediaControlSeekBackButtonElement):
(WebCore::MediaControlRewindButtonElement::MediaControlRewindButtonElement):
(WebCore::MediaControlReturnToRealtimeButtonElement::MediaControlReturnToRealtimeButtonElement):
(WebCore::MediaControlToggleClosedCaptionsButtonElement::MediaControlToggleClosedCaptionsButtonElement):
(WebCore::MediaControlClosedCaptionsContainerElement::MediaControlClosedCaptionsContainerElement):
(WebCore::MediaControlClosedCaptionsTrackListElement::MediaControlClosedCaptionsTrackListElement):
(WebCore::MediaControlTimelineElement::MediaControlTimelineElement):
(WebCore::MediaControlPanelVolumeSliderElement::MediaControlPanelVolumeSliderElement):
(WebCore::MediaControlFullscreenVolumeSliderElement::MediaControlFullscreenVolumeSliderElement):
(WebCore::MediaControlFullscreenButtonElement::MediaControlFullscreenButtonElement):
(WebCore::MediaControlFullscreenVolumeMinButtonElement::MediaControlFullscreenVolumeMinButtonElement):
(WebCore::MediaControlFullscreenVolumeMaxButtonElement::MediaControlFullscreenVolumeMaxButtonElement):
(WebCore::MediaControlTimeRemainingDisplayElement::MediaControlTimeRemainingDisplayElement):
(WebCore::MediaControlCurrentTimeDisplayElement::MediaControlCurrentTimeDisplayElement):
(WebCore::MediaControlTextTrackContainerElement::MediaControlTextTrackContainerElement):
(WebCore::MediaControlPanelElement::shadowPseudoId): Deleted.
(WebCore::MediaControlPanelEnclosureElement::shadowPseudoId): Deleted.
(WebCore::MediaControlOverlayEnclosureElement::shadowPseudoId): Deleted.
(WebCore::MediaControlTimelineContainerElement::shadowPseudoId): Deleted.
(WebCore::MediaControlVolumeSliderContainerElement::shadowPseudoId): Deleted.
(WebCore::MediaControlStatusDisplayElement::shadowPseudoId): Deleted.
(WebCore::MediaControlPanelMuteButtonElement::shadowPseudoId): Deleted.
(WebCore::MediaControlVolumeSliderMuteButtonElement::shadowPseudoId): Deleted.
(WebCore::MediaControlPlayButtonElement::shadowPseudoId): Deleted.
(WebCore::MediaControlOverlayPlayButtonElement::shadowPseudoId): Deleted.
(WebCore::MediaControlSeekForwardButtonElement::shadowPseudoId): Deleted.
(WebCore::MediaControlSeekBackButtonElement::shadowPseudoId): Deleted.
(WebCore::MediaControlRewindButtonElement::shadowPseudoId): Deleted.
(WebCore::MediaControlReturnToRealtimeButtonElement::shadowPseudoId): Deleted.
(WebCore::MediaControlToggleClosedCaptionsButtonElement::shadowPseudoId): Deleted.
(WebCore::MediaControlClosedCaptionsContainerElement::shadowPseudoId): Deleted.
(WebCore::MediaControlClosedCaptionsTrackListElement::shadowPseudoId): Deleted.
(WebCore::MediaControlTimelineElement::shadowPseudoId): Deleted.
(WebCore::MediaControlPanelVolumeSliderElement::shadowPseudoId): Deleted.
(WebCore::MediaControlFullscreenVolumeSliderElement::shadowPseudoId): Deleted.
(WebCore::MediaControlFullscreenButtonElement::shadowPseudoId): Deleted.
(WebCore::MediaControlFullscreenVolumeMinButtonElement::shadowPseudoId): Deleted.
(WebCore::MediaControlFullscreenVolumeMaxButtonElement::shadowPseudoId): Deleted.
(WebCore::MediaControlTimeRemainingDisplayElement::shadowPseudoId): Deleted.
(WebCore::MediaControlCurrentTimeDisplayElement::shadowPseudoId): Deleted.
(WebCore::MediaControlTextTrackContainerElement::textTrackContainerElementShadowPseudoId): Deleted.
(WebCore::MediaControlTextTrackContainerElement::shadowPseudoId): Deleted.

• html/shadow/MediaControlElements.h:
• html/shadow/MediaControls.cpp:

(WebCore::MediaControls::MediaControls):
(WebCore::MediaControls::shadowPseudoId): Deleted.

• html/shadow/MediaControls.h:

7:20 PM Changeset in webkit [171906] by ryuan.choi@samsung.com

• 4 edits in trunk

[EFL][WK2] MiniBrower comes to crash when combo box is pressed
​https://bugs.webkit.org/show_bug.cgi?id=135378

Reviewed by Gyuyoung Kim.

Source/WebKit2:
Added doxygen comment of popup_menu_show/popup_menu_hide not to confuse the usage.

• UIProcess/API/efl/ewk_view.h:

Tools:
"clicked" signal of elm_menu is emitted after EwkView calls popup_menu_hide
and removes Ewk_Popup_Menu instance.

• MiniBrowser/efl/main.c:

(on_popup_menu_show):
(on_popup_menu_discarded): Deleted.

6:26 PM Changeset in webkit [171905] by timothy_horton@apple.com

• 2 edits in trunk/Source/WebCore

Build fix for platforms where we should have automaticallyAdjustsContentInsets but it isn't public yet

• platform/mac/ScrollViewMac.mm:

6:26 PM Changeset in webkit [171904] by clopez@igalia.com

• 4 edits in trunk

[EFL] Add support for building with Geoclue2.
​https://bugs.webkit.org/show_bug.cgi?id=135455

Reviewed by Gyuyoung Kim.

.:

• Source/cmake/OptionsEfl.cmake: Add gio-unix if ENABLE_GEOLOCATION

is set.

Source/WebCore:
No new tests required, no new functionality.

• PlatformEfl.cmake: Generate derived sources for Geoclue2Interface

and include gio-unix path.

6:15 PM Changeset in webkit [171903] by Brent Fulgham

• 3 edits
  1 add in trunk

[Win] Use RC_PROJECTBUILDVERSION as build portion of version
​https://bugs.webkit.org/show_bug.cgi?id=135478

Reviewed by David Kilzer.

Tools:
Add new test suite for the version-stamp program.

• Scripts/webkitperl/auto-version_unittest/versionStampTests.pl: Added.

WebKitLibraries:

• win/tools/scripts/version-stamp.pl: Check environment for

RC_PROJECTBUILDVERSION, and use it for the build portion of
the file version resource. Otherwise, use the VERSION_BUILD
value we calculated from the version string.

6:01 PM Changeset in webkit [171902] by mitz@apple.com

• 3 edits in trunk/Tools

Reverted r171893, because it broke http/tests/appcache/different-https-origin-resource-main.html,
which loads HTTPS content without calling the delegate.

Rubber-stamped by Alexey Proskuryakov.

• WebKitTestRunner/InjectedBundle/ios/InjectedBundleIOS.mm:

(WTR::InjectedBundle::platformInitialize):

• WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:

(WTR::InjectedBundle::platformInitialize):

5:53 PM Changeset in webkit [171901] by ryuan.choi@samsung.com

• 3 edits
  1 delete in trunk/Source/WebKit2

[EFL] remove ewk_defines.h
​https://bugs.webkit.org/show_bug.cgi?id=135456

Reviewed by Gyuyoung Kim.

• UIProcess/API/efl/ewk_context_menu.h:
• UIProcess/API/efl/ewk_context_menu_item.h: Moved the declaration from ewk_defines.h
• UIProcess/API/efl/ewk_defines.h: Removed.

5:50 PM Changeset in webkit [171900] by Brent Fulgham

• 2 edits in trunk/Tools

Unreviewed typo correction (and build fix).

• MiniBrowser/mac/WK2BrowserWindowController.m:

(-[WK2BrowserWindowController awakeFromNib]): Use correct
property name (_fullScreenIsEnabled -> _fullScreenEnabled)

5:39 PM Changeset in webkit [171899] by Brent Fulgham

• 3 edits in trunk/Source/WebKit2

Unreviewed typo correction.
​https://bugs.webkit.org/show_bug.cgi?id=135482

Rename '_fullScreenIsEnabled' -> '_fullScreenEnabled'

• UIProcess/API/Cocoa/WKPreferences.mm:

(-[WKPreferences _fullScreenEnabled]): Added
(-[WKPreferences _fullScreenIsEnabled]): Deleted.

• UIProcess/API/Cocoa/WKPreferencesPrivate.h:

5:26 PM Changeset in webkit [171898] by Beth Dakin

• 2 edits in trunk/LayoutTests

platform/mac/fast/scrolling/scroll-select-bottom-test.html failing on Mavericks
(after 171891?)
​https://bugs.webkit.org/show_bug.cgi?id=135485

Skipping this test for now to allow some time to investigate the failure.

• platform/mac/TestExpectations:

5:15 PM Changeset in webkit [171897] by Brent Fulgham

• 5 edits in trunk

MiniBrowser Should Support Fullscreen Videos in WebKit2 Mode
​https://bugs.webkit.org/show_bug.cgi?id=135482

Reviewed by Simon Fraser.

Source/WebKit2:

Add accessors for the missing Fullscreen API so that MiniBrowser
can use them.

• UIProcess/API/Cocoa/WKPreferences.mm:

(-[WKPreferences _fullScreenIsEnabled]): Added.
(-[WKPreferences _setFullScreenEnabled:]): Added.

• UIProcess/API/Cocoa/WKPreferencesPrivate.h: Add accessor for

Fullscreen mode.

Tools:

• MiniBrowser/mac/WK2BrowserWindowController.m:

(-[WK2BrowserWindowController awakeFromNib]): Activate the Fullscreen
feature.

4:55 PM Changeset in webkit [171896] by Alan Bujtas

• 5 edits in trunk/Source/WebCore

Subpixel rendering: Region painting needs to take subpixel accumulation into account.
​https://bugs.webkit.org/show_bug.cgi?id=135469

Similar to non-region painting, when the context is translated, we need to propagate
the subpixel difference so that renderers get snapped to the same position as if they
were not part of a region.

Reviewed by Simon Fraser.

Covered by existing tests/not testable (webkit.org/b/135470)

• html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlTextTrackContainerElement::createTextTrackRepresentationImage):

• page/FrameView.cpp:

(WebCore::FrameView::paintContents):

• rendering/RenderLayer.cpp:

(WebCore::RenderLayer::paint):
(WebCore::RenderLayer::calculateClipRects):

• rendering/RenderLayer.h:

4:52 PM Changeset in webkit [171895] by jer.noble@apple.com

• 2 edits in trunk/Source/WebCore

[iOS] Video in an <embed> has a bad aspect ratio when in fullscreen mode.
​https://bugs.webkit.org/show_bug.cgi?id=135481

Reviewed by Simon Fraser.

Do not change the gravity of our AVPlayerLayer when in full screen mode; its gravity
is controlled by setVideoFullscreenGravity(), and should not be affected by style changes.

• platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::updateVideoLayerGravity):

4:17 PM Changeset in webkit [171894] by commit-queue@webkit.org

• 3 edits in trunk/Source/WebInspectorUI

Web Inspector: Timeline recording is not working inspecting iOS 7 and earlier
​https://bugs.webkit.org/show_bug.cgi?id=135466

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-07-31
Reviewed by Timothy Hatcher.

Start / stop capturing for older backends that won't emit start / stop events.

• UserInterface/Protocol/InspectorBackend.js:

(InspectorBackend.Agent.prototype.hasEvent):
Provide a way to check if an event is supported.

• UserInterface/Controllers/TimelineManager.js:

(WebInspector.TimelineManager.prototype.startCapturing):
(WebInspector.TimelineManager.prototype.stopCapturing):
Fallback to starting and stopping capturing manually if the backend
does not provide the events.

3:56 PM Changeset in webkit [171893] by ap@apple.com

• 3 edits in trunk/Tools

[Mac, iOS] Remove -setAllowsAnyHTTPSCertificate calls
​https://bugs.webkit.org/show_bug.cgi?id=135472

Reviewed by Dan Bernstein.

We now handle server trust challenges, and don't need such hacks.

• WebKitTestRunner/InjectedBundle/ios/InjectedBundleIOS.mm:

(WTR::InjectedBundle::platformInitialize):

• WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:

(WTR::InjectedBundle::platformInitialize):

3:45 PM Changeset in webkit [171892] by Beth Dakin

• 1 edit
  1 add in trunk/LayoutTests

Test failure fix. I accidentally removed this file that is still used by another
test in the directory.

• platform/mac-wk2/tiled-drawing/resources/iframe-to-hit-test.html: Added.

3:32 PM Changeset in webkit [171891] by Beth Dakin

• 15 edits
  5 moves
  1 add in trunk

Hit-testing broken in WebKit 1 views with AppKit's contentInsets
​https://bugs.webkit.org/show_bug.cgi?id=135434
-and corresponding-
<rdar://problem/17850323>

Reviewed by Benjamin Poulain.

Source/WebCore:
AppKit's contentInsets are factored into scroll positions and mouse positions, but
in WebCore, we generally want all of those things to be factored out so that, for
example, the scroll position of a document pinned to the top is the same whether
or not there is a contentInset. So to fix hit-testing in WebKit 1 views with
contentInsets, this patch factors the inset out or into of all coordinate
conversion methods just like we do for the WebKit2 contentInset.

This patch also adds the ability to test WK1 platformContentInsets with
window.internals, and it re-names convertFromRenderer to
convertFromRendererToContainingView and also re-names convertToRenderer to
convertFromContainingViewToRenderer.

ScrollView::topContentInset() takes an optional parameter indicating whether the
caller wants the WebCore::Page contentInset or the platform content inset. It’s
necessary to distinguish between these cases because there is a lot of code that
only wants the WebCore::Page contentInset since that feature is actually
implemented in WebCore as opposed to being implemented at the platform level.

• WebCore.exp.in:
• page/FrameView.cpp:

(WebCore::FrameView::topContentInset):

For layout test purposes, set the platforTopContentInset here if there is a
platformWidget().
(WebCore::FrameView::topContentInsetDidChange):

Re-named functions, also all coordinate conversion functions call
topContentInset(ManualOrPlatformContentInset)
(WebCore::FrameView::convertFromContainingViewToRenderer):
(WebCore::FrameView::convertToContainingView):
(WebCore::FrameView::convertFromContainingView):
(WebCore::FrameView::convertFromRenderer): Deleted.
(WebCore::FrameView::convertToRenderer): Deleted.

• page/FrameView.h:
• page/Page.cpp:

(WebCore::Page::setTopContentInset):

• platform/ScrollView.cpp:

(WebCore::ScrollView::documentScrollOffsetRelativeToViewOrigin):
(WebCore::ScrollView::documentScrollPositionRelativeToViewOrigin):
(WebCore::ScrollView::contentsToRootView):
(WebCore::ScrollView::rootViewToTotalContents):
(WebCore::ScrollView::contentsToWindow):
(WebCore::ScrollView::platformTopContentInset):
(WebCore::ScrollView::platformSetTopContentInset):

• platform/ScrollView.h:

(WebCore::ScrollView::topContentInset):

• platform/ios/ScrollViewIOS.mm:

(WebCore::ScrollView::platformTopContentInset):
(WebCore::ScrollView::platformSetTopContentInset):

Implement new platform inset-related functions using AppKit's implementation.

• platform/mac/ScrollViewMac.mm:

(WebCore::ScrollView::platformTopContentInset):
(WebCore::ScrollView::platformSetTopContentInset):

When we set the scroll position for the documentView, we have to factor the inset
back into the WebCore scroll position.
(WebCore::ScrollView::platformSetScrollPosition):

Re-named functions.

• rendering/RenderLayer.cpp:

(WebCore::RenderLayer::convertFromScrollbarToContainingView):
(WebCore::RenderLayer::convertFromContainingViewToScrollbar):

• rendering/RenderListBox.cpp:

(WebCore::RenderListBox::convertFromScrollbarToContainingView):
(WebCore::RenderListBox::convertFromContainingViewToScrollbar):

Source/WebKit2:
Re-named functions.

• WebProcess/Plugins/PDF/PDFPlugin.mm:

(WebKit::PDFPlugin::convertFromScrollbarToContainingView):
(WebKit::PDFPlugin::convertFromContainingViewToScrollbar):

LayoutTests:
These hit-testing related contentInset tests will now work for mac on wk1 on
Yosemite and wk2.

• platform/mac-wk1/TestExpectations:
• platform/mac-wk2/tiled-drawing/content-inset-hit-testing-expected.txt: Removed.
• platform/mac-wk2/tiled-drawing/content-inset-hit-testing-in-frame-expected.txt: Removed.
• platform/mac-wk2/tiled-drawing/content-inset-hit-testing-in-frame.html: Removed.
• platform/mac-wk2/tiled-drawing/content-inset-hit-testing.html: Removed.
• platform/mac-wk2/tiled-drawing/resources/iframe-to-hit-test.html: Removed.
• platform/mac/fast/events/content-inset-hit-testing-expected.txt: Copied from platform/mac-wk2/tiled-drawing/content-inset-hit-testing-expected.txt.
• platform/mac/fast/events/content-inset-hit-testing-in-frame-expected.txt: Copied from platform/mac-wk2/tiled-drawing/content-inset-hit-testing-in-frame-expected.txt.
• platform/mac/fast/events/content-inset-hit-testing-in-frame.html: Copied from platform/mac-wk2/tiled-drawing/content-inset-hit-testing-in-frame.html.
• platform/mac/fast/events/content-inset-hit-testing.html: Copied from platform/mac-wk2/tiled-drawing/content-inset-hit-testing.html.
• platform/mac/fast/events/resources: Added.
• platform/mac/fast/events/resources/iframe-to-hit-test.html: Copied from platform/mac-wk2/tiled-drawing/resources/iframe-to-hit-test.html.

3:07 PM Changeset in webkit [171890] by dino@apple.com

• 6 edits in trunk/Source/WebCore

Default buttons do not pulse in OS X 10.10
​https://bugs.webkit.org/show_bug.cgi?id=135447
<rdar://problem/17875896>

Reviewed by Dan Bernstein.

OS X Yosemite does not have the animated pulsing default
buttons seen in previous releases. We don't need to have
a timer in RenderButton constantly triggering repaints.

• platform/mac/ThemeMac.mm:

(WebCore::paintButton): No need to advance the animation.

• rendering/RenderButton.cpp:

(WebCore::RenderButton::styleDidChange): Ask the theme if it
should advance the animation.

• rendering/RenderTheme.h:

(WebCore::RenderTheme::defaultButtonHasAnimation): Virtual function
indicating if the button needs to repaint.

• rendering/RenderThemeMac.h:
• rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::defaultButtonHasAnimation): Provide platform
specific result on Yosemite and above.

3:06 PM Changeset in webkit [171889] by timothy_horton@apple.com

• 2 edits in trunk/Source/WebCore

DOM::renderedImageForcingBlackText returns an image with the wrong logical size on 2x displays
​https://bugs.webkit.org/show_bug.cgi?id=135442
<rdar://problem/17614632>

Reviewed by Simon Fraser.

• bindings/objc/DOM.mm:

(-[DOMRange renderedImageForcingBlackText:renderedImageForcingBlackText:]):
Scale the NSImage size by the device scale factor,
similar to what we did for drag images in r167403.
Ideally this scaling would happen in the code that
generates the images, but this is a much larger change
with much more regression potential.

2:56 PM Changeset in webkit [171888] by mark.lam@apple.com

• 3 edits in trunk/Source/JavaScriptCore

JSCell::classInfo() belongs in JSCellInlines.h.
<​https://webkit.org/b/135475>

Reviewed by Mark Hahnenberg.

• runtime/JSCellInlines.h:

(JSC::JSCell::classInfo):

• runtime/JSDestructibleObject.h:

(JSC::JSCell::classInfo): Deleted.

2:48 PM Changeset in webkit [171887] by oliver@apple.com

• 2 edits in trunk/Source/WebKit2

Various SSO services need the networking process to be able to spoof its bundle id
​https://bugs.webkit.org/show_bug.cgi?id=135468
<rdar://problem/17864139>

Reviewed by Alexey Proskuryakov.

Just add the entitlement required to allow the sandbox to let this happen.

• Configurations/Network-iOS.entitlements:

2:38 PM Changeset in webkit [171886] by betravis@adobe.com

• 18 edits in trunk

[CSS Font Loading] Rename document.fontloader to document.fonts
​https://bugs.webkit.org/show_bug.cgi?id=135393

Reviewed by Bem Jones-Bey.

Source/WebCore:
The most recent version of the specification has renamed
document.fontloader to document.fonts. This change updates the
names in WebCore and LayoutTests.

Fixed up existing tests under LayoutTests/fast/css/fontloader-*
and LayoutTests/http/webfont/fontloader-*

• css/CSSFontFace.cpp:

(WebCore::CSSFontFace::notifyFontLoader):
(WebCore::CSSFontFace::notifyLoadingDone):

• dom/Document.cpp:

(WebCore::Document::fonts):
(WebCore::Document::fontloader): Deleted.

• dom/Document.h:
• dom/Document.idl:
• page/FrameView.cpp:

(WebCore::FrameView::performPostLayoutTasks):

LayoutTests:
Update tests to use the new document.fonts name.

• fast/css/fontloader-download-error.html:
• fast/css/fontloader-events.html:
• fast/css/fontloader-loadingdone.html:
• fast/css/fontloader-multiple-faces-download-error-expected.txt:
• fast/css/fontloader-multiple-faces-download-error.html:
• fast/css/fontloader-multiple-faces-expected.txt:
• fast/css/fontloader-multiple-faces.html:
• fast/css/fontloader-multiple-families-expected.txt:
• fast/css/fontloader-multiple-families.html:
• http/tests/webfont/fontloader-loading-attribute-expected.txt:
• http/tests/webfont/fontloader-loading-attribute.html:

2:00 PM Changeset in webkit [171885] by jonowells@apple.com

• 15 edits in trunk/Source/WebInspectorUI

Web Inspector: Sync button look and feel with Xcode updates.
​https://bugs.webkit.org/show_bug.cgi?id=135445

Reviewed by Timothy Hatcher.

Update styles to match recent changes to Xcode text-only
buttons, the navigation bar, and search fields. Include
older style rules for older Mac platforms.

• UserInterface/Views/ButtonNavigationItem.css:

(.navigation-bar .item.button.text-only):
(body.mac-platform.legacy .navigation-bar .item.button.text-only):

• UserInterface/Views/CSSStyleDetailsSidebarPanel.css:

(.sidebar > .panel.details.css-style > .navigation-bar):
(.sidebar > .panel.details.css-style > .content):
(body.mac-platform.legacy .sidebar > .panel.details.css-style > .content):

• UserInterface/Views/DebuggerSidebarPanel.css:

(.sidebar > .panel.navigation.debugger > .content):
(body.mac-platform.legacy .sidebar > .panel.navigation.debugger > .content):

• UserInterface/Views/DividerNavigationItem.css:

(.navigation-bar .item.divider):
(body.mac-platform.legacy .navigation-bar .item.divider):

• UserInterface/Views/FilterBar.css:

(.filter-bar):
(body.mac-platform.legacy .filter-bar):
(.filter-bar > input[type="search"]):
(body.mac-platform.legacy .filter-bar > input[type="search"]):

• UserInterface/Views/LogContentView.css:

(.search-bar.log-search-bar > input[type="search"]):
(@media reader):
(.log-search-bar > input): Deleted.

• UserInterface/Views/Main.css:

(#split-content-browser > .navigation-bar):
(body.mac-platform.legacy #split-content-browser > .navigation-bar):

• UserInterface/Views/NavigationBar.css:

(.navigation-bar):
(body.mac-platform.legacy .navigation-bar):
(.navigation-bar .item):
(body.mac-platform.legacy .navigation-bar .item):

• UserInterface/Views/NavigationSidebarPanel.css:

(.sidebar > .panel.navigation > .content):
(body.mac-platform.legacy .sidebar > .panel.navigation > .content):

• UserInterface/Views/QuickConsole.css:

(.quick-console):
(body.mac-platform.legacy .quick-console):

• UserInterface/Views/RadioButtonNavigationItem.css:

(.navigation-bar .item.radio.button.text-only:hover):
(body.mac-platform.legacy .navigation-bar .item.radio.button.text-only:hover):
(.navigation-bar .item.radio.button.text-only.selected):
(body.mac-platform.legacy .navigation-bar .item.radio.button.text-only.selected):
(.navigation-bar .item.radio.button.text-only:active):
(.navigation-bar .item.radio.button.text-only.selected:active):
(body.mac-platform.legacy .navigation-bar .item.radio.button.text-only.selected:active):

• UserInterface/Views/ResourceSidebarPanel.css:

(.sidebar > .panel.navigation.resource > .empty-content-placeholder):
(body.mac-platform.legacy .sidebar > .panel.navigation.resource > .empty-content-placeholder):
(.sidebar > .panel.navigation.resource > .search-bar):
(body.mac-platform.legacy .sidebar > .panel.navigation.resource > .search-bar):
(.sidebar > .panel.navigation.resource > .search-bar > input[type="search"]):
(body.mac-platform.legacy .sidebar > .panel.navigation.resource > .search-bar > input[type="search"]):

• UserInterface/Views/ScopeBar.css:

(.scope-bar > li):
(body.mac-platform.legacy .scope-bar > li):
(.scope-bar > li:hover):
(body.mac-platform.legacy .scope-bar > li:hover):
(.scope-bar > li.selected):
(.scope-bar > li:active):
(body.mac-platform.legacy .scope-bar > li:active):
(.scope-bar > li.selected:active):
(body.mac-platform.legacy .scope-bar > li.selected:active):

• UserInterface/Views/SearchBar.css:

(.search-bar > input[type="search"]):
(body.mac-platform.legacy .search-bar > input[type="search"]):
Update styles and apply older styles to legacy Mac platforms.

1:22 PM Changeset in webkit [171884] by dburkart@apple.com

• 7 copies in branches/safari-537.78-branch/LayoutTests

Merge in missing LayoutTests from merge of r169475 -> r171377.

1:19 PM Changeset in webkit [171883] by Lucas Forschler

• 2 edits in branches/safari-600.1-branch/WebKitLibraries

Merge r171870. <rdar://problem/17872507>

12:50 PM Changeset in webkit [171882] by abucur@adobe.com

• 4 edits
  2 adds in trunk

REGRESSION: Search highlight is broken in RTL multicolumn content
​https://bugs.webkit.org/show_bug.cgi?id=135452

Reviewed by Simon Fraser.

Source/WebCore:
The offsets for elements inside RTL multi-column elements are incorrectly computed because
the columns don't calculate their left position according to the writing direction.

The patch extracts the column position computation in two helper functions (for top and left)
so they can be used when needed in different parts of the code. In our case, the |columnLogicalLeft|
function should be used inside |columnTranslationForOffset|.

Test: fast/multicol/content-bounding-box-rtl.html

• rendering/RenderMultiColumnSet.cpp:

(WebCore::RenderMultiColumnSet::columnLogicalLeft): Return the logical left of a column relative to the set.
(WebCore::RenderMultiColumnSet::columnLogicalTop): Return the logical top of a column relative to the set.
(WebCore::RenderMultiColumnSet::columnRectAt): Split the code between columnLogicalLeft and columnLogicalTop.
(WebCore::RenderMultiColumnSet::collectLayerFragments): Make code clearer by adding a new line.
(WebCore::RenderMultiColumnSet::columnTranslationForOffset): Use columnLogicalLeft instead of duplicating logic.

• rendering/RenderMultiColumnSet.h:

LayoutTests:
A test that verifies the bounding boxes for content inside a RTL multi-column element are correctly computed:

• for static elements
• for relative positioned elements
• for absolutely positioned elements

• fast/multicol/content-bounding-box-rtl-expected.txt: Added.
• fast/multicol/content-bounding-box-rtl.html: Added.

12:47 PM Changeset in webkit [171881] by Brian Burg

• 3 edits in trunk/Source/WebInspectorUI

Web Inspector: MessageDispatcher should not synchronously dispatch all backend messages
​https://bugs.webkit.org/show_bug.cgi?id=135427

Reviewed by Timothy Hatcher.

The frontend dispatches all queued messages from the backend synchronously, even if there are
hundreds of messages, or even if some of the messages take a long time (>10ms) to process.

This patch adds a time limit to the frontend's message dispatcher. If the time limit is exceeded
when processing the message queue, unhandled messages remain in the queue and the dispatcher goes
to sleep until the next run loop (obtained by a new setTimeout).

This has the effect of removing stutters when the message queue has hundreds of small messages.
The outliers are still the same since some single messages can take over 200ms to be handled.

This patch also improves performance logging in InspectorBackend so that it is easier to see
message handling times and their distribution among run loop turns.

• UserInterface/Protocol/InspectorBackend.js:

(InspectorBackendClass): Add a new diagnostic flag that warns about slow message handling.
(InspectorBackendClass.prototype._dispatchCallback.get if): Improve logging.
(InspectorBackendClass.prototype._dispatchCallback): Improve logging.
(InspectorBackendClass.prototype._dispatchEvent): Improve logging.

• UserInterface/Protocol/MessageDispatcher.js:

(WebInspector.dispatchNextQueuedMessageFromBackend): Keep track of a time limit for message
dispatching, and set a new timeout if we exceed the time limit.

12:21 PM Changeset in webkit [171880] by ap@apple.com

• 4 edits in trunk/Tools

media/track/add-and-remove-track.html and media/media-fragments/TC0001.html are flaky
on Mac WK2 EWS, asserting under TestRunner::removeAllWebNotificationPermissions
​https://bugs.webkit.org/show_bug.cgi?id=135418

Reviewed by Anders Carlsson.

This was only happening in shared web process mode, because WKBundlePostMessage
has different behavior then. When there is no process, the message is dropped on
the floor in multiple process mode, but it's stored to be delivered after launch
in shared process mode.

So, calling resetStateToConsistentValues() resulted in storing a Reset bundle message
that was delivered immediately after launch, when there was nothing to reset.

We don't actually need to reset anything at this point, as the previous call has
already reset everything UI process side, and web process is brand new. All we need
is to reattach the page to a process, as invoke() expects one to exist.

• WebKitTestRunner/TestController.cpp: (WTR::TestController::reattachPageToWebProcess):
• WebKitTestRunner/TestController.h:
• WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::invoke):

12:21 PM Changeset in webkit [171879] by matthew_hanson@apple.com

• 5 edits in tags/Safari-600.1.4.2/Source

Merge r171866. <rdar://problem/17872676>

12:17 PM Changeset in webkit [171878] by Lucas Forschler

• 2 edits in tags/Safari-600.1.2.5/WebKitLibraries

Merge r171870. <rdar://problem/17872507>

12:17 PM Changeset in webkit [171877] by matthew_hanson@apple.com

• 5 edits in branches/safari-600.1.4-branch/Source

Merge r171866. <rdar://problem/17872676>

12:13 PM Changeset in webkit [171876] by Lucas Forschler

• 5 edits in tags/Safari-600.1.2.5/Source

Versioning.

12:08 PM Changeset in webkit [171875] by Lucas Forschler

• 1 copy in tags/Safari-600.1.2.5

New Tag.

12:03 PM Changeset in webkit [171874] by matthew_hanson@apple.com

• 1 copy in tags/Safari-600.1.4.2

New Tag.

11:59 AM Changeset in webkit [171873] by matthew_hanson@apple.com

• 2 edits in branches/safari-600.1.4-branch/Source/WebKit2

Merge r171829. <rdar://problem/17824833>

11:53 AM Changeset in webkit [171872] by matthew_hanson@apple.com

• 2 edits in branches/safari-600.1.4-branch/Source/WebCore

Merge r171851. <rdar://problem/17719026>

11:20 AM Changeset in webkit [171871] by mhodovan.u-szeged@partner.samsung.com

• 7 edits in trunk/Source/WebCore

Eliminate "FractionConversion" from CSSPrimitiveValue::convertToLength
​https://bugs.webkit.org/show_bug.cgi?id=135377

Reviewed by Darin Adler.

The FractionConversion argument in CSSPrimitiveValue::convertToLength
doesn't seem to actually have a purpose. It is for converting numbers
into Length(x * 100, Percent), but this case shouldn't be reachable.
The original patch introducing it doesn't shed any light either:
[​https://bugs.webkit.org/show_bug.cgi?id=74913

This patch removes the now unused FractionConversion argument. Note
that we can probably also merge the two Fixed conversions, as the
two only differ in clamping large numbers (probably unintended).

No new tests.

• css/CSSCalculationValue.cpp:

(WebCore::determineCategory):

• css/CSSParser.cpp:

(WebCore::parseTransformTranslateArguments):
(WebCore::parseTranslateTransformValue):
(WebCore::parseTransformArguments): Deleted.

• css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::convertToLength):

• css/DeprecatedStyleBuilder.cpp:

(WebCore::ApplyPropertyClip::convertToLength):

• css/StyleResolver.cpp:

(WebCore::StyleResolver::convertToIntLength):
(WebCore::StyleResolver::convertToFloatLength):

• css/TransformFunctions.cpp:

(WebCore::convertToFloatLength):

11:00 AM Changeset in webkit [171870] by Brent Fulgham

• 2 edits in trunk/WebKitLibraries

[Win] Fix build failure when using 5-tuple build versions.
​https://bugs.webkit.org/show_bug.cgi?id=135464
<rdar://problem/17872507>

Reviewed by David Kilzer.

• win/tools/scripts/version-stamp.pl: Modify the environment for

the VersionStamper sub-process to work around bug in that tool.

10:42 AM Changeset in webkit [171869] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Right edge of Timeline Record button does not work
​https://bugs.webkit.org/show_bug.cgi?id=135444

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-07-31
Reviewed by Timothy Hatcher.

When hovering the record button we would show the status text, however
because the left edge of the status text box would overlap the right
edge of the record button causing completely unexpected behavior.

Position the status text correctly so that it never overlaps the record
button. 5px to match the left margin of the record button, and another
2px for some padding between the button and text.

• UserInterface/Views/TimelineSidebarPanel.css:

(.sidebar > .panel.navigation.timeline > .status-bar > .record-status):

10:40 AM Changeset in webkit [171868] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit2

Fix uninitialized scalar variable
​https://bugs.webkit.org/show_bug.cgi?id=135461

Patch by Przemyslaw Kuczynski <​p.kuczynski@samsung.com> on 2014-07-31
Reviewed by Alexey Proskuryakov.

If fopen fails, returned ApplicationMemoryStats structure will be uninitialized

• Shared/linux/WebMemorySamplerLinux.cpp:

(WebKit::sampleMemoryAllocatedForApplication): Initialized applicationStats.

10:37 AM Changeset in webkit [171867] by commit-queue@webkit.org

• 2 edits in trunk/Source/JavaScriptCore

Build warning in webkit/Source/JavaScriptCore/llint/LLIntSlowPaths.cpp
​https://bugs.webkit.org/show_bug.cgi?id=135414

Patch by Tanay C <​tanay.c@samsung.com> on 2014-07-31
Reviewed by Csaba Osztrogonác.

• llint/LLIntSlowPaths.cpp:

(JSC::LLInt::putToScopeCommon):removed unused parameter from function definition

10:34 AM Changeset in webkit [171866] by commit-queue@webkit.org

• 6 edits in trunk/Source

Web Inspector: console.profile missing profile information
​https://bugs.webkit.org/show_bug.cgi?id=135432

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-07-31
Reviewed by Timothy Hatcher.

Source/WebCore:
By switching console.profile to start/stop the timeline we would
not have a chance to recompile JS functions with profiling information.
This used to work because whenever the inspector was open we would
have profiling information enabled. Go back to that behavior.

• inspector/InspectorController.cpp:

(WebCore::InspectorController::profilerEnabled):
Instead of checking if the timeline agent has started, check if the
timeline agent has been created. Going back to the normal behavior
of always having profiling information when the inspector is open.

• inspector/InspectorTimelineAgent.h:
• inspector/InspectorTimelineAgent.cpp:

(WebCore::InspectorTimelineAgent::didCreateFrontendAndBackend):
Recompile initializing the timeline agent to include profiling information.

(WebCore::InspectorTimelineAgent::willDestroyFrontendAndBackend):
Recompile destrying the timeline agent, only if needed.

(WebCore::InspectorTimelineAgent::willCallFunction):
(WebCore::InspectorTimelineAgent::didCallFunction):
(WebCore::InspectorTimelineAgent::willEvaluateScript):
(WebCore::InspectorTimelineAgent::didEvaluateScript):
Using a boolean to track nested calls would not give expected
behavior when un-nesting. Switch to a counter to ensure that
as we start profiling in the outermost level we then stop
profiling at that same level and not inside an inner nesting.

Source/WebInspectorUI:

• UserInterface/Models/ScriptTimelineRecord.js:

Delete the payload information as soon as it has been processed.
It is no longer needed anymore and can be garbage collected.

10:24 AM Changeset in webkit [171865] by betravis@adobe.com

• 9 edits in trunk/LayoutTests

[CSS Font Loading] Test expectations should show success
​https://bugs.webkit.org/show_bug.cgi?id=135420

Reviewed by Bem Jones-Bey.

Modify the expected files to represent success, and skip
the tests until the feature is enabled.

• TestExpectations: Skip the tests.
• fast/css/fontloader-download-error-expected.txt:
• fast/css/fontloader-events-expected.txt:
• fast/css/fontloader-loadingdone-expected.txt:
• fast/css/fontloader-multiple-faces-download-error-expected.txt:
• fast/css/fontloader-multiple-faces-expected.txt:
• fast/css/fontloader-multiple-families-expected.txt:
• http/tests/webfont/fontloader-loading-attribute-expected.txt:

10:20 AM Changeset in webkit [171864] by bshafiei@apple.com

• 7 edits in tags/Safari-600.1.3.3/Source

Roll out r171647. <rdar://problem/17315168>

10:18 AM Changeset in webkit [171863] by bshafiei@apple.com

• 5 edits
  9 deletes in tags/Safari-600.1.3.3

Roll out r171661. <rdar://problem/17315237>

10:16 AM Changeset in webkit [171862] by commit-queue@webkit.org

• 6 edits in trunk/Source/WebCore

Refactor EventHandler to call ScrollAnimator::handleWheelEvent for overflow scrolling
​https://bugs.webkit.org/show_bug.cgi?id=135195

Patch by Wenson Hsieh <Wenson Hsieh> on 2014-07-31
Reviewed by Beth Dakin.

ScrollableArea::handleWheelEvent is not currently being used to handle wheel events for overflow scrolling; it instead directly invokes ScrollableArea::scroll.
In order to expose wheel phases on Mac, the PlatformWheelEvent itself should propagate down to ScrollableArea, not just the scroll granularity, direction and
multiplier required by ScrollableArea::scroll. With this patch, PlatformWheelEvent will be "shipped" along with the WheelEvent.

No new tests, since behavior should not have changed.

• page/EventHandler.cpp:

(WebCore::didScrollInScrollableAreaForSingleAxis): Calls ScrollableArea::scroll directly using WheelEvent's data. Used to handle programmatic WheelEvents, e.g. from JavaScript.
(WebCore::handleWheelEventInAppropriateEnclosingBoxForSingleAxis): Finds the correct ScrollableArea and attempts to scroll it using the information contained in the WheelEvent via ScrollableArea::handleWheelEvent
(WebCore::EventHandler::defaultWheelEventHandler): Updated to use handleWheelEventInAppropriateEnclosingBoxForSingleAxis instead of scrollNode.
(WebCore::scrollNode): Deleted.

• rendering/RenderListBox.h: Made RenderListBox::scroll public so it can be invoked from EventHandler::handleWheelEventInAppropriateEnclosingBoxForSingleAxis.
• rendering/RenderNamedFlowThread.cpp: Refactored to let EventHandler update nextScrollBlock in the case of isRenderNamedFlowThread().

(WebCore::RenderNamedFlowThread::fragmentFromRenderBoxAsRenderBlock):

• rendering/RenderNamedFlowThread.h:

10:15 AM Changeset in webkit [171861] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit2

Clean up the WebKit build from unused parameter warning in Webkit2/WebProcess module
​https://bugs.webkit.org/show_bug.cgi?id=135413

Patch by Rohit Kumar <​kumar.rohit@samsung.com> on 2014-07-31
Reviewed by Darin Adler.

• WebProcess/OriginData/WebOriginDataManager.cpp:

(WebKit::WebOriginDataManager::getOrigins):
(WebKit::WebOriginDataManager::deleteEntriesForOrigin):
(WebKit::WebOriginDataManager::deleteEntriesModifiedBetweenDates):
(WebKit::WebOriginDataManager::deleteAllEntries):

10:11 AM Changeset in webkit [171860] by Chris Fleizach

• 7 edits in trunk/Source/WebKit2

AX: iOS: Crash accessing m_page in WKAccessibilityPageObject
​https://bugs.webkit.org/show_bug.cgi?id=134617

Reviewed by Darin Adler.

Provide a way to detach a WK2 WebPage object so that it can uninitialize other pointers, like the accessibility object.

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::~WebPage):

• WebProcess/WebPage/WebPage.h:
• WebProcess/WebPage/efl/WebPageEfl.cpp:

(WebKit::WebPage::platformDetach):

• WebProcess/WebPage/gtk/WebPageGtk.cpp:

(WebKit::WebPage::platformDetach):

• WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::platformDetach):

• WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::platformDetach):

9:45 AM Changeset in webkit [171859] by mitz@apple.com

• 4 edits in trunk

[WK2] Regression tests can't load HTTPS pages with NetworkProcess due to self-signed certificate
​https://bugs.webkit.org/show_bug.cgi?id=115282

Reviewed by Sam Weinig.

Tools:

• WebKitTestRunner/TestController.cpp:

(WTR::TestController::canAuthenticateAgainstProtectionSpaceInFrame): Return true for any
local host server trust protection space.
(WTR::TestController::didReceiveAuthenticationChallengeInFrame): Respond with a non-empty
credential to server trust challenges.

LayoutTests:

• platform/mac-wk2/TestExpectations: Removed the exceptions listed under this bug.

9:43 AM Changeset in webkit [171858] by mitz@apple.com

• 5 edits in trunk/Source

Source/WebCore: WebCore part of: Server trust authentication challenges aren’t sent to the navigation delegate
​https://bugs.webkit.org/show_bug.cgi?id=135327

Reviewed by Alexey Proskuryakov.

• platform/network/cf/ResourceHandleCFNet.cpp:

(WebCore::ResourceHandle::receivedCredential): Don’t try to change the persistence of
credentials used for server trust, because the platform doesn’t support persistence values
other than Session for server trust.

• platform/network/mac/ResourceHandleMac.mm:

(WebCore::ResourceHandle::receivedCredential): Ditto.

Source/WebKit2: WebKit part of: Server trust authentication challenges aren’t sent to the navigation delegate
​https://bugs.webkit.org/show_bug.cgi?id=135327

Reviewed by Alexey Proskuryakov.

• UIProcess/Cocoa/NavigationState.mm:

(WebKit::NavigationState::LoaderClient::canAuthenticateAgainstProtectionSpaceInFrame):
Return true for server trust protection spaces if the delegate implements
-webView:didReceiveAuthenticationChallenge:completionHandler:.
(WebKit::NavigationState::LoaderClient::didReceiveAuthenticationChallengeInFrame): Removed
an assertion that is no longer true due to the above.

9:41 AM Changeset in webkit [171857] by mitz@apple.com

• 2 edits in trunk/Source/WebCore

Tried to fix building with the OS X 10.9 SDK while targeting OS X 10.8.

• platform/network/cocoa/CredentialCocoa.mm:

(WebCore::toCredentialPersistence):

9:24 AM Changeset in webkit [171856] by commit-queue@webkit.org

• 3 edits in trunk/Tools

[webkitpy] Make diff_text generate correct diff if there is no newline at the end of file
​https://bugs.webkit.org/show_bug.cgi?id=135381

Patch by Tibor Meszaros <​tmeszaros.u-szeged@partner.samsung.com> on 2014-07-31
Reviewed by Csaba Osztrogonác.

• Scripts/webkitpy/port/base.py:

(Port.diff_text):

• Scripts/webkitpy/port/base_unittest.py:

(PortTest.test_diff_text):

9:16 AM Changeset in webkit [171855] by mitz@apple.com

• 2 edits in trunk/Source/WebCore

Reverted r171854, because it broke building with the OS X 10.8 SDK.

• platform/network/cocoa/CredentialCocoa.mm:

(WebCore::toCredentialPersistence):

9:07 AM Changeset in webkit [171854] by mitz@apple.com

• 2 edits in trunk/Source/WebCore

Tried to fix building with the OS X 10.9 SDK while targeting OS X 10.8.

• platform/network/cocoa/CredentialCocoa.mm:

(WebCore::toCredentialPersistence):

8:58 AM Changeset in webkit [171853] by Michał Pakuła vel Rutka

• 2 edits in trunk/LayoutTests

Unreviewed EFL gardening

Update test expectations for crashing tests.

• platform/efl/TestExpectations:

8:21 AM Changeset in webkit [171852] by fpizlo@apple.com

• 1 edit
  1 add in trunk/Source/JavaScriptCore

NewFunctionExpression and NewFunctionNoCheck should setHaveStructures(true)
​https://bugs.webkit.org/show_bug.cgi?id=135430

Reviewed by Mark Hahnenberg.

We already handled this correctly after the ftlopt merge, but it's useful to have the test.

• tests/stress/new-function-expression-has-structures.js: Added.

(foo.f):
(foo.f.prototype.f):
(foo):

8:08 AM Changeset in webkit [171851] by jer.noble@apple.com

• 2 edits in trunk/Source/WebCore

REGRESSION(??): [iOS] Disabling MediaPlaybackRequiresUserGesture does not remove user gesture requirement for entering full screen.
​https://bugs.webkit.org/show_bug.cgi?id=135443

Reviewed by Dean Jackson.

Allow full screen mode to be entered without a user gesture if the gesture requirement for media playback
has been unset.

• html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::HTMLMediaElement):

7:05 AM Changeset in webkit [171850] by Carlos Garcia Campos

• 4 edits in trunk

Unreviewed. Update OptionsGTK.cmake and NEWS for 2.5.1 release.

.:

• Source/cmake/OptionsGTK.cmake: Bump version numbers.

Source/WebKit2:

• gtk/NEWS: Add release notes for 2.5.1.

6:43 AM Changeset in webkit [171849] by abucur@adobe.com

• 3 edits
  6 adds in trunk

2014-07-31 Andrei Bucur <​abucur@adobe.com>

[CSS Multicolumn] Clear the lines when switching to multi-column layout
​https://bugs.webkit.org/show_bug.cgi?id=135127

Reviewed by Alexandru Chiculita.

Source/WebCore:

When switching an element to multi-column layout it becomes a container of block
children. When this happens the existing line boxes must be deleted in addition
to clearing the hasInlineChildren flag.

Tests: fast/multicol/inline-container-to-multicol.html

fast/multicol/inline-container-to-multicol-float.html
fast/multicol/inline-container-to-multicol-positioned.html

• rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::createMultiColumnFlowThread):

LayoutTests:

Tests that verifies lines are correctly cleared when an element is switched to
multi-column layout.

• fast/multicol/inline-container-to-multicol-expected.txt: Added.
• fast/multicol/inline-container-to-multicol.html: Added.
• fast/multicol/inline-container-to-multicol-float-expected.txt: Added.
• fast/multicol/inline-container-to-multicol-float.html: Added.
• fast/multicol/inline-container-to-multicol-positioned-expected.txt: Added.
• fast/multicol/inline-container-to-multicol-positioned.html: Added.

6:18 AM Changeset in webkit [171848] by Carlos Garcia Campos

• 5 edits in trunk

Unreviewed. Fix GTK+ make distcheck.

Source/WebKit2:

• Shared/InteractionInformationAtPosition.h: Only include

WebCore/SelectionRect.h for IOS.

Tools:

• gtk/make-dist.py:

(ensure_version_if_possible): Use 4.0 instead of 3.0 as binary
version to find the pkg-config file.

• gtk/manifest.txt: Add missing resource to the tarball.

5:27 AM Changeset in webkit [171847] by Carlos Garcia Campos

• 2 edits in trunk/Tools

[GTK] make distcheck is building from sources dir instead of dist dir
​https://bugs.webkit.org/show_bug.cgi?id=135457

Reviewed by Philippe Normand.

• gtk/make-dist.py:

(Distcheck.configure): Use dist_dir as source dir.
(Distcheck.check): Pass dist_dir to configure().

2:16 AM Changeset in webkit [171846] by Carlos Garcia Campos

• 4 edits in trunk

[GTK] Bump binary version for 2.6
​https://bugs.webkit.org/show_bug.cgi?id=133724

Reviewed by Philippe Normand.

.:

• Source/cmake/OptionsGTK.cmake: Bump binary version to 4.0 and

update library version numbers.

Source/WebKit2:

• PlatformGTK.cmake: Fix JavaScriptCore dependency on

instrospection commands and make them depend on GTK+-3.0.

1:41 AM Changeset in webkit [171845] by Carlos Garcia Campos

• 2 edits in trunk/Tools

[GTK] Do not include files that are not in git in the tarball
​https://bugs.webkit.org/show_bug.cgi?id=134804

Reviewed by Philippe Normand.

Skip all files in the source tree that are not under version control
except for files added from the build dir like the documentation.

• gtk/make-dist.py:

(Directory.init): Initialize the list of files under control version.
(Directory.list_cms_files): Helper function to list all files
under the control version for the current source root.
(Directory.should_skip_file): Return True for files that are not
under control version only when the source root is also under
control version.
(Directory.get_files): Filter the files also using should_skip_file().

12:36 AM Changeset in webkit [171844] by akling@apple.com

• 2 edits in trunk/Source/WebKit

Speculative Windows build fixery, part II.

This seems to indicate that adding the globalObjectTable to the exports file
was the wrong idea:

1>WebKit.exp : error LNK2001: unresolved external symbol "struct JSC::HashTable const JSC::globalObjectTable" (?globalObjectTable@JSC@@3UHashTable@1@B)

• WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:

Jul 30, 2014:

11:51 PM Changeset in webkit [171843] by akling@apple.com

• 3 edits in trunk/Source/JavaScriptCore

Speculative Windows build fix.

Try to dllimport the dllexported global object HashTable.

• jsc.cpp:
• testRegExp.cpp:

11:17 PM Changeset in webkit [171842] by Lucas Forschler

• 5 edits in branches/safari-600.1-branch/Source

Versioning.

11:06 PM Changeset in webkit [171841] by Lucas Forschler

• 1 copy in tags/Safari-600.1.6

New Tag.

10:49 PM Changeset in webkit [171840] by Lucas Forschler

• 10 edits
  2 copies in branches/safari-600.1-branch

Merged r171825.

10:40 PM Changeset in webkit [171839] by Lucas Forschler

• 2 edits in branches/safari-600.1-branch/Source/WebCore

Merged r171802. <rdar://problem/17199364>

10:38 PM Changeset in webkit [171838] by akling@apple.com

• 10 edits in trunk/Source

PropertyName's internal string is always atomic.
<​https://webkit.org/b/135451>

Source/JavaScriptCore:
Now that we've merged the JSC::Identifier and WTF::AtomicString tables,
we know that any string that's an Identifier is guaranteed to be atomic.

A PropertyName can be either an Identifier or a PrivateName, and the
private names are also guaranteed to be atomic internally.

Make PropertyName vend AtomicStringImpl* instead of StringImpl*.

Reviewed by Benjamin Poulain.

• runtime/PropertyName.h:

(JSC::PropertyName::PropertyName):
(JSC::PropertyName::uid):
(JSC::PropertyName::publicName):

Source/WebCore:
Use PropertyName::publicName() directly instead of taking the slow route
through AtomicString::findStringWithHash().

These strings are always atomic, and findStringWithHash() would trudge
through a full hash lookup just to discover that indeed, they are!

Reviewed by Benjamin Poulain.

• bindings/js/JSDOMBinding.cpp:

(WebCore::findAtomicString): Deleted.

• bindings/js/JSDOMBinding.h:
• bindings/js/JSDOMWindowCustom.cpp:

(WebCore::namedItemGetter):
(WebCore::JSDOMWindow::getOwnPropertySlot):
(WebCore::JSDOMWindow::getOwnPropertySlotByIndex):

• bindings/js/JSHTMLDocumentCustom.cpp:

(WebCore::JSHTMLDocument::canGetItemsForName):
(WebCore::JSHTMLDocument::nameGetter):

Source/WTF:
Remove AtomicString::findStringWithHash() since nobody uses it anymore.

Reviewed by Benjamin Poulain.

• wtf/text/AtomicString.cpp:

(WTF::findString): Deleted.
(WTF::AtomicString::findStringWithHash): Deleted.

• wtf/text/AtomicString.h:

8:36 PM Changeset in webkit [171837] by Lucas Forschler

• 2 edits in branches/safari-600.1-branch/Source/WebKit2

Merged r171829. <rdar://problem/17824833>

8:19 PM Changeset in webkit [171836] by benjamin@webkit.org

• 1 edit
  2 adds in trunk/LayoutTests

Add a layout test for Geolocation's request queueing for hidden pages
​https://bugs.webkit.org/show_bug.cgi?id=135402

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2014-07-30
Reviewed by Zalan Bujtas.

Sam added the queueing feature in r171188. This patch adds a layout test
for the simplest case.

• fast/dom/Geolocation/requestQueuingForHiddenPage-expected.txt: Added.
• fast/dom/Geolocation/requestQueuingForHiddenPage.html: Added.

8:18 PM Changeset in webkit [171835] by benjamin@webkit.org

• 2 edits in trunk/Source/WebCore

ElementRuleCollector: group the shadow tree code
​https://bugs.webkit.org/show_bug.cgi?id=135410

Reviewed by Andreas Kling.

• css/ElementRuleCollector.cpp:

(WebCore::ElementRuleCollector::collectMatchingRules):
Little cleanup: group the shadow tree rule collection in the same block.

8:17 PM Changeset in webkit [171834] by benjamin@webkit.org

• 3 edits in trunk/Source/WebCore

Cleanup DetailsMarkerControl
​https://bugs.webkit.org/show_bug.cgi?id=135429

Reviewed by Andreas Kling.

Remove the override of shadowPseudoId(). This is a simple type of shadowId,
it should use the generic pseudo() path.

Move DetailsMarkerControl::create() out-of-line. One could justify inlining the constructor,
inlining the ::create() function has little value.

• html/shadow/DetailsMarkerControl.cpp:

(WebCore::DetailsMarkerControl::create):
(WebCore::DetailsMarkerControl::DetailsMarkerControl):
(WebCore::DetailsMarkerControl::rendererIsNeeded):
(WebCore::DetailsMarkerControl::shadowPseudoId): Deleted.
(WebCore::DetailsMarkerControl::summaryElement): Deleted.

• html/shadow/DetailsMarkerControl.h:

(WebCore::DetailsMarkerControl::create): Deleted.

8:16 PM Changeset in webkit [171833] by benjamin@webkit.org

• 3 edits in trunk/Source/WebCore

Remove UploadButtonElement::shadowPseudoId()
​https://bugs.webkit.org/show_bug.cgi?id=135435

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2014-07-30
Reviewed by Andreas Kling.

Use the generic pseudo() path instead of a custom shadowPseudoId().

• html/FileInputType.cpp:

(WebCore::UploadButtonElement::create):
(WebCore::UploadButtonElement::createForMultiple):
(WebCore::UploadButtonElement::UploadButtonElement):
Set the type in the common constructor instead of the call sites.
(WebCore::UploadButtonElement::shadowPseudoId): Deleted.

• html/FileInputType.h:

8:16 PM Changeset in webkit [171832] by benjamin@webkit.org

• 3 edits in trunk/Source/WebCore

Remove SpinButtonElement::shadowPseudoId
​https://bugs.webkit.org/show_bug.cgi?id=135436

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2014-07-30
Reviewed by Andreas Kling.

Use the generic pseudo.

• html/shadow/SpinButtonElement.cpp:

(WebCore::SpinButtonElement::SpinButtonElement):
(WebCore::SpinButtonElement::shadowPseudoId): Deleted.

• html/shadow/SpinButtonElement.h:

8:15 PM Changeset in webkit [171831] by benjamin@webkit.org

• 3 edits in trunk/Source/WebCore

Clean up YouTubeEmbedShadowElement
​https://bugs.webkit.org/show_bug.cgi?id=135437

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2014-07-30
Reviewed by Andreas Kling.

• html/shadow/YouTubeEmbedShadowElement.cpp:

(WebCore::YouTubeEmbedShadowElement::YouTubeEmbedShadowElement):
(WebCore::YouTubeEmbedShadowElement::pluginElement): Deleted.
This is unused in WebCore.

(WebCore::YouTubeEmbedShadowElement::shadowPseudoId): Deleted.
Use the generic pseudo path instead of a custom shadowPseudoId.

• html/shadow/YouTubeEmbedShadowElement.h:

8:14 PM Changeset in webkit [171830] by benjamin@webkit.org

• 3 edits in trunk/Source/WebCore

Remove shadowPseudoId() from InputFieldSpeechButtonElement and SearchFieldCancelButtonElement
​https://bugs.webkit.org/show_bug.cgi?id=135438

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2014-07-30
Reviewed by Andreas Kling.

Use the generic path.

• html/shadow/TextControlInnerElements.cpp:

(WebCore::SearchFieldCancelButtonElement::SearchFieldCancelButtonElement):
(WebCore::InputFieldSpeechButtonElement::InputFieldSpeechButtonElement):
(WebCore::SearchFieldCancelButtonElement::shadowPseudoId): Deleted.
(WebCore::InputFieldSpeechButtonElement::shadowPseudoId): Deleted.

• html/shadow/TextControlInnerElements.h:

7:19 PM Changeset in webkit [171829] by enrica@apple.com

• 2 edits in trunk/Source/WebKit2

REGRESSION (WK2 iOS): Inline editing for Chinese and Japanese keyboards does not work in Safari.
​https://bugs.webkit.org/show_bug.cgi?id=135449
<rdar://problem/17824833>

Reviewed by Benjamin Poulain.

The WebProcess sends the notification that the gesture modified the phrase boundary,
but the flag was not being converted properly, therefore we failed to notify
the text input system that a change had occurred.

• UIProcess/ios/WKContentViewInteraction.mm:

(toUIWKSelectionFlags):

6:48 PM Changeset in webkit [171828] by bshafiei@apple.com

• 5 edits in tags/Safari-600.1.3.41/Source

Versioning.

6:46 PM Changeset in webkit [171827] by bshafiei@apple.com

• 1 copy in tags/Safari-600.1.3.41

New tag.

6:13 PM Changeset in webkit [171826] by aestes@apple.com

• 25 edits in trunk/Source

USE(CONTENT_FILTERING) should be ENABLE(CONTENT_FILTERING)
​https://bugs.webkit.org/show_bug.cgi?id=135439

Reviewed by Tim Horton.

We now support two different platform content filters, and will soon support a mock content filter (as part of
webkit.org/b/128858). This makes content filtering a feature of WebKit, not just an adoption of a third-party
library. ENABLE() is the correct macro to use for such a feature.

Source/JavaScriptCore:

• Configurations/FeatureDefines.xcconfig:

Source/WebCore:

• Configurations/FeatureDefines.xcconfig:
• WebCore.exp.in:
• loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::finishedLoading):
(WebCore::DocumentLoader::responseReceived):
(WebCore::DocumentLoader::commitData):
(WebCore::DocumentLoader::dataReceived):

• loader/DocumentLoader.h:
• loader/FrameLoaderClient.h:
• platform/ContentFilter.h:
• platform/ios/ContentFilterIOS.mm:
• platform/mac/ContentFilterMac.mm:

Source/WebKit/mac:

• Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

• Configurations/FeatureDefines.xcconfig:
• Shared/WebCoreArgumentCoders.h:
• UIProcess/WebFrameProxy.cpp:

(WebKit::WebFrameProxy::didStartProvisionalLoad):

• UIProcess/WebFrameProxy.h:
• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::decidePolicyForNavigationAction):

• UIProcess/WebPageProxy.h:
• UIProcess/WebPageProxy.messages.in:
• WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
• WebProcess/WebCoreSupport/WebFrameLoaderClient.h:

Source/WTF:

• wtf/Platform.h:

3:54 PM Changeset in webkit [171825] by matthew_hanson@apple.com

• 10 edits
  1 copy
  2 adds in tags/Safari-600.1.2.4

Merge r171798. <rdar://problem/17849033>

3:26 PM Changeset in webkit [171824] by akling@apple.com

• 226 edits
  2 deletes in trunk/Source

Static hash tables no longer need to be coupled with a VM.
<​https://webkit.org/b/135421>

Source/JavaScriptCore:
Now that the static hash tables are using char instead of StringImpl,
it's no longer necessary to make them per-VM.

This patch removes the hook in ClassInfo for providing your own static
hash table getter. Everyone now uses ClassInfo::staticPropHashTable.
Most of this patch is tweaking ClassInfo construction sites to pass one
less null pointer.

Also simplified Lookup.h to stop requiring ExecState/VM to access the
static hash tables.

Reviewed by Geoffrey Garen.

• API/JSAPIWrapperObject.mm:
• API/JSCallbackConstructor.cpp:
• API/JSCallbackFunction.cpp:
• API/JSCallbackObject.cpp:
• API/ObjCCallbackFunction.mm:
• bytecode/UnlinkedCodeBlock.cpp:
• create_hash_table:
• debugger/DebuggerScope.cpp:
• inspector/JSInjectedScriptHost.cpp:
• inspector/JSInjectedScriptHostPrototype.cpp:
• inspector/JSJavaScriptCallFrame.cpp:
• inspector/JSJavaScriptCallFramePrototype.cpp:
• interpreter/CallFrame.h:

(JSC::ExecState::arrayConstructorTable): Deleted.
(JSC::ExecState::arrayPrototypeTable): Deleted.
(JSC::ExecState::booleanPrototypeTable): Deleted.
(JSC::ExecState::dataViewTable): Deleted.
(JSC::ExecState::dateTable): Deleted.
(JSC::ExecState::dateConstructorTable): Deleted.
(JSC::ExecState::errorPrototypeTable): Deleted.
(JSC::ExecState::globalObjectTable): Deleted.
(JSC::ExecState::jsonTable): Deleted.
(JSC::ExecState::numberConstructorTable): Deleted.
(JSC::ExecState::numberPrototypeTable): Deleted.
(JSC::ExecState::objectConstructorTable): Deleted.
(JSC::ExecState::privateNamePrototypeTable): Deleted.
(JSC::ExecState::regExpTable): Deleted.
(JSC::ExecState::regExpConstructorTable): Deleted.
(JSC::ExecState::regExpPrototypeTable): Deleted.
(JSC::ExecState::stringConstructorTable): Deleted.
(JSC::ExecState::promisePrototypeTable): Deleted.
(JSC::ExecState::promiseConstructorTable): Deleted.

• jsc.cpp:
• parser/Lexer.h:

(JSC::Keywords::isKeyword):
(JSC::Keywords::getKeyword):

• runtime/Arguments.cpp:
• runtime/ArgumentsIteratorConstructor.cpp:
• runtime/ArgumentsIteratorPrototype.cpp:
• runtime/ArrayBufferNeuteringWatchpoint.cpp:
• runtime/ArrayConstructor.cpp:

(JSC::ArrayConstructor::getOwnPropertySlot):

• runtime/ArrayIteratorConstructor.cpp:
• runtime/ArrayIteratorPrototype.cpp:
• runtime/ArrayPrototype.cpp:

(JSC::ArrayPrototype::getOwnPropertySlot):

• runtime/BooleanConstructor.cpp:
• runtime/BooleanObject.cpp:
• runtime/BooleanPrototype.cpp:

(JSC::BooleanPrototype::getOwnPropertySlot):

• runtime/ClassInfo.h:

(JSC::ClassInfo::hasStaticProperties):
(JSC::ClassInfo::propHashTable): Deleted.

• runtime/ConsolePrototype.cpp:
• runtime/CustomGetterSetter.cpp:
• runtime/DateConstructor.cpp:

(JSC::DateConstructor::getOwnPropertySlot):

• runtime/DateInstance.cpp:
• runtime/DatePrototype.cpp:

(JSC::DatePrototype::getOwnPropertySlot):

• runtime/Error.cpp:
• runtime/ErrorConstructor.cpp:
• runtime/ErrorInstance.cpp:
• runtime/ErrorPrototype.cpp:

(JSC::ErrorPrototype::getOwnPropertySlot):

• runtime/ExceptionHelpers.cpp:
• runtime/Executable.cpp:
• runtime/FunctionConstructor.cpp:
• runtime/FunctionPrototype.cpp:
• runtime/GetterSetter.cpp:
• runtime/InternalFunction.cpp:
• runtime/JSAPIValueWrapper.cpp:
• runtime/JSActivation.cpp:
• runtime/JSArgumentsIterator.cpp:
• runtime/JSArray.cpp:
• runtime/JSArrayBuffer.cpp:
• runtime/JSArrayBufferConstructor.cpp:
• runtime/JSArrayBufferPrototype.cpp:
• runtime/JSArrayBufferView.cpp:
• runtime/JSArrayIterator.cpp:
• runtime/JSBoundFunction.cpp:
• runtime/JSConsole.cpp:
• runtime/JSDataView.cpp:
• runtime/JSDataViewPrototype.cpp:

(JSC::JSDataViewPrototype::getOwnPropertySlot):

• runtime/JSFunction.cpp:
• runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::getOwnPropertySlot):

• runtime/JSMap.cpp:
• runtime/JSMapIterator.cpp:
• runtime/JSNameScope.cpp:
• runtime/JSNotAnObject.cpp:
• runtime/JSONObject.cpp:

(JSC::JSONObject::getOwnPropertySlot):

• runtime/JSObject.cpp:

(JSC::getClassPropertyNames):
(JSC::JSObject::put):
(JSC::JSObject::deleteProperty):
(JSC::JSObject::findPropertyHashEntry):
(JSC::JSObject::reifyStaticFunctionsForDelete):

• runtime/JSObject.h:
• runtime/JSPromise.cpp:
• runtime/JSPromiseConstructor.cpp:

(JSC::JSPromiseConstructor::getOwnPropertySlot):

• runtime/JSPromiseDeferred.cpp:
• runtime/JSPromisePrototype.cpp:

(JSC::JSPromisePrototype::getOwnPropertySlot):

• runtime/JSPromiseReaction.cpp:
• runtime/JSPropertyNameIterator.cpp:
• runtime/JSProxy.cpp:
• runtime/JSSet.cpp:
• runtime/JSSetIterator.cpp:
• runtime/JSString.cpp:
• runtime/JSTypedArrayConstructors.cpp:
• runtime/JSTypedArrayPrototypes.cpp:
• runtime/JSTypedArrays.cpp:
• runtime/JSVariableObject.cpp:
• runtime/JSWeakMap.cpp:
• runtime/JSWithScope.cpp:
• runtime/Lookup.cpp:

(JSC::HashTable::createTable):

• runtime/Lookup.h:

(JSC::HashTable::initializeIfNeeded):
(JSC::HashTable::entry):
(JSC::HashTable::begin):
(JSC::HashTable::end):
(JSC::getStaticPropertySlot):
(JSC::getStaticFunctionSlot):
(JSC::getStaticValueSlot):
(JSC::lookupPut):

• runtime/MapConstructor.cpp:
• runtime/MapData.cpp:
• runtime/MapIteratorConstructor.cpp:
• runtime/MapIteratorPrototype.cpp:
• runtime/MapPrototype.cpp:
• runtime/MathObject.cpp:
• runtime/NameConstructor.cpp:
• runtime/NameInstance.cpp:
• runtime/NamePrototype.cpp:

(JSC::NamePrototype::getOwnPropertySlot):

• runtime/NativeErrorConstructor.cpp:
• runtime/NumberConstructor.cpp:

(JSC::NumberConstructor::getOwnPropertySlot):

• runtime/NumberObject.cpp:
• runtime/NumberPrototype.cpp:

(JSC::NumberPrototype::getOwnPropertySlot):

• runtime/ObjectConstructor.cpp:

(JSC::ObjectConstructor::getOwnPropertySlot):

• runtime/ObjectPrototype.cpp:
• runtime/PropertyTable.cpp:
• runtime/RegExp.cpp:
• runtime/RegExpConstructor.cpp:

(JSC::RegExpConstructor::getOwnPropertySlot):

• runtime/RegExpMatchesArray.cpp:
• runtime/RegExpObject.cpp:

(JSC::RegExpObject::getOwnPropertySlot):

• runtime/RegExpPrototype.cpp:

(JSC::RegExpPrototype::getOwnPropertySlot):

• runtime/SetConstructor.cpp:
• runtime/SetIteratorConstructor.cpp:
• runtime/SetIteratorPrototype.cpp:
• runtime/SetPrototype.cpp:
• runtime/SparseArrayValueMap.cpp:
• runtime/StrictEvalActivation.cpp:
• runtime/StringConstructor.cpp:

(JSC::StringConstructor::getOwnPropertySlot):

• runtime/StringObject.cpp:
• runtime/StringPrototype.cpp:
• runtime/Structure.cpp:

(JSC::Structure::Structure):
(JSC::Structure::freezeTransition):
(JSC::ClassInfo::hasStaticSetterOrReadonlyProperties):

• runtime/StructureChain.cpp:
• runtime/StructureRareData.cpp:
• runtime/SymbolTable.cpp:
• runtime/VM.cpp:

(JSC::VM::VM):
(JSC::VM::~VM):

• runtime/VM.h:
• runtime/WeakMapConstructor.cpp:
• runtime/WeakMapData.cpp:
• runtime/WeakMapPrototype.cpp:
• testRegExp.cpp:

Source/WebCore:
Update for JSC::ClassInfo changes.

Remove the JSNoStaticTables mode for IDL code generation, which was used to
ensure that each VM had its own unique copy of certain static tables.
This was used for interfaces that could be used in workers, and now there's
no need to manually annotate these things anymore.

Also remove the DOMObjectHashTableMap class that was only used for this.

Reviewed by Geoffrey Garen.

• Modules/indexeddb/IDBAny.idl:
• Modules/indexeddb/IDBCursor.idl:
• Modules/indexeddb/IDBCursorWithValue.idl:
• Modules/indexeddb/IDBDatabase.idl:
• Modules/indexeddb/IDBFactory.idl:
• Modules/indexeddb/IDBIndex.idl:
• Modules/indexeddb/IDBKeyRange.idl:
• Modules/indexeddb/IDBObjectStore.idl:
• Modules/indexeddb/IDBOpenDBRequest.idl:
• Modules/indexeddb/IDBRequest.idl:
• Modules/indexeddb/IDBTransaction.idl:
• Modules/indexeddb/IDBVersionChangeEvent.idl:
• Modules/webdatabase/Database.idl:
• Modules/webdatabase/DatabaseSync.idl:
• Modules/webdatabase/SQLError.idl:
• Modules/webdatabase/SQLException.idl:
• Modules/webdatabase/SQLResultSet.idl:
• Modules/webdatabase/SQLResultSetRowList.idl:
• Modules/webdatabase/SQLTransaction.idl:
• Modules/webdatabase/SQLTransactionSync.idl:
• Modules/websockets/CloseEvent.idl:
• Modules/websockets/WebSocket.idl:
• WebCore.xcodeproj/project.pbxproj:
• bindings/js/DOMObjectHashTableMap.cpp: Removed.
• bindings/js/DOMObjectHashTableMap.h: Removed.
• bindings/js/JSDOMBinding.cpp:

(WebCore::getHashTableForGlobalData): Deleted.

• bindings/js/JSDOMBinding.h:

(WebCore::getStaticValueSlotEntryWithoutCaching):

• bindings/js/JSDOMGlobalObject.cpp:
• bindings/js/JSDOMWindowBase.cpp:
• bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::getOwnPropertySlot):
(WebCore::JSDOMWindow::put):

• bindings/js/JSDOMWindowShell.cpp:
• bindings/js/JSImageConstructor.cpp:
• bindings/js/JSLocationCustom.cpp:

(WebCore::JSLocation::putDelegate):

• bindings/js/JSStorageCustom.cpp:

(WebCore::JSStorage::deleteProperty):
(WebCore::JSStorage::putDelegate):

• bindings/js/JSWorkerGlobalScopeBase.cpp:
• bindings/js/WebCoreJSClientData.h:
• bindings/scripts/CodeGeneratorJS.pm:

(GenerateGetOwnPropertySlotBody):
(GenerateImplementation):
(GenerateConstructorHelperMethods):
(hashTableAccessor): Deleted.
(prototypeHashTableAccessor): Deleted.
(constructorHashTableAccessor): Deleted.

• bindings/scripts/IDLAttributes.txt:
• bridge/c/CRuntimeObject.cpp:
• bridge/c/c_instance.cpp:
• bridge/objc/ObjCRuntimeObject.mm:
• bridge/objc/objc_instance.mm:
• bridge/objc/objc_runtime.mm:
• bridge/runtime_array.cpp:
• bridge/runtime_method.cpp:
• bridge/runtime_object.cpp:
• crypto/CryptoKey.idl:
• css/CSSFontFaceLoadEvent.idl:
• dom/DOMCoreException.idl:
• dom/DOMStringList.idl:
• dom/ErrorEvent.idl:
• dom/Event.idl:
• dom/EventException.idl:
• dom/EventListener.idl:
• dom/MessageChannel.idl:
• dom/MessageEvent.idl:
• dom/MessagePort.idl:
• dom/ProgressEvent.idl:
• fileapi/Blob.idl:
• fileapi/File.idl:
• fileapi/FileError.idl:
• fileapi/FileException.idl:
• fileapi/FileList.idl:
• fileapi/FileReader.idl:
• fileapi/FileReaderSync.idl:
• html/DOMURL.idl:
• page/EventSource.idl:
• page/WorkerNavigator.idl:
• workers/DedicatedWorkerGlobalScope.idl:
• workers/SharedWorkerGlobalScope.idl:
• workers/WorkerGlobalScope.idl:
• workers/WorkerLocation.idl:
• xml/XMLHttpRequest.idl:
• xml/XMLHttpRequestException.idl:
• xml/XMLHttpRequestProgressEvent.idl:
• xml/XMLHttpRequestUpload.idl:

Source/WebKit/mac:
Reviewed by Geoffrey Garen.

• Plugins/Hosted/ProxyInstance.mm:
• Plugins/Hosted/ProxyRuntimeObject.mm:

Source/WebKit2:
Reviewed by Geoffrey Garen.

• WebProcess/Plugins/Netscape/JSNPMethod.cpp:
• WebProcess/Plugins/Netscape/JSNPObject.cpp:

3:20 PM Changeset in webkit [171823] by Lucas Forschler

• 5 edits in branches/safari-537.78-branch/Source

Versioning.

3:19 PM Changeset in webkit [171822] by Lucas Forschler

• 1 copy in tags/Safari-537.78.2

New Tag.

3:05 PM Changeset in webkit [171821] by matthew_hanson@apple.com

• 5 edits in tags/Safari-600.1.2.4/Source

Versioning.

2:53 PM Changeset in webkit [171820] by matthew_hanson@apple.com

• 1 copy in tags/Safari-600.1.2.4

New Tag.

2:46 PM Changeset in webkit [171819] by Brian Burg

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: ProbeSetDetailsSection should not create live location links for unresolved breakpoints
​https://bugs.webkit.org/show_bug.cgi?id=135367

Reviewed by Timothy Hatcher.

Regenerate the source code link whenever the breakpoint resolved status changes. If it is
resolved, then we can create a live location link that respects source maps.

• UserInterface/Views/ProbeSetDetailsSection.js:

(WebInspector.ProbeSetDetailsSection):
(WebInspector.ProbeSetDetailsSection.prototype._updateLinkElement): Added.
(WebInspector.ProbeSetDetailsSection.prototype._probeSetPositionTextOrLink): Deleted.

2:34 PM Changeset in webkit [171818] by rniwa@webkit.org

• 2 edits in trunk/Websites/perf.webkit.org

Merging platforms mixes baselines and targets into reported data
​https://bugs.webkit.org/show_bug.cgi?id=135260

Reviewed by Geoffrey Garen.

Make sure two test configurations we're merging are of the same type (e.g. baseline, target, current).
Otherwise, we'll erroneously mix up runs for baseline, target, and current (reported values).

• public/admin/platforms.php:

2:28 PM Changeset in webkit [171817] by psolanki@apple.com

• 1 edit
  2 moves in trunk/LayoutTests

Move iphone-simulator test results landed in r171094 to the correct directory.

• platform/ios-sim/fast/events/ontouchstart-active-selector-expected.txt: Renamed from LayoutTests/platform/iphone-simulator/fast/events/ontouchstart-active-selector-expected.txt.
• platform/ios-sim/fast/events/ontouchstart-active-selector.html: Renamed from LayoutTests/platform/iphone-simulator/fast/events/ontouchstart-active-selector.html.

2:03 PM Changeset in webkit [171816] by mitz@apple.com

• 5 edits
  2 deletes in trunk/Source/WebKit2

Get rid of the WKNSURLProtectionSpace wrapper
​https://bugs.webkit.org/show_bug.cgi?id=135425

Reviewed by Sam Weinig.

• Shared/Cocoa/APIObject.mm:

(API::Object::newObject): Don’t allocate WKNSURLProtectionSpace wrappers.

• Shared/Cocoa/WKNSURLProtectionSpace.h: Removed.
• Shared/Cocoa/WKNSURLProtectionSpace.mm: Removed.

• UIProcess/API/Cocoa/WKBrowsingContextController.mm:

(canAuthenticateAgainstProtectionSpaceInFrame): Get the NSURLProtectionSpace from the
WebCore::ProtectionSpace in the WebProtectionSpace.

• UIProcess/Cocoa/NavigationState.mm:

(WebKit::NavigationState::LoaderClient::canAuthenticateAgainstProtectionSpaceInFrame): Ditto.

• WebKit2.xcodeproj/project.pbxproj: Removed references to removed files.

1:55 PM Changeset in webkit [171815] by Lucas Forschler

• 5 edits in branches/safari-537.78-branch/Source

Fix Versioning.

1:45 PM Changeset in webkit [171814] by Lucas Forschler

• 7 edits
  1 copy in branches/safari-600.1-branch/Source/WebInspectorUI

Merged r171790. <rdar://problem/17848962>

1:44 PM Changeset in webkit [171813] by Lucas Forschler

• 2 edits in branches/safari-600.1-branch/Source/WebInspectorUI

Merged r171787. <rdar://problem/17852395>

1:40 PM Changeset in webkit [171812] by Lucas Forschler

• 3 edits in branches/safari-600.1-branch/Source/WebInspectorUI

Merged r171786. <rdar://problem/17852407>

1:36 PM Changeset in webkit [171811] by Lucas Forschler

• 3 edits
  2 copies in branches/safari-600.1-branch

Merged r171785. <rdar://problem/17851910>

1:33 PM Changeset in webkit [171810] by Lucas Forschler

• 6 edits in branches/safari-600.1-branch/Source/WebInspectorUI

Merged r171783. <rdar://problem/17848773>

1:31 PM Changeset in webkit [171809] by Lucas Forschler

• 2 edits in branches/safari-600.1-branch/Source/WebCore

Merged r171766. <rdar://problem/17824645>

1:29 PM Changeset in webkit [171808] by Lucas Forschler

• 11 edits in branches/safari-600.1-branch/Source

Merged r171749. <rdar://problem/15917314>

1:26 PM Changeset in webkit [171807] by Lucas Forschler

• 8 edits
  2 copies in branches/safari-600.1-branch

Merged r171718. <rdar://problem/17824793>

1:15 PM Changeset in webkit [171806] by matthew_hanson@apple.com

• 5 edits in branches/safari-600.1.4-branch/Source

Versioning.

1:13 PM Changeset in webkit [171805] by matthew_hanson@apple.com

• 1 copy in tags/Safari-600.1.4.1

New Tag.

12:56 PM Changeset in webkit [171804] by matthew_hanson@apple.com

• 2 edits in branches/safari-600.1.4-branch/Source/WebCore

Merge r171766. <rdar://problem/17824645>

12:50 PM Changeset in webkit [171803] by matthew_hanson@apple.com

• 2 edits in branches/safari-600.1.4-branch/Source/WebCore

Merge r171702. <rdar://problem/16828238>

12:40 PM Changeset in webkit [171802] by mitz@apple.com

• 2 edits in trunk/Source/WebCore

<rdar://problem/17199364> [Mac] Popup button arrows appear on the left, underlapping text, when the UI layout direction is right-to-left
​https://bugs.webkit.org/show_bug.cgi?id=135426

Reviewed by Dean Jackson.

No test, because the UI layout direction in the test harness is always left-to-right.

• rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::popupButton): Forced the user interface layout direction of the
NSPopUpButtonCell to left-to-right. Added a FIXME about how we could make this vary based on
the direction of the <select>, though that would require additional changes elsewhere.

11:56 AM Changeset in webkit [171801] by mitz@apple.com

• 25 edits in trunk/Source

Source/WebCore: Made Credential hold onto an NSURLCredential when needed.
Work towards fixing ​https://bugs.webkit.org/show_bug.cgi?id=135327

Reviewed by Alexey Proskuryakov.

No change in functionality.

• WebCore.exp.in: Updated.

• platform/network/Credential.h: Removed definition of CERTIFICATE_CREDENTIALS_SUPPORTED,

which is not used anymore.

• platform/network/CredentialBase.h:

(WebCore::CredentialBase::encodingRequiresPlatformData): Added a base implementation that
returns false.

• platform/network/cf/AuthenticationCF.cpp:

Changed to use the Credential constructor that takes an CFURLCredential, and the new
cfCredential member function. Made the createCF and core functions Windows-only and
therefore removed the CERTIFICATE_CREDENTIALS_SUPPORTED code from them.

• platform/network/cf/AuthenticationCF.h:

• platform/network/cf/CredentialStorageCFNet.cpp:

(WebCore::CredentialStorage::getFromPersistentStorage): Changed to construct a Credential
from a CFURLCredential.
(WebCore::CredentialStorage::saveToPersistentStorage): Changed to use the new cfCredential
member function.

• platform/network/cf/ResourceHandleCFNet.cpp:

(WebCore::ResourceHandle::didReceiveAuthenticationChallenge): Ditto to both.
(WebCore::ResourceHandle::receivedCredential): Ditto.

• platform/network/cocoa/CredentialCocoa.h:

Replaced the m_identity, m_certificates and m_type member variables with an m_nsCredential
one holding onto an NSURLCredential. Declared constructors from and getters for
NSURLCredential and CFURLCredentialRef.
(WebCore::Credential::encodingRequiresPlatformData): Override that checks the
NSURLCredential if necessary.

• platform/network/cocoa/CredentialCocoa.mm:

(WebCore::toNSURLCredentialPersistence): New helper function.
(WebCore::toCredentialPersistence): Ditto.
(WebCore::Credential::Credential): Defined constructors to create or take an
NSURLCredential.
(WebCore::Credential::cfCredential): Added.
(WebCore::Credential::nsCredential): Added. Returns nil for the empty credential.
(WebCore::Credential::isEmpty): Changed to check m_nsCredential.
(WebCore::Credential::platformCompare): Changed to compare m_nsCredential if needed.
(WebCore::Credential::encodingRequiresPlatformData): Returns true if the credential is not
a user and a password.

• platform/network/mac/AuthenticationMac.h: Removed mac and core functions for Credential.
• platform/network/mac/AuthenticationMac.mm:

(-[WebCoreAuthenticationClientAsChallengeSender useCredential:forAuthenticationChallenge:]):
Changed to use Credential constructor that takes an NSURLCredential.
(WebCore::AuthenticationChallenge::AuthenticationChallenge): Ditto. Also use the
nsCredential getter.

• platform/network/mac/CredentialStorageMac.mm:

(WebCore::CredentialStorage::getFromPersistentStorage): Use new Credential constructor.

• platform/network/mac/ResourceHandleMac.mm:

(WebCore::ResourceHandle::didReceiveAuthenticationChallenge): Ditto. Also use the
nsCredential getter.
(WebCore::ResourceHandle::receivedCredential): Ditto.

Source/WebKit/mac: Updated for changes to the WebCore::Credential API.
Work towards fixing ​https://bugs.webkit.org/show_bug.cgi?id=135327

Reviewed by Alexey Proskuryakov.

• Misc/WebDownload.mm:

(-[WebDownloadInternal download:didReceiveAuthenticationChallenge:]): Use new nsCredential
getter.

• Plugins/WebBaseNetscapePluginView.mm:

(WebKit::getAuthenticationInfo): Ditto.

Source/WebKit2: Updated for changes to the WebCore::Credential API.
Work towards fixing ​https://bugs.webkit.org/show_bug.cgi?id=135327

Reviewed by Alexey Proskuryakov.

• Shared/Downloads/mac/DownloadMac.mm:

(WebKit::Download::receivedCredential):Use new Credential::nsCredential getter.

• Shared/WebCoreArgumentCoders.cpp:

(IPC::ArgumentCoder<Credential>::encode): If encoding the credential requires encoding the
platform data, do that.
(IPC::ArgumentCoder<Credential>::decode): If platform data was encoded, decode it.

• Shared/WebCoreArgumentCoders.h:

• Shared/mac/WebCoreArgumentCodersMac.mm:

(IPC::ArgumentCoder<Credential>::encodePlatformData): Archive the NSURLCredential.
(IPC::ArgumentCoder<Credential>::decodePlatformData): Unarchive it.

• UIProcess/API/Cocoa/WKNSURLAuthenticationChallenge.mm:

(-[WKNSURLAuthenticationChallengeSender useCredential:forAuthenticationChallenge:]): Use
Credential constructor that takes an NSURLCredential.

• UIProcess/Cocoa/NavigationState.mm:

(WebKit::NavigationState::LoaderClient::didReceiveAuthenticationChallengeInFrame): Ditto.

9:49 AM Changeset in webkit [171800] by dfarler@apple.com

• 1 edit
  15 adds in trunk/Tools

iOS Simulator LayoutTestRelay
​https://bugs.webkit.org/show_bug.cgi?id=135269

Reviewed by David Kilzer.

• LayoutTestRelay/Configurations/Base.xcconfig: Added.
• LayoutTestRelay/Configurations/DebugRelease.xcconfig: Added.
• LayoutTestRelay/LayoutTestRelay.xcodeproj/project.pbxproj: Added.
• LayoutTestRelay/LayoutTestRelay/LTPipeRelay.h: Added.
• LayoutTestRelay/LayoutTestRelay/LTPipeRelay.m: Added.

(-[LTPipeRelay inPipePath]):
(-[LTPipeRelay outPipePath]):
(-[LTPipeRelay errorPipePath]):
(-[LTPipeRelay outputStream]):
(-[LTPipeRelay initWithPrefix:]):
(-[LTPipeRelay setup]):
(-[LTPipeRelay tearDown]):
(-[LTPipeRelay connect]):
(-[LTPipeRelay disconnect]):
(-[LTPipeRelay createFIFOs]):
(-[LTPipeRelay destroyFIFOs]):
(-[LTPipeRelay relayStream:]):
(-[LTPipeRelay stream:handleEvent:]):

• LayoutTestRelay/LayoutTestRelay/LTRelay.h: Added.
• LayoutTestRelay/LayoutTestRelay/LTRelayController.h: Added.
• LayoutTestRelay/LayoutTestRelay/LTRelayController.m: Added.

(-[LTRelayController uniqueAppPath]):
(-[LTRelayController uniqueAppURL]):
(-[LTRelayController uniqueAppIdentifier]):
(-[LTRelayController processName]):
(-[LTRelayController initWithDevice:productDir:appPath:identifierSuffix:dumpToolArguments:]):
(-[LTRelayController readFileHandle:]):
(-[LTRelayController receivedStandardOutputData:]):
(-[LTRelayController receivedStandardErrorData:]):
(-[LTRelayController disconnected]):
(-[LTRelayController connected]):
(-[LTRelayController crashWithMessage:]):
(-[LTRelayController launchSimulator]):
(-[LTRelayController bootDevice]):
(-[LTRelayController createUniqueApp]):
(-[LTRelayController killApp]):
(-[LTRelayController launchApp]):
(-[LTRelayController start]):

• LayoutTestRelay/LayoutTestRelay/main.m: Added.

(usage):
(getTestingSimDevice):
(getRequiredStringArgument):
(getRemainderArguments):
(main):

• LayoutTestRelay/Makefile: Added.
• Tools/Scripts/build-layouttestrelay: Added.

9:35 AM Changeset in webkit [171799] by svillar@igalia.com

• 3 edits in trunk/Source/WebCore

[GTK] Build depends on OpenGL ES
​https://bugs.webkit.org/show_bug.cgi?id=135289

Reviewed by Martin Robinson.

Guard the OpenGL ES code with USE(OPENGL_ES_2).

• platform/graphics/opengl/Extensions3DOpenGLES.cpp:
• platform/graphics/opengl/Extensions3DOpenGLES.h:

9:35 AM Changeset in webkit [171798] by Brent Fulgham

• 11 edits
  1 add in trunk

[Win] Modify version numbering scheme to support 5-tuple versions
​https://bugs.webkit.org/show_bug.cgi?id=135400
<rdar://problem/17849033>

Reviewed by David Kilzer.

Source/JavaScriptCore:

• JavaScriptCore.vcxproj/JavaScriptCorePostBuild.cmd: Use the

new version-stamp.pl script to version JavaScriptCore.dll.

Source/WebKit:

• WebKit.vcxproj/WebKit/WebKitPostBuild.cmd: Use the new

version-stamp.pl script to version JavaScriptCore.dll.

Source/WTF:

• WTF.vcxproj/WTFPostBuild.cmd: Use new version-stamp.pl script

to version WTF.dll.

• WTF.vcxproj/WTFPreBuild.cmd: Make sure we have created the

appropriate version resource during builds.

Tools:
Update test cases to recognize that we can only support Major
values from 0-65535, Minor values from 0-64, Tiny values from 0-999,
Micro values from 0-64, and Nano values from 0-999.

• Scripts/webkitperl/auto-version_unittest/autoVersionTests.pl: Update

test expectations for physical limits.

WebKitLibraries:
Revise the auto-version.pl script so that it generates a set of packed
version tuples that allow us to map 5-tuple versions into something
that will work with Windows' 3-tuple version structure.

• win/tools/scripts/auto-version.pl:

(packTwoValues): Added,
(splitVersion): Revised to return packed combination of minor-tiny and
micro-nano to be used as "MINOR" and "TINY" portion of version.
(splitBuildMajorVersion): Deleted.

• win/tools/scripts/version-stamp.pl: Added.

9:23 AM Changeset in webkit [171797] by stavila@adobe.com

• 4 edits in trunk/Source/WebCore

Member name collision in RenderView and SelectionSubtreeRoot
​https://bugs.webkit.org/show_bug.cgi?id=135233

Reviewed by Mihnea Ovidenie.

The selectionStart/End members in RenderView have been renamed to fix confusion caused by the fact that
RenderView inherits SelectionSubtreeRoot, which also has the same selectionStart/End members.

No new tests required, no new functionality.

• rendering/RenderBlock.cpp:

(WebCore::RenderBlock::isSelectionRoot):

• rendering/RenderView.cpp:

(WebCore::RenderView::RenderView):
(WebCore::RenderView::setSelection):
(WebCore::RenderView::getSelection):

• rendering/RenderView.h:

3:52 AM Changeset in webkit [171796] by Carlos Garcia Campos

• 2 edits in trunk/Source/WebKit2

[GTK] REGRESSION(r171742): Test /webkit2/WebKitWebView/disallow-modal-dialogs fails
​https://bugs.webkit.org/show_bug.cgi?id=135412

Reviewed by Philippe Normand.

The problem is that WebPageProxy::setUIClient() calls
setCanRunModal() with the value of m_uiClient->canRunModal() which
is always true for us. We override that manually by calling
setCanRunModal() depending on the WebKitSettings. In r171742,
webkitWebViewUpdateSettings(), the method that overrides
setCanRunModal(), was moved before attachUIClientToView(), so the
value set by WebPageProxy::setUIClient() is the last one and takes
precedence. We need to make sure webkitWebViewUpdateSettings() is
always called after attachUIClientToView().

• UIProcess/API/gtk/WebKitWebView.cpp:

(webkitWebViewConstructed): Move webkitWebViewUpdateSettings()
call after attachUIClientToView() and add a comment to not forget
about it again.

12:47 AM Changeset in webkit [171795] by zandobersek@gmail.com

• 3 edits in trunk/Source/WebCore

[TexMap] Move TextureMapperLayer::textureMapper() definition into the header
​https://bugs.webkit.org/show_bug.cgi?id=135384

Reviewed by Martin Robinson.

Move the definitions of TextureMapperLayer::textureMapper() and TextureMapperLayer::rootLayer()
into the TextureMapperLayer header. This makes both functions inline-able, removing unnecessary
calling overhead in GraphicsLayerTextureMapper::flushCompositingState() and
GraphicsLayerTextureMapper::updateBackingStoreIfNeeded().

TextureMapperLayer::rootLayer() now also returns a reference.

• platform/graphics/texmap/TextureMapperLayer.cpp:

(WebCore::TextureMapperLayer::~TextureMapperLayer):
(WebCore::TextureMapperLayer::rootLayer): Deleted.
(WebCore::TextureMapperLayer::textureMapper): Deleted.

• platform/graphics/texmap/TextureMapperLayer.h:

(WebCore::TextureMapperLayer::textureMapper):
(WebCore::TextureMapperLayer::rootLayer):

12:47 AM Changeset in webkit [171794] by Carlos Garcia Campos

• 2 edits in trunk/Tools

[GTK] GLib tests fail with recent GTK+ due to runtime warning about deprecated properties
​https://bugs.webkit.org/show_bug.cgi?id=135411

Reviewed by Sergio Villar Senin.

Recent versions of GTK+ now warn at runtime when a deprecated
property or signal is used. A diagnostic mode was added that is
enabled by default, but that can be disabled by setting
G_ENABLE_DIAGNOSTIC=0. Runtime warnings are considered test
failures by gtester, so we need to run the tests with the
diganostic mode disabled.

• TestWebKitAPI/gtk/WebKit2Gtk/TestMain.cpp:

(main):

12:45 AM Changeset in webkit [171793] by zandobersek@gmail.com

• 2 edits in trunk

[CMake] Bump the minimum required version
​https://bugs.webkit.org/show_bug.cgi?id=135382

Reviewed by Gyuyoung Kim.

• CMakeLists.txt: Bump the minimum required version to 2.8.11 after

we introduced usage of target_include_directories().

12:06 AM Changeset in webkit [171792] by Carlos Garcia Campos

• 11 edits
  3 deletes in trunk

[GTK] Remove WebKitCertificateInfo from WebKit2GTK+ API
​https://bugs.webkit.org/show_bug.cgi?id=134830

Reviewed by Gustavo Noronha Silva.

Source/WebKit2:
It was added to make the API more convenient but it has ended up
making it more complicated. WebKitWebView::load-failed-with-tls-errors
now receives a GTlsCertificate + GTlsCertificateFlags and
webkit_web_context_allow_tls_certificate_for_host() receives a GTlsCertificate
since the errors are not actually needed. This makes the API more
consistent with the existing method webkit_web_view_get_tls_info().

• PlatformGTK.cmake: Remove files from compilation.
• UIProcess/API/gtk/WebKitCertificateInfo.cpp: Removed.
• UIProcess/API/gtk/WebKitCertificateInfo.h: Removed.
• UIProcess/API/gtk/WebKitCertificateInfoPrivate.h: Removed.
• UIProcess/API/gtk/WebKitWebContext.cpp:

(webkit_web_context_allow_tls_certificate_for_host):

• UIProcess/API/gtk/WebKitWebContext.h:
• UIProcess/API/gtk/WebKitWebView.cpp:

(webkit_web_view_class_init):
(webkitWebViewLoadFailedWithTLSErrors):

• UIProcess/API/gtk/WebKitWebView.h:
• UIProcess/API/gtk/docs/webkit2gtk-docs.sgml:
• UIProcess/API/gtk/docs/webkit2gtk-sections.txt:
• UIProcess/API/gtk/webkit2.h:

Tools:
Update the SSL test for the API changes.

• TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:

(testLoadFailedWithTLSErrors):