Timeline



Aug 11, 2014:

8:20 PM Changeset in webkit [172429] by msaboff@apple.com
  • 12 edits in trunk/Source/JavaScriptCore

Eliminate {push,pop}CalleeSaves in favor of individual pushes & pops
​https://bugs.webkit.org/show_bug.cgi?id=127155

Reviewed by Geoffrey Garen.

Eliminated the offline assembler instructions {push,pop}CalleeSaves as well as the
ARM64 specific {push,pop}LRAndFP and replaced them with individual push and pop
instructions. Where the registers referenced by the added push and pop instructions
are not part of the offline assembler register aliases, used a newly added "emit"
offline assembler instruction which takes a string literal and outputs that
string as a native instruction.

  • llint/LowLevelInterpreter.asm:
  • offlineasm/arm.rb:
  • offlineasm/arm64.rb:
  • offlineasm/ast.rb:
  • offlineasm/cloop.rb:
  • offlineasm/instructions.rb:
  • offlineasm/mips.rb:
  • offlineasm/parser.rb:
  • offlineasm/sh4.rb:
  • offlineasm/transform.rb:
  • offlineasm/x86.rb:
8:01 PM Changeset in webkit [172428] by mrowe@apple.com
  • 2 edits in trunk/Source/WebCore

Fix the Mac build.

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
6:23 PM Changeset in webkit [172427] by bshafiei@apple.com
  • 5 edits in branches/safari-600.1.4-branch/Source

Versioning.

6:19 PM Changeset in webkit [172426] by bshafiei@apple.com
  • 1 copy in tags/Safari-600.1.4.10

New tag.

6:12 PM Changeset in webkit [172425] by Brent Fulgham
  • 9 edits in trunk

[Mac, iOS] Some media content never reaches full 'loaded' state
​https://bugs.webkit.org/show_bug.cgi?id=135814
<rdar://problem/17476923>

Reviewed by Jer Noble.

Source/WebCore:

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:

(WebCore::MediaPlayerPrivateAVFoundation::duration): Change to a wrapper that just calls
the durationDouble method and narrows to a float.
(WebCore::MediaPlayerPrivateAVFoundation::durationDouble): Revised version of duration
that works with doubles.
(WebCore::MediaPlayerPrivateAVFoundation::currentTime): Wrapper that calls the
currentTimeDouble method and narrows to a float.
(WebCore::MediaPlayerPrivateAVFoundation::seekWithTolerance): Use durationDouble for
comparison with passed 'time' argument (which is a double).
(WebCore::MediaPlayerPrivateAVFoundation::didEnd): Use 'currentTimeDouble' so we can
cache the double precision version of this value.
(WebCore::MediaPlayerPrivateAVFoundation::extraMemoryCost): Use 'durationDouble' since
the rest of the calculation is in terms of doubles.

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
  • platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:

(WebCore::MediaPlayerPrivateAVFoundationCF::platformDuration): Convert to 'double'. All
uses of this method are internal to the MediaPlayerPrivateAVFoundation* files.
(WebCore::MediaPlayerPrivateAVFoundationCF::currentTimeDouble): Switch from float implementation.
(WebCore::MediaPlayerPrivateAVFoundationCF::currentTime): Deleted. (Moved to parent class)

  • platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.h:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::platformDuration): Convert to 'double'. All
uses of this method are internal to the MediaPlayerPrivateAVFoundation* files.
(WebCore::MediaPlayerPrivateAVFoundationObjC::currentTimeDouble): Switch from floating implementation.
(WebCore::MediaPlayerPrivateAVFoundationObjC::currentTime): Deleted. (Moved to parent class)

LayoutTests:

  • platform/mac/media/video-seek-past-end-paused-expected.txt: Rebaseline

result for new rounding behavior.

6:04 PM Changeset in webkit [172424] by enrica@apple.com
  • 6 edits in trunk/Source

Improve look and feel of combined service menu..
​https://bugs.webkit.org/show_bug.cgi?id=135824
<rdar://problem/17936880>

Reviewed by Tim Horton.
Source/WebCore:

Adding some localizable strings.

  • English.lproj/Localizable.strings:

Source/WebKit2:


When showing the combined menu, list the phone numbers first,
grouped under a common header, followed by the entries relative
to the services.

  • Platform/mac/MenuUtilities.h:
  • Platform/mac/MenuUtilities.mm:

(WebKit::menuItemTitleForTelephoneNumberGroup):
(WebKit::menuItemForTelephoneNumber):

  • UIProcess/mac/WebContextMenuProxyMac.mm:

(WebKit::WebContextMenuProxyMac::setupServicesMenu):

6:00 PM Changeset in webkit [172423] by bshafiei@apple.com
  • 6 edits in branches/safari-600.1.4-branch/Source/WebCore

Merged r172422. <rdar://problem/17912361>

5:36 PM Changeset in webkit [172422] by jer.noble@apple.com
  • 6 edits in trunk/Source/WebCore

[iOS] <video> element requests are missing session cookies; sometimes persistant cookies.
​https://bugs.webkit.org/show_bug.cgi?id=135816

Reviewed by Alexey Proskuryakov.

On iOS, the AVFoundation framework will copy appropriate cookies for the requested URL across to the
mediaserverd process. For WebKit2, the WebProcess does not have access to session cookies for the
current browsing session. When creating an AVURLAsset, fetch the appropriate cookies for the requested
URL, and pass them into AVURLAsset in the options dictionary.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::mediaPlayerGetRawCookies): Call CookieJar's equivalent method.

  • html/HTMLMediaElement.h:
  • platform/graphics/MediaPlayer.cpp:

(WebCore::MediaPlayer::getRawCookies): Pass to HTMLMediaElement.

  • platform/graphics/MediaPlayer.h:

(WebCore::MediaPlayerClient::mediaPlayerGetRawCookies):

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::toNSHTTPCookie): Convert a WebCore Cookie -> NSHTTPCookie.
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVAssetForURL): Fetch cookies for the requested

URL, and if successful, add them to the AVURLAsset options dictionary.

5:15 PM WebInspectorCodingStyleGuide edited by Brian Burg
How to document promise fulfillment values (diff)
5:13 PM Changeset in webkit [172421] by roger_fong@apple.com
  • 4 edits in trunk/Source/WebCore

Adjustments to CueBox CSS Width calculations Part 2.
​https://bugs.webkit.org/show_bug.cgi?id=135820
<rdar://problem/17954473>.

Reviewed by Brent Fulgham.

Two adjustments made:
a) The default font size used was incorrect. It is not just 10px,
but should be based off a percentage of the video size.
b) The top/left CSS property needs to be adjusted appropriately if the cue
is center aligned and we change the cue's size such that the cue remains centered.

  • html/track/TextTrackCueGeneric.cpp:

(WebCore::TextTrackCueGenericBoxElement::applyCSSProperties):

  • html/track/VTTCue.cpp:

(WebCore::VTTCueBox::applyCSSProperties):

  • html/track/VTTCue.h: Remove unnecessary constant.
4:41 PM Changeset in webkit [172420] by Brian Burg
  • 5 edits
    2 copies
    4 adds in trunk/Source/WebInspectorUI

Web Inspector: show a replay dashboard when capturing or replaying
​https://bugs.webkit.org/show_bug.cgi?id=135170

Reviewed by Timothy Hatcher.

This patch adds a replay dashboard with record/play/pause buttons. It
is shown automatically when the user starts capturing an execution from
the replay menu in the Timelines sidebar panel.

  • UserInterface/Base/Main.js:

(WebInspector.loaded):
(WebInspector._captureDidStart):

  • UserInterface/Controllers/DashboardManager.js:

(WebInspector.DashboardManager):

  • UserInterface/Images/ReplayPauseButton.svg: Added.
  • UserInterface/Images/ReplayPlayButton.svg: Added.
  • UserInterface/Images/ReplayRecordingButton.svg: Added.
  • UserInterface/Main.html:
  • UserInterface/Models/ReplayDashboard.js: Copied from Source/WebInspectorUI/UserInterface/Controllers/DashboardManager.js.

(WebInspector.ReplayDashboard):

  • UserInterface/Views/DashboardView.js:

(WebInspector.DashboardView):

  • UserInterface/Views/ReplayDashboardView.css: Copied from Source/WebInspectorUI/UserInterface/Controllers/DashboardManager.js.

(.toolbar .dashboard.replay):
(.toolbar .dashboard.replay div.navigation-bar):
(.toolbar .dashboard.replay .item.button > .glyph):
(.toolbar.label-only .dashboard.replay .item.button > .glyph):

  • UserInterface/Views/ReplayDashboardView.js: Added.

(WebInspector.ReplayDashboardView):
(WebInspector.ReplayDashboardView.prototype._captureButtonItemClicked):
(WebInspector.ReplayDashboardView.prototype._replayButtonItemClicked):
(WebInspector.ReplayDashboardView.prototype._captureStarted):
(WebInspector.ReplayDashboardView.prototype._captureStopped):
(WebInspector.ReplayDashboardView.prototype._playbackStarted):
(WebInspector.ReplayDashboardView.prototype._playbackPaused):
(WebInspector.ReplayDashboardView.prototype._playbackFinished):

4:40 PM Changeset in webkit [172419] by mitz@apple.com
  • 2 edits in trunk/Tools

Added an update-webkit option to update the auxiliary libraries or not.
Part of ​https://bugs.webkit.org/show_bug.cgi?id=135815

Reviewed by Tim Horton.

  • Scripts/update-webkit: Added --[no-]auxiliary-libs option, which defaults to yes unless

an Internal directory exists alongside the WebKit root directory.

4:26 PM Changeset in webkit [172418] by Bem Jones-Bey
  • 2 edits in trunk/Tools

Remove hg changeset from w3c-import.log
​https://bugs.webkit.org/show_bug.cgi?id=135735

Reviewed by Ryosuke Niwa.

Since the csswg's test suite is now accessible via github and it is
possible to push changes by creating github pull requests, the hg
changeset makes less sense, as many people will just use a clone of
the git repo. There isn't an obvious thing to replace it with, so
might as well remove it for now instead of having it just be set to
UNKNOWN in imports.

This also adds a pointer to the github repo in the generated comments
in the w3c-import.log.

  • Scripts/webkitpy/w3c/test_importer.py:

(TestImporter.init): Remove changeset handling.
(TestImporter.do_import): Ditto.
(TestImporter.write_import_log): Ditto.
(TestImporter.load_changeset): Deleted.

4:03 PM Changeset in webkit [172417] by Beth Dakin
  • 4 edits
    12 adds in trunk

Fixed backgrounds don't paint in blurred inset areas
​https://bugs.webkit.org/show_bug.cgi?id=135712

Reviewed by Simon Fraser.

Source/WebCore:

Background geometry calculations for fixed background need to use the larger
visible rect.

The first version of this patch caused a regression because it universally
adjusted the value for top to account for the inset whether or not the
viewportRect location was adjusted for the same. This version fixes that — those
two changes go hand-in-hand.

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry):

LayoutTests:

  • platform/mac-wk1/TestExpectations:
  • platform/mac-wk1/fast: Added.
  • platform/mac-wk1/fast/backgrounds: Added.
  • platform/mac-wk1/fast/backgrounds/resources: Added.
  • platform/mac-wk1/fast/backgrounds/resources/green.png: Added.
  • platform/mac-wk1/fast/backgrounds/top-content-inset-fixed-attachment-expected.html: Added.
  • platform/mac-wk1/fast/backgrounds/top-content-inset-fixed-attachment.html: Added.
  • platform/mac-wk2/tiled-drawing/resources/green-blue.png: Added.
  • platform/mac-wk2/tiled-drawing/resources/green.png: Added.
  • platform/mac-wk2/tiled-drawing/top-content-inset-fixed-attachment-body-expected.html: Added.
  • platform/mac-wk2/tiled-drawing/top-content-inset-fixed-attachment-body.html: Added.
  • platform/mac-wk2/tiled-drawing/top-content-inset-fixed-attachment-expected.html: Added.
  • platform/mac-wk2/tiled-drawing/top-content-inset-fixed-attachment.html: Added.
3:30 PM Changeset in webkit [172416] by Lucas Forschler
  • 8 edits in tags/Safari-600.1.2.10/Source

Merged r172397. <rdar://problem/17978299>

3:28 PM Changeset in webkit [172415] by Lucas Forschler
  • 5 edits in tags/Safari-600.1.2.10/Source

Versioning.

3:25 PM Changeset in webkit [172414] by Lucas Forschler
  • 1 copy in tags/Safari-600.1.2.10

New Tag.

3:00 PM Changeset in webkit [172413] by mark.lam@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

Re-landing r172401 with fixed test.
<​https://webkit.org/b/135782>

Not reviewed.

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitGetByVal):
(JSC::BytecodeGenerator::pushIndexedForInScope):
(JSC::BytecodeGenerator::pushStructureForInScope):

  • bytecompiler/BytecodeGenerator.h:

(JSC::ForInContext::ForInContext):
(JSC::ForInContext::base):
(JSC::StructureForInContext::StructureForInContext):
(JSC::IndexedForInContext::IndexedForInContext):

  • bytecompiler/NodesCodegen.cpp:

(JSC::ForInNode::emitMultiLoopBytecode):

  • tests/stress/for-in-tests.js:
2:25 PM Changeset in webkit [172412] by Brian Burg
  • 3 edits in trunk/Source/WebInspectorUI

Web Inspector: DebuggerManager commands should return promises
​https://bugs.webkit.org/show_bug.cgi?id=135690

Reviewed by Timothy Hatcher.

Convert the existing debugger commands to return promises. This
requires separately waiting for protocol command's promise to be
fulfilled, as well as waiting for the appropriate DebuggerManager
event. If the protocol command promise is rejected, tear down the
single-fire event listener.

  • UserInterface/Controllers/DebuggerManager.js:

(WebInspector.DebuggerManager.prototype.pause):
(WebInspector.DebuggerManager.prototype.resume):
(WebInspector.DebuggerManager.prototype.stepOver):
(WebInspector.DebuggerManager.prototype.stepInto):
(WebInspector.DebuggerManager.prototype.stepOut):

  • UserInterface/Controllers/ReplayManager.js: Use the promise-based API.

(WebInspector.ReplayManager.prototype._suppressBreakpointsAndResumeIfNeeded):

2:16 PM Changeset in webkit [172411] by rniwa@webkit.org
  • 2 edits in trunk/Websites/perf.webkit.org

Report run id's in api/runs.php for the new dashboard UI
​https://bugs.webkit.org/show_bug.cgi?id=135813

Reviewed by Andreas Kling.

Include run_id in the generated JSON.

  • public/api/runs.php:

(fetch_runs_for_config): Don't sort results by time since that has been done in the front end for ages now.
(format_run):

1:48 PM Changeset in webkit [172410] by rniwa@webkit.org
  • 2 edits in trunk/Websites/perf.webkit.org

Merging platforms mixes baselines and targets into reported data
​https://bugs.webkit.org/show_bug.cgi?id=135260

Reviewed by Andreas Kling.

When merging two platforms, move test configurations of a different type (baseline, target)
as well as of different metric (Time, Runs).

Also avoid fetching the entire table of runs just to see if there are no remaining runs.
It's sufficient to detect one such test_runs object.

  • public/admin/platforms.php:

(merge_platforms):

1:42 PM Changeset in webkit [172409] by Antti Koivisto
  • 9 edits in trunk/Source/WebCore

Pass inherited style only when resolving tree style
​https://bugs.webkit.org/show_bug.cgi?id=135799

Reviewed by Andreas Kling.

No need to pass around the style parent element.

  • dom/ContainerNode.h:

(WebCore::ContainerNode::childShouldCreateRenderer): Deleted.

  • dom/Element.cpp:

(WebCore::Element::childShouldCreateRenderer):

  • dom/Element.h:
  • style/StyleResolveTree.cpp:

(WebCore::Style::RenderTreePosition::parent):
(WebCore::Style::nextSiblingRenderer):
(WebCore::Style::RenderTreePosition::RenderTreePosition):
(WebCore::Style::RenderTreePosition::computeNextSibling):
(WebCore::Style::shouldCreateRenderer):
(WebCore::Style::styleForElement):
(WebCore::Style::createRendererIfNeeded):
(WebCore::Style::textRendererIsNeeded):
(WebCore::Style::createTextRendererIfNeeded):
(WebCore::Style::attachTextRenderer):
(WebCore::Style::updateTextRendererAfterContentChange):
(WebCore::Style::attachChildren):
(WebCore::Style::attachDistributedChildren):
(WebCore::Style::attachShadowRoot):
(WebCore::Style::attachBeforeOrAfterPseudoElementIfNeeded):
(WebCore::Style::attachRenderTree):
(WebCore::Style::resolveLocal):
(WebCore::Style::resolveTextNode):
(WebCore::Style::resolveShadowTree):
(WebCore::Style::updateBeforeOrAfterPseudoElement):
(WebCore::Style::resolveTree):

  • svg/SVGDocument.cpp:

(WebCore::SVGDocument::childShouldCreateRenderer): Deleted.

Implement this in SVGSVGElement::rendererIsNeeded instead.

  • svg/SVGDocument.h:
  • svg/SVGSVGElement.cpp:

(WebCore::SVGSVGElement::rendererIsNeeded):

1:24 PM Changeset in webkit [172408] by Yusuke Suzuki
  • 7 edits
    4 adds in trunk

CSS JIT: support :scope
​https://bugs.webkit.org/show_bug.cgi?id=135733

Reviewed by Benjamin Poulain.

Implement :scope for CSS JIT. It introduces scope field to CheckingContext
and it makes CheckingContext more similar to SelectorChecker::SelectorCheckingContext.
And since :scope requires CheckingContext, QueryingRules can accept SelectorCheckerWithCheckingContext.

Source/WebCore:

Tests: fast/selectors/querySelector-scope-filtered-root.html

fast/selectors/scope-works-as-root.html

  • css/ElementRuleCollector.cpp:

(WebCore::ElementRuleCollector::ruleMatches):

  • cssjit/SelectorCompiler.cpp:

(WebCore::SelectorCompiler::shouldUseRenderStyleFromCheckingContext):
(WebCore::SelectorCompiler::addPseudoClassType):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateSelectorChecker):
(WebCore::SelectorCompiler::SelectorCodeGenerator::addFlagsToElementStyleFromContext):
(WebCore::SelectorCompiler::SelectorCodeGenerator::loadCheckingContext):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementMatching):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementIsActive):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementIsFirstChild):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementIsHovered):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementIsLastChild):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementIsOnlyChild):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementIsNthChild):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementHasPseudoElement):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateRequestedPseudoElementEqualsToSelectorPseudoElement):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementIsScopeRoot):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateMarkPseudoStyleForPseudoElement):

  • cssjit/SelectorCompiler.h:

(WebCore::SelectorCompiler::CheckingContext::CheckingContext):

  • dom/SelectorQuery.cpp:

(WebCore::SelectorDataList::executeCompiledSimpleSelectorChecker):
(WebCore::SelectorDataList::executeCompiledSelectorCheckerWithCheckingContext):
(WebCore::SelectorDataList::execute):

  • dom/SelectorQuery.h:

LayoutTests:

  • fast/selectors/querySelector-scope-filtered-root-expected.txt: Added.
  • fast/selectors/querySelector-scope-filtered-root.html: Added.

Searching root node of querySelectorAll is filtered to id node, but :scope root node should not be changed.

  • fast/selectors/scope-works-as-root-expected.html: Added.
  • fast/selectors/scope-works-as-root.html: Added.

:scope in stylesheet works as :root.

1:07 PM Changeset in webkit [172407] by Lucas Forschler
  • 3 edits in branches/safari-600.1-branch/Source/WebInspectorUI

Merged r172403. <rdar://problem/17979472>.

1:07 PM Changeset in webkit [172406] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit2

Add Private WKPreferences API for developer extras (show inspector)
​https://bugs.webkit.org/show_bug.cgi?id=135811

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-08-11
Reviewed by Timothy Hatcher.

  • UIProcess/API/Cocoa/WKPreferences.mm:

(-[WKPreferences _developerExtrasEnabled]):
(-[WKPreferences _setDeveloperExtrasEnabled:]):

  • UIProcess/API/Cocoa/WKPreferencesPrivate.h:
1:00 PM Changeset in webkit [172405] by commit-queue@webkit.org
  • 5 edits in trunk/Source/JavaScriptCore

Unreviewed, rolling out r172401.
​https://bugs.webkit.org/show_bug.cgi?id=135812

Failing stress/for-in-tests.js
​http://build.webkit.org/builders/Apple%20Mavericks%20Release%20WK1%20%28Tests%29/builds/7945/steps
/jscore-test/logs/stdio (Requested by mlam on #webkit).

Reverted changeset:

"for-in optimization should also make sure the base matches
the object being iterated"
​https://bugs.webkit.org/show_bug.cgi?id=135782
​http://trac.webkit.org/changeset/172401

12:50 PM Changeset in webkit [172404] by timothy@apple.com
  • 3 edits in trunk/Source/WebCore

Web Inspector: console.profile shouldn't stop auto-recorded profiles
​https://bugs.webkit.org/show_bug.cgi?id=135810

Reviewed by Joseph Pecoraro.

  • inspector/InspectorTimelineAgent.cpp:

(WebCore::InspectorTimelineAgent::start): Added. Call internalStart. Set m_enabledFromFrontend.
(WebCore::InspectorTimelineAgent::stop): Added. Calls internalStop. Clear m_enabledFromFrontend.
(WebCore::InspectorTimelineAgent::internalStart): Renamed from start.
(WebCore::InspectorTimelineAgent::internalStop): Renamed from stop.
(WebCore::InspectorTimelineAgent::startFromConsole): Use internalStart.
(WebCore::InspectorTimelineAgent::stopFromConsole): Use internalStop. Only stop if !m_enabledFromFrontend.
(WebCore::InspectorTimelineAgent::InspectorTimelineAgent): Initialize m_enabledFromFrontend.

  • inspector/InspectorTimelineAgent.h: Added m_enabledFromFrontend.
12:22 PM Changeset in webkit [172403] by timothy@apple.com
  • 3 edits in trunk/Source/WebInspectorUI

Web Inspector: Update folder icons
​https://bugs.webkit.org/show_bug.cgi?id=135808

Reviewed by Joseph Pecoraro.

  • UserInterface/Images/FolderGeneric.png: Updated.
  • UserInterface/Images/FolderGeneric@2x.png: Updated.
12:19 PM Changeset in webkit [172402] by Brian Burg
  • 8 edits in trunk/Source/JavaScriptCore

Web Inspector: use type builders to construct high fidelity type information payloads
​https://bugs.webkit.org/show_bug.cgi?id=135803

Reviewed by Timothy Hatcher.

Due to some typos in the protocol file, the code had worked with raw objects
rather than with type builders. Convert to using builders.

  • inspector/agents/InspectorRuntimeAgent.cpp:

(Inspector::InspectorRuntimeAgent::getRuntimeTypesForVariablesAtOffsets):

  • inspector/agents/InspectorRuntimeAgent.h:
  • inspector/protocol/Runtime.json: Fix 'item' for 'items'; true for 'true'.
  • runtime/HighFidelityTypeProfiler.cpp:

(JSC::HighFidelityTypeProfiler::getTypesForVariableAtOffsetForInspector):

  • runtime/HighFidelityTypeProfiler.h:
  • runtime/TypeSet.cpp:

(JSC::TypeSet::allStructureRepresentations):
(JSC::StructureShape::stringRepresentation):
(JSC::StructureShape::inspectorRepresentation):

  • runtime/TypeSet.h:
11:59 AM Changeset in webkit [172401] by mhahnenberg@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

for-in optimization should also make sure the base matches the object being iterated
​https://bugs.webkit.org/show_bug.cgi?id=135782

Reviewed by Geoffrey Garen.

If we access a different base object with the same index, we shouldn't try to randomly
load from that object's backing store.

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitGetByVal):
(JSC::BytecodeGenerator::pushIndexedForInScope):
(JSC::BytecodeGenerator::pushStructureForInScope):

  • bytecompiler/BytecodeGenerator.h:

(JSC::ForInContext::ForInContext):
(JSC::ForInContext::base):
(JSC::StructureForInContext::StructureForInContext):
(JSC::IndexedForInContext::IndexedForInContext):

  • bytecompiler/NodesCodegen.cpp:

(JSC::ForInNode::emitMultiLoopBytecode):

  • tests/stress/for-in-tests.js:
11:47 AM Changeset in webkit [172400] by Brent Fulgham
  • 2 edits in trunk/Source/JavaScriptCore

[Win] Unreviewed gardening.

  • JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters: Display files in

proper folder categories..

11:43 AM Changeset in webkit [172399] by timothy@apple.com
  • 26 edits in trunk/Source/WebInspectorUI

Web Inspector: DataGrid and its clients are a cluster-cuss of styles
​https://bugs.webkit.org/show_bug.cgi?id=135788

Clean up DataGrid and its subclasses and client styles.

Reviewed by Joseph Pecoraro.

  • Localizations/en.lproj/localizedStrings.js:
  • UserInterface/Views/ApplicationCacheFrameContentView.css:

(.content-view.application-cache-frame > .data-grid):

  • UserInterface/Views/CookieStorageContentView.css:

(.content-view.cookie-storage > .data-grid):

  • UserInterface/Views/DOMStorageContentView.css:

(.content-view.dom-storage > .data-grid):

  • UserInterface/Views/DOMTreeDataGrid.css:

(.dom-tree-data-grid .data-grid):
(.dom-tree-data-grid .name-column .icon):

  • UserInterface/Views/DOMTreeDataGrid.js:

(WebInspector.DOMTreeDataGrid):

  • UserInterface/Views/DataGrid.css:

(.data-grid):
(.data-grid table):
(.data-grid .data-container):
(.data-grid.inline):
(.data-grid th):
(.data-grid :-webkit-any(th, td):not(:last-child)):
(.data-grid th.sortable:active):
(.data-grid th:-webkit-any(.sort-ascending, .sort-descending)):
(.data-grid table.data):
(.data-grid td):
(.data-grid:focus tr.selected td:not(:last-child)):
(body.mac-platform.legacy .data-grid:focus tr.selected td:not(:last-child)):
(.data-grid :-webkit-any(th, td) > div):
(.data-grid th:-webkit-any(.sort-ascending, .sort-descending) > div:first-child):
(.data-grid th.sort-ascending > div:first-child::after):
(.data-grid th.sort-descending > div:first-child::after):
(.data-grid td .subtitle):
(.data-grid td .subtitle::before):
(.data-grid:focus tr.selected td .subtitle):
(.data-grid td.error):
(.data-grid tr.selected td.error):
(.data-grid td .icon):
(.data-grid td .go-to-arrow):
(.data-grid tr:-webkit-any(.selected, :hover) .go-to-arrow):

  • UserInterface/Views/DatabaseContentView.css:

(.storage-view):

  • UserInterface/Views/DatabaseTableContentView.css:

(.content-view.database-table > .data-grid):

  • UserInterface/Views/DetailsSection.css:

(.details-section > .content .data-grid):

  • UserInterface/Views/IndexedDatabaseObjectStoreContentView.css:

(.content-view.indexed-database-object-store > .data-grid):

  • UserInterface/Views/LayerTreeDataGridNode.js:

(WebInspector.LayerTreeDataGridNode.prototype._makeNameCell):
(WebInspector.LayerTreeDataGridNode.prototype._updateNameCellData):

  • UserInterface/Views/LayerTreeSidebarPanel.css:

(.layer-tree.panel .data-grid):
(.layer-tree.panel .name-column .icon):
(.layer-tree.panel tr.reflection .name-column .icon):
(.layer-tree.panel tr.pseudo-element .name-column .icon):
(.layer-tree.panel .name-column .reflection):
(.layer-tree.panel tr.selected .name-column .reflection):
(.layer-tree.panel .bottom-bar):
(body.mac-platform.legacy .layer-tree.panel .bottom-bar):
(.layer-tree.panel .bottom-bar > div):
(body.mac-platform.legacy .layer-tree.panel .bottom-bar > div):
(body.mac-platform.legacy .layer-tree-popover):

  • UserInterface/Views/LayerTreeSidebarPanel.js:

(WebInspector.LayerTreeSidebarPanel):
(WebInspector.LayerTreeSidebarPanel.prototype._buildLayerInfoSection):
(WebInspector.LayerTreeSidebarPanel.prototype._buildDataGridSection):
(WebInspector.LayerTreeSidebarPanel.prototype._buildBottomBar):
(WebInspector.LayerTreeSidebarPanel.prototype._updateMetrics):

  • UserInterface/Views/LegacyJavaScriptProfileView.css:

(.content-view.profile-view > .data-grid):

  • UserInterface/Views/LegacyProfileView.css:
  • UserInterface/Views/LogContentView.css:

(.console-message .bubble):

  • UserInterface/Views/NetworkTimelineView.css:

(.timeline-view.network > .data-grid):

  • UserInterface/Views/OverviewTimelineView.css:

(.timeline-view.overview > .timeline-ruler > .header):
(.timeline-view.overview > .data-grid):

  • UserInterface/Views/OverviewTimelineView.js:
  • UserInterface/Views/ProbeDetailsSidebarPanel.css:

(.details-section.probe-set .options > .probe-add):
(.popover .probe-popover):

  • UserInterface/Views/ProbeSetDataGrid.css:

(.details-section.probe-set .data-grid tr.past-value td):
(.details-section.probe-set .data-grid > td.unknown-value):
(.details-section.probe-set .data-grid tr.revealed.highlighted):
(.details-section.probe-set .data-grid tr.separator):
(.details-section.probe-set .data-grid > tr.data-updated):
(.details-section.probe-set .data-grid .selected .section *):
(.details-section.probe-set .data-grid .selected td.unknown-value):
(.details-section.probe-set .data-grid .section):

  • UserInterface/Views/QuickConsole.css:

(.quick-console):

  • UserInterface/Views/TimelineDataGrid.css:

(.data-grid.timeline th):
(.data-grid.timeline > .navigation-bar-container > .navigation-bar):

  • UserInterface/Views/TimelineRuler.css:

(.timeline-ruler > .header):
(.timeline-ruler > .header > .divider):

11:39 AM Changeset in webkit [172398] by mhahnenberg@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

JIT should use full 64-bit stores for jsBoolean and jsNull
​https://bugs.webkit.org/show_bug.cgi?id=135784

Reviewed by Michael Saboff.

This guarantees that we set the high bits of the register with the correct tag.

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_has_structure_property):
(JSC::JIT::emit_op_next_enumerator_pname):

11:23 AM Changeset in webkit [172397] by Brent Fulgham
  • 8 edits in trunk/Source

[Win] Adjust build script for Windows production build.
​https://bugs.webkit.org/show_bug.cgi?id=135806
<rdar://problem/17978299>

Reviewed by Timothy Hatcher.

../JavaScriptCore:

in WebInspectorUI build.

../WebCore:

  • WebCore.vcxproj/copyForwardingHeaders.cmd: Copy file needed

for WebInspectorUI build.

../WebInspectorUI:

  • WebInspectorUI.vcxproj/WebInspectorUI.make: Make sure target for

xcopy operation exists.

  • WebInspectorUI.vcxproj/WebInspectorUI.proj: Don't create directories

we don't need, make sure the target location exists before we build.

  • WebInspectorUI.vcxproj/build-webinspectorui.pl: Make sure that

production builds get the intermediary command files from the
right place.

11:10 AM Changeset in webkit [172396] by Brian Burg
  • 5 edits
    5 adds in trunk

Web Inspector: Add a helper to avoid leaking single-fire event listeners in Promise chains
​https://bugs.webkit.org/show_bug.cgi?id=135772

Reviewed by Timothy Hatcher.

Source/WebInspectorUI:

A common pattern when working with promise chains is to convert an event
handler into a promise by using a single-fire event listener with the
resolve continuation as the callback. This is fine if the event fires;
if it doesn't fire, then the event emitter permanently keeps a reference to the
this-object and the callback.

This patch adds EventListener, a proxy object for events that can be manipulated
from multiple promise callback functions. If a promise is rejected, the catch
block can disconnect any event listeners set up earlier in the promise chain.

This patch also reimplements EventListenerSet to use multiple EventListeners,
since they share the same logic to uniformly handle Inspector and DOM events.

Test: inspector/event-listener.html
Test: inspector/event-listener-set.html

  • UserInterface/Base/EventListener.js: Added.

(WebInspector.EventListener):
(WebInspector.EventListener.prototype.this._callback):
(WebInspector.EventListener.prototype.connect):
(WebInspector.EventListener.prototype.disconnect):

  • UserInterface/Base/EventListenerSet.js: Update license block.

(WebInspector.EventListenerSet.prototype.register):
(WebInspector.EventListenerSet.prototype.install):
(WebInspector.EventListenerSet.prototype.uninstall):

  • UserInterface/Main.html: Include EventListener.
  • UserInterface/Test.html: Include EventListener and EventListenerSet.

LayoutTests:

  • inspector/event-listener-expected.txt: Added.
  • inspector/event-listener-set-expected.txt: Added.
  • inspector/event-listener-set.html: Added.
  • inspector/event-listener.html: Added.
10:52 AM Changeset in webkit [172395] by enrica@apple.com
  • 2 edits in trunk/Source/WebKit2

[Services with UI] Action menu arrow hit testing is sometimes wrong.
​https://bugs.webkit.org/show_bug.cgi?id=135776
<rdar://problem/17837670>

Reviewed by Brady Eidson.

There was a problem in the algorithm that stitches together the selection rectangles
to be given to Data Detectors API.
This change adds a new function that stiches together all the rects contributing to the
first line, all the rects contributing to the last line and all the ones in the middle.
This way we can have a maximum of 3 non overlapping rectangles.

  • WebProcess/WebPage/mac/ServicesOverlayController.mm:

(WebKit::stitchRects):
(WebKit::compactRectsWithGapRects):

3:40 AM Changeset in webkit [172394] by commit-queue@webkit.org
  • 4 edits in trunk

Unreviewed, rolling out r172393.
​https://bugs.webkit.org/show_bug.cgi?id=135796

discussion needed about GnuTLS version bump on the bots
(Requested by philn on #webkit).

Reverted changeset:

​https://bugs.webkit.org/show_bug.cgi?id=133317
​http://trac.webkit.org/changeset/172393

3:23 AM Changeset in webkit [172393] by commit-queue@webkit.org
  • 4 edits in trunk

[GTK] Adds dependency on GnuTLS 3.0+ for the implementation of subtle crypto algorithms
​https://bugs.webkit.org/show_bug.cgi?id=133317

.:

GnuTLS is already an indirect dependency through libsoup -> glib-networking.

Patch by Eduardo Lima Mitev <​elima@igalia.com> on 2014-08-11
Reviewed by Philippe Normand.

No new tests since no new functionality has been added.

  • Source/cmake/OptionsGTK.cmake: Adds search for required GnuTLS package

Source/WebCore:

Patch by Eduardo Lima Mitev <​elima@igalia.com> on 2014-08-11
Reviewed by Philippe Normand.

No new tests since no new functionality has been added.

  • PlatformGTK.cmake: Adds GnuTLS libs and included dirs to WebCore targets
3:07 AM Changeset in webkit [172392] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/Source/WebKit2

Unreviewed, EFL build fix since r172385.

  • PlatformEfl.cmake:
3:04 AM Changeset in webkit [172391] by Philippe Normand
  • 2 edits in trunk/Source/WebCore

[GTK] Fix debug build after r172389.

Patch by Eduardo Lima Mitev <​elima@igalia.com> on 2014-08-11
Rubber-stamped by Philippe Normand.

  • crypto/gtk/CryptoKeyRSAGtk.cpp:

(WebCore::CryptoKeyRSA::exportData): Remove spurious ASSERT from
stub. It will be added back along with the real implementation of
the method.

2:48 AM Changeset in webkit [172390] by zandobersek@gmail.com
  • 2 edits in trunk/Source/WebCore

Unreviewed fix after r172348.

  • platform/graphics/cairo/BitmapImageCairo.cpp:

(WebCore::BitmapImage::BitmapImage): Initialize m_minimumSubsamplingLevel to 0.

1:59 AM Changeset in webkit [172389] by commit-queue@webkit.org
  • 6 edits
    11 adds in trunk

[GTK] Adds stubs for all subtle crypto algorithm implemntations
​https://bugs.webkit.org/show_bug.cgi?id=133316

Patch by Eduardo Lima Mitev <​elima@igalia.com> on 2014-08-11
Reviewed by Philippe Normand.

.:

  • Source/cmake/OptionsGTK.cmake: Add ENABLE_SUBTLE_CRYPTO option
  • Source/cmake/WebKitFeatures.cmake: Add ENABLE_SUBTLE_CRYPTO option
  • Source/cmakeconfig.h.cmake: Define ENABLE_SUBTLE_CRYPTO

Source/WebCore:

No new tests since no new functionality has been added.

  • CMakeLists.txt: Add subtle crypto 'algorithms' and 'parameters' dirs to WebCore incuded dirs
  • PlatformGTK.cmake: Add subtle crypto sources to WebCore target
  • crypto/gtk/CryptoAlgorithmAES_CBCGtk.cpp: Added.

(WebCore::CryptoAlgorithmAES_CBC::platformEncrypt):
(WebCore::CryptoAlgorithmAES_CBC::platformDecrypt):

  • crypto/gtk/CryptoAlgorithmAES_KWGtk.cpp: Added.

(WebCore::CryptoAlgorithmAES_KW::platformEncrypt):
(WebCore::CryptoAlgorithmAES_KW::platformDecrypt):

  • crypto/gtk/CryptoAlgorithmHMACGtk.cpp: Added.

(WebCore::CryptoAlgorithmHMAC::platformSign):
(WebCore::CryptoAlgorithmHMAC::platformVerify):

  • crypto/gtk/CryptoAlgorithmRSAES_PKCS1_v1_5Gtk.cpp: Added.

(WebCore::CryptoAlgorithmRSAES_PKCS1_v1_5::platformEncrypt):
(WebCore::CryptoAlgorithmRSAES_PKCS1_v1_5::platformDecrypt):

  • crypto/gtk/CryptoAlgorithmRSASSA_PKCS1_v1_5Gtk.cpp: Added.

(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::platformSign):
(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::platformVerify):

  • crypto/gtk/CryptoAlgorithmRSA_OAEPGtk.cpp: Added.

(WebCore::CryptoAlgorithmRSA_OAEP::platformEncrypt):
(WebCore::CryptoAlgorithmRSA_OAEP::platformDecrypt):

  • crypto/gtk/CryptoAlgorithmRegistryGtk.cpp: Added.

(WebCore::CryptoAlgorithmRegistry::platformRegisterAlgorithms):

  • crypto/gtk/CryptoDigestGtk.cpp: Added.

(WebCore::CryptoDigest::CryptoDigest):
(WebCore::CryptoDigest::~CryptoDigest):
(WebCore::CryptoDigest::create):
(WebCore::CryptoDigest::addBytes):
(WebCore::CryptoDigest::computeHash):

  • crypto/gtk/CryptoKeyRSAGtk.cpp: Added.

(WebCore::CryptoKeyRSA::CryptoKeyRSA):
(WebCore::CryptoKeyRSA::create):
(WebCore::CryptoKeyRSA::~CryptoKeyRSA):
(WebCore::CryptoKeyRSA::restrictToHash):
(WebCore::CryptoKeyRSA::isRestrictedToHash):
(WebCore::CryptoKeyRSA::keySizeInBits):
(WebCore::CryptoKeyRSA::buildAlgorithmDescription):
(WebCore::CryptoKeyRSA::exportData):
(WebCore::CryptoKeyRSA::generatePair):

  • crypto/gtk/SerializedCryptoKeyWrapGtk.cpp: Added.

(WebCore::getDefaultWebCryptoMasterKey):
(WebCore::wrapSerializedCryptoKey):
(WebCore::unwrapSerializedCryptoKey):

  • crypto/keys/CryptoKeyRSA.h:
1:49 AM Changeset in webkit [172388] by Carlos Garcia Campos
  • 1 copy in releases/WebKitGTK/webkit-2.5.2

WebKitGTK+ 2.5.2

1:05 AM Changeset in webkit [172387] by Carlos Garcia Campos
  • 4 edits in trunk

Unreviewed. Update OptionsGTK.cmake and NEWS for 2.5.2 release.

.:

  • Source/cmake/OptionsGTK.cmake: Bump version numbers.

Source/WebKit2:

  • gtk/NEWS: Add release notes for 2.5.2.
12:29 AM Changeset in webkit [172386] by Carlos Garcia Campos
  • 2 edits in trunk/Tools

Unreviewed. Fix GTK+ make distcheck.

  • gtk/manifest.txt: Remove Source/WebCore/Resources/inputSpeech.png.

Aug 10, 2014:

11:34 PM Changeset in webkit [172385] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit2

[GTK] No IPC messages are sent when building WebKitGTK+ with VERSION_SCRIPT
​https://bugs.webkit.org/show_bug.cgi?id=135760

Reviewed by Philippe Normand.

The problem is that the threading initialization is failing
because there are two copies of WTF, one in libjavascriptcoregtk
and the other in libwebkit2gtk. When WebKit2 is initialized in the
UI process, JSC::initializeThreading() is called first and then
WTF::initializeMainThread(). The former is calling
ThreadIdentifierData::initializeOnce() initializing the
ThreadIdentifierData::m_key symbol in libjavascriptcoregtk, while
the latter is using the ThreadIdentifierData API from libwebkit2gtk
that hasn't been initialized.

  • CMakeLists.txt: Do not add WTF to the list of WebKit2 libraries,

WebKit2 already depends on JavaScriptCore that already links to WTF.

9:22 PM Changeset in webkit [172384] by commit-queue@webkit.org
  • 2 edits
    1 delete in trunk/Source/WebCore

Remove inputSpeech.png
​https://bugs.webkit.org/show_bug.cgi?id=135771

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2014-08-10
Reviewed by Andreas Kling.

  • Resources/inputSpeech.png: Removed.
  • WebCore.xcodeproj/project.pbxproj:
6:26 PM Changeset in webkit [172383] by timothy_horton@apple.com
  • 9 edits in trunk/Source

Yelp phone number highlights often disappear
​https://bugs.webkit.org/show_bug.cgi?id=135789
<rdar://problem/17971057>

Reviewed by Brady Eidson.

Since selectedTelephoneNumberRangesChanged doesn't provide an associated
Frame, an incoming selectedTelephoneNumberRangesChanged from a subframe
would overwrite ServicesOverlayController's cached (and potentially active)
telephone number highlights.

This happens a lot on Yelp, because they have many subframes which are
doing layout on a regular basis.

  • WebProcess/WebCoreSupport/WebEditorClient.cpp:

(WebKit::WebEditorClient::selectedTelephoneNumberRangesChanged):

  • WebProcess/WebCoreSupport/WebEditorClient.h:

Adjust to the new (lack of) arguments.

  • WebProcess/WebPage/ServicesOverlayController.h:
  • WebProcess/WebPage/mac/ServicesOverlayController.mm:

(WebKit::ServicesOverlayController::selectedTelephoneNumberRangesChanged):
Adjust logging; we can revisit it later.

(WebKit::ServicesOverlayController::buildPhoneNumberHighlights):
When building phone number highlights, walk the Frame tree and retrieve
them from all of the Editors.

(WebKit::ServicesOverlayController::didRebuildPotentialHighlights):
(WebKit::ServicesOverlayController::telephoneNumberRangesForFocusedFrame):
(WebKit::ServicesOverlayController::determineActiveHighlight):
(WebKit::ServicesOverlayController::handleClick):
Retrieve the detected telephone number ranges from the focused frame
when combining telephone numbers with selection services.
This ensures that we don't show combined phone number highlights from other frames.

  • editing/Editor.cpp:

(WebCore::Editor::scanSelectionForTelephoneNumbers):
(WebCore::Editor::clearDataDetectedTelephoneNumbers): Deleted.

  • editing/Editor.h:

(WebCore::Editor::detectedTelephoneNumberRanges):

  • page/EditorClient.h:

(WebCore::EditorClient::selectedTelephoneNumberRangesChanged):
Cache and expose detected telephone number ranges on Editor.
Change selectedTelephoneNumberRangesChanged to take no arguments; it's
just a notification now.

6:23 PM Changeset in webkit [172382] by timothy_horton@apple.com
  • 3 edits in trunk/Source/WebKit2

Refactor ServiceOverlayController in preparation for fading between highlights
​https://bugs.webkit.org/show_bug.cgi?id=135787
<rdar://problem/17935736>

Reviewed by Brady Eidson.

Rework ServicesOverlayController so that we always keep a set of generic
"potential highlights", which are refcounted Highlight objects and
wrap a DDHighlightRef, as well as a type (Selection or TelephoneNumber),
Range (only used in the case of TelephoneNumber), and potentially more
things in the future (like, say, fade state!).

We eagerly update the list of potential highlights when the selection or set
of detected telephone numbers changes, and use this information to install
or uninstall the page overlay as needed.

When we need to recompute the "active" highlight from this set (for example,
we need to handle a mouse event or paint the highlight), we look through
the set of potential highlights and decide. This moves the "active" highlight
decision logic into one small and confined place.

  • WebProcess/WebPage/ServicesOverlayController.h:

(WebKit::ServicesOverlayController::Highlight):
Add the new aforementioned refcounted Highlight class.
Rename m_lastHoveredHighlightChangeTime to m_lastActiveHighlightChangeTime.
Make m_webPage a reference.
The rest is just added/removed/adjusted functions for the refactoring.

(WebKit::TelephoneNumberData::TelephoneNumberData): Deleted.

  • WebProcess/WebPage/mac/ServicesOverlayController.mm:

(WebKit::ServicesOverlayController::Highlight::createForSelection):
(WebKit::ServicesOverlayController::Highlight::createForTelephoneNumber):
Create Highlights for the two different highlight types.

(WebKit::ServicesOverlayController::ServicesOverlayController):
(WebKit::ServicesOverlayController::willMoveToWebPage):
Our WebPage pointer is always valid because it owns us; don't clear it.
We need to keep it around so that we can uninstall the overlay and
install it again later, anyway.

(WebKit::ServicesOverlayController::selectionRectsDidChange):
(WebKit::ServicesOverlayController::selectedTelephoneNumberRangesChanged):
When selection rects or detected telephone numbers change, rebuild potential highlights.
This will have the side-effect of installing the overlay if needed.

(WebKit::ServicesOverlayController::mouseIsOverHighlight):
Make this function take a Highlight instead of a DDHighlightRef.

(WebKit::ServicesOverlayController::remainingTimeUntilHighlightShouldBeShown):
Make this function take a Highlight instead of a DDHighlightRef.

(WebKit::ServicesOverlayController::drawHighlight):
Make this function take a Highlight instead of a DDHighlightRef.
There's no reason to do the translation separately from the layer blit,
also allowing us to avoid the StateSaver.

(WebKit::ServicesOverlayController::drawRect):
drawRect now always paints the active highlight, instead of duplicating
logic about which highlight should be active.
Also, it will update the active highlight before painting.
We no longer need to re-determine whether the active highlight's phone
number range is still a valid phone number range, because we rebuild
the potential highlights whenever the set of phone number ranges changes.

(WebKit::ServicesOverlayController::clearActiveHighlight):
Mostly an adoption of new names.

(WebKit::ServicesOverlayController::removeAllPotentialHighlightsOfType):
Run through the list of potential highlights and remove any of the given type.
The two highlight building functions use this helper to clear the old ones before building.

(WebKit::ServicesOverlayController::buildPhoneNumberHighlights):
(WebKit::ServicesOverlayController::buildSelectionHighlight):
Rebuild the list of potential highlights, replacing all highlights of
the given type with new ones.

(WebKit::ServicesOverlayController::hasRelevantSelectionServices):
Factor out the code that decides whether our current selection is
viable for servicing based on whether we have plain-text and/or rich-text services.

(WebKit::ServicesOverlayController::didRebuildPotentialHighlights):
When rebuilding potential highlights, if we have no potential highlights at all,
uninstall the page overlay; we don't need mouse tracking and don't need to
paint anything. This improves memory use and compositing performance significantly,
where previously we were leaving the overlay up forever after creating it.

If we have either detected telephone numbers or relevant selection services,
create and install the overlay if it doesn't already exist.

(WebKit::ServicesOverlayController::createOverlayIfNeeded):
This just moved from elsehwere, except that it now uses FadeMode::DoNotFade.
It doesn't make sense to fade on install/uninstall (which happens even before hover)
but not on changing the active highlight; fading will be re-addressed in the next patch.

(WebKit::ServicesOverlayController::highlightsAreEquivalent):
Determine whether two highlights are equivalent. While we may have
created a new Highlight at rebuild time, if two telephone number
highlights have equivalent ranges, there's no need to 'transition' to the new one.

(WebKit::ServicesOverlayController::determineActiveHighlight):
Run through the list of services, and try to find one that is hovered.
We prefer telephone number highlights to selection highlights, and
we will never make a selection highlight active if it is both
not serviceable and there are no telephone numbers to show in the combined menu.
This is the centralized location for determination of which highlight
should be considered active. If the active highlight changed, update
the time since last change and cancel the mouse-down tracking.

(WebKit::ServicesOverlayController::mouseEvent):
Adjust some comments to be more explanatory.
A bunch of code moved out of here and into determineActiveHighlight.

(WebKit::ServicesOverlayController::handleClick):
Adjust to take a reference and use Highlight instead of DDHighlightRef.

4:35 PM WebInspectorCodingStyleGuide edited by Brian Burg
formatting (diff)
4:32 PM WebInspectorCodingStyleGuide edited by Brian Burg
i promise to document promises (diff)
3:54 PM WebInspectorTests edited by Brian Burg
bugfixes (diff)
3:50 PM WebInspectorTests edited by Brian Burg
add notes about debugging tests; add notes about model tests (diff)
1:12 PM Changeset in webkit [172381] by oliver@apple.com
  • 5 edits in trunk

Destructuring assignment in a var declaration list incorrectly consumes subsequent variable initialisers
​https://bugs.webkit.org/show_bug.cgi?id=135773

Reviewed by Michael Saboff.

Source/JavaScriptCore:

We should be using parseAssignment expression in order to get the correct
precedence.

  • parser/Parser.cpp:

(JSC::Parser<LexerType>::parseVarDeclarationList):

LayoutTests:

Add new tests.

  • js/destructuring-assignment-expected.txt:
  • js/script-tests/destructuring-assignment.js:
1:07 PM Changeset in webkit [172380] by commit-queue@webkit.org
  • 5 edits in trunk

JSC Lexer is allowing octals 08 and 09 in strict mode functions
​https://bugs.webkit.org/show_bug.cgi?id=135704

Patch by Diego Pino Garcia <Diego Pino Garcia> on 2014-08-10
Reviewed by Oliver Hunt.

Return syntax error ("Decimal integer literals with a leading zero are
forbidden in strict mode") if a number starts with 0 and is followed
by a digit.

  • parser/Lexer.cpp:

(JSC::Lexer<T>::lex):

3:25 AM Changeset in webkit [172379] by timothy@apple.com
  • 12 edits
    3 deletes in trunk/Source

Web Inspector: new glyphs are visible on OS X 10.9 builds
​https://bugs.webkit.org/show_bug.cgi?id=135743

Reviewed by Joseph Pecoraro.

Source/WebInspectorUI:

  • UserInterface/Images/Legacy/UserInputPrompt.svg: Removed.
  • UserInterface/Images/Legacy/UserInputPromptPrevious.svg: Removed.
  • UserInterface/Images/Legacy/UserInputResult.svg: Removed.

Removed images that were not used.

  • UserInterface/Views/DashboardContainerView.css:

(body.mac-platform.legacy .dashboard-container .advance-arrow):

  • UserInterface/Views/DebuggerDashboardView.js:

(WebInspector.DebuggerDashboardView):

  • UserInterface/Views/FolderIcon.css:

(body.mac-platform.legacy .folder-icon .icon):

  • UserInterface/Views/HierarchicalPathComponent.css:

(body.mac-platform.legacy .hierarchical-path-component > .selector-arrows):

  • UserInterface/Views/LogContentView.js:

(WebInspector.LogContentView):
Use legacy images.

  • UserInterface/Views/NavigationSidebarPanel.css:

(.navigation-sidebar-panel-content-tree-outline:focus .item.selected .subtitle):
Fix color for selected subtitle.

  • UserInterface/Views/TimelineSidebarPanel.js:

(WebInspector.TimelineSidebarPanel):
Use legacy images.

Source/WebKit/mac:

  • WebCoreSupport/WebInspectorClient.mm:

(-[WebInspectorWindowController window]): Use 10100 instead of 1090 for the version.

Source/WebKit2:

  • UIProcess/mac/WebInspectorProxyMac.mm:

(WebKit::WebInspectorProxy::createInspectorWindow): Use 10100 instead of 1090 for the version.

1:45 AM Changeset in webkit [172378] by benjamin@webkit.org
  • 2 edits in trunk/Source/WTF

Update HashTable's operator= after r172167 per review comments

  • wtf/HashTable.h:

Update the type as suggested by Darin.

12:30 AM Changeset in webkit [172377] by Carlos Garcia Campos
  • 4 edits
    1 move in trunk

[GTK] REGRESSION(r166239): The ld version script is not being used
​https://bugs.webkit.org/show_bug.cgi?id=135694

Reviewed by Martin Robinson.

.:

Move the symbols filter file from Tools/gtk to Source/cmake and rename
it as gtksymbols.filter. Also updated it, since some of the symbols
exported were renamed.

  • Source/cmake/OptionsGTK.cmake:
  • Source/cmake/gtksymbols.filter: Renamed from Tools/gtk/symbols.filter.

Source/WebKit2:

  • CMakeLists.txt: Add VERSION_SCRIPT to WebKit2 link flags if present.
12:09 AM Changeset in webkit [172376] by Carlos Garcia Campos
  • 2 edits in trunk

[GTK] Child processes should be installed in a versioned directory
​https://bugs.webkit.org/show_bug.cgi?id=135754

Reviewed by Gustavo Noronha Silva.

Define LIBEXEC_INSTALL_DIR as
${CMAKE_INSTALL_FULL_LIBEXECDIR}/webkitgtk-${WEBKITGTK_API_VERSION}
so that the child processes are installed in $libexec/webkitgtk-4.0.
This makes it possible to install 2.6 in parallel to older versions.

  • Source/cmake/OptionsGTK.cmake:
Note: See TracTimeline for information about the timeline view.