Timeline

Aug 13, 2014:

10:09 PM Changeset in webkit [172577] by dbates@webkit.org

• 2 edits in trunk/Source/bmalloc

Attempt to fix the build following <​http://trac.webkit.org/changeset/172576>
(​https://bugs.webkit.org/show_bug.cgi?id=135895)

Substitute PerThreadStorage<T>::initSharedKeyIfNeeded() for initSharedKeyIfNeeded() in
implementation of PerThread<T>::getFastCase().

• bmalloc/PerThread.h:

(bmalloc::PerThread<T>::getFastCase):

10:00 PM Changeset in webkit [172576] by dbates@webkit.org

• 3 edits in trunk/Source/bmalloc

Make bmalloc::PerThread work without C++ thread local storage
​https://bugs.webkit.org/show_bug.cgi?id=135895

Reviewed by Geoffrey Garen.

Implement support for building bmalloc without C++ thread local storage.

• bmalloc/BPlatform.h: Remove macro define BPLATFORM_IOS_SIMULATOR. Added macro function

BCOMPILER_SUPPORTS() and macro define BCOMPILER_SUPPORTS_CXX_THREAD_LOCAL that can be used
to determine whether the compiler supports C++ thread local storage.

• bmalloc/PerThread.h:

(bmalloc::PerThreadStorage::get): Modified to call pthread_getspecific() when building
without C++ thread local storage.
(bmalloc::PerThreadStorage::initSharedKeyIfNeeded): Added.
(bmalloc::PerThreadStorage::init): Moved logic to initialize shared Pthread key from here to
PerThreadStorage::initSharedKeyIfNeeded().
(bmalloc::PerThread<T>::getFastCase): Modified to call PerThreadStorage::initSharedKeyIfNeeded()
before querying PerThreadStorage::get() when building without C++ thread local storage so as to
ensure that the shared key has been initialized.
(_pthread_setspecific_direct): Deleted.
(_pthread_getspecific_direct): Deleted.

9:25 PM Changeset in webkit [172575] by Lucas Forschler

• 2 edits in branches/safari-600.1-branch/Source/WebKit2

Merged r172546. <rdar://problem/17998929>

9:23 PM Changeset in webkit [172574] by Lucas Forschler

• 2 edits in branches/safari-600.1-branch/Source/WebKit2

Merged r172539. <rdar://problem/17998706>

9:21 PM Changeset in webkit [172573] by Lucas Forschler

• 2 edits in branches/safari-600.1-branch/Source/WebCore

Merged r172538. <rdar://problem/17665229>

9:18 PM Changeset in webkit [172572] by Lucas Forschler

• 3 edits
  2 copies in branches/safari-600.1-branch

Merged r172534. <rdar://problem/17942035>

9:16 PM Changeset in webkit [172571] by Lucas Forschler

• 2 edits in branches/safari-600.1-branch/Source/WebInspectorUI

Merged r172533. <rdar://problem/18009039>

9:15 PM Changeset in webkit [172570] by Lucas Forschler

• 2 edits in branches/safari-600.1-branch/Source/WebInspectorUI

Merged r172531. <rdar://problem/18008775>

9:13 PM Changeset in webkit [172569] by Lucas Forschler

• 2 edits in branches/safari-600.1-branch/Source/WebInspectorUI

Merged r172530. <rdar://problem/18008584>

9:11 PM Changeset in webkit [172568] by Lucas Forschler

• 3 edits in branches/safari-600.1-branch/Source/WebKit2

Merged r172528. <rdar://problem/17982341>

9:10 PM Changeset in webkit [172567] by Lucas Forschler

• 3 edits in branches/safari-600.1-branch/Source/WebInspectorUI

Merged r172527. <rdar://problem/17999511>

9:07 PM Changeset in webkit [172566] by Lucas Forschler

• 9 edits in branches/safari-600.1-branch/Source

Merged r172526. <rdar://problem/18005074>

9:05 PM Changeset in webkit [172565] by Lucas Forschler

• 2 edits in branches/safari-600.1-branch/Source/WebInspectorUI

Merged r172525. <rdar://problem/17997324>

9:03 PM Changeset in webkit [172564] by Lucas Forschler

• 2 edits in branches/safari-600.1-branch/Source/WebInspectorUI

Merged r172515. <rdar://problem/17997717>

9:01 PM Changeset in webkit [172563] by Lucas Forschler

• 2 edits in branches/safari-600.1-branch/Source/WebKit2

Merged r172512. <rdar://problem/17982275>

8:59 PM Changeset in webkit [172562] by Lucas Forschler

• 3 edits in branches/safari-600.1-branch/Source/WebCore

Merged r172507. <rdar://problem/17979262>

8:57 PM Changeset in webkit [172561] by Lucas Forschler

• 5 edits in branches/safari-600.1-branch/Source

Merged r172501. <rdar://problem/17992795>

8:55 PM Changeset in webkit [172560] by Lucas Forschler

• 12 edits in branches/safari-600.1-branch/Source/WebKit2

Merged r172500. <rdar://problem/17986556>

8:53 PM Changeset in webkit [172559] by Lucas Forschler

• 2 edits in branches/safari-600.1-branch/Source/WebKit2

Merged r172498. <rdar://problem/17996339>

8:49 PM Changeset in webkit [172558] by Lucas Forschler

• 2 edits in branches/safari-600.1-branch/Source/WebKit2

Merged r172497. <rdar://problem/17994679>

8:47 PM Changeset in webkit [172557] by Lucas Forschler

• 2 edits in branches/safari-600.1-branch/Source/WebInspectorUI

Merged r172488. <rdar://problem/17994473>

8:45 PM Changeset in webkit [172556] by Lucas Forschler

• 3 edits in branches/safari-600.1-branch/Source/WebKit2

Merged r172484. <rdar://problem/17582099>

8:43 PM Changeset in webkit [172555] by Lucas Forschler

• 7 edits in branches/safari-600.1-branch/Source/WebKit2

Merged r172483. r<rdar://problem/17935736>

8:41 PM Changeset in webkit [172554] by Lucas Forschler

• 2 edits in branches/safari-600.1-branch/Source/WebKit2

Merged r172395. <rdar://problem/17837670>

8:38 PM Changeset in webkit [172553] by Lucas Forschler

• 9 edits in branches/safari-600.1-branch/Source

Merged r172383. <rdar://problem/17971057>

8:19 PM Changeset in webkit [172552] by Lucas Forschler

• 3 edits in branches/safari-600.1-branch/Source/WebKit2

Merged r172382. <rdar://problem/17935736>

8:12 PM Changeset in webkit [172551] by Lucas Forschler

• 3 edits in branches/safari-600.1-branch/Source/WebInspectorUI/UserInterface/Views

Merge patch for <rdar://problem/17999231>.

7:53 PM Changeset in webkit [172550] by commit-queue@webkit.org

• 2 edits in trunk/Source/JavaScriptCore

Add ARM64 support to CMake-based builds
​https://bugs.webkit.org/show_bug.cgi?id=135912

Patch by Akos Kiss <​akiss@inf.u-szeged.hu> on 2014-08-13
Reviewed by Gyuyoung Kim.

This patch ensures that CMake does not fail with Unknown CPU error when
building for ARM64.

• CMakeLists.txt:

7:52 PM Changeset in webkit [172549] by commit-queue@webkit.org

• 2 edits
  1 add in trunk/Tools

[EFL] Bump up and patch dependencies to allow building for aarch64
​https://bugs.webkit.org/show_bug.cgi?id=135885

Patch by Akos Kiss <​akiss@inf.u-szeged.hu> on 2014-08-13
Reviewed by Gyuyoung Kim.

The currently used versions of pixman, libffi, glib, glib-networking,
and fontconfig fail to configure for aarch64, so they are bumped up to
the latest stable version.

Gstreamer-plugins-base configures for aarch64 but incorrectly recogizes
ARM NEON assembly support, so it is patched with a change that has been
accepted by upstream.

• efl/jhbuild.modules:
• efl/patches/gst-prevent-neon-check-in-configure-from-passing-under-aarch64.patch: Added.

6:22 PM Changeset in webkit [172548] by commit-queue@webkit.org

• 8 edits in trunk/Source

Enable CSS_SCROLL_SNAP for iOS
​https://bugs.webkit.org/show_bug.cgi?id=135915

Turn on CSS_SCROLL_SNAP for iOS and the iOS simulator.

Patch by Wenson Hsieh <Wenson Hsieh> on 2014-08-13
Reviewed by Tim Horton.

• Configurations/FeatureDefines.xcconfig:

6:13 PM Changeset in webkit [172547] by jonowells@apple.com

• 1 edit
  2 adds in trunk/Source/WebInspectorUI

Web Inspector: eslint configuration should be stored as .eslintrc
​https://bugs.webkit.org/show_bug.cgi?id=135916

.eslintrc file added to allow for ESLint solutions, within editors and otherwise,
to be automatically configured based on the WebKit JavaScript coding style. The
initial file is incomplete.

Reviewed by Joseph Pecoraro.

• .eslintrc: Added.
• External/.eslintrc: Added.

5:39 PM Changeset in webkit [172546] by enrica@apple.com

• 2 edits in trunk/Source/WebKit2

[Services with UI] Use a longer delay duration for editable content.
​https://bugs.webkit.org/show_bug.cgi?id=135918
<rdar://problem/17998929>

Reviewed by Tim Horton.

Use a 1 second delay for selections in editable content.

• WebProcess/WebPage/mac/ServicesOverlayController.mm:

(WebKit::ServicesOverlayController::remainingTimeUntilHighlightShouldBeShown):

5:23 PM Changeset in webkit [172545] by Simon Fraser

• 2 edits
  1 add in trunk/LayoutTests

Land correct results for compositing/fixed-image-loading.html on WK1 and WK2.

• compositing/fixed-image-loading-expected.txt:
• platform/mac-wk2/compositing/fixed-image-loading-expected.txt: Added.

5:23 PM Changeset in webkit [172544] by timothy@apple.com

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Missing semicolon after console.assert in TimelineSidebarPanel.js
​https://bugs.webkit.org/show_bug.cgi?id=135917

Reviewed by Joseph Pecoraro.

• UserInterface/Views/TimelineSidebarPanel.js:

5:16 PM Changeset in webkit [172543] by commit-queue@webkit.org

• 8 edits
  2 adds in trunk/Source/WebCore

Compute and store snap point positions
​https://bugs.webkit.org/show_bug.cgi?id=135268

Patch by Wenson Hsieh <Wenson Hsieh> on 2014-08-13
Reviewed by Simon Fraser.

Working towards implementing a way to extract snap positions (i.e. LayoutUnits) from the parsed snap point properties from CSS,
as well as a way of storing the information. Supports both mainframe and overflow scrolling.

No changes in behavior. I will write tests when I implement snapping for iOS and Mac.

• WebCore.xcodeproj/project.pbxproj:
• page/FrameView.cpp:

(WebCore::FrameView::updateSnapOffsets): Invokes the static routine in AxisScrollSnapOffsets to update snap offsets for mainframe.

• page/FrameView.h:
• page/scrolling/AxisScrollSnapOffsets.cpp: Added.

(WebCore::appendAndSortChildSnapOffsets):
(WebCore::updateFromStyle):
(WebCore::updateSnapOffsetsForScrollableArea): Update the ScrollableArea's snap axes.

• page/scrolling/AxisScrollSnapOffsets.h: Added.
• platform/ScrollableArea.cpp:

(WebCore::ScrollableArea::setHorizontalSnapOffsets):
(WebCore::ScrollableArea::setVerticalSnapOffsets):
(WebCore::ScrollableArea::clearHorizontalSnapOffsets): Resets the unique_ptr for horizontal snap points.
(WebCore::ScrollableArea::clearVerticalSnapOffsets): Resets the unique_ptr for vertical snap points.

• platform/ScrollableArea.h:

(WebCore::ScrollableArea::horizontalSnapOffsets): Returns a pointer to the ScrollableArea's horizontal snap points.
(WebCore::ScrollableArea::verticalSnapOffsets): Returns a pointer to the ScrollableArea's vertical snap points.
(WebCore::ScrollableArea::updateSnapOffsets):

• rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateSnapOffsets): Invokes the static routine in AxisScrollSnapOffsets to update snap offsets for an overflow area.

• rendering/RenderLayer.h:

4:55 PM Changeset in webkit [172542] by mrowe@apple.com

• 9 edits in trunk

<​https://webkit.org/b/135911> WebKit should build on Yosemite with the public SDK.

Reviewed by Darin Adler.

Source/WebCore:

• rendering/RenderThemeMac.mm: Fix the forward-declaration of NSServicesRolloverButtonCell.

Source/WebKit/mac:

• Misc/WebSharingServicePickerController.mm: Forward-declare some details related to NSSharingServicePicker.

Source/WebKit2:

• Platform/IPC/mac/ImportanceAssertion.h: Forward-declare the new assertion functions we use.
• UIProcess/mac/WebContextMenuProxyMac.mm: Forward-declare some details related to NSSharingServicePicker.

Tools:

• DumpRenderTree/mac/TextInputController.m: Don't use extern "C" in a non-C++ file.

4:35 PM Changeset in webkit [172541] by ap@apple.com

• 2 edits in trunk/Source/WebKit2

iOS build fix.

• UIProcess/WebContext.cpp:

(WebKit::WebContext::ensureNetworkProcess):
(WebKit::WebContext::createNewWebProcess):

3:53 PM Changeset in webkit [172540] by achristensen@apple.com

• 17 edits in trunk

Progress towards CMake on Mac.
​https://bugs.webkit.org/show_bug.cgi?id=135819

Reviewed by Laszlo Gombos.

.:

• Source/cmake/OptionsMac.cmake:

Disable some more features temporarily to get CMake working.

• Source/cmake/WebKitMacros.cmake:

Added an extension parameter to GENERATE_BINDINGS to allow ObjC bindings to generate .mm files.

Source/JavaScriptCore:

• CMakeLists.txt:

Add the remote inspector headers to the forwarding headers list.

Source/WebCore:

• CMakeLists.txt:

Include derived sources directory, which is needed by Apple ports.
Separated svg and non-svg idls for ObjC bindings.
Don't build the new gamepad API right now. It's causing naming conflicts and it's not done.
Process CSSUnknownRule.idl.

• PlatformGTK.cmake:

Added cpp as the extension of the generated bindings.

• PlatformMac.cmake:

Include more directories and sources.
Add forwarding headers.
Generate ObjC bindings.

• bindings/objc/DOMUIKitExtensions.mm:

Moved config.h to recognize the PLATFORM macro.

• bindings/scripts/CodeGeneratorObjC.pm:

(ReadPublicInterfaces):
(GenerateInterface):
Added some workarounds for CMake.

• bindings/scripts/IDLAttributes.txt:

Added missing attribute names.

• platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

Added PLATFORM(IOS) to protect IOS_AIRPLAY code.

• platform/mac/PasteboardMac.mm:

Added necessary DRAG_SUPPORT protection.

• platform/text/mac/TextCodecMac.cpp:

Moved config.h to recognize the PLATFORM macro.

Tools:

• WebKitTestRunner/CMakeLists.txt:

Added new cpp parameter for the extension of the generated files.

3:30 PM Changeset in webkit [172539] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit2

Opening Web Inspector causes a large amount of sandbox violations
​https://bugs.webkit.org/show_bug.cgi?id=135908

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-08-13
Reviewed by Timothy Hatcher.

• WebProcess/com.apple.WebProcess.sb.in:

Permit the WebContent process to create file read extensions for the
system WebInspectorUI.framework which the Network process can already
read anyways.

3:15 PM Changeset in webkit [172538] by jer.noble@apple.com

• 2 edits in trunk/Source/WebCore

[MSE] Replacing existing samples with overlapping new samples will cause playback to stutter.
​https://bugs.webkit.org/show_bug.cgi?id=135902

Reviewed by Eric Carlson.

Only mark the TrackBuffer as needing re-enqueueing if the samples removed by overlapping samples
themselves overlap with potentially enqueued but not yet displayed frames.

• Modules/mediasource/SourceBuffer.cpp:

(WebCore::SourceBuffer::sourceBufferPrivateDidReceiveSample):

2:39 PM Changeset in webkit [172537] by Simon Fraser

• 2 edits in trunk/LayoutTests

Fix the test result for MountainLion and Mavericks, which don't composite fixed position.

• compositing/fixed-image-loading-expected.txt:

2:06 PM Changeset in webkit [172536] by akling@apple.com

• 20 edits in trunk/Source/WebCore

CSSValueList should never contain null values.
<​https://webkit.org/b/135887>

It's not legal for a CSSValueList to contain null CSSValues, so make
it store a Vector of Ref<CSSValue> internally instead.

This allows the compiler to avoid emitting a number of null checks.
It will also allow a future patch to make CSSValueList vend CSSValue&
instead of CSSValue*.

Most of the patch is fixing up things on their way into a CSSValueList
to not be null at the call site, now that append() and prepend() are
taking PassRef instead of PassRefPtr.

Reviewed by Sam Weinig.

• css/BasicShapeFunctions.cpp:

(WebCore::valueForBasicShape):

• css/BasicShapeFunctions.h:
• css/CSSBorderImage.cpp:

(WebCore::createBorderImageValue):

• css/CSSBorderImage.h:
• css/CSSComputedStyleDeclaration.cpp:

(WebCore::valueForImageSliceSide):
(WebCore::valueForNinePieceImageSlice):
(WebCore::valueForNinePieceImageQuad):
(WebCore::valueForNinePieceImage):
(WebCore::getBorderRadiusShorthandValue):
(WebCore::ComputedStyleExtractor::valueForShadow):
(WebCore::ComputedStyleExtractor::valueForFilter):
(WebCore::specifiedValueForGridTrackSize):
(WebCore::addValuesForNamedGridLinesAtIndex):
(WebCore::scrollSnapCoordinates):
(WebCore::createTimingFunctionValue):
(WebCore::fillSourceTypeToCSSValue):
(WebCore::contentToCSSValue):
(WebCore::shapePropertyValue):
(WebCore::ComputedStyleExtractor::propertyValue):
(WebCore::ComputedStyleExtractor::getCSSPropertyValuesForShorthandProperties):
(WebCore::ComputedStyleExtractor::getCSSPropertyValuesForSidesShorthand):
(WebCore::ComputedStyleExtractor::getCSSPropertyValuesForGridShorthand):
(WebCore::ComputedStyleExtractor::getBackgroundShorthandValue):

• css/CSSComputedStyleDeclaration.h:
• css/CSSFontSelector.cpp:

(WebCore::CSSFontSelector::addFontFaceRule):

• css/CSSParser.cpp:

(WebCore::createPrimitiveValuePair):
(WebCore::parseTranslateTransformValue):
(WebCore::CSSParser::createPrimitiveNumericValue):
(WebCore::CSSParser::createPrimitiveStringValue):
(WebCore::CSSParser::addFillValue):
(WebCore::CSSParser::parseNonElementSnapPoints):
(WebCore::CSSParser::parseScrollSnapDestination):
(WebCore::CSSParser::parseFillShorthand):
(WebCore::CSSParser::addAnimationValue):
(WebCore::CSSParser::parseAnimationShorthand):
(WebCore::CSSParser::parseTransitionShorthand):
(WebCore::CSSParser::parseQuotes):
(WebCore::CSSParser::parseContent):
(WebCore::CSSParser::parseFillProperty):
(WebCore::CSSParser::parseAnimationProperty):
(WebCore::CSSParser::parseGridPosition):
(WebCore::CSSParser::parseGridTemplateRowsAndAreas):
(WebCore::CSSParser::parseGridLineNames):
(WebCore::CSSParser::parseGridTrackList):
(WebCore::CSSParser::parseGridTrackRepeatFunction):
(WebCore::CSSParser::parseGridTrackSize):
(WebCore::CSSParser::parseBasicShapeAndOrBox):
(WebCore::CSSParser::parseFontVariant):
(WebCore::CSSParser::parseTransform):
(WebCore::CSSParser::parseBuiltinFilterArguments):
(WebCore::CSSParser::parseFilter):
(WebCore::CSSParser::parseTextEmphasisStyle):

• css/CSSParser.h:
• css/CSSProperty.cpp:

(WebCore::CSSProperty::wrapValueInCommaSeparatedList):

• css/CSSValueList.cpp:

(WebCore::CSSValueList::CSSValueList):
(WebCore::CSSValueList::removeAll):
(WebCore::CSSValueList::hasValue):
(WebCore::CSSValueList::copy):
(WebCore::CSSValueList::customCSSText):
(WebCore::CSSValueList::equals):
(WebCore::CSSValueList::addSubresourceStyleURLs):
(WebCore::CSSValueList::hasFailedOrCanceledSubresources):

• css/CSSValueList.h:

(WebCore::CSSValueList::item):
(WebCore::CSSValueList::itemWithoutBoundsCheck):
(WebCore::CSSValueList::append):
(WebCore::CSSValueList::prepend):

• css/SVGCSSComputedStyleDeclaration.cpp:

(WebCore::paintOrder):

• css/SVGCSSParser.cpp:

(WebCore::CSSParser::parsePaintOrder):

• editing/EditingStyle.cpp:

(WebCore::mergeTextDecorationValues):

• editing/EditorCommand.cpp:

(WebCore::executeToggleStyleInList):

• svg/SVGFontFaceSrcElement.cpp:

(WebCore::SVGFontFaceSrcElement::srcValue):

• svg/SVGLength.cpp:

(WebCore::SVGLength::toCSSPrimitiveValue):

• svg/SVGLength.h:

1:31 PM Changeset in webkit [172535] by achristensen@apple.com

• 1 edit
  2 deletes in trunk/Source/WebCore

Removed dead plugins code.
​https://bugs.webkit.org/show_bug.cgi?id=135862

Reviewed by Alexey Proskuryakov.

• plugins/PluginDataNone.cpp: Removed.
• plugins/mac: Removed.
• plugins/mac/PluginPackageMac.cpp: Removed.
• plugins/mac/PluginViewMac.mm: Removed.

1:21 PM Changeset in webkit [172534] by Simon Fraser

• 3 edits
  2 adds in trunk

[WK1] A fixed-position <img> may not show on page load
​https://bugs.webkit.org/show_bug.cgi?id=135893

Reviewed by Tim Horton.

Source/WebCore:

A position:fixed image could fail to display because we didn't make a
compositing layer for it under some circumstances. This can happen if
RenderLayerCompositor::requiresCompositingForPosition() runs before the
image is loaded, in which cause the layer is zero-sized, so does not get
composited.

When the image loads, there was no code path that ensured that compositing
would be re-evaluated (unlike size changes due to style updates). Fix by
having RenderLayer::contentChanged() also check for ImageChanged.

Test: compositing/fixed-image-loading.html

• rendering/RenderLayer.cpp:

(WebCore::RenderLayer::contentChanged):

LayoutTests:

Test with a position:fixed image. Note that the test has to force layout
early on to test the bug.

• compositing/fixed-image-loading-expected.txt: Added.
• compositing/fixed-image-loading.html: Added.

1:14 PM Changeset in webkit [172533] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Inline DataGrid inside details sidebar has double thick top border with legacy styles
​https://bugs.webkit.org/show_bug.cgi?id=135894

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-08-13
Reviewed by Timothy Hatcher.

• UserInterface/Views/DetailsSection.css:

(body.mac-platform.legacy .details-section:not(.collapsed) .data-grid.inline):
In legacy styles the details-section header always has a 1px bottom border.
In all styles, an inline data grid had a 1px border everywhere. So, handle
this specific case by removing the top border of an inline data grid
that is inside an expanded details section.

12:43 PM Changeset in webkit [172532] by dbates@webkit.org

• 8 edits in trunk/Source

[iOS] Make JavaScriptCore and bmalloc build with the public SDK
​https://bugs.webkit.org/show_bug.cgi?id=135848

Reviewed by Geoffrey Garen.

Source/bmalloc:

• bmalloc/BPlatform.h: Added macro BPLATFORM_IOS_SIMULATOR, which evaluates to true

when building for the iOS Simulator.

• bmalloc/PerThread.h: Use pthread_machdep.h code path when building for iOS Simulator

using the public SDK.
(_pthread_setspecific_direct): Added; only defined when building for the iOS Simulator
using the public SDK.
(_pthread_getspecific_direct): Added; only defined when building for the iOS Simulator
using the public SDK.

Source/JavaScriptCore:

• API/JSBase.h: Declare NSMap functions with external linkage when building for iOS without the

header <Foundation/NSMapTablePriv.h>.

• inspector/remote/RemoteInspector.mm: Define XPC functions with external linkage when building

without the system header <xpc/xpc.h>.

• inspector/remote/RemoteInspectorXPCConnection.h: Define xpc_connection_t and xpc_object_t when building

without the system header <xpc/xpc.h>.

• inspector/remote/RemoteInspectorXPCConnection.mm: Declare XPC functions with external linkage when

building without without the system header <xpc/xpc.h>.
(Inspector::RemoteInspectorXPCConnection::closeOnQueue): Fix code style; use nullptr instead of NULL.
(Inspector::RemoteInspectorXPCConnection::sendMessage): Ditto.

12:25 PM Changeset in webkit [172531] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: "No Filter Results" view only shows once, does not show again
​https://bugs.webkit.org/show_bug.cgi?id=135892

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-08-13
Reviewed by Timothy Hatcher.

• UserInterface/Views/NavigationSidebarPanel.js:

(WebInspector.NavigationSidebarPanel.prototype.showEmptyContentPlaceholder):
We were checking at the wrong level for a parent. Check if the root
placeholder element has a parent or not.

12:12 PM Changeset in webkit [172530] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Incorrect border colors in event listeners sections in details sidebar
​https://bugs.webkit.org/show_bug.cgi?id=135891

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-08-13
Reviewed by Timothy Hatcher.

• UserInterface/Views/DetailsSection.css:

(.details-section .details-section > .header):
(.details-section .details-section:not(.collapsed) > .header):
Remove box-shadow and replace with a bottom border.

(body.mac-platform.legacy .details-section .details-section.collapsed > .header):
(.details-section .details-section.collaspsed > .header): Deleted.
Collapsed was spelled incorrectly so this was not applying properly before.
But correct this for legacy because legacy still uses a box-shadow.

12:05 PM Changeset in webkit [172529] by Bem Jones-Bey

• 5 edits in trunk/Source/WebCore

Refactor ShapeOutsideInfo so it isn't mutated for each line
​https://bugs.webkit.org/show_bug.cgi?id=135781

Reviewed by Zoltan Horvath.

Encapsulate the per line state into a ShapeOutsideDeltas object.
updateDeltasForContainingBlockLine has been renamed to
computeDeltasForContainingBlockLine, and it returns an instance of the
ShapeOutsideDeltas object for that line. This object is cached, but
none of the functionality of ShapeOutsideInfo is dependant on any line
specific data anymore.

No new tests, no behavior change.

• rendering/FloatingObjects.cpp:

(WebCore::ComputeFloatOffsetForFloatLayoutAdapter<FloatingObject::FloatLeft>::updateOffsetIfNeeded):

Update to take a FloatingObject reference because the FloatingObject cannot be null.

(WebCore::ComputeFloatOffsetForFloatLayoutAdapter<FloatingObject::FloatRight>::updateOffsetIfNeeded):

Ditto.

(WebCore::ComputeFloatOffsetAdapter<FloatTypeValue>::collectIfNeeded): Pass FloatingObject to

updateOffsetIfNeeded as a reference, since it cannot be null.

(WebCore::ComputeFloatOffsetForLineLayoutAdapter<FloatingObject::FloatLeft>::updateOffsetIfNeeded):

Use ShapeOutsideDeltas object to calculate the offset and take the FloatingObject as a
reference.

(WebCore::ComputeFloatOffsetForLineLayoutAdapter<FloatingObject::FloatRight>::updateOffsetIfNeeded):

Ditto.

(WebCore::shapeInfoForFloat): Deleted.

• rendering/line/LineWidth.cpp:

(WebCore::LineWidth::shrinkAvailableWidthForNewFloatIfNeeded): Update to use ShapeOutsideDeltas object.

• rendering/shapes/ShapeOutsideInfo.cpp:

(WebCore::ShapeOutsideInfo::computeDeltasForContainingBlockLine): Return a ShaoeOutsideDeltas object

instead of storing line specific data in instance variables.

(WebCore::ShapeOutsideInfo::updateDeltasForContainingBlockLine): Deleted.

• rendering/shapes/ShapeOutsideInfo.h:

12:03 PM Changeset in webkit [172528] by timothy_horton@apple.com

• 3 edits in trunk/Source/WebKit2

Avoid making new active service overlay highlights while the mouse is down
​https://bugs.webkit.org/show_bug.cgi?id=135872
<rdar://problem/17982341>

Reviewed by Enrica Casucci.

• WebProcess/WebPage/ServicesOverlayController.h:
• WebProcess/WebPage/mac/ServicesOverlayController.mm:

(WebKit::ServicesOverlayController::remainingTimeUntilHighlightShouldBeShown):
(WebKit::ServicesOverlayController::mouseEvent):
If the mouse is pressed or it's been less than 200ms since the mouse went up,
don't allow the highlight to change. We apply the mouse-is-pressed rule to telephone
number highlights as well, unlike the rest of the hysteresis logic.

12:00 PM Changeset in webkit [172527] by commit-queue@webkit.org

• 3 edits in trunk/Source/WebInspectorUI

Web Inspector: Timeline Close buttons can use polish for new and legacy styles
​https://bugs.webkit.org/show_bug.cgi?id=135870

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-08-13
Reviewed by Timothy Hatcher.

• UserInterface/Images/Legacy/Close.svg:

Ensure this has fill colors in tree selections.

• UserInterface/Views/TimelineSidebarPanel.css:

(.sidebar > .panel.navigation.timeline > .timelines-content .close-button):
(body.mac-platform.legacy .sidebar > .panel.navigation.timeline > .timelines-content .close-button):
(body.mac-platform.legacy .sidebar > .panel.navigation.timeline > .content .item > .status > .status-button):
Size the close-button for the top overviews differently in new styles (14x14) and legacy (12x12).

11:58 AM Changeset in webkit [172526] by timothy@apple.com

• 9 edits in trunk/Source

Web Inspector: Workaround a NSWindow change to the title bar.
​https://bugs.webkit.org/show_bug.cgi?id=135880

Reviewed by Joseph Pecoraro.

Source/WebInspectorUI:

• UserInterface/Base/Main.js:

(WebInspector._updateToolbarHeight): Don't call in legacy mode.

• UserInterface/Views/DashboardContainerView.css:

(.toolbar .dashboard-container):
(.toolbar .dashboard):
Drive-by fix some errant drop-shadows. The transparent border was pushing the inset top
drop shadow down when it shouldn't. Remove duplicate background and shadow.

• UserInterface/Views/Main.css:

(body): Set the background white, never needs to be transparent now.
(body.mac-platform.legacy:not(.docked)): Set background to transparent when not docked in legacy.
(body.docked.bottom): Update border color.
(body.docked.right): Ditto.
(body.docked.bottom.mac-platform.legacy): Keep old border color.
(body.docked.right.mac-platform.legacy): Ditto.

• UserInterface/Views/Toolbar.css:

(.toolbar): Set a default border and background gradient.
(body.window-inactive .toolbar): No gradient but use a solid color when inactive.
(body.mac-platform:not(.legacy):not(.docked) .toolbar): Padding on the top for the title bar.
(body.mac-platform:not(.legacy):not(.docked) .toolbar.icon-and-label-vertical): Account for title bar height.
(body.mac-platform:not(.legacy):not(.docked) .toolbar.icon-and-label-vertical.small-size): Ditto.
(body.mac-platform:not(.legacy):not(.docked) .toolbar.icon-only): Ditto.
(body.mac-platform:not(.legacy):not(.docked) .toolbar.label-only): Ditto.
(body.mac-platform.legacy .toolbar): No inset shadow in legacy when not docked.
(body.mac-platform.legacy.docked .toolbar): Restore legacy border color.
(body.mac-platform.legacy:not(.docked) .toolbar .item.button > .label): Only disable sub-pixel antialiasing on legacy!
(body.mac-platform.legacy.window-inactive .toolbar): Restore legacy border color.

Source/WebKit/mac:

• WebCoreSupport/WebInspectorClient.mm:

(WebInspectorFrontendClient::setToolbarHeight): Only call setContentBorderThickness: on 10.9 and earlier.
(-[WebInspectorWindowController init]): Only call setDrawsBackground: on 10.9 and earlier.
(-[WebInspectorWindowController window]): Set titlebarAppearsTransparent on 10.10.
Only call border thickness APIs on 10.9 and earlier.

Source/WebKit2:

• UIProcess/mac/WebInspectorProxyMac.mm:

(WebKit::WebInspectorProxy::createInspectorWindow): Set titlebarAppearsTransparent on 10.10.
Only call border thickness APIs on 10.9 and earlier.
(WebKit::WebInspectorProxy::platformCreateInspectorPage): Only call setDrawsBackground: on 10.9 and earlier.
(WebKit::WebInspectorProxy::platformSetToolbarHeight): Only call setContentBorderThickness: on 10.9 and earlier.

11:51 AM Changeset in webkit [172525] by timothy@apple.com

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Restore Helvetica as the dashboard font in legacy mode
​https://bugs.webkit.org/show_bug.cgi?id=135886

Reviewed by Joseph Pecoraro.

• UserInterface/Views/DefaultDashboardView.css:

(body.mac-platform.legacy .toolbar .dashboard.default > .item):

11:00 AM Changeset in webkit [172524] by zoltan@webkit.org

• 4 edits
  2 adds in trunk

[CSS3-Text] Add rendering support for the none value of text-justify property
​https://bugs.webkit.org/show_bug.cgi?id=135349

Reviewed by David Hyatt.

Source/WebCore:

Spec: ​http://dev.w3.org/csswg/css-text-3/#valdef-text-justify.none

Test: fast/css3-text/css3-text-justify/text-justify-none.html

• rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlockFlow::computeInlineDirectionPositionsForSegment):

LayoutTests:

• fast/css3-text/css3-text-justify/text-justify-none-expected.html: Added.
• fast/css3-text/css3-text-justify/text-justify-none.html: Added.
• platform/mac/TestExpectations:

10:24 AM Changeset in webkit [172523] by eric.carlson@apple.com

• 6 edits
  2 adds in trunk

Media document sends incorrect referer header
​https://bugs.webkit.org/show_bug.cgi?id=135839

Reviewed by Jer Noble.

Source/WebCore:

Test: http/tests/media/media-document-referer.html

• html/MediaDocument.cpp:

(WebCore::MediaDocumentParser::MediaDocumentParser): Stash referrer.
(WebCore::MediaDocumentParser::createDocumentStructure): Set outgoing referrer.
(WebCore::MediaDocument::MediaDocument): Stash referrer.

• html/MediaDocument.h:

LayoutTests:

• http/tests/media/media-document-referer-expected.txt: Added.
• http/tests/media/media-document-referer.html: Added.
• http/tests/media/resources/video-referer-check-referer.php: Take expected referer as a

parameter instead of hard coding it.

• http/tests/media/video-referer.html: Pass referer to loader script.

8:45 AM Changeset in webkit [172522] by mihnea@adobe.com

• 2 edits
  50 moves
  1 add in trunk/LayoutTests

[CSSRegions] Move scrolling tests under fast/regions/scrolling
​https://bugs.webkit.org/show_bug.cgi?id=135881

Reviewed by Andrei Bucur.

• fast/regions/scrolling/scroll-into-view-expected.html: Renamed from LayoutTests/fast/regions/scroll-into-view-expected.html.
• fast/regions/scrolling/scroll-into-view-relative-expected.html: Renamed from LayoutTests/fast/regions/scroll-into-view-relative-expected.html.
• fast/regions/scrolling/scroll-into-view-relative.html: Renamed from LayoutTests/fast/regions/scroll-into-view-relative.html.
• fast/regions/scrolling/scroll-into-view.html: Renamed from LayoutTests/fast/regions/scroll-into-view.html.
• fast/regions/scrolling/scrollable-first-region-expected.html: Renamed from LayoutTests/fast/regions/scrollable-first-region-expected.html.
• fast/regions/scrolling/scrollable-first-region.html: Renamed from LayoutTests/fast/regions/scrollable-first-region.html.
• fast/regions/scrolling/scrollable-last-region-expected.html: Renamed from LayoutTests/fast/regions/scrollable-last-region-expected.html.
• fast/regions/scrolling/scrollable-last-region.html: Renamed from LayoutTests/fast/regions/scrollable-last-region.html.
• fast/regions/scrolling/scrollable-paragraph-unsplittable-expected.html: Renamed from LayoutTests/fast/regions/scrollable-paragraph-unsplittable-expected.html.
• fast/regions/scrolling/scrollable-paragraph-unsplittable.html: Renamed from LayoutTests/fast/regions/scrollable-paragraph-unsplittable.html.
• fast/regions/scrolling/scrollable-region-content-size-expected.html: Renamed from LayoutTests/fast/regions/scrollable-region-content-size-expected.html.
• fast/regions/scrolling/scrollable-region-content-size-horiz-bt-expected.html: Renamed from LayoutTests/fast/regions/scrollable-region-content-size-horiz-bt-expected.html.
• fast/regions/scrolling/scrollable-region-content-size-horiz-bt.html: Renamed from LayoutTests/fast/regions/scrollable-region-content-size-horiz-bt.html.
• fast/regions/scrolling/scrollable-region-content-size-no-overflow-expected.html: Renamed from LayoutTests/fast/regions/scrollable-region-content-size-no-overflow-expected.html.
• fast/regions/scrolling/scrollable-region-content-size-no-overflow-horiz-bt-expected.html: Renamed from LayoutTests/fast/regions/scrollable-region-content-size-no-overflow-horiz-bt-expected.html.
• fast/regions/scrolling/scrollable-region-content-size-no-overflow-horiz-bt.html: Renamed from LayoutTests/fast/regions/scrollable-region-content-size-no-overflow-horiz-bt.html.
• fast/regions/scrolling/scrollable-region-content-size-no-overflow-vert-rl-expected.html: Renamed from LayoutTests/fast/regions/scrollable-region-content-size-no-overflow-vert-rl-expected.html.
• fast/regions/scrolling/scrollable-region-content-size-no-overflow-vert-rl.html: Renamed from LayoutTests/fast/regions/scrollable-region-content-size-no-overflow-vert-rl.html.
• fast/regions/scrolling/scrollable-region-content-size-no-overflow.html: Renamed from LayoutTests/fast/regions/scrollable-region-content-size-no-overflow.html.
• fast/regions/scrolling/scrollable-region-content-size-relative-expected.html: Renamed from LayoutTests/fast/regions/scrollable-region-content-size-relative-expected.html.
• fast/regions/scrolling/scrollable-region-content-size-relative.html: Renamed from LayoutTests/fast/regions/scrollable-region-content-size-relative.html.
• fast/regions/scrolling/scrollable-region-content-size-vert-rl-expected.html: Renamed from LayoutTests/fast/regions/scrollable-region-content-size-vert-rl-expected.html.
• fast/regions/scrolling/scrollable-region-content-size-vert-rl.html: Renamed from LayoutTests/fast/regions/scrollable-region-content-size-vert-rl.html.
• fast/regions/scrolling/scrollable-region-content-size-vertical-lr-expected.html: Renamed from LayoutTests/fast/regions/scrollable-region-content-size-vertical-lr-expected.html.
• fast/regions/scrolling/scrollable-region-content-size-vertical-lr.html: Renamed from LayoutTests/fast/regions/scrollable-region-content-size-vertical-lr.html.
• fast/regions/scrolling/scrollable-region-content-size.html: Renamed from LayoutTests/fast/regions/scrollable-region-content-size.html.
• fast/regions/scrolling/scrollable-region-scrollable-absolute-content-background-expected.html: Renamed from LayoutTests/fast/regions/scrollable-region-scrollable-absolute-content-background-expected.html.
• fast/regions/scrolling/scrollable-region-scrollable-absolute-content-background.html: Renamed from LayoutTests/fast/regions/scrollable-region-scrollable-absolute-content-background.html.
• fast/regions/scrolling/scrollable-region-scrollable-content-background-expected.html: Renamed from LayoutTests/fast/regions/scrollable-region-scrollable-content-background-expected.html.
• fast/regions/scrolling/scrollable-region-scrollable-content-background.html: Renamed from LayoutTests/fast/regions/scrollable-region-scrollable-content-background.html.
• fast/regions/scrolling/scrollable-region-scrollable-content-expected.html: Renamed from LayoutTests/fast/regions/scrollable-region-scrollable-content-expected.html.
• fast/regions/scrolling/scrollable-region-scrollable-content.html: Renamed from LayoutTests/fast/regions/scrollable-region-scrollable-content.html.
• fast/regions/scrolling/scrollable-regions-hit-testing-inside-expected.html: Renamed from LayoutTests/fast/regions/scrollable-regions-hit-testing-inside-expected.html.
• fast/regions/scrolling/scrollable-regions-hit-testing-inside.html: Renamed from LayoutTests/fast/regions/scrollable-regions-hit-testing-inside.html.
• fast/regions/scrolling/scrollable-single-region-bt-expected.html: Renamed from LayoutTests/fast/regions/scrollable-single-region-bt-expected.html.
• fast/regions/scrolling/scrollable-single-region-bt.html: Renamed from LayoutTests/fast/regions/scrollable-single-region-bt.html.
• fast/regions/scrolling/scrollable-single-region-expected.html: Renamed from LayoutTests/fast/regions/scrollable-single-region-expected.html.
• fast/regions/scrolling/scrollable-single-region-lr-expected.html: Renamed from LayoutTests/fast/regions/scrollable-single-region-lr-expected.html.
• fast/regions/scrolling/scrollable-single-region-lr.html: Renamed from LayoutTests/fast/regions/scrollable-single-region-lr.html.
• fast/regions/scrolling/scrollable-single-region-relative-element-expected.html: Renamed from LayoutTests/fast/regions/scrollable-single-region-relative-element-expected.html.
• fast/regions/scrolling/scrollable-single-region-relative-element.html: Renamed from LayoutTests/fast/regions/scrollable-single-region-relative-element.html.
• fast/regions/scrolling/scrollable-single-region-rl-expected.html: Renamed from LayoutTests/fast/regions/scrollable-single-region-rl-expected.html.
• fast/regions/scrolling/scrollable-single-region-rl.html: Renamed from LayoutTests/fast/regions/scrollable-single-region-rl.html.
• fast/regions/scrolling/scrollable-single-region.html: Renamed from LayoutTests/fast/regions/scrollable-single-region.html.
• fast/regions/scrolling/wheel-scroll-abspos-expected.html: Renamed from LayoutTests/fast/regions/wheel-scroll-abspos-expected.html.
• fast/regions/scrolling/wheel-scroll-abspos.html: Renamed from LayoutTests/fast/regions/wheel-scroll-abspos.html.
• fast/regions/scrolling/wheel-scroll-expected.html: Renamed from LayoutTests/fast/regions/wheel-scroll-expected.html.
• fast/regions/scrolling/wheel-scroll.html: Renamed from LayoutTests/fast/regions/wheel-scroll.html.
• fast/regions/scrolling/wheel-scrollable-single-region-expected.html: Renamed from LayoutTests/fast/regions/wheel-scrollable-single-region-expected.html.
• fast/regions/scrolling/wheel-scrollable-single-region.html: Renamed from LayoutTests/fast/regions/wheel-scrollable-single-region.html.
• platform/gtk/TestExpectations: Fix path for previously moved tests.

7:31 AM Changeset in webkit [172521] by commit-queue@webkit.org

• 2 edits
  2 adds in trunk/Tools

Make check-webkit-style run sort-export-file
​https://bugs.webkit.org/show_bug.cgi?id=135877

Patch by Renato Nagy <​nagy.renato@stud.u-szeged.hu> on 2014-08-13
Reviewed by Csaba Osztrogonác.

• Scripts/webkitpy/style/checker.py:

(_all_categories):
(FileType):
(CheckerDispatcher._file_type):
(CheckerDispatcher._create_checker):

• Scripts/webkitpy/style/checkers/exportfile.py: Added.

(ExportFileChecker):
(ExportFileChecker.init):
(ExportFileChecker.check):

• Scripts/webkitpy/style/checkers/exportfile_unittest.py: Added.

(handle_style_error):
(MockErrorHandler):
(MockErrorHandler.init):
(MockErrorHandler.turn_off_line_filtering):
(MockErrorHandler.call):
(ExportFileTest):
(ExportFileTest.setUp):
(ExportFileTest.tearDown):
(ExportFileTest.test_sorted):
(ExportFileTest.test_non_sorted):
(ExportFileTest.test_parse_error):

6:12 AM Changeset in webkit [172520] by ryuan.choi@samsung.com

• 7 edits in trunk/Source/WebKit2

[EFL] Add API to set application name for the user agent
​https://bugs.webkit.org/show_bug.cgi?id=135640

Reviewed by Gyuyoung Kim.

Add ewk_application_name_for_user_agent_set to make default user agent string
with application name which application passes.
It's useful for application to set only application information without knowledge
of legacy user agent components.

• UIProcess/API/efl/EwkView.cpp:

(EwkView::EwkView):
(EwkView::setApplicationNameForUserAgent):

• UIProcess/API/efl/EwkView.h:

(EwkView::applicationNameForUserAgent):

• UIProcess/API/efl/ewk_view.cpp:

(ewk_view_application_name_for_user_agent_set):
(ewk_view_application_name_for_user_agent_get):

• UIProcess/API/efl/ewk_view.h:
• UIProcess/API/efl/tests/test_ewk2_view.cpp:

(TEST_F):

• UIProcess/efl/WebPageProxyEfl.cpp:

(WebKit::WebPageProxy::standardUserAgent):

5:10 AM Changeset in webkit [172519] by jinwoo7.song@samsung.com

• 2 edits in trunk/Tools

[EFL] Sets the persistent storage for cookies in MiniBrowser
​https://bugs.webkit.org/show_bug.cgi?id=135875

Reviewed by Gyuyoung Kim.

In case of EWK_COOKIE_ACCEPT_POLICY_ALWAYS, sets the persistent storage
for non-session cookies can be stored persistently.

• MiniBrowser/efl/main.c:

(elm_main):

4:41 AM EFLWebKit edited by gyuyoung.kim@samsung.com

(diff)

4:38 AM EFLWebKitBuildBots edited by gyuyoung.kim@samsung.com

(diff)

4:36 AM EFLWebKitBuildBots edited by gyuyoung.kim@samsung.com

(diff)

4:20 AM Changeset in webkit [172518] by Antti Koivisto

• 3 edits in trunk/LayoutTests

Don't recurse into non-rendered subtrees when computing style
​https://bugs.webkit.org/show_bug.cgi?id=135844

Reviewed by Andreas Kling.

Rebase.

• http/tests/security/video-poster-cross-origin-crash-expected.txt:
• platform/mac/fast/ruby/ruby-base-merge-block-children-crash-2-expected.txt:

3:13 AM Changeset in webkit [172517] by Antti Koivisto

• 2 edits in trunk/Source/WebCore

Don't recurse into non-rendered subtrees when computing style
​https://bugs.webkit.org/show_bug.cgi?id=135844

Reviewed by Andreas Kling.

• style/StyleResolveTree.cpp:

(WebCore::Style::resetStyleForNonRenderedDescendants):

Do a simple reset of the style dirty bits and any computed style in non-renderer subtrees.

(WebCore::Style::attachRenderTree):
(WebCore::Style::resolveTree):

Don't recurse into descendants if the element does not create a renderer.
We didn't compute style anyway in such subtrees.

Aug 12, 2014:

11:44 PM Changeset in webkit [172516] by Carlos Garcia Campos

• 2 edits in trunk/Source/WebKit2

[CMAKE] WebProcess shouldn't need to explicitly link to JavaScriptCore and WebCore
​https://bugs.webkit.org/show_bug.cgi?id=135832

Reviewed by Gyuyoung Kim.

Linking to WebKit2 should be enough, like Network and Plugin processes.

• CMakeLists.txt:

9:15 PM Changeset in webkit [172515] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Timeline record content view close button does not work after scrolling, invisible scrollbar
​https://bugs.webkit.org/show_bug.cgi?id=135863

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-08-12
Reviewed by Timothy Hatcher.

A workaround is to not have position:relative content inside of
scrollable region. Turns out this was only done in two places,
and I do not see any absolutely positioned content in navigation
sidebar content tree outlines. This also fixes clicking on the
reload button if you've scrolled the Resources sidebar.

• UserInterface/Views/NavigationSidebarPanel.css:

(.navigation-sidebar-panel-content-tree-outline .children): Deleted.
(.navigation-sidebar-panel-content-tree-outline .item): Deleted.

9:07 PM Changeset in webkit [172514] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Remove unused variable in Platform.js
​https://bugs.webkit.org/show_bug.cgi?id=135869

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-08-12
Reviewed by Timothy Hatcher.

• UserInterface/Base/Platform.js:

8:53 PM Changeset in webkit [172513] by mmaxfield@apple.com

• 7 edits
  2 adds in trunk

Elements whose contents start with an astral Unicode symbol disappear when CSS ::first-letter is applied to them
​https://bugs.webkit.org/show_bug.cgi?id=135756

Reviewed by Darin Adler.

Source/WebCore:

The previous code assumed that all "characters" are exactly 1 16-bit code unit wide. Instead, use numCharactersInGraphemeClusters().

This patch also modifies the signature of numCharactersInGraphemeClusters() to take a StringView instead
of a string, which will avoid a copy.

Test: css1/pseudo/firstletter-surrogate.html

• platform/text/TextBreakIterator.cpp:

(WebCore::numCharactersInGraphemeClusters): Update numCharactersInGraphemeClusters() to take a StringView.

• platform/text/TextBreakIterator.h: Ditto.
• rendering/RenderBlock.cpp:

(WebCore::RenderBlock::createFirstLetterRenderer): Use numCharactersInGraphemeClusters() to determine the length
of the first letter, rather than assuming it has length of 1 code unit
(WebCore::RenderBlock::updateFirstLetter): Add a FIXME comment.

Source/WTF:

Add a method to StringView which passes through contains() to find().

• wtf/text/StringView.h:

(WTF::StringView::contains):

LayoutTests:

Make sure the pseudoclass matches manually wrapping a <span> around the character.

• css1/pseudo/firstletter-surrogate-expected.html: Added.
• css1/pseudo/firstletter-surrogate.html: Added.

8:02 PM Changeset in webkit [172512] by timothy_horton@apple.com

• 2 edits in trunk/Source/WebKit2

Document-relative page overlays drop some mouse events with non-zero top content inset
​https://bugs.webkit.org/show_bug.cgi?id=135871
<rdar://problem/17982275>

Reviewed by Beth Dakin.

• WebProcess/WebPage/PageOverlay.cpp:

(WebKit::PageOverlay::mouseEvent):
Convert the mouse position into document-relative coordinates; the bounds()
already are! This way, we can actually compare them without being wrong sometimes.

7:35 PM Changeset in webkit [172511] by dbates@webkit.org

• 2 edits in trunk/Tools

[iOS] build-webkit should not build WebKitSystemInterface and WebKitAdditions
​https://bugs.webkit.org/show_bug.cgi?id=135845

Reviewed by Andy Estes.

Towards building the iOS WebKit port using the public SDK, remove the logic
added to build-webkit to build projects WebKitSystemInterface and
WebKitAdditions when building the iOS WebKit port.

• Scripts/build-webkit:

7:33 PM Changeset in webkit [172510] by dbates@webkit.org

• 2 edits in trunk/Source/bmalloc

BPLATFORM(IOS) always evaluates to false
​https://bugs.webkit.org/show_bug.cgi?id=135843

Reviewed by Geoffrey Garen.

Fix typo in definition of BPLATFORM() and include system header TargetConditionals.h
(when building on an Apple platform) so that BPLATFORM(X) evaluates to true when
building for platform X. In particular, so that BPLATFORM(IOS) evaluates to true when
building for iOS.

As a side effect of this change, the change made in <​http://trac.webkit.org/changeset/167289>
will be honored and iOS will assume a VM page size of 16kB (again) instead of 4kB.

• bmalloc/BPlatform.h:

5:13 PM Changeset in webkit [172509] by Brent Fulgham

• 2 edits in trunk/Source/WebKit

[Win] Unreviewed build fix after r172504

• WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in: Add missing

symbol exports.

4:45 PM Changeset in webkit [172508] by psolanki@apple.com

• 2 edits in trunk/Source/WTF

Enable didReceiveDataArray callback on Mac
​https://bugs.webkit.org/show_bug.cgi?id=135554
<rdar://problem/9170731>

Reviewed by Andreas Kling.

Enable WTF_USE_NETWORK_CFDATA_ARRAY_CALLBACK for all Cocoa platforms so that we use the same
code path for Mac and iOS.

• wtf/Platform.h:

4:40 PM Changeset in webkit [172507] by jer.noble@apple.com

• 3 edits in trunk/Source/WebCore

[MSE][Mac] Seeking to the very beginning of a buffered range stalls video playback
​https://bugs.webkit.org/show_bug.cgi?id=135865

Reviewed by Eric Carlson.

AVSampleBufferRenderSynchronizer will report a current time of about 100ms or so before
the destination seek time when seeking. It does this in order to pre-roll the synchronized
audio renderer, but this can lead to playback stalling when MediaSource::monitorSourceBuffers()
looks at the media element's current time and determines that the current time is 100ms before
any buffered samples.

Clamp the value of currentMediaTime() to, at a minimum, the last requested seek time. This was
the suggested course of action from <rdar://problem/17789374>.

• platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h:
• platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:

(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::durationDouble):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::currentMediaTime):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::seekInternal):

4:37 PM Changeset in webkit [172506] by jer.noble@apple.com

• 2 edits in trunk/Source/WebCore

[MSE] YouTube will lose audio, video after seeking backwards to an unbuffered range.
​https://bugs.webkit.org/show_bug.cgi?id=135855

Reviewed by Eric Carlson.

When seeking into an unbuffered or partially buffered range, we will unconditionally pass samples to the
decode queue even if there exist large gaps between those samples. Subsequently, the decoder will not
notify us that it has become ready for new samples until playback reaches those later samples and the samples
are discarded.

When sending samples to be decoded in provideMediaData(), stop if there exists a large gap in the sample timeline.
Do this by tracking the last enqueued decode end time, and look to see if the next sample's decode time indicates
a gap of greater than 1 second.

• Modules/mediasource/SourceBuffer.cpp:

(WebCore::SourceBuffer::TrackBuffer::TrackBuffer): Initialize lastEnqueuedDecodeEndTime.
(WebCore::SourceBuffer::seekToTime): Set needsReenqueueing, in case samples do not yet exist in the trackBuffer

sufficient to re-enqueue for the destination time, so that re-enqueueing will occur after the next append.

(WebCore::SourceBuffer::sourceBufferPrivateDidReceiveSample): Check against lastEnqueuedDecodeEndTime, rather than

lastEnqueuedPresentationTime before adding samples to the decodeQueue.

(WebCore::SourceBuffer::provideMediaData): Stop when we reach a large gap between samples.
(WebCore::SourceBuffer::reenqueueMediaForTime): Set or clear lastEnqueuedDecodeEndTime based on whether we

have appended any non-displaying samples after flushing.

4:15 PM Changeset in webkit [172505] by commit-queue@webkit.org

• 5 edits in trunk

Unreviewed, rolling out r172494.
​https://bugs.webkit.org/show_bug.cgi?id=135864

asserting on bots (Requested by kling on #webkit).

Reverted changeset:

"Don't recurse into non-rendered subtrees when computing
style"
​https://bugs.webkit.org/show_bug.cgi?id=135844
​http://trac.webkit.org/changeset/172494

4:13 PM Changeset in webkit [172504] by mmaxfield@apple.com

• 6 edits
  2 adds in trunk

Fonts forced to use non synthetic italics might be laid out with the incorrect baseline
​https://bugs.webkit.org/show_bug.cgi?id=135403

Reviewed by Darin Adler.

Source/WebCore:

When italics is specified on a font, and the font isn't coming from the cache, we ask
the SimpleFontData to provide a non-synthetic-italic version of itself. Our current
implementation doesn't preserve whether or not the SimpleFontData includes vertical
glyphs (glyphs that are not rotated when drawn in the vertical writing mode), which
determines which baseline we use to lay out the text. By passing "false" to
the isTextOrientationFallback argument to SimpleFontData::create(), we preserve this
hasVerticalGlyphs flag.

Test: fast/text/international/synthesized-italic-vertical-latin-double.html

• platform/graphics/SimpleFontData.cpp:

(WebCore::SimpleFontData::nonSyntheticItalicFontData):

• testing/Internals.cpp:

(WebCore::Internals::invalidateFontCache): Add "invalidateFontCache" to window.internals.

• testing/Internals.h: Ditto.
• testing/Internals.idl: Ditto.

LayoutTests:

Laying out the same string twice (where there is a cache collision) should be rendered
the same as laying out similar strings (where there is no cache collision).

• fast/text/international/synthesized-italic-vertical-latin-double-expected.html: Added.
• fast/text/international/synthesized-italic-vertical-latin-double.html: Added.

4:11 PM Changeset in webkit [172503] by commit-queue@webkit.org

• 15 edits in trunk/Source

Source/JavaScriptCore:
Runtime switch for long mouse press gesture. Part of 135257 - Add long mouse press gesture.
​https://bugs.webkit.org/show_bug.cgi?id=135682

Patch by Peyton Randolph <​prandolph@apple.com> on 2014-08-12
Reviewed by Tim Horton.

• Configurations/FeatureDefines.xcconfig:

Remove ENABLE_LONG_MOUSE_PRESS feature flag.

Source/WebCore:
Runtime switch for long mouse press gesture. Part of 135257 - Add long mouse press gesture.
​https://bugs.webkit.org/show_bug.cgi?id=135682

Patch by Peyton Randolph <​prandolph@apple.com> on 2014-08-12
Reviewed by Tim Horton.

This patch adds a runtime switch for the Long Mouse Press Gesture and initially sets the feature flag
to false. It also removes the ENABLE_LONG_MOUSE_PRESS feature flag as the runtime switch now guards
its functionality.

• Configurations/FeatureDefines.xcconfig: Remove LONG_MOUSE_PRESS feature flag.
• page/EventHandler.cpp:

(WebCore::EventHandler::EventHandler):
(WebCore::EventHandler::clear): Remove feature flag.
(WebCore::EventHandler::handleMousePressEvent): Ditto.
(WebCore::EventHandler::eventMayStartDrag): Ditto.
(WebCore::EventHandler::handleMouseReleaseEvent):
Perform event iff long mouse presses are enabled.
(WebCore::EventHandler::beginTrackingPotentialLongMousePress): Ditto.
(WebCore::EventHandler::recognizeLongMousePress): Ditto.
(WebCore::EventHandler::cancelTrackingPotentialLongMousePress): Ditto.
(WebCore::EventHandler::handleMouseMoveEvent): Remove feature flag.
(WebCore::EventHandler::handleDrag): Ditto.
(WebCore::EventHandler::mouseMovementExceedsThreshold): Ditto.

• page/EventHandler.h:
• page/Settings.in: Add longMousePressEnabled setting, initially false.

Source/WebKit/mac:
Runtime switch for long mouse press gesture. Part of 135257 - Add long mouse press gesture.
​https://bugs.webkit.org/show_bug.cgi?id=135682

Patch by Peyton Randolph <​prandolph@apple.com> on 2014-08-12
Reviewed by Tim Horton.

• Configurations/FeatureDefines.xcconfig:

Remove LONG_MOUSE_PRESS feature flag.

Source/WebKit2:
Runtime switch for long mouse press gesture. Part of 135257 - Add long mouse press gesture
​https://bugs.webkit.org/show_bug.cgi?id=135682

Patch by Peyton Randolph <​prandolph@apple.com> on 2014-08-12
Reviewed by Tim Horton.

• Configurations/FeatureDefines.xcconfig: Remove LONG_MOUSE_PRESS feature flag.
• Shared/WebPreferencesDefinitions.h:

Add LongMousePressEnabled preference, initially false.

• UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetLongMousePressEnabled): Added.
(WKPreferencesGetLongMousePressEnabled): Added.

• UIProcess/API/C/WKPreferencesRefPrivate.h:
• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):
Reflect the WebKit long mouse press setting in WebCore.

3:50 PM Changeset in webkit [172502] by psolanki@apple.com

• 6 edits in trunk/Source

Cached file backed resources don't make it to the Web Process when NETWORK_CFDATA_ARRAY_CALLBACK is enabled
​https://bugs.webkit.org/show_bug.cgi?id=135727
<rdar://problem/17947880>

Reviewed by Darin Adler.

Source/WebCore:

Add SharedBuffer::existingCFData() which returns CFDataRef if it has one. Refactor
this code out of createCFData().

• WebCore.exp.in:
• platform/SharedBuffer.h:
• platform/mac/SharedBufferMac.mm:

(WebCore::SharedBuffer::existingCFData): Added.
(WebCore::SharedBuffer::createCFData):

Source/WebKit2:

tryGetShareableHandleFromSharedBuffer() assumed that we have a file backed resource only if
we had a CFDataRef (platformData()) in SharedBuffer. This is wrong when we use the data
array callbacks since the file backed buffer could be in the data array. Instead of relying
on hasPlatformData(), explicitly ask the SharedBuffer to give us a CFDataRef if it has one
so that SharedBuffer can take care of the data array case.

• NetworkProcess/mac/NetworkResourceLoaderMac.mm:

(WebKit::NetworkResourceLoader::tryGetShareableHandleFromSharedBuffer):

3:48 PM Changeset in webkit [172501] by timothy_horton@apple.com

• 5 edits in trunk/Source

Small region (~1px tall) where you get the selection button instead of the phone number overlay
​https://bugs.webkit.org/show_bug.cgi?id=135852
<rdar://problem/17992795>

Reviewed by Enrica Casucci.

• WebProcess/WebPage/ServicesOverlayController.h:
• WebProcess/WebPage/mac/ServicesOverlayController.mm:

(WebKit::ServicesOverlayController::findTelephoneNumberHighlightContainingSelectionHighlight):
(WebKit::ServicesOverlayController::determineActiveHighlight):
If our new active highlight is a selection highlight that is completely contained
by one of the phone number highlights, we'll make the phone number highlight active
even if it's not hovered. This fixes the case where the selection highlight
(a subset of a telephone number) is slightly taller than the telephone number
highlight, and can be hovered without hovering the phone number highlight

• WebCore.exp.in:

3:43 PM Changeset in webkit [172500] by ap@apple.com

• 12 edits in trunk/Source/WebKit2

REGRESSION: WebContent process has a sandbox extension for the entirety of user's temp directory
​https://bugs.webkit.org/show_bug.cgi?id=135853
<rdar://problem/17986556>

Reviewed by Oliver hunt.

Move extensions recently added for iOS benefit under PLATFORM(IOS). Removed some
dead code while at it (child processes don't need actual paths, they only need
sandbox extensions in most cases).

• NetworkProcess/cocoa/NetworkProcessCocoa.mm:

(WebKit::NetworkProcess::platformInitializeNetworkProcessCocoa):

• Shared/Network/NetworkProcessCreationParameters.cpp:

(WebKit::NetworkProcessCreationParameters::encode):
(WebKit::NetworkProcessCreationParameters::decode):

• Shared/Network/NetworkProcessCreationParameters.h:
• Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::encode):
(WebKit::WebProcessCreationParameters::decode):

• Shared/WebProcessCreationParameters.h:
• UIProcess/WebContext.cpp:

(WebKit::WebContext::ensureNetworkProcess):
(WebKit::WebContext::createNewWebProcess):
(WebKit::WebContext::openGLCacheDirectory): Deleted.
(WebKit::WebContext::networkingHSTSDatabasePath): Deleted.

• UIProcess/WebContext.h:
• UIProcess/efl/WebContextEfl.cpp:

(WebKit::WebContext::containerTemporaryDirectory): Deleted.
(WebKit::WebContext::platformDefaultNetworkingHSTSDatabasePath): Deleted.

• UIProcess/gtk/WebContextGtk.cpp:

(WebKit::WebContext::containerTemporaryDirectory): Deleted.
(WebKit::WebContext::platformDefaultNetworkingHSTSDatabasePath): Deleted.

• UIProcess/mac/WebContextMac.mm:

(WebKit::WebContext::openGLCacheDirectory):
(WebKit::WebContext::parentBundleDirectory):
(WebKit::WebContext::networkingHSTSDatabasePath):
(WebKit::WebContext::platformDefaultOpenGLCacheDirectory): Deleted.
(WebKit::WebContext::platformDefaultNetworkingHSTSDatabasePath): Deleted.

• WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::WebProcess::platformInitializeWebProcess):

3:43 PM Changeset in webkit [172499] by achristensen@apple.com

• 8 edits in trunk/Source

Generate header detection headers for CMake on Windows.
​https://bugs.webkit.org/show_bug.cgi?id=135807

Reviewed by Brent Fulgham.

Source/JavaScriptCore:

• CMakeLists.txt:

Include the derived sources directory to find WTF/WTFHeaderDetection.h.

Source/WebCore:

• CMakeLists.txt:
• PlatformWin.cmake:

Generate and include a stub WebCoreHeaderDetection.h.

Source/WTF:

• wtf/CMakeLists.txt:
• wtf/PlatformWin.cmake:

Generate and include a stub WTFHeaderDetection.h.

3:42 PM Changeset in webkit [172498] by timothy_horton@apple.com

• 2 edits in trunk/Source/WebKit2

REGRESSION (r172424): Extra menu header in combined telephone number menu when no phone paired
​https://bugs.webkit.org/show_bug.cgi?id=135854
<rdar://problem/17996339>

Reviewed by Enrica Casucci.

• UIProcess/mac/WebContextMenuProxyMac.mm:

(WebKit::WebContextMenuProxyMac::setupServicesMenu):
Get all the menu items ahead of time, and only add the shared header
if there are any telephone number menu items.

3:32 PM Changeset in webkit [172497] by enrica@apple.com

• 2 edits in trunk/Source/WebKit2

Crash at com.apple.WebKit.WebContent at com.apple.WebKit: WebKit::expandForGap
​https://bugs.webkit.org/show_bug.cgi?id=135859
<rdar://problem/17994679>

Reviewed by Tim Horton.

expandForGap made the assumption that the selection rects were always three.
This was not true even before ​http://trac.webkit.org/changeset/172395 but
was more likely to happen after that change.

• WebProcess/WebPage/mac/ServicesOverlayController.mm:

(WebKit::expandForGap):

3:30 PM Changeset in webkit [172496] by commit-queue@webkit.org

• 3 edits
  2 adds in trunk

Make sure that begin time cannot be greater than SMILTime::indefiniteValue unintentionally.
​https://bugs.webkit.org/show_bug.cgi?id=135838

Patch by Renata Hodovan <​rhodovan.u-szeged@partner.samsung.com> on 2014-08-12
Reviewed by Darin Adler.

Source/WebCore:

When WebCore::SVGSMILElement::resolveInterval creates a SMILTime begin
node for a SMILInterval, then it only checks if the value of begin is
indefinite or unresolved but misses the case if it is between these two
reference values.

This is a backport of my fix in Blink: ​https://codereview.chromium.org/406263002/.

Test: svg/animations/animateMotion-crash-with-large-begin-time.html

• svg/animation/SVGSMILElement.cpp:

(WebCore::SVGSMILElement::parseOffsetValue):
(WebCore::SVGSMILElement::parseClockValue):

LayoutTests:

• svg/animations/animateMotion-crash-with-large-begin-time-expected.txt: Added.
• svg/animations/animateMotion-crash-with-large-begin-time.html: Added.

2:59 PM Changeset in webkit [172495] by aestes@apple.com

• 2 edits in trunk/Source/WebCore

Revert a change that wasn't meant to be a part of r172482.

• loader/ResourceLoader.cpp:

(WebCore::ResourceLoader::init):

2:31 PM Changeset in webkit [172494] by Antti Koivisto

• 5 edits in trunk

Don't recurse into non-rendered subtrees when computing style
​https://bugs.webkit.org/show_bug.cgi?id=135844

Reviewed by Andreas Kling.
Source/WebCore:

• style/StyleResolveTree.cpp:

(WebCore::Style::resetStyleForNonRenderedDescendants):

Do a simple reset of the style dirty bits and any computed style in non-rendered subtrees.

(WebCore::Style::attachRenderTree):
(WebCore::Style::resolveTree):

Don't recurse into descendants if the element does not create a renderer.
We didn't compute style anyway in such subtrees.

LayoutTests:

Rebase.

• http/tests/security/video-poster-cross-origin-crash-expected.txt:
• platform/mac/fast/ruby/ruby-base-merge-block-children-crash-2-expected.txt:

1:58 PM Changeset in webkit [172493] by matthew_hanson@apple.com

• 2 edits in tags/Safari-600.1.9/Source/WebKit2

Rollout 172395. <rdar://problem/17837670>

1:56 PM Changeset in webkit [172492] by matthew_hanson@apple.com

• 2 edits in branches/safari-600.1-branch/Source/WebKit2

Rollout172395. <rdar://problem/17837670>

1:53 PM Changeset in webkit [172491] by Yusuke Suzuki

• 2 edits in trunk/Tools

[GTK] Adds dependency for GnuTLS 3.0+ explicitly in gtk/install-dependencies
​https://bugs.webkit.org/show_bug.cgi?id=135850

Reviewed by Philippe Normand.

After r172433, GTK port requires GnuTLS 3.0+. In this time, libgnutls-dev is 2.x in
Ubuntu(trusty) and Debian(sid). So added libgnutls28-dev explicitly.

• gtk/install-dependencies:

1:48 PM Changeset in webkit [172490] by matthew_hanson@apple.com

• 3 edits
  1 copy in tags/Safari-600.1.9

Merge r171903. <rdar://problem/17885078>

1:46 PM Changeset in webkit [172489] by matthew_hanson@apple.com

• 3 edits
  1 copy in branches/safari-600.1-branch

Merge r171903. <rdar://problem/17885078>

1:43 PM Changeset in webkit [172488] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Timeline selection range creation does not work when clicking event bubble or near bottom of overview
​https://bugs.webkit.org/show_bug.cgi?id=135849

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-08-12
Reviewed by Timothy Hatcher.

Click events on elements in the graph container (event bubbles) or
in the scroll container (bottom 16px) were becoming the event targets.
As siblings of the ruler, the dispatch would not go through the ruler.
The ruler was supposed to be overlaying everything in the overview,
so give the ruler a z-index so it really is overlaying elements.

• UserInterface/Views/TimelineRuler.css:

(.timeline-ruler):

1:37 PM Changeset in webkit [172487] by Antti Koivisto

• 9 edits in trunk/Source/WebCore

Remove isInCanvasSubtree bit
​https://bugs.webkit.org/show_bug.cgi?id=135837

Reviewed by Andreas Kling.

The logic to update this bit is in a wrong place and it is not clear it does
the right thing in all cases. Also the optimization doesn't seem necessary,
the focus code is not that hot.

• accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::getOrCreate):

• dom/Element.cpp:

(WebCore::Element::isFocusable):
(WebCore::Element::clearStyleDerivedDataBeforeDetachingRenderer):
(WebCore::Element::setIsInCanvasSubtree): Deleted.
(WebCore::Element::isInCanvasSubtree): Deleted.

• dom/Element.h:
• dom/ElementRareData.h:

(WebCore::ElementRareData::ElementRareData):
(WebCore::ElementRareData::isInCanvasSubtree): Deleted.
(WebCore::ElementRareData::setIsInCanvasSubtree): Deleted.

• html/HTMLAnchorElement.cpp:

(WebCore::HTMLAnchorElement::isKeyboardFocusable):

• html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::HTMLCanvasElement):
(WebCore::HTMLCanvasElement::willAttachRenderers): Deleted.

• html/HTMLCanvasElement.h:
• style/StyleResolveTree.cpp:

(WebCore::Style::attachRenderTree):

1:29 PM Changeset in webkit [172486] by matthew_hanson@apple.com

• 5 edits in branches/safari-600.1-branch/Source

Versioning.

1:16 PM Changeset in webkit [172485] by matthew_hanson@apple.com

• 1 copy in tags/Safari-600.1.9

New Tag.

1:03 PM Changeset in webkit [172484] by timothy_horton@apple.com

• 3 edits in trunk/Source/WebKit2

Don't show the combined menu if there are no services available
​https://bugs.webkit.org/show_bug.cgi?id=135846
<rdar://problem/17582099>

Reviewed by Enrica Casucci.

• WebProcess/WebPage/ServicesOverlayController.h:

Add a FIXME.

• WebProcess/WebPage/mac/ServicesOverlayController.mm:

(WebKit::ServicesOverlayController::determineActiveHighlight):
Don't allow a selection Highlight to become active if there is no
service available to handle it. Previously we showed the combined menu
with just phone numbers in it if any were detected.

12:31 PM Changeset in webkit [172483] by timothy_horton@apple.com

• 7 edits in trunk/Source/WebKit2

Add a fade transition to services highlights
​https://bugs.webkit.org/show_bug.cgi?id=135829
<rdar://problem/17935736>

Reviewed by Enrica Casucci.

Add a smooth fade to highlight installation and uninstallation.
To do so, we make each highlight paint into its own small layer.

• WebProcess/WebPage/PageOverlay.cpp:

(WebKit::PageOverlay::layer):

• WebProcess/WebPage/PageOverlay.h:
• WebProcess/WebPage/PageOverlayController.cpp:

(WebKit::PageOverlayController::layerForOverlay):

• WebProcess/WebPage/PageOverlayController.h:

Expose the GraphicsLayer on PageOverlay.

• WebProcess/WebPage/ServicesOverlayController.h:

(WebKit::ServicesOverlayController::Highlight::layer):
(WebKit::ServicesOverlayController::activeHighlight):
(WebKit::ServicesOverlayController::webPage):
(WebKit::ServicesOverlayController::Highlight::Highlight): Deleted.

• WebProcess/WebPage/mac/ServicesOverlayController.mm:

(WebKit::ServicesOverlayController::Highlight::createForSelection):
(WebKit::ServicesOverlayController::Highlight::createForTelephoneNumber):
(WebKit::ServicesOverlayController::Highlight::Highlight):
Highlights now own a GraphicsLayer, which are later installed
as sublayers of the ServicesOverlayController's PageOverlay layer.
These layers are sized and positioned according to the DDHighlight's bounds.

(WebKit::ServicesOverlayController::Highlight::~Highlight):
(WebKit::ServicesOverlayController::Highlight::invalidate):
ServicesOverlayController will invalidate any remaining highlights
when it is torn down, so they can clear their backpointers.

(WebKit::ServicesOverlayController::Highlight::notifyFlushRequired):
Forward flush notifications to the DrawingArea.

(WebKit::ServicesOverlayController::Highlight::paintContents):
Paint the DDHighlight into the layer. Translation is done by the layer position,
so we zero the bounds origin when painting.

(WebKit::ServicesOverlayController::Highlight::deviceScaleFactor):
Forward the deviceScaleFactor so that things are painted at the right scale.

(WebKit::ServicesOverlayController::Highlight::fadeIn):
(WebKit::ServicesOverlayController::Highlight::fadeOut):
Apply a fade animation to the layer.

(WebKit::ServicesOverlayController::Highlight::didFinishFadeOutAnimation):
When the fade completes, unparent the layer, unless it has become active again.

(WebKit::ServicesOverlayController::ServicesOverlayController):
(WebKit::ServicesOverlayController::~ServicesOverlayController):
Invalidate all highlights, so they can clear their backpointers.

(WebKit::ServicesOverlayController::remainingTimeUntilHighlightShouldBeShown):
Make remainingTimeUntilHighlightShouldBeShown act upon a particular highlight
instead of always the active highlight.

(WebKit::ServicesOverlayController::determineActiveHighlightTimerFired): Rename.

(WebKit::ServicesOverlayController::drawRect):
drawRect is no longer called and will no longer do anything; all of the
painting is done in sublayers.

(WebKit::ServicesOverlayController::buildPhoneNumberHighlights):
Ensure that phone number Highlights stay stable even while the selection
changes, by comparing the underlying Ranges and keeping around old Highlights
that match the new ones. This enables us to e.g. fade in while changing
the selection within a phone number.

(WebKit::ServicesOverlayController::buildSelectionHighlight):
(WebKit::ServicesOverlayController::didRebuildPotentialHighlights):
(WebKit::ServicesOverlayController::createOverlayIfNeeded):
Don't call setNeedsDisplay; the overlay doesn't have backing store.
Instead, call determineActiveHighlight, which will install/uninstall
highlights as necessary.

(WebKit::ServicesOverlayController::determineActiveHighlight):
Apply fade in/fade out to the overlays.
Keep track of which highlight we're going to activate, until the hysteresis
delay is up, then actually make it active/parent it/fade it in.
We now will have no active highlight between the fade out of the previous one
and the fade in of the new one (during the hysteresis delay).

(WebKit::ServicesOverlayController::mouseEvent):
The overlay now will not become active until the delay is up, so we don't
need to check it again here.

(WebKit::ServicesOverlayController::handleClick):
(WebKit::ServicesOverlayController::didCreateHighlight):
(WebKit::ServicesOverlayController::willDestroyHighlight):
(WebKit::ServicesOverlayController::repaintHighlightTimerFired): Deleted.
(WebKit::ServicesOverlayController::drawHighlight): Deleted.

12:12 PM Changeset in webkit [172482] by aestes@apple.com

• 26 edits
  8 deletes in trunk/Source

[iOS] Get rid of iOS.xcconfig
​https://bugs.webkit.org/show_bug.cgi?id=135809

Reviewed by Joseph Pecoraro.

All iOS.xcconfig did was include AspenFamily.xcconfig, so there's no need for the indirection.

Source/bmalloc:

• Configurations/Base.xcconfig:
• Configurations/iOS.xcconfig: Removed.
• bmalloc.xcodeproj/project.pbxproj:

Source/JavaScriptCore:

• Configurations/Base.xcconfig:
• Configurations/iOS.xcconfig: Removed.
• JavaScriptCore.xcodeproj/project.pbxproj:

Source/ThirdParty:

• gtest/xcode/Config/General.xcconfig:
• gtest/xcode/Config/iOS.xcconfig: Removed.
• gtest/xcode/gtest.xcodeproj/project.pbxproj:

Source/ThirdParty/ANGLE:

• ANGLE.xcodeproj/project.pbxproj:
• Configurations/Base.xcconfig:
• Configurations/iOS.xcconfig: Removed.

Source/WebCore:

• Configurations/Base.xcconfig:
• Configurations/iOS.xcconfig: Removed.
• WebCore.xcodeproj/project.pbxproj:

Source/WebKit:

• WebKit.xcodeproj/project.pbxproj:

Source/WebKit/mac:

• Configurations/Base.xcconfig:
• Configurations/iOS.xcconfig: Removed.

Source/WebKit2:

• Configurations/Base.xcconfig:
• Configurations/iOS.xcconfig: Removed.
• WebKit2.xcodeproj/project.pbxproj:

Source/WTF:

• Configurations/Base.xcconfig:
• Configurations/iOS.xcconfig: Removed.
• WTF.xcodeproj/project.pbxproj:

11:52 AM Changeset in webkit [172481] by roger_fong@apple.com

• 3 edits in trunk/Source/WebCore

Adjust max-width of cues based on text alignment when cue size is expanded.
​https://bugs.webkit.org/show_bug.cgi?id=135823.

Reviewed by Brent Fulgham.

All units are in percentages.
If we are left aligned the max cue width is the 100 minus the cue position.
If we are right aligned the max cue width is the cue position.
If we are centered the max cue width is just 100.

• html/track/TextTrackCueGeneric.cpp:

(WebCore::TextTrackCueGenericBoxElement::applyCSSProperties):

• html/track/VTTCue.cpp:

(WebCore::VTTCueBox::applyCSSProperties):

10:50 AM Changeset in webkit [172480] by Lucas Forschler

• 3 edits
  1 delete in tags/Safari-600.1.8.1/Source/WebCore

Rollout r172278. <rdar://problem/17981175>

10:47 AM Changeset in webkit [172479] by Lucas Forschler

• 5 edits in tags/Safari-600.1.8.1/Source

Versioning.

10:38 AM Changeset in webkit [172478] by Lucas Forschler

• 1 copy in tags/Safari-600.1.8.1

New Tag.

10:34 AM Changeset in webkit [172477] by Lucas Forschler

• 2 edits
  1 delete in branches/safari-600.1-branch/Source/WebInspectorUI

Merged r172436. <rdar://problem/17987726>

10:32 AM Changeset in webkit [172476] by Lucas Forschler

• 10 edits in branches/safari-600.1-branch/Source/WebInspectorUI

Merged r172435. <rdar://problem/17987681>

10:29 AM Changeset in webkit [172475] by Lucas Forschler

• 2 edits in branches/safari-600.1-branch/Source/WebInspectorUI

Merged r172432. <rdar://problem/16709018>

10:17 AM Changeset in webkit [172474] by Lucas Forschler

• 2 edits in branches/safari-600.1-branch/Source/WebCore

Merged r172471. <rdar://problem/17990895>

10:11 AM Changeset in webkit [172473] by Lucas Forschler

• 3 edits
  1 delete in branches/safari-600.1-branch/Source/WebCore

Merged r172399. <rdar://problem/17971237>

9:32 AM Changeset in webkit [172472] by commit-queue@webkit.org

• 3 edits
  2 adds in trunk

[GStreamer] playback rate is rounded to integer
​https://bugs.webkit.org/show_bug.cgi?id=135802

Patch by Fabien Vallée <​fvallee@connected-labs.com> on 2014-08-12
Reviewed by Philippe Normand.

Source/WebCore:

Test: media/video-ended-event-slow-motion-playback.html

• platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::setRate):

LayoutTests:

add test to ensure playback is actually working
in slow motion (playback rate = 0.5): Player
should reach EOS and dispatch ended event.

• media/video-ended-event-slow-motion-playback-expected.txt: Added.
• media/video-ended-event-slow-motion-playback.html: Added.

9:06 AM Changeset in webkit [172471] by Brent Fulgham

• 2 edits in trunk/Source/WebCore

[Win] Unreviewed build fix after r17425

• platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.h: Remove

unused 'currentTime' declaration from header file. This is now fully implemented
in platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h.

8:06 AM Changeset in webkit [172470] by Lucas Forschler

• 26 edits in branches/safari-600.1-branch/Source/WebInspectorUI

Merged r172399. <rdar://problem/17971237>

8:03 AM Changeset in webkit [172469] by Lucas Forschler

• 12 edits
  3 deletes in branches/safari-600.1-branch/Source

Merged r172379. <rdar://problem/17955579>

7:25 AM Changeset in webkit [172468] by Lucas Forschler

• 9 edits in branches/safari-600.1-branch

Merged r172425. <rdar://problem/17476923>

7:22 AM Changeset in webkit [172467] by Lucas Forschler

• 6 edits in branches/safari-600.1-branch/Source

Merged r172424. <rdar://problem/17936880>

7:20 AM Changeset in webkit [172466] by Lucas Forschler

• 2 edits in branches/safari-600.1-branch/Source/WebCore

Merged r172428. <rdar://problem/17912361>

7:18 AM Changeset in webkit [172465] by Lucas Forschler

• 6 edits in branches/safari-600.1-branch/Source/WebCore

Merged r172422. <rdar://problem/17912361>

7:11 AM Changeset in webkit [172464] by Lucas Forschler

• 4 edits in branches/safari-600.1-branch/Source/WebCore

Merged r172421. <rdar://problem/17961164>

7:06 AM Changeset in webkit [172463] by Lucas Forschler

• 4 edits
  7 copies in branches/safari-600.1-branch

Merged r172417. <rdar://problem/17848141>

7:04 AM Changeset in webkit [172462] by Lucas Forschler

• 3 edits in branches/safari-600.1-branch/Source/WebKit2

Merged r172406. <rdar://problem/17981554>

7:01 AM Changeset in webkit [172461] by Lucas Forschler

• 3 edits in branches/safari-600.1-branch/Source/WebCore

Merged r172404. <rdar://problem/17979844>

6:58 AM Changeset in webkit [172460] by Lucas Forschler

• 8 edits in branches/safari-600.1-branch/Source

Merged r172397. <rdar://problem/17983299>

6:56 AM Changeset in webkit [172459] by Lucas Forschler

• 1 edit
  1 copy in branches/safari-600.1-branch/Source/WebInspectorUI

Merged r172262. <rdar://problem/17983299>

6:51 AM Changeset in webkit [172458] by Lucas Forschler

• 2 edits in branches/safari-600.1-branch/Source/WebKit2

Merged r172395. <rdar://problem/17837670>

6:43 AM Changeset in webkit [172457] by Lucas Forschler

• 3 edits in branches/safari-600.1-branch/Source/WebKit2

Merged r172374. <rdar://problem/17969843>

6:42 AM Changeset in webkit [172456] by Lucas Forschler

• 3 edits
  2 copies in branches/safari-600.1-branch

Merged r172373. <rdar://problem/17952364>

6:40 AM Changeset in webkit [172455] by Lucas Forschler

• 2 edits in branches/safari-600.1-branch/Source/WebKit2

Merged r172369. <rdar://problem/17533459>

6:38 AM Changeset in webkit [172454] by Lucas Forschler

• 6 edits in branches/safari-600.1-branch/Source/WebKit2

Merged r172366. <rdar://problem/17533459>

6:36 AM Changeset in webkit [172453] by Lucas Forschler

• 3 edits
  3 copies in branches/safari-600.1-branch

Merged r172365. <rdar://problem/17959896>

6:32 AM Changeset in webkit [172452] by Lucas Forschler

• 2 edits in branches/safari-600.1-branch/Source/WebKit2

Merged r172364. <rdar://problem/17962180>

6:30 AM Changeset in webkit [172451] by Lucas Forschler

• 5 edits in branches/safari-600.1-branch

Merged r172351. <rdar://problem/17961164>

6:25 AM Changeset in webkit [172450] by Lucas Forschler

• 2 edits in branches/safari-600.1-branch/Source/WebKit2

Merged r172344. <rdar://problem/17907752>

6:23 AM Changeset in webkit [172449] by Lucas Forschler

• 2 edits in branches/safari-600.1-branch/Source/WebKit2

Merged r172343. <rdar://problem/17933167>

6:22 AM Changeset in webkit [172448] by Lucas Forschler

• 2 edits in branches/safari-600.1-branch/Source/WebInspectorUI

Merged r172336. <rdar://problem/17955491>

6:20 AM Changeset in webkit [172447] by Lucas Forschler

• 2 edits in branches/safari-600.1-branch/Source/WebInspectorUI

Merged r172333. <rdar://problem/17955768>

6:15 AM Changeset in webkit [172446] by Lucas Forschler

• 8 edits in branches/safari-600.1-branch/Source

Merged r172235. <rdar://problem/17388461>

5:07 AM Changeset in webkit [172445] by g.czajkowski@samsung.com

• 4 edits
  1 move in trunk/Source/WebKit2

[EFL] Rename ewk_private.h to EwkDebug.h
​https://bugs.webkit.org/show_bug.cgi?id=135797

Reviewed by Gyuyoung Kim.

ewk_private.h contains only debug macros alllowing
logging.

• UIProcess/API/efl/EwkView.cpp:
• UIProcess/API/efl/ewk_main.cpp:
• UIProcess/efl/EwkDebug.h: Renamed from Source/WebKit2/UIProcess/API/efl/ewk_private.h.
• UIProcess/efl/ViewClientEfl.cpp:

4:42 AM Changeset in webkit [172444] by Carlos Garcia Campos

• 2 edits in releases/WebKitGTK/webkit-2.2/Source/WebKit2

Merge r172442 - [GTK] The plugins metadata cache doesn't work if the user cache directory doesn't exist
​https://bugs.webkit.org/show_bug.cgi?id=135834

Reviewed by Philippe Normand.

Make sure the user cache directory exists. If creating the
directory fails for whatever reason, do not try to save the cache
to disk.

• UIProcess/Plugins/gtk/PluginInfoCache.cpp:

(WebKit::PluginInfoCache::PluginInfoCache):
(WebKit::PluginInfoCache::updatePluginInfo):

4:29 AM Changeset in webkit [172443] by zandobersek@gmail.com

• 2 edits in trunk/Source/WebCore

Dont allocate GCond in VideoSinkGStreamer.cpp dynamically.

Rubber-stamped by Carlos Garcia Campos.

• platform/graphics/gstreamer/VideoSinkGStreamer.cpp:

(_WebKitVideoSinkPrivate::_WebKitVideoSinkPrivate): Move the
g_cond_init() and gst_video_info_init() calls here.
(_WebKitVideoSinkPrivate::~_WebKitVideoSinkPrivate): Move the
g_cond_clear() call here.
(webkit_video_sink_init):
(webkitVideoSinkTimeoutCallback):
(webkitVideoSinkRender):
(unlockBufferMutex):
(webkit_video_sink_class_init):
(webkitVideoSinkDispose): Deleted. Not required anymore.

3:55 AM Changeset in webkit [172442] by Carlos Garcia Campos

• 2 edits in trunk/Source/WebKit2

[GTK] The plugins metadata cache doesn't work if the user cache directory doesn't exist
​https://bugs.webkit.org/show_bug.cgi?id=135834

Reviewed by Philippe Normand.

Make sure the user cache directory exists. If creating the
directory fails for whatever reason, do not try to save the cache
to disk.

• UIProcess/Plugins/gtk/PluginInfoCache.cpp:

(WebKit::PluginInfoCache::PluginInfoCache):
(WebKit::PluginInfoCache::updatePluginInfo):

3:39 AM Changeset in webkit [172441] by zandobersek@gmail.com

• 7 edits in trunk/Source

Clean up GMutexLocker
​https://bugs.webkit.org/show_bug.cgi?id=135833

Reviewed by Carlos Garcia Campos.

Source/WebCore:

Don't dynamically allocate GMutex objects. Update GMutexLocker
initializations to pass in a GMutex reference, not a pointer.

• platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:

(WebCore::MediaPlayerPrivateGStreamerBase::MediaPlayerPrivateGStreamerBase):
(WebCore::MediaPlayerPrivateGStreamerBase::~MediaPlayerPrivateGStreamerBase):

• platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:
• platform/graphics/gstreamer/VideoSinkGStreamer.cpp:

(_WebKitVideoSinkPrivate::_WebKitVideoSinkPrivate): Initialize the GMutex.
(_WebKitVideoSinkPrivate::~_WebKitVideoSinkPrivate): Clear the GMutex.
(webkit_video_sink_init):
(webkitVideoSinkRender):
(webkitVideoSinkDispose):

• platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:

(webKitWebSrcGetProperty):
(webKitWebSrcStop):
(webKitWebSrcStart):
(webKitWebSrcChangeState):
(webKitWebSrcQueryWithParent):
(webKitWebSrcGetUri):
(webKitWebSrcSetUri):
(webKitWebSrcNeedDataMainCb):
(webKitWebSrcNeedDataCb):
(webKitWebSrcEnoughDataMainCb):
(webKitWebSrcEnoughDataCb):
(webKitWebSrcSeekDataCb):
(webKitWebSrcSetMediaPlayer):
(StreamingClient::createReadBuffer):
(StreamingClient::handleResponseReceived):
(StreamingClient::handleDataReceived):
(StreamingClient::handleNotifyFinished):
(ResourceHandleStreamingClient::wasBlocked):
(ResourceHandleStreamingClient::cannotShowURL):

Source/WTF:

Place the GMutexLocker into the WTF namespace. There's no need for this
class to use FastMalloc since it's always allocated on the stack. The
constructor and class now operate on a GMutex reference. There's little
need for an additional inline specifier for methods defined in the header.
The mutex() method is removed as it was not used. m_val is renamed to a
more descriptive m_locked and is made a boolean.

• wtf/gobject/GMutexLocker.h:

(WTF::GMutexLocker::GMutexLocker):
(WTF::GMutexLocker::~GMutexLocker):
(WTF::GMutexLocker::lock):
(WTF::GMutexLocker::unlock):
(WebCore::GMutexLocker::GMutexLocker): Deleted.
(WebCore::GMutexLocker::~GMutexLocker): Deleted.
(WebCore::GMutexLocker::lock): Deleted.
(WebCore::GMutexLocker::unlock): Deleted.
(WebCore::GMutexLocker::mutex): Deleted.

3:36 AM Changeset in webkit [172440] by zandobersek@gmail.com

• 2 edits in trunk/Source/WTF

Make GRefPtr move-able
​https://bugs.webkit.org/show_bug.cgi?id=135801

Reviewed by Carlos Garcia Campos.

Add move constructor and move assignment operator for GRefPtr.

• wtf/gobject/GRefPtr.h:

(WTF::GRefPtr::GRefPtr):
(WTF::=):

2:35 AM Changeset in webkit [172439] by commit-queue@webkit.org

• 4 edits in trunk

[GTK] Subtle-crypto feature off by default and add a new configure flag to enable it
​https://bugs.webkit.org/show_bug.cgi?id=135798

Patch by Eduardo Lima Mitev <​elima@igalia.com> on 2014-08-12
Reviewed by Philippe Normand.

.:

• Source/cmake/OptionsGTK.cmake: Makes SUBTLE_CRYPTO flag off by default.

Tools:

• Scripts/webkitperl/FeatureList.pm: Adds new flag --subtle-crypto to

toggle SUBTLE_CRYPTO feature.

1:25 AM Changeset in webkit [172438] by ryuan.choi@samsung.com

• 2 edits
  1 add in trunk/Tools

[EFL] Disable ecore logs about bad fd
​https://bugs.webkit.org/show_bug.cgi?id=135831

Reviewed by Gyuyoung Kim.

ecore checks EBADF and prints the warnings.
But, it looks noise in layout test because it's not webkit issue.
This patch disables it until we found right solution.

• efl/jhbuild.modules:
• efl/patches/ecore_remove_warnings.patch: Added.

1:22 AM Changeset in webkit [172437] by commit-queue@webkit.org

• 2 edits in trunk/Tools

[EFL][WK2] Minibrowser: Enhance the application to use download directory selector.
​https://bugs.webkit.org/show_bug.cgi?id=135791

Patch by Shivakumar JM <​shiva.jm@samsung.com> on 2014-08-12
Reviewed by Gyuyoung Kim.

Currently Minibrowser stores the downloaded files to /tmp directory, add support so that destination folder can be selected by the
user.

• MiniBrowser/efl/main.c:

(on_download_request):

1:16 AM Changeset in webkit [172436] by commit-queue@webkit.org

• 2 edits
  1 delete in trunk/Source/WebInspectorUI

Web Inspector: GoToLine dialog clear text button looks poor
​https://bugs.webkit.org/show_bug.cgi?id=135828

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-08-12
Reviewed by Timothy Hatcher.

Legacy/CloseWhite.svg was not used, but in the case where the white
close button is needed the thicker bars looks better. Re-use the
Legacy image as the default CloseWhite.svg.

• UserInterface/Images/CloseWhite.svg:
• UserInterface/Images/Legacy/CloseWhite.svg: Removed.

1:12 AM Changeset in webkit [172435] by commit-queue@webkit.org

• 10 edits in trunk/Source/WebInspectorUI

Web Inspector: Easier Way to go back to the Timeline Overviews
​https://bugs.webkit.org/show_bug.cgi?id=135827

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-08-12
Reviewed by Timothy Hatcher.

• Localizations/en.lproj/localizedStrings.js:

Added new tooltip UIString.

• UserInterface/Images/Close.svg:
• UserInterface/Images/CloseLarge.svg:
• UserInterface/Images/Legacy/Close.svg:

Add "stroked" class so the buttons can fill with white on selected rows.
Also re-center the non-legacy images horizontally.

• UserInterface/Views/GeneralTreeElement.js:

(WebInspector.GeneralTreeElement.prototype.set status):
Do not recreate elements if the status did not change.

• UserInterface/Views/LayoutTimelineView.js:

(WebInspector.LayoutTimelineView):
(WebInspector.LayoutTimelineView.prototype._treeElementDeselected):
(WebInspector.LayoutTimelineView.prototype._treeElementSelected):
(WebInspector.LayoutTimelineView.prototype._updateTreeElementWithCloseButton):
(WebInspector.LayoutTimelineView.prototype._closeStatusButtonClicked):

• UserInterface/Views/NetworkTimelineView.js:

(WebInspector.NetworkTimelineView):
(WebInspector.NetworkTimelineView.prototype._treeElementDeselected):
(WebInspector.NetworkTimelineView.prototype._treeElementSelected):
(WebInspector.NetworkTimelineView.prototype._updateTreeElementWithCloseButton):
(WebInspector.NetworkTimelineView.prototype._closeStatusButtonClicked):

• UserInterface/Views/OverviewTimelineView.js:

(WebInspector.OverviewTimelineView.prototype._treeElementDeselected):
(WebInspector.OverviewTimelineView.prototype._treeElementSelected):
(WebInspector.OverviewTimelineView.prototype._updateTreeElementWithCloseButton):
(WebInspector.OverviewTimelineView.prototype._closeStatusButtonClicked):

• UserInterface/Views/ScriptTimelineView.js:

(WebInspector.ScriptTimelineView):
(WebInspector.ScriptTimelineView.prototype._treeElementDeselected):
(WebInspector.ScriptTimelineView.prototype._treeElementSelected):
(WebInspector.ScriptTimelineView.prototype._updateTreeElementWithCloseButton):
(WebInspector.ScriptTimelineView.prototype._closeStatusButtonClicked):
Provide select/deselect handlers to show/hide the close status bar button
when selecting a row that shows a non-Timeline content view. Currently the
only content views the tree elements can show are Resource views, so the
tooltip is the same everywhere.

1:06 AM Changeset in webkit [172434] by ap@apple.com

• 2 edits in trunk/Source/WebKit2

[Mac] Allow reading CoreGraphics debugging preferences
​https://bugs.webkit.org/show_bug.cgi?id=135821
<rdar://problem/11219259>

Reviewed by Darin Adler.

• WebProcess/com.apple.WebProcess.sb.in:

1:03 AM Changeset in webkit [172433] by commit-queue@webkit.org

• 4 edits in trunk

[GTK] Adds dependency on GnuTLS 3.0+ for the implementation of subtle crypto algorithms
​https://bugs.webkit.org/show_bug.cgi?id=133317

.:

GnuTLS is already an indirect dependency through libsoup -> glib-networking.

Patch by Eduardo Lima Mitev <​elima@igalia.com> on 2014-08-12
Reviewed by Philippe Normand.

No new tests since no new functionality has been added.

• Source/cmake/OptionsGTK.cmake: Adds search for required GnuTLS package

Source/WebCore:

Patch by Eduardo Lima Mitev <​elima@igalia.com> on 2014-08-12
Reviewed by Philippe Normand.

No new tests since no new functionality has been added.

• PlatformGTK.cmake: Adds GnuTLS libs and included dirs to WebCore targets

12:56 AM Changeset in webkit [172432] by timothy@apple.com

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Expect to see top level JavaScript function profiler details for event handlers in timeline
​https://bugs.webkit.org/show_bug.cgi?id=132109

Reviewed by Joseph Pecoraro.

• UserInterface/Views/ScriptTimelineView.js:

(WebInspector.ScriptTimelineView.prototype._processPendingRecords): Don't promote root node children if
there is only one child.

12:49 AM Changeset in webkit [172431] by Philippe Normand

• 9 edits
  2 deletes in trunk/Source/WebCore

[WebAudio] FFTFrame is cluttered with dead code
​https://bugs.webkit.org/show_bug.cgi?id=135751

Reviewed by Eric Carlson.

Cleaned up unused FFTFrame implementations from the tree. If the
FFMPEG or IPP versions are needed later on again this patch can be
rolled out.

No new tests, the code removed was disabled on all ports.

• platform/audio/Biquad.cpp:

(WebCore::Biquad::Biquad):
(WebCore::Biquad::~Biquad):
(WebCore::Biquad::process):
(WebCore::Biquad::reset):
(WebCore::Biquad::setNormalizedCoefficients):

• platform/audio/Biquad.h:
• platform/audio/DirectConvolver.cpp:

(WebCore::DirectConvolver::DirectConvolver):
(WebCore::DirectConvolver::process):
(WebCore::DirectConvolver::reset):

• platform/audio/DirectConvolver.h:
• platform/audio/FFTFrame.h:
• platform/audio/FFTFrameStub.cpp:
• platform/audio/ffmpeg/FFTFrameFFMPEG.cpp: Removed.
• platform/audio/ipp/FFTFrameIPP.cpp: Removed.
• platform/audio/mac/FFTFrameMac.cpp:

12:42 AM Changeset in webkit [172430] by g.czajkowski@samsung.com

• 6 edits
  1 add in trunk

[EFL] Prevent the client from creating ewk_view when EWebkit is not initialized
​https://bugs.webkit.org/show_bug.cgi?id=135606

Reviewed by Gyuyoung Kim.

Source/WebKit2:

Similarly to EFL modules (eina, evas etc.), application using EWebKit
has to initialize it using ewk_init().

Do not allow the client to create ewk_view if ewk_init has not been called.
Add an appropriate logs warning the client about wrong APIs usage.

• UIProcess/API/efl/ewk_main.cpp: Add EwkMain class to control ewk lifetime.

(WebKit::EwkMain::EwkMain):
(WebKit::EwkMain::shared):
(WebKit::EwkMain::~EwkMain): Add logs when the client forgot to destroy EWebkit.
(WebKit::EwkMain::initialize):
(WebKit::EwkMain::finalize):
(WebKit::EwkMain::shutdownInitializedEFLModules):
(ewk_init):
(ewk_shutdown):

• UIProcess/API/efl/ewk_main_private.h: Added.

(WebKit::EwkMain::isInitialized):
(WebKit::EwkMain::logDomainId):

• UIProcess/API/efl/ewk_private.h:
• UIProcess/API/efl/ewk_view.cpp:

(EWKViewCreate):
Prevent the client from creating ewk_view when ewk_init() has not been called.

Tools:

TestWebKitAPI does not initialize EWebkit using ewk_init()
which is not recommended.

• TestWebKitAPI/efl/PlatformWebView.cpp:

(TestWebKitAPI::createEcoreEvas):
Renamed from initEcoreEvas() since it doesn't not initialize
ecore evas.

(TestWebKitAPI::PlatformWebView::PlatformWebView):
Call ewk_init() that initalizes all EFL modules needed by EWebKit
instead of ecore_evas_init() only.

(TestWebKitAPI::PlatformWebView::~PlatformWebView):
Call ewk_shutdown() to finalize EWebkit.
(TestWebKitAPI::initEcoreEvas): Deleted.