Timeline
Aug 18, 2014:
- 11:12 PM Changeset in webkit [172745] by
-
- 3 edits in branches/safari-600.1.4.11-branch/Source/WebCore
Merged r172317. <rdar://problem/18052514>
- 10:10 PM Changeset in webkit [172744] by
-
- 31 edits3 adds in trunk/Source
Unreviewed, rolling out r172736.
https://bugs.webkit.org/show_bug.cgi?id=136060
Caused 14% PLT regressions (Requested by rniwa on #webkit).
Reverted changeset:
"Remove PurgeableBuffer since it is not very useful any more"
https://bugs.webkit.org/show_bug.cgi?id=135939
http://trac.webkit.org/changeset/172736
- 10:04 PM Changeset in webkit [172743] by
-
- 5 edits in branches/safari-600.1-branch/Source
Bump versioning
- 9:41 PM Changeset in webkit [172742] by
-
- 4 edits3 deletes in trunk/Source/JavaScriptCore
Unreviewed, rolling out r172741.
https://bugs.webkit.org/show_bug.cgi?id=136058
This change is breaking PLT. (Requested by mlam on #webkit).
Reverted changeset:
"REGRESSION(r172401): for-in optimization no longer works at
all"
https://bugs.webkit.org/show_bug.cgi?id=136056
http://trac.webkit.org/changeset/172741
- 7:48 PM Changeset in webkit [172741] by
-
- 4 edits3 adds in trunk/Source/JavaScriptCore
REGRESSION(r172401): for-in optimization no longer works at all
https://bugs.webkit.org/show_bug.cgi?id=136056
Reviewed by Mark Hahnenberg.
This is a partial roll-out of r172401. It turns out that the fix wasn't actually fixing a
real bug (since it's fine to use op_get_direct_pname on the wrong base because it has a
structure check) and it was actually breaking the entire for-in optimization (since there is
no way that we can statically prove that the base matches, because the base we see is a
newly created temporary, and anyway doing it right would be really hard in our bytecode
because it's 3AC form).
But, I added a new test for the problem, and kept the original test. Both the old test and
the new test prove that r172401 wasn't fixing what it thought it was fixing. To the extent
that it resolved crashes it was because it just disabled the for-in optimization entirely.
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitGetByVal):
(JSC::BytecodeGenerator::pushIndexedForInScope):
(JSC::BytecodeGenerator::pushStructureForInScope):
- bytecompiler/BytecodeGenerator.h:
(JSC::ForInContext::ForInContext):
(JSC::StructureForInContext::StructureForInContext):
(JSC::IndexedForInContext::IndexedForInContext):
(JSC::ForInContext::base): Deleted.
- bytecompiler/NodesCodegen.cpp:
(JSC::ForInNode::emitMultiLoopBytecode):
- tests/stress/for-in-base-reassigned.js: Added.
- tests/stress/for-in-base-reassigned-later.js: Added.
- tests/stress/for-in-base-reassigned-later-and-change-structure.js: Added.
- 7:46 PM Changeset in webkit [172740] by
-
- 2 edits in trunk/LayoutTests
Mark shape-image-threshold-001.html as crashing in debug
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-08-18
The test css3/shapes/shape-outside/values/shape-image-threshold-001.html systematically assert
in debug. Skip the results until the author investigate.
- 7:31 PM Changeset in webkit [172739] by
-
- 4 edits in trunk/Source/JavaScriptCore
Gardening: build fix for non-Mac builds after r172737.
https://bugs.webkit.org/show_bug.cgi?id=135750
Not reviewed.
- CMakeLists.txt:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
- 6:04 PM Changeset in webkit [172738] by
-
- 7 edits in trunk/Source
Provide default implementations of all GraphicsLayerClient methods
https://bugs.webkit.org/show_bug.cgi?id=136054
Reviewed by Tim Horton.
Source/WebCore:
Make none of the functions in GraphicsLayerClient pure virtual, since in many cases
subclasses don't need to provide their own implementations.
- platform/graphics/GraphicsLayerClient.h:
(WebCore::GraphicsLayerClient::notifyAnimationStarted):
(WebCore::GraphicsLayerClient::notifyFlushRequired):
(WebCore::GraphicsLayerClient::paintContents):
- rendering/RenderLayerCompositor.h:
Source/WebKit2:
Remove overrides which are no longer required.
- WebProcess/WebPage/PageOverlayController.h:
- WebProcess/WebPage/ServicesOverlayController.h:
- WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h:
- 5:55 PM Changeset in webkit [172737] by
-
- 15 edits2 moves in trunk/Source/JavaScriptCore
REGRESSION(r172129): ftlopt branch merge made performance tests flakey crash
https://bugs.webkit.org/show_bug.cgi?id=135750
Reviewed by Mark Lam.
This was caused by a rather embarrassing oversight in how the DFG tracks structures: we
could sometimes perform an optimization that requires a structure to be alive but forget to
ensure that the structure is actually kept alive. In particular, any watchpoint-based
optimizations involve setting watchpoints even if the code that got optimized is eventually
deleted because it is unreachable. All such optimizations would leave behind something in
the IR to tell us that we are interested in the structure and that therefore it should be
kept alive. But, IR can be deleted if it is unreachable.
The solution is to ensure that as soon as the DFG is made aware of a structure, it adds it
to the set of weak references.
- JavaScriptCore.xcodeproj/project.pbxproj:
- dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):
- dfg/DFGAbstractValue.cpp:
(JSC::DFG::AbstractValue::setOSREntryValue):
(JSC::DFG::AbstractValue::set):
(JSC::DFG::AbstractValue::normalizeClarity):
(JSC::DFG::AbstractValue::assertIsRegistered):
(JSC::DFG::AbstractValue::assertIsWatched): Deleted.
- dfg/DFGAbstractValue.h:
(JSC::DFG::AbstractValue::assertIsRegistered):
(JSC::DFG::AbstractValue::assertIsWatched): Deleted.
- dfg/DFGCommon.h:
- dfg/DFGConstantFoldingPhase.cpp:
(JSC::DFG::ConstantFoldingPhase::addStructureTransitionCheck):
- dfg/DFGDesiredWeakReferences.cpp:
(JSC::DFG::DesiredWeakReferences::addLazily):
(JSC::DFG::DesiredWeakReferences::contains):
(JSC::DFG::DesiredWeakReferences::reallyAdd):
(JSC::DFG::DesiredWeakReferences::visitChildren):
- dfg/DFGDesiredWeakReferences.h:
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::canOptimizeStringObjectAccess):
- dfg/DFGGraph.cpp:
(JSC::DFG::Graph::Graph):
(JSC::DFG::Graph::registerFrozenValues):
(JSC::DFG::Graph::convertToConstant):
(JSC::DFG::Graph::registerStructure):
(JSC::DFG::Graph::assertIsRegistered):
(JSC::DFG::Graph::assertIsWatched): Deleted.
- dfg/DFGGraph.h:
- dfg/DFGPlan.cpp:
(JSC::DFG::Plan::compileInThreadImpl):
- dfg/DFGStructureAbstractValue.cpp:
(JSC::DFG::StructureAbstractValue::assertIsRegistered):
(JSC::DFG::StructureAbstractValue::assertIsWatched): Deleted.
- dfg/DFGStructureAbstractValue.h:
(JSC::DFG::StructureAbstractValue::assertIsRegistered):
(JSC::DFG::StructureAbstractValue::assertIsWatched): Deleted.
- dfg/DFGStructureRegistrationPhase.cpp: Copied from Source/JavaScriptCore/dfg/DFGWatchableStructureWatchingPhase.cpp.
(JSC::DFG::StructureRegistrationPhase::StructureRegistrationPhase):
(JSC::DFG::StructureRegistrationPhase::run):
(JSC::DFG::StructureRegistrationPhase::registerStructures):
(JSC::DFG::StructureRegistrationPhase::registerStructure):
(JSC::DFG::performStructureRegistration):
(JSC::DFG::WatchableStructureWatchingPhase::WatchableStructureWatchingPhase): Deleted.
(JSC::DFG::WatchableStructureWatchingPhase::run): Deleted.
(JSC::DFG::WatchableStructureWatchingPhase::tryWatch): Deleted.
(JSC::DFG::performWatchableStructureWatching): Deleted.
- dfg/DFGStructureRegistrationPhase.h: Copied from Source/JavaScriptCore/dfg/DFGWatchableStructureWatchingPhase.h.
- dfg/DFGWatchableStructureWatchingPhase.cpp: Removed.
- dfg/DFGWatchableStructureWatchingPhase.h: Removed.
- 4:25 PM Changeset in webkit [172736] by
-
- 31 edits3 deletes in trunk/Source
Remove PurgeableBuffer since it is not very useful any more
https://bugs.webkit.org/show_bug.cgi?id=135939
Reviewed by Geoffrey Garen.
Source/WebCore:
The usefulness of having purgeable memory for cached resources has diminished now that
WebKit uses file backed resources when possible. Since this is read only memory, it is in
essence "purgeable". Having the PurgeableBuffer code adds additional complexity that we
don't need. e.g. on my Mac, I am not seeing any entry for "WebCore purgeable data" when I
run vmmap against the web processes that I have running. It is used on iOS, however even
there much of the purgeable memory we create gets replaced by file backed memory once we get
the notification from CFNetwork.
No new tests because no functional changes.
- WebCore.xcodeproj/project.pbxproj:
- inspector/InspectorPageAgent.cpp:
(WebCore::prepareCachedResourceBuffer):
- loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::subresource):
- loader/ResourceBuffer.cpp:
(WebCore::ResourceBuffer::hasPurgeableBuffer): Deleted.
(WebCore::ResourceBuffer::setShouldUsePurgeableMemory): Deleted.
(WebCore::ResourceBuffer::createPurgeableBuffer): Deleted.
(WebCore::ResourceBuffer::releasePurgeableBuffer): Deleted.
- loader/ResourceBuffer.h:
- loader/SubresourceLoader.cpp:
(WebCore::SubresourceLoader::didFinishLoading):
- loader/cache/CachedCSSStyleSheet.cpp:
(WebCore::CachedCSSStyleSheet::sheetText):
(WebCore::CachedCSSStyleSheet::destroyDecodedData):
- loader/cache/CachedCSSStyleSheet.h:
- loader/cache/CachedImage.cpp:
(WebCore::CachedImage::image):
(WebCore::CachedImage::imageForRenderer):
(WebCore::CachedImage::imageSizeForRenderer):
(WebCore::CachedImage::destroyDecodedData):
(WebCore::CachedImage::canUseDiskImageCache):
- loader/cache/CachedImage.h:
- loader/cache/CachedResource.cpp:
(WebCore::CachedResource::addClientToSet):
(WebCore::CachedResource::isSafeToMakePurgeable): Deleted.
(WebCore::CachedResource::makePurgeable): Deleted.
(WebCore::CachedResource::isPurgeable): Deleted.
(WebCore::CachedResource::wasPurged): Deleted.
- loader/cache/CachedResource.h:
(WebCore::CachedResource::resourceBuffer):
(WebCore::CachedResource::purgePriority): Deleted.
- loader/cache/CachedScript.cpp:
(WebCore::CachedScript::script):
(WebCore::CachedScript::destroyDecodedData):
- loader/cache/CachedScript.h:
- loader/cache/MemoryCache.cpp:
(WebCore::MemoryCache::resourceForRequestImpl):
(WebCore::MemoryCache::pruneDeadResourcesToSize):
(WebCore::MemoryCache::evict):
(WebCore::MemoryCache::TypeStatistic::addResource):
(WebCore::MemoryCache::dumpStats):
(WebCore::MemoryCache::dumpLRULists):
(WebCore::MemoryCache::makeResourcePurgeable): Deleted.
- loader/cache/MemoryCache.h:
(WebCore::MemoryCache::TypeStatistic::TypeStatistic):
(WebCore::MemoryCache::shouldMakeResourcePurgeableOnEviction): Deleted.
- platform/PurgePriority.h: Removed.
- platform/PurgeableBuffer.h: Removed.
- platform/SharedBuffer.cpp:
(WebCore::SharedBuffer::SharedBuffer):
(WebCore::SharedBuffer::size):
(WebCore::SharedBuffer::data):
(WebCore::SharedBuffer::append):
(WebCore::SharedBuffer::clear):
(WebCore::SharedBuffer::copy):
(WebCore::SharedBuffer::getSomeData):
(WebCore::SharedBuffer::adoptPurgeableBuffer): Deleted.
(WebCore::SharedBuffer::createPurgeableBuffer): Deleted.
(WebCore::SharedBuffer::releasePurgeableBuffer): Deleted.
- platform/SharedBuffer.h:
(WebCore::SharedBuffer::hasPurgeableBuffer): Deleted.
(WebCore::SharedBuffer::shouldUsePurgeableMemory): Deleted.
- platform/cf/SharedBufferCF.cpp:
(WebCore::SharedBuffer::SharedBuffer):
- platform/mac/PurgeableBufferMac.cpp: Removed.
- platform/mac/SharedBufferMac.mm:
(WebCore::SharedBuffer::createCFData):
- platform/soup/SharedBufferSoup.cpp:
Source/WebKit/mac:
- Misc/WebCache.mm:
(+[WebCache statistics]):
Source/WebKit/win:
- WebCache.cpp:
(WebCache::statistics):
Source/WebKit2:
- WebProcess/WebProcess.cpp:
(WebKit::getWebCoreMemoryCacheStatistics):
Source/WTF:
- wtf/Platform.h: Remove ENABLE_PURGEABLE_MEMORY define.
- wtf/VMTags.h: Remove VM tags used by WebCore for cached resource purgeable memory.
- 4:22 PM Changeset in webkit [172735] by
-
- 2 edits in trunk/Source/WebCore
Use modern for loop instead of iterators in SharedBufferCF.cpp
https://bugs.webkit.org/show_bug.cgi?id=136000
Reviewed by Andreas Kling.
- platform/cf/SharedBufferCF.cpp:
(WebCore::SharedBuffer::copyBufferAndClear):
(WebCore::SharedBuffer::copySomeDataFromDataArray):
(WebCore::SharedBuffer::maybeAppendDataArray): Use auto& instead of auto for less RetainPtr/refcount churn.
- 4:20 PM Changeset in webkit [172734] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fix ASSERT in ARM64's JSC::GPRInfo::debugName
https://bugs.webkit.org/show_bug.cgi?id=136050
Patch by Akos Kiss <akiss@inf.u-szeged.hu> on 2014-08-18
Reviewed by Darin Adler.
Remove cast of GPRReg to unsigned to prevent signed/unsigned comparison
error.
- jit/GPRInfo.h:
(JSC::GPRInfo::debugName):
- 4:10 PM Changeset in webkit [172733] by
-
- 2 edits405 adds in trunk/LayoutTests
[CSS Shapes] Import the CSS Shapes W3C test suite
https://bugs.webkit.org/show_bug.cgi?id=135921
Patch by Rebecca Hauck <rhauck@adobe.com> on 2014-08-18
Reviewed by Bem Jones-Bey.
This patch contains the imported CSS Shapes W3C test suite
brought in and converted to WebKit style using
Tools/Scripts/impoart-w3c-tests.
- TestExpectations:
- css3/shapes/shape-outside-invalid-001-expected.txt: Added.
- css3/shapes/shape-outside-invalid-001.html: Added.
- css3/shapes/shape-outside-invalid-circle-000-expected.txt: Added.
- css3/shapes/shape-outside-invalid-circle-000.html: Added.
- css3/shapes/shape-outside-invalid-circle-001-expected.txt: Added.
- css3/shapes/shape-outside-invalid-circle-001.html: Added.
- css3/shapes/shape-outside-invalid-circle-002-expected.txt: Added.
- css3/shapes/shape-outside-invalid-circle-002.html: Added.
- css3/shapes/shape-outside-invalid-circle-003-expected.txt: Added.
- css3/shapes/shape-outside-invalid-circle-003.html: Added.
- css3/shapes/shape-outside-invalid-ellipse-001-expected.txt: Added.
- css3/shapes/shape-outside-invalid-ellipse-001.html: Added.
- css3/shapes/shape-outside-invalid-ellipse-002-expected.txt: Added.
- css3/shapes/shape-outside-invalid-ellipse-002.html: Added.
- css3/shapes/shape-outside-invalid-ellipse-003-expected.txt: Added.
- css3/shapes/shape-outside-invalid-ellipse-003.html: Added.
- css3/shapes/shape-outside-invalid-ellipse-004-expected.txt: Added.
- css3/shapes/shape-outside-invalid-ellipse-004.html: Added.
- css3/shapes/shape-outside-invalid-ellipse-005-expected.txt: Added.
- css3/shapes/shape-outside-invalid-ellipse-005.html: Added.
- css3/shapes/shape-outside-invalid-ellipse-006-expected.txt: Added.
- css3/shapes/shape-outside-invalid-ellipse-006.html: Added.
- css3/shapes/shape-outside-invalid-inset-001-expected.txt: Added.
- css3/shapes/shape-outside-invalid-inset-001.html: Added.
- css3/shapes/shape-outside-invalid-inset-002-expected.txt: Added.
- css3/shapes/shape-outside-invalid-inset-002.html: Added.
- css3/shapes/shape-outside-invalid-inset-003-expected.txt: Added.
- css3/shapes/shape-outside-invalid-inset-003.html: Added.
- css3/shapes/shape-outside-invalid-inset-004-expected.txt: Added.
- css3/shapes/shape-outside-invalid-inset-004.html: Added.
- css3/shapes/shape-outside/shape-box/shape-outside-box-002-expected.html: Added.
- css3/shapes/shape-outside/shape-box/shape-outside-box-002.html: Added.
- css3/shapes/shape-outside/shape-box/shape-outside-box-003-expected.html: Added.
- css3/shapes/shape-outside/shape-box/shape-outside-box-003.html: Added.
- css3/shapes/shape-outside/shape-box/shape-outside-box-004-expected.html: Added.
- css3/shapes/shape-outside/shape-box/shape-outside-box-004.html: Added.
- css3/shapes/shape-outside/shape-box/shape-outside-box-006-expected.html: Added.
- css3/shapes/shape-outside/shape-box/shape-outside-box-006.html: Added.
- css3/shapes/shape-outside/shape-box/shape-outside-box-007-expected.html: Added.
- css3/shapes/shape-outside/shape-box/shape-outside-box-007.html: Added.
- css3/shapes/shape-outside/shape-box/shape-outside-box-008-expected.html: Added.
- css3/shapes/shape-outside/shape-box/shape-outside-box-008.html: Added.
- css3/shapes/shape-outside/shape-box/w3c-import.log: Added.
- css3/shapes/shape-outside/shape-image/gradients/shape-outside-linear-gradient-001-expected.html: Added.
- css3/shapes/shape-outside/shape-image/gradients/shape-outside-linear-gradient-001.html: Added.
- css3/shapes/shape-outside/shape-image/gradients/shape-outside-linear-gradient-002-expected.html: Added.
- css3/shapes/shape-outside/shape-image/gradients/shape-outside-linear-gradient-002.html: Added.
- css3/shapes/shape-outside/shape-image/gradients/shape-outside-linear-gradient-003-expected.html: Added.
- css3/shapes/shape-outside/shape-image/gradients/shape-outside-linear-gradient-003.html: Added.
- css3/shapes/shape-outside/shape-image/gradients/shape-outside-linear-gradient-004-expected.html: Added.
- css3/shapes/shape-outside/shape-image/gradients/shape-outside-linear-gradient-004.html: Added.
- css3/shapes/shape-outside/shape-image/gradients/shape-outside-radial-gradient-001-expected.html: Added.
- css3/shapes/shape-outside/shape-image/gradients/shape-outside-radial-gradient-001.html: Added.
- css3/shapes/shape-outside/shape-image/gradients/shape-outside-radial-gradient-002-expected.html: Added.
- css3/shapes/shape-outside/shape-image/gradients/shape-outside-radial-gradient-002.html: Added.
- css3/shapes/shape-outside/shape-image/gradients/shape-outside-radial-gradient-003-expected.html: Added.
- css3/shapes/shape-outside/shape-image/gradients/shape-outside-radial-gradient-003.html: Added.
- css3/shapes/shape-outside/shape-image/gradients/shape-outside-radial-gradient-004-expected.html: Added.
- css3/shapes/shape-outside/shape-image/gradients/shape-outside-radial-gradient-004.html: Added.
- css3/shapes/shape-outside/shape-image/gradients/w3c-import.log: Added.
- css3/shapes/shape-outside/shape-image/shape-image-000-expected.html: Added.
- css3/shapes/shape-outside/shape-image/shape-image-000.html: Added.
- css3/shapes/shape-outside/shape-image/shape-image-001-expected.html: Added.
- css3/shapes/shape-outside/shape-image/shape-image-001.html: Added.
- css3/shapes/shape-outside/shape-image/shape-image-002-expected.html: Added.
- css3/shapes/shape-outside/shape-image/shape-image-002.html: Added.
- css3/shapes/shape-outside/shape-image/shape-image-003-expected.html: Added.
- css3/shapes/shape-outside/shape-image/shape-image-003.html: Added.
- css3/shapes/shape-outside/shape-image/shape-image-004-expected.html: Added.
- css3/shapes/shape-outside/shape-image/shape-image-004.html: Added.
- css3/shapes/shape-outside/shape-image/shape-image-005-expected.html: Added.
- css3/shapes/shape-outside/shape-image/shape-image-005.html: Added.
- css3/shapes/shape-outside/shape-image/shape-image-012-expected.html: Added.
- css3/shapes/shape-outside/shape-image/shape-image-012.html: Added.
- css3/shapes/shape-outside/shape-image/shape-image-013-expected.html: Added.
- css3/shapes/shape-outside/shape-image/shape-image-013.html: Added.
- css3/shapes/shape-outside/shape-image/shape-image-014-expected.html: Added.
- css3/shapes/shape-outside/shape-image/shape-image-014.html: Added.
- css3/shapes/shape-outside/shape-image/shape-image-015-expected.html: Added.
- css3/shapes/shape-outside/shape-image/shape-image-015.html: Added.
- css3/shapes/shape-outside/shape-image/shape-image-016-expected.html: Added.
- css3/shapes/shape-outside/shape-image/shape-image-016.html: Added.
- css3/shapes/shape-outside/shape-image/shape-image-017-expected.html: Added.
- css3/shapes/shape-outside/shape-image/shape-image-017.html: Added.
- css3/shapes/shape-outside/shape-image/shape-image-018-expected.html: Added.
- css3/shapes/shape-outside/shape-image/shape-image-018.html: Added.
- css3/shapes/shape-outside/shape-image/shape-image-019-expected.html: Added.
- css3/shapes/shape-outside/shape-image/shape-image-019.html: Added.
- css3/shapes/shape-outside/shape-image/shape-image-020-expected.html: Added.
- css3/shapes/shape-outside/shape-image/shape-image-020.html: Added.
- css3/shapes/shape-outside/shape-image/shape-image-021-expected.html: Added.
- css3/shapes/shape-outside/shape-image/shape-image-021.html: Added.
- css3/shapes/shape-outside/shape-image/shape-image-022-expected.html: Added.
- css3/shapes/shape-outside/shape-image/shape-image-022.html: Added.
- css3/shapes/shape-outside/shape-image/shape-image-023-expected.html: Added.
- css3/shapes/shape-outside/shape-image/shape-image-023.html: Added.
- css3/shapes/shape-outside/shape-image/support/left-half-rectangle-20.png: Added.
- css3/shapes/shape-outside/shape-image/support/left-half-rectangle-20.svg: Added.
- css3/shapes/shape-outside/shape-image/support/left-half-rectangle-50.png: Added.
- css3/shapes/shape-outside/shape-image/support/left-half-rectangle-50.svg: Added.
- css3/shapes/shape-outside/shape-image/support/left-half-rectangle-70.png: Added.
- css3/shapes/shape-outside/shape-image/support/left-half-rectangle-70.svg: Added.
- css3/shapes/shape-outside/shape-image/support/left-half-rectangle.jpg: Added.
- css3/shapes/shape-outside/shape-image/support/left-half-rectangle.png: Added.
- css3/shapes/shape-outside/shape-image/support/left-half-rectangle.svg: Added.
- css3/shapes/shape-outside/shape-image/support/right-half-rectangle-20.png: Added.
- css3/shapes/shape-outside/shape-image/support/right-half-rectangle-50.png: Added.
- css3/shapes/shape-outside/shape-image/support/right-half-rectangle-70.png: Added.
- css3/shapes/shape-outside/shape-image/support/right-half-rectangle-70.svg: Added.
- css3/shapes/shape-outside/shape-image/support/right-half-rectangle.gif: Added.
- css3/shapes/shape-outside/shape-image/support/right-half-rectangle.jpg: Added.
- css3/shapes/shape-outside/shape-image/support/right-half-rectangle.png: Added.
- css3/shapes/shape-outside/shape-image/support/right-half-rectangle.svg: Added.
- css3/shapes/shape-outside/shape-image/support/w3c-import.log: Added.
- css3/shapes/shape-outside/shape-image/w3c-import.log: Added.
- css3/shapes/shape-outside/supported-shapes/circle/shape-outside-circle-013-expected.html: Added.
- css3/shapes/shape-outside/supported-shapes/circle/shape-outside-circle-013.html: Added.
- css3/shapes/shape-outside/supported-shapes/circle/shape-outside-circle-014-expected.html: Added.
- css3/shapes/shape-outside/supported-shapes/circle/shape-outside-circle-014.html: Added.
- css3/shapes/shape-outside/supported-shapes/circle/shape-outside-circle-015-expected.html: Added.
- css3/shapes/shape-outside/supported-shapes/circle/shape-outside-circle-015.html: Added.
- css3/shapes/shape-outside/supported-shapes/circle/shape-outside-circle-016-expected.html: Added.
- css3/shapes/shape-outside/supported-shapes/circle/shape-outside-circle-016.html: Added.
- css3/shapes/shape-outside/supported-shapes/circle/shape-outside-circle-017-expected.html: Added.
- css3/shapes/shape-outside/supported-shapes/circle/shape-outside-circle-017.html: Added.
- css3/shapes/shape-outside/supported-shapes/circle/shape-outside-circle-018-expected.html: Added.
- css3/shapes/shape-outside/supported-shapes/circle/shape-outside-circle-018.html: Added.
- css3/shapes/shape-outside/supported-shapes/circle/shape-outside-circle-019-expected.html: Added.
- css3/shapes/shape-outside/supported-shapes/circle/shape-outside-circle-019.html: Added.
- css3/shapes/shape-outside/supported-shapes/circle/shape-outside-circle-020-expected.html: Added.
- css3/shapes/shape-outside/supported-shapes/circle/shape-outside-circle-020.html: Added.
- css3/shapes/shape-outside/supported-shapes/circle/shape-outside-circle-021-expected.html: Added.
- css3/shapes/shape-outside/supported-shapes/circle/shape-outside-circle-021.html: Added.
- css3/shapes/shape-outside/supported-shapes/circle/shape-outside-circle-022-expected.html: Added.
- css3/shapes/shape-outside/supported-shapes/circle/shape-outside-circle-022.html: Added.
- css3/shapes/shape-outside/supported-shapes/circle/shape-outside-circle-024-expected.html: Added.
- css3/shapes/shape-outside/supported-shapes/circle/shape-outside-circle-024.html: Added.
- css3/shapes/shape-outside/supported-shapes/circle/shape-outside-circle-025-expected.html: Added.
- css3/shapes/shape-outside/supported-shapes/circle/shape-outside-circle-025.html: Added.
- css3/shapes/shape-outside/supported-shapes/circle/shape-outside-circle-026-expected.html: Added.
- css3/shapes/shape-outside/supported-shapes/circle/shape-outside-circle-026.html: Added.
- css3/shapes/shape-outside/supported-shapes/circle/shape-outside-circle-027-expected.html: Added.
- css3/shapes/shape-outside/supported-shapes/circle/shape-outside-circle-027.html: Added.
- css3/shapes/shape-outside/supported-shapes/circle/shape-outside-circle-028-expected.html: Added.
- css3/shapes/shape-outside/supported-shapes/circle/shape-outside-circle-028.html: Added.
- css3/shapes/shape-outside/supported-shapes/circle/shape-outside-circle-029-expected.html: Added.
- css3/shapes/shape-outside/supported-shapes/circle/shape-outside-circle-029.html: Added.
- css3/shapes/shape-outside/supported-shapes/circle/shape-outside-circle-030-expected.html: Added.
- css3/shapes/shape-outside/supported-shapes/circle/shape-outside-circle-030.html: Added.
- css3/shapes/shape-outside/supported-shapes/circle/shape-outside-circle-031-expected.html: Added.
- css3/shapes/shape-outside/supported-shapes/circle/shape-outside-circle-031.html: Added.
- css3/shapes/shape-outside/supported-shapes/circle/w3c-import.log: Added.
- css3/shapes/shape-outside/supported-shapes/ellipse/shape-outside-ellipse-013-expected.html: Added.
- css3/shapes/shape-outside/supported-shapes/ellipse/shape-outside-ellipse-013.html: Added.
- css3/shapes/shape-outside/supported-shapes/ellipse/shape-outside-ellipse-014-expected.html: Added.
- css3/shapes/shape-outside/supported-shapes/ellipse/shape-outside-ellipse-014.html: Added.
- css3/shapes/shape-outside/supported-shapes/ellipse/shape-outside-ellipse-015-expected.html: Added.
- css3/shapes/shape-outside/supported-shapes/ellipse/shape-outside-ellipse-015.html: Added.
- css3/shapes/shape-outside/supported-shapes/ellipse/shape-outside-ellipse-016-expected.html: Added.
- css3/shapes/shape-outside/supported-shapes/ellipse/shape-outside-ellipse-016.html: Added.
- css3/shapes/shape-outside/supported-shapes/ellipse/shape-outside-ellipse-017-expected.html: Added.
- css3/shapes/shape-outside/supported-shapes/ellipse/shape-outside-ellipse-017.html: Added.
- css3/shapes/shape-outside/supported-shapes/ellipse/shape-outside-ellipse-018-expected.html: Added.
- css3/shapes/shape-outside/supported-shapes/ellipse/shape-outside-ellipse-018.html: Added.
- css3/shapes/shape-outside/supported-shapes/ellipse/shape-outside-ellipse-019-expected.html: Added.
- css3/shapes/shape-outside/supported-shapes/ellipse/shape-outside-ellipse-019.html: Added.
- css3/shapes/shape-outside/supported-shapes/ellipse/shape-outside-ellipse-020-expected.html: Added.
- css3/shapes/shape-outside/supported-shapes/ellipse/shape-outside-ellipse-020.html: Added.
- css3/shapes/shape-outside/supported-shapes/ellipse/shape-outside-ellipse-021-expected.html: Added.
- css3/shapes/shape-outside/supported-shapes/ellipse/shape-outside-ellipse-021.html: Added.
- css3/shapes/shape-outside/supported-shapes/ellipse/shape-outside-ellipse-022-expected.html: Added.
- css3/shapes/shape-outside/supported-shapes/ellipse/shape-outside-ellipse-022.html: Added.
- css3/shapes/shape-outside/supported-shapes/ellipse/shape-outside-ellipse-023-expected.html: Added.
- css3/shapes/shape-outside/supported-shapes/ellipse/shape-outside-ellipse-023.html: Added.
- css3/shapes/shape-outside/supported-shapes/ellipse/shape-outside-ellipse-024-expected.html: Added.
- css3/shapes/shape-outside/supported-shapes/ellipse/shape-outside-ellipse-024.html: Added.
- css3/shapes/shape-outside/supported-shapes/ellipse/shape-outside-ellipse-025-expected.html: Added.
- css3/shapes/shape-outside/supported-shapes/ellipse/shape-outside-ellipse-025.html: Added.
- css3/shapes/shape-outside/supported-shapes/ellipse/shape-outside-ellipse-030-expected.html: Added.
- css3/shapes/shape-outside/supported-shapes/ellipse/shape-outside-ellipse-030.html: Added.
- css3/shapes/shape-outside/supported-shapes/ellipse/shape-outside-ellipse-031-expected.html: Added.
- css3/shapes/shape-outside/supported-shapes/ellipse/shape-outside-ellipse-031.html: Added.
- css3/shapes/shape-outside/supported-shapes/ellipse/w3c-import.log: Added.
- css3/shapes/shape-outside/supported-shapes/inset/shape-outside-inset-010-expected.html: Added.
- css3/shapes/shape-outside/supported-shapes/inset/shape-outside-inset-010.html: Added.
- css3/shapes/shape-outside/supported-shapes/inset/shape-outside-inset-011-expected.html: Added.
- css3/shapes/shape-outside/supported-shapes/inset/shape-outside-inset-011.html: Added.
- css3/shapes/shape-outside/supported-shapes/inset/shape-outside-inset-012-expected.html: Added.
- css3/shapes/shape-outside/supported-shapes/inset/shape-outside-inset-012.html: Added.
- css3/shapes/shape-outside/supported-shapes/inset/shape-outside-inset-013-expected.html: Added.
- css3/shapes/shape-outside/supported-shapes/inset/shape-outside-inset-013.html: Added.
- css3/shapes/shape-outside/supported-shapes/inset/shape-outside-inset-014-expected.html: Added.
- css3/shapes/shape-outside/supported-shapes/inset/shape-outside-inset-014.html: Added.
- css3/shapes/shape-outside/supported-shapes/inset/shape-outside-inset-015-expected.html: Added.
- css3/shapes/shape-outside/supported-shapes/inset/shape-outside-inset-015.html: Added.
- css3/shapes/shape-outside/supported-shapes/inset/w3c-import.log: Added.
- css3/shapes/shape-outside/supported-shapes/polygon/shape-outside-polygon-007-expected.html: Added.
- css3/shapes/shape-outside/supported-shapes/polygon/shape-outside-polygon-007.html: Added.
- css3/shapes/shape-outside/supported-shapes/polygon/shape-outside-polygon-008-expected.html: Added.
- css3/shapes/shape-outside/supported-shapes/polygon/shape-outside-polygon-008.html: Added.
- css3/shapes/shape-outside/supported-shapes/polygon/shape-outside-polygon-009-expected.html: Added.
- css3/shapes/shape-outside/supported-shapes/polygon/shape-outside-polygon-009.html: Added.
- css3/shapes/shape-outside/supported-shapes/polygon/shape-outside-polygon-010-expected.html: Added.
- css3/shapes/shape-outside/supported-shapes/polygon/shape-outside-polygon-010.html: Added.
- css3/shapes/shape-outside/supported-shapes/polygon/shape-outside-polygon-011-expected.html: Added.
- css3/shapes/shape-outside/supported-shapes/polygon/shape-outside-polygon-011.html: Added.
- css3/shapes/shape-outside/supported-shapes/polygon/shape-outside-polygon-012-expected.html: Added.
- css3/shapes/shape-outside/supported-shapes/polygon/shape-outside-polygon-012.html: Added.
- css3/shapes/shape-outside/supported-shapes/polygon/shape-outside-polygon-013-expected.html: Added.
- css3/shapes/shape-outside/supported-shapes/polygon/shape-outside-polygon-013.html: Added.
- css3/shapes/shape-outside/supported-shapes/polygon/shape-outside-polygon-014-expected.html: Added.
- css3/shapes/shape-outside/supported-shapes/polygon/shape-outside-polygon-014.html: Added.
- css3/shapes/shape-outside/supported-shapes/polygon/shape-outside-polygon-015-expected.html: Added.
- css3/shapes/shape-outside/supported-shapes/polygon/shape-outside-polygon-015.html: Added.
- css3/shapes/shape-outside/supported-shapes/polygon/shape-outside-polygon-016-expected.html: Added.
- css3/shapes/shape-outside/supported-shapes/polygon/shape-outside-polygon-016.html: Added.
- css3/shapes/shape-outside/supported-shapes/polygon/shape-outside-polygon-017-expected.html: Added.
- css3/shapes/shape-outside/supported-shapes/polygon/shape-outside-polygon-017.html: Added.
- css3/shapes/shape-outside/supported-shapes/polygon/w3c-import.log: Added.
- css3/shapes/shape-outside/supported-shapes/support/rounded-rectangle.js: Added.
(ellipseXIntercept):
(scanConvertRoundedRectangleOutside):
(genLeftRoundedRectFloatShapeOutsideRefTest):
(getRoundedRectLeftEdge):
(genRightRoundedRectFloatShapeOutsideRefTest):
- css3/shapes/shape-outside/supported-shapes/support/subpixel-utils.js: Added.
(SubPixelLayout):
(SubPixelLayout.):
- css3/shapes/shape-outside/supported-shapes/support/test-utils.js: Added.
(verifyTextPoints):
- css3/shapes/shape-outside/values/shape-image-threshold-000-expected.txt: Added.
- css3/shapes/shape-outside/values/shape-image-threshold-000.html: Added.
- css3/shapes/shape-outside/values/shape-image-threshold-001-expected.txt: Added.
- css3/shapes/shape-outside/values/shape-image-threshold-001.html: Added.
- css3/shapes/shape-outside/values/shape-image-threshold-002-expected.txt: Added.
- css3/shapes/shape-outside/values/shape-image-threshold-002.html: Added.
- css3/shapes/shape-outside/values/shape-image-threshold-003-expected.txt: Added.
- css3/shapes/shape-outside/values/shape-image-threshold-003.html: Added.
- css3/shapes/shape-outside/values/shape-margin-000-expected.txt: Added.
- css3/shapes/shape-outside/values/shape-margin-000.html: Added.
- css3/shapes/shape-outside/values/shape-margin-001-expected.txt: Added.
- css3/shapes/shape-outside/values/shape-margin-001.html: Added.
- css3/shapes/shape-outside/values/shape-margin-002-expected.txt: Added.
- css3/shapes/shape-outside/values/shape-margin-002.html: Added.
- css3/shapes/shape-outside/values/shape-margin-003-expected.txt: Added.
- css3/shapes/shape-outside/values/shape-margin-003.html: Added.
- css3/shapes/shape-outside/values/shape-margin-004-expected.txt: Added.
- css3/shapes/shape-outside/values/shape-margin-004.html: Added.
- css3/shapes/shape-outside/values/shape-margin-005-expected.txt: Added.
- css3/shapes/shape-outside/values/shape-margin-005.html: Added.
- css3/shapes/shape-outside/values/shape-outside-box-000-expected.txt: Added.
- css3/shapes/shape-outside/values/shape-outside-box-000.html: Added.
- css3/shapes/shape-outside/values/shape-outside-circle-000-expected.txt: Added.
- css3/shapes/shape-outside/values/shape-outside-circle-000.html: Added.
- css3/shapes/shape-outside/values/shape-outside-circle-001-expected.txt: Added.
- css3/shapes/shape-outside/values/shape-outside-circle-001.html: Added.
- css3/shapes/shape-outside/values/shape-outside-circle-002-expected.txt: Added.
- css3/shapes/shape-outside/values/shape-outside-circle-002.html: Added.
- css3/shapes/shape-outside/values/shape-outside-circle-003-expected.txt: Added.
- css3/shapes/shape-outside/values/shape-outside-circle-003.html: Added.
- css3/shapes/shape-outside/values/shape-outside-circle-004-expected.txt: Added.
- css3/shapes/shape-outside/values/shape-outside-circle-004.html: Added.
- css3/shapes/shape-outside/values/shape-outside-circle-005-expected.txt: Added.
- css3/shapes/shape-outside/values/shape-outside-circle-005.html: Added.
- css3/shapes/shape-outside/values/shape-outside-circle-006-expected.txt: Added.
- css3/shapes/shape-outside/values/shape-outside-circle-006.html: Added.
- css3/shapes/shape-outside/values/shape-outside-circle-007-expected.txt: Added.
- css3/shapes/shape-outside/values/shape-outside-circle-007.html: Added.
- css3/shapes/shape-outside/values/shape-outside-circle-008-expected.txt: Added.
- css3/shapes/shape-outside/values/shape-outside-circle-008.html: Added.
- css3/shapes/shape-outside/values/shape-outside-circle-009-expected.txt: Added.
- css3/shapes/shape-outside/values/shape-outside-circle-009.html: Added.
- css3/shapes/shape-outside/values/shape-outside-circle-010-expected.txt: Added.
- css3/shapes/shape-outside/values/shape-outside-circle-010.html: Added.
- css3/shapes/shape-outside/values/shape-outside-circle-011-expected.txt: Added.
- css3/shapes/shape-outside/values/shape-outside-circle-011.html: Added.
- css3/shapes/shape-outside/values/shape-outside-computed-shape-000-expected.txt: Added.
- css3/shapes/shape-outside/values/shape-outside-computed-shape-000.html: Added.
- css3/shapes/shape-outside/values/shape-outside-computed-shape-001-expected.txt: Added.
- css3/shapes/shape-outside/values/shape-outside-computed-shape-001.html: Added.
- css3/shapes/shape-outside/values/shape-outside-ellipse-000-expected.txt: Added.
- css3/shapes/shape-outside/values/shape-outside-ellipse-000.html: Added.
- css3/shapes/shape-outside/values/shape-outside-ellipse-001-expected.txt: Added.
- css3/shapes/shape-outside/values/shape-outside-ellipse-001.html: Added.
- css3/shapes/shape-outside/values/shape-outside-ellipse-002-expected.txt: Added.
- css3/shapes/shape-outside/values/shape-outside-ellipse-002.html: Added.
- css3/shapes/shape-outside/values/shape-outside-ellipse-003-expected.txt: Added.
- css3/shapes/shape-outside/values/shape-outside-ellipse-003.html: Added.
- css3/shapes/shape-outside/values/shape-outside-ellipse-004-expected.txt: Added.
- css3/shapes/shape-outside/values/shape-outside-ellipse-004.html: Added.
- css3/shapes/shape-outside/values/shape-outside-ellipse-005-expected.txt: Added.
- css3/shapes/shape-outside/values/shape-outside-ellipse-005.html: Added.
- css3/shapes/shape-outside/values/shape-outside-ellipse-006-expected.txt: Added.
- css3/shapes/shape-outside/values/shape-outside-ellipse-006.html: Added.
- css3/shapes/shape-outside/values/shape-outside-ellipse-007-expected.txt: Added.
- css3/shapes/shape-outside/values/shape-outside-ellipse-007.html: Added.
- css3/shapes/shape-outside/values/shape-outside-ellipse-008-expected.txt: Added.
- css3/shapes/shape-outside/values/shape-outside-ellipse-008.html: Added.
- css3/shapes/shape-outside/values/shape-outside-ellipse-009-expected.txt: Added.
- css3/shapes/shape-outside/values/shape-outside-ellipse-009.html: Added.
- css3/shapes/shape-outside/values/shape-outside-ellipse-010-expected.txt: Added.
- css3/shapes/shape-outside/values/shape-outside-ellipse-010.html: Added.
- css3/shapes/shape-outside/values/shape-outside-ellipse-011-expected.txt: Added.
- css3/shapes/shape-outside/values/shape-outside-ellipse-011.html: Added.
- css3/shapes/shape-outside/values/shape-outside-inset-000-expected.txt: Added.
- css3/shapes/shape-outside/values/shape-outside-inset-000.html: Added.
- css3/shapes/shape-outside/values/shape-outside-inset-001-expected.txt: Added.
- css3/shapes/shape-outside/values/shape-outside-inset-001.html: Added.
- css3/shapes/shape-outside/values/shape-outside-inset-002-expected.txt: Added.
- css3/shapes/shape-outside/values/shape-outside-inset-002.html: Added.
- css3/shapes/shape-outside/values/shape-outside-inset-003-expected.txt: Added.
- css3/shapes/shape-outside/values/shape-outside-inset-003.html: Added.
- css3/shapes/shape-outside/values/shape-outside-inset-004-expected.txt: Added.
- css3/shapes/shape-outside/values/shape-outside-inset-004.html: Added.
- css3/shapes/shape-outside/values/shape-outside-inset-005-expected.txt: Added.
- css3/shapes/shape-outside/values/shape-outside-inset-005.html: Added.
- css3/shapes/shape-outside/values/shape-outside-inset-006-expected.txt: Added.
- css3/shapes/shape-outside/values/shape-outside-inset-006.html: Added.
- css3/shapes/shape-outside/values/shape-outside-inset-007-expected.txt: Added.
- css3/shapes/shape-outside/values/shape-outside-inset-007.html: Added.
- css3/shapes/shape-outside/values/shape-outside-inset-008-expected.txt: Added.
- css3/shapes/shape-outside/values/shape-outside-inset-008.html: Added.
- css3/shapes/shape-outside/values/shape-outside-inset-009-expected.txt: Added.
- css3/shapes/shape-outside/values/shape-outside-inset-009.html: Added.
- css3/shapes/shape-outside/values/shape-outside-polygon-000-expected.txt: Added.
- css3/shapes/shape-outside/values/shape-outside-polygon-000.html: Added.
- css3/shapes/shape-outside/values/shape-outside-polygon-001-expected.txt: Added.
- css3/shapes/shape-outside/values/shape-outside-polygon-001.html: Added.
- css3/shapes/shape-outside/values/shape-outside-polygon-002-expected.txt: Added.
- css3/shapes/shape-outside/values/shape-outside-polygon-002.html: Added.
- css3/shapes/shape-outside/values/shape-outside-polygon-003-expected.txt: Added.
- css3/shapes/shape-outside/values/shape-outside-polygon-003.html: Added.
- css3/shapes/shape-outside/values/shape-outside-polygon-004-expected.txt: Added.
- css3/shapes/shape-outside/values/shape-outside-polygon-004.html: Added.
- css3/shapes/shape-outside/values/shape-outside-polygon-005-expected.txt: Added.
- css3/shapes/shape-outside/values/shape-outside-polygon-005.html: Added.
- css3/shapes/shape-outside/values/shape-outside-polygon-006-expected.txt: Added.
- css3/shapes/shape-outside/values/shape-outside-polygon-006.html: Added.
- css3/shapes/shape-outside/values/shape-outside-shape-arguments-000-expected.txt: Added.
- css3/shapes/shape-outside/values/shape-outside-shape-arguments-000.html: Added.
- css3/shapes/shape-outside/values/shape-outside-shape-arguments-001-expected.txt: Added.
- css3/shapes/shape-outside/values/shape-outside-shape-arguments-001.html: Added.
- css3/shapes/shape-outside/values/shape-outside-shape-box-pair-000-expected.txt: Added.
- css3/shapes/shape-outside/values/shape-outside-shape-box-pair-000.html: Added.
- css3/shapes/shape-outside/values/shape-outside-shape-inherit-000-expected.txt: Added.
- css3/shapes/shape-outside/values/shape-outside-shape-inherit-000.html: Added.
- css3/shapes/shape-outside/values/shape-outside-shape-initial-000-expected.txt: Added.
- css3/shapes/shape-outside/values/shape-outside-shape-initial-000.html: Added.
- css3/shapes/shape-outside/values/shape-outside-shape-none-000-expected.txt: Added.
- css3/shapes/shape-outside/values/shape-outside-shape-none-000.html: Added.
- css3/shapes/shape-outside/values/shape-outside-shape-notation-000-expected.txt: Added.
- css3/shapes/shape-outside/values/shape-outside-shape-notation-000.html: Added.
- css3/shapes/shape-outside/values/support/parsing-utils.js: Added.
(ParsingUtils):
(ParsingUtils.):
- css3/shapes/shape-outside/values/support/w3c-import.log: Added.
- css3/shapes/shape-outside/values/w3c-import.log: Added.
- css3/shapes/spec-examples/shape-outside-001-expected.html: Added.
- css3/shapes/spec-examples/shape-outside-001.html: Added.
- css3/shapes/spec-examples/shape-outside-002-expected.html: Added.
- css3/shapes/spec-examples/shape-outside-002.html: Added.
- css3/shapes/spec-examples/shape-outside-003-expected.html: Added.
- css3/shapes/spec-examples/shape-outside-003.html: Added.
- css3/shapes/spec-examples/shape-outside-004-expected.html: Added.
- css3/shapes/spec-examples/shape-outside-004.html: Added.
- css3/shapes/spec-examples/shape-outside-005-expected.html: Added.
- css3/shapes/spec-examples/shape-outside-005.html: Added.
- css3/shapes/spec-examples/shape-outside-006-expected.html: Added.
- css3/shapes/spec-examples/shape-outside-006.html: Added.
- css3/shapes/spec-examples/shape-outside-007-expected.html: Added.
- css3/shapes/spec-examples/shape-outside-007.html: Added.
- css3/shapes/spec-examples/shape-outside-008-expected.html: Added.
- css3/shapes/spec-examples/shape-outside-008.html: Added.
- css3/shapes/spec-examples/shape-outside-010-expected.html: Added.
- css3/shapes/spec-examples/shape-outside-010.html: Added.
- css3/shapes/spec-examples/shape-outside-011-expected.html: Added.
- css3/shapes/spec-examples/shape-outside-011.html: Added.
- css3/shapes/spec-examples/shape-outside-012-expected.html: Added.
- css3/shapes/spec-examples/shape-outside-012.html: Added.
- css3/shapes/spec-examples/shape-outside-013-expected.html: Added.
- css3/shapes/spec-examples/shape-outside-013.html: Added.
- css3/shapes/spec-examples/shape-outside-014-expected.html: Added.
- css3/shapes/spec-examples/shape-outside-014.html: Added.
- css3/shapes/spec-examples/shape-outside-015-expected.html: Added.
- css3/shapes/spec-examples/shape-outside-015.html: Added.
- css3/shapes/spec-examples/shape-outside-016-expected.html: Added.
- css3/shapes/spec-examples/shape-outside-016.html: Added.
- css3/shapes/spec-examples/shape-outside-017-expected.html: Added.
- css3/shapes/spec-examples/shape-outside-017.html: Added.
- css3/shapes/spec-examples/shape-outside-018-expected.html: Added.
- css3/shapes/spec-examples/shape-outside-018.html: Added.
- css3/shapes/spec-examples/shape-outside-019-expected.html: Added.
- css3/shapes/spec-examples/shape-outside-019.html: Added.
- css3/shapes/spec-examples/support/circle-no-shadow.png: Added.
- css3/shapes/spec-examples/support/circle-shadow.png: Added.
- css3/shapes/spec-examples/support/rounded-triangle.svg: Added.
- css3/shapes/spec-examples/support/w3c-import.log: Added.
- css3/shapes/spec-examples/w3c-import.log: Added.
- css3/shapes/w3c-import.log: Added.
- 3:42 PM Changeset in webkit [172732] by
-
- 4 edits in branches/safari-600.1-branch
Merged r172680. <rdar://problem/18049780>
- 3:39 PM Changeset in webkit [172731] by
-
- 5 edits in branches/safari-600.1-branch/Source/WebKit2
Merged r172660. <rdar://problem/18049780>
- 3:16 PM Changeset in webkit [172730] by
-
- 9 edits in trunk/Source/WebCore
Tighten RenderCounter typing
https://bugs.webkit.org/show_bug.cgi?id=136049
Reviewed by Andreas Kling.
RenderObject* -> RenderElement&
- rendering/CounterNode.cpp:
(WebCore::CounterNode::CounterNode):
(WebCore::CounterNode::create):
(WebCore::showTreeAndMark):
- rendering/CounterNode.h:
(WebCore::CounterNode::owner):
- rendering/RenderCounter.cpp:
(WebCore::previousInPreOrder):
(WebCore::parentOrPseudoHostElement):
(WebCore::previousSiblingOrParent):
(WebCore::areRenderersElementsSiblings):
(WebCore::nextInPreOrder):
(WebCore::planCounter):
(WebCore::findPlaceForCounter):
(WebCore::makeCounterNode):
(WebCore::RenderCounter::originalText):
(WebCore::destroyCounterNodeWithoutMapRemoval):
(WebCore::RenderCounter::destroyCounterNodes):
(WebCore::RenderCounter::destroyCounterNode):
(WebCore::RenderCounter::rendererRemovedFromTree):
(WebCore::updateCounters):
(WebCore::RenderCounter::rendererSubtreeAttached):
(WebCore::RenderCounter::rendererStyleChanged):
(showCounterRendererTree):
- rendering/RenderCounter.h:
- rendering/RenderElement.cpp:
(WebCore::RenderElement::RenderElement):
(WebCore::RenderElement::insertChildInternal):
(WebCore::RenderElement::removeChildInternal):
(WebCore::RenderElement::styleDidChange):
(WebCore::RenderElement::willBeDestroyed):
- rendering/RenderElement.h:
(WebCore::RenderElement::hasCounterNodeMap):
(WebCore::RenderElement::setHasCounterNodeMap):
Move CounterNodeMap to RenderElement from RenderObject.
- rendering/RenderObject.cpp:
(WebCore::RenderObject::willBeDestroyed):
- rendering/RenderObject.h:
(WebCore::RenderObject::RenderObjectBitfields::RenderObjectBitfields):
(WebCore::RenderObject::hasCounterNodeMap): Deleted.
(WebCore::RenderObject::setHasCounterNodeMap): Deleted.
- 3:03 PM Changeset in webkit [172729] by
-
- 19 edits in trunk/Source
Expose long mouse press WebKit API. Part of 135257 - Add long mouse press gesture
https://bugs.webkit.org/show_bug.cgi?id=136048
Patch by Peyton Randolph <prandolph@apple.com> on 2014-08-18
Reviewed by Dan Bernstein.
This patch exposes long mouse press API callbacks in both the injected bundle and on the UI process
through their respective page UI clients. The callbacks are modeled off of the mouseDidMoveOverElement
callback. Like the mouseDidMoveOverElement callback, these callbacks allow the bundle to pass
information to the UI process via a userData out parameter.
Source/WebCore:
- page/Chrome.cpp:
(WebCore::Chrome::didBeginTrackingPotentialLongMousePress): Added.
(WebCore::Chrome::didRecognizeLongMousePress): Added.
(WebCore::Chrome::didCancelTrackingPotentialLongMousePress): Added.
- page/Chrome.h:
- page/ChromeClient.h:
(WebCore::ChromeClient::didBeginTrackingPotentialLongMousePress): Added.
(WebCore::ChromeClient::didRecognizeLongMousePress): Added.
(WebCore::ChromeClient::didCancelTrackingPotentialLongMousePress): Added.
- page/EventHandler.cpp:
(WebCore::EventHandler::handleMousePressEvent):
Pass the press hit test result to kick off the long mouse press.
(WebCore::EventHandler::beginTrackingPotentialLongMousePress): Notify the chrome.
(WebCore::EventHandler::recognizeLongMousePress): Ditto.
(WebCore::EventHandler::cancelTrackingPotentialLongMousePress):
Ditto. Also opportunistically remove a runtime switch check to see if long pressing is enabled. The
runtime switch check was only triggered when long pressing was disabled in the middle of a long press.
- page/EventHandler.h:
Source/WebKit2:
- UIProcess/API/APIUIClient.h:
(API::UIClient::didBeginTrackingPotentialLongMousePress): Added.
(API::UIClient::didRecognizeLongMousePress): Added.
(API::UIClient::didCancelTrackingPotentialLongMousePress): Added.
- UIProcess/API/C/WKPage.cpp:
(WKPageSetPageUIClient):
- UIProcess/API/C/WKPageUIClient.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didBeginTrackingPotentialLongMousePress): Added.
(WebKit::WebPageProxy::didRecognizeLongMousePress): Added.
(WebKit::WebPageProxy::didCancelTrackingPotentialLongMousePress): Added.
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
- WebProcess/InjectedBundle/API/APIInjectedBundlePageUIClient.h:
(API::InjectedBundle::PageUIClient::didBeginTrackingPotentialLongMousePress): Added.
(API::InjectedBundle::PageUIClient::didRecognizeLongMousePress): Added.
(API::InjectedBundle::PageUIClient::didCancelTrackingPotentialLongMousePress): Added.
- WebProcess/InjectedBundle/API/c/WKBundlePageUIClient.h:
- WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp: Added.
(WebKit::InjectedBundlePageUIClient::didBeginTrackingPotentialLongMousePress): Added.
(WebKit::InjectedBundlePageUIClient::didRecognizeLongMousePress): Added.
(WebKit::InjectedBundlePageUIClient::didCancelTrackingPotentialLongMousePress): Added.
- WebProcess/InjectedBundle/InjectedBundlePageUIClient.h:
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::didBeginTrackingPotentialLongMousePress): Added.
(WebKit::WebChromeClient::didRecognizeLongMousePress): Added.
(WebKit::WebChromeClient::didCancelTrackingPotentialLongMousePress): Added.
- WebProcess/WebCoreSupport/WebChromeClient.h:
- 2:44 PM Changeset in webkit [172728] by
-
- 3 edits in trunk/Tools
Added an update-webkit option to override the ../Internal check.
Part of https://bugs.webkit.org/show_bug.cgi?id=135815
Reviewed by Tim Horton.
- Scripts/update-webkit:
Added an explicit --internal option to control updating ../Internal, defaulting to whether
../Internal exists.
(runSvnUpdate): Moved to webkitdirs.pm.
(runGitUpdate): Ditto.
- Scripts/webkitdirs.pm:
(runSvnUpdateAndResolveChangeLogs): Moved runSvnUpdate from update-webkit and renamed to this.
(runGitUpdate): Moved from update-webkit.
- 2:33 PM Changeset in webkit [172727] by
-
- 4 edits2 adds in trunk
REGRESSION(r168256): JSString can get 8-bit flag wrong when re-using AtomicStrings.
<https://webkit.org/b/133574>
<rdar://problem/18051847>
Source/JavaScriptCore:
The optimization that resolves JSRopeStrings into an existing
AtomicString (to save time and memory by avoiding StringImpl allocation)
had a bug that it wasn't copying the 8-bit flag from the AtomicString.
This could lead to a situation where a 16-bit StringImpl containing
only 8-bit characters is sitting in the AtomicString table, is found
by the rope resolution optimization, and gives you a rope that thinks
it's all 8-bit, but has a fiber with 16-bit characters.
Resolving that rope will then yield incorrect results.
This was all caught by an assertion, but very hard to reproduce.
Test: js/dopey-rope-with-16-bit-propertyname.html
Reviewed by Darin Adler.
- runtime/JSString.cpp:
(JSC::JSRopeString::resolveRopeToAtomicString):
(JSC::JSRopeString::resolveRopeToExistingAtomicString):
- runtime/JSString.h:
(JSC::JSString::setIs8Bit):
(JSC::JSString::toExistingAtomicString):
LayoutTests:
Add a tests that creates a 16-bit AtomicString with only 8-bit characters,
then tiers up into baseline JIT and uses that string as part of a rope-within-a-rope
and serializes that rope to get an incorrect concatenation.
Reviewed by Darin Adler.
- js/dopey-rope-with-16-bit-propertyname-expected.txt: Added.
- js/dopey-rope-with-16-bit-propertyname.html: Added.
- 2:14 PM Changeset in webkit [172726] by
-
- 2 edits in trunk/Tools
Make update-webkit more lenient for pure git svn repositories
https://bugs.webkit.org/show_bug.cgi?id=135805
Reviewed by Oliver Hunt.
Make the call to git fetch be non fatal. If you have a pure git svn repository, then the
call to git fetch will fail and update-webkit will abort. The purpose of r72966 was to
provide an optimization when you have a git repository setup. We should not fail if the
git setup does not have svn-remote.svn.fetch set.
- Scripts/update-webkit:
(runGitUpdate):
- 2:14 PM Changeset in webkit [172725] by
-
- 6 edits in trunk/Source
Fix unintentional integer overflow before widen
https://bugs.webkit.org/show_bug.cgi?id=135463
Patch by Przemyslaw Kuczynski <p.kuczynski@samsung.com> on 2014-08-18
Reviewed by Oliver Hunt.
Overflowing expression is evaluated using operands arithmetic but then is used in
context which expects an wider integer type. To avoid overflow at least one operand
has to be representative of the wider type.
Source/WebCore:
- loader/FTPDirectoryParser.cpp:
(WebCore::parseOneFTPLine): Changed strtoul to strtoull.
- loader/ProgressTracker.cpp:
(WebCore::ProgressTracker::incrementProgress): Added static_cast to long long.
- platform/efl/FileSystemEfl.cpp:
(WebCore::getVolumeFreeSizeForPath): Added static_cast to uint64_t.
Source/WebKit2:
- WebProcess/soup/WebProcessSoup.cpp:
(WebKit::getMemorySize): Added long long literal.
- 2:11 PM Changeset in webkit [172724] by
-
- 2 edits in trunk/Source/WebKit2
Fix resource leak in unclosed file descriptor handles
https://bugs.webkit.org/show_bug.cgi?id=135458
Patch by Przemyslaw Kuczynski <p.kuczynski@samsung.com> on 2014-08-18
Reviewed by Oliver Hunt.
Leaving descriptor unclosed will cause the resources associated with the open
file description never be freed (they are freed on closing the last descriptor
refering to the underlying file).
- Shared/Plugins/Netscape/x11/NetscapePluginModuleX11.cpp:
(WebKit::StdoutDevNullRedirector::StdoutDevNullRedirector): Closed newStdout descriptor.
(WebKit::StdoutDevNullRedirector::~StdoutDevNullRedirector): Closed m_savedStdout descriptor.
- 1:58 PM Changeset in webkit [172723] by
-
- 5 edits2 adds in trunk
Implement CanvasRenderingContext2D direction attribute
https://bugs.webkit.org/show_bug.cgi?id=135878
Reviewed by Darin Adler.
Source/WebCore:
The attribute, 'direction', represents the text directionality.
This is an important attribute for the bi-directional text within the CanvasRenderingContext2D.
The allowed set of values are 'rtl', 'ltr' and 'inherit'.
Specification URL: http://www.whatwg.org/specs/web-apps/current-work/multipage/scripting.html#dom-context-2d-direction
Test: fast/canvas/canvas-direction.html
- html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::inheritedDirection):
(WebCore::CanvasRenderingContext2D::CanvasRenderingContext2D):
(WebCore::CanvasRenderingContext2D::reset):
(WebCore::CanvasRenderingContext2D::State::State):
(WebCore::CanvasRenderingContext2D::State::operator=):
(WebCore::CanvasRenderingContext2D::direction):
(WebCore::CanvasRenderingContext2D::setDirection):
(WebCore::CanvasRenderingContext2D::drawTextInternal):
- html/canvas/CanvasRenderingContext2D.h:
- html/canvas/CanvasRenderingContext2D.idl:
LayoutTests:
- fast/canvas/canvas-direction-expected.txt: Added.
- fast/canvas/canvas-direction.html: Added.
- 1:54 PM Changeset in webkit [172722] by
-
- 4 edits1 add in trunk/Source/WebInspectorUI
Web Inspector: Introduce an inspector Abstract Syntax Tree.
https://bugs.webkit.org/show_bug.cgi?id=135763
Patch by Saam Barati <sbarati@apple.com> on 2014-08-18
Reviewed by Joseph Pecoraro.
This patch adds an Abstract Syntax Tree to the Web inspector.
This syntax tree is modeled off the Esprima.js syntax tree
which complies with the Mozilla Parser API:
https://developer.mozilla.org/en-US/docs/Mozilla/Projects/SpiderMonkey/Parser_API
Script is the owner of the Web Inspector syntax tree, and has an API
for accessing its syntax tree property.
- UserInterface/External/Esprima/esprima.js:
- UserInterface/Main.html:
- UserInterface/Models/Script.js:
(WebInspector.Script):
(WebInspector.Script.prototype.requestScriptSyntaxTree.makeSyntaxTreeAndCallCallback):
(WebInspector.Script.prototype._resolveResource):
(WebInspector.Script.prototype._makeSyntaxTree):
- UserInterface/Models/ScriptSyntaxTree.js: Added.
(WebInspector.ScriptSyntaxTree):
(WebInspector.ScriptSyntaxTree.prototype.get parsedSuccessfully):
(WebInspector.ScriptSyntaxTree.prototype.forEachNode):
(WebInspector.ScriptSyntaxTree.prototype.):
(WebInspector.ScriptSyntaxTree.prototype.filter):
(WebInspector.ScriptSyntaxTree.prototype.filterForNodesInRange):
(WebInspector.ScriptSyntaxTree.prototype.filterByRange):
(WebInspector.ScriptSyntaxTree.prototype.containsNonEmptyReturnStatement.removeFunctionsFilter):
(WebInspector.ScriptSyntaxTree.prototype.containsNonEmptyReturnStatement):
(WebInspector.ScriptSyntaxTree.prototype.updateTypes):
(WebInspector.ScriptSyntaxTree.prototype._defaultParserState):
(WebInspector.ScriptSyntaxTree.prototype._recurse):
(WebInspector.ScriptSyntaxTree.prototype._recurseArray):
(WebInspector.ScriptSyntaxTree.prototype._createInternalSyntaxTree):
- 1:52 PM Changeset in webkit [172721] by
-
- 11 edits6 adds in trunk
The style is not updated correctly when the pseudo class :empty is applied on anything but the rightmost element
https://bugs.webkit.org/show_bug.cgi?id=135999
Reviewed by Antti Koivisto.
Source/WebCore:
In Element's checkForEmptyStyleChange(), the style invalidation was only considering the invalidation of the element
for which the subtree has changed. When the pseudo class :empty is used with a sibling combinator (e.g. foo:empty+bar),
we were never invalidating the style of the element on which the selector applies.
This patch fixes the issue by invalidating the whole subtree rooted at the parent if the :empty rules applies
to siblings. A new flag "styleOfSiblingsAffectedByEmpty" is introduced to cover this case.
SelectorChecker just sets the flag all the time if any sibling rule exists.
This is overkill but that code is just there for non-jit cases.
SelectorCompiler does a better job and only sets the flag if matching anything else than the rightmost element.
There is a case not optimized, :empty with descendant (e.g. foo:empty>bar). Those cases are useless in practice,
it is not worth optimizing them.
Tests: fast/css/pseudo-element-updates-on-empty.html
fast/selectors/not-empty-adjacent-style-update.html
fast/selectors/not-empty-style-update.html
- css/SelectorChecker.cpp:
(WebCore::SelectorChecker::checkOne):
- cssjit/SelectorCompiler.cpp:
(WebCore::SelectorCompiler::fragmentMatchesTheRightmostElement):
shouldUseRenderStyleFromCheckingContext() is renamed fragmentMatchesTheRightmostElement() because
it is now also used by generateElementIsEmpty() in a context where the Context's style is irrelevant.
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateSelectorChecker):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementIsActive):
(WebCore::SelectorCompiler::setStyleOfSiblingsAffectedByEmpty):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementIsEmpty):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementIsFirstChild):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementIsHovered):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementIsLastChild):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementIsOnlyChild):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementIsNthChild):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementHasPseudoElement):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateRequestedPseudoElementEqualsToSelectorPseudoElement):
(WebCore::SelectorCompiler::shouldUseRenderStyleFromCheckingContext): Deleted.
(WebCore::SelectorCompiler::setElementStyleIsAffectedByEmptyAndUpdateRenderStyleIfNecessary): Deleted.
- dom/Element.cpp:
(WebCore::checkForEmptyStyleChange):
(WebCore::Element::setStyleOfSiblingsAffectedByEmpty):
(WebCore::Element::rareDataStyleOfSiblingsAffectedByEmpty):
- dom/Element.h:
(WebCore::Element::styleOfSiblingsAffectedByEmpty):
- dom/ElementRareData.h:
(WebCore::ElementRareData::styleOfSiblingsAffectedByEmpty):
(WebCore::ElementRareData::setStyleOfSiblingsAffectedByEmpty):
(WebCore::ElementRareData::ElementRareData):
LayoutTests:
- fast/css/pseudo-element-updates-on-empty-expected.html: Added.
- fast/css/pseudo-element-updates-on-empty.html: Added.
- fast/selectors/empty-adjacent-style-update-expected.txt:
- fast/selectors/empty-adjacent-style-update.html:
- fast/selectors/empty-style-update-expected.txt:
- fast/selectors/empty-style-update.html:
- fast/selectors/not-empty-adjacent-style-update-expected.txt: Copied from LayoutTests/fast/selectors/empty-adjacent-style-update-expected.txt.
- fast/selectors/not-empty-adjacent-style-update.html: Copied from LayoutTests/fast/selectors/empty-adjacent-style-update.html.
- fast/selectors/not-empty-style-update-expected.txt: Copied from LayoutTests/fast/selectors/empty-style-update-expected.txt.
- fast/selectors/not-empty-style-update.html: Copied from LayoutTests/fast/selectors/empty-style-update.html.
- 1:41 PM Changeset in webkit [172720] by
-
- 2 edits in trunk/Source/WebCore
[Mac] Unreviewed merge correction.
- page/mac/EventHandlerMac.mm:
(WebCore::EventHandler::platformCompleteWheelEvent): Revert an
unintended change from r172705.
- 1:25 PM Changeset in webkit [172719] by
-
- 2 edits in trunk/Source/WebKit/ios
Fix the iOS build after r172709.
- WebView/WebPDFViewPlaceholder.mm:
(-[WebPDFViewPlaceholder simulateClickOnLinkToURL:]):
- 12:52 PM Changeset in webkit [172718] by
-
- 1 edit1 delete in trunk/LayoutTests
Remove a test inadvertently landed in r172709.
- fast/loader/redirect-to-invalid-url-using-javascript-disallowed-after-load.html: Removed.
- 12:11 PM Changeset in webkit [172717] by
-
- 7 edits in trunk/Source/JavaScriptCore
The parser should generate AST nodes the var declarations with no initializers
https://bugs.webkit.org/show_bug.cgi?id=135545
Patch by Saam Barati <sbarati@apple.com> on 2014-08-18
Reviewed by Geoffrey Garen.
Currently, JSC's parser ignores variable declarations
that have no assignment initializer value because all
variables are implicitly assigned to undefined. But,
type profiling needs an AST node to be generated for these
empty variable declarations because it needs to be able to
profile their text locations and to see that their type
is undefined.
- bytecompiler/NodesCodegen.cpp:
(JSC::EmptyVarExpression::emitBytecode):
- parser/ASTBuilder.h:
(JSC::ASTBuilder::createVarStatement):
(JSC::ASTBuilder::createEmptyVarExpression):
- parser/NodeConstructors.h:
(JSC::EmptyVarExpression::EmptyVarExpression):
- parser/Nodes.h:
- parser/Parser.cpp:
(JSC::Parser<LexerType>::parseVarDeclarationList):
- parser/SyntaxChecker.h:
(JSC::SyntaxChecker::createEmptyVarExpression):
- 12:07 PM Changeset in webkit [172716] by
-
- 2 edits in trunk/Source/WebCore
Small cleanup for ShapeOutsideDeltas
https://bugs.webkit.org/show_bug.cgi?id=136043
Reviewed by Zoltan Horvath.
Remove explicit initializtion of LayoutUnit members and explicitly
size the boolean flags so they pack properly.
No new tests, no behavior change.
- rendering/shapes/ShapeOutsideInfo.h:
- 11:55 AM Changeset in webkit [172715] by
-
- 2 edits in trunk/Tools
Enable Web Inspector in MiniBrowser WK2 windows
https://bugs.webkit.org/show_bug.cgi?id=136045
Reviewed by Tim Horton.
Set the pref to enable developer extras for all WK2 windows.
- MiniBrowser/mac/WK2BrowserWindowController.m:
(-[WK2BrowserWindowController awakeFromNib]):
- 11:24 AM Changeset in webkit [172714] by
-
- 4 edits in tags/Safari-600.1.10.2
Merged r172680. <rdar://problem/18049780>
- 11:23 AM Changeset in webkit [172713] by
-
- 5 edits in tags/Safari-600.1.10.2/Source/WebKit2
Merged r172660. <rdar://problem/18049780>
- 11:21 AM Changeset in webkit [172712] by
-
- 5 edits in tags/Safari-600.1.10.2/Source
Bump versioning.
- 11:18 AM Changeset in webkit [172711] by
-
- 20 edits2 adds in trunk
calc() doesn't work for SVG CSS properties
https://bugs.webkit.org/show_bug.cgi?id=136026
Reviewed by Andreas Kling.
Source/WebCore:
Make calc() work on SVG CSS properties as well. stroke-width and
stroke-dashoffset used SVGLength. SVGLength doesn't work together with
cross units length arguments like % and px (just returns 0 in these
cases). I moved these properties over to Length. All modified files
beside to SVGCSSParser are related to this switch.
Test: svg/css/parse-calc-length.html
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::ComputedStyleExtractor::propertyValue):
- css/DeprecatedStyleBuilder.cpp:
(WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder):
- css/SVGCSSComputedStyleDeclaration.cpp:
(WebCore::ComputedStyleExtractor::svgPropertyValue):
- css/SVGCSSParser.cpp:
(WebCore::CSSParser::parseSVGValue):
- css/SVGCSSStyleSelector.cpp:
(WebCore::StyleResolver::applySVGProperty):
- page/animation/CSSPropertyAnimation.cpp:
(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):
- rendering/style/RenderStyle.h:
- rendering/style/SVGRenderStyle.h:
(WebCore::SVGRenderStyle::setStrokeWidth):
(WebCore::SVGRenderStyle::setStrokeDashOffset):
(WebCore::SVGRenderStyle::strokeWidth):
(WebCore::SVGRenderStyle::strokeDashOffset):
(WebCore::SVGRenderStyle::initialStrokeDashOffset): Deleted.
(WebCore::SVGRenderStyle::initialStrokeWidth): Deleted.
- rendering/style/SVGRenderStyleDefs.cpp:
(WebCore::StyleStrokeData::StyleStrokeData):
- rendering/style/SVGRenderStyleDefs.h:
- rendering/svg/RenderSVGShape.cpp:
(WebCore::RenderSVGShape::strokeWidth):
- rendering/svg/RenderSVGText.cpp:
(WebCore::RenderSVGText::strokeBoundingBox):
- rendering/svg/SVGRenderSupport.cpp:
(WebCore::SVGRenderSupport::applyStrokeStyleToContext):
- rendering/svg/SVGRenderTreeAsText.cpp:
(WebCore::writeStyle):
- svg/SVGLengthContext.cpp:
(WebCore::SVGLengthContext::valueForLength):
LayoutTests:
Test calc() on length properties for SVG.
- svg/css/getComputedStyle-basic-expected.txt:
- svg/css/parse-calc-length-expected.txt: Added.
- svg/css/parse-calc-length.html: Added.
- 10:55 AM Changeset in webkit [172710] by
-
- 1 copy in tags/Safari-600.1.10.2
Tagging
- 10:48 AM Changeset in webkit [172709] by
-
- 13 edits12 adds10 deletes in trunk
REGRESSION (r167856): adobe.com no longer able to launch Create Cloud app using a URL with a custom scheme
https://bugs.webkit.org/show_bug.cgi?id=136010
Reviewed by Darin Adler.
Source/WebCore:
r167856 caused WebKit to stop scheduling certain kinds of navigations (window.location changes, meta-refresh,
and some calls to window.open) when the request URL is invalid. Adobe.com performs one of these navigations to
an invalid URL with an external scheme (aam:), relying on Safari's navigation policy delegate to ignore the
navigation and launch the external app registered to handle aam: URLs. Since the navigation is no longer
scheduled, the policy delegate is never executed and the external app never launches.
Instead of not scheduling the navigation, allow it to proceed until the client's policy delegate has executed
and made a decision. Only disallow the navigation if the policy delegate told WebKit to proceed with the load.
This exposes these navigations to clients via the policy delegate and via willPerformClientRedirectToURL and
didCancelClientRedirectForFrame on the frame load delegate.
To constrain this check only to the navigation types covered by r167856, only two NavigationSchedulers
(ScheduledRedirect and ScheduledLocationChange) enable the invalid URL check.
Note that r167856 also caused an iOS regression, and this was resolved in r170120 by adding a linked-on-or-after
check and a WebCore setting. Since the iOS regression is also resolved by the approach described above, this
patch reverts r170120 (but keeps some of its tests).
Tests: fast/loader/redirect-to-invalid-url-using-javascript-calls-policy-delegate.html
fast/loader/redirect-to-invalid-url-using-javascript-disallowed.html
fast/loader/redirect-to-invalid-url-using-meta-refresh-calls-policy-delegate.html
fast/loader/redirect-to-invalid-url-using-meta-refresh-disallowed.html
fast/loader/window-open-to-invalid-url-calls-policy-delegate.html
fast/loader/window-open-to-invalid-url-disallowed.html
- WebCore.exp.in: Updated the symbol FrameLoader::loadFrameRequest.
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::changeLocation): Added an AllowNavigationToInvalidURL argument; passed down to urlSelected.
(WebCore::FrameLoader::urlSelected): Added an AllowNavigationToInvalidURL argument; passed down to loadFrameRequest.
(WebCore::FrameLoader::loadURLIntoChildFrame): Passed AllowNavigationToInvalidURL::Yes to loadURL.
(WebCore::FrameLoader::loadFrameRequest): Added an AllowNavigationToInvalidURL argument; passed down to loadURL and loadPostRequest.
(WebCore::FrameLoader::loadURL): Added an AllowNavigationToInvalidURL argument; passed down to continueLoadAfterNewWindowPolicy and loadWithNavigationAction.
(WebCore::FrameLoader::loadPostRequest): Ditto.
(WebCore::FrameLoader::load): Passed AllowNavigationToInvalidURL::Yes to continueLoadAfterNewWindowPolicy.
(WebCore::FrameLoader::loadWithNavigationAction): Added an AllowNavigationToInvalidURL argument; passed down to loadWithDocumentLoader.
(WebCore::FrameLoader::loadWithDocumentLoader): Added an AllowNavigationToInvalidURL argument; passed down to continueLoadAfterNavigationPolicy.
(WebCore::FrameLoader::reloadWithOverrideEncoding): Passed AllowNavigationToInvalidURL::Yes to loadWithDocumentLoader.
(WebCore::FrameLoader::reload): Ditto.
(WebCore::FrameLoader::continueLoadAfterNavigationPolicy):
Added an AllowNavigationToInvalidURL argument; if its value is No and the request's URL is invalid, do not continue.
Added a FIXME about calling clientRedirectCancelledOrFinished on non-quick redirect cancellations.
(WebCore::FrameLoader::continueLoadAfterNewWindowPolicy): Added an AllowNavigationToInvalidURL argument; passed down to loadWithNavigationAction.
(WebCore::FrameLoader::loadDifferentDocumentItem): Passed AllowNavigationToInvalidURL::Yes to either loadWithDocumentLoader or loadWithNavigationAction.
- loader/FrameLoader.h:
- loader/FrameLoaderTypes.h: Defined AllowNavigationToInvalidURL to have values of Yes and No.
- loader/NavigationScheduler.cpp:
(WebCore::ScheduledRedirect::fire): Passed AllowNavigationToInvalidURL::No to FrameLoader::changeLocation.
(WebCore::ScheduledLocationChange::fire): Ditto.
(WebCore::NavigationScheduler::shouldScheduleNavigation): Removed the URL::isValid check.
(WebCore::NavigationScheduler::scheduleLocationChange): Passed AllowNavigationToInvalidURL::No to FrameLoder::changeLocation during fragment navigations.
- page/ContextMenuController.cpp:
(WebCore::openNewWindow): Passed AllowNavigationToInvalidURL::Yes to FrameLoader::loadFrameRequest.
(WebCore::ContextMenuController::contextMenuItemSelected): Ditto.
- page/Settings.in: Removed allowNavigationToInvalidURL.
Source/WebKit/mac:
- Misc/WebKitVersionChecks.h: Removed WEBKIT_FIRST_VERSION_WITH_NAVIGATION_URL_VALIDATION.
- WebView/WebPDFView.mm:
(-[WebPDFView PDFViewWillClickOnLink:withURL:]): Passed AllowNavigationToInvalidURL::Yes to FrameLoader::loadFrameRequest.
- WebView/WebView.mm:
(-[WebView _preferencesChanged:]): Reverted the linked-on-or-after check added in r170120 since it's no longer necessary.
LayoutTests:
Removed tests that verified the behavior of setAllowNavigationToInvalidURL(true), which no longer exists:
- fast/loader/allow-redirect-to-invalid-url-using-javascript-expected.txt: Removed.
- fast/loader/allow-redirect-to-invalid-url-using-javascript.html: Removed.
- fast/loader/allow-redirect-to-invalid-url-using-meta-refresh-expected.txt: Removed.
- fast/loader/allow-redirect-to-invalid-url-using-meta-refresh.html: Removed.
Added tests that verify the policy delegate is executed on some navigations to invalid URLs:
- fast/loader/redirect-to-invalid-url-using-javascript-calls-policy-delegate-expected.txt: Added.
- fast/loader/redirect-to-invalid-url-using-javascript-calls-policy-delegate.html: Added.
- fast/loader/redirect-to-invalid-url-using-meta-refresh-calls-policy-delegate-expected.txt: Added.
- fast/loader/redirect-to-invalid-url-using-meta-refresh-calls-policy-delegate.html: Added.
- fast/loader/window-open-to-invalid-url-calls-policy-delegate-expected.txt: Added.
- fast/loader/window-open-to-invalid-url-calls-policy-delegate.html: Added.
Renamed some existing tests added in r170120, modified them to log willPerformClientRedirectToURL and
didCancelClientRedirectForFrame, and added a test to verify navigations in existing frames via window.open:
- fast/loader/redirect-to-invalid-url-using-javascript-disallowed-expected.txt: Renamed from fast/loader/disallow-redirect-to-invalid-url-using-javascript-expected.txt.
- fast/loader/redirect-to-invalid-url-using-javascript-disallowed.html: Renamed from fast/loader/disallow-redirect-to-invalid-url-using-javascript.html.
- fast/loader/redirect-to-invalid-url-using-meta-refresh-disallowed-expected.txt: Renamed from fast/loader/disallow-redirect-to-invalid-url-using-meta-refresh-expected.txt.
- fast/loader/redirect-to-invalid-url-using-meta-refresh-disallowed.html: Renamed from fast/loader/disallow-redirect-to-invalid-url-using-meta-refresh.html.
- fast/loader/window-open-to-invalid-url-disallowed-expected.txt: Added.
- fast/loader/window-open-to-invalid-url-disallowed.html: Added.
- 10:08 AM Changeset in webkit [172708] by
-
- 5 edits in branches/safari-600.1.4.11-branch/Source
Versioning.
- 10:08 AM Changeset in webkit [172707] by
-
- 11 edits in trunk
Completed iterator can be revived by adding more than one new entry to the target object
https://bugs.webkit.org/show_bug.cgi?id=129993
Patch by Diego Pino Garcia <Diego Pino Garcia> on 2014-08-18
Reviewed by Oliver Hunt.
Source/JavaScriptCore:
When iterator reaches end, finish iterator.
- runtime/JSMapIterator.h:
(JSC::JSMapIterator::finish):
- runtime/JSSetIterator.h:
(JSC::JSSetIterator::finish):
- runtime/MapData.h:
(JSC::MapData::const_iterator::finish): set index of iterator to max
Int32.
- runtime/MapIteratorPrototype.cpp:
(JSC::MapIteratorPrototypeFuncNext):
- runtime/SetIteratorPrototype.cpp:
(JSC::SetIteratorPrototypeFuncNext):
LayoutTests:
Test a Map or Set iterator should remain dead after using it.
- js/basic-map-expected.txt:
- js/basic-set-expected.txt:
- js/script-tests/basic-map.js:
(set var):
(set map):
- js/script-tests/basic-set.js:
(keys.set keys):
(set add.set add):
- 10:02 AM Changeset in webkit [172706] by
-
- 3 edits2 adds in trunk
Fix keyTimes list length of from/to/by animations.
https://bugs.webkit.org/show_bug.cgi?id=136037
Patch by Renata Hodovan <rhodovan.u-szeged@partner.samsung.com> on 2014-08-18
Reviewed by Darin Adler.
Source/WebCore:
For from/to/by animations, the length of keyTimes and keyPoints
attribute if are specified must be equal and must have at least
2 values.
This is backport of my fix in Blink: https://codereview.chromium.org/453243003/
Test: svg/animations/invalid-keytime-number-crash.html
- svg/SVGAnimationElement.cpp:
(WebCore::SVGAnimationElement::startedActiveInterval):
LayoutTests:
- svg/animations/invalid-keytime-number-crash-expected.txt: Added.
- svg/animations/invalid-keytime-number-crash.html: Added.
- 9:51 AM Changeset in webkit [172705] by
-
- 4 edits in trunk/Source/WebCore
[Mac] Follow-up to r136040 based on Darin Adler's comments.
Pass Widget* as a Widget&, since it can never be null.
- page/EventHandler.cpp:
(WebCore::EventHandler::platformCompletePlatformWidgetWheelEvent):
(WebCore::EventHandler::handleWheelEvent):
- page/EventHandler.h:
- page/mac/EventHandlerMac.mm:
(WebCore::EventHandler::platformCompleteWheelEvent):
(WebCore::EventHandler::platformCompletePlatformWidgetWheelEvent):
- 9:35 AM Changeset in webkit [172704] by
-
- 2 edits in trunk/Websites/webkit.org
Remove people that have left Adobe from Security Contact list
https://bugs.webkit.org/show_bug.cgi?id=135256
Reviewed by Alexey Proskuryakov.
- security/security-group-members.html:
- 8:54 AM Changeset in webkit [172703] by
-
- 4 edits in trunk/Source/WebCore
[Mac] Gesture scrolls don't work in the WebKit1 clients after scrolling a non-scrollable iFrame
https://bugs.webkit.org/show_bug.cgi?id=136029
<rdar://problem/17767169>
Reviewed by Maciej Stachowiak.
This is difficult to test in our layout tests, since it relies on specific host application
behavior.
If the platform widget is a frame view (IFrame), and we are in WebKit1, 'passWheelEventToWidget'
has already called 'scrollWheel' on the underlying platform widget. We need to return true in
this case to avoid getting multiple copies of the scrollWheel event sent to the platform widget.
- page/EventHandler.cpp:
(WebCore::EventHandler::platformCompletePlatformWidgetWheelEvent): Revise default stub to
accept a Widget* argument.
(WebCore::EventHandler::handleWheelEvent):
- page/EventHandler.h:
- page/mac/EventHandlerMac.mm:
(WebCore::EventHandler::platformCompletePlatformWidgetWheelEvent): Check for WK1 case and
return 'true' when the underlying NSScrollView has been issues a scrollWheel event.
- 3:01 AM Changeset in webkit [172702] by
-
- 1 edit1 add in trunk/LayoutTests
Unreviewed GTK gardening. Adding a GTK-specific baseline
that's required after changes in r172620.
- platform/gtk/editing/pasteboard/onpaste-text-html-expected.txt: Added.
- 2:52 AM Changeset in webkit [172701] by
-
- 3 edits in trunk/Tools
master.cfg should handle special return codes of run-perf-tests
https://bugs.webkit.org/show_bug.cgi?id=135974
Patch by Renato Nagy <nagy.renato@stud.u-szeged.hu> on 2014-08-18
Reviewed by Ryosuke Niwa.
- BuildSlaveSupport/build.webkit.org-config/master.cfg:
(RunAndUploadPerfTests.getText2):
- BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
(RunAndUploadPerfTestsTest):
(RunAndUploadPerfTestsTest.assertResults):
(RunAndUploadPerfTestsTest.test_tests_failed):
(RunAndUploadPerfTestsTest.test_build_bad_build):
(RunAndUploadPerfTestsTest.test_build_bad_source_json):
(RunAndUploadPerfTestsTest.test_build_bad_marge):
(RunAndUploadPerfTestsTest.test_build_bad_failed_uploading):
(RunAndUploadPerfTestsTest.test_build_bad_preparation):
- 1:16 AM Changeset in webkit [172700] by
-
- 2 edits in trunk/Source/WebKit2
[EFL] ewk_init() is sufficient to initialize EFL components
https://bugs.webkit.org/show_bug.cgi?id=136036
Reviewed by Gyuyoung Kim.
Developers do not have to initialize EFL components as ewk_init()
already does it.
- UIProcess/API/efl/ewk_intro.h:
- 12:35 AM Changeset in webkit [172699] by
-
- 8 edits1 move10 adds11 deletes in trunk
Revert r172697.
It made several webarchive layout tests flaky and didn't have the correct behavior for non-quick redirects.
Source/WebCore:
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::continueLoadAfterNavigationPolicy):
- loader/NavigationScheduler.cpp:
(WebCore::NavigationScheduler::shouldScheduleNavigation):
- page/Settings.in:
Source/WebKit/mac:
- Misc/WebKitVersionChecks.h:
- WebView/WebView.mm:
(-[WebView _preferencesChanged:]):
LayoutTests:
- fast/loader/allow-redirect-to-invalid-url-using-javascript-expected.txt: Added.
- fast/loader/allow-redirect-to-invalid-url-using-javascript.html: Added.
- fast/loader/allow-redirect-to-invalid-url-using-meta-refresh-expected.txt: Added.
- fast/loader/allow-redirect-to-invalid-url-using-meta-refresh.html: Added.
- fast/loader/disallow-redirect-to-invalid-url-using-javascript-expected.txt: Added.
- fast/loader/disallow-redirect-to-invalid-url-using-javascript.html: Added.
- fast/loader/disallow-redirect-to-invalid-url-using-meta-refresh-expected.txt: Added.
- fast/loader/disallow-redirect-to-invalid-url-using-meta-refresh.html: Added.
- fast/loader/redirect-to-invalid-url-using-javascript-calls-policy-delegate-expected.txt: Removed.
- fast/loader/redirect-to-invalid-url-using-javascript-calls-policy-delegate.html: Removed.
- fast/loader/redirect-to-invalid-url-using-javascript-disallowed-expected.txt: Removed.
- fast/loader/redirect-to-invalid-url-using-javascript-disallowed.html: Removed.
- fast/loader/redirect-to-invalid-url-using-meta-refresh-calls-policy-delegate-expected.txt: Removed.
- fast/loader/redirect-to-invalid-url-using-meta-refresh-calls-policy-delegate.html: Removed.
- fast/loader/redirect-to-invalid-url-using-meta-refresh-disallowed-expected.txt: Removed.
- fast/loader/redirect-to-invalid-url-using-meta-refresh-disallowed.html: Removed.
- fast/loader/resources/redirect-to-invalid-url-using-javascript.html: Added.
- fast/loader/resources/redirect-to-invalid-url-using-meta-refresh.html: Added.
- fast/loader/window-open-to-invalid-url-calls-policy-delegate-expected.txt: Removed.
- fast/loader/window-open-to-invalid-url-calls-policy-delegate.html: Removed.
- fast/loader/window-open-to-invalid-url-disallowed-expected.txt: Removed.
- fast/loader/window-open-to-invalid-url-disallowed.html: Removed.
Aug 17, 2014:
- 11:03 PM Changeset in webkit [172698] by
-
- 4 edits in trunk
[CMake] Optimization-disabling compiler flags should be appended to CMAKE_C(XX)_FLAGS_RELEASE
https://bugs.webkit.org/show_bug.cgi?id=135980
Reviewed by Martin Robinson.
CMAKE_C(XX)_FLAGS_RELEASE variables usually contain the -On flag which
overrides any other disabled optimization that was prepended to these
variables or was added to the CMAKE_C(XX)_FLAGS variables which CMake
lists first in the final list of compilation flags.
To avoid -On re-enabling optimizations that we'd like to keep disabled,
the specific compiler flags must be appended to CMAKE_C(XX)_FLAGS_RELEASE.
- Source/cmake/OptionsCommon.cmake:
- Source/cmake/OptionsEfl.cmake: Also do the appending with CMAKE_SHARED_LINKER_FLAGS_RELEASE.
- Source/cmake/OptionsGTK.cmake:
- 9:37 PM Changeset in webkit [172697] by
-
- 8 edits12 adds10 deletes in trunk
REGRESSION (r167856): adobe.com no longer able to launch Create Cloud app using a URL with a custom scheme
https://bugs.webkit.org/show_bug.cgi?id=136010
Reviewed by Darin Adler.
Source/WebCore:
r167856 caused WebKit to stop scheduling certain kinds of navigations (window.location changes, meta-refresh,
and some calls to window.open) when the request URL is invalid. Adobe.com performs one of these navigations to
an invalid URL with an external scheme (aam:), relying on Safari's navigation policy delegate to ignore the
navigation and launch the external app registered to handle aam: URLs. Since the navigation is no longer
scheduled, the policy delegate is never executed and the external app never launches.
Instead of not scheduling the navigation, allow it to proceed until the client's policy delegate has executed
and made a decision. Only disallow the navigation if the policy delegate told WebKit to proceed with the load.
This exposes these navigations to clients via the policy delegate and via willPerformClientRedirectToURL and
didCancelClientRedirectForFrame on the frame load delegate.
Note that r167856 also caused an iOS regression, and this was resolved in r170120 by adding a linked-on-or-after
check and a WebCore setting. Since the iOS regression is also resolved by the approach described above, this
patch reverts r170120 (but keeps some of its tests).
Tests: fast/loader/redirect-to-invalid-url-using-javascript-calls-policy-delegate.html
fast/loader/redirect-to-invalid-url-using-javascript-disallowed.html
fast/loader/redirect-to-invalid-url-using-meta-refresh-calls-policy-delegate.html
fast/loader/redirect-to-invalid-url-using-meta-refresh-disallowed.html
fast/loader/window-open-to-invalid-url-calls-policy-delegate.html
fast/loader/window-open-to-invalid-url-disallowed.html
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::continueLoadAfterNavigationPolicy): Do not continue if the navigation will be a redirect
to an invalid URL.
- loader/NavigationScheduler.cpp:
(WebCore::NavigationScheduler::shouldScheduleNavigation): Resumed scheduling navigations to invalid URLs.
- page/Settings.in: Removed the allowNavigationToInvalidURL setting.
Source/WebKit/mac:
Reverted the linked-on-or-after check added in r170120 since it is no longer necessary.
- Misc/WebKitVersionChecks.h:
- WebView/WebView.mm:
(-[WebView _preferencesChanged:]):
LayoutTests:
Removed tests that verified the behavior of setAllowNavigationToInvalidURL(true), which no longer exists:
- fast/loader/allow-redirect-to-invalid-url-using-javascript-expected.txt: Removed.
- fast/loader/allow-redirect-to-invalid-url-using-javascript.html: Removed.
- fast/loader/allow-redirect-to-invalid-url-using-meta-refresh-expected.txt: Removed.
- fast/loader/allow-redirect-to-invalid-url-using-meta-refresh.html: Removed.
Added tests that verify the policy delegate is executed on some navigations to invalid URLs:
- fast/loader/redirect-to-invalid-url-using-javascript-calls-policy-delegate-expected.txt: Added.
- fast/loader/redirect-to-invalid-url-using-javascript-calls-policy-delegate.html: Added.
- fast/loader/redirect-to-invalid-url-using-meta-refresh-calls-policy-delegate-expected.txt: Added.
- fast/loader/redirect-to-invalid-url-using-meta-refresh-calls-policy-delegate.html: Added.
- fast/loader/window-open-to-invalid-url-calls-policy-delegate-expected.txt: Added.
- fast/loader/window-open-to-invalid-url-calls-policy-delegate.html: Added.
Renamed some existing tests added in r170120, modified them to log willPerformClientRedirectToURL and
didCancelClientRedirectForFrame, and added a test to verify navigations in existing frames via window.open:
- fast/loader/redirect-to-invalid-url-using-javascript-disallowed-expected.txt: Renamed from fast/loader/disallow-redirect-to-invalid-url-using-javascript-expected.txt.
- fast/loader/redirect-to-invalid-url-using-javascript-disallowed.html: Renamed from fast/loader/disallow-redirect-to-invalid-url-using-javascript.html.
- fast/loader/redirect-to-invalid-url-using-meta-refresh-disallowed-expected.txt: Renamed from fast/loader/disallow-redirect-to-invalid-url-using-meta-refresh-expected.txt.
- fast/loader/redirect-to-invalid-url-using-meta-refresh-disallowed.html: Renamed from fast/loader/disallow-redirect-to-invalid-url-using-meta-refresh.html.
- fast/loader/window-open-to-invalid-url-disallowed-expected.txt: Added.
- fast/loader/window-open-to-invalid-url-disallowed.html: Added.
- 12:54 PM Changeset in webkit [172696] by
-
- 2 edits in trunk/Tools
[Win] Unreviewed change to force rebuild
(plus drive-by add an accessor I wanted for
some future tooling).
- WinLauncher/WinLauncher.h:
(WinLauncher::webView): Added.
- 8:35 AM Changeset in webkit [172695] by
-
- 2 edits in trunk/WebKitLibraries
[Win] Unreviewed build fix.
Upload static VS2013 version of WebKitSystemInterface.
- win/lib32/WebKitSystemInterface.lib: