Context Navigation

← Previous Period
Next Period →

Timeline

Aug 21, 2014:

10:41 PM Changeset in webkit [172855] by achristensen@apple.com

2 edits in trunk/Tools

[Win] Another unreviewed build fix.

DumpRenderTree/config.h:

Defined WEBCORE_EXPORT on Windows.

10:38 PM Changeset in webkit [172854] by Antti Koivisto

10 edits
2 adds in trunk

Animated GIFs scrolled out of view still cause titlebar blur to update, on tumblr.com page
https://bugs.webkit.org/show_bug.cgi?id=136139

Reviewed by Simon Fraser.

Source/WebCore:

The mechanism for pausing GIF images outside the viewport did not work for subframes.

Test: fast/repaint/no-animation-outside-viewport-subframe.html

WebCore.exp.in:
page/FrameView.cpp:

(WebCore::FrameView::scrollPositionChanged):
(WebCore::FrameView::resumeVisibleImageAnimationsIncludingSubframes):

Add a function for resuming animations as needed in all subframes.
This is used after scrolling instead of calling the RenderView function directly.

page/FrameView.h:
page/Page.cpp:

(WebCore::Page::resumeAnimatingImages):

rendering/RenderElement.cpp:

(WebCore::RenderElement::newImageAnimationFrameAvailable):

Determine the overall visible rect so that it is correct in subframes too.

rendering/RenderLayer.cpp:

(WebCore::RenderLayer::scrollTo):

rendering/RenderView.cpp:

(WebCore::RenderView::resumePausedImageAnimationsIfNeeded):

LayoutTests:

fast/repaint/no-animation-outside-viewport-subframe-expected.txt: Added.
fast/repaint/no-animation-outside-viewport-subframe.html: Added.

10:30 PM Changeset in webkit [172853] by mark.lam@apple.com

3 edits in trunk/Source/JavaScriptCore

r171362 accidentally increased the size of InlineCallFrame.
<https://webkit.org/b/136141>

Reviewed by Filip Pizlo.

r171362 increased the size of InlineCallFrame::kind to 2 bits. This increased
the size of InlineCallFrame from 72 to 80 though not intentionally. The fix
is to reduce the size of InlineCallFrame::stackOffset to 29 bits.

Also added an assert to ensure that we never set a value that exceeds the size
of InlineCallFrame::stackOffset.

bytecode/CodeOrigin.h:

(JSC::InlineCallFrame::setStackOffset):

dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):

10:27 PM Changeset in webkit [172852] by achristensen@apple.com

2 edits in trunk/Source/WebKit/win

[Win] Unreviewed build fix after r172849.

WebKitPrefix.h:

Defined WEBCORE_EXPORT.

10:22 PM Changeset in webkit [172851] by matthew_hanson@apple.com

2 edits in branches/safari-600.1-branch/Source/WebCore

Merge r172841. <rdar://problem/17733682>

10:20 PM Changeset in webkit [172850] by matthew_hanson@apple.com

11 edits in branches/safari-600.1-branch

Merge r172707. <rdar://problem/18043281>

9:21 PM Changeset in webkit [172849] by achristensen@apple.com

183 edits in trunk/Source/WebCore

More WEBCORE_EXPORT macros!
https://bugs.webkit.org/show_bug.cgi?id=136146

Reviewed by Benjamin Poulain.

Modules/geolocation/GeolocationClient.h:
Modules/mediastream/UserMediaClient.h:
Modules/mediastream/UserMediaRequest.h:
Modules/notifications/NotificationClient.h:
Modules/speech/SpeechSynthesis.h:
bindings/generic/RuntimeEnabledFeatures.h:
bindings/js/DOMWrapperWorld.h:
bindings/js/GCController.h:
bindings/js/IDBBindingUtilities.h:
bindings/js/JSDOMBinding.h:
bindings/js/JSNodeCustom.h:
bindings/js/JSNodeListCustom.h:
bindings/js/JSPluginElementFunctions.h:
bindings/js/ScriptController.h:
bindings/js/SerializedScriptValue.h:
crypto/SerializedCryptoKeyWrap.h:
css/LengthFunctions.h:
css/StyleProperties.h:
css/StyleSheetContents.h:
dom/DeviceOrientationClient.h:
dom/Range.h:
dom/ScriptExecutionContext.h:
dom/StyledElement.h:
dom/TreeScope.h:
dom/UIEventWithKeyState.h:
dom/UserGestureIndicator.h:
dom/UserTypingGestureIndicator.h:
dom/ViewportArguments.h:
editing/SmartReplace.h:
editing/TextIterator.h:
editing/VisiblePosition.h:
editing/VisibleSelection.h:
editing/VisibleUnits.h:
editing/cocoa/HTMLConverter.h:
editing/htmlediting.h:
editing/mac/TextAlternativeWithRange.h:
editing/mac/TextUndoInsertionMarkupMac.h:
editing/markup.h:
history/HistoryItem.cpp:
history/PageCache.h:
html/TimeRanges.h:
html/parser/HTMLParserIdioms.h:
inspector/InstrumentingAgents.h:
loader/FrameLoader.h:
loader/ResourceBuffer.h:
loader/ResourceLoadScheduler.h:
loader/ResourceLoader.h:

(WebCore::ResourceLoader::originalRequest):

loader/SubframeLoader.h:
loader/SubresourceLoader.h:
loader/TextResourceDecoder.h:
loader/appcache/ApplicationCacheStorage.h:
loader/cache/MemoryCache.h:
loader/icon/IconDatabaseBase.h:
loader/ios/DiskImageCacheIOS.h:
page/Chrome.h:
page/SecurityOrigin.h:
page/SecurityPolicy.h:
page/Settings.h:
page/UserContentController.h:
page/UserContentURLPattern.h:
page/UserMessageHandlerDescriptor.h:
page/ViewportConfiguration.h:
page/VisitedLinkStore.h:
page/WheelEventDeltaTracker.h:
page/cocoa/UserAgent.h:
page/scrolling/ScrollingConstraints.h:
page/scrolling/ScrollingCoordinator.h:
page/scrolling/ScrollingStateFixedNode.h:
page/scrolling/ScrollingStateFrameScrollingNode.h:
page/scrolling/ScrollingStateNode.h:
page/scrolling/ScrollingStateOverflowScrollingNode.h:
page/scrolling/ScrollingStateScrollingNode.h:
page/scrolling/ScrollingStateStickyNode.h:
page/scrolling/ScrollingStateTree.h:
page/scrolling/ScrollingThread.h:
page/scrolling/ScrollingTree.h:
page/scrolling/ScrollingTreeOverflowScrollingNode.h:
page/scrolling/ScrollingTreeScrollingNode.h:
page/scrolling/ios/ScrollingTreeFrameScrollingNodeIOS.h:
page/scrolling/mac/ScrollingTreeFixedNode.h:
page/scrolling/mac/ScrollingTreeFrameScrollingNodeMac.h:
page/scrolling/mac/ScrollingTreeStickyNode.h:
platform/Cursor.h:
platform/DragImage.h:
platform/FileSystem.h:
platform/Language.h:
platform/LinkHash.h:
platform/LocalizedStrings.h:
platform/Logging.h:
platform/MemoryPressureHandler.h:
platform/NotImplemented.h:
platform/PlatformStrategies.h:
platform/PublicSuffix.h:
platform/RuntimeApplicationChecks.h:
platform/RuntimeApplicationChecksIOS.h:
platform/SchemeRegistry.h:
platform/ScrollView.h:
platform/ScrollableArea.h:
platform/Scrollbar.h:
platform/ScrollbarTheme.h:
platform/SharedBuffer.h:
platform/ThreadCheck.h:
platform/ThreadGlobalData.h:
platform/Timer.h:
platform/URL.h:
platform/UUID.h:
platform/UserActivity.h:
platform/Widget.h:
platform/cf/CFURLExtras.h:
platform/cf/RunLoopObserver.h:
platform/cocoa/SystemVersion.h:
platform/graphics/Color.h:
platform/graphics/FloatRect.h:
platform/graphics/FontCache.h:
platform/graphics/GeometryUtilities.h:
platform/graphics/GraphicsContext.h:
platform/graphics/IntRect.h:
platform/graphics/LayoutRect.h:
platform/graphics/StringTruncator.h:
platform/graphics/TextRun.h:
platform/graphics/ca/TileController.h:
platform/graphics/ca/mac/PlatformCAAnimationMac.h:
platform/graphics/cg/GraphicsContextCG.h:
platform/graphics/mac/ColorMac.h:
platform/graphics/transforms/TransformationMatrix.h:
platform/ios/FileSystemIOS.h:
platform/ios/PlatformEventFactoryIOS.h:
platform/ios/SelectionRect.h:
platform/ios/SystemMemory.h:
platform/ios/TileControllerMemoryHandlerIOS.h:
platform/ios/WebVideoFullscreenInterfaceAVKit.h:
platform/mac/PlatformEventFactoryMac.h:
platform/mac/ScrollbarThemeMac.h:
platform/mac/WebCoreNSURLExtras.h:
platform/mac/WebNSAttributedStringExtras.h:
platform/network/BlobRegistry.h:
platform/network/CookieStorage.h:
platform/network/DNS.h:
platform/network/NetworkStateNotifier.h:
platform/network/PlatformCookieJar.h:
platform/network/ProxyServer.h:
platform/network/ResourceErrorBase.h:
platform/network/ResourceHandle.h:
platform/network/ResourceHandleClient.h:
platform/network/ResourceRequestBase.h:
platform/network/ResourceResponseBase.h:
platform/network/SynchronousLoaderClient.h:
platform/network/cf/ResourceError.h:
platform/network/cf/ResourceRequest.h:
platform/network/cf/ResourceResponse.h:
platform/network/ios/QuickLook.h:
platform/network/mac/AuthenticationMac.h:
platform/sql/SQLiteDatabase.cpp:
platform/text/LocaleToScriptMapping.h:
platform/text/TextBreakIterator.h:
platform/text/TextEncoding.h:

(WebCore::TextEncoding::decode):

platform/text/TextEncodingRegistry.h:
platform/text/TextStream.h:
rendering/RenderBlock.h:
rendering/RenderBox.h:
rendering/RenderEmbeddedObject.h:
rendering/RenderLayer.h:
rendering/RenderLayerBacking.h:
rendering/RenderLayerCompositor.h:
rendering/RenderListItem.h:
rendering/RenderObject.h:
rendering/RenderText.h:
rendering/RenderTextControl.h:
rendering/RenderThemeIOS.h:
rendering/RenderTreeAsText.h:
rendering/RenderView.h:
rendering/RenderWidget.h:
rendering/ScrollBehavior.cpp:
rendering/break_lines.cpp:
rendering/style/RenderStyle.h:
replay/UserInputBridge.h:
storage/StorageEventDispatcher.h:
storage/StorageMap.h:
storage/StorageStrategy.h:
storage/StorageTracker.h:
testing/Internals.h:
workers/WorkerThread.h:

Added more WEBCORE_EXPORT macros where needed.

8:55 PM Changeset in webkit [172848] by matthew_hanson@apple.com

5 edits in branches/safari-600.1-branch/Source

Versioning.

8:35 PM Changeset in webkit [172847] by Alan Bujtas

2 edits
1 add
1 delete in trunk/LayoutTests

ruby-base-merge-block-children-crash-2.html should not use render tree dump.

Unreviewed gardening.

fast/ruby/ruby-base-merge-block-children-crash-2-expected.txt: Added.
fast/ruby/ruby-base-merge-block-children-crash-2.html: restore previous version of the test.
platform/mac/fast/ruby/ruby-base-merge-block-children-crash-2-expected.txt: Removed.

8:27 PM Changeset in webkit [172846] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit2

Possible RetainPtr misuse in WKScriptMessage.mm - could leak
https://bugs.webkit.org/show_bug.cgi?id=136140

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-08-21
Reviewed by Darin Adler.

Adopt a copy into a RetainPtr to avoid leaking.

UIProcess/API/Cocoa/WKScriptMessage.mm:

(-[WKScriptMessage _initWithBody:webView:frameInfo:name:]):

8:22 PM Changeset in webkit [172845] by commit-queue@webkit.org

2 edits in trunk/Source/JavaScriptCore

Web Inspector: RetainPtr misuse, CFRunLoopSource leak
https://bugs.webkit.org/show_bug.cgi?id=136143

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-08-21
Reviewed by Timothy Hatcher.

Adopt a Create into the RetainPtr to avoid leaking.

inspector/remote/RemoteInspectorDebuggableConnection.mm:

(Inspector::RemoteInspectorDebuggableConnection::setupRunLoop):

8:14 PM Changeset in webkit [172844] by timothy_horton@apple.com

138 edits in trunk/Source

Revert r172831, it broke the Windows build.

wtf/ExportMacros.h:

... and many more.

8:07 PM Changeset in webkit [172843] by Alan Bujtas

1 edit
2 deletes in trunk/LayoutTests

Remove flaky saturated reftest. UnitTest takes care of saturated arithmetics.

Unreviewed gardening.

fast/dynamic/saturated-layout-arithmetic-expected.html: Removed.
fast/dynamic/saturated-layout-arithmetic.html: Removed.

6:28 PM Changeset in webkit [172842] by ryuan.choi@samsung.com

2 edits in trunk/Source/WebCore

Unreviewed build fix when RUBBER_BANDING is not enabled.

rendering/RenderLayer.cpp:

(WebCore::RenderLayer::overhangAmount):
(WebCore::RenderLayer::setHasHorizontalScrollbar):
(WebCore::RenderLayer::setHasVerticalScrollbar):

6:19 PM Changeset in webkit [172841] by Brent Fulgham

2 edits in trunk/Source/WebCore

[Win] WebCore.proj is not copying WebKit resource files.
https://bugs.webkit.org/show_bug.cgi?id=136142
<rdar://problem/17733682>

Reviewed by Tim Horton.

WebCore.vcxproj/WebCore.proj: Copy missing resource files during

post-build step.

5:25 PM Changeset in webkit [172840] by commit-queue@webkit.org

2 edits in trunk/Tools

[EFL][WK2] Minibrowser : Add stop button to abort page load
https://bugs.webkit.org/show_bug.cgi?id=136122

Patch by Rohit Kumar <kumar.rohit@samsung.com> on 2014-08-21
Reviewed by Gyuyoung Kim.

MiniBrowser/efl/main.c:

(on_key_down):
(on_stop_button_clicked): Callback for stop button press.
(window_create):

4:49 PM Changeset in webkit [172839] by Simon Fraser

3 edits
1 add in trunk/Source/WebInspectorUI

Add a button to enable paint flashing in the web inspector
https://bugs.webkit.org/show_bug.cgi?id=136133

Reviewed by Tim Hatcher.

Add a button to the right of the layer borders button to turn on paint flashing.
Future patches will actually enable this feature.

Localizations/en.lproj/localizedStrings.js: Tooltip strings.
UserInterface/Images/PaintFlashing.svg: Added. "Paintbrush" icon.
UserInterface/Views/DOMTreeContentView.js:

(WebInspector.DOMTreeContentView):
(WebInspector.DOMTreeContentView.prototype.get navigationItems):
(WebInspector.DOMTreeContentView.prototype._togglePaintFlashing):

4:11 PM Changeset in webkit [172838] by mark.lam@apple.com

2 edits in trunk/Source/JavaScriptCore

REGRESSION(r172808): It made 6 different tests fail on 32 bit platforms.
<https://webkit.org/b/136123>

Reviewed by Filip Pizlo.

The original patch in r172808 removed the code to skip the top scope in
the 64-bit port of JIT::emitResolveClosure() but not in the 32-bit port.
This patch fixes that and achieves parity.

jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::emitResolveClosure):

4:09 PM Changeset in webkit [172837] by Simon Fraser

2 edits in trunk/Source/WebCore

Try to fix the 32-bit build by using wildcards in the exported non-virtual thunks
for GraphicsLayerCA::platformCALayerAnimationStarted and GraphicsLayerCA::platformCALayerAnimationEnded.

WebCore.exp.in:

3:43 PM Changeset in webkit [172836] by Simon Fraser

31 edits in trunk/Source

Add animationDidEnd callbacks on GraphicsLayer
https://bugs.webkit.org/show_bug.cgi?id=136084

Reviewed by Tim Horton.

Hook up GraphicsLayerClient::notifyAnimationEnded() so that code using GraphicsLayers directly
can add animations, and know when they finish.

Source/WebCore:

WebCore.exp.in:
platform/graphics/GraphicsLayerClient.h:

(WebCore::GraphicsLayerClient::notifyAnimationStarted):
(WebCore::GraphicsLayerClient::notifyAnimationEnded):

platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::platformCALayerAnimationStarted):
(WebCore::GraphicsLayerCA::platformCALayerAnimationEnded):

platform/graphics/ca/GraphicsLayerCA.h:
platform/graphics/ca/PlatformCALayer.h:
platform/graphics/ca/PlatformCALayerClient.h:

(WebCore::PlatformCALayerClient::platformCALayerAnimationStarted):
(WebCore::PlatformCALayerClient::platformCALayerAnimationEnded):

platform/graphics/ca/mac/PlatformCALayerMac.h:
platform/graphics/ca/mac/PlatformCALayerMac.mm:

(-[WebAnimationDelegate animationDidStart:]):
(-[WebAnimationDelegate animationDidStop:finished:]):
(PlatformCALayerMac::animationStarted):
(PlatformCALayerMac::animationEnded):

rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::notifyAnimationStarted):

rendering/RenderLayerBacking.h:

Source/WebKit2:

UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.h:
UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.mm:

(WebKit::RemoteLayerTreeDrawingAreaProxy::acceleratedAnimationDidEnd):

UIProcess/mac/RemoteLayerTreeHost.h:
UIProcess/mac/RemoteLayerTreeHost.mm:

(WebKit::RemoteLayerTreeHost::animationDidEnd):

WebProcess/WebPage/DrawingArea.h:

(WebKit::DrawingArea::acceleratedAnimationDidEnd):

WebProcess/WebPage/DrawingArea.messages.in:
WebProcess/WebPage/mac/PlatformCAAnimationRemote.mm:

(-[WKAnimationDelegate animationDidStop:finished:]):

WebProcess/WebPage/mac/PlatformCALayerRemote.cpp:

(WebKit::PlatformCALayerRemote::animationStarted):
(WebKit::PlatformCALayerRemote::animationEnded):

WebProcess/WebPage/mac/PlatformCALayerRemote.h:
WebProcess/WebPage/mac/RemoteLayerTreeContext.h:
WebProcess/WebPage/mac/RemoteLayerTreeContext.mm:

(WebKit::RemoteLayerTreeContext::layerWillBeDestroyed):
(WebKit::RemoteLayerTreeContext::willStartAnimationOnLayer):
(WebKit::RemoteLayerTreeContext::animationDidStart):
(WebKit::RemoteLayerTreeContext::animationDidEnd):

WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h:
WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:

(WebKit::RemoteLayerTreeDrawingArea::acceleratedAnimationDidEnd):

2:34 PM Changeset in webkit [172835] by Alan Bujtas

17 edits
2 adds in trunk

Enable SATURATED_LAYOUT_ARITHMETIC.
https://bugs.webkit.org/show_bug.cgi?id=136106

Reviewed by Simon Fraser.

SATURATED_LAYOUT_ARITHMETIC protects LayoutUnit against arithmetic overflow.
(No measurable performance regression on Mac.)

Source/cmake/OptionsMac.cmake:
Source/cmake/WebKitFeatures.cmake:
Source/cmakeconfig.h.cmake:

Source/JavaScriptCore:

Configurations/FeatureDefines.xcconfig:

Source/WebCore:

Test: fast/dynamic/saturated-layout-arithmetic.html

Configurations/FeatureDefines.xcconfig:

Source/WebKit/mac:

Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

Configurations/FeatureDefines.xcconfig:

Source/WTF:

wtf/FeatureDefines.h:

LayoutTests:

fast/dynamic/saturated-layout-arithmetic-expected.html: Added.
fast/dynamic/saturated-layout-arithmetic.html: Added.
fast/ruby/ruby-base-merge-block-children-crash-2.html: saturated arithmetics changes behavior. fix test case.
scrollbars/scrollbar-large-overflow-rectangle.html: saturated arithmetics changes behavior. fix test case.

2:30 PM Changeset in webkit [172834] by commit-queue@webkit.org

4 edits
2 adds in trunk

New ruby parsing rule breaks some real web sites.
https://bugs.webkit.org/show_bug.cgi?id=136062

Patch by Yuki Sekiguchi <yuki.sekiguchi@access-company.com> on 2014-08-21
Reviewed by Ryosuke Niwa.

Source/WebCore:

An RP element should not auto close an RTC element.

The HTML5.1 spec was changed:
http://www.w3.org/html/wg/drafts/html/master/syntax.html#parsing-main-inbody
This was done at the following commit:
https://github.com/w3c/html/commit/c61397b989b28235ee2228f280aa8d475f3b9ebf

This patch changed the RP element's behavior to follow the spec change.

Test: fast/ruby/rp-inside-rtc.html

html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::processStartTagForInBody):

LayoutTests:

html5lib-test was updated using my pull request:
https://github.com/darobin/html5lib-tests/pull/2

fast/ruby/rp-inside-rtc-expected.html: Added.
fast/ruby/rp-inside-rtc.html: Added.
html5lib/resources/ruby.dat: The rp element should not auto close the rtc element.

1:29 PM Changeset in webkit [172833] by commit-queue@webkit.org

4 edits
4 adds in trunk

REGRESSION: CSS not() selector does not work when it appears after or within @supports
https://bugs.webkit.org/show_bug.cgi?id=136063

Patch by Yuki Sekiguchi <yuki.sekiguchi@access-company.com> on 2014-08-21
Reviewed by Darin Adler.

Source/WebCore:

CSSParser changes its m_parsingMode to SupportsMode when it finds
"@supports" token. However, the mode will be never changed to
NormalMode. This changes parsing algorithm for "not" token forever,
and it cannot parse not pseudo class selector.

When we finish parsing @supports rule, we should change to normal
mode.

@media does the same thing. This patch changed CharacterEndMediaQuery
to CharacterEndConditionQuery, and we change parsing mode from
SupportsMode to NormalMode when the parser finished to parse
@supports rule.

Like "@-webkit-mediaquery", we cannot use '{' to
"@-webkit-supports-condition". Changed "@-webkit-supports-condition"
parsing rule and parseSupportsCondition() not to use '{'.

Tests: css3/supports-not-selector-cssom.html

css3/supports-not-selector.html

css/CSSGrammar.y.in:
css/CSSParser.cpp:

(WebCore::CSSParser::parseSupportsCondition):
(WebCore::isCSSLetter):
(WebCore::CSSParser::realLex):

LayoutTests:

Test that @supports doesn't break "not" pseudo class selector.

css3/supports-not-selector-cssom-expected.txt: Added.
css3/supports-not-selector-cssom.html: Added.
css3/supports-not-selector-expected.html: Added.
css3/supports-not-selector.html: Added.

1:08 PM Changeset in webkit [172832] by Beth Dakin

22 edits in trunk

overflow:scroll elements should support rubber-banding
https://bugs.webkit.org/show_bug.cgi?id=91655

Reviewed by Sam Weinig and Darin Adler.

Source/WebCore:

This patch enables rubber-banding in overflow regions and it keeps latching
working as currently implemented.

We cannot return early here if there is no scroll delta. There won't be a scroll
delta in most cases during event.phase() == PlatformWheelEventPhaseEnded, but that
phase is required to be processed in order for rubber-banding to work properly.

dom/Element.cpp:

(WebCore::Element::dispatchWheelEvent):

page/EventHandler.cpp:

(WebCore::handleWheelEventInAppropriateEnclosingBoxForSingleAxis):

Add a setting for this, which will default to true. This allows us to disable the
feature in WebKit1 for now. There is a bug about making it work.

page/Settings.in:

allowsHorizontalStretching() and allowsVerticalStretching() now take the
PlatformWheelEvent as a parameter, so that ScrollElasticityAutomatic can use the
event to decide whether or not stretching should be allowed in this case.
ScrollElasticityAutomatic will not allow stretching if it is a brand new gesture
that would result in a rubber-band. We don't want to rubber-band in that case
because we want the event to propagate up to a parent view. Also added some helper
functions just to make that code easier to read.

page/scrolling/mac/ScrollingTreeFrameScrollingNodeMac.h:
page/scrolling/mac/ScrollingTreeFrameScrollingNodeMac.mm:

(WebCore::newGestureIsStarting):
(WebCore::ScrollingTreeFrameScrollingNodeMac::isAlreadyPinnedInDirectionOfGesture):
(WebCore::ScrollingTreeFrameScrollingNodeMac::allowsHorizontalStretching):
(WebCore::ScrollingTreeFrameScrollingNodeMac::allowsVerticalStretching):

platform/mac/ScrollAnimatorMac.h:
platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::handleWheelEvent):
(WebCore::newGestureIsStarting):
(WebCore::ScrollAnimatorMac::isAlreadyPinnedInDirectionOfGesture):
(WebCore::ScrollAnimatorMac::allowsVerticalStretching):
(WebCore::ScrollAnimatorMac::allowsHorizontalStretching):

platform/mac/ScrollElasticityController.h:
platform/mac/ScrollElasticityController.mm:

(WebCore::ScrollElasticityController::handleWheelEvent):

To opt into rubber-banding, all we have to do is implement overhangAmount and set
scroll elasticity. We'll choose ScrollElasticityAutomatic which means that we'll
only rubber-band in directions that can scroll and that we won't rubber-band for
new gestures when we're already pinned to the edge.

rendering/RenderLayer.cpp:

(WebCore::RenderLayer::overhangAmount):
(WebCore::RenderLayer::setHasHorizontalScrollbar):
(WebCore::RenderLayer::setHasVerticalScrollbar):

Source/WebKit/mac:

Disable rubber-banding in overflow areas for now.

WebView/WebView.mm:

(-[WebView _preferencesChanged:]):

LayoutTests:

Re-baseline. Mostly these tests are different now that end end event is handled.

platform/mac-wk2/tiled-drawing/scrolling/fast-scroll-div-latched-div-expected.txt:
platform/mac-wk2/tiled-drawing/scrolling/fast-scroll-div-latched-div-with-handler-expected.txt:
platform/mac-wk2/tiled-drawing/scrolling/fast-scroll-div-latched-mainframe-with-handler-expected.txt:
platform/mac-wk2/tiled-drawing/scrolling/fast-scroll-iframe-latched-iframe-with-handler-expected.txt:
platform/mac-wk2/tiled-drawing/scrolling/fast-scroll-iframe-latched-mainframe-with-handler-expected.txt:
platform/mac-wk2/tiled-drawing/scrolling/fast-scroll-select-latched-mainframe-with-handler-expected.txt:
platform/mac-wk2/tiled-drawing/scrolling/fast-scroll-select-latched-select-with-handler-expected.txt:

This test requires a longer timeout to ensure that the rubber-band has ended.

platform/mac/fast/scrolling/scroll-latched-nested-div.html:

12:51 PM Changeset in webkit [172831] by achristensen@apple.com

138 edits in trunk/Source

More WEBCORE_EXPORT macros.
https://bugs.webkit.org/show_bug.cgi?id=136129

Reviewed by Tim Horton.

Source/WebCore:

Modules/geolocation/Geolocation.h:
Modules/geolocation/GeolocationController.h:
Modules/indexeddb/IDBDatabaseBackend.h:
Modules/indexeddb/IDBDatabaseMetadata.h:
Modules/indexeddb/IDBKey.h:
Modules/indexeddb/IDBKeyData.h:
Modules/indexeddb/IDBKeyPath.h:
Modules/indexeddb/IDBKeyRange.h:
Modules/indexeddb/IDBKeyRangeData.h:
Modules/notifications/Notification.h:
Modules/notifications/NotificationController.h:
bindings/js/GCController.h:
bridge/IdentifierRep.h:
css/StyleProperties.h:
dom/ExceptionCodePlaceholder.h:
dom/KeyboardEvent.h:
dom/MouseEvent.h:
dom/MouseRelatedEvent.h:
dom/Node.h:

(WebCore::Node::hasEditableStyle):

dom/NodeTraversal.h:
dom/Position.h:

(WebCore::Position::Position):

dom/Range.h:

(WebCore::Range::startContainer):
(WebCore::Range::startOffset):
(WebCore::Range::endContainer):
(WebCore::Range::endOffset):

editing/FrameSelection.h:

(WebCore::DragCaretController::clear):

history/HistoryItem.h:
history/PageCache.h:
html/FormController.h:
html/HTMLElement.h:
html/HTMLFormElement.h:
html/HTMLFrameOwnerElement.h:
html/HTMLInputElement.h:
html/HTMLMediaElement.h:
html/HTMLOptGroupElement.h:
html/HTMLOptionElement.h:
html/HTMLPlugInElement.h:
html/HTMLPlugInImageElement.h:
html/HTMLSelectElement.h:
html/HTMLTableCellElement.h:
html/HTMLTextAreaElement.h:
html/HTMLTextFormControlElement.h:
html/HTMLVideoElement.h:
html/ImageDocument.h:
html/PluginDocument.h:
html/forms/FileIconLoader.h:
html/shadow/InsertionPoint.h:
inspector/InspectorClient.h:
inspector/InspectorController.h:
inspector/InspectorFrontendClientLocal.h:
inspector/InspectorInstrumentation.h:
loader/FrameLoadRequest.h:
loader/FrameLoader.h:
loader/FrameLoaderStateMachine.h:
loader/HistoryController.h:
loader/LoaderStrategy.h:
loader/NavigationAction.h:
loader/NetscapePlugInStreamLoader.h:
loader/ProgressTracker.h:
loader/archive/cf/LegacyWebArchive.h:
loader/cache/MemoryCache.h:
loader/icon/IconController.h:
loader/icon/IconDatabase.h:
loader/icon/IconDatabaseBase.h:
page/FocusController.h:
page/Frame.h:
page/FrameDestructionObserver.h:

Replaced WEBCORE_TESTING with WEBCORE_EXPORT.

page/FrameTree.h:
page/FrameView.h:
page/Page.h:
page/PageConsole.h:
page/PageGroup.h:
page/PageThrottler.h:
page/PrintContext.h:
page/scrolling/ScrollingConstraints.h:
page/scrolling/ScrollingStateNode.h:
platform/FileChooser.h:
platform/GamepadProvider.h:
platform/Length.h:
platform/MIMETypeRegistry.h:
platform/MemoryPressureHandler.h:
platform/Pasteboard.h:
platform/PlatformExportMacros.h:

Removed WEBCORE_TESTING, which I'm replacing with WEBCORE_EXPORT.

platform/PlatformKeyboardEvent.h:
platform/PlatformPasteboard.h:
platform/PlatformSpeechSynthesisVoice.h:
platform/PlatformSpeechSynthesizer.h:
platform/audio/MediaSessionManager.h:
platform/graphics/FloatPoint.h:
platform/graphics/FloatQuad.h:
platform/graphics/FloatRect.h:
platform/graphics/FloatSize.h:
platform/graphics/Font.h:
platform/graphics/FontCache.h:
platform/graphics/FontGlyphs.h:
platform/graphics/FontPlatformData.h:
platform/graphics/GlyphPageTreeNode.h:
platform/graphics/Gradient.h:
platform/graphics/GraphicsContext.h:
platform/graphics/GraphicsLayer.h:
platform/graphics/Icon.h:
platform/graphics/Image.h:
platform/graphics/ImageBuffer.h:
platform/graphics/IntPoint.h:
platform/graphics/IntRect.h:
platform/graphics/IntSize.h:
platform/graphics/LayoutRect.h:
platform/graphics/MediaPlayer.h:
platform/graphics/Path.h:
platform/graphics/Region.h:
platform/graphics/ca/GraphicsLayerCA.h:
platform/graphics/ca/LayerFlushScheduler.h:
platform/graphics/ca/LayerPool.h:
platform/graphics/ca/PlatformCAFilters.h:
platform/graphics/ca/PlatformCALayer.h:
platform/graphics/ca/mac/PlatformCAAnimationMac.h:
platform/graphics/ca/mac/PlatformCALayerMac.h:
platform/graphics/cg/IOSurfacePool.h:
platform/graphics/cocoa/IOSurface.h:
platform/graphics/filters/FilterOperations.h:
platform/graphics/mac/MediaPlayerPrivateQTKit.h:
platform/ios/LegacyTileCache.h:
platform/ios/PlatformEventFactoryIOS.h:
platform/ios/wak/FloatingPointEnvironment.h:
platform/mac/HIDGamepadProvider.h:
platform/mock/MockMediaStreamCenter.h:
platform/network/FormData.h:
platform/network/HTTPHeaderMap.h:
platform/network/NetworkStorageSession.h:
platform/network/ProtectionSpaceBase.h:
platform/network/cocoa/ProtectionSpaceCocoa.h:

(WebCore::ProtectionSpace::encodingRequiresPlatformData):

platform/network/ios/QuickLook.h:
platform/text/TextBreakIterator.h:
plugins/PluginData.h:
plugins/PluginMainThreadScheduler.h:
rendering/HitTestLocation.h:
rendering/HitTestResult.h:
rendering/InlineBox.h:

Added more WEBCORE_EXPORT macros, which don't do anything yet.

Source/WTF:

wtf/ExportMacros.h:

Removed WTF_TESTING which isn't used.

8:47 AM Changeset in webkit [172830] by clopez@igalia.com

8 edits in trunk/Tools

[GTK] Load the llvmpipe (Mesa) libraries when running the tests with Xvfb.
https://bugs.webkit.org/show_bug.cgi?id=134070

Reviewed by Martin Robinson.

Scripts/webkitpy/port/base.py:

(Port.init): Set default _jhbuild_wrapper variable.
(Port._should_use_jhbuild): Implement generic check.

Scripts/webkitpy/port/efl.py: Rename to jhbuild_wrapper variable

to make it consistent with the other ports.

Scripts/webkitpy/port/gtk.py:

(GtkPort.init): Use the new _should_use_jhbuild() method.
(GtkPort.setup_environ_for_server): Get the path for llvmpipe_libgl_path by
querying the jhbuild with printenv. Also check that the path contains
the libraries we expect. Preload this path only for XvfbDriver.

Scripts/webkitpy/port/xvfbdriver.py:

(XvfbDriver.check_driver): Check for the jhbuild wrapper and use it.
(XvfbDriver._start): The environment for llvmpipe_libgl_path is now
configured at setup_environ_for_server()

Scripts/webkitpy/port/xvfbdriver_unittest.py:

(XvfbDriverTest.make_driver): Get the port default environment.
(XvfbDriverTest.test_start_no_pixel_tests): The expected log now
should include the environment that is passed when running Xvfb.
(XvfbDriverTest.test_start_pixel_tests): Ditto.
(XvfbDriverTest.test_start_arbitrary_worker_number): Ditto.
(XvfbDriverTest.test_start_next_worker): Ditto.

gtk/jhbuild.modules: Rename checkoutdir to generic "Mesa" to

prevent future problems when the version is raised. Add also a
comment with a warning.

gtk/jhbuildrc: The path LLVMPIPE_LIBGL_PATH should be the one

that has the llvm optimized Gallium libGL libraries.

6:06 AM WebKitGTK/KeepingTheTreeGreen edited by clopez@igalia.com

(diff)

5:29 AM Changeset in webkit [172829] by commit-queue@webkit.org

3 edits in trunk/Tools

Fix countFailures of RunLLINTCLoopTests and Run32bitJSCTests.
https://bugs.webkit.org/show_bug.cgi?id=136125

Patch by Renato Nagy <nagy.renato@stud.u-szeged.hu> on 2014-08-21
Reviewed by Csaba Osztrogonác.

BuildSlaveSupport/build.webkit.org-config/master.cfg:

(RunLLINTCLoopTests.countFailures):
(Run32bitJSCTests.countFailures):

BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:

(RunLLINTCLoopTestsTest):
(RunLLINTCLoopTestsTest.assertResults):
(RunLLINTCLoopTestsTest.test_failures):
(RunLLINTCLoopTestsTest.test_failure):
(RunLLINTCLoopTestsTest.test_no_failure):
(Run32bitJSCTestsTest):
(Run32bitJSCTestsTest.assertResults):
(Run32bitJSCTestsTest.test_failures):
(Run32bitJSCTestsTest.test_failure):
(Run32bitJSCTestsTest.test_no_failure):

4:00 AM WebKitGTK/2.4.x edited by vjaquez@igalia.com

minor code style fix (diff)

3:57 AM WebKitGTK/2.4.x edited by vjaquez@igalia.com

propose r172828 for 2.4.5 (diff)

3:51 AM Changeset in webkit [172828] by vjaquez@igalia.com

6 edits in trunk

[GTK] WebkitWebProcess crashing navigating away from ogg video element
https://bugs.webkit.org/show_bug.cgi?id=135348

Reviewed by Philippe Normand.

Source/WebCore:

Let GraphicsLayerTextureMapper know it needs to detach the platform
layer when a MediaPlayerPrivateGStreamerBase is destroyed.

No new test since media/restore-from-page-cache.html covers it.

platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:

(WebCore::MediaPlayerPrivateGStreamerBase::~MediaPlayerPrivateGStreamerBase):

Source/WebKit2:

When a page is cached, by default doesn't recreate the backing store
(an optimization added in r89316).

Not all the ports uses that optimization. For example IOS port doesn't
use it (r161185).

In the case of the GTK port, the MediaPlayerPrivateGStreamer, not only
processes video buffers, also display them, because it is a
TextureMapperPlatformLayer too.

Nevertheless, in r153937, when a page is cached, the player is
destroyed. But our player has a backing store and the render tree
doesn't know that the player has gone. Hence, when the page is redraw,
the TextureMapper tree visits the video element, which doesn't exist
anymore, a segmentation fault occurs.

So, as our media player renders, and as we cannot trust that the
player exists when a page is painted, we cannot rely in the r89316
optimization.

Disabling the backing stores optimization fixes the problem.

Covered by existing tests.

WebProcess/soup/WebProcessSoup.cpp:

(WebKit::WebProcess::platformSetCacheModel): Enable the backing store
clearing when page caching for GTK.

LayoutTests:

platform/gtk/TestExpectations: Enable

media/restore-from-page-cache.html,
plugins/netscape-plugin-page-cache-works.html and
animations/resume-after-page-cache.html. They should pass correctly.
Skip compositing/iframes/page-cache-layer-tree.html since we disable
that optimization.

2:32 AM Changeset in webkit [172827] by commit-queue@webkit.org

2 edits in trunk/LayoutTests

[EFL][WK2] Websocket Layout Tests passed in latest build.
https://bugs.webkit.org/show_bug.cgi?id=136100

Unreviewed gardening.

Websocket Layout Tests passed in latest build, possibly because r172438 (https://bugs.webkit.org/show_bug.cgi?id=135831) in version
172796.

Patch by Shivakumar JM <shiva.jm@samsung.com> on 2014-08-21

platform/efl/TestExpectations:

Aug 20, 2014:

8:33 PM Changeset in webkit [172826] by benjamin@webkit.org

22 edits
12 adds in trunk

CSS: Implement the :placeholder-shown pseudo-class from Selectors Level 4
https://bugs.webkit.org/show_bug.cgi?id=118162

Reviewed by Antti Koivisto.

Source/WebCore:

Previously, HTMLTextFormControlElement was using some mix of its own state
and style to change the visibility of the placeholder. That approach was a little
bit too fragile, and we do not want the style to depends on the renderer() since
that creates circular dependencies.

The biggest change here is refactoring HTMLTextFormControlElement to have
1) An explicit "visible placeholder" state.
2) Separate the textUpdate() from the visibilityUpdate().
3) Remove the dependencies between the Element's style and the placeholder's style.

This is done by simply using display:none; on the placeholder so that its parent's visibility
is irrelevant.

When matching the selector, the style is set as unique since style sharing does not deal with
the changes of HTMLTextFormControlElement.

Tests: fast/css/placeholder-shown-basics.html

fast/selectors/placeholder-shown-long-adjacent-backtracking.html
fast/selectors/placeholder-shown-sibling-style-update.html
fast/selectors/placeholder-shown-style-update.html
fast/selectors/placeholder-shown-with-input-basics.html
fast/selectors/placeholder-shown-with-textarea-basics.html

css/CSSSelector.cpp:

(WebCore::CSSSelector::selectorText):
Add the CSS Selector description for CSSOM.

css/CSSSelector.h:
css/SelectorChecker.cpp:

(WebCore::SelectorChecker::checkOne):

css/SelectorCheckerTestFunctions.h:

(WebCore::isPlaceholderShown):

css/SelectorPseudoClassAndCompatibilityElementMap.in:
css/html.css:

(::-webkit-input-placeholder):
Previously, the display was forced through the UA stylesheet. Since the display is now part
of the placeholder visibility, it is explicitly handled by HTMLTextFormControlElement and
its subclasses.

cssjit/SelectorCompiler.cpp:

(WebCore::SelectorCompiler::addPseudoClassType):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementMatching):
(WebCore::SelectorCompiler::makeUniqueIfNecessaryAndTestIsPlaceholderShown):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementHasPlaceholderShown):

html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::parseAttribute):

html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::updateValue):
(WebCore::HTMLTextAreaElement::setValueCommon):
(WebCore::HTMLTextAreaElement::updatePlaceholderText):

html/HTMLTextFormControlElement.cpp:

(WebCore::HTMLTextFormControlElement::HTMLTextFormControlElement):
(WebCore::HTMLTextFormControlElement::dispatchFocusEvent):
(WebCore::HTMLTextFormControlElement::dispatchBlurEvent):
(WebCore::HTMLTextFormControlElement::placeholderShouldBeVisible):
(WebCore::HTMLTextFormControlElement::updatePlaceholderVisibility):
(WebCore::HTMLTextFormControlElement::selectionDirection):
(WebCore::HTMLTextFormControlElement::restoreCachedSelection):
(WebCore::HTMLTextFormControlElement::parseAttribute):
(WebCore::HTMLTextFormControlElement::hidePlaceholder):
(WebCore::HTMLTextFormControlElement::showPlaceholderIfNecessary):

html/HTMLTextFormControlElement.h:

(WebCore::HTMLTextFormControlElement::isPlaceholderVisible):
(WebCore::HTMLTextFormControlElement::cachedSelectionDirection):

html/TextFieldInputType.cpp:

(WebCore::TextFieldInputType::updatePlaceholderText):
(WebCore::TextFieldInputType::subtreeHasChanged):
(WebCore::TextFieldInputType::updateInnerTextValue):

rendering/RenderTextControl.cpp:

(WebCore::RenderTextControl::styleDidChange):

testing/Internals.cpp:

(WebCore::Internals::visiblePlaceholder):

LayoutTests:

Add basic test coverage for common operations: styling, querySelector, CSSOM.

The layout test failure of placeholder-shown-sibling-style-update.html seems unrelated
to this patch, it fails in many more cases. This will be investigated separately, the failure
are used as expected values for now.

fast/css/css-selector-text-expected.txt:
fast/css/css-selector-text.html:
fast/css/css-set-selector-text-expected.txt:
fast/css/css-set-selector-text.html:
fast/css/placeholder-shown-basics-expected.html: Added.
fast/css/placeholder-shown-basics.html: Added.
fast/selectors/placeholder-shown-long-adjacent-backtracking-expected.txt: Added.
fast/selectors/placeholder-shown-long-adjacent-backtracking.html: Added.
fast/selectors/placeholder-shown-sibling-style-update-expected.txt: Added.
fast/selectors/placeholder-shown-sibling-style-update.html: Added.
fast/selectors/placeholder-shown-style-update-expected.txt: Added.
fast/selectors/placeholder-shown-style-update.html: Added.
fast/selectors/placeholder-shown-with-input-basics-expected.txt: Added.
fast/selectors/placeholder-shown-with-input-basics.html: Added.
fast/selectors/placeholder-shown-with-textarea-basics-expected.txt: Added.
fast/selectors/placeholder-shown-with-textarea-basics.html: Added.

8:24 PM Changeset in webkit [172825] by gyuyoung.kim@samsung.com

2 edits in trunk/Tools

Unreviewed, EFL build fix since r172814.

WebKitTestRunner/config.h: Define WEBCORE_EXPORT.

8:20 PM Changeset in webkit [172824] by dburkart@apple.com

1 copy in tags/Safari-600.1.14

Tag 600.1.14

7:45 PM Changeset in webkit [172823] by matthew_hanson@apple.com

5 edits in branches/safari-600.1-branch/Source

Versioning.

7:29 PM Changeset in webkit [172822] by commit-queue@webkit.org

2 edits in trunk/Source/JavaScriptCore

Fix how CodeBlock dumps the opcode op_profile_type
https://bugs.webkit.org/show_bug.cgi?id=136088

Patch by Saam Barati <sbarati@apple.com> on 2014-08-20
Reviewed by Filip Pizlo.

op_profile_type was modified to receive two extra arguments,
but its dump in CodeBlock::dumpBytecode wasn't changed to
account for this, so it broke CodeBlock::dumpBytecode when
op_profile_type was in the stream of bytecode instructions.
CodeBlock::dumpBytecode now accounts for the change in
op_profile_type's arity.

bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dumpBytecode):

6:18 PM Changeset in webkit [172821] by dburkart@apple.com

1 copy in tags/Safari-600.1.13

Tagging.

6:03 PM Changeset in webkit [172820] by commit-queue@webkit.org

38 edits
4 moves in trunk/Source

Rename HighFidelityTypeProfiling variables for more clarity
https://bugs.webkit.org/show_bug.cgi?id=135899

Patch by Saam Barati <sbarati@apple.com> on 2014-08-20
Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Many names that are used in the type profiling infrastructure
prefix themselves with "HighFidelity" or include the words "high"
and/or "fidelity" in some way. But the words "high" and "fidelity" don't
add anything descriptive to the names surrounding type profiling.
So this patch removes all uses of "HighFidelity" and its variants.

Most renamings change "HighFidelity*" to "TypeProfiler*" or simply
drop the prefix "HighFidelity" all together. Now, almost all names
in relation to type profiling contain in them "TypeProfiler" or
"TypeProfiling" or some combination of the words "type" and "profile".

This patch also changes how we check if type profiling is enabled:
We no longer call vm::isProfilingTypesWithHighFidelity. We now just
check that vm::typeProfiler is not null.

This patch also changes all calls to TypeProfilerLog::processLogEntries
to use ASCIILiteral to form WTFStrings instead of vanilla C string literals.

CMakeLists.txt:
JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
JavaScriptCore.xcodeproj/project.pbxproj:
bytecode/BytecodeList.json:
bytecode/BytecodeUseDef.h:

(JSC::computeUsesForBytecodeOffset):
(JSC::computeDefsForBytecodeOffset):

bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dumpBytecode):
(JSC::CodeBlock::CodeBlock):

bytecode/TypeLocation.h:
bytecode/UnlinkedCodeBlock.cpp:

(JSC::UnlinkedFunctionExecutable::UnlinkedFunctionExecutable):
(JSC::UnlinkedCodeBlock::typeProfilerExpressionInfoForBytecodeOffset):
(JSC::UnlinkedCodeBlock::addTypeProfilerExpressionInfo):
(JSC::UnlinkedCodeBlock::highFidelityTypeProfileExpressionInfoForBytecodeOffset): Deleted.
(JSC::UnlinkedCodeBlock::addHighFidelityTypeProfileExpressionInfo): Deleted.

bytecode/UnlinkedCodeBlock.h:

(JSC::UnlinkedFunctionExecutable::typeProfilingStartOffset):
(JSC::UnlinkedFunctionExecutable::typeProfilingEndOffset):
(JSC::UnlinkedFunctionExecutable::highFidelityTypeProfilingStartOffset): Deleted.
(JSC::UnlinkedFunctionExecutable::highFidelityTypeProfilingEndOffset): Deleted.

bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::generate):
(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::emitMove):
(JSC::BytecodeGenerator::emitTypeProfilerExpressionInfo):
(JSC::BytecodeGenerator::emitProfileType):
(JSC::BytecodeGenerator::emitHighFidelityTypeProfilingExpressionInfo): Deleted.
(JSC::BytecodeGenerator::emitProfileTypesWithHighFidelity): Deleted.

bytecompiler/BytecodeGenerator.h:

(JSC::BytecodeGenerator::isProfilingTypesWithHighFidelity): Deleted.

bytecompiler/NodesCodegen.cpp:

(JSC::ThisNode::emitBytecode):
(JSC::ResolveNode::emitBytecode):
(JSC::BracketAccessorNode::emitBytecode):
(JSC::DotAccessorNode::emitBytecode):
(JSC::FunctionCallValueNode::emitBytecode):
(JSC::FunctionCallResolveNode::emitBytecode):
(JSC::FunctionCallBracketNode::emitBytecode):
(JSC::FunctionCallDotNode::emitBytecode):
(JSC::CallFunctionCallDotNode::emitBytecode):
(JSC::ApplyFunctionCallDotNode::emitBytecode):
(JSC::PostfixNode::emitResolve):
(JSC::PostfixNode::emitBracket):
(JSC::PostfixNode::emitDot):
(JSC::PrefixNode::emitResolve):
(JSC::PrefixNode::emitBracket):
(JSC::PrefixNode::emitDot):
(JSC::ReadModifyResolveNode::emitBytecode):
(JSC::AssignResolveNode::emitBytecode):
(JSC::AssignDotNode::emitBytecode):
(JSC::ReadModifyDotNode::emitBytecode):
(JSC::AssignBracketNode::emitBytecode):
(JSC::ReadModifyBracketNode::emitBytecode):
(JSC::ConstDeclNode::emitCodeSingle):
(JSC::EmptyVarExpression::emitBytecode):
(JSC::ReturnNode::emitBytecode):
(JSC::FunctionBodyNode::emitBytecode):

heap/Heap.cpp:

(JSC::Heap::collect):

inspector/agents/InspectorRuntimeAgent.cpp:

(Inspector::InspectorRuntimeAgent::getRuntimeTypesForVariablesAtOffsets):
(Inspector::recompileAllJSFunctionsForTypeProfiling):
(Inspector::InspectorRuntimeAgent::willDestroyFrontendAndBackend):
(Inspector::InspectorRuntimeAgent::enableTypeProfiler):
(Inspector::InspectorRuntimeAgent::disableTypeProfiler):
(Inspector::InspectorRuntimeAgent::setTypeProfilerEnabledState):
(Inspector::InspectorRuntimeAgent::enableHighFidelityTypeProfiling): Deleted.
(Inspector::InspectorRuntimeAgent::disableHighFidelityTypeProfiling): Deleted.
(Inspector::InspectorRuntimeAgent::setHighFidelityTypeProfilingEnabledState): Deleted.

inspector/agents/InspectorRuntimeAgent.h:
inspector/protocol/Runtime.json:
jit/JIT.cpp:

(JSC::JIT::privateCompileMainPass):
(JSC::JIT::privateCompile):

jit/JIT.h:
jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_profile_type):
(JSC::JIT::emit_op_profile_types_with_high_fidelity): Deleted.

jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_profile_type):
(JSC::JIT::emit_op_profile_types_with_high_fidelity): Deleted.

jit/JITOperations.cpp:
jsc.cpp:

(functionDumpTypesForAllVariables):

llint/LLIntSlowPaths.cpp:
llint/LowLevelInterpreter.asm:
runtime/CodeCache.cpp:

(JSC::CodeCache::getGlobalCodeBlock):

runtime/CommonSlowPaths.cpp:

(JSC::SLOW_PATH_DECL):

runtime/CommonSlowPaths.h:
runtime/Executable.cpp:

(JSC::ScriptExecutable::ScriptExecutable):
(JSC::ProgramExecutable::ProgramExecutable):
(JSC::FunctionExecutable::FunctionExecutable):
(JSC::ProgramExecutable::initializeGlobalProperties):

runtime/Executable.h:

(JSC::ScriptExecutable::typeProfilingStartOffset):
(JSC::ScriptExecutable::typeProfilingEndOffset):
(JSC::ScriptExecutable::highFidelityTypeProfilingStartOffset): Deleted.
(JSC::ScriptExecutable::highFidelityTypeProfilingEndOffset): Deleted.

runtime/HighFidelityLog.cpp: Removed.
runtime/HighFidelityLog.h: Removed.
runtime/HighFidelityTypeProfiler.cpp: Removed.
runtime/HighFidelityTypeProfiler.h: Removed.
runtime/Options.h:
runtime/SymbolTable.cpp:

(JSC::SymbolTable::prepareForTypeProfiling):
(JSC::SymbolTable::uniqueIDForVariable):
(JSC::SymbolTable::uniqueIDForRegister):
(JSC::SymbolTable::prepareForHighFidelityTypeProfiling): Deleted.

runtime/SymbolTable.h:
runtime/TypeProfiler.cpp: Added.

(JSC::TypeProfiler::logTypesForTypeLocation):
(JSC::TypeProfiler::insertNewLocation):
(JSC::TypeProfiler::getTypesForVariableAtOffsetForInspector):
(JSC::descriptorMatchesTypeLocation):
(JSC::TypeProfiler::findLocation):

runtime/TypeProfiler.h: Added.

(JSC::QueryKey::QueryKey):
(JSC::QueryKey::isHashTableDeletedValue):
(JSC::QueryKey::operator==):
(JSC::QueryKey::hash):
(JSC::QueryKeyHash::hash):
(JSC::QueryKeyHash::equal):
(JSC::TypeProfiler::functionHasExecutedCache):
(JSC::TypeProfiler::typeLocationCache):

runtime/TypeProfilerLog.cpp: Added.

(JSC::TypeProfilerLog::initializeLog):
(JSC::TypeProfilerLog::~TypeProfilerLog):
(JSC::TypeProfilerLog::processLogEntries):

runtime/TypeProfilerLog.h: Added.

(JSC::TypeProfilerLog::LogEntry::structureIDOffset):
(JSC::TypeProfilerLog::LogEntry::valueOffset):
(JSC::TypeProfilerLog::LogEntry::locationOffset):
(JSC::TypeProfilerLog::TypeProfilerLog):
(JSC::TypeProfilerLog::recordTypeInformationForLocation):
(JSC::TypeProfilerLog::logEndPtr):
(JSC::TypeProfilerLog::logStartOffset):
(JSC::TypeProfilerLog::currentLogEntryOffset):

runtime/VM.cpp:

(JSC::VM::VM):
(JSC::VM::enableTypeProfiler):
(JSC::VM::disableTypeProfiler):
(JSC::VM::dumpTypeProfilerData):
(JSC::VM::enableHighFidelityTypeProfiling): Deleted.
(JSC::VM::disableHighFidelityTypeProfiling): Deleted.
(JSC::VM::dumpHighFidelityProfilingTypes): Deleted.

runtime/VM.h:

(JSC::VM::typeProfilerLog):
(JSC::VM::typeProfiler):
(JSC::VM::isProfilingTypesWithHighFidelity): Deleted.
(JSC::VM::highFidelityLog): Deleted.
(JSC::VM::highFidelityTypeProfiler): Deleted.

Source/WebInspectorUI:

Change a reference in a comment to a JavaScriptCore file to its
newly renamed variant.

UserInterface/Models/ScriptSyntaxTree.js:

5:32 PM Changeset in webkit [172819] by bshafiei@apple.com

5 edits in branches/safari-600.1.4.11-branch/Source

Versioning.

4:55 PM Changeset in webkit [172818] by mrowe@apple.com

2 edits in trunk/Source/WebCore

Fix the release build after r172806.

Modules/mediasource/SourceBuffer.cpp:

(WebCore::SourceBuffer::sourceBufferPrivateDidReceiveRenderingError): Add a missing semicolon.

3:55 PM Changeset in webkit [172817] by benjamin@webkit.org

16 edits
4 deletes in trunk

Remove HTMLInputElement's suggestedValue
https://bugs.webkit.org/show_bug.cgi?id=136094

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-08-20
Reviewed by Darin Adler.

Source/WebCore:

That code is Chrome specific. It is unused now.

WebCore.exp.in:
html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::setValue):
(WebCore::HTMLInputElement::setValueFromRenderer):
(WebCore::HTMLInputElement::suggestedValue): Deleted.
(WebCore::HTMLInputElement::setSuggestedValue): Deleted.

html/HTMLInputElement.h:
html/HTMLTextFormControlElement.cpp:

(WebCore::HTMLTextFormControlElement::placeholderShouldBeVisible):

html/HTMLTextFormControlElement.h:

(WebCore::HTMLTextFormControlElement::isEmptySuggestedValue): Deleted.

html/InputType.cpp:

(WebCore::InputType::canSetSuggestedValue): Deleted.

html/InputType.h:
html/TextFieldInputType.cpp:

(WebCore::TextFieldInputType::updateInnerTextValue):
(WebCore::TextFieldInputType::canSetSuggestedValue): Deleted.

html/TextFieldInputType.h:
testing/Internals.cpp:

(WebCore::Internals::suggestedValue): Deleted.
(WebCore::Internals::setSuggestedValue): Deleted.

testing/Internals.h:
testing/Internals.idl:

Source/WebKit:

WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:

LayoutTests:

fast/forms/suggested-value-after-setvalue-expected.txt: Removed.
fast/forms/suggested-value-after-setvalue.html: Removed.
fast/forms/suggested-value-expected.txt: Removed.
fast/forms/suggested-value.html: Removed.

3:39 PM Changeset in webkit [172816] by dino@apple.com

3 edits
2 adds in trunk

WebAudio FFT analysis uses incorrect scaling
https://bugs.webkit.org/show_bug.cgi?id=136120

Reviewed by Tim Horton.

Source/WebCore:

This is a port of Blink r166687 (author rtoy)
https://codereview.chromium.org/156993002

Currently, for a fixed sine-wave input, the peak FFT amplitude changes
depending on the selected FFT size. This is incorrect; the FFT amplitude
should not appreciably change when the FFT size changes.

Layout test added to verify the FFT result stays approximately constant,
independent of the FFT size used.

When this test is run using an older version of WebKit, the peak varies
from about -44 dB (FFT size 32) to -7 dB (FFT size 2048). With this CL,
the peak is about -7 dB. (It's not 0 dB because of the Blackman window that is applied.)

Note: this change may break existing applications that depended on this strange scaling effect.

Test: webaudio/realtimeanalyser-fft-scaling.html

Modules/webaudio/RealtimeAnalyser.cpp:

(WebCore::RealtimeAnalyser::doFFTAnalysis):

LayoutTests:

Test from Blink r166687.

webaudio/realtimeanalyser-fft-scaling.html: Added.
webaudio/realtimeanalyser-fft-scaling-expected.txt: Added.

3:08 PM Changeset in webkit [172815] by bshafiei@apple.com

1 copy in tags/Safari-600.1.4.11.2

New tag.

2:56 PM Changeset in webkit [172814] by achristensen@apple.com

107 edits in trunk

Introducing WEBCORE_EXPORT macro.
https://bugs.webkit.org/show_bug.cgi?id=136108

Reviewed by Antti Koivisto.

Source/WebCore:

This should eventually replace WebCore.exp.in.

platform/PlatformExportMacros.h:

Define WEBCORE_EXPORT to nothing to not cause problems while I'm working on it.

Modules/encryptedmedia/CDM.h:
Modules/speech/DOMWindowSpeechSynthesis.h:
Modules/webdatabase/DatabaseManager.h:
Modules/webdatabase/DatabaseTracker.h:
accessibility/AXObjectCache.h:
bindings/js/DOMWrapperWorld.h:
bridge/jsc/BridgeJSC.h:
bridge/runtime_method.h:
bridge/runtime_object.h:
bridge/runtime_root.h:
css/CSSComputedStyleDeclaration.h:
css/CSSParserMode.h:
css/CSSValue.h:
css/DOMWindowCSS.h:
css/StyleSheetContents.h:
dom/CharacterData.h:
dom/ClientRect.h:
dom/ClientRectList.h:
dom/ContainerNode.h:
dom/ContextDestructionObserver.h:
dom/DOMImplementation.h:
dom/DataTransfer.h:
dom/DeviceMotionData.h:
dom/DeviceOrientationData.h:
dom/Document.h:

(WebCore::Document::setAnnotatedRegionsDirty):

dom/DocumentMarker.h:
dom/DocumentMarkerController.h:
dom/DocumentStyleSheetCollection.h:
dom/Element.h:
dom/Event.h:

(WebCore::Event::create):

dom/EventListenerMap.h:
editing/DictationAlternative.h:
editing/EditCommand.h:
editing/EditingStyle.h:
editing/Editor.h:
editing/mac/AlternativeTextUIController.h:
history/BackForwardController.h:
history/BackForwardList.h:
history/CachedFrame.h:
loader/CookieJar.h:
loader/CrossOriginPreflightResultCache.h:
loader/DocumentLoader.h:
loader/DocumentWriter.h:
loader/appcache/ApplicationCache.h:
loader/appcache/ApplicationCacheHost.h:
loader/appcache/ApplicationCacheStorage.h:
loader/archive/ArchiveResource.h:
loader/cache/CachedImage.h:
loader/cache/CachedResource.h:
loader/cache/CachedResourceHandle.h:
loader/cache/CachedResourceLoader.h:
page/Chrome.h:
page/ContextMenuController.h:
page/DOMWindow.h:
page/DOMWindowExtension.h:
page/DragController.h:
page/EventHandler.h:
page/animation/AnimationController.h:
page/scrolling/AsyncScrollingCoordinator.h:
platform/CalculationValue.h:
platform/ContentFilter.h:
platform/ContextMenu.h:
platform/ContextMenuItem.h:
platform/CrossThreadCopier.h:
platform/Cursor.h:
platform/DatabaseStrategy.h:
platform/DisplaySleepDisabler.h:
platform/DragData.h:
platform/LocalizedStrings.h:
platform/audio/AudioHardwareListener.h:
platform/audio/AudioSession.h:
platform/audio/ios/MediaSessionManagerIOS.mm:
platform/graphics/BitmapImage.h:
platform/graphics/Color.h:
platform/graphics/DisplayRefreshMonitor.h:
platform/graphics/transforms/AffineTransform.h:
platform/ios/WebCoreSystemInterfaceIOS.mm:
platform/ios/WebVideoFullscreenModelMediaElement.h:
platform/ios/wak/WAKView.mm:
platform/ios/wak/WKContentObservation.h:
platform/ios/wak/WKView.h:
platform/ios/wak/WebCoreThread.h:
platform/ios/wak/WebCoreThreadMessage.h:
platform/mac/BlockExceptions.h:
platform/mock/DeviceOrientationClientMock.h:
platform/network/AuthenticationChallengeBase.h:
platform/network/BlobData.h:
platform/network/BlobDataFileReference.h:
platform/network/BlobRegistry.h:
platform/network/BlobRegistryImpl.h:
platform/network/CredentialBase.h:
platform/network/CredentialStorage.h:
platform/network/PlatformCookieJar.h:
platform/network/cf/AuthenticationChallenge.h:
platform/network/cocoa/CredentialCocoa.h:
platform/network/mac/CertificateInfo.h:
platform/sql/SQLiteDatabase.h:

(WebCore::SQLiteDatabase::disableThreadingChecks):

platform/sql/SQLiteDatabaseTracker.h:
platform/sql/SQLiteStatement.h:
platform/sql/SQLiteTransaction.h:
platform/text/BidiContext.h:

Added WEBCORE_EXPORT macros.

Source/WebKit2:

config.h:

Added stub definition of WEBCORE_EXPORT defined to nothing to be able to compile with WebCore headers.

Tools:

TestWebKitAPI/config.h:

Added stub definition of WEBCORE_EXPORT defined to nothing to be able to compile with WebCore headers.

2:43 PM Changeset in webkit [172813] by Csaba Osztrogonác

3 edits in trunk/Source/JavaScriptCore

URTBF after r172799.

disassembler/ARM64/A64DOpcode.cpp:
disassembler/ARM64Disassembler.cpp:

2:43 PM Changeset in webkit [172812] by mrowe@apple.com

2 edits in trunk/Source/WebKit

<https://webkit.org/b/136119> WebKit1 plug-in test failures in production builds after r172595

Reviewed by Alexey Proskuryakov.

WebKit.xcodeproj/project.pbxproj: Add the symlinks at the top level of WebKitLegacy.framework

even in Production builds. Add the symlinks in the right locations too.

2:07 PM Changeset in webkit [172811] by psolanki@apple.com

8 edits
4 copies
1 add in trunk/Source

Move DiskCacheMonitor to WebCore so that WebKit1 clients can use it as well
https://bugs.webkit.org/show_bug.cgi?id=135896

Reviewed by Andreas Kling.

Source/WebCore:

Refactor code and move it to WebCore.

WebCore.exp.in:
WebCore.xcodeproj/project.pbxproj:
loader/ResourceLoader.h:

Make willCacheResponse protected so that SubresourceLoader can override it.

loader/SubresourceLoader.h:
loader/cocoa/DiskCacheMonitorCocoa.h: Added.

Mostly the same as the existing NetworkDiskCacheMonitor class in WebKit2. In the
CFNetwork callback block, it calls a virtual function that is overridden by
NetworkDiskCacheMonitor to send a message to WebContent process.

(WebCore::DiskCacheMonitor::~DiskCacheMonitor):
(WebCore::DiskCacheMonitor::resourceRequest):
(WebCore::DiskCacheMonitor::sessionID):

loader/cocoa/DiskCacheMonitorCocoa.mm:

(WebCore::DiskCacheMonitor::tryGetFileBackedSharedBufferFromCFURLCachedResponse):

Copied from NetworkResourceLoader::tryGetFileBackedSharedBufferFromCFURLCachedResponse.

(WebCore::DiskCacheMonitor::monitorFileBackingStoreCreation):
(WebCore::DiskCacheMonitor::DiskCacheMonitor):
(WebCore::DiskCacheMonitor::resourceBecameFileBacked):

Replace the cached resource data with the contents of the file backed buffer. This is
used in WebKit1 (and also for any resource loads that happen from the WebContent
process).

loader/cocoa/SubresourceLoaderCocoa.mm: Added.

(WebCore::SubresourceLoader::willCacheResponse):

Override willCacheresponse from ResourceLoader to listen for disk cache notifications.

Source/WebKit2:

NetworkProcess/mac/NetworkDiskCacheMonitor.h:

Inherit from WebCore::DiskCacheMonitor which has the bulk of the functionality now.

(WebKit::NetworkDiskCacheMonitor::~NetworkDiskCacheMonitor):

NetworkProcess/mac/NetworkDiskCacheMonitor.mm:

(WebKit::NetworkDiskCacheMonitor::monitorFileBackingStoreCreation):
(WebKit::NetworkDiskCacheMonitor::NetworkDiskCacheMonitor):
(WebKit::NetworkDiskCacheMonitor::resourceBecameFileBacked):

Override virtual method and send the data to the WebContent process as before.

2:04 PM Changeset in webkit [172810] by Lucas Forschler

2 edits in branches/safari-600.1-branch/Source/JavaScriptCore

Merged r172805. <rdar://problem/18075852>

2:02 PM Changeset in webkit [172809] by eric.carlson@apple.com

4 edits in trunk/Source/WebCore

Cleanup MediaSession
https://bugs.webkit.org/show_bug.cgi?id=136116

Reviewed by Brent Fulgham.

MediaSessionManagerClient interface isn't used, remove it.
No new tests, this doesn't change behavior.

WebCore.exp.in:
platform/audio/MediaSessionManager.cpp:

(WebCore::MediaSessionManager::addSession):
(WebCore::MediaSessionManager::removeSession):
(WebCore::MediaSessionManager::sessionWillBeginPlayback):
(WebCore::MediaSessionManager::addClient): Deleted.
(WebCore::MediaSessionManager::removeClient): Deleted.

platform/audio/MediaSessionManager.h:

(WebCore::MediaSessionManagerClient::~MediaSessionManagerClient): Deleted.
(WebCore::MediaSessionManagerClient::MediaSessionManagerClient): Deleted.

1:47 PM Changeset in webkit [172808] by oliver@apple.com

19 edits in trunk/Source/JavaScriptCore

Stop implicitly skipping a function's own activation when walking the scope chain
https://bugs.webkit.org/show_bug.cgi?id=136118

Reviewed by Geoffrey Garen.

Remove the current logic that implicitly skips a function's
own activation when walking the scope chain. This is ground
work for ensuring that all closed variable access is made
through the function's activation. This leads to a further
10% regression on earley, but we're already tracking the
overall performance regression.

bytecode/CodeBlock.cpp:

(JSC::CodeBlock::CodeBlock):

dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::getScope):
(JSC::DFG::ByteCodeParser::parseBlock):

dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

dfg/DFGDoesGC.cpp:

(JSC::DFG::doesGC):

dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

dfg/DFGHeapLocation.cpp:

(WTF::printInternal):

dfg/DFGHeapLocation.h:
dfg/DFGNodeType.h:
dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):

dfg/DFGSafeToExecute.h:

(JSC::DFG::safeToExecute):

dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

jit/JITPropertyAccess.cpp:

(JSC::JIT::emitResolveClosure):

llint/LowLevelInterpreter32_64.asm:
llint/LowLevelInterpreter64.asm:
runtime/JSScope.cpp:

(JSC::JSScope::abstractResolve):

runtime/JSScope.h:

1:28 PM Changeset in webkit [172807] by msaboff@apple.com

2 edits in trunk/Source/JavaScriptCore

REGRESSION: Web Inspector crashes when reloading apple.com with Timeline recording active
https://bugs.webkit.org/show_bug.cgi?id=136034

Reviewed by Mark Lam.

DebuggerCallFrame::positionForCallFrame is trying to unwind starting somewhere in the middle
of the stack. Hardened StackVisitor to skip over the frames between the current top frame
and the requested start frame.

interpreter/StackVisitor.cpp:

(JSC::StackVisitor::StackVisitor):

1:19 PM Changeset in webkit [172806] by eric.carlson@apple.com

3 edits in trunk/Source/WebCore

[MSE] add additional SourceBuffer and MediaSource logging
https://bugs.webkit.org/show_bug.cgi?id=136114

Reviewed by Brent Fulgham.

No new tests, this adds debug-only logging.

Modules/mediasource/MediaSource.cpp:

(WebCore::MediaSource::setReadyState): Fix a typo.
(WebCore::MediaSource::streamEndedWithError): Log the error.

Modules/mediasource/SourceBuffer.cpp:

(WebCore::SourceBuffer::sourceBufferPrivateAppendComplete): Log when parsing fails.
(WebCore::SourceBuffer::sourceBufferPrivateDidReceiveRenderingError): Log error.
(WebCore::SourceBuffer::sourceBufferPrivateDidEndStream): Ditto.
(WebCore::SourceBuffer::sourceBufferPrivateDidReceiveInitializationSegment): Log.
(WebCore::SourceBuffer::sourceBufferPrivateDidReceiveSample): Log error.

12:46 PM Changeset in webkit [172805] by Brent Fulgham

2 edits in trunk/Source/JavaScriptCore

[Win] JavaScriptCore.dll is missing version information.
https://bugs.webkit.org/show_bug.cgi?id=136105
<rdar://problem/18075852>

Reviewed by Dean Jackson.

JavaScriptCore.vcxproj/JavaScriptCorePreBuild.cmd: Add missing step to generate

version information for intermediary build path.

12:27 PM Changeset in webkit [172804] by commit-queue@webkit.org

3 edits in trunk/Source/JavaScriptCore

Fix a memory leak in TypeSet
https://bugs.webkit.org/show_bug.cgi?id=135913

Patch by Saam Barati <sbarati@apple.com> on 2014-08-20
Reviewed by Filip Pizlo.

Currently, TypeSet unconditionally allocates memory for its member
variable m_structureHistory, but never deallocates it. Change this
from being a pointer that is unconditionally allocated to a member
variable that will be deallocated when TypeSet itself is deallocated.

runtime/TypeSet.cpp:

(JSC::TypeSet::TypeSet):
(JSC::TypeSet::addTypeInformation):
(JSC::TypeSet::seenTypes):
(JSC::TypeSet::displayName):
(JSC::TypeSet::allStructureRepresentations):
(JSC::StructureShape::leastCommonAncestor):

runtime/TypeSet.h:

12:10 PM Changeset in webkit [172803] by commit-queue@webkit.org

2 edits in trunk/Tools

import-w3c-tests doesn't import .svg support files
https://bugs.webkit.org/show_bug.cgi?id=135928

Patch by Rebecca Hauck <rhauck@adobe.com> on 2014-08-20
Reviewed by Bem Jones-Bey.

This patch fixes the W3C import script to not treat all
files with an xml mimetype as convertible tests, which
was causing SVG support files to not be imported.

Scripts/webkitpy/w3c/test_importer.py:

(TestImporter.find_importable_tests):

11:37 AM Changeset in webkit [172802] by commit-queue@webkit.org

105 edits in trunk/Source/WebCore

Unreviewed, rolling out r172798.
https://bugs.webkit.org/show_bug.cgi?id=136113

Broke builds (Requested by msaboff on #webkit).

Reverted changeset:

"Introducing WEBCORE_EXPORT macro."
https://bugs.webkit.org/show_bug.cgi?id=136108
http://trac.webkit.org/changeset/172798

11:11 AM Changeset in webkit [172801] by commit-queue@webkit.org

2 edits in trunk/Source/JavaScriptCore

[Win] Assertion fails when running JSC stress tests.
https://bugs.webkit.org/show_bug.cgi?id=136103

Patch by peavo@outlook.com <peavo@outlook.com> on 2014-08-20
Reviewed by Darin Adler.

Use unsigned bitfield member instead of enum bitfield member to avoid negative values.

bytecode/CodeOrigin.h: Use unsigned bitfield member.

(JSC::InlineCallFrame::specializationKind): Compile fix.

11:05 AM Changeset in webkit [172800] by ap@apple.com

2 edits in trunk/LayoutTests

fast/multicol/mixed-opacity-fixed-test.html fails in compositing mode
https://bugs.webkit.org/show_bug.cgi?id=136109

platform/mac-wk2/TestExpectations: Updated test expectations to a non-flaky failure,

and to point to the new bug.

10:59 AM Changeset in webkit [172799] by commit-queue@webkit.org

6 edits in trunk/Source

Enable ARM64 disassembler on EFL
https://bugs.webkit.org/show_bug.cgi?id=136089

Patch by Akos Kiss <akiss@inf.u-szeged.hu> on 2014-08-20
Reviewed by Filip Pizlo.

Source/JavaScriptCore:

CMakeLists.txt:

Added disassembler/ARM64Disassembler.cpp and
disassembler/ARM64/A64DOpcode.cpp to JavaScriptCore_SOURCES.

disassembler/ARM64/A64DOpcode.cpp:

Added USE(ARM64_DISASSEMBLER) guard around implementation.

disassembler/ARM64/A64DOpcode.h:

(JSC::ARM64Disassembler::A64DOpcode::appendUnsignedImmediate64):
(JSC::ARM64Disassembler::A64DOpcode::appendPCRelativeOffset):
Made format strings portable by changing "%llx" to "%" PRIx64 for
uint64_t arguments.

Source/WTF:

wtf/Platform.h:

Enable WTF_USE_ARM64_DISASSEMBLER for EFL as well.

10:56 AM Changeset in webkit [172798] by achristensen@apple.com

105 edits in trunk/Source/WebCore

Introducing WEBCORE_EXPORT macro.
https://bugs.webkit.org/show_bug.cgi?id=136108

Reviewed by Antti Koivisto.

This should eventually replace WebCore.exp.in.

platform/PlatformExportMacros.h:

Define WEBCORE_EXPORT to nothing to not cause problems while I'm working on it.

Modules/encryptedmedia/CDM.h:
Modules/speech/DOMWindowSpeechSynthesis.h:
Modules/webdatabase/DatabaseManager.h:
Modules/webdatabase/DatabaseTracker.h:
accessibility/AXObjectCache.h:
bindings/js/DOMWrapperWorld.h:
bridge/jsc/BridgeJSC.h:
bridge/runtime_method.cpp:
bridge/runtime_method.h:
bridge/runtime_object.cpp:
bridge/runtime_object.h:
bridge/runtime_root.h:
css/CSSComputedStyleDeclaration.h:
css/CSSParserMode.h:
css/CSSValue.h:
css/DOMWindowCSS.h:
css/StyleSheetContents.h:
dom/CharacterData.h:
dom/ClientRect.h:
dom/ClientRectList.h:
dom/ContainerNode.h:
dom/ContextDestructionObserver.h:
dom/DOMImplementation.h:
dom/DataTransfer.h:
dom/DeviceMotionData.h:
dom/DeviceOrientationData.h:
dom/Document.h:

(WebCore::Document::setAnnotatedRegionsDirty):

dom/DocumentMarker.h:
dom/DocumentMarkerController.h:
dom/DocumentStyleSheetCollection.h:
dom/Element.h:
dom/Event.h:

(WebCore::Event::create):

dom/EventListenerMap.h:
editing/DictationAlternative.h:
editing/EditCommand.h:
editing/EditingStyle.h:
editing/Editor.h:
editing/mac/AlternativeTextUIController.h:
history/BackForwardController.h:
history/BackForwardList.h:
history/CachedFrame.h:
loader/CookieJar.h:
loader/CrossOriginPreflightResultCache.h:
loader/DocumentLoader.h:
loader/DocumentWriter.h:
loader/appcache/ApplicationCache.h:
loader/appcache/ApplicationCacheHost.h:
loader/appcache/ApplicationCacheStorage.h:
loader/archive/ArchiveResource.h:
loader/cache/CachedImage.h:
loader/cache/CachedResource.h:
loader/cache/CachedResourceHandle.h:
loader/cache/CachedResourceLoader.h:
page/Chrome.h:
page/ContextMenuController.h:
page/DOMWindow.h:
page/DOMWindowExtension.h:
page/DragController.h:
page/EventHandler.h:
page/animation/AnimationController.h:
page/scrolling/AsyncScrollingCoordinator.h:
platform/CalculationValue.h:
platform/ContentFilter.h:
platform/ContextMenu.h:
platform/ContextMenuItem.h:
platform/CrossThreadCopier.h:
platform/Cursor.h:
platform/DatabaseStrategy.h:
platform/DisplaySleepDisabler.h:
platform/DragData.h:
platform/LocalizedStrings.h:
platform/audio/AudioHardwareListener.h:
platform/audio/AudioSession.h:
platform/audio/ios/MediaSessionManagerIOS.mm:
platform/graphics/BitmapImage.h:
platform/graphics/Color.h:
platform/graphics/DisplayRefreshMonitor.h:
platform/graphics/transforms/AffineTransform.h:
platform/ios/WebCoreSystemInterfaceIOS.mm:
platform/ios/WebVideoFullscreenModelMediaElement.h:
platform/ios/wak/WAKView.mm:
platform/ios/wak/WKContentObservation.h:
platform/ios/wak/WKView.h:
platform/ios/wak/WebCoreThread.h:
platform/ios/wak/WebCoreThreadMessage.h:
platform/mac/BlockExceptions.h:
platform/mock/DeviceOrientationClientMock.h:
platform/network/AuthenticationChallengeBase.h:
platform/network/BlobData.h:
platform/network/BlobDataFileReference.h:
platform/network/BlobRegistry.h:
platform/network/BlobRegistryImpl.h:
platform/network/CredentialBase.h:
platform/network/CredentialStorage.h:
platform/network/PlatformCookieJar.h:
platform/network/cf/AuthenticationChallenge.h:
platform/network/cocoa/CredentialCocoa.h:
platform/network/mac/CertificateInfo.h:
platform/sql/SQLiteDatabase.h:

(WebCore::SQLiteDatabase::disableThreadingChecks):

platform/sql/SQLiteDatabaseTracker.h:
platform/sql/SQLiteStatement.h:
platform/sql/SQLiteTransaction.h:
platform/text/BidiContext.h:

Added WEBCORE_EXPORT macros.

7:44 AM Changeset in webkit [172797] by Alan Bujtas

4 edits
32 adds in trunk

Dashed/dotted borders do not paint.
https://bugs.webkit.org/show_bug.cgi?id=135898

Reviewed by Simon Fraser.

Source/WebCore:

Remove the empty line checks for drawLines. There's no need to protect the graphics
context from empty lines.

Tests: fast/borders/border-painting-dashed-at-all.html

fast/borders/border-painting-dashed.html
fast/borders/border-painting-dotted-at-all.html
fast/borders/border-painting-dotted.html
fast/borders/border-painting-double-at-all.html
fast/borders/border-painting-double.html
fast/borders/border-painting-groove-at-all.html
fast/borders/border-painting-inset-at-all.html
fast/borders/border-painting-inset.html
fast/borders/border-painting-outset-at-all.html
fast/borders/border-painting-outset.html
fast/borders/border-painting-ridge-at-all.html
fast/borders/border-painting-solid-at-all.html
fast/borders/border-painting-solid.html
fast/borders/hidpi-border-painting-groove.html
fast/borders/hidpi-border-painting-ridge.html

rendering/RenderObject.cpp:

(WebCore::RenderObject::drawLineForBoxSide):
(WebCore::drawBorderLineRect): Deleted.
(WebCore::drawBorderLine): Deleted.

LayoutTests:

*-at-all files test that we always paint borders.
The other set of files test that borders are painted properly. They take
advantage of the fact that borders with radius use a different painting code path.

TestExpectations:
fast/borders/border-painting-dashed-at-all-expected.html: Added.
fast/borders/border-painting-dashed-at-all.html: Added.
fast/borders/border-painting-dashed-expected.html: Added.
fast/borders/border-painting-dashed.html: Added.
fast/borders/border-painting-dotted-at-all-expected.html: Added.
fast/borders/border-painting-dotted-at-all.html: Added.
fast/borders/border-painting-dotted-expected.html: Added.
fast/borders/border-painting-dotted.html: Added.
fast/borders/border-painting-double-at-all-expected.html: Added.
fast/borders/border-painting-double-at-all.html: Added.
fast/borders/border-painting-double-expected.html: Added.
fast/borders/border-painting-double.html: Added.
fast/borders/border-painting-groove-at-all-expected.html: Added.
fast/borders/border-painting-groove-at-all.html: Added.
fast/borders/border-painting-inset-at-all-expected.html: Added.
fast/borders/border-painting-inset-at-all.html: Added.
fast/borders/border-painting-inset-expected.html: Added.
fast/borders/border-painting-inset.html: Added.
fast/borders/border-painting-outset-at-all-expected.html: Added.
fast/borders/border-painting-outset-at-all.html: Added.
fast/borders/border-painting-outset-expected.html: Added.
fast/borders/border-painting-outset.html: Added.
fast/borders/border-painting-ridge-at-all-expected.html: Added.
fast/borders/border-painting-ridge-at-all.html: Added.
fast/borders/border-painting-solid-at-all-expected.html: Added.
fast/borders/border-painting-solid-at-all.html: Added.
fast/borders/border-painting-solid-expected.html: Added.
fast/borders/border-painting-solid.html: Added.
fast/borders/hidpi-border-painting-groove-expected.html: Added.
fast/borders/hidpi-border-painting-groove.html: Added.
fast/borders/hidpi-border-painting-ridge-expected.html: Added.
fast/borders/hidpi-border-painting-ridge.html: Added.

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed