Timeline



Aug 23, 2014:

6:35 PM Changeset in webkit [172892] by ap@apple.com
  • 2 edits in trunk/Tools

build.webkit.org/dashboard: Further improve Trac loading
​https://bugs.webkit.org/show_bug.cgi?id=136174

Reviewed by Timothy Hatcher.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:

(Trac.prototype._xmlTimelineURL): Passing -1 as "max" resulted in an off by one
error, the oldest commit within the range wasn't returned. The correct argument for
"no limit" is 0.
(Trac.prototype.load): Added a function to load a specific time range.
(Trac.prototype._loaded): Updated to support loading revisions that are arbitrarily
positioned with regards to ones that were already known.

6:22 PM Changeset in webkit [172891] by ap@apple.com
  • 3 edits in trunk/Tools

build.webkit.org/dashboard: Make it possible to pull historic data from Buildbot
​https://bugs.webkit.org/show_bug.cgi?id=136182

Reviewed by Timothy Hatcher.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:

Make it possible to create a complete BuildbotIteration object with JSON, not only by
loading data from the network.

An iteration has three states:

  1. Just created, it only knows the revision, and whether it's already finished.

BuildbotIteration constructor used to create these.

  1. A complete JSON report loaded from buildbot. The new constructor form creates these.
  2. Data about tests is fetched.
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:

Make it possible to pull all data from a buildbot queue. This needs to be better
optimized eventually, as it's somewhat slow.

1:39 PM Changeset in webkit [172890] by beidson@apple.com
  • 8 edits in trunk/Source/WebCore

Random Gamepad cleanup
​https://bugs.webkit.org/show_bug.cgi?id=136193

Reviewed by Sam Weinig.

No new tests (Not tested yet, and no change in behavior anyways)

  • Use DOMWindow WeakPtrs when iterating
  • More references instead of pointers
  • Modules/gamepad/GamepadEvent.cpp:

(WebCore::GamepadEvent::GamepadEvent):

  • Modules/gamepad/GamepadEvent.h:

(WebCore::GamepadEvent::create):

  • Modules/gamepad/GamepadManager.cpp:

(WebCore::GamepadManager::platformGamepadDisconnected):
(WebCore::GamepadManager::makeGamepadVisible):

  • Modules/gamepad/NavigatorGamepad.cpp:

(WebCore::NavigatorGamepad::gamepadFromPlatformGamepad):
(WebCore::NavigatorGamepad::gamepadAtIndex): Deleted.

  • Modules/gamepad/NavigatorGamepad.h:
  • page/DOMWindow.cpp:

(WebCore::DOMWindow::DOMWindow):

  • page/DOMWindow.h:
2:24 AM Changeset in webkit [172889] by commit-queue@webkit.org
  • 15 edits in trunk/Source

Unify GraphicsLayer::setContentsToMedia and setContentsToCanvas
​https://bugs.webkit.org/show_bug.cgi?id=109658
Source/WebCore:

Patch by Byungseon Shin <​sun.shin@lge.com> on 2014-08-23
Reviewed by Martin Robinson.

Based on patch originally written by Tim Horton.
Merge setContentsToMedia and setContentsToCanvas into setContentsToPlatformLayer.

  • WebCore.exp.in:

Adjust exports.

  • platform/graphics/GraphicsLayer.h:

Move ContentsLayerPurpose enum up out of GraphicsLayer platform implmentations
and into GraphicsLayer, so we can use it as a parameter.
Add ContentsLayerForPlugin.

(WebCore::GraphicsLayer::setContentsToPlatformLayer):
Remove setContentsToMedia and setContentsToCanvas, and replace them
with setContentsToPlatformLayer, which previously existed but was unused
and simply called setContentsToMedia.
setContentsToPlatformLayer takes a ContentsLayerPurpose, primarily
so that GraphicsLayerCA can know whether it needs to setNeedsDisplay
the layer when parenting it (canvas) or not (everything else).

  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::setContentsToPlatformLayer):
Rename function setContentsToMedia -> setContentsToPlatformLayer.
Rename argument mediaLayer -> platformLayer.
Store the passed-in ContentsLayerPurpose.
Remove setContentsToCanvas.

(WebCore::GraphicsLayerCA::commitLayerChangesBeforeSublayers):
(WebCore::GraphicsLayerCA::updateContentsPlatformLayer):
Remove updateContentsMediaLayer and updateContentsCanvas layer,
add updateContentsPlatformLayer.

  • platform/graphics/ca/GraphicsLayerCA.h:

Do the same to the LayerChange enum.

  • platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:

(WebCore::GraphicsLayerTextureMapper::setContentsToImage):
(WebCore::GraphicsLayerTextureMapper::setContentsToPlatformLayer):

  • platform/graphics/texmap/GraphicsLayerTextureMapper.h:
  • platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:

(WebCore::CoordinatedGraphicsLayer::CoordinatedGraphicsLayer):
(WebCore::CoordinatedGraphicsLayer::setContentsNeedsDisplay):
(WebCore::CoordinatedGraphicsLayer::setContentsToPlatformLayer):
(WebCore::CoordinatedGraphicsLayer::syncPlatformLayer):
(WebCore::CoordinatedGraphicsLayer::destroyPlatformLayerIfNeeded):
(WebCore::CoordinatedGraphicsLayer::createPlatformLayerIfNeeded):
(WebCore::CoordinatedGraphicsLayer::flushCompositingStateForThisLayerOnly):
Fold these together in the same way as elsewhere.

  • platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h:

Do the same to the LayerChange enum.

  • platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.cpp:

(WebCore::CoordinatedGraphicsScene::createPlatformLayerIfNeeded):
(WebCore::CoordinatedGraphicsScene::syncPlatformLayerIfNeeded):
(WebCore::CoordinatedGraphicsScene::destroyPlatformLayerIfNeeded):
(WebCore::CoordinatedGraphicsScene::setLayerState):

  • platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.h:
  • platform/graphics/texmap/coordinated/CoordinatedGraphicsState.h:

(WebCore::CoordinatedGraphicsLayerState::CoordinatedGraphicsLayerState):
Rename canvasLayer -> platformLayer.

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateConfiguration):
Use the new setContentsToPlatformLayer, passing in the relevant ContentsLayerPurpose.

Source/WebKit2:

Patch by Byungseon Shin <​sun.shin@lge.com> on 2014-08-23
Reviewed by Martin Robinson.

Based on patch originally written by Tim Horton.
Merge setContentsToMedia and setContentsToCanvas into setContentsToPlatformLayer.

  • Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp:

(IPC::ArgumentCoder<CoordinatedGraphicsLayerState>::encode):
(IPC::ArgumentCoder<CoordinatedGraphicsLayerState>::decode):
Rename canvas -> platformLayer.

1:16 AM Changeset in webkit [172888] by commit-queue@webkit.org
  • 4 edits in trunk/Source

Web Inspector: Do not copy large module source strings
​https://bugs.webkit.org/show_bug.cgi?id=136191

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-08-23
Reviewed by Benjamin Poulain.

Source/JavaScriptCore:

  • inspector/InjectedScriptManager.cpp:

(Inspector::InjectedScriptManager::injectedScriptSource):

Source/WebCore:

  • inspector/CommandLineAPIModule.cpp:

(WebCore::CommandLineAPIModule::source):

12:15 AM Changeset in webkit [172887] by zandobersek@gmail.com
  • 5 edits in trunk/Source/WebCore

Remove uses of CrossThreadTask in ThreadableWebSocketChannelClientWrapper, WorkerThreadableWebSocketChannel
​https://bugs.webkit.org/show_bug.cgi?id=133954

Reviewed by Darin Adler.

Replace uses of CrossThreadTask with C++11 lambdas in the ThreadableWebSocketChannelClientWrapper
and WorkerThreadableWebSocketChannel classes.

  • Modules/websockets/ThreadableWebSocketChannelClientWrapper.cpp:

(WebCore::ThreadableWebSocketChannelClientWrapper::didConnect):
(WebCore::ThreadableWebSocketChannelClientWrapper::didReceiveMessage):
(WebCore::ThreadableWebSocketChannelClientWrapper::didReceiveBinaryData):
(WebCore::ThreadableWebSocketChannelClientWrapper::didUpdateBufferedAmount):
(WebCore::ThreadableWebSocketChannelClientWrapper::didStartClosingHandshake):
(WebCore::ThreadableWebSocketChannelClientWrapper::didClose):
(WebCore::ThreadableWebSocketChannelClientWrapper::didReceiveMessageError):
(WebCore::ThreadableWebSocketChannelClientWrapper::processPendingTasks):
(WebCore::ThreadableWebSocketChannelClientWrapper::processPendingTasksCallback): Deleted.
(WebCore::ThreadableWebSocketChannelClientWrapper::didConnectCallback): Deleted.
(WebCore::ThreadableWebSocketChannelClientWrapper::didReceiveMessageCallback): Deleted.
(WebCore::ThreadableWebSocketChannelClientWrapper::didReceiveBinaryDataCallback): Deleted.
(WebCore::ThreadableWebSocketChannelClientWrapper::didUpdateBufferedAmountCallback): Deleted.
(WebCore::ThreadableWebSocketChannelClientWrapper::didStartClosingHandshakeCallback): Deleted.
(WebCore::ThreadableWebSocketChannelClientWrapper::didCloseCallback): Deleted.
(WebCore::ThreadableWebSocketChannelClientWrapper::didReceiveMessageErrorCallback): Deleted.

  • Modules/websockets/ThreadableWebSocketChannelClientWrapper.h:
  • Modules/websockets/WorkerThreadableWebSocketChannel.cpp:

(WebCore::WorkerThreadableWebSocketChannel::Peer::send):
(WebCore::WorkerThreadableWebSocketChannel::Peer::bufferedAmount):
(WebCore::WorkerThreadableWebSocketChannel::Peer::didConnect):
(WebCore::WorkerThreadableWebSocketChannel::Peer::didReceiveMessage):
(WebCore::WorkerThreadableWebSocketChannel::Peer::didReceiveBinaryData):
(WebCore::WorkerThreadableWebSocketChannel::Peer::didUpdateBufferedAmount):
(WebCore::WorkerThreadableWebSocketChannel::Peer::didStartClosingHandshake):
(WebCore::WorkerThreadableWebSocketChannel::Peer::didClose):
(WebCore::WorkerThreadableWebSocketChannel::Peer::didReceiveMessageError):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::mainThreadInitialize):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::connect):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::send):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::bufferedAmount):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::close):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::fail):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::disconnect):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::suspend):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::resume):
(WebCore::workerGlobalScopeDidSend): Deleted.
(WebCore::workerGlobalScopeDidGetBufferedAmount): Deleted.
(WebCore::workerGlobalScopeDidConnect): Deleted.
(WebCore::workerGlobalScopeDidReceiveMessage): Deleted.
(WebCore::workerGlobalScopeDidReceiveBinaryData): Deleted.
(WebCore::workerGlobalScopeDidUpdateBufferedAmount): Deleted.
(WebCore::workerGlobalScopeDidStartClosingHandshake): Deleted.
(WebCore::workerGlobalScopeDidClose): Deleted.
(WebCore::workerGlobalScopeDidReceiveMessageError): Deleted.
(WebCore::WorkerThreadableWebSocketChannel::mainThreadConnect): Deleted.
(WebCore::WorkerThreadableWebSocketChannel::mainThreadSend): Deleted.
(WebCore::WorkerThreadableWebSocketChannel::mainThreadSendArrayBuffer): Deleted.
(WebCore::WorkerThreadableWebSocketChannel::mainThreadSendBlob): Deleted.
(WebCore::WorkerThreadableWebSocketChannel::mainThreadBufferedAmount): Deleted.
(WebCore::WorkerThreadableWebSocketChannel::mainThreadClose): Deleted.
(WebCore::WorkerThreadableWebSocketChannel::mainThreadFail): Deleted.
(WebCore::WorkerThreadableWebSocketChannel::mainThreadDestroy): Deleted.
(WebCore::WorkerThreadableWebSocketChannel::mainThreadSuspend): Deleted.
(WebCore::WorkerThreadableWebSocketChannel::mainThreadResume): Deleted.

  • Modules/websockets/WorkerThreadableWebSocketChannel.h:
12:12 AM Changeset in webkit [172886] by Yusuke Suzuki
  • 3 edits in trunk/Source/WebCore

Clean up build warnings: control reaches end of non-void function
​https://bugs.webkit.org/show_bug.cgi?id=135889

Reviewed by Alexey Proskuryakov.

  • bindings/js/JSCryptoAlgorithmDictionary.cpp:

(WebCore::JSCryptoAlgorithmDictionary::createParametersForEncrypt):
(WebCore::JSCryptoAlgorithmDictionary::createParametersForDecrypt):
(WebCore::JSCryptoAlgorithmDictionary::createParametersForSign):
(WebCore::JSCryptoAlgorithmDictionary::createParametersForVerify):
(WebCore::JSCryptoAlgorithmDictionary::createParametersForDigest):
(WebCore::JSCryptoAlgorithmDictionary::createParametersForGenerateKey):
(WebCore::JSCryptoAlgorithmDictionary::createParametersForDeriveKey):
(WebCore::JSCryptoAlgorithmDictionary::createParametersForDeriveBits):
(WebCore::JSCryptoAlgorithmDictionary::createParametersForImportKey):
(WebCore::JSCryptoAlgorithmDictionary::createParametersForExportKey):

  • crypto/CryptoKey.cpp:

(WebCore::CryptoKey::type):

12:11 AM Changeset in webkit [172885] by zandobersek@gmail.com
  • 2 edits in trunk/Source/WebCore

[TexMap] Only notify of a required flush on the first layer property change
​https://bugs.webkit.org/show_bug.cgi?id=136104

Reviewed by Martin Robinson.

The GraphicsLayer's client should only be notified that a flush is required
when the first change of one of the layer's properties is initiated, instead
of requesting the flush on every such change.

  • platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:

(WebCore::GraphicsLayerTextureMapper::notifyChange):

Aug 22, 2014:

11:59 PM Changeset in webkit [172884] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

Try to fix the Mac build using the internal SDK.

  • bindings/objc/PublicDOMInterfaces.h:
11:32 PM Changeset in webkit [172883] by commit-queue@webkit.org
  • 12 edits
    3 deletes in trunk

Remove LevelDB.
​https://bugs.webkit.org/show_bug.cgi?id=136170

Patch by Renato Nagy <​nagy.renato@stud.u-szeged.hu> on 2014-08-22
Reviewed by Gyuyoung Kim.

Source/ThirdParty:

  • leveldb/AUTHORS: Removed.
  • leveldb/LICENSE: Removed.
  • leveldb/Makefile: Removed.
  • leveldb/NEWS: Removed.
  • leveldb/README: Removed.
  • leveldb/TODO: Removed.
  • leveldb/build_detect_platform: Removed.
  • leveldb/db/builder.cc: Removed.
  • leveldb/db/builder.h: Removed.
  • leveldb/db/c.cc: Removed.
  • leveldb/db/c_test.c: Removed.
  • leveldb/db/corruption_test.cc: Removed.
  • leveldb/db/db_bench.cc: Removed.
  • leveldb/db/db_impl.cc: Removed.
  • leveldb/db/db_impl.h: Removed.
  • leveldb/db/db_iter.cc: Removed.
  • leveldb/db/db_iter.h: Removed.
  • leveldb/db/db_test.cc: Removed.
  • leveldb/db/dbformat.cc: Removed.
  • leveldb/db/dbformat.h: Removed.
  • leveldb/db/dbformat_test.cc: Removed.
  • leveldb/db/filename.cc: Removed.
  • leveldb/db/filename.h: Removed.
  • leveldb/db/filename_test.cc: Removed.
  • leveldb/db/leveldb_main.cc: Removed.
  • leveldb/db/log_format.h: Removed.
  • leveldb/db/log_reader.cc: Removed.
  • leveldb/db/log_reader.h: Removed.
  • leveldb/db/log_test.cc: Removed.
  • leveldb/db/log_writer.cc: Removed.
  • leveldb/db/log_writer.h: Removed.
  • leveldb/db/memtable.cc: Removed.
  • leveldb/db/memtable.h: Removed.
  • leveldb/db/repair.cc: Removed.
  • leveldb/db/skiplist.h: Removed.
  • leveldb/db/skiplist_test.cc: Removed.
  • leveldb/db/snapshot.h: Removed.
  • leveldb/db/table_cache.cc: Removed.
  • leveldb/db/table_cache.h: Removed.
  • leveldb/db/version_edit.cc: Removed.
  • leveldb/db/version_edit.h: Removed.
  • leveldb/db/version_edit_test.cc: Removed.
  • leveldb/db/version_set.cc: Removed.
  • leveldb/db/version_set.h: Removed.
  • leveldb/db/version_set_test.cc: Removed.
  • leveldb/db/write_batch.cc: Removed.
  • leveldb/db/write_batch_internal.h: Removed.
  • leveldb/db/write_batch_test.cc: Removed.
  • leveldb/doc/bench/db_bench_sqlite3.cc: Removed.
  • leveldb/doc/bench/db_bench_tree_db.cc: Removed.
  • leveldb/doc/benchmark.html: Removed.
  • leveldb/doc/doc.css: Removed.
  • leveldb/doc/impl.html: Removed.
  • leveldb/doc/index.html: Removed.
  • leveldb/doc/log_format.txt: Removed.
  • leveldb/doc/table_format.txt: Removed.
  • leveldb/helpers/memenv/memenv.cc: Removed.
  • leveldb/helpers/memenv/memenv.h: Removed.
  • leveldb/helpers/memenv/memenv_test.cc: Removed.
  • leveldb/include/leveldb/c.h: Removed.
  • leveldb/include/leveldb/cache.h: Removed.
  • leveldb/include/leveldb/comparator.h: Removed.
  • leveldb/include/leveldb/db.h: Removed.
  • leveldb/include/leveldb/env.h: Removed.
  • leveldb/include/leveldb/filter_policy.h: Removed.
  • leveldb/include/leveldb/iterator.h: Removed.
  • leveldb/include/leveldb/options.h: Removed.
  • leveldb/include/leveldb/slice.h: Removed.
  • leveldb/include/leveldb/status.h: Removed.
  • leveldb/include/leveldb/table.h: Removed.
  • leveldb/include/leveldb/table_builder.h: Removed.
  • leveldb/include/leveldb/write_batch.h: Removed.
  • leveldb/port/README: Removed.
  • leveldb/port/atomic_pointer.h: Removed.
  • leveldb/port/port.h: Removed.
  • leveldb/port/port_example.h: Removed.
  • leveldb/port/port_posix.cc: Removed.
  • leveldb/port/port_posix.h: Removed.
  • leveldb/port/thread_annotations.h: Removed.
  • leveldb/port/win/stdint.h: Removed.
  • leveldb/table/block.cc: Removed.
  • leveldb/table/block.h: Removed.
  • leveldb/table/block_builder.cc: Removed.
  • leveldb/table/block_builder.h: Removed.
  • leveldb/table/filter_block.cc: Removed.
  • leveldb/table/filter_block.h: Removed.
  • leveldb/table/filter_block_test.cc: Removed.
  • leveldb/table/format.cc: Removed.
  • leveldb/table/format.h: Removed.
  • leveldb/table/iterator.cc: Removed.
  • leveldb/table/iterator_wrapper.h: Removed.
  • leveldb/table/merger.cc: Removed.
  • leveldb/table/merger.h: Removed.
  • leveldb/table/table.cc: Removed.
  • leveldb/table/table_builder.cc: Removed.
  • leveldb/table/table_test.cc: Removed.
  • leveldb/table/two_level_iterator.cc: Removed.
  • leveldb/table/two_level_iterator.h: Removed.
  • leveldb/util/arena.cc: Removed.
  • leveldb/util/arena.h: Removed.
  • leveldb/util/arena_test.cc: Removed.
  • leveldb/util/bloom.cc: Removed.
  • leveldb/util/bloom_test.cc: Removed.
  • leveldb/util/cache.cc: Removed.
  • leveldb/util/cache_test.cc: Removed.
  • leveldb/util/coding.cc: Removed.
  • leveldb/util/coding.h: Removed.
  • leveldb/util/coding_test.cc: Removed.
  • leveldb/util/comparator.cc: Removed.
  • leveldb/util/crc32c.cc: Removed.
  • leveldb/util/crc32c.h: Removed.
  • leveldb/util/crc32c_test.cc: Removed.
  • leveldb/util/env.cc: Removed.
  • leveldb/util/env_posix.cc: Removed.
  • leveldb/util/env_test.cc: Removed.
  • leveldb/util/filter_policy.cc: Removed.
  • leveldb/util/hash.cc: Removed.
  • leveldb/util/hash.h: Removed.
  • leveldb/util/histogram.cc: Removed.
  • leveldb/util/histogram.h: Removed.
  • leveldb/util/logging.cc: Removed.
  • leveldb/util/logging.h: Removed.
  • leveldb/util/mutexlock.h: Removed.
  • leveldb/util/options.cc: Removed.
  • leveldb/util/posix_logger.h: Removed.
  • leveldb/util/random.h: Removed.
  • leveldb/util/status.cc: Removed.
  • leveldb/util/testharness.cc: Removed.
  • leveldb/util/testharness.h: Removed.
  • leveldb/util/testutil.cc: Removed.
  • leveldb/util/testutil.h: Removed.

Source/WebCore:

  • CMakeLists.txt:
  • Modules/indexeddb/IDBObjectStore.cpp:

(WebCore::IDBObjectStore::createIndex):

  • Modules/indexeddb/IDBTransactionCoordinator.cpp:

(WebCore::IDBTransactionCoordinator::canRunTransaction):
(WebCore::doScopesOverlap): Deleted.

  • Modules/indexeddb/leveldb/IDBBackingStoreCursorLevelDB.cpp: Removed.
  • Modules/indexeddb/leveldb/IDBBackingStoreCursorLevelDB.h: Removed.
  • Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.cpp: Removed.
  • Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.h: Removed.
  • Modules/indexeddb/leveldb/IDBBackingStoreTransactionLevelDB.cpp: Removed.
  • Modules/indexeddb/leveldb/IDBBackingStoreTransactionLevelDB.h: Removed.
  • Modules/indexeddb/leveldb/IDBFactoryBackendLevelDB.cpp: Removed.
  • Modules/indexeddb/leveldb/IDBFactoryBackendLevelDB.h: Removed.
  • Modules/indexeddb/leveldb/IDBIndexWriterLevelDB.cpp: Removed.
  • Modules/indexeddb/leveldb/IDBIndexWriterLevelDB.h: Removed.
  • Modules/indexeddb/leveldb/IDBLevelDBCoding.cpp: Removed.
  • Modules/indexeddb/leveldb/IDBLevelDBCoding.h: Removed.
  • Modules/indexeddb/leveldb/IDBServerConnectionLevelDB.cpp: Removed.
  • Modules/indexeddb/leveldb/IDBServerConnectionLevelDB.h: Removed.
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/DatabaseStrategy.cpp:

(WebCore::DatabaseStrategy::createIDBFactoryBackend):

  • platform/leveldb/LevelDBComparator.h: Removed.
  • platform/leveldb/LevelDBDatabase.cpp: Removed.
  • platform/leveldb/LevelDBDatabase.h: Removed.
  • platform/leveldb/LevelDBIterator.h: Removed.
  • platform/leveldb/LevelDBSlice.h: Removed.
  • platform/leveldb/LevelDBTransaction.cpp: Removed.
  • platform/leveldb/LevelDBTransaction.h: Removed.
  • platform/leveldb/LevelDBWriteBatch.cpp: Removed.
  • platform/leveldb/LevelDBWriteBatch.h: Removed.

Tools:

  • Scripts/webkitpy/common/config/watchlist:
  • Scripts/webkitpy/style/checker.py:
11:29 PM Changeset in webkit [172882] by commit-queue@webkit.org
  • 4 edits in trunk

.:
[EFL] Turn on ENABLE_GAMEPAD_DEPRECATED option.
​https://bugs.webkit.org/show_bug.cgi?id=136110

Patch by KwangHyuk Kim <​hyuki.kim@samsung.com> on 2014-08-22
Reviewed by Gyuyoung Kim.

Turn on ENABLE_GAMEPAD_DEPRECATED option for the WK2 Efl.

  • Source/cmake/OptionsEfl.cmake:

Source/WebCore:
[EFL] Fix build break caused by ENABLE_GAMEPAD_DEPRECATED.
​https://bugs.webkit.org/show_bug.cgi?id=136110

Patch by KwangHyuk Kim <​hyuki.kim@samsung.com> on 2014-08-22
Reviewed by Gyuyoung Kim.

WebCore_INCLUDE_DIRECTORY for gamepad was removed from WK2 Efl in order to fix build break when ENABLE_GAMEPAD_DEPRECATED is on.

No new tests because no functional changes.

  • PlatformEfl.cmake:
9:34 PM Changeset in webkit [172881] by zoltan@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL][WK2] Remove fast/css3-text/css3-text-align-last/text-align-last-with-text-align-justify.html from skipped list
​https://bugs.webkit.org/show_bug.cgi?id=128732

Reviewed by Gyuyoung Kim.

  • css3/shapes/shape-outside/supported-shapes/polygon/shape-outside-polygon-012.html:
  • platform/efl/TestExpectations:
9:30 PM Changeset in webkit [172880] by benjamin@webkit.org
  • 13 edits
    12 adds in trunk

Style invalidation does not work for adjacent node updates
​https://bugs.webkit.org/show_bug.cgi?id=136145

Reviewed by Antti Koivisto.

Source/WebCore:

There were a bunch of cases in which the style would be in an inconsistent
state until the style resolver kicks in for the entire document.

For example, let's take the selector "foo.bar + target". When the class "bar"
changes, the element foo is invalidated. The element target is untouched.

Now, if the style of "target" is accessed, nodeOrItsAncestorNeedsStyleRecalc()
returns false and the old style is accessed.

At some point, when the style of the entire document is resolved, the node
"foo" is styled, and "target" is invalidated.

To fix the issue, this patch adds an extra flag keeping track of subtrees that
have any node needing style recalc: DirectChildNeedsStyleRecalcFlag.

When invalidating the node "foo", its parent is marked with
DirectChildNeedsStyleRecalcFlag to note that one of the child nodes has an invalid style.

When verifying the style state in nodeOrItsAncestorNeedsStyleRecalc(), we check that flag
in addition to the siblings dependencies to find if the node is part of a subtree that may
be invalid due to sibling selectors.

Similarly, in the style resolver, we use the flag to clear the style on all elements
that could potentially be invalid.

This patch removes the changes introduced by r172721
(The style is not updated correctly when the pseudo class :empty is applied on anything but the rightmost element).
That bug was just a special case of what is solved here.

Tests: fast/selectors/attribute-direct-adjacent-style-update.html

fast/selectors/attribute-sibling-style-update.html
fast/selectors/class-direct-adjacent-style-update.html
fast/selectors/class-sibling-style-update.html
fast/selectors/first-child-direct-adjacent-style-update.html
fast/selectors/first-child-sibling-style-update.html

  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::checkOne):

  • cssjit/SelectorCompiler.cpp:

(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementIsEmpty):
(WebCore::SelectorCompiler::setStyleOfSiblingsAffectedByEmpty): Deleted.

  • dom/ContainerNode.h:

(WebCore::ContainerNode::directChildNeedsStyleRecalc):
(WebCore::ContainerNode::setDirectChildNeedsStyleRecalc):
Remove the special case for :empty.

  • dom/Document.cpp:

(WebCore::nodeOrItsAncestorNeedsStyleRecalc):

  • dom/Element.cpp:

(WebCore::checkForEmptyStyleChange):
(WebCore::checkForSiblingStyleChanges):
(WebCore::Element::setStyleOfSiblingsAffectedByEmpty): Deleted.
(WebCore::Element::rareDataStyleOfSiblingsAffectedByEmpty): Deleted.

  • dom/Element.h:

(WebCore::Element::styleOfSiblingsAffectedByEmpty): Deleted.

  • dom/ElementRareData.h:

(WebCore::ElementRareData::ElementRareData):
(WebCore::ElementRareData::styleOfSiblingsAffectedByEmpty): Deleted.
(WebCore::ElementRareData::setStyleOfSiblingsAffectedByEmpty): Deleted.

  • dom/Node.cpp:

(WebCore::markAncestorsWithChildNeedsStyleRecalc):
(WebCore::Node::setNeedsStyleRecalc):
(WebCore::Node::markAncestorsWithChildNeedsStyleRecalc): Deleted.

  • dom/Node.h:

(WebCore::Node::clearChildNeedsStyleRecalc):

  • style/StyleResolveTree.cpp:

(WebCore::Style::resetStyleForNonRenderedDescendants):

LayoutTests:

Add tests covering the basic cases: classes and attributes.

First-child covers the basic positional updates.

The tests have a version without any indirect adjacent ("~") because the marking
used for those is much more generic and having them hide some bugs.

Some tests are still failing. That is due to the style resolver not handling
direct siblings ("+") correctly when there are multiple of them. I will address
that separately.

  • fast/selectors/attribute-direct-adjacent-style-update-expected.txt: Added.
  • fast/selectors/attribute-direct-adjacent-style-update.html: Added.
  • fast/selectors/attribute-sibling-style-update-expected.txt: Added.
  • fast/selectors/attribute-sibling-style-update.html: Added.
  • fast/selectors/class-direct-adjacent-style-update-expected.txt: Added.
  • fast/selectors/class-direct-adjacent-style-update.html: Added.
  • fast/selectors/class-sibling-style-update-expected.txt: Added.
  • fast/selectors/class-sibling-style-update.html: Added.
  • fast/selectors/first-child-direct-adjacent-style-update.html: Added.
  • fast/selectors/first-child-sibling-style-update-expected.txt: Added.
  • fast/selectors/first-child-sibling-style-update.html: Added.
  • fast/selectors/placeholder-shown-sibling-style-update-expected.txt:
6:58 PM Changeset in webkit [172879] by matthew_hanson@apple.com
  • 5 edits in branches/safari-600.1-branch/Source

Versioning.

6:54 PM Changeset in webkit [172878] by matthew_hanson@apple.com
  • 1 copy in tags/Safari-600.1.15

New Tag.

6:28 PM Changeset in webkit [172877] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Remove unused legacy InspectorFrontendHost methods
​https://bugs.webkit.org/show_bug.cgi?id=136186

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-08-22
Reviewed by Andreas Kling.

  • bindings/js/JSInspectorFrontendHostCustom.cpp:

(WebCore::JSInspectorFrontendHost::recordActionTaken): Deleted.
(WebCore::JSInspectorFrontendHost::recordPanelShown): Deleted.
(WebCore::JSInspectorFrontendHost::recordSettingChanged): Deleted.

  • inspector/InspectorFrontendHost.idl:
5:43 PM Changeset in webkit [172876] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

Remove unnecessary WTFString creation in Dictionary getter
​https://bugs.webkit.org/show_bug.cgi?id=136184

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-08-22
Reviewed by Benjamin Poulain.

  • bindings/js/Dictionary.cpp:

(WebCore::Dictionary::getWithUndefinedOrNullCheck):

  • bindings/js/Dictionary.h:
  • bindings/js/JSDictionary.cpp:

(WebCore::JSDictionary::getWithUndefinedOrNullCheck):

  • bindings/js/JSDictionary.h:
4:04 PM Changeset in webkit [172875] by commit-queue@webkit.org
  • 18 edits in trunk/Source

Unreviewed, rolling out r172866.
​https://bugs.webkit.org/show_bug.cgi?id=136177

Broke iOS build (Requested by othermaciej on #webkit).

Reverted changeset:

"Replace use of WKCopyCFLocalizationPreferredName with
NSLocale public API"
​https://bugs.webkit.org/show_bug.cgi?id=136082
​http://trac.webkit.org/changeset/172866

3:30 PM Changeset in webkit [172874] by hyatt@apple.com
  • 5 edits
    3 adds in trunk

Add proper support for letter-spacing to bopomofo Ruby
​https://bugs.webkit.org/show_bug.cgi?id=136171

Reviewed by Sam Weinig.

Source/WebCore:

Added fast/ruby/bopomofo-letter-spacing.html

  • rendering/RenderRubyRun.cpp:

(WebCore::RenderRubyRun::layout):
Alter the layout of bopomofo ruby so that the distance between the base characters is the max of
the letter-spacing between the characters and the minimum required width to hold two rows of
Ruby.

Push the bopomofo ruby into the letter-spacing to ensure that it comes right after the base character
and not after all the letter-spacing.

LayoutTests:

  • fast/ruby/bopomofo-letter-spacing.html: Added.
  • platform/mac/fast/ruby/bopomofo-expected.png:
  • platform/mac/fast/ruby/bopomofo-expected.txt:
  • platform/mac/fast/ruby/bopomofo-letter-spacing-expected.png: Added.
  • platform/mac/fast/ruby/bopomofo-letter-spacing-expected.txt: Added.
3:09 PM Changeset in webkit [172873] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

Fix showing paint rects when selecting lines in the timeline
​https://bugs.webkit.org/show_bug.cgi?id=136173

Reviewed by Joseph Pecoraro.

Fix the condition used to decide when to show the overlay.

  • inspector/InspectorOverlay.cpp:

(WebCore::InspectorOverlay::shouldShowOverlay):

3:09 PM Changeset in webkit [172872] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

Use the correct rect for paint flashing
​https://bugs.webkit.org/show_bug.cgi?id=136169

Reviewed by Sam Weinig.

Use the rect we've converted to root document coordinates for paint flashing.

  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::didPaint):

1:55 PM Changeset in webkit [172871] by dino@apple.com
  • 2 edits in trunk/Source/WebCore

Google Canvas2D maps are too slow and uncontrollable with Safari with full screen mode
​https://bugs.webkit.org/show_bug.cgi?id=136168

Reviewed by Tim Horton.

When Google maps are using their 2D "lite" fallback and you're drawing in a huge
window such as fullscreen 4K, we would drop back to unaccelerated mode, thinking
that we'd exceeded the maximum IOSurface size.

Remove the hardcoded limit on IOSurface sizes, and instead ask the system
what it believe the maximum to be. This was significantly higher than our
limit on the systems I tested.

  • platform/graphics/cg/ImageBufferCG.cpp:

(WebCore::ImageBuffer::ImageBuffer): Include our IOSurface wrapper, which
has a query for maximum size, and use that instead.

1:40 PM Changeset in webkit [172870] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

Maybe fix Windows.

  • inspector/InspectorOverlay.cpp:

(WebCore::InspectorOverlay::showPaintRect):

1:26 PM Changeset in webkit [172869] by Simon Fraser
  • 10 edits in trunk/Source

Implement paint flashing in the WK1 InspectorOverlay page
​https://bugs.webkit.org/show_bug.cgi?id=136138

Reviewed by Sam Weinig, Joseph Pecoraro.

Implement paint flashing for the WebKit1 InspectorOverlay via a second canvas in the overlay page.
We avoid allocating backing store for this canvas until we have paint rects.

Because this overlay page is weird and doesn't know how to paint itself, InspectorOverlay manages
an array of rects, and pushes them to the page when they change, before forcing a paint.

Because iOS doesn't use the InspectorOverlay page, stub out setShowPaintRects on its
WebKit WebInspectorClient, but don't yet implement paint flashing there.

Source/WebCore:

  • inspector/InspectorOverlay.cpp:

(WebCore::InspectorOverlay::InspectorOverlay):
(WebCore::InspectorOverlay::shouldShowOverlay):
(WebCore::InspectorOverlay::update):
(WebCore::buildObjectForRect):
(WebCore::InspectorOverlay::setShowingPaintRects):
(WebCore::InspectorOverlay::showPaintRect):
(WebCore::InspectorOverlay::updatePaintRectsTimerFired):
(WebCore::InspectorOverlay::drawPaintRects):
(WebCore::InspectorOverlay::forcePaint):
(WebCore::quadToPath): Deleted.
(WebCore::drawOutlinedQuad): Deleted.
(WebCore::InspectorOverlay::drawOutline): Deleted.

  • inspector/InspectorOverlay.h:
  • inspector/InspectorOverlayPage.html:
  • inspector/InspectorOverlayPage.js:

(updatePaintRects):
(reset):
(_drawShapeHighlight):

  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::setShowPaintRects):
(WebCore::InspectorPageAgent::didPaint):

Source/WebKit/ios:

  • WebCoreSupport/WebInspectorClientIOS.mm:

(WebInspectorClient::setShowPaintRects):
(WebInspectorClient::showPaintRect):

Source/WebKit/mac:

  • WebCoreSupport/WebInspectorClient.h:
  • WebCoreSupport/WebInspectorClient.mm:

(WebInspectorClient::WebInspectorClient):

1:10 PM Changeset in webkit [172868] by eric.carlson@apple.com
  • 6 edits in trunk/Source/WebCore

[iOS] Cleanup media code
​https://bugs.webkit.org/show_bug.cgi?id=136163

Reviewed by Jer Noble.

No new tests, no functionality was changed.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::HTMLMediaElement): Don't initialize m_requestingPlay.
(WebCore::HTMLMediaElement::parseMediaPlayerAttribute): Deleted.
(WebCore::HTMLMediaElement::parseAttribute): Don't call parseMediaPlayerAttribute.
(WebCore::HTMLMediaElement::playInternal): m_requestingPlay is dead, Jim.
(WebCore::HTMLMediaElement::updatePlayState): Ditto.
(WebCore::HTMLMediaElement::updatePlayState): Remove obsolete FIXME.

  • html/HTMLMediaElement.h:
  • platform/graphics/MediaPlayer.cpp:

(WebCore::MediaPlayer::attributeChanged): Deleted.
(WebCore::MediaPlayer::readyForPlayback): Deleted.

  • platform/graphics/MediaPlayer.h:
  • platform/graphics/MediaPlayerPrivate.h:

(WebCore::MediaPlayerPrivateInterface::attributeChanged): Deleted.
(WebCore::MediaPlayerPrivateInterface::readyForPlayback): Deleted.

12:54 PM Changeset in webkit [172867] by msaboff@apple.com
  • 17 edits in trunk/Source/JavaScriptCore

REGRESSION(r163179): Sporadic crash in js/dom/line-column-numbers.html test
​https://bugs.webkit.org/show_bug.cgi?id=136111

Reviewed by Filip Pizlo.

The problem was that we weren't properly handling VM::topVMEntryFrame in two ways.

First in the case where we get an exception of a stack overflow during setup of the direct
callee frame of a VM entry frame, we need to throw the exception in the caller's frame.
This requires unrolling topVMEntryFrame while creating the exception object. This is
accomplished with the renamed NativeCallFrameTracerWithRestore object. As part of this,
split the JIT rollback exception handling to call a new helper,
callLookupExceptionHandlerFromCallerFrame, which will unroll the callFrame and VMEntryFrame.

Second, when we unwind to find a handler, we also need to unwind topVMCallFrame for the
case where we end up (re)throwing another exception after entering the catch block, but
before another vmEntry call. Added VM::vmEntryFrameForThrow as a way similar to
VM::callFrameForThrow to pass the appropriate VMENtryFrame to the catch block.

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::compileExceptionHandlers):

  • ftl/FTLCompile.cpp:

(JSC::FTL::fixFunctionBasedOnStackMaps):

  • jit/JIT.cpp:

(JSC::JIT::privateCompileExceptionHandlers):
Split out the unroll cases to use the new helper callLookupExceptionHandlerFromCallerFrame()
to unwind both the callFrame and topVMEntryFrame.

  • interpreter/Interpreter.cpp:

(JSC::UnwindFunctor::UnwindFunctor):
(JSC::UnwindFunctor::operator()):
(JSC::Interpreter::unwind):

  • jit/JITExceptions.cpp:

(JSC::genericUnwind):
Added VMEntryFrame as another component to unwind.

  • interpreter/Interpreter.h:

(JSC::NativeCallFrameTracer::NativeCallFrameTracer):
(JSC::NativeCallFrameTracerWithRestore::NativeCallFrameTracerWithRestore):
(JSC::NativeCallFrameTracerWithRestore::~NativeCallFrameTracerWithRestore):
Renamed and changed to save and restore topCallFrame and topVMEntryFrame around the setting of
both values.

  • interpreter/StackVisitor.cpp:

(JSC::StackVisitor::gotoNextFrame):
(JSC::StackVisitor::readNonInlinedFrame):

  • interpreter/StackVisitor.h:

(JSC::StackVisitor::Frame::vmEntryFrame):
Added code to unwind the VMEntryFrame.

  • jit/CCallHelpers.h:

(JSC::CCallHelpers::jumpToExceptionHandler): Updated comment to indicate that the value
the handler should use for VM::topEntryFrame is in VM::vmEntryFrameForThrow.

  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_catch):

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_catch):

  • llint/LowLevelInterpreter32_64.asm:
  • llint/LowLevelInterpreter64.asm:

Added code to update VM::topVMEntryFrame from VM::vmEntryFrameForThrowOffset.

  • jit/JITOperations.cpp:
  • jit/JITOperations.h:

(JSC::operationThrowStackOverflowError):
(JSC::operationCallArityCheck):
(JSC::operationConstructArityCheck):

  • runtime/VM.h:

(JSC::VM::vmEntryFrameForThrowOffset):
(JSC::VM::topVMEntryFrameOffset):
Added as the side channel to return the topVMEntryFrame that the handler should use.

12:39 PM Changeset in webkit [172866] by mjs@apple.com
  • 18 edits in trunk/Source

Replace use of WKCopyCFLocalizationPreferredName with NSLocale public API
​https://bugs.webkit.org/show_bug.cgi?id=136082

Reviewed by Alexey Proskuryakov.

Source/WebCore:

  • platform/mac/Language.mm:

(WebCore::httpStyleLanguageCode): Replace use of WKCopyCFLocalizationPreferredName
with new WebCoreNSStringExtras helper.

  • platform/mac/WebCoreNSStringExtras.mm: Replacements for the aspects of

WKCopyCFLocalizationPreferredName.
(preferredBundleLocalizationName): New helper - most preferred localization available
in the main bundle, canonicalized the way we like it.
(canonicalLocalizationName): Convert a lcalization name to a string with language and
country code, using default if necessary (e.g. "en" maps to "en_US").

  • WebCore.order: Remove mention of WKCopyCFLocalizationPreferredName.
  • WebCore.exp.in: ditto; also export preferredBundleLocalizationName for WebKit(2).
  • platform/ios/WebCoreSystemInterfaceIOS.mm: ditto
  • platform/mac/WebCoreSystemInterface.h: ditto
  • platform/mac/WebCoreSystemInterface.mm: ditto

Source/WebKit/mac:

  • Plugins/Hosted/NetscapePluginHostManager.mm:

(WebKit::NetscapePluginHostManager::spawnPluginHost): Get current
localization name using WebCore helper instead of SPI.

  • Plugins/WebBasePluginPackage.mm: Fixed the include style for this

file.
(-[WebBasePluginPackage getPluginInfoFromPLists]): Get current
localization name using WebCore helper instead of SPI.
(+[WebBasePluginPackage preferredLocalizationName]): Deleted. This
helper no longer pulls its weight.

  • WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface): Remove mention of
WKCopyCFLocalizationPreferredName.

  • WebKit.order: ditto

Source/WebKit2:

  • UIProcess/Launcher/mac/ProcessLauncherMac.mm:

(WebKit::connectToService): Remove accidental leftover retrieval
of the localization.
(WebKit::createProcess): Get current localization name from
CFBundle API instead of using SPI.

  • WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:

(InitWebCoreSystemInterface): Remove mention of WKCopyCFLocalizationPreferredName

  • mac/WebKit2.order: ditto
12:09 PM Changeset in webkit [172865] by dbates@webkit.org
  • 30 edits in trunk/Source

[iOS] Disable ENABLE_IOS_{GESTURE, TOUCH}_EVENTS, and temporarily disable ENABLE_TOUCH_EVENTS
and ENABLE_XSLT when building with the iOS public SDK
​https://bugs.webkit.org/show_bug.cgi?id=135945

Reviewed by Andy Estes.

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

Towards bringing up the iOS WebKit port using the iOS public SDK, disable the proprietary
iOS gesture and touch event code. For now we also temporarily disable ENABLE_TOUCH_EVENTS
and ENABLE_XSLT while we focus to get the rest of the port built using the public SDK. We'll
look to enable these features once we stabilize the build.

  • Configurations/FeatureDefines.xcconfig: Disable ENABLE_IOS_{GESTURE, TOUCH}_EVENTS, ENABLE_TOUCH_EVENTS

and ENABLE_XSLT when building with the public SDK.

  • Configurations/WebCore.xcconfig:
  • DerivedSources.make: Conditionally generate derived sources for touch and gesture events as applicable and pass

define WTF_USE_APPLE_INTERNAL_SDK when generating bindings (if applicable). Make the logic for determining
whether WTF_PLATFORM_IOS is defined consistent with logic for determining whether WTF_USE_APPLE_INTERNAL_SDK and
ENABLE_ORIENTATION_EVENTS are defined. We should look to further cleanup this code.

  • bindings/js/ios/TouchConstructors.cpp: Substitute ENABLE(IOS_TOUCH_EVENTS) for macro expression "PLATFORM(IOS) && ENABLE(TOUCH_EVENTS)".
  • bindings/objc/DOMEvents.h: Write preprocessor logic in terms of ENABLE_TOUCH_EVENTS and ENABLE_IOS_GESTURE_EVENTS.
  • bindings/objc/PublicDOMInterfaces.h: Include private header <WebKitAdditions/PublicDOMInterfacesIOS.h> when

it exists as opposed to assuming it exists when building for iOS.

  • dom/Document.cpp:

(WebCore::Document::Document): Substitute ENABLE(IOS_TOUCH_EVENTS) for macro expression "ENABLE(TOUCH_EVENTS) && PLATFORM(IOS)".
(WebCore::Document::prepareForDestruction): Ditto.
(WebCore::Document::removeAllEventListeners): Ditto.

  • dom/Document.h: Write preprocessor logic in terms of ENABLE_IOS_TOUCH_EVENTS and ENABLE_TOUCH_EVENTS.
  • dom/Document.idl: Ditto.
  • dom/Touch.h: Substitute ENABLE(IOS_TOUCH_EVENTS) for PLATFORM(IOS)..
  • dom/TouchEvent.h: Ditto.
  • dom/TouchList.h: Ditto.
  • dom/ios/TouchEvents.cpp: Substitute ENABLE(IOS_TOUCH_EVENTS) for macro expression "PLATFORM(IOS) && ENABLE(TOUCH_EVENTS)".
  • history/CachedFrame.cpp: Add PLATFORM(IOS) guard.
  • html/shadow/SliderThumbElement.cpp:

(WebCore::SliderThumbElement::SliderThumbElement): Substitute ENABLE(IOS_TOUCH_EVENTS) for ENABLE(TOUCH_EVENTS).
(WebCore::SliderThumbElement::willDetachRenderers): Ditto.

  • html/shadow/SliderThumbElement.h: Ditto.
  • loader/EmptyClients.h: Ditto.
  • platform/ios/PlatformEventFactoryIOS.h: Write preprocessor logic in terms of ENABLE_IOS_TOUCH_EVENTS and ENABLE_TOUCH_EVENTS.

Only include header <WebKitAdditions/PlatformTouchEventIOS.h> when building with ENABLE_TOUCH_EVENTS enabled.

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig: Disable ENABLE_IOS_{GESTURE, TOUCH}_EVENTS, ENABLE_TOUCH_EVENTS

and ENABLE_XSLT when building with the public SDK.

  • MigrateHeaders.make: Conditionally migrate headers for touch and gesture events.

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig: Disable ENABLE_IOS_{GESTURE, TOUCH}_EVENTS, ENABLE_TOUCH_EVENTS

and ENABLE_XSLT when building with the public SDK.

  • Shared/WebEventConversion.h: Write preprocessor logic in terms of ENABLE(IOS_TOUCH_EVENTS).
  • WebProcess/WebPage/WebPage.h: Ditto.

Source/WTF:

  • wtf/FeatureDefines.h:
12:07 PM Changeset in webkit [172864] by Simon Fraser
  • 12 edits in trunk/Source

Implement paint flashing via GraphicsLayers in the WK2 inspector overlay
​https://bugs.webkit.org/show_bug.cgi?id=136136

Reviewed by Sam Weinig, Joseph Pecoraro.
Source/WebCore:

Allow InspectorClient to have a custom implementation of showPaintRect(). For
WebKit2's WebInspectorClient, implement this by creating a set of GraphicsLayers
which are parented in a document overlay, with 0.25s fade-out animations.

Also change InspectorInstrumentation::didPaintImpl() to no longer take a GraphicsContext;
it makes no sense to paint the paint rects directly into the context of the web page.
Now that the paint rects are painted into an overlay, the rectangles need to be converted
to root document coordinates, which is done in InspectorInstrumentation::didPaintImpl().

Remove the generic InspectorOverlay::drawOutline()-based indicators; they will
be reimplemented in a later patch.

  • WebCore.exp.in:
  • inspector/InspectorClient.h:

(WebCore::InspectorClient::showPaintRect):

  • inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::didPaintImpl):

  • inspector/InspectorInstrumentation.h:

(WebCore::InspectorInstrumentation::didPaint):

  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::didPaint):

  • inspector/InspectorPageAgent.h:
  • page/FrameView.cpp:

(WebCore::FrameView::didPaintContents):

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::paintContents):

Source/WebKit2:

Allow InspectorClient to have a custom implementation of showPaintRect(). For
WebKit2's WebInspectorClient, implement this by creating a set of GraphicsLayers
which are parented in a document overlay, with 0.25s fade-out animations.

Also change InspectorInstrumentation::didPaintImpl() to no longer take a GraphicsContext;
it makes no sense to paint the paint rects directly into the context of the web page.
Now that the paint rects are painted into an overlay, the rectangles need to be converted
to root document coordinates, which is done in InspectorInstrumentation::didPaintImpl().

Remove the generic InspectorOverlay::drawOutline()-based indicators; they will
be reimplemented in a later patch.

  • WebProcess/WebCoreSupport/WebInspectorClient.cpp:

(WebKit::RepaintIndicatorLayerClient::RepaintIndicatorLayerClient):
(WebKit::RepaintIndicatorLayerClient::~RepaintIndicatorLayerClient):
(WebKit::RepaintIndicatorLayerClient::notifyAnimationEnded):
(WebKit::WebInspectorClient::WebInspectorClient):
(WebKit::WebInspectorClient::~WebInspectorClient):
(WebKit::WebInspectorClient::showPaintRect):
(WebKit::WebInspectorClient::animationEndedForLayer):

  • WebProcess/WebCoreSupport/WebInspectorClient.h:

(WebKit::WebInspectorClient::WebInspectorClient): Deleted.

11:59 AM Changeset in webkit [172863] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WTF

Enable fixed executable allocator for any ARM64 target.
​https://bugs.webkit.org/show_bug.cgi?id=136162

Patch by Akos Kiss <​akiss@inf.u-szeged.hu> on 2014-08-22
Reviewed by Michael Saboff.

The ARM64 macro assembler relies on near calls being implemented by BL
instructions, which have only 128MB offset range from PC. The
on-demand executable allocator cannot ensure that any two locations in
memory allocated for the JIT-compiled code are within this range.
However, the fixed executable allocator has a fixed 16MB memory pool for
ARM64.

  • wtf/Platform.h:

Define ENABLE_EXECUTABLE_ALLOCATOR_FIXED if CPU(ARM64), and update
attached comment.

11:25 AM Changeset in webkit [172862] by commit-queue@webkit.org
  • 138 edits in trunk/Source

Unreviewed, rolling out r172844.
​https://bugs.webkit.org/show_bug.cgi?id=136164

re-applying WEBCORE_EXPORTS patch (Requested by
alexchristensen on #webkit).

Reverted changeset:

"Revert r172831, it broke the Windows build."
​http://trac.webkit.org/changeset/172844

11:18 AM Changeset in webkit [172861] by hyatt@apple.com
  • 14 edits
    6 adds in trunk

Implement rudimentary Bopomofo Ruby support (ruby-position:inter-character)
​https://bugs.webkit.org/show_bug.cgi?id=136137
<rdar://problem/12567545>

Reviewed by Sam Weinig.

Source/WebCore:

Added fast/ruby/bopomofo.html and fast/ruby/bopomofo-rl.html.

  • css/CSSParser.cpp:

(WebCore::isValidKeywordPropertyAndValue):

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator RubyPosition):

  • css/CSSPropertyNames.in:
  • css/CSSValueKeywords.in:

Add support for the new inter-character value for ruby-position and also
add support for a new font-size keyword, -webkit-ruby-text, that is used
to set a smart initial font size based off the type of ruby being presented.

  • css/DeprecatedStyleBuilder.cpp:

(WebCore::ApplyPropertyFontSize::determineRubyTextSizeMultiplier):
(WebCore::ApplyPropertyFontSize::applyValue):
Determine the Ruby text size multiplier when -webkit-ruby-text is specified
as the font size. For ruby-position of before/after, we use 50% of the parent
font size. For inter-character ruby, we default to 25% instead. If inter-character
Ruby is nested, we assume it's to display tone marks, and we use 100% to ensure
the tone mark is the same size and does not get smaller.

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::adjustStyleForInterCharacterRuby):
(WebCore::StyleResolver::applyMatchedProperties):

  • css/StyleResolver.h:

ruby-position is now the highest priority CSS property, and it is resolved
before all other properties to ensure that its value can be checked when
determining a smart default font size. adjustStyleForInterCharacterRuby is a new
function called to auto-adjust inter-character ruby text to be vertical writing mode when
encountered inside horizontal documents.

  • css/html.css:

(ruby > rt):
Change the font-size from 50% to -webkit-ruby-text to allow us to customize it as
needed depending on what kind of Ruby we want to show.

  • rendering/RenderRubyRun.cpp:

(WebCore::RenderRubyRun::layout):

  • rendering/RenderRubyRun.h:

Add layout code to properly position vertical ruby text relative to a horizontal base.

  • rendering/style/RenderStyleConstants.h:

Add the new inter-character constant for ruby-position.

  • rendering/style/StyleRareInheritedData.h:

Increase the number of storage bits for RubyPosition from 1 to 2 now that we support 3 values.

LayoutTests:

  • fast/ruby/bopomofo-rl.html: Added.
  • fast/ruby/bopomofo.html: Added.
  • platform/mac/fast/ruby/bopomofo-expected.png: Added.
  • platform/mac/fast/ruby/bopomofo-expected.txt: Added.
  • platform/mac/fast/ruby/bopomofo-rl-expected.png: Added.
  • platform/mac/fast/ruby/bopomofo-rl-expected.txt: Added.
10:56 AM Changeset in webkit [172860] by jonlee@apple.com
  • 11 edits in trunk/Source

Fix iOS build due to r172832 and move RUBBER_BANDING out of FeatureDefines.h
​https://bugs.webkit.org/show_bug.cgi?id=136157

Reviewed by Simon Fraser.

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig: Add ENABLE(RUBBER_BANDING).

Source/WebCore:

  • Configurations/FeatureDefines.xcconfig: Add ENABLE(RUBBER_BANDING).

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig: Add ENABLE(RUBBER_BANDING).
  • WebView/WebView.mm:

(-[WebView _preferencesChanged:]): Wrap in ENABLE(RUBBER_BANDING).

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig: Add ENABLE(RUBBER_BANDING).

Source/WTF:

  • wtf/FeatureDefines.h: Remove ENABLE(RUBBER_BANDING) logic for Mac platform.
9:09 AM Changeset in webkit [172859] by Lucas Forschler
  • 10 edits
    2 copies in branches/safari-600.1-branch

Merged r172854. <rdar://problem/18001179>

5:40 AM Changeset in webkit [172858] by clopez@igalia.com
  • 2 edits in trunk/Tools

[GTK] install-dependencies don't installs Xvfb that is needed for the tests.
​https://bugs.webkit.org/show_bug.cgi?id=136153

Reviewed by Martin Robinson.

  • gtk/install-dependencies: Add Xvfb package to the list of dependencies necessary for running tests.
2:32 AM WebKitGTK/KeepingTheTreeGreen edited by clopez@igalia.com
(diff)
2:27 AM Changeset in webkit [172857] by gyuyoung.kim@samsung.com
  • 3 edits in trunk

[EFL] Apply eflsymbols.filter to WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=136148

Reviewed by Csaba Osztrogonác.

eflsymbol filter hasn't been applied to WK2 port. Additionally clean up WK1 symbol
in the eflsymbols.filter.

  • Source/cmake/OptionsEfl.cmake:
  • Source/cmake/eflsymbols.filter:
1:19 AM Changeset in webkit [172856] by zandobersek@gmail.com
  • 2 edits
    2 adds in trunk/Source/WebCore

[GTK] Add the Wayland protocol extension
​https://bugs.webkit.org/show_bug.cgi?id=136102

Reviewed by Martin Robinson.

Add the Wayland protocol extension that allows mapping GtkWidget
objects (via an ID that's unique to that GtkWidget) to the
corresponding Wayland surface objects. This way the nested
compositor has the proper information about what GtkWidget has
to be updated when surfaces are committed by the LayerTreeHost.

  • PlatformGTK.cmake:
  • platform/graphics/wayland: Added.
  • platform/graphics/wayland/WebKitGtkWaylandClientProtocol.xml: Added.
Note: See TracTimeline for information about the timeline view.