⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Aug 30, 2014:

4:19 PM Changeset in webkit [173142] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

Convert string literals to character literals in makeString usage
​https://bugs.webkit.org/show_bug.cgi?id=136394

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-08-30
Reviewed by Sam Weinig.

  • inspector/InspectorOverlay.cpp:

(WebCore::InspectorOverlay::evaluateInOverlay):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::setOriginalURLForDownloadRequest):

  • loader/MixedContentChecker.cpp:

(WebCore::MixedContentChecker::logWarning):

  • page/ContentSecurityPolicy.cpp:

(WebCore::CSPDirectiveList::checkMediaTypeAndReportViolation):
(WebCore::ContentSecurityPolicy::reportUnsupportedDirective):
(WebCore::ContentSecurityPolicy::reportInvalidPathCharacter):
Also reorder some code to ensure single string creation.

3:43 PM Changeset in webkit [173141] by mjs@apple.com
  • 12 edits in trunk/Source

Use RetainPtr::autorelease in some places where it seems appropriate
​https://bugs.webkit.org/show_bug.cgi?id=136280

Reviewed by Darin Adler.

Source/JavaScriptCore:

  • API/JSContext.mm:

(-[JSContext name]): Use RetainPtr::autorelease() in place of ObjC autorelease.

  • API/JSValue.mm:

(valueToString): Make appropriate use of RetainPtr

Source/WebCore:

  • platform/mac/URLMac.mm:

(WebCore::URL::operator NSURL *): Use autorelease() instead of
CFBridgingRelease(leakRef())

Source/WebKit/mac:

  • WebView/WebHTMLView.mm:

(imageFromRect): Use RetainPtr in this function.

  • WebView/WebPDFRepresentation.mm:

(-[WebPDFRepresentation convertPostScriptDataSourceToPDF:]): Use RetainPtr
in this method.

Source/WebKit2:

  • Shared/Cocoa/WKNSURLExtras.mm:

(urlWithWTFString): Use autorelease() instead of CFBridgingRelease(leakRef())

Source/WTF:

  • wtf/text/mac/StringImplMac.mm:

(WTF::StringImpl::operator NSString *): Use autorelease() instead of
CFBridgingRelease(leakRef())

11:22 AM Changeset in webkit [173140] by fpizlo@apple.com
  • 2 edits in trunk/Tools

[RJST] eager-no-cjit should really mean eager
​https://bugs.webkit.org/show_bug.cgi?id=136407

Reviewed by Mark Hahnenberg.

At some point we made NO_CJIT_OPTIONS force threshold settings to something reasonable
and well-known. But the way we appended options was such that NO_CJIT_OPTIONS came in
after EAGER_OPTIONS. The whole point of "eager" was to use eager tier-up thresholds. This
all meant that NO_CJIT_OPTIONS was overriding the eagerness of EAGER_OPTIONS, for the one
threshold setting that NO_CJIT_OPTIONS was currently setting
(thresholdForJITAfterWarmUp). The solution is to make sure that we always append
NO_CJIT_OPTIONS before we append EAGER_OPTIONS.

Luckily, no tests regressed during the time that we lost eager-no-cjit coverage.

  • Scripts/run-jsc-stress-tests:
9:20 AM Changeset in webkit [173139] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/LayoutTests

Unreviewed EFL gardening. Mark some compositing tests as "failure" since r172999

  • platform/efl/TestExpectations:
6:42 AM Changeset in webkit [173138] by Yusuke Suzuki
  • 7 edits
    10 adds in trunk

CSS: Refactor :visited handling in SelectorChecker
​https://bugs.webkit.org/show_bug.cgi?id=135639

Reviewed by Benjamin Poulain.

Source/WebCore:

:visited is specially handled in the SelectorChecker and style resolution
because of security issues. That is nested links and adjacent combinators.
Since we propagate linkState from the ancestors,

  1. linkStates of ancestors from the target node are only used to calculate the linkState of the current node. This is why adjacent combinators disable :visited.
  1. linkState is overrides by the closest link element in the ancestors. This is why :visited is effective on the closest link element.

In this patch, we fix 3 things.

  1. Simplify SelectorChecker. Move m_mode to CheckingContext and it makes CheckingContext more similar to SelectorCompiler::CheckingContext in CSS JIT. And hide visitedMatchType parameter from the caller of SelectorChecker.
  1. Disable :visited inside :-webkit-any. Currently, :-webkit-any provides MatchAll link match type. So considering visited match type in the matching phase of :visited provides inconsistency. In this patch, :-webkit-any(:visited) never matches. And :-webkit-any(:link) acts like a :-webkit-any(:any-link). This behavior represents that visited match type is always considered as disabled inside :-webkit-any. This behavior may be changed when Selector Level4 is implemented.
  1. Fix the issue when traversing the descendant element, first encountered link check is missing.

Tests: fast/history/link-inside-any.html

fast/history/link-inside-not.html
fast/history/nested-visited-test-override.html
fast/history/visited-inside-any.html
fast/history/visited-inside-not.html

  • css/ElementRuleCollector.cpp:

(WebCore::ElementRuleCollector::ruleMatches):

  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::SelectorChecker):
(WebCore::SelectorChecker::match):
(WebCore::hasScrollbarPseudoElement):
(WebCore::checkingContextForParent):
(WebCore::SelectorChecker::matchRecursively):
(WebCore::SelectorChecker::checkOne):

  • css/SelectorChecker.h:

(WebCore::SelectorChecker::SelectorCheckingContext::SelectorCheckingContext):

  • css/StyleResolver.h:

(WebCore::checkRegionSelector):

  • dom/SelectorQuery.cpp:

(WebCore::SelectorDataList::selectorMatches):

LayoutTests:

  • fast/history/link-inside-any-expected.txt: Added.
  • fast/history/link-inside-any.html: Added.
  • fast/history/link-inside-not-expected.txt: Added.
  • fast/history/link-inside-not.html: Added.
  • fast/history/nested-visited-test-override-expected.txt: Added.
  • fast/history/nested-visited-test-override.html: Added.
  • fast/history/visited-inside-any-expected.txt: Added.
  • fast/history/visited-inside-any.html: Added.
  • fast/history/visited-inside-not-expected.txt: Added.
  • fast/history/visited-inside-not.html: Added.

Aug 29, 2014:

8:16 PM Changeset in webkit [173137] by matthew_hanson@apple.com
  • 5 edits in branches/safari-600.1-branch/Source

Versioning.

8:15 PM Changeset in webkit [173136] by matthew_hanson@apple.com
  • 1 copy in tags/Safari-600.1.17

New Tag.

7:55 PM Changeset in webkit [173135] by Alan Bujtas
  • 2 edits in trunk/Source/WebCore

Subpixel layout: Remove LayoutUnit's kEffectiveFixedPointDenominator.
​https://bugs.webkit.org/show_bug.cgi?id=136383.

Reviewed by Simon Fraser.

There's only one subpixel denominator now.

No change in functionality.

  • platform/LayoutUnit.h:

(WebCore::LayoutUnit::LayoutUnit):
(WebCore::LayoutUnit::fromFloatCeil):
(WebCore::LayoutUnit::fromFloatFloor):
(WebCore::LayoutUnit::toInt):
(WebCore::LayoutUnit::toFloat):
(WebCore::LayoutUnit::toDouble):
(WebCore::LayoutUnit::operator++):
(WebCore::LayoutUnit::ceil):
(WebCore::LayoutUnit::round):
(WebCore::LayoutUnit::floor):
(WebCore::LayoutUnit::ceilToFloat):
(WebCore::LayoutUnit::fraction):
(WebCore::LayoutUnit::epsilon):
(WebCore::LayoutUnit::nearlyMax):
(WebCore::LayoutUnit::nearlyMin):
(WebCore::LayoutUnit::isInBounds):
(WebCore::LayoutUnit::setValue):
(WebCore::boundedMultiply):
(WebCore::operator*):
(WebCore::operator/):
(WebCore::operator%):
(WebCore::roundToDevicePixel):
(WebCore::floorToDevicePixel):
(WebCore::ceilToDevicePixel):

7:55 PM Changeset in webkit [173134] by Alan Bujtas
  • 2 edits in trunk/Source/WebCore

Rename updatePreferredWidth to make it more explicit.
​https://bugs.webkit.org/show_bug.cgi?id=136389

Reviewed by Simon Fraser.

No change in functionality.

  • rendering/RenderBlock.cpp:

(WebCore::preferredWidth):
(WebCore::RenderBlock::computeInlinePreferredLogicalWidths):
(WebCore::updatePreferredWidth): Deleted.

6:33 PM Changeset in webkit [173133] by barraclough@apple.com
  • 4 edits in trunk/Source/WebCore

Make timerNestingLevel threadsafe
​https://bugs.webkit.org/show_bug.cgi?id=136401

Reviewed by Tim Horton.

timerNestingLevel, used by DOMTimer to determine whether a timer is 'nested'
(repeating, possible due to a timer rescheduling itself) is a global. Since
worker threads can set timers too this is not thread safe.

  • dom/ScriptExecutionContext.cpp:

(WebCore::ScriptExecutionContext::ScriptExecutionContext):

  • added initialize m_timerNestingLevel
  • dom/ScriptExecutionContext.h:

(WebCore::ScriptExecutionContext::timerNestingLevel):
(WebCore::ScriptExecutionContext::setTimerNestingLevel):

  • added accessors
  • page/DOMTimer.cpp:

(WebCore::DOMTimer::DOMTimer):
(WebCore::DOMTimer::fired):

  • move timerNestingLevel to the context
6:11 PM Changeset in webkit [173132] by barraclough@apple.com
  • 2 edits in trunk/Source/WebCore

DOMTimer::m_nestingLevel is prone to overflow
​https://bugs.webkit.org/show_bug.cgi?id=136399

Reviewed by Alexey Proskuryakov.

Since this would happen after the 2 billionth timer fire this is unlikely,
and consequences aren't severe (breaks throttling).

This change has the following consequences.

  • m_nestingLevel saturates to its max value.
  • unnested timers are indicated by a nesting level of 0.
  • repeat timers update m_nestingLevel on every fire, not just those that should have been throttled.

The last point is subtle, but ultimately should be inconsequential. Timers
whose requested timeout is less that the minimum interval will saturate quickly
anyway; timers with an original interval greater than the minimum previously
wouldn't have incremented m_nestingLevel, but doing so now doesn't hurt since
they won't be throttled when they hit the threshold. This simplifies things
conceptually a little & reduces the test performed on each timer fire.

  • page/DOMTimer.cpp:

(WebCore::shouldForwardUserGesture):

  • unnested timers are indicated by a nesting level of 0

(WebCore::DOMTimer::DOMTimer):

  • don't increment nesting level on construction

(WebCore::DOMTimer::fired):

  • saturating increments

(WebCore::DOMTimer::adjustMinimumTimerInterval):
(WebCore::DOMTimer::intervalClampedToMinimum):

  • added ASSERTs
5:19 PM Changeset in webkit [173131] by commit-queue@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

Ensure that the call frame passed from doVMEntry to the called function always contains the valid scope chain.
​https://bugs.webkit.org/show_bug.cgi?id=136391

Patch by Akos Kiss <​akiss@inf.u-szeged.hu> on 2014-08-29
Reviewed by Michael Saboff.

Do not rely on calling conventions to fill in the CallerFrame component
of the ExecState* parameter of the called function.

  • llint/LowLevelInterpreter32_64.asm:
  • llint/LowLevelInterpreter64.asm:
5:01 PM Changeset in webkit [173130] by jhoneycutt@apple.com
  • 2 edits in branches/safari-600.1-branch/LayoutTests

2014-08-29 Jon Honeycutt <​jhoneycutt@apple.com>

Skip some tests that test features disabled on the branch.

Rubber-stamped by Andreas Kling.

  • platform/mac/TestExpectations:
4:34 PM Changeset in webkit [173129] by dbates@webkit.org
  • 1 edit
    1 add in trunk/Tools

[iOS] Configure Xcode to build a command line tool for the iOS Simulator
​https://bugs.webkit.org/show_bug.cgi?id=136388

Reviewed by David Kilzer.

Add a script, called configure-xcode-for-ios-development, to configure Xcode to
support building a command line tool for the iOS Simulator. You must run this
script as root.

The script uses the xcspec files in the OS X SDK to create xcspec files in the
iOS Simulator SDK with the product- and package- type definitions to build a
command line tool, if applicable.

  • Scripts/configure-xcode-for-ios-development: Added.
4:24 PM Changeset in webkit [173128] by jhoneycutt@apple.com
  • 2 edits in branches/safari-600.1-branch/LayoutTests

2014-08-29 Jon Honeycutt <​jhoneycutt@apple.com>

Merge r171595, which updates a media test's expected result.

Rubber-stamped by Andreas Kling.

2014-07-25 Zalan Bujtas <Alan Bujtas>

Unreviewed media test gardening after r171593.

  • platform/mac/http/tests/media/hls/video-controls-live-stream-expected.txt:
4:17 PM Changeset in webkit [173127] by jhoneycutt@apple.com
  • 2 edits in branches/safari-600.1-branch/LayoutTests

2014-08-29 Jon Honeycutt <​jhoneycutt@apple.com>

Add an expected failure for a test that relies on a feature disabled on
the branch.

Rubber-stamped by Andreas Kling.

3:55 PM Changeset in webkit [173126] by timothy_horton@apple.com
  • 6 edits
    1 delete in trunk/Tools

Remove Windows WebKit2 code from TestWebKitAPI
​https://bugs.webkit.org/show_bug.cgi?id=136385

Reviewed by Alexey Proskuryakov.

  • TestWebKitAPI/PlatformUtilities.h:
  • TestWebKitAPI/PlatformWebView.h:

(TestWebKitAPI::PlatformWebView::setParentWindowMessageObserver): Deleted.

  • TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:

(TestWebKitAPI::TEST): Deleted.

  • TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:

(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:

(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebKit2/win/AltKeyGeneratesWMSysCommand.cpp: Removed.
  • TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp: Removed.
  • TestWebKitAPI/Tests/WebKit2/win/HideFindIndicator.cpp: Removed.
  • TestWebKitAPI/Tests/WebKit2/win/ResizeViewWhileHidden.cpp: Removed.
  • TestWebKitAPI/Tests/WebKit2/win/TranslateMessageGeneratesWMChar.cpp: Removed.
  • TestWebKitAPI/Tests/WebKit2/win/WMCloseCallsUIClientClose.cpp: Removed.
  • TestWebKitAPI/Tests/WebKit2/win/WMPrint.cpp: Removed.
3:52 PM Changeset in webkit [173125] by saambarati1@gmail.com
  • 2 edits in trunk/Source/JavaScriptCore

emit op_profile_type for deconstruction assignments
​https://bugs.webkit.org/show_bug.cgi?id=136274

Reviewed by Filip Pizlo.

Enable type profiling for ES6 deconstruction expressions.

  • bytecompiler/NodesCodegen.cpp:

(JSC::BindingNode::bindValue):

3:21 PM Changeset in webkit [173124] by jhoneycutt@apple.com
  • 2 edits in branches/safari-600.1-branch/LayoutTests

2014-08-28 Jon Honeycutt <​jhoneycutt@apple.com>

Merge r172800, which just updates TestExpectations to fix a failing
test on the branch.

Rubber-stamped by Andreas Kling.

2014-08-20 Alexey Proskuryakov <​ap@apple.com>

fast/multicol/mixed-opacity-fixed-test.html fails in compositing mode
​https://bugs.webkit.org/show_bug.cgi?id=136109

  • platform/mac-wk2/TestExpectations: Updated test expectations to a non-flaky failure, and to point to the new bug.
2:58 PM Changeset in webkit [173123] by Lucas Forschler
  • 8 edits in branches/safari-600.1-branch/Source/WebKit2

Merged r173121. rdar://problem/16991213

2:55 PM Changeset in webkit [173122] by Lucas Forschler
  • 3 edits in branches/safari-600.1-branch/Source/WebKit2

Merged r173118. rdar://problem/16991213

2:38 PM Changeset in webkit [173121] by ap@apple.com
  • 8 edits in trunk/Source/WebKit2

More occasional crashes in ServicesController::resfreshExistingServices
​https://bugs.webkit.org/show_bug.cgi?id=136387
<rdar://problem/18167200>

Patch by Tim Horton <​timothy_horton@apple.com> on 2014-08-29
Reviewed by Dan Bernstein.

  • UIProcess/mac/ServicesController.mm:

(WebKit::ServicesController::ServicesController):
Speculative fix; if this block is called synchronously, we'll end up
calling back into ::shared() before the NeverDestroyed is initialized,
ending up with two ServicesControllers.

2:33 PM Changeset in webkit [173120] by commit-queue@webkit.org
  • 31 edits in trunk/Source

JavaScriptCore: Use ASCIILiteral where possible
​https://bugs.webkit.org/show_bug.cgi?id=136179

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-08-29
Reviewed by Michael Saboff.

Source/JavaScriptCore:

General string / character related changes. Use ASCIILiteral where
possible, jsNontrivialString where possible, and replace string
literals with character literals in some places.

No new tests, no changes to functionality.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::nameForRegister):

  • bytecompiler/NodesCodegen.cpp:

(JSC::PostfixNode::emitBytecode):
(JSC::PrefixNode::emitBytecode):
(JSC::AssignErrorNode::emitBytecode):
(JSC::ForInNode::emitMultiLoopBytecode):
(JSC::ForOfNode::emitBytecode):
(JSC::ObjectPatternNode::toString):

  • dfg/DFGFunctionWhitelist.cpp:

(JSC::DFG::FunctionWhitelist::contains):

  • dfg/DFGOperations.cpp:

(JSC::DFG::newTypedArrayWithSize):
(JSC::DFG::newTypedArrayWithOneArgument):

  • inspector/ConsoleMessage.cpp:

(Inspector::ConsoleMessage::addToFrontend):

  • inspector/InspectorBackendDispatcher.cpp:

(Inspector::InspectorBackendDispatcher::dispatch):

  • inspector/ScriptCallStackFactory.cpp:

(Inspector::extractSourceInformationFromException):

  • inspector/scripts/codegen/generator_templates.py:
  • interpreter/StackVisitor.cpp:

(JSC::StackVisitor::Frame::functionName):
(JSC::StackVisitor::Frame::sourceURL):

  • jit/JITOperations.cpp:
  • jsc.cpp:

(functionDescribeArray):
(functionRun):
(functionLoad):
(functionReadFile):
(functionCheckSyntax):
(functionTransferArrayBuffer):
(runWithScripts):
(runInteractive):

  • parser/Lexer.cpp:

(JSC::Lexer<T>::invalidCharacterMessage):
(JSC::Lexer<T>::parseString):
(JSC::Lexer<T>::parseStringSlowCase):
(JSC::Lexer<T>::lex):

  • profiler/Profile.cpp:

(JSC::Profile::Profile):

  • runtime/Arguments.cpp:

(JSC::argumentsFuncIterator):

  • runtime/ArrayPrototype.cpp:

(JSC::performSlowSort):
(JSC::arrayProtoFuncSort):

  • runtime/ExceptionHelpers.cpp:

(JSC::createError):
(JSC::createInvalidParameterError):
(JSC::createNotAConstructorError):
(JSC::createNotAFunctionError):
(JSC::createNotAnObjectError):
(JSC::createErrorForInvalidGlobalAssignment):

  • runtime/FunctionPrototype.cpp:

(JSC::insertSemicolonIfNeeded):

  • runtime/JSArray.cpp:

(JSC::JSArray::defineOwnProperty):
(JSC::JSArray::pop):
(JSC::JSArray::push):

  • runtime/JSArrayBufferConstructor.cpp:

(JSC::JSArrayBufferConstructor::finishCreation):

  • runtime/JSArrayBufferPrototype.cpp:

(JSC::arrayBufferProtoFuncSlice):

  • runtime/JSDataView.cpp:

(JSC::JSDataView::create):

  • runtime/JSDataViewPrototype.cpp:

(JSC::getData):
(JSC::setData):

  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::reset):

  • runtime/JSGlobalObjectFunctions.cpp:

(JSC::globalFuncProtoSetter):

  • runtime/JSPromiseConstructor.cpp:

(JSC::JSPromiseConstructor::finishCreation):

  • runtime/LiteralParser.cpp:

(JSC::LiteralParser<CharType>::Lexer::lex):
(JSC::LiteralParser<CharType>::Lexer::lexString):
(JSC::LiteralParser<CharType>::parse):

  • runtime/LiteralParser.h:

(JSC::LiteralParser::getErrorMessage):

  • runtime/TypeSet.cpp:

(JSC::TypeSet::seenTypes):
(JSC::TypeSet::displayName):
(JSC::TypeSet::allPrimitiveTypeNames):
(JSC::StructureShape::propertyHash):
(JSC::StructureShape::stringRepresentation):

Source/WTF:

  • wtf/text/WTFString.cpp:

(asciiDebug):

2:32 PM Changeset in webkit [173119] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit2

More occasional crashes in ServicesController::resfreshExistingServices
​https://bugs.webkit.org/show_bug.cgi?id=136387
<rdar://problem/18167200>

Reviewed by Dan Bernstein.

  • UIProcess/mac/ServicesController.mm:

(WebKit::ServicesController::ServicesController):
Speculative fix; if this block is called synchronously, we'll end up
calling back into ::shared() before the NeverDestroyed is initialized,
ending up with two ServicesControllers.

2:23 PM Changeset in webkit [173118] by ap@apple.com
  • 3 edits in trunk/Source/WebKit2

WebPageProxy::close() is a no-op for terminated processes
​https://bugs.webkit.org/show_bug.cgi?id=136378
Related to <rdar://problem/16991213> and to <rdar://problem/17095600>

Reviewed by Brady Eidson.

Also fixes issues that got uncovered after making close() work.

  • UIProcess/WebInspectorProxy.cpp: (WebKit::WebInspectorProxy::invalidate): Don't

close the page, because it makes no sense, and causes an assertion now. Previosly,
this was OK because the page was invalid already, and close() was a no-op.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::~WebPageProxy): Added some assertions to catch invalidation
issues earlier.
(WebKit::WebPageProxy::reattachToWebProcess): Make it an invariant that a page's
process always has a message receiver for it, until close() removes it.
(WebKit::WebPageProxy::close): Make this function work for all open pages, whether
they have a page or not.
(WebKit::WebPageProxy::processDidFinishLaunching): Added an asserion that process
agrees about its state.
(WebKit::WebPageProxy::resetStateAfterProcessExited): Don't remove a message receiver,
we now only do this in reattach or close.

1:10 PM Changeset in webkit [173117] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebInspectorUI

Web Inspector: Fix how Popover animates
​https://bugs.webkit.org/show_bug.cgi?id=136353

Patch by Saam Barati <​sbarati@apple.com> on 2014-08-29
Reviewed by Timothy Hatcher.

Popovers currently don't animate properly because they use
window.requestAnimationFrame which won't fire its callback
while the inspector is paused in the debugger. This patches
switches the callback mechanism to setTimeout and also changes
how a Popover's anchor animates to prevent visual glitches.

Popover also has a new function that allows a new target
frame and new content to be set simultaneously and to
animate to show the new content while changing the
location of the popover frame.

SourceCodeTextEditor uses Popover's new API for animating
between popovers when paused in the debugger. SourceCodeTextEditor
also now ensures proper balancing of popover tracking event
listeners.

  • UserInterface/Views/Popover.js:

(WebInspector.Popover.prototype.present):
(WebInspector.Popover.prototype.presentNewContentWithFrame):
(WebInspector.Popover.prototype.dismiss):
(WebInspector.Popover.prototype._update):
(WebInspector.Popover.prototype.drawBackground):
(WebInspector.Popover.prototype._animateFrame):
(WebInspector.Popover.prototype._drawFrame):
(WebInspector.Popover.prototype._addListenersIfNeeded):
(WebInspector.Popover.prototype._animateFrame.drawBackground): Deleted.

  • UserInterface/Views/SourceCodeTextEditor.js:

(WebInspector.SourceCodeTextEditor.prototype._showPopover):
(WebInspector.SourceCodeTextEditor.prototype._dismissPopover):
(WebInspector.SourceCodeTextEditor.prototype._trackPopoverEvents):

11:15 AM Changeset in webkit [173116] by clopez@igalia.com
  • 2 edits in trunk/Tools

[JSC] Some JSC tests are dependent on the machine time zone.
​https://bugs.webkit.org/show_bug.cgi?id=136363

Reviewed by Filip Pizlo.

  • Scripts/run-javascriptcore-tests: Export TZ environment variable to US/Pacific.

Unskip the tests that were skipped on r99580.

11:15 AM Changeset in webkit [173115] by Antti Koivisto
  • 5 edits
    5 deletes in trunk/Source/WebKit2

Remove NetworkResourceLoaderClient and subclasses.
​https://bugs.webkit.org/show_bug.cgi?id=136370

Reviewed by Darin Adler.

This code is needlessly abstract. Move what logic these classes have to NetworkResourceLoader.

  • NetworkProcess/AsynchronousNetworkLoaderClient.cpp: Removed.
  • NetworkProcess/AsynchronousNetworkLoaderClient.h: Removed.
  • NetworkProcess/NetworkLoaderClient.h: Removed.
  • NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::NetworkResourceLoader::NetworkResourceLoader):
(WebKit::NetworkResourceLoader::~NetworkResourceLoader):
(WebKit::NetworkResourceLoader::isSynchronous):
(WebKit::NetworkResourceLoader::didReceiveResponseAsync):
(WebKit::NetworkResourceLoader::didReceiveBuffer):
(WebKit::NetworkResourceLoader::didFinishLoading):
(WebKit::NetworkResourceLoader::didFail):
(WebKit::NetworkResourceLoader::willSendRequestAsync):
(WebKit::NetworkResourceLoader::didSendData):
(WebKit::NetworkResourceLoader::sendBuffer):
(WebKit::NetworkResourceLoader::sendReplyToSynchronousRequest):
(WebKit::NetworkResourceLoader::canAuthenticateAgainstProtectionSpaceAsync):

  • NetworkProcess/NetworkResourceLoader.h:

(WebKit::NetworkResourceLoader::SynchronousLoadData::SynchronousLoadData):

  • NetworkProcess/SynchronousNetworkLoaderClient.cpp: Removed.
  • NetworkProcess/SynchronousNetworkLoaderClient.h: Removed.
  • WebKit2.xcodeproj/project.pbxproj:
10:55 AM Changeset in webkit [173114] by Alan Bujtas
  • 14 edits in trunk/Source/WebCore

Improve showRenderTree() output.
​https://bugs.webkit.org/show_bug.cgi?id=136244

Reviewed by Darin Adler.

Add more debugging information to showRenderTree().

Not testable.

  • rendering/InlineBox.cpp:

(WebCore::InlineBox::showLineTreeForThis):
(WebCore::InlineBox::showLineTreeAndMark):
(WebCore::InlineBox::showLineBox):
(showNodeTree):
(showLineTree):
(WebCore::InlineBox::showBox): Deleted.

  • rendering/InlineBox.h:
  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::showLineTreeAndMark):

  • rendering/InlineFlowBox.h:
  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::showLineBox):
(WebCore::InlineTextBox::showBox): Deleted.

  • rendering/InlineTextBox.h:
  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::showLineTreeAndMark): Deleted.

  • rendering/RenderBlock.h:
  • rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::showLineTreeAndMark):

  • rendering/RenderBlockFlow.h:
  • rendering/RenderObject.cpp:

(WebCore::showRenderTreeLegend):
(WebCore::RenderObject::showNodeTreeForThis):
(WebCore::RenderObject::showRenderTreeForThis):
(WebCore::RenderObject::showLineTreeForThis):
(WebCore::RenderObject::showRegionsInformation):
(WebCore::RenderObject::showRenderObject):
(WebCore::RenderObject::showRenderSubTreeAndMark):
(showNodeTree):
(showLineTree):
(showRenderTree):
(WebCore::RenderObject::showRenderTreeAndMark): Deleted.

  • rendering/RenderObject.h:
  • rendering/RootInlineBox.h:
8:55 AM Changeset in webkit [173113] by Csaba Osztrogonác
  • 6 edits
    35 deletes in trunk/Source

Unreviwed, remove empty directories.

Source/JavaScriptCore:

  • qt: Removed.

Source/ThirdParty/ANGLE:

  • src/compiler/depgraph: Removed.
  • src/compiler/timing: Removed.
  • src/libGLESv2/renderer/shaders: Removed.
  • src/libGLESv2/renderer/shaders/compiled: Removed.

Source/WebCore:

  • Modules/networkinfo: Removed.
  • inspector/front-end: Removed.
  • inspector/front-end/Images: Removed.
  • inspector/front-end/UglifyJS: Removed.
  • inspector/front-end/ace: Removed.
  • inspector/front-end/cm: Removed.
  • platform/audio/ffmpeg: Removed.
  • platform/audio/ipp: Removed.
  • platform/graphics/gpu/opencl: Removed.

Source/WebKit:

  • efl: Removed.
  • efl/DefaultTheme: Removed.
  • efl/DefaultTheme/widget: Removed.
  • efl/WebCoreSupport: Removed.
  • efl/ewk: Removed.
  • efl/tests: Removed.
  • efl/tests/UnitTestUtils: Removed.
  • efl/tests/resources: Removed.
  • gtk: Removed.
  • gtk/WebCoreSupport: Removed.
  • gtk/docs: Removed.
  • gtk/gdom: Removed.
  • gtk/resources: Removed.
  • gtk/webkit: Removed.

Source/WebKit/mac:

  • ForwardingHeaders/wtf: Removed.

Source/WebKit2:

  • PluginProcess/qt: Removed.
  • Shared/API/c/qt: Removed.
  • Shared/Downloads/qt: Removed.
  • Shared/FileAPI: Removed.
  • Shared/qt: Removed.
  • UIProcess/API/C/qt: Removed.
  • UIProcess/API/cpp/qt: Removed.
  • UIProcess/API/qt: Removed.
  • UIProcess/API/qt/raw: Removed.
  • UIProcess/API/qt/tests: Removed.
  • UIProcess/API/qt/tests/html: Removed.
  • UIProcess/API/qt/tests/html/resources: Removed.
  • UIProcess/API/qt/tests/inspectorserver: Removed.
  • UIProcess/API/qt/tests/publicapi: Removed.
  • UIProcess/API/qt/tests/qmltests: Removed.
  • UIProcess/API/qt/tests/qmltests/DesktopBehavior: Removed.
  • UIProcess/API/qt/tests/qmltests/WebView: Removed.
  • UIProcess/API/qt/tests/qmltests/common: Removed.
  • UIProcess/API/qt/tests/qquickwebview: Removed.
  • UIProcess/API/qt/tests/qrawwebview: Removed.
  • UIProcess/InspectorServer/qt: Removed.
  • UIProcess/Launcher/qt: Removed.
  • UIProcess/Plugins/qt: Removed.
  • UIProcess/SharedWorkers: Removed.
  • UIProcess/qt: Removed.
  • WebProcess/Cookies/qt: Removed.
  • WebProcess/Downloads: Removed.
  • WebProcess/IndexedDB: Removed.
  • WebProcess/InjectedBundle/qt: Removed.
  • WebProcess/NetworkInfo: Removed.
  • WebProcess/Plugins/Netscape/qt: Removed.
  • WebProcess/WebCoreSupport/qt: Removed.
  • WebProcess/WebPage/qt: Removed.
  • WebProcess/qt: Removed.
  • qt: Removed.
3:05 AM Changeset in webkit [173112] by commit-queue@webkit.org
  • 10 edits in trunk

[EFL] Remove non Coordinated Graphics code path from cmake build system after r142169
​https://bugs.webkit.org/show_bug.cgi?id=135560

Patch by Eva Balazsfalvi <​evab.u-szeged@partner.samsung.com> on 2014-08-29
Reviewed by Gyuyoung Kim.

.:

  • Source/cmake/OptionsEfl.cmake: Removed TILED_BACKING_STORE guard.

Source/WebCore:

No new tests required, no new functionality.

  • PlatformEfl.cmake: Removed TEXTURE_MAPPER and 3D_GRAPHICS guards.
  • platform/graphics/efl/GraphicsContext3DEfl.cpp: Removed TEXTURE_MAPPER_GL and GRAPHICS_SURFACE guards.

(WebCore::GraphicsContext3D::platformLayer):
(WebCore::GraphicsContext3D::createGraphicsSurfaces):

  • platform/graphics/efl/GraphicsContext3DPrivate.cpp: Removed TEXTURE_MAPPER_GL and GRAPHICS_SURFACE guards.

(WebCore::GraphicsContext3DPrivate::initialize):
(WebCore::GraphicsContext3DPrivate::releaseResources):
(WebCore::GraphicsContext3DPrivate::paintToTextureMapper):
(WebCore::GraphicsContext3DPrivate::graphicsSurfaceFlags):

  • platform/graphics/efl/GraphicsContext3DPrivate.h: Removed TEXTURE_MAPPER_GL and GRAPHICS_SURFACE guards.
  • platform/graphics/surfaces/efl/GraphicsSurfaceCommon.cpp: Removed GRAPHICS_SURFACE guard.

Tools:

  • Scripts/webkitperl/FeatureList.pm: Removed TILED_BACKING_STORE guard.
1:06 AM Changeset in webkit [173111] by Carlos Garcia Campos
  • 2 edits
    1 move in trunk/Source/WebCore

RenderThemeGtk depends on classes outside of platform
​https://bugs.webkit.org/show_bug.cgi?id=22176

Reviewed by Martin Robinson.

Move RenderThemeGtk.cpp from platform to rendering.

  • PlatformGTK.cmake:
  • rendering/RenderThemeGtk.cpp: Renamed from Source/WebCore/platform/gtk/RenderThemeGtk.cpp.
12:42 AM Changeset in webkit [173110] by Carlos Garcia Campos
  • 5 edits in trunk/Source/WebCore

[GTK] ScrollbarThemeGtk should not depend on RenderThemeGtk
​https://bugs.webkit.org/show_bug.cgi?id=136338

Reviewed by Philippe Normand.

Remove the dependency by creating the GtkStyleContext for the
scrollbars in ScrollbarThemeGtk.

  • platform/gtk/RenderThemeGtk.cpp:

(WebCore::gtkStyleChangedCallback): Call ScrollbarThemeGtk::themeChanged().
(WebCore::getStyleContext): Remove the scrollbar style context support.

  • platform/gtk/RenderThemeGtk.h: Remove gtkScrollbarStyle().
  • platform/gtk/ScrollbarThemeGtk.cpp:

(WebCore::ScrollbarStyleContext::ScrollbarStyleContext): Helper
class to create the global GtkStyleContext for scrollbars.
(WebCore::ScrollbarStyleContext::~ScrollbarStyleContext):
(WebCore::ScrollbarStyleContext::context):
(WebCore::gtkScrollbarStyleContext):
(WebCore::ScrollbarThemeGtk::ScrollbarThemeGtk): Remove m_context initialization.
(WebCore::ScrollbarThemeGtk::themeChanged): Invalidate the
GtkStylecontext and call updateThemeProperties().
(WebCore::ScrollbarThemeGtk::updateThemeProperties): Use the
global style context.
(WebCore::ScrollbarThemeGtk::paintTrackBackground): Ditto.
(WebCore::ScrollbarThemeGtk::paintScrollbarBackground): Ditto.
(WebCore::ScrollbarThemeGtk::paintThumb): Ditto.
(WebCore::ScrollbarThemeGtk::paintButton): Ditto.

  • platform/gtk/ScrollbarThemeGtk.h:
12:39 AM Changeset in webkit [173109] by Carlos Garcia Campos
  • 5 edits
    2 deletes in trunk/Source/WebCore

[GTK] Merge RenderThemeGtk3.cpp into RenderThemeGtk.cpp and ScrollbarThemeGtk3.cpp intoScrollbarThemeGtk.cpp
​https://bugs.webkit.org/show_bug.cgi?id=136336

Reviewed by Philippe Normand.

There's no reason to have two files now that there's no GTK+2
support. Also fix coding style issues and compile warnings.

  • PlatformGTK.cmake:
  • platform/gtk/RenderThemeGtk.cpp:
  • platform/gtk/RenderThemeGtk.h:
  • platform/gtk/RenderThemeGtk3.cpp: Removed.
  • platform/gtk/ScrollbarThemeGtk.cpp:
  • platform/gtk/ScrollbarThemeGtk3.cpp: Removed.
Note: See TracTimeline for information about the timeline view.