Timeline
Aug 31, 2014:
- 10:10 PM Changeset in webkit [173153] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, fix build break on EFL and GTK since r173152.
- platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::GraphicsContext::platformInit): Remove a bool parameter because it was removed from function's declaration.
- 6:53 PM Changeset in webkit [173152] by
-
- 5 edits in trunk/Source/WebCore
Remove GraphicsContext constructor that takes shouldUseContextColors
https://bugs.webkit.org/show_bug.cgi?id=136421
Reviewed by Dan Bernstein.
- WebCore.exp.in:
- platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContext::GraphicsContext):
- platform/graphics/GraphicsContext.h:
(WebCore::GraphicsContextState::GraphicsContextState):
- platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::platformInit):
(WebCore::GraphicsContext::drawLinesForText):
As far as I can tell, the last user of this constructor died with WebNSStringDrawing.
Adjust all code to assume shouldUseContextColors=true.
- 6:11 PM Changeset in webkit [173151] by
-
- 2 edits in trunk/Source/WebCore
Remove unused ARMv6-specific #if branches in WebCore::canHyphenate
https://bugs.webkit.org/show_bug.cgi?id=136420
Reviewed by Dan Bernstein.
- platform/text/cf/HyphenationCF.cpp:
(WebCore::AtomicStringKeyedMRUCache<RetainPtr<CFLocaleRef>>::createValueForNullKey):
Use kCFAllocatorDefault instead of 0.
(WebCore::canHyphenate):
Remove ARMv6-specific code.
- 3:06 PM Changeset in webkit [173150] by
-
- 9 edits in trunk/Source
Remove unnecessary (and unnecessarily iOS-specific) setStrokeAndFillColor
https://bugs.webkit.org/show_bug.cgi?id=136416
Reviewed by Dan Bernstein.
- WebCore.exp.in:
- platform/graphics/GraphicsContext.h:
- platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::setStrokeAndFillColor): Deleted.
Remove.
- WebView/WebFrameView.mm:
(-[WebFrameView drawRect:]):
We only end up filling, so only set the fill color.
- WebView/WebPDFViewIOS.mm:
(-[WebPDFView drawPage:]):
(-[WebPDFView drawRect:]):
- WebView/WebPlainWhiteView.mm:
We only end up filling, so only set the fill color.
- 3:03 PM Changeset in webkit [173149] by
-
- 5 edits in trunk/Source/WebCore
Remove duplicate implementation of drawEllipse and some related PLATFORM(IOS) ifdefs
https://bugs.webkit.org/show_bug.cgi?id=136413
Reviewed by Dan Bernstein.
No new tests, just cleanup.
- platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContext::drawRaisedEllipse):
There's nothing iOS specific about this function.
- platform/graphics/GraphicsContext.h:
- platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::GraphicsContext::drawEllipse):
- platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::drawEllipse):
Un-ifdef drawRaisedEllipse; delete the reimplementation of drawEllipse that takes
a FloatRect and make the normal one take a FloatRect instead.
(WebCore::GraphicsContext::platformInit):
Make sure that the CGContext's line width starts out in sync with GraphicsContext's.
By default, CGContext has a line width of 1 and GraphicsContext 0, so they could previously
have been out of sync until someone set the width explicitly.
- 3:02 PM Changeset in webkit [173148] by
-
- 2 edits in trunk/Source/WebCore
Fix a harmless mismerge in BitmapImage::destroyDecodedDataIfNecessary
https://bugs.webkit.org/show_bug.cgi?id=136412
Reviewed by Alexey Proskuryakov.
No new tests, just cleanup.
- platform/graphics/BitmapImage.cpp:
(WebCore::BitmapImage::destroyDecodedDataIfNecessary):
Drop the leading 'c' and the 'static' on the cutoff parameter.
Remove the duplicated early return (seems like it happened in the merge).
Remove reference to the exact size in the comment, since it's different on iOS.
- 3:01 PM Changeset in webkit [173147] by
-
- 3 edits1 delete in trunk/Source/WebCore
Use SinkDocument instead of PDFDocument; get rid of PDFDocument
https://bugs.webkit.org/show_bug.cgi?id=136414
Reviewed by Alexey Proskuryakov.
- WebCore.xcodeproj/project.pbxproj:
- loader/DocumentWriter.cpp:
(WebCore::DocumentWriter::createDocument):
- pdf/ios/PDFDocument.cpp: Removed.
- pdf/ios/PDFDocument.h: Removed.
Use the generic SinkDocument, which ignores all incoming data just like PDFDocument.
Delete the unnecessary and iOS-specific PDFDocument.cpp/h
- 11:14 AM Changeset in webkit [173146] by
-
- 1 copy in tags/Safari-600.1.18
New tag.
- 1:06 AM Changeset in webkit [173145] by
-
- 2 edits in trunk/Source/WebCore
Adjust an antique comment in Image::drawPattern
https://bugs.webkit.org/show_bug.cgi?id=136411
Reviewed by Dan Bernstein.
- platform/graphics/cg/ImageCG.cpp:
(WebCore::Image::drawPattern):
Reword the comment.
- 1:04 AM Changeset in webkit [173144] by
-
- 2 edits in trunk/Source/WebKit2
Occasional crashes (null deref) under ViewGestureController::endMagnificationGesture
https://bugs.webkit.org/show_bug.cgi?id=136409
<rdar://problem/18104748>
Reviewed by Dan Bernstein.
- UIProcess/mac/ViewGestureControllerMac.mm:
(WebKit::ViewGestureController::endMagnificationGesture):
Null-check DrawingArea.
- 12:41 AM Changeset in webkit [173143] by
-
- 2 edits in trunk/Source/WebCore
SVGImage::drawPatternForContainer creates a buffer without respecting the destination's acceleration setting
https://bugs.webkit.org/show_bug.cgi?id=136408
<rdar://problem/12013317>
Reviewed by Dan Bernstein.
No new tests required, just a performance improvement.
- svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::drawPatternForContainer):
Use ImageBuffer::createCompatibleBuffer, which passes the destination's
acceleration setting through to the ImageBuffer constructor.
I didn't use GraphicsContext::createCompatibleBuffer because adjusting
how this function applies the destination's CTM is outside the scope of this patch.
Aug 30, 2014:
- 4:19 PM Changeset in webkit [173142] by
-
- 5 edits in trunk/Source/WebCore
Convert string literals to character literals in makeString usage
https://bugs.webkit.org/show_bug.cgi?id=136394
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-08-30
Reviewed by Sam Weinig.
- inspector/InspectorOverlay.cpp:
(WebCore::InspectorOverlay::evaluateInOverlay):
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::setOriginalURLForDownloadRequest):
- loader/MixedContentChecker.cpp:
(WebCore::MixedContentChecker::logWarning):
- page/ContentSecurityPolicy.cpp:
(WebCore::CSPDirectiveList::checkMediaTypeAndReportViolation):
(WebCore::ContentSecurityPolicy::reportUnsupportedDirective):
(WebCore::ContentSecurityPolicy::reportInvalidPathCharacter):
Also reorder some code to ensure single string creation.
- 3:43 PM Changeset in webkit [173141] by
-
- 12 edits in trunk/Source
Use RetainPtr::autorelease in some places where it seems appropriate
https://bugs.webkit.org/show_bug.cgi?id=136280
Reviewed by Darin Adler.
Source/JavaScriptCore:
- API/JSContext.mm:
(-[JSContext name]): Use RetainPtr::autorelease() in place of ObjC autorelease.
- API/JSValue.mm:
(valueToString): Make appropriate use of RetainPtr
Source/WebCore:
- platform/mac/URLMac.mm:
(WebCore::URL::operator NSURL *): Use autorelease() instead of
CFBridgingRelease(leakRef())
Source/WebKit/mac:
- WebView/WebHTMLView.mm:
(imageFromRect): Use RetainPtr in this function.
- WebView/WebPDFRepresentation.mm:
(-[WebPDFRepresentation convertPostScriptDataSourceToPDF:]): Use RetainPtr
in this method.
Source/WebKit2:
- Shared/Cocoa/WKNSURLExtras.mm:
(urlWithWTFString): Use autorelease() instead of CFBridgingRelease(leakRef())
Source/WTF:
- wtf/text/mac/StringImplMac.mm:
(WTF::StringImpl::operator NSString *): Use autorelease() instead of
CFBridgingRelease(leakRef())
- 11:22 AM Changeset in webkit [173140] by
-
- 2 edits in trunk/Tools
[RJST] eager-no-cjit should really mean eager
https://bugs.webkit.org/show_bug.cgi?id=136407
Reviewed by Mark Hahnenberg.
At some point we made NO_CJIT_OPTIONS force threshold settings to something reasonable
and well-known. But the way we appended options was such that NO_CJIT_OPTIONS came in
after EAGER_OPTIONS. The whole point of "eager" was to use eager tier-up thresholds. This
all meant that NO_CJIT_OPTIONS was overriding the eagerness of EAGER_OPTIONS, for the one
threshold setting that NO_CJIT_OPTIONS was currently setting
(thresholdForJITAfterWarmUp). The solution is to make sure that we always append
NO_CJIT_OPTIONS before we append EAGER_OPTIONS.
Luckily, no tests regressed during the time that we lost eager-no-cjit coverage.
- Scripts/run-jsc-stress-tests:
- 9:20 AM Changeset in webkit [173139] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL gardening. Mark some compositing tests as "failure" since r172999
- platform/efl/TestExpectations:
- 6:42 AM Changeset in webkit [173138] by
-
- 7 edits10 adds in trunk
CSS: Refactor :visited handling in SelectorChecker
https://bugs.webkit.org/show_bug.cgi?id=135639
Reviewed by Benjamin Poulain.
Source/WebCore:
:visited is specially handled in the SelectorChecker and style resolution
because of security issues. That is nested links and adjacent combinators.
Since we propagate linkState from the ancestors,
- linkStates of ancestors from the target node are only used to calculate the linkState of the current node. This is why adjacent combinators disable :visited.
- linkState is overrides by the closest link element in the ancestors. This is why :visited is effective on the closest link element.
In this patch, we fix 3 things.
- Simplify SelectorChecker. Move m_mode to CheckingContext and it makes CheckingContext more similar to SelectorCompiler::CheckingContext in CSS JIT. And hide visitedMatchType parameter from the caller of SelectorChecker.
- Disable :visited inside :-webkit-any. Currently, :-webkit-any provides MatchAll link match type. So considering visited match type in the matching phase of :visited provides inconsistency. In this patch, :-webkit-any(:visited) never matches. And :-webkit-any(:link) acts like a :-webkit-any(:any-link). This behavior represents that visited match type is always considered as disabled inside :-webkit-any. This behavior may be changed when Selector Level4 is implemented.
- Fix the issue when traversing the descendant element, first encountered link check is missing.
Tests: fast/history/link-inside-any.html
fast/history/link-inside-not.html
fast/history/nested-visited-test-override.html
fast/history/visited-inside-any.html
fast/history/visited-inside-not.html
- css/ElementRuleCollector.cpp:
(WebCore::ElementRuleCollector::ruleMatches):
- css/SelectorChecker.cpp:
(WebCore::SelectorChecker::SelectorChecker):
(WebCore::SelectorChecker::match):
(WebCore::hasScrollbarPseudoElement):
(WebCore::checkingContextForParent):
(WebCore::SelectorChecker::matchRecursively):
(WebCore::SelectorChecker::checkOne):
- css/SelectorChecker.h:
(WebCore::SelectorChecker::SelectorCheckingContext::SelectorCheckingContext):
- css/StyleResolver.h:
(WebCore::checkRegionSelector):
- dom/SelectorQuery.cpp:
(WebCore::SelectorDataList::selectorMatches):
LayoutTests:
- fast/history/link-inside-any-expected.txt: Added.
- fast/history/link-inside-any.html: Added.
- fast/history/link-inside-not-expected.txt: Added.
- fast/history/link-inside-not.html: Added.
- fast/history/nested-visited-test-override-expected.txt: Added.
- fast/history/nested-visited-test-override.html: Added.
- fast/history/visited-inside-any-expected.txt: Added.
- fast/history/visited-inside-any.html: Added.
- fast/history/visited-inside-not-expected.txt: Added.
- fast/history/visited-inside-not.html: Added.
