Timeline



Sep 8, 2014:

11:36 PM Changeset in webkit [173421] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

Minor refactor in CSSComputedStyleDeclaration
​https://bugs.webkit.org/show_bug.cgi?id=136664

Reviewed by Darin Adler.

The "if (length.isPercentNotCalculated()) createValue() else zoomAdjustedPixelValue()"
pattern occurred a number of times here, so factor into percentageOrZoomAdjustedValue().

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::positionOffsetValue): l -> length
(WebCore::percentageOrZoomAdjustedValue):
(WebCore::getBorderRadiusCornerValues):
(WebCore::getBorderRadiusCornerValue):
(WebCore::scrollSnapDestination):
(WebCore::scrollSnapPoints):
(WebCore::scrollSnapCoordinates):

11:34 PM Changeset in webkit [173420] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebKit2

[WebKit2] Fix build error in WebKit2/WebProcess module
​https://bugs.webkit.org/show_bug.cgi?id=136667

Patch by Shivakumar JM <​shiva.jm@samsung.com> on 2014-09-08
Reviewed by Darin Adler.

Fix the build error by handling default case.

  • WebProcess/Network/WebResourceLoadScheduler.cpp:

(WebKit::maximumBufferingTime):

11:07 PM Changeset in webkit [173419] by ap@apple.com
  • 2 edits in trunk/Source/WebCore

Application Cache Storage: failed to execute statement "DELETE FROM CacheGroups" error "no such table: CacheGroups"
​https://bugs.webkit.org/show_bug.cgi?id=136647

Reviewed by Darin Adler.

  • loader/appcache/ApplicationCacheStorage.cpp: (WebCore::ApplicationCacheStorage::verifySchemaVersion):

Don't try to delete the tables if we can't expect to have them yet.

7:56 PM Changeset in webkit [173418] by mmaxfield@apple.com
  • 6 edits
    2 adds in trunk

REGRESSION (r172153): Text drawn with wrong color when second text shadow has zero offset and blur (breaks buttons at aws.amazon.com)
​https://bugs.webkit.org/show_bug.cgi?id=136612

Reviewed by Darin Adler.

Source/WebCore:

r172153 was fundamentally broken, and would restore graphics contexts that had never been saved. This patch
reimplements r172153 by using "continue" to skip loop iterations instead of changing the internal logic of
the loop.

In addition, I have refactored InlineTextBox::applyShadowToGraphicsContext() to take an extra boolean
reference as an out parameter in order to make it obvious it if saved a graphics context that needs
to be restored. This should make it less likely to make these kinds of mistakes in the future.

Test: fast/text/empty-shadow-with-color.html

  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::applyShadowToGraphicsContext): Add bool reference out param.

  • rendering/InlineTextBox.h: Ditto.
  • rendering/TextPainter.cpp:

(WebCore::isEmptyShadow): Change logic to not skip loop iterations on a null shadow.
(WebCore::paintTextWithShadows): Use continue to skip loop iterations for empty shadows. In addition,
use the out param in InlineTextBox::applyShadowToGraphicsContext().

  • rendering/svg/SVGInlineTextBox.cpp:

(WebCore::SVGInlineTextBox::paintTextWithShadows): Update for new sigurature of
InlineTextBox::applyShadowToGraphicsContext().

LayoutTests:

Make sure that text is drawn with correct color when second text shadow has zero offset and blur

  • fast/text/empty-shadow-with-color-expected.html: Added.
  • fast/text/empty-shadow-with-color.html: Added.
7:31 PM Changeset in webkit [173417] by mmaxfield@apple.com
  • 2 edits in trunk/PerformanceTests

PerformanceTests/SVG/SVG-Text.html has unparsable output
​https://bugs.webkit.org/show_bug.cgi?id=136648

Reviewed by Gavin Barraclough.

I need to clean up the arbitrary text on the page before telling
the test runner infrastructure that the test is complete.

  • SVG/SVG-Text.html:
7:03 PM Changeset in webkit [173416] by roger_fong@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed. More webgl conformance test gardening.

  • platform/mac/TestExpectations:
6:46 PM Changeset in webkit [173415] by mjs@apple.com
  • 2 edits in trunk/Source/WebKit/mac

Fix 32-bit Mac build for new warnings
​https://bugs.webkit.org/show_bug.cgi?id=136624

Reviewed by Darin Adler.

(Jessie already fixed this but my version with typedefs seems a tiny bit cleaner.)

  • Carbon/HIViewAdapter.m:

(+[HIViewAdapter bindHIViewToNSView:nsView:]): Need to use explicit casting now.

6:39 PM Changeset in webkit [173414] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/Tools

[EFL] Enable fixed layout by default
​https://bugs.webkit.org/show_bug.cgi?id=136607

Reviewed by Csaba Osztrogonác.

Fixed layout is being used by Tizen platform by default. However, the feature
has still many defects now. So, we need to enable it by default, then should fix
those bugs.

  • MiniBrowser/efl/main.c:
5:34 PM Changeset in webkit [173413] by fpizlo@apple.com
  • 22 edits
    2 adds in trunk/Source

DFG should have a reusable SSA builder
​https://bugs.webkit.org/show_bug.cgi?id=136331

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

We want to implement sophisticated SSA transformations like object allocation sinking
(​https://bugs.webkit.org/show_bug.cgi?id=136330), but to do that, we need to be able to do
updates to SSA that require inserting new Phi's. This requires calculating where Phis go.
Previously, our Phi calculation was based on Aycock and Horspool's algorithm, and our
implementation of this algorithm only worked when doing CPS->SSA conversion. The code
could not be reused for cases where some phase happens to know that it introduced a few
defs in some blocks and it wants to figure out where the Phis should go. Moreover, even
the general algorithm of Aycock and Horspool is not well suited to such targetted SSA
updates, since it requires first inserting maximal Phis. That scales well when the Phis
were already there (like in our CPS form) but otherwise it's quite unnatural and may be
difficult to make efficient.

The usual way of handling both SSA conversion and SSA update is to use Cytron et al's
algorithm based on dominance frontiers. For a while now, I've been working on creating a
Cytron-based SSA calculator that can be used both as a replacement for our current SSA
converter and as a reusable tool for any phase that needs to do SSA update. I previously
optimized our dominator calculation and representation to use dominator trees computed
using Lengauer and Tarjan's algorithm - mainly to make it more scalable to enumerate over
the set of blocks that dominate you or vice-versa, and then I implemented a dominance
frontier calculator. This patch implements the final step towards making SSA update
available to all SSA phases: it implements an SSACalculator that can tell you where Phis
go when given an arbitrary set of Defs. To keep things simple, and to ensure that we have
good test coverage for this SSACalculator, this patch replaces the old Aycock-Horspool
SSA converter with one based on the SSACalculator.

This has no observable impact. It does reduce the amount of code in SSAConversionPhase.
But even better, it makes SSAConversionPhase have significantly less tricky logic. It
mostly just relies on SSACalculator to do the tricky stuff, and SSAConversionPhase mostly
just reasons about the weirdnesses unique to the ThreadedCPS form that it sees as input.
In fact, using the Cytron et al approach means that there isn't really any "smoke and
mirrors" trickyness related to SSA. SSACalculator's only "tricks" are using the pruned
iterated dominance frontier to place Phi's and using the dom tree to find reaching defs.
The complexity is mostly confined to Dominators, which computes various dominator-related
properties over the control flow graph. That class can be difficult to understand, but at
least it follows well-known graph theory wisdom.

  • CMakeLists.txt:
  • JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • dfg/DFGAnalysis.h:
  • dfg/DFGCSEPhase.cpp:
  • dfg/DFGDCEPhase.cpp:

(JSC::DFG::DCEPhase::run):

  • dfg/DFGDominators.h:

(JSC::DFG::Dominators::immediateDominatorOf):
(JSC::DFG::Dominators::forAllBlocksInIteratedDominanceFrontierOf):
(JSC::DFG::Dominators::forAllBlocksInPrunedIteratedDominanceFrontierOf):

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dump):
(JSC::DFG::Graph::blocksInPreOrder):
(JSC::DFG::Graph::blocksInPostOrder):
(JSC::DFG::Graph::getBlocksInPreOrder): Deleted.
(JSC::DFG::Graph::getBlocksInPostOrder): Deleted.

  • dfg/DFGGraph.h:
  • dfg/DFGLICMPhase.cpp:

(JSC::DFG::LICMPhase::run):

  • dfg/DFGNodeFlags.h:
  • dfg/DFGPhase.cpp:

(JSC::DFG::Phase::beginPhase):
(JSC::DFG::Phase::endPhase):

  • dfg/DFGPhase.h:
  • dfg/DFGSSACalculator.cpp: Added.

(JSC::DFG::SSACalculator::Variable::dump):
(JSC::DFG::SSACalculator::Variable::dumpVerbose):
(JSC::DFG::SSACalculator::Def::dump):
(JSC::DFG::SSACalculator::SSACalculator):
(JSC::DFG::SSACalculator::~SSACalculator):
(JSC::DFG::SSACalculator::newVariable):
(JSC::DFG::SSACalculator::newDef):
(JSC::DFG::SSACalculator::nonLocalReachingDef):
(JSC::DFG::SSACalculator::reachingDefAtTail):
(JSC::DFG::SSACalculator::dump):

  • dfg/DFGSSACalculator.h: Added.

(JSC::DFG::SSACalculator::Variable::index):
(JSC::DFG::SSACalculator::Variable::Variable):
(JSC::DFG::SSACalculator::Def::variable):
(JSC::DFG::SSACalculator::Def::block):
(JSC::DFG::SSACalculator::Def::value):
(JSC::DFG::SSACalculator::Def::Def):
(JSC::DFG::SSACalculator::variable):
(JSC::DFG::SSACalculator::computePhis):
(JSC::DFG::SSACalculator::phisForBlock):
(JSC::DFG::SSACalculator::reachingDefAtHead):

  • dfg/DFGSSAConversionPhase.cpp:

(JSC::DFG::SSAConversionPhase::SSAConversionPhase):
(JSC::DFG::SSAConversionPhase::run):
(JSC::DFG::SSAConversionPhase::forwardPhiChildren): Deleted.
(JSC::DFG::SSAConversionPhase::forwardPhi): Deleted.
(JSC::DFG::SSAConversionPhase::forwardPhiEdge): Deleted.
(JSC::DFG::SSAConversionPhase::deduplicateChildren): Deleted.

  • dfg/DFGSSAConversionPhase.h:
  • dfg/DFGValidate.cpp:

(JSC::DFG::Validate::Validate):
(JSC::DFG::Validate::dumpGraphIfAppropriate):
(JSC::DFG::validate):

  • dfg/DFGValidate.h:
  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::lower):

  • runtime/Options.h:

Source/WTF:

Update the alloc() method to use variadic templates. This makes it more natural to use.

  • wtf/SegmentedVector.h:

(WTF::SegmentedVector::alloc):

5:33 PM Changeset in webkit [173412] by Lucas Forschler
  • 5 edits in branches/safari-600.1-branch/Source

Versioning.

5:24 PM Changeset in webkit [173411] by Lucas Forschler
  • 1 copy in tags/Safari-600.1.21

New Tag.

5:21 PM Changeset in webkit [173410] by commit-queue@webkit.org
  • 54 edits
    2 deletes in trunk/Source

Unreviewed, rolling out r173402.
​https://bugs.webkit.org/show_bug.cgi?id=136649

Breaking buildw with error "unable to restore file position to
0x00000c60 for section DWARF.debug_info (errno = 9)"
(Requested by mlam_ on #webkit).

Reverted changeset:

"Move CallFrame and Register inlines functions out of
JSScope.h."
​https://bugs.webkit.org/show_bug.cgi?id=136579
​http://trac.webkit.org/changeset/173402

5:18 PM Changeset in webkit [173409] by roger_fong@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed. Skip some WebGL conformance tests that may be passing on the bots now.

  • platform/mac/TestExpectations:
5:08 PM Changeset in webkit [173408] by roger_fong@apple.com
  • 2 edits in branches/safari-600.1-branch/Source/ThirdParty

Unreviewed build fix for FHPrime 64bit builds.

  • gtest/msvc/gtest-md.vcxproj:
5:02 PM Changeset in webkit [173407] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebInspectorUI

Web Inspector: Inspector frequently restores wrong view when opened (often Timelines instead of Resource)
​https://bugs.webkit.org/show_bug.cgi?id=135965

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-09-08
Reviewed by Timothy Hatcher.

There were numerous subtle race conditions in state restoration.
This patch intends to fix a number of them to get what feels
like sane behavior for selected sidebar state restoration.

  1. Starting a Timeline recording no longer automatically switches to the TimelineContentView.

This was making every reload switch to Timelines. If you had
a resource selected (e.g. the DOM Tree) we should go back
to showing the DOM tree.

  1. Background sidebars should not reveal and select tree elements.

This was making resources get selected in Timelines when reloading the page
because the background Resources sidebar was restoring selection of the resource.
That is an unexpected selection and breaks the experience of Timelines.

  1. ContentView changes during page navigation / reload should not be saved, and improve Resource restoration.

If a TimelineContentView was in the ContentBrowser back/forward history,
a reload with a resource selected in the Resources sidebar would end up
showing the Timelines sidebar. This was because when ContentViews are
closed during the navigation, the ContentBrowser would fall back to the
remaining TimelineContentView and switch to its only allowed sidebar
(Timelines). ResourceSidebarPanel, knowing a resource was selected,
would select the MainFrame intending to stay in the Resource sidebar,
but the resource is okay with showing in any sidebar, so we stay on Timelines.

  1. Resource sidebar state restoration should propertly restore selection.

On reload, state restoration would know the resource to re-select in the
Resources sidebar. As ResourceTreeElements are added to the sidebar
they are checked against the state restoration cookie. If they match,
they would select the element and delete the cookie. Unfortunately,
if this was the first TreeElement child being added to a FrameTreeElement,
the FrameTreeElement onpopulate would remove all children and re-add
them in a unique way. Unfortunately this means the TreeElement we
selected based on the cookie, immediately got thrown away and recreated,
and we no longer reveal and select it. This is a special case for
FrameTreeElements which use the onpopulate SPI. So, instead of starting
processing the new element queue, if this is the first time just trigger
the onpopulate and elements are made just once.

  1. Show Error Console triggering early, could have unexpected sidebar behavior.

Opening Web Inspector directly to the console can run before
WebInspector.contentLoaded (DOMContentLoaded). So in that case
WebInspector.showFullHeightConsole was not handling if the contentBrowser
had no content view yet, and the sidebar might be-reopened later on
in contentLoaded based on the setting value.

  1. Improve automatic resource selection for sidebars with multiple tree outlines.

Selecting a call frame tree element was unexpectedly changing the
selection to a Resource where the breakpoint was set. This was
because we were only looking at one of potentially many content
tree outlines in the sidebar to see if there was a user action.

  • UserInterface/Base/Main.js:

(WebInspector.contentLoaded):
(WebInspector.showFullHeightConsole):
(WebInspector.toggleConsoleView):
(WebInspector._mainResourceDidChange):
(WebInspector._provisionalLoadStarted):
(WebInspector._revealAndSelectRepresentedObjectInNavigationSidebar):
(WebInspector._updateCookieForInspectorViewState):
(WebInspector._contentBrowserCurrentContentViewDidChange):

  • UserInterface/Views/NavigationSidebarPanel.js:

(WebInspector.NavigationSidebarPanel.prototype._treeElementAddedOrChanged):

  • UserInterface/Views/ResourceSidebarPanel.js:

(WebInspector.ResourceSidebarPanel.prototype._mainFrameMainResourceDidChange.delayedWork):
(WebInspector.ResourceSidebarPanel.prototype._mainFrameMainResourceDidChange):

  • UserInterface/Views/TimelineSidebarPanel.js:

(WebInspector.TimelineSidebarPanel.prototype._recordingLoaded):

5:00 PM Changeset in webkit [173406] by commit-queue@webkit.org
  • 5 edits
    3 adds in trunk

Web Inspector: Add layout test for lowercase CSSProperty names
​https://bugs.webkit.org/show_bug.cgi?id=135961

Patch by Matt Baker <Matt Baker> on 2014-09-08
Reviewed by Joseph Pecoraro.

Source/WebInspectorUI:

Modified test components to support testing CSSStyleManager and related classes:

  • Added required models to Test.html
  • Added CSSCompletions initialization to Test.js
  • CSSCompletions doesn't assume presence of CodeMirror.
  • UserInterface/Base/Test.js:

(WebInspector.loaded):

  • UserInterface/Models/CSSCompletions.js:
  • UserInterface/Test.html:

LayoutTests:

Added test to check that property names in matched CSS rules are returned in lowercase
when specified with upper or mixed case in the original CSS source.

  • inspector/css/matched-style-properties-expected.txt: Added.
  • inspector/css/matched-style-properties.html: Added.
4:59 PM Changeset in webkit [173405] by commit-queue@webkit.org
  • 5 edits in trunk

Web Inspector: Fixes to layout test infrastructure
​https://bugs.webkit.org/show_bug.cgi?id=136360

Patch by Matt Baker <Matt Baker> on 2014-09-08
Reviewed by Joseph Pecoraro.

Source/WebInspectorUI:

Added missing includes to Test.html, which was breaking tests that
depended on SourceCodeLocation and LazySourceCodeLocation. Also fixed
bug which prevented test results from being resent after reloading the
page under test.

  • UserInterface/Base/Test.js:

(InspectorTest.reloadPage):

  • UserInterface/Test.html:

LayoutTests:

Updated expected results to reflect breakpoint resolution changes in r171784.

  • inspector/debugger/probe-manager-add-remove-actions-expected.txt:
4:54 PM Changeset in webkit [173404] by bshafiei@apple.com
  • 5 edits in branches/safari-600.1.4.11-branch/Source

Versioning.

4:41 PM Changeset in webkit [173403] by bshafiei@apple.com
  • 1 copy in tags/Safari-600.1.4.11.5

New tag.

3:58 PM Changeset in webkit [173402] by mark.lam@apple.com
  • 54 edits
    2 adds in trunk/Source

Move CallFrame and Register inlines functions out of JSScope.h.
<​https://webkit.org/b/136579>

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

This include fixing up some files to #include JSCInlines.h to pick up
these inline functions. I also added JSCellInlines.h to JSCInlines.h
since it is included from many of the affected .cpp files.

  • API/ObjCCallbackFunction.mm:
  • JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
  • JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • bindings/ScriptValue.cpp:
  • inspector/InjectedScriptHost.cpp:
  • inspector/InjectedScriptManager.cpp:
  • inspector/JSGlobalObjectInspectorController.cpp:
  • inspector/JSJavaScriptCallFrame.cpp:
  • inspector/ScriptDebugServer.cpp:
  • interpreter/CallFrameInlines.h:

(JSC::CallFrame::vm):
(JSC::CallFrame::lexicalGlobalObject):
(JSC::CallFrame::globalThisValue):

  • interpreter/RegisterInlines.h: Added.

(JSC::Register::operator=):
(JSC::Register::scope):

  • runtime/ArgumentsIteratorConstructor.cpp:
  • runtime/JSArrayIterator.cpp:
  • runtime/JSCInlines.h:
  • runtime/JSCJSValue.cpp:
  • runtime/JSMapIterator.cpp:
  • runtime/JSPromiseConstructor.cpp:
  • runtime/JSPromiseDeferred.cpp:
  • runtime/JSPromiseFunctions.cpp:
  • runtime/JSPromisePrototype.cpp:
  • runtime/JSPromiseReaction.cpp:
  • runtime/JSScope.h:

(JSC::Register::operator=): Deleted.
(JSC::Register::scope): Deleted.
(JSC::ExecState::vm): Deleted.
(JSC::ExecState::lexicalGlobalObject): Deleted.
(JSC::ExecState::globalThisValue): Deleted.

  • runtime/JSSetIterator.cpp:
  • runtime/MapConstructor.cpp:
  • runtime/MapData.cpp:
  • runtime/MapIteratorPrototype.cpp:
  • runtime/MapPrototype.cpp:
  • runtime/SetConstructor.cpp:
  • runtime/SetIteratorPrototype.cpp:
  • runtime/SetPrototype.cpp:
  • runtime/WeakMapConstructor.cpp:
  • runtime/WeakMapPrototype.cpp:

Source/WebCore:

No new tests.

Added #include of the appropriate *Inlines.h files. Unlike in
JavaScriptCore, I #include'd the specific needed *Inlines.h instead of
JSCInlines.h. This is done to minimize the need for WebCore to be
rebuilt when JSC changes are introduced.

  • ForwardingHeaders/interpreter/RegisterInlines.h: Added.
  • bindings/js/JSAudioBufferSourceNodeCustom.cpp:
  • bindings/js/JSAudioTrackCustom.cpp:
  • bindings/js/JSBiquadFilterNodeCustom.cpp:
  • bindings/js/JSCSSStyleDeclarationCustom.cpp:
  • bindings/js/JSCanvasRenderingContext2DCustom.cpp:
  • bindings/js/JSCommandLineAPIHostCustom.cpp:
  • bindings/js/JSCustomSQLStatementErrorCallback.cpp:
  • bindings/js/JSDOMBinding.h:
  • bindings/js/JSDOMStringListCustom.cpp:
  • bindings/js/JSDOMWindowBase.cpp:
  • bindings/js/JSDOMWindowShell.cpp:
  • bindings/js/JSDocumentCustom.cpp:
  • bindings/js/JSHTMLDocumentCustom.cpp:
  • bindings/js/JSOscillatorNodeCustom.cpp:
  • bindings/js/JSPannerNodeCustom.cpp:
  • bindings/js/JSPopStateEventCustom.cpp:
  • dom/TreeWalker.cpp:
  • html/HTMLPlugInImageElement.cpp:
  • inspector/CommandLineAPIModule.cpp:
  • inspector/InspectorController.cpp:
3:33 PM Changeset in webkit [173401] by dino@apple.com
  • 5 edits
    2 adds in trunk/Source/WebCore

Separate the Apple media controls module from other ports
​https://bugs.webkit.org/show_bug.cgi?id=136644
rdar://problem/18270969

Reviewed by Eric Carlson.

Make a mediaControlsBase.{js|css} that acts as the base
class for the EFL and GTK ports (they were using mediaControlsApple).
Over time, the Apple-specific controls may use more of the
Base class.

  • Modules/mediacontrols/mediaControlsBase.css: Added.
  • Modules/mediacontrols/mediaControlsBase.js: Added.
  • PlatformEfl.cmake:
  • PlatformGTK.cmake:
  • platform/efl/RenderThemeEfl.cpp:

(WebCore::RenderThemeEfl::mediaControlsStyleSheet): Load Base rather than Apple.
(WebCore::RenderThemeEfl::mediaControlsScript): Ditto.

  • rendering/RenderThemeGtk.cpp:

(WebCore::RenderThemeGtk::mediaControlsScript): Ditto.

2:40 PM Changeset in webkit [173400] by ap@apple.com
  • 2 edits in trunk/LayoutTests

Investigate test failures on ML caused by MediaTime refactoring
​https://bugs.webkit.org/show_bug.cgi?id=136532

Added another test that appears to have been affected by this refactoring.

  • platform/mac/TestExpectations:
2:38 PM Changeset in webkit [173399] by Simon Fraser
  • 3 edits in trunk/Source/WebKit2

Fix the iOS build.

  • Shared/EntryPointUtilities/mac/XPCService/XPCServiceMain.Development.mm:
  • Shared/EntryPointUtilities/mac/XPCService/XPCServiceMain.mm:
2:22 PM Changeset in webkit [173398] by jochen@chromium.org
  • 2 edits in trunk/Source/WebCore

Always update the referrer header in CachedResource
​https://bugs.webkit.org/show_bug.cgi?id=136642

Reviewed by Alexey Proskuryakov.

If a request already includes a referrer header, and the document has
a non-default referrer policy, it is possible that we have to modify
the referrer header.

  • loader/cache/CachedResource.cpp:

(WebCore::CachedResource::addAdditionalRequestHeaders):

1:51 PM Changeset in webkit [173397] by commit-queue@webkit.org
  • 182 edits in trunk

Remove FILTERS flag
​https://bugs.webkit.org/show_bug.cgi?id=136571

Patch by Eva Balazsfalvi <​evab.u-szeged@partner.samsung.com> on 2014-09-08
Reviewed by Darin Adler.

.:

  • Source/cmake/OptionsEfl.cmake:
  • Source/cmake/OptionsGTK.cmake:
  • Source/cmake/OptionsMac.cmake:
  • Source/cmake/WebKitFeatures.cmake:
  • Source/cmakeconfig.h.cmake:

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

No new tests required, no new functionality.

  • CMakeLists.txt:
  • Configurations/FeatureDefines.xcconfig:
  • DerivedSources.make:
  • dom/DOMImplementation.cpp:

(WebCore::isSupportedSVG10Feature):
(WebCore::isSupportedSVG11Feature):

  • platform/graphics/cpu/arm/filters/FEBlendNEON.h:
  • platform/graphics/cpu/arm/filters/FECompositeArithmeticNEON.h:
  • platform/graphics/cpu/arm/filters/FEGaussianBlurNEON.h:
  • platform/graphics/cpu/arm/filters/NEONHelpers.h:
  • platform/graphics/filters/DistantLightSource.cpp:
  • platform/graphics/filters/DistantLightSource.h:
  • platform/graphics/filters/FEBlend.cpp:
  • platform/graphics/filters/FEBlend.h:
  • platform/graphics/filters/FEColorMatrix.cpp:
  • platform/graphics/filters/FEColorMatrix.h:
  • platform/graphics/filters/FEComponentTransfer.cpp:
  • platform/graphics/filters/FEComponentTransfer.h:
  • platform/graphics/filters/FEComposite.cpp:
  • platform/graphics/filters/FEComposite.h:
  • platform/graphics/filters/FEConvolveMatrix.cpp:
  • platform/graphics/filters/FEConvolveMatrix.h:
  • platform/graphics/filters/FEDiffuseLighting.cpp:
  • platform/graphics/filters/FEDiffuseLighting.h:
  • platform/graphics/filters/FEDisplacementMap.cpp:
  • platform/graphics/filters/FEDisplacementMap.h:
  • platform/graphics/filters/FEDropShadow.cpp:
  • platform/graphics/filters/FEDropShadow.h:
  • platform/graphics/filters/FEFlood.cpp:
  • platform/graphics/filters/FEFlood.h:
  • platform/graphics/filters/FEGaussianBlur.cpp:
  • platform/graphics/filters/FEGaussianBlur.h:
  • platform/graphics/filters/FELighting.cpp:
  • platform/graphics/filters/FELighting.h:
  • platform/graphics/filters/FEMerge.cpp:
  • platform/graphics/filters/FEMerge.h:
  • platform/graphics/filters/FEMorphology.cpp:
  • platform/graphics/filters/FEMorphology.h:
  • platform/graphics/filters/FEOffset.cpp:
  • platform/graphics/filters/FEOffset.h:
  • platform/graphics/filters/FESpecularLighting.cpp:
  • platform/graphics/filters/FESpecularLighting.h:
  • platform/graphics/filters/FETile.cpp:
  • platform/graphics/filters/FETile.h:
  • platform/graphics/filters/FETurbulence.cpp:
  • platform/graphics/filters/FETurbulence.h:
  • platform/graphics/filters/Filter.h:
  • platform/graphics/filters/FilterEffect.cpp:
  • platform/graphics/filters/FilterEffect.h:
  • platform/graphics/filters/LightSource.h:
  • platform/graphics/filters/PointLightSource.cpp:
  • platform/graphics/filters/PointLightSource.h:
  • platform/graphics/filters/SourceAlpha.cpp:
  • platform/graphics/filters/SourceAlpha.h:
  • platform/graphics/filters/SourceGraphic.cpp:
  • platform/graphics/filters/SourceGraphic.h:
  • platform/graphics/filters/SpotLightSource.cpp:
  • platform/graphics/filters/SpotLightSource.h:
  • rendering/svg/RenderSVGResource.cpp:

(WebCore::removeFromCacheAndInvalidateDependencies):

  • rendering/svg/RenderSVGResourceFilter.cpp:
  • rendering/svg/RenderSVGResourceFilter.h:
  • rendering/svg/RenderSVGResourceFilterPrimitive.cpp:
  • rendering/svg/RenderSVGResourceFilterPrimitive.h:
  • rendering/svg/RenderSVGRoot.cpp:
  • rendering/svg/SVGRenderSupport.cpp:

(WebCore::SVGRenderSupport::intersectRepaintRectWithResources):

  • rendering/svg/SVGRenderTreeAsText.cpp:

(WebCore::writeSVGResourceContainer):
(WebCore::writeResources):

  • rendering/svg/SVGRenderingContext.cpp:

(WebCore::SVGRenderingContext::~SVGRenderingContext):
(WebCore::SVGRenderingContext::prepareToRenderSVGContent):

  • rendering/svg/SVGRenderingContext.h:

(WebCore::SVGRenderingContext::SVGRenderingContext):

  • rendering/svg/SVGResources.cpp:

(WebCore::targetReferenceFromResource):
(WebCore::SVGResources::buildCachedResources):
(WebCore::SVGResources::removeClientFromCache):
(WebCore::SVGResources::resourceDestroyed):
(WebCore::SVGResources::buildSetOfResources):
(WebCore::SVGResources::resetFilter):
(WebCore::SVGResources::dump):

  • rendering/svg/SVGResources.h:

(WebCore::SVGResources::filter):
(WebCore::SVGResources::ClipperFilterMaskerData::ClipperFilterMaskerData):

  • rendering/svg/SVGResourcesCycleSolver.cpp:

(WebCore::SVGResourcesCycleSolver::breakCycle):

  • svg/SVGAnimatedEnumeration.cpp:

(WebCore::enumerationValueForTargetAttribute):

  • svg/SVGComponentTransferFunctionElement.cpp:
  • svg/SVGComponentTransferFunctionElement.h:
  • svg/SVGComponentTransferFunctionElement.idl:
  • svg/SVGFEBlendElement.cpp:
  • svg/SVGFEBlendElement.h:
  • svg/SVGFEBlendElement.idl:
  • svg/SVGFEColorMatrixElement.cpp:
  • svg/SVGFEColorMatrixElement.h:
  • svg/SVGFEColorMatrixElement.idl:
  • svg/SVGFEComponentTransferElement.cpp:
  • svg/SVGFEComponentTransferElement.h:
  • svg/SVGFEComponentTransferElement.idl:
  • svg/SVGFECompositeElement.cpp:
  • svg/SVGFECompositeElement.h:
  • svg/SVGFECompositeElement.idl:
  • svg/SVGFEConvolveMatrixElement.cpp:
  • svg/SVGFEConvolveMatrixElement.h:
  • svg/SVGFEConvolveMatrixElement.idl:
  • svg/SVGFEDiffuseLightingElement.cpp:
  • svg/SVGFEDiffuseLightingElement.h:
  • svg/SVGFEDiffuseLightingElement.idl:
  • svg/SVGFEDisplacementMapElement.cpp:
  • svg/SVGFEDisplacementMapElement.h:
  • svg/SVGFEDisplacementMapElement.idl:
  • svg/SVGFEDistantLightElement.cpp:
  • svg/SVGFEDistantLightElement.h:
  • svg/SVGFEDistantLightElement.idl:
  • svg/SVGFEDropShadowElement.cpp:
  • svg/SVGFEDropShadowElement.h:
  • svg/SVGFEDropShadowElement.idl:
  • svg/SVGFEFloodElement.cpp:
  • svg/SVGFEFloodElement.h:
  • svg/SVGFEFloodElement.idl:
  • svg/SVGFEFuncAElement.cpp:
  • svg/SVGFEFuncAElement.h:
  • svg/SVGFEFuncAElement.idl:
  • svg/SVGFEFuncBElement.cpp:
  • svg/SVGFEFuncBElement.h:
  • svg/SVGFEFuncBElement.idl:
  • svg/SVGFEFuncGElement.cpp:
  • svg/SVGFEFuncGElement.h:
  • svg/SVGFEFuncGElement.idl:
  • svg/SVGFEFuncRElement.cpp:
  • svg/SVGFEFuncRElement.h:
  • svg/SVGFEFuncRElement.idl:
  • svg/SVGFEGaussianBlurElement.cpp:
  • svg/SVGFEGaussianBlurElement.h:
  • svg/SVGFEGaussianBlurElement.idl:
  • svg/SVGFEImageElement.cpp:
  • svg/SVGFEImageElement.h:
  • svg/SVGFEImageElement.idl:
  • svg/SVGFELightElement.cpp:
  • svg/SVGFELightElement.h:
  • svg/SVGFEMergeElement.cpp:
  • svg/SVGFEMergeElement.h:
  • svg/SVGFEMergeElement.idl:
  • svg/SVGFEMergeNodeElement.cpp:
  • svg/SVGFEMergeNodeElement.h:
  • svg/SVGFEMergeNodeElement.idl:
  • svg/SVGFEMorphologyElement.cpp:
  • svg/SVGFEMorphologyElement.h:
  • svg/SVGFEMorphologyElement.idl:
  • svg/SVGFEOffsetElement.cpp:
  • svg/SVGFEOffsetElement.h:
  • svg/SVGFEOffsetElement.idl:
  • svg/SVGFEPointLightElement.cpp:
  • svg/SVGFEPointLightElement.h:
  • svg/SVGFEPointLightElement.idl:
  • svg/SVGFESpecularLightingElement.cpp:
  • svg/SVGFESpecularLightingElement.h:
  • svg/SVGFESpecularLightingElement.idl:
  • svg/SVGFESpotLightElement.cpp:
  • svg/SVGFESpotLightElement.h:
  • svg/SVGFESpotLightElement.idl:
  • svg/SVGFETileElement.cpp:
  • svg/SVGFETileElement.h:
  • svg/SVGFETileElement.idl:
  • svg/SVGFETurbulenceElement.cpp:
  • svg/SVGFETurbulenceElement.h:
  • svg/SVGFETurbulenceElement.idl:
  • svg/SVGFilterElement.cpp:
  • svg/SVGFilterElement.h:
  • svg/SVGFilterElement.idl:
  • svg/SVGFilterPrimitiveStandardAttributes.cpp:
  • svg/SVGFilterPrimitiveStandardAttributes.h:
  • svg/graphics/filters/SVGFEImage.cpp:
  • svg/graphics/filters/SVGFEImage.h:
  • svg/graphics/filters/SVGFilter.cpp:
  • svg/graphics/filters/SVGFilter.h:
  • svg/graphics/filters/SVGFilterBuilder.cpp:
  • svg/graphics/filters/SVGFilterBuilder.h:
  • svg/svgtags.in:

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:

Source/WTF:

  • wtf/FeatureDefines.h:

Tools:

  • Scripts/webkitperl/FeatureList.pm:

WebKitLibraries:

  • win/tools/vsprops/FeatureDefines.props:
  • win/tools/vsprops/FeatureDefinesCairo.props:
1:36 PM Changeset in webkit [173396] by Lucas Forschler
  • 2 edits in branches/safari-600.1-branch/Source/WebCore

Merged r173365. rdar://problem/18257576

1:10 PM Changeset in webkit [173395] by roger_fong@apple.com
  • 2 edits in branches/safari-600.1-branch/Source/ThirdParty/ANGLE

Unreviewed tentative build fix for FHPrime bots.

  • ANGLE.vcxproj/libGLESv2Common.props:
1:01 PM Changeset in webkit [173394] by Antti Koivisto
  • 7 edits in trunk/Source/WebKit2

Buffer images on web process side
​https://bugs.webkit.org/show_bug.cgi?id=136631

Reviewed by Darin Adler.

We can substantially reduce IPC and decoding time for large images by allowing some buffering.

This patch makes us buffer image data up to 0.5s before sending it over to the web process.

  • NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::NetworkResourceLoader::NetworkResourceLoader):
(WebKit::NetworkResourceLoader::cleanup):
(WebKit::NetworkResourceLoader::didReceiveBuffer):

Start the timer.

(WebKit::NetworkResourceLoader::didFinishLoading):
(WebKit::NetworkResourceLoader::startBufferingTimerIfNeeded):
(WebKit::NetworkResourceLoader::bufferingTimerFired):
(WebKit::NetworkResourceLoader::sendBuffer):

Send the data when the timer fires or the load finishes, whichever happens first.

  • NetworkProcess/NetworkResourceLoader.h:
  • Platform/IPC/ArgumentCoders.h:

Support encoding std::chrono::duration

  • Shared/Network/NetworkResourceLoadParameters.cpp:

(WebKit::NetworkResourceLoadParameters::NetworkResourceLoadParameters):
(WebKit::NetworkResourceLoadParameters::encode):
(WebKit::NetworkResourceLoadParameters::decode):

  • Shared/Network/NetworkResourceLoadParameters.h:

Pass maximimum buffering duration.

  • WebProcess/Network/WebResourceLoadScheduler.cpp:

(WebKit::maximumBufferingTime):

Deterimine duration from the resource type.
Enabled full buffering for font resources. They are not decoded incrementally.

(WebKit::WebResourceLoadScheduler::scheduleLoad):

11:59 AM Changeset in webkit [173393] by mitz@apple.com
  • 4 edits in trunk/Source

HAVE(VOUCHERS) is not available outside of WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=136637

Reviewed by Tim Horton.

Source/WebKit2:

  • config.h: Moved the definition of HAVE_VOUCHERS from here to wtf’s Platform.h.

Source/WTF:

  • wtf/Platform.h: Moved the definition of HAVE_VOUCHERS from WebKit2’s config.h here.
11:57 AM Changeset in webkit [173392] by Simon Fraser
  • 7 edits in trunk/Source/WebCore

Use enum class for the RunPostLayoutTasks enum
​https://bugs.webkit.org/show_bug.cgi?id=136640

Reviewed by Dean Jackson.

Use enum class for RunPostLayoutTasks fixing callers. Add an explanatory comment,
and add some spacing.

  • dom/Document.cpp:

(WebCore::Document::updateLayoutIgnorePendingStylesheets):

  • dom/Document.h:
  • html/HTMLAppletElement.cpp:

(WebCore::HTMLAppletElement::renderWidgetForJSBindings):

  • html/HTMLEmbedElement.cpp:

(WebCore::HTMLEmbedElement::renderWidgetForJSBindings):

  • html/HTMLObjectElement.cpp:

(WebCore::HTMLObjectElement::renderWidgetForJSBindings):

  • testing/Internals.cpp:

(WebCore::Internals::updateLayoutIgnorePendingStylesheetsAndRunPostLayoutTasks):

11:54 AM Changeset in webkit [173391] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[WinCairo] Compile error.
​https://bugs.webkit.org/show_bug.cgi?id=136633

Patch by ​peavo@outlook.com <​peavo@outlook.com> on 2014-09-08
Reviewed by Darin Adler.

Enum name has already been defined.

  • platform/audio/AudioHardwareListener.h:
11:44 AM Changeset in webkit [173390] by bshafiei@apple.com
  • 2 edits in branches/safari-600.1.4.11-branch/Source/WebCore

Merged r173344. <rdar://problem/18267402>

11:32 AM Changeset in webkit [173389] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebCore

Remove some unused code in ImageSourceCG
​https://bugs.webkit.org/show_bug.cgi?id=136638

Reviewed by Dan Bernstein.

  • platform/graphics/cg/ImageSourceCG.cpp:

(WebCore::ImageSource::setData):
Remove this code. Firstly, it's in a USE(CG) && !PLATFORM(COCOA) && !PLATFORM(WIN)
block, and that's simply not a thing. Secondly, the referenced bug was fixed in Lion.

11:14 AM Changeset in webkit [173388] by saambarati1@gmail.com
  • 3 edits
    1 add in trunk/Source/JavaScriptCore

Merge StructureShapes that share the same prototype chain
​https://bugs.webkit.org/show_bug.cgi?id=136549

Reviewed by Filip Pizlo.

Instead of keeping track of many discrete StructureShapes that share
the same prototype chain, TypeSet should merge StructureShapes that
have the same prototype chain and provide a new member variable for
optional structure fields. This provides a cleaner and more concise
interface for dealing with StructureShapes within TypeSet. Instead
of having many discrete shapes that are almost identical, almost
identical shapes will be merged together with an interface for
understanding what fields the shapes being merged together differ in.

  • runtime/TypeSet.cpp:

(JSC::TypeSet::addTypeInformation):
(JSC::StructureShape::addProperty):
(JSC::StructureShape::toJSONString):
(JSC::StructureShape::inspectorRepresentation):
(JSC::StructureShape::hasSamePrototypeChain):
(JSC::StructureShape::merge):

  • runtime/TypeSet.h:
  • tests/typeProfiler/optional-fields.js: Added.

(wrapper.func):
(wrapper):

11:04 AM Changeset in webkit [173387] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit2

Try to fix the build after r173383, part 4.

  • Shared/EntryPointUtilities/mac/XPCService/XPCServiceMain.Development.mm:

Machine finally caught up so I could actually test the fixes!

10:53 AM Changeset in webkit [173386] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit2

Try to fix the build after r173383, part 3.

  • Shared/EntryPointUtilities/mac/XPCService/XPCServiceMain.mm:
10:45 AM Changeset in webkit [173385] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WTF

Try to fix the build after r173383, part 2.

  • wtf/OSObjectPtr.h:
10:37 AM Changeset in webkit [173384] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WTF

Try to fix the build after r173383.

  • wtf/OSObjectPtr.h:
10:26 AM Changeset in webkit [173383] by weinig@apple.com
  • 2 edits in trunk/Source/WTF

Make OSObjectPtr a bit more like RefPtr
​https://bugs.webkit.org/show_bug.cgi?id=136613

Reviewed by Darin Adler.

Address some of Darin's feedback by:

  • Making the adopting constructor private and friending adoptOSObject().
  • Implementing the assignment operator using swap.
  • Adding a move assignment operator.
  • wtf/OSObjectPtr.h:

(WTF::OSObjectPtr::operator=):
(WTF::OSObjectPtr::swap):
(WTF::OSObjectPtr::OSObjectPtr):

10:10 AM Changeset in webkit [173382] by gyuyoung.kim@samsung.com
  • 13 edits in trunk/Source/WebCore

Introduce CSS_RULE_TYPE_CASTS, and use it
​https://bugs.webkit.org/show_bug.cgi?id=136628

Reviewed by Darin Adler.

As a step to use toFoo, this patch introduces toCSSFooRule(). This will help to detect
wrong type cast. Additionally some missing type casts are clean up as well.

No new tests, no behavior changes.

  • bindings/gobject/WebKitDOMPrivate.cpp:

(WebKit::wrap):

  • css/CSSFontSelector.cpp:

(WebCore::CSSFontSelector::addFontFaceRule):

  • css/CSSImportRule.h:
  • css/CSSMediaRule.h:
  • css/CSSParser.cpp:

(WebCore::CSSParser::parseGridTemplateRowsAndAreas):

  • css/CSSRule.h:
  • css/CSSStyleRule.h:
  • css/CSSSupportsRule.h:
  • css/InspectorCSSOMWrappers.cpp:

(WebCore::InspectorCSSOMWrappers::collect):

  • css/WebKitCSSRegionRule.h:
  • inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::asCSSStyleRule):
(WebCore::InspectorCSSAgent::collectStyleSheets):

  • inspector/InspectorStyleSheet.cpp:

(WebCore::asCSSRuleList):
(WebCore::fillMediaListChain):

  • page/PageSerializer.cpp:

(WebCore::PageSerializer::serializeCSSStyleSheet):

10:05 AM Changeset in webkit [173381] by ap@apple.com
  • 4 edits in trunk/Tools

Dashboard metrics should ignore commits that didn't trigger builds
​https://bugs.webkit.org/show_bug.cgi?id=136618

Reviewed by Darin Adler.

Commits that didn't trigger builds are ones like ChangeLog updates, patches for
other platforms etc. It does not make sense to count wait time for these, as it
can be arbitrarily long.

The new algorithm is much slower asymptotically, but it's OK, computers are fast.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:

(BuildbotIteration.prototype._parseData): Record changes that triggered the iteration.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:

We used to walk the timeline to see which revisions are fully tested, but that's not
correct. A revision that's only tested by a subset of queues finishes independently
of another that's tested by another subset. Now, we just search for the answer for
each revision individually.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsView.js:

(MetricsView.prototype._update.appendQueueResults): Added worst revision number, which
the analyzer now reports. Removed best time, which is more confusing than meaningful.

9:11 AM Changeset in webkit [173380] by jberlin@webkit.org
  • 2 edits in trunk/Source/WebKit/mac

32-bit build fix after r173364.

  • Carbon/HIViewAdapter.m:

(+[HIViewAdapter bindHIViewToNSView:nsView:]):

8:28 AM Changeset in webkit [173379] by mitz@apple.com
  • 3 edits in trunk/Source/WebKit/mac

Build fix.

Added back SPI that is still in use.

  • Misc/WebNSURLExtras.h:
  • Misc/WebNSURLExtras.mm:

(-[NSURL _webkit_URLByRemovingFragment]):

8:21 AM Changeset in webkit [173378] by mitz@apple.com
  • 4 edits in trunk/Source

Source/WebKit/mac:
iOS Simulator build fix.

  • Misc/WebKitSystemBits.m:

(WebMemorySize):

Source/WebKit2:
Build fix.

  • Platform/IPC/Connection.h:
8:21 AM Changeset in webkit [173377] by jberlin@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

More 32-bit Release build fixes after r173364.

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

7:45 AM Changeset in webkit [173376] by jberlin@webkit.org
  • 2 edits in trunk/Source/WTF

More build fixes after r173374.

  • wtf/dtoa/strtod.cc:
7:33 AM Changeset in webkit [173375] by jberlin@webkit.org
  • 2 edits in trunk/Source/WTF

Build fix after r173374.

  • wtf/dtoa/strtod.cc:
7:26 AM Changeset in webkit [173374] by jberlin@webkit.org
  • 2 edits in trunk/Source/WTF

Speculative build fix after r173364.

  • wtf/dtoa/strtod.cc:
3:01 AM Changeset in webkit [173373] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/Source/WebCore

[EFL[WK2] MiniBrowser comes to crash on debug mode
​https://bugs.webkit.org/show_bug.cgi?id=136617

Reviewed by Csaba Osztrogonác.

Fix wrong ASSERTION use in applyCursorFromEcoreX().

  • platform/efl/EflScreenUtilities.cpp: Change ASSERT(!window) with *ASSERT(window)*

(WebCore::applyCursorFromEcoreX):

2:32 AM Changeset in webkit [173372] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Remove EWebLauncher from webkitdirs.pm
​https://bugs.webkit.org/show_bug.cgi?id=136622

Patch by Tibor Meszaros <​tmeszaros.u-szeged@partner.samsung.com> on 2014-09-08
Reviewed by Gyuyoung Kim.

  • Scripts/webkitdirs.pm:

(launcherName):

Sep 7, 2014:

7:39 PM Changeset in webkit [173371] by mjs@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Fix typos in last patch to fix build.

Unreviewed build fix.

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::silentSavePlanForGPR):
(JSC::DFG::SpeculativeJIT::jumpSlowForUnwantedArrayMode):

7:16 PM Changeset in webkit [173370] by mjs@apple.com
  • 10 edits in trunk/Source

Introduce COMPILER_QUIRK(CONSIDERS_UNREACHABLE_CODE) and use it
​https://bugs.webkit.org/show_bug.cgi?id=136616

Reviewed by Darin Adler.
Source/JavaScriptCore:


Many compilers will analyze unrechable code paths (e.g. after an
unreachable code path), so sometimes they need dead code initializations.
But clang with suitable warnings will complain about unreachable code. So
use the quirk to include it conditionally.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::printGetByIdOp):

  • dfg/DFGOSRExitCompilerCommon.cpp:

(JSC::DFG::handleExitCounts):

  • dfg/DFGPlan.cpp:

(JSC::DFG::Plan::compileInThread):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::silentSavePlanForGPR):

  • jsc.cpp:
  • runtime/JSArray.cpp:

(JSC::JSArray::fillArgList):
(JSC::JSArray::copyToArguments):

  • runtime/RegExp.cpp:

(JSC::RegExp::compile):
(JSC::RegExp::compileMatchOnly):

Source/WTF:

  • wtf/Compiler.h: Define the quirk for all compilers but clang.
6:36 PM Changeset in webkit [173369] by gyuyoung.kim@samsung.com
  • 5 edits in trunk/Source/WebCore

Introduce toBasicShapeFoo() instead of static_cast<BasicShapeFoo*>
​https://bugs.webkit.org/show_bug.cgi?id=136609

Reviewed by Darin Adler.

To use BasicShapeFoo() helps to detect wrong type casting and improve code readability.

No new tests, no behavior changes.

  • css/BasicShapeFunctions.cpp:

(WebCore::valueForBasicShape):

  • rendering/shapes/Shape.cpp:

(WebCore::Shape::createShape):

  • rendering/style/BasicShapes.cpp:

(WebCore::BasicShape::canBlend):
(WebCore::BasicShapeCircle::blend):
(WebCore::BasicShapeEllipse::blend):
(WebCore::BasicShapePolygon::blend):
(WebCore::BasicShapeInset::blend):

  • rendering/style/BasicShapes.h:
12:14 PM Changeset in webkit [173368] by Darin Adler
  • 2 edits in trunk/Source/WebKit/mac

Fix build failure seen on Mountain Lion buildbot.

  • Misc/WebNSDataExtras.h: Make WEB_GUESS_MIME_TYPE_PEEK_LENGTH an unsigned instead

of an int, to avoid warning about mixing signs.

10:56 AM Changeset in webkit [173367] by weinig@apple.com
  • 16 edits
    1 move
    2 adds in trunk

XPCPtr should be converted into an all purpose smart pointer for os_objects
​https://bugs.webkit.org/show_bug.cgi?id=136602

Reviewed by Darin Adler.

Source/WebKit2:

  • DatabaseProcess/EntryPoint/mac/XPCService/DatabaseServiceEntryPoint.mm:

(DatabaseServiceInitializer):

  • NetworkProcess/EntryPoint/mac/XPCService/NetworkServiceEntryPoint.mm:

(WebKit::NetworkServiceInitializerDelegate::NetworkServiceInitializerDelegate):
(NetworkServiceInitializer):

  • Platform/IPC/Connection.h:

(IPC::Connection::Identifier::Identifier):

  • Platform/IPC/mac/ConnectionMac.mm:

(IPC::ConnectionTerminationWatchdog::createConnectionTerminationWatchdog):
(IPC::ConnectionTerminationWatchdog::ConnectionTerminationWatchdog):

  • Platform/IPC/mac/XPCPtr.h: Removed.
  • PluginProcess/EntryPoint/mac/XPCService/PluginServiceEntryPoint.mm:

(WebKit::PluginServiceInitializerDelegate::PluginServiceInitializerDelegate):
(PluginServiceInitializer):

  • Shared/EntryPointUtilities/mac/XPCService/XPCServiceEntryPoint.h:

(WebKit::XPCServiceInitializerDelegate::XPCServiceInitializerDelegate):
(WebKit::XPCServiceInitializer):

  • Shared/EntryPointUtilities/mac/XPCService/XPCServiceEntryPoint.mm:

(WebKit::XPCServiceInitializerDelegate::checkEntitlements):
(WebKit::XPCServiceInitializerDelegate::hasEntitlement):

  • Shared/EntryPointUtilities/mac/XPCService/XPCServiceMain.Development.mm:

(WebKit::XPCServiceEventHandler):

  • Shared/EntryPointUtilities/mac/XPCService/XPCServiceMain.mm:

(WebKit::XPCServiceEventHandler):

  • UIProcess/Launcher/mac/ProcessLauncherMac.mm:

(WebKit::connectToService):
(WebKit::connectToReExecService):

  • WebProcess/EntryPoint/mac/XPCService/WebContentServiceEntryPoint.mm:

(WebContentServiceInitializer):
Update after the rename of XPCPtr to OSObjectPtr.

Source/WTF:

  • WTF.xcodeproj/project.pbxproj:
  • wtf/OSObjectPtr.h: Copied from Source/WebKit2/Platform/IPC/mac/XPCPtr.h.

(WTF::retainOSObject):
(WTF::releaseOSObject):
(WTF::OSObjectPtr::OSObjectPtr):
(WTF::OSObjectPtr::~OSObjectPtr):
(WTF::OSObjectPtr::operator=):
(WTF::adoptOSObject):
(IPC::XPCPtr::XPCPtr): Deleted.
(IPC::XPCPtr::~XPCPtr): Deleted.
(IPC::XPCPtr::operator=): Deleted.
(IPC::adoptXPC): Deleted.
Rename/move XPCPtr to OSObjectPtr and make it work with any os_object.

Tools:

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WTF/darwin: Added.
  • TestWebKitAPI/Tests/WTF/darwin/OSObjectPtr.cpp: Added.

Add basic unit tests for OSObjectPtr.

2:30 AM Changeset in webkit [173366] by timothy@apple.com
  • 3 edits in trunk/Source/WebInspectorUI

Use a <circle> instead of a <path> in DownloadArrow.svg.
​https://bugs.webkit.org/show_bug.cgi?id=136608

Reviewed by Antoine Quint.

  • UserInterface/Images/DownloadArrow.svg:
  • UserInterface/Views/TreeElementStatusButton.css:

(.item > .status > .status-button > svg .filled):
(body.mac-platform.legacy .item > .status > .status-button > svg .filled):
(:focus .item.selected > .status > .status-button > svg .filled):
(.item > .status > .status-button > svg .stroked):
(body.mac-platform.legacy .item > .status > .status-button > svg .stroked):
(:focus .item.selected > .status > .status-button > svg .stroked):
Tweak CSS selectors to apply to other shapes, not just path.

Note: See TracTimeline for information about the timeline view.