Timeline
Sep 10, 2014:
- 11:41 PM Changeset in webkit [173508] by
-
- 2 edits in trunk/Tools
[EFL][WK2] Minibrowser : Shift+Scroll navigate to back or forward url's
https://bugs.webkit.org/show_bug.cgi?id=136698
Patch by Tanay C <tanay.c@samsung.com> on 2014-09-10
Reviewed by Gyuyoung Kim.
- MiniBrowser/efl/main.c: Add functionality to support shift + mouse scroll navigation
(on_mouse_wheel): Added.
(window_free):
(window_create):
- 9:42 PM Changeset in webkit [173507] by
-
- 4 edits in trunk/Source/WebCore
Use ASSERT instead of ASSERT_WITH_SECURITY_IMPLICATION
https://bugs.webkit.org/show_bug.cgi?id=136732
Reviewed by Andy Estes.
Since r173458 changed to use static_cast<> with toFoo, ASSERT_WITH_SECURITY_IMPLICATION doesn't
need to be used anymore. ASSERT is enough for it.
- workers/DefaultSharedWorkerRepository.cpp:
(WebCore::SharedWorkerProxy::addToWorkerDocuments):
- workers/WorkerMessagingProxy.cpp:
(WebCore::WorkerMessagingProxy::startWorkerGlobalScope):
- xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::document):
- 9:01 PM Changeset in webkit [173506] by
-
- 2 edits in trunk/Source/WebCore
[SVG] Cleanup iterator code in SMILTimeContainer using range-based loop
https://bugs.webkit.org/show_bug.cgi?id=136720
Reviewed by Filip Pizlo.
No new tests, no change on behavior.
- svg/animation/SMILTimeContainer.cpp:
(WebCore::SMILTimeContainer::setElapsed):
(WebCore::SMILTimeContainer::updateAnimations):
- 7:37 PM Changeset in webkit [173505] by
-
- 13 edits1 add in trunk/Source
Web Inspector: Modify the type profiler runtime protocol to transfer some computation into the WebInspector
https://bugs.webkit.org/show_bug.cgi?id=136500
Reviewed by Joseph Pecoraro.
Source/JavaScriptCore:
This patch changes the type profiler protocol to the Web Inspector
by moving the work of calculating computed properties that effect the UI
into the Web Inspector. This makes the Web Inspector have control over the
strings it displays as UI elements representing type information to the user
instead of JavaScriptCore deciding on a convention for these strings.
JavaScriptCore now sends enough information to the Web Inspector so that
it can compute the properties JavaScriptCore used to compute.
- inspector/agents/InspectorRuntimeAgent.cpp:
(Inspector::InspectorRuntimeAgent::getRuntimeTypesForVariablesAtOffsets):
- inspector/protocol/Runtime.json:
- runtime/TypeProfiler.cpp:
(JSC::TypeProfiler::getTypesForVariableAtOffsetForInspector): Deleted.
- runtime/TypeProfiler.h:
- runtime/TypeSet.cpp:
(JSC::TypeSet::inspectorTypeSet):
(JSC::StructureShape::leastCommonAncestor):
(JSC::StructureShape::inspectorRepresentation):
- runtime/TypeSet.h:
Source/WebInspectorUI:
This patch maintains the same UI in the Web Inspector for displaying
type information, but now accounts for the new protocol for type profiling.
The Inspector now has a TypeSet class that wraps the TypeDescription
protocol object and creates a simple interface for asking protocol objects
about their type.
- UserInterface/Controllers/TypeTokenAnnotator.js:
(WebInspector.TypeTokenAnnotator.prototype._insertTypeTokensForEachNode):
- UserInterface/Main.html:
- UserInterface/Models/TypeSet.js: Added.
(WebInspector.TypeSet):
(WebInspector.TypeSet.fromPayload):
(WebInspector.TypeSet.prototype.isContainedIn):
- UserInterface/Views/SourceCodeTextEditor.js:
(WebInspector.SourceCodeTextEditor.prototype._tokenTrackingControllerHighlightedJavaScriptTypeInformation.handler):
(WebInspector.SourceCodeTextEditor.prototype._tokenTrackingControllerHighlightedJavaScriptTypeInformation):
- UserInterface/Views/TypePropertiesSection.js:
(WebInspector.TypePropertiesSection.prototype.onpopulate):
(WebInspector.TypePropertyTreeElement.prototype.onpopulate):
- UserInterface/Views/TypeTokenView.js:
(WebInspector.TypeTokenView.prototype.update):
(WebInspector.TypeTokenView.prototype._shouldShowPopover):
(WebInspector.TypeTokenView.prototype._displayTypeName):
- 6:47 PM Changeset in webkit [173504] by
-
- 3 edits in trunk/Source/WebCore
Fix the build.
- platform/network/ResourceHandle.h:
- platform/network/mac/ResourceHandleMac.mm:
- 6:25 PM Changeset in webkit [173503] by
-
- 2 edits in trunk/Tools
[EFL][WK2] Minibrowser : Add tooltip for toolbar buttons in Minibrowser
https://bugs.webkit.org/show_bug.cgi?id=136284
Patch by Rohit Kumar <kumar.rohit@samsung.com> on 2014-09-10
Reviewed by Gyuyoung Kim.
- MiniBrowser/efl/main.c:
(window_create):
- 5:50 PM Changeset in webkit [173502] by
-
- 6 edits in trunk/Source/WebCore
Delete class SavedDrawingStateForMask
https://bugs.webkit.org/show_bug.cgi?id=136498
Patch by Myles C. Maxfield <mmaxfield@apple.com> <litherum@gmail.com> on 2014-09-09
Reviewed by Darin Adler.
This class is left over from when text-decoration-skip: ink used
GraphicsContext masking.
No new tests because there is no behavior change.
- rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::applyShadowToGraphicsContext):
- rendering/InlineTextBox.h:
- rendering/TextPainter.cpp:
(WebCore::TextPainter::TextPainter):
(WebCore::paintTextWithShadows):
(WebCore::TextPainter::paintText):
- rendering/TextPainter.h:
(WebCore::SavedDrawingStateForMask::SavedDrawingStateForMask): Deleted.
- rendering/svg/SVGInlineTextBox.cpp:
(WebCore::SVGInlineTextBox::paintTextWithShadows):
- 5:47 PM Changeset in webkit [173501] by
-
- 3 edits in trunk/Source/WebCore
Call setCollectsTimingData only once, and before making any {CF,NS}URLConnections
https://bugs.webkit.org/show_bug.cgi?id=136731
<rdar://problem/18252844>
Reviewed by Simon Fraser.
- platform/network/cf/ResourceHandleCFNet.cpp:
(WebCore::ResourceHandle::start):
Move setCollectsTimingData to before createCFURLConnection, so the first connection
has timing data associated with it.
- platform/network/mac/ResourceHandleMac.mm:
(WebCore::ResourceHandle::createNSURLConnection):
Move setCollectsTimingData to before we create our NSURLConnection, so the first connection
has timing data associated with it.
Use setCollectsTimingData instead of the NSURLConnection SPI directly.
(WebCore::ResourceHandle::setCollectsTimingData):
Only call _setCollectsTimingData once.
- 5:38 PM Changeset in webkit [173500] by
-
- 12 edits3 adds in trunk/LayoutTests
Unreviewed gardening. Rebaseline failing media/video- tests broken by r156546.
- platform/mac/TestExpectations:
- platform/mac/media/video-controls-captions-trackmenu-localized-expected.txt:
- platform/mac/media/video-controls-captions-trackmenu-only-captions-descriptions-and-subtitles-expected.txt: Added.
- platform/mac/media/video-controls-captions-trackmenu-sorted-expected.txt:
- platform/mac/media/video-controls-no-scripting-expected.txt: Added.
- platform/mac/media/video-controls-rendering-expected.png:
- platform/mac/media/video-controls-rendering-expected.txt:
- platform/mac/media/video-display-toggle-expected.png:
- platform/mac/media/video-display-toggle-expected.txt:
- platform/mac/media/video-empty-source-expected.png:
- platform/mac/media/video-empty-source-expected.txt:
- platform/mac/media/video-volume-slider-expected.png:
- platform/mac/media/video-volume-slider-expected.txt:
- platform/mac/media/volume-bar-empty-when-muted-expected.txt: Added.
- 5:25 PM Changeset in webkit [173499] by
-
- 11 edits in trunk/Source/WebCore
Remove iOS-only -webkit-composition-fill-color CSS property.
https://bugs.webkit.org/show_bug.cgi?id=136728
rdar://problem/10439154
Reviewed by Tim Horton.
This property is no longer used on iOS.
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::ComputedStyleExtractor::propertyValue):
- css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
- css/CSSPropertyNames.in:
- css/StyleResolver.cpp:
(WebCore::StyleResolver::applyProperty):
- editing/EditingStyle.cpp:
- platform/graphics/Color.h:
- rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::paintCompositionBackground):
- rendering/style/RenderStyle.h:
- rendering/style/StyleRareInheritedData.cpp:
(WebCore::StyleRareInheritedData::StyleRareInheritedData):
(WebCore::StyleRareInheritedData::operator==):
- rendering/style/StyleRareInheritedData.h:
- 5:01 PM Changeset in webkit [173498] by
-
- 4 edits in trunk/Tools
import-w3c-tests doesn't handle relative paths to support files in ref files correctly
https://bugs.webkit.org/show_bug.cgi?id=135929
Patch by Rebecca Hauck <rhauck@adobe.com> on 2014-09-10
Reviewed by Bem Jones-Bey.
The recent refactor of the W3C test repo falsified a bunch of assmumptions that
were made when this script was originally written with respect to relative paths
in ref files. This patch updates import-w3c-tests to update paths in ref files if
they move relative to the test file.
- Scripts/webkitpy/w3c/test_converter.py:
(convert_for_webkit):
(_W3CTestConverter.init):
(_W3CTestConverter.convert_reference_relpaths):
(_W3CTestConverter.convert_style_data):
(_W3CTestConverter.convert_attributes_if_needed):
- Scripts/webkitpy/w3c/test_importer.py:
(TestImporter.find_importable_tests):
(TestImporter.import_tests):
- Scripts/webkitpy/w3c/test_parser.py:
(TestParser.load_file):
(TestParser.analyze_test):
(TestParser.support_files):
- 4:57 PM Changeset in webkit [173497] by
-
- 2 edits in trunk/Source/JavaScriptCore
Apply ARM64-specific lowering to load/store instructions in offlineasm
https://bugs.webkit.org/show_bug.cgi?id=136569
Patch by Akos Kiss <akiss@inf.u-szeged.hu> on 2014-09-10
Reviewed by Michael Saboff.
The standard risc lowering of load/store instructions with base +
immediate offset addresses is to move the offset to a temporary, add the
base to the temporary, and then change the load/store to use the
temporary + 0 immediate offset address. However, on ARM64, base +
register offset addressing mode is available, so it is unnecessary to
perform explicit register additions but it is enough to change load/store
to use base + temporary as the address.
- offlineasm/arm64.rb: Added arm64LowerMalformedLoadStoreAddresses
- 4:48 PM Changeset in webkit [173496] by
-
- 2 edits in trunk/LayoutTests
More unreviewed gardening.
- Mark tests as WontFix which depend on platform support which will never be added.
- Fix http/tests/media/video-auth.html by marking it as failing on MountainLion.
- platform/mac/TestExpectations:
- 3:44 PM Changeset in webkit [173495] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening. Re-skip some obsolete EME tests.
- platform/mac/TestExpectations:
- 3:41 PM Changeset in webkit [173494] by
-
- 5 edits in trunk/Source/WebInspectorUI
Web Inspector: Eliminate typeof "undefined" checks
https://bugs.webkit.org/show_bug.cgi?id=136691
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-09-10
Reviewed by Alexey Proskuryakov.
- UserInterface/Base/Main.js:
(WebInspector.linkifyURLAsNode):
(WebInspector.linkifyStringAsFragment):
- UserInterface/Protocol/InspectorBackend.js:
(InspectorBackend.Command.prototype._invokeWithArguments):
- UserInterface/Views/DataGrid.js:
(WebInspector.DataGrid.prototype.get resizeMethod):
- UserInterface/Views/NavigationBar.js:
(WebInspector.NavigationBar.prototype.get minimumWidth):
- 3:22 PM Changeset in webkit [173493] by
-
- 3 edits in trunk/Source/WebCore
Remove ImageSource::ShouldSkipMetadata
https://bugs.webkit.org/show_bug.cgi?id=136713
Reviewed by Pratik Solanki.
- platform/graphics/ImageSource.h:
- platform/graphics/cg/ImageSourceCG.cpp:
(WebCore::createImageSourceOptions):
(WebCore::imageSourceOptions):
(WebCore::ImageSource::frameSizeAtIndex):
(WebCore::ImageSource::createFrameAtIndex):
(WebCore::ImageSource::frameDurationAtIndex):
Remove ShouldSkipMetadata and users. Nobody ever uses DoNotSkipMetadata.
- 3:13 PM Changeset in webkit [173492] by
-
- 11 edits1 add in trunk/Source/WebInspectorUI
Web Inspector: Fix obscure ESLint warnings and skip directories
https://bugs.webkit.org/show_bug.cgi?id=136686
Reviewed by Timothy Hatcher.
- .eslintignore: Added.
Skip directories we do not want ESLint to process.
- .eslintrc:
Add rules we've seen and sort sections.
- UserInterface/Controllers/FormatterContentBuilder.js:
(FormatterContentBuilder.prototype._appendIndent):
- UserInterface/Models/Color.js:
- UserInterface/Models/DOMNodeStyles.js:
(WebInspector.DOMNodeStyles.prototype._parseStyleDeclarationPayload):
- UserInterface/Views/CSSStyleDeclarationTextEditor.js:
- UserInterface/Views/DOMTreeDataGridNode.js:
- UserInterface/Views/DOMTreeElement.js:
(WebInspector.DOMTreeElement.prototype.ondelete):
(WebInspector.DOMTreeElement.prototype._insertInLastAttributePosition):
(WebInspector.DOMTreeElement.prototype._distinctClosingTagElement):
- UserInterface/Views/EditingSupport.js:
(WebInspector.EditingConfig):
- UserInterface/Views/LayerTreeDataGridNode.js:
(WebInspector.LayerTreeDataGridNode.prototype._makeOutlet):
- UserInterface/Views/TreeOutline.js:
(TreeOutline.prototype.appendChild):
(TreeOutline.prototype.insertChild):
(TreeOutline.prototype.removeChildAtIndex):
(TreeOutline.prototype.removeChild):
(TreeElement.prototype.expandRecursively):
Fix linter issues.
- 2:55 PM Changeset in webkit [173491] by
-
- 2 edits in trunk/LayoutTests
Skip some flaky tests that may be affecting subsequent tests.
- platform/mac/TestExpectations:
- 2:52 PM Changeset in webkit [173490] by
-
- 22 edits2 moves in trunk/Source/JavaScriptCore
Rename JSVariableObject to JSEnvironmentRecord to align naming with ES spec
https://bugs.webkit.org/show_bug.cgi?id=136710
Reviewed by Anders Carlsson.
This is a trivial rename.
- CMakeLists.txt:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
- JavaScriptCore.xcodeproj/project.pbxproj:
- dfg/DFGAbstractHeap.h:
- dfg/DFGClobberize.h:
(JSC::DFG::clobberize):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- ftl/FTLAbstractHeapRepository.cpp:
- ftl/FTLAbstractHeapRepository.h:
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileGetClosureRegisters):
- jit/JITOpcodes32_64.cpp:
- jit/JITPropertyAccess.cpp:
(JSC::JIT::emitGetClosureVar):
(JSC::JIT::emitPutClosureVar):
- jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::emitGetClosureVar):
(JSC::JIT::emitPutClosureVar):
- llint/LLIntOffsetsExtractor.cpp:
- llint/LowLevelInterpreter32_64.asm:
- llint/LowLevelInterpreter64.asm:
- runtime/JSActivation.cpp:
(JSC::JSActivation::getOwnNonIndexPropertyNames):
- runtime/JSActivation.h:
- runtime/JSEnvironmentRecord.cpp: Renamed from Source/JavaScriptCore/runtime/JSVariableObject.cpp.
- runtime/JSEnvironmentRecord.h: Renamed from Source/JavaScriptCore/runtime/JSVariableObject.h.
(JSC::JSEnvironmentRecord::registers):
(JSC::JSEnvironmentRecord::registerAt):
(JSC::JSEnvironmentRecord::addressOfRegisters):
(JSC::JSEnvironmentRecord::offsetOfRegisters):
(JSC::JSEnvironmentRecord::JSEnvironmentRecord):
- runtime/JSNameScope.h:
- runtime/JSSegmentedVariableObject.h:
- 2:45 PM Changeset in webkit [173489] by
-
- 5 edits in branches/safari-600.1.4.11-branch/Source/WebKit2
Merged r173450. <rdar://problem/17629840>
- 2:42 PM Changeset in webkit [173488] by
-
- 2 edits in trunk/LayoutTests
"AVF info: hasOfflineRenderer, board-id check : true" in media/track/track-forced-subtitles-in-band.html
https://bugs.webkit.org/show_bug.cgi?id=124219
Unreviewed gardening. This skip was made unnecessary after selective filtering was added in r160247.
- platform/mac/TestExpectations:
- 2:40 PM Changeset in webkit [173487] by
-
- 2 edits in branches/safari-600.1.4.11-branch/Source/WebCore
Merged r173345. <rdar://problem/17457013>
- 2:38 PM Changeset in webkit [173486] by
-
- 2 edits in trunk/LayoutTests
More unreviewed gardening of media/ tests; Move tests into the correct sub-groups and add comments
to test expectations without attached bugzilla bugs (due to WontFix, etc.).
- platform/mac/TestExpectations:
- 2:38 PM Changeset in webkit [173485] by
-
- 1 move in tags/Safari-600.1.17.1
Rename Tag.
- 1:40 PM Changeset in webkit [173484] by
-
- 3 edits in trunk/Source/WebCore
https://bugs.webkit.org/show_bug.cgi?id=136650
Rubber-banding in the DOM view of the WebInspector is really jumpy
-and corresponding-
rdar://problem/18166043
Reviewed by Darin Adler.
This patch implements the ScrollableArea virtual function isRubberBandInProgress()
for RenderLayer, and then uses that to determine whether to clamp the scroll
position in updateScrollInfoAfterLayout().
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::isRubberBandInProgress):
(WebCore::RenderLayer::updateScrollInfoAfterLayout):
- rendering/RenderLayer.h:
- 1:34 PM Changeset in webkit [173483] by
-
- 5 edits in branches/safari-600.1.17-branch/Source
Versioning.
- 1:32 PM Changeset in webkit [173482] by
-
- 1 copy in tags/safari-600.1.17.1
New Tag.
- 1:30 PM Changeset in webkit [173481] by
-
- 2 edits in branches/safari-600.1.17-branch/Source/WebCore
Merge r173218. rdar://problem/18112559
- 1:14 PM Changeset in webkit [173480] by
-
- 3 edits in trunk/Source/JavaScriptCore
[mips] Add missing parts and fix LLINT mips backend
https://bugs.webkit.org/show_bug.cgi?id=136706
Reviewed by Michael Saboff.
- llint/LowLevelInterpreter.asm: Fix invalid CalleeSave register number.
Implement initPCRelative and setEntryAddress macros.
- llint/LowLevelInterpreter32_64.asm: Fix register distribution in
doVMEntry macro.
- 12:59 PM Changeset in webkit [173479] by
-
- 2 edits in trunk/LayoutTests
More unreviewed gardening; despite the comment, media/audio-repaint.html is failing on all mac ports, not just on Lion.
- platform/mac/TestExpectations:
- 12:26 PM Changeset in webkit [173478] by
-
- 2 edits in trunk/Source/WebCore
Remove a workaround in frameIsCompleteAtIndex for a problem that was fixed in Lion
https://bugs.webkit.org/show_bug.cgi?id=136652
Reviewed by Dan Bernstein.
- platform/graphics/cg/ImageSourceCG.cpp:
(WebCore::ImageSource::frameIsCompleteAtIndex):
ImageIO returns the right thing now.
- 12:15 PM Changeset in webkit [173477] by
-
- 14 edits in trunk/Source/WebInspectorUI
Web Inspector: Fix ESLint consistent-return warnings
https://bugs.webkit.org/show_bug.cgi?id=136682
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-09-10
Reviewed by Timothy Hatcher.
- .eslintrc:
- UserInterface/Controllers/BranchManager.js:
(WebInspector.BranchManager.prototype.createBranch):
- UserInterface/Controllers/FrameResourceManager.js:
(WebInspector.FrameResourceManager.prototype._addNewResourceToFrame):
- UserInterface/Models/DOMNodeStyles.js:
(WebInspector.DOMNodeStyles.prototype._parseStyleDeclarationPayload):
- UserInterface/Views/BoxModelDetailsSectionRow.js:
(WebInspector.BoxModelDetailsSectionRow.prototype._applyUserInput):
- UserInterface/Views/DOMTreeElement.js:
(WebInspector.DOMTreeElement.prototype.showChild):
(WebInspector.DOMTreeElement.prototype._startEditingTarget):
(WebInspector.DOMTreeElement.prototype._startEditing):
- UserInterface/Views/EditingSupport.js:
- UserInterface/Views/EventListenerSectionGroup.js:
(WebInspector.EventListenerSectionGroup.prototype._nodeTextOrLink):
- UserInterface/Views/FrameContentView.js:
(WebInspector.FrameContentView.prototype._showContentViewForIdentifier):
- UserInterface/Views/NavigationBar.js:
(WebInspector.NavigationBar.prototype.insertNavigationItem):
(WebInspector.NavigationBar.prototype.removeNavigationItem):
- UserInterface/Views/QuickConsole.js:
(WebInspector.QuickConsole.prototype._insertExecutionContextPathComponentForFrame):
- UserInterface/Views/Sidebar.js:
(WebInspector.Sidebar.prototype.addSidebarPanel):
(WebInspector.Sidebar.prototype.removeSidebarPanel):
- UserInterface/Views/TextEditor.js:
(WebInspector.TextEditor.prototype.addStyleClassToLine):
(WebInspector.TextEditor.prototype.removeStyleClassFromLine):
(WebInspector.TextEditor.prototype.toggleStyleClassForLine):
- 11:58 AM Changeset in webkit [173476] by
-
- 3 edits in trunk/Source/WebCore
Laying out a TextRun using an SVG font is O(n2)
https://bugs.webkit.org/show_bug.cgi?id=136584
Reviewed by Darin Adler.
Addressing post-commit review from Darin.
No new tests.
- platform/graphics/Font.h:
(WebCore::Font::treatAsSpace): Un-inline.
(WebCore::Font::treatAsZeroWidthSpace): Ditto.
(WebCore::Font::treatAsZeroWidthSpaceInComplexScript): Ditto.
- svg/SVGFontData.cpp:
(WebCore::computeNormalizedSpaces): Avoid unnecessary copy.
- 11:15 AM Changeset in webkit [173475] by
-
- 4 edits in trunk/LayoutTests
Unreviewed. Fix a snapshotting test. Test was incorrect as it assumed the wrong window size.
- platform/mac-wk2/TestExpectations: Remove some duplicate test expectations.
- platform/mac-wk2/plugins/snapshotting/snapshot-plugin-not-quite-blocked-by-image-expected.txt:
- plugins/snapshotting/snapshot-plugin-not-quite-blocked-by-image.html:
- 11:10 AM Changeset in webkit [173474] by
-
- 2 edits in trunk/Source/WebCore
[Curl] Optimization; avoid reallocating string many times.
https://bugs.webkit.org/show_bug.cgi?id=136704
Patch by peavo@outlook.com <peavo@outlook.com> on 2014-09-10
Reviewed by Alex Christensen.
Adding individual characters to a string is inefficient, the string will be reallocated each time.
- platform/network/curl/CookieJarCurl.cpp:
(WebCore::readCurlCookieToken):
- 11:01 AM Changeset in webkit [173473] by
-
- 5 edits in branches/safari-600.1.17-branch/Source
Versioning.
- 10:45 AM Changeset in webkit [173472] by
-
- 2 edits in trunk/LayoutTests
Rollout r173446, the skipped tests still fail only on the bots.
- platform/mac-wk2/TestExpectations:
- 10:43 AM Changeset in webkit [173471] by
-
- 1 copy in branches/safari-600.1.17-branch
New Branch.
- 10:18 AM Changeset in webkit [173470] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening. Group all the media expectations together logically.
- platform/mac/TestExpectations:
- 9:43 AM Changeset in webkit [173469] by
-
- 6 edits2 adds in trunk/Source/JavaScriptCore
TypeSet needs a mode where it no longer profiles structure shapes
https://bugs.webkit.org/show_bug.cgi?id=136263
Reviewed by Filip Pizlo.
The TypeSet data structure used to gather as many StructureShape
objects as it encountered during type profiling. But, this meant
that there was no upper limit on how many objects it could allocate.
This patch places a fixed upper bound on the number of StructureShapes
allocated per TypeSet to prevent using too much memory for little gain
in type profiling usefulness.
StructureShape objects are now also aware of when they are created
from Structures which are dictionaries.
In total, this patch lays the final groundwork needed in refactoring
the inspector protocol for the type profiler.
- runtime/Structure.cpp:
(JSC::Structure::toStructureShape):
- runtime/TypeProfiler.cpp:
(JSC::TypeProfiler::typeInformationForExpressionAtOffset):
- runtime/TypeSet.cpp:
(JSC::TypeSet::TypeSet):
(JSC::TypeSet::addTypeInformation):
(JSC::StructureShape::StructureShape):
(JSC::StructureShape::toJSONString):
(JSC::StructureShape::enterDictionaryMode):
- runtime/TypeSet.h:
(JSC::TypeSet::isOverflown):
- tests/typeProfiler/dictionary-mode.js: Added.
(wrapper):
- tests/typeProfiler/driver/driver.js:
- tests/typeProfiler/overflow.js: Added.
(wrapper.Proto):
(wrapper):
- 9:35 AM Changeset in webkit [173468] by
-
- 7 edits in trunk/Source/WebKit2
NetworkResourceLoader cleanups
https://bugs.webkit.org/show_bug.cgi?id=136701
Reviewed by Darin Adler.
After smashing NetworkResourceLoader together with the clients it can be made nicer.
- NetworkProcess/NetworkResourceLoadScheduler.cpp:
(WebKit::NetworkResourceLoadScheduler::scheduleLoader):
(WebKit::NetworkResourceLoadScheduler::removeLoader):
- NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::SynchronousLoadData::SynchronousLoadData):
The original request is now part of the loader.
(WebKit::sendReplyToSynchronousRequest):
(WebKit::NetworkResourceLoader::NetworkResourceLoader):
Instead of copying everything out from NetworkResourceLoadParameters just include the whole thing as a const field.
SanboxExtension construction moves to NetworkResourceLoadParameters::decode()
Stuff that is related to starting the load moves to start().
(WebKit::NetworkResourceLoader::~NetworkResourceLoader):
(WebKit::NetworkResourceLoader::start):
(WebKit::NetworkResourceLoader::setDefersLoading):
Eliminate m_deferredRequest since we now always remember the original request.
(WebKit::NetworkResourceLoader::cleanup):
(WebKit::NetworkResourceLoader::didConvertHandleToDownload):
(WebKit::NetworkResourceLoader::abort):
(WebKit::NetworkResourceLoader::didReceiveResponseAsync):
(WebKit::NetworkResourceLoader::didFail):
(WebKit::NetworkResourceLoader::willSendRequestAsync):
(WebKit::NetworkResourceLoader::continueWillSendRequest):
Eliminate unnecessary m_suggestedRequestForWillSendRequest.
(WebKit::NetworkResourceLoader::wasBlocked):
(WebKit::NetworkResourceLoader::cannotShowURL):
(WebKit::NetworkResourceLoader::shouldUseCredentialStorage):
(WebKit::NetworkResourceLoader::didReceiveAuthenticationChallenge):
(WebKit::NetworkResourceLoader::receivedCancellation):
(WebKit::NetworkResourceLoader::startBufferingTimerIfNeeded):
(WebKit::NetworkResourceLoader::consumeSandboxExtensions):
(WebKit::NetworkResourceLoader::invalidateSandboxExtensions):
(WebKit::NetworkResourceLoader::sendAbortingOnFailure):
- NetworkProcess/NetworkResourceLoader.h:
(WebKit::NetworkResourceLoader::originalRequest):
(WebKit::NetworkResourceLoader::currentRequest):
(WebKit::NetworkResourceLoader::sessionID):
(WebKit::NetworkResourceLoader::defersLoading):
(WebKit::NetworkResourceLoader::isLoadingMainResource):
(WebKit::NetworkResourceLoader::request): Deleted.
(WebKit::NetworkResourceLoader::sendAbortingOnFailure): Deleted.
Made private and moved to cpp.
- NetworkProcess/mac/NetworkDiskCacheMonitor.mm:
(WebKit::NetworkDiskCacheMonitor::NetworkDiskCacheMonitor):
Use original request instead of the current one. This might fix a bug where we didn't use file backing over redirects.
- Shared/Network/NetworkResourceLoadParameters.cpp:
(WebKit::NetworkResourceLoadParameters::decode):
Decode to SanboxExtensions to the actual type rather than a handle.
- Shared/Network/NetworkResourceLoadParameters.h:
- 9:22 AM Changeset in webkit [173467] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, rolling out r173446.
https://bugs.webkit.org/show_bug.cgi?id=136707
These two tests fail consistently on Mavericks and ML WK2
bots. (Requested by jernoble|laptop on #webkit).
Reverted changeset:
"Unskip two snapshotting tests that work for me consistently
locally."
http://trac.webkit.org/changeset/173446
- 9:00 AM Changeset in webkit [173466] by
-
- 5 edits in trunk/Source/WebInspectorUI
Web Inspector: Fix ESLint no-undef warnings
https://bugs.webkit.org/show_bug.cgi?id=136660
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-09-10
Reviewed by Timothy Hatcher.
- UserInterface/Models/DOMSearchMatchObject.js:
(WebInspector.DOMSearchMatchObject.prototype._generateClassName):
(WebInspector.DOMSearchMatchObject.titleForDOMNode):
- UserInterface/Models/Gradient.js:
(WebInspector.Gradient.fromString):
- UserInterface/Views/CodeMirrorAdditions.js:
- UserInterface/Views/ReplayDashboardView.js:
(WebInspector.ReplayDashboardView):
- 8:58 AM Changeset in webkit [173465] by
-
- 1 edit1 add in trunk/Source/WebCore
[Curl] Compile error, CertificateInfo.h is not found.
https://bugs.webkit.org/show_bug.cgi?id=136703
Patch by peavo@outlook.com <peavo@outlook.com> on 2014-09-10
Reviewed by Alex Christensen.
Curl also needs to implement the CertificateInfo class.
- platform/network/curl/CertificateInfo.h: Added.
(WebCore::CertificateInfo::CertificateInfo):
- 8:54 AM Changeset in webkit [173464] by
-
- 7 edits in trunk/Source/WebCore
Clean up some ENABLE(PICTURE_SIZES) stuff, don't change function signatures inside #ifdefs
https://bugs.webkit.org/show_bug.cgi?id=136654
Reviewed by Darin Adler.
Adding parameters inside an #ifdef makes for unreadable code, so remove some
#if ENABLE(PICTURE_SIZES) related to the preload scanner and always pass the arguments.
Reduced the argument count on some functions by just passing a Document&.
Also fix a couple of uses of #if ENABLE_PICTURE_SIZES.
- html/HTMLImageElement.h:
- html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::pumpTokenizer):
(WebCore::HTMLDocumentParser::insert):
(WebCore::HTMLDocumentParser::append):
(WebCore::HTMLDocumentParser::appendCurrentInputStreamToPreloadScannerAndScan):
- html/parser/HTMLPreloadScanner.cpp:
(WebCore::TokenPreloadScanner::scan):
(WebCore::HTMLPreloadScanner::scan):
- html/parser/HTMLPreloadScanner.h:
- html/parser/HTMLSrcsetParser.cpp:
(WebCore::pickBestImageCandidate):
(WebCore::bestFitSourceForImageAttributes):
- html/parser/HTMLSrcsetParser.h:
- 8:51 AM Changeset in webkit [173463] by
-
- 3 edits in trunk/Source/WebInspectorUI
Web Inspector: Remove unused Console search highlight methods
https://bugs.webkit.org/show_bug.cgi?id=136661
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-09-10
Reviewed by Timothy Hatcher.
ESLint's no-undef warning complained about some undefined references
in these functions that would have thrown exceptions. Turns out this
code is unused, and we do highlighting in the console separately.
- UserInterface/Views/ConsoleCommand.js:
(WebInspector.ConsoleCommand.prototype.clearHighlight): Deleted.
(WebInspector.ConsoleCommand.prototype.highlightSearchResults): Deleted.
(WebInspector.ConsoleCommand.prototype.matchesRegex): Deleted.
- UserInterface/Views/ConsoleMessageImpl.js:
(WebInspector.ConsoleMessageImpl.prototype.clearHighlight): Deleted.
(WebInspector.ConsoleMessageImpl.prototype.highlightSearchResults): Deleted.
(WebInspector.ConsoleMessageImpl.prototype.matchesRegex): Deleted.
- 8:49 AM Changeset in webkit [173462] by
-
- 6 edits in trunk/Source/WebInspectorUI
Web Inspector: Fix ESLint* no-avoidable-bind warnings
https://bugs.webkit.org/show_bug.cgi?id=136690
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-09-10
Reviewed by Timothy Hatcher.
- UserInterface/Protocol/RemoteObject.js:
(WebInspector.LocalJSONObject.prototype._children):
- UserInterface/Views/CSSStyleDetailsSidebarPanel.js:
(WebInspector.CSSStyleDetailsSidebarPanel):
- UserInterface/Views/LayerTreeSidebarPanel.js:
(WebInspector.LayerTreeSidebarPanel.prototype._updateDataGrid):
- UserInterface/Views/LogContentView.js:
(WebInspector.LogContentView.prototype._filterMessages):
- UserInterface/Views/TextResourceContentView.js:
(WebInspector.TextResourceContentView.prototype.get supplementalRepresentedObjects):
- 7:59 AM Changeset in webkit [173461] by
-
- 2 edits in trunk/Source/JavaScriptCore
[MIPS] branch32WithPatch missing
https://bugs.webkit.org/show_bug.cgi?id=136696
Reviewed by Michael Saboff.
Added the missing branch32WithPatch. The implementation
is currently the same as the branchPtrithPatch because
the macro assembler supports only 32 bit MIPS.
- assembler/MacroAssemblerMIPS.h:
(JSC::MacroAssemblerMIPS::branch32WithPatch):
- 7:57 AM Changeset in webkit [173460] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fix !ENABLE(DFG_JIT) build
https://bugs.webkit.org/show_bug.cgi?id=136702
Reviewed by Michael Saboff.
- bytecode/CallEdgeProfile.h:
- 7:47 AM Changeset in webkit [173459] by
-
- 3 edits2 adds in trunk
AX: aria-labelledby is not honoring sub-node text
https://bugs.webkit.org/show_bug.cgi?id=136689
Reviewed by Mario Sanchez Prada.
Source/WebCore:
Test: accessibility/aria-labelledby-with-descendants.html
When aria-labelledby retrieves the textUnderElements it needs to consider
all sub-children, including focusable content.
- accessibility/AccessibilityNodeObject.cpp:
(WebCore::accessibleNameForNode):
LayoutTests:
- accessibility/aria-labelledby-with-descendants-expected.txt: Added.
- accessibility/aria-labelledby-with-descendants.html: Added.
- 6:23 AM Changeset in webkit [173458] by
-
- 9 edits in trunk/Source/WebCore
Use toDocument instead of static_cast<Document*>
https://bugs.webkit.org/show_bug.cgi?id=136694
Reviewed by Andy Estes.
Clean up static_cast<Document*>.
- Modules/mediasource/SourceBuffer.cpp:
(WebCore::SourceBuffer::document):
- Modules/webaudio/AudioContext.cpp:
(WebCore::AudioContext::document):
- bindings/gobject/WebKitDOMPrivate.cpp:
(WebKit::wrap):
- dom/ScriptExecutionContext.cpp:
(WebCore::ScriptExecutionContext::dispatchErrorEvent): Add a line to remove .get().
- workers/DefaultSharedWorkerRepository.cpp:
(WebCore::SharedWorkerProxy::addToWorkerDocuments):
- workers/WorkerMessagingProxy.cpp:
(WebCore::WorkerMessagingProxy::startWorkerGlobalScope):
- xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::document):
(WebCore::XMLHttpRequest::open):
- 3:12 AM Changeset in webkit [173457] by
-
- 13 edits2 deletes in trunk/Source/WebCore
Merge CheckingContexts from SelectorCompiler and SelectorChecker
https://bugs.webkit.org/show_bug.cgi?id=135255
Reviewed by Benjamin Poulain.
In this patch, we merge SelectorChecker::SelectorCheckingContext and SelectorCompiler::CheckingContext.
We expose only SelectorChecker::CheckingContext. That is the same to the old SelectorCompiler::CheckingContext.
In SelectorChecker.cpp, we define SelectorChecker::CheckingContextWithStatus and use it internally.
And we move VisitedMatchType from SelectorChecker.h to SelectorChecker.cpp.
VisitedMatchType is also explicitly used by SelectorCheckerFastPath. However, SelectorCheckerFastPath is now
used only from SelectorQuery (Style resolution algorithm no longer uses it: r171059).
In this patch, we remove SelectorCheckerFastPath since the major cases are covered by CSS JIT.
InRightMostWithIdMatch,Element#matchesand multiple selectorsquerySelector('a, b')cases,
CSS JIT is not used. So dropping fast path affects them. But 1) these cases are rare or 2) the target node
is typically only one since nodes are filtered before matching. So it doesn't have performance regression.
And now since CheckingContextWithStatus is the derived class of CheckingContext, we can use
the same test functions; template parameter is not necessary. It reduces code size.
- CMakeLists.txt:
- WebCore.xcodeproj/project.pbxproj:
- css/CSSAllInOne.cpp:
- css/ElementRuleCollector.cpp:
(WebCore::ElementRuleCollector::ruleMatches):
- css/SelectorChecker.cpp:
(WebCore::SelectorChecker::CheckingContextWithStatus::CheckingContextWithStatus):
(WebCore::SelectorChecker::match):
(WebCore::checkingContextForParent):
(WebCore::SelectorChecker::matchRecursively):
(WebCore::canMatchHoverOrActiveInQuirksMode):
(WebCore::SelectorChecker::checkOne):
(WebCore::SelectorChecker::checkScrollbarPseudoClass):
- css/SelectorChecker.h:
(WebCore::SelectorChecker::CheckingContext::CheckingContext):
(WebCore::SelectorChecker::SelectorCheckingContext::SelectorCheckingContext): Deleted.
- css/SelectorCheckerFastPath.cpp: Removed.
- css/SelectorCheckerFastPath.h: Removed.
- css/SelectorCheckerTestFunctions.h:
(WebCore::scrollbarMatchesEnabledPseudoClass):
(WebCore::scrollbarMatchesDisabledPseudoClass):
(WebCore::scrollbarMatchesHoverPseudoClass):
(WebCore::scrollbarMatchesActivePseudoClass):
(WebCore::scrollbarMatchesHorizontalPseudoClass):
(WebCore::scrollbarMatchesVerticalPseudoClass):
(WebCore::scrollbarMatchesDecrementPseudoClass):
(WebCore::scrollbarMatchesIncrementPseudoClass):
(WebCore::scrollbarMatchesStartPseudoClass):
(WebCore::scrollbarMatchesEndPseudoClass):
(WebCore::scrollbarMatchesDoubleButtonPseudoClass):
(WebCore::scrollbarMatchesSingleButtonPseudoClass):
(WebCore::scrollbarMatchesNoButtonPseudoClass):
(WebCore::scrollbarMatchesCornerPresentPseudoClass):
- css/StyleResolver.h:
(WebCore::checkRegionSelector):
- cssjit/SelectorCompiler.cpp:
(WebCore::SelectorCompiler::SelectorFragment::appendUnoptimizedPseudoClassWithContext):
(WebCore::SelectorCompiler::addScrollbarPseudoClassType):
(WebCore::SelectorCompiler::SelectorCodeGenerator::addFlagsToElementStyleFromContext):
(WebCore::SelectorCompiler::SelectorCodeGenerator::branchOnResolvingModeWithCheckingContext):
(WebCore::SelectorCompiler::elementIsActiveForStyleResolution):
(WebCore::SelectorCompiler::setElementStyleFromContextIsAffectedByEmptyAndUpdateRenderStyleIfNecessary):
(WebCore::SelectorCompiler::elementIsHoveredForStyleResolution):
(WebCore::SelectorCompiler::makeContextStyleUniqueIfNecessaryAndTestIsPlaceholderShown):
(WebCore::SelectorCompiler::makeElementStyleUniqueIfNecessaryAndTestIsPlaceholderShown):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateRequestedPseudoElementEqualsToSelectorPseudoElement):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementIsScopeRoot):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateMarkPseudoStyleForPseudoElement):
- cssjit/SelectorCompiler.h:
(WebCore::SelectorCompiler::CheckingContext::CheckingContext): Deleted.
- dom/SelectorQuery.cpp:
(WebCore::SelectorDataList::SelectorDataList):
(WebCore::SelectorDataList::selectorMatches):
(WebCore::SelectorDataList::executeCompiledSelectorCheckerWithCheckingContext):
(WebCore::isCompiledSelector):
(WebCore::SelectorDataList::compileSelector):
(WebCore::SelectorDataList::execute):
- dom/SelectorQuery.h:
(WebCore::SelectorDataList::SelectorData::SelectorData):
- 1:37 AM Changeset in webkit [173456] by
-
- 8 edits in trunk
[GTK] allow overwriting destination of download
https://bugs.webkit.org/show_bug.cgi?id=136372
Patch by Michael Catanzaro <Michael Catanzaro> on 2014-09-10
Reviewed by Carlos Garcia Campos.
Source/WebKit2:
- UIProcess/API/gtk/WebKitDownload.cpp:
(webkitDownloadGetProperty): Added
(webkit_download_class_init): Install webkitDownloadGetProperty
(webkitDownloadDecideDestinationWithSuggestedFilename): Add
allowOverwrite parameter and set it appropriately
(webkit_download_get_allow_overwrite): Added
(webkit_download_set_allow_overwrite): Added
- UIProcess/API/gtk/WebKitDownload.h: New API
- UIProcess/API/gtk/WebKitDownloadClient.cpp:
(decideDestinationWithSuggestedFilename): Pass allowOverwrite to
webkitDownloadDecideDestinationWithSuggestedFilename
- UIProcess/API/gtk/WebKitDownloadPrivate.h: Add allowOverwrite
parameter to webkitDownloadDecideDestinationWithSuggestedFilename
- UIProcess/API/gtk/docs/webkit2gtk-sections.txt: New API
Tools:
- TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
(downloadLocalFileSuccessfully): Split from testDownloadLocalFile
(testDownloadLocalFile): Split off downloadLocalFileSuccessfully
(createFileAtDestination): Added
(testDownloadOverwriteDestinationAllowed): Added
(testDownloadOverwriteDestinationDisallowed): Added
(testDownloadLocalFileError): Use new DownloadErrorTest::ExpectedError
(testDownloadRemoteFileError): Use new DownloadErrorTest::ExpectedError
(beforeAll): New tests
- 12:21 AM Changeset in webkit [173455] by
-
- 2 edits in trunk/Source/WebKit2
[GTK] Clean up the WebKit build from unused parameter warning in Webkit2/UIProcess module
https://bugs.webkit.org/show_bug.cgi?id=136670
Patch by Rohit Kumar <kumar.rohit@samsung.com> on 2014-09-10
Reviewed by Martin Robinson.
- UIProcess/API/gtk/PageClientImpl.cpp:
(WebKit::PageClientImpl::didSameDocumentNavigationForMainFrame):
Sep 9, 2014:
- 8:59 PM Changeset in webkit [173454] by
-
- 4 edits in trunk
[MSE] http/tests/media/media-source/mediasource-config-change-mp4-v-bitrate.html failing after r173318
https://bugs.webkit.org/show_bug.cgi?id=136676
Reviewed by Eric Carlson.
Source/WebCore:
Revert the inadvertant conditional change introduced in r173318.
- Modules/mediasource/MediaSource.cpp:
(WebCore::MediaSource::setDurationInternal):
LayoutTests:
- platform/mac/TestExpectations:
- 5:05 PM Changeset in webkit [173453] by
-
- 4 edits in trunk/Source/WebCore
Unreviewed build fix for Windows.
- platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp:
- platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
- platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:
- 4:31 PM Changeset in webkit [173452] by
-
- 7 edits in trunk
iOS Simulator: run-webkit-tests chokes on unterminated UTF-8 when writing a test result
https://bugs.webkit.org/show_bug.cgi?id=135551
Reviewed by Daniel Bates.
Prevent printing invalid Unicode strings going to stderr.
Also, make filesystem.py more tolerant about receiving
Unicode (encoded as UTF-8) when writing to files, in the
rare case that an NSError description will make it to
stderr, such as -[LTRelayController createUniqueApp].
- LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
(-[LTRelayController launchSimulator]): Removed.
(-[LTRelayController createUniqueApp]):
Don't explicitly try to uninstall the app. It is automatically handled
when installing an app with the same bundle identifier.
(-[LTRelayController start]):
(-[LTRelayController bootDevice]): Removed.
The device already boots as a part of starting the simulator. Attempting
to boot a second time may cause spurious stderr output.
- Scripts/webkitpy/port/driver.py:
(IOSSimulatorDriver._setup_environ_for_driver):
Explicitly set DEVELOPER_DIR once so xcode-select isn't called.
Open the iOS Simulator once instead of the LayoutTestRelay trying
to do it.
- Scripts/webkitpy/port/ios.py:
(IOSSimulatorPort._get_crash_log):
Make sure stderr is at least an empty string.
(IOSSimulatorPort):
(IOSSimulatorPort.developer_dir):
New property for setting up DEVELOPER_DIR in the driver environment.
- 4:21 PM Changeset in webkit [173451] by
-
- 5 edits in tags/Safari-600.1.22/Source
Versioning.
- 4:16 PM Changeset in webkit [173450] by
-
- 5 edits in trunk/Source/WebKit2
REGRESSION (WebKit2): -webkit-touch-callout: none has no effect.
https://bugs.webkit.org/show_bug.cgi?id=136685
rdar://problem/17629840
Reviewed by Benjamin Poulain.
We need to check if the touch callout is enabled for the element before starting
the long press gesture.
The information about the touch callout is returned together with the rest of data
returned by the InteractionInformationAtPosition.
- Shared/InteractionInformationAtPosition.cpp:
(WebKit::InteractionInformationAtPosition::encode):
(WebKit::InteractionInformationAtPosition::decode):
- Shared/InteractionInformationAtPosition.h:
(WebKit::InteractionInformationAtPosition::InteractionInformationAtPosition):
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _actionForLongPress]):
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::getPositionInformation):
- 4:12 PM Changeset in webkit [173449] by
-
- 1 copy in tags/Safari-600.1.22
New Tag.
- 4:04 PM Changeset in webkit [173448] by
-
- 3 edits in trunk/Tools
Clean up the MiniBrowser Xcode project
https://bugs.webkit.org/show_bug.cgi?id=136684
Reviewed by Tim Horton.
- MiniBrowser/Configurations/Base.xcconfig: Enabled warnings recommended by Xcode 6.
- MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: Removed explicit linking against
WebKit2.framework. Upgraded project file version.
- 4:03 PM Changeset in webkit [173447] by
-
- 5 edits in branches/safari-600.1-branch/Source
Versioning.
- 3:52 PM Changeset in webkit [173446] by
-
- 2 edits in trunk/LayoutTests
Unskip two snapshotting tests that work for me consistently locally.
- platform/mac-wk2/TestExpectations:
- 3:47 PM Changeset in webkit [173445] by
-
- 3 edits in trunk/Source/WebCore
FrameLoader::prepareForHistoryNavigation is unused
https://bugs.webkit.org/show_bug.cgi?id=136683
Reviewed by Tim Horton.
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::prepareForHistoryNavigation): Deleted.
- loader/FrameLoader.h: Removed the declaration.
- 2:58 PM Changeset in webkit [173444] by
-
- 4 edits4 adds in trunk
[CSS Grid Layout] Ignore ::first-letter pseudo-element
https://bugs.webkit.org/show_bug.cgi?id=136625
Reviewed by Darin Adler.
Source/WebCore:
According to the spec the ::first-letter pseudo-element do not apply to
grid containers (neither to flexboxes).
Fixed issue in RenderBlock::getFirstLetter() that applies to both grids
and flexboxes. Basically if the grid's or flexbox's container was
defining the ::first-line pseudo-element and the grid or flexbox itself
too, the value from the grid or flexbox was being applied to the items.
Added the proper check to avoid this.
Added two new tests for grid and modified one flexbox test to cover the
issue explained above.
Tests: css3/flexbox/flexbox-ignore-container-firstLetter.html
fast/css-grid-layout/grid-container-ignore-first-letter.html
fast/css-grid-layout/grid-item-first-letter-valid.html
- rendering/RenderBlock.cpp:
(WebCore::isRenderBlockFlowOrRenderButton): New method refactoring
similar calls through the source code.
(WebCore::RenderBlock::firstLineBlock): Use
isRenderBlockFlowOrRenderButton().
(WebCore::findFirstLetterBlock): Modify it to use
isRenderBlockFlowOrRenderButton() in order to include grids and not only
check flexboxes.
(WebCore::RenderBlock::getFirstLetter): Use
isRenderBlockFlowOrRenderButton().
(WebCore::RenderBlock::updateFirstLetter): Early return if
firstLetterContainer is null (in the case of flexboxes or grids).
LayoutTests:
- css3/flexbox/flexbox-ignore-container-firstLetter.html: Modify test,
in order to actually check that the ::first-letter in a regular
container is ignored in the flexbox.
- fast/css-grid-layout/grid-container-ignore-first-letter-expected.txt: Added.
- fast/css-grid-layout/grid-container-ignore-first-letter.html: Added.
- fast/css-grid-layout/grid-item-first-letter-valid-expected.txt: Added.
- fast/css-grid-layout/grid-item-first-letter-valid.html: Added.
- 2:49 PM Changeset in webkit [173443] by
-
- 12 edits in trunk/Source
Disable the "unreachable-code" warning
https://bugs.webkit.org/show_bug.cgi?id=136677
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-09-09
Reviewed by Darin Adler.
Source/JavaScriptCore:
- Configurations/Base.xcconfig:
Source/ThirdParty:
- gtest/xcode/Config/General.xcconfig:
Source/WebInspectorUI:
- Configurations/Base.xcconfig:
Source/WebKit/mac:
- Configurations/Base.xcconfig:
Source/WebKit2:
- Configurations/Base.xcconfig:
Source/WTF:
The warning causes various build errors depending on which Clang you are using.
For example, with recent clangs, it breaks all the ARCHS dependent code like this:
if (sizeof(uintptr_t) == 4)
Something for 32 bits.
else
Somethign for 64 bits.
- Configurations/Base.xcconfig:
- 2:43 PM Changeset in webkit [173442] by
-
- 2 edits in trunk/Source/WebKit2
[Cocoa] -[WKBackForwardList backList] contains an unnecessary nil check
https://bugs.webkit.org/show_bug.cgi?id=136680
Reviewed by Anders Carlsson.
- UIProcess/API/Cocoa/WKBackForwardList.mm:
(-[WKBackForwardList backList]): Removed nil check.
(-[WKBackForwardList forwardList]): Ditto.
- 2:03 PM Changeset in webkit [173441] by
-
- 8 edits14 adds in trunk
Add support for :read-write/:read-only matching editable content
https://bugs.webkit.org/show_bug.cgi?id=136668
Reviewed by Antti Koivisto.
Source/WebCore:
This is the second part of the update of :read-write/:read-only to the latest spec
(http://www.whatwg.org/specs/web-apps/current-work/multipage/scripting.html#selectors).
The selectors :read-write/:read-only should match elements that are editable. The exact definition is:
"elements that are editing hosts or editable and are neither input elements nor textarea elements".
Matching that definition is really easy. It was done by updating HTMLElement's matchesReadWritePseudoClass()
to consider both contentEditable and designMode.
The tricky part is making that efficient in all cases. Matching contentEditable is horribly inefficient
compared to the other primitives. We don't want to execute that for every element.
Since matchesReadWritePseudoClass() was used by the theming code, that code was adjusted to
-Avoid calling that on regular HTMLElement, limiting the query to <input> and <textarea> where it is fast.
-Avoid the call entirely when possible.
Tests: fast/css/read-only-read-write-contenteditable-basics.html
fast/css/read-only-read-write-designmode-basics.html
fast/css/read-only-read-write-webkit-user-modify.html
fast/selectors/read-only-read-write-contenteditable-basics.html
fast/selectors/read-only-read-write-contenteditable-svg-foreignObject.html
fast/selectors/read-only-read-write-designmode-basics.html
fast/selectors/read-only-read-write-style-update.html
- html/HTMLElement.cpp:
(WebCore::contentEditableType):
This code is a generalization of the code that was in HTMLElement::contentEditable().
It is used by both matchesReadWritePseudoClass() and contentEditable() to determine
a valid state from the value of contentEditable.
(WebCore::HTMLElement::matchesReadWritePseudoClass):
Per the definition of editable content, we first check if the current element is an editing host,
if not we look for an editing host. If there are none, test for designMode.
(WebCore::HTMLElement::contentEditable):
(WebCore::RenderTheme::isReadOnlyControl):
The old definition would only match <input> and <textarea>. The code was updated to keep the same
behavior after matchesReadWritePseudoClass() is udpated. This avoids the performance problem of calling
matchesReadWritePseudoClass() on regular HTMLElement.
- platform/ControlStates.h:
ReadOnlyState was only used by ThemeMac for convertControlStatesToThemeDrawState().
In turn, convertControlStatesToThemeDrawState() was only used for painting
"-webkit-inner-spin-button". Buttons are not read-write to begin with.
The whole code looks like legacy from styling of input elements and was removed.
Removing ReadOnlyState removes the expensive part of extractControlStatesForRenderer().
- html/HTMLElement.h:
- html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::readOnlyAttributeChanged):
- platform/mac/ThemeMac.mm:
(WebCore::convertControlStatesToThemeDrawState):
- rendering/RenderTheme.cpp:
(WebCore::RenderTheme::extractControlStatesForRenderer):
LayoutTests:
- fast/css/read-only-read-write-contenteditable-basics-expected.html: Added.
- fast/css/read-only-read-write-contenteditable-basics.html: Added.
- fast/css/read-only-read-write-designmode-basics-expected.html: Added.
- fast/css/read-only-read-write-designmode-basics.html: Added.
- fast/css/read-only-read-write-webkit-user-modify-expected.txt: Added.
- fast/css/read-only-read-write-webkit-user-modify.html: Added.
- fast/selectors/read-only-read-write-contenteditable-basics-expected.txt: Added.
- fast/selectors/read-only-read-write-contenteditable-basics.html: Added.
- fast/selectors/read-only-read-write-contenteditable-svg-foreignObject-expected.txt: Added.
- fast/selectors/read-only-read-write-contenteditable-svg-foreignObject.html: Added.
- fast/selectors/read-only-read-write-designmode-basics-expected.txt: Added.
- fast/selectors/read-only-read-write-designmode-basics.html: Added.
- fast/selectors/read-only-read-write-style-update-expected.txt: Added.
- fast/selectors/read-only-read-write-style-update.html: Added.
- 1:56 PM Changeset in webkit [173440] by
-
- 2 edits in trunk/LayoutTests
[Mac] Unreviewed gardening. Mark two media-source tests as failing.
- platform/mac/TestExpectations:
- 1:30 PM Changeset in webkit [173439] by
-
- 2 edits in trunk/Source/WebCore
[MSE] media/media-source tests broken after r173318
https://bugs.webkit.org/show_bug.cgi?id=136675
Reviewed by Eric Carlson.
Fixes the following tests:
http/tests/media/media-source/mediasource-play.html
http/tests/media/media-source/mediasource-remove.html
media/media-source/media-source-monitor-source-buffers.html
media/media-source/media-source-overlapping-append-buffered.html
In r173318, a for loop was converted to a C++11 loop, but in so doing, left
pre-initialized, empty values in the beginning of returned Vector, which caused
the calling algorithm to miscalculate the amount of data buffered by the media
source.
- Modules/mediasource/MediaSource.cpp:
(WebCore::MediaSource::activeRanges):
- 1:12 PM Changeset in webkit [173438] by
-
- 3 edits in trunk/Tools
svn-{apply, unapply} fails to apply/unapply SVN 1.7 patch that adds new file with property change
https://bugs.webkit.org/show_bug.cgi?id=136379
Patch by Daniel Bates <dbates@webkit.org> on 2014-09-09
Reviewed by David Kilzer.
Fixes an issue where svn-{apply, unapply} fail to apply or unapply, respectively,
a patch generated using Subversion 1.7.4 (r1295709) that both adds a new file F
and sets a property on F (say, the executable bit).
- Scripts/svn-apply:
(patch): Only add file if the diff has text chunks.
- Scripts/svn-unapply:
(patch): Only delete added file if the diff has text chunks.
- 12:51 PM Changeset in webkit [173437] by
-
- 2 edits in trunk/LayoutTests
Fix syntax on some expected failures.
- platform/mac/TestExpectations:
- 12:46 PM Changeset in webkit [173436] by
-
- 53 edits in trunk/Source/WebInspectorUI
Web Inspector: Fix ESLint no-trailing-spaces warnings
https://bugs.webkit.org/show_bug.cgi?id=136657
Reviewed by NOBODY (OOPS!).
- .eslintrc:
- UserInterface/Base/DOMUtilities.js:
- UserInterface/Base/URLUtilities.js:
(relativePath):
- UserInterface/Base/Utilities.js:
- UserInterface/Controllers/CodeMirrorColorEditingController.js:
(WebInspector.CodeMirrorColorEditingController.prototype._colorPickerColorChanged):
- UserInterface/Controllers/CodeMirrorDragToAdjustNumberController.js:
(WebInspector.CodeMirrorDragToAdjustNumberController.prototype.set enabled):
(WebInspector.CodeMirrorDragToAdjustNumberController.prototype.dragToAdjustControllerCanAdjustObjectAtPoint):
- UserInterface/Controllers/CodeMirrorEditingController.js:
(WebInspector.CodeMirrorEditingController.prototype.handleKeydownEvent):
- UserInterface/Controllers/CodeMirrorGradientEditingController.js:
(WebInspector.CodeMirrorGradientEditingController.prototype.gradientSliderStopWasSelected):
- UserInterface/Controllers/CodeMirrorTokenTrackingController.js:
(WebInspector.CodeMirrorTokenTrackingController.prototype._processJavaScriptExpression):
- UserInterface/Controllers/DragToAdjustController.js:
(WebInspector.DragToAdjustController.prototype.set active):
(WebInspector.DragToAdjustController.prototype._setDragging):
(WebInspector.DragToAdjustController.prototype._setTracksMouseClickAndDrag):
- UserInterface/External/Esprima/esprima.js:
- UserInterface/Models/ApplicationCacheFrame.js:
(WebInspector.ApplicationCacheFrame):
- UserInterface/Models/ApplicationCacheManifest.js:
(WebInspector.ApplicationCacheManifest):
(WebInspector.ApplicationCacheManifest.prototype.get manifestURL):
- UserInterface/Models/CookieStorageObject.js:
- UserInterface/Models/DOMSearchMatchObject.js:
(WebInspector.DOMSearchMatchObject.prototype.get title):
(WebInspector.DOMSearchMatchObject.titleForDOMNode):
- UserInterface/Models/DatabaseObject.js:
(WebInspector.DatabaseObject.prototype.getTableNames):
- UserInterface/Models/DatabaseTableObject.js:
(WebInspector.DatabaseTableObject):
- UserInterface/Models/Gradient.js:
(WebInspector.Gradient.fromString):
(WebInspector.RadialGradient.prototype.toString):
- UserInterface/Models/IssueMessage.js:
(WebInspector.IssueMessage.prototype._formatTextIfNecessary):
- UserInterface/Models/Resource.js:
(WebInspector.Resource.prototype.getImageSize.imageDidLoad):
(WebInspector.Resource.prototype.getImageSize):
- UserInterface/Models/Script.js:
(WebInspector.Script.prototype._makeSyntaxTree):
- UserInterface/Models/SourceCodeLocation.js:
(WebInspector.SourceCodeLocation.prototype.hasDifferentDisplayLocation):
- UserInterface/Models/TextMarker.js:
- UserInterface/Protocol/PageObserver.js:
- UserInterface/Views/ApplicationCacheDetailsSidebarPanel.js:
(WebInspector.ApplicationCacheDetailsSidebarPanel.prototype.set applicationCacheFrame):
(WebInspector.ApplicationCacheDetailsSidebarPanel.prototype.refresh):
(WebInspector.ApplicationCacheDetailsSidebarPanel.prototype._networkStateUpdated):
- UserInterface/Views/ApplicationCacheFrameTreeElement.js:
(WebInspector.ApplicationCacheFrameTreeElement):
- UserInterface/Views/ApplicationCacheManifestTreeElement.js:
(WebInspector.ApplicationCacheManifestTreeElement.prototype.get name):
(WebInspector.ApplicationCacheManifestTreeElement.prototype.get secondaryName):
- UserInterface/Views/ButtonNavigationItem.js:
(WebInspector.ButtonNavigationItem):
- UserInterface/Views/ColorPicker.js:
- UserInterface/Views/ColorWheel.js:
(WebInspector.ColorWheel.prototype._draw):
- UserInterface/Views/CompletionSuggestionsView.js:
(WebInspector.CompletionSuggestionsView.prototype.show):
- UserInterface/Views/ConsoleCommand.js:
- UserInterface/Views/ConsolePrompt.js:
- UserInterface/Views/ContentFlowTreeElement.js:
- UserInterface/Views/CookieStorageTreeElement.js:
(WebInspector.CookieStorageTreeElement):
- UserInterface/Views/EventListenerSectionGroup.js:
(WebInspector.EventListenerSectionGroup.prototype._functionTextOrLink):
- UserInterface/Views/GeneralTreeElementPathComponent.js:
- UserInterface/Views/GoToLineDialog.js:
(WebInspector.GoToLineDialog.prototype._handleKeydownEvent):
- UserInterface/Views/LayerTreeDataGridNode.js:
(WebInspector.LayerTreeDataGridNode.prototype._makeNameCell):
- UserInterface/Views/LayerTreeSidebarPanel.js:
- UserInterface/Views/LogContentView.js:
(WebInspector.LogContentView.prototype._highlightRanges):
- UserInterface/Views/NavigationBar.js:
(WebInspector.NavigationBar):
- UserInterface/Views/NavigationItem.js:
(WebInspector.NavigationItem):
- UserInterface/Views/ResourceDetailsSidebarPanel.js:
(WebInspector.ResourceDetailsSidebarPanel.prototype._refreshImageSizeSection):
- UserInterface/Views/ScopeBar.js:
- UserInterface/Views/ScopeBarItem.js:
(WebInspector.ScopeBarItem):
- UserInterface/Views/ScopeChainDetailsSidebarPanel.js:
(WebInspector.ScopeChainDetailsSidebarPanel):
- UserInterface/Views/ScriptTimelineDataGridNode.js:
(WebInspector.ScriptTimelineDataGridNode.prototype.updateRangeTimes):
- UserInterface/Views/ScriptTreeElement.js:
(WebInspector.ScriptTreeElement):
- UserInterface/Views/SearchBar.js:
- UserInterface/Views/SearchResultTreeElement.js:
(WebInspector.SearchResultTreeElement.truncateAndHighlightTitle):
- UserInterface/Views/Slider.js:
Conflicts:
Source/WebInspectorUI/UserInterface/Controllers/CodeMirrorColorEditingController.js
- 12:28 PM WebKitGTK/KeepingTheTreeGreen edited by
- (diff)
- 12:27 PM WebKitGTK/KeepingTheTreeGreen edited by
- (diff)
- 12:25 PM Changeset in webkit [173435] by
-
- 4 edits in trunk
[GTK] Unreviewed GTK gardening.
Tools:
- Scripts/run-gtk-tests:
(TestRunner): Skip TestSSL:webkit2/WebKitWebView/ssl (fails since r173423).
LayoutTests:
Update some expectations for new cases.
- 12:07 PM Changeset in webkit [173434] by
-
- 2 edits in trunk/LayoutTests
Skip some WebGL tests failing on Mavericks and MountainLion bots.
- platform/mac/TestExpectations:
- 11:38 AM WebKitGTK/KeepingTheTreeGreen edited by
- (diff)
- 11:27 AM WebKitGTK/KeepingTheTreeGreen edited by
- (diff)
- 10:34 AM Changeset in webkit [173433] by
-
- 15 edits in trunk/Source/WebInspectorUI
Web Inspector: Fix ESLint eqeqeq warnings
https://bugs.webkit.org/show_bug.cgi?id=136658
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-09-09
Reviewed by Andy Estes.
- UserInterface/Controllers/DOMTreeManager.js:
(WebInspector.DOMTreeManager.prototype.mycallback):
(WebInspector.DOMTreeManager.prototype.searchResult):
- UserInterface/Models/Breakpoint.js:
(WebInspector.Breakpoint.prototype.clearActions):
- UserInterface/Models/DOMTree.js:
(WebInspector.DOMTree.prototype._requestRootDOMNode.rootObjectAvailable):
(WebInspector.DOMTree.prototype._requestRootDOMNode.rootDOMNodeAvailable):
(WebInspector.DOMTree.prototype._requestRootDOMNode.dispatchCallbacks):
(WebInspector.DOMTree.prototype._requestRootDOMNode):
- UserInterface/Models/ProbeSet.js:
(WebInspector.ProbeSet.prototype.removeProbe):
- UserInterface/Models/ProbeSetDataTable.js:
(WebInspector.ProbeSetDataTable.prototype.addSampleForProbe):
- UserInterface/Views/CodeMirrorAdditions.js:
- UserInterface/Views/CookieStorageContentView.js:
(WebInspector.CookieStorageContentView.prototype._filterCookies):
(WebInspector.cookieMatchesResourceURL):
- UserInterface/Views/DOMStorageContentView.js:
(WebInspector.DOMStorageContentView.prototype._editingCallback):
- UserInterface/Views/DOMTreeElement.js:
(WebInspector.DOMTreeElement):
(WebInspector.DOMTreeElement.prototype._updateChildren):
(WebInspector.DOMTreeElement.prototype._startEditingTarget):
(WebInspector.DOMTreeElement.prototype._textNodeEditingCommitted):
- UserInterface/Views/DataGrid.js:
(WebInspector.DataGrid.prototype._resizerDragging):
- UserInterface/Views/DatabaseContentView.js:
(WebInspector.DatabaseContentView.prototype._queryError):
- UserInterface/Views/DetailsSectionSimpleRow.js:
(.valueElementClicked):
(WebInspector.DetailsSectionSimpleRow):
- UserInterface/Views/Slider.js:
(WebInspector.Slider.prototype.get _maxX):
- UserInterface/Views/TreeOutline.js:
(TreeElement.prototype.expand):
- 10:31 AM Changeset in webkit [173432] by
-
- 7 edits in trunk/Source/WebInspectorUI
Web Inspector: Fix ESLint no-extra-semi
https://bugs.webkit.org/show_bug.cgi?id=136666
Reviewed by Andy Estes.
Add explicit no-extra-semi rule to .eslintrc. Remove all unnecessary
semicolons as identified by ESLint.
- .eslintrc:
- Tools/PrettyPrinting/Formatter.js:
(Formatter):
- UserInterface/Controllers/Formatter.js:
(Formatter):
- UserInterface/Models/Resource.js:
(WebInspector.Resource.prototype.getImageSize.imageDidLoad):
(WebInspector.Resource.prototype.getImageSize):
- UserInterface/Views/LayerTreeSidebarPanel.js:
(WebInspector.LayerTreeSidebarPanel.prototype._sortDataGrid.comparator):
(WebInspector.LayerTreeSidebarPanel.prototype._sortDataGrid):
- UserInterface/Views/ObjectPropertiesSection.js:
(WebInspector.ObjectPropertyTreeElement.prototype.callback):
(WebInspector.ObjectPropertyTreeElement.prototype.applyExpression):
- 10:29 AM Changeset in webkit [173431] by
-
- 73 edits in trunk/Source/WebInspectorUI
Web Inspector: Fix ESLint semi (missing semicolon)
https://bugs.webkit.org/show_bug.cgi?id=136665
Reviewed by Andy Estes.
Add missing semicolons as identified by ESLint. Add explicit semi rule to .eslintrc.
- .eslintrc:
- Tools/PrettyPrinting/FormatterContentBuilder.js:
- Tools/PrettyPrinting/FormatterDebug.js:
(Formatter.prototype.debug):
- UserInterface/Base/DOMUtilities.js:
- UserInterface/Base/EventListener.js:
(WebInspector.EventListener):
(WebInspector.EventListener.prototype.this._callback):
(WebInspector.EventListener.prototype.connect):
- UserInterface/Base/Object.js:
(WebInspector.Object):
(WebInspector.Object.addConstructorFunctions):
(WebInspector.Event):
- UserInterface/Base/URLUtilities.js:
(WebInspector.displayNameForURL):
(WebInspector.displayNameForHost):
- UserInterface/Base/Utilities.js:
(.):
- UserInterface/Controllers/BranchManager.js:
(WebInspector.BranchManager):
- UserInterface/Controllers/CSSStyleManager.js:
(WebInspector.CSSStyleManager):
- UserInterface/Controllers/CodeMirrorColorEditingController.js:
(WebInspector.CodeMirrorColorEditingController):
- UserInterface/Controllers/CodeMirrorEditingController.js:
(WebInspector.CodeMirrorEditingController):
- UserInterface/Controllers/CodeMirrorGradientEditingController.js:
(WebInspector.CodeMirrorGradientEditingController):
(WebInspector.CodeMirrorGradientEditingController.prototype.popoverDidPresent):
- UserInterface/Controllers/CodeMirrorTokenTrackingController.js:
- UserInterface/Controllers/FormatterContentBuilder.js:
- UserInterface/Controllers/FormatterSourceMap.js:
(WebInspector.FormatterSourceMap.fromBuilder):
- UserInterface/Controllers/IssueManager.js:
(WebInspector.IssueManager):
- UserInterface/Controllers/LogManager.js:
(WebInspector.LogManager):
- UserInterface/Models/BreakpointAction.js:
- UserInterface/Models/CSSCompletions.js:
(WebInspector.CSSCompletions):
(WebInspector.CSSCompletions.requestCSSNameCompletions):
- UserInterface/Models/CSSKeywordCompletions.js:
(WebInspector.CSSKeywordCompletions.forProperty):
(WebInspector.CSSKeywordCompletions.isColorAwareProperty):
- UserInterface/Models/CSSStyleSheet.js:
(WebInspector.CSSStyleSheet.resetUniqueDisplayNameNumbers):
- UserInterface/Models/Color.js:
(WebInspector.Color):
(WebInspector.Color.fromString):
- UserInterface/Models/DOMNode.js:
(WebInspector.DOMNode):
- UserInterface/Models/DOMSearchMatchObject.js:
(WebInspector.DOMSearchMatchObject.titleForDOMNode):
- UserInterface/Models/ExecutionContext.js:
(WebInspector.ExecutionContext.supported):
- UserInterface/Models/Gradient.js:
(WebInspector.LinearGradient):
(WebInspector.LinearGradient.linearGradientWithComponents):
(WebInspector.RadialGradient):
(WebInspector.RadialGradient.radialGradientWithComponents):
- UserInterface/Models/IssueMessage.js:
(WebInspector.IssueMessage):
- UserInterface/Models/ReplaySessionSegment.js:
(WebInspector.IncompleteSessionSegment):
- UserInterface/Models/Resource.js:
(WebInspector.Resource.prototype.associateWithScript):
- UserInterface/Models/Script.js:
(WebInspector.Script.resetUniqueDisplayNameNumbers):
- UserInterface/Models/Setting.js:
(WebInspector.Setting):
- UserInterface/Models/SourceCodePosition.js:
(WebInspector.SourceCodePosition):
- UserInterface/Models/SourceMap.js:
(WebInspector.SourceMap):
(WebInspector.SourceMap.StringCharIterator):
- UserInterface/Models/TextMarker.js:
(WebInspector.TextMarker):
- UserInterface/Models/TextRange.js:
(WebInspector.TextRange):
- UserInterface/Protocol/InspectorFrontendHostStub.js:
(.WebInspector.InspectorFrontendHostStub):
- UserInterface/Protocol/MessageDispatcher.js:
(WebInspector.dispatchNextQueuedMessageFromBackend):
(WebInspector.dispatchMessageFromBackend):
- UserInterface/Protocol/RemoteObject.js:
(WebInspector.RemoteObject):
(WebInspector.RemoteObject.fromPrimitiveValue):
(WebInspector.RemoteObject.fromLocalObject):
(WebInspector.RemoteObject.resolveNode):
(WebInspector.RemoteObject.fromPayload):
(WebInspector.RemoteObject.type):
(WebInspector.RemoteObjectProperty):
(WebInspector.RemoteObjectProperty.fromPrimitiveValue):
(WebInspector.LocalJSONObject):
- UserInterface/Protocol/ReplayObserver.js:
(WebInspector.ReplayPosition.fromProtocol):
- UserInterface/Views/BreakpointActionView.js:
(WebInspector.BreakpointActionView.displayStringForType):
- UserInterface/Views/CSSStyleDeclarationTextEditor.js:
(WebInspector.CSSStyleDeclarationTextEditor.prototype.if):
- UserInterface/Views/ClusterContentView.js:
(WebInspector.ClusterContentView.prototype.goBack):
(WebInspector.ClusterContentView.prototype.goForward):
- UserInterface/Views/CodeMirrorAdditions.js:
- UserInterface/Views/ColorWheel.js:
(WebInspector.ColorWheel):
- UserInterface/Views/ConsoleMessage.js:
(WebInspector.ConsoleMessage):
(WebInspector.ConsoleMessage.create):
- UserInterface/Views/ConsoleMessageImpl.js:
(WebInspector.ConsoleMessageImpl):
- UserInterface/Views/ContextMenu.js:
(WebInspector.ContextMenuItem):
(WebInspector.ContextSubMenuItem):
(WebInspector.ContextMenu):
(WebInspector.ContextMenu.Provider):
(WebInspector.ContextMenu.registerProvider):
(WebInspector.contextMenuItemSelected):
(WebInspector.contextMenuCleared):
- UserInterface/Views/DOMTreeElement.js:
(WebInspector.DOMTreeElement):
- UserInterface/Views/DOMTreeOutline.js:
(WebInspector.DOMTreeOutline):
- UserInterface/Views/DOMTreeUpdater.js:
(WebInspector.DOMTreeUpdater):
- UserInterface/Views/DatabaseContentView.js:
(WebInspector.DatabaseContentView):
- UserInterface/Views/EditingSupport.js:
(WebInspector.isBeingEdited):
(WebInspector.markBeingEdited):
(WebInspector.isEditingAnyField):
(WebInspector.isEventTargetAnEditableField):
(WebInspector.EditingConfig):
(WebInspector.startEditing):
- UserInterface/Views/EventListenerSection.js:
(WebInspector.EventListenerSection):
- UserInterface/Views/EventListenerSectionGroup.js:
(WebInspector.EventListenerSectionGroup):
- UserInterface/Views/FindBanner.js:
- UserInterface/Views/GeneralTreeElement.js:
(WebInspector.GeneralTreeElement):
- UserInterface/Views/GoToLineDialog.js:
(WebInspector.GoToLineDialog):
- UserInterface/Views/IndeterminateProgressSpinner.js:
(WebInspector.IndeterminateProgressSpinner):
- UserInterface/Views/LayoutTimelineDataGrid.js:
(WebInspector.LayoutTimelineDataGrid):
- UserInterface/Views/LogContentView.js:
(WebInspector.LogContentView):
- UserInterface/Views/NavigationItem.js:
- UserInterface/Views/ObjectPropertiesSection.js:
(WebInspector.ObjectPropertiesSection):
(WebInspector.ObjectPropertiesSection.CompareProperties):
(WebInspector.ObjectPropertyTreeElement):
- UserInterface/Views/ProbeSetDetailsSection.js:
- UserInterface/Views/PropertiesSection.js:
(WebInspector.PropertiesSection):
- UserInterface/Views/ResourceTreeElement.js:
(WebInspector.ResourceTreeElement.compareResourceTreeElements):
(WebInspector.ResourceTreeElement.compareFolderAndResourceTreeElements):
- UserInterface/Views/ScriptTimelineDataGrid.js:
(WebInspector.ScriptTimelineDataGrid):
- UserInterface/Views/SearchResultTreeElement.js:
(WebInspector.SearchResultTreeElement.truncateAndHighlightTitle):
- UserInterface/Views/TimelineRuler.js:
(WebInspector.TimelineRuler):
(WebInspector.TimelineRuler.prototype.get allowsClippedLabels):
(WebInspector.TimelineRuler.prototype._handleMouseUp):
- UserInterface/Views/Toolbar.js:
- UserInterface/Views/TreeOutline.js:
(TreeOutline.prototype.appendChild):
(TreeOutline.prototype.insertChild):
(TreeOutline.prototype.removeChildAtIndex):
(TreeOutline.prototype.removeChild):
(TreeOutline.prototype.removeChildren):
(TreeOutline.prototype.removeChildrenRecursive):
(TreeOutline.prototype._rememberTreeElement):
(TreeOutline.prototype._forgetTreeElement):
(TreeOutline.prototype._forgetChildrenRecursive):
(TreeOutline.prototype.getCachedTreeElement):
(TreeOutline.prototype.findTreeElement):
(TreeOutline.prototype._treeElementDidChange):
(TreeOutline.prototype.treeElementFromPoint):
(TreeOutline.prototype._treeKeyDown):
(TreeOutline.prototype.expand):
(TreeOutline.prototype.collapse):
(TreeOutline.prototype.revealed):
(TreeOutline.prototype.reveal):
(TreeOutline.prototype.select):
(TreeOutline.prototype.revealAndSelect):
(TreeElement.prototype._attach):
(TreeElement.prototype._detach):
(TreeElement.treeElementMouseDown):
(TreeElement.treeElementToggled):
(TreeElement.treeElementDoubleClicked):
(TreeElement.prototype.collapse):
(TreeElement.prototype.collapseRecursively):
(TreeElement.prototype.expand):
(TreeElement.prototype.expandRecursively):
(TreeElement.prototype.hasAncestor):
(TreeElement.prototype.reveal):
(TreeElement.prototype.revealed):
(TreeElement.prototype.selectOnMouseDown):
(TreeElement.prototype.select):
(TreeElement.prototype.revealAndSelect):
(TreeElement.prototype.deselect):
(TreeElement.prototype.onpopulate):
(TreeElement.prototype.traverseNextTreeElement):
(TreeElement.prototype.traversePreviousTreeElement):
(TreeElement.prototype.isEventWithinDisclosureTriangle):
- UserInterface/Views/TreeOutlineDataGridSynchronizer.js:
(WebInspector.TreeOutlineDataGridSynchronizer):
- 10:26 AM Changeset in webkit [173430] by
-
- 2 edits in trunk/Tools
Update my email in contributors.json
https://bugs.webkit.org/show_bug.cgi?id=136671
Patch by Christophe Dumez <Chris Dumez> on 2014-09-09
Reviewed by Andreas Kling.
- Scripts/webkitpy/common/config/contributors.json:
- 8:58 AM Changeset in webkit [173429] by
-
- 5 edits in trunk/Source/WebKit2
Make DrawingArea a real MessageReceiver
https://bugs.webkit.org/show_bug.cgi?id=136438
Reviewed by Darin Adler.
- WebProcess/WebPage/DrawingArea.cpp:
(WebKit::DrawingArea::DrawingArea):
(WebKit::DrawingArea::~DrawingArea):
- WebProcess/WebPage/DrawingArea.h:
- WebProcess/WebPage/DrawingArea.messages.in:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
(WebKit::WebPage::~WebPage):
(WebKit::WebPage::didReceiveMessage):
Make DrawingArea a real MessageReceiver instead of a LegacyReceiver that
jumps through WebPage to receive its messages.
- 8:09 AM Changeset in webkit [173428] by
-
- 3 edits4 adds in trunk
AX: HTML5 landmark (and related) elements should not be ignored.
https://bugs.webkit.org/show_bug.cgi?id=135116
Patch by Takeshi Kurosawa <taken.spc@gmail.com> on 2014-09-09
Reviewed by Chris Fleizach.
Make sure following element should not be ignored in computeAccessibilityIsIgnored
- header, aside, address, main, nav, article, section
- dt, dd
Source/WebCore:
Tests: platform/mac/accessibility/descriptionlist-not-ignored.html
platform/mac/accessibility/landmark-not-ignored.html
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::computeAccessibilityIsIgnored):
LayoutTests:
- platform/mac/accessibility/descriptionlist-not-ignored-expected.txt: Added.
- platform/mac/accessibility/descriptionlist-not-ignored.html: Added.
- platform/mac/accessibility/landmark-not-ignored-expected.txt: Added.
- platform/mac/accessibility/landmark-not-ignored.html: Added.
- 4:39 AM Changeset in webkit [173427] by
-
- 3 edits in trunk/Source/WebCore
[CSS Grid Layout] RenderGrid methods should take RenderBox references
https://bugs.webkit.org/show_bug.cgi?id=136630
Reviewed by Darin Adler.
RenderGrid has several methods that take pointers to RenderBox
instances but the body of those methods assumes that the objects
will never be NULL. We should replace them by references.
- rendering/RenderGrid.cpp:
(WebCore::RenderGrid::computeUsedBreadthOfGridTracks):
(WebCore::RenderGrid::logicalContentHeightForChild):
(WebCore::RenderGrid::minContentForChild):
(WebCore::RenderGrid::maxContentForChild):
(WebCore::RenderGrid::resolveContentBasedTrackSizingFunctions):
(WebCore::RenderGrid::resolveContentBasedTrackSizingFunctionsForItems):
(WebCore::RenderGrid::insertItemIntoGrid):
(WebCore::RenderGrid::placeItemsOnGrid):
(WebCore::RenderGrid::createEmptyGridAreaAtSpecifiedPositionsOutsideGrid):
(WebCore::RenderGrid::placeSpecifiedMajorAxisItemsOnGrid):
(WebCore::RenderGrid::placeAutoMajorAxisItemsOnGrid):
(WebCore::RenderGrid::placeAutoMajorAxisItemOnGrid):
(WebCore::RenderGrid::layoutGridItems):
(WebCore::RenderGrid::cachedGridCoordinate):
(WebCore::RenderGrid::gridAreaBreadthForChild):
(WebCore::RenderGrid::findChildLogicalPosition):
- rendering/RenderGrid.h:
- 3:34 AM Changeset in webkit [173426] by
-
- 2 edits in trunk/Source/WebCore
Remove unnecessary assert that is getting hit in some scenarios.
- platform/network/ResourceResponseBase.cpp:
(WebCore::ResourceResponseBase::certificateInfo):
- 2:22 AM Changeset in webkit [173425] by
-
- 2 edits in trunk/Source/WebCore
Try to fix windows build.
- platform/network/cf/ResourceResponseCFNet.cpp:
(WebCore::ResourceResponse::platformCertificateInfo):
- 1:56 AM Changeset in webkit [173424] by
-
- 3 edits2 adds in trunk
[CSSRegions]Incorrect layout for multicol element transformed into region
https://bugs.webkit.org/show_bug.cgi?id=136459
Reviewed by David Hyatt.
Source/WebCore:
Until we will support the multicolumn region functionality, a multicolumn element
that also has flow-from style is not transformed into a region (https://bugs.webkit.org/show_bug.cgi?id=135153).
However, when a multicolumn element with flow-from style dynamically loses
its multicolumn style while keeping the flow-from style, we have to transform
the element into a region by detaching and attaching the associated DOM node,
in the same way we are proceeding when an element receives a different flow-from style.
Test: fast/regions/multicol/nested-multicol-into-region-dynamic.html
- style/StyleResolveTree.cpp:
(WebCore::Style::determineChange):
LayoutTests:
- fast/regions/multicol/nested-multicol-into-region-dynamic-expected.txt: Added.
- fast/regions/multicol/nested-multicol-into-region-dynamic.html: Added.
- 1:19 AM Changeset in webkit [173423] by
-
- 22 edits1 move in trunk/Source
Pass certificate info as part of ResourceResponse
https://bugs.webkit.org/show_bug.cgi?id=136611
Reviewed by Darin Adler.
Source/WebCore:
The current way of passing certificate info separately from ResourceResponse and then jamming it back
is complex and confusing. This patch makes it a true part of the ResourceResponse.
With this patch we also only create and pass the certificate info object for the main resource. It is
a big and complex object and we never look into it for any other resource type.
- WebCore.exp.in:
- platform/network/ResourceResponseBase.cpp:
(WebCore::ResourceResponseBase::ResourceResponseBase):
Mark initialized for synthetic responses, unitialized for those backed by a platform request.
(WebCore::ResourceResponseBase::initializeCertificateInfo):
Calling this pulls the certificate info out from the platform type.
It shoud only be used for resources that need it.
(WebCore::ResourceResponseBase::certificateInfo):
- platform/network/ResourceResponseBase.h:
(WebCore::ResourceResponseBase::platformCertificateInfo):
(WebCore::ResourceResponseBase::platformSuggestedFileName):
(WebCore::ResourceResponseBase::encode):
(WebCore::ResourceResponseBase::decode):
Encode and decode certificate info if it is present.
- platform/network/cf/ResourceResponse.h:
- platform/network/mac/CertificateInfo.h:
- platform/network/mac/CertificateInfoMac.mm:
(WebCore::CertificateInfo::CertificateInfo):
- platform/network/mac/ResourceResponseMac.mm:
(WebCore::ResourceResponse::platformCertificateInfo):
(WebCore::ResourceResponse::setCertificateChain): Deleted.
(WebCore::ResourceResponse::certificateChain): Deleted.
- platform/network/soup/ResourceResponse.h:
- platform/network/soup/ResourceResponseSoup.cpp:
(WebCore::ResourceResponse::platformCertificateInfo):
Source/WebKit2:
- NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::didReceiveResponseAsync):
Initialize the certificate info only if requested.
- WebProcess/Network/WebResourceLoader.cpp:
(WebKit::WebResourceLoader::didReceiveResponse):
(WebKit::WebResourceLoader::didReceiveResponseWithCertificateInfo): Deleted.
Rename didReceiveResponseWithCertificateInfo -> didReceiveResponse as it is now part of the response.
- WebProcess/Network/WebResourceLoader.h:
- WebProcess/Network/WebResourceLoader.messages.in:
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
Request certificate info for the main resource only.
(WebKit::WebFrameLoaderClient::dispatchDidCommitLoad):
- WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::certificateInfo):
- 12:57 AM Changeset in webkit [173422] by
-
- 2 edits in trunk/Source/WebCore
[CSSRegions] Use C++11 range-based loops in FlowThreadController
https://bugs.webkit.org/show_bug.cgi?id=136634
Reviewed by Andrei Bucur.
No new tests as no new functionality was introduced.
- rendering/FlowThreadController.cpp:
(WebCore::FlowThreadController::ensureRenderFlowThreadWithName):
(WebCore::FlowThreadController::styleDidChange):
(WebCore::FlowThreadController::layoutRenderNamedFlowThreads):
(WebCore::FlowThreadController::updateFlowThreadsChainIfNecessary):
(WebCore::FlowThreadController::updateFlowThreadsNeedingLayout):
(WebCore::FlowThreadController::updateFlowThreadsNeedingTwoStepLayout):
(WebCore::FlowThreadController::resetFlowThreadsWithAutoHeightRegions):
(WebCore::FlowThreadController::updateFlowThreadsIntoMeasureContentPhase):
(WebCore::FlowThreadController::updateFlowThreadsLayerToRegionMappingsIfNeeded):
(WebCore::FlowThreadController::updateNamedFlowsLayerListsIfNeeded):
(WebCore::FlowThreadController::collectFixedPositionedLayers):
(WebCore::FlowThreadController::isAutoLogicalHeightRegionsCountConsistent):
