Timeline



Sep 20, 2014:

2:52 PM Changeset in webkit [173795] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

FTL OSRExit construction should be based on methods that return ExitValues rather than methods that add ExitValues to OSRExit
​https://bugs.webkit.org/show_bug.cgi?id=136978

Reviewed by Dean Jackson.

  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::buildExitArguments):
(JSC::FTL::LowerDFGToLLVM::exitValueForNode):
(JSC::FTL::LowerDFGToLLVM::exitArgument):
(JSC::FTL::LowerDFGToLLVM::addExitArgumentForNode): Deleted.
(JSC::FTL::LowerDFGToLLVM::tryToSetConstantExitArgument): Deleted.
(JSC::FTL::LowerDFGToLLVM::addExitArgument): Deleted.

11:45 AM Changeset in webkit [173794] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

FTL OSR exit should do reboxing and value recovery in the same pass
​https://bugs.webkit.org/show_bug.cgi?id=136977

Reviewed by Oliver Hunt.

It's conceptually simpler to have all of the logic in one place. After the
recover-and-rebox loop is done, all of the exit values are in the form that the baseline
JIT would want them to be in; the only remaining task is to move them into the right
place on the stack after we do all of the necessary stack adjustments.

  • ftl/FTLOSRExitCompiler.cpp:

(JSC::FTL::compileStub):

10:59 AM Changeset in webkit [173793] by fpizlo@apple.com
  • 12 edits in trunk/Source/JavaScriptCore

StorageAccessData should be referenced in a sensible way
​https://bugs.webkit.org/show_bug.cgi?id=136963

Reviewed and rubber stamped by Michael Saboff.

  • dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleGetByOffset):
(JSC::DFG::ByteCodeParser::handlePutByOffset):
(JSC::DFG::ByteCodeParser::handlePutById):

  • dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

  • dfg/DFGConstantFoldingPhase.cpp:

(JSC::DFG::ConstantFoldingPhase::emitGetByOffset):
(JSC::DFG::ConstantFoldingPhase::emitPutByOffset):

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dump):

  • dfg/DFGGraph.h:
  • dfg/DFGNode.h:

(JSC::DFG::Node::convertToGetByOffset):
(JSC::DFG::Node::convertToPutByOffset):
(JSC::DFG::Node::storageAccessData):
(JSC::DFG::Node::storageAccessDataIndex): Deleted.

  • dfg/DFGSafeToExecute.h:

(JSC::DFG::safeToExecute):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileGetByOffset):
(JSC::FTL::LowerDFGToLLVM::compilePutByOffset):

8:34 AM Changeset in webkit [173792] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Option+Click on CSS url(...) should jump to resource view
​https://bugs.webkit.org/show_bug.cgi?id=136965

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-09-20
Reviewed by Timothy Hatcher.

  • UserInterface/Views/CodeMirrorAdditions.js:

When parsing CSS url(...) tokens, the contents of url(...)
are a "string" type, not "atom".

Sep 19, 2014:

11:49 PM Changeset in webkit [173791] by jer.noble@apple.com
  • 4 edits in trunk/Source/WebCore

[EME][Mac] Support secure proof of key release in the com.apple.fps.2_0 keysystem.
​https://bugs.webkit.org/show_bug.cgi?id=136898

Reviewed by Eric Carlson.

Add support for proof of key release to the CDM by supporting a new "mime" type called
"keyrelease". When a session of type "keyrelease" is created, the initData is the server
certificate, the keyMessage contains the first stored proof of key release if present,
and closing the session will remove that proof from storage.

  • platform/graphics/avfoundation/CDMPrivateMediaSourceAVFObjC.mm:

(WebCore::CDMPrivateMediaSourceAVFObjC::supportsKeySystemAndMimeType):

  • platform/graphics/avfoundation/objc/CDMSessionMediaSourceAVFObjC.h:
  • platform/graphics/avfoundation/objc/CDMSessionMediaSourceAVFObjC.mm:

(WebCore::CDMSessionMediaSourceAVFObjC::CDMSessionMediaSourceAVFObjC):
(WebCore::CDMSessionMediaSourceAVFObjC::generateKeyRequest):
(WebCore::CDMSessionMediaSourceAVFObjC::releaseKeys):
(WebCore::sessionStorageDirectory):
(WebCore::CDMSessionMediaSourceAVFObjC::update):
(WebCore::CDMSessionMediaSourceAVFObjC::generateKeyReleaseMessage):

11:02 PM Changeset in webkit [173790] by jer.noble@apple.com
  • 3 edits in trunk/Source/WebCore

[Media][Mac] Buffered range slides around as you resize a window
​https://bugs.webkit.org/show_bug.cgi?id=136960

Reviewed by Dean Jackson.

Rather than using a canvas as the background image for the timeline slider, use a generated SVG image
to represent the buffered ranges.

  • Modules/mediacontrols/mediaControlsApple.css:

(audio::-webkit-media-controls-timeline):

  • Modules/mediacontrols/mediaControlsApple.js:

(Controller.prototype.createControls):
(Controller.prototype.updateProgress):

10:46 PM Changeset in webkit [173789] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

JSStringRef leak on the leaks bot allocation under selectTextWithCriteriaCallback
​https://bugs.webkit.org/show_bug.cgi?id=136974

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-09-19
Reviewed by Chris Fleizach.

  • DumpRenderTree/AccessibilityUIElement.cpp:

(selectTextWithCriteriaCallback):
Be sure to release the string if it was allocated.

8:07 PM Changeset in webkit [173788] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebKit2

WebContent crash in WebKit::WebPage::expandedRangeFromHandle
​https://bugs.webkit.org/show_bug.cgi?id=136969

Reviewed by David Kilzer.

The crash was caused by m_currentBlockSelection and frame.selection().selection().toNormalizedRange()
both being null and the subsequent lines of code assuming currentRange to be not null.

Replace the assertion by an early exit since the range could be null here.

In the future, we should figure out if there are other things we need to do in addition
to checking the nullity when this race condition is hit.

  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::computeExpandAndShrinkThresholdsForHandle):

8:01 PM Changeset in webkit [173787] by rniwa@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Leak of mallocs under StructureSet::OutOfLineList::create
​https://bugs.webkit.org/show_bug.cgi?id=136970

Reviewed by Filip Pizlo.

addOutOfLine should free the old list when expanding the capacity.

  • bytecode/StructureSet.cpp:

(JSC::StructureSet::addOutOfLine):

7:44 PM Changeset in webkit [173786] by ap@apple.com
  • 2 edits in trunk/Tools

build.webkit.org/dashboard: Pending builds don't show up when there is a commit with no comments
​https://bugs.webkit.org/show_bug.cgi?id=136966

Reviewed by Daniel Bates.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:

(Trac.prototype._convertCommitInfoElementToObject): Tolerate these horrible commits.

7:33 PM Changeset in webkit [173785] by gyuyoung.kim@samsung.com
  • 6 edits
    2 adds in trunk

[CoordinatedGraphics][EFL] window.scrollTo(x, y) doesn't work when fixed layout is enabled
​https://bugs.webkit.org/show_bug.cgi?id=136917

Reviewed by Darin Adler.

Source/WebCore:

When fixed layout is enabled, scrollTo doesn't work on EFL port with coordinated graphics.
Since updateScrollbars() doesn't update scroll position when delegatesScrolling() is enabled.
To fix this issue, EFL port should update scroll position based on WK2 port. This patch
update scroll position in FrameView::requestScrollPositionUpdate() as Mac port.

TestWebKitAPI: Tools/TestWebKitAPI/Tests/WebKit2/efl/WKViewScrollTo

  • page/FrameView.cpp:

(WebCore::FrameView::requestScrollPositionUpdate):

Tools:

Added WKViewScrollTo.cpp and scrollTo.html to test this issue.

  • TestWebKitAPI/PlatformEfl.cmake:
  • TestWebKitAPI/Tests/WebKit2/efl/WKViewScrollTo.cpp: Added.

(TestWebKitAPI::didFinishLoadForFrame):
(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebKit2/efl/scrollTo.html: Added.
6:10 PM Changeset in webkit [173784] by Brent Fulgham
  • 11 edits
    4 adds in trunk

Latching in iframes is not working as expected
​https://bugs.webkit.org/show_bug.cgi?id=136729
<rdar://problem/18370549>

Reviewed by Simon Fraser.

Source/WebCore:

Test: platform/mac/fast/scrolling/scrolling-iframe-100pct.html

Correct latching behavior by moving the concept of latching from the event handler to the main frame.
The event handlers are per-document, and can improperly latch to the iframe element (rather than the
scrollable content of the iframe) resulting in incorrect behavior.

Also move the wheel event delta tracking to the main frame, as this is similarly "top-level" in nature.

  • WebCore.vcxproj/WebCore.vcxproj: Add new LatchedState class.
  • WebCore.vcxproj/WebCore.vcxproj.filters: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • page/EventHandler.cpp:

(WebCore::EventHandler::EventHandler): Update constructor after moving some members to the new
LatchedState object.
(WebCore::EventHandler::clear): Call 'clear' on the LatchedState class.
(WebCore::EventHandler::platformRecordWheelEvent): Update for new LatchedState class.
(WebCore::EventHandler::handleWheelEvent): Ditto.
(WebCore::EventHandler::clearLatchedState): Ditto.
(WebCore::EventHandler::defaultWheelEventHandler): Ditto.

  • page/EventHandler.h:
  • page/LatchedState.cpp: Added.

(WebCore::LatchedState::LatchedState):
(WebCore::LatchedState::~LatchedState):
(WebCore::LatchedState::clear):
(WebCore::LatchedState::setWheelEventElement):
(WebCore::LatchedState::setWidgetIsLatched):
(WebCore::LatchedState::setPreviousWheelScrolledElement):
(WebCore::LatchedState::setScrollableContainer):

  • page/LatchedState.h: Added.

(WebCore::LatchedState::wheelEventElement):
(WebCore::LatchedState::frame):
(WebCore::LatchedState::setFrame):
(WebCore::LatchedState::widgetIsLatched):
(WebCore::LatchedState::previousWheelScrolledElement):
(WebCore::LatchedState::scrollableContainer):
(WebCore::LatchedState::startedGestureAtScrollLimit):
(WebCore::LatchedState::setStartedGestureAtScrollLimit):

  • page/MainFrame.cpp:

(WebCore::MainFrame::MainFrame): Update for new members (LatchedState and WheelEventDeltaTracker)

  • page/MainFrame.h:
  • page/mac/EventHandlerMac.mm:

(WebCore::EventHandler::platformPrepareForWheelEvents): Use mainFrame-located latching information.
(WebCore::EventHandler::platformRecordWheelEvent): Use mainFrame-located wheel event delta tracking.
(WebCore::EventHandler::platformCompleteWheelEvent): Make sure to use the latched frame as well as
the latched element so that events get routed properly.
(WebCore::EventHandler::platformCompletePlatformWidgetWheelEvent): Update for new mainFrame
location for latched state information.

LayoutTests:

  • platform/mac/fast/scrolling/scroll-iframe-webkit1-latching-bug-expected.txt: Added.
  • platform/mac/fast/scrolling/scroll-iframe-webkit1-latching-bug.html: Added.
5:11 PM Changeset in webkit [173783] by Chris Dumez
  • 4 edits in trunk/Source/WebCore

Minimize virtual function calls in MarkupAccumulator
​https://bugs.webkit.org/show_bug.cgi?id=136957

Reviewed by Benjamin Poulain.

This patch minimizes the number of virtual function calls in
MarkupAccumulator by:

  • De-virtualizing MarkupAccumulator::appendString(), which is never overridden
  • Having MarkupAccumulator::appendEndTag() virtual function take an Element in argument instead of a Node, as it only applies to Element. Also add a non-virtual overload that takes a Node in argument and that does the isElementNode() check so that we don't need to explicitly do the check at each call site.

No new tests, no behavior change.

  • editing/MarkupAccumulator.cpp:

(WebCore::MarkupAccumulator::appendEndTag):
(WebCore::MarkupAccumulator::shouldSelfClose):
(WebCore::MarkupAccumulator::appendEndMarkup):

  • editing/MarkupAccumulator.h:

(WebCore::MarkupAccumulator::appendEndTag):

  • page/PageSerializer.cpp:

(WebCore::SerializerMarkupAccumulator::appendEndTag):

5:05 PM Changeset in webkit [173782] by psolanki@apple.com
  • 2 edits in trunk/Source/WebCore

[iOS] ASSERTION FAILED: WTF::isMainThread() in WebCore::memoryCache() when using WebKit1
​https://bugs.webkit.org/show_bug.cgi?id=136962
<rdar://problem/18342344>

Reviewed by Geoffrey Garen.

The disk cache monitor callback code was being executed on the main thread. This is wrong
when the web thread is being used in WebKit1 on iOS. The code needs to run on the web
thread. Use WebThreadRun to dispatch the block to the web thread. This works for WebKit2 as
well since when web thread is not being used, WebThreadRun invokes the block directly.

  • loader/cocoa/DiskCacheMonitorCocoa.mm:

(WebCore::DiskCacheMonitor::DiskCacheMonitor):

4:10 PM Changeset in webkit [173781] by matthew_hanson@apple.com
  • 5 edits in branches/safari-600.1.17-branch/Source

Versioning.

4:08 PM Changeset in webkit [173780] by matthew_hanson@apple.com
  • 1 copy in tags/Safari-600.1.17.2

New Tag.

4:05 PM Changeset in webkit [173779] by matthew_hanson@apple.com
  • 1 edit in branches/safari-600.1.17-branch/WebKitLibraries/ChangeLog

Correct Radar to <rdar://problem/18375370>

4:04 PM Changeset in webkit [173778] by matthew_hanson@apple.com
  • 2 edits in branches/safari-600.1.17-branch/WebKitLibraries

Merge r173768. <rdar://problem/173768>

3:59 PM Changeset in webkit [173777] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix; pass duration into the lambda.

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:

(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::durationChanged):

3:30 PM Changeset in webkit [173776] by dino@apple.com
  • 15 edits in trunk/Source

Multithreaded WebGL is a bad idea - remove it
​https://bugs.webkit.org/show_bug.cgi?id=136964
<rdar://problem/18399858>

Reviewed by Brent Fulgham.

Source/WebCore:

We should not allow multithreaded GL access. Remove the
feature.

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::create):

  • page/Settings.in:
  • platform/graphics/GraphicsContext3D.h:

(WebCore::GraphicsContext3D::Attributes::Attributes):

  • platform/graphics/mac/GraphicsContext3DMac.mm:

(WebCore::GraphicsContext3D::GraphicsContext3D):

Source/WebKit/mac:

Remove the setting to allow multithreaded WebGL.

  • WebView/WebPreferenceKeysPrivate.h:
  • WebView/WebPreferences.mm:

(+[WebPreferences initialize]):
(-[WebPreferences multithreadedWebGLEnabled]): Deleted.
(-[WebPreferences setMultithreadedWebGLEnabled:]): Deleted.

  • WebView/WebPreferencesPrivate.h:
  • WebView/WebView.mm:

(-[WebView _preferencesChanged:]):

Source/WebKit2:

Remove the setting to allow multithreaded WebGL.

  • Shared/WebPreferencesDefinitions.h:
  • UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetMultithreadedWebGLEnabled): Deleted.
(WKPreferencesGetMultithreadedWebGLEnabled): Deleted.

  • UIProcess/API/C/WKPreferencesRefPrivate.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):

3:20 PM Changeset in webkit [173775] by dburkart@apple.com
  • 5 edits in branches/Safari-600.1.4.10-branch/Source

Bump versioning

2:41 PM Changeset in webkit [173774] by dburkart@apple.com
  • 1 move in tags/Safari-600.1.4.11.9

Fix tag name typo

2:39 PM Changeset in webkit [173773] by dburkart@apple.com
  • 1 copy in tags/safari-600.1.4.11.9

Tagging 600.1.4.11.9

2:25 PM Changeset in webkit [173772] by dburkart@apple.com
  • 2 edits in branches/safari-600.1.4.11-branch/Source/WebKit2

Merge r173722. <rdar://problem/18389146>

1:53 PM Changeset in webkit [173771] by eric.carlson@apple.com
  • 2 edits in trunk/Source/WebCore

[MSE][Mac] work around AVSampleBufferRenderSynchronizer early callbacks
​https://bugs.webkit.org/show_bug.cgi?id=136958

Reviewed by Jer Noble.

No new tests, we have been unable to come up with a test case that reproduces
this issue reliably.

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:

(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::durationChanged): Set the synchronizer

time to duration when the duration time observer is called early. Add more logging.

1:26 PM Changeset in webkit [173770] by benjamin@webkit.org
  • 3 edits in trunk/Source/WebCore

CSS JIT: allocate the minimum required register count in debug
​https://bugs.webkit.org/show_bug.cgi?id=136933

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2014-09-19
Reviewed by Andreas Kling.

It is hard to catch bugs of minimumRegisterRequirements() because every CPU has a different
number of registers available by default.

This patch aims at improving testing by creating artificial register pressure when running
in debug. When running in debug, we no longer allocate all the available registers right away.
Instead, we allocate just enough to satisfy minimumRegisterRequirements().

The expectation with this is that under-allocation would be detected quicker since they would
crash debug builds.

  • cssjit/RegisterAllocator.h:

(WebCore::RegisterAllocator::RegisterAllocator):
(WebCore::RegisterAllocator::reserveCallerSavedRegisters):
(WebCore::RegisterAllocator::availableRegisterCount): Deleted.

  • cssjit/SelectorCompiler.cpp:

(WebCore::SelectorCompiler::SelectorCodeGenerator::generateSelectorChecker):

1:26 PM Changeset in webkit [173769] by benjamin@webkit.org
  • 3 edits in trunk/Source/WebCore

Add a size check for CSSSelector
​https://bugs.webkit.org/show_bug.cgi?id=136882

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2014-09-19
Reviewed by Christophe Dumez.

  • css/CSSSelector.cpp:
1:19 PM Changeset in webkit [173768] by Brent Fulgham
  • 2 edits in trunk/WebKitLibraries

[Win] Turn off SSE Instructions for 32-bit Builds
​https://bugs.webkit.org/show_bug.cgi?id=136959
<rdar://problem/18375370>

Reviewed by Dean Jackson.

  • win/tools/vsprops/common.props: Conditionally exclude the enhanced (SSE) instruction

set when building for 32-bit Windows. Otherwise, continue using SSE.

11:48 AM Changeset in webkit [173767] by evab.u-szeged@partner.samsung.com
  • 2 edits in trunk/Source/WebCore

REGRESSION(r173464): It broke the !ENABLE(PICTURE_SIZES) build
​https://bugs.webkit.org/show_bug.cgi?id=136942

Reviewed by Simon Fraser.

  • html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::parseAttribute):

11:43 AM Changeset in webkit [173766] by Simon Fraser
  • 9 edits in trunk/Source

Provide a default argument for the most commonly used HitTestRequest variant
​https://bugs.webkit.org/show_bug.cgi?id=136653

Reviewed by Darin Adler.

Make the default HitTestRequest flags be ReadOnly | Active | DisallowShadowContent
and change call sites using the default flags to use a HitTestRequest temporary.

Source/WebCore:

  • dom/TreeScope.cpp:

(WebCore::nodeFromPoint):

  • editing/FrameSelection.cpp:

(WebCore::FrameSelection::contains):

  • page/DragController.cpp:

(WebCore::elementUnderMouse):

  • page/EventHandler.cpp:

(WebCore::EventHandler::handleMouseDraggedEvent):
(WebCore::EventHandler::handleMousePressEvent):

  • rendering/HitTestRequest.h:

(WebCore::HitTestRequest::HitTestRequest):

Source/WebKit2:

  • WebProcess/WebPage/ViewGestureGeometryCollector.cpp:

(WebKit::ViewGestureGeometryCollector::collectGeometryForSmartMagnificationGesture):

  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::dynamicViewportSizeUpdate):

11:33 AM Changeset in webkit [173765] by Chris Dumez
  • 20 edits in trunk/Source

Allow DOM methods to return references instead of pointers
​https://bugs.webkit.org/show_bug.cgi?id=136931

Source/WebCore:

Reviewed by Sam Weinig.

It is common practice in WebKit to have methods return a reference
instead of a pointer if the pointer can never be null. However, this
unfortunately did not work for DOM methods (functions called by JS
bindings). This prevented further refactoring.

This patch brings support for having DOM methods to return references
instead of pointers when the pointer cannot be null. The generated
bindings were calling WTF::getPtr() on the pointer type returned by
the implementation already (in case it was a smart pointer type).
This patch leverages this by having WTF::getPtr() convert reference
arguments into raw pointers.

This patch also updates a few DOM methods on Document and Element
classes to return a reference instead of a pointer, to test the change.
There are likely more DOM methods that can be updated though.

No new tests, no behavior change.

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::classList):

  • bindings/js/JSDOMBinding.h:

(WTF::getPtr): Deleted.

  • dom/Document.cpp:

(WebCore::Document::implementation):
(WebCore::Document::webkitGetNamedFlows):
(WebCore::Document::namedFlows):
(WebCore::Document::setXMLVersion):
(WebCore::Document::setXMLStandalone):
(WebCore::Document::securityPolicy):
(WebCore::Document::styleSheets):

  • dom/Document.h:

(WebCore::Document::timing):

  • dom/Element.cpp:

(WebCore::Element::classList):
(WebCore::Element::dataset):

  • dom/Element.h:
  • html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlPanelElement::setPosition):
(WebCore::MediaControlPanelElement::resetPosition):
(WebCore::MediaControlClosedCaptionsTrackListElement::updateDisplay):

  • html/track/VTTRegion.cpp:

(WebCore::VTTRegion::displayLastTextTrackCueBox):
(WebCore::VTTRegion::willRemoveTextTrackCueBox):

  • inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::getAllStyleSheets):
(WebCore::InspectorCSSAgent::getNamedFlowCollection):

  • page/PerformanceTiming.cpp:

(WebCore::PerformanceTiming::documentTiming):

  • rendering/FlowThreadController.cpp:

(WebCore::FlowThreadController::ensureRenderFlowThreadWithName):

Source/WTF:

Add support for having WTF::getPtr() transform reference arguments
into raw pointers so that DOM methods can now return references when
appropriate and so that the generated bindings code can handle this
via WTF::getPtr().

This patch had to alter the way getPtr() was overloaded for smart
pointer types so that we don't call &p on smart pointers but p.get().
This was needed because the new WTF::getPtr(T&) was being called for
RefPtr<T> arguments instead of the getPtr(const RefPtr<T>&) overload.
This was addressed using traits and template specialization to
distinguish WTF smart pointers from other types.

Reviewed by Sam Weinig.

  • wtf/GetPtr.h:

(WTF::getPtr):

  • wtf/OwnPtr.h:

(WTF::getPtr): Deleted.

  • wtf/PassOwnPtr.h:

(WTF::getPtr): Deleted.

  • wtf/PassRefPtr.h:

(WTF::getPtr): Deleted.

  • wtf/Ref.h:
  • wtf/RefPtr.h:

(WTF::getPtr): Deleted.

  • wtf/gobject/GRefPtr.h:

(WTF::getPtr): Deleted.

11:15 AM Changeset in webkit [173764] by jer.noble@apple.com
  • 1 edit
    2 adds in trunk/LayoutTests

Videos with controls enabled never receive 'dragstart' events.
​https://bugs.webkit.org/show_bug.cgi?id=136837

Reviewed by Sam Weinig.

  • media/video-controls-drag-expected.txt: Added.
  • media/video-controls-drag.html: Added.
11:10 AM Changeset in webkit [173763] by dbates@webkit.org
  • 22 edits in trunk

Always assume internal SDK when building configuration Production
​https://bugs.webkit.org/show_bug.cgi?id=136925
<rdar://problem/18362399>

Reviewed by Dan Bernstein.

Source/bmalloc:

  • Configurations/Base.xcconfig:

Source/JavaScriptCore:

As a side effect of this change we will always enable ENABLE_TOUCH_EVENTS, ENABLE_IOS_{GESTURE, TOUCH}_EVENTS,
and ENABLE_XSLT when either building configuration Production or building with the Internal SDK.

  • Configurations/Base.xcconfig:

Source/ThirdParty/ANGLE:

  • Configurations/Base.xcconfig:

Source/WebCore:

As a side effect of this change we will always enable ENABLE_TOUCH_EVENTS, ENABLE_IOS_{GESTURE, TOUCH}_EVENTS,
and ENABLE_XSLT when either building configuration Production or building with the Internal SDK.

  • Configurations/Base.xcconfig:

Source/WebInspectorUI:

  • Configurations/DebugRelease.xcconfig: Also move #include of HaveInternalSDK.xcconfig from DebugRelease.xcconfig

to Base.xcconfig so as to be consistent with the format of other Base.xcconfig/DebugRelease.xcconfig files
(e.g. Source/WebCore/Configurations/Base.xcconfig and Source/WebCore/Configurations/DebugRelease.xcconfig).

Source/WebKit/mac:

As a side effect of this change we will always enable ENABLE_TOUCH_EVENTS, ENABLE_IOS_{GESTURE, TOUCH}_EVENTS,
and ENABLE_XSLT when either building configuration Production or building with the Internal SDK.

  • Configurations/Base.xcconfig:

Source/WebKit2:

As a side effect of this change we will always enable ENABLE_TOUCH_EVENTS, ENABLE_IOS_{GESTURE, TOUCH}_EVENTS,
and ENABLE_XSLT when either building configuration Production or building with the Internal SDK.

  • Configurations/Base.xcconfig:

Source/WTF:

  • Configurations/Base.xcconfig:

Tools:

  • DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
  • MiniBrowser/Configurations/DebugRelease.xcconfig:
  • TestWebKitAPI/Configurations/DebugRelease.xcconfig:
  • WebKitTestRunner/Configurations/DebugRelease.xcconfig:
11:04 AM Changeset in webkit [173762] by Simon Fraser
  • 3 edits in trunk/Source/WebKit2

Fix the Mac Mavericks build. Only iOS cares about fencing.

  • Platform/mac/LayerHostingContext.h:
  • Platform/mac/LayerHostingContext.mm:
10:47 AM Changeset in webkit [173761] by commit-queue@webkit.org
  • 9 edits
    3 adds in trunk

Simple ES6 feature:String prototype additions
​https://bugs.webkit.org/show_bug.cgi?id=131704

Patch by Diego Pino Garcia <Diego Pino Garcia> on 2014-09-19
Reviewed by Darin Adler.

Source/JavaScriptCore:

  • runtime/StringPrototype.cpp:

(JSC::StringPrototype::finishCreation):
(JSC::stringProtoFuncStartsWith): Added.
(JSC::stringProtoFuncEndsWith): Added.
(JSC::stringProtoFuncContains): Added.

Source/WTF:

  • wtf/text/StringImpl.cpp:

(WTF::StringImpl::find):
(WTF::equalInner): Added.
(WTF::StringImpl::startsWith): Add implementation that supports
'startOffset' parameter.
(WTF::StringImpl::endsWith): Add implementation that supports
'endOffset' parameter.

  • wtf/text/StringImpl.h:
  • wtf/text/WTFString.h:

(WTF::String::contains): Modify current implementation to allow
setting a startOffset, 0 by default.
(WTF::String::startsWith):
(WTF::String::endsWith):

LayoutTests:

Test ES6 functions: string.startsWith(), string.endsWith() and
string.contains().

  • js/Object-getOwnPropertyNames-expected.txt:
  • js/script-tests/Object-getOwnPropertyNames.js:
  • js/script-tests/string-contains.js: Added.

(stringToSearchIn.toString):
(startOffset.valueOf):
(matchString.toString):
(endOffset.valueOf):

  • js/string-contains-expected.txt: Added.
  • js/string-contains.html: Added.
10:38 AM Changeset in webkit [173760] by commit-queue@webkit.org
  • 13 edits
    1 move
    1 add
    10 deletes in trunk

WTR and DRT didReceiveAuthenticationChallengeInFrame should print messages consistently
​https://bugs.webkit.org/show_bug.cgi?id=136847

Tools:

Added protection space host and port logging to WTR didReceiveAuthenticationChallengeInFrame.

Patch by Youenn Fablet <​youenn.fablet@crf.canon.fr> on 2014-09-19
Reviewed by Alexey Proskuryakov.

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::didReceiveAuthenticationChallengeInFrame):

LayoutTests:

Updated WK2 expected.txt files according new logging of didReceiveAuthenticationChallengeInFrame.
Factorized efl/gtk platform specific expected files as WK2 expected files.

Patch by Youenn Fablet <​youenn.fablet@crf.canon.fr> on 2014-09-19
Reviewed by Alexey Proskuryakov.

  • platform/gtk/http/tests/loading/basic-auth-resend-wrong-credentials-expected.txt: Removed.
  • platform/gtk/http/tests/loading/basic-credentials-sent-automatically-expected.txt: Removed.
  • platform/gtk/http/tests/media/video-auth-expected.txt: Removed.
  • platform/gtk/http/tests/misc/401-alternative-content-expected.txt: Removed.
  • platform/gtk/http/tests/misc/authentication-redirect-1/authentication-sent-to-redirect-cross-origin-expected.txt: Removed.
  • platform/gtk/http/tests/misc/authentication-redirect-2/authentication-sent-to-redirect-same-origin-expected.txt: Removed.
  • platform/gtk/http/tests/misc/authentication-redirect-4/authentication-sent-to-redirect-same-origin-url-expected.txt: Removed.
  • platform/gtk/http/tests/security/401-logout/401-logout-expected.txt: Removed.
  • platform/gtk/http/tests/xmlhttprequest/failed-auth-expected.txt: Removed.
  • platform/gtk/http/tests/xmlhttprequest/remember-bad-password-expected.txt: Removed.
  • platform/wk2/http/tests/loading/authentication-after-redirect-stores-wrong-credentials/authentication-after-redirect-stores-wrong-credentials-expected.txt:
  • platform/wk2/http/tests/loading/basic-auth-resend-wrong-credentials-expected.txt:
  • platform/wk2/http/tests/loading/basic-credentials-sent-automatically-expected.txt:
  • platform/wk2/http/tests/media/video-auth-expected.txt: Renamed from LayoutTests/platform/efl/http/tests/media/video-auth-expected.txt.
  • platform/wk2/http/tests/misc/401-alternative-content-expected.txt:
  • platform/wk2/http/tests/misc/authentication-redirect-1/authentication-sent-to-redirect-cross-origin-expected.txt:
  • platform/wk2/http/tests/misc/authentication-redirect-2/authentication-sent-to-redirect-same-origin-expected.txt:
  • platform/wk2/http/tests/misc/authentication-redirect-4/authentication-sent-to-redirect-same-origin-url-expected.txt:
  • platform/wk2/http/tests/security/401-logout/401-logout-expected.txt:
  • platform/wk2/http/tests/xmlhttprequest/failed-auth-expected.txt:
  • platform/wk2/http/tests/xmlhttprequest/remember-bad-password-expected.txt:
9:36 AM Changeset in webkit [173759] by Carlos Garcia Campos
  • 1 copy in releases/WebKitGTK/webkit-2.5.90

WebKitGTK+ 2.5.90

9:31 AM Changeset in webkit [173758] by Carlos Garcia Campos
  • 4 edits in releases/WebKitGTK/webkit-2.6

Unreviewed. Update OptionsGTK.cmake and NEWS for 2.5.90 release.

.:

  • Source/cmake/OptionsGTK.cmake: Bump version numbers.

Source/WebKit2:

  • gtk/NEWS: Add release notes for 2.5.90.
9:01 AM Changeset in webkit [173757] by Carlos Garcia Campos
  • 4 edits in releases/WebKitGTK/webkit-2.6

Merge r173755 - [GTK] Missing inspector files in the tarball
​https://bugs.webkit.org/show_bug.cgi?id=136952

Reviewed by Gustavo Noronha Silva.

Source/WebKit2:

  • PlatformGTK.cmake: Use APPEND instead of GLOB to add individual

and generated files to the list of inspector files.

Tools:

  • gtk/manifest.txt: Add

Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js
to the tarball.

9:00 AM Changeset in webkit [173756] by Carlos Garcia Campos
  • 6 edits
    55 adds in releases/WebKitGTK/webkit-2.6

Merge r173753 - Webkitgtk 2.5.3: tarball contains APPLE LICENSE file - stating not distributable
​https://bugs.webkit.org/show_bug.cgi?id=136632

Reviewed by Gustavo Noronha Silva.

Source/WebInspectorUI:

Add free icons for the GTK port. These icons are from the GNOME
project, some of them adapted by Andres Gomez for the inspector.
This is only a subset of the icons, since we still don't have a
free replacement for all of them, but at least it makes the
inspector kind of usable.

  • UserInterface/Images/gtk/AUTHORS: Added.
  • UserInterface/Images/gtk/BackArrow.svg: Added.
  • UserInterface/Images/gtk/BreakpointActionAdd.svg: Added.
  • UserInterface/Images/gtk/BreakpointActionRemove.svg: Added.
  • UserInterface/Images/gtk/BreakpointButton.svg: Added.
  • UserInterface/Images/gtk/BreakpointInactiveButton.svg: Added.
  • UserInterface/Images/gtk/Breakpoints.svg: Added.
  • UserInterface/Images/gtk/COPYING: Added.
  • UserInterface/Images/gtk/Close.svg: Added.
  • UserInterface/Images/gtk/CloseWhite.svg: Added.
  • UserInterface/Images/gtk/ContentFlow.svg: Added.
  • UserInterface/Images/gtk/Crosshair.svg: Added.
  • UserInterface/Images/gtk/DOMCharacterData.svg: Added.
  • UserInterface/Images/gtk/DOMComment.svg: Added.
  • UserInterface/Images/gtk/DOMDocument.svg: Added.
  • UserInterface/Images/gtk/DOMDocumentType.svg: Added.
  • UserInterface/Images/gtk/DOMElement.svg: Added.
  • UserInterface/Images/gtk/DOMNode.svg: Added.
  • UserInterface/Images/gtk/DOMTextNode.svg: Added.
  • UserInterface/Images/gtk/DOMTree.svg: Added.
  • UserInterface/Images/gtk/DisclosureTriangleSmallClosed.svg: Added.
  • UserInterface/Images/gtk/DisclosureTriangleSmallOpen.svg: Added.
  • UserInterface/Images/gtk/DisclosureTriangleTinyClosed.svg: Added.
  • UserInterface/Images/gtk/DisclosureTriangleTinyOpen.svg: Added.
  • UserInterface/Images/gtk/DockBottom.svg: Added.
  • UserInterface/Images/gtk/DockRight.svg: Added.
  • UserInterface/Images/gtk/DocumentCSS.png: Added.
  • UserInterface/Images/gtk/​DocumentCSS@2x.png: Added.
  • UserInterface/Images/gtk/DocumentFont.png: Added.
  • UserInterface/Images/gtk/​DocumentFont@2x.png: Added.
  • UserInterface/Images/gtk/DocumentGeneric.png: Added.
  • UserInterface/Images/gtk/​DocumentGeneric@2x.png: Added.
  • UserInterface/Images/gtk/DocumentImage.png: Added.
  • UserInterface/Images/gtk/​DocumentImage@2x.png: Added.
  • UserInterface/Images/gtk/DocumentJS.png: Added.
  • UserInterface/Images/gtk/​DocumentJS@2x.png: Added.
  • UserInterface/Images/gtk/DocumentMarkup.png: Added.
  • UserInterface/Images/gtk/​DocumentMarkup@2x.png: Added.
  • UserInterface/Images/gtk/DownloadArrow.svg: Added.
  • UserInterface/Images/gtk/Error.svg: Added.
  • UserInterface/Images/gtk/Errors.svg: Added.
  • UserInterface/Images/gtk/ErrorsEnabled.svg: Added.
  • UserInterface/Images/gtk/EventListener.svg: Added.
  • UserInterface/Images/gtk/Exception.svg: Added.
  • UserInterface/Images/gtk/FilterFieldGlyph.svg: Added.
  • UserInterface/Images/gtk/FolderGeneric.png: Added.
  • UserInterface/Images/gtk/​FolderGeneric@2x.png: Added.
  • UserInterface/Images/gtk/ForwardArrow.svg: Added.
  • UserInterface/Images/gtk/Function.svg: Added.
  • UserInterface/Images/gtk/GoToArrow.svg: Added.
  • UserInterface/Images/gtk/Resources.svg: Added.
  • UserInterface/Images/gtk/SortIndicatorDownArrow.svg: Added.
  • UserInterface/Images/gtk/SortIndicatorUpArrow.svg: Added.
  • UserInterface/Images/gtk/UpDownArrows.svg: Added.

Source/WebKit2:

  • PlatformGTK.cmake: Use only the icons from the gtk directory since they are free.

Tools:

  • gtk/generate-inspector-gresource-manifest.py: Use an alias for

the gtk icons.

  • gtk/manifest.txt: Only include the free icons in the tarball.
8:59 AM WebKitGTK/2.6.x edited by Carlos Garcia Campos
(diff)
8:58 AM Changeset in webkit [173755] by Carlos Garcia Campos
  • 4 edits in trunk

[GTK] Missing inspector files in the tarball
​https://bugs.webkit.org/show_bug.cgi?id=136952

Reviewed by Gustavo Noronha Silva.

Source/WebKit2:

  • PlatformGTK.cmake: Use APPEND instead of GLOB to add individual

and generated files to the list of inspector files.

Tools:

  • gtk/manifest.txt: Add

Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js
to the tarball.

8:48 AM Changeset in webkit [173754] by Chris Dumez
  • 4 edits in trunk/Source/WebCore

Optimize MarkupAccumulator::appendText()
​https://bugs.webkit.org/show_bug.cgi?id=136935

Reviewed by Benjamin Poulain.

MarkupAccumulator::appendText() was calling the generic appendNodeValue()
method to append the text. appendNodeValue() supports any kind of Node and
thus calls the Node::nodeValue() virtual function.

Since appendText() is the only caller to appendNodeValue(), this patch
inlines the code in appendText() and makes it specific to Text Node, and
thus more efficient. The code now calls CharacterData::data() instead of
the Node::nodeValue() virtual function. This patch also updates
CharacterData::data() to return a const reference to avoid copying the
return value.

No new tests, no behavior change.

  • dom/CharacterData.h:

(WebCore::CharacterData::data):

  • editing/MarkupAccumulator.cpp:

(WebCore::MarkupAccumulator::appendText):
(WebCore::MarkupAccumulator::appendNodeValue): Deleted.

  • editing/MarkupAccumulator.h:
8:40 AM Changeset in webkit [173753] by Carlos Garcia Campos
  • 6 edits
    55 adds in trunk

Webkitgtk 2.5.3: tarball contains APPLE LICENSE file - stating not distributable
​https://bugs.webkit.org/show_bug.cgi?id=136632

Reviewed by Gustavo Noronha Silva.

Source/WebInspectorUI:

Add free icons for the GTK port. These icons are from the GNOME
project, some of them adapted by Andres Gomez for the inspector.
This is only a subset of the icons, since we still don't have a
free replacement for all of them, but at least it makes the
inspector kind of usable.

  • UserInterface/Images/gtk/AUTHORS: Added.
  • UserInterface/Images/gtk/BackArrow.svg: Added.
  • UserInterface/Images/gtk/BreakpointActionAdd.svg: Added.
  • UserInterface/Images/gtk/BreakpointActionRemove.svg: Added.
  • UserInterface/Images/gtk/BreakpointButton.svg: Added.
  • UserInterface/Images/gtk/BreakpointInactiveButton.svg: Added.
  • UserInterface/Images/gtk/Breakpoints.svg: Added.
  • UserInterface/Images/gtk/COPYING: Added.
  • UserInterface/Images/gtk/Close.svg: Added.
  • UserInterface/Images/gtk/CloseWhite.svg: Added.
  • UserInterface/Images/gtk/ContentFlow.svg: Added.
  • UserInterface/Images/gtk/Crosshair.svg: Added.
  • UserInterface/Images/gtk/DOMCharacterData.svg: Added.
  • UserInterface/Images/gtk/DOMComment.svg: Added.
  • UserInterface/Images/gtk/DOMDocument.svg: Added.
  • UserInterface/Images/gtk/DOMDocumentType.svg: Added.
  • UserInterface/Images/gtk/DOMElement.svg: Added.
  • UserInterface/Images/gtk/DOMNode.svg: Added.
  • UserInterface/Images/gtk/DOMTextNode.svg: Added.
  • UserInterface/Images/gtk/DOMTree.svg: Added.
  • UserInterface/Images/gtk/DisclosureTriangleSmallClosed.svg: Added.
  • UserInterface/Images/gtk/DisclosureTriangleSmallOpen.svg: Added.
  • UserInterface/Images/gtk/DisclosureTriangleTinyClosed.svg: Added.
  • UserInterface/Images/gtk/DisclosureTriangleTinyOpen.svg: Added.
  • UserInterface/Images/gtk/DockBottom.svg: Added.
  • UserInterface/Images/gtk/DockRight.svg: Added.
  • UserInterface/Images/gtk/DocumentCSS.png: Added.
  • UserInterface/Images/gtk/​DocumentCSS@2x.png: Added.
  • UserInterface/Images/gtk/DocumentFont.png: Added.
  • UserInterface/Images/gtk/​DocumentFont@2x.png: Added.
  • UserInterface/Images/gtk/DocumentGeneric.png: Added.
  • UserInterface/Images/gtk/​DocumentGeneric@2x.png: Added.
  • UserInterface/Images/gtk/DocumentImage.png: Added.
  • UserInterface/Images/gtk/​DocumentImage@2x.png: Added.
  • UserInterface/Images/gtk/DocumentJS.png: Added.
  • UserInterface/Images/gtk/​DocumentJS@2x.png: Added.
  • UserInterface/Images/gtk/DocumentMarkup.png: Added.
  • UserInterface/Images/gtk/​DocumentMarkup@2x.png: Added.
  • UserInterface/Images/gtk/DownloadArrow.svg: Added.
  • UserInterface/Images/gtk/Error.svg: Added.
  • UserInterface/Images/gtk/Errors.svg: Added.
  • UserInterface/Images/gtk/ErrorsEnabled.svg: Added.
  • UserInterface/Images/gtk/EventListener.svg: Added.
  • UserInterface/Images/gtk/Exception.svg: Added.
  • UserInterface/Images/gtk/FilterFieldGlyph.svg: Added.
  • UserInterface/Images/gtk/FolderGeneric.png: Added.
  • UserInterface/Images/gtk/​FolderGeneric@2x.png: Added.
  • UserInterface/Images/gtk/ForwardArrow.svg: Added.
  • UserInterface/Images/gtk/Function.svg: Added.
  • UserInterface/Images/gtk/GoToArrow.svg: Added.
  • UserInterface/Images/gtk/Resources.svg: Added.
  • UserInterface/Images/gtk/SortIndicatorDownArrow.svg: Added.
  • UserInterface/Images/gtk/SortIndicatorUpArrow.svg: Added.
  • UserInterface/Images/gtk/UpDownArrows.svg: Added.

Source/WebKit2:

  • PlatformGTK.cmake: Use only the icons from the gtk directory since they are free.

Tools:

  • gtk/generate-inspector-gresource-manifest.py: Use an alias for

the gtk icons.

  • gtk/manifest.txt: Only include the free icons in the tarball.
3:39 AM WebKitGTK/2.6.x created by Carlos Garcia Campos
3:23 AM Changeset in webkit [173752] by Carlos Garcia Campos
  • 1 copy in releases/WebKitGTK/webkit-2.6

Branch WebKitGTK+ for 2.6

2:21 AM Changeset in webkit [173751] by Carlos Garcia Campos
  • 4 edits in trunk

[GTK] generate-inspector-gresource-manifest.py should receive the list of files from the makefile
​https://bugs.webkit.org/show_bug.cgi?id=136943

Reviewed by Philippe Normand.

Source/WebKit2:

  • PlatformGTK.cmake: Fix the inspector file list and pass it to

the generate-inspector-gresource-manifest.py script.

Tools:

Update the script to receive the list of files from the command
line instead of scanning the given directories.

  • gtk/generate-inspector-gresource-manifest.py:

(get_filenames): Convert filenames to use relative paths.
(find_all_files_in_directory): Deleted.
(find_all_files_in_directory.select_file): Deleted.

Note: See TracTimeline for information about the timeline view.