Timeline
Sep 22, 2014:
- 11:00 PM Changeset in webkit [173866] by
-
- 29 edits in trunk/Source/WebCore
Unreviewed build fix after r173859.
Partial revert to fix debug build after r173859.
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::remoteSVGRootElement):
- html/HTMLFrameOwnerElement.cpp:
(WebCore::HTMLFrameOwnerElement::getSVGDocument):
- page/EventHandler.cpp:
(WebCore::EventHandler::handleMousePressEvent):
(WebCore::EventHandler::handleMouseMoveEvent):
(WebCore::EventHandler::handleMouseReleaseEvent):
- page/Frame.cpp:
(WebCore::Frame::setPageAndTextZoomFactors):
- page/FrameView.cpp:
(WebCore::FrameView::scrollToAnchor):
- rendering/svg/RenderSVGBlock.h:
(WebCore::RenderSVGBlock::graphicsElement):
- rendering/svg/RenderSVGGradientStop.cpp:
(WebCore::RenderSVGGradientStop::gradientElement):
- rendering/svg/RenderSVGInline.h:
(WebCore::RenderSVGInline::graphicsElement):
- rendering/svg/RenderSVGResourceClipper.cpp:
(WebCore::RenderSVGResourceClipper::pathOnlyClipping):
- rendering/svg/RenderSVGResourceContainer.cpp:
(WebCore::RenderSVGResourceContainer::transformOnNonScalingStroke):
- rendering/svg/RenderSVGShape.h:
(WebCore::RenderSVGShape::graphicsElement):
- rendering/svg/RenderSVGTransformableContainer.h:
- rendering/svg/SVGRenderSupport.cpp:
(WebCore::SVGRenderSupport::updateMaskedAncestorShouldIsolateBlending):
- rendering/svg/SVGRenderTreeAsText.cpp:
(WebCore::operator<<):
- rendering/svg/SVGRenderingContext.cpp:
(WebCore::SVGRenderingContext::prepareToRenderSVGContent):
- rendering/svg/SVGResources.cpp:
(WebCore::targetReferenceFromResource):
- svg/SVGAElement.cpp:
(WebCore::SVGAElement::defaultEventHandler):
- svg/SVGAnimateElement.cpp:
(WebCore::SVGAnimateElement::calculateAnimatedValue):
- svg/SVGAnimationElement.cpp:
(WebCore::SVGAnimationElement::currentValuesForValuesAnimation):
- svg/SVGElement.cpp:
(WebCore::SVGElement::getBoundingBox):
- svg/SVGLinearGradientElement.cpp:
(WebCore::SVGLinearGradientElement::collectGradientAttributes):
- svg/SVGLocatable.cpp:
(WebCore::SVGLocatable::getTransformToElement):
- svg/SVGPolyElement.cpp:
(WebCore::SVGPolyElement::synchronizePoints):
(WebCore::SVGPolyElement::lookupOrCreatePointsWrapper):
- svg/SVGRadialGradientElement.cpp:
(WebCore::SVGRadialGradientElement::collectGradientAttributes):
- svg/SVGTextContentElement.cpp:
(WebCore::SVGTextContentElement::synchronizeTextLength):
(WebCore::SVGTextContentElement::lookupOrCreateTextLengthWrapper):
(WebCore::SVGTextContentElement::elementFromRenderer):
- svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::toClipPath):
- svg/animation/SVGSMILElement.cpp:
(WebCore::SVGSMILElement::connectConditions):
(WebCore::SVGSMILElement::disconnectConditions):
- svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::hasSingleSecurityOrigin):
(WebCore::SVGImage::setContainerSize):
(WebCore::SVGImage::containerSize):
(WebCore::SVGImage::embeddedContentBox):
(WebCore::SVGImage::hasRelativeWidth):
(WebCore::SVGImage::hasRelativeHeight):
(WebCore::SVGImage::computeIntrinsicDimensions):
(WebCore::SVGImage::startAnimation):
(WebCore::SVGImage::stopAnimation):
- 9:39 PM Changeset in webkit [173865] by
-
- 8 edits in trunk/Source/WebCore
Ensure that layout is up-to-date before hit-testing via RenderView
https://bugs.webkit.org/show_bug.cgi?id=136651
Reviewed by David Hyatt.
Ensure that layout is up-to-date before we do hit-testing via the RenderView.
Previously, RenderLayer::hitTest() called updateLayout(), but it's better
to push that responsibility onto RenderView before entering the RenderLayer
tree.
Make callers a little more consistent in getting the RenderView via
Frame::contentRenderer(), though perhaps we should remove that and just
call Document::renderView() everywhere.
- accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::press): Hit test via the RenderView, rather
than doing so on the RenderView's layer, to ensure that we updateLayout().
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::accessibilityHitTest): This code calls
hitTest() on arbitrary layers, so needs to explicitly update layout.
- editing/FrameSelection.cpp:
(WebCore::FrameSelection::contains):
- page/EventHandler.cpp:
(WebCore::EventHandler::eventMayStartDrag):
(WebCore::EventHandler::updateSelectionForMouseDrag):
(WebCore::EventHandler::hitTestResultAtPoint): The explicit updateLayout() is
no longer needed.
(WebCore::EventHandler::updateCursor):
(WebCore::EventHandler::handleWheelEvent):
(WebCore::EventHandler::hoverTimerFired):
(WebCore::hitTestResultInFrame):
- page/Frame.cpp:
(WebCore::Frame::contentRenderer):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::hitTest):
- rendering/RenderView.cpp:
(WebCore::RenderView::hitTest): Here's where we ensure that layout is up-to-date.
- 9:31 PM Changeset in webkit [173864] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, EFL gardening. Unskip media test on EFL port. Almost media tests
are passed except for some tests. Unfortunately what revision fixed this crash on media test.
To maintain media test on EFL port again, this commit unskips those tests.
- platform/efl/TestExpectations:
- 9:13 PM Changeset in webkit [173863] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, EFL gardening. Unskip batterystatus, which doesn't come to crash anymore.
- platform/efl/TestExpectations:
- 8:08 PM Changeset in webkit [173862] by
-
- 2 edits in trunk/LayoutTests
[Windows] More test expectation gardening.
- platform/win/TestExpectations: Skip some failing image only failures, unskip some tests reported as now passing.
- 7:25 PM Changeset in webkit [173861] by
-
- 2 edits in trunk/LayoutTests
[Windows] More test expectation gardening.
- platform/win/TestExpectations:
- 6:05 PM Changeset in webkit [173860] by
-
- 2 edits in trunk/Tools
[EFL][WK2] Minibrowser : Add keyboard support for page reload while ignoring cache
https://bugs.webkit.org/show_bug.cgi?id=136813
Patch by Rohit Kumar <kumar.rohit@samsung.com> on 2014-09-22
Reviewed by Gyuyoung Kim.
Ctrl+r is used for page reload along with F5. Ctrl+Shift+r and Ctrl+F5 is used for page reload while ignoring cache.
- MiniBrowser/efl/main.c:
(on_key_down):
- 5:55 PM Changeset in webkit [173859] by
-
- 102 edits in trunk/Source/WebCore
Use downcast<SVG*Element>() instead of toSVG*Element()
https://bugs.webkit.org/show_bug.cgi?id=137004
Reviewed by Benjamin Poulain.
Use downcast<SVG*Element>() instead of toSVG*Element() for casting SVG
Elements and get rid of the transition toSVG*Element() macros.
Also use downcast<MathML*Element>() instead of toMathML*Element() for
casting MathML Elements.
The HTML Elements casting counterparts will be taken care of in a
separate patch.
No new tests, no behavior change.
- accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::alternativeText):
(WebCore::AccessibilityNodeObject::accessibilityDescription):
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::remoteSVGRootElement):
- bindings/js/JSElementCustom.cpp:
(WebCore::toJSNewlyCreated):
- bindings/js/JSNodeCustom.cpp:
(WebCore::createWrapperInline):
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::ComputedStyleExtractor::propertyValue):
- css/CSSCursorImageValue.cpp:
(WebCore::resourceReferencedByCursorElement):
(WebCore::CSSCursorImageValue::updateIfSVGCursorIsUsed):
- css/ElementRuleCollector.cpp:
(WebCore::ElementRuleCollector::matchAllRules):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::locateCousinList):
(WebCore::StyleResolver::canShareStyleWithElement):
(WebCore::StyleResolver::locateSharedStyle):
- dom/DocumentStyleSheetCollection.cpp:
(WebCore::DocumentStyleSheetCollection::collectActiveStyleSheets):
- dom/Element.cpp:
(WebCore::Element::synchronizeAllAttributes):
(WebCore::Element::synchronizeAttribute):
(WebCore::Element::boundsInRootViewSpace):
(WebCore::Element::getBoundingClientRect):
(WebCore::Element::childShouldCreateRenderer):
(WebCore::Element::fastAttributeLookupAllowed):
- dom/EventDispatcher.cpp:
(WebCore::eventTargetRespectingTargetRules):
- dom/ScriptElement.cpp:
(WebCore::toScriptElementIfPossible):
- dom/make_names.pl:
(printTypeHelpers):
- html/HTMLFrameOwnerElement.cpp:
(WebCore::HTMLFrameOwnerElement::getSVGDocument):
- inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::viaInspectorStyleSheet):
- mathml/MathMLElement.cpp:
(WebCore::MathMLElement::isPhrasingContent):
(WebCore::MathMLElement::childShouldCreateRenderer):
(WebCore::MathMLElement::attributeChanged):
- mathml/MathMLElement.h:
(WebCore::Node::hasTagName):
- mathml/MathMLSelectElement.cpp:
(WebCore::MathMLSelectElement::getSelectedSemanticsChild):
- page/EventHandler.cpp:
(WebCore::EventHandler::handleMousePressEvent):
(WebCore::EventHandler::handleMouseMoveEvent):
(WebCore::EventHandler::handleMouseReleaseEvent):
(WebCore::instanceAssociatedWithShadowTreeElement):
- page/Frame.cpp:
(WebCore::Frame::setPageAndTextZoomFactors):
- page/FrameView.cpp:
(WebCore::FrameView::scrollToAnchor):
- rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::parseColSpanFromDOM):
(WebCore::RenderTableCell::parseRowSpanFromDOM):
(WebCore::RenderTableCell::computePreferredLogicalWidths):
- rendering/mathml/RenderMathMLMenclose.cpp:
(WebCore::RenderMathMLMenclose::addChild):
(WebCore::RenderMathMLMenclose::computePreferredLogicalWidths):
(WebCore::RenderMathMLMenclose::updateLogicalHeight):
(WebCore::RenderMathMLMenclose::paint):
- rendering/svg/RenderSVGBlock.h:
(WebCore::RenderSVGBlock::graphicsElement):
- rendering/svg/RenderSVGForeignObject.cpp:
(WebCore::RenderSVGForeignObject::foreignObjectElement):
- rendering/svg/RenderSVGGradientStop.cpp:
(WebCore::RenderSVGGradientStop::gradientElement):
- rendering/svg/RenderSVGGradientStop.h:
- rendering/svg/RenderSVGImage.cpp:
(WebCore::RenderSVGImage::imageElement):
- rendering/svg/RenderSVGInline.h:
(WebCore::RenderSVGInline::graphicsElement):
- rendering/svg/RenderSVGModelObject.cpp:
(WebCore::getElementCTM):
(WebCore::RenderSVGModelObject::checkIntersection):
(WebCore::RenderSVGModelObject::checkEnclosure):
- rendering/svg/RenderSVGModelObject.h:
(WebCore::RenderSVGModelObject::element):
- rendering/svg/RenderSVGRect.cpp:
(WebCore::RenderSVGRect::rectElement):
- rendering/svg/RenderSVGResource.cpp:
(WebCore::removeFromCacheAndInvalidateDependencies):
- rendering/svg/RenderSVGResourceClipper.cpp:
(WebCore::RenderSVGResourceClipper::pathOnlyClipping):
(WebCore::RenderSVGResourceClipper::drawContentIntoMaskImage):
- rendering/svg/RenderSVGResourceClipper.h:
- rendering/svg/RenderSVGResourceContainer.cpp:
(WebCore::RenderSVGResourceContainer::transformOnNonScalingStroke):
- rendering/svg/RenderSVGResourceFilter.h:
- rendering/svg/RenderSVGResourceLinearGradient.h:
- rendering/svg/RenderSVGResourceMarker.h:
- rendering/svg/RenderSVGResourceMasker.h:
- rendering/svg/RenderSVGResourcePattern.cpp:
(WebCore::RenderSVGResourcePattern::patternElement):
- rendering/svg/RenderSVGResourceRadialGradient.h:
- rendering/svg/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::svgSVGElement):
- rendering/svg/RenderSVGShape.h:
(WebCore::RenderSVGShape::graphicsElement):
- rendering/svg/RenderSVGText.cpp:
(WebCore::RenderSVGText::textElement):
- rendering/svg/RenderSVGTextPath.cpp:
(WebCore::RenderSVGTextPath::textPathElement):
(WebCore::RenderSVGTextPath::layoutPath):
- rendering/svg/RenderSVGTransformableContainer.cpp:
(WebCore::RenderSVGTransformableContainer::calculateLocalTransform):
- rendering/svg/RenderSVGTransformableContainer.h:
- rendering/svg/RenderSVGViewportContainer.cpp:
(WebCore::RenderSVGViewportContainer::svgSVGElement):
- rendering/svg/SVGPathData.cpp:
(WebCore::updatePathFromLineElement):
(WebCore::updatePathFromPathElement):
(WebCore::updatePathFromPolygonElement):
(WebCore::updatePathFromPolylineElement):
- rendering/svg/SVGRenderSupport.cpp:
(WebCore::SVGRenderSupport::layoutChildren):
(WebCore::SVGRenderSupport::applyStrokeStyleToContext):
(WebCore::SVGRenderSupport::updateMaskedAncestorShouldIsolateBlending):
- rendering/svg/SVGRenderTreeAsText.cpp:
(WebCore::operator<<):
- rendering/svg/SVGRenderingContext.cpp:
(WebCore::SVGRenderingContext::prepareToRenderSVGContent):
- rendering/svg/SVGResources.cpp:
(WebCore::targetReferenceFromResource):
(WebCore::SVGResources::buildCachedResources):
- rendering/svg/SVGTextLayoutEngine.cpp:
(WebCore::SVGTextLayoutEngine::layoutTextOnLineOrPath):
- svg/SVGAElement.cpp:
(WebCore::SVGAElement::createElementRenderer):
(WebCore::SVGAElement::defaultEventHandler):
- svg/SVGAltGlyphDefElement.cpp:
(WebCore::SVGAltGlyphDefElement::hasValidGlyphElements):
- svg/SVGAltGlyphElement.cpp:
(WebCore::SVGAltGlyphElement::hasValidGlyphElements):
- svg/SVGAnimateElement.cpp:
(WebCore::SVGAnimateElement::calculateAnimatedValue):
- svg/SVGAnimatedTransformList.cpp:
(WebCore::SVGAnimatedTransformListAnimator::SVGAnimatedTransformListAnimator):
- svg/SVGAnimationElement.cpp:
(WebCore::SVGAnimationElement::currentValuesForValuesAnimation):
(WebCore::SVGAnimationElement::adjustForInheritance):
- svg/SVGDocument.cpp:
(WebCore::SVGDocument::rootElement):
- svg/SVGElement.cpp:
(WebCore::SVGElement::ownerSVGElement):
(WebCore::SVGElement::viewportElement):
(WebCore::SVGElement::getBoundingBox):
(WebCore::SVGElement::childShouldCreateRenderer):
(WebCore::SVGElement::title):
(WebCore::SVGElement::updateRelativeLengthsInformation):
- svg/SVGElement.h:
(WebCore::Node::hasTagName):
- svg/SVGFEComponentTransferElement.cpp:
(WebCore::SVGFEComponentTransferElement::build):
- svg/SVGFEImageElement.cpp:
(WebCore::SVGFEImageElement::buildPendingResource):
- svg/SVGFilterElement.cpp:
(WebCore::SVGFilterElement::childShouldCreateRenderer):
- svg/SVGFilterPrimitiveStandardAttributes.h:
(WebCore::isSVGFilterPrimitiveStandardAttributes):
- svg/SVGFontData.cpp:
(WebCore::SVGFontData::applySVGGlyphSelection):
- svg/SVGFontElement.cpp:
(WebCore::SVGFontElement::ensureGlyphCache):
- svg/SVGFontFaceElement.cpp:
(WebCore::SVGFontFaceElement::rebuildFontFace):
- svg/SVGFontFaceFormatElement.cpp:
(WebCore::SVGFontFaceFormatElement::childrenChanged):
- svg/SVGFontFaceSrcElement.cpp:
(WebCore::SVGFontFaceSrcElement::srcValue):
(WebCore::SVGFontFaceSrcElement::childrenChanged):
- svg/SVGFontFaceUriElement.cpp:
(WebCore::SVGFontFaceUriElement::childrenChanged):
- svg/SVGGlyphElement.cpp:
(WebCore::SVGGlyphElement::invalidateGlyphCache):
- svg/SVGGraphicsElement.h:
(WebCore::isSVGGraphicsElement):
- svg/SVGHKernElement.cpp:
(WebCore::SVGHKernElement::insertedInto):
(WebCore::SVGHKernElement::removedFrom):
- svg/SVGImageLoader.cpp:
(WebCore::SVGImageLoader::dispatchLoadEvent):
- svg/SVGLengthContext.cpp:
(WebCore::SVGLengthContext::determineViewport):
- svg/SVGLinearGradientElement.cpp:
(WebCore::setGradientAttributes):
(WebCore::SVGLinearGradientElement::collectGradientAttributes):
- svg/SVGLocatable.cpp:
(WebCore::SVGLocatable::nearestViewportElement):
(WebCore::SVGLocatable::farthestViewportElement):
(WebCore::SVGLocatable::computeCTM):
(WebCore::SVGLocatable::getTransformToElement):
- svg/SVGMPathElement.cpp:
(WebCore::SVGMPathElement::buildPendingResource):
(WebCore::SVGMPathElement::pathElement):
(WebCore::SVGMPathElement::notifyParentOfPathChange):
- svg/SVGMarkerElement.cpp:
(WebCore::SVGMarkerElement::synchronizeOrientType):
(WebCore::SVGMarkerElement::lookupOrCreateOrientTypeWrapper):
- svg/SVGPathElement.cpp:
(WebCore::SVGPathElement::invalidateMPathDependencies):
(WebCore::SVGPathElement::lookupOrCreateDWrapper):
(WebCore::SVGPathElement::synchronizeD):
- svg/SVGPathSegList.cpp:
(WebCore::SVGPathSegList::commitChange):
- svg/SVGPatternElement.cpp:
(WebCore::SVGPatternElement::collectPatternAttributes):
- svg/SVGPolyElement.cpp:
(WebCore::SVGPolyElement::synchronizePoints):
(WebCore::SVGPolyElement::lookupOrCreatePointsWrapper):
- svg/SVGRadialGradientElement.cpp:
(WebCore::setGradientAttributes):
(WebCore::SVGRadialGradientElement::collectGradientAttributes):
- svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::setupInitialView):
- svg/SVGTextContentElement.cpp:
(WebCore::SVGTextContentElement::synchronizeTextLength):
(WebCore::SVGTextContentElement::lookupOrCreateTextLengthWrapper):
(WebCore::SVGTextContentElement::elementFromRenderer):
- svg/SVGTextContentElement.h:
(WebCore::isSVGTextContentElement):
- svg/SVGTextPathElement.cpp:
(WebCore::SVGTextPathElement::buildPendingResource):
- svg/SVGUseElement.cpp:
(WebCore::dumpInstanceTree):
(WebCore::SVGUseElement::buildPendingResource):
(WebCore::SVGUseElement::toClipPath):
(WebCore::SVGUseElement::buildInstanceTree):
(WebCore::SVGUseElement::hasCycleUseReferencing):
(WebCore::SVGUseElement::expandUseElementsInShadowTree):
(WebCore::SVGUseElement::associateInstancesWithShadowTreeElements):
- svg/SVGVKernElement.cpp:
(WebCore::SVGVKernElement::insertedInto):
(WebCore::SVGVKernElement::removedFrom):
- svg/SVGViewSpec.cpp:
(WebCore::SVGViewSpec::viewTarget):
- svg/animation/SVGSMILElement.cpp:
(WebCore::SVGSMILElement::buildPendingResource):
(WebCore::SVGSMILElement::connectConditions):
(WebCore::SVGSMILElement::disconnectConditions):
- svg/animation/SVGSMILElement.h:
(WebCore::isSVGSMILElement):
- svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::hasSingleSecurityOrigin):
(WebCore::SVGImage::setContainerSize):
(WebCore::SVGImage::containerSize):
(WebCore::SVGImage::embeddedContentBox):
(WebCore::SVGImage::hasRelativeWidth):
(WebCore::SVGImage::hasRelativeHeight):
(WebCore::SVGImage::computeIntrinsicDimensions):
(WebCore::SVGImage::startAnimation):
(WebCore::SVGImage::stopAnimation):
- svg/graphics/filters/SVGFEImage.cpp:
(WebCore::FEImage::platformApplySoftware):
- svg/properties/SVGAnimatedPathSegListPropertyTearOff.h:
(WebCore::SVGAnimatedPathSegListPropertyTearOff::animValDidChange):
- svg/properties/SVGPathSegListPropertyTearOff.cpp:
(WebCore::SVGPathSegListPropertyTearOff::contextElement):
- 5:47 PM Changeset in webkit [173858] by
-
- 2 edits in trunk/Source/WebCore
Follow on fix for [iOS] ASSERTION FAILED: WTF::isMainThread() in WebCore::memoryCache() when using WebKit1
https://bugs.webkit.org/show_bug.cgi?id=136962
Rubber-stamped by Simon Fraser.
Remove the const per review comment. It is not needed.
- loader/cocoa/DiskCacheMonitorCocoa.mm:
(WebCore::DiskCacheMonitor::DiskCacheMonitor):
- 5:23 PM Changeset in webkit [173857] by
-
- 10 edits in trunk
Move nodeFromPoint() back to Document where it belongs
https://bugs.webkit.org/show_bug.cgi?id=137012
Reviewed by Zalan Bujtas.
Source/WebCore:
nodeFromPoint() was moved into TreeScope for ShadowDOM work, but now we can move
it back to its logical place.
Make versions of elementFromPoint and caretRangeFromPoint that take LayoutPoints,
and change the current scale/offset code to be in layout units (which results
in a small behavior change).
elementFromPoint(int, int) and caretRangeFromPoint(int, int) are still required
for bindings code.
- dom/Document.cpp:
(WebCore::Document::nodeFromPoint):
(WebCore::Document::elementFromPoint):
(WebCore::Document::caretRangeFromPoint):
- dom/Document.h:
(WebCore::Document::elementFromPoint): Move logic from TreeScope::elementFromPoint()
here.
- dom/TreeScope.cpp:
(WebCore::nodeFromPoint): Deleted.
(WebCore::TreeScope::elementFromPoint): Deleted.
- dom/TreeScope.h:
LayoutTests:
All platforms use subpixel layout now, so remove the conditional behavior in this test.
Fix the test to account for scaling now being done in layout units.
- fast/dom/Document/CaretRangeFromPoint/hittest-relative-to-viewport-expected.txt:
- fast/dom/Document/CaretRangeFromPoint/hittest-relative-to-viewport.html:
- platform/mac/fast/dom/Document/CaretRangeFromPoint/hittest-relative-to-viewport-expected.txt:
- 4:10 PM Changeset in webkit [173856] by
-
- 1 edit6 adds2 deletes in trunk/LayoutTests
Split the test parsing-css-nth-child-of.html in 3
https://bugs.webkit.org/show_bug.cgi?id=137013
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-09-22
Rubber-stamped by Christophe Dumez.
parsing-css-nth-child-of.html tends to be too slow in debug, causing timeout from time to time.
The speed issues will be fixed once we JIT the selector. Since it will take a while before the JIT is ready,
this patch splits the test in three to avoid timeouts on the bots.
- fast/css/parsing-css-nth-child-of-1-expected.txt: Renamed from LayoutTests/fast/css/parsing-css-nth-child-of-expected.txt.
- fast/css/parsing-css-nth-child-of-1.html: Added.
- fast/css/parsing-css-nth-child-of-2-expected.txt: Added.
- fast/css/parsing-css-nth-child-of-2.html: Renamed from LayoutTests/fast/css/parsing-css-nth-child-of.html.
- fast/css/parsing-css-nth-child-of-3-expected.txt: Added.
- fast/css/parsing-css-nth-child-of-3.html: Added.
- 3:37 PM Changeset in webkit [173855] by
-
- 5 edits in branches/safari-600.1.4.11-branch/Source
Versioning.
- 3:34 PM Changeset in webkit [173854] by
-
- 1 copy in tags/Safari-600.1.4.11.10
New tag.
- 3:09 PM Changeset in webkit [173853] by
-
- 4 edits16 adds in trunk
Add the baseline implementation of :nth-child(An+B of selector-list)
https://bugs.webkit.org/show_bug.cgi?id=136975
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-09-22
Reviewed by Darin Adler.
Source/WebCore:
Tests: fast/css/nth-child-of-classname.html
fast/css/nth-child-of-complex-selector.html
fast/css/nth-child-of-compound-selector.html
fast/css/nth-child-of-tagname.html
fast/selectors/nth-child-of-basics.html
fast/selectors/nth-child-of-class-style-update.html
fast/selectors/nth-child-of-complex-selectors.html
fast/selectors/nth-child-of-selector-list.html
- css/SelectorChecker.cpp:
(WebCore::SelectorChecker::checkOne):
Pretty basic:
-Go over the previous siblings.
-For each sibling, test the selector list. If it matches, increase the count.
- cssjit/SelectorCompiler.cpp:
(WebCore::SelectorCompiler::addPseudoClassType):
Skip any case of the new selector. This will be implemented separately.
LayoutTests:
- fast/css/nth-child-of-classname-expected.html: Added.
- fast/css/nth-child-of-classname.html: Added.
- fast/css/nth-child-of-complex-selector-expected.html: Added.
- fast/css/nth-child-of-complex-selector.html: Added.
- fast/css/nth-child-of-compound-selector-expected.html: Added.
- fast/css/nth-child-of-compound-selector.html: Added.
- fast/css/nth-child-of-tagname-expected.html: Added.
- fast/css/nth-child-of-tagname.html: Added.
Cover basic styling and style sharing.
- fast/selectors/nth-child-of-basics-expected.txt: Added.
- fast/selectors/nth-child-of-basics.html: Added.
- fast/selectors/nth-child-of-complex-selectors-expected.txt: Added.
- fast/selectors/nth-child-of-complex-selectors.html: Added.
- fast/selectors/nth-child-of-selector-list-expected.txt: Added.
- fast/selectors/nth-child-of-selector-list.html: Added.
Cover querySelector and styling of various cases.
- fast/selectors/nth-child-of-class-style-update-expected.txt: Added.
- fast/selectors/nth-child-of-class-style-update.html: Added.
Basic case of style invalidation.
- 3:08 PM Changeset in webkit [173852] by
-
- 7 edits in trunk/Source/WebCore
Implement 'vhea', 'vmtx', and 'kern' tables in SVG -> OTF converter
https://bugs.webkit.org/show_bug.cgi?id=136971
Reviewed by Darin Adler.
This patch fills in the tables related to vertical metrics and kerning. The vertical metrics tables are
fairly straightforward. On the other hand, the 'kern' table has subtables which can be in a variety
of formats; however, according to Microsoft, Windows only allows one particular format, which doesn't
allow for ranges of glyphs to be described and therefore might lead to a large 'kern' table size. In
the interest of platform agnosticism I have implemented this particular format, and have not actually
witnessed any extremely large 'kern' tables in any of the fonts that I have looked at.
I also added basic support for the horiz-origin-x and horiz-origin-y SVG properties, though support
might not be perfect based on my testing.
Regarding testing, after this patch, almost all of our SVG fonts tests pass (barring tiny rebaselining;
the platform font system calculates slightly different advances than we did. These differences are tiny
and expected from such a dramatic shift in text handling engines.) There are around two dozen failing
tests left that look like they are actually indiciative of code problems.
- svg/SVGFontElement.cpp:
(WebCore::SVGFontElement::ensureGlyphCache): Refactor to accept new signature of
SVG*KernElement::build*KerningPair().
- svg/SVGHKernElement.cpp:
(WebCore::SVGHKernElement::buildHorizontalKerningPair): Refactor to allow for intermediate data to be
returned, which the SVG -> OTF font converter can use.
- svg/SVGHKernElement.h: New signature for buildHorizontalKerningPair().
- svg/SVGToOTFFontConversion.cpp:
(WebCore::SVGToOTFFontConverter::GlyphData::GlyphData): Save the glyph's vertical advance along with
the glyph's horizontal advance.
(WebCore::SVGToOTFFontConverter::KerningData::KerningData): This data represents a record in one of
the two 'kern' subtables, and as such needs to be sorted.
(WebCore::SVGToOTFFontConverter::KerningData::operator<): Sort comparator.
(WebCore::SVGToOTFFontConverter::appendHEADTable): Save the unitsPerEm locally to save a conditional.
(WebCore::SVGToOTFFontConverter::appendHHEATable): Ditto.
(WebCore::SVGToOTFFontConverter::appendHMTXTable): Ditto. Also use the horizontal advance as opposed to
the vertical advance.
(WebCore::SVGToOTFFontConverter::appendOS2Table): Save the unitsPerEm locally to save a conditional.
Also if the average advance isn't found in the font, use the missing glyph's advance. If there is no
missing glyph, bail and use the unitsPerEm.
(WebCore::SVGToOTFFontConverter::appendVORGTable): If the default vertical origin isn't found in the
font, use the missing glyphs's vertical origin. If there is no missing glyph, bail and use 0.
(WebCore::SVGToOTFFontConverter::appendVHEATable): Parallel of 'hhea' table, except for vertical info.
(WebCore::SVGToOTFFontConverter::appendVMTXTable): Parallel of 'hmtx' table, except for vertical info.
(WebCore::SVGToOTFFontConverter::appendKerningHelperFields): Computes and appends 4 fields that font
parsers need in order to do a binary search on the kern records.
(WebCore::SVGToOTFFontConverter::addCodepointRanges): For each codepoint in the ranges, look up its
representative glyph and append it to a set.
(WebCore::SVGToOTFFontConverter::addCodepoints): For each codepoint in the range, look up its
representative glyph and append it to a set.
(WebCore::SVGToOTFFontConverter::addGlyphNames): For each glyph name, look up its representative glyph
and append it to a set.
(WebCore::SVGToOTFFontConverter::computeKerningData): Call SVG*KernElement::build*KerningPair() and
iterate through all the data it returned, building up records into a Vector.
(WebCore::SVGToOTFFontConverter::appendKERNTable): Go through the vector that computeKerningData()
returned and actually write out the two subtables. One is for horizontal kerning and the other is for
vertical kerning.
(WebCore::CFFBuilder::CFFBuilder): Use the position of the glyph origin to perform the initial moveto
command.
(WebCore::transcodeGlyphPaths): Get the glyph's origin and pass it to the CFFBuilder.
(WebCore::SVGToOTFFontConverter::appendGlyphData): Templated overloading so that the missing glyph
gets a null SVGGlyphElement pointer but the rest of the glyphs get a non-null one.
(WebCore::SVGToOTFFontConverter::processGlyphElement): Called on both SVGGlyphElements and
SVGMissingGlyphElements, this pulls out information from the element and computs its path information.
(WebCore::SVGToOTFFontConverter::SVGToOTFFontConverter): Use the new templated version of
processGlyphElement so we can get the same glyph parsing behavior on SVGMissingGlyphElements. In
addition, populate two maps for the kerning table creation function to use.
(WebCore::SVGToOTFFontConverter::convertSVGToOTFFont): Append new tables.
- svg/SVGVKernElement.cpp:
(WebCore::SVGVKernElement::buildVerticalKerningPair): Refactor to allow for intermediate data to be
returned, which the SVG -> OTF font converter can use.
- svg/SVGVKernElement.h: New signature for buildVerticalKerningPair().
- 3:00 PM Changeset in webkit [173851] by
-
- 6 edits2 adds in trunk
[Cocoa] Add UI delegate callback when window.close() is called
https://bugs.webkit.org/show_bug.cgi?id=137008
<rdar://problem/17801001>
Reviewed by Anders Carlsson.
Source/WebKit2:
Implement support infrastructure to notify the UI client when window.close() is called.
- UIProcess/API/Cocoa/WKUIDelegatePrivate.h: Added method declaration for -_webViewClose:.
- UIProcess/Cocoa/UIDelegate.h: Added override declaration for API::UIClient::close().
- UIProcess/Cocoa/UIDelegate.mm:
(WebKit::UIDelegate::setDelegate): Wire up delegate method to Objective-C selector, -[WKUIDelegatePrivate _webViewClose:].
(WebKit::UIDelegate::UIClient::close): Added; turns around and calls -[WKUIDelegatePrivate _webViewClose:] (if applicable).
Tools:
Add a test to ensure that -[WKUIDelegatePrivate _webViewClose:] is called on window.close()
for window opened via JavaScript (i.e. window.open()).
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebKit2/open-and-close-window.html: Added.
- TestWebKitAPI/Tests/WebKit2Cocoa/OpenAndCloseWindow.mm: Added.
- 2:13 PM Changeset in webkit [173850] by
-
- 2 edits in branches/safari-600.1.4.11-branch/Source/WebKit2
Merged r173788. <rdar://problem/17878728>
- 2:10 PM Changeset in webkit [173849] by
-
- 2 edits in branches/safari-600.1.4.11-branch/Source/WebKit2
Roll out r171775. <rdar://problem/17173916>
- 2:10 PM Changeset in webkit [173848] by
-
- 2 edits in trunk/Source/WebCore
WebSocket crash when a connection is closed from server side
https://bugs.webkit.org/show_bug.cgi?id=137009
rdar://problem/18333977
rdar://problem/12708225
Reviewed by Brady Eidson.
I don't think that this can be tested with our test server.
- Modules/websockets/WebSocketChannel.cpp:
(WebCore::WebSocketChannel::WebSocketChannel): Added logging.
(WebCore::WebSocketChannel::~WebSocketChannel): Ditto.
(WebCore::WebSocketChannel::close): Protect self, because startClosingHandshake
can release the last reference.
(WebCore::WebSocketChannel::fail): Added an assertion that the channel is always
closed after this function.
(WebCore::WebSocketChannel::startClosingHandshake): Protect self, and don't change
the stack from closed back to closing if after failing to send closing handshake.
(WebCore::WebSocketChannel::processOutgoingFrameQueue): Protect self.
- 1:25 PM Changeset in webkit [173847] by
-
- 2 edits in trunk/Source/JavaScriptCore
FTL allocatePropertyStorage code should involve less copy-paste
https://bugs.webkit.org/show_bug.cgi?id=137006
Reviewed by Michael Saboff.
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::allocatePropertyStorage):
(JSC::FTL::LowerDFGToLLVM::reallocatePropertyStorage):
(JSC::FTL::LowerDFGToLLVM::allocatePropertyStorageWithSizeImpl):
- 1:04 PM Changeset in webkit [173846] by
-
- 2 edits in branches/safari-600.1.4.11-branch/Source/WebKit2
Merged r171775. <rdar://problem/17173916>
- 12:52 PM Changeset in webkit [173845] by
-
- 3 edits2 adds in trunk
Bad cast in isValidColumnSpanner.
https://bugs.webkit.org/show_bug.cgi?id=133380.
Reviewed by Simon Fraser.
Source/WebCore:
Added fast/multicol/multicol-crazy-nesting.html
- rendering/RenderMultiColumnFlowThread.cpp:
(WebCore::isValidColumnSpanner):
The crawl up the chain looking for unsplittable objects should use containing blocks
and not be casting to parent boxes. You can have an inline in the parent chain, so
this was not the right way to walk up the tree.
LayoutTests:
- fast/multicol/multicol-crazy-nesting-expected.txt: Added.
- fast/multicol/multicol-crazy-nesting.html: Added.
- 12:01 PM Changeset in webkit [173844] by
-
- 1 move in branches/safari-600.1.4.10-branch
Fix typo.
- 11:55 AM Changeset in webkit [173843] by
-
- 3 edits2 adds in trunk
ASSERT in RenderMultiColumnSet::requiresBalancing.
https://bugs.webkit.org/show_bug.cgi?id=136376.
Reviewed by David Kilzer.
Source/WebCore:
Added fast/multicol/multicol-selection.html.
- rendering/RenderMultiColumnFlowThread.cpp:
(WebCore::isValidColumnSpanner):
Don't allow an object to become a spanner if it does not have the flow
thread as its containing block. Otherwise the flow thread won't get notified
of spanner placeholder insertions, and so the spanner ends up orphaned.
LayoutTests:
- fast/multicol/multicol-selection-expected.txt: Added.
- fast/multicol/multicol-selection.html: Added.
- 11:51 AM Changeset in webkit [173842] by
-
- 5 edits in branches/safari-600.1.4.11-branch/Source
Versioning.
- 11:36 AM Changeset in webkit [173841] by
-
- 2 edits in trunk/Tools
W3C importer should import html files within resources folders
https://bugs.webkit.org/show_bug.cgi?id=127548
Patch by Youenn Fablet <youennf@gmail.com> on 2014-09-22
Reviewed by Ryosuke Niwa.
Import HTML files in any folder named "resources" even if file is not detected as a HTML test file
- Scripts/webkitpy/w3c/test_importer.py:
(TestImporter.find_importable_tests):
- 11:35 AM Changeset in webkit [173840] by
-
- 2 edits in trunk/Source/WebCore
[Win] Implement cap height in SimpleFontDataWin to enable initial-letter support for Windows.
https://bugs.webkit.org/show_bug.cgi?id=136841
Reviewed by David Hyatt.
- platform/graphics/win/SimpleFontDataCGWin.cpp:
(WebCore::SimpleFontData::platformInit): Add missing calls to set up our fonts.
- 9:53 AM Changeset in webkit [173839] by
-
- 7 edits3 adds in trunk
Simple ES6 feature: Number constructor extras
https://bugs.webkit.org/show_bug.cgi?id=131707
Patch by Diego Pino Garcia <Diego Pino Garcia> on 2014-09-22
Reviewed by Darin Adler.
Source/JavaScriptCore:
- runtime/CommonIdentifiers.h: Added new identifiers.
- runtime/NumberConstructor.cpp:
(JSC::NumberConstructor::getOwnPropertySlot):
(JSC::NumberConstructor::isFunction): Added.
(JSC::numberConstructorEpsilonValue): Added.
(JSC::numberConstructorNegInfinity): Added.
(JSC::numberConstructorPosInfinity): Added.
(JSC::numberConstructorMaxValue): Added.
(JSC::numberConstructorMinValue): Added.
(JSC::numberConstructorMaxSafeInteger): Added.
(JSC::numberConstructorMinSafeInteger): Added.
(JSC::numberConstructorFuncIsFinite): Added.
(JSC::numberConstructorFuncIsInteger): Added.
(JSC::numberConstructorFuncIsNaN): Added.
(JSC::numberConstructorFuncIsSafeInteger): Added.
- runtime/NumberConstructor.h:
LayoutTests:
- js/Object-getOwnPropertyNames-expected.txt:
- js/number-constructor-expected.txt: Added.
- js/number-constructor.html: Added.
- js/script-tests/Object-getOwnPropertyNames.js:
- js/script-tests/number-constructor.js: Added.
- 8:51 AM Changeset in webkit [173838] by
-
- 2 edits in trunk/Source/WebCore
Update HTMLMediaElement logging
https://bugs.webkit.org/show_bug.cgi?id=136991
Reviewed by Alexey Proskuryakov.
No new tests, only logging was changed.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::HTMLMediaElement):
(WebCore::HTMLMediaElement::~HTMLMediaElement):
(WebCore::HTMLMediaElement::parseAttribute):
- 8:34 AM Changeset in webkit [173837] by
-
- 5 edits in trunk/Source/JavaScriptCore
FTL should store the four bytes of the cell header using a 32-bit store rather than four 8-bit stores
https://bugs.webkit.org/show_bug.cgi?id=136992
Reviewed by Sam Weinig.
LLVM ought to be able to do this optimization for us given how the code was written, but
any such lower-level attempts to optimize this would get into trouble with the weird
object materialization logic I'll be introducing in bug 136330. So, this brings the
merging of the byte stores into the FTL lowering so that we can control it explicitly.
- ftl/FTLAbstractHeap.h:
(JSC::FTL::AbstractHeap::changeParent):
- ftl/FTLAbstractHeapRepository.cpp:
(JSC::FTL::AbstractHeapRepository::AbstractHeapRepository):
- ftl/FTLAbstractHeapRepository.h:
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::allocateCell):
- 8:00 AM Changeset in webkit [173836] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION(r173631): It broke the !ENABLE(VIDEO) build
https://bugs.webkit.org/show_bug.cgi?id=136946
Reviewed by Jer Noble.
No new tests required, no new functionality.
- page/DragController.cpp:
(WebCore::DragController::startDrag):
- 7:47 AM Changeset in webkit [173835] by
-
- 6 edits in trunk/Source/WebCore
[CSSRegions] Use nullptr in regions code
https://bugs.webkit.org/show_bug.cgi?id=137001
Reviewed by Andrei Bucur.
No new tests as no new functionality is introduced.
- dom/DOMNamedFlowCollection.cpp:
(WebCore::DOMNamedFlowCollection::item):
(WebCore::DOMNamedFlowCollection::namedItem):
- dom/NamedFlowCollection.cpp:
(WebCore::NamedFlowCollection::flowByName):
- dom/WebKitNamedFlow.cpp:
(WebCore::WebKitNamedFlow::WebKitNamedFlow):
- rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::getLayerListForRegion):
(WebCore::RenderFlowThread::regionForCompositedLayer):
(WebCore::RenderFlowThread::regionAtBlockOffset):
(WebCore::RenderFlowThread::mapFromFlowToRegion):
(WebCore::RenderFlowThread::firstRegion):
(WebCore::RenderFlowThread::lastRegion):
(WebCore::RenderFlowThread::currentActiveRenderBox):
- rendering/RenderNamedFlowThread.cpp:
(WebCore::RenderNamedFlowThread::nextRendererForElement):
- 4:20 AM Changeset in webkit [173834] by
-
- 2 edits in releases/WebKitGTK/webkit-2.6/Tools
Merge r173832 - [GTK] Test /webkit2/WebKitWebView/can-show-mime-type fails if evince browser plugin is installed
https://bugs.webkit.org/show_bug.cgi?id=136998
Reviewed by Philippe Normand.
- TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
(testWebViewCanShowMIMEType): Remove the check of PDF as
unsupported MIME type.
- 4:19 AM WebKitGTK/2.6.x edited by
- (diff)
- 4:19 AM Changeset in webkit [173833] by
-
- 2 edits in releases/WebKitGTK/webkit-2.6/Source/WebCore/platform/gtk/po
Merge r173831 - [kn] Kannada Translation for webkit - Updated
https://bugs.webkit.org/show_bug.cgi?id=116941
Patch by Shankar Prasad <svenkate@redhat.com> on 2014-09-22
Reviewed by Philippe Normand.
- kn.po:
- 4:15 AM Changeset in webkit [173832] by
-
- 2 edits in trunk/Tools
[GTK] Test /webkit2/WebKitWebView/can-show-mime-type fails if evince browser plugin is installed
https://bugs.webkit.org/show_bug.cgi?id=136998
Reviewed by Philippe Normand.
- TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
(testWebViewCanShowMIMEType): Remove the check of PDF as
unsupported MIME type.
- 4:11 AM WebKitGTK/2.6.x edited by
- (diff)
- 4:10 AM Changeset in webkit [173831] by
-
- 2 edits in trunk/Source/WebCore/platform/gtk/po
[kn] Kannada Translation for webkit - Updated
https://bugs.webkit.org/show_bug.cgi?id=116941
Patch by Shankar Prasad <svenkate@redhat.com> on 2014-09-22
Reviewed by Philippe Normand.
- kn.po:
- 3:40 AM Changeset in webkit [173830] by
-
- 7 edits2 adds in releases/WebKitGTK/webkit-2.6
Merge r173806 - [CSS Regions] Assertion failure and null dereference crash when using animations and regions
https://bugs.webkit.org/show_bug.cgi?id=136918
Reviewed by Andrei Bucur.
Source/WebCore:
In some situations, for instance when an image has an attached animation, the style change caused by the animation
triggers a geometry update for the backing store associated with the image's layer. This may occur before
the layout for the image has finished.
Moreover, if the image in such situation - having a composited layer - is displayed in a region,
sicne the layout did not finish yet, the mappings between the layers of the elements collected in the named flow
and the regions associated with the named flow are not updated and cannot be used.
Therefore in those situations, we have to bail out early and use these mappings only after the layout has finished.
This patch also changes RenderLayerBacking method updateAfterDescendents -> updateAfterDescendants.
Test: fast/regions/animated-image-in-region.html
- rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::cachedRegionForCompositedLayer):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::calculateClipRects):
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateAfterDescendants):
- rendering/RenderLayerBacking.h:
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::rebuildCompositingLayerTree):
(WebCore::RenderLayerCompositor::updateLayerTreeGeometry):
(WebCore::RenderLayerCompositor::updateCompositingDescendantGeometry):
LayoutTests:
- fast/regions/animated-image-in-region-expected.txt: Added.
- fast/regions/animated-image-in-region.html: Added.
- 3:34 AM Changeset in webkit [173829] by
-
- 4 edits in releases/WebKitGTK/webkit-2.6/Source/WebCore
Merge r173800 - Fix post-mortem nits for r173724
https://bugs.webkit.org/show_bug.cgi?id=136986
Reviewed by Darin Adler.
Fix post-mortem nits for r173724.
No new tests, no behavior change.
- editing/EditingStyle.cpp:
(WebCore::HTMLAttributeEquivalent::attributeValueAsCSSValue):
(WebCore::HTMLFontSizeEquivalent::attributeValueAsCSSValue):
Use nullptr instead of 0.
- editing/SplitElementCommand.cpp:
(WebCore::SplitElementCommand::doUnapply):
Use getIdAttribute() / setIdAttribute().
- rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::computePreferredLogicalWidths):
Use fastHasAttribute() for nowrap and do an early return to avoid
calling styleOrColLogicalWidth() if the nowrap attribute is missing.
- 3:32 AM Changeset in webkit [173828] by
-
- 2 edits in releases/WebKitGTK/webkit-2.6/Source/JavaScriptCore
Merge r173787 - Leak of mallocs under StructureSet::OutOfLineList::create
https://bugs.webkit.org/show_bug.cgi?id=136970
Reviewed by Filip Pizlo.
addOutOfLine should free the old list when expanding the capacity.
- bytecode/StructureSet.cpp:
(JSC::StructureSet::addOutOfLine):
- 3:29 AM Changeset in webkit [173827] by
-
- 2 edits in releases/WebKitGTK/webkit-2.6/Source/WebCore
Merge r173767 - REGRESSION(r173464): It broke the !ENABLE(PICTURE_SIZES) build
https://bugs.webkit.org/show_bug.cgi?id=136942
Reviewed by Simon Fraser.
- html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::parseAttribute):
- 3:01 AM WebKitGTK/2.6.x edited by
- (diff)
- 2:56 AM Changeset in webkit [173826] by
-
- 2 edits in releases/WebKitGTK/webkit-2.6/Source/WebCore/platform/gtk/po
Merge r173824 - [l10n] [mr] WebKitGTK+ Marathi Translations
https://bugs.webkit.org/show_bug.cgi?id=136979
Patch by Sandeep Shedmake <sandeep.shedmake@gmail.com> on 2014-09-22
Reviewed by Philippe Normand.
- mr.po:
- 2:53 AM Changeset in webkit [173825] by
-
- 2 edits in trunk/Tools
Unreviewed. Fix WebKitGTKTranslations rule in watchlist.
In r145081 GTK+ translations were moved from Source/WebKit/gtk/po/
to Source/WebCore/platform/gtk/po/ but the rule was not updated.
- Scripts/webkitpy/common/config/watchlist: Use
Source/WebCore/platform/gtk/po/ as directory to watch for
WebKitGTKTranslations rule and add berto and myself to the list of
watchers.
- 2:48 AM Changeset in webkit [173824] by
-
- 2 edits in trunk/Source/WebCore/platform/gtk/po
[l10n] [mr] WebKitGTK+ Marathi Translations
https://bugs.webkit.org/show_bug.cgi?id=136979
Patch by Sandeep Shedmake <sandeep.shedmake@gmail.com> on 2014-09-22
Reviewed by Philippe Normand.
- mr.po:
- 2:47 AM WebKitGTK/2.6.x edited by
- (diff)
- 2:42 AM Changeset in webkit [173823] by
-
- 6 edits4 adds in releases/WebKitGTK/webkit-2.6
Merge r173809 - [GStreamer] Cannot play Vimeo video
https://bugs.webkit.org/show_bug.cgi?id=134969
Reviewed by Sergio Villar Senin.
Source/WebCore:
Ensure the GStreamer HTTP source element also sends cookies when
it's sending its requests. Some streaming platforms such as Vimeo
do server-side cookie checks on incoming requests before serving
media data.
Test: http/tests/media/hls/video-cookie.html
- platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
(webKitWebSrcStart): Set first-party cookie URL to the request so
the ResourceLoader properly sets cookies in the HTTP request.
LayoutTests:
New test for a HLS stream enforcing a specific cookie before
serving its fragments, like Vimeo does.
- http/tests/media/hls/video-cookie-expected.txt: Added.
- http/tests/media/hls/video-cookie.html: Added.
- http/tests/media/resources/hls/playlist-with-cookie.m3u8: Added.
- http/tests/media/resources/hls/sub-playlist-with-cookie.php: Added.
- http/tests/media/resources/video-cookie-check-cookie.php:
- platform/gtk/TestExpectations: Marked test as slow, as the other
HLS test.
- 2:41 AM WebKitGTK/2.6.x edited by
- (diff)
- 2:37 AM Changeset in webkit [173822] by
-
- 2 edits in releases/WebKitGTK/webkit-2.6/Source/WebCore/platform/gtk/po
Merge r173815 - [l10n] Updated Polish translation of WebKitGTK+
https://bugs.webkit.org/show_bug.cgi?id=136976
Patch by Piotr Drąg <piotrdrag@gmail.com> on 2014-09-22
Reviewed by Philippe Normand.
- pl.po:
- 2:36 AM Changeset in webkit [173821] by
-
- 2 edits in releases/WebKitGTK/webkit-2.6/Source/WebCore/platform/gtk/po
Merge r173814 - [l10n] Updated Hebrew translation of WebKitGTK+
https://bugs.webkit.org/show_bug.cgi?id=136678
Patch by Yosef Or Boczko <yoseforb@gnome.org> on 2014-09-22
Reviewed by Philippe Normand.
- he.po:
- 2:36 AM WebKitGTK/2.6.x edited by
- (diff)
- 2:35 AM Changeset in webkit [173820] by
-
- 2 edits in releases/WebKitGTK/webkit-2.6/Source/WebCore/platform/gtk/po
Merge r173813 - Webkit Tamil translations updated
https://bugs.webkit.org/show_bug.cgi?id=136816
Patch by Shantha kumar <shantha.thamizh@gmail.com> on 2014-09-22
Reviewed by Philippe Normand.
- ta.po:
- 2:34 AM Changeset in webkit [173819] by
-
- 2 edits in releases/WebKitGTK/webkit-2.6/Source/WebCore/platform/gtk/po
Merge r173812 - [as] Updated Assamese translations of WebKitGtk+
https://bugs.webkit.org/show_bug.cgi?id=136908
Patch by Nilamdyuti Goswami <ngoswami@redhat.com> on 2014-09-22
Reviewed by Philippe Normand.
- as.po:
- 2:33 AM Changeset in webkit [173818] by
-
- 2 edits in releases/WebKitGTK/webkit-2.6/Source/WebCore/platform/gtk/po
Merge r173811 - Odia (or_IN) translation for webkit
https://bugs.webkit.org/show_bug.cgi?id=136920
Patch by Manoj Kumar Giri <mgiri@redhat.com> on 2014-09-22
Reviewed by Philippe Normand.
- or.po:
- 2:32 AM Changeset in webkit [173817] by
-
- 2 edits in releases/WebKitGTK/webkit-2.6/Source/WebCore/platform/gtk/po
Merge r173810 - Webkit Gujarati Translations
https://bugs.webkit.org/show_bug.cgi?id=136525
Patch by Sweta Kothari <swkothar@redhat.com> on 2014-09-22
Reviewed by Philippe Normand.
- gu.po:
- 2:29 AM WebKitGTK/2.6.x edited by
- (diff)
- 2:29 AM WebKitGTK/2.6.x edited by
- (diff)
- 1:51 AM Changeset in webkit [173816] by
-
- 2 edits in trunk/Tools
Fix syntaxError in watchlist since r173594
https://bugs.webkit.org/show_bug.cgi?id=136996
Reviewed by Philippe Normand.
- Scripts/webkitpy/common/config/watchlist: Removed unnecessary comma.
- 1:44 AM WebKitGTK/2.6.x edited by
- (diff)
- 1:41 AM WebKitGTK/2.6.x edited by
- (diff)
- 1:36 AM Changeset in webkit [173815] by
-
- 2 edits in trunk/Source/WebCore/platform/gtk/po
[l10n] Updated Polish translation of WebKitGTK+
https://bugs.webkit.org/show_bug.cgi?id=136976
Patch by Piotr Drąg <piotrdrag@gmail.com> on 2014-09-22
Reviewed by Philippe Normand.
- pl.po:
- 1:34 AM Changeset in webkit [173814] by
-
- 2 edits in trunk/Source/WebCore/platform/gtk/po
[l10n] Updated Hebrew translation of WebKitGTK+
https://bugs.webkit.org/show_bug.cgi?id=136678
Patch by Yosef Or Boczko <yoseforb@gnome.org> on 2014-09-22
Reviewed by Philippe Normand.
- he.po:
- 1:33 AM Changeset in webkit [173813] by
-
- 2 edits in trunk/Source/WebCore/platform/gtk/po
Webkit Tamil translations updated
https://bugs.webkit.org/show_bug.cgi?id=136816
Patch by Shantha kumar <shantha.thamizh@gmail.com> on 2014-09-22
Reviewed by Philippe Normand.
- ta.po:
- 1:32 AM Changeset in webkit [173812] by
-
- 2 edits in trunk/Source/WebCore/platform/gtk/po
[as] Updated Assamese translations of WebKitGtk+
https://bugs.webkit.org/show_bug.cgi?id=136908
Patch by Nilamdyuti Goswami <ngoswami@redhat.com> on 2014-09-22
Reviewed by Philippe Normand.
- as.po:
- 1:30 AM Changeset in webkit [173811] by
-
- 2 edits in trunk/Source/WebCore/platform/gtk/po
Odia (or_IN) translation for webkit
https://bugs.webkit.org/show_bug.cgi?id=136920
Patch by Manoj Kumar Giri <mgiri@redhat.com> on 2014-09-22
Reviewed by Philippe Normand.
- or.po:
- 1:28 AM Changeset in webkit [173810] by
-
- 2 edits in trunk/Source/WebCore/platform/gtk/po
Webkit Gujarati Translations
https://bugs.webkit.org/show_bug.cgi?id=136525
Patch by Sweta Kothari <swkothar@redhat.com> on 2014-09-22
Reviewed by Philippe Normand.
- gu.po:
- 1:15 AM Changeset in webkit [173809] by
-
- 6 edits4 adds in trunk
[GStreamer] Cannot play Vimeo video
https://bugs.webkit.org/show_bug.cgi?id=134969
Reviewed by Sergio Villar Senin.
Source/WebCore:
Ensure the GStreamer HTTP source element also sends cookies when
it's sending its requests. Some streaming platforms such as Vimeo
do server-side cookie checks on incoming requests before serving
media data.
Test: http/tests/media/hls/video-cookie.html
- platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
(webKitWebSrcStart): Set first-party cookie URL to the request so
the ResourceLoader properly sets cookies in the HTTP request.
LayoutTests:
New test for a HLS stream enforcing a specific cookie before
serving its fragments, like Vimeo does.
- http/tests/media/hls/video-cookie-expected.txt: Added.
- http/tests/media/hls/video-cookie.html: Added.
- http/tests/media/resources/hls/playlist-with-cookie.m3u8: Added.
- http/tests/media/resources/hls/sub-playlist-with-cookie.php: Added.
- http/tests/media/resources/video-cookie-check-cookie.php:
- platform/gtk/TestExpectations: Marked test as slow, as the other
HLS test.
- 12:51 AM Changeset in webkit [173808] by
-
- 2 edits in trunk/Source/WebCore
Leverage RenderLayerBacking::renderer() instead of m_owningLayer.renderer()
https://bugs.webkit.org/show_bug.cgi?id=136954
Reviewed by Darin Adler.
No new tests just refactoring.
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateCompositedBounds):
(WebCore::RenderLayerBacking::updateDirectlyCompositedBackgroundImage):
(WebCore::RenderLayerBacking::paintIntoLayer):
- 12:20 AM Changeset in webkit [173807] by
-
- 6 edits in trunk/Source/WTF
Eliminate redundant PtrHash specializations
https://bugs.webkit.org/show_bug.cgi?id=136990
Patch by Sam Weinig <sam@webkit.org> on 2014-09-22
Reviewed by Darin Adler.
Now that we have IsSmartPtr, we can eliminate all the specializations
of PtrHash that we had (for RefPtr, OwnPtr, RetainPtr, and std::unique_ptr)
and instead just have one that uses GetPtrHelper.
No changes of behavior intended.
- wtf/GetPtr.h:
Remove unnecessary const_cast that Darin noticed.
- wtf/HashFunctions.h:
(WTF::PtrHash::hash): Deleted.
(WTF::PtrHash::equal): Deleted.
(WTF::PtrHash<RefPtr<P>>::hash): Deleted.
(WTF::PtrHash<RefPtr<P>>::equal): Deleted.
Specialize PtrHash based on whether the type is a smart pointer, and use GetPtrHelper
to implement the smart pointer specialized variant.
- wtf/HashMap.h:
Remove include of GetPtr.h that is now included by HashFunctions.h
- wtf/OwnPtr.h:
(WTF::PtrHash<OwnPtr<P>>::hash): Deleted.
(WTF::PtrHash<OwnPtr<P>>::equal): Deleted.
Remove unnecessary specialization of PtrHash.
- wtf/RetainPtr.h:
(WTF::PtrHash<RetainPtr<P>>::hash): Deleted.
(WTF::PtrHash<RetainPtr<P>>::equal): Deleted.
Specialize IsSmartPointer for RetainPtr and remove the then unnecessary specialization of PtrHash.
(This is already tested in the API test WTF/cf/RetainPtrHashing).
- 12:08 AM Changeset in webkit [173806] by
-
- 7 edits2 adds in trunk
[CSS Regions] Assertion failure and null dereference crash when using animations and regions
https://bugs.webkit.org/show_bug.cgi?id=136918
Reviewed by Andrei Bucur.
Source/WebCore:
In some situations, for instance when an image has an attached animation, the style change caused by the animation
triggers a geometry update for the backing store associated with the image's layer. This may occur before
the layout for the image has finished.
Moreover, if the image in such situation - having a composited layer - is displayed in a region,
sicne the layout did not finish yet, the mappings between the layers of the elements collected in the named flow
and the regions associated with the named flow are not updated and cannot be used.
Therefore in those situations, we have to bail out early and use these mappings only after the layout has finished.
This patch also changes RenderLayerBacking method updateAfterDescendents -> updateAfterDescendants.
Test: fast/regions/animated-image-in-region.html
- rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::cachedRegionForCompositedLayer):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::calculateClipRects):
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateAfterDescendants):
- rendering/RenderLayerBacking.h:
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::rebuildCompositingLayerTree):
(WebCore::RenderLayerCompositor::updateLayerTreeGeometry):
(WebCore::RenderLayerCompositor::updateCompositingDescendantGeometry):
LayoutTests:
- fast/regions/animated-image-in-region-expected.txt: Added.
- fast/regions/animated-image-in-region.html: Added.
Sep 21, 2014:
- 11:58 PM Changeset in webkit [173805] by
-
- 5 edits in trunk/Source
Web Inspector: fix TypeSet hierarchy in TypeTokenView
https://bugs.webkit.org/show_bug.cgi?id=136982
Reviewed by Joseph Pecoraro.
Source/JavaScriptCore:
TypeSet was computing the set of type booleans in the Inspector::Protocol::Runtime::TypeSet
object incorrectly because it was calling TypeSet::doesTypeConformTo(T) which checks if the
type set has only been of type T. It now checks '(m_seenTypes & T) != TypeNothing' to see
if type T is in the set of seen types, but not the entire set itself.
- runtime/TypeSet.cpp:
(JSC::TypeSet::inspectorTypeSet):
Source/WebInspectorUI:
The protocol object representation of TypeSet was being computed
incorrectly in JSC::TypeSet. This patch fixes that problem
and also asserts that the type information that the Web Inspector
receives is not empty.
- UserInterface/Models/TypeSet.js:
(WebInspector.TypeSet):
- UserInterface/Views/TypeTokenView.js:
(WebInspector.TypeTokenView.prototype._displayTypeName):
- 10:59 PM BadContent edited by
- add one more spammer (diff)
- 8:51 PM Changeset in webkit [173804] by
-
- 167 edits in trunk/Source
Generate Element casting helper functions
https://bugs.webkit.org/show_bug.cgi?id=136839
Reviewed by Darin Adler.
Source/WebCore:
Generate Element casting helper functions instead of requiring explicit
use of NODE_TYPE_CASTS() macro. Casting is now done using the following
form: downcast<HTMLDivElement>(), instead of toHTMLDivElement().
The previous form (i.e. toHTMLDivElement()) is still supported for now
by generating macros that convert these calls into the new form, until
the code base is ported to the new casting helpers.
The plan is also to use is<HTMLDivElement>() instead of
isHTMLDivElement() for consistency but this was not changed in this
patch to avoid blowing up the size.
This CL also updates the way we convert a JSValue into an
implementation pointer. Instead of using toHTMLDivElement(), which
looked like a cast, we now use JSHTMLDivElement::toWrapped(). This
avoids conflicting with the toXXXElement() macros and makes it
clearer this is not a simple cast.
No new tests, no behavior change.
- Modules/plugins/QuickTimePluginReplacement.mm:
(WebCore::QuickTimePluginReplacement::installReplacement):
- WebCore.exp.in:
- bindings/js/JSAudioBufferSourceNodeCustom.cpp:
(WebCore::JSAudioBufferSourceNode::setBuffer):
- bindings/js/JSBlobCustom.cpp:
(WebCore::constructJSBlob):
- bindings/js/JSCommandLineAPIHostCustom.cpp:
(WebCore::JSCommandLineAPIHost::getEventListeners):
(WebCore::JSCommandLineAPIHost::databaseId):
(WebCore::JSCommandLineAPIHost::storageId):
- bindings/js/JSDOMFormDataCustom.cpp:
(WebCore::toHTMLFormElementOrNull):
(WebCore::constructJSDOMFormData):
(WebCore::JSDOMFormData::append):
(WebCore::toHTMLFormElement): Deleted.
- bindings/js/JSDOMStringListCustom.cpp:
(WebCore::JSDOMStringList::toWrapped):
(WebCore::toDOMStringList): Deleted.
- bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::toWrapped):
(WebCore::toDOMWindow): Deleted.
- bindings/js/JSDictionary.cpp:
(WebCore::JSDictionary::convertValue):
- bindings/js/JSDocumentCustom.cpp:
(WebCore::JSDocument::createTouchList):
- bindings/js/JSEventTargetCustom.cpp:
(WebCore::JSEventTarget::toWrapped):
(WebCore::toEventTarget): Deleted.
- bindings/js/JSExceptionBase.cpp:
(WebCore::toExceptionBase):
- bindings/js/JSHTMLMediaElementCustom.cpp:
(WebCore::JSHTMLMediaElement::setController):
- bindings/js/JSHTMLOptionsCollectionCustom.cpp:
(WebCore::JSHTMLOptionsCollection::add):
(WebCore::JSHTMLOptionsCollection::remove):
- bindings/js/JSHTMLSelectElementCustom.cpp:
(WebCore::JSHTMLSelectElement::remove):
(WebCore::selectIndexSetter):
- bindings/js/JSInspectorFrontendHostCustom.cpp:
(WebCore::JSInspectorFrontendHost::showContextMenu):
- bindings/js/JSMessageEventCustom.cpp:
(WebCore::handleInitMessageEvent):
- bindings/js/JSMessagePortCustom.cpp:
(WebCore::fillMessagePortArray):
- bindings/js/JSNodeCustom.cpp:
(WebCore::JSNode::insertBefore):
(WebCore::JSNode::replaceChild):
(WebCore::JSNode::removeChild):
(WebCore::JSNode::appendChild):
- bindings/js/JSNodeFilterCustom.cpp:
(WebCore::JSNodeFilter::toWrapped):
(WebCore::toNodeFilter): Deleted.
- bindings/js/JSSubtleCryptoCustom.cpp:
(WebCore::JSSubtleCrypto::encrypt):
(WebCore::JSSubtleCrypto::decrypt):
(WebCore::JSSubtleCrypto::sign):
(WebCore::JSSubtleCrypto::verify):
(WebCore::JSSubtleCrypto::exportKey):
(WebCore::JSSubtleCrypto::wrapKey):
(WebCore::JSSubtleCrypto::unwrapKey):
- bindings/js/JSWebGLRenderingContextCustom.cpp:
(WebCore::JSWebGLRenderingContext::getAttachedShaders):
(WebCore::JSWebGLRenderingContext::getProgramParameter):
(WebCore::JSWebGLRenderingContext::getShaderParameter):
(WebCore::JSWebGLRenderingContext::getUniform):
(WebCore::dataFunctionf):
(WebCore::dataFunctioni):
(WebCore::dataFunctionMatrix):
- bindings/js/JSXMLHttpRequestCustom.cpp:
(WebCore::JSXMLHttpRequest::send):
- bindings/js/SerializedScriptValue.cpp:
(WebCore::CloneSerializer::dumpIfTerminal):
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
(GenerateImplementation):
(GenerateParametersCheck):
(JSValueToNative):
- bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:
(WebCore::jsTestActiveDOMObjectPrototypeFunctionExcitingFunction):
(WebCore::JSTestActiveDOMObject::toWrapped):
(WebCore::toTestActiveDOMObject): Deleted.
- bindings/scripts/test/JS/JSTestActiveDOMObject.h:
- bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp:
(WebCore::JSTestCustomNamedGetter::toWrapped):
(WebCore::toTestCustomNamedGetter): Deleted.
- bindings/scripts/test/JS/JSTestCustomNamedGetter.h:
- bindings/scripts/test/JS/JSTestEventConstructor.cpp:
(WebCore::JSTestEventConstructor::toWrapped):
(WebCore::toTestEventConstructor): Deleted.
- bindings/scripts/test/JS/JSTestEventConstructor.h:
- bindings/scripts/test/JS/JSTestEventTarget.cpp:
(WebCore::jsTestEventTargetPrototypeFunctionDispatchEvent):
(WebCore::JSTestEventTarget::toWrapped):
(WebCore::toTestEventTarget): Deleted.
- bindings/scripts/test/JS/JSTestEventTarget.h:
- bindings/scripts/test/JS/JSTestException.cpp:
(WebCore::JSTestException::toWrapped):
(WebCore::toTestException): Deleted.
- bindings/scripts/test/JS/JSTestException.h:
- bindings/scripts/test/JS/JSTestGenerateIsReachable.cpp:
(WebCore::JSTestGenerateIsReachable::toWrapped):
(WebCore::toTestGenerateIsReachable): Deleted.
- bindings/scripts/test/JS/JSTestGenerateIsReachable.h:
- bindings/scripts/test/JS/JSTestInterface.cpp:
(WebCore::setJSTestInterfaceImplementsNode):
(WebCore::setJSTestInterfaceSupplementalNode):
(WebCore::jsTestInterfacePrototypeFunctionImplementsMethod2):
(WebCore::jsTestInterfacePrototypeFunctionSupplementalMethod2):
(WebCore::JSTestInterface::toWrapped):
(WebCore::toTestInterface): Deleted.
- bindings/scripts/test/JS/JSTestInterface.h:
- bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
(WebCore::JSTestMediaQueryListListener::toWrapped):
(WebCore::toTestMediaQueryListListener): Deleted.
- bindings/scripts/test/JS/JSTestMediaQueryListListener.h:
- bindings/scripts/test/JS/JSTestNamedConstructor.cpp:
(WebCore::JSTestNamedConstructor::toWrapped):
(WebCore::toTestNamedConstructor): Deleted.
- bindings/scripts/test/JS/JSTestNamedConstructor.h:
- bindings/scripts/test/JS/JSTestNondeterministic.cpp:
(WebCore::JSTestNondeterministic::toWrapped):
(WebCore::toTestNondeterministic): Deleted.
- bindings/scripts/test/JS/JSTestNondeterministic.h:
- bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::setJSTestObjTestObjAttr):
(WebCore::setJSTestObjXMLObjAttr):
(WebCore::setJSTestObjWithScriptExecutionContextAttribute):
(WebCore::setJSTestObjWithScriptStateAttributeRaises):
(WebCore::setJSTestObjWithScriptExecutionContextAttributeRaises):
(WebCore::setJSTestObjWithScriptExecutionContextAndScriptStateAttribute):
(WebCore::setJSTestObjWithScriptExecutionContextAndScriptStateAttributeRaises):
(WebCore::setJSTestObjWithScriptExecutionContextAndScriptStateWithSpacesAttribute):
(WebCore::setJSTestObjWithScriptArgumentsAndCallStackAttribute):
(WebCore::setJSTestObjMutablePoint):
(WebCore::setJSTestObjImmutablePoint):
(WebCore::jsTestObjPrototypeFunctionVoidMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionByteMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionOctetMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionLongMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionObjMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionMethodWithSequenceArg):
(WebCore::jsTestObjPrototypeFunctionMethodThatRequiresAllArgsAndThrows):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod1):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod2):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod8):
(WebCore::jsTestObjPrototypeFunctionConvert1):
(WebCore::jsTestObjPrototypeFunctionConvert2):
(WebCore::jsTestObjPrototypeFunctionConvert4):
(WebCore::jsTestObjPrototypeFunctionConvert5):
(WebCore::jsTestObjPrototypeFunctionStrictFunctionWithSequence):
(WebCore::jsTestObjPrototypeFunctionStrictFunctionWithArray):
(WebCore::jsTestObjPrototypeFunctionVariadicNodeMethod):
(WebCore::JSTestObj::toWrapped):
(WebCore::toTestObj): Deleted.
- bindings/scripts/test/JS/JSTestObj.h:
- bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:
(WebCore::JSTestOverloadedConstructorsConstructor::constructJSTestOverloadedConstructors3):
(WebCore::JSTestOverloadedConstructors::toWrapped):
(WebCore::toTestOverloadedConstructors): Deleted.
- bindings/scripts/test/JS/JSTestOverloadedConstructors.h:
- bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
(WebCore::JSTestSerializedScriptValueInterface::toWrapped):
(WebCore::toTestSerializedScriptValueInterface): Deleted.
- bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h:
- bindings/scripts/test/JS/JSTestTypedefs.cpp:
(WebCore::jsTestTypedefsPrototypeFunctionMethodWithSequenceArg):
(WebCore::jsTestTypedefsPrototypeFunctionCallWithSequenceThatRequiresInclude):
(WebCore::JSTestTypedefs::toWrapped):
(WebCore::toTestTypedefs): Deleted.
- bindings/scripts/test/JS/JSTestTypedefs.h:
- bindings/scripts/test/JS/JSattribute.cpp:
(WebCore::JSattribute::toWrapped):
(WebCore::toattribute): Deleted.
- bindings/scripts/test/JS/JSattribute.h:
- bindings/scripts/test/JS/JSreadonly.cpp:
(WebCore::JSreadonly::toWrapped):
(WebCore::toreadonly): Deleted.
- bindings/scripts/test/JS/JSreadonly.h:
- dom/Element.h:
(WebCore::downcast):
- dom/make_names.pl:
(printTypeHelpers):
- html/HTMLAnchorElement.h:
- html/HTMLAreaElement.h:
- html/HTMLAudioElement.h:
- html/HTMLBaseElement.h:
- html/HTMLBodyElement.h:
- html/HTMLCanvasElement.h:
- html/HTMLDataListElement.h:
- html/HTMLDetailsElement.h:
- html/HTMLDivElement.h:
- html/HTMLEmbedElement.h:
- html/HTMLFieldSetElement.h:
- html/HTMLFormElement.h:
- html/HTMLFrameElement.h:
- html/HTMLFrameSetElement.h:
- html/HTMLHtmlElement.h:
- html/HTMLIFrameElement.h:
- html/HTMLImageElement.h:
- html/HTMLInputElement.h:
- html/HTMLLabelElement.h:
- html/HTMLLegendElement.h:
- html/HTMLLinkElement.h:
- html/HTMLMapElement.h:
- html/HTMLMarqueeElement.h:
- html/HTMLMetaElement.h:
- html/HTMLMeterElement.h:
- html/HTMLOListElement.h:
- html/HTMLObjectElement.h:
- html/HTMLOptGroupElement.h:
- html/HTMLOptionElement.h:
- html/HTMLParamElement.h:
- html/HTMLProgressElement.h:
- html/HTMLScriptElement.h:
- html/HTMLSelectElement.h:
- html/HTMLSourceElement.h:
- html/HTMLStyleElement.h:
- html/HTMLSummaryElement.h:
- html/HTMLTableCaptionElement.h:
- html/HTMLTableElement.h:
- html/HTMLTableRowElement.h:
- html/HTMLTemplateElement.h:
- html/HTMLTextAreaElement.h:
- html/HTMLTitleElement.h:
- html/HTMLTrackElement.h:
- html/HTMLVideoElement.h:
- inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::scriptValueAsNode):
- mathml/MathMLMencloseElement.h:
- svg/SVGAltGlyphDefElement.h:
- svg/SVGAltGlyphElement.h:
- svg/SVGAltGlyphItemElement.h:
- svg/SVGAnimateMotionElement.h:
- svg/SVGAnimateTransformElement.h:
- svg/SVGCircleElement.h:
- svg/SVGClipPathElement.h:
- svg/SVGCursorElement.h:
- svg/SVGEllipseElement.h:
- svg/SVGFEDistantLightElement.h:
- svg/SVGFEFuncAElement.h:
- svg/SVGFEFuncBElement.h:
- svg/SVGFEFuncGElement.h:
- svg/SVGFEFuncRElement.h:
- svg/SVGFEMergeNodeElement.h:
- svg/SVGFEPointLightElement.h:
- svg/SVGFESpotLightElement.h:
- svg/SVGFilterElement.h:
- svg/SVGFontElement.h:
- svg/SVGFontFaceElement.h:
- svg/SVGFontFaceNameElement.h:
- svg/SVGFontFaceSrcElement.h:
- svg/SVGFontFaceUriElement.h:
- svg/SVGForeignObjectElement.h:
- svg/SVGGlyphElement.h:
- svg/SVGGlyphRefElement.h:
- svg/SVGHKernElement.h:
- svg/SVGImageElement.h:
- svg/SVGLineElement.h:
- svg/SVGLinearGradientElement.h:
- svg/SVGMPathElement.h:
- svg/SVGMarkerElement.h:
- svg/SVGMaskElement.h:
- svg/SVGMissingGlyphElement.h:
- svg/SVGPathElement.h:
- svg/SVGPatternElement.h:
- svg/SVGPolygonElement.h:
- svg/SVGPolylineElement.h:
- svg/SVGRadialGradientElement.h:
- svg/SVGRectElement.h:
- svg/SVGSVGElement.h:
- svg/SVGScriptElement.h:
- svg/SVGStopElement.h:
- svg/SVGStyleElement.h:
- svg/SVGTextElement.h:
- svg/SVGTextPathElement.h:
- svg/SVGTitleElement.h:
- svg/SVGUseElement.h:
- svg/SVGVKernElement.h:
- svg/SVGViewElement.h:
Source/WebKit:
Update some of the exported symbols on Windows for functions that were
renamed.
- WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
Source/WebKit/mac:
Use JSXXX::toWrapped() instead of toXXX() function.
- DOM/WebDOMOperations.mm:
- WebView/WebView.mm:
(-[WebView _notificationIDForTesting:]):
Source/WebKit/win:
Use JSXXX::toWrapped() instead of toXXX() function.
- WebView.cpp:
(WebView::elementFromJS):
Source/WebKit2:
Use JSXXX::toWrapped() instead of toXXX() function.
- WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:
(WebKit::InjectedBundleNodeHandle::getOrCreate):
- WebProcess/InjectedBundle/DOM/InjectedBundleRangeHandle.cpp:
(WebKit::InjectedBundleRangeHandle::getOrCreate):
- WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::webNotificationID):
- 8:42 PM Changeset in webkit [173803] by
-
- 3 edits in trunk/Source/WebInspectorUI
Web Inspector: unlocalized 'many' string in type profiler inline bubble
https://bugs.webkit.org/show_bug.cgi?id=136980
Reviewed by Timothy Hatcher.
Generate the localizable string for the type profiler's "many" inline bubble.
- Localizations/en.lproj/localizedStrings.js:
- UserInterface/Views/TypeTokenView.js:
- 5:31 PM Changeset in webkit [173802] by
-
- 3 edits in trunk/Source/WebKit/mac
Leak: WebNotificationPrivate ObjC leaks seen on leaks bot
https://bugs.webkit.org/show_bug.cgi?id=136972
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-09-21
Reviewed by Darin Adler.
- WebView/WebNotification.h:
- WebView/WebNotification.mm:
(-[WebNotification initWithCoreNotification:notificationID:]):
Switch to RetainPtr and adopt into _private to ensure when we are
deallocated that _private will get deallocated.
- 5:24 PM Changeset in webkit [173801] by
-
- 15 edits1 move1 add in trunk
Make possible HashSet<std::unique_ptr<>>
https://bugs.webkit.org/show_bug.cgi?id=136166
Reviewed by Darin Adler.
Source/WTF:
- wtf/GetPtr.h:
(WTF::getPtr):
(WTF::GetPtrHelper<std::unique_ptr<T>>::getPtr):
Make specializing GetPtrHelper a bit cleaner (you don't have to put
IsSmartPtr<T>::value everywhere any more) and add specializations for
std::unique_ptr.
- wtf/HashFunctions.h:
(WTF::PtrHash<std::unique_ptr<P>>):
Add specialization for PtrHash for std::unique_ptr and set it as the DefaultHash
for it as well.
- wtf/HashMap.h:
- wtf/HashSet.h:
Add overloads of find(), contains(), remove(), take() (and get() for HashMap) for "smart pointers" that
take the raw pointer type as the parameter. These use SFINAE to make themselves only available
when the IsSmartPtr<KeyType>::value is true.
- wtf/HashTraits.h:
Override constructDeletedValue() and isDeletedValue() in the std::unique_ptr specialization
since the default implementation depends on the type having a constructor that takes a HashTableDeletedValue
and function named isHashTableDeletedValue().
- wtf/OwnPtr.h:
(WTF::OwnPtr::OwnPtr):
(WTF::OwnPtr::isHashTableDeletedValue):
(WTF::OwnPtr::hashTableDeletedValue):
Add HashTableDeletedValue constructor/functions to allow the constructDeletedValue() and isDeletedValue()
hash traits to work.
(WTF::PtrHash<OwnPtr<P>>::hash):
(WTF::PtrHash<OwnPtr<P>>::equal):
Add specialization for PtrHash for OwnPtr and set it as the DefaultHash
for it as well.
- wtf/Ref.h:
Update for the less verbose GetPtrHelper specialization.
Tools:
- TestWebKitAPI/Tests/WTF/CopyMoveCounter.h: Removed.
- TestWebKitAPI/Counters.cpp: Added.
- TestWebKitAPI/Counters.h: Copied from Tools/TestWebKitAPI/Tests/WTF/CopyMoveCounter.h.
Move the CopyMoveCounter helper from CopyMoveCounter.h to Counters.h, and add a ConstructorDestructorCounter
helper to the mix as well. Add Counters.cpp to allow for the global variables to be used in more than one
translation unit.
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
Add new files.
- TestWebKitAPI/Tests/WTF/HashMap.cpp:
Add tests for using std::unique_ptr and OwnPtr as the key's of a HashMap.
- TestWebKitAPI/Tests/WTF/HashSet.cpp:
Add tests for using std::unique_ptr and OwnPtr as the values of a HashSet.
- 5:18 PM Changeset in webkit [173800] by
-
- 4 edits in trunk/Source/WebCore
Fix post-mortem nits for r173724
https://bugs.webkit.org/show_bug.cgi?id=136986
Reviewed by Darin Adler.
Fix post-mortem nits for r173724.
No new tests, no behavior change.
- editing/EditingStyle.cpp:
(WebCore::HTMLAttributeEquivalent::attributeValueAsCSSValue):
(WebCore::HTMLFontSizeEquivalent::attributeValueAsCSSValue):
Use nullptr instead of 0.
- editing/SplitElementCommand.cpp:
(WebCore::SplitElementCommand::doUnapply):
Use getIdAttribute() / setIdAttribute().
- rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::computePreferredLogicalWidths):
Use fastHasAttribute() for nowrap and do an early return to avoid
calling styleOrColLogicalWidth() if the nowrap attribute is missing.
- 4:52 PM Changeset in webkit [173799] by
-
- 5 edits in trunk/Source/JavaScriptCore
Structure should have a method for concurrently getting all of the property map entries, and this method shouldn't involve copy-paste
https://bugs.webkit.org/show_bug.cgi?id=136983
Reviewed by Mark Hahnenberg.
- runtime/PropertyMapHashTable.h:
(JSC::PropertyMapEntry::PropertyMapEntry): Moved PropertyMapEntry struct to Structure.h so that Structure can refer to it.
- runtime/Structure.cpp:
(JSC::Structure::getConcurrently): Switch to using the new forEachPropertyConcurrently() method.
(JSC::Structure::getPropertiesConcurrently): The subject of this patch. It will be useful for object allocation sinking (bug 136330).
(JSC::Structure::dump): Switch to using the new forEachPropertyConcurrently() method.
- runtime/Structure.h:
(JSC::PropertyMapEntry::PropertyMapEntry): Moved from PropertyMapHashTable.h.
- runtime/StructureInlines.h:
(JSC::Structure::forEachPropertyConcurrently): Capture this very common concurrent structure iteration pattern into a template method.
- 1:30 PM Changeset in webkit [173798] by
-
- 2 edits in trunk/Tools
run-webkit-tests should count tests submitted as absolute paths once
https://bugs.webkit.org/show_bug.cgi?id=136848
Patch by Youenn Fablet <youenn.fablet@crf.canon.fr> on 2014-09-21
Reviewed by Darin Adler.
- Scripts/webkitpy/port/base.py:
(Port._expanded_paths): In case of absolute path, do not search for platform specific tests.
- 12:18 PM Changeset in webkit [173797] by
-
- 16 edits in trunk/Source/JavaScriptCore
Structure::getConcurrently() doesn't need to take a VM& argument.
Rubber stamped by Dan Bernstein.
Removed the extra argument, and then removed similar arguments from other methods until
I could build successfully again. It turned out that many methods took a VM& argument
just for calling getConcurrently().
- bytecode/CodeBlock.cpp:
(JSC::dumpStructure):
(JSC::dumpChain):
(JSC::CodeBlock::printGetByIdCacheStatus):
(JSC::CodeBlock::printPutByIdCacheStatus):
- bytecode/ComplexGetStatus.cpp:
(JSC::ComplexGetStatus::computeFor):
- bytecode/GetByIdStatus.cpp:
(JSC::GetByIdStatus::computeFromLLInt):
(JSC::GetByIdStatus::computeForStubInfo):
(JSC::GetByIdStatus::computeFor):
- bytecode/GetByIdStatus.h:
- bytecode/PutByIdStatus.cpp:
(JSC::PutByIdStatus::computeFromLLInt):
(JSC::PutByIdStatus::computeForStubInfo):
(JSC::PutByIdStatus::computeFor):
- bytecode/PutByIdStatus.h:
- dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
- dfg/DFGConstantFoldingPhase.cpp:
(JSC::DFG::ConstantFoldingPhase::foldConstants):
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::isStringPrototypeMethodSane):
- runtime/IntendedStructureChain.cpp:
(JSC::IntendedStructureChain::mayInterceptStoreTo):
- runtime/IntendedStructureChain.h:
- runtime/Structure.cpp:
(JSC::Structure::getConcurrently):
- runtime/Structure.h:
- runtime/StructureInlines.h:
(JSC::Structure::getConcurrently):
- 11:26 AM Changeset in webkit [173796] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, speculative build fix.
If you use typed arrays, you gotta include runtime/TypedArrayInlines.h.
- platform/graphics/avfoundation/objc/CDMSessionMediaSourceAVFObjC.mm:
