Timeline



Sep 24, 2014:

9:30 PM Changeset in webkit [173946] by dbates@webkit.org
  • 2 edits in trunk/Source/WebKit/ios

[iOS] Another iOS build fix; workaround for CoreLocation
​https://bugs.webkit.org/show_bug.cgi?id=137104
<rdar://problem/18450785>

Rubber-stamped by Benjamin Poulain.

Workaround CoreLocation issue by adding a default statement in -[WebGeolocationCoreLocationProvider requestGeolocationAuthorization]
and -[WebGeolocationCoreLocationProvider locationManager:didChangeAuthorizationStatus:].
We'll remove these default statements once we have the fix for <rdar://problem/18448331>.

  • Misc/WebGeolocationCoreLocationProvider.mm:

(-[WebGeolocationCoreLocationProvider requestGeolocationAuthorization]):
(-[WebGeolocationCoreLocationProvider locationManager:didChangeAuthorizationStatus:]):

9:02 PM Changeset in webkit [173945] by Chris Dumez
  • 2 edits in trunk/Source/WebCore

Use tighter typing for render objects in RenderGeometryMap
​https://bugs.webkit.org/show_bug.cgi?id=137102

Reviewed by Ryosuke Niwa.

Use tighter typing for render objects in RenderGeometryMap for clarity
and efficiency.

In particular, using RenderElement type instead of RenderObject
in canMapBetweenRenderers() allows us to call the faster
RenderElement::style() instead of RenderObject::style().

No new tests, no behavior change.

  • rendering/RenderGeometryMap.cpp:

(WebCore::canMapBetweenRenderers):
(WebCore::RenderGeometryMap::pushMappingsToAncestor):

8:50 PM Changeset in webkit [173944] by Chris Dumez
  • 39 edits in trunk/Source

Add initial is<>() / downcast<>() support for any type of Nodes
​https://bugs.webkit.org/show_bug.cgi?id=137056

Reviewed by Benjamin Poulain.

Source/WebCore:

Add initial is<>() / downcast<>() support for any type of Nodes, not
just Elements by:

  • Moving the is<>() / downcast<>() declarations from Element.h to Node.h
  • Introducing a SPECIALIZE_TYPE_TRAITS_*() macro that generates the needed template specializations for is<>() / downcast<>() to work. This macro will replace NODE_TYPE_CASTS() entirely once the code base is fully ported.

This patch makes use of SPECIALIZE_TYPE_TRAITS_*() macro for
HTMLFormControlElement, that is an HTMLElement for which the template
specializations cannot be automatically generated because it requires
special handling.

This patch also makes use of SPECIALIZE_TYPE_TRAITS_*() macro for
DocumentFragment to show that it can be used for non-Element Nodes.

No new tests, no behavior change.

  • accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::isReadOnly):
(WebCore::AccessibilityNodeObject::isRequired):
(WebCore::AccessibilityNodeObject::isControl):

  • css/SelectorCheckerTestFunctions.h:

(WebCore::isAutofilled):
(WebCore::isDisabled):
(WebCore::isEnabled):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::canShareStyleWithElement):
(WebCore::StyleResolver::adjustRenderStyle):

  • dom/Document.cpp:

(WebCore::Document::importNode):
(WebCore::Document::setFocusedElement):

  • dom/DocumentFragment.h:

(WebCore::isDocumentFragment):

  • dom/Element.cpp:

(WebCore::Element::focus):

  • dom/Element.h:

(WebCore::is): Deleted.
(WebCore::downcast): Deleted.

  • dom/Node.h:

(WebCore::is):
(WebCore::downcast):

  • dom/make_names.pl:

(printTypeHelpers):

  • editing/FrameSelection.cpp:

(WebCore::scanForForm):

  • editing/TextIterator.cpp:

(WebCore::isRendererReplacedElement):

  • html/FormAssociatedElement.h:
  • html/HTMLElement.h:
  • html/HTMLFieldSetElement.cpp:

(WebCore::updateFromControlElementsAncestorDisabledStateUnder):
(WebCore::HTMLFieldSetElement::refreshElementsIfNeeded):

  • html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElement::enclosingFormControlElement):

  • html/HTMLFormControlElement.h:

(WebCore::isHTMLFormControlElement):

  • html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::submitImplicitly):
(WebCore::submitElementFromEvent):
(WebCore::HTMLFormElement::validateInteractively):
(WebCore::HTMLFormElement::submit):
(WebCore::HTMLFormElement::reset):
(WebCore::HTMLFormElement::formElementIndex):
(WebCore::HTMLFormElement::defaultButton):
(WebCore::HTMLFormElement::checkInvalidControlsAndCollectUnhandled):
(WebCore::HTMLFormElement::documentDidResumeFromPageCache):

  • html/HTMLMediaElement.h:
  • html/HTMLPlugInImageElement.h:
  • html/HTMLSummaryElement.cpp:

(WebCore::isClickableControl):

  • html/LabelableElement.h:
  • html/RadioNodeList.cpp:

(WebCore::RadioNodeList::checkElementMatchesRadioNodeListFilter):
(WebCore::RadioNodeList::elementMatches):

  • html/parser/HTMLConstructionSite.cpp:

(WebCore::HTMLConstructionSite::findFosterSite):

  • html/parser/HTMLTreeBuilder.cpp:

(WebCore::disallowTelephoneNumberParsing):

  • loader/FormSubmission.cpp:

(WebCore::FormSubmission::create):

  • mathml/MathMLElement.h:
  • page/ContextMenuController.cpp:

(WebCore::ContextMenuController::populate):

  • page/Frame.cpp:

(WebCore::Frame::searchForLabelsBeforeElement):

  • rendering/RenderButton.cpp:

(WebCore::RenderButton::formControlElement):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::resize):

  • rendering/RenderTheme.cpp:

(WebCore::RenderTheme::isReadOnlyControl):

  • svg/SVGElement.h:
  • svg/SVGFilterPrimitiveStandardAttributes.h:
  • svg/animation/SVGSMILElement.h:

Source/WebKit/mac:

Use is<HTMLFormControlElement>() / downcast<HTMLFormControlElement>()
instead of isFormControlElement() / toHTMLFormControlElement().

  • WebView/WebHTMLRepresentation.mm:

(searchForLabelsBeforeElement):

Source/WebKit/win:

Use is<HTMLFormControlElement>() / downcast<HTMLFormControlElement>()
instead of isFormControlElement() / toHTMLFormControlElement().

  • WebFrame.cpp:

(WebFrame::elementWithName):

7:53 PM Changeset in webkit [173943] by Darin Adler
  • 8 edits
    3 adds in trunk

Old Turkic characters behave as left-to-right instead of right-to-left, because they are encoded as surrogate pairs.
​https://bugs.webkit.org/show_bug.cgi?id=70029

Reviewed by Dan Bernstein.

Source/WebCore:

Test: fast/text/international/old-turkic-direction.html

  • CMakeLists.txt: Added InlineIterator.cpp.
  • WebCore.vcxproj/WebCore.vcxproj: Ditto.
  • WebCore.vcxproj/WebCore.vcxproj.filters: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • rendering/RenderingAllInOne.cpp: Ditto.
  • rendering/InlineIterator.cpp: Added.

(WebCore::InlineIterator::surrogateTextDirection): New function used to compute the direction
when a surrogate pair is involved.

  • rendering/InlineIterator.h: Made the characterAt function private.

(WebCore::InlineIterator::previousInSameNode): Took out unneeded range check. A zero will underflow
and become a large number and the characterAt function will return 0 in that case.
(WebCore::InlineIterator::direction): Added code to check U16_IS_SINGLE before calling
u_charDirection, and call surrogateTextDirection instead.

LayoutTests:

  • fast/text/international/old-turkic-direction.html: Added.
  • fast/text/international/old-turkic-direction-expected.html: Added.
7:46 PM Changeset in webkit [173942] by Chris Dumez
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix after r173941.

Rename shadow to m_shadow.

  • rendering/TextPainter.h:

(WebCore::ShadowApplier::shadowIsCompletelyCoveredByText):

7:32 PM Changeset in webkit [173941] by mmaxfield@apple.com
  • 9 edits
    2 deletes in trunk

REGRESSION: Text with a zero offset, zero blur shadow vanishes
​https://bugs.webkit.org/show_bug.cgi?id=136801

Reviewed by Darin Adler.

Source/WebCore:

This patch performs some cleanup regarding TextPainter's shadow logic and handles an
additional case of empty shadows. Previously, there was tight coupling between
applyShadowToGraphicalContext() and paintTextWithShadows(), as they both used a
collection of variables to determine how shadows are to be drawn. This complexity has
been moved into a helper class, ShadowApplier, which performs what
applyShadowToGraphicsContext() used to do, and cleans up correctly in its destructor.
This removes the tight coupling mentioned earlier.

Test: fast/text/empty-shadow.html

  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::applyShadowToGraphicsContext): Moved to ShadowApplier.

  • rendering/InlineTextBox.h: Deleted applyShadowToGraphicsContext signature.
  • rendering/TextPainter.cpp:

(WebCore::ShadowApplier::ShadowApplier): Perform the contents of applyShadowToGraphicsContext()
(WebCore::ShadowApplier::~ShadowApplier): Undo the work done previously
(WebCore::paintTextWithShadows): Create a ShadowApplier to do the relevant shadow work. In addition,
refactor some boolean flags to more meaningful ones with relation to the computation at hand.
(WebCore::isEmptyShadow): Moved to TextPainter.h, named shadowIsCompletelyCoveredByText()

  • rendering/TextPainter.h:

(WebCore::ShadowApplier::ShadowApplier): Moved from InlineTextBox::applyShadowToGraphicsContext().
(WebCore::ShadowApplier::extraOffset): Getter.
(WebCore::ShadowApplier::~ShadowApplier): Moved from TextPainter::paintTextWithShadows().
(WebCore::isLastShadowIteration): Helper function.
(WebCore::shadowIsCompletelyCoveredByText): Determines whether or not we should not draw the shadow.

  • rendering/svg/SVGInlineTextBox.cpp:

(WebCore::SVGInlineTextBox::paintTextWithShadows): Update to use ShadowApplier.

LayoutTests:

This test should be a comprehensive test of empty shadows. It tests every
combination of one and two shadows being empty, as well as transparent and
opaque text.

After updating fast/text/empty-shadow.html, fast/text/empty-shadow-with-color.html
is no longer necessary.

  • fast/text/empty-shadow-expected.html:
  • fast/text/empty-shadow-with-color-expected.html: Removed.
  • fast/text/empty-shadow-with-color.html: Removed.
  • fast/text/empty-shadow.html:
7:17 PM Changeset in webkit [173940] by dbates@webkit.org
  • 2 edits in trunk/Source/WebKit/ios

[iOS] Fix the iOS build; add case statements for kCLAuthorizationStatusAuthorized
​https://bugs.webkit.org/show_bug.cgi?id=137101
<rdar://problem/18449815>

Reviewed by Mark Lam.

  • Misc/WebGeolocationCoreLocationProvider.mm:

(-[WebGeolocationCoreLocationProvider requestGeolocationAuthorization]):
(-[WebGeolocationCoreLocationProvider locationManager:didChangeAuthorizationStatus:]):

5:25 PM Changeset in webkit [173939] by Brian Burg
  • 6 edits in trunk/Source

Web Inspector: subtract elapsed time while debugger is paused from profile nodes
​https://bugs.webkit.org/show_bug.cgi?id=136796

Reviewed by Timothy Hatcher.

Source/JavaScriptCore:

Rather than accruing no time to any profile node created while the debugger is paused,
we can instead count a node's elapsed time and exclude time elapsed while paused.

Time for a node may elapse in a non-contiguous fashion depending on the interleaving of
didPause, didContinue, willExecute, and didExecute. A node's start time is set to the
start of the last such interval that accrues elapsed time.

  • profiler/ProfileGenerator.cpp:

(JSC::ProfileGenerator::ProfileGenerator):
(JSC::ProfileGenerator::beginCallEntry):
(JSC::ProfileGenerator::endCallEntry):
(JSC::ProfileGenerator::didPause): Added.
(JSC::ProfileGenerator::didContinue): Added.

  • profiler/ProfileGenerator.h:

(JSC::ProfileGenerator::didPause): Deleted.
(JSC::ProfileGenerator::didContinue): Deleted.

  • profiler/ProfileNode.h: Rename totalTime to elapsedTime.

(JSC::ProfileNode::Call::Call):
(JSC::ProfileNode::Call::elapsedTime): Added.
(JSC::ProfileNode::Call::setElapsedTime): Added.
(JSC::CalculateProfileSubtreeDataFunctor::operator()):
(JSC::ProfileNode::Call::totalTime): Deleted.
(JSC::ProfileNode::Call::setTotalTime): Deleted.

Source/WebCore:

  • inspector/TimelineRecordFactory.cpp:

(WebCore::buildInspectorObject):

4:29 PM Changeset in webkit [173938] by Chris Dumez
  • 2 edits in trunk/Source/WebKit/win

Unreviewed build fix after r173932.

Unreviewed build fix after r173932 for Windows. Use WebCore:: namespace
explicitely in DOMCoreClasses.cpp.

  • DOMCoreClasses.cpp:

(DOMElement::createInstance):

4:28 PM Changeset in webkit [173937] by dfarler@apple.com
  • 5 edits in trunk/Tools

[iOS] run-webkit-tests should support minor versions under devices and create a testing device under the right runtime
​https://bugs.webkit.org/show_bug.cgi?id=136895

Reviewed by David Kilzer.

Create Device, DeviceType, and Runtime data classes.
Create Simulator class represent simctl output.

Wherever possible, use structured data classes anywhere a raw
identifier or UDID string was used for a cleaner implementation
and to encapsulate the inherent fragility of scraping simctl output.

Create a suitably named testing device if one doesn't exist.

Finally, accurately handle having multiple simulator runtimes (SDKs)
installed in the active Xcode.app bundle.

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:

(_set_up_derived_options):

  • Scripts/webkitpy/port/driver.py:

(IOSSimulatorDriver.cmd_line):
Construct DeviceType and Runtime objects from identifiers passed at the
command line, still providing sensible defaults for 32- and 64-bit testing.

  • Scripts/webkitpy/port/ios.py:

(IOSSimulatorPort.init):
(IOSSimulatorPort.setup_test_run):
(IOSSimulatorPort):
(IOSSimulatorPort.testing_device):
Cache the testing device once it is created or found.
(IOSSimulatorPort.reset_preferences):
Get the device path from the Device object instead of consructing it
in the port class.
(IOSSimulatorPort.simulator_udid): Deleted.
Get the UDID from the testing_device :: Device object itself.

  • Scripts/webkitpy/xcode/simulator.py:

Created Device, DeviceType, Runtime, and Simulator classes.
(get_runtimes): Deleted.
(get_devices): Deleted.
(get_device_types): Deleted.
(get_latest_runtime): Deleted.

4:11 PM Changeset in webkit [173936] by timothy@apple.com
  • 1 edit in trunk/Source/WebKit/mac/WebCoreSupport/WebInspectorClient.mm

Attempt to fix crash seen on bots.

3:07 PM Changeset in webkit [173935] by ggaren@apple.com
  • 2 edits in trunk/Source/WTF

Do the bmalloc.
​https://bugs.webkit.org/show_bug.cgi?id=132629

Reviewed by Gavin Barraclough.

64-bit only for now, just to try it out.

  • wtf/FastMalloc.cpp:
3:02 PM Changeset in webkit [173934] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

Remove incorrect use of the BKSProcessAssertionAllowSuspendOnSleep flag for process suspension in iOS WebKit2
<rdar://problem/18400566>
​https://bugs.webkit.org/show_bug.cgi?id=137077

Reviewed by Anders Carlsson.

  • UIProcess/ios/ProcessAssertionIOS.mm:

Remove use of the BKSProcessAssertionAllowSuspendOnSleep which does not do what we expect, and instead
causes processes to be suspended "forever" after sleep.

2:41 PM Changeset in webkit [173933] by timothy@apple.com
  • 2 edits in trunk/Source/WebKit2/UIProcess

Fix 32-bit Mac build.

2:25 PM Changeset in webkit [173932] by Chris Dumez
  • 72 edits in trunk/Source

Use is<HTML*Element>() instead of isHTML*Element() - Part 1
​https://bugs.webkit.org/show_bug.cgi?id=137068

Reviewed by Ryosuke Niwa.

Start using is<HTML*Element>() instead of isHTML*Element().
Remaining usages will be updated in a follow-up patch to
reduce the size of the change.

Source/WebCore:

No new tests, no behavior change.

  • accessibility/AccessibilityListBoxOption.cpp:

(WebCore::AccessibilityListBoxOption::isSelected):
(WebCore::AccessibilityListBoxOption::canSetSelectedAttribute):
(WebCore::AccessibilityListBoxOption::stringValue):
(WebCore::AccessibilityListBoxOption::listBoxOptionParentNode):

  • accessibility/AccessibilityMediaControls.cpp:

(WebCore::AccessibilityMediaTimeline::valueDescription):

  • accessibility/AccessibilityMenuListOption.cpp:

(WebCore::AccessibilityMenuListOption::setElement):

  • accessibility/AccessibilityMenuListPopup.cpp:

(WebCore::AccessibilityMenuListPopup::menuListOptionAccessibilityObject):

  • accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::determineAccessibilityRole):
(WebCore::AccessibilityNodeObject::isNativeTextControl):
(WebCore::AccessibilityNodeObject::isNativeImage):
(WebCore::AccessibilityNodeObject::isInputImage):
(WebCore::AccessibilityNodeObject::isReadOnly):
(WebCore::AccessibilityNodeObject::valueForRange):
(WebCore::AccessibilityNodeObject::maxValueForRange):
(WebCore::AccessibilityNodeObject::minValueForRange):
(WebCore::isNodeActionElement):
(WebCore::AccessibilityNodeObject::titleElementText):
(WebCore::AccessibilityNodeObject::visibleText):
(WebCore::AccessibilityNodeObject::title):
(WebCore::AccessibilityNodeObject::colorValue):
(WebCore::accessibleNameForNode):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::isFileUploadButton):
(WebCore::AccessibilityRenderObject::addRadioButtonGroupMembers):
(WebCore::AccessibilityRenderObject::setValue):
(WebCore::AccessibilityRenderObject::accessibilityHitTest):
(WebCore::AccessibilityRenderObject::determineAccessibilityRole):
(WebCore::AccessibilityRenderObject::addTextFieldChildren):

  • accessibility/atk/AXObjectCacheAtk.cpp:

(WebCore::notifyChildrenSelectionChange):

  • css/SelectorCheckerTestFunctions.h:

(WebCore::isDisabled):
(WebCore::isEnabled):
(WebCore::isChecked):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::adjustRenderStyle):

  • dom/EventDispatcher.cpp:

(WebCore::EventDispatcher::dispatchEvent):

  • editing/FrameSelection.cpp:

(WebCore::FrameSelection::selectAll):

  • editing/ReplaceSelectionCommand.cpp:

(WebCore::ReplaceSelectionCommand::shouldPerformSmartReplace):

  • editing/VisibleSelection.cpp:

(WebCore::VisibleSelection::isInPasswordField):

  • editing/cocoa/HTMLConverter.mm:

(HTMLConverter::_processElement):

  • editing/gtk/EditorGtk.cpp:

(WebCore::elementURL):

  • editing/ios/EditorIOS.mm:

(WebCore::Editor::setTextAlignmentForChangedBaseWritingDirection):

  • editing/markup.cpp:

(WebCore::StyledMarkupAccumulator::appendText):
(WebCore::isPlainTextMarkup):
(WebCore::collectElementsToRemoveFromFragment):

  • html/HTMLCollection.cpp:

(WebCore::isMatchingElement):

  • html/HTMLEmbedElement.cpp:

(WebCore::HTMLEmbedElement::rendererIsNeeded):

  • html/HTMLFormControlElement.cpp:

(WebCore::shouldAutofocus):

  • html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::getTextFieldValues):
(WebCore::HTMLFormElement::formElementIndex):

  • html/HTMLImageLoader.cpp:

(WebCore::HTMLImageLoader::dispatchLoadEvent):
(WebCore::HTMLImageLoader::notifyFinished):

  • html/HTMLNameCollection.cpp:

(WebCore::DocumentNameCollection::elementMatchesIfIdAttributeMatch):
(WebCore::DocumentNameCollection::elementMatchesIfNameAttributeMatch):
(WebCore::DocumentNameCollection::elementMatches):

  • html/HTMLOptGroupElement.cpp:

(WebCore::HTMLOptGroupElement::recalcSelectOptions):
(WebCore::HTMLOptGroupElement::ownerSelectElement):

  • html/HTMLOptionElement.cpp:

(WebCore::HTMLOptionElement::index):
(WebCore::HTMLOptionElement::ownerSelectElement):

  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::add):
(WebCore::HTMLSelectElement::value):
(WebCore::HTMLSelectElement::setValue):
(WebCore::HTMLSelectElement::childShouldCreateRenderer):
(WebCore::HTMLSelectElement::setLength):
(WebCore::HTMLSelectElement::nextValidIndex):
(WebCore::HTMLSelectElement::saveLastSelection):
(WebCore::HTMLSelectElement::setActiveSelectionAnchorIndex):
(WebCore::HTMLSelectElement::updateListBoxSelection):
(WebCore::HTMLSelectElement::listBoxOnChange):
(WebCore::HTMLSelectElement::recalcListItems):
(WebCore::HTMLSelectElement::selectedIndex):
(WebCore::HTMLSelectElement::selectOption):
(WebCore::HTMLSelectElement::optionToListIndex):
(WebCore::HTMLSelectElement::listToOptionIndex):
(WebCore::HTMLSelectElement::deselectItemsWithoutValidation):
(WebCore::HTMLSelectElement::saveFormControlState):
(WebCore::HTMLSelectElement::searchOptionsForValue):
(WebCore::HTMLSelectElement::restoreFormControlState):
(WebCore::HTMLSelectElement::appendFormData):
(WebCore::HTMLSelectElement::reset):
(WebCore::HTMLSelectElement::updateSelectedState):
(WebCore::HTMLSelectElement::listBoxDefaultEventHandler):
(WebCore::HTMLSelectElement::lastSelectedListIndex):
(WebCore::HTMLSelectElement::optionAtIndex):
(WebCore::HTMLSelectElement::accessKeySetSelectedIndex):
(WebCore::HTMLSelectElement::length):

  • html/HTMLTagNames.in:
  • html/RadioInputType.cpp:

(WebCore::RadioInputType::handleKeydownEvent):
(WebCore::RadioInputType::isKeyboardFocusable):

  • html/parser/HTMLConstructionSite.cpp:

(WebCore::hasImpliedEndTag):

  • html/parser/HTMLElementStack.cpp:

(WebCore::HTMLNames::isSelectScopeMarker):

  • html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::processStartTagForInBody):
(WebCore::HTMLTreeBuilder::processStartTag):
(WebCore::HTMLTreeBuilder::processEndTag):

  • html/shadow/MediaControlElementTypes.cpp:

(WebCore::mediaControlElementType):

  • loader/FormSubmission.cpp:

(WebCore::FormSubmission::create):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::handleFallbackContent):

  • loader/ImageLoader.cpp:

(WebCore::ImageLoader::dispatchPendingBeforeLoadEvent):

  • loader/SubframeLoader.cpp:

(WebCore::SubframeLoader::requestObject):

  • loader/archive/cf/LegacyWebArchive.cpp:

(WebCore::LegacyWebArchive::create):

  • page/Chrome.cpp:

(WebCore::Chrome::setToolTip):

  • page/EventHandler.cpp:

(WebCore::isSubmitImage):
(WebCore::EventHandler::handleMousePressEvent):

  • page/FocusController.cpp:

(WebCore::clearSelectionIfNeeded):

  • page/FrameView.cpp:

(WebCore::FrameView::addEmbeddedObjectToUpdate):
(WebCore::FrameView::updateEmbeddedObject):

  • page/PageSerializer.cpp:

(WebCore::frameOwnerURLAttributeName):

  • page/SpatialNavigation.cpp:

(WebCore::canScrollInDirection):

  • rendering/HitTestResult.cpp:

(WebCore::HitTestResult::altDisplayString):
(WebCore::HitTestResult::absoluteImageURL):
(WebCore::HitTestResult::absolutePDFURL):
(WebCore::HitTestResult::isContentEditable):

  • rendering/RenderBlockFlow.cpp:

(WebCore::resizeTextPermitted):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::sizesLogicalWidthToFitContent):

  • rendering/RenderButton.cpp:

(WebCore::RenderButton::updateFromElement):
(WebCore::RenderButton::canHaveGeneratedChildren):

  • rendering/RenderDetailsMarker.cpp:

(WebCore::RenderDetailsMarker::isOpen):

  • rendering/RenderFileUploadControl.cpp:

(WebCore::RenderFileUploadControl::uploadButton):

  • rendering/RenderImage.cpp:

(WebCore::RenderImage::updateAltText):

  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::updateFromElement):
(WebCore::RenderListBox::addFocusRingRects):
(WebCore::RenderListBox::paintItemForeground):
(WebCore::RenderListBox::paintItemBackground):

  • rendering/RenderMenuList.cpp:

(WebCore::selectedOptionCount):
(RenderMenuList::updateOptionsWidth):
(RenderMenuList::setTextFromOption):
(RenderMenuList::itemText):
(RenderMenuList::itemIsEnabled):
(RenderMenuList::itemIsSelected):

  • rendering/RenderTheme.cpp:

(WebCore::RenderTheme::paintSliderTicks):

  • testing/Internals.cpp:

(WebCore::Internals::selectColorInColorChooser):
(WebCore::Internals::wasLastChangeUserEdit):
(WebCore::Internals::isSelectPopupVisible):

  • xml/parser/XMLDocumentParserLibxml2.cpp:

(WebCore::XMLDocumentParser::startElementNs):

Source/WebKit/ios:

  • WebCoreSupport/WebChromeClientIOS.mm:

(WebChromeClientIOS::focusedElementChanged):

Source/WebKit/mac:

  • WebCoreSupport/WebChromeClient.mm:

(WebChromeClient::focusedElementChanged):

  • WebCoreSupport/WebEditorClient.mm:

(WebEditorClient::textFieldDidBeginEditing):
(WebEditorClient::textFieldDidEndEditing):
(WebEditorClient::textDidChangeInTextField):
(WebEditorClient::doTextFieldCommandFromEvent):
(WebEditorClient::textWillBeDeletedInTextField):
(WebEditorClient::textDidChangeInTextArea):

  • WebView/WebHTMLRepresentation.mm:

(inputElementFromDOMElement):

Source/WebKit/win:

  • DOMCoreClasses.cpp:

(DOMElement::createInstance):

  • DOMHTMLClasses.cpp:

(DOMHTMLOptionElement::text):
(DOMHTMLOptionElement::label):
(DOMHTMLInputElement::form):
(DOMHTMLInputElement::disabled):
(DOMHTMLInputElement::readOnly):
(DOMHTMLInputElement::setType):
(DOMHTMLInputElement::value):
(DOMHTMLInputElement::setValue):
(DOMHTMLInputElement::setValueForUser):
(DOMHTMLInputElement::select):
(DOMHTMLInputElement::setSelectionStart):
(DOMHTMLInputElement::selectionStart):
(DOMHTMLInputElement::setSelectionEnd):
(DOMHTMLInputElement::selectionEnd):
(DOMHTMLInputElement::isTextField):
(DOMHTMLInputElement::rectOnScreen):
(DOMHTMLInputElement::replaceCharactersInRange):
(DOMHTMLInputElement::selectedRange):
(DOMHTMLInputElement::setAutofilled):
(DOMHTMLInputElement::isAutofilled):
(DOMHTMLInputElement::isUserEdited):
(DOMHTMLTextAreaElement::form):
(DOMHTMLTextAreaElement::value):
(DOMHTMLTextAreaElement::setValue):
(DOMHTMLTextAreaElement::select):
(DOMHTMLTextAreaElement::isUserEdited):

  • WebFrame.cpp:

(inputElementFromDOMElement):

Source/WebKit2:

  • WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:

(WebKit::InjectedBundleNodeHandle::setHTMLInputElementValueForUser):
(WebKit::InjectedBundleNodeHandle::isHTMLInputElementAutofilled):
(WebKit::InjectedBundleNodeHandle::setHTMLInputElementAutofilled):
(WebKit::InjectedBundleNodeHandle::htmlInputElementLastChangeWasUserEdit):
(WebKit::InjectedBundleNodeHandle::htmlTextAreaElementLastChangeWasUserEdit):
(WebKit::InjectedBundleNodeHandle::isTextField):

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::focusedElementChanged):

  • WebProcess/WebCoreSupport/WebEditorClient.cpp:

(WebKit::WebEditorClient::textFieldDidBeginEditing):
(WebKit::WebEditorClient::textFieldDidEndEditing):
(WebKit::WebEditorClient::textDidChangeInTextField):
(WebKit::WebEditorClient::textDidChangeInTextArea):
(WebKit::WebEditorClient::doTextFieldCommandFromEvent):
(WebKit::WebEditorClient::textWillBeDeletedInTextField):

  • WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::containsAnyFormControls):

  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::setAssistedNodeValue):
(WebKit::WebPage::setAssistedNodeValueAsNumber):
(WebKit::WebPage::setAssistedNodeSelectedIndex):

2:22 PM Changeset in webkit [173931] by eric.carlson@apple.com
  • 4 edits in trunk/Source/WebCore

[iOS] Remove MediaPlayer::setHasPlaybackTargetAvailabilityListeners
​https://bugs.webkit.org/show_bug.cgi?id=137075

Reviewed by Dean Jackson.

No new tests, this just removes unused code.

  • platform/graphics/MediaPlayer.cpp:

(WebCore::MediaPlayer::setHasPlaybackTargetAvailabilityListeners): Deleted.

  • platform/graphics/MediaPlayer.h:
  • platform/graphics/MediaPlayerPrivate.h:

(WebCore::MediaPlayerPrivateInterface::setHasPlaybackTargetAvailabilityListeners): Deleted.

1:11 PM Changeset in webkit [173930] by adachan@apple.com
  • 4 edits in trunk/Source/WebKit2

Add stub implementation of WKPageIsPlayingAudio().
​https://bugs.webkit.org/show_bug.cgi?id=137044

Reviewed by Anders Carlsson.

Also add an isPlayingAudioDidChange callback to WKPageUIClient.

  • UIProcess/API/C/WKPage.cpp:

(WKPageIsPlayingAudio):

  • UIProcess/API/C/WKPagePrivate.h:
  • UIProcess/API/C/WKPageUIClient.h:
12:58 PM Changeset in webkit [173929] by timothy@apple.com
  • 53 edits
    1 copy
    5 adds
    1 delete in trunk/Source

Make the Web Inspector use a separate web process.

​https://bugs.webkit.org/show_bug.cgi?id=135120

Reviewed by Anders Carlsson.

Source/WebCore:

  • English.lproj/Localizable.strings: Updated.
  • WebCore.exp.in:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/ScriptGlobalObject.h:
  • bindings/js/ScriptState.h:
  • inspector/InspectorFrontendHost.h:
  • inspector/InspectorPageAgent.h:
  • page/Chrome.h:

Exported a few functions and private headers.

  • inspector/InspectorController.cpp:

(WebCore::InspectorController::InspectorController):
(WebCore::InspectorController::setInspectorFrontendClient):
(WebCore::InspectorController::hasInspectorFrontendClient):
(WebCore::InspectorController::show):

  • inspector/InspectorController.h:

Make InspectorFrontendClient a pointer instead of a std::unique_ptr.
This makes it easier to implement InspectorFrontendClient as
part of an existing object that is externally owned.

  • testing/Internals.cpp:

(WebCore::Internals::openDummyInspectorFrontend):
(WebCore::Internals::closeDummyInspectorFrontend):

  • testing/Internals.h:

Change InspectorFrontendClientDummy from being moved to owned.

Source/WebInspectorUI:

  • Localizations/en.lproj/localizedStrings.js: Updated.
  • UserInterface/Base/Main.js:

(WebInspector.loaded):
(WebInspector.contentLoaded):
Move InspectorFrontendHost.loaded to later in the load.
Calling it early just shows the window before we have
a user interface to show.

  • UserInterface/Base/Test.js:

(WebInspector.loaded):
(WebInspector.contentLoaded):
Match the changes in Main.js.

  • UserInterface/Protocol/InspectorFrontendAPI.js:

(InspectorFrontendAPI.savedURL): Change comment.
(InspectorFrontendAPI.appendedToURL): Change comment.
(InspectorFrontendAPI.dispatch): Add an assert and early
return to be safe from unknown commands.
(InspectorFrontendAPI.loadCompleted): Delete _pendingCommands,
no need to keep an empty array around a one time use.

Source/WebKit/ios:

  • WebCoreSupport/WebInspectorClientIOS.mm:

(WebInspectorClient::WebInspectorClient):
Removed m_frontendClient initialization since it is
now a std::unique_ptr that defaults to nullptr.

Source/WebKit/mac:

  • WebCoreSupport/WebInspectorClient.h:
  • WebCoreSupport/WebInspectorClient.mm:

(WebInspectorClient::WebInspectorClient):
(WebInspectorClient::openInspectorFrontend):
(WebInspectorClient::releaseFrontend):
Own WebInspectorFrontendClient instead of moving it.

Source/WebKit/win:

  • WebCoreSupport/WebInspectorClient.cpp:

(WebInspectorClient::openInspectorFrontend):

  • WebCoreSupport/WebInspectorClient.h:

(WebInspectorClient::frontendClient):
Own WebInspectorFrontendClient instead of moving it.

Source/WebKit2:

  • CMakeLists.txt:
  • DerivedSources.make:
  • PlatformEfl.cmake:
  • PlatformGTK.cmake:
  • WebKit2.xcodeproj/project.pbxproj:

Added new WebInspectorUI files and removed WebInspectorFrontendClient.cpp.

  • Shared/APIObject.h: Added BundleInspectorUI.
  • Shared/EntryPointUtilities/mac/LegacyProcess/ChildProcessEntryPoint.mm:

(WebKit::ChildProcessMainDelegate::getExtraInitializationData):

  • Shared/EntryPointUtilities/mac/XPCService/XPCServiceEntryPoint.mm:

(WebKit::XPCServiceInitializerDelegate::getExtraInitializationData):
Add support for "inspector-process" data, a boolean that is used by
WebProcess::initializeProcessName.

  • UIProcess/API/C/WKInspector.cpp:

(WKInspectorIsDebuggingJavaScript):
(WKInspectorToggleJavaScriptDebugging):
(WKInspectorIsProfilingJavaScript):
(WKInspectorToggleJavaScriptProfiling):

  • UIProcess/API/C/WKInspector.h:

Stub out functions we don't support but need to keep for nightly compatibility.

  • UIProcess/WebInspectorProxy.cpp:

(WebKit::WebInspectorPageGroups::createInspectorPageGroup):
(WebKit::WebInspectorProxy::WebInspectorProxy):
(WebKit::WebInspectorProxy::invalidate):
(WebKit::WebInspectorProxy::connect):
(WebKit::WebInspectorProxy::showConsole):
(WebKit::WebInspectorProxy::showResources):
(WebKit::WebInspectorProxy::showMainResourceForFrame):
(WebKit::WebInspectorProxy::attach):
(WebKit::WebInspectorProxy::detach):
(WebKit::WebInspectorProxy::inspectorContext):
(WebKit::WebInspectorProxy::dispatchMessageFromRemoteFrontend):
(WebKit::WebInspectorProxy::eagerlyCreateInspectorPage):
(WebKit::WebInspectorProxy::createInspectorPage):
(WebKit::WebInspectorProxy::open):
(WebKit::WebInspectorProxy::didClose):
(WebKit::WebInspectorProxy::attachAvailabilityChanged):

  • UIProcess/WebInspectorProxy.h:

(WebKit::WebInspectorProxy::isConnected):
(WebKit::WebInspectorProxy::canAttach):

  • UIProcess/WebInspectorProxy.messages.in:
  • UIProcess/efl/WebInspectorProxyEfl.cpp:

(WebKit::WebInspectorProxy::platformCreateInspectorPage):

  • UIProcess/gtk/WebInspectorProxyGtk.cpp:

(WebKit::WebInspectorProxy::platformCreateInspectorPage):
(WebKit::WebInspectorProxy::platformAttach):

  • UIProcess/mac/WebInspectorProxyMac.mm:

(-[WKWebInspectorProxyObjCAdapter close]):
(WebKit::WebInspectorProxy::platformCreateInspectorPage):
(WebKit::WebInspectorProxy::platformDidClose):
(WebKit::WebInspectorProxy::platformHide):
(WebKit::WebInspectorProxy::platformSave):
(WebKit::WebInspectorProxy::platformAppend):
(WebKit::WebInspectorProxy::platformAttach):
Changed how the Inspector page is created by making it in a new WebContext for
the Inspector. This removes us from the main process pool and guarantees no process
sharing for our user interface. Also send new WebInspectorUI messages to the Inspector
page and not the inspected page when appropriate.

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::getLaunchOptions): Add "inspector-process" to extraInitializationData
if the context is the Inspector context. This is used by WebProcess::initializeProcessName.

  • WebProcess/WebCoreSupport/WebInspectorClient.cpp:

(WebKit::WebInspectorClient::openInspectorFrontend):
(WebKit::WebInspectorClient::closeInspectorFrontend):
(WebKit::WebInspectorClient::bringFrontendToFront):

  • WebProcess/WebCoreSupport/WebInspectorClient.h:

Remove the InspectorFrontendChannel class from WebInspectorClient and clean up a little.
InspectorFrontendChannel implementation moved to WebInspector.

  • WebProcess/WebCoreSupport/WebInspectorFrontendClient.cpp: Removed. Superseded by WebInspectorUI.
  • WebProcess/WebPage/WebInspector.cpp:

(WebKit::WebInspector::create):
(WebKit::WebInspector::WebInspector):
(WebKit::WebInspector::createInspectorPage):
(WebKit::WebInspector::closeFrontend):
(WebKit::WebInspector::openInNewTab):
(WebKit::WebInspector::showConsole):
(WebKit::WebInspector::showResources):
(WebKit::WebInspector::showMainResourceForFrame):
(WebKit::WebInspector::startPageProfiling):
(WebKit::WebInspector::stopPageProfiling):
(WebKit::WebInspector::canAttachWindow):
(WebKit::WebInspector::updateDockingAvailability):
(WebKit::WebInspector::sendMessageToBackend):
(WebKit::WebInspector::sendMessageToFrontend):
(WebKit::WebInspector::remoteFrontendConnected):
(WebKit::WebInspector::remoteFrontendDisconnected):

  • WebProcess/WebPage/WebInspector.h:

(WebKit::WebInspector::didClose):
(WebKit::WebInspector::didReceiveInvalidMessage):
(WebKit::WebInspector::setAttached):

  • WebProcess/WebPage/WebInspector.messages.in:

Stop taking an optional InspectorFrontendChannel and inherit it instead. Create a connection that
can be passed to the other web process for WebInspectorUI to use. Stop referencing Inspector's page
directly, since it is in another process now.

  • WebProcess/WebPage/WebInspectorUI.cpp: Added.

(WebKit::WebInspectorUI::create):
(WebKit::WebInspectorUI::WebInspectorUI):
(WebKit::WebInspectorUI::establishConnection):
(WebKit::WebInspectorUI::windowObjectCleared):
(WebKit::WebInspectorUI::frontendLoaded):
(WebKit::WebInspectorUI::moveWindowBy):
(WebKit::WebInspectorUI::bringToFront):
(WebKit::WebInspectorUI::closeWindow):
(WebKit::WebInspectorUI::requestSetDockSide):
(WebKit::WebInspectorUI::setDockSide):
(WebKit::WebInspectorUI::changeAttachedWindowHeight):
(WebKit::WebInspectorUI::changeAttachedWindowWidth):
(WebKit::WebInspectorUI::setToolbarHeight):
(WebKit::WebInspectorUI::openInNewTab):
(WebKit::WebInspectorUI::save):
(WebKit::WebInspectorUI::append):
(WebKit::WebInspectorUI::inspectedURLChanged):
(WebKit::WebInspectorUI::showConsole):
(WebKit::WebInspectorUI::showResources):
(WebKit::WebInspectorUI::showMainResourceForFrame):
(WebKit::WebInspectorUI::startPageProfiling):
(WebKit::WebInspectorUI::stopPageProfiling):
(WebKit::WebInspectorUI::didSave):
(WebKit::WebInspectorUI::didAppend):
(WebKit::WebInspectorUI::sendMessageToFrontend):
(WebKit::WebInspectorUI::sendMessageToBackend):
(WebKit::WebInspectorUI::evaluateCommandOnLoad):
(WebKit::WebInspectorUI::evaluateExpressionOnLoad):
(WebKit::WebInspectorUI::evaluatePendingExpressions):

  • WebProcess/WebPage/WebInspectorUI.h: Added.

(WebKit::WebInspectorUI::page):
(WebKit::WebInspectorUI::didClose):
(WebKit::WebInspectorUI::didReceiveInvalidMessage):
(WebKit::WebInspectorUI::attachedBottom):
(WebKit::WebInspectorUI::attachedRight):
(WebKit::WebInspectorUI::detached):
(WebKit::WebInspectorUI::evaluateCommandOnLoad):

  • WebProcess/WebPage/WebInspectorUI.messages.in: Added.
  • WebProcess/WebPage/efl/WebInspectorUIEfl.cpp: Added.

(WebKit::WebInspectorUI::canSave):
(WebKit::WebInspectorUI::localizedStringsURL):

  • WebProcess/WebPage/gtk/WebInspectorUIGtk.cpp: Added.

(WebKit::WebInspectorUI::canSave):
(WebKit::WebInspectorUI::localizedStringsURL):

  • WebProcess/WebPage/mac/WebInspectorUIMac.mm: Added.

(WebKit::WebInspectorUI::canSave):
(WebKit::WebInspectorUI::localizedStringsURL):
Implement the InspectorFrontendClient and handle a connection to the inspected page's WebInspector.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):
(WebKit::WebPage::~WebPage):
(WebKit::WebPage::inspector):
(WebKit::WebPage::inspectorUI):
(WebKit::WebPage::didReceiveMessage):
Setup as a listener for WebInspectorUI messages.

  • WebProcess/WebPage/WebPage.h:

(WebKit::WebPage::isInspectorPage): It is an Inspector page if we have a m_inspectorUI.

  • WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::WebProcess::initializeProcessName):
Name the process "%@ Web Inspector" if it is an Inspector content process. Processes in that
context are not shared with multiple pages.

12:57 PM Changeset in webkit [173928] by dino@apple.com
  • 5 edits in trunk/Source/WebCore

[Yosemite] Button text doesn't go white while pushing the button, like it does for real buttons
​https://bugs.webkit.org/show_bug.cgi?id=137054
rdar://problem/17559038

Reviewed by NOBODY (OOPS!).

On Yosemite and above, system buttons paint with white-ish text when they
are pressed. Since this isn't exposed by API, I've hardcoded the value
into RenderThemeMac.

The actual state is exposed by adding a :active rule to html.css that
uses a new CSSValueKeyword: ActiveButtonText.

Unfortunately I can't find a way to test this, because the active state isn't
testable. We should really expose the Inspector's forcePseudoState function into
window.internals.

  • css/CSSValueKeywords.in: Add "activebuttontext".
  • css/html.css:

(input[type="button"]:active, input[type="submit"]:active, input[type="reset"]:active, input[type="file"]::-webkit-file-upload-button:active, button:active): New rule for active
button elements.

  • rendering/RenderTheme.cpp:

(WebCore::RenderTheme::systemColor): Handle CSSValueActivebuttontext as black.

  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::systemColor): Handle CSSValueActivebuttontext as
white with 75% opacity.

12:52 PM Changeset in webkit [173927] by dino@apple.com
  • 2 edits in trunk/Source/WebKit2

Add a deprecated stub for WKPreferencesSetMultithreadedWebGLEnabled (and Get)
​https://bugs.webkit.org/show_bug.cgi?id=137071

Reviewed by Brent Fulgham.

Put in stubs for WKPreferencesSetMultithreadedWebGLEnabled and
WKPreferencesGetMultithreadedWebGLEnabled. These were removed in
r173776 but are still needed for nightly builds to link
(or will be once Yosemite nightlies are available).

  • Shared/API/c/WKDeprecatedFunctions.cpp:

(WKPreferencesSetMultithreadedWebGLEnabled):
(WKPreferencesGetMultithreadedWebGLEnabled):

12:24 PM Changeset in webkit [173926] by roger_fong@apple.com
  • 2 edits in trunk/Tools

[Windows] Tentative fix for Windows test bots.

  • Scripts/webkitpy/common/system/path.py:

(_CygPath.convert):

10:30 AM Changeset in webkit [173925] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

Add New Test for overrideMimeType in XMLHttpRequest.
​https://bugs.webkit.org/show_bug.cgi?id=137057

Patch by Shivakumar JM <​shiva.jm@samsung.com> on 2014-09-24
Reviewed by Alexey Proskuryakov.

As part of bug: ​https://bugs.webkit.org/show_bug.cgi?id=136699, add more tests to test overrideMimeType for all states.

  • http/tests/xmlhttprequest/xmlhttprequest-overridemimetype-invalidstaterror-expected.txt: Added.
  • http/tests/xmlhttprequest/xmlhttprequest-overridemimetype-invalidstaterror.html: Added.
10:26 AM Changeset in webkit [173924] by ap@apple.com
  • 13 edits in trunk/Tools

Change more build.webkit.org links to https
​https://bugs.webkit.org/show_bug.cgi?id=137049

Reviewed by Csaba Osztrogonác.

Fix appspot, svn.webkit.org and Trac links.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:
  • BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ViewController.js:

(ViewController.prototype._domForBuildName):

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:

(.):

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWS.js:

(EWS):

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitTestHistory.js:

(TestHistory):

  • BuildSlaveSupport/build.webkit.org-config/templates/root.html:
9:59 AM Changeset in webkit [173923] by dbates@webkit.org
  • 2 edits in trunk/Source/WebKit2

[iOS] Fix the iOS build after <​http://trac.webkit.org/changeset/173893>
(​https://bugs.webkit.org/show_bug.cgi?id=137007)

Add closing parenthesis characters that were inadvertently removed in <​http://trac.webkit.org/changeset/173893>.

  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::setAssistedNodeSelectedIndex):
(WebKit::WebPage::getAssistedNodeInformation):

9:11 AM Changeset in webkit [173922] by llango.u-szeged@partner.samsung.com
  • 4 edits in trunk

Update the list of u-szeged contributors.

Rubber-stamped by Csaba Osztrogonác <Csaba Osztrogonác>.

Tools:

  • Scripts/webkitpy/common/config/contributors.json:

Websites/webkit.org:

  • team.html:
8:56 AM Changeset in webkit [173921] by Chris Dumez
  • 34 edits in trunk/Source/WebCore

Use is<SVG*Element>() instead of isSVG*Element()
​https://bugs.webkit.org/show_bug.cgi?id=137058

Reviewed by Dirk Schulze.

Use is<SVG*Element>() instead of isSVG*Element() and drop support for
generated isSVG*Element().

No new tests, no behavior change.

  • css/CSSCursorImageValue.cpp:

(WebCore::resourceReferencedByCursorElement):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::useSVGZoomRulesForLength):

  • dom/DocumentStyleSheetCollection.cpp:

(WebCore::DocumentStyleSheetCollection::collectActiveStyleSheets):

  • dom/ScriptElement.cpp:

(WebCore::toScriptElementIfPossible):

  • dom/make_names.pl:

(printTypeHelpers):

  • editing/gtk/EditorGtk.cpp:

(WebCore::elementURL):

  • rendering/HitTestResult.cpp:

(WebCore::HitTestResult::absoluteImageURL):
(WebCore::HitTestResult::isLiveLink):

  • rendering/svg/RenderSVGEllipse.cpp:

(WebCore::RenderSVGEllipse::calculateRadiiAndCenter):

  • rendering/svg/RenderSVGTransformableContainer.cpp:

(WebCore::RenderSVGTransformableContainer::calculateLocalTransform):

  • rendering/svg/SVGPathData.cpp:

(WebCore::updatePathFromCircleElement):

  • rendering/svg/SVGRenderTreeAsText.cpp:

(WebCore::operator<<):

  • rendering/svg/SVGResources.cpp:

(WebCore::targetReferenceFromResource):

  • svg/SVGAltGlyphDefElement.cpp:

(WebCore::SVGAltGlyphDefElement::hasValidGlyphElements):

  • svg/SVGAltGlyphElement.cpp:

(WebCore::SVGAltGlyphElement::hasValidGlyphElements):

  • svg/SVGAnimateMotionElement.cpp:

(WebCore::SVGAnimateMotionElement::hasValidAttributeType):

  • svg/SVGDocument.cpp:

(WebCore::SVGDocument::rootElement):

  • svg/SVGElement.cpp:

(WebCore::SVGElement::isOutermostSVGSVGElement):
(WebCore::SVGElement::ownerSVGElement):
(WebCore::SVGElement::viewportElement):

  • svg/SVGFEComponentTransferElement.cpp:

(WebCore::SVGFEComponentTransferElement::build):

  • svg/SVGFELightElement.cpp:

(WebCore::SVGFELightElement::findLightElement):

  • svg/SVGFontData.cpp:

(WebCore::SVGFontData::applySVGGlyphSelection):

  • svg/SVGFontElement.cpp:

(WebCore::SVGFontElement::ensureGlyphCache):

  • svg/SVGFontFaceElement.cpp:

(WebCore::SVGFontFaceElement::associatedFontElement):
(WebCore::SVGFontFaceElement::rebuildFontFace):

  • svg/SVGFontFaceSrcElement.cpp:

(WebCore::SVGFontFaceSrcElement::srcValue):
(WebCore::SVGFontFaceSrcElement::childrenChanged):

  • svg/SVGGlyphElement.cpp:

(WebCore::SVGGlyphElement::invalidateGlyphCache):

  • svg/SVGHKernElement.cpp:

(WebCore::SVGHKernElement::insertedInto):
(WebCore::SVGHKernElement::removedFrom):

  • svg/SVGLengthContext.cpp:

(WebCore::SVGLengthContext::determineViewport):

  • svg/SVGLocatable.cpp:

(WebCore::isViewportElement):

  • svg/SVGMPathElement.cpp:

(WebCore::SVGMPathElement::pathElement):
(WebCore::SVGMPathElement::notifyParentOfPathChange):

  • svg/SVGPathElement.cpp:

(WebCore::SVGPathElement::invalidateMPathDependencies):

  • svg/SVGPatternElement.cpp:

(WebCore::SVGPatternElement::collectPatternAttributes):

  • svg/SVGSVGElement.cpp:

(WebCore::SVGSVGElement::setupInitialView):

  • svg/SVGUseElement.cpp:

(WebCore::dumpInstanceTree):
(WebCore::SVGUseElement::expandUseElementsInShadowTree):

  • svg/SVGVKernElement.cpp:

(WebCore::SVGVKernElement::insertedInto):
(WebCore::SVGVKernElement::removedFrom):

8:40 AM WebKitGTK/2.6.x edited by Carlos Garcia Campos
(diff)
8:11 AM Changeset in webkit [173920] by Carlos Garcia Campos
  • 1 copy in releases/WebKitGTK/webkit-2.6.0

WebKitGTK+ 2.6.0

8:10 AM Changeset in webkit [173919] by Carlos Garcia Campos
  • 4 edits in releases/WebKitGTK/webkit-2.6

Unreviewed. Update OptionsGTK.cmake and NEWS for 2.6.0 release.

.:

  • Source/cmake/OptionsGTK.cmake: Bump version numbers.

Source/WebKit2:

  • gtk/NEWS: Add release notes for 2.6.0.
6:38 AM Changeset in webkit [173918] by Carlos Garcia Campos
  • 3 edits in releases/WebKitGTK/webkit-2.6/Source/JavaScriptCore

Merge r173886 - [CLoop] - Fix CLoop on the 32-bit Big-Endians
​https://bugs.webkit.org/show_bug.cgi?id=137020

Patch by Tomas Popela <​tpopela@redhat.com> on 2014-09-23
Reviewed by Mark Lam.

  • llint/LowLevelInterpreter.asm:
  • llint/LowLevelInterpreter32_64.asm:
6:37 AM Changeset in webkit [173917] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.6/Source/WebCore

Merge r173848 - WebSocket crash when a connection is closed from server side
​https://bugs.webkit.org/show_bug.cgi?id=137009
rdar://problem/18333977
rdar://problem/12708225

Reviewed by Brady Eidson.

I don't think that this can be tested with our test server.

  • Modules/websockets/WebSocketChannel.cpp:

(WebCore::WebSocketChannel::WebSocketChannel): Added logging.
(WebCore::WebSocketChannel::~WebSocketChannel): Ditto.
(WebCore::WebSocketChannel::close): Protect self, because startClosingHandshake
can release the last reference.
(WebCore::WebSocketChannel::fail): Added an assertion that the channel is always
closed after this function.
(WebCore::WebSocketChannel::startClosingHandshake): Protect self, and don't change
the stack from closed back to closing if after failing to send closing handshake.
(WebCore::WebSocketChannel::processOutgoingFrameQueue): Protect self.

6:36 AM Changeset in webkit [173916] by Carlos Garcia Campos
  • 3 edits
    2 adds in releases/WebKitGTK/webkit-2.6

Merge r173845 - Bad cast in isValidColumnSpanner.
​https://bugs.webkit.org/show_bug.cgi?id=133380.

Reviewed by Simon Fraser.

Source/WebCore:

Added fast/multicol/multicol-crazy-nesting.html

  • rendering/RenderMultiColumnFlowThread.cpp:

(WebCore::isValidColumnSpanner):
The crawl up the chain looking for unsplittable objects should use containing blocks
and not be casting to parent boxes. You can have an inline in the parent chain, so
this was not the right way to walk up the tree.

LayoutTests:

  • fast/multicol/multicol-crazy-nesting-expected.txt: Added.
  • fast/multicol/multicol-crazy-nesting.html: Added.
6:35 AM Changeset in webkit [173915] by Carlos Garcia Campos
  • 3 edits
    2 adds in releases/WebKitGTK/webkit-2.6

Merge r173843 - ASSERT in RenderMultiColumnSet::requiresBalancing.
​https://bugs.webkit.org/show_bug.cgi?id=136376.

Reviewed by David Kilzer.

Source/WebCore:

Added fast/multicol/multicol-selection.html.

  • rendering/RenderMultiColumnFlowThread.cpp:

(WebCore::isValidColumnSpanner):
Don't allow an object to become a spanner if it does not have the flow
thread as its containing block. Otherwise the flow thread won't get notified
of spanner placeholder insertions, and so the spanner ends up orphaned.

LayoutTests:

  • fast/multicol/multicol-selection-expected.txt: Added.
  • fast/multicol/multicol-selection.html: Added.
6:33 AM Changeset in webkit [173914] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.6/Source/WebCore

Merge r173836 - REGRESSION(r173631): It broke the !ENABLE(VIDEO) build
​https://bugs.webkit.org/show_bug.cgi?id=136946

Reviewed by Jer Noble.

No new tests required, no new functionality.

  • page/DragController.cpp:

(WebCore::DragController::startDrag):

5:59 AM Changeset in webkit [173913] by Carlos Garcia Campos
  • 5 edits
    1 copy
    104 adds in releases/WebKitGTK/webkit-2.6/Source/WebInspectorUI

Merge r173912 - Unreviewed. Add more free icons for the Web Inspector in GTK+

Patch by Andres Gomez <Andres Gomez> on 2014-09-24

  • UserInterface/Images/gtk/AUTHORS:
  • UserInterface/Images/gtk/ApplicationCache.png: Added.
  • UserInterface/Images/gtk/​ApplicationCache@2x.png: Added.
  • UserInterface/Images/gtk/BottomUpTree.svg: Added.
  • UserInterface/Images/gtk/Breakpoint.png: Added.
  • UserInterface/Images/gtk/​Breakpoint@2x.png: Added.
  • UserInterface/Images/gtk/BreakpointButton.svg:
  • UserInterface/Images/gtk/BreakpointInactive.png: Added.
  • UserInterface/Images/gtk/​BreakpointInactive@2x.png: Added.
  • UserInterface/Images/gtk/BreakpointInactiveButton.svg:
  • UserInterface/Images/gtk/COPYING:
  • UserInterface/Images/gtk/COPYING_CCBYSA3: Copied from Source/WebInspectorUI/UserInterface/Images/gtk/COPYING.
  • UserInterface/Images/gtk/ClippingCSS.png: Added.
  • UserInterface/Images/gtk/​ClippingCSS@2x.png: Added.
  • UserInterface/Images/gtk/ClippingGeneric.png: Added.
  • UserInterface/Images/gtk/​ClippingGeneric@2x.png: Added.
  • UserInterface/Images/gtk/ClippingJS.png: Added.
  • UserInterface/Images/gtk/​ClippingJS@2x.png: Added.
  • UserInterface/Images/gtk/CloseTimeline.png: Added.
  • UserInterface/Images/gtk/​CloseTimeline@2x.png: Added.
  • UserInterface/Images/gtk/ColorIcon.png: Added.
  • UserInterface/Images/gtk/​ColorIcon@2x.png: Added.
  • UserInterface/Images/gtk/Colors.png: Added.
  • UserInterface/Images/gtk/​Colors@2x.png: Added.
  • UserInterface/Images/gtk/ColorsLarge.png: Added.
  • UserInterface/Images/gtk/​ColorsLarge@2x.png: Added.
  • UserInterface/Images/gtk/Database.png: Added.
  • UserInterface/Images/gtk/​Database@2x.png: Added.
  • UserInterface/Images/gtk/DatabaseTable.png: Added.
  • UserInterface/Images/gtk/​DatabaseTable@2x.png: Added.
  • UserInterface/Images/gtk/HierarchicalNavigationItemChevron.svg: Added.
  • UserInterface/Images/gtk/IndeterminateProgressSpinner1.svg: Added.
  • UserInterface/Images/gtk/IndeterminateProgressSpinner10.svg: Added.
  • UserInterface/Images/gtk/IndeterminateProgressSpinner11.svg: Added.
  • UserInterface/Images/gtk/IndeterminateProgressSpinner12.svg: Added.
  • UserInterface/Images/gtk/IndeterminateProgressSpinner2.svg: Added.
  • UserInterface/Images/gtk/IndeterminateProgressSpinner3.svg: Added.
  • UserInterface/Images/gtk/IndeterminateProgressSpinner4.svg: Added.
  • UserInterface/Images/gtk/IndeterminateProgressSpinner5.svg: Added.
  • UserInterface/Images/gtk/IndeterminateProgressSpinner6.svg: Added.
  • UserInterface/Images/gtk/IndeterminateProgressSpinner7.svg: Added.
  • UserInterface/Images/gtk/IndeterminateProgressSpinner8.svg: Added.
  • UserInterface/Images/gtk/IndeterminateProgressSpinner9.svg: Added.
  • UserInterface/Images/gtk/Issues.svg: Added.
  • UserInterface/Images/gtk/IssuesEnabled.svg: Added.
  • UserInterface/Images/gtk/LayerBorders.svg: Added.
  • UserInterface/Images/gtk/LessColumns.svg: Added.
  • UserInterface/Images/gtk/LocalStorage.png: Added.
  • UserInterface/Images/gtk/​LocalStorage@2x.png: Added.
  • UserInterface/Images/gtk/Locked.svg: Added.
  • UserInterface/Images/gtk/Logs.svg: Added.
  • UserInterface/Images/gtk/Memory.svg: Added.
  • UserInterface/Images/gtk/MoreColumns.svg: Added.
  • UserInterface/Images/gtk/Native.svg: Added.
  • UserInterface/Images/gtk/NavigationItemAngleBrackets.svg: Added.
  • UserInterface/Images/gtk/NavigationItemBrushAndRuler.svg: Added.
  • UserInterface/Images/gtk/NavigationItemBug.svg: Added.
  • UserInterface/Images/gtk/NavigationItemCurleyBraces.svg: Added.
  • UserInterface/Images/gtk/NavigationItemFile.svg: Added.
  • UserInterface/Images/gtk/NavigationItemLayers.svg: Added.
  • UserInterface/Images/gtk/NavigationItemLog.svg: Added.
  • UserInterface/Images/gtk/NavigationItemMagnifyingGlass.svg: Added.
  • UserInterface/Images/gtk/NavigationItemStopwatch.svg: Added.
  • UserInterface/Images/gtk/NavigationItemStorage.svg: Added.
  • UserInterface/Images/gtk/NavigationItemTrash.svg: Added.
  • UserInterface/Images/gtk/NavigationItemVariable.svg: Added.
  • UserInterface/Images/gtk/Network.png: Added.
  • UserInterface/Images/gtk/​Network@2x.png: Added.
  • UserInterface/Images/gtk/NetworkLarge.png: Added.
  • UserInterface/Images/gtk/​NetworkLarge@2x.png: Added.
  • UserInterface/Images/gtk/Pause.svg: Added.
  • UserInterface/Images/gtk/Percent.svg: Added.
  • UserInterface/Images/gtk/Plus.svg: Added.
  • UserInterface/Images/gtk/PseudoElement.svg: Added.
  • UserInterface/Images/gtk/Reflection.svg: Added.
  • UserInterface/Images/gtk/Reload.svg: Added.
  • UserInterface/Images/gtk/Request.svg: Added.
  • UserInterface/Images/gtk/Response.svg: Added.
  • UserInterface/Images/gtk/ResultLine.svg: Added.
  • UserInterface/Images/gtk/Resume.svg: Added.
  • UserInterface/Images/gtk/SessionStorage.png: Added.
  • UserInterface/Images/gtk/​SessionStorage@2x.png: Added.
  • UserInterface/Images/gtk/ShadowDOM.svg: Added.
  • UserInterface/Images/gtk/SourceCode.svg: Added.
  • UserInterface/Images/gtk/SplitToggleDown.svg: Added.
  • UserInterface/Images/gtk/SplitToggleUp.svg: Added.
  • UserInterface/Images/gtk/StepInto.svg: Added.
  • UserInterface/Images/gtk/StepOut.svg: Added.
  • UserInterface/Images/gtk/StepOver.svg: Added.
  • UserInterface/Images/gtk/StyleRuleAuthor.svg: Added.
  • UserInterface/Images/gtk/StyleRuleInherited.svg: Added.
  • UserInterface/Images/gtk/StyleRuleInheritedElement.svg: Added.
  • UserInterface/Images/gtk/StyleRuleInspector.svg: Added.
  • UserInterface/Images/gtk/StyleRuleUser.svg: Added.
  • UserInterface/Images/gtk/StyleRuleUserAgent.svg: Added.
  • UserInterface/Images/gtk/Time.svg: Added.
  • UserInterface/Images/gtk/TimelineRecordAnimation.svg: Added.
  • UserInterface/Images/gtk/TimelineRecordEvent.svg: Added.
  • UserInterface/Images/gtk/TimelineRecordLayout.svg: Added.
  • UserInterface/Images/gtk/TimelineRecordPaint.svg: Added.
  • UserInterface/Images/gtk/TimelineRecordScriptEvaluated.svg: Added.
  • UserInterface/Images/gtk/TimelineRecordStyle.svg: Added.
  • UserInterface/Images/gtk/TimelineRecordTimer.svg: Added.
  • UserInterface/Images/gtk/Undock.svg: Added.
  • UserInterface/Images/gtk/UserInputPrompt.svg: Added.
  • UserInterface/Images/gtk/UserInputPromptPrevious.svg: Added.
  • UserInterface/Images/gtk/UserInputResult.svg: Added.
  • UserInterface/Images/gtk/Warning.svg: Added.
  • UserInterface/Images/gtk/Weight.svg: Added.
5:53 AM Changeset in webkit [173912] by Carlos Garcia Campos
  • 5 edits
    1 copy
    104 adds in trunk/Source/WebInspectorUI

Unreviewed. Add more free icons for the Web Inspector in GTK+

Patch by Andres Gomez <Andres Gomez> on 2014-09-24

  • UserInterface/Images/gtk/AUTHORS:
  • UserInterface/Images/gtk/ApplicationCache.png: Added.
  • UserInterface/Images/gtk/​ApplicationCache@2x.png: Added.
  • UserInterface/Images/gtk/BottomUpTree.svg: Added.
  • UserInterface/Images/gtk/Breakpoint.png: Added.
  • UserInterface/Images/gtk/​Breakpoint@2x.png: Added.
  • UserInterface/Images/gtk/BreakpointButton.svg:
  • UserInterface/Images/gtk/BreakpointInactive.png: Added.
  • UserInterface/Images/gtk/​BreakpointInactive@2x.png: Added.
  • UserInterface/Images/gtk/BreakpointInactiveButton.svg:
  • UserInterface/Images/gtk/COPYING:
  • UserInterface/Images/gtk/COPYING_CCBYSA3: Copied from Source/WebInspectorUI/UserInterface/Images/gtk/COPYING.
  • UserInterface/Images/gtk/ClippingCSS.png: Added.
  • UserInterface/Images/gtk/​ClippingCSS@2x.png: Added.
  • UserInterface/Images/gtk/ClippingGeneric.png: Added.
  • UserInterface/Images/gtk/​ClippingGeneric@2x.png: Added.
  • UserInterface/Images/gtk/ClippingJS.png: Added.
  • UserInterface/Images/gtk/​ClippingJS@2x.png: Added.
  • UserInterface/Images/gtk/CloseTimeline.png: Added.
  • UserInterface/Images/gtk/​CloseTimeline@2x.png: Added.
  • UserInterface/Images/gtk/ColorIcon.png: Added.
  • UserInterface/Images/gtk/​ColorIcon@2x.png: Added.
  • UserInterface/Images/gtk/Colors.png: Added.
  • UserInterface/Images/gtk/​Colors@2x.png: Added.
  • UserInterface/Images/gtk/ColorsLarge.png: Added.
  • UserInterface/Images/gtk/​ColorsLarge@2x.png: Added.
  • UserInterface/Images/gtk/Database.png: Added.
  • UserInterface/Images/gtk/​Database@2x.png: Added.
  • UserInterface/Images/gtk/DatabaseTable.png: Added.
  • UserInterface/Images/gtk/​DatabaseTable@2x.png: Added.
  • UserInterface/Images/gtk/HierarchicalNavigationItemChevron.svg: Added.
  • UserInterface/Images/gtk/IndeterminateProgressSpinner1.svg: Added.
  • UserInterface/Images/gtk/IndeterminateProgressSpinner10.svg: Added.
  • UserInterface/Images/gtk/IndeterminateProgressSpinner11.svg: Added.
  • UserInterface/Images/gtk/IndeterminateProgressSpinner12.svg: Added.
  • UserInterface/Images/gtk/IndeterminateProgressSpinner2.svg: Added.
  • UserInterface/Images/gtk/IndeterminateProgressSpinner3.svg: Added.
  • UserInterface/Images/gtk/IndeterminateProgressSpinner4.svg: Added.
  • UserInterface/Images/gtk/IndeterminateProgressSpinner5.svg: Added.
  • UserInterface/Images/gtk/IndeterminateProgressSpinner6.svg: Added.
  • UserInterface/Images/gtk/IndeterminateProgressSpinner7.svg: Added.
  • UserInterface/Images/gtk/IndeterminateProgressSpinner8.svg: Added.
  • UserInterface/Images/gtk/IndeterminateProgressSpinner9.svg: Added.
  • UserInterface/Images/gtk/Issues.svg: Added.
  • UserInterface/Images/gtk/IssuesEnabled.svg: Added.
  • UserInterface/Images/gtk/LayerBorders.svg: Added.
  • UserInterface/Images/gtk/LessColumns.svg: Added.
  • UserInterface/Images/gtk/LocalStorage.png: Added.
  • UserInterface/Images/gtk/​LocalStorage@2x.png: Added.
  • UserInterface/Images/gtk/Locked.svg: Added.
  • UserInterface/Images/gtk/Logs.svg: Added.
  • UserInterface/Images/gtk/Memory.svg: Added.
  • UserInterface/Images/gtk/MoreColumns.svg: Added.
  • UserInterface/Images/gtk/Native.svg: Added.
  • UserInterface/Images/gtk/NavigationItemAngleBrackets.svg: Added.
  • UserInterface/Images/gtk/NavigationItemBrushAndRuler.svg: Added.
  • UserInterface/Images/gtk/NavigationItemBug.svg: Added.
  • UserInterface/Images/gtk/NavigationItemCurleyBraces.svg: Added.
  • UserInterface/Images/gtk/NavigationItemFile.svg: Added.
  • UserInterface/Images/gtk/NavigationItemLayers.svg: Added.
  • UserInterface/Images/gtk/NavigationItemLog.svg: Added.
  • UserInterface/Images/gtk/NavigationItemMagnifyingGlass.svg: Added.
  • UserInterface/Images/gtk/NavigationItemStopwatch.svg: Added.
  • UserInterface/Images/gtk/NavigationItemStorage.svg: Added.
  • UserInterface/Images/gtk/NavigationItemTrash.svg: Added.
  • UserInterface/Images/gtk/NavigationItemVariable.svg: Added.
  • UserInterface/Images/gtk/Network.png: Added.
  • UserInterface/Images/gtk/​Network@2x.png: Added.
  • UserInterface/Images/gtk/NetworkLarge.png: Added.
  • UserInterface/Images/gtk/​NetworkLarge@2x.png: Added.
  • UserInterface/Images/gtk/Pause.svg: Added.
  • UserInterface/Images/gtk/Percent.svg: Added.
  • UserInterface/Images/gtk/Plus.svg: Added.
  • UserInterface/Images/gtk/PseudoElement.svg: Added.
  • UserInterface/Images/gtk/Reflection.svg: Added.
  • UserInterface/Images/gtk/Reload.svg: Added.
  • UserInterface/Images/gtk/Request.svg: Added.
  • UserInterface/Images/gtk/Response.svg: Added.
  • UserInterface/Images/gtk/ResultLine.svg: Added.
  • UserInterface/Images/gtk/Resume.svg: Added.
  • UserInterface/Images/gtk/SessionStorage.png: Added.
  • UserInterface/Images/gtk/​SessionStorage@2x.png: Added.
  • UserInterface/Images/gtk/ShadowDOM.svg: Added.
  • UserInterface/Images/gtk/SourceCode.svg: Added.
  • UserInterface/Images/gtk/SplitToggleDown.svg: Added.
  • UserInterface/Images/gtk/SplitToggleUp.svg: Added.
  • UserInterface/Images/gtk/StepInto.svg: Added.
  • UserInterface/Images/gtk/StepOut.svg: Added.
  • UserInterface/Images/gtk/StepOver.svg: Added.
  • UserInterface/Images/gtk/StyleRuleAuthor.svg: Added.
  • UserInterface/Images/gtk/StyleRuleInherited.svg: Added.
  • UserInterface/Images/gtk/StyleRuleInheritedElement.svg: Added.
  • UserInterface/Images/gtk/StyleRuleInspector.svg: Added.
  • UserInterface/Images/gtk/StyleRuleUser.svg: Added.
  • UserInterface/Images/gtk/StyleRuleUserAgent.svg: Added.
  • UserInterface/Images/gtk/Time.svg: Added.
  • UserInterface/Images/gtk/TimelineRecordAnimation.svg: Added.
  • UserInterface/Images/gtk/TimelineRecordEvent.svg: Added.
  • UserInterface/Images/gtk/TimelineRecordLayout.svg: Added.
  • UserInterface/Images/gtk/TimelineRecordPaint.svg: Added.
  • UserInterface/Images/gtk/TimelineRecordScriptEvaluated.svg: Added.
  • UserInterface/Images/gtk/TimelineRecordStyle.svg: Added.
  • UserInterface/Images/gtk/TimelineRecordTimer.svg: Added.
  • UserInterface/Images/gtk/Undock.svg: Added.
  • UserInterface/Images/gtk/UserInputPrompt.svg: Added.
  • UserInterface/Images/gtk/UserInputPromptPrevious.svg: Added.
  • UserInterface/Images/gtk/UserInputResult.svg: Added.
  • UserInterface/Images/gtk/Warning.svg: Added.
  • UserInterface/Images/gtk/Weight.svg: Added.
2:14 AM Changeset in webkit [173911] by commit-queue@webkit.org
  • 7 edits
    3 deletes in trunk

Unreviewed, rolling out r173839.
​https://bugs.webkit.org/show_bug.cgi?id=137062

NumberConstruct should no longer use static tables (Requested
by dpino on #webkit).

Reverted changeset:

"Simple ES6 feature: Number constructor extras"
​https://bugs.webkit.org/show_bug.cgi?id=131707
​http://trac.webkit.org/changeset/173839

1:35 AM WebKitGTK/KeepingTheTreeGreen edited by ltilve@igalia.com
(diff)
12:56 AM Changeset in webkit [173910] by commit-queue@webkit.org
  • 5 edits
    6 adds in trunk

Remove the style marking from :nth-child()
​https://bugs.webkit.org/show_bug.cgi?id=137055

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2014-09-24
Reviewed by Andreas Kling.

Source/WebCore:

Previously, :nth-child() had to mark the RenderStyle as unique in order
to prevent it from being used for style sharing.

After r173229, :nth-child() use the more generic element marking
"StyleIsAffectedByPreviousSibling".

In StyleResolver::canShareStyleWithElement(), StyleIsAffectedByPreviousSibling
is already used to prevent style sharing of those elements, making the "Unique"
flag redundant.

Since it is now useless, remove the style marking from SelectorChecker and the CSS JIT.

Tests: fast/css/nth-child-style-sharing-even.html

fast/css/nth-child-style-sharing-fixed-integer.html
fast/css/nth-child-style-sharing-odd.html

  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::checkOne):

  • cssjit/SelectorCompiler.cpp:

(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementIsNthChild):
(WebCore::SelectorCompiler::setElementChildIndexAndUpdateStyle): Deleted.

  • rendering/style/RenderStyle.h:

LayoutTests:

Add basic tests for style sharing with :nth-child().

  • fast/css/nth-child-style-sharing-even-expected.html: Added.
  • fast/css/nth-child-style-sharing-even.html: Added.
  • fast/css/nth-child-style-sharing-fixed-integer-expected.html: Added.
  • fast/css/nth-child-style-sharing-fixed-integer.html: Added.
  • fast/css/nth-child-style-sharing-odd-expected.html: Added.
  • fast/css/nth-child-style-sharing-odd.html: Added.

Sep 23, 2014:

11:31 PM WebKitGTK/2.6.x edited by tpopela@redhat.com
(diff)
10:10 PM Changeset in webkit [173909] by ggaren@apple.com
  • 2 edits in trunk/Source/WTF

2014-09-23 Geoffrey Garen <​ggaren@apple.com>

Rolled out r173346.

bmalloc should honor the FastMalloc statistics API
​https://bugs.webkit.org/show_bug.cgi?id=136592

This didn't really work. Because we allow ranges with and without
physical pages to merge, and we allow double-committing and
double-decommitting, we can't rely on commit actions to track memory
footprint.

  • wtf/FastMalloc.cpp: (WTF::fastMallocStatistics):
10:07 PM Changeset in webkit [173908] by ggaren@apple.com
  • 6 edits in trunk/Source/bmalloc

2014-09-23 Geoffrey Garen <​ggaren@apple.com>

Rolled out r173346.

bmalloc should honor the FastMalloc statistics API
​https://bugs.webkit.org/show_bug.cgi?id=136592

This didn't really work. Because we allow ranges with and without
physical pages to merge, and we allow double-committing and
double-decommitting, we can't rely on commit actions to track memory
footprint.

  • bmalloc/Heap.cpp: (bmalloc::Heap::size): Deleted. (bmalloc::Heap::capacity): Deleted.
  • bmalloc/Heap.h:
  • bmalloc/VMHeap.cpp: (bmalloc::VMHeap::VMHeap): (bmalloc::VMHeap::allocateSmallChunk): (bmalloc::VMHeap::allocateMediumChunk): (bmalloc::VMHeap::allocateLargeChunk):
  • bmalloc/VMHeap.h: (bmalloc::VMHeap::allocateSmallPage): (bmalloc::VMHeap::allocateMediumPage): (bmalloc::VMHeap::allocateLargeRange): (bmalloc::VMHeap::deallocateSmallPage): (bmalloc::VMHeap::deallocateMediumPage): (bmalloc::VMHeap::deallocateLargeRange): (bmalloc::VMHeap::size): Deleted. (bmalloc::VMHeap::capacity): Deleted.
  • bmalloc/bmalloc.h: (bmalloc::api::heapSize): Deleted. (bmalloc::api::heapCapacity): Deleted.
8:31 PM Changeset in webkit [173907] by Chris Dumez
  • 9 edits in trunk/Source/WebCore

Add support for is<HTML*Element>() for type checking
​https://bugs.webkit.org/show_bug.cgi?id=137015

Reviewed by Benjamin Poulain.

Add support for is<HTML*Element>() for type checking while keeping
support for the legacy toHTML*Element() form until the code base is
ported.

toHTML*Element() helpers are now macros to the new is<HTML*Element>()
type checking helpers.

No new tests, no behavior change.

  • dom/Document.cpp:

(WebCore::Document::setTitle):

  • dom/Element.cpp:

(WebCore::Element::childShouldCreateRenderer):

  • dom/Element.h:

(WebCore::is):
(WebCore::downcast):
(WebCore::isElementOfType): Deleted.

  • dom/ElementAncestorIterator.h:

(WebCore::lineageOfType):

  • dom/ElementIterator.h:

(WebCore::findElementAncestorOfType):

  • dom/ElementTraversal.h:

(WebCore::Traversal<ElementType>::firstChildTemplate):
(WebCore::Traversal<ElementType>::lastChildTemplate):
(WebCore::Traversal<ElementType>::firstWithinTemplate):
(WebCore::Traversal<ElementType>::lastWithinTemplate):
(WebCore::Traversal<ElementType>::nextTemplate):
(WebCore::Traversal<ElementType>::previous):
(WebCore::Traversal<ElementType>::nextSibling):
(WebCore::Traversal<ElementType>::previousSibling):
(WebCore::Traversal<ElementType>::nextSkippingChildren):

  • dom/TypedElementDescendantIterator.h:

(WebCore::TypedElementDescendantIteratorAdapter<ElementType>::from):
(WebCore::TypedElementDescendantConstIteratorAdapter<ElementType>::from):

  • dom/make_names.pl:

(printTypeHelpers):

8:17 PM Changeset in webkit [173906] by benjamin@webkit.org
  • 3 edits
    8 adds in trunk

The style resolution cache applies properties incorrectly whenever direction != ltr
​https://bugs.webkit.org/show_bug.cgi?id=137052

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2014-09-23
Reviewed by Andreas Kling.

Source/WebCore:

The optimization r135021 introduced a bug whenever the direction of subtree is not
uniform in the whole page.

When StyleResolver::applyMatchedProperties() resolves the style, some properties are
resolved differently based on the writing-mode and the direction.

In isCacheableInMatchedPropertiesCache(), the cases for writing-mode are already handled
by not caching any style with anything else than the default.
The direction was ignored, causing the bugs solved here.

Tests: css3/flexbox/flex-flow-2.html

fast/css/style-resolver-cache-direction-1.html
fast/css/style-resolver-cache-direction-2.html
fast/css/style-resolver-cache-direction-3.html

  • css/StyleResolver.cpp:

(WebCore::isCacheableInMatchedPropertiesCache):

LayoutTests:

  • css3/flexbox/flex-flow-2-expected.txt: Added.
  • css3/flexbox/flex-flow-2.html: Added.

The test flex-flow.html should have uncovered the bug. It did not because it uses
:nth-child(), which disable style optimizations.

flex-flow-2.html is a copy of flex-flow.html using classes instead of :nth-child().
This would have caught the bug.

  • fast/css/style-resolver-cache-direction-1-expected.html: Added.
  • fast/css/style-resolver-cache-direction-1.html: Added.
  • fast/css/style-resolver-cache-direction-2-expected.html: Added.
  • fast/css/style-resolver-cache-direction-2.html: Added.
  • fast/css/style-resolver-cache-direction-3-expected.html: Added.
  • fast/css/style-resolver-cache-direction-3.html: Added.

New basic tests for the fix.

6:45 PM Changeset in webkit [173905] by Chris Dumez
  • 18 edits in trunk/Source/WebCore

Have CSS classes' methods return more references
​https://bugs.webkit.org/show_bug.cgi?id=137036

Reviewed by Ryosuke Niwa.

Have CSS classes' methods return more references instead of pointers
when possible.

No new tests, no behavior change.

  • css/CSSFontFaceRule.cpp:

(WebCore::CSSFontFaceRule::style):

  • css/CSSFontFaceRule.h:
  • css/CSSGroupingRule.cpp:

(WebCore::CSSGroupingRule::cssRules):

  • css/CSSGroupingRule.h:
  • css/CSSImportRule.cpp:

(WebCore::CSSImportRule::media):

  • css/CSSImportRule.h:
  • css/CSSPageRule.cpp:

(WebCore::CSSPageRule::style):

  • css/CSSPageRule.h:
  • css/CSSStyleRule.cpp:

(WebCore::CSSStyleRule::style):

  • css/CSSStyleRule.h:
  • css/WebKitCSSKeyframeRule.cpp:

(WebCore::WebKitCSSKeyframeRule::style):

  • css/WebKitCSSKeyframeRule.h:
  • css/WebKitCSSKeyframesRule.cpp:

(WebCore::WebKitCSSKeyframesRule::cssRules):

  • css/WebKitCSSKeyframesRule.h:
  • css/WebKitCSSViewportRule.cpp:

(WebCore::WebKitCSSViewportRule::style):

  • css/WebKitCSSViewportRule.h:
  • inspector/InspectorStyleSheet.cpp:

(WebCore::asCSSRuleList):
(WebCore::fillMediaListChain):
(WebCore::InspectorStyleSheet::setRuleSelector):
(WebCore::InspectorStyleSheet::deleteRule):
(WebCore::InspectorStyleSheet::buildObjectForSelectorList):
(WebCore::InspectorStyleSheet::buildObjectForRule):
(WebCore::InspectorStyleSheet::styleForId):
(WebCore::InspectorStyleSheet::ruleIndexByStyle):
(WebCore::InspectorStyleSheet::ruleId):
(WebCore::InspectorStyleSheet::revalidateStyle):

5:52 PM Changeset in webkit [173904] by roger_fong@apple.com
  • 4 edits in trunk

[Windows] Enable CSS Supports Rule on Windows.

  • win/tools/vsprops/FeatureDefines.props:
  • css/CSSAllInOne.cpp:
5:46 PM Changeset in webkit [173903] by roger_fong@apple.com
  • 3 edits in trunk/Tools

[Windows] More debugging for the Windows bots.

  • Scripts/webkitpy/common/system/path.py:

(_CygPath):

5:16 PM Changeset in webkit [173902] by roger_fong@apple.com
  • 2 edits in trunk/Tools

Unreviewed. Fix for r173899, those tabs should be spaces.

  • Scripts/webkitpy/port/driver.py:

(Driver._command_from_driver_input):
(Driver): Deleted.

5:08 PM Changeset in webkit [173901] by roger_fong@apple.com
  • 2 edits
    3 adds in trunk/LayoutTests

[Windows] More windows test gardening of some fast/dom tests.

  • platform/win/TestExpectations:
  • platform/win/fast/dom/NavigatorContentUtils: Added.
  • platform/win/fast/dom/NavigatorContentUtils/is-protocol-handler-registered-expected.txt: Added.
  • platform/win/fast/dom/navigator-detached-no-crash-expected.txt: Added.
4:58 PM Changeset in webkit [173900] by Brent Fulgham
  • 2 edits in trunk/Source/WebKit

[Win] 64-bit Build fix after r173882.

  • WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in: Add correct 64-bit mangled symbol name.
4:34 PM Changeset in webkit [173899] by roger_fong@apple.com
  • 2 edits in trunk/Tools

[Windows] Add some logging to debug a problem with the Windows bots that causes layout tests to exit early.

  • Scripts/webkitpy/port/driver.py:

(Driver):

4:07 PM Changeset in webkit [173898] by Lucas Forschler
  • 2 edits in branches/safari-600.1-branch/Source/WebCore

Rollout 173848. rdar://problem/12708225

3:30 PM Changeset in webkit [173897] by Lucas Forschler
  • 2 edits in branches/safari-600.1-branch/Source/WebCore

Merged r173848. rdar://problem/12708225

3:29 PM Changeset in webkit [173896] by mark.lam@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

DebuggerCallFrame::invalidate() should invalidate all DebuggerScope chains.
<​https://webkit.org/b/137045>

Reviewed by Geoffrey Garen.

DebuggerCallFrame::invalidate() currently invalidates all DebuggerCallFrames
in the debugger stack, but only invalidates the DebuggerScope chain of the
top most frame. We should also invalidate all the DebuggerScope chains of
the other frames in the debugger stack.

  • debugger/DebuggerCallFrame.cpp:

(JSC::DebuggerCallFrame::invalidate):

  • debugger/DebuggerScope.cpp:

(JSC::DebuggerScope::invalidateChain):

3:27 PM Changeset in webkit [173895] by Chris Dumez
  • 27 edits in trunk/Source

Unreviewed build fix after r173893.

Partial revert of r173893 to fix debug builds.

Source/WebCore:

  • accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::text):

  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::namedItemGetter):
(WebCore::JSDOMWindow::getOwnPropertySlot):
(WebCore::JSDOMWindow::getOwnPropertySlotByIndex):

  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::checkOne):

  • cssjit/SelectorCompiler.cpp:

(WebCore::SelectorCompiler::makeContextStyleUniqueIfNecessaryAndTestIsPlaceholderShown):
(WebCore::SelectorCompiler::makeElementStyleUniqueIfNecessaryAndTestIsPlaceholderShown):
(WebCore::SelectorCompiler::isPlaceholderShown):

  • dom/Document.cpp:

(WebCore::Document::processHttpEquiv):

  • dom/Element.cpp:

(WebCore::Element::insertedInto):
(WebCore::Element::removedFrom):
(WebCore::Element::updateName):
(WebCore::Element::updateId):

  • editing/Editor.cpp:

(WebCore::Editor::selectionForCommand):
(WebCore::findFirstMarkable):

  • editing/FrameSelection.cpp:

(WebCore::FrameSelection::selectAll):

  • html/HTMLElement.cpp:

(WebCore::HTMLElement::matchesReadWritePseudoClass):
(WebCore::HTMLElement::directionality):

  • html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::parseAttribute):

  • html/HTMLObjectElement.cpp:

(WebCore::HTMLObjectElement::updateDocNamedItem):

  • html/HTMLPlugInImageElement.cpp:

(WebCore::addPlugInsFromNodeListMatchingPlugInOrigin):

  • html/HTMLTextFormControlElement.cpp:

(WebCore::enclosingTextFormControl):

  • page/FrameView.cpp:

(WebCore::FrameView::addEmbeddedObjectToUpdate):
(WebCore::FrameView::updateEmbeddedObject):

  • rendering/HitTestResult.cpp:

(WebCore::HitTestResult::absolutePDFURL):

  • rendering/RenderEmbeddedObject.cpp:

(WebCore::RenderEmbeddedObject::paintContents):
(WebCore::RenderEmbeddedObject::layout):

  • rendering/RenderSnapshottedPlugIn.cpp:

(WebCore::RenderSnapshottedPlugIn::plugInImageElement):

  • rendering/RenderTextControl.cpp:

(WebCore::RenderTextControl::textFormControlElement):

  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::paintSearchFieldCancelButton):
(WebCore::RenderThemeMac::paintSnapshottedPluginOverlay):

  • testing/Internals.cpp:

(WebCore::Internals::visiblePlaceholder):

Source/WebKit/win:

  • DOMHTMLClasses.cpp:

(DOMHTMLDocument::URL):
(DOMHTMLDocument::body):
(DOMHTMLDocument::forms):

Source/WebKit2:

  • WebProcess/Plugins/PDF/PDFPluginTextAnnotation.mm:

(WebKit::PDFPluginTextAnnotation::value):

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::initializePlugin):
(WebKit::PluginView::pluginSnapshotTimerFired):
(WebKit::PluginView::pluginDidReceiveUserInteraction):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::createPlugin):

3:16 PM Changeset in webkit [173894] by Brent Fulgham
  • 6 edits in trunk/Source/WebCore

Implement snapping behavior for Mac overflow scrolling
​https://bugs.webkit.org/show_bug.cgi?id=135774

Patch by Wenson Hsieh <Wenson Hsieh> on 2014-09-22
Reviewed by Beth Dakin.

Hooks into AxisScrollSnapAnimator to implement overflow scroll snapping on Mac.

We need to find a way to test this!

  • dom/Element.cpp:

(WebCore::Element::dispatchWheelEvent):

  • page/EventHandler.cpp:

(WebCore::handleWheelEventInAppropriateEnclosingBoxForSingleAxis):

  • platform/ScrollAnimator.cpp:

(WebCore::ScrollAnimator::handleWheelEvent):
(WebCore::ScrollAnimator::updateScrollAnimatorsAndTimers):
(WebCore::ScrollAnimator::scrollOffsetInAxis):
(WebCore::ScrollAnimator::immediateScrollInAxis):
(WebCore::ScrollAnimator::startScrollSnapTimer):
(WebCore::ScrollAnimator::stopScrollSnapTimer):
(WebCore::ScrollAnimator::horizontalScrollSnapTimerFired):
(WebCore::ScrollAnimator::verticalScrollSnapTimerFired):

  • platform/ScrollAnimator.h:
  • platform/mac/AxisScrollSnapAnimator.h:
  • platform/mac/AxisScrollSnapAnimator.mm:

(WebCore::AxisScrollSnapAnimator::AxisScrollSnapAnimator):
(WebCore::AxisScrollSnapAnimator::beginScrollSnapAnimation):
(WebCore::AxisScrollSnapAnimator::endScrollSnapAnimation):
(WebCore::AxisScrollSnapAnimator::initializeGlideParameters):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateScrollInfoAfterLayout):

3:03 PM Changeset in webkit [173893] by Chris Dumez
  • 155 edits in trunk/Source

Use downcast<HTML*Element>() instead of toHTML*Element()
​https://bugs.webkit.org/show_bug.cgi?id=137007

Reviewed by Benjamin Poulain.

Source/WebCore:

Use downcast<HTML*Element>() instead of toHTML*Element() and drop
transition macros for toHTML*Element().

This patch also cleans up the surrounding code.

No new tests, no behavior change.

  • accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::focusedUIElementForPage):
(WebCore::AXObjectCache::labelChanged):

  • accessibility/AccessibilityListBox.cpp:

(WebCore::AccessibilityListBox::canSetSelectedChildrenAttribute):
(WebCore::AccessibilityListBox::addChildren):

  • accessibility/AccessibilityListBoxOption.cpp:

(WebCore::AccessibilityListBoxOption::isSelected):
(WebCore::AccessibilityListBoxOption::stringValue):
(WebCore::AccessibilityListBoxOption::listBoxOptionParentNode):

  • accessibility/AccessibilityMediaControls.cpp:

(WebCore::AccessibilityMediaTimeline::valueDescription):

  • accessibility/AccessibilityMenuListOption.cpp:

(WebCore::AccessibilityMenuListOption::isEnabled):
(WebCore::AccessibilityMenuListOption::isSelected):
(WebCore::AccessibilityMenuListOption::setSelected):
(WebCore::AccessibilityMenuListOption::stringValue):

  • accessibility/AccessibilityMenuListPopup.cpp:

(WebCore::AccessibilityMenuListPopup::addChildren):

  • accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::determineAccessibilityRole):
(WebCore::AccessibilityNodeObject::isNativeTextControl):
(WebCore::AccessibilityNodeObject::isNativeImage):
(WebCore::AccessibilityNodeObject::isInputImage):
(WebCore::AccessibilityNodeObject::isMultiSelectable):
(WebCore::AccessibilityNodeObject::isReadOnly):
(WebCore::AccessibilityNodeObject::valueForRange):
(WebCore::AccessibilityNodeObject::maxValueForRange):
(WebCore::AccessibilityNodeObject::minValueForRange):
(WebCore::isNodeActionElement):
(WebCore::AccessibilityNodeObject::alternativeText):
(WebCore::AccessibilityNodeObject::visibleText):
(WebCore::AccessibilityNodeObject::title):
(WebCore::AccessibilityNodeObject::text):
(WebCore::AccessibilityNodeObject::stringValue):
(WebCore::AccessibilityNodeObject::colorValue):
(WebCore::accessibleNameForNode):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::isFileUploadButton):
(WebCore::AccessibilityRenderObject::stringValue):
(WebCore::AccessibilityRenderObject::labelElementContainer):
(WebCore::AccessibilityRenderObject::internalLinkElement):
(WebCore::AccessibilityRenderObject::addRadioButtonGroupMembers):
(WebCore::AccessibilityRenderObject::url):
(WebCore::AccessibilityRenderObject::setValue):
(WebCore::AccessibilityRenderObject::getDocumentLinks):
(WebCore::AccessibilityRenderObject::accessibilityImageMapHitTest):
(WebCore::AccessibilityRenderObject::accessibilityHitTest):
(WebCore::AccessibilityRenderObject::determineAccessibilityRole):
(WebCore::AccessibilityRenderObject::addTextFieldChildren):
(WebCore::AccessibilityRenderObject::stringValueForMSAA):
(WebCore::AccessibilityRenderObject::isLinked):

  • accessibility/AccessibilitySlider.cpp:

(WebCore::AccessibilitySlider::inputElement):
(WebCore::AccessibilitySliderThumb::elementRect):

  • accessibility/AccessibilityTable.cpp:

(WebCore::AccessibilityTable::tableElement):
(WebCore::AccessibilityTable::title):

  • accessibility/atk/AXObjectCacheAtk.cpp:

(WebCore::notifyChildrenSelectionChange):

  • accessibility/atk/WebKitAccessibleInterfaceSelection.cpp:

(optionFromSelection):
(webkitAccessibleSelectionGetSelectionCount):

  • accessibility/atk/WebKitAccessibleInterfaceTable.cpp:

(webkitAccessibleTableGetCaption):

  • accessibility/atk/WebKitAccessibleWrapperAtk.cpp:

(webkitAccessibleGetDescription):

  • accessibility/ios/AccessibilityObjectIOS.mm:

(WebCore::AccessibilityObject::accessibilityPasswordFieldLength):

  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::namedItemGetter):
(WebCore::JSDOMWindow::getOwnPropertySlot):
(WebCore::JSDOMWindow::getOwnPropertySlotByIndex):

  • bindings/js/JSHTMLDocumentCustom.cpp:

(WebCore::JSHTMLDocument::nameGetter):

  • bindings/js/JSHTMLFrameSetElementCustom.cpp:

(WebCore::JSHTMLFrameSetElement::nameGetter):

  • bindings/js/JSNodeCustom.cpp:

(WebCore::isReachableFromDOM):

  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::checkOne):

  • css/SelectorCheckerTestFunctions.h:

(WebCore::isChecked):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::adjustRenderStyle):

  • css/StyleSheetList.cpp:

(WebCore::StyleSheetList::getNamedItem):

  • cssjit/SelectorCompiler.cpp:

(WebCore::SelectorCompiler::makeContextStyleUniqueIfNecessaryAndTestIsPlaceholderShown):
(WebCore::SelectorCompiler::makeElementStyleUniqueIfNecessaryAndTestIsPlaceholderShown):
(WebCore::SelectorCompiler::isPlaceholderShown):

  • dom/CurrentScriptIncrementer.h:

(WebCore::CurrentScriptIncrementer::CurrentScriptIncrementer):

  • dom/DataTransfer.cpp:

(WebCore::DataTransfer::setDragImage):

  • dom/Document.cpp:

(WebCore::Document::setTitle):
(WebCore::Document::processHttpEquiv):
(WebCore::Document::iconURLs):

  • dom/DocumentOrderedMap.cpp:

(WebCore::keyMatchesMapName):
(WebCore::keyMatchesLowercasedMapName):
(WebCore::keyMatchesLowercasedUsemap):
(WebCore::DocumentOrderedMap::getElementByMapName):
(WebCore::DocumentOrderedMap::getElementByLowercasedMapName):
(WebCore::DocumentOrderedMap::getElementByLowercasedUsemap):
(WebCore::DocumentOrderedMap::getElementByLabelForAttribute):

  • dom/DocumentStyleSheetCollection.cpp:

(WebCore::DocumentStyleSheetCollection::collectActiveStyleSheets):

  • dom/Element.cpp:

(WebCore::Element::insertedInto):
(WebCore::Element::removedFrom):
(WebCore::Element::updateName):
(WebCore::Element::updateId):
(WebCore::Element::updateLabel):
(WebCore::Element::ensureCachedHTMLCollection):

  • dom/EventDispatcher.cpp:

(WebCore::EventDispatcher::dispatchEvent):

  • dom/ScriptElement.cpp:

(WebCore::toScriptElementIfPossible):

  • dom/VisitedLinkState.cpp:

(WebCore::linkHashForElement):
(WebCore::VisitedLinkState::determineLinkStateSlowCase):

  • dom/make_names.pl:

(printTypeHelpers):

  • editing/Editor.cpp:

(WebCore::Editor::selectionForCommand):
(WebCore::imageElementFromImageDocument):
(WebCore::findFirstMarkable):

  • editing/FrameSelection.cpp:

(WebCore::FrameSelection::selectAll):
(WebCore::scanForForm):

  • editing/MarkupAccumulator.cpp:

(WebCore::MarkupAccumulator::serializeNodesWithNamespaces):

  • editing/ReplaceSelectionCommand.cpp:

(WebCore::ReplaceSelectionCommand::shouldPerformSmartReplace):

  • editing/VisibleSelection.cpp:

(WebCore::VisibleSelection::nonBoundaryShadowTreeRootNode):
(WebCore::VisibleSelection::isInPasswordField):

  • editing/cocoa/HTMLConverter.mm:

(HTMLConverter::_processElement):

  • editing/ios/EditorIOS.mm:

(WebCore::Editor::setTextAlignmentForChangedBaseWritingDirection):

  • editing/markup.cpp:

(WebCore::isPlainTextMarkup):

  • html/ColorInputType.cpp:

(WebCore::ColorInputType::suggestions):

  • html/FTPDirectoryDocument.cpp:

(WebCore::FTPDirectoryDocumentParser::loadDocumentTemplate):
(WebCore::FTPDirectoryDocumentParser::createBasicDocument):

  • html/FormAssociatedElement.cpp:

(WebCore::FormAssociatedElement::findAssociatedForm):

  • html/HTMLAnchorElement.cpp:

(WebCore::appendServerMapMousePosition):

  • html/HTMLAreaElement.cpp:

(WebCore::HTMLAreaElement::imageElement):

  • html/HTMLCollection.cpp:

(WebCore::isMatchingElement):

  • html/HTMLElement.cpp:

(WebCore::HTMLElement::matchesReadWritePseudoClass):
(WebCore::HTMLElement::setInnerHTML):
(WebCore::HTMLElement::directionality):

  • html/HTMLEmbedElement.cpp:

(WebCore::HTMLEmbedElement::rendererIsNeeded):

  • html/HTMLFieldSetElement.cpp:

(WebCore::HTMLFieldSetElement::refreshElementsIfNeeded):

  • html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElement::computeIsDisabledByFieldsetAncestor):
(WebCore::shouldAutofocus):

  • html/HTMLFormControlsCollection.cpp:

(WebCore::HTMLFormControlsCollection::formControlElements):
(WebCore::HTMLFormControlsCollection::formImageElements):

  • html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::getTextFieldValues):
(WebCore::HTMLFormElement::assertItemCanBeInPastNamesMap):

  • html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::parseAttribute):

  • html/HTMLImageLoader.cpp:

(WebCore::HTMLImageLoader::notifyFinished):

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::dataList):
(WebCore::HTMLInputElement::setupDateTimeChooserParameters):

  • html/HTMLKeygenElement.cpp:

(WebCore::HTMLKeygenElement::shadowSelect):

  • html/HTMLLegendElement.cpp:

(WebCore::HTMLLegendElement::virtualForm):

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::parseAttribute):

  • html/HTMLNameCollection.cpp:

(WebCore::DocumentNameCollection::elementMatchesIfIdAttributeMatch):
(WebCore::DocumentNameCollection::elementMatchesIfNameAttributeMatch):
(WebCore::DocumentNameCollection::elementMatches):

  • html/HTMLObjectElement.cpp:

(WebCore::HTMLObjectElement::updateDocNamedItem):
(WebCore::HTMLObjectElement::containsJavaApplet):

  • html/HTMLOptGroupElement.cpp:

(WebCore::HTMLOptGroupElement::recalcSelectOptions):
(WebCore::HTMLOptGroupElement::ownerSelectElement):

  • html/HTMLOptionElement.cpp:

(WebCore::HTMLOptionElement::ownerDataListElement):
(WebCore::HTMLOptionElement::ownerSelectElement):

  • html/HTMLOptionsCollection.cpp:

(WebCore::HTMLOptionsCollection::add):

  • html/HTMLOptionsCollection.h:
  • html/HTMLPlugInImageElement.cpp:

(WebCore::addPlugInsFromNodeListMatchingPlugInOrigin):

  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::hasPlaceholderLabelOption):
(WebCore::HTMLSelectElement::value):
(WebCore::HTMLSelectElement::setValue):
(WebCore::HTMLSelectElement::saveLastSelection):
(WebCore::HTMLSelectElement::setActiveSelectionAnchorIndex):
(WebCore::HTMLSelectElement::updateListBoxSelection):
(WebCore::HTMLSelectElement::listBoxOnChange):
(WebCore::HTMLSelectElement::recalcListItems):
(WebCore::HTMLSelectElement::selectedIndex):
(WebCore::HTMLSelectElement::selectOption):
(WebCore::HTMLSelectElement::deselectItemsWithoutValidation):
(WebCore::HTMLSelectElement::saveFormControlState):
(WebCore::HTMLSelectElement::searchOptionsForValue):
(WebCore::HTMLSelectElement::restoreFormControlState):
(WebCore::HTMLSelectElement::appendFormData):
(WebCore::HTMLSelectElement::reset):
(WebCore::HTMLSelectElement::updateSelectedState):
(WebCore::HTMLSelectElement::lastSelectedListIndex):
(WebCore::HTMLSelectElement::optionAtIndex):
(WebCore::HTMLSelectElement::accessKeySetSelectedIndex):

  • html/HTMLSummaryElement.cpp:

(WebCore::HTMLSummaryElement::detailsElement):

  • html/HTMLTableElement.cpp:

(WebCore::HTMLTableElement::caption):

  • html/HTMLTablePartElement.cpp:

(WebCore::HTMLTablePartElement::findParentTable):

  • html/HTMLTableRowElement.cpp:

(WebCore::HTMLTableRowElement::rowIndex):

  • html/HTMLTableRowsCollection.cpp:

(WebCore::HTMLTableRowsCollection::rowAfter):
(WebCore::HTMLTableRowsCollection::lastRow):
(WebCore::HTMLTableRowsCollection::customElementAfter):

  • html/HTMLTableRowsCollection.h:
  • html/HTMLTemplateElement.cpp:

(WebCore::HTMLTemplateElement::cloneNode):

  • html/HTMLTextFormControlElement.cpp:

(WebCore::enclosingTextFormControl):

  • html/ImageDocument.cpp:

(WebCore::ImageDocument::createDocumentStructure):

  • html/LabelsNodeList.cpp:

(WebCore::LabelsNodeList::elementMatches):

  • html/MediaDocument.cpp:

(WebCore::MediaDocumentParser::createDocumentStructure):
(WebCore::descendentVideoElement):
(WebCore::ancestorVideoElement):
(WebCore::MediaDocument::replaceMediaElementTimerFired):

  • html/PluginDocument.cpp:

(WebCore::PluginDocumentParser::createDocumentStructure):

  • html/RadioInputType.cpp:

(WebCore::RadioInputType::handleKeydownEvent):
(WebCore::RadioInputType::isKeyboardFocusable):

  • html/RadioNodeList.cpp:

(WebCore::RadioNodeList::checkElementMatchesRadioNodeListFilter):

  • html/RangeInputType.cpp:

(WebCore::RangeInputType::updateTickMarkValues):

  • html/parser/HTMLConstructionSite.cpp:

(WebCore::insert):
(WebCore::HTMLConstructionSite::insertTextNode):
(WebCore::HTMLConstructionSite::ownerDocumentForCurrentNode):

  • html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::HTMLTreeBuilder):

  • html/shadow/DetailsMarkerControl.cpp:

(WebCore::DetailsMarkerControl::rendererIsNeeded):

  • html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlTextTrackContainerElement::updateDisplay):

  • html/shadow/MeterShadowElement.cpp:

(WebCore::MeterShadowElement::meterElement):

  • html/shadow/ProgressShadowElement.cpp:

(WebCore::ProgressShadowElement::progressElement):

  • html/shadow/TextControlInnerElements.cpp:

(WebCore::SearchFieldResultsButtonElement::defaultEventHandler):
(WebCore::SearchFieldCancelButtonElement::defaultEventHandler):
(WebCore::SearchFieldCancelButtonElement::willRespondToMouseClickEvents):

  • inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::viaInspectorStyleSheet):

  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::buildObjectForNode):

  • loader/FormSubmission.cpp:

(WebCore::FormSubmission::create):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::handleFallbackContent):

  • loader/ImageLoader.cpp:

(WebCore::ImageLoader::dispatchPendingBeforeLoadEvent):

  • loader/SubframeLoader.cpp:

(WebCore::SubframeLoader::requestObject):

  • page/Chrome.cpp:

(WebCore::Chrome::setToolTip):

  • page/DragController.cpp:

(WebCore::DragController::draggableElement):

  • page/EventHandler.cpp:

(WebCore::isSubmitImage):

  • page/FocusController.cpp:

(WebCore::FocusController::advanceFocusDirectionally):

  • page/FrameView.cpp:

(WebCore::FrameView::addEmbeddedObjectToUpdate):
(WebCore::FrameView::updateEmbeddedObject):

  • page/PageSerializer.cpp:

(WebCore::PageSerializer::serializeFrame):

  • page/SpatialNavigation.cpp:

(WebCore::FocusCandidate::FocusCandidate):

  • page/ios/FrameIOS.mm:

(WebCore::ancestorRespondingToClickEvents):

  • rendering/HitTestResult.cpp:

(WebCore::HitTestResult::altDisplayString):
(WebCore::HitTestResult::absolutePDFURL):
(WebCore::HitTestResult::enterFullscreenForVideo):
(WebCore::HitTestResult::mediaControlsEnabled):
(WebCore::HitTestResult::isLiveLink):
(WebCore::HitTestResult::isContentEditable):

  • rendering/RenderButton.cpp:

(WebCore::RenderButton::updateFromElement):

  • rendering/RenderCounter.cpp:

(WebCore::planCounter):

  • rendering/RenderEmbeddedObject.cpp:

(WebCore::RenderEmbeddedObject::paintContents):
(WebCore::RenderEmbeddedObject::layout):

  • rendering/RenderFieldset.h:
  • rendering/RenderFileUploadControl.cpp:

(WebCore::RenderFileUploadControl::inputElement):
(WebCore::RenderFileUploadControl::uploadButton):

  • rendering/RenderFrame.cpp:

(WebCore::RenderFrame::frameElement):

  • rendering/RenderFrameSet.cpp:

(WebCore::RenderFrameSet::frameSetElement):

  • rendering/RenderHTMLCanvas.cpp:

(WebCore::RenderHTMLCanvas::canvasElement):

  • rendering/RenderIFrame.cpp:

(WebCore::RenderIFrame::iframeElement):

  • rendering/RenderImage.cpp:

(WebCore::RenderImage::RenderImage):
(WebCore::RenderImage::paintAreaElementFocusRing):
(WebCore::RenderImage::paintIntoRect):
(WebCore::RenderImage::imageMap):
(WebCore::RenderImage::updateAltText):

  • rendering/RenderLayerBacking.cpp:

(WebCore::canvasCompositingStrategy):
(WebCore::RenderLayerBacking::createPrimaryGraphicsLayer):
(WebCore::RenderLayerBacking::updateConfiguration):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::requiresCompositingForCanvas):

  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::selectElement):
(WebCore::RenderListBox::updateFromElement):
(WebCore::RenderListBox::paintItemForeground):
(WebCore::RenderListBox::paintItemBackground):

  • rendering/RenderListItem.cpp:

(WebCore::RenderListItem::calcValue):
(WebCore::RenderListItem::updateListMarkerNumbers):

  • rendering/RenderMarquee.cpp:

(WebCore::RenderMarquee::marqueeSpeed):

  • rendering/RenderMenuList.cpp:

(WebCore::selectedOptionCount):
(RenderMenuList::selectElement):
(RenderMenuList::updateOptionsWidth):
(RenderMenuList::setTextFromOption):
(RenderMenuList::itemText):
(RenderMenuList::itemIsSelected):

  • rendering/RenderMeter.cpp:

(WebCore::RenderMeter::meterElement):

  • rendering/RenderProgress.cpp:

(WebCore::RenderProgress::progressElement):

  • rendering/RenderSlider.cpp:

(WebCore::RenderSlider::element):

  • rendering/RenderSnapshottedPlugIn.cpp:

(WebCore::RenderSnapshottedPlugIn::plugInImageElement):

  • rendering/RenderTextControl.cpp:

(WebCore::RenderTextControl::textFormControlElement):

  • rendering/RenderTextControlMultiLine.cpp:

(WebCore::RenderTextControlMultiLine::textAreaElement):

  • rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::inputElement):

  • rendering/RenderTheme.cpp:

(WebCore::RenderTheme::paintSliderTicks):

  • rendering/RenderThemeIOS.mm:

(WebCore::RenderThemeIOS::paintMenuListButtonDecorations):

  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::paintSearchFieldCancelButton):
(WebCore::RenderThemeMac::paintSnapshottedPluginOverlay):

  • rendering/RenderVideo.cpp:

(WebCore::RenderVideo::videoElement):

  • svg/graphics/SVGImageCache.cpp:

(WebCore::SVGImageCache::imageForRenderer):

  • svg/svgtags.in:

Generate helpers to SVGAElement so that isSVGAElement() can be used
instead of hasTagName(SVGNames::aTag). I did such update in this
patch.

  • testing/Internals.cpp:

(WebCore::Internals::visiblePlaceholder):
(WebCore::Internals::wasLastChangeUserEdit):
(WebCore::Internals::updateLayoutIgnorePendingStylesheetsAndRunPostLayoutTasks):
(WebCore::Internals::isSelectPopupVisible):

  • xml/parser/XMLDocumentParserLibxml2.cpp:

(WebCore::XMLDocumentParser::startElementNs):

Source/WebKit/ios:

Use downcast<HTML*Element>() instead of toHTML*Element().

  • WebCoreSupport/WebChromeClientIOS.mm:

(WebChromeClientIOS::focusedElementChanged):

Source/WebKit/mac:

Use downcast<HTML*Element>() instead of toHTML*Element().

  • DOM/WebDOMOperations.mm:

(-[DOMHTMLInputElement _setAutofilled:]):

  • WebCoreSupport/WebChromeClient.mm:

(WebChromeClient::focusedElementChanged):

  • WebCoreSupport/WebEditorClient.mm:

(WebEditorClient::textFieldDidBeginEditing):
(WebEditorClient::textFieldDidEndEditing):
(WebEditorClient::textDidChangeInTextField):
(WebEditorClient::doTextFieldCommandFromEvent):
(WebEditorClient::textWillBeDeletedInTextField):
(WebEditorClient::textDidChangeInTextArea):

  • WebView/WebHTMLRepresentation.mm:

(inputElementFromDOMElement):

Source/WebKit/win:

Use downcast<HTML*Element>() instead of toHTML*Element().

  • DOMHTMLClasses.cpp:

(DOMHTMLDocument::URL):
(DOMHTMLDocument::body):
(DOMHTMLDocument::forms):
(DOMHTMLFormElement::action):
(DOMHTMLFormElement::method):
(DOMHTMLSelectElement::options):
(DOMHTMLSelectElement::activateItemAtIndex):
(DOMHTMLOptionElement::text):
(DOMHTMLOptionElement::label):
(DOMHTMLInputElement::form):
(DOMHTMLInputElement::disabled):
(DOMHTMLInputElement::readOnly):
(DOMHTMLInputElement::setType):
(DOMHTMLInputElement::value):
(DOMHTMLInputElement::setValue):
(DOMHTMLInputElement::setValueForUser):
(DOMHTMLInputElement::select):
(DOMHTMLInputElement::setSelectionStart):
(DOMHTMLInputElement::selectionStart):
(DOMHTMLInputElement::setSelectionEnd):
(DOMHTMLInputElement::selectionEnd):
(DOMHTMLInputElement::isTextField):
(DOMHTMLInputElement::replaceCharactersInRange):
(DOMHTMLInputElement::selectedRange):
(DOMHTMLInputElement::setAutofilled):
(DOMHTMLInputElement::isAutofilled):
(DOMHTMLInputElement::isUserEdited):
(DOMHTMLTextAreaElement::form):
(DOMHTMLTextAreaElement::value):
(DOMHTMLTextAreaElement::setValue):
(DOMHTMLTextAreaElement::select):
(DOMHTMLTextAreaElement::isUserEdited):
(DOMHTMLIFrameElement::contentFrame):

  • WebFrame.cpp:

(formElementFromDOMElement):
(inputElementFromDOMElement):

Source/WebKit2:

Use downcast<HTML*Element>() instead of toHTML*Element().

  • WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:

(WebKit::InjectedBundleNodeHandle::setHTMLInputElementValueForUser):
(WebKit::InjectedBundleNodeHandle::isHTMLInputElementAutofilled):
(WebKit::InjectedBundleNodeHandle::setHTMLInputElementAutofilled):
(WebKit::InjectedBundleNodeHandle::htmlInputElementLastChangeWasUserEdit):
(WebKit::InjectedBundleNodeHandle::htmlTextAreaElementLastChangeWasUserEdit):
(WebKit::InjectedBundleNodeHandle::isTextField):
(WebKit::InjectedBundleNodeHandle::htmlTableCellElementCellAbove):
(WebKit::InjectedBundleNodeHandle::htmlIFrameElementContentFrame):

  • WebProcess/Plugins/PDF/PDFPluginChoiceAnnotation.mm:

(WebKit::PDFPluginChoiceAnnotation::commit):

  • WebProcess/Plugins/PDF/PDFPluginTextAnnotation.mm:

(WebKit::PDFPluginTextAnnotation::createAnnotationElement):
(WebKit::PDFPluginTextAnnotation::value):

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::initializePlugin):
(WebKit::PluginView::pluginSnapshotTimerFired):
(WebKit::PluginView::pluginDidReceiveUserInteraction):

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::focusedElementChanged):

  • WebProcess/WebCoreSupport/WebEditorClient.cpp:

(WebKit::WebEditorClient::textFieldDidBeginEditing):
(WebKit::WebEditorClient::textFieldDidEndEditing):
(WebKit::WebEditorClient::textDidChangeInTextField):
(WebKit::WebEditorClient::textDidChangeInTextArea):
(WebKit::WebEditorClient::doTextFieldCommandFromEvent):
(WebKit::WebEditorClient::textWillBeDeletedInTextField):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::createPlugin):

  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::setAssistedNodeValue):
(WebKit::WebPage::setAssistedNodeValueAsNumber):
(WebKit::WebPage::setAssistedNodeSelectedIndex):
(WebKit::isAssistableNode): Deleted.
(WebKit::WebPage::getAssistedNodeInformation): Deleted.

2:24 PM Changeset in webkit [173892] by mark.lam@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Renamed DebuggerCallFrameScope to DebuggerPausedScope.
<​https://webkit.org/b/137042>

Reviewed by Michael Saboff.

DebuggerPausedScope is a better name for this data structure because it
is meant for tracking the period within which the debugger is paused,
and doing clean ups after the pause ends.

  • debugger/Debugger.cpp:

(JSC::DebuggerPausedScope::DebuggerPausedScope):
(JSC::DebuggerPausedScope::~DebuggerPausedScope):
(JSC::Debugger::pauseIfNeeded):
(JSC::DebuggerCallFrameScope::DebuggerCallFrameScope): Deleted.
(JSC::DebuggerCallFrameScope::~DebuggerCallFrameScope): Deleted.

  • debugger/Debugger.h:
  • debugger/DebuggerCallFrame.h:
2:21 PM Changeset in webkit [173891] by Chris Dumez
  • 3 edits in trunk/Source/WebCore

Have DataTransfer::files() return a reference
​https://bugs.webkit.org/show_bug.cgi?id=137039

Reviewed by Ryosuke Niwa.

Have DataTransfer::files() return a reference instead of a pointer as
it can never return null.

No new tests, no behavior change.

  • dom/DataTransfer.cpp:

(WebCore::DataTransfer::files):

  • dom/DataTransfer.h:
2:17 PM Changeset in webkit [173890] by Chris Dumez
  • 3 edits in trunk/Source/WebCore

Have NamedNodeMap::element() and DOMStringMap::element() return a reference
​https://bugs.webkit.org/show_bug.cgi?id=137040

Reviewed by Ryosuke Niwa.

Have NamedNodeMap::element() and DOMStringMap::element() return a
reference instead of a pointer as they can never return null.

No new tests, no behavior change.

  • dom/DatasetDOMStringMap.h:
  • dom/NamedNodeMap.h:

(WebCore::NamedNodeMap::element):

2:08 PM Changeset in webkit [173889] by timothy@apple.com
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Remove UserInterface/Images/gtk from Apple builds
​https://bugs.webkit.org/show_bug.cgi?id=136955

Reviewed by Joseph Pecoraro.

  • Scripts/copy-user-interface-resources.pl:

Remove Images/Legacy and Images/gtk on Mac and Windows builds by looking
at the MAC_OS_X_VERSION_MAJOR and OFFICIAL_BUILD environment vars.

2:04 PM Changeset in webkit [173888] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebKit2

REGRESSION (r171197): Clip's content is drawn behind Safari window when entering Full Screen youtube html5 first time
​https://bugs.webkit.org/show_bug.cgi?id=137029

Reviewed by Brent Fulgham.

In r171197, we ordered the full screen window on- and off-screen so that the fullscreen animation went to the
correct screen, which introduced a subtle glitch at the beginning and end of an animation. For entering, ensure
that the window is scaled to its starting size before ordering on-screen. For exiting, order the window off-
screen before resetting its clipping rect.

  • UIProcess/mac/WKFullScreenWindowController.mm:

(-[WKFullScreenWindowController beganEnterFullScreenWithInitialFrame:finalFrame:]):
(-[WKFullScreenWindowController finishedExitFullScreenAnimation:]):

1:54 PM Changeset in webkit [173887] by jer.noble@apple.com
  • 2 edits in trunk/Tools

[Tools] git-commit uses wrong ChangeLog when run from a subdirectory
​https://bugs.webkit.org/show_bug.cgi?id=137031

Reviewed by Joseph Pecoraro.

commit-log-editor is run from the top of the Git checkout, even when git-commit is invoked
from a subdirectory, making the parsed locations of ChangeLog files incorrect. Git provides
a mapping prefix in the GIT_PREFIX environment variable, so apply this prefix to the parsed
ChangeLog locations before passing them to createCommitMessage().

  • Scripts/commit-log-editor:
1:21 PM Changeset in webkit [173886] by commit-queue@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

[CLoop] - Fix CLoop on the 32-bit Big-Endians
​https://bugs.webkit.org/show_bug.cgi?id=137020

Patch by Tomas Popela <​tpopela@redhat.com> on 2014-09-23
Reviewed by Mark Lam.

  • llint/LowLevelInterpreter.asm:
  • llint/LowLevelInterpreter32_64.asm:
12:53 PM Changeset in webkit [173885] by Chris Dumez
  • 5 edits in trunk/Source/WebCore

Have DOMImplementation::document() and Element::attributes() return references
​https://bugs.webkit.org/show_bug.cgi?id=137035

Reviewed by Andreas Kling.

Have DOMImplementation::document() and Element::attributes() return
references instead of pointers as they can never return null.

No new tests, no behavior change.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):
Update the JS Bindings code generator to use WTF::getPtr() in a couple
more places so that the implementation can return references instead
of pointers even when [GenerateIsReachable=xxx] IDL extended attribute
is used.

  • dom/DOMImplementation.h:

(WebCore::DOMImplementation::document):

  • dom/Element.cpp:

(WebCore::Element::attributes):

  • dom/Element.h:

(WebCore::Node::attributes):

12:30 PM Changeset in webkit [173884] by Chris Dumez
  • 5 edits in trunk/Source/WebCore

Have Document::ensureTemplateDocument() return a reference
​https://bugs.webkit.org/show_bug.cgi?id=137033

Reviewed by Ryosuke Niwa.

Have Document::ensureTemplateDocument() return a reference instead of
a pointer as it can never return null.

No new tests, no behavior change.

  • dom/Document.cpp:

(WebCore::Document::ensureTemplateDocument):

  • dom/Document.h:
  • editing/markup.cpp:

(WebCore::createFragmentForInnerOuterHTML):

  • html/HTMLTemplateElement.cpp:

(WebCore::HTMLTemplateElement::content):
(WebCore::HTMLTemplateElement::didMoveToNewDocument):

11:44 AM Changeset in webkit [173883] by Chris Dumez
  • 28 edits in trunk/Source/WebCore

Have Document::accessSVGExtensions() return a reference
​https://bugs.webkit.org/show_bug.cgi?id=137030

Reviewed by Ryosuke Niwa.

Have Document::accessSVGExtensions() return a reference instead of a
pointer as it can never return null.

No new tests, no behavior change.

  • dom/ContainerNode.cpp:

(WebCore::ContainerNode::removeChild):
(WebCore::ContainerNode::removeChildren):

  • dom/Document.cpp:

(WebCore::Document::commonTeardown):
(WebCore::Document::implicitClose):
(WebCore::Document::accessSVGExtensions):

  • dom/Document.h:
  • dom/Element.cpp:

(WebCore::Element::~Element):
(WebCore::Element::removedFrom):

  • editing/markup.cpp:

(WebCore::isPlainTextMarkup):

  • history/CachedFrame.cpp:

(WebCore::CachedFrameBase::restore):

  • rendering/FilterEffectRenderer.cpp:

(WebCore::FilterEffectRenderer::buildReferenceFilter):

  • rendering/svg/RenderSVGResource.cpp:

(WebCore::removeFromCacheAndInvalidateDependencies):

  • rendering/svg/RenderSVGResourceContainer.cpp:

(WebCore::svgExtensionsFromElement):

  • rendering/svg/RenderSVGResourceContainer.h:

(WebCore::getRenderSVGResourceContainerById):
(WebCore::getRenderSVGResourceById):

  • rendering/svg/SVGResources.cpp:

(WebCore::registerPendingResource):
(WebCore::SVGResources::buildCachedResources):

  • rendering/svg/SVGResourcesCache.cpp:

(WebCore::resourcesCacheFromRenderer):
(WebCore::SVGResourcesCache::resourceDestroyed):

  • svg/SVGElement.cpp:

(WebCore::SVGElement::~SVGElement):
(WebCore::SVGElement::reportAttributeParsingError):
(WebCore::SVGElement::removedFrom):
(WebCore::SVGElement::viewportElement):
(WebCore::SVGElement::attributeChanged):
(WebCore::SVGElement::buildPendingResourcesIfNeeded):
(WebCore::SVGElement::accessDocumentSVGExtensions): Deleted.

  • svg/SVGElement.h:
  • svg/SVGFEConvolveMatrixElement.cpp:

(WebCore::SVGFEConvolveMatrixElement::parseAttribute):

  • svg/SVGFEGaussianBlurElement.cpp:

(WebCore::SVGFEGaussianBlurElement::parseAttribute):

  • svg/SVGFEImageElement.cpp:

(WebCore::SVGFEImageElement::clearResourceReferences):
(WebCore::SVGFEImageElement::buildPendingResource):

  • svg/SVGFitToViewBox.cpp:

(WebCore::SVGFitToViewBox::parseViewBox):

  • svg/SVGFontFaceElement.cpp:

(WebCore::SVGFontFaceElement::insertedInto):
(WebCore::SVGFontFaceElement::removedFrom):

  • svg/SVGMPathElement.cpp:

(WebCore::SVGMPathElement::buildPendingResource):
(WebCore::SVGMPathElement::clearResourceReferences):

  • svg/SVGPathElement.cpp:

(WebCore::SVGPathElement::parseAttribute):
(WebCore::SVGPathElement::invalidateMPathDependencies):

  • svg/SVGPolyElement.cpp:

(WebCore::SVGPolyElement::parseAttribute):

  • svg/SVGSVGElement.cpp:

(WebCore::SVGSVGElement::~SVGSVGElement):
(WebCore::SVGSVGElement::insertedInto):
(WebCore::SVGSVGElement::removedFrom):

  • svg/SVGTRefElement.cpp:

(WebCore::SVGTRefElement::detachTarget):
(WebCore::SVGTRefElement::buildPendingResource):

  • svg/SVGTextPathElement.cpp:

(WebCore::SVGTextPathElement::clearResourceReferences):
(WebCore::SVGTextPathElement::buildPendingResource):

  • svg/SVGUseElement.cpp:

(WebCore::SVGUseElement::clearResourceReferences):
(WebCore::SVGUseElement::buildPendingResource):
(WebCore::SVGUseElement::toClipPath):
(WebCore::SVGUseElement::buildInstanceTree):

  • svg/animation/SVGSMILElement.cpp:

(WebCore::SVGSMILElement::clearResourceReferences):
(WebCore::SVGSMILElement::buildPendingResource):

11:38 AM Changeset in webkit [173882] by commit-queue@webkit.org
  • 26 edits in trunk/Source

Web Inspector: Should be able to attach a debugger to a JSContext before anything is executed
​https://bugs.webkit.org/show_bug.cgi?id=136893

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-09-23
Reviewed by Timothy Hatcher.

Source/JavaScriptCore:

Adds new remote inspector protocol handling for automatic inspection.
Debuggers can signal they have enabled automatic inspection, and
when debuggables are created the current application will pause to
see if the debugger will inspect or decline to inspect the debuggable.

  • inspector/remote/RemoteInspectorConstants.h:
  • inspector/remote/RemoteInspector.h:
  • inspector/remote/RemoteInspector.mm:

(Inspector::globalAutomaticInspectionState):
(Inspector::RemoteInspector::RemoteInspector):
(Inspector::RemoteInspector::start):
When first starting, check the global "is there an auto-inspect" debugger state.
This is necessary so that the current application knows if it should pause or
not when a debuggable is created, even without having connected to webinspectord yet.

(Inspector::RemoteInspector::updateDebuggableAutomaticInspectCandidate):
When a debuggable has enabled remote inspection, take this path to propose
it as an automatic inspection candidate if there is an auto-inspect debugger.

(Inspector::RemoteInspector::sendAutomaticInspectionCandidateMessage):
Send the automatic inspection candidate message.

(Inspector::RemoteInspector::receivedSetupMessage):
(Inspector::RemoteInspector::setupFailed):
(Inspector::RemoteInspector::setupSucceeded):
After attempting to open an inspector, unpause if it was for the
automatic inspection candidate.

(Inspector::RemoteInspector::waitingForAutomaticInspection):
When running a nested runloop, check if we should remain paused.

(Inspector::RemoteInspector::setupXPCConnectionIfNeeded):
If by the time we connect to webinspectord we have a candidate, then
immediately send the candidate message.

(Inspector::RemoteInspector::stopInternal):
(Inspector::RemoteInspector::xpcConnectionFailed):
In error cases, clear our state.

(Inspector::RemoteInspector::xpcConnectionReceivedMessage):
(Inspector::RemoteInspector::receivedAutomaticInspectionConfigurationMessage):
(Inspector::RemoteInspector::receivedAutomaticInspectionRejectMessage):
Update state when receiving new messages.

  • inspector/remote/RemoteInspectorDebuggable.h:
  • inspector/remote/RemoteInspectorDebuggable.cpp:

(Inspector::RemoteInspectorDebuggable::setRemoteDebuggingAllowed):
Special case when a debuggable is newly allowed to be debuggable.

(Inspector::RemoteInspectorDebuggable::pauseWaitingForAutomaticInspection):
Run a nested run loop while this is an automatic inspection candidate.

  • inspector/JSGlobalObjectInspectorController.h:
  • inspector/JSGlobalObjectInspectorController.cpp:

(Inspector::JSGlobalObjectInspectorController::JSGlobalObjectInspectorController):
(Inspector::JSGlobalObjectInspectorController::connectFrontend):
When the inspector starts via automatic inspection automatically pause.
We plan on removing this condition by having the frontend signal to the
backend when it is completely initialized.

  • inspector/remote/RemoteInspectorDebuggableConnection.h:
  • inspector/remote/RemoteInspectorDebuggableConnection.mm:

(Inspector::RemoteInspectorDebuggableConnection::setup):
Pass on the flag of whether or not this was automatic inspection.

  • runtime/JSGlobalObjectDebuggable.h:
  • runtime/JSGlobalObjectDebuggable.cpp:

(JSC::JSGlobalObjectDebuggable::connect):
(JSC::JSGlobalObjectDebuggable::pauseWaitingForAutomaticInspection):
When pausing in a JSGlobalObject we need to release the API lock.

Source/WebCore:

Automatic inspection is currently disabled for web pages.
This just updates the interfaces that changed.

  • WebCore.exp.in:
  • inspector/InspectorController.cpp:

(WebCore::InspectorController::connectFrontend):
(WebCore::InspectorController::show):

  • inspector/InspectorController.h:
  • page/PageDebuggable.cpp:

(WebCore::PageDebuggable::connect):

  • page/PageDebuggable.h:
  • testing/Internals.cpp:

(WebCore::Internals::openDummyInspectorFrontend):

Source/WebKit:

  • WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:

Source/WebKit2:

  • WebProcess/WebPage/WebInspector.cpp:

(WebKit::WebInspector::remoteFrontendConnected):

Source/WTF:

Currently automatic inspection only happens in processes that have a
debugger attached. That condition may change in the future, but this
function can stand on its own in WTF. It may be useful in the future
to perhaps continue though ASSERTs if you have a debugger attached.

  • wtf/Assertions.cpp:
  • wtf/Assertions.h:
11:24 AM Changeset in webkit [173881] by ggaren@apple.com
  • 13 edits
    2 adds
    1 delete in trunk/Source/bmalloc

bmalloc: Allocation should be more precise
​https://bugs.webkit.org/show_bug.cgi?id=136993

Reviewed by Gavin Barraclough.

13% reduction in heap size on the MallocBench *_memory_warning benchmarks.

This patch teaches the allocator to merge adjacent free lines into a
single allocatable range. This allows us to shrink the size of an
individual line without increasing fragmentation or the rate of allocator
slow paths.

We'll only take more slow paths when available memory is sparse, which
is exactly when it's worth it. When available memory is dense, we'll
take fewer slow paths.

  • bmalloc.xcodeproj/project.pbxproj:
  • bmalloc/Algorithm.h:

(bmalloc::divideRoundingUp):

  • bmalloc/Allocator.cpp:

(bmalloc::Allocator::Allocator): Updated for interface changes.

(bmalloc::Allocator::scavenge): Scavenge by object instead of by line.
Now that we merge lines, it's not convenient to scavenge by line.

(bmalloc::Allocator::allocateSmallBumpRange):
(bmalloc::Allocator::allocateMediumBumpRange): Allocate whole ranges
instead of individual lines.

(bmalloc::Allocator::allocateSlowCase):
(bmalloc::Allocator::allocateSmallLine): Deleted.
(bmalloc::Allocator::allocateMediumLine): Deleted.
(bmalloc::Allocator::allocateMedium): Deleted.

  • bmalloc/Allocator.h:

(bmalloc::Allocator::allocateFastCase): Folded medium allocations
into the standard fast path with small allocations. Since a BumpAllocator
just allocates out of an arbitrary range, it doesn't need to distinguish
between small and medium lines.

  • bmalloc/BumpAllocator.h:

(bmalloc::BumpAllocator::size):
(bmalloc::BumpAllocator::BumpAllocator):
(bmalloc::BumpAllocator::init):
(bmalloc::BumpAllocator::refill):
(bmalloc::BumpAllocator::line): Deleted. No need to track line information
anymore: the heap just gives us a pointer and a pre-computed number of
objects, and we allocate them.

  • bmalloc/Deallocator.cpp:

(bmalloc::Deallocator::processObjectLog): Updated for interface changes.

  • bmalloc/Heap.cpp:

(bmalloc::Heap::Heap):
(bmalloc::Heap::initializeLineMetadata): Pre-compute precise metadata
detailing where all objects will lie in memory. After we merge two lines,
we might allocate an object that spans from one line to the next. This
metadata details which bits of memory overlap in that way, and how they
overlap.

(bmalloc::Heap::refillSmallBumpRangeCache):
(bmalloc::Heap::refillMediumBumpRangeCache): Scan a whole page at a time,
and merge adjacent free lines into BumpRanges.

(bmalloc::Heap::allocateSmallPage):
(bmalloc::Heap::allocateMediumPage):
(bmalloc::Heap::deallocateSmallLine):
(bmalloc::Heap::deallocateMediumLine): Track pages rather than lines,
since we scan for free memory a page at a time.

(bmalloc::Heap::allocateSmallLineSlowCase): Deleted.
(bmalloc::Heap::allocateMediumLineSlowCase): Deleted. Folded into the
fast path.

  • bmalloc/Heap.h:

(bmalloc::Heap::derefSmallLine):
(bmalloc::Heap::derefMediumLine):
(bmalloc::Heap::deallocateSmallLine): Deleted.
(bmalloc::Heap::allocateSmallLine): Deleted.
(bmalloc::Heap::deallocateMediumLine): Deleted.
(bmalloc::Heap::allocateMediumLine): Deleted. Updated for interface changes.

  • bmalloc/Line.h:

(bmalloc::Line<Traits>::ref):
(bmalloc::Line<Traits>::deref):
(bmalloc::Line<Traits>::concurrentRef): Deleted. We don't pass a derefCount
anymore, since we only ever deref by 1 now.

  • bmalloc/MediumAllocator.h:

(bmalloc::MediumAllocator::isNull): Deleted.
(bmalloc::MediumAllocator::MediumAllocator): Deleted.
(bmalloc::MediumAllocator::line): Deleted.
(bmalloc::MediumAllocator::allocate): Deleted.
(bmalloc::MediumAllocator::derefCount): Deleted.
(bmalloc::MediumAllocator::refill): Deleted.
(bmalloc::MediumAllocator::clear): Deleted. Deleted some code that's
been dead for a while, since it doesn't build anymore with this patch.

  • bmalloc/Page.h:

(bmalloc::Page::sizeClass):
(bmalloc::Page::setSizeClass):
(bmalloc::Page::smallSizeClass): Deleted.
(bmalloc::Page::setSmallSizeClass): Deleted. Renamed setSmallSizeClass
to sizeClass, since we use it for medium sizes too.

  • bmalloc/Sizes.h:

(bmalloc::Sizes::sizeClass):
(bmalloc::Sizes::objectSize): Shrank line sizes to save memory.

(bmalloc::Sizes::smallSizeClassFor): Deleted.
(bmalloc::Sizes::mediumSizeClassFor): Deleted.

  • bmalloc/bmalloc.h:

(bmalloc::api::realloc): Now that we have precise objects sizes, realloc
can be a bit more precise. It also has to be, since we can't guarantee
that an object ends at the end of a line anymore.

11:09 AM Changeset in webkit [173880] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

W3C test importer should detect manual and reference tests according their filenames
​https://bugs.webkit.org/show_bug.cgi?id=133852

Patch by Youenn Fablet <​youenn.fablet@crf.canon.fr> on 2014-09-23
Reviewed by Bem Jones-Bey.

  • Scripts/webkitpy/w3c/test_parser.py:

(TestParser.analyze_test): Adding checks based on WPT filename rules.
(TestParser.is_wpt_manualtest): Detecting whether the test is a manual test based on its filename.
(TestParser):
(TestParser.potential_ref_filename): Getting the potential reference filename of a test from its filename.
(TestParser.is_wpt_reftest): Detecting whether the test is a ref test based on its filename.

  • Scripts/webkitpy/w3c/test_parser_unittest.py:

(test_analyze_manual_wpt_test): Adding a test for a "-manual.html" file with testharness.js link in it.

10:32 AM Changeset in webkit [173879] by Bem Jones-Bey
  • 2 edits in trunk/Tools

Unreviewed, add Rebecca Hauck as a contributor.

  • Scripts/webkitpy/common/config/contributors.json:
10:11 AM Changeset in webkit [173878] by Brent Fulgham
  • 2 edits in trunk/Source/WebKit

[Win] Correct 64-bit Windows export definitions after r173804.

  • WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in: Provide proper

64-bit mangled symbol names.

10:11 AM Changeset in webkit [173877] by ddkilzer@apple.com
  • 18 edits in trunk/Tools

Switch build.webkit.org URLs to https

Reviewed by Lucas Forschler and Alexey Proskuryakov.

  • TestResultServer/app.yaml: Update version to this commit

revision.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:
  • BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/WebKitBuildbot.js:

(WebKitBuildbot):

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:

(.):

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:

(WebKitBuildbot):

  • BuildSlaveSupport/build.webkit.org-config/templates/root.html:
  • Scripts/webkitpy/common/config/urls.py:
  • Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:

(test_builder_with_name):

  • Scripts/webkitpy/tool/commands/queries.py:

(TreeStatus):

  • TestResultServer/generate_builders_json.py:

(main):

  • TestResultServer/generate_builders_json_unittest.py:

(GenerateBuildersJsonTest.test_generate_json_data.dummy_fetch_json):
(GenerateBuildersJsonTest):
(GenerateBuildersJsonTest.test_generate_json_data):

  • TestResultServer/static-dashboards/builders.jsonp:
  • TestResultServer/static-dashboards/flakiness_dashboard.js:

(loadExpectationsLayoutTests):

  • TestResultServer/static-dashboards/timeline_explorer.js:
10:10 AM Changeset in webkit [173876] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

W3C test importer should copy .htaccess files
​https://bugs.webkit.org/show_bug.cgi?id=136850

Patch by Youenn Fablet <​youenn.fablet@crf.canon.fr> on 2014-09-23
Reviewed by Bem Jones-Bey.

  • Scripts/webkitpy/w3c/test_importer.py:

(TestImporter.should_skip_file): Helper function to check whether to skip file or not. Added ".htaccess" file specific check.
(TestImporter):
(TestImporter.find_importable_tests): Making use of new helper function.

9:56 AM Changeset in webkit [173875] by ap@apple.com
  • 2 edits in trunk/Tools

Trying to revive bot watcher's dashboard after HSTS.

Unreviewed.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:

(WebKitBuildbot): It looks like XMLHttpRequest may not like HSTS redirects, let's try to avoid these.

9:41 AM Changeset in webkit [173874] by commit-queue@webkit.org
  • 4 edits in trunk

[GTK] Adds implementation of subtle crypto HMAC algorithm
​https://bugs.webkit.org/show_bug.cgi?id=133320

Patch by Eduardo Lima Mitev <​elima@igalia.com> on 2014-09-23
Reviewed by Philippe Normand.

Source/WebCore:

Tests are already in place under crypto/subtle/hmac-*.html

  • crypto/gtk/CryptoAlgorithmHMACGtk.cpp:

(WebCore::getGnutlsDigestAlgorithm):
(WebCore::calculateSignature):
(WebCore::CryptoAlgorithmHMAC::platformSign):
(WebCore::CryptoAlgorithmHMAC::platformVerify):

LayoutTests:

  • platform/gtk/TestExpectations: Whitelists HMAC related tests that are passing
9:14 AM Changeset in webkit [173873] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/LayoutTests

Unreviewed, rolling out r173864.

It still make tests failes on EFL bots

Reverted changeset:

"Unreviewed, EFL gardening. Unskip media test on EFL port.
Almost media tests"
​http://trac.webkit.org/changeset/173864

8:17 AM Changeset in webkit [173872] by commit-queue@webkit.org
  • 4 edits in trunk

[GTK] Adds implementation of Subtle Crypto digest algorithms
​https://bugs.webkit.org/show_bug.cgi?id=133319

Source/WebCore:

Patch by Eduardo Lima Mitev <​elima@igalia.com> on 2014-09-23
Reviewed by Philippe Normand.

Tests are already in place under crypto/subtle/sha-*.html

  • crypto/gtk/CryptoDigestGtk.cpp:

(WebCore::CryptoDigest::CryptoDigest):
(WebCore::CryptoDigest::~CryptoDigest):
(WebCore::CryptoDigest::create):
(WebCore::CryptoDigest::addBytes):
(WebCore::CryptoDigest::computeHash):

LayoutTests:

Leaves all crypto/subtle tests skipped and whitelist only those related to
digest algorithms (sha-*.html). When enough crypto algorithms are implemented,
we can invert the approach and blacklist only those tests whose algorithms are
not implemented.

Patch by Eduardo Lima Mitev <​elima@igalia.com> on 2014-09-23
Reviewed by Philippe Normand.

  • platform/gtk/TestExpectations: Unskip tests for Subtle-Crypto digest algorithms.
7:47 AM Changeset in webkit [173871] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Make Tools/BuildSlaveSupport/wait-for-SVN-server.py handle server donwtime
​https://bugs.webkit.org/show_bug.cgi?id=137026

Patch by Tibor Meszaros <​tmeszaros.u-szeged@partner.samsung.com> on 2014-09-23
Reviewed by Csaba Osztrogonác.

  • BuildSlaveSupport/wait-for-SVN-server.py:

(getLatestSVNRevision):
(waitForSVNRevision):

2:57 AM Changeset in webkit [173870] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Remove unlinkZeroFiles from build-webkit
​https://bugs.webkit.org/show_bug.cgi?id=137018

Patch by Tibor Meszaros <​tmeszaros.u-szeged@partner.samsung.com> on 2014-09-23
Reviewed by Csaba Osztrogonác.

  • Scripts/build-webkit:

(unlinkZeroFiles): Deleted.

2:26 AM Changeset in webkit [173869] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[GTK] Minibrowser : Add keyboard support for stop page load
​https://bugs.webkit.org/show_bug.cgi?id=136857

Patch by Rohit Kumar <​kumar.rohit@samsung.com> on 2014-09-23
Reviewed by Philippe Normand.

Keyboard support to stop page load in GTK Minibrowser using F6 and Escape keys.

  • MiniBrowser/gtk/BrowserWindow.c:

(stopPageLoad): Callback to stop page load.
(browser_window_init):

1:37 AM Changeset in webkit [173868] by svillar@igalia.com
  • 2 edits in trunk/Source/WebCore

[CSS Grid Layout] Do not grow tracks when the growth factor is 0
​https://bugs.webkit.org/show_bug.cgi?id=136575

Reviewed by Darin Adler.

A couple of performance optimizations for the track sizing
algorithm. On the one hand we avoid the computation of the
available logical space share if the track has no growth potential
(the current breadth is the maximum breadth) and on the other
hand, we avoid calling RenderGrid::distributeSpaceToTracks() if
the available logical space is not greater than 0.

The combined effect of these two changes is an impressive +16%
improvement in auto-grid-lots-of-data.html performance test.

No new tests as there is no change in the functionality.

  • rendering/RenderGrid.cpp:

(WebCore::RenderGrid::resolveContentBasedTrackSizingFunctionsForItems):
(WebCore::RenderGrid::distributeSpaceToTracks):

12:47 AM Changeset in webkit [173867] by Ion Rosca
  • 6 edits
    4 adds in trunk

[CSS Blending] The composited layers isolated by the page group should blend with the default white background color.
​https://bugs.webkit.org/show_bug.cgi?id=136563

Reviewed by Simon Fraser.

Source/WebCore:

If a blending layer is not isolated, then it should blend with a white backdrop:
​http://dev.w3.org/fxtf/compositing-1/#pagebackdrop

Tests: css3/blending/blend-mode-body-composited-child-background-color.html

css3/blending/blend-mode-body-composited-child.html

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::isSimpleContainerCompositingLayer):
If the isolating composited layer is the root renderer, then it should have a backing store
into which the initial white backdrop will be painted.

LayoutTests:

  • css3/blending/blend-mode-blended-element-overlapping-composited-sibling-should-have-compositing-layer-expected.txt:
  • css3/blending/blend-mode-body-composited-child-background-color-expected.html: Added.
  • css3/blending/blend-mode-body-composited-child-background-color.html: Added.
  • css3/blending/blend-mode-body-composited-child-expected.html: Added.
  • css3/blending/blend-mode-body-composited-child.html: Added.
  • css3/blending/blend-mode-parent-of-composited-blended-has-layer-expected.txt:
  • css3/blending/blend-mode-with-composited-descendant-should-have-layer-expected.txt:
Note: See TracTimeline for information about the timeline view.