Context Navigation

← Previous Period
Next Period →

Timeline

Sep 29, 2014:

8:34 PM Changeset in webkit [174095] by Brian Burg

7 edits in trunk/Source

Web Inspector: InjectedScripts should not be profiled or displayed in Timeline
https://bugs.webkit.org/show_bug.cgi?id=136806

Reviewed by Timothy Hatcher.

Source/JavaScriptCore:

It doesn't make sense to show profile nodes for injected scripts when profiling user content.
For now, omit nodes by suspending profiling before and after executing injected scripts.

profiler/LegacyProfiler.cpp:

(JSC::LegacyProfiler::suspendProfiling): Added.
(JSC::LegacyProfiler::unsuspendProfiling): Added.

profiler/LegacyProfiler.h:
profiler/ProfileGenerator.cpp: Add isSuspended() flag, remove unused typedef.

(JSC::ProfileGenerator::ProfileGenerator):
(JSC::ProfileGenerator::willExecute):
(JSC::ProfileGenerator::didExecute):

profiler/ProfileGenerator.h:

(JSC::ProfileGenerator::setIsSuspended): Added.

Source/WebCore:

Instead of creating timeline records for injected scripts, suspend profiling
of the current page before and after calling injected script functions.

inspector/InspectorController.cpp:

(WebCore::InspectorController::willCallInjectedScriptFunction):
(WebCore::InspectorController::didCallInjectedScriptFunction):

8:30 PM Changeset in webkit [174094] by Brian Burg

27 edits in trunk/Source

Web Inspector: InspectorValues should use references for out parameters
https://bugs.webkit.org/show_bug.cgi?id=137190

Reviewed by Joseph Pecoraro.

Source/JavaScriptCore:

Use references for out parameters in asType() and getType() methods.
Also convert to references in some miscellaneous code where we don't
expect or handle null values.

Remove variants of asObject() and asArray() that return a nullable RefPtr.
Now, client code is forced to use out parameters and check for cast failure.

Iron out control flow in some functions and fix some style issues.

inspector/InjectedScript.cpp:

(Inspector::InjectedScript::getFunctionDetails):
(Inspector::InjectedScript::wrapObject):
(Inspector::InjectedScript::wrapTable):

inspector/InjectedScriptBase.cpp:

(Inspector::InjectedScriptBase::makeEvalCall):

inspector/InjectedScriptManager.cpp:

(Inspector::InjectedScriptManager::injectedScriptForObjectId): Simplify control flow.

inspector/InspectorBackendDispatcher.cpp:

(Inspector::InspectorBackendDispatcher::dispatch):
(Inspector::getPropertyValue):
(Inspector::AsMethodBridges::asInteger):
(Inspector::AsMethodBridges::asDouble):
(Inspector::AsMethodBridges::asString):
(Inspector::AsMethodBridges::asBoolean):
(Inspector::AsMethodBridges::asObject):
(Inspector::AsMethodBridges::asArray):

inspector/InspectorProtocolTypes.h:

(Inspector::Protocol::BindingTraits<Protocol::Array<T>>::runtimeCast):
(Inspector::Protocol::BindingTraits<Protocol::Array<T>>::assertValueHasExpectedType):

inspector/InspectorValues.cpp: Use more by-reference out parameters. Add more spacing.

(Inspector::InspectorValue::asBoolean):
(Inspector::InspectorValue::asDouble):
(Inspector::InspectorValue::asInteger):
(Inspector::InspectorValue::asString):
(Inspector::InspectorValue::asValue):
(Inspector::InspectorValue::asObject):
(Inspector::InspectorValue::asArray):
(Inspector::InspectorValue::parseJSON):
(Inspector::InspectorValue::toJSONString):
(Inspector::InspectorValue::writeJSON):
(Inspector::InspectorBasicValue::asBoolean):
(Inspector::InspectorBasicValue::asDouble):
(Inspector::InspectorBasicValue::asInteger):
(Inspector::InspectorBasicValue::writeJSON):
(Inspector::InspectorString::asString):
(Inspector::InspectorString::writeJSON):
(Inspector::InspectorObjectBase::asObject):
(Inspector::InspectorObjectBase::openAccessors):
(Inspector::InspectorObjectBase::getBoolean):
(Inspector::InspectorObjectBase::getString):
(Inspector::InspectorObjectBase::getObject):
(Inspector::InspectorObjectBase::getArray):
(Inspector::InspectorObjectBase::writeJSON):
(Inspector::InspectorArrayBase::asArray):
(Inspector::InspectorArrayBase::writeJSON):

inspector/InspectorValues.h:
inspector/agents/InspectorDebuggerAgent.cpp:

(Inspector::InspectorDebuggerAgent::breakpointActionsFromProtocol):
(Inspector::InspectorDebuggerAgent::setBreakpointByUrl):
(Inspector::parseLocation):
(Inspector::InspectorDebuggerAgent::setBreakpoint):
(Inspector::InspectorDebuggerAgent::continueToLocation):
(Inspector::InspectorDebuggerAgent::didParseSource):

inspector/agents/InspectorRuntimeAgent.cpp:

(Inspector::InspectorRuntimeAgent::getRuntimeTypesForVariablesAtOffsets):

inspector/scripts/codegen/generate_protocol_types_implementation.py:

(ProtocolTypesImplementationGenerator):
(ProtocolTypesImplementationGenerator._generate_assertion_for_enum):

inspector/scripts/codegen/generator_templates.py:
inspector/scripts/tests/expected/type-requiring-runtime-casts.json-result:
replay/EncodedValue.cpp:

(JSC::EncodedValue::asObject):
(JSC::EncodedValue::asArray):
(JSC::EncodedValue::convertTo<bool>):
(JSC::EncodedValue::convertTo<double>):
(JSC::EncodedValue::convertTo<float>):
(JSC::EncodedValue::convertTo<int32_t>):
(JSC::EncodedValue::convertTo<int64_t>):
(JSC::EncodedValue::convertTo<uint32_t>):
(JSC::EncodedValue::convertTo<uint64_t>):
(JSC::EncodedValue::convertTo<String>):

Source/WebCore:

Clean up some call sites to explicitly check for cast success, and simplify
some exceptional control flows.

No new tests, no behavior changed.

inspector/CommandLineAPIHost.cpp:

(WebCore::CommandLineAPIHost::inspectImpl):

inspector/InspectorCSSAgent.cpp:

(WebCore::computePseudoClassMask):

inspector/InspectorDOMAgent.cpp:

(WebCore::parseColor):
(WebCore::parseConfigColor):
(WebCore::parseQuad):
(WebCore::InspectorDOMAgent::performSearch):
(WebCore::InspectorDOMAgent::highlightConfigFromInspectorObject):
(WebCore::InspectorDOMAgent::innerHighlightQuad):
(WebCore::InspectorDOMAgent::highlightFrame):

inspector/InspectorDOMStorageAgent.cpp:

(WebCore::InspectorDOMStorageAgent::findStorageArea):

inspector/InspectorIndexedDBAgent.cpp: Use NeverDestroyed instead of DEPRECATED_DEFINE_STATIC_LOCAL.
inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::didClearWindowObjectInWorld):

inspector/InspectorReplayAgent.cpp:

(WebCore::InspectorReplayAgent::replayToPosition):

inspector/InspectorResourceAgent.cpp:

(WebCore::InspectorResourceAgent::willSendRequest):

inspector/InspectorStyleSheet.cpp:

(WebCore::InspectorStyle::styleWithProperties):

inspector/InspectorStyleSheet.h:

(WebCore::InspectorCSSId::InspectorCSSId):

inspector/InspectorTimelineAgent.cpp:

(WebCore::InspectorTimelineAgent::startFromConsole):
(WebCore::InspectorTimelineAgent::stopFromConsole):

inspector/InspectorWorkerAgent.cpp:

7:02 PM Changeset in webkit [174093] by clopez@igalia.com

5 edits in trunk/Tools

[GTK] [EFL] Install TestNetscapePlugin apart from the other libs.
https://bugs.webkit.org/show_bug.cgi?id=137212

This moves TestNetscapePlugin to a new folder (lib/plugins).
We should not use the same directory for TestNetscapePlugin and
the other libraries, because we end up scanning all the .so in the
lib dir for every test.

Reviewed by Carlos Garcia Campos.

DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt: Set LIBRARY_OUTPUT_DIRECTORY to lib/plugins.
Scripts/webkitpy/port/efl.py:

(EflPort.setup_environ_for_server): Update plugin path.

Scripts/webkitpy/port/gtk.py:

(GtkPort.setup_environ_for_server): Update plugin path.

TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: Update plugin path.

4:08 PM Changeset in webkit [174092] by ap@apple.com

3 edits in trunk/Tools

A small change to EWS bubble text. Explain why there are messages for ineligible patches.

Rubber-stamped by Tim Horton.

QueueStatusServer/app.yaml:
QueueStatusServer/handlers/statusbubble.py:

(StatusBubble._build_bubble):

3:38 PM Changeset in webkit [174091] by fpizlo@apple.com

3 edits in trunk/Source/JavaScriptCore

DFG HasStructureProperty codegen should use one fewer registers
https://bugs.webkit.org/show_bug.cgi?id=137235

Reviewed by Andreas Kling.

This was an obvious source of inefficiency and it was causing us to run out of registers on
x86-32.

dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

3:25 PM Changeset in webkit [174090] by fpizlo@apple.com

5 edits in trunk/Source/JavaScriptCore

Don't use GPRResult unless you're flushing registers and making a runtime function call
https://bugs.webkit.org/show_bug.cgi?id=137234

Rubber stamped by Andreas Kling.

Rename GPRResult to GPRFlushedCallResult, in an attempt to dissuade people from using it for results in the
general case.

Replace GPRResult with GPRTemporary in those places where it was causing bugs: particularly in GetDirectPname it
would cause us to spill the register that has the base, and the code was assuming (rightly) that the base and the
result were in different registers. That's a valid assumption when using GPRTemporary but not with GPRResult.
Also this code wasn't getting any benefit from using GPRResult because it wasn't doing flushRegisters().

I don't know how to test this. A test would require setting up a particularly awkward register allocation state.

dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileIn):
(JSC::DFG::SpeculativeJIT::compileNewFunctionNoCheck):
(JSC::DFG::SpeculativeJIT::compileNewFunctionExpression):
(JSC::DFG::SpeculativeJIT::compileRegExpExec):
(JSC::DFG::SpeculativeJIT::compileAllocatePropertyStorage):
(JSC::DFG::SpeculativeJIT::compileReallocatePropertyStorage):
(JSC::DFG::SpeculativeJIT::compileToStringOnCell):

dfg/DFGSpeculativeJIT.h:

(JSC::DFG::GPRFlushedCallResult::GPRFlushedCallResult):
(JSC::DFG::GPRFlushedCallResult2::GPRFlushedCallResult2):
(JSC::DFG::GPRResult::GPRResult): Deleted.
(JSC::DFG::GPRResult2::GPRResult2): Deleted.

dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranch):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompare):
(JSC::DFG::SpeculativeJIT::emitCall):
(JSC::DFG::SpeculativeJIT::compile):

dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranch):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompare):
(JSC::DFG::SpeculativeJIT::emitCall):
(JSC::DFG::SpeculativeJIT::compile):
(JSC::DFG::SpeculativeJIT::speculateDoubleRepMachineInt):

3:23 PM Changeset in webkit [174089] by Chris Dumez

68 edits in trunk/Source

Use is<>() / downcast<>() for Document
https://bugs.webkit.org/show_bug.cgi?id=137221

Reviewed by Andreas Kling.

Use is<>() / downcast<>() for Document instead of isDocumentNode() /
toDocument().

Source/WebCore:

No new tests, no behavior change.

Modules/geolocation/Geolocation.cpp:

(WebCore::Geolocation::document):
(WebCore::Geolocation::frame):
(WebCore::Geolocation::page):

Modules/indexeddb/IDBFactory.cpp:
Modules/mediasource/SourceBuffer.cpp:

(WebCore::SourceBuffer::document):

Modules/mediastream/RTCPeerConnection.cpp:

(WebCore::RTCPeerConnection::RTCPeerConnection):

Modules/notifications/Notification.cpp:

(WebCore::Notification::Notification):
(WebCore::Notification::show):
(WebCore::Notification::permission):
(WebCore::Notification::requestPermission):

Modules/webaudio/AudioContext.cpp:

(WebCore::AudioContext::document):

Modules/webaudio/OfflineAudioContext.cpp:

(WebCore::OfflineAudioContext::create):

Modules/webdatabase/DatabaseContext.cpp:

(WebCore::DatabaseContext::allowDatabaseAccess):
(WebCore::DatabaseContext::databaseExceededQuota):

Modules/websockets/ThreadableWebSocketChannel.cpp:

(WebCore::ThreadableWebSocketChannel::create):

Modules/websockets/WebSocket.cpp:

(WebCore::WebSocket::connect):

Modules/websockets/WebSocketHandshake.cpp:

(WebCore::WebSocketHandshake::clientHandshakeMessage):
(WebCore::WebSocketHandshake::clientHandshakeRequest):

Modules/websockets/WorkerThreadableWebSocketChannel.cpp:

(WebCore::WorkerThreadableWebSocketChannel::Peer::Peer):

bindings/gobject/WebKitDOMPrivate.cpp:

(WebKit::wrap):

bindings/js/DOMConstructorWithDocument.h:

(WebCore::DOMConstructorWithDocument::document):

bindings/js/DOMRequestState.h:

(WebCore::DOMRequestState::DOMRequestState):
(WebCore::DOMRequestState::clear):

bindings/js/JSAudioContextCustom.cpp:

(WebCore::constructJSAudioContext):

bindings/js/JSDOMGlobalObject.cpp:

(WebCore::toJSDOMGlobalObject):

bindings/js/JSLazyEventListener.cpp:

(WebCore::JSLazyEventListener::initializeJSFunction):

bindings/js/JSNodeCustom.cpp:

(WebCore::createWrapperInline):

bindings/js/ScheduledAction.cpp:

(WebCore::ScheduledAction::execute):

bindings/js/ScriptState.cpp:

(WebCore::frameFromExecState):

crypto/SubtleCrypto.cpp:

(WebCore::SubtleCrypto::document):

dom/Comment.cpp:

(WebCore::Comment::create):

dom/ContainerNode.cpp:

(WebCore::checkAcceptChild):

dom/ContainerNodeAlgorithms.cpp:

(WebCore::ChildNodeInsertionNotifier::notifyDescendantInsertedIntoDocument):

dom/Document.h:

(WebCore::isDocument):

dom/DocumentFragment.cpp:

(WebCore::DocumentFragment::create):

dom/Element.cpp:

(WebCore::Element::computeInheritedLanguage):

dom/EventDispatcher.cpp:

(WebCore::WindowEventContext::WindowEventContext):

dom/EventTarget.cpp:

(WebCore::EventTarget::fireEventListeners):

dom/NamedFlowCollection.cpp:

(WebCore::NamedFlowCollection::document):

dom/Node.cpp:

(WebCore::Node::isDefaultNamespace):
(WebCore::Node::lookupPrefix):
(WebCore::Node::lookupNamespaceURI):
(WebCore::Node::removedLastRef):

dom/Range.cpp:

(WebCore::Range::create):

dom/ScriptExecutionContext.cpp:

(WebCore::ScriptExecutionContext::dispatchErrorEvent):

dom/Text.cpp:

(WebCore::Text::create):

editing/MarkupAccumulator.cpp:

(WebCore::MarkupAccumulator::appendStartMarkup):

html/HTMLDocument.h:

(WebCore::isHTMLDocument):

html/HTMLNameCollection.h:

(WebCore::HTMLNameCollection::document):

html/HTMLStyleElement.cpp:

(WebCore::HTMLStyleElement::insertedInto):

html/ImageDocument.h:

(WebCore::isImageDocument):

html/MediaDocument.h:

(WebCore::isMediaDocument):

html/PluginDocument.h:

(WebCore::isPluginDocument):

html/track/TextTrackCue.h:

(WebCore::TextTrackCue::ownerDocument):

html/track/VTTCue.cpp:

(WebCore::VTTCue::initialize):

html/track/VTTRegion.h:

(WebCore::VTTRegion::ownerDocument):

inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::assertDocument):
(WebCore::InspectorDOMAgent::buildObjectForNode):
(WebCore::InspectorDOMAgent::innerParentNode):

inspector/InspectorInstrumentation.cpp:

(WebCore::frameForScriptExecutionContext):

inspector/InspectorInstrumentation.h:

(WebCore::InspectorInstrumentation::instrumentingAgentsForContext):

loader/TextTrackLoader.cpp:

(WebCore::TextTrackLoader::corsPolicyPreventedLoad):
(WebCore::TextTrackLoader::notifyFinished):
(WebCore::TextTrackLoader::load):

loader/ThreadableLoader.cpp:

(WebCore::ThreadableLoader::create):
(WebCore::ThreadableLoader::loadResourceSynchronously):

loader/WorkerThreadableLoader.cpp:

(WebCore::WorkerThreadableLoader::MainThreadBridge::mainThreadCreateLoader):

page/ContentSecurityPolicy.cpp:

(WebCore::ContentSecurityPolicy::reportViolation):

page/Crypto.cpp:

(WebCore::Crypto::document):

page/DOMTimer.cpp:

(WebCore::DOMTimer::install):
(WebCore::DOMTimer::fired):

page/DOMWindow.cpp:

(WebCore::DOMWindow::focus):
(WebCore::DOMWindow::close):
(WebCore::DOMWindow::document):
(WebCore::DOMWindow::styleMedia):
(WebCore::DOMWindow::getComputedStyle):

page/DragController.cpp:

(WebCore::DragController::dragExited):
(WebCore::DragController::dragEnteredOrUpdated):

page/EventSource.cpp:

(WebCore::EventSource::create):

page/FocusController.cpp:

(WebCore::FocusController::advanceFocusDirectionally):

page/History.cpp:

(WebCore::History::go):

page/SpatialNavigation.cpp:

(WebCore::scrollInDirection):
(WebCore::scrollableEnclosingBoxOrParentFrameForNodeInDirection):
(WebCore::canScrollInDirection):
(WebCore::nodeRectInAbsoluteCoordinates):

svg/SVGDocument.h:

(WebCore::isSVGDocument):

testing/Internals.cpp:

(WebCore::Internals::contextDocument):
(WebCore::Internals::frame):
(WebCore::Internals::updateLayoutIgnorePendingStylesheetsAndRunPostLayoutTasks):

testing/js/WebCoreTestSupport.cpp:

(WebCoreTestSupport::injectInternalsObject):
(WebCoreTestSupport::resetInternalsObject):

workers/DefaultSharedWorkerRepository.cpp:

(WebCore::SharedWorkerProxy::addToWorkerDocuments):

workers/WorkerMessagingProxy.cpp:

(WebCore::WorkerMessagingProxy::startWorkerGlobalScope):

xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::document):
(WebCore::XMLHttpRequest::open):

Source/WebKit2:

WebProcess/InjectedBundle/API/mac/WKDOMDocument.mm:

(-[WKDOMDocument createElement:]):
(-[WKDOMDocument createTextNode:]):
(-[WKDOMDocument body]):

3:14 PM Changeset in webkit [174088] by ap@apple.com

3 edits in trunk/Tools

Typo fix, suggested by Tim Horton.

QueueStatusServer/handlers/statusbubble.py:

(StatusBubble._build_message_for_provisional_failure):

2:55 PM Changeset in webkit [174087] by ap@apple.com

5 edits in trunk/Tools

Improve Bugzilla status bubbles
https://bugs.webkit.org/show_bug.cgi?id=137232

Reviewed by Ryosuke Niwa.

QueueStatusServer/app.yaml: Will update again with an actual version when landing.

QueueStatusServer/handlers/statusbubble.py: Eliminated yellow color, added

blue and orange. Significantly extended tooltips. Made bubbles show up even for queues
that are stuck, as it was only confusing that they disappeared after 99.

QueueStatusServer/model/attachment.py: Removed functionality that was only used

by old bubbles. We need a lot more information to determine color, so the implementation
can not be here.

QueueStatusServer/templates/statusbubble.html: Updated colors in CSS, made bubbles

always have a link for consistency. Added code to convert timestamps in tooltips
to local time zone.

2:26 PM Changeset in webkit [174086] by commit-queue@webkit.org

17 edits
1 move
1 add in trunk

Unreviewed, rolling out r174045.
https://bugs.webkit.org/show_bug.cgi?id=137231

Introduced a crash during page loading tests on Mac (Requested
by rniwa on #webkit).

Reverted changeset:

"Replace OSObjectPtr with RetainPtr/adoptOS"
https://bugs.webkit.org/show_bug.cgi?id=137158
http://trac.webkit.org/changeset/174045

1:54 PM Changeset in webkit [174085] by hyatt@apple.com

4 edits
2 adds in trunk

REGRESSION (r168046): Confused column spans when combined with dynamic animations
https://bugs.webkit.org/show_bug.cgi?id=134048.

Reviewed by Dean Jackson.

Source/WebCore:

Added fast/multicol/multicol-fieldset-span-changes.html

rendering/RenderMultiColumnFlowThread.cpp:

(WebCore::RenderMultiColumnFlowThread::processPossibleSpannerDescendant):
Refactor handling of insertions into the multicolumn flow thread into
a helper function, processPossibleSpannerDescendant. This makes it easier
to call the code from more than one place.

(WebCore::RenderMultiColumnFlowThread::flowThreadDescendantInserted):
Modify the nested columns span shifting code to avoid problems. The
new code suppresses notifications and does the move of the spanner back
into the original spot *before* removing the placeholder. This ensures that
the placeholder parent still exists.

The stale placeholder is then removed and destroyed after the spanner has been put back
into place.

(WebCore::RenderMultiColumnFlowThread::handleSpannerRemoval):
(WebCore::RenderMultiColumnFlowThread::flowThreadRelativeWillBeRemoved):
Refactor the removal notifications for spanners into a helper function so that it can
be called to do cleanup from the code that cleans up stale placeholders on a shift.

rendering/RenderMultiColumnFlowThread.h:

Modified to add the new helpers.

LayoutTests:

fast/multicol/multicol-fieldset-span-changes-expected.txt: Added.
fast/multicol/multicol-fieldset-span-changes.html: Added.

1:50 PM Changeset in webkit [174084] by Chris Dumez

7 edits in trunk/Source/WebCore

Use SPECIALIZE_TYPE_TRAITS_*() macro for MathMLElement
https://bugs.webkit.org/show_bug.cgi?id=137222

Reviewed by Ryosuke Niwa.

Use SPECIALIZE_TYPE_TRAITS_*() macro for MathMLElement instead of
NODE_TYPE_CASTS() + NodeTypeCastTraits template specialization.

No new tests, no behavior change.

accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::accessibilityDescription):

accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::isMathElement):

css/CSSDefaultStyleSheets.cpp:

(WebCore::CSSDefaultStyleSheets::ensureDefaultStyleSheetsForElement):

mathml/MathMLElement.cpp:

(WebCore::MathMLElement::attributeChanged):

mathml/MathMLElement.h:

(WebCore::isMathMLElement):

mathml/MathMLSelectElement.cpp:

(WebCore::MathMLSelectElement::getSelectedSemanticsChild):

1:39 PM Changeset in webkit [174083] by roger_fong@apple.com

2 edits in trunk/LayoutTests

[Windows] Skip some failing inspector tests following r174020.

platform/win/TestExpectations:

1:25 PM Changeset in webkit [174082] by roger_fong@apple.com

3 edits in trunk/LayoutTests

[Mac] Unreviewed. Missing test gardening from r174080.

accessibility/roles-computedRoleString-expected.txt:
accessibility/roles-computedRoleString.html:

1:19 PM Changeset in webkit [174081] by andersca@apple.com

2 edits in trunk/Source/WebKit2

Set the TBA versions based on the PLATFORM_NAME
https://bugs.webkit.org/show_bug.cgi?id=137226
Follow-up fix for <rdar://problem/17761459>.

Reviewed by Dan Bernstein.

mac/rewrite-availability-macros.sh:

Turns out that MACOSX_DEPLOYMENT_TARGET is set even for iOS builds,
so set the versions based on the PLATFORM_NAME environment variable.

12:42 PM Changeset in webkit [174080] by roger_fong@apple.com

4 edits in trunk/LayoutTests

[Mac] Unreviewed test gardening.

These accessibility tests need to be changed following r174074.

accessibility/aria-labelledby-with-descendants-expected.txt:
accessibility/roles-computedRoleString.html:
platform/mac/TestExpectations: Some previously skipped inspector tests crash in debug configuration.

12:29 PM Changeset in webkit [174079] by eric.carlson@apple.com

3 edits in trunk/Source/WebCore

[Mac] Remove MediaPlayerPrivateQTKit frame rate code
https://bugs.webkit.org/show_bug.cgi?id=137217

Reviewed by Carlos Garcia Campos.

No new tests, this removes obsolete code.

platform/graphics/mac/MediaPlayerPrivateQTKit.h:
platform/graphics/mac/MediaPlayerPrivateQTKit.mm:

(WebCore::MediaPlayerPrivateQTKit::MediaPlayerPrivateQTKit):
(WebCore::MediaPlayerPrivateQTKit::play):
(WebCore::MediaPlayerPrivateQTKit::pause):
(WebCore::MediaPlayerPrivateQTKit::didEnd):
(WebCore::MediaPlayerPrivateQTKit::repaint):
(WebCore::MediaPlayerPrivateQTKit::paint):

12:26 PM Changeset in webkit [174078] by timothy_horton@apple.com

2 edits in trunk/Tools

Add Jake as a contributor.

Scripts/webkitpy/common/config/contributors.json:

12:13 PM Changeset in webkit [174077] by roger_fong@apple.com

2 edits in trunk/Tools

[Windows] Skip a javascriptcore test following r174036.

Scripts/run-javascriptcore-tests:

11:42 AM Changeset in webkit [174076] by roger_fong@apple.com

2 edits in trunk/Tools

[Windows] Reduce number of processes used by NRWT on Windows to 1.

Scripts/webkitpy/port/win.py:

(WinPort.default_child_processes):
Reduce number of processes to 1 so we can get a good baseline for what failures
we should be expecting to see from the Windows bots.

11:28 AM Changeset in webkit [174075] by mitz@apple.com

2 edits in trunk/Source/WebKit2

Build fix.

WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::performActionOnElement):

11:18 AM Changeset in webkit [174074] by Chris Fleizach

7 edits
2 adds in trunk

AX: in an aria-labelledby computation, do not traverse into elements whose nameFrom value does not include 'contents'
https://bugs.webkit.org/show_bug.cgi?id=136714

Reviewed by Darin Adler.

Source/WebCore:

There are certain ARIA elements that tell us we should not query their children when determining the name of the object.
Those ones have the "nameFrom" property set to "author" instead of "contents." WebKit needs to honor that status.

Test: accessibility/aria-namefrom-author.html

Modified: accessibility/aria-labelledby-with-descendants.html

accessibility/AccessibilityNodeObject.cpp:

(WebCore::shouldUseAccessiblityObjectInnerText):
(WebCore::shouldAddSpaceBeforeAppendingNextElement):
(WebCore::appendNameToStringBuilder):
(WebCore::AccessibilityNodeObject::textUnderElement):
(WebCore::accessibleNameForNode):
(WebCore::AccessibilityNodeObject::accessibilityDescriptionForElements):

accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::accessibleNameDerivesFromContent):
(WebCore::initializeRoleMap):

accessibility/AccessibilityObject.h:

LayoutTests:

accessibility/aria-labelledby-with-descendants-expected.txt:
accessibility/aria-labelledby-with-descendants.html:
accessibility/aria-namefrom-author-expected.txt: Added.
accessibility/aria-namefrom-author.html: Added.

11:12 AM Changeset in webkit [174073] by eric.carlson@apple.com

2 edits in trunk/Source/WebCore

[iOS] Optimize media controls AirPlay discovery
https://bugs.webkit.org/show_bug.cgi?id=137180

Reviewed by Darin Adler.

AirPlay discovery mode uses increases power consumption, so don't enable it when there
is no chance an AirPlay target picker will be useful.

Modules/mediacontrols/mediaControlsiOS.js:

(ControllerIOS): Initialize isListeningForPlaybackTargetAvailabilityEvent.
(ControllerIOS.prototype.addVideoListeners): Don't enable register wireless playback event

listeners, it isn't possible to show the target picker until there is an inline controller.

(ControllerIOS.prototype.removeVideoListeners): Call setShouldListenForPlaybackTargetAvailabilityEvent.
(ControllerIOS.prototype.setControlsType): Add wireless event listers on when not showing

the one button controller.

(ControllerIOS.prototype.updateStatusDisplay): Unregister wireless event listeners when the

media element is in an error state.

(ControllerIOS.prototype.setShouldListenForPlaybackTargetAvailabilityEvent): New, add or

remove event listeners.

11:05 AM Changeset in webkit [174072] by aestes@apple.com

8 edits in trunk/Source/WebKit2

[iOS] Add basic support for link navigation in WKPDFView
https://bugs.webkit.org/show_bug.cgi?id=137182

Reviewed by Tim Horton.

Teach WKPDFView to navigate to URLs when PDF link annotations are tapped.

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::navigateToURLWithSimulatedClick): Sent Messages::WebPage::NavigateToURLWithSimulatedClick.

UIProcess/WebPageProxy.h:
UIProcess/ios/WKPDFView.h:
UIProcess/ios/WKPDFView.mm:

(-[WKPDFView _clearPages]): Removed self as the UIPDFAnnotationControllerDelegate.
(-[WKPDFView _revalidateViews]): Added self as the UIPDFAnnotationControllerDelegate.
(-[WKPDFView annotation:wasTouchedAtPoint:controller:]): Retrieved the URL from the touched annotation,
computed the touched point relative to the WKPDFView and to the screen, and called
navigateToURLWithSimulatedClick() after a 200 ms delay in order to show a soon-to-be-added tap highlight
(this value matches the delay in UIWebPDFView).

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::navigateToURLWithSimulatedClick): Created a fake single-click MouseEvent and called
FrameLoader::urlSelected(). Creating a mouse event ensures that the navigation appears as a
NavigationTypeLinkClicked in navigation policy delegates.

WebProcess/WebPage/WebPage.h:
WebProcess/WebPage/WebPage.messages.in:

11:00 AM Changeset in webkit [174071] by eric.carlson@apple.com

5 edits in trunk/Source/WebCore

[iOS] Remove obsolete playbackTargetAvailabilityChanged methods
https://bugs.webkit.org/show_bug.cgi?id=137179

Reviewed by Darin Adler.

No new tests, this just removes unused code.

html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::mediaPlayerPlaybackTargetAvailabilityChanged): Deleted.

html/HTMLMediaElement.h:

platform/graphics/MediaPlayer.cpp:

(WebCore::MediaPlayer::playbackTargetAvailabilityChanged): Deleted.

platform/graphics/MediaPlayer.h:

(WebCore::MediaPlayerClient::mediaPlayerPlaybackTargetAvailabilityChanged): Deleted.

10:44 AM Changeset in webkit [174070] by commit-queue@webkit.org

2 edits in trunk/Source/ThirdParty/ANGLE

[WinCairo] D3D11 is not used by default.
https://bugs.webkit.org/show_bug.cgi?id=137215

Patch by peavo@outlook.com <peavo@outlook.com> on 2014-09-29
Reviewed by Alex Christensen.

ANGLE_DEFAULT_D3D11 needs to be defined for D3D11 to be used as default.

ANGLE.vcxproj/libGLESv2Common.props:

10:35 AM Changeset in webkit [174069] by Chris Dumez

28 edits in trunk/Source/WebCore

Use the new is<>() / downcast<>() for ShadowRoot and StyledElement
https://bugs.webkit.org/show_bug.cgi?id=137199

Reviewed by Darin Adler.

Use the new is<>() / downcast<>() for ShadowRoot and StyledElement and
move towards getting rid of the NODE_TYPE_CASTS() macro.

No new tests, no behavior change.

css/ElementRuleCollector.cpp:

(WebCore::ElementRuleCollector::matchAllRules):

css/StyleResolver.cpp:

(WebCore::StyleResolver::State::initElement):
(WebCore::StyleResolver::State::initForStyleResolve):
(WebCore::StyleResolver::locateCousinList):
(WebCore::StyleResolver::findSiblingForStyleSharing):

dom/Attr.cpp:

(WebCore::Attr::style):

dom/Element.cpp:

(WebCore::Element::removeAttribute):

dom/EventDispatcher.cpp:

(WebCore::EventRelatedNodeResolver::moveToParentOrShadowHost):
(WebCore::EventRelatedNodeResolver::findHostOfTreeScopeInTargetTreeScope):
(WebCore::eventTargetRespectingTargetRules):
(WebCore::EventPath::EventPath):

dom/Node.cpp:

(WebCore::Node::containingShadowRoot):
(WebCore::Node::parentOrShadowHostElement):
(WebCore::Node::showNodePathForThis):

dom/NodeRenderingTraversal.cpp:

(WebCore::NodeRenderingTraversal::traverseParent):

dom/ShadowRoot.h:

(WebCore::isShadowRoot):
(WebCore::Node::shadowRoot):
(WebCore::Node::parentOrShadowHostNode):

dom/StyledElement.h:

(WebCore::StyledElement::presentationAttributeStyle):
(WebCore::isStyledElement):

dom/Text.cpp:

(WebCore::isSVGShadowText):

dom/TreeScope.cpp:

(WebCore::TreeScope::focusedElement):

dom/TreeScopeAdopter.cpp:

(WebCore::TreeScopeAdopter::moveNodeToNewDocument):

editing/ApplyStyleCommand.cpp:

(WebCore::ApplyStyleCommand::removeEmbeddingUpToEnclosingBlock):
(WebCore::ApplyStyleCommand::pushDownInlineStyleAroundNode):

editing/EditingStyle.cpp:

(WebCore::EditingStyle::wrappingStyleForSerialization):

editing/Editor.cpp:

(WebCore::Editor::applyEditingStyleToElement):

editing/ReplaceSelectionCommand.cpp:

(WebCore::ReplaceSelectionCommand::removeRedundantStylesAndKeepStyleSpanInline):

editing/cocoa/HTMLConverter.mm:

(HTMLConverterCaches::inlineStylePropertyForElement):

editing/markup.cpp:

(WebCore::StyledMarkupAccumulator::appendElement):

inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::buildObjectForAttributesStyle):

inspector/InspectorOverlay.cpp:

(WebCore::buildObjectForElementInfo):

page/DragController.cpp:

(WebCore::asFileInput):

page/EventHandler.cpp:

(WebCore::EventHandler::handleMousePressEvent):

page/FocusController.cpp:

(WebCore::FocusNavigationScope::owner):

page/PageSerializer.cpp:

(WebCore::PageSerializer::serializeFrame):

rendering/RenderLayer.cpp:

(WebCore::RenderLayer::resize):

svg/SVGElement.cpp:

(WebCore::SVGElement::title):

testing/Internals.cpp:

(WebCore::Internals::shadowRoot):
(WebCore::Internals::shadowRootType):
(WebCore::Internals::includerFor):

10:20 AM Changeset in webkit [174068] by Chris Dumez

43 edits in trunk/Source

Use the new is<>() / downcast<>() for Text Nodes
https://bugs.webkit.org/show_bug.cgi?id=137188

Reviewed by Darin Adler.

Use the new is<>() / downcast<>() functions for Text Nodes instead of
isText() / toText().

Source/WebCore:

No new tests, no behavior change.

accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::textUnderElement):

bindings/gobject/WebKitDOMPrivate.cpp:

(WebKit::wrap):

css/SelectorChecker.cpp:

(WebCore::SelectorChecker::checkOne):

dom/CharacterData.cpp:

(WebCore::CharacterData::parserAppendData):
(WebCore::CharacterData::setDataAndUpdate):

dom/ContainerNode.cpp:

(WebCore::destroyRenderTreeIfNeeded):

dom/Node.cpp:

(WebCore::Node::normalize):

dom/Position.cpp:

(WebCore::Position::containerNode):
(WebCore::Position::containerText):
(WebCore::Position::isRenderedCharacter):
(WebCore::Position::leadingWhitespacePosition):

dom/Range.cpp:

(WebCore::Range::insertNode):
(WebCore::Range::getBorderAndTextQuads):

dom/Text.cpp:

(WebCore::earliestLogicallyAdjacentTextNode):
(WebCore::latestLogicallyAdjacentTextNode):

dom/Text.h:

(WebCore::isText):

dom/TextNodeTraversal.cpp:

(WebCore::TextNodeTraversal::contentsAsString):

dom/TextNodeTraversal.h:

(WebCore::TextNodeTraversal::firstTextChildTemplate):
(WebCore::TextNodeTraversal::firstTextWithinTemplate):
(WebCore::TextNodeTraversal::traverseNextTextTemplate):
(WebCore::TextNodeTraversal::nextSibling):

editing/ApplyBlockElementCommand.cpp:

(WebCore::isNewLineAtPosition):
(WebCore::ApplyBlockElementCommand::endOfNextParagrahSplittingTextNodesIfNeeded):

editing/ApplyStyleCommand.cpp:

(WebCore::ApplyStyleCommand::splitTextAtEnd):
(WebCore::ApplyStyleCommand::splitTextElementAtEnd):
(WebCore::ApplyStyleCommand::joinChildTextNodes):

editing/BreakBlockquoteCommand.cpp:

(WebCore::BreakBlockquoteCommand::doApply):

editing/CompositeEditCommand.cpp:

(WebCore::CompositeEditCommand::insertNodeAt):
(WebCore::CompositeEditCommand::positionOutsideTabSpan):
(WebCore::CompositeEditCommand::canRebalance):
(WebCore::CompositeEditCommand::rebalanceWhitespaceAt):
(WebCore::CompositeEditCommand::prepareWhitespaceAtPositionForSplit):
(WebCore::CompositeEditCommand::deleteInsignificantText):
(WebCore::CompositeEditCommand::removePlaceholderAt):
(WebCore::CompositeEditCommand::cleanupAfterDeletion):
(WebCore::CompositeEditCommand::moveParagraphs):

editing/DeleteSelectionCommand.cpp:

(WebCore::DeleteSelectionCommand::handleGeneralDelete):
(WebCore::DeleteSelectionCommand::fixupWhitespace):
(WebCore::DeleteSelectionCommand::doApply):

editing/Editor.cpp:

(WebCore::Editor::setComposition):

editing/InsertLineBreakCommand.cpp:

(WebCore::InsertLineBreakCommand::doApply):

editing/InsertParagraphSeparatorCommand.cpp:

(WebCore::InsertParagraphSeparatorCommand::doApply):

editing/InsertTextCommand.cpp:

(WebCore::InsertTextCommand::insertTab):

editing/MarkupAccumulator.cpp:

(WebCore::MarkupAccumulator::appendStartMarkup):

editing/ReplaceSelectionCommand.cpp:

(WebCore::ReplaceSelectionCommand::removeUnrenderedTextNodesAtEnds):
(WebCore::ReplaceSelectionCommand::addSpacesForSmartReplace):
(WebCore::ReplaceSelectionCommand::mergeTextNodesAroundPosition):
(WebCore::ReplaceSelectionCommand::insertAsListItems):
(WebCore::ReplaceSelectionCommand::performTrivialReplace):

editing/TextIterator.cpp:

(WebCore::TextIterator::handleTextNode):
(WebCore::TextIterator::handleTextBox):
(WebCore::SimplifiedBackwardsTextIterator::handleTextNode):

editing/VisibleUnits.cpp:

(WebCore::startPositionForLine):
(WebCore::endPositionForLine):
(WebCore::startOfParagraph):
(WebCore::endOfParagraph):

editing/htmlediting.cpp:

(WebCore::lineBreakExistsAtPosition):

editing/markup.cpp:

(WebCore::StyledMarkupAccumulator::renderedText):
(WebCore::replaceChildrenWithFragment):
(WebCore::replaceChildrenWithText):

html/HTMLElement.cpp:

(WebCore::mergeWithNextTextNode):
(WebCore::HTMLElement::setOuterHTML):
(WebCore::HTMLElement::setOuterText):

html/HTMLObjectElement.cpp:

(WebCore::HTMLObjectElement::hasFallbackContent):
(WebCore::HTMLObjectElement::updateDocNamedItem):

html/HTMLOptionElement.cpp:

(WebCore::HTMLOptionElement::setText):

html/HTMLScriptElement.cpp:

(WebCore::HTMLScriptElement::setText):

html/HTMLTextFormControlElement.cpp:

(WebCore::HTMLTextFormControlElement::innerTextValue):
(WebCore::positionForIndex):
(WebCore::HTMLTextFormControlElement::indexForPosition):
(WebCore::HTMLTextFormControlElement::valueWithHardLineBreaks):

html/HTMLTitleElement.cpp:

(WebCore::HTMLTitleElement::setText):

html/parser/HTMLConstructionSite.cpp:

(WebCore::HTMLConstructionSite::insertTextNode):

inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::setNodeValue):

rendering/RenderCombineText.h:
rendering/RenderNamedFlowThread.cpp:

(WebCore::RenderNamedFlowThread::getRanges):

rendering/RenderText.cpp:

(WebCore::RenderText::textNode):

rendering/svg/RenderSVGInlineText.h:
style/StyleResolveTree.cpp:

(WebCore::Style::invalidateWhitespaceOnlyTextSiblingsAfterAttachIfNeeded):
(WebCore::Style::attachChildren):
(WebCore::Style::attachDistributedChildren):
(WebCore::Style::detachDistributedChildren):
(WebCore::Style::detachChildren):
(WebCore::Style::resolveShadowTree):
(WebCore::Style::resolveTree):

Source/WebKit2:

WebProcess/InjectedBundle/API/mac/WKDOMText.mm:

(-[WKDOMText data]):
(-[WKDOMText setData:]):

10:16 AM Changeset in webkit [174067] by Chris Dumez

14 edits in trunk/Source/WebCore

Remove remaining uses of NODE_TYPE_CASTS() from html/
https://bugs.webkit.org/show_bug.cgi?id=137172

Reviewed by Darin Adler.

Remove remaining uses of NODE_TYPE_CASTS() from html/ and use the new
SPECIALIZE_TYPE_TRAITS_*() macro instead so that is<>() / downcast<>()
works for those types.

No new tests, no behavior change.

css/SelectorCheckerTestFunctions.h:

(WebCore::matchesLangPseudoClass):
(WebCore::matchesFutureCuePseudoClass):
(WebCore::matchesPastCuePseudoClass):

css/StyleResolver.cpp:

(WebCore::StyleResolver::canShareStyleWithElement):
The new casting function found a bad cast from a StyledElement to VTTElement.
Those two types are unrelated as VTTElement inherits directly from Element.
Knowing that |element| in this method cannot be a VTTElement simplifies the
logic a bit.

dom/NodeRenderingTraversal.cpp:

(WebCore::NodeRenderingTraversal::findFirstEnteringInsertionPoints):
(WebCore::NodeRenderingTraversal::findLastEnteringInsertionPoints):
(WebCore::NodeRenderingTraversal::traverseParent):

html/HTMLLabelElement.cpp:

(WebCore::nodeAsSupportedLabelableElement):

html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::innerTextElement):

html/LabelableElement.h:

(WebCore::isLabelableElement):

html/shadow/ContentDistributor.cpp:

(WebCore::ContentDistributor::ensureInsertionPointList):

html/shadow/InsertionPoint.h:

(WebCore::isInsertionPoint):
(WebCore::isActiveInsertionPoint):
(WebCore::parentNodeForDistribution):

html/shadow/TextControlInnerElements.h:

(WebCore::isTextControlInnerTextElement):

html/track/VTTCue.cpp:

(WebCore::VTTCue::copyWebVTTNodeToDOMTree):
(WebCore::VTTCue::markFutureAndPastNodes):

html/track/WebVTTElement.h:

(WebCore::isWebVTTElement):

html/track/WebVTTParser.cpp:

(WebCore::WebVTTTreeBuilder::constructTreeFromToken):

style/StyleResolveTree.cpp:

(WebCore::Style::attachRenderTree):
(WebCore::Style::detachChildren):

10:05 AM Changeset in webkit [174066] by commit-queue@webkit.org

5 edits in trunk

Missing changes from r174049
https://bugs.webkit.org/show_bug.cgi?id=137206

Patch by Diego Pino Garcia <Diego Pino Garcia> on 2014-09-29
Reviewed by Darin Adler.

Source/JavaScriptCore:

runtime/CommonIdentifiers.h:

LayoutTests:

js/number-constructor-expected.txt:
js/script-tests/number-constructor.js:

9:58 AM Changeset in webkit [174065] by Chris Dumez

23 edits in trunk/Source

Make is<>() / downcast<>() work for HTMLDocument and its subclasses
https://bugs.webkit.org/show_bug.cgi?id=137169

Reviewed by Darin Adler.

Source/WebCore:

Make is<>() / downcast<>() work for HTMLDocument and its subclasses by
using the SPECIALIZE_TYPE_TRAITS_*() macro. Drop the DOCUMENT_TYPE_CASTS()
macro as it is no longer needed.

No new tests, no behavior change.

bindings/js/JSDOMWindowCustom.cpp:

(WebCore::namedItemGetter):
(WebCore::JSDOMWindow::getOwnPropertySlot):
(WebCore::JSDOMWindow::getOwnPropertySlotByIndex):

dom/Document.cpp:

(WebCore::Document::prepareForDestruction):
(WebCore::Document::processHttpEquiv):
(WebCore::eventTargetElementForDocument):

dom/Document.h:
dom/Element.cpp:

(WebCore::Element::insertedInto):
(WebCore::Element::removedFrom):
(WebCore::Element::updateName):
(WebCore::Element::updateId):

html/HTMLDocument.h:

(WebCore::isHTMLDocument):

html/HTMLElement.cpp:

(WebCore::HTMLElement::matchesReadWritePseudoClass):

html/HTMLEmbedElement.cpp:

(WebCore::HTMLEmbedElement::updateWidget):

html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::parseAttribute):

html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::parseAttribute):

html/HTMLObjectElement.cpp:

(WebCore::HTMLObjectElement::updateDocNamedItem):

html/ImageDocument.cpp:

(WebCore::ImageDocumentParser::document):

html/ImageDocument.h:

(WebCore::isImageDocument):

html/MediaDocument.h:

(WebCore::isMediaDocument):

html/PluginDocument.cpp:

(WebCore::PluginDocumentParser::createDocumentStructure):

html/PluginDocument.h:

(WebCore::isPluginDocument):

loader/SubframeLoader.cpp:

(WebCore::SubframeLoader::loadPlugin):

page/DragController.cpp:

(WebCore::DragController::operationForLoad):

page/FrameView.cpp:

(WebCore::determineLayerFlushThrottleState):

Source/WebKit/win:

Use is<>() / downcast<>() for HTMLDocument and its subclasses.

DOMHTMLClasses.cpp:

(DOMHTMLDocument::URL):
(DOMHTMLDocument::body):
(DOMHTMLDocument::forms):

Source/WebKit2:

Use is<>() / downcast<>() for HTMLDocument and its subclasses.

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::pdfDocumentForPrintingFrame):

9:31 AM Changeset in webkit [174064] by Bruno de Oliveira Abinader

4 edits
2 deletes in trunk

Revert "Support for :enabled selector on Anchor & Area elements"
https://bugs.webkit.org/show_bug.cgi?id=134826

Reviewed by Darin Adler.

Source/WebCore:

HTML spec has been modified [1] to disable support for :enabled CSS
selector on Anchor, Area & Link elements, after discussion on W3C
Bugzilla [2].

This reverts r171671.

[1] https://html5.org/r/8818
[2] https://www.w3.org/Bugs/Public/show_bug.cgi?id=26622

css/SelectorCheckerTestFunctions.h:

(WebCore::isEnabled):

html/HTMLAnchorElement.cpp:

(WebCore::HTMLAnchorElement::parseAttribute):

LayoutTests:

These layout tests are no longer correct after changes to the :enabled
CSS selector specification.

fast/css/css-selector-enabled-links-expected.txt: Removed.
fast/css/css-selector-enabled-links.html: Removed.

9:26 AM Changeset in webkit [174063] by Darin Adler

4 edits in trunk

Tweak and tighten SVG font converter
https://bugs.webkit.org/show_bug.cgi?id=136956

Reviewed by Myles Maxfield.

Source/WebCore:

svg/SVGToOTFFontConversion.cpp: Fixed copyright date.

(WebCore::overwrite32): Changed to use normal subscripting for clarity.
(WebCore::overwrite16): Added.
(WebCore::SVGToOTFFontConverter::GlyphData::GlyphData): Added a move
to make constructing each GlyphData less expensive.
(WebCore::SVGToOTFFontConverter::KerningData): Removed the < operator
since it the struct contains more than what we want to sort it by, so it's
not elegant to build the sorting rule into the struct.
(WebCore::SVGToOTFFontConverter): Removed "k" prefix from some constants.
Replaced many function templates with non-template functions. Changed
key type for m_codepointToIndexMap to UChar32.
(WebCore::integralLog2): Tweaked formatting.
(WebCore::SVGToOTFFontConverter::appendCMAPTable): Removed a stray
cast that doesn't have any effect. Use the Glyph type to index m_glyphs.
(WebCore::SVGToOTFFontConverter::appendHEADTable): Append the magic
number in a more straightforward way.
(WebCore::clampTo): Tweak formatting of the template function.
(WebCore::SVGToOTFFontConverter::appendHHEATable): Made some minor
style changes and improved some comments.
(WebCore::SVGToOTFFontConverter::appendOS2Table): Made some minor
style changes and tightened up code that did parsing a bit, removing the
dynamically allocated array for the fixed length Panose number.
Also use first and last instead of hand-coded versions of those.
(WebCore::appendValidCFFString): Renamed.
(WebCore::SVGToOTFFontConverter::appendCFFTable): Made various tweaks,
including more specific of null for the "no weight" value instead of
either empty or null.
(WebCore::SVGToOTFFontConverter::appendVORGTable): Simplified some of
the numeric parsing, since toInt is guaranteed to return 0 when it also
would return "false" for ok. Also got rid of a local vector and instead
just fixed up the size of the table afterward.
(WebCore::SVGToOTFFontConverter::appendVHEATable): Tweaked comment.
(WebCore::SVGToOTFFontConverter::addCodepointRanges): Use isValidKey
instead of a local hardcoded rule to check hash table key validity.
Check for zero in the result of get rather than using find on the HashMap.
(WebCore::SVGToOTFFontConverter::addCodepointRanges): Ditto.
(WebCore::SVGToOTFFontConverter::addGlyphNames): Ditto.
(WebCore::SVGToOTFFontConverter::addKerningPair): Added. Factored out from
appendKERNSubtable to reduce template bloat and improve clarity.
(WebCore::SVGToOTFFontConverter::appendKERNSubtable): Tweaked formatting.
Moved the bulk of the function into non-template function.
(WebCore::SVGToOTFFontConverter::finishAppendingKERNSubtable): Added.
Non-template part of appendKERNSubtable. Also changed std::sort to supply
custom comparison function rather than trying to use the < operator directly
on KerningData.
(WebCore::writeCFFEncodedNumber): Don't use powf just to multiply by
2^{16. It's pretty easy to do that with plain old multiplication.

(WebCore::CFFBuilder::CFFBuilder): Renamed m_firstPoint to

m_hasBoundingBox.

(WebCore::CFFBuilder::boundingBox): Made this public and const and made

the rest of the class private.

(WebCore::CFFBuilder::updateBoundingBox): Used early return and revised

to use m_hasBoundingBox.

(WebCore::CFFBuilder::writePoint): Added. Used to keep the other

functions below smaller.

(WebCore::CFFBuilder::moveTo): Marked virtual and simplified using writePoint.

Might find a way to simplify even further by teaching writePoint about

the PathCoordinateMode.

(WebCore::CFFBuilder::lineTo): Ditto.

(WebCore::CFFBuilder::curveToCubic): Ditto. Also removed comment that said

the function could be faster. Not sure that's important to state like this.

(WebCore::SVGToOTFFontConverter::transcodeGlyphPaths): Changed into a

non-template function. Tweaked logic and formatting a bit.

(WebCore::SVGToOTFFontConverter::processGlyphElement): Changed into a

non-template function. Moved the code from appendGlyphData in here.

Use WTF::move so we don't copy the glyph paths when creating a GlyphData.

(WebCore::SVGToOTFFontConverter::SVGToOTFFontConverter): Updated a bit for

function changes above. Changed code to use isValidKey to check if we can

add to m_codepointToIndexMap. Parse font-style rather than parsing

font-weight twice. Round weights instead of truncating them. Change rule

to "first wins" instead of "last wins" when there are multiple segments.

Removed one vague and non-helpful comment.

(WebCore::isFourByteAligned): Fixed minor formatting issue by making the

function non-abstract. No reason not to hard-code the number 3 when the

number four appears in the function name.

(WebCore::calculateChecksum): Removed unneeded comment about why the

checksum is little-endian; since this came from Windows documentation there

is no doubt that little-endian is correct, so we don't need a comment creating

fear, uncertainty, and doubt. If the checksum computation is wrong, it should

become obvious that we have a bad checksum. Also changed the for loop to use

its own loop variable instead of changing startingOffset, which is not logical.

(WebCore::SVGToOTFFontConverter::appendTable): Updated for name changes.

(WebCore::SVGToOTFFontConverter::convertSVGToOTFFont): Ditto. Also streamlined

the checksum code a little. The comment still is a little peculiar; I was

tempted to take it out.}

Tools:

I was investigating behavior of String::toInt, String::toDouble, and
String::toFloat for various failure cases, and decided to start some
unit tests for those functions here.

TestWebKitAPI/Tests/WTF/WTFString.cpp:

(TestWebKitAPI::TEST): Addded a first small bit of StringToInt and
StringToDouble testing.

8:37 AM Changeset in webkit [174062] by dbates@webkit.org

2 edits in trunk/Source/WebKit/ios

[iOS] Remove CoreLocation workaround
https://bugs.webkit.org/show_bug.cgi?id=137198

Reviewed by Dan Bernstein.

Following the fix for <rdar://problem/18448331>, we can revert the CoreLocation workaround
committed in <http://trac.webkit.org/changeset/173946> and <http://trac.webkit.org/changeset/173940> (in order).

Misc/WebGeolocationCoreLocationProvider.mm:

(-[WebGeolocationCoreLocationProvider requestGeolocationAuthorization]):
(-[WebGeolocationCoreLocationProvider locationManager:didChangeAuthorizationStatus:]):

8:30 AM Changeset in webkit [174061] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit2

Fix !ENABLE(INSPECTOR) build after r173929
https://bugs.webkit.org/show_bug.cgi?id=137210

Patch by Tibor Meszaros <tmeszaros.u-szeged@partner.samsung.com> on 2014-09-29
Reviewed by Timothy Hatcher.

UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::getLaunchOptions):

8:16 AM Changeset in webkit [174060] by Philippe Normand

2 edits in trunk/Tools

[GTK][CMake] TestWebCore target build sometimes fail
https://bugs.webkit.org/show_bug.cgi?id=137207

Reviewed by Csaba Osztrogon.

TestWebKitAPI/PlatformGTK.cmake: Make sure the forwarding

headers are generated before the TestWebCore target is built.

5:32 AM Changeset in webkit [174059] by Carlos Garcia Campos

2 edits
2 deletes in trunk/Source/WebCore

[GTK] Remove MainFrameScrollbarGtk.cpp
https://bugs.webkit.org/show_bug.cgi?id=137211

Reviewed by Philippe Normand.

This was only used by WebKit1.

PlatformGTK.cmake:
platform/gtk/MainFrameScrollbarGtk.cpp: Removed.
platform/gtk/MainFrameScrollbarGtk.h: Removed.

4:54 AM Changeset in webkit [174058] by Carlos Garcia Campos

7 edits
2 deletes in trunk

[GTK] Remove IntPointGtk.cpp and IntRectGtk.cpp
https://bugs.webkit.org/show_bug.cgi?id=137209

Reviewed by Philippe Normand.

Source/WebCore:

IntPointGtk is unused and IntRectGtk is only required by GTK+2 and
only used when building with GTK+2 in GtkInputMethodFilter.cpp
that can be easily replaced.

PlatformGTK.cmake:
platform/graphics/IntPoint.h:
platform/graphics/IntRect.h:
platform/graphics/gtk/IntPointGtk.cpp: Removed.
platform/graphics/gtk/IntRectGtk.cpp: Removed.
platform/gtk/GtkInputMethodFilter.cpp:

(WebCore::GtkInputMethodFilter::setCursorRect):

Tools:

TestWebKitAPI/PlatformGTK.cmake: Remove unneeded IntRectGtk.cpp

from the WebCore test sources.

3:08 AM Changeset in webkit [174057] by svillar@igalia.com

9 edits
6 adds in trunk

[CSS Grid Layout] Handle percentages of indefinite sizes in minmax() and grid-auto-*
https://bugs.webkit.org/show_bug.cgi?id=136453

Reviewed by Darin Adler.

Source/WebCore:

After r165048 percentages of indefinite sizes were correctly
computed to "auto". The problem is that we were not doing it when
the percentage was inside the minmax() function. In those cases it
should compute to min-content for the min track sizing function or
to max-content for the max track sizing function.

We were not doing it also for the track sizes specified in
grid-auto-{column|row} properties. Fixed as well as the code is
the same.

Tests: fast/css-grid-layout/percent-of-indefinite-track-size-in-auto.html

fast/css-grid-layout/percent-of-indefinite-track-size-in-minmax-crash.html
fast/css-grid-layout/percent-of-indefinite-track-size.html

rendering/RenderGrid.cpp:

(WebCore::RenderGrid::gridTrackSize):

rendering/RenderGrid.h:
rendering/style/GridLength.h:

(WebCore::GridLength::isPercentage):

rendering/style/GridTrackSize.h:

(WebCore::GridTrackSize::GridTrackSize):

LayoutTests:

Added three new tests, one to verify that we do not assert with
percentages inside minmax() and another two to verify that we
properly compute the percentage of indefinite size in various
situations both in grid-template-* properties and in
grid-auto-{column|row} properties.

Three other tests required minimum adjustments as they were using
percentages of indefinite sizes inside minmax functions. In order
to keep the original expected behavior some definite sizes were
added.

fast/css-grid-layout/grid-auto-columns-rows-auto-flow-resolution.html:
fast/css-grid-layout/grid-auto-columns-rows-resolution.html:
fast/css-grid-layout/grid-auto-columns-rows-update.html:
fast/css-grid-layout/percent-of-indefinite-track-size-expected.txt: Added.
fast/css-grid-layout/percent-of-indefinite-track-size-in-auto-expected.txt: Added.
fast/css-grid-layout/percent-of-indefinite-track-size-in-auto.html: Added.
fast/css-grid-layout/percent-of-indefinite-track-size-in-minmax-crash-expected.txt: Added.
fast/css-grid-layout/percent-of-indefinite-track-size-in-minmax-crash.html: Added.
fast/css-grid-layout/percent-of-indefinite-track-size.html: Added.

2:16 AM Changeset in webkit [174056] by Carlos Garcia Campos

1 copy in releases/WebKitGTK/webkit-2.4.6

WebKitGTK+ 2.4.6

1:54 AM Changeset in webkit [174055] by Carlos Garcia Campos

2 edits in trunk/Source/WebCore

Unreviewed. Move sources not using GTK+ from WebCorePlatformGTK_SOURCES to WebCore_SOURCES.

PlatformGTK.cmake:

1:51 AM Changeset in webkit [174054] by Carlos Garcia Campos

3 edits in trunk/Source/WebKit2

REGRESSION(r172919): WebKitPluginProcess fails to scan GTK+2 plugins after r172919.
https://bugs.webkit.org/show_bug.cgi?id=137191

Reviewed by Philippe Normand.

In r172919 I moved the GTK+ symbols mix check earlier, before the
plugin is loaded and initialized. That made impossible to use the
GTK3 plugin process to scan gtk2 plugins, because we need to load
the plugin to get its metadata. But we don't need to initialize
the plugin to check if it requires GTK2, so we can do that check
in the UI process to decide which plugin process to use.

Shared/Plugins/Netscape/x11/NetscapePluginModuleX11.cpp:

(WebKit::NetscapePluginModule::getPluginInfoForLoadedPlugin):
Remove the requires GTK2 check.
(WebKit::NetscapePluginModule::scanPlugin): Don't write
requires-gtk2 to stdout.

UIProcess/Plugins/unix/PluginProcessProxyUnix.cpp:

(WebKit::pluginRequiresGtk2): Helper function to check if the
given plugin path requires GTK2.
(WebKit::PluginProcessProxy::scanPlugin): Check if the plugin path
requires GTK2 and use WebKitPluginProcess2 in such case, or return
early if GTK2 plugins are not enabled. Log error messages when
something fails scanning the plugin to make it easiert to debug
problems in the future.

12:15 AM Changeset in webkit [174053] by gyuyoung.kim@samsung.com

3 edits in trunk/Source/WebCore

Use std::unique_ptr instead of PassOwnPtr|OwnPtr for NamedNodeMap
https://bugs.webkit.org/show_bug.cgi?id=137201

Reviewed by Darin Adler.

No new tests, just refactoring patch.

dom/ElementRareData.h: Use std::unique_ptr instead of OwnPtr.

(WebCore::ElementRareData::setAttributeMap): Use std::unique_ptr.

dom/NamedNodeMap.h:

(WebCore::NamedNodeMap::create): ditto.

Sep 28, 2014:

8:42 PM Changeset in webkit [174052] by mmaxfield@apple.com

13 edits
1 add in trunk/Source

Replace wkGetGlyphsForCharacters() with CGFontGetGlyphsForUnichars()
https://bugs.webkit.org/show_bug.cgi?id=137197

Reviewed by Alexey Proskuryakov.

No new tests because there is no behavior change.

Source/WebCore:

WebCore.exp.in:
WebCore.order:
WebCore.xcodeproj/project.pbxproj:
platform/graphics/mac/GlyphPageTreeNodeMac.cpp:

(WebCore::GlyphPage::fill): Use SPI call instead of WKSI call

platform/mac/WebCoreSystemInterface.h:
platform/mac/WebCoreSystemInterface.mm:
platform/spi/cocoa/CGFontUnicodeSupport.h: Added for SPI call.

Source/WebKit:

mac/WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

WebKit.order:

Source/WebKit2:

WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

mac/WebKit2.order:

8:02 PM Changeset in webkit [174051] by mmaxfield@apple.com

3 edits in trunk/Tools

Allow webkit-patch upload to respect the --directory argument with git checkouts
https://bugs.webkit.org/show_bug.cgi?id=137166

Reviewed by Darin Adler.

We simply hadn't plumbed it through.

Scripts/webkitpy/common/checkout/scm/detection.py:

(SCMDetector.detect_scm_system):

Scripts/webkitpy/common/checkout/scm/git.py:

(Git.init):
(Git.changed_files):

7:13 PM Changeset in webkit [174050] by Chris Dumez

32 edits
2 copies in trunk/Source/WebCore

Automatically generate template specializations for most Elements
https://bugs.webkit.org/show_bug.cgi?id=137174

Reviewed by Darin Adler.

Previously, the template specializations to make is<>() / downcast<>()
work for HTML/SVG/MathML elements were only generated if
"generateTypeHelpers" parameter was explicitly specified for the
corresponding tag name in the *Tags.in file.

We are however able to generate the template specializations for most
types so this patch drops the "generateTypeHelpers" parameter and
generates those template specializations by default.

One case we cannot generate the specialization ifor is when a class is
associated to several tag names but this patch updates the
make_names.pl script to detect this and skip those classes.

No new tests, no behavior change.

CMakeLists.txt:
WebCore.xcodeproj/project.pbxproj:
dom/make_names.pl:

(defaultTagPropertyHash):
(printTypeHelpers):

html/HTMLTagNames.in:
mathml/mathtags.in:
svg/SVGAllInOne.cpp:
svg/SVGAnimateColorElement.cpp:

(WebCore::SVGAnimateColorElement::SVGAnimateColorElement):
(WebCore::SVGAnimateColorElement::determinePropertyValueTypes):

svg/SVGAnimateColorElement.h:
svg/SVGAnimateElement.cpp:

(WebCore::SVGAnimateElement::SVGAnimateElement):
(WebCore::SVGAnimateElement::~SVGAnimateElement): Deleted.
(WebCore::SVGAnimateElement::hasValidAttributeType): Deleted.
(WebCore::SVGAnimateElement::determineAnimatedPropertyType): Deleted.
(WebCore::SVGAnimateElement::calculateAnimatedValue): Deleted.
(WebCore::SVGAnimateElement::calculateToAtEndOfDurationValue): Deleted.
(WebCore::SVGAnimateElement::calculateFromAndToValues): Deleted.
(WebCore::SVGAnimateElement::calculateFromAndByValues): Deleted.
(WebCore::propertyTypesAreConsistent): Deleted.
(WebCore::SVGAnimateElement::resetAnimatedType): Deleted.
(WebCore::applyCSSPropertyToTarget): Deleted.
(WebCore::removeCSSPropertyFromTarget): Deleted.
(WebCore::applyCSSPropertyToTargetAndInstances): Deleted.
(WebCore::removeCSSPropertyFromTargetAndInstances): Deleted.
(WebCore::notifyTargetAboutAnimValChange): Deleted.
(WebCore::notifyTargetAndInstancesAboutAnimValChange): Deleted.
(WebCore::SVGAnimateElement::clearAnimatedType): Deleted.
(WebCore::SVGAnimateElement::applyResultsToTarget): Deleted.
(WebCore::SVGAnimateElement::animatedPropertyTypeSupportsAddition): Deleted.
(WebCore::SVGAnimateElement::isAdditive): Deleted.
(WebCore::SVGAnimateElement::calculateDistance): Deleted.
(WebCore::SVGAnimateElement::setTargetElement): Deleted.
(WebCore::SVGAnimateElement::setAttributeName): Deleted.
(WebCore::SVGAnimateElement::resetAnimatedPropertyType): Deleted.
(WebCore::SVGAnimateElement::ensureAnimator): Deleted.

svg/SVGAnimateElement.h:

(WebCore::isSVGAnimateElement): Deleted.

svg/SVGAnimateElementBase.cpp: Copied from Source/WebCore/svg/SVGAnimateElement.cpp.

(WebCore::SVGAnimateElementBase::SVGAnimateElementBase):
(WebCore::SVGAnimateElementBase::~SVGAnimateElementBase):
(WebCore::SVGAnimateElementBase::hasValidAttributeType):
(WebCore::SVGAnimateElementBase::determineAnimatedPropertyType):
(WebCore::SVGAnimateElementBase::calculateAnimatedValue):
(WebCore::SVGAnimateElementBase::calculateToAtEndOfDurationValue):
(WebCore::SVGAnimateElementBase::calculateFromAndToValues):
(WebCore::SVGAnimateElementBase::calculateFromAndByValues):
(WebCore::propertyTypesAreConsistent):
(WebCore::SVGAnimateElementBase::resetAnimatedType):
(WebCore::applyCSSPropertyToTarget):
(WebCore::removeCSSPropertyFromTarget):
(WebCore::applyCSSPropertyToTargetAndInstances):
(WebCore::removeCSSPropertyFromTargetAndInstances):
(WebCore::notifyTargetAboutAnimValChange):
(WebCore::notifyTargetAndInstancesAboutAnimValChange):
(WebCore::SVGAnimateElementBase::clearAnimatedType):
(WebCore::SVGAnimateElementBase::applyResultsToTarget):
(WebCore::SVGAnimateElementBase::animatedPropertyTypeSupportsAddition):
(WebCore::SVGAnimateElementBase::isAdditive):
(WebCore::SVGAnimateElementBase::calculateDistance):
(WebCore::SVGAnimateElementBase::setTargetElement):
(WebCore::SVGAnimateElementBase::setAttributeName):
(WebCore::SVGAnimateElementBase::resetAnimatedPropertyType):
(WebCore::SVGAnimateElementBase::ensureAnimator):

svg/SVGAnimateElementBase.h: Copied from Source/WebCore/svg/SVGAnimateElement.h.

(WebCore::isSVGAnimateElementBase):

svg/SVGAnimateTransformElement.cpp:

(WebCore::SVGAnimateTransformElement::SVGAnimateTransformElement):
(WebCore::SVGAnimateTransformElement::parseAttribute):

svg/SVGAnimateTransformElement.h:
svg/SVGAnimatedAngle.cpp:
svg/SVGAnimatedBoolean.cpp:
svg/SVGAnimatedColor.cpp:
svg/SVGAnimatedInteger.cpp:
svg/SVGAnimatedIntegerOptionalInteger.cpp:
svg/SVGAnimatedLength.cpp:
svg/SVGAnimatedLengthList.cpp:
svg/SVGAnimatedNumber.cpp:
svg/SVGAnimatedNumberList.cpp:
svg/SVGAnimatedNumberOptionalNumber.cpp:
svg/SVGAnimatedPath.cpp:
svg/SVGAnimatedPointList.cpp:
svg/SVGAnimatedPreserveAspectRatio.cpp:
svg/SVGAnimatedRect.cpp:
svg/SVGAnimatedString.cpp:
svg/SVGAnimationElement.cpp:

(WebCore::SVGAnimationElement::currentValuesForValuesAnimation):

svg/SVGSetElement.cpp:

(WebCore::SVGSetElement::SVGSetElement):

svg/SVGSetElement.h:
svg/svgtags.in:

6:52 PM Changeset in webkit [174049] by commit-queue@webkit.org

7 edits
3 adds in trunk

Simple ES6 feature: Number constructor extras
https://bugs.webkit.org/show_bug.cgi?id=131707

Patch by Diego Pino Garcia <Diego Pino Garcia> on 2014-09-28
Reviewed by Darin Adler.

Source/JavaScriptCore:

runtime/CommonIdentifiers.h:
runtime/NumberConstructor.cpp:

(JSC::NumberConstructor::finishCreation): Setup constants and
functions.
(JSC::numberConstructorFuncIsFinite): Added.
(JSC::numberConstructorFuncIsInteger): Added.
(JSC::numberConstructorFuncIsNaN): Added.
(JSC::numberConstructorFuncIsSafeInteger): Added.
(JSC::NumberConstructor::getOwnPropertySlot): Deleted.
(JSC::numberConstructorNaNValue): Deleted.
(JSC::numberConstructorNegInfinity): Deleted.
(JSC::numberConstructorPosInfinity): Deleted.
(JSC::numberConstructorMaxValue): Deleted.
(JSC::numberConstructorMinValue): Deleted.

runtime/NumberConstructor.h:

LayoutTests:

js/Object-getOwnPropertyNames-expected.txt:
js/number-constructor-expected.txt: Added.
js/number-constructor.html: Added.
js/script-tests/Object-getOwnPropertyNames.js:
js/script-tests/number-constructor.js: Added.

6:18 PM Changeset in webkit [174048] by gyuyoung.kim@samsung.com

12 edits in trunk/Source

Use std::unique_ptr for ContextMenuController
https://bugs.webkit.org/show_bug.cgi?id=137178

Reviewed by Darin Adler.

Switch to using std::unique_ptr instead of OwnPtr and PassOwnPtr
for ContextMenuController class. Inherited class is changed by this use as well.

Source/WebCore:

No new tests, no behavior changes.

loader/EmptyClients.cpp:

(WebCore::EmptyContextMenuClient::customizeMenu):

loader/EmptyClients.h:
page/ContextMenuClient.h:
page/ContextMenuController.cpp:

(WebCore::ContextMenuController::clearContextMenu):
(WebCore::ContextMenuController::maybeCreateContextMenu):
(WebCore::ContextMenuController::showContextMenu):

page/ContextMenuController.h:

Source/WebKit/win:

WebCoreSupport/WebContextMenuClient.cpp:

(WebContextMenuClient::customizeMenu):

WebCoreSupport/WebContextMenuClient.h:

Source/WebKit2:

WebProcess/WebCoreSupport/WebContextMenuClient.cpp:

(WebKit::WebContextMenuClient::customizeMenu):

WebProcess/WebCoreSupport/WebContextMenuClient.h:

6:04 PM Changeset in webkit [174047] by gyuyoung.kim@samsung.com

14 edits in trunk/Source

Move ColorInputType class to std::unique_ptr
https://bugs.webkit.org/show_bug.cgi?id=137173

Reviewed by Darin Adler.

Replace uses of PassOwnPtr in code under ColorInputType class with std::unique_ptr.
Child classes follow this change as well.

Source/WebCore:

No new tests, no behavior changes.

html/ColorInputType.cpp:

(WebCore::ColorInputType::didEndChooser):

html/ColorInputType.h:
loader/EmptyClients.cpp:

(WebCore::EmptyChromeClient::createColorChooser):

loader/EmptyClients.h:
page/Chrome.cpp:

(WebCore::Chrome::createColorChooser):

page/Chrome.h:
page/ChromeClient.h:

Source/WebKit/mac:

WebCoreSupport/WebChromeClient.h:
WebCoreSupport/WebChromeClient.mm:

(WebChromeClient::createColorChooser):

Source/WebKit2:

WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::createColorChooser):

WebProcess/WebCoreSupport/WebChromeClient.h:

4:18 PM Changeset in webkit [174046] by commit-queue@webkit.org

16 edits in trunk

Fix some minor typos: psuedo -> pseudo
https://bugs.webkit.org/show_bug.cgi?id=137192

Patch by Sungmann Cho <sungmann.cho@navercorp.com> on 2014-09-28
Reviewed by Alexey Proskuryakov.

PerformanceTests:

Speedometer/resources/todomvc/architecture-examples/emberjs/bower_components/handlebars/handlebars.js:

Source/WebCore:

No new tests, no behavior change.

css/CSSSelector.cpp:

(WebCore::CSSSelector::specificityForOneSelector):

LayoutTests:

fast/dom/Window/getMatchedCSSRules-with-invalid-pseudo-elements-expected.txt:
fast/dom/Window/getMatchedCSSRules-with-invalid-pseudo-elements.html:
fast/dom/Window/getMatchedCSSRules-with-pseudo-elements-expected.txt:
fast/dom/Window/getMatchedCSSRules-with-pseudo-elements.html:
fast/selectors/159.html:
fast/selectors/160.html:
fast/selectors/166.html:
platform/efl/fast/selectors/166-expected.txt:
platform/gtk/fast/selectors/166-expected.txt:
platform/ios-sim/fast/selectors/166-expected.txt:
platform/mac/fast/selectors/166-expected.txt:

1:59 PM Changeset in webkit [174045] by weinig@apple.com

17 edits
1 move
1 delete in trunk

Replace OSObjectPtr with RetainPtr/adoptOS
https://bugs.webkit.org/show_bug.cgi?id=137158

Reviewed by Dan Bernstein.

Source/WebKit2:

DatabaseProcess/EntryPoint/mac/XPCService/DatabaseServiceEntryPoint.mm:

(DatabaseServiceInitializer):

NetworkProcess/EntryPoint/mac/XPCService/NetworkServiceEntryPoint.mm:

(WebKit::NetworkServiceInitializerDelegate::NetworkServiceInitializerDelegate):
(NetworkServiceInitializer):

Platform/IPC/Connection.h:

(IPC::Connection::Identifier::Identifier):

Platform/IPC/mac/ConnectionMac.mm:

(IPC::ConnectionTerminationWatchdog::createConnectionTerminationWatchdog):
(IPC::ConnectionTerminationWatchdog::ConnectionTerminationWatchdog):

PluginProcess/EntryPoint/mac/XPCService/PluginServiceEntryPoint.mm:

(WebKit::PluginServiceInitializerDelegate::PluginServiceInitializerDelegate):
(PluginServiceInitializer):

Shared/EntryPointUtilities/mac/XPCService/XPCServiceEntryPoint.h:

(WebKit::XPCServiceInitializerDelegate::XPCServiceInitializerDelegate):
(WebKit::XPCServiceInitializer):

Shared/EntryPointUtilities/mac/XPCService/XPCServiceEntryPoint.mm:

(WebKit::XPCServiceInitializerDelegate::checkEntitlements):
(WebKit::XPCServiceInitializerDelegate::hasEntitlement):

Shared/EntryPointUtilities/mac/XPCService/XPCServiceMain.Development.mm:

(WebKit::XPCServiceEventHandler):

Shared/EntryPointUtilities/mac/XPCService/XPCServiceMain.mm:

(WebKit::XPCServiceEventHandler):

UIProcess/Launcher/mac/ProcessLauncherMac.mm:

(WebKit::connectToService):
(WebKit::connectToReExecService):

WebProcess/EntryPoint/mac/XPCService/WebContentServiceEntryPoint.mm:

(WebContentServiceInitializer):

Source/WTF:

WTF.xcodeproj/project.pbxproj:
wtf/OSObjectPtr.h: Removed.
wtf/RetainPtr.h:

(WTF::adoptOS):
Added. This adopt function is slightly different than both adoptCF and adoptNS,
in that unlike adoptCF(), it can be passed an Objective-C type (since OS objects
are sometimes Objective-C objects, but not always), and unlike adoptNS() it doesn't
require us to jump through hoops to appease GC (since OS objects are not Objective-C
objects if GC is enabled).

Tools:

TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
TestWebKitAPI/Tests/WTF/darwin/OSObjectPtr.cpp: Removed.
TestWebKitAPI/Tests/WTF/darwin/RetainPtrOSObject.cpp: Copied from Tools/TestWebKitAPI/Tests/WTF/darwin/OSObjectPtr.cpp.

Rename and change test to use RetainPtr. Remove now unneeded part testing WTF::retainOSObject/WTF::releaseOSObject.

7:07 AM WebKitGTK/2.6.x edited by berto@igalia.com

(diff)

1:23 AM Changeset in webkit [174044] by Carlos Garcia Campos

1 edit
1 move in trunk/Source/WebCore

Unreviewed. Move RenderThemeGtk.h from platform/gtk to rendering.

I forgot to move this file in r173111.

rendering/RenderThemeGtk.h: Renamed from Source/WebCore/platform/gtk/RenderThemeGtk.h.

1:18 AM Changeset in webkit [174043] by Carlos Garcia Campos

4 edits in trunk/Source/WebCore

[ATK] WebKitAccessibleWrapperAtk should not depend on GTK
https://bugs.webkit.org/show_bug.cgi?id=137177

Reviewed by Martin Robinson.

It's used to get the web view widget, but there's no GtkWidget in
the web process and platformPageClient is always NULL.

PlatformGTK.cmake: Move accessibility sources to the WebCore

sources list.

accessibility/atk/WebKitAccessibleWrapperAtk.cpp:

(atkParentOfRootObject): Remove code to get view GtkWidget.

editing/atk/FrameSelectionAtk.cpp: Remove unneeded header include.

1:14 AM Changeset in webkit [174042] by Carlos Garcia Campos

2 edits
2 deletes in trunk/Source/WebCore

[GTK] Remove unused GtkPluginWidget
https://bugs.webkit.org/show_bug.cgi?id=137176

Reviewed by Csaba Osztrogonác.

It was only used by WebKit1.

PlatformGTK.cmake:
platform/gtk/GtkPluginWidget.cpp: Removed.
platform/gtk/GtkPluginWidget.h: Removed.

1:06 AM Changeset in webkit [174041] by Carlos Garcia Campos

5 edits in trunk/Source/WebCore

[cairo] GraphicsContext should not depend on GTK+
https://bugs.webkit.org/show_bug.cgi?id=137175

Reviewed by Martin Robinson.

Remove the unused methods depending on GDK and simplify
GraphicsContext::drawFocusRing() using only cairo API.

PlatformGTK.cmake: Move GraphicsContextCairo.cpp to the webcore sources.
platform/graphics/GraphicsContext.h:
platform/graphics/cairo/GraphicsContextCairo.cpp:

(WebCore::GraphicsContext::drawFocusRing): Iterate the rectangles
instead of creating a region for the rectangles and call gdk_cairo_region().
(WebCore::GraphicsContext::setGdkExposeEvent): Deleted.
(WebCore::GraphicsContext::gdkExposeEvent): Deleted.
(WebCore::GraphicsContext::gdkWindow): Deleted.

Context Navigation

Timeline

Sep 29, 2014:

Sep 28, 2014:

Download in other formats: