Context Navigation

← Previous Period
Next Period →

Timeline

Oct 4, 2014:

11:34 PM Changeset in webkit [174325] by mmaxfield@apple.com

2 edits in trunk/Source/WebCore

[SVG -> OTF Converter] Arabic forms are not substituted correctly
https://bugs.webkit.org/show_bug.cgi?id=137092

Reviewed by Darin Adler.

Tests: svg/W3C-SVG-1.1/fonts-glyph-02-t.svg

svg/custom/glyph-selection-arabic-forms.svg

svg/SVGToOTFFontConversion.cpp:

(WebCore::SVGToOTFFontConverter::appendArabicReplacementSubtable): Invoked for each of the three
Arabic form substitutions.
(WebCore::SVGToOTFFontConverter::appendGSUBTable): OpenType "Advanced Typographic Table":
"Glyph substitution data"
(WebCore::SVGToOTFFontConverter::SVGToOTFFontConverter): Re-order the m_codepointsToIndicesMap
to prefer isolated forms of glyphs.
(WebCore::SVGToOTFFontConverter::convertSVGToOTFFont): Append the GSUB table.
(WebCore::calculateChecksum): Deleted.

3:24 PM Changeset in webkit [174324] by commit-queue@webkit.org

7 edits
4 adds in trunk

Implement Element.closest() API
https://bugs.webkit.org/show_bug.cgi?id=137418

Patch by Dhi Aurrahman <diorahman@rockybars.com> on 2014-10-04
Reviewed by Benjamin Poulain.

Source/WebCore:

Implement Element.closest() API as specified in [1].

[1]: https://dom.spec.whatwg.org/#dom-element-closest

Tests: fast/selectors/closest-general.html

fast/selectors/closest-scope.html

dom/Element.cpp:

(WebCore::Element::closest):

dom/Element.h:
dom/Element.idl:
dom/SelectorQuery.cpp:

(WebCore::SelectorDataList::selectorClosest):
(WebCore::SelectorDataList::closest):

dom/SelectorQuery.h:

(WebCore::SelectorQuery::closest):

LayoutTests:

Add test cases for Element.closest() API

fast/selectors/closest-general-expected.txt: Added.
fast/selectors/closest-general.html: Added.
fast/selectors/closest-scope-expected.txt: Added.
fast/selectors/closest-scope.html: Added.

3:11 PM Changeset in webkit [174323] by commit-queue@webkit.org

6 edits
9 adds in trunk/Source/WebInspectorUI

Web Inspector: Add PrettyPrinter CSS tests
https://bugs.webkit.org/show_bug.cgi?id=134005

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-10-04
Reviewed by Timothy Hatcher.

Add CSS pretty printing tests. Improve pretty printing of calc()
expressions and media-queries with whitespace around operators
and keywords. Also fix the debug output in the tool for CSS.

Tools/PrettyPrinting/CodeMirrorFormatters.js:
Tools/PrettyPrinting/FormatterContentBuilder.js:

(FormatterContentBuilder.prototype._appendIndent):

Tools/PrettyPrinting/FormatterDebug.js:

(.debugToken):
(Formatter.prototype.debug):

Tools/PrettyPrinting/css-tests/basic-expected.css: Added.
Tools/PrettyPrinting/css-tests/basic.css: Added.
Tools/PrettyPrinting/css-tests/calc-expected.css: Added.
Tools/PrettyPrinting/css-tests/calc.css: Added.
Tools/PrettyPrinting/css-tests/media-query-expected.css: Added.
Tools/PrettyPrinting/css-tests/media-query.css: Added.
Tools/PrettyPrinting/css-tests/selectors-expected.css: Added.
Tools/PrettyPrinting/css-tests/selectors.css: Added.
Tools/PrettyPrinting/index.html:
UserInterface/Views/CodeMirrorFormatters.js:

2:55 PM Changeset in webkit [174322] by Brian Burg

24 edits
1 delete in trunk/Source

Unreviewed, rolling out r174319.

Causes assertions in fast/profiler tests. Needs nontrivial
investigation, will take offline.

Reverted changeset:

"Web Inspector: timelines should not count time elapsed while
paused in the debugger"
https://bugs.webkit.org/show_bug.cgi?id=136351
http://trac.webkit.org/changeset/174319

12:55 PM Changeset in webkit [174321] by timothy_horton@apple.com

2 edits in trunk/Source/WebKit

Try to fix the Windows build after r174315.

WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:

12:35 PM Changeset in webkit [174320] by timothy_horton@apple.com

2 edits in trunk/Source/WebKit

Try to fix the Windows build after r174315.

WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:

12:18 PM Changeset in webkit [174319] by Brian Burg

24 edits
1 add in trunk/Source

Web Inspector: timelines should not count time elapsed while paused in the debugger
https://bugs.webkit.org/show_bug.cgi?id=136351

Reviewed by Timothy Hatcher.

Source/JavaScriptCore:

Now that we have a stopwatch to provide pause-aware timing data, we can remove the
profiler's handling of debugger pause/continue callbacks. The timeline agent accounts
for debugger pauses by pausing and resuming the stopwatch.

API/JSProfilerPrivate.cpp:

(JSStartProfiling): Use a fresh stopwatch when profiling from the JSC API.

inspector/ScriptDebugServer.cpp:

(Inspector::ScriptDebugServer::handlePause):

profiler/LegacyProfiler.cpp:

(JSC::LegacyProfiler::profiler): Use nullptr.
(JSC::LegacyProfiler::startProfiling): Hand off a stopwatch to the profile generator.
(JSC::LegacyProfiler::stopProfiling): Use nullptr.
(JSC::LegacyProfiler::didPause): Deleted.
(JSC::LegacyProfiler::didContinue): Deleted.

profiler/LegacyProfiler.h:
profiler/ProfileGenerator.cpp: Remove debugger pause/continue callbacks and the

timestamp member that was used to track time elapsed by the debugger. Just use the
stopwatch's elapsed times to generate start/elapsed times for function calls.
(JSC::ProfileGenerator::create):
(JSC::ProfileGenerator::ProfileGenerator):
(JSC::ProfileGenerator::beginCallEntry):
(JSC::ProfileGenerator::endCallEntry):
(JSC::ProfileGenerator::didPause): Deleted.
(JSC::ProfileGenerator::didContinue): Deleted.

profiler/ProfileGenerator.h:

Source/WebCore:

To avoid counting time elapsed while the debugger is paused, timeline records should
keep track of time elapsed since the start of timeline capturing, rather than wall clock
timestamps. We can easily compute elapsed time by sharing Stopwatch instance among
all timeline record-generating code. The stopwatch is paused while the debugger is paused,
so subsequent time measurements will not include time elapsed while the debugger is paused.

Agents use the shared stopwatch to generate timestamps if the timeline agent is active
(i.e., a timeline recording is being captured). If not, use a zero timestamp since the timing data is only revealed through the Timeline interface.

This refactoring is safe because start and end times are only used to graph records; the
timestamp's actual value is irrelevant and is not displayed in the user interface. Date
timestamps are still included with network-related records as part of their header data.

No new tests, because we cannot reliably test timing changes induced by debugger pauses.
It is possible for records to accrue time before the debugger pauses or after it resumes.

inspector/InspectorCSSAgent.cpp: Remove unused include.
inspector/InspectorPageAgent.cpp: Use timestamps from the shared stopwatch.

(WebCore::InspectorPageAgent::timestamp):
(WebCore::InspectorPageAgent::domContentEventFired):
(WebCore::InspectorPageAgent::loadEventFired):

inspector/InspectorPageAgent.h:
inspector/InspectorResourceAgent.cpp: Use timestamps from the shared stopwatch.

(WebCore::InspectorResourceAgent::timestamp):
(WebCore::InspectorResourceAgent::willSendRequest):
(WebCore::InspectorResourceAgent::didReceiveResponse):
(WebCore::InspectorResourceAgent::didReceiveData):
(WebCore::InspectorResourceAgent::didFinishLoading):
(WebCore::InspectorResourceAgent::didFailLoading):
(WebCore::InspectorResourceAgent::didLoadResourceFromMemoryCache):
(WebCore::InspectorResourceAgent::willSendWebSocketHandshakeRequest):
(WebCore::InspectorResourceAgent::didReceiveWebSocketHandshakeResponse):
(WebCore::InspectorResourceAgent::didCloseWebSocket):
(WebCore::InspectorResourceAgent::didReceiveWebSocketFrame):
(WebCore::InspectorResourceAgent::didSendWebSocketFrame):
(WebCore::InspectorResourceAgent::didReceiveWebSocketFrameError):

inspector/InspectorResourceAgent.h:
inspector/InspectorTimelineAgent.cpp: Add calls to reset, start, and stop the stopwatch.

(WebCore::InspectorTimelineAgent::didCreateFrontendAndBackend):
(WebCore::InspectorTimelineAgent::internalStart):
(WebCore::InspectorTimelineAgent::internalStop):
(WebCore::startProfiling):
(WebCore::InspectorTimelineAgent::startFromConsole):
(WebCore::InspectorTimelineAgent::willCallFunction):
(WebCore::InspectorTimelineAgent::willEvaluateScript):
(WebCore::InspectorTimelineAgent::didPause):
(WebCore::InspectorTimelineAgent::didContinue):
(WebCore::InspectorTimelineAgent::InspectorTimelineAgent):
(WebCore::InspectorTimelineAgent::timestamp):
(WebCore::TimelineTimeConverter::reset): Deleted.

inspector/InspectorTimelineAgent.h: Make timestamp() public, and remove old timepieces.

(WebCore::TimelineTimeConverter::TimelineTimeConverter): Deleted.
(WebCore::TimelineTimeConverter::fromMonotonicallyIncreasingTime): Deleted.
(WebCore::InspectorTimelineAgent::timeConverter): Deleted.

inspector/TimelineRecordFactory.cpp:

Source/WebInspectorUI:

Don't update the timeline's current time when the debugger is paused.

Start and end times for timeline records are now in seconds elapsed since timeline
recording started, rather than milliseconds since the epoch. Add a workaround to
preserve compatibility with old backends.

UserInterface/Controllers/TimelineManager.js:

(WebInspector.TimelineManager.prototype.capturingStarted):
(WebInspector.TimelineManager.prototype.eventRecorded.processRecord):
(WebInspector.TimelineManager.prototype.eventRecorded):

UserInterface/Views/TimelineContentView.js:

(WebInspector.TimelineContentView.prototype._debuggerPaused):
(WebInspector.TimelineContentView.prototype._debuggerResumed):

Source/WTF:

WTF.vcxproj/WTF.vcxproj:
WTF.vcxproj/WTF.vcxproj.filters:
WTF.xcodeproj/project.pbxproj:
wtf/CMakeLists.txt:
wtf/Stopwatch.h: Added. This implements a refcounted monotonic stopwatch.

(WTF::Stopwatch::reset):
(WTF::Stopwatch::start):
(WTF::Stopwatch::stop):

10:18 AM Changeset in webkit [174318] by fpizlo@apple.com

24 edits
6 adds in trunk

FTL should sink PutLocals
https://bugs.webkit.org/show_bug.cgi?id=137168

Reviewed by Oliver Hunt.
Source/JavaScriptCore:

We've known for a while that our PutLocal situation was sub-optimal. We emit them anytime we
"pass" arguments to an inlined function call, because we need to enable the runtime to grab
those arguments when doing foo.arguments where foo is inlined: our engine doesn't deoptimize
in that case but rather just relies on the arguments being flushed (i.e. a copy of their
values is spilled) at a well-known place in a well-known format.

The PutLocals incur two costs: (1) they are store instructions and stores ain't free, and (2)
they look like escaping sites and so they inhibit object allocation sinking.

But in most cases, the PutLocals are unnecessary because the inlined code never performs any
side effect that could transitively lead to function.arguments. Even if the inlined code
could do such a side effect, it may be on a rare path so there is no need to penalize the
entire function.

This patch implements one solution to the PutLocal problem: it aggressively sinks PutLocals
to the latest possible point. This is even more aggressive than the object allocation
sinking. That sinking algorithm avoids creating situations where an object could be
materialized more than one along any path. PutLocal sinking, on the other hand, doesn't avoid
this at all - both to make the phase cheaper and simpler and to make it more aggressive.
Every PutLocal is sunk no matter what.

The upside of this patch is that it eliminates many PutLocals: many of them are sunk "past
their death", thus eliminating them completely. Others are sunk to rare paths. This enables a
lot of object allocation sinking and it removes a lot of pointless store instructions.

It also has downsites. Sinking PutLocals increases register pressure because it increases the
live ranges of things like inlined arguments.

This patch is a net performance win in its current form: 1% SunSpider regression, 2% OctaneV2
progression, 0.6% Kraken regression, 1% AsmBench progression, and 0.5% CompressionBench
regression. The biggest win is on Octane/raytrace, which improves by 27%.

Relanding after fixing internal builds. We have to be careful about implicit casts from int64
to int32.

CMakeLists.txt:
JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
JavaScriptCore.xcodeproj/project.pbxproj:
bytecode/CodeBlock.h:
bytecode/Operands.h:

(JSC::Operands::dump): Deleted.

bytecode/OperandsInlines.h:

(JSC::Traits>::dump):

bytecode/VirtualRegister.h:

(JSC::VirtualRegister::isHeader):

dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):

dfg/DFGClobberSet.h:

(JSC::DFG::ClobberSetAdd::operator()):
(JSC::DFG::ClobberSetOverlaps::operator()):

dfg/DFGClobberize.h:

(JSC::DFG::clobberize):
(JSC::DFG::NoOpClobberize::operator()):
(JSC::DFG::CheckClobberize::operator()):
(JSC::DFG::AbstractHeapOverlaps::operator()):
(JSC::DFG::ReadMethodClobberize::operator()):
(JSC::DFG::WriteMethodClobberize::operator()):
(JSC::DFG::DefMethodClobberize::operator()):

dfg/DFGFlushFormat.h:

(JSC::DFG::merge):

dfg/DFGGraph.cpp:

(JSC::DFG::Graph::Graph):

dfg/DFGGraph.h:

(JSC::DFG::Graph::capturedVarsFor):

dfg/DFGObjectAllocationSinkingPhase.cpp:

(JSC::DFG::ObjectAllocationSinkingPhase::determineMaterializationPoints):
(JSC::DFG::ObjectAllocationSinkingPhase::placeMaterializationPoints):

dfg/DFGPlan.cpp:

(JSC::DFG::Plan::compileInThreadImpl):

dfg/DFGPreciseLocalClobberize.h: Added.

(JSC::DFG::PreciseLocalClobberizeAdaptor::PreciseLocalClobberizeAdaptor):
(JSC::DFG::PreciseLocalClobberizeAdaptor::read):
(JSC::DFG::PreciseLocalClobberizeAdaptor::write):
(JSC::DFG::PreciseLocalClobberizeAdaptor::def):
(JSC::DFG::PreciseLocalClobberizeAdaptor::callIfAppropriate):
(JSC::DFG::PreciseLocalClobberizeAdaptor::readTop):
(JSC::DFG::PreciseLocalClobberizeAdaptor::writeTop):
(JSC::DFG::forEachLocalReadByUnwind):
(JSC::DFG::preciseLocalClobberize):

dfg/DFGPutLocalSinkingPhase.cpp: Added.

(JSC::DFG::performPutLocalSinking):

dfg/DFGPutLocalSinkingPhase.h: Added.
dfg/DFGSSACalculator.h:

(JSC::DFG::SSACalculator::computePhis):

dfg/DFGValidate.cpp:

Source/WTF:

Make the set bits of a BitVector iterable.

wtf/BitVector.h:

(WTF::BitVector::SetBitsIterable::SetBitsIterable):
(WTF::BitVector::SetBitsIterable::iterator::iterator):
(WTF::BitVector::SetBitsIterable::iterator::operator*):
(WTF::BitVector::SetBitsIterable::iterator::operator++):
(WTF::BitVector::SetBitsIterable::iterator::operator==):
(WTF::BitVector::SetBitsIterable::iterator::operator!=):
(WTF::BitVector::SetBitsIterable::begin):
(WTF::BitVector::SetBitsIterable::end):
(WTF::BitVector::setBits):

LayoutTests:

js/regress/elidable-new-object-then-call-expected.txt: Added.
js/regress/elidable-new-object-then-call.html: Added.
js/regress/script-tests/elidable-new-object-then-call.js: Added.

(sumOfArithSeries):
(bar):
(foo):

3:04 AM Changeset in webkit [174317] by Csaba Osztrogonác

2 edits in trunk/Tools

[jhbuild] Simplify platform detection in update-webkit-libs-jhbuild
https://bugs.webkit.org/show_bug.cgi?id=137390

Reviewed by Carlos Garcia Campos.

Scripts/update-webkit-libs-jhbuild:

2:07 AM Changeset in webkit [174316] by Carlos Garcia Campos

2 edits in trunk/Source/WebKit2

Unreviewed. Add missing inspector files to compilation.

PlatformGTK.cmake: Add javascript sources in

WebInspectorUI/UserInterface/External/Esprima to the list of
inspector files.

1:47 AM Changeset in webkit [174315] by timothy_horton@apple.com

17 edits
20 adds in trunk

Make it possible to test page overlays
https://bugs.webkit.org/show_bug.cgi?id=137339

Reviewed by Dan Bernstein.

Tests: pageoverlay/overlay-installation.html

pageoverlay/overlay-large-document-scrolled.html
pageoverlay/overlay-large-document.html

Do some initial work to make page overlays testable.
There are many more tests to be written, but this lays the groundwork.

WebCore.exp.in:
WebCore.xcodeproj/project.pbxproj:
WebCore.vcxproj/WebCoreTestSupport.vcxproj:
WebCore.vcxproj/WebCoreTestSupport.vcxproj.filters:
CMakeLists.txt:

Add MockPageOverlayClient.

platform/graphics/GraphicsLayer.h:
page/PageOverlayController.h:
page/PageOverlayController.cpp:

(WebCore::PageOverlayController::shouldSkipLayerInDump):
Don't skip PageOverlayController-owned layers in the layer tree dump if the
layerTreeAsText behavior says that we should include them.

platform/graphics/GraphicsLayer.cpp:

(WebCore::dumpChildren):

platform/graphics/GraphicsLayerClient.h:

(WebCore::GraphicsLayerClient::shouldSkipLayerInDump):

rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::shouldSkipLayerInDump):

rendering/RenderLayerBacking.h:

Pass the LayerTreeAsTextBehavior through shouldSkipLayerInDump.

testing/Internals.cpp:

(WebCore::Internals::resetToConsistentState):
Uninstall all page overlays when resetting to a consistent state.

(WebCore::Internals::installMockPageOverlay):
(WebCore::Internals::pageOverlayLayerTreeAsText):
Expose two new internals functions.
installMockPageOverlay takes "view" or "document", allowing script
to choose the appropriate overlay type.
pageOverlayLayerTreeAsText dumps both view and document-relative
overlays, from each overlay container layer.

testing/Internals.h:
testing/Internals.idl:

Fix some typos.

testing/MockPageOverlayClient.cpp: Added.

(WebCore::MockPageOverlayClient::shared):
(WebCore::MockPageOverlayClient::MockPageOverlayClient):
(WebCore::MockPageOverlayClient::installOverlay):
(WebCore::MockPageOverlayClient::uninstallAllOverlays):
(WebCore::MockPageOverlayClient::layerTreeAsText):
(WebCore::MockPageOverlayClient::pageOverlayDestroyed):
(WebCore::MockPageOverlayClient::willMoveToPage):
(WebCore::MockPageOverlayClient::didMoveToPage):
When the overlay is parented, mark it as needing repaint.
Future tests might want to test overlays without content,
but for now this is a reasonable default behavior.

(WebCore::MockPageOverlayClient::drawRect):
Paint the overlay rects as described in the LayoutTests ChangeLog.

(WebCore::MockPageOverlayClient::mouseEvent):
(WebCore::MockPageOverlayClient::didScrollFrame):
(WebCore::MockPageOverlayClient::copyAccessibilityAttributeStringValueForPoint):
(WebCore::MockPageOverlayClient::copyAccessibilityAttributeBoolValueForPoint):
(WebCore::MockPageOverlayClient::copyAccessibilityAttributeNames):

testing/MockPageOverlayClient.h: Added.

pageoverlay/overlay-installation.html: Added.

Add a test which just installs one view-relative and one document-relative
overlay, and dumps the layer tree and pixel results. The mock overlay
strokes a blue rectangle (inset a little from the overlay bounds) for
view-relative overlays, and a green rectangle (inset a bit more) for
document-relative overlays.

pageoverlay/overlay-large-document.html: Added.
pageoverlay/overlay-large-document-scrolled.html: Added.

Tests that do the same as the -installation test, but with a larger document;
the view-relative overlay should be the same size (or slightly smaller,
because we have scrollbars now), but the document-relative overlay should
be the size of the document. The second test scrolls to maxX, maxY, and
the document-relative overlay should scroll along with it, while the
view-relative overlay should remain fixed.

pageoverlay/overlay-installation-expected.txt: Added.
pageoverlay/overlay-large-document-expected.txt: Added.
pageoverlay/overlay-large-document-scrolled-expected.txt: Added.

"Normal" layer tree expectations.

platform/mac-wk1/pageoverlay/overlay-installation-expected.png: Added.
platform/mac-wk1/pageoverlay/overlay-installation-expected.txt: Added.
platform/mac-wk1/pageoverlay/overlay-large-document-expected.png: Added.
platform/mac-wk1/pageoverlay/overlay-large-document-expected.txt: Added.
platform/mac-wk1/pageoverlay/overlay-large-document-scrolled-expected.png: Added.
platform/mac-wk1/pageoverlay/overlay-large-document-scrolled-expected.txt: Added.

Expected results for WebKit1 differ for view-relative overlays, because
we don't currently hook up view-relative overlays for WebKit1.

platform/mac/pageoverlay/overlay-installation-expected.png: Added.
platform/mac/pageoverlay/overlay-large-document-expected.png: Added.
platform/mac/pageoverlay/overlay-large-document-scrolled-expected.png: Added.

"Normal" pixel dump expectations.

1:37 AM Changeset in webkit [174314] by Carlos Garcia Campos

14 edits
2 adds in trunk/Source/WebCore

Move DragController::createFragmentFromDragData implementation to the editor
https://bugs.webkit.org/show_bug.cgi?id=136819

Reviewed by Darin Adler.

Make Editor::webContentFromPasteboard() common to all ports and
add a implementation for every port.

PlatformWin.cmake: Add new files to compilation.
WebCore.vcxproj/WebCore.vcxproj: Ditto.
editing/Editor.cpp:

(WebCore::Editor::pasteWithPasteboard): Move to EditorWin.cpp
since this is only used by windows port.

editing/Editor.h:
editing/efl/EditorEfl.cpp:

(WebCore::Editor::webContentFromPasteboard):

editing/gtk/EditorGtk.cpp:

(WebCore::Editor::webContentFromPasteboard):

editing/win/EditorWin.cpp: Added.

(WebCore::Editor::pasteWithPasteboard):
(WebCore::Editor::webContentFromPasteboard):

page/DragController.cpp:

(WebCore::documentFragmentFromDragData): Use the editor instead of
createFragmentFromDragData() that has been removed. Also made this
method a static funtion again.

page/DragController.h:
page/efl/DragControllerEfl.cpp: Remove createFragmentFromDragData().
page/gtk/DragControllerGtk.cpp: Ditto.
page/mac/DragControllerMac.mm: Ditto.
page/win/DragControllerWin.cpp: Ditto.
platform/Pasteboard.h:

(WebCore::Pasteboard::dragDataMap): Add a getter for m_dragDataMap
as required by Editor::webContentFromPasteboard for windows.

1:30 AM Changeset in webkit [174313] by Chris Dumez

6 edits in trunk/Source/WebCore

Use is<>() / downcast<>() for CSS StyleProperties
https://bugs.webkit.org/show_bug.cgi?id=137398

Reviewed by Benjamin Poulain.

Use is<>() / downcast<>() for CSS StyleProperties subclasses.

No new tests, no behavior change.

css/StyleProperties.cpp:

(WebCore::StyleProperties::immutableCopyIfNeeded):
(WebCore::MutableStyleProperties::MutableStyleProperties):
(WebCore::StyleProperties::hasCSSOMWrapper):

css/StyleProperties.h:

(WebCore::StyleProperties::PropertyReference::propertyMetadata):
(WebCore::StyleProperties::PropertyReference::propertyValue):
(WebCore::StyleProperties::propertyCount):
(WebCore::StyleProperties::deref):
(WebCore::StyleProperties::findPropertyIndex):
(isType):
(WebCore::toMutableStyleProperties): Deleted.
(WebCore::toImmutableStyleProperties): Deleted.

css/StyleRule.cpp:

(WebCore::StyleRule::mutableProperties):
(WebCore::StyleRulePage::mutableProperties):
(WebCore::StyleRuleFontFace::mutableProperties):

css/WebKitCSSKeyframeRule.cpp:

(WebCore::StyleKeyframe::mutableProperties):

dom/StyledElement.cpp:

(WebCore::StyledElement::ensureMutableInlineStyle):
(WebCore::StyledElement::setInlineStyleFromString):

1:05 AM Changeset in webkit [174312] by roger_fong@apple.com

2 edits in trunk/LayoutTests

[Windows] Skip remaining failing media tests after adding audio devices to the bots.

platform/win/TestExpectations:

12:56 AM Changeset in webkit [174311] by zandobersek@gmail.com

2 edits in trunk/Source/WebCore

[TexMap] Clean up GraphicsLayerTextureMapper::prepareBackingStoreIfNeeded()
https://bugs.webkit.org/show_bug.cgi?id=137263

Reviewed by Darin Adler.

platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:

(WebCore::GraphicsLayerTextureMapper::prepareBackingStoreIfNeeded): Clean up
the method a bit. When the backing store will not be in use the change mask
should only get updated if there was a backing store present beforehand.

12:46 AM Changeset in webkit [174310] by Carlos Garcia Campos

2 edits in trunk/Tools

[GTK] Do not generate webkit2gtk-tests-resources.gresource unconditionally
https://bugs.webkit.org/show_bug.cgi?id=137391

Reviewed by Martin Robinson.

Add a custom command to only re-generate
webkit2gtk-tests-resources.gresource when any of its dependencies changes.

TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:

12:35 AM Changeset in webkit [174309] by Carlos Garcia Campos

2 edits in trunk/Tools

[GTK] generate-gtkdoc crashes when generating HTML due to encoding issues
https://bugs.webkit.org/show_bug.cgi?id=135502

Reviewed by Martin Robinson.

When writing to stdout/stderr fails due to a UnicodeDecodeError
exception, try again without encoding the output.

gtk/gtkdoc.py:

(GTKDoc._run_command):

12:14 AM Changeset in webkit [174308] by zandobersek@gmail.com

2 edits in trunk/Source/WebCore

[TexMap] Remove QDoc comments in GraphicsLayerTextureMapper
https://bugs.webkit.org/show_bug.cgi?id=137264

Reviewed by Andreas Kling.

Remove all the QDoc comments in the class that were
left over by the Qt port.

platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:

(WebCore::GraphicsLayerTextureMapper::setNeedsDisplay):

Oct 3, 2014:

7:41 PM Changeset in webkit [174307] by Yusuke Suzuki

2 edits
68 adds in trunk/LayoutTests

Introduce Promise A+ tests into WebKit
https://bugs.webkit.org/show_bug.cgi?id=136878

Reviewed by Sam Weinig.

To ensure WebKit Promise stability, introducing Promise A+ tests[1] into WebKit.
It's also used to test V8 Promise[2].
So the tests guarantee that WebKit Promise's spec validity and interchangeability
to the other browser's Promise implementation.

Promise A+ tests assumes that it works on the Node.js environment. To work it on
LayoutTests correctly, we need to transform Node.js styled JavaScript code into
browser styled code. In this patch, we use browserify[3] to transform the test code.
Through transforming pipeline, some dependent JS code is bundled into the produced code.
So added SinonJS[4] and browserify's license files into the test directory.

And tests assume that it is used with Mocha[5] test runner. So introducing mocha.js and
added LICENSE file into this directory.

And since Promises/A+ 2.3.3 has many tests, it consumes much time (13s in GTK debug build).
So mark it as a Slow test.

[1]: https://github.com/promises-aplus/promises-tests
[2]: https://code.google.com/p/v8/source/browse#svn%2Ftrunk%2Ftest%2Fpromises-aplus
[3]: http://browserify.org/
[4]: http://sinonjs.org/
[5]: http://visionmedia.github.io/mocha/

TestExpectations:
js/promises-tests/README: Added.
js/promises-tests/browserify-entry-point.js: Added.

(.):

js/promises-tests/browserify.LICENSE: Added.
js/promises-tests/mocha.LICENSE: Added.
js/promises-tests/promises-tests-2-1-2-expected.txt: Added.
js/promises-tests/promises-tests-2-1-2.html: Added.
js/promises-tests/promises-tests-2-1-3-expected.txt: Added.
js/promises-tests/promises-tests-2-1-3.html: Added.
js/promises-tests/promises-tests-2-2-1-expected.txt: Added.
js/promises-tests/promises-tests-2-2-1.html: Added.
js/promises-tests/promises-tests-2-2-2-expected.txt: Added.
js/promises-tests/promises-tests-2-2-2.html: Added.
js/promises-tests/promises-tests-2-2-3-expected.txt: Added.
js/promises-tests/promises-tests-2-2-3.html: Added.
js/promises-tests/promises-tests-2-2-4-expected.txt: Added.
js/promises-tests/promises-tests-2-2-4.html: Added.
js/promises-tests/promises-tests-2-2-5-expected.txt: Added.
js/promises-tests/promises-tests-2-2-5.html: Added.
js/promises-tests/promises-tests-2-2-6-expected.txt: Added.
js/promises-tests/promises-tests-2-2-6.html: Added.
js/promises-tests/promises-tests-2-2-7-expected.txt: Added.
js/promises-tests/promises-tests-2-2-7.html: Added.
js/promises-tests/promises-tests-2-3-1-expected.txt: Added.
js/promises-tests/promises-tests-2-3-1.html: Added.
js/promises-tests/promises-tests-2-3-2-expected.txt: Added.
js/promises-tests/promises-tests-2-3-2.html: Added.
js/promises-tests/promises-tests-2-3-3-expected.txt: Added.
js/promises-tests/promises-tests-2-3-3.html: Added.
js/promises-tests/promises-tests-2-3-4-expected.txt: Added.
js/promises-tests/promises-tests-2-3-4.html: Added.
js/promises-tests/promises-tests.LICENSE: Added.
js/promises-tests/promises-tests.js: Added.

(.):

js/promises-tests/promises-tests/.gitignore: Added.
js/promises-tests/promises-tests/.jshintrc: Added.
js/promises-tests/promises-tests/.npmignore: Added.
js/promises-tests/promises-tests/LICENSE.txt: Added.
js/promises-tests/promises-tests/README.md: Added.
js/promises-tests/promises-tests/lib/cli.js: Added.

(getAdapterFilePath):
(adapterObjectFromFilePath):

js/promises-tests/promises-tests/lib/getMochaOpts.js: Added.

(module.exports):

js/promises-tests/promises-tests/lib/programmaticRunner.js: Added.

(normalizeAdapter.adapter.resolved):
(normalizeAdapter.adapter.rejected):
(normalizeAdapter):
(.cb):
(.):
(module.exports):
(module.exports.mocha):

js/promises-tests/promises-tests/lib/tests/2.1.2.js: Added.

(.):

js/promises-tests/promises-tests/lib/tests/2.1.3.js: Added.

(.):

js/promises-tests/promises-tests/lib/tests/2.2.1.js: Added.
js/promises-tests/promises-tests/lib/tests/2.2.2.js: Added.

(.):

js/promises-tests/promises-tests/lib/tests/2.2.3.js: Added.

(.):

js/promises-tests/promises-tests/lib/tests/2.2.4.js: Added.

(.):

js/promises-tests/promises-tests/lib/tests/2.2.5.js: Added.
js/promises-tests/promises-tests/lib/tests/2.2.6.js: Added.

(.return.if):
(callbackAggregator):
(.):

js/promises-tests/promises-tests/lib/tests/2.2.7.js: Added.

(.):

js/promises-tests/promises-tests/lib/tests/2.3.1.js: Added.

(.):

js/promises-tests/promises-tests/lib/tests/2.3.2.js: Added.

(.):
(testPromiseResolution):

js/promises-tests/promises-tests/lib/tests/2.3.3.js: Added.

(.):
(testPromiseResolution):
(testCallingResolvePromiseRejectsWith):
(testCallingRejectPromiseRejectsWith):
(describe):

js/promises-tests/promises-tests/lib/tests/2.3.4.js: Added.

(.):

js/promises-tests/promises-tests/lib/tests/helpers/reasons.js: Added.

(exports.string_appeared_here):
(exports.string_appeared_here.return.then):

js/promises-tests/promises-tests/lib/tests/helpers/testThreeCases.js: Added.

(.specify):
(.):
(exports.testFulfilled):
(exports.testRejected):

js/promises-tests/promises-tests/lib/tests/helpers/thenables.js: Added.

(exports.fulfilled.string_appeared_here.return.then):
(exports.fulfilled.string_appeared_here):
(exports.fulfilled.string_appeared_here.):
(exports.fulfilled.get string_appeared_here.return.then):
(exports.fulfilled.get string_appeared_here):
(exports.rejected.string_appeared_here.return.then):
(exports.rejected.string_appeared_here):
(exports.rejected.string_appeared_here.):
(exports.rejected.get string_appeared_here.return.then):
(exports.rejected.get string_appeared_here):

js/promises-tests/promises-tests/package.json: Added.
js/promises-tests/promises-tests/test/getMochaOptsTest.js: Added.
js/promises-tests/resources/adapter.js: Added.

(LayoutTestsReporter.runner):
(window.adapter.resolved):
(window.adapter.rejected):
(window.adapter.deferred):

js/promises-tests/resources/mocha.js: Added.

(.):

js/promises-tests/sinonjs.LICENSE: Added.

5:04 PM Changeset in webkit [174306] by bshafiei@apple.com

5 edits in branches/safari-600.1.4.11-branch/Source

Versioning.

5:01 PM Changeset in webkit [174305] by bshafiei@apple.com

1 copy in tags/Safari-600.1.4.11.12

New tag.

4:48 PM Changeset in webkit [174304] by ap@apple.com

3 edits in trunk/Tools/QueueStatusServer

Bugzilla status bubble displays an exception showing attachment 175738
https://bugs.webkit.org/show_bug.cgi?id=137410

Reviewed by Tim Horton.

QueueStatusServer/app.yaml: Update version.

QueueStatusServer/handlers/statusbubble.py: (StatusBubble._build_bubble):

Don't fail even if expected status message is missing.

QueueStatusServer/model/patchlog.py: (PatchLog): Quick unrelated fix - define

the field in the same way it's defined in QueueStatus table.

4:36 PM Changeset in webkit [174303] by ap@apple.com

1 edit in trunk/Tools/ChangeLog

Bugzilla status bubble displays an exception showing attachment 175738
https://bugs.webkit.org/show_bug.cgi?id=137410

Reviewed by Tim Horton.

QueueStatusServer/app.yaml: Update version.

QueueStatusServer/handlers/statusbubble.py: (StatusBubble._build_bubble):

Don't fail even if expected status message is missing.

QueueStatusServer/model/patchlog.py: (PatchLog): Quick unrelated fix - define

the field in the same way it's defined in QueueStatus table.

4:27 PM Changeset in webkit [174302] by ap@apple.com

3 edits in trunk/Tools

Record latest message in PatchLog for quick access
https://bugs.webkit.org/show_bug.cgi?id=137405

Fixing a typo.

QueueStatusServer/app.yaml:
QueueStatusServer/handlers/releasepatch.py:

4:22 PM Changeset in webkit [174301] by msaboff@apple.com

2 edits in trunk/Source/JavaScriptCore

REGRESSION(r174216): CodeBlock::dumpByteCodes crashes on op_push_name_scope
https://bugs.webkit.org/show_bug.cgi?id=137412

Reviewed by Mark Lam.

Added support for the JSNameScope::type opcode parameter in dumpBytecode().

bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dumpBytecode):

4:17 PM Changeset in webkit [174300] by Chris Dumez

63 edits in trunk/Source/WebCore

Use is<>() / downcast<>() for CSSValue subclasses
https://bugs.webkit.org/show_bug.cgi?id=137381

Reviewed by Benjamin Poulain.

Use is<>() / downcast<>() for CSSValue subclasses.

No new tests, no behavior change.

css/CSSAspectRatioValue.h:
css/CSSBorderImageSliceValue.h:
css/CSSCalculationValue.cpp:

(WebCore::CSSCalcExpressionNodeParser::parseValue):

css/CSSCalculationValue.h:
css/CSSCanvasValue.h:
css/CSSComputedStyleDeclaration.cpp:

(WebCore::getBorderRadiusShorthandValue):
(WebCore::ComputedStyleExtractor::propertyMatches):

css/CSSCrossfadeValue.cpp:

(WebCore::subimageKnownToBeOpaque):

css/CSSCrossfadeValue.h:
css/CSSCursorImageValue.cpp:

(WebCore::CSSCursorImageValue::~CSSCursorImageValue):
(WebCore::CSSCursorImageValue::updateIfSVGCursorIsUsed):
(WebCore::CSSCursorImageValue::cachedImage):
(WebCore::CSSCursorImageValue::cachedOrPendingImage):
(WebCore::CSSCursorImageValue::isSVGCursor):

css/CSSCursorImageValue.h:
css/CSSFilterImageValue.h:
css/CSSFontFaceSrcValue.h:
css/CSSFontFeatureValue.h:
css/CSSFontSelector.cpp:

(WebCore::CSSFontSelector::addFontFaceRule):

css/CSSFontValue.h:
css/CSSFunctionValue.h:
css/CSSGradientValue.cpp:

(WebCore::CSSGradientValue::image):
(WebCore::CSSGradientValue::gradientWithStylesResolved):

css/CSSGradientValue.h:
css/CSSGridLineNamesValue.h:
css/CSSGridTemplateAreasValue.h:
css/CSSImageGeneratorValue.cpp:

(WebCore::CSSImageGeneratorValue::image):
(WebCore::CSSImageGeneratorValue::isFixedSize):
(WebCore::CSSImageGeneratorValue::fixedSize):
(WebCore::CSSImageGeneratorValue::isPending):
(WebCore::CSSImageGeneratorValue::knownToBeOpaque):
(WebCore::CSSImageGeneratorValue::loadSubimages):
(WebCore::CSSImageGeneratorValue::subimageIsPending):
(WebCore::CSSImageGeneratorValue::cachedImageForCSSValue):

css/CSSImageGeneratorValue.h:
css/CSSImageSetValue.cpp:

(WebCore::CSSImageSetValue::fillImageSet):

css/CSSImageSetValue.h:
css/CSSImageValue.h:
css/CSSInheritedValue.h:
css/CSSInitialValue.h:
css/CSSLineBoxContainValue.h:
css/CSSParser.cpp:

(WebCore::CSSParser::parseColor):
(WebCore::CSSParser::addFillValue):
(WebCore::CSSParser::addAnimationValue):
(WebCore::CSSParser::parse3ValuesFillPosition):
(WebCore::CSSParser::parseFillPosition):
(WebCore::CSSParser::parseFillRepeat):
(WebCore::gridMissingGridPositionValue):
(WebCore::CSSParser::parseGridTemplateRowsAndAreas):
(WebCore::CSSParser::parseBasicShapeCircle):
(WebCore::CSSParser::parseBasicShapeEllipse):
(WebCore::CSSParser::parseDeprecatedGradient):
(WebCore::CSSParser::parseDeprecatedRadialGradient):
(WebCore::CSSParser::parseRadialGradient):
(WebCore::CSSParser::createFontFaceRule):

css/CSSPrimitiveValue.h:
css/CSSReflectValue.h:
css/CSSShadowValue.h:
css/CSSTimingFunctionValue.h:
css/CSSToStyleMap.cpp:

(WebCore::CSSToStyleMap::mapFillAttachment):
(WebCore::CSSToStyleMap::mapFillClip):
(WebCore::CSSToStyleMap::mapFillComposite):
(WebCore::CSSToStyleMap::mapFillBlendMode):
(WebCore::CSSToStyleMap::mapFillOrigin):
(WebCore::CSSToStyleMap::mapFillRepeatX):
(WebCore::CSSToStyleMap::mapFillRepeatY):
(WebCore::CSSToStyleMap::mapFillSize):
(WebCore::CSSToStyleMap::mapFillXPosition):
(WebCore::CSSToStyleMap::mapFillYPosition):
(WebCore::CSSToStyleMap::mapFillMaskSourceType):
(WebCore::CSSToStyleMap::mapAnimationDelay):
(WebCore::CSSToStyleMap::mapAnimationDirection):
(WebCore::CSSToStyleMap::mapAnimationDuration):
(WebCore::CSSToStyleMap::mapAnimationFillMode):
(WebCore::CSSToStyleMap::mapAnimationIterationCount):
(WebCore::CSSToStyleMap::mapAnimationName):
(WebCore::CSSToStyleMap::mapAnimationPlayState):
(WebCore::CSSToStyleMap::mapAnimationProperty):
(WebCore::CSSToStyleMap::mapAnimationTimingFunction):
(WebCore::CSSToStyleMap::mapNinePieceImage):
(WebCore::CSSToStyleMap::mapNinePieceImageSlice):
(WebCore::CSSToStyleMap::mapNinePieceImageQuad):
(WebCore::CSSToStyleMap::mapNinePieceImageRepeat):

css/CSSUnicodeRangeValue.h:
css/CSSValue.cpp:

(WebCore::CSSValue::isImplicitInitialValue):
(WebCore::CSSValue::addSubresourceStyleURLs):
(WebCore::CSSValue::hasFailedOrCanceledSubresources):
(WebCore::CSSValue::equals):
(WebCore::CSSValue::cssText):
(WebCore::CSSValue::destroy):
(WebCore::CSSValue::cloneForCSSOM):

css/CSSValue.h:
css/CSSValueList.h:

(WebCore::CSSValueListInspector::CSSValueListInspector):

css/DeprecatedStyleBuilder.cpp:

(WebCore::ApplyPropertyDefault::applyValue):
(WebCore::ApplyPropertyNumber::applyValue):
(WebCore::ApplyPropertyAuto::applyValue):
(WebCore::ApplyPropertyClip::applyValue):
(WebCore::ApplyPropertyColor::applyValue):
(WebCore::ApplyPropertyLength::applyValue):
(WebCore::ApplyPropertyString::applyValue):
(WebCore::ApplyPropertyBorderRadius::applyValue):
(WebCore::ApplyPropertyFillLayer::applyValue):
(WebCore::ApplyPropertyComputeLength::applyValue):
(WebCore::ApplyPropertyFont::applyValue):
(WebCore::ApplyPropertyFontFamily::applyValue):
(WebCore::ApplyPropertyFontSize::applyValue):
(WebCore::ApplyPropertyFontWeight::applyValue):
(WebCore::ApplyPropertyFontVariantLigatures::applyValue):
(WebCore::ApplyPropertyCounter::applyValue):
(WebCore::ApplyPropertyCursor::applyValue):
(WebCore::ApplyPropertyTextAlign::applyValue):
(WebCore::ApplyPropertyTextDecoration::applyValue):
(WebCore::ApplyPropertyTextDecorationSkip::applyValue):
(WebCore::ApplyPropertyMarqueeIncrement::applyValue):
(WebCore::ApplyPropertyMarqueeRepetition::applyValue):
(WebCore::ApplyPropertyMarqueeSpeed::applyValue):
(WebCore::ApplyPropertyTextUnderlinePosition::applyValue):
(WebCore::ApplyPropertyLineHeight::applyValue):
(WebCore::ApplyPropertyLineHeightForIOSTextAutosizing::applyValue):
(WebCore::ApplyPropertyWordSpacing::applyValue):
(WebCore::ApplyPropertyPageSize::applyValue):
(WebCore::ApplyPropertyTextEmphasisStyle::applyValue):
(WebCore::ApplyPropertyTextEmphasisPosition::applyValue):
(WebCore::ApplyPropertyResize::applyValue):
(WebCore::ApplyPropertyVerticalAlign::applyValue):
(WebCore::ApplyPropertyAspectRatio::applyValue):
(WebCore::ApplyPropertyZoom::applyValue):
(WebCore::ApplyPropertyDisplay::applyValue):
(WebCore::ApplyPropertyClipPath::applyValue):
(WebCore::ApplyPropertyShape::applyValue):
(WebCore::ApplyPropertyImageResolution::applyValue):
(WebCore::ApplyPropertyTextIndent::applyValue):

css/MediaList.cpp:

(WebCore::reportMediaQueryWarningIfNeeded):

css/MediaQueryEvaluator.cpp:

(WebCore::compareAspectRatioValue):
(WebCore::numberValue):
(WebCore::orientationMediaFeatureEval):
(WebCore::evalResolution):
(WebCore::device_pixel_ratioMediaFeatureEval):
(WebCore::resolutionMediaFeatureEval):
(WebCore::computeLength):
(WebCore::view_modeMediaFeatureEval):
(WebCore::pointerMediaFeatureEval):

css/SVGCSSComputedStyleDeclaration.cpp:

(WebCore::strokeDashArrayToCSSValueList):
(WebCore::ComputedStyleExtractor::svgPropertyValue):

css/SVGCSSStyleSelector.cpp:

(WebCore::StyleResolver::applySVGProperty):

css/SourceSizeList.cpp:

(WebCore::computeLength):

css/StyleProperties.cpp:

(WebCore::StyleProperties::getLayeredShorthandValue):

css/StyleResolver.cpp:

(WebCore::extractDirectionAndWritingMode):
(WebCore::createGridTrackSize):
(WebCore::createGridTrackList):
(WebCore::createGridPosition):
(WebCore::StyleResolver::parseSnapCoordinate):
(WebCore::StyleResolver::parseSnapPoints):
(WebCore::StyleResolver::applyProperty):
(WebCore::StyleResolver::styleImage):
(WebCore::StyleResolver::generatedOrPendingFromValue):
(WebCore::StyleResolver::createFilterOperations):

css/TransformFunctions.cpp:

(WebCore::transformsForValue):

css/ViewportStyleResolver.cpp:

(WebCore::ViewportStyleResolver::getViewportArgumentValue):

css/WebKitCSSFilterValue.h:
css/WebKitCSSMatrix.cpp:

(WebCore::WebKitCSSMatrix::setMatrixValue):

css/WebKitCSSTransformValue.h:

(WebCore::toWebKitCSSTransformValue): Deleted.

editing/ApplyStyleCommand.cpp:

(WebCore::ApplyStyleCommand::computedFontSize):

editing/EditingStyle.cpp:

(WebCore::identifierForStyleProperty):
(WebCore::HTMLElementEquivalent::valueIsPresentInStyle):
(WebCore::HTMLTextDecorationEquivalent::valueIsPresentInStyle):
(WebCore::cssValueToRGBA):
(WebCore::EditingStyle::extractFontSizeDelta):
(WebCore::EditingStyle::textDirection):
(WebCore::EditingStyle::prepareToApplyAt):
(WebCore::EditingStyle::mergeStyle):
(WebCore::EditingStyle::mergeStyleFromRulesForSerialization):
(WebCore::EditingStyle::legacyFontSize):
(WebCore::EditingStyle::textDirectionForSelection):
(WebCore::StyleChange::extractTextStyles):
(WebCore::diffTextDecorations):
(WebCore::fontWeightIsBold):
(WebCore::isTransparentColorValue):

editing/EditorCommand.cpp:

(WebCore::executeToggleStyleInList):

editing/cocoa/HTMLConverter.mm:

(stringFromCSSValue):
(HTMLConverterCaches::floatPropertyValueForNode):
(HTMLConverterCaches::colorPropertyValueForNode):

editing/markup.cpp:

(WebCore::propertyMissingOrEqualToNone):

page/PageSerializer.cpp:

(WebCore::PageSerializer::retrieveResourcesForProperties):

page/animation/CSSPropertyAnimation.cpp:

(WebCore::blendFunc):

rendering/RenderTextControl.cpp:

(WebCore::RenderTextControl::adjustInnerTextStyle):

rendering/style/StylePendingImage.h:

(WebCore::StylePendingImage::cssImageValue):
(WebCore::StylePendingImage::cssCursorImageValue):
(WebCore::StylePendingImage::cssImageSetValue):

svg/SVGColor.h:
svg/SVGFontFaceElement.cpp:

(WebCore::SVGFontFaceElement::rebuildFontFace):

svg/SVGPaint.h:

4:05 PM Changeset in webkit [174299] by andersca@apple.com

2 edits in trunk/Source/WebKit2

Remove a workaround for a bug that's been fixed
https://bugs.webkit.org/show_bug.cgi?id=137411

Reviewed by Dan Bernstein.

mac/rewrite-availability-macros.sh:

3:19 PM Changeset in webkit [174298] by saambarati1@gmail.com

2 edits in trunk/Source/JavaScriptCore

Implement op_profile_type in the 32-bit baseline JIT
https://bugs.webkit.org/show_bug.cgi?id=137181

Reviewed by Michael Saboff.

Generate inline code to write to the TypeProfilerLog inside the 32-bit
baseline JIT instead of unconditionally bailing out to the slow path
for op_profile_type.

jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_profile_type):

3:07 PM Changeset in webkit [174297] by mmaxfield@apple.com

8 edits in trunk/Source/WebCore

Clean up interface to Font::expansionOpportunityCount()
https://bugs.webkit.org/show_bug.cgi?id=137355

Reviewed by Dean Jackson.

There are two overloads of Font::expansionOpportunityCount() which perform the same
operation. One overload takes a UChar*, the other takes an LChar*, and they both
take a length. This is the abstraction that StringView was designed to be. Instead
of forcing each caller to take a different overload based on if their data is
8 bit or not, allow the caller to construct a StringView and pass that into
Font::expansionOpportunityCount() instead of a raw pointer/length.

No new tests because there is no behavior change.

platform/graphics/Font.cpp:

(WebCore::Font::expansionOpportunityCountInternal): Original two functions,
renamed.
(WebCore::Font::expansionOpportunityCount): Takes a StringView, calls
expansionOpportunityCountInternal().

platform/graphics/Font.h: Update signatures.
platform/graphics/WidthIterator.cpp:

(WebCore::WidthIterator::WidthIterator): Use new signature to
Font::expansionOpportunityCount().

platform/graphics/mac/ComplexTextController.cpp:

(WebCore::ComplexTextController::ComplexTextController): Ditto.

rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlockFlow::computeInlineDirectionPositionsForSegment): Ditto.

rendering/RenderText.cpp:

(WebCore::RenderText::stringView): Accessor to encapsulate character pointer
and length.

rendering/RenderText.h: Signature of new accessor.

3:05 PM Changeset in webkit [174296] by Beth Dakin

23 edits
6 deletes in trunk

Unreviewed, rolling out r174275.
https://bugs.webkit.org/show_bug.cgi?id=137408

Build failures on the internal bots. (Requested by dethbakin
on #webkit).

Reverted changeset:

"FTL should sink PutLocals"
https://bugs.webkit.org/show_bug.cgi?id=137168
http://trac.webkit.org/changeset/174275

Patch by Commit Queue <commit-queue@webkit.org> on 2014-10-03

3:03 PM Changeset in webkit [174295] by Brent Fulgham

2 edits in trunk/Source/WebCore

[Win] Unreviewed build fix for MSVC 2013 SP 3.

The std::array initializer is not fully implemented in SP3 and causes a
build error.

platform/graphics/transforms/AffineTransform.cpp: Use old style assignment

initialization for MSVC builds until this bug is fixed.

2:46 PM Changeset in webkit [174294] by oliver@apple.com

8 edits in trunk/Source/JavaScriptCore

tearoff_arguments should always refer to the unmodified arguments register
https://bugs.webkit.org/show_bug.cgi?id=137406

Reviewed by Michael Saboff.

To simplify subsequent work, and remove unnecessary work from
actual execution this patch simply ensures that tear_off_arguments
refers to the actual unmodified arguments register.

bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitReturn):

dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_tear_off_arguments):

jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_tear_off_arguments):

llint/LLIntSlowPaths.cpp:

(JSC::LLInt::LLINT_SLOW_PATH_DECL):

llint/LowLevelInterpreter32_64.asm:
llint/LowLevelInterpreter64.asm:

2:43 PM Changeset in webkit [174293] by Chris Dumez

2 edits in trunk/Source/WTF

Add TypeCasts.h to xcodeproject
https://bugs.webkit.org/show_bug.cgi?id=137403

Reviewed by Benjamin Poulain.

Add TypeCasts.h to xcodeproject.

WTF.xcodeproj/project.pbxproj:

2:35 PM Changeset in webkit [174292] by saambarati1@gmail.com

9 edits in trunk/Source

Web Inspector: Move the computation that results in UI strings from JSC to the Web Inspector
https://bugs.webkit.org/show_bug.cgi?id=137295

Reviewed by Timothy Hatcher.

Source/JavaScriptCore:

Remove unnecessary functions and properties from JSC that are
now being computed inside the Web Inspector.

inspector/agents/InspectorRuntimeAgent.cpp:

(Inspector::InspectorRuntimeAgent::getRuntimeTypesForVariablesAtOffsets):

inspector/protocol/Runtime.json:
runtime/TypeSet.cpp:

(JSC::TypeSet::allPrimitiveTypeNames): Deleted.

runtime/TypeSet.h:

Source/WebInspectorUI:

The inspector now computes a set of properties that was previously
computed inside JSC.

This patch also addresses the weird experience of the
type of an expression claiming to be both a Number and
an Integer. This could be a bit confusing because Number
is supposed to represent Double|Integer and the previous
UI implied that Number was equivalent to Double. The new UI only
ever shows either the type of Number or Integer when showing
the type information of an expression. It never shows both Number
and Integer simultaneously to describe a single expression.

UserInterface/Models/TypeSet.js:

(WebInspector.TypeSet):
(WebInspector.TypeSet.prototype.isContainedIn):
(WebInspector.TypeSet.prototype.get primitiveTypeNames):

UserInterface/Views/TypePropertiesSection.js:

(WebInspector.TypePropertiesSection):
(WebInspector.TypePropertiesSection.prototype.onpopulate):

UserInterface/Views/TypeTokenView.js:

(WebInspector.TypeTokenView):
(WebInspector.TypeTokenView.prototype.update):
(WebInspector.TypeTokenView.prototype._shouldShowPopover):
(WebInspector.TypeTokenView.prototype._displayTypeName):

2:35 PM Changeset in webkit [174291] by ap@apple.com

6 edits in trunk/Tools

Record latest message in PatchLog for quick access
https://bugs.webkit.org/show_bug.cgi?id=137405

Reviewed by Ryosuke Niwa.

It's no SQL...

QueueStatusServer/handlers/releasepatch.py:
QueueStatusServer/handlers/updatestatus.py:
QueueStatusServer/loggers/recordpatchevent.py:
QueueStatusServer/model/patchlog.py:

2:18 PM Changeset in webkit [174290] by dfarler@apple.com

2 edits in trunk/Tools

-asan-blacklist option also renamed to generic -fsanitize-blacklist
https://bugs.webkit.org/show_bug.cgi?id=137377

Reviewed by Daniel Bates.

asan/asan.xcconfig:

-asan-blacklist -> -fsanitize-blacklist

http://llvm.org/viewvc/llvm-project?view=revision&revision=212505

1:47 PM Changeset in webkit [174289] by betravis@adobe.com

2 edits in trunk/LayoutTests

FTL should sink PutLocals
https://bugs.webkit.org/show_bug.cgi?id=137168

Patch by Filip Pizlo <fpizlo@apple.com> on 2014-10-02
Reviewed by Oliver Hunt.

js/regress/elidable-new-object-then-call-expected.txt: Added.
js/regress/elidable-new-object-then-call.html: Added.
js/regress/script-tests/elidable-new-object-then-call.js: Added.

(sumOfArithSeries):
(bar):
(foo):

1:45 PM Changeset in webkit [174288] by jer.noble@apple.com

2 edits in trunk/Source/WebKit2

Revert an accidental change introduced by r173318.

Rubber-stamped by Tim Horton.

WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::suspendPainting):
(WebKit::TiledCoreAnimationDrawingArea::resumePainting):

1:36 PM Changeset in webkit [174287] by timothy_horton@apple.com

4 edits in trunk/Source

WKWebView snapshot of Daring Fireball has the wrong color in the obscured inset
https://bugs.webkit.org/show_bug.cgi?id=137383
<rdar://problem/18535439>

Reviewed by Sam Weinig.

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::snapshotAtSize):
Use documentBackgroundColor instead of baseBackgroundColor if backgroundShouldExtendBeyondPage is set.

rendering/RenderView.cpp:

(WebCore::RenderView::paintBoxDecorations):
Use documentBackgroundColor instead of baseBackgroundColor if backgroundShouldExtendBeyondPage is set.

1:32 PM Changeset in webkit [174286] by aestes@apple.com

2 edits in trunk/Source/WebKit2

[iOS] Highlight clicked links in WKPDFView
https://bugs.webkit.org/show_bug.cgi?id=137400

Reviewed by Tim Horton.

Show a _UIHighlightView on top of clicked links for 200 ms before starting the navigation. This matches the behavior of UIWebPDFView.

UIProcess/ios/WKPDFView.mm:

(-[WKPDFView _createHighlightViewWithFrame:]): Created a _UIHighlightView with a color and border radius matching the values used by UIWebPDFView.
(-[WKPDFView annotation:wasTouchedAtPoint:controller:]): Displayed the highlight, then removed it after the navigation began.

1:29 PM Changeset in webkit [174285] by roger_fong@apple.com

2 edits in trunk/Tools

[Windows] Include batch size argument to layout tests on Windows.

BuildSlaveSupport/build.webkit.org-config/master.cfg:

(RunWebKitTests.start):
This is a speculative fix for the the inconsistent crashes we are seeing on Windows.
These crashes seem to happen on random tests though generally in a spread out fashion.
It seems possible that the DRT instance is being clobbered somehow after running too many
tests in a row so we will try to mitigate this by just forcing DRT to restart periodically.

1:28 PM Changeset in webkit [174284] by timothy_horton@apple.com

3 edits in trunk/Source/WebKit/ios

REGRESSION (r165896): UIWebView PDFs have a forced black background
https://bugs.webkit.org/show_bug.cgi?id=137387
<rdar://problem/17948411>

Reviewed by David Kilzer.

WebView/WebPDFViewPlaceholder.h:
WebView/WebPDFViewPlaceholder.mm:

(-[WebPDFViewPlaceholder layout]):
Remove an ill-advised attempt to force the PDF background color from WebKit.
The idea was that we would maintain Safari's black background except if there
were no pages in the PDF, in which case we would use white instead to avoid
having an all-black view. However, this broke clients who didn't want a black
background, because we were now forcing it to black. Also, we don't need to
maintain the black color in Safari because it doesn't use WebPDFViewPlaceholder anymore.
This wasn't an important part of the patch, in any case.

1:27 PM Changeset in webkit [174283] by dino@apple.com

5 edits in trunk/Source/WebCore

webkit-appearance: default-button styling does not set the button font color to white
https://bugs.webkit.org/show_bug.cgi?id=137399
rdar://problem/17788616

Reviewed by Dave Hyatt.

When a button is styled with -webkit-appearance: default-button, it should
use the CSSValueActivebuttontext value for its text color when the window
is active, and the normal value when the window is inactive.

Since activating (focus/blur) windows doesn't cause a style recalculation, this
is applied as a paint-time operation. However, the render tree children that
paint the text don't know that they are contained within a RenderButton
and that the button is a default type. So I added an inherited flag, similar
to what we use for visited links, to remember if we're in a button. And then
computeTextPaintStyle chooses the correct value.

We can't test this because our LayoutTest system doesn't have
an active window, and thus the default button renders like a normal
button. This should cause no regressions though. Also, the appearance is
protected behind an SPI (or Setting), so this is not exposed to the Web.

rendering/RenderTheme.cpp:

(WebCore::RenderTheme::adjustStyle): Set the flag if we're inside a default button.

rendering/TextPaintStyle.cpp:

(WebCore::computeTextPaintStyle): If we're in a default button inside an active window,
use the CSSValueActivebuttontext color.

rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::RenderStyle): Add and expose the new inherited flag: ._insideDefaultButton.
(WebCore::RenderStyle::changeRequiresRepaint): Ditto.

rendering/style/RenderStyle.h: Ditto.

1:26 PM Changeset in webkit [174282] by timothy_horton@apple.com

3 edits in trunk/Source/WebKit/ios

REGRESSION (r173265): UIWebView PDF loading is completely broken
https://bugs.webkit.org/show_bug.cgi?id=137386
<rdar://problem/18524717>

Reviewed by David Kilzer.

WebView/WebPDFViewPlaceholder.h:
WebView/WebPDFViewPlaceholder.mm:

(-[WebPDFViewPlaceholder layout]):
(-[WebPDFViewPlaceholder finishedLoadingWithDataSource:]):
Restore important code that creates the CGDataProvider and sets _didFinishLoad
and calls _doPostLoadOrUnlockTasks after finishing a load, which was haphazardly
removed in the aforementioned revision.

1:20 PM Changeset in webkit [174281] by bshafiei@apple.com

2 edits in branches/safari-600.1.4.11-branch/Source/WebCore

Merged r174277. <rdar://problem/18436044>

1:15 PM Changeset in webkit [174280] by bshafiei@apple.com

4 edits in branches/safari-600.1.4.11-branch/Source/WebCore

Merged r174244. <rdar://problem/18507382>

1:10 PM Changeset in webkit [174279] by mmaxfield@apple.com

2 edits in trunk/Source/WebCore

[SVG -> OTF Converter] Support non-BMP codepoints
https://bugs.webkit.org/show_bug.cgi?id=137097

Patch by Myles C. Maxfield <mmaxfield@apple.com> on 2014-09-28
Reviewed by Darin Adler.

This patch has two pieces:

1) Moves write16(), overwrite32() and overwrite16() inside SVGToOTFFontConverter. This
is so that we don't have to keep passing around references to m_result everywhere. Instead,
put the output vector inside the class as an instance member variable. In addition, rename
write32() and write16() to append32() and append16(), and provide a copy of append32 inside
SVGToOTFFontConverter.

2) Change the "Codepoint" typedef to be a String, and rename it to Codepoints. This is so that
we can implement ligatures later on. Update all the places that use this variable to work with
a String of multiple codepoints.

This patch updates the CMAP table to use format 12 instead of format 4. It currently only maps
single codepoints to glyph IDs and skips all multi-codepoint glyphs. We will implement
ligatures in another patch.

Test: svg/custom/glyph-selection-non-bmp.svg

svg/SVGToOTFFontConversion.cpp:

(WebCore::append32): Append a result to a given vector. This is for the path transcoder.
(WebCore::SVGToOTFFontConverter::releaseResult): WTF::move()'s the result.
(WebCore::SVGToOTFFontConverter::GlyphData::GlyphData): Update to take Codepoints instead of Codepoint.
(WebCore::SVGToOTFFontConverter::append32): Piece 1 above.
(WebCore::SVGToOTFFontConverter::append16): Ditto.
(WebCore::SVGToOTFFontConverter::append4ByteCode): Convenience function.
(WebCore::SVGToOTFFontConverter::overwrite32): Piece 1 above.
(WebCore::SVGToOTFFontConverter::overwrite16): Ditto.
(WebCore::SVGToOTFFontConverter::appendCMAPTable): Update to format 12.
(WebCore::SVGToOTFFontConverter::appendHEADTable): Passing in a result vector is no longer necessary.
(WebCore::SVGToOTFFontConverter::appendHHEATable): Ditto.
(WebCore::SVGToOTFFontConverter::appendHMTXTable): Ditto.
(WebCore::SVGToOTFFontConverter::appendMAXPTable): Ditto.
(WebCore::SVGToOTFFontConverter::appendNAMETable): Ditto.
(WebCore::SVGToOTFFontConverter::appendOS2Table): Ditto.
(WebCore::SVGToOTFFontConverter::appendPOSTTable): Ditto.
(WebCore::isValidStringForCFF): Ditto.
(WebCore::SVGToOTFFontConverter::appendCFFValidString): Ditto.
(WebCore::SVGToOTFFontConverter::appendCFFTable): Ditto.
(WebCore::SVGToOTFFontConverter::appendVORGTable): Ditto.
(WebCore::SVGToOTFFontConverter::appendVHEATable): Ditto.
(WebCore::SVGToOTFFontConverter::appendVMTXTable): Ditto.
(WebCore::SVGToOTFFontConverter::addCodepointRanges): Update for Codepoints.
(WebCore::SVGToOTFFontConverter::addCodepoints): Ditto.
(WebCore::SVGToOTFFontConverter::addGlyphNames): Ditto.
(WebCore::SVGToOTFFontConverter::appendKERNSubtable): Ditto.
(WebCore::SVGToOTFFontConverter::appendKERNTable): Ditto.
(WebCore::writeCFFEncodedNumber): Passing in a result vector is no longer necessary.
(WebCore::SVGToOTFFontConverter::appendGlyphData): Update for Codepoints.
(WebCore::SVGToOTFFontConverter::processGlyphElement): Update for Codepoints.
(WebCore::SVGToOTFFontConverter::compareCodepointsLexicographically): Comparing Codepoints
(WebCore::SVGToOTFFontConverter::SVGToOTFFontConverter): Update for Codepoints.
(WebCore::SVGToOTFFontConverter::calculateChecksum): Passing in a result vector is no longer necessary.
(WebCore::SVGToOTFFontConverter::appendTable): Ditto.
(WebCore::SVGToOTFFontConverter::convertSVGToOTFFont): Ditto.
(WebCore::convertSVGToOTFFont): Move out of the result vector.
(WebCore::write32): Deleted.
(WebCore::write16): Deleted.
(WebCore::overwrite32): Deleted.
(WebCore::appendCFFValidString): Deleted.
(WebCore::transcodeGlyphPaths): Deleted.
(WebCore::calculateChecksum): Deleted.

1:08 PM Changeset in webkit [174278] by Beth Dakin

16 edits
2 deletes in trunk/Source/WebCore

Unreviewed, rolling out r174270.
https://bugs.webkit.org/show_bug.cgi?id=137397

crashes on the bots (Requested by dethbakin on #webkit).

Reverted changeset:

"EventSender dispatches should be per-Document"
https://bugs.webkit.org/show_bug.cgi?id=136051
http://trac.webkit.org/changeset/174270

Patch by Commit Queue <commit-queue@webkit.org> on 2014-10-03

1:07 PM Changeset in webkit [174277] by jer.noble@apple.com

2 edits in trunk/Source/WebCore

[iOS] Back-to-back fullscreen videos result in incorrectly sized videos
https://bugs.webkit.org/show_bug.cgi?id=137380

Reviewed by Eric Carlson.

During a normal workflow, a <video> element will create an AVPlayerLayer, then it will get a
fullscreen (hosted) parent layer, then it will be told an explicit fullscreen size. But when
a <video> element creates an AVPlayerLayer after the <video> element is already in
fullscreen mode, it sets that AVPlayerLayer's frame using the size of the hosted parent
layer, rather than the explicit fullscreen size. Instead, use the (already set) explicit
fullscreen size after creating the AVPlayerLayer.

platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::ensureAVPlayerLayer):
(WebCore::MediaPlayerPrivateAVFoundationObjC::platformLayer):

12:58 PM Changeset in webkit [174276] by roger_fong@apple.com

2 edits in trunk/Tools

[Windows] Settle for 2 chid processes running NRWT on Windows.

Scripts/webkitpy/port/win.py:

(WinPort.default_child_processes): 3 child processes reintroduces the sporadic crashing, will settle for 2.

12:38 PM Changeset in webkit [174275] by fpizlo@apple.com

23 edits
6 adds in trunk

FTL should sink PutLocals
https://bugs.webkit.org/show_bug.cgi?id=137168

Reviewed by Oliver Hunt.
Source/JavaScriptCore:

CMakeLists.txt:
JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
JavaScriptCore.xcodeproj/project.pbxproj:
bytecode/CodeBlock.h:
bytecode/Operands.h:

(JSC::Operands::dump): Deleted.

bytecode/OperandsInlines.h:

(JSC::Traits>::dump):

bytecode/VirtualRegister.h:

(JSC::VirtualRegister::isHeader):

dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):

dfg/DFGClobberSet.h:

(JSC::DFG::ClobberSetAdd::operator()):
(JSC::DFG::ClobberSetOverlaps::operator()):

dfg/DFGClobberize.h:

dfg/DFGFlushFormat.h:

(JSC::DFG::merge):

dfg/DFGGraph.cpp:

(JSC::DFG::Graph::Graph):

dfg/DFGGraph.h:

(JSC::DFG::Graph::capturedVarsFor):

dfg/DFGObjectAllocationSinkingPhase.cpp:

(JSC::DFG::ObjectAllocationSinkingPhase::determineMaterializationPoints):
(JSC::DFG::ObjectAllocationSinkingPhase::placeMaterializationPoints):

dfg/DFGPlan.cpp:

(JSC::DFG::Plan::compileInThreadImpl):

dfg/DFGPreciseLocalClobberize.h: Added.

dfg/DFGPutLocalSinkingPhase.cpp: Added.

(JSC::DFG::performPutLocalSinking):

dfg/DFGPutLocalSinkingPhase.h: Added.
dfg/DFGSSACalculator.h:

(JSC::DFG::SSACalculator::computePhis):

dfg/DFGValidate.cpp:

Source/WTF:

Make the set bits of a BitVector iterable.

wtf/BitVector.h:

LayoutTests:

js/regress/elidable-new-object-then-call-expected.txt: Added.
js/regress/elidable-new-object-then-call.html: Added.
js/regress/script-tests/elidable-new-object-then-call.js: Added.

(sumOfArithSeries):
(bar):
(foo):

11:38 AM Changeset in webkit [174274] by commit-queue@webkit.org

2 edits
3 adds
1 delete in trunk/Tools

[GTK] Bump up and patch dependencies to allow building for aarch64
https://bugs.webkit.org/show_bug.cgi?id=137147

Patch by Akos Kiss <akiss@inf.u-szeged.hu> on 2014-10-03
Reviewed by Martin Robinson.

The currently used versions of pixman, libffi, librsvg, glib,
glib-networking, fontconfig, libxml2, gst-plugins-base fail to configure
and/or build for aarch64, so they are bumped up and patched where
necessary. Wherever possible, the same versions and patches were used as
for the EFL port bump-up
(https://bugs.webkit.org/show_bug.cgi?id=135885).

After the bump-up, a hitherto hidden bug in gst-plugins-good caused a
regression by crashing http/tests/media/video-redirect.html . A patch
already in upstream fixes that bug.

This change does not touch xserver, which also needs bumping up, but
will be dealt with later.

gtk/jhbuild.modules:

Specified versions and patches necessary to correctly build for aarch64.

gtk/patches/gst-events-arent-gstobjects.patch:

Added. Patches gst-plugins-good to fix a bug in .mov file demuxing.

gtk/patches/gst-prevent-neon-check-in-configure-from-passing-under-aarch64.patch:

Added. Patches gst-plugins-base to configure correctly for aarch64.

gtk/patches/librsvg-2.36.1-bump-up-config.guess-to-support-aarch64.patch:

Added. Bumps up config.guess and config.sub in librsvg to recognize
aarch64.

gtk/patches/libxml2-2.9.0-dtd.patch:

Removed. Not necessary for libxml2 v2.9.1 anymore.

11:35 AM Changeset in webkit [174273] by betravis@adobe.com

4 edits
2 adds in trunk

REGRESSION (r173531): Use after free in WebCore::RenderStyle::fontMetrics /
WebCore::CSSPrimitiveValue::computeLengthDouble
https://bugs.webkit.org/show_bug.cgi?id=136864

Reviewed by Andreas Kling.

Source/WebCore:

FontLoader previously called updateDocumentStyleIfNeeded,
which would reset styles currently in use as part of
the tabIndex calculation. The FontLoader should instead
wait for pending stylesheets to load.

Tests: fast/css/fontloader-tab-index.html

css/FontLoader.cpp:

(WebCore::FontLoader::notifyWhenFontsReady): Do not immediately
call loadingDone().
(WebCore::FontLoader::loadingDone): Wait for stylesheets to
finish loading rather than updating document styles.

css/FontLoader.h:

(WebCore::FontLoader::loading): Include JS font loads when testing
for the loading state.

LayoutTests:

Test that getting the tab index on a body element with
font-relative measurements to a local @font-face do not
cause a crash.

fast/css/fontloader-tab-index-expected.html: Added.
fast/css/fontloader-tab-index.html: Added.

10:55 AM Changeset in webkit [174272] by mmaxfield@apple.com

2 edits in trunk/Source/WebCore

Unreviewed build fix.

Fixing the Windows build after r174269.

Patch by Myles C. Maxfield <mmaxfield@apple.com> on 2014-10-03

platform/graphics/win/UniscribeController.cpp:

(WebCore::UniscribeController::shapeAndPlaceItem):

10:43 AM Changeset in webkit [174271] by mmaxfield@apple.com

3 edits in trunk

Support modern for loops over StringViews
https://bugs.webkit.org/show_bug.cgi?id=137165

Patch by Myles C. Maxfield <mmaxfield@apple.com> on 2014-10-03
Reviewed by Darin Adler.

This patch adds two functions, codePoints() and codeUnits(), on StringView.
These two functions return small objects which have begin() and end() functions,
which means it can be used by the modern for loop style. This small class also
has an inner iterator class which can be incremented, dereferenced, and
compared.

Using these new objects looks like this:
for (UChar codeunit : stringView.codeUnits()) { } and
for (UChar32 codepoint : stringView.codePoints()) { }.

wtf/text/StringView.h:

(WTF::StringView::codepoints):
(WTF::StringView::codeunits):
(WTF::StringViewCodePointIterator::StringViewCodePointIterator):
(WTF::StringViewCodePointIterator::Iterator::Iterator):
(WTF::StringViewCodePointIterator::Iterator::operator*):
(WTF::StringViewCodePointIterator::Iterator::operator!=):
(WTF::StringViewCodeUnitIterator::StringViewCodeUnitIterator):
(WTF::StringViewCodeUnitIterator::Iterator::Iterator):
(WTF::StringViewCodeUnitIterator::Iterator::operator*):
(WTF::StringViewCodeUnitIterator::Iterator::operator!=):

10:15 AM Changeset in webkit [174270] by Brian Burg

16 edits
2 adds in trunk/Source/WebCore

EventSender dispatches should be per-Document
https://bugs.webkit.org/show_bug.cgi?id=136051

Reviewed by Andreas Kling.

EventSender uses a Timer to asynchronously dispatch the same event to multiple
elements of the same type on a future run loop. However, we previously dispatched events
to elements from any Document rather than the one that requested the event send.

This patch changes EventSender to be associated with a single Document. EventSenders
for each Document are lazily allocated. Further per-Document or global optimizations
are possible.

This change also lays the groundwork for making EventSender-related DOM events
deterministic during web replay, tracked at <https://webkit.org/b/137090>.

No new tests, covered by fast/text/svg-font-trigger-load-event.html.

CMakeLists.txt:
WebCore.vcxproj/WebCore.vcxproj:
WebCore.vcxproj/WebCore.vcxproj.filters:
WebCore.xcodeproj/project.pbxproj:
dom/DOMAllInOne.cpp:
dom/Document.cpp:

(WebCore::Document::Document):
(WebCore::Document::implicitClose):
Dispatch pending events for this document only. Rename local variable f to frame.

dom/Document.h:

(WebCore::Document::sharedEventSenders):

dom/EventSender.h:

(WebCore::EventSender::EventSender):
(WebCore::EventSender::hasPendingEvents):
(WebCore::EventSender<T>::dispatchEventSoon):
(WebCore::EventSender<T>::cancelEvent):
(WebCore::EventSender<T>::dispatchPendingEvents):
(WebCore::EventSender<T>::EventSender): Deleted. The type argument was not necessary.

dom/SharedEventSenders.cpp: Added. Lazily creates event senders as they are requested.

(WebCore::SharedEventSenders::linkLoadEventSender):
(WebCore::SharedEventSenders::styleLoadEventSender):
(WebCore::SharedEventSenders::imageBeforeloadEventSender):
(WebCore::SharedEventSenders::imageLoadEventSender):
(WebCore::SharedEventSenders::imageErrorEventSender):

dom/SharedEventSenders.h: Added.

(WebCore::SharedEventSenders::SharedEventSenders):

html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::~HTMLLinkElement):
(WebCore::HTMLLinkElement::dispatchPendingEvent):
(WebCore::HTMLLinkElement::notifyLoadedSheetAndAllCriticalSubresources):
(WebCore::linkLoadEventSender): Deleted.
(WebCore::HTMLLinkElement::dispatchPendingLoadEvents): Deleted.

html/HTMLLinkElement.h:
html/HTMLStyleElement.cpp:

(WebCore::HTMLStyleElement::~HTMLStyleElement):
(WebCore::HTMLStyleElement::dispatchPendingEvent):
(WebCore::HTMLStyleElement::notifyLoadedSheetAndAllCriticalSubresources):
(WebCore::styleLoadEventSender): Deleted.
(WebCore::HTMLStyleElement::dispatchPendingLoadEvents): Deleted.

html/HTMLStyleElement.h:
loader/ImageLoader.cpp:

(WebCore::ImageLoader::beforeLoadEventSender):
(WebCore::ImageLoader::loadEventSender):
(WebCore::ImageLoader::errorEventSender):
(WebCore::ImageLoader::dispatchPendingEvent):
(WebCore::beforeLoadEventSender): Deleted.
(WebCore::loadEventSender): Deleted.
(WebCore::errorEventSender): Deleted.
(WebCore::ImageLoader::dispatchPendingBeforeLoadEvents): Deleted.
(WebCore::ImageLoader::dispatchPendingLoadEvents): Deleted.
(WebCore::ImageLoader::dispatchPendingErrorEvents): Deleted.

loader/ImageLoader.h:
xml/parser/XMLDocumentParser.cpp:

(WebCore::XMLDocumentParser::append): Remove an early call to the EventSender for image
beforeload events. This was a performance optimization, but is no longer safe since the
document (and thus the event sender) may not be available in a synchronous document write.

9:57 AM Changeset in webkit [174269] by mmaxfield@apple.com

9 edits in trunk/Source/WebCore

TextRun::length() should return an unsigned
https://bugs.webkit.org/show_bug.cgi?id=137354

Patch by Myles C. Maxfield <mmaxfield@apple.com> on 2014-10-03
Reviewed by Antti Koivisto.

Currently, the m_len instance variable that backs the TextRun::length() function is
an unsigned, but the length() function implicitly casts that to an int when
returning it. This patch makes the function return an unsigned, and makes the
do any casting if necessary.

No new tests because there is no behavior change.

platform/graphics/Font.cpp:

(WebCore::Font::drawText): Cast result to int.
(WebCore::Font::drawEmphasisMarks): Ditto.
(WebCore::Font::adjustSelectionRectForText): Ditto.
(WebCore::computeUnderlineType): Update internal type to be unsigned.

platform/graphics/GlyphBuffer.h:

(WebCore::GlyphBuffer::add): Update sentinel value to be unsigned.
(WebCore::GlyphBuffer::saveOffsetsInString): Ditto.

platform/graphics/GraphicsContext.cpp: Update internal type to be unsigned.
platform/graphics/TextRun.h:

(WebCore::TextRun::length): Update return type.
(WebCore::TextRun::charactersLength): Ditto.

platform/graphics/WidthIterator.cpp:

(WebCore::WidthIterator::advanceInternal): Cast result to int.

rendering/svg/SVGTextMetricsBuilder.cpp:

(WebCore::SVGTextMetricsBuilder::currentCharacterStartsSurrogatePair): Remove
unnecessary casts.
(WebCore::SVGTextMetricsBuilder::advance): Ditto.

svg/SVGFontData.cpp:

(WebCore::SVGFontData::applySVGGlyphSelection): Cast result to int.

9:51 AM WebKitGTK/KeepingTheTreeGreen edited by clopez@igalia.com

(diff)

9:47 AM Changeset in webkit [174268] by weinig@apple.com

8 edits
1 delete in trunk

Remove RefPtrHashMap
https://bugs.webkit.org/show_bug.cgi?id=137200

Reviewed by Darin Adler.

Source/WTF:

HashMap now has all the features of the RefPtr specialization of HashMap
(which lived in RefPtrHashMap.h) and is in fact more efficient when moving
items into it. For instance:

For HashMap<RefPtr<Foo>, Bar> map:

RefPtr<Foo> foo = ...;
map.add(WTF::move(foo), Bar());

will now not cause a ref() / deref(), but will successfully move the item in
without churn. The same is true if foo.release() was used.

WTF.vcxproj/WTF.vcxproj:
WTF.vcxproj/WTF.vcxproj.filters:
WTF.xcodeproj/project.pbxproj:
wtf/CMakeLists.txt:

Remove references to RefPtrHashMap.h.

wtf/RefPtrHashMap.h: Removed.

wtf/HashMap.h:

Remove #include of RefPtrHashMap.h and add inlineGet to match the interface
exposed by the RefPtrHashMap specialization.

Tools:

TestWebKitAPI/Tests/WTF/HashMap.cpp:

(TestWebKitAPI::TEST):
Add tests for using a HashMap with RefPtr keys, focusing on ensuring that
a minimum of refcount churn occurs.

9:43 AM Changeset in webkit [174267] by clopez@igalia.com

35 edits
1 add in trunk/LayoutTests

[GTK] Unreviewed GTK gardening.

platform/gtk/TestExpectations: Update test name for bug 136673 after r173418.
platform/gtk/css1/box_properties/clear_float-expected.txt: Rebaseline after r174233.
platform/gtk/css1/box_properties/float_on_text_elements-expected.txt: Rebaseline after r174233.
platform/gtk/css2.1/t0905-c5525-fltcont-00-d-g-expected.txt: Rebaseline after r174233.
platform/gtk/css2.1/t0905-c5525-fltwidth-00-c-g-expected.txt: Rebaseline after r174233.
platform/gtk/css2.1/t1602-c546-txt-align-00-b-expected.txt: Rebaseline after r174233.
platform/gtk/fast/multicol/float-avoidance-expected.txt: Rebaseline after r174233.
platform/gtk/fast/multicol/overflow-across-columns-expected.txt: Rebaseline after r174233.
platform/gtk/fast/multicol/overflow-across-columns-percent-height-expected.txt: Rebaseline after r174233.
platform/gtk/fast/multicol/overflow-unsplittable-expected.txt: Rebaseline after r174233.
platform/gtk/fast/multicol/positive-leading-expected.txt: Rebaseline after r174233.
platform/gtk/fast/multicol/vertical-lr/float-avoidance-expected.txt: Rebaseline after r174233.
platform/gtk/fast/multicol/vertical-rl/float-avoidance-expected.txt: Rebaseline after r174233.
platform/gtk/fast/regions/multiple-directionality-changes-in-variable-width-regions-expected.txt: Rebaseline after r174233.
platform/gtk/fast/regions/repaint/line-flow-with-floats-in-regions-expected.txt: Rebaseline after r174233.
platform/gtk/fast/repaint/line-flow-with-floats-1-expected.txt: Rebaseline after r174233.
platform/gtk/fast/repaint/line-flow-with-floats-10-expected.txt: Rebaseline after r174233.
platform/gtk/fast/repaint/line-flow-with-floats-2-expected.txt: Rebaseline after r174233.
platform/gtk/fast/repaint/line-flow-with-floats-3-expected.txt: Rebaseline after r174233.
platform/gtk/fast/repaint/line-flow-with-floats-4-expected.txt: Rebaseline after r174233.
platform/gtk/fast/repaint/line-flow-with-floats-5-expected.txt: Rebaseline after r174233.
platform/gtk/fast/repaint/line-flow-with-floats-6-expected.txt: Rebaseline after r174233.
platform/gtk/fast/repaint/line-flow-with-floats-7-expected.txt: Rebaseline after r174233.
platform/gtk/fast/repaint/line-flow-with-floats-8-expected.txt: Rebaseline after r174233.
platform/gtk/fast/repaint/line-flow-with-floats-9-expected.txt: Rebaseline after r174233.
platform/gtk/fast/text/justified-selection-at-edge-expected.txt: Rebaseline after r174233.
platform/gtk/fast/text/justify-ideograph-leading-expansion-expected.txt: Rebaseline after r174233.
platform/gtk/fast/text/justify-nbsp-expected.txt: Added. Rebaseline after r174233.
platform/gtk/fast/text/trailing-white-space-2-expected.txt: Rebaseline after r174233.
platform/gtk/tables/mozilla/marvin/x_tbody_align_justify-expected.txt: Rebaseline after r174233.
platform/gtk/tables/mozilla/marvin/x_td_align_justify-expected.txt: Rebaseline after r174233.
platform/gtk/tables/mozilla/marvin/x_tfoot_align_justify-expected.txt: Rebaseline after r174233.
platform/gtk/tables/mozilla/marvin/x_th_align_justify-expected.txt: Rebaseline after r174233.
platform/gtk/tables/mozilla/marvin/x_thead_align_justify-expected.txt: Rebaseline after r174233.
platform/gtk/tables/mozilla/marvin/x_tr_align_justify-expected.txt: Rebaseline after r174233.

8:03 AM Changeset in webkit [174266] by evab.u-szeged@partner.samsung.com

6 edits in trunk/Tools

Remove workarounds for versions of Python before 2.7
https://bugs.webkit.org/show_bug.cgi?id=137338

Reviewed by Csaba Osztrogonác.

Scripts/webkitpy/common/system/autoinstall.py:

(AutoInstaller._extract_targz):
(AutoInstaller._unzip):
(AutoInstaller): Deleted.
(AutoInstaller._extract_all): Deleted.

Scripts/webkitpy/common/webkitunittest.py:

(TestCase.setUp): Deleted.

Scripts/webkitpy/layout_tests/models/test_configuration.py:

(TestConfigurationConverter.collapse_macros):
(TestConfigurationConverter.to_specifiers_list.try_collapsing):
(TestConfigurationConverter.to_specifiers_list.try_abbreviating):
(TestConfigurationConverter):
(TestConfigurationConverter.combinations): Deleted.

Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
Scripts/webkitpy/port/base.py:

6:34 AM WebKitGTK/KeepingTheTreeGreen edited by clopez@igalia.com

(diff)

5:26 AM Changeset in webkit [174265] by evab.u-szeged@partner.samsung.com

8 edits in trunk/Tools

Unreviewed, rolling out r174264.
https://bugs.webkit.org/show_bug.cgi?id=137392

It broke run-webkit-tests (Requested by ebalazsfalvi on
#webkit).

Reverted changeset:

"Remove workarounds for versions of Python before 2.7"
https://bugs.webkit.org/show_bug.cgi?id=137338
http://trac.webkit.org/changeset/174264

Patch by Commit Queue <commit-queue@webkit.org> on 2014-10-03

3:14 AM Changeset in webkit [174264] by evab.u-szeged@partner.samsung.com

8 edits in trunk/Tools

Remove workarounds for versions of Python before 2.7
https://bugs.webkit.org/show_bug.cgi?id=137338

Reviewed by Csaba Osztrogonác.

Scripts/webkitpy/common/system/autoinstall.py:

(AutoInstaller._extract_targz):
(AutoInstaller._unzip):
(AutoInstaller): Deleted.
(AutoInstaller._extract_all): Deleted.

Scripts/webkitpy/common/webkitunittest.py:

(TestCase.setUp): Deleted.

Scripts/webkitpy/layout_tests/models/test_configuration.py:

Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
Scripts/webkitpy/port/base.py:
Scripts/webkitpy/port/driver.py:

(ContentBlock.init):

Scripts/webkitpy/port/server_process.py:

(ServerProcess._reset):

3:13 AM Changeset in webkit [174263] by evab.u-szeged@partner.samsung.com

4 edits in trunk/Tools

Remove autoinstaller workaround for python 2.6
https://bugs.webkit.org/show_bug.cgi?id=137343

Reviewed by Daniel Bates.

Reverting <http://trac.webkit.org/changeset/124928>, neither Python
2.6, nor Snow Leopard is supported anymore, so the workaround is not
needed anymore.

Scripts/webkitpy/common/system/autoinstall.py:

(AutoInstaller.install):

Scripts/webkitpy/test/main.py:

(Tester._run_tests):

Scripts/webkitpy/thirdparty/init.py:

(AutoinstallImportHook._install_mechanize):
(AutoinstallImportHook._install_pep8):
(AutoinstallImportHook._install_pylint):
(AutoinstallImportHook._install_buildbot):
(AutoinstallImportHook._install_coverage):
(AutoinstallImportHook._install_eliza):
(AutoinstallImportHook._install_irc):
(AutoinstallImportHook._install):
(autoinstall_everything):

2:25 AM Changeset in webkit [174262] by Csaba Osztrogonác

6 edits in trunk/Source/WebKit2

[GTK] URTBF after r174231.

WebProcess/InjectedBundle/API/gtk/WebKitWebPage.cpp:

(webkit_web_page_get_dom_document):

WebProcess/WebPage/DrawingAreaImpl.cpp:

(WebKit::DrawingAreaImpl::didInstallPageOverlay): Deleted.
(WebKit::DrawingAreaImpl::didUninstallPageOverlay): Deleted.
(WebKit::DrawingAreaImpl::setPageOverlayNeedsDisplay): Deleted.
(WebKit::DrawingAreaImpl::setPageOverlayOpacity): Deleted.

WebProcess/WebPage/DrawingAreaImpl.h:
WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp:

(WebKit::LayerTreeHostGtk::createPageOverlayLayer):
(WebKit::LayerTreeHostGtk::destroyPageOverlayLayer):
(WebKit::LayerTreeHostGtk::didInstallPageOverlay): Deleted.
(WebKit::LayerTreeHostGtk::didUninstallPageOverlay): Deleted.
(WebKit::LayerTreeHostGtk::setPageOverlayNeedsDisplay): Deleted.

WebProcess/WebPage/gtk/LayerTreeHostGtk.h:

1:00 AM Changeset in webkit [174261] by gyuyoung.kim@samsung.com

8 edits in trunk/Source

[EFL] Fix build break since r174231 and r174256
https://bugs.webkit.org/show_bug.cgi?id=137384

Unreviewed, EFL build fix.

r174231 and r174256 didn't consider EFL port and CoordinatedGraphics area.

Source/WebCore:

css/WebKitCSSViewportRule.cpp:

(WebCore::WebKitCSSViewportRule::WebKitCSSViewportRule):

css/WebKitCSSViewportRule.h:

Source/WebKit2:

WebProcess/WebPage/CoordinatedGraphics/CoordinatedDrawingArea.cpp:

(WebKit::CoordinatedDrawingArea::mainFrameContentSizeChanged):

WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:

(WebKit::CoordinatedLayerTreeHost::setRootCompositingLayer):
(WebKit::CoordinatedLayerTreeHost::didFlushRootLayer):
(WebKit::CoordinatedLayerTreeHost::deviceOrPageScaleFactorChanged):

WebProcess/WebPage/TapHighlightController.cpp:

(WebKit::TapHighlightController::highlight):
(WebKit::TapHighlightController::hideHighlight):

WebProcess/WebPage/TapHighlightController.h: Add WebCore:: namespace prefix to PageOverlay argument type.

12:53 AM Changeset in webkit [174260] by saambarati1@gmail.com

2 edits in trunk/Source/JavaScriptCore

Change how 32-bit JSValues check if they are a Boolean

Rubber stamped by Filip Pizlo.

32-bit JSValue::isBoolean can simply check if its tag corresponds
to the boolean tag instead of checking if it's either true or false.

runtime/JSCJSValueInlines.h:

(JSC::JSValue::isBoolean):

12:13 AM Changeset in webkit [174259] by Yusuke Suzuki

13 edits
16 adds in trunk

CSS Selectors Level 4: Add parsing for :matches
https://bugs.webkit.org/show_bug.cgi?id=137348

Reviewed by Benjamin Poulain.

Source/WebCore:

Add initial parsing functionality of :matches pseudo class in Selectors Level 4.
It accepts selector list as a parameter. It can contain pseudo elements.
And now at the parsing phase, multiple pseudo elements are allowed.
Currently :not doesn't accept any functional pseudo classes, :not(:matches(...)) is rejected.
And currently, :matches(:visited, :link) is allowed in the parsing phase.

css/CSSGrammar.y.in:
css/CSSParser.cpp:

(WebCore::CSSParser::detectFunctionTypeToken):

css/CSSSelector.cpp:

(WebCore::appendSelectorList):
(WebCore::CSSSelector::selectorText):

css/CSSSelector.h:
css/SelectorChecker.cpp:

(WebCore::SelectorChecker::checkOne):

css/SelectorPseudoClassAndCompatibilityElementMap.in:
cssjit/SelectorCompiler.cpp:

(WebCore::SelectorCompiler::addPseudoClassType):

LayoutTests:

fast/css/css-selector-text-expected.txt:
fast/css/css-selector-text.html:
fast/css/css-set-selector-text-expected.txt:
fast/css/css-set-selector-text.html:

Cover CSSOM tests; canonicalizing :matches text representation.

fast/css/parsing-css-matches-1-expected.txt: Added.
fast/css/parsing-css-matches-1.html: Added.
fast/css/parsing-css-matches-2-expected.txt: Added.
fast/css/parsing-css-matches-2.html: Added.
fast/css/parsing-css-matches-3-expected.txt: Added.
fast/css/parsing-css-matches-3.html: Added.
fast/css/parsing-css-matches-4-expected.txt: Added.
fast/css/parsing-css-matches-4.html: Added.
fast/css/parsing-css-matches-5-expected.txt: Added.
fast/css/parsing-css-matches-5.html: Added.
fast/css/parsing-css-matches-6-expected.txt: Added.
fast/css/parsing-css-matches-6.html: Added.

Valid :matches are tested in the above tests. Selector lists with 1, 2, 3 elements are tested.

Context Navigation

Timeline

Oct 4, 2014:

Oct 3, 2014:

Download in other formats: