Timeline
Oct 7, 2014:
- 11:37 PM Changeset in webkit [174419] by
-
- 13 edits in trunk
[EFL] Enable custom URI schemes with CustomProtocols
https://bugs.webkit.org/show_bug.cgi?id=128177
Patch by Pascal Jacquemart <p.jacquemart@samsung.com> on 2014-10-07
Reviewed by Gyuyoung Kim.
Fixing ewk_context_url_scheme_register() ewebkit2 API
rely on r162449 - CustomProtocols implementation from Carlos Garcia Campos
.:
- Source/cmake/OptionsEfl.cmake: Forcing CUSTOM_PROTOCOLS flag
Source/WebKit2:
- PlatformEfl.cmake:
- UIProcess/API/efl/ewk_context.h:
- UIProcess/API/efl/ewk_url_scheme_request.cpp:
(EwkUrlSchemeRequest::EwkUrlSchemeRequest):
(EwkUrlSchemeRequest::finish):
- UIProcess/API/efl/ewk_url_scheme_request_private.h:
(EwkUrlSchemeRequest::create):
- UIProcess/API/efl/tests/test_ewk2_context.cpp:
(TEST_F):
- UIProcess/Network/CustomProtocols/soup/WebSoupCustomProtocolRequestManager.cpp:
- UIProcess/efl/RequestManagerClientEfl.cpp:
(WebKit::RequestManagerClientEfl::RequestManagerClientEfl):
(WebKit::RequestManagerClientEfl::startLoading):
(WebKit::RequestManagerClientEfl::stopLoading):
(WebKit::RequestManagerClientEfl::registerURLSchemeHandler):
(WebKit::EwkUrlSchemeHandler::EwkUrlSchemeHandler): Deleted.
(WebKit::RequestManagerClientEfl::didReceiveURIRequest): Deleted.
- UIProcess/efl/RequestManagerClientEfl.h:
- UIProcess/efl/WebContextEfl.cpp:
(WebKit::WebContext::platformInitializeWebProcess):
- UIProcess/soup/WebContextSoup.cpp:
(WebKit::WebContext::platformInitializeNetworkProcess):
- 10:36 PM Changeset in webkit [174418] by
-
- 2 edits in trunk/Tools
Remove build warnings in Hashmap API tests
https://bugs.webkit.org/show_bug.cgi?id=137484
Patch by Tanay C <tanay.c@samsung.com> on 2014-10-07
Reviewed by Darin Adler.
- TestWebKitAPI/Tests/WTF/HashMap.cpp:
(TestWebKitAPI::TEST): Changed EXPECT_EQ(false, addResult.isNewEntry) to EXPECT_FALSE(addResult.isNewEntry)
- 10:17 PM Changeset in webkit [174417] by
-
- 3 edits in trunk/Source/WebKit2
Remove WKPageCreateSnapshotOfVisibleContent API.
https://bugs.webkit.org/show_bug.cgi?id=66979
Patch by Sungmann Cho <sungmann.cho@navercorp.com> on 2014-10-07
Reviewed by Darin Adler.
After the landing of the first patch of webkit.org/b/66979,
WKPageCreateSnapshotOfVisibleContent API has been neglected for years.
Currently, this is not used anywhere and does not break the nightlies.
So we can remove this.
- UIProcess/API/C/WKPage.cpp:
(WKPageCreateSnapshotOfVisibleContent): Deleted.
- UIProcess/API/C/WKPagePrivate.h:
- 9:51 PM Changeset in webkit [174416] by
-
- 2 edits in trunk/Source/WebCore
[EFL] Call requestScrollPositionUpdate() instead of delegatedScrollRequested() in ScrollView::scrollTo()
https://bugs.webkit.org/show_bug.cgi?id=137478
Reviewed by Benjamin Poulain.
As r174380 did, ScrollView::scrollTo() also calls requestScrollPositionUpdate() instead of delegatedScrollRequested().
delegatedScrollRequested() will be only called by requestScrollPositionUpdate(), and it needs to be merged by existing
other scroll request function.
No new tests, no behavior changes.
- platform/ScrollView.cpp:
(WebCore::ScrollView::scrollTo):
- 8:48 PM Changeset in webkit [174415] by
-
- 3 edits in trunk/Source/WebKit2
Remove WKPageSetInvalidMessageFunction.
https://bugs.webkit.org/show_bug.cgi?id=137509
Patch by Sungmann Cho <sungmann.cho@navercorp.com> on 2014-10-07
Reviewed by Benjamin Poulain.
According to the FIXME comment in WKPageSetInvalidMessageFunction,
we can remove this function when doing so won't break the nightlies.
Currently, this is not used anywhere and does not break the nightlies.
So we can remove this.
- UIProcess/API/C/WKPage.cpp:
(WKPageSetInvalidMessageFunction): Deleted.
- UIProcess/API/C/WKPagePrivate.h:
- 7:23 PM Changeset in webkit [174414] by
-
- 5 edits in trunk/Source/WebCore
Safari 8 on OSX 10.10 does not run WebGL in Retina HiDPI mode.
https://bugs.webkit.org/show_bug.cgi?id=134854
<rdar://problem/18465263>
Reviewed by Tim Horton.
The NSOpenGLLayer has to have its contentScale property
set accordingly when on a retina display. Do this by
adding another value to the GraphicsContext3D creation
attribute dictionary, representing the device pixel ratio.
Then, when we come to draw into the layer, make sure
we set our GL viewport to the correct value.
This is currently untestable because:
- we can't just read from the GL buffer as it is always correct
- WebGL isn't working in reftests
- a layer dump doesn't show the change since it was done in a CALayer subclass.
- html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::create): Pass the devicePixelRatio into the attribute dictionary.
- platform/graphics/GraphicsContext3D.h:
(WebCore::GraphicsContext3D::Attributes::Attributes): Add a devicePixelRatio attribute.
- platform/graphics/mac/WebGLLayer.h: New property to save us looking up the attributes
each frame.
- platform/graphics/mac/WebGLLayer.mm:
(-[WebGLLayer initWithGraphicsContext3D:]): Store the devicePixelRatio, and set our
contents scale appropriately.
(-[WebGLLayer drawInCGLContext:pixelFormat:forLayerTime:displayTime:]): Draw into
a correctly sized backbuffer.
(-[WebGLLayer copyImageSnapshotWithColorSpace:]): Generate an image of the correct size.
- 5:41 PM Changeset in webkit [174413] by
-
- 6 edits in trunk/Source/WebKit2
[WK2] Use is<>() / downcast<>() for DrawingArea subclasses
https://bugs.webkit.org/show_bug.cgi?id=137497
Reviewed by Benjamin Poulain.
Use is<>() / downcast<>() for DrawingArea subclasses.
- WebProcess/WebPage/DrawingArea.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::didCommitLoad):
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::synchronizeDynamicViewportUpdate):
- WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h:
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
- 4:17 PM Changeset in webkit [174412] by
-
- 4 edits in trunk/Source/WTF
[Win] Resolve some MSVC static analyzer warnings
https://bugs.webkit.org/show_bug.cgi?id=137504
Reviewed by Dean Jackson.
- wtf/GregorianDateTime.cpp:
(WTF::GregorianDateTime::setToCurrentLocalTime): Properly handle
possible timezone error case.
- wtf/OSAllocatorWin.cpp:
(WTF::OSAllocator::decommit): Silence a spurious warning about using
MEM_DECOMMIT instead of MEM_RELEASE.
- wtf/ThreadingWin.cpp: Silence a spurious warning about how the
tryLock method is implemented.
- 3:28 PM Changeset in webkit [174411] by
-
- 4 edits4 copies in trunk
Roll-over Changelogs.
Source/JavaScriptCore:
- ChangeLog-2014-10-07: Copied from Source/JavaScriptCore/ChangeLog.
Source/WebCore:
- ChangeLog-2014-10-07: Copied from Source/WebCore/ChangeLog.
Source/WebKit2:
- ChangeLog-2014-10-07: Copied from Source/WebKit2/ChangeLog.
LayoutTests:
- ChangeLog-2014-10-07: Copied from LayoutTests/ChangeLog.
- 3:26 PM Changeset in webkit [174410] by
-
- 10 edits in trunk/Source
Use more Ref and PassRef for Gradient.
<https://webkit.org/b/137490>
Codify the fact that CanvasGradient always has an internal WebCore::Gradient
and make GraphicsContext gradient setters take PassRef, exposing some
unnecessary null checks.
Reviewed by Christophe Dumez.
- WebCore.exp.in:
- html/canvas/CanvasGradient.h:
(WebCore::CanvasGradient::gradient):
- platform/graphics/Gradient.h:
(WebCore::Gradient::create):
- platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContext::setStrokeGradient):
(WebCore::GraphicsContext::setFillGradient):
- platform/graphics/GraphicsContext.h:
- rendering/RenderThemeIOS.mm:
(WebCore::RenderThemeIOS::paintProgressBar):
- rendering/svg/RenderSVGPath.cpp:
(WebCore::useStrokeStyleToFill):
- rendering/svg/RenderSVGResourceGradient.cpp:
(WebCore::RenderSVGResourceGradient::applyResource):
- 3:17 PM Changeset in webkit [174409] by
-
- 2 edits in trunk/LayoutTests
Bug link should be at the beginning of the line.
- platform/mac/TestExpectations:
- 3:14 PM Changeset in webkit [174408] by
-
- 8 edits in trunk/Tools
Commit queue doesn't drop obsolete patches sometimes
https://bugs.webkit.org/show_bug.cgi?id=137460
Patch by Jake Nielsen <jacob_nielsen@apple.com> on 2014-10-07
Reviewed by Alexey Proskuryakov.
- Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
Adds another test patch for use in queues_unittest.py.
courtesy of Csaba Osztrogonác <Csaba Osztrogonác>
(MockBugzilla):
- Scripts/webkitpy/tool/bot/commitqueuetask.py:
Raises a PatchIsNotValid exception in the case of validate() returning
false.
(CommitQueueTask.run):
- Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
Raises a PatchIsNotValid exception in the case of validate() returning
false.
(EarlyWarningSystemTask.run):
- Scripts/webkitpy/tool/bot/patchanalysistask.py:
Defines PatchIsNotValid exception.
(PatchIsNotValid):
(PatchIsNotValid.init):
- Scripts/webkitpy/tool/commands/earlywarningsystem.py:
Remove call to validate() and instead catches the PatchIsNotValid
exception.
(AbstractEarlyWarningSystem.review_patch):
- Scripts/webkitpy/tool/commands/queues.py:
Adds logic to catch the PatchIsNotValid exception.
(CommitQueue.process_work_item):
- Scripts/webkitpy/tool/commands/queues_unittest.py:
Adds the test_non_valid_patch test to ensure that invalid patches are
handled properly, and don't just result in indefinite spinning.
courtesy of Csaba Osztrogonác <Csaba Osztrogonác>
(test_non_valid_patch):
- 2:35 PM Changeset in webkit [174407] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed iOS build fix after r174400.
Missing explicit WebKit:: namespace.
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _didCommitLoadForMainFrame]):
(-[WKWebView _restorePageStateToExposedRect:scale:]):
(-[WKWebView _restorePageStateToUnobscuredCenter:scale:]):
- 2:35 PM Changeset in webkit [174406] by
-
- 3 edits2 adds in trunk
[iOS] Teach run-webkit-tests to honor TestExpectation file for iOS Simulator 64-bit builds
https://bugs.webkit.org/show_bug.cgi?id=137499
Patch by Daniel Bates <dabates@apple.com> on 2014-10-07
Reviewed by Simon Fraser.
Tools:
Fixes an issue where the TestExpectation file for the iOS Simulator platform was only
honored when running run-webkit-tests with a 32-bit simulator build of iOS WebKit. We
should honor the TestExpectation file for the iOS Simulator platform for both 32- and 64-
bit simulator builds of iOS WebKit.
- Scripts/webkitpy/port/ios.py:
(IOSSimulatorPort._generate_all_test_configurations):
LayoutTests:
Add a new platform directory, called ios-simulator, and associated TestExpectation file.
For now, there is a single entry to skip all accessibility tests on iOS due to significant
API differences. We'll likely update TestExpectations as we rebaseline iOS Simulator
layout test results.
- platform/ios-simulator/TestExpectations: Added.
- 1:52 PM Changeset in webkit [174405] by
-
- 6 edits in trunk/Source/WebCore
Defer resolution of viewport size.
https://bugs.webkit.org/show_bug.cgi?id=137376
rdar://problem/18558094
Reviewed by Benjamin Poulain.
ViewportConfiguration should resolve the viewport size on configuration update.
- dom/Document.cpp:
(WebCore::Document::processViewport): Defer resolution of viewport size.
- dom/ViewportArguments.cpp:
(WebCore::finalizeViewportArguments): Deleted.
- dom/ViewportArguments.h:
- page/ViewportConfiguration.cpp:
(WebCore::ViewportConfiguration::updateConfiguration): Resolve viewport size.
(WebCore::ViewportConfiguration::viewportArgumentsLength): Resolves width or height based on viewport arguments.
- page/ViewportConfiguration.h:
- 1:37 PM Changeset in webkit [174404] by
-
- 2 edits in trunk/Source/WebCore
[iOS] WebKit1 clients crash in DiskCacheMonitor::tryGetFileBackedSharedBufferFromCFURLCachedResponse()
https://bugs.webkit.org/show_bug.cgi?id=137495
<rdar://problem/18495034>
Reviewed by Andreas Kling.
Retain/release the CFCachedURLResponseRef object otherwise we could access a deleted object
and crash on the web thread.
- loader/cocoa/DiskCacheMonitorCocoa.mm:
(WebCore::DiskCacheMonitor::DiskCacheMonitor):
- 12:33 PM Changeset in webkit [174403] by
-
- 46 edits in trunk/Source
Use is<>() / downcast<>() for RenderText / RenderTextFragment
https://bugs.webkit.org/show_bug.cgi?id=137476
Reviewed by Darin Adler.
Source/WebCore:
Use is<>() / downcast<>() for RenderText / RenderTextFragment, and
clean up the surrounding code.
No new tests, no behavior change.
- WebCore.exp.in:
Export symbol for RenderInline::linesBoundingBox() as it is used by
RenderInline::orderBoundingBox() which is inlined and now called in
WebRenderNode.mm.
- WebCore.xcodeproj/project.pbxproj:
Make RenderInline.h header as Private so that it can be included by
WebRenderNode.mm, similarly to RenderText.h.
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::textUnderElement):
(WebCore::AccessibilityRenderObject::boundingBoxRect):
(WebCore::AccessibilityRenderObject::computeAccessibilityIsIgnored):
(WebCore::AccessibilityRenderObject::passwordFieldValue):
- accessibility/atk/AccessibilityObjectAtk.cpp:
(WebCore::AccessibilityObject::getLengthForTextRange):
- bindings/objc/DOMUIKitExtensions.mm:
(-[DOMNode textHeight]):
(-[DOMNode findExplodedTextNodeAtPoint:]):
- dom/ContainerNode.cpp:
(WebCore::ContainerNode::getUpperLeftCorner):
(WebCore::ContainerNode::getLowerRightCorner):
- dom/DocumentMarkerController.cpp:
(WebCore::DocumentMarkerController::addMarker):
- dom/Position.cpp:
(WebCore::hasInlineBoxWrapper):
(WebCore::Position::upstream):
(WebCore::Position::downstream):
(WebCore::Position::hasRenderedNonAnonymousDescendantsWithHeight):
(WebCore::Position::isCandidate):
(WebCore::Position::rendersInDifferentPosition):
(WebCore::searchAheadForBetterMatch):
(WebCore::Position::getInlineBoxAndOffset):
- dom/PositionIterator.cpp:
(WebCore::PositionIterator::isCandidate):
- dom/Range.cpp:
(WebCore::Range::textRects):
(WebCore::Range::textQuads):
(WebCore::Range::getBorderAndTextQuads):
- editing/FrameSelection.cpp:
(WebCore::FrameSelection::debugRenderer):
- editing/TextIterator.cpp:
(WebCore::hasVisibleTextNode):
(WebCore::TextIterator::handleTextNode):
(WebCore::maxOffsetIncludingCollapsedSpaces):
(WebCore::SimplifiedBackwardsTextIterator::handleFirstLetter):
- editing/VisibleUnits.cpp:
(WebCore::startOfParagraph):
(WebCore::endOfParagraph):
- page/FrameView.cpp:
(WebCore::countRenderedCharactersInRenderObjectWithThreshold):
- rendering/BidiRun.cpp:
(WebCore::BidiRun::BidiRun):
- rendering/InlineIterator.cpp:
(WebCore::InlineIterator::surrogateTextDirection):
- rendering/InlineIterator.h:
(WebCore::InlineIterator::atTextParagraphSeparator):
(WebCore::InlineIterator::atParagraphSeparator):
(WebCore::isEmptyInline):
(WebCore::InlineIterator::fastIncrementInTextNode):
(WebCore::InlineIterator::increment):
(WebCore::InlineIterator::characterAt):
(WebCore::InlineIterator::direction):
- rendering/InlineTextBox.h:
(WebCore::InlineTextBox::renderer):
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::updateFirstLetterStyle):
(WebCore::RenderBlock::updateFirstLetter):
- rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::deleteLineBoxesBeforeSimpleLineLayout):
(WebCore::isVisibleRenderText):
(WebCore::RenderBlockFlow::adjustComputedFontSizes):
(WebCore::stripTrailingSpace):
(WebCore::RenderBlockFlow::computeInlinePreferredLogicalWidths):
- rendering/RenderBlockLineLayout.cpp:
(WebCore::createInlineBoxForRenderer):
(WebCore::dirtyLineBoxesForRenderer):
(WebCore::reachedEndOfTextRenderer):
(WebCore::RenderBlockFlow::computeInlineDirectionPositionsForSegment):
(WebCore::RenderBlockFlow::computeBlockDirectionPositionsForLine):
(WebCore::RenderBlockFlow::handleTrailingSpaces):
(WebCore::RenderBlockFlow::determineStartPosition):
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::moveChildrenTo):
- rendering/RenderElement.cpp:
(WebCore::RenderElement::hasImmediateNonWhitespaceTextChildOrBorderOrOutline):
(WebCore::RenderElement::addChild):
- rendering/RenderInline.cpp:
(WebCore::RenderInline::generateCulledLineBoxRects):
(WebCore::RenderInline::culledInlineFirstLineBox):
(WebCore::RenderInline::culledInlineLastLineBox):
(WebCore::RenderInline::culledInlineVisualOverflowBoundingBox):
(WebCore::RenderInline::dirtyLineBoxes):
- rendering/RenderInline.h:
Make borderBoundingBox() public so that call sites (here
WebRenderNode.mm) can use tighter typing and benefit from the virtual
function being final.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::calculateClipRects):
- rendering/RenderLineBoxList.cpp:
(WebCore::RenderLineBoxList::dirtyLinesFromChangedChild):
- rendering/RenderNamedFlowThread.cpp:
(WebCore::RenderNamedFlowThread::getRanges):
- rendering/RenderRubyRun.cpp:
(WebCore::RenderRubyRun::getOverhang):
- rendering/RenderSelectionInfo.cpp:
(WebCore::RenderSelectionInfo::RenderSelectionInfo):
- rendering/RenderText.cpp:
(WebCore::isInlineFlowOrEmptyText):
(WebCore::RenderText::previousCharacter):
- rendering/RenderText.h:
(WebCore::Text::renderer):
- rendering/RenderTextFragment.h:
(isType):
- rendering/RenderTreeAsText.cpp:
(WebCore::RenderTreeAsText::writeRenderObject):
(WebCore::write):
- rendering/SimpleLineLayout.cpp:
(WebCore::SimpleLineLayout::canUseFor):
(WebCore::SimpleLineLayout::create):
- rendering/SimpleLineLayoutFunctions.cpp:
(WebCore::SimpleLineLayout::paintFlow):
(WebCore::SimpleLineLayout::hitTestFlow):
- rendering/SimpleLineLayoutResolver.h:
(WebCore::SimpleLineLayout::RunResolver::RunResolver):
- rendering/TextAutoSizing.cpp:
(WebCore::TextAutoSizingValue::addNode):
- rendering/TextAutosizer.cpp:
(WebCore::TextAutosizer::containerIsRowOfLinks):
(WebCore::TextAutosizer::measureDescendantTextWidth):
- rendering/line/BreakingContextInlineHeaders.h:
(WebCore::BreakingContext::commitLineBreakAtCurrentWidth):
(WebCore::shouldAddBorderPaddingMargin):
(WebCore::shouldSkipWhitespaceAfterStartObject):
(WebCore::BreakingContext::handleText):
(WebCore::textBeginsWithBreakablePosition):
(WebCore::BreakingContext::canBreakAtThisPosition):
Source/WebKit/mac:
- WebView/WebRenderNode.mm:
(copyRenderNode):
Source/WebKit2:
Use is<>() / downcast<>() for RenderText / RenderTextFragment.
- Shared/WebRenderObject.cpp:
(WebKit::WebRenderObject::WebRenderObject):
- 12:11 PM Changeset in webkit [174402] by
-
- 20 edits5 adds in trunk
[Media] Expose AudioTracks in the "captions" menu.
https://bugs.webkit.org/show_bug.cgi?id=137472
Reviewed by Brent Fulgham.
Source/WebCore:
Test: media/video-controls-audiotracks-trackmenu.html
If more than one AudioTrack is present in the video element, add those tracks to the
captions menu:
- English.lproj/mediaControlsLocalizedStrings.js:
- Modules/mediacontrols/mediaControlsApple.js:
(Controller.prototype.addVideoListeners):
(Controller.prototype.removeVideoListeners):
(Controller.prototype.handleAudioTrackChange):
(Controller.prototype.handleAudioTrackAdd):
(Controller.prototype.handleAudioTrackRemove):
(Controller.prototype.updateCaptionButton):
(Controller.prototype.buildCaptionMenu):
(Controller.prototype.handleCaptionItemKeyUp):
(Controller.prototype.audioTrackItemSelected):
(Controller.prototype.focusSiblingAudioTrackItem):
(Controller.prototype.handleAudioTrackItemKeyUp):
Add support to MediaControlHost for retrieving the sorted audio track list, and the
localized names for every audio track:
- Modules/mediacontrols/MediaControlsHost.cpp:
(WebCore::MediaControlsHost::sortedTrackListForMenu):
(WebCore::MediaControlsHost::displayNameForTrack):
- Modules/mediacontrols/MediaControlsHost.h:
- Modules/mediacontrols/MediaControlsHost.idl:
- page/CaptionUserPreferences.cpp:
(WebCore::trackDisplayName):
(WebCore::CaptionUserPreferences::displayNameForTrack):
(WebCore::CaptionUserPreferences::sortedTrackListForMenu):
- page/CaptionUserPreferences.h:
- platform/LocalizedStrings.cpp:
(WebCore::audioTrackNoLabelText):
- platform/LocalizedStrings.h:
- platform/efl/LocalizedStringsEfl.cpp:
(WebCore::audioTrackNoLabelText):
- platform/gtk/LocalizedStringsGtk.cpp:
(WebCore::audioTrackNoLabelText):
Drive-by fix; do not recurse into AudioTrackPrivate->setEnabled() when the enabled
state changes.
- html/track/AudioTrack.cpp:
(WebCore::AudioTrack::enabledChanged):
Fix possible out-of-bounds Vector access when adding tracks to a track list by
sorting the list at insert time, rather than inserting into the track's reported
position in the Vector:
- html/track/AudioTrackList.cpp:
(AudioTrackList::append):
- html/track/VideoTrackList.cpp:
(VideoTrackList::append):
Correctly report the trackIndex of audio and video tracks from AVFoundation:
- platform/graphics/avfoundation/AudioTrackPrivateAVF.h:
(WebCore::AudioTrackPrivateAVF::trackIndex):
(WebCore::AudioTrackPrivateAVF::setTrackIndex):
(WebCore::AudioTrackPrivateAVF::AudioTrackPrivateAVF):
- platform/graphics/avfoundation/VideoTrackPrivateAVF.h:
(WebCore::VideoTrackPrivateAVF::trackIndex):
(WebCore::VideoTrackPrivateAVF::setTrackIndex):
(WebCore::VideoTrackPrivateAVF::VideoTrackPrivateAVF):
- platform/graphics/avfoundation/objc/AudioTrackPrivateAVFObjC.mm:
(WebCore::AudioTrackPrivateAVFObjC::resetPropertiesFromTrack):
- platform/graphics/avfoundation/objc/VideoTrackPrivateAVFObjC.cpp:
(WebCore::VideoTrackPrivateAVFObjC::resetPropertiesFromTrack):
LayoutTests:
- media/content/audio-tracks.mp4: Added.
- media/content/audio-tracks.ogg: Added.
- media/content/audio-tracks.webm: Added.
- media/video-controls-audiotracks-trackmenu-expected.txt: Added.
- media/video-controls-audiotracks-trackmenu.html: Added.
- 11:57 AM Changeset in webkit [174401] by
-
- 15 edits in trunk/Source/JavaScriptCore
Remove op_new_captured_func
https://bugs.webkit.org/show_bug.cgi?id=137491
Reviewed by Mark Lam.
Removes the op_captured_new_func opcode as part of the work
towards having any magical opcodes that write directly to
named "registers" and then have a follow on op to ensure that
the environment record correctly represents the stack state.
For this we add a non-captured scratch register so we don't
have to have any kind of magic opcode, and instead simply
have sensible creation and move semantics for capturing new
functions.
- bytecode/BytecodeList.json:
- bytecode/BytecodeUseDef.h:
(JSC::computeUsesForBytecodeOffset):
(JSC::computeDefsForBytecodeOffset):
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dumpBytecode):
(JSC::CodeBlock::CodeBlock):
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::emitNewFunction):
(JSC::BytecodeGenerator::emitLazyNewFunction):
(JSC::BytecodeGenerator::emitNewFunctionInternal):
- bytecompiler/BytecodeGenerator.h:
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
- dfg/DFGCapabilities.cpp:
(JSC::DFG::capabilityLevel):
- jit/JIT.cpp:
(JSC::JIT::privateCompileMainPass):
- jit/JIT.h:
- jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_new_captured_func): Deleted.
- llint/LowLevelInterpreter32_64.asm:
- llint/LowLevelInterpreter64.asm:
- runtime/CommonSlowPaths.cpp:
(JSC::SLOW_PATH_DECL): Deleted.
- runtime/CommonSlowPaths.h:
- 11:41 AM Changeset in webkit [174400] by
-
- 15 edits1 move in trunk/Source
[WK2] Use is<>() / downcast<>() for DrawingAreaProxy subclasses
https://bugs.webkit.org/show_bug.cgi?id=137477
Reviewed by Andreas Kling.
Source/WebCore:
Include TypeCastsCF.h now that the header was renamed.
No new tests, no behavior change.
- platform/cf/SharedBufferCF.cpp:
Source/WebKit2:
Use is<>() / downcast<>() for DrawingAreaProxy subclasses.
- Shared/cf/KeyedDecoder.cpp:
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _didCommitLoadForMainFrame]):
(-[WKWebView _restorePageStateToExposedRect:scale:]):
(-[WKWebView _restorePageStateToUnobscuredCenter:scale:]):
- UIProcess/Cocoa/WebPageProxyCocoa.mm:
- UIProcess/DrawingAreaProxy.h:
- UIProcess/Scrolling/RemoteScrollingCoordinatorProxy.cpp:
(WebKit::RemoteScrollingCoordinatorProxy::layerTreeHost):
- UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::WebPageProxy::updateVisibleContentRects):
(WebKit::WebPageProxy::dynamicViewportUpdateChangedTarget):
- UIProcess/ios/WebVideoFullscreenManagerProxy.mm:
(WebKit::WebVideoFullscreenManagerProxy::setupFullscreenWithID):
- UIProcess/mac/LegacySessionStateCoding.cpp:
- UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.h:
- UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.h:
Source/WTF:
Rename wtf/cf/TypeCasts.h to wtf/cf/TypeCastsCF.h to avoid conflict
with wtf/TypeCasts.h. They were using the same #ifndef guard and it
was causing problems when both were included in the same context.
- WTF.xcodeproj/project.pbxproj:
- wtf/cf/TypeCastsCF.h: Renamed from Source/WTF/wtf/cf/TypeCasts.h.
(WTF::dynamic_cf_cast):
(WTF::checked_cf_cast):
- 10:15 AM Changeset in webkit [174399] by
-
- 2 edits in trunk/Source/WTF
Try to fix the Mountain Lion build.
- wtf/text/StringView.h:
(WTF::StringView::underlyingStringIsValid):
(WTF::StringView::setUnderlyingString):
(WTF::StringView::invalidate):
- 9:36 AM Changeset in webkit [174398] by
-
- 2 edits in trunk/Source/WTF
Use "1", not "true".
- wtf/text/StringView.h:
- 9:20 AM Changeset in webkit [174397] by
-
- 2 edits in trunk/Source/WTF
Temporarily disable the StringView lifetime checking.
- wtf/text/StringView.h:
- 9:12 AM Changeset in webkit [174396] by
-
- 2 edits in trunk/Tools
[GTK] jhbuild modules should build xserver with the --without-dtrace option.
https://bugs.webkit.org/show_bug.cgi?id=137482
Patch by Youenn Fablet <youenn.fablet@crf.canon.fr> on 2014-10-07
Reviewed by Martin Robinson.
- gtk/jhbuild.modules: Added --without-dtrace option to xserver jhbuild.modules config.
- 9:06 AM Changeset in webkit [174395] by
-
- 2 edits in trunk/Source/WTF
Another build fix attempt.
- wtf/text/StringView.cpp:
(WTF::StringView::UnderlyingString::UnderlyingString):
- 8:49 AM Changeset in webkit [174394] by
-
- 4 edits in trunk
[SOUP] TLS errors should take precedence over HTTP authentication
https://bugs.webkit.org/show_bug.cgi?id=137300
Reviewed by Sergio Villar Senin.
Source/WebCore:
Handle TLS errors in got-headers callback to make sure it happens
before starting the authentication process.
- platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::handleUnignoredTLSErrors): Refactored to receive the
soup message.
(WebCore::gotHeadersCallback): Return early and cancel the request in case of TLS errors.
(WebCore::sendRequestCallback): Do not handle TLS errors here, the request should have already been
cancelled at this point in case of TLS errors.
Tools:
Add a test case to check that authenticate signal is not emitted
in case of TLS errors, and the load fails instead.
- TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
(webViewAuthenticationCallback):
(testTLSErrorsHTTPAuth):
(httpsServerCallback):
(beforeAll):
- 8:47 AM Changeset in webkit [174393] by
-
- 2 edits in trunk/Source/WTF
Try to fix the Windows build.
- wtf/text/StringView.cpp:
(WTF::StringView::UnderlyingString::UnderlyingString):
- 12:42 AM Changeset in webkit [174392] by
-
- 15 edits in releases/WebKitGTK/webkit-2.6/Source
Merge r173776 - Multithreaded WebGL is a bad idea - remove it
https://bugs.webkit.org/show_bug.cgi?id=136964
<rdar://problem/18399858>
Reviewed by Brent Fulgham.
Source/WebCore:
We should not allow multithreaded GL access. Remove the
feature.
- html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::create):
- page/Settings.in:
- platform/graphics/GraphicsContext3D.h:
(WebCore::GraphicsContext3D::Attributes::Attributes):
- platform/graphics/mac/GraphicsContext3DMac.mm:
(WebCore::GraphicsContext3D::GraphicsContext3D):
Source/WebKit/mac:
Remove the setting to allow multithreaded WebGL.
- WebView/WebPreferenceKeysPrivate.h:
- WebView/WebPreferences.mm:
(+[WebPreferences initialize]):
(-[WebPreferences multithreadedWebGLEnabled]): Deleted.
(-[WebPreferences setMultithreadedWebGLEnabled:]): Deleted.
- WebView/WebPreferencesPrivate.h:
- WebView/WebView.mm:
(-[WebView _preferencesChanged:]):
Source/WebKit2:
Remove the setting to allow multithreaded WebGL.
- Shared/WebPreferencesDefinitions.h:
- UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetMultithreadedWebGLEnabled): Deleted.
(WKPreferencesGetMultithreadedWebGLEnabled): Deleted.
- UIProcess/API/C/WKPreferencesRefPrivate.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):
- 12:26 AM Changeset in webkit [174391] by
-
- 3 edits6 adds in releases/WebKitGTK/webkit-2.6
Merge r174002 - [GTK] Fix support for the initial-letter CSS property to first-letter
https://bugs.webkit.org/show_bug.cgi?id=137108
Patch by Lorenzo Tilve <ltilve@igalia.com> on 2014-09-26
Reviewed by Alejandro G. Castro.
Source/WebCore:
Add support for cap-height to the font system.
- platform/graphics/freetype/SimpleFontDataFreeType.cpp:
(WebCore::SimpleFontData::platformInit):
LayoutTests:
Add missing GTK test expectation files after http://webkit.org/b/136484
- platform/gtk/fast/css-generated-content/initial-letter-basic-expected.txt: Added.
- platform/gtk/fast/css-generated-content/initial-letter-border-padding-expected.txt: Added.
- platform/gtk/fast/css-generated-content/initial-letter-clearance-expected.txt: Added.
- platform/gtk/fast/css-generated-content/initial-letter-descender-expected.txt: Added.
- platform/gtk/fast/css-generated-content/initial-letter-raised-expected.txt: Added.
- platform/gtk/fast/css-generated-content/initial-letter-sunken-expected.txt: Added.
- 12:23 AM Changeset in webkit [174390] by
-
- 47 edits9 copies7 adds12 deletes in releases/WebKitGTK/webkit-2.6/Source/WebInspectorUI
Merge r174207 - Web Inspector: [GTK] Missing icons and enhancing the proportion and visibility of some icons
https://bugs.webkit.org/show_bug.cgi?id=137248
Reviewed by Carlos Garcia Campos.
Add more free icons and removed some unused ones for the Web
Inspector in GTK+.
Also, enhanced the visibility and/or proportion of several of the
icons.
- UserInterface/Images/gtk/AUTHORS:
- UserInterface/Images/gtk/COPYING:
- UserInterface/Images/gtk/Checkers.svg: Added.
- UserInterface/Images/gtk/Circle.svg: Added.
- UserInterface/Images/gtk/CloseLarge.svg: Added.
- UserInterface/Images/gtk/CloseTimeline.png: Removed.
- UserInterface/Images/gtk/CloseTimeline@2x.png: Removed.
- UserInterface/Images/gtk/Crosshair.svg:
- UserInterface/Images/gtk/DOMCharacterData.svg:
- UserInterface/Images/gtk/DOMComment.svg:
- UserInterface/Images/gtk/DOMDocument.svg:
- UserInterface/Images/gtk/DOMDocumentType.svg:
- UserInterface/Images/gtk/DOMElement.svg:
- UserInterface/Images/gtk/DOMNode.svg:
- UserInterface/Images/gtk/DOMTextNode.svg:
- UserInterface/Images/gtk/DOMTree.svg:
- UserInterface/Images/gtk/EventListener.svg:
- UserInterface/Images/gtk/Exception.svg:
- UserInterface/Images/gtk/Function.svg:
- UserInterface/Images/gtk/GradientStop.png: Added.
- UserInterface/Images/gtk/GradientStop@2x.png: Added.
- UserInterface/Images/gtk/GradientStopSelected.png: Added.
- UserInterface/Images/gtk/GradientStopSelected@2x.png: Added.
- UserInterface/Images/gtk/Issues.svg:
- UserInterface/Images/gtk/IssuesEnabled.svg:
- UserInterface/Images/gtk/LessColumns.svg: Removed.
- UserInterface/Images/gtk/Logs.svg:
- UserInterface/Images/gtk/Memory.svg: Removed.
- UserInterface/Images/gtk/MoreColumns.svg: Removed.
- UserInterface/Images/gtk/Native.svg:
- UserInterface/Images/gtk/NavigationItemAngleBrackets.svg:
- UserInterface/Images/gtk/NavigationItemBrushAndRuler.svg:
- UserInterface/Images/gtk/NavigationItemBug.svg:
- UserInterface/Images/gtk/NavigationItemFile.svg:
- UserInterface/Images/gtk/NavigationItemLayers.svg:
- UserInterface/Images/gtk/NavigationItemMagnifyingGlass.svg: Removed.
- UserInterface/Images/gtk/NavigationItemProbes.pdf: Added.
- UserInterface/Images/gtk/NavigationItemStopwatch.svg:
- UserInterface/Images/gtk/NavigationItemTypes.svg: Added.
- UserInterface/Images/gtk/PaintFlashing.svg: Added.
- UserInterface/Images/gtk/PseudoElement.svg:
- UserInterface/Images/gtk/Record.svg: Added.
- UserInterface/Images/gtk/Recording.png: Removed.
- UserInterface/Images/gtk/Recording@2x.png: Removed.
- UserInterface/Images/gtk/RecordingHovered.png: Removed.
- UserInterface/Images/gtk/RecordingHovered@2x.png: Removed.
- UserInterface/Images/gtk/RecordingStopped.png: Removed.
- UserInterface/Images/gtk/RecordingStopped@2x.png: Removed.
- UserInterface/Images/gtk/Reflection.svg:
- UserInterface/Images/gtk/ReplayPauseButton.svg: Added.
- UserInterface/Images/gtk/ReplayPlayButton.svg: Added.
- UserInterface/Images/gtk/ReplayRecordingButton.svg: Added.
- UserInterface/Images/gtk/Request.svg:
- UserInterface/Images/gtk/Resources.svg:
- UserInterface/Images/gtk/Response.svg:
- UserInterface/Images/gtk/ResultLine.svg:
- UserInterface/Images/gtk/SourceCode.svg:
- UserInterface/Images/gtk/Stop.svg: Added.
- UserInterface/Images/gtk/StyleRuleAuthor.svg:
- UserInterface/Images/gtk/StyleRuleInherited.svg:
- UserInterface/Images/gtk/StyleRuleInheritedElement.svg:
- UserInterface/Images/gtk/StyleRuleInspector.svg:
- UserInterface/Images/gtk/StyleRuleUser.svg:
- UserInterface/Images/gtk/StyleRuleUserAgent.svg:
- UserInterface/Images/gtk/Time.svg:
- UserInterface/Images/gtk/TimelineRecordAnimation.svg:
- UserInterface/Images/gtk/TimelineRecordConsoleProfile.svg: Added.
- UserInterface/Images/gtk/TimelineRecordEvent.svg:
- UserInterface/Images/gtk/TimelineRecordLayout.svg:
- UserInterface/Images/gtk/TimelineRecordPaint.svg:
- UserInterface/Images/gtk/TimelineRecordProbeSampled.svg: Added.
- UserInterface/Images/gtk/TimelineRecordScriptEvaluated.svg:
- UserInterface/Images/gtk/TimelineRecordStyle.svg:
- UserInterface/Images/gtk/TimelineRecordTimer.svg:
- UserInterface/Images/gtk/Weight.svg:
- 12:06 AM Changeset in webkit [174389] by
-
- 2 edits in trunk/Source/WebCore
Fix a warning when passing an NSInteger to abs().
https://bugs.webkit.org/show_bug.cgi?id=137480
Reviewed by Mark Rowe.
Use std::abs() instead, which is overloaded for both long (a.k.a. NSInteger) and int.
- platform/graphics/avfoundation/objc/CDMSessionMediaSourceAVFObjC.mm:
(WebCore::CDMSessionMediaSourceAVFObjC::layerDidReceiveError):
(WebCore::CDMSessionMediaSourceAVFObjC::rendererDidReceiveError):
Oct 6, 2014:
- 11:58 PM Changeset in webkit [174388] by
-
- 9 edits1 add in trunk/Source
Make StringView check the lifetime of the StringImpl it's created from
https://bugs.webkit.org/show_bug.cgi?id=137202
Reviewed by Anders Carlsson.
Source/WebCore:
- platform/graphics/TextRun.cpp: Update since TextRun's definition now
uses a StringView.
Source/WTF:
- WTF.vcxproj/WTF.vcxproj: Added StringView.cpp.
- WTF.vcxproj/WTF.vcxproj.filters: Added StringView.cpp.
- WTF.xcodeproj/project.pbxproj: Added StringView.cpp.
- wtf/CMakeLists.txt: Added StringView.cpp.
- wtf/text/StringImpl.cpp:
(WTF::StringImpl::~StringImpl): Call StringView::invalidate.
- wtf/text/StringView.cpp: Added.
(WTF::underlyingStrings): Returns map from StringImpl to the underlying
string object used by StringView to track validity.
(WTF::StringView::invalidate): Mark the underlying string object invalid,
and remove it from the map, so any future StringImpl will get a new one,
even if it has the same pointer.
(WTF::StringView::underlyingStringIsValid): Return true only if the
underlying string is still valid.
(WTF::StringView::setUnderlyingString): Create and manage reference counts
of underlying string objects as needed.
- wtf/text/StringView.h: Moved function bodies out of the class definition,
so we can now read a clean class definition to see the class design and what
functions it offers.
(WTF::StringView::StringView): Added a comment to the default constructor.
Also added copy and move constructors so they can call setUnderlyingString
and assert the underlying string is valid as needed, replacing the
compiler-generated ones.
(WTF::StringView::~StringView): Added a call to setUnderlyingString.
(WTF::StringView::operator=): Added these assignment operators with the same
job as the constructors above.
(WTF::StringView::initialize): Added a comment.
(WTF::StringView::characters8): Added an assertion that the underlying
string is valid.
(WTF::StringView::characters16): Ditto.
(WTF::StringView::substring): Added code to propagate the underlying string
from the original string to the substring.
(WTF::StringView::invalidate): Inline empty version of this function for
non-debug builds.
(WTF::StringView::underlyingStringIsValid): Ditto.
(WTF::StringView::setUnderlyingString): Ditto.
- 11:54 PM Changeset in webkit [174387] by
-
- 2 edits in trunk/Source/WebKit2
Remove unused warning in WebPageOverlay
https://bugs.webkit.org/show_bug.cgi?id=137444
Reviewed by Darin Adler.
Commenting the unused parameter to supress the warning.
- WebProcess/WebPage/WebPageOverlay.h:
(WebKit::WebPageOverlay::Client::copyAccessibilityAttributeStringValueForPoint):
(WebKit::WebPageOverlay::Client::copyAccessibilityAttributeBoolValueForPoint):
- 11:19 PM Changeset in webkit [174386] by
-
- 2 edits in trunk/Source/JavaScriptCore
Objective-C objects must be fully defined when used in a WTF::Vector
https://bugs.webkit.org/show_bug.cgi?id=137479
Reviewed by Mark Rowe.
When compiling an Objective-C++ file under ARC, @class types are considered non-trivially destructable, so
Vector needs to see their definition in order to call their destructor.
See <http://clang.llvm.org/docs/AutomaticReferenceCounting.html#ownership-qualified-fields-of-structs-and-unions> for details.
- API/ObjcRuntimeExtras.h: Imported <objc/Protocol.h>.
- 10:26 PM Changeset in webkit [174385] by
-
- 2 edits in trunk/Tools
Make webkit-patch find-users useful
https://bugs.webkit.org/show_bug.cgi?id=137475
Reviewed by Alexey Proskuryakov.
Make find-users use the CommitterList instead of accessing Bugzilla.
This essentially exposes the same functionality as webkitbot's whois command.
- Scripts/webkitpy/tool/commands/findusers.py:
(FindUsers.execute):
- 9:42 PM Changeset in webkit [174384] by
-
- 8 edits in trunk/Source/WebKit2
Call WKPageUIClient::isPlayingAudioDidChange() whenever audio starts/stops playing on a page.
https://bugs.webkit.org/show_bug.cgi?id=137050
Reviewed by Anders Carlsson.
Implement WebChromeClient::isPlayingAudioDidChange() which sends the new isPlayingAudio state
over to the UI process. WebPageProxy caches the isPlayingAudio state, and when that changes,
it calls WKPageUIClient::isPlayingAudioDidChange().
- UIProcess/API/APIUIClient.h:
(API::UIClient::isPlayingAudioDidChange):
- UIProcess/API/C/WKPage.cpp:
(WKPageSetPageUIClient):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::isPlayingAudioDidChange):
- UIProcess/WebPageProxy.h:
(WebKit::WebPageProxy::isPlayingAudio):
- UIProcess/WebPageProxy.messages.in:
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::isPlayingAudioDidChange):
- WebProcess/WebCoreSupport/WebChromeClient.h:
- 8:32 PM Changeset in webkit [174383] by
-
- 3 edits in trunk/Source/WebCore
[iOS] Fix remaining misuses of abs() and fabsf()
https://bugs.webkit.org/show_bug.cgi?id=130947
Reviewed by Simon Fraser.
Fixed issues found when compiling with -Wabsolute-value.
- platform/ios/ScrollAnimatorIOS.mm:
(WebCore::ScrollAnimatorIOS::handleTouchEvent): Called abs() instead of fabsf for integral types. Explicitly
cast the divisor to float in the call to atanf().
- platform/ios/wak/WKView.mm:
(_WKViewAutoresizeCoord): Explicitly cast origMarginsTotal to an int before calling abs(). Added a FIXME
indicating the strange behavior when origMarginsTotal is in the range (0, 1) (as pointed out by Darin).
- 8:28 PM Changeset in webkit [174382] by
-
- 9 edits in trunk/Source/WebCore
CanvasPattern always has an internal WebCore::Pattern.
<https://webkit.org/b/137456>
Use more Ref & PassRef for CanvasPattern and Pattern.
Removed some impossible null checks in GraphicsContext that
got exposed as compile errors with these changes.
Reviewed by Anders Carlsson.
- html/canvas/CanvasPattern.h:
(WebCore::CanvasPattern::pattern):
- platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContext::setStrokePattern):
(WebCore::GraphicsContext::setFillPattern):
- platform/graphics/GraphicsContext.h:
- platform/graphics/Pattern.cpp:
(WebCore::Pattern::create):
- platform/graphics/Pattern.h:
- platform/graphics/filters/FETile.cpp:
(WebCore::FETile::platformApplySoftware):
- rendering/svg/RenderSVGPath.cpp:
(WebCore::useStrokeStyleToFill):
- rendering/svg/RenderSVGResourcePattern.cpp:
(WebCore::RenderSVGResourcePattern::applyResource):
- 8:10 PM Changeset in webkit [174381] by
-
- 2 edits in trunk/Source/JavaScriptCore
[Win] Use of 1-bit Enum type behaves improperly
https://bugs.webkit.org/show_bug.cgi?id=137471
<rdar://problem/18559172>
Reviewed by Mark Lam.
Represent 1-bit enum element as 'unsigned', as we have done elsewhere
in WebKit to avoid problems when building with MSVC.
- debugger/Debugger.h:
- 7:33 PM Changeset in webkit [174380] by
-
- 8 edits in trunk/Source
[EFL] Restore previous scroll position using restoreViewState()
https://bugs.webkit.org/show_bug.cgi?id=136999
Reviewed by Benjamin Poulain.
There are duplicating code paths to restore previous scroll position and scale factor in
HistoryController::restoreScrollPositionAndViewState. EFL port has processed the two code paths.
It causes wrong rendering update or scroll position change when previous page's scroll position
is restored. Thus EFL port begins to use restoreViewState() to restore scroll position and scale factor.
This patch is first step to support it.
Additionally EFL port has supported to use ScrollingCoordinatorCoordinatedGraphics::requestScrollPositionUpdate()
since r173785. So EFL port can use the requestScrollPositionUpdate() to restore scroll position on previous page
instead of delegatedScrollRequested(). However setScrollPosition() can't be used there for now, because iOS port
should call it when delegatesScrolling is disabled. On the other hand, EFL port supports it only when delegatesScrolling
is enabled.
Source/WebCore:
Test covered by WKViewRestoreZoomAndScrollBackForward API test.
- loader/HistoryController.cpp:
(WebCore::HistoryController::restoreScrollPositionAndViewState):
EFL port only calls restoreViewState() to restore previous page's view state.
- page/Page.cpp:
(WebCore::Page::setPageScaleFactor):
Source/WebKit2:
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::saveViewStateToItem):
Move iOS saveViewStateToItem() to common place in order to share iOS implementation with EFL port.
(WebKit::WebFrameLoaderClient::restoreViewState):
EFL begins to share restoreViewState() of iOS, thus move iOS restoreViewState() to common place.
- WebProcess/WebCoreSupport/ios/WebFrameLoaderClientIOS.mm:
(WebKit::WebFrameLoaderClient::saveViewStateToItem): Deleted.
(WebKit::WebFrameLoaderClient::restoreViewState): Deleted.
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/efl/WebPageEfl.cpp:
(WebKit::WebPage::restorePageState):
Call scalePage() to update previous scaleFactor and scrollPosition of historyItem both to WebProcess and UIProcess.
(WebKit::WebPage::savePageState):
- 6:55 PM Changeset in webkit [174379] by
-
- 4 edits in trunk/Source/WebCore
Web Inspector: Highlighted selectors in Rules sidebar break with selectors that contain nested selector lists
https://bugs.webkit.org/show_bug.cgi?id=137378
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-10-06
Reviewed by Joseph Pecoraro.
We should not update the parser's selectorRange when matching a nested selector list.
To implement this with low risk of unbalanced start+end and good error recovery,
I have wrapped the parsing of selector_list between a start/end function at the grammar
level. Whenever the parser enter a nested selector list, m_nestedSelectorLevel goes up
by one. Any time the parsing is currently in a nested selector list, we never update
the selector ranges.
- css/CSSGrammar.y.in:
- css/CSSParser.cpp:
(WebCore::CSSParser::CSSParser):
(WebCore::CSSParser::markSelectorStart):
(WebCore::CSSParser::markSelectorEnd):
- css/CSSParser.h:
(WebCore::CSSParser::startNestedSelectorList):
(WebCore::CSSParser::endNestedSelectorList):
- 6:16 PM Changeset in webkit [174378] by
-
- 2 edits in trunk/Source/WebCore
[Windows] Build fix for EWS bots.
- WebCore.vcxproj/WebCoreGenerated.make: Make sure we always regenerate WebCore derived sources.
- 6:15 PM Changeset in webkit [174377] by
-
- 2 edits in trunk/Source/WTF
[Win] DateMath's calculateUTFOffset does not account for DST.
https://bugs.webkit.org/show_bug.cgi?id=137458
<rdar://problem/18559172>
Reviewed by Geoffrey Garen.
Check the return value of GetTimeZoneInformation and use the
proper bias against UTC (depending on whether we are in daylight
savings time, or standard time).
Also, handle possible error cases in the FileTimeToSystemTime
and SystemTimeToTzSpecificLocalTime, rather than using potentially
uninitialized values.
- wtf/DateMath.cpp:
(WTF::calculateUTCOffset): Use proper daylight-savings-time state.
(WTF::calculateDSTOffset): Avoid uninitialized data due to failing
API calls.
- 6:10 PM Changeset in webkit [174376] by
-
- 2 edits in trunk/Tools
AX: iOS8: Crash at -[WebAccessibilityObjectWrapper accessibilityElementAtIndex:]
https://bugs.webkit.org/show_bug.cgi?id=137289
Unreviewed build fix.
- DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
(AccessibilityUIElement::getChildrenWithRange):
- 5:26 PM Changeset in webkit [174375] by
-
- 97 edits in trunk/Source
Add is<>() / downcast<>() support for RenderObject subclasses
https://bugs.webkit.org/show_bug.cgi?id=137424
Reviewed by Benjamin Poulain.
Source/WebCore:
Add is<>() / downcast<>() support for RenderObject subclasses, and
get rid of IsRendererOfType traits struct as we can now rely on the
TypeCastsTraits instead.
toRender*() is still supported for most render objects because I did
not want to remove all usages in this patch, to keep the size small.
For now, only the MathML render objects were ported over to using
is<>() / downcast<>(). Other render objects will be taken care of in
follow-up patches and I will drop support for toRender*()
incrementally.
No new tests, no behavior change.
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::isMathFenceOperator):
(WebCore::AccessibilityRenderObject::isMathSeparatorOperator):
(WebCore::AccessibilityRenderObject::mathLineThickness):
- dom/make_names.pl:
(printTypeHelpers):
- mathml/MathMLInlineContainerElement.cpp:
(WebCore::MathMLInlineContainerElement::childrenChanged):
- mathml/MathMLTextElement.cpp:
(WebCore::MathMLTextElement::didAttachRenderers):
(WebCore::MathMLTextElement::childrenChanged):
- rendering/RenderAncestorIterator.h:
(WebCore::lineageOfType):
- rendering/RenderBlock.h:
- rendering/RenderBlockFlow.h:
- rendering/RenderBox.h:
- rendering/RenderBoxModelObject.h:
- rendering/RenderButton.h:
- rendering/RenderCombineText.h:
- rendering/RenderCounter.h:
- rendering/RenderDetailsMarker.h:
- rendering/RenderElement.h:
- rendering/RenderEmbeddedObject.h:
- rendering/RenderFieldset.h:
- rendering/RenderFileUploadControl.h:
- rendering/RenderFlexibleBox.h:
- rendering/RenderFlowThread.h:
- rendering/RenderFrame.h:
- rendering/RenderFrameSet.h:
- rendering/RenderFullScreen.h:
- rendering/RenderGrid.h:
- rendering/RenderHTMLCanvas.h:
- rendering/RenderIFrame.h:
- rendering/RenderImage.h:
- rendering/RenderInline.h:
- rendering/RenderIterator.h:
(WebCore::isRendererOfType):
(WebCore::RenderTraversal::firstChild):
(WebCore::RenderTraversal::lastChild):
(WebCore::RenderTraversal::nextSibling):
(WebCore::RenderTraversal::previousSibling):
(WebCore::RenderTraversal::findAncestorOfType):
- rendering/RenderLayerModelObject.h:
- rendering/RenderLineBreak.h:
- rendering/RenderListBox.h:
- rendering/RenderListItem.h:
- rendering/RenderListMarker.h:
- rendering/RenderMedia.h:
- rendering/RenderMenuList.h:
- rendering/RenderMeter.h:
- rendering/RenderMultiColumnFlowThread.h:
- rendering/RenderMultiColumnSet.h:
- rendering/RenderMultiColumnSpannerPlaceholder.h:
- rendering/RenderNamedFlowFragment.h:
- rendering/RenderNamedFlowThread.h:
- rendering/RenderObject.h:
(WebCore::RenderObject>): Deleted.
- rendering/RenderProgress.h:
- rendering/RenderQuote.h:
- rendering/RenderRegion.h:
- rendering/RenderReplaced.h:
- rendering/RenderRubyRun.h:
- rendering/RenderScrollbarPart.h:
- rendering/RenderSearchField.h:
- rendering/RenderSlider.h:
- rendering/RenderSnapshottedPlugIn.h:
- rendering/RenderTable.h:
- rendering/RenderTableCaption.h:
- rendering/RenderTableCell.h:
- rendering/RenderTableCol.h:
- rendering/RenderTableRow.h:
- rendering/RenderTableSection.h:
- rendering/RenderText.h:
- rendering/RenderTextControl.h:
- rendering/RenderTextControlMultiLine.h:
- rendering/RenderTextControlSingleLine.h:
- rendering/RenderTextFragment.h:
- rendering/RenderVideo.h:
- rendering/RenderView.h:
- rendering/RenderWidget.h:
- rendering/mathml/RenderMathMLBlock.h:
- rendering/mathml/RenderMathMLFenced.cpp:
(WebCore::RenderMathMLFenced::updateFromElement):
- rendering/mathml/RenderMathMLFraction.cpp:
(WebCore::RenderMathMLFraction::unembellishedOperator):
- rendering/mathml/RenderMathMLFraction.h:
- rendering/mathml/RenderMathMLOperator.h:
- rendering/mathml/RenderMathMLRadicalOperator.h:
- rendering/mathml/RenderMathMLRoot.cpp:
(WebCore::RenderMathMLRoot::baseWrapper):
(WebCore::RenderMathMLRoot::radicalWrapper):
(WebCore::RenderMathMLRoot::indexWrapper):
(WebCore::RenderMathMLRoot::radicalOperator):
(WebCore::RenderMathMLRootWrapper::removeChild):
- rendering/mathml/RenderMathMLRoot.h:
- rendering/mathml/RenderMathMLRow.cpp:
(WebCore::RenderMathMLRow::updateOperatorProperties):
(WebCore::RenderMathMLRow::layout):
- rendering/mathml/RenderMathMLRow.h:
- rendering/mathml/RenderMathMLScripts.cpp:
(WebCore::RenderMathMLScripts::addChildInternal):
(WebCore::RenderMathMLScripts::removeChildInternal):
(WebCore::RenderMathMLScripts::unembellishedOperator):
(WebCore::RenderMathMLScripts::layout):
(WebCore::RenderMathMLScriptsWrapper::addChildInternal):
(WebCore::RenderMathMLScriptsWrapper::addChild):
(WebCore::RenderMathMLScriptsWrapper::removeChildInternal):
(WebCore::RenderMathMLScriptsWrapper::removeChild):
- rendering/mathml/RenderMathMLScripts.h:
- rendering/mathml/RenderMathMLSpace.h:
- rendering/mathml/RenderMathMLSquareRoot.h:
- rendering/mathml/RenderMathMLToken.h:
- rendering/mathml/RenderMathMLUnderOver.cpp:
(WebCore::RenderMathMLUnderOver::unembellishedOperator):
- rendering/svg/RenderSVGContainer.h:
- rendering/svg/RenderSVGGradientStop.h:
- rendering/svg/RenderSVGImage.h:
- rendering/svg/RenderSVGInlineText.h:
- rendering/svg/RenderSVGModelObject.h:
- rendering/svg/RenderSVGPath.h:
- rendering/svg/RenderSVGResourceContainer.h:
- rendering/svg/RenderSVGResourceFilter.h:
- rendering/svg/RenderSVGRoot.h:
- rendering/svg/RenderSVGShape.h:
- rendering/svg/RenderSVGText.h:
- rendering/svg/RenderSVGTextPath.h:
- rendering/svg/RenderSVGViewportContainer.h:
Source/WTF:
Handle correctly calling TypeCastTraits<ExpectedType, ArgType>::isOfType(ArgType&)
with ExpectedType being a base class of ArgType (or the same as ArgType). The
previous template specialization was only meant to support the case where
ExpectedType is the same as ArgType but even that wasn't working as the compiler
would complain about ambiguous partial specializations. Since this is needed by
RenderTraversal functions, this patch adds an extra isBaseType template parameter
to TypeCastTraits to resolve the ambiguity and relies on std::is_base_of for the
detection.
- wtf/TypeCasts.h:
- 5:15 PM Changeset in webkit [174374] by
-
- 9 edits in trunk/Source/WebCore
Use is<>() / downcast<>() for ScrollingTreeNode subclasses
https://bugs.webkit.org/show_bug.cgi?id=137451
Reviewed by Tim Horton.
Use is<>() / downcast<>() for ScrollingTreeNode subclasses.
No new tests, no behavior change.
- page/scrolling/ScrollingTree.cpp:
(WebCore::ScrollingTree::handleWheelEvent):
(WebCore::ScrollingTree::viewportChangedViaDelegatedScrolling):
(WebCore::ScrollingTree::scrollPositionChangedViaDelegatedScrolling):
- page/scrolling/ScrollingTreeFrameScrollingNode.h:
- page/scrolling/ScrollingTreeNode.h:
- page/scrolling/ScrollingTreeOverflowScrollingNode.h:
- page/scrolling/ScrollingTreeScrollingNode.h:
- page/scrolling/mac/ScrollingTreeFixedNode.h:
- page/scrolling/mac/ScrollingTreeStickyNode.h:
- page/scrolling/mac/ScrollingTreeStickyNode.mm:
(WebCore::ScrollingTreeStickyNode::updateLayersAfterAncestorChange):
- 4:54 PM Changeset in webkit [174373] by
-
- 2 edits in trunk/Source/WebCore
Addressing post-review comment on r174297.
https://bugs.webkit.org/show_bug.cgi?id=137355
Unreviewed.
- rendering/RenderText.cpp:
(WebCore::RenderText::stringView):
- 3:44 PM Changeset in webkit [174372] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed merge fix for r174279.
https://bugs.webkit.org/show_bug.cgi?id=137097
- svg/SVGToOTFFontConversion.cpp:
(WebCore::SVGToOTFFontConverter::convertSVGToOTFFont):
- 3:17 PM Changeset in webkit [174371] by
-
- 10 edits in trunk/Source/JavaScriptCore
Fixed compiler warnings on Windows build.
<https://webkit.org/b/135205>
Reviewed by Geoffrey Garen.
Benchmarking with jsc shows that perf is neutral with this change.
- assembler/MacroAssemblerX86_64.h:
(JSC::MacroAssemblerX86_64::call):
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::CodeBlock):
- dfg/DFGArgumentPosition.h:
(JSC::DFG::ArgumentPosition::mergeShouldNeverUnbox):
(JSC::DFG::ArgumentPosition::mergeArgumentUnboxingAwareness):
- dfg/DFGEdge.h:
(JSC::DFG::Edge::makeWord):
- dfg/DFGNodeFlags.h:
(JSC::DFG::nodeMayOverflow):
(JSC::DFG::nodeMayNegZero):
- dfg/DFGOSRExitCompilerCommon.cpp:
(JSC::DFG::reifyInlinedCallFrames):
- dfg/DFGVariableAccessData.cpp:
(JSC::DFG::VariableAccessData::mergeIsCaptured):
- dfg/DFGVariableAccessData.h:
(JSC::DFG::VariableAccessData::mergeIsProfitableToUnbox):
(JSC::DFG::VariableAccessData::mergeStructureCheckHoistingFailed):
(JSC::DFG::VariableAccessData::mergeCheckArrayHoistingFailed):
(JSC::DFG::VariableAccessData::mergeIsArgumentsAlias):
(JSC::DFG::VariableAccessData::mergeIsLoadedFrom):
- runtime/JSDataViewPrototype.cpp:
(JSC::getData):
- 3:07 PM Changeset in webkit [174370] by
-
- 3 edits2 adds in trunk
REGRESSION (Simple Line Layout): Inline block baselines computed incorrectly
https://bugs.webkit.org/show_bug.cgi?id=137461
Reviewed by Simon Fraser.
Source/WebCore:
Added fast/inline-block/simple-line-layout.html
- rendering/SimpleLineLayoutFunctions.h:
(WebCore::SimpleLineLayout::computeFlowFirstLineBaseline):
(WebCore::SimpleLineLayout::computeFlowLastLineBaseline):
Fix the baseline computation functions in simple line layout to
use lineCount rather than runCount.
LayoutTests:
- fast/inline-block/simple-line-layout-expected.html: Added.
- fast/inline-block/simple-line-layout.html: Added.
- 3:07 PM Changeset in webkit [174369] by
-
- 13 edits in trunk/Source/WebKit2
[Mac] We are spending too much time serializing ProtectionSpace objects
https://bugs.webkit.org/show_bug.cgi?id=137367
Reviewed by Dan Bernstein.
When profiling the load of nytimes.com, I noticed that we were spending
a lot of CPU time serializing ProtectionSpace objects (in particular
the NSURLProtectionSpace platform data):
- 5.6% of CPU time for Network Process
- 2.5% of CPU time for WebProcess
Serializing an NSURLProtectionSpace seems to be costly due to server
trust verification. We do this for every sub-resource load over HTTPS
due to the canAuthenticateAgainstProtectionSpace() callback for server
trust validation, from the NetworkProcess to the WebProcess and then to
the UIProcess.
This patch adds a WKContextSetCanHandleHTTPSServerTrustEvaluation(bool)
WK2 private API that the client can call to indicate that it cannot
handle HTTPS server trust evaluation and that it is thus unnecessary to
call the canAuthenticateAgainstProtectionSpace() callback for such
evaluations. This reduces the amount of IPC between the process and
thus the number of times we have to serialize the ProtectionSpace.
In the case of the nytimes.com load, there is no longer any
ProtectionSpace serialization happening as
canAuthenticateAgainstProtectionSpace() was only called for HTTPS
server trust evaluation.
- NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::NetworkProcess):
(WebKit::NetworkProcess::initializeNetworkProcess):
(WebKit::NetworkProcess::setCanHandleHTTPSServerTrustEvaluation):
- NetworkProcess/NetworkProcess.h:
(WebKit::NetworkProcess::canHandleHTTPSServerTrustEvaluation):
- NetworkProcess/NetworkProcess.messages.in:
- NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::canAuthenticateAgainstProtectionSpaceAsync):
- Shared/Network/NetworkProcessCreationParameters.cpp:
(WebKit::NetworkProcessCreationParameters::encode):
(WebKit::NetworkProcessCreationParameters::decode):
- Shared/Network/NetworkProcessCreationParameters.h:
- UIProcess/API/C/WKContext.cpp:
(WKContextSetCanHandleHTTPSServerTrustEvaluation):
- UIProcess/API/C/WKContextPrivate.h:
- UIProcess/API/Cocoa/WKProcessPool.mm:
(-[WKProcessPool _setCanHandleHTTPSServerTrustEvaluation:]):
- UIProcess/API/Cocoa/WKProcessPoolPrivate.h:
- UIProcess/WebContext.cpp:
(WebKit::WebContext::WebContext):
(WebKit::WebContext::ensureNetworkProcess):
(WebKit::WebContext::setCanHandleHTTPSServerTrustEvaluation):
- UIProcess/WebContext.h:
- 2:53 PM Changeset in webkit [174368] by
-
- 2 edits in trunk/Source/WebKit
[Win] Unreviewed 64-bit build fix after r174315.
- WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in: Update exports for
64-bit symbol names.
- 2:52 PM Changeset in webkit [174367] by
-
- 3 edits in trunk/Source/WebKit2
Don't attempt to paint into zero-sized backing store
https://bugs.webkit.org/show_bug.cgi?id=137465
Reviewed by Tim Horton.
Page scale could cause the backing store for a small composited element to become empty,
in which case we'd try to allocate, and paint into a graphics context with no surface
behind it.
Fix by bailing from RemoteLayerBackingStore::display() when checking the backing store
size after accounting for scale.
- Shared/mac/RemoteLayerBackingStore.h:
- Shared/mac/RemoteLayerBackingStore.mm:
(WebKit::RemoteLayerBackingStore::backingStoreSize):
(WebKit::RemoteLayerBackingStore::swapToValidFrontBuffer):
(WebKit::RemoteLayerBackingStore::display):
- 2:37 PM Changeset in webkit [174366] by
-
- 6 edits3 moves in trunk/Tools
build.webkit.org/dashboard: Add commit queue
https://bugs.webkit.org/show_bug.cgi?id=137462
Reviewed by Tim Horton.
Generalizes EWS into "bubble queue", which also includes commit queue and style queue.
Style queue is still invisible, as it doesn't have an associated platform, and also
we never have problems with it anyway, so it's not worth watching.
The UI now allows for adding more bots to the Other column (such as leaks bot).
To make that actually happen, we'll need to refactor QueueView, allowing for multiple
sources of data in a cell.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueue.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueue.js.
(BubbleQueue):
(BubbleQueue.prototype.get statusPageURL):
(BubbleQueue.prototype.update):
(BubbleQueue.prototype.loadDetailedStatus):
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWS.js.
(BubbleQueueServer):
(BubbleQueueServer.prototype.jsonQueueLengthURL):
(BubbleQueueServer.prototype.jsonQueueStatusURL):
(BubbleQueueServer.prototype.queueStatusURL):
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueView.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueueView.js.
(BubbleQueueView):
(BubbleQueueView.prototype.update.appendQueue):
(BubbleQueueView.prototype.update):
(BubbleQueueView.prototype._addQueueHeadingToPopover):
(BubbleQueueView.prototype._popoverContentForBubbleQueue):
(BubbleQueueView.prototype._presentPopoverForBubbleQueue):
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWS.js: Removed.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueue.js: Removed.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueueView.js: Removed.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
(.bubble-server-popover .popover-queue-heading .queue-charts-link):
(.bubble-server-popover .latest-status-no-link):
(.bubble-server-popover .bot-status-description):
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html:
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js:
(buildAggregateTable):
(buildQueuesTable):
Removed dysfunctional support for EWS for now. It will be different.
- 2:36 PM Changeset in webkit [174365] by
-
- 3 edits in trunk/Source/WebCore
Add ChromeClient::isPlayingAudioDidChange().
https://bugs.webkit.org/show_bug.cgi?id=137220
Reviewed by Jer Noble.
This is called when the Page's m_isPlayingAudio changes.
No new tests, no behavior change.
- page/ChromeClient.h:
(WebCore::ChromeClient::isPlayingAudioDidChange):
- page/Page.cpp:
(WebCore::Page::updateIsPlayingAudio):
- 1:58 PM Changeset in webkit [174364] by
-
- 3 edits in trunk/Tools
One more case of incorrect comparison in recordpatchevent.py
https://bugs.webkit.org/show_bug.cgi?id=137459
Reviewed by Tim Horton.
- QueueStatusServer/app.yaml:
- QueueStatusServer/loggers/recordpatchevent.py:
(RecordPatchEvent.started):
- 1:45 PM Changeset in webkit [174363] by
-
- 17 edits in trunk
Unreviewed, rolling out r174336.
Mozilla's Dromaeo still relies on the deprecated function.
Reverted changeset:
"Add a deprecation warning for Element.webkitMatchesSelector"
https://bugs.webkit.org/show_bug.cgi?id=137417
http://trac.webkit.org/changeset/174336
- 1:42 PM Changeset in webkit [174362] by
-
- 2 edits in trunk/Source/JavaScriptCore
Remove incorrect assertion.
- 1:27 PM Changeset in webkit [174361] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fix cloop build.
- 1:18 PM Changeset in webkit [174360] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed build fix.
<https://webkit.org/b/137279>
- jit/CCallHelpers.h:
(JSC::CCallHelpers::setupArgumentsWithExecState):
- 12:29 PM Changeset in webkit [174359] by
-
- 6 edits in trunk/Source/JavaScriptCore
REGRESSION(r174226): [JSC] Crash when running the perf test Speedometer/Full.html
https://bugs.webkit.org/show_bug.cgi?id=137404
Reviewed by Michael Saboff.
Update the Arguments object to recognise that it must always have an
environment record if the referenced callee has one, and if such is not
present it should not try to extract one from the callframe, as that
path leads to madness.
Happily this makes some of the other code more sensible, and removes a
bunch of unnecessary and icky logic.
- interpreter/Interpreter.cpp:
(JSC::unwindCallFrame):
- jit/JITOperations.cpp:
- llint/LLIntSlowPaths.cpp:
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
- runtime/Arguments.cpp:
(JSC::Arguments::tearOff):
(JSC::Arguments::didTearOffActivation): Deleted.
- runtime/Arguments.h:
(JSC::Arguments::argument):
(JSC::Arguments::finishCreation):
- 12:20 PM Changeset in webkit [174358] by
-
- 13 edits in trunk/Source/WebCore
Use is<>() / downcast<>() for CryptoKey subclasses
https://bugs.webkit.org/show_bug.cgi?id=137436
Reviewed by Ryosuke Niwa.
Use is<>() / downcast<>() for CryptoKey subclasses.
No new tests, no behavior change.
- bindings/js/JSCryptoKeySerializationJWK.cpp:
(WebCore::addJWKAlgorithmToJSON):
- bindings/js/SerializedScriptValue.cpp:
(WebCore::CloneSerializer::write):
- crypto/CryptoKey.h:
- crypto/algorithms/CryptoAlgorithmAES_CBC.cpp:
(WebCore::CryptoAlgorithmAES_CBC::keyAlgorithmMatches):
(WebCore::CryptoAlgorithmAES_CBC::encrypt):
(WebCore::CryptoAlgorithmAES_CBC::decrypt):
- crypto/algorithms/CryptoAlgorithmAES_KW.cpp:
(WebCore::CryptoAlgorithmAES_KW::keyAlgorithmMatches):
(WebCore::CryptoAlgorithmAES_KW::encryptForWrapKey):
(WebCore::CryptoAlgorithmAES_KW::decryptForUnwrapKey):
- crypto/algorithms/CryptoAlgorithmHMAC.cpp:
(WebCore::CryptoAlgorithmHMAC::keyAlgorithmMatches):
(WebCore::CryptoAlgorithmHMAC::sign):
(WebCore::CryptoAlgorithmHMAC::verify):
- crypto/algorithms/CryptoAlgorithmRSAES_PKCS1_v1_5.cpp:
(WebCore::CryptoAlgorithmRSAES_PKCS1_v1_5::keyAlgorithmMatches):
(WebCore::CryptoAlgorithmRSAES_PKCS1_v1_5::encrypt):
(WebCore::CryptoAlgorithmRSAES_PKCS1_v1_5::decrypt):
- crypto/algorithms/CryptoAlgorithmRSASSA_PKCS1_v1_5.cpp:
(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::keyAlgorithmMatches):
(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::sign):
(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::verify):
- crypto/algorithms/CryptoAlgorithmRSA_OAEP.cpp:
(WebCore::CryptoAlgorithmRSA_OAEP::keyAlgorithmMatches):
(WebCore::CryptoAlgorithmRSA_OAEP::encrypt):
(WebCore::CryptoAlgorithmRSA_OAEP::decrypt):
- crypto/keys/CryptoKeyAES.h:
(WebCore::isCryptoKeyAES): Deleted.
- crypto/keys/CryptoKeyHMAC.h:
(WebCore::isCryptoKeyHMAC): Deleted.
- crypto/keys/CryptoKeyRSA.h:
(WebCore::isCryptoKeyRSA): Deleted.
- 12:09 PM Changeset in webkit [174357] by
-
- 3 edits in trunk/Tools
webkit-queues PatchLog is incorrect for patches that took less than a second
https://bugs.webkit.org/show_bug.cgi?id=137453
Reviewed by Tim Horton.
- QueueStatusServer/app.yaml: Updated app version.
- QueueStatusServer/loggers/recordpatchevent.py: (RecordPatchEvent.stopped):
Don't bail out for patches that took 0 seconds to process (as frequently happens
when a patch is obsolete).
- 11:57 AM Changeset in webkit [174356] by
-
- 5 edits in trunk/Source/WebCore
Some compositing logic cleanup
https://bugs.webkit.org/show_bug.cgi?id=133060
Reviewed by Zalan Bujtas.
Move compositing-related code from RenderLayer::styleChanged() to
RenderLayerCompositor::layerStyleChanged(). Combine various tests
(many clip-related) for changes that require layer rebuilding into
styleChangeRequiresLayerRebuild().
Remove code that calls setBackingNeedsRepaint() after filters change
between being composited or not; I verified that existing "repaint after
style change" code takes care those repaints.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::calculateClipRects):
(WebCore::RenderLayer::checkIfDescendantClippingContextNeedsUpdate): Deleted.
- rendering/RenderLayer.h:
- rendering/RenderLayerCompositor.cpp:
(WebCore::checkIfDescendantClippingContextNeedsUpdate):
(WebCore::styleChangeRequiresLayerRebuild):
(WebCore::RenderLayerCompositor::layerStyleChanged):
- rendering/RenderLayerCompositor.h:
- 11:56 AM Changeset in webkit [174355] by
-
- 2 edits in trunk/Source/WebCore
Fix the iOS build after https://trac.webkit.org/changeset/174353.
- platform/audio/ios/AudioDestinationIOS.h:
- 11:39 AM Changeset in webkit [174354] by
-
- 2 edits in trunk/Source/WebKit/mac
Build fix.
- Misc/WebCache.mm:
(+[WebCache imageForURL:]):
- 11:22 AM Changeset in webkit [174353] by
-
- 10 edits in trunk/Source/WebCore
Implement Page::isPlayingAudio().
https://bugs.webkit.org/show_bug.cgi?id=137218
Reviewed by Eric Carlson.
- Add a hasMediaCharacteristics() method to MediaSession. There are three characteristics:
audible, visual, and legible. MediaSession gets the media characteristics information from
its MediaSessionClient.
- Add a mediaStateDidChange() method to MediaSessionClient that MediaSession can call when its
state changes.
- Each Document keeps a set of MediaSessions it contains. When that set changes, or when a MediaSession
changes state, or when its characteristics change, Document::updateIsPlayingAudio() is called. That method
iterates through all its MediaSessions to check if the overall isPlayingAudio state has changed in the Document.
- Each Page caches its overall isPlayingAudio state. Whenever a Document's isPlayingAudio state changes,
it calls Page::updateIsPlayingAudio() which iterates through its frames' documents to calculate its
overall isPlayingAudio state.
No new tests, no behavior change.
- dom/Document.cpp:
(WebCore::Document::Document):
Initialize m_isPlayingAudio.
(WebCore::Document::registerMediaSession):
Add the MediaSession to m_mediaSessions. Call updateIsPlayingAudio().
(WebCore::Document::unregisterMediaSession):
Remove the MediaSession from m_mediaSessions. Call updateIsPlayingAudio().
(WebCore::Document::updateIsPlayingAudio):
Go through all the MediaSessions in this Document and check if any has the Audible characteristic
and is playing. If the overall isPlayingAudio state changes, call Page::updateIsPlayingAudio().
- dom/Document.h:
(WebCore::Document::isPlayingAudio):
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::registerWithDocument):
Call Document::registerMediaSession().
(WebCore::HTMLMediaElement::unregisterWithDocument):
Call Document::unregisterMediaSession().
(WebCore::HTMLMediaElement::mediaPlayerCharacteristicChanged):
Call Document::updateIsPlayingAudio().
(WebCore::HTMLMediaElement::stop):
Call MediaSession::clientWillPausePlayback() so the MediaSession's state can be set back to Paused.
(WebCore::HTMLMediaElement::hasMediaCharacteristics):
Call hasAudio() to check if the HTMLMediaElement has the Audible characteristic. Call hasVideo()
to check if it has the Visual characteristic. Call hasClosedCaptions() to check if it has the
Legible characteristic.
(WebCore::HTMLMediaElement::mediaStateDidChange):
Call Document::updateIsPlayingAudio().
- html/HTMLMediaElement.h:
- page/Page.cpp:
(WebCore::Page::Page):
Initialize m_isPlayingAudio.
(WebCore::Page::updateIsPlayingAudio):
Iterate through all its frames' documents to check if any has audio playing. If the overall isPlayingAudio
state has changed, update m_isPlayingAudio.
- page/Page.h:
(WebCore::Page::isPlayingAudio):
- platform/audio/MediaSession.cpp:
(WebCore::MediaSession::setState):
If the MediaSession's state has changed, call Document::updateIsPlayingAudio().
(WebCore::MediaSession::hasMediaCharacteristics):
Call MediaSessionClient::hasMediaCharacteristics().
- platform/audio/MediaSession.h:
(WebCore::MediaSessionClient::mediaStateDidChange):
- platform/audio/mac/AudioDestinationMac.h:
AudioDestination only has the Audible characteristic.
- 11:09 AM Changeset in webkit [174352] by
-
- 2 edits in trunk/Source/WebKit/mac
Unreviewed build fix after r174333.
Forgot explicit WebCore:: namespace.
- Misc/WebCache.mm:
(+[WebCache imageForURL:]):
- 11:08 AM Changeset in webkit [174351] by
-
- 8 edits in trunk/Source
Use is<>() / downcast<>() for ScrollingTree subclasses
https://bugs.webkit.org/show_bug.cgi?id=137449
Reviewed by Ryosuke Niwa.
Use is<>() / downcast<>() for ScrollingTree subclasses.
Source/WebCore:
No new tests, no behavior change.
- page/scrolling/ScrollingTree.h:
- page/scrolling/ThreadedScrollingTree.h:
- page/scrolling/ios/ScrollingTreeIOS.h:
- page/scrolling/mac/ScrollingCoordinatorMac.mm:
(WebCore::ScrollingCoordinatorMac::handleWheelEvent):
(WebCore::ScrollingCoordinatorMac::commitTreeState):
Source/WebKit2:
- UIProcess/Scrolling/RemoteScrollingTree.h:
- WebProcess/WebPage/EventDispatcher.cpp:
(WebKit::EventDispatcher::addScrollingTreeForPage):
- 11:01 AM Changeset in webkit [174350] by
-
- 2 edits in trunk/Source/WebCore
[Win] Build fix aftr r174347.
- platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp: Use correct build
macro to prevent build break when ENCRYPTED_MEDIA_V2 is not enabled.
- 10:55 AM Changeset in webkit [174349] by
-
- 2 edits in trunk/LayoutTests
[Windows] Skip remaining failing media tests after adding audio devices to the bots Part 2.
- platform/win/TestExpectations:
- 10:55 AM Changeset in webkit [174348] by
-
- 2 edits in trunk/Source/WTF
[Win] Project file gardening.
- WTF.vcxproj/WTF.vcxproj.filters: Move HashMethod.h and
FastBitVector.cpp to proper places in hierarchy.
- 10:53 AM Changeset in webkit [174347] by
-
- 2 edits in trunk/Source/WebCore
[Win] Project file gardening.
- WebCore.vcxproj/WebCore.vcxproj.filters: Move EditorWin.cpp and MediatTimeAVFoundation to proper folder locations in project.
- 10:49 AM Changeset in webkit [174346] by
-
- 7 edits in trunk/Source/WebCore
[Win] Extend AVFoundationCF Media Implementation
https://bugs.webkit.org/show_bug.cgi?id=137409
Reviewed by Eric Carlson.
This code is not yet being built and tested by our system. Appropriate
tests will be activated when we enable the build.
Most of this patch involves correcting some misuse of the AVFoundationCF API.
- It is never appropriate in AVCF to pass a null CFErrorRef; instead you must pass a CFErrorRef with error type kCFURLErrorUnknown.
- Because of the asynchronous way we handle the request/response, it is possible for AVCF to make two AVCF requests while negotiating the key exchange.
- platform/graphics/avfoundation/cf/AVFoundationCFSoftLinking.h: Add
missing declaration.
- platform/graphics/avfoundation/cf/CDMSessionAVFoundationCF.cpp:
(WebCore::CDMSessionAVFoundationCF::generateKeyRequest): Tighten up scope
of 'underlyingError'.
(WebCore::CDMSessionAVFoundationCF::update): Add call to complete the
loading process.
- platform/graphics/avfoundation/cf/InbandTextTrackPrivateAVCF.cpp:
(WebCore::InbandTextTrackPrivateAVCF::label): Handle null titles CFArray
found during testing.
(WebCore::InbandTextTrackPrivateAVCF::language): Ditto for a null locale.
- platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:
(WebCore::MediaPlayerPrivateAVFoundationCF::registerMediaEngine): Add support
for the new 'supportsKeySystem' method.
(WebCore::MediaPlayerPrivateAVFoundationCF::createContextVideoRenderer): Add
assertion for mainThread.
(WebCore::MediaPlayerPrivateAVFoundationCF::destroyContextVideoRenderer): Ditto.
(WebCore::MediaPlayerPrivateAVFoundationCF::createVideoLayer): Ditto.
(WebCore::MediaPlayerPrivateAVFoundationCF::destroyVideoLayer): Ditto.
(WebCore::MediaPlayerPrivateAVFoundationCF::createAVPlayer): Ditto.
(WebCore::MediaPlayerPrivateAVFoundationCF::createAVPlayerItem): Ditto.
(WebCore::MediaPlayerPrivateAVFoundationCF::platformLayer): Ditto.
(WebCore::MediaPlayerPrivateAVFoundationCF::platformSetVisible): Ditto.
(WebCore::MediaPlayerPrivateAVFoundationCF::paintCurrentFrameInContext): Ditto.
(WebCore::MediaPlayerPrivateAVFoundationCF::paint): Ditto.
(WebCore::MediaPlayerPrivateAVFoundationCF::supportsKeySystem): Added.
(WebCore::MediaPlayerPrivateAVFoundationCF::sizeChanged): Add assertion that this
is being called on the main thread.
(WebCore::MediaPlayerPrivateAVFoundationCF::processMediaSelectionOptions): Handle
the allows empty media selection properly based on test behavior.
(WebCore::AVFWrapper::AVFWrapper): Initialize resource loader callback structure
when building with AVFOUNDATION_LOADER_DELEGATE.
(WebCore::AVFWrapper::createAssetForURL): Use AVFWrapper's loader callback struct,
rather than passing the address of a temporary value.
(WebCore::AVFWrapper::processNotification): Stop using the deprecated
'dispatch_get_current_queue' function.
(WebCore::AVFWrapper::processCue): Ditto.
(WebCore::AVFWrapper::legibleOutputCallback): Ditto.
(WebCore::AVFWrapper::processShouldWaitForLoadingOfResource): Pass a valid CFError
object; nullptr is not allowed as an argument to the "...FinishedLoadingWithError"
method.
(WebCore::AVFWrapper::shouldWaitForLoadingOfResource): Add support for multiple
in-flight requests.
(WebCore::AVFWrapper::platformLayer): Assert we are on the main thread.
(WebCore::AVFWrapper::setRequestForKey): Add support for multiple in-flight requests.
(WebCore::AVFWrapper::takeRequestForKeyURI): Ditto.
(WebCore::LayerClient::platformCALayerLayoutSublayersOfLayer): Ditto.
- platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.h:
- platform/graphics/avfoundation/cf/WebCoreAVCFResourceLoader.cpp: Make sure we pass
valid CFError objects, rather than nullptr.
- 9:39 AM Changeset in webkit [174345] by
-
- 3 edits in trunk/Source/WebCore
AX: Performance: Certain Web site causes Safari to hang completely while entering form data
https://bugs.webkit.org/show_bug.cgi?id=137420
Reviewed by Mario Sanchez Prada.
If a website has multiple nested tables that are not "accessibility" tables, the performance of accessibility slows to a crawl because:
1) We are re-computing accessibilityIsIgnored many times.
As a solution, we can enable the isIgnoredCache when updating children.
2) When asking if an object isTableCell, we'd go up the parent chain, asking each of those parents the same question, which exploded into calling this many times.
As a solution, I've changed our determination of isTableCell to instead check if the parent is an accessibiltyTable which should be much faster.
No new functionality. Existing tests cover changes.
- accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::updateChildrenIfNecessary):
(WebCore::AccessibilityObject::accessibilityIsIgnored):
- accessibility/AccessibilityTableCell.cpp:
(WebCore::AccessibilityTableCell::parentTable):
(WebCore::AccessibilityTableCell::isTableCell):
- 9:25 AM Changeset in webkit [174344] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, touch testing/Internals.idl to try to fix Windows EWS after r174315.
- testing/Internals.idl: Remove unnecessary whitespaces.
- 7:34 AM Changeset in webkit [174343] by
-
- 3 edits in trunk/Tools
EWS bubble hover shows wrong timestamps
https://bugs.webkit.org/show_bug.cgi?id=137252
Reviewed by Alexey Proskuryakov.
Add "Z" suffix to timestamps to make sure if it is handled as UTC time.
- QueueStatusServer/handlers/queuestatusjson.py:
(QueueStatusJSON.get):
- QueueStatusServer/handlers/statusbubble.py:
(StatusBubble._iso_time):
- 5:47 AM Changeset in webkit [174342] by
-
- 2 edits in trunk/Tools
Unreviewed, updated list of email addresses in contributors.json
- Scripts/webkitpy/common/config/contributors.json: Added my former
email address in Igalia, for the sake of completeness.
- 2:10 AM Changeset in webkit [174341] by
-
- 2 edits in trunk/Tools
Unreviewed, moved myself to the list of committers.
- Scripts/webkitpy/common/config/contributors.json:
