Timeline



Oct 16, 2014:

11:31 PM Changeset in webkit [174812] by Carlos Garcia Campos
  • 2 edits in trunk

REGRESSION(CMake): [GTK] WebKitSettings:enable-smooth-scrolling does nothing
​https://bugs.webkit.org/show_bug.cgi?id=137781

Reviewed by Martin Robinson.

We used to enable smooth scrolling unconditionally in autotools
(via WebKitFeatures.m4), but since the switch to CMake it's
unconditionally disabled, so changing the setting doesn't have any
effect.

  • Source/cmake/OptionsGTK.cmake: Enable smooth scrolling.
10:34 PM Changeset in webkit [174811] by Yusuke Suzuki
  • 3 edits
    4 adds in trunk

CSS Selectors Level 4: Implement :matches in SelectorChecker
​https://bugs.webkit.org/show_bug.cgi?id=137393

Reviewed by Benjamin Poulain.

Source/WebCore:

In this patch, we introduce initial :matches implementation.
In this current implementation, we don't consider pseudo elements.

Test: fast/selectors/querySelector-matches.html

  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::checkOne):

LayoutTests:

  • fast/selectors/matches-selector-list-expected.txt: Added.
  • fast/selectors/matches-selector-list.html: Added.
  • fast/selectors/querySelector-matches-expected.txt: Added.
  • fast/selectors/querySelector-matches.html: Added.
10:17 PM Changeset in webkit [174810] by Yusuke Suzuki
  • 3 edits in trunk/Source/WebCore

CSS JIT: Introduce StackAllocator::addressOf
​https://bugs.webkit.org/show_bug.cgi?id=137771

Reviewed by Benjamin Poulain.

Introduce StackAllocator::addressOf and drop offsetToStackReference, it's too primitive.

  • cssjit/SelectorCompiler.cpp:

(WebCore::SelectorCompiler::SelectorCodeGenerator::generateSelectorChecker):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateParentElementTreeWalker):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateDirectAdjacentTreeWalker):
(WebCore::SelectorCompiler::SelectorCodeGenerator::loadCheckingContext):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateAdjacentBacktrackingTail):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateDescendantBacktrackingTail):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementIsFirstLink):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateStoreLastVisitedElement):

  • cssjit/StackAllocator.h:

(WebCore::StackAllocator::addressOf):
(WebCore::StackAllocator::offsetToStackReference):

10:14 PM Changeset in webkit [174809] by mitz@apple.com
  • 4 edits in trunk

OSObjectPtr is missing leakRef()
​https://bugs.webkit.org/show_bug.cgi?id=137798

Reviewed by Sam Weinig.

Source/WTF:

  • wtf/OSObjectPtr.h:

Tools:

  • TestWebKitAPI/Tests/WTF/darwin/OSObjectPtr.cpp:

(TestWebKitAPI::TEST(OSObjectPtr, LeakRef)): Added.

8:26 PM Changeset in webkit [174808] by Lucas Forschler
  • 2 edits in trunk/Tools

Update target platform to remove Leopard, Snow Leopard, Lion.
Add Yosemite.

Unreviewed.

  • BuildSlaveSupport/build.webkit.org-config/wkbuild.py:

(_should_file_trigger_build):

7:17 PM Changeset in webkit [174807] by ap@apple.com
  • 3 edits
    2 adds in trunk

REGRESSION (r169024): Undetermined text is not displayed in the search field of Adobe Help Website
​https://bugs.webkit.org/show_bug.cgi?id=137679
rdar://problem/18450335

Reviewed by Enrica Casucci.

Source/WebCore:

Test: platform/mac/editing/input/selected-composed-text-painting.html

  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paint): We do not paint

selection beckground for unconfirmed text with underlines, so we should use a regular
style for text painting, as well.

LayoutTests:

  • platform/mac/editing/input/selected-composed-text-painting-expected.html: Added.
  • platform/mac/editing/input/selected-composed-text-painting.html: Added.
6:54 PM Changeset in webkit [174806] by dburkart@apple.com
  • 3 edits in branches/safari-600.1-branch/LayoutTests

Merge r171301

6:54 PM Changeset in webkit [174805] by Chris Dumez
  • 14 edits in trunk/Source/WebCore

Use is<>() / downcast<>() for BasicShape subclasses
​https://bugs.webkit.org/show_bug.cgi?id=137766

Reviewed by Andreas Kling.

Use is<>() / downcast<>() for BasicShape subclasses and clean up the
surrounding code.

No new tests, no behavior change.

  • css/BasicShapeFunctions.cpp:

(WebCore::valueForBasicShape):
(WebCore::basicShapeForValue):

  • css/BasicShapeFunctions.h:
  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::shapePropertyValue):

  • page/animation/CSSPropertyAnimation.cpp:

(WebCore::blendFunc):

  • rendering/ClipPathOperation.h:

(WebCore::ShapeClipPathOperation::create):
Take a PassRef<BasicShape> in argument to make it obvious it is never
null.

(WebCore::ShapeClipPathOperation::basicShape):
Return a reference instead of a pointer as it can never return null.

(WebCore::ShapeClipPathOperation::windRule):
(WebCore::ShapeClipPathOperation::pathForReferenceRect):
Make it non-const due to the const-correctness of Ref::get().

(WebCore::ShapeClipPathOperation::ShapeClipPathOperation):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::nodeAtPoint):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::setupClipPath):

  • rendering/shapes/Shape.cpp:

(WebCore::Shape::createShape):

  • rendering/shapes/Shape.h:
  • rendering/shapes/ShapeOutsideInfo.cpp:

(WebCore::ShapeOutsideInfo::computedShape):

  • rendering/style/BasicShapes.cpp:

(WebCore::BasicShape::canBlend):
(WebCore::BasicShapeCircle::blend):
(WebCore::BasicShapeEllipse::blend):
(WebCore::BasicShapePolygon::blend):
(WebCore::BasicShapeInset::blend):

  • rendering/style/BasicShapes.h:
  • rendering/svg/SVGRenderingContext.cpp:

(WebCore::SVGRenderingContext::prepareToRenderSVGContent):

6:53 PM Changeset in webkit [174804] by Chris Dumez
  • 9 edits in trunk/Source/WebCore

Leverage the new RenderElement::m_isCSSAnimating flag in more places
​https://bugs.webkit.org/show_bug.cgi?id=137786

Reviewed by Simon Fraser.

Leverage the new RenderElement::m_isCSSAnimating flag that was introduced
in r174703 in more places, for performance. This avoids doing extra work
for renderers on which we are not running animations on. This patch also
updates the API a bit to use more references instead of pointers, making
it clear the RenderElement cannot be null and thus avoiding unnecessary
null checks.

No new tests, no behavior change.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::computeRenderStyleForProperty):

  • page/animation/AnimationController.cpp:

(WebCore::AnimationControllerPrivate::ensureCompositeAnimation):
(WebCore::AnimationControllerPrivate::clear):
(WebCore::AnimationControllerPrivate::updateAnimationTimerForRenderer):
(WebCore::AnimationControllerPrivate::isRunningAnimationOnRenderer):
(WebCore::AnimationControllerPrivate::isRunningAcceleratedAnimationOnRenderer):
(WebCore::AnimationControllerPrivate::pauseAnimationAtTime):
(WebCore::AnimationControllerPrivate::pauseTransitionAtTime):
(WebCore::AnimationControllerPrivate::getAnimatedStyleForRenderer):
(WebCore::AnimationController::cancelAnimations):
(WebCore::AnimationController::updateAnimations):
(WebCore::AnimationController::getAnimatedStyleForRenderer):
(WebCore::AnimationController::notifyAnimationStarted):
(WebCore::AnimationController::isRunningAnimationOnRenderer):
(WebCore::AnimationController::isRunningAcceleratedAnimationOnRenderer):

  • page/animation/AnimationController.h:
  • page/animation/AnimationControllerPrivate.h:
  • rendering/RenderElement.cpp:

(WebCore::RenderElement::willBeDestroyed):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::currentTransform):

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateGeometry):
(WebCore::RenderLayerBacking::notifyAnimationStarted):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::requiresCompositingForAnimation):
(WebCore::RenderLayerCompositor::isRunningAcceleratedTransformAnimation):

6:14 PM Changeset in webkit [174803] by commit-queue@webkit.org
  • 35 edits in trunk

Removing CUSTOM_PROTOCOLS guard
​https://bugs.webkit.org/show_bug.cgi?id=137741

Patch by Pascal Jacquemart <​p.jacquemart@samsung.com> on 2014-10-16
Reviewed by Benjamin Poulain.

.:

  • Source/cmake/OptionsEfl.cmake:

Source/WebKit2:

  • NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::NetworkProcess):

  • Shared/Network/CustomProtocols/Cocoa/CustomProtocolManagerCocoa.mm:
  • Shared/Network/CustomProtocols/CustomProtocolManager.h:
  • Shared/Network/CustomProtocols/CustomProtocolManager.messages.in:
  • Shared/Network/CustomProtocols/soup/CustomProtocolManagerImpl.cpp:
  • Shared/Network/CustomProtocols/soup/CustomProtocolManagerImpl.h:
  • Shared/Network/CustomProtocols/soup/CustomProtocolManagerSoup.cpp:
  • Shared/Network/NetworkProcessCreationParameters.cpp:

(WebKit::NetworkProcessCreationParameters::encode):
(WebKit::NetworkProcessCreationParameters::decode):

  • Shared/Network/NetworkProcessCreationParameters.h:
  • Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::encode):
(WebKit::WebProcessCreationParameters::decode):

  • Shared/WebProcessCreationParameters.h:
  • UIProcess/API/C/soup/WKAPICastSoup.h:
  • UIProcess/API/C/soup/WKSoupCustomProtocolRequestManager.cpp:

(WKSoupCustomProtocolRequestManagerGetTypeID):
(WKSoupCustomProtocolRequestManagerSetClient):

  • UIProcess/Network/CustomProtocols/CustomProtocolManagerProxy.h:
  • UIProcess/Network/CustomProtocols/CustomProtocolManagerProxy.messages.in:
  • UIProcess/Network/CustomProtocols/mac/CustomProtocolManagerProxyMac.mm:
  • UIProcess/Network/CustomProtocols/soup/CustomProtocolManagerProxySoup.cpp:
  • UIProcess/Network/CustomProtocols/soup/WebSoupCustomProtocolRequestManager.cpp:
  • UIProcess/Network/CustomProtocols/soup/WebSoupCustomProtocolRequestManager.h:
  • UIProcess/Network/CustomProtocols/soup/WebSoupCustomProtocolRequestManagerClient.cpp:
  • UIProcess/Network/CustomProtocols/soup/WebSoupCustomProtocolRequestManagerClient.h:
  • UIProcess/Network/NetworkProcessProxy.cpp:

(WebKit::NetworkProcessProxy::NetworkProcessProxy):

  • UIProcess/Network/NetworkProcessProxy.h:
  • UIProcess/WebContext.cpp:

(WebKit::WebContext::WebContext):
(WebKit::WebContext::unregisterGlobalURLSchemeAsHavingCustomProtocolHandlers):
(WebKit::WebContext::unregisterSchemeForCustomProtocol):

  • UIProcess/WebContext.h:
  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::WebProcessProxy):

  • UIProcess/WebProcessProxy.h:
  • UIProcess/mac/WebContextMac.mm:

(WebKit::WebContext::platformInitializeWebProcess):
(WebKit::WebContext::platformInitializeNetworkProcess):

  • WebKit2Prefix.h:
  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::WebProcess):

  • WebProcess/soup/WebKitSoupRequestGeneric.cpp:

(webkitSoupRequestGenericSendAsync):
(webkitSoupRequestGenericSendFinish):

  • WebProcess/soup/WebKitSoupRequestGeneric.h:
6:12 PM Changeset in webkit [174802] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Missing RefPtr.release() calls in TextureMapper
​https://bugs.webkit.org/show_bug.cgi?id=137777

Patch by Adrien Destugues <​pulkomandy@gmail.com> on 2014-10-16
Reviewed by Chris Dumez.

No new tests: no functional change, cleanup/optimization.

Avoids useless ref/deref cycle when returning from functions.

  • platform/graphics/texmap/TextureMapper.cpp:

(WebCore::TextureMapper::acquireTextureFromPool):

  • platform/graphics/texmap/TextureMapperLayer.cpp:

(WebCore::TextureMapperLayer::paintIntoSurface):

5:35 PM Changeset in webkit [174801] by Chris Dumez
  • 6 edits in trunk/Source/WebCore

Use is<>() / downcast<>() for ContentData subclasses
​https://bugs.webkit.org/show_bug.cgi?id=137768

Reviewed by Andreas Kling.

Use is<>() / downcast<>() for ContentData subclasses.

No new tests, no behavior change.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::contentToCSSValue):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::loadPendingImages):

  • rendering/RenderElement.cpp:

(WebCore::RenderElement::createFor):

  • rendering/style/ContentData.h:

(WebCore::operator==):

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::setContent):

4:55 PM Changeset in webkit [174800] by ddkilzer@apple.com
  • 2 edits in trunk/Tools

commit-queue: fails to replace OO-PS! with reviewer name
<​http://webkit.org/b/137795>

Reviewed by Alexey Proskuryakov.

  • Scripts/webkitpy/common/net/bugzilla/bugzilla.py:

(Bugzilla.fetch_bug_dictionary): Bugzilla 4.2.x never gives out
email addresses to unauthenticated page loads, so we must always
authenticate before getting bug data so we get full email
addresses.

4:39 PM Changeset in webkit [174799] by Simon Fraser
  • 3 edits in trunk/Source/WebKit2

Crash under RemoteLayerTreeHost::getLayer() when closing a tab
​https://bugs.webkit.org/show_bug.cgi?id=137796
rdar://problem/18547565

Reviewed by Tim Horton.

CA can call our animation delegate after the RemoteLayerTreeHost has been
destroyed. CAAnimation retains its delegate, so it's safe for us to null out
the WKAnimationDelegate's pointer to the RemoteLayerTreeHost when tearing down
the RemoteLayerTreeHost.

  • UIProcess/mac/RemoteLayerTreeHost.mm:

(WebKit::RemoteLayerTreeHost::~RemoteLayerTreeHost):
(WebKit::RemoteLayerTreeHost::animationDidEnd):

  • WebProcess/WebPage/mac/PlatformCAAnimationRemote.mm:

(-[WKAnimationDelegate invalidate]):
(-[WKAnimationDelegate animationDidStart:]):
(-[WKAnimationDelegate animationDidStop:finished:]):

3:43 PM Changeset in webkit [174798] by Alan Bujtas
  • 2 edits in trunk/LayoutTests

[Mac] Unreviewed gardening.

  • platform/mac/TestExpectations:
3:43 PM Changeset in webkit [174797] by ddkilzer@apple.com
  • 2 edits in trunk/Tools

commit-queue: fails to close bugs after successfully landing patches
<​http://webkit.org/b/137794>

Reviewed by Alexey Proskuryakov.

  • Scripts/webkitpy/common/net/bugzilla/bugzilla.py:

(Bugzilla.clear_attachment_flags): Change 'nr=0' to 'nr=1' to
tell Mechanize to use the second <textarea> on the page with
name="comment".

3:08 PM Changeset in webkit [174796] by Brent Fulgham
  • 7 edits in trunk/Tools

[Win] Update DRT to match Mac Logic
​https://bugs.webkit.org/show_bug.cgi?id=137787

Reviewed by Dean Jackson.

  • DumpRenderTree/win/DumpRenderTree.cpp:

(initialize): 0 -> nullptr
(runTest): Initialize MSG structure before using.
(main): Add CRT debug flags if building DRT with debug malloc on Windows.
Also, cleanly shut down COM when exiting.

  • DumpRenderTree/win/FrameLoadDelegate.cpp:

(FrameLoadDelegate::didChangeLocationWithinPageForFrame): Move from
header and add printf to match Mac.
(FrameLoadDelegate::windowScriptObjectAvailable): Ditto.

  • DumpRenderTree/win/FrameLoadDelegate.h:

(FrameLoadDelegate::didChangeLocationWithinPageForFrame): Deleted.
(FrameLoadDelegate::windowScriptObjectAvailable): Deleted.

  • DumpRenderTree/win/ResourceLoadDelegate.cpp:

(isLocalhost): Added.
(hostIsUsedBySomeTestsToGenerateError): Added.
(ResourceLoadDelegate::willSendRequest): Add logic to mimic Mac's use
of certain error and redirect host names.

  • DumpRenderTree/win/UIDelegate.cpp:

(UIDelegate::runJavaScriptAlertPanelWithMessage): Use 'done' flag to decide if
anything should be output to the console. This modifies behavior to match the Mac.
(UIDelegate::runJavaScriptConfirmPanelWithMessage): Ditto.
(UIDelegate::runJavaScriptTextInputPanelWithPrompt): Ditto.
(UIDelegate::runBeforeUnloadConfirmPanelWithMessage): Ditto.
(UIDelegate::webViewAddMessageToConsole): Ditto.

  • WinLauncher/PageLoadTestClient.cpp:

(PageLoadTestClient::pageLoadEndedAtTime): Drive-by-fix for an assertion that I
added last week.

3:02 PM Changeset in webkit [174795] by oliver@apple.com
  • 9 edits in trunk/Source/JavaScriptCore

Use a single allocation for the Arguments object
​https://bugs.webkit.org/show_bug.cgi?id=137751

Reviewed by Filip Pizlo.

This patch removes the secondary allocation for parameters in the Arguments
object. This is faily simple, but we needed to make it possible for the JIT
to allocate a variable GC object. To do this i've added a new
emitAllocateVariableSizedJSObject function to the JIT that does the work to
find the correct heap for a variable sized allocation and then bump that
allocator.

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::emitAllocateArguments):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::emitAllocateVariableSizedJSObject):

  • heap/CopyToken.h:
  • heap/Heap.h:

(JSC::Heap::subspaceForObjectWithoutDestructor):
(JSC::Heap::subspaceForObjectNormalDestructor):
(JSC::Heap::subspaceForObjectsWithImmortalStructure):

  • heap/MarkedSpace.h:

(JSC::MarkedSpace::subspaceForObjectsWithNormalDestructor):
(JSC::MarkedSpace::subspaceForObjectsWithImmortalStructure):
(JSC::MarkedSpace::subspaceForObjectsWithoutDestructor):

  • interpreter/StackVisitor.cpp:

(JSC::StackVisitor::Frame::createArguments):

  • runtime/Arguments.cpp:

(JSC::Arguments::visitChildren):
(JSC::Arguments::copyBackingStore):
(JSC::Arguments::tearOff):
(JSC::Arguments::allocateRegisterArray): Deleted.

  • runtime/Arguments.h:

(JSC::Arguments::create):
(JSC::Arguments::isTornOff):
(JSC::Arguments::offsetOfRegisterArray):
(JSC::Arguments::registerArraySizeInBytes):
(JSC::Arguments::registerArray):
(JSC::Arguments::allocationSize): Deleted.

2:58 PM Changeset in webkit [174794] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Unreviewed, rolling out r174744.
​https://bugs.webkit.org/show_bug.cgi?id=137790

Caused another WebGL conformance test to fail (Requested by
rfong on #webkit).

Reverted changeset:

"glReadPixels on NVIDIA cards returns the wrong values for the
alpha channel when alpha is off."
​https://bugs.webkit.org/show_bug.cgi?id=137752
​http://trac.webkit.org/changeset/174744

2:57 PM Changeset in webkit [174793] by commit-queue@webkit.org
  • 4 edits in trunk

Unreviewed, rolling out r174754.
​https://bugs.webkit.org/show_bug.cgi?id=137789

Speculative fix for Windows test was ineffective. (Requested
by rfong on #webkit).

Reverted changeset:

"[Windows] Add some more logging to debug Windows test
issues."
​http://trac.webkit.org/changeset/174754

2:33 PM Changeset in webkit [174792] by Alan Bujtas
  • 2 edits in trunk/LayoutTests

[Mac] Unreviewed gardening.

Unskip more subpixel related tests.

  • platform/mac/TestExpectations:
1:13 PM Changeset in webkit [174791] by timothy_horton@apple.com
  • 21 edits
    2 adds in trunk/Source

Implement selection services menu for Legacy WebKit
​https://bugs.webkit.org/show_bug.cgi?id=137582
<rdar://problem/18604241>

Reviewed by Brady Eidson.

  • WebCore.exp.in:
  • editing/Editor.h:
  • editing/ios/EditorIOS.mm:

(WebCore::Editor::replaceSelectionWithAttributedString):

  • editing/mac/EditorMac.mm:

(WebCore::Editor::replaceSelectionWithAttributedString):
Add replaceSelectionWithAttributedString, which replaces the selection
with the given attributed string (converting to plain text if the destination
is not richly editable).

  • WebKit.xcodeproj/project.pbxproj:
  • Misc/WebSharingServicePickerController.h:

Move SPI into the header (in the near future it will be moved to a modern-style SPI header).
Add WebSharingServicePickerClient, which other classes can implement
instead of tying WebSharingServicePickerController strongly to WebContextMenuClient.
Make initWithData:... -> initWithItems:... instead, taking an array of NSItemProviders.

  • Misc/WebSharingServicePickerController.mm:

Pass in NSSharingServicePickerStyle, so that clients can specify the style.

(-[WebSharingServicePickerController clear]):
(-[WebSharingServicePickerController didShareImageData:confirmDataIsValidTIFFData:]):
(-[WebSharingServicePickerController sharingServicePicker:didChooseSharingService:]):
(-[WebSharingServicePickerController sharingService:sourceFrameOnScreenForShareItem:]):
(-[WebSharingServicePickerController sharingService:transitionImageForShareItem:contentRect:]):
(-[WebSharingServicePickerController sharingService:sourceWindowForShareItems:sharingContentScope:]):
Make use of WebSharingServicePickerClient.

(-[WebSharingServicePickerController sharingService:didShareItems:]):
If we're returned a NSAttributedString, paste it on top of the current selection,
similar to what the WebKit2 implementation currently does.

  • WebCoreSupport/WebChromeClient.h:
  • WebCoreSupport/WebChromeClient.mm:

(WebChromeClient::handleTelephoneNumberClick):
(WebChromeClient::handleSelectionServiceClick):
(WebChromeClient::hasRelevantSelectionServices):
Override the services-related ChromeClient functions, forward them to WebSelectionServiceController.

  • WebCoreSupport/WebContextMenuClient.h:
  • WebCoreSupport/WebContextMenuClient.mm:

(WebContextMenuClient::sharingServicePickerWillBeDestroyed):
(WebContextMenuClient::pageForSharingServicePicker):
(WebContextMenuClient::windowForSharingServicePicker):
(WebContextMenuClient::screenRectForCurrentSharingServicePickerItem):
(WebContextMenuClient::imageForCurrentSharingServicePickerItem):
(WebContextMenuClient::contextMenuForEvent):
(WebContextMenuClient::screenRectForHitTestNode): Deleted.
(WebContextMenuClient::renderedImageForControlledImage): Deleted.
(WebContextMenuClient::clearSharingServicePickerController): Deleted.
Have WebContextMenuClient implement WebSharingServicePickerClient to avoid
having WebSharingServicePickerController tightly bound to it.
Make an NSItemProvider array when instantiating WebSharingServicePickerController
instead of handing it data directly.

  • WebCoreSupport/WebSelectionServiceController.h: Copied from Source/WebKit/mac/WebCoreSupport/WebContextMenuClient.h.
  • WebCoreSupport/WebSelectionServiceController.mm: Added.

(WebSelectionServiceController::WebSelectionServiceController):
Add WebSelectionServiceController, which will act as the WebSharingServicePickerClient
for selection services.

(WebSelectionServiceController::handleSelectionServiceClick):
Create a WebSharingSericePickerController with the selection's attributed string, and show its menu.

(hasCompatibleServicesForItems):
(WebSelectionServiceController::hasRelevantSelectionServices):
Determine whether or not services are available.

(WebSelectionServiceController::sharingServicePickerWillBeDestroyed):
(WebSelectionServiceController::pageForSharingServicePicker):
(WebSelectionServiceController::windowForSharingServicePicker):
Implement the rest of the WebSharingServicePickerClient overrides.

(WebSelectionServiceController::screenRectForCurrentSharingServicePickerItem):
(WebSelectionServiceController::imageForCurrentSharingServicePickerItem):
These are only useful for image sharing services, so we don't need to
implement them (WebContextMenuClient does, on the other hand).

  • WebView/WebView.mm:

(-[WebView _selectionServiceController]):

  • WebView/WebViewData.h:
  • WebView/WebViewData.mm:
  • WebView/WebViewInternal.h:

Keep a WebSelectionServiceController.

  • UIProcess/mac/WebContextMenuProxyMac.mm:

(-[WKSharingServicePickerDelegate sharingService:didShareItems:]):
Add a note that we should transition to using replaceSelectionWithAttributedString.

  • WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::handleSelectionServiceClick):
Allow editor services in editable-but-not-rich-text areas, just like in WebKit1.

12:56 PM Changeset in webkit [174790] by fpizlo@apple.com
  • 2 edits
    1 add in trunk/Source/JavaScriptCore

Apparently we've had a hole in arguments capture all along
​https://bugs.webkit.org/show_bug.cgi?id=137767

Reviewed by Oliver Hunt.

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::getArgument):

  • tests/stress/arguments-captured.js: Added.

(foo):
(bar):

12:55 PM Changeset in webkit [174789] by saambarati1@gmail.com
  • 16 edits in trunk/Source/JavaScriptCore

Have the ProfileType node in the DFG convert to a structure check where it can
​https://bugs.webkit.org/show_bug.cgi?id=137596

Reviewed by Filip Pizlo.

TypeSet now keeps track of the live set of Structures it has seen.
It no longer nukes everything during GC. It now only removes unmarked
structures during GC. This modification allows the ProfileType node
to convert into a CheckStructure node safely in the DFG.

This change brings up the conversion rate from ProfileType to Check
or CheckStructrue from ~45% to ~65%. This change also speeds the
type profiler up significantly: consistently between 2x-20x faster.

This patch also does some slight refactoring: a few type profiler
related fields are moved from VM to TypeProfiler.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::CodeBlock):

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

  • dfg/DFGNode.h:

(JSC::DFG::Node::convertToCheckStructure):

  • heap/Heap.cpp:

(JSC::Heap::collect):

  • runtime/SymbolTable.cpp:

(JSC::SymbolTable::uniqueIDForVariable):

  • runtime/SymbolTable.h:
  • runtime/TypeLocationCache.cpp:

(JSC::TypeLocationCache::getTypeLocation):

  • runtime/TypeProfiler.cpp:

(JSC::TypeProfiler::TypeProfiler):
(JSC::TypeProfiler::nextTypeLocation):
(JSC::TypeProfiler::invalidateTypeSetCache):
(JSC::TypeProfiler::dumpTypeProfilerData):

  • runtime/TypeProfiler.h:

(JSC::TypeProfiler::getNextUniqueVariableID):

  • runtime/TypeProfilerLog.cpp:

(JSC::TypeProfilerLog::processLogEntries):

  • runtime/TypeSet.cpp:

(JSC::TypeSet::addTypeInformation):
(JSC::TypeSet::invalidateCache):

  • runtime/TypeSet.h:

(JSC::TypeSet::structureSet):

  • runtime/VM.cpp:

(JSC::VM::VM):
(JSC::VM::enableTypeProfiler):
(JSC::VM::disableTypeProfiler):
(JSC::VM::dumpTypeProfilerData):
(JSC::VM::nextTypeLocation): Deleted.
(JSC::VM::invalidateTypeSetCache): Deleted.

  • runtime/VM.h:

(JSC::VM::typeProfiler):
(JSC::VM::getNextUniqueVariableID): Deleted.

  • tests/typeProfiler/dfg-jit-optimizations.js:
12:53 PM Changeset in webkit [174788] by timothy_horton@apple.com
  • 3 edits in trunk/Source/WebKit2

Various crashes in ViewGestureControllerIOS when closing a tab while a swipe gesture is in progress
​https://bugs.webkit.org/show_bug.cgi?id=137770
<rdar://problem/17916459>

Reviewed by Dan Bernstein.

When tearing down a WKWebView in the middle of a swipe gesture, a variety of
UI process crashes were observed. First, two uses of potentially deleted objects
(the WebBackForwardListItem and ViewGestureController), which were fixed by
extending the object's lifetime and checking for its liveness, respectively.
Second, a potential null-deref of DrawingArea if the timing of endSwipeGesture
vs. page teardown was such that DrawingArea was null but everything else was in line.
Lastly, another case of messaging a potentially deleted object (specifically,
the _UIViewControllerTransitionContext's animator) in a callback from CA, which
was fixed by nulling out the animator (and a few other properties) when tearing
down the ViewGestureController.

  • UIProcess/ios/ViewGestureControllerIOS.mm:

(-[WKSwipeTransitionController invalidate]):
Clear the soon-to-be-invalid ViewGestureController pointer.

(WebKit::ViewGestureController::~ViewGestureController):
Call [WKSwipeTransitionController invalidate] upon destruction.
Clear our transition context's interactor and animator, and inform it that
the transition is not in flight. This avoids a crash when calling back
to the already-destroyed animator later.

(WebKit::ViewGestureController::beginSwipeGesture):
Keep a reference to the target WebBackForwardListItem; this avoids
it being deleted between here and the transition completion block firing.

Look up the ViewGestureController by pageID, just like we do in endSwipeGesture,
to avoid situations where the callback fires after the WKWebView/ViewGestureController
have gone away.

Hold on to our _UIViewControllerOneToOneTransitionContext, so that we can do the
aforementioned clearing upon deallocation.

(WebKit::ViewGestureController::endSwipeGesture):
Null check the DrawingArea. If it is null, instead of doing our normal delayed logic
for swipe snapshot teardown, just put things back together immediately.

(WebKit::ViewGestureController::removeSwipeSnapshot):
Clear m_swipeTransitionContext.

12:45 PM Changeset in webkit [174787] by ap@apple.com
  • 4 edits in trunk/Source/WebCore

Crashes in ResourceHandleCFURLConnectionDelegateWithOperationQueue due to unimplemented retain/release
​https://bugs.webkit.org/show_bug.cgi?id=137779
rdar://problem/18679320

Reviewed by Brady Eidson.

  • platform/network/cf/ResourceHandleCFURLConnectionDelegate.cpp:

(WebCore::ResourceHandleCFURLConnectionDelegate::retain):
(WebCore::ResourceHandleCFURLConnectionDelegate::release):
(WebCore::ResourceHandleCFURLConnectionDelegate::makeConnectionClient):

  • platform/network/cf/ResourceHandleCFURLConnectionDelegate.h:

Implemented retain/release. They are necessary, as ResourceHandle goes away when
it's canceled, and there is noone else to keep the client object alive but
CFURLConnection itself.

  • platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:

(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::willSendRequest):
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::didReceiveResponse):
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::didReceiveData):
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::didFinishLoading):
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::didFail):
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::willCacheResponse):
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::didReceiveChallenge):
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::didSendBodyData):
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::canRespondToProtectionSpace):
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::didReceiveDataArray):
Added a FIXME about potential improvements that I spotted while invsestigating this.

12:14 PM Changeset in webkit [174786] by Alan Bujtas
  • 16 edits in trunk/LayoutTests

[Mac] Unreviewed gardening.

Unskip subpixel border tests.

  • platform/mac/TestExpectations:
  • platform/mac/css1/units/length_units-expected.txt:
  • platform/mac/fast/css/bidi-override-in-anonymous-block-expected.txt:
  • platform/mac/fast/repaint/repaint-during-scroll-with-zoom-expected.txt:
  • platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-initial-value-001-expected.txt:
  • platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-style-001-expected.txt:
  • platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-style-002-expected.txt:
  • platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-style-004-expected.txt:
  • platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-with-three-values-001-expected.txt:
  • platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-with-two-values-001-expected.txt:
  • platform/mac/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-003-expected.txt:
  • platform/mac/media/video-zoom-expected.txt:
  • platform/mac/svg/custom/svg-fonts-in-html-expected.txt:
  • platform/mac/svg/zoom/page/zoom-svg-float-border-padding-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/bugs/bug1055-2-expected.txt:
9:01 AM Changeset in webkit [174785] by ddkilzer@apple.com
  • 2 edits in trunk/Websites/bugs.webkit.org/template/en/default

Fix JavaScript alert() about missing search terms when submitting patch review

  • template/en/default/attachment/reviewform.html.tmpl: Pass

hide_content=1 argument when including global/header.html.tmpl.

  • template/en/default/global/header.html.tmpl: Add hide_content argument

that hides header content when including the file.

9:01 AM Changeset in webkit [174784] by ddkilzer@apple.com
  • 2 edits in trunk/Websites/bugs.webkit.org

Re-enable WebKit-based user matching

  • data/params: Disable Bugzilla's own user matching, which also

requires the JSON::RPC Perl module.

  • template/en/default/global/footer.html.tmpl: Include

committers-autocomplete.js everywhere. Every. Where.

9:01 AM Changeset in webkit [174783] by ddkilzer@apple.com
  • 1 edit in trunk/Websites/bugs.webkit.org/code-review.js

Fix loading of legacy comments from older Bugzillas

  • code-review.js:

(fetchHistory): We must support both the old-style and new-style
formats for attachment comments since the old-style format is
quoted and stored as text in the database forever.

9:01 AM Changeset in webkit [174782] by ddkilzer@apple.com
  • 1 edit in trunk/Websites/bugs.webkit.org/data/params

Update proxy URL parameter used by Bugzilla

  • data/params: Update proxy URL.
9:01 AM Changeset in webkit [174781] by ddkilzer@apple.com
  • 1 edit in trunk/Websites/bugs.webkit.org/mod_perl.pl

Fix maximum unshared memory size of Apache processes

  • mod_perl.pl: Set the maximum unshared memory size of Apache

processes to 700 MB. According to the manpage, this is the
correct way to do it in a mod_perl config file.

9:01 AM Changeset in webkit [174780] by ddkilzer@apple.com
  • 1 edit in trunk/Websites/bugs.webkit.org/.htaccess

Remove unneeded rule from .htaccess

  • .htaccess: Remove an old rule that doesn't match any files.
9:01 AM Changeset in webkit [174779] by ddkilzer@apple.com
  • 27 edits
    4 adds in trunk/Websites/bugs.webkit.org

Upgrade to Bugzilla 4.2.11.

9:01 AM Changeset in webkit [174778] by ddkilzer@apple.com
  • 14 edits
    3 copies
    1 delete in trunk/Websites/bugs.webkit.org/template/en

Move template/en/custom files onto template/en/default

9:01 AM Changeset in webkit [174777] by ddkilzer@apple.com
  • 1 edit in trunk/Websites/bugs.webkit.org/template/en/custom/attachment/edit.html.tmpl

Do not hide details on attachment edit page

  • template/en/custom/attachment/edit.html.tmpl: Comment out the

call to toggle_attachment_details_visibility() that initially
hides the details.

9:01 AM Changeset in webkit [174776] by ddkilzer@apple.com
  • 1 edit in trunk/Websites/bugs.webkit.org/js/field.js

Re-fix Bug 26950: Make the summary and alias fields support click-to-edit <​https://bugs.webkit.org/show_bug.cgi?id=26950>

  • js/field.js: Port the changes from r45538 to Bugzilla 4.2.5.
9:01 AM Changeset in webkit [174775] by ddkilzer@apple.com
  • 1 edit in trunk/Websites/bugs.webkit.org/migrate.pl

migrate.pl: remove unnecessary change

9:01 AM Changeset in webkit [174774] by ddkilzer@apple.com
  • 2 edits in trunk/Websites/bugs.webkit.org

Fix "View Diff" buttons on edit attachment page

  • js/attachment.js:

(viewPrettyPatch): Change code syntax from Perl to JavaScript.
When I moved this method from
template/en/custom/attachment/edit.html.tmpl into
js/attachment.js during the Bugzilla 4.2.1 merge, I wrote some
of the code using Perl syntax.

  • template/en/custom/attachment/edit.html.tmpl:
  • Fix 120-column truncation of code. (That's what you get for copying and pasting code from 'git diff' in a terminal window.)
  • Pass attachment_id into the viewPrettyPatch() method since the method expects it.
9:01 AM Changeset in webkit [174773] by ddkilzer@apple.com
  • 4 edits
    2 deletes in trunk/Websites/bugs.webkit.org

Remove references to Rietveld from bugs.webkit.org

Rietveld was an experiment that was added by Google. It was
never enabled for everyone, so it's safe to remove the changes
that reference it.

  • Bugzilla/Flag.pm: Remove code that prevented mail messages from

being sent for patches reviewed in Rietveld.

  • attachment.cgi: Remove reference to the "rietveldreview"

template.

  • template/en/custom/attachment/list.html.tmpl: Remove code

that handled the Rietveld review flag.

  • template/en/custom/attachment/reviewform.html.tmpl: Remove code

that handled the "rietveldReview" CGI parameter.

  • template/en/custom/attachment/rietveldreview.html.tmpl: Delete.
  • template/en/custom/flag/list.html.tmpl: Delete. After

removing the code to handle Rietveld reviews, there were no more
local WebKit changes to the custom template file, so it could be
removed.

9:01 AM Changeset in webkit [174772] by ddkilzer@apple.com
  • 3 edits in trunk/Websites/bugs.webkit.org

Display legal text when uploading a patch with a new bug

  • js/attachment.js:

(setContentTypeDisabledState): Make this work on the Enter Bug
page so that the "Submit Bug" button changes to
"Agree and Submit Bug" when the "patch" checkbox is checked, and
it changes back to "Submit Bug" when unchecked.

  • template/en/custom/attachment/createformcontents.html.tmpl:

Include the attachment/patchlegalese.html.tmpl template when
returning the page so that it will be shown when the "patch"
checkbox is checked. Set the 'product' variable from the CGI
variable of the same name.

  • template/en/custom/attachment/patchlegalese.html.tmpl: Add the

'expert_fields' class to the <tr> element so that it gets
shown/hidden when the Show/Hide Advanced Fields links are
clicked.

9:01 AM Changeset in webkit [174771] by ddkilzer@apple.com
  • 2 edits in trunk/Websites/bugs.webkit.org

Get rid of large blank area when adding non-patch attachment

  • js/attachment.js:
  • template/en/custom/attachment/patchlegalese.html.tmpl:
  • Use 'display: none;' and 'display: table-row;' instead of 'visibility: collapse;' and 'visibility: visible;' to hide and show the text.
9:01 AM Changeset in webkit [174770] by ddkilzer@apple.com
  • 1 edit
    1 add in trunk/Websites/bugs.webkit.org/template/en/custom/attachment

Move patch legalese into its own template file for reuse

  • template/en/custom/attachment/create.html.tmpl:
  • template/en/custom/attachment/patchlegalese.html.tmpl:
  • Extract patch legalese into its own file.
9:01 AM Changeset in webkit [174769] by ddkilzer@apple.com
  • 2 edits in trunk/Websites/bugs.webkit.org

Fix review form after Bugzilla 4.2.5 update

  • code-review.js:

(fetchHistory):

  • Trim author since new format adds a space before the name.
  • Update comment_marker to match the text now used by Bugzilla.
  • template/en/custom/attachment/reviewform.html.tmpl:
  • Add global/header.html.tmpl to make sure we get the standard HTML for including CSS, JavaScript, etc.
    • Remove redundant <link> tags.
    • Add CSS in local <style> to hide the header.
    • Change local <script> to be passed as an argument into global/header.html.tmpl when it is processed.
    • NOTE: local <style> tag should be passed as an argument into global/header.html.tmpl, but that breaks page layout, so it was skipped for now.
  • Fix fallout form moving flag_types into the attachment object when processing flag/list.html.tmpl.
9:01 AM Changeset in webkit [174768] by ddkilzer@apple.com
  • 1 edit in trunk/Websites/bugs.webkit.org/template/en/custom/global/header.html.tmpl

Add back "WebKit Bugzilla" text in page header

9:01 AM Changeset in webkit [174767] by ddkilzer@apple.com
  • 3 adds in trunk/Websites/bugs.webkit.org

Add .htaccess files created by checksetup.pl

9:01 AM Changeset in webkit [174766] by ddkilzer@apple.com
  • 1 edit in trunk/Websites/bugs.webkit.org/data/params

data/params: update after running checksetup.pl

9:01 AM Changeset in webkit [174765] by ddkilzer@apple.com
  • 101 edits
    1 add in trunk/Websites/bugs.webkit.org

Upgrade to Bugzilla 4.2.7.

Conflicts:

buglist.cgi
report.cgi

9:00 AM Changeset in webkit [174764] by ddkilzer@apple.com
  • 408 edits
    41 copies
    5 moves
    371 adds
    77 deletes in trunk/Websites/bugs.webkit.org

Upgrade bugs.webkit.org to Bugzilla 4.2
<​http://webkit.org/b/55882>

Upgrade to Bugzilla 4.2.1.

Conflicts:

.htaccess
Bugzilla.pm
Bugzilla/Auth.pm
Bugzilla/Auth/Login/CGI.pm
Bugzilla/Auth/Persist/Cookie.pm
Bugzilla/Bug.pm
Bugzilla/BugMail.pm
Bugzilla/CGI.pm
Bugzilla/Config/Attachment.pm
Bugzilla/Config/Common.pm
Bugzilla/Config/General.pm
Bugzilla/Constants.pm
Bugzilla/DB/Mysql.pm
Bugzilla/DB/Oracle.pm
Bugzilla/DB/Schema.pm
Bugzilla/DB/Schema/Oracle.pm
Bugzilla/Error.pm
Bugzilla/Flag.pm
Bugzilla/FlagType.pm
Bugzilla/Hook.pm
Bugzilla/Install/DB.pm
Bugzilla/Install/Filesystem.pm
Bugzilla/Install/Localconfig.pm
Bugzilla/Install/Requirements.pm
Bugzilla/Install/Util.pm
Bugzilla/Mailer.pm
Bugzilla/Product.pm
Bugzilla/Search.pm
Bugzilla/Search/Quicksearch.pm
Bugzilla/Search/Saved.pm
Bugzilla/Series.pm
Bugzilla/Template.pm
Bugzilla/Template/Plugin/Hook.pm
Bugzilla/Token.pm
Bugzilla/User.pm
Bugzilla/Util.pm
Bugzilla/WebService.pm
Bugzilla/WebService/Bug.pm
Bugzilla/WebService/Bugzilla.pm
Bugzilla/WebService/Constants.pm
Bugzilla/WebService/Product.pm
Bugzilla/WebService/User.pm
attachment.cgi
buglist.cgi
checksetup.pl
colchange.cgi
collectstats.pl
contrib/bugzilla_ldapsync.rb
contrib/bzdbcopy.pl
contrib/gnats2bz.pl
contrib/recode.pl
contrib/sendbugmail.pl
contrib/yp_nomail.sh
docs/en/xml/Bugzilla-Guide.xml
docs/en/xml/about.xml
docs/en/xml/installation.xml
docs/en/xml/security.xml
docs/en/xml/troubleshooting.xml
editflagtypes.cgi
editparams.cgi
editproducts.cgi
editvalues.cgi
editwhines.cgi
email_in.pl
enter_bug.cgi
extensions/BmpConvert/Config.pm
extensions/OldBugMove/template/en/default/admin/params/oldbugmove.html.tmpl
extensions/Voting/template/en/default/hook/bug/process/header-title.html.tmpl
extensions/Voting/template/en/default/hook/search/search-report-select-rep_fields.html.tmpl
extensions/example/code/webservice-error_codes.pl
extensions/example/version.pl
images/favicon.ico
importxml.pl
index.cgi
install-module.pl
js/field.js
js/util.js
long_list.cgi
mod_perl.pl
post_bug.cgi
process_bug.cgi
quips.cgi
sanitycheck.cgi
show_bug.cgi
showattachment.cgi
sidebar.cgi
skins/contrib/Dusk/global.css
skins/contrib/Dusk/index.css
skins/standard/global.css
skins/standard/show_bug.css
t/008filter.t
template/en/custom/attachment/review.html.tmpl
template/en/default/account/prefs/saved-searches.html.tmpl
template/en/default/admin/classifications/delete.html.tmpl
template/en/default/admin/classifications/edit-common.html.tmpl
template/en/default/admin/classifications/footer.html.tmpl
template/en/default/admin/components/create.html.tmpl
template/en/default/admin/components/edit.html.tmpl
template/en/default/admin/params/attachment.html.tmpl
template/en/default/admin/sanitycheck/messages.html.tmpl
template/en/default/admin/users/confirm-delete.html.tmpl
template/en/default/admin/workflow/edit.html.tmpl
template/en/default/attachment/created.html.tmpl
template/en/default/attachment/diff-header.html.tmpl
template/en/default/attachment/edit.html.tmpl
template/en/default/attachment/list.html.tmpl
template/en/default/attachment/updated.html.tmpl
template/en/default/bug/comments.html.tmpl
template/en/default/bug/create/create-guided.html.tmpl
template/en/default/bug/create/create.html.tmpl
template/en/default/bug/create/created.html.tmpl
template/en/default/bug/edit.html.tmpl
template/en/default/bug/field.html.tmpl
template/en/default/bug/process/header.html.tmpl
template/en/default/bug/show.html.tmpl
template/en/default/bug/show.xml.tmpl
template/en/default/config.rdf.tmpl
template/en/default/email/whine.txt.tmpl
template/en/default/filterexceptions.pl
template/en/default/flag/list.html.tmpl
template/en/default/global/common-links.html.tmpl
template/en/default/global/confirm-action.html.tmpl
template/en/default/global/field-descs.none.tmpl
template/en/default/global/footer.html.tmpl
template/en/default/global/header.html.tmpl
template/en/default/global/user-error.html.tmpl
template/en/default/global/userselect.html.tmpl
template/en/default/list/edit-multiple.html.tmpl
template/en/default/list/list.html.tmpl
template/en/default/pages/fields.html.tmpl
template/en/default/pages/release-notes.html.tmpl
template/en/default/search/boolean-charts.html.tmpl
template/en/default/search/form.html.tmpl
template/en/default/search/search-report-graph.html.tmpl
template/en/default/search/search-report-table.html.tmpl
template/en/default/setup/strings.txt.pl
token.cgi
userprefs.cgi
xml.cgi
xmlrpc.cgi

8:26 AM Changeset in webkit [174763] by Antti Koivisto
  • 3 edits in trunk/Source/WebKit2

REGRESSION (r173356): Downloading a disk image appends ".txt" to it
​https://bugs.webkit.org/show_bug.cgi?id=137493
<rdar://problem/18321947>

Reviewed by Alexey Proskuryakov.

  • Shared/Downloads/ios/DownloadIOS.mm:

(WebKit::Download::startWithHandle):

  • Shared/Downloads/mac/DownloadMac.mm:

(WebKit::Download::startWithHandle):

It appears that the synthesized NS/CFURLResponse fails to serialize the suggested filename correctly
unless it has been accessed first.

6:29 AM Changeset in webkit [174762] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Use isnan from std namespace in ProfileGenerator.cpp
​https://bugs.webkit.org/show_bug.cgi?id=137653

Patch by Adrien Destugues <​pulkomandy@gmail.com> on 2014-10-16
Reviewed by Darin Adler.

The C++ isnan() function is in the std namespace. The unprefixed isnan
may be available because of C99 headers leakage in C++, but should not
be used.

No new tests: no functional change, build fix on platforms which don't
export C99 functions in C++.

  • profiler/ProfileGenerator.cpp:

(JSC::ProfileGenerator::beginCallEntry):
(JSC::ProfileGenerator::endCallEntry):
(JSC::ProfileGenerator::didPause):
(JSC::ProfileGenerator::didContinue):

Oct 15, 2014:

11:50 PM Changeset in webkit [174761] by abucur@adobe.com
  • 17 edits
    4 adds in trunk

ASSERTION FAILED in WebCore::RenderFlowThread::getRegionRangeForBox
​https://bugs.webkit.org/show_bug.cgi?id=135563

Reviewed by David Hyatt.

Source/WebCore:

The new multi-column code doesn't work correctly when the document contains nested fragmentation
contexts. The problem is the current flow thread concept that can store only one RenderFlowThread
at a time and use it during layout.

The stored flow thread is always correct for regions because named flow threads are absolutley positioned
so every child renderer is contained inside them (with the expcetion of fixed positioned elements which are
treated separately).

For multi-column elements this is no longer the case. An absolutely positioned element inside a static
multi-column element will be contained by a block outside the fragmentation context. It can even be
contained by a different multi-column element in the case of nested flow threads.

The patch below explores a solution that's not based on a current flow thread stored globally. The proposed
patch makes every block to store a pointer to its fragmentation context and a flag that states if this pointer
needs to be updated or not. If the renderer is not a block it will get its flow thread from the containing
block. Once the containing flow thread is requested for the block, the pointer is computed and cached until
invalidated:

  • when a subtree is removed from a flow thread
  • when the position property of an element inside a flow thread changes

The process is recursive and it doesn't affect elements that are not nested inside a flow thread. If a block
changes position from relative to static, any element that was contained by it can only be contained by an
ancestor of the block. This ancestor will still be outside of any flow thread. This ensures that non-fragmentation
code is not affected from a performance perspective.

The patch affects the results of the performance tests:

  • the regions layout tests have a decreased performance raging from 2% to 5-6%
  • the regions selection tests have an increased performance raging from 1-2% to 10%
  • the multicolumn layout tests (now pending review in b137687) have an increased performance

raging from 1.8% to 5%

Tests: fast/multicol/multicol-all-positioned-crash.html

fast/multicol/multicol-transform-containing-block.html

  • rendering/FlowThreadController.cpp:

(WebCore::FlowThreadController::FlowThreadController):

  • rendering/FlowThreadController.h:

(WebCore::FlowThreadController::currentRenderFlowThread): Deleted.
(WebCore::FlowThreadController::setCurrentRenderFlowThread): Deleted.

  • rendering/LayoutState.h:

(WebCore::LayoutState::currentRenderFlowThread):
(WebCore::LayoutState::setCurrentRenderFlowThread):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlockRareData::RenderBlockRareData):
(WebCore::RenderBlock::styleWillChange):
(WebCore::RenderBlock::styleDidChange):
(WebCore::RenderBlock::collapseAnonymousBoxChild):
(WebCore::RenderBlock::cachedFlowThreadContainingBlock):
(WebCore::RenderBlock::cachedFlowThreadContainingBlockNeedsUpdate):
(WebCore::RenderBlock::setCachedFlowThreadContainingBlockNeedsUpdate):
(WebCore::RenderBlock::updateCachedFlowThreadContainingBlock):
(WebCore::RenderBlock::locateFlowThreadContainingBlock):

  • rendering/RenderBlock.h:
  • rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::styleWillChange):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::borderBoxRectInRegion):

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::layout):
(WebCore::RenderFlowThread::updateAllLayerToRegionMappings):
(WebCore::RenderFlowThread::repaintRectangleInRegions):
(WebCore::CurrentRenderFlowThreadMaintainer::CurrentRenderFlowThreadMaintainer): Deleted.
(WebCore::CurrentRenderFlowThreadMaintainer::~CurrentRenderFlowThreadMaintainer): Deleted.
(WebCore::CurrentRenderFlowThreadDisabler::CurrentRenderFlowThreadDisabler): Deleted.
(WebCore::CurrentRenderFlowThreadDisabler::~CurrentRenderFlowThreadDisabler): Deleted.

  • rendering/RenderFlowThread.h:
  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::paintLayer):
(WebCore::RenderLayer::hitTestLayer):
(WebCore::RenderLayer::mapLayerClipRectsToFragmentationLayer):
(WebCore::RenderLayer::calculateClipRects):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::showRegionsInformation):
(WebCore::RenderObject::insertedIntoTree):
(WebCore::RenderObject::removeFromRenderFlowThread):
(WebCore::RenderObject::removeFromRenderFlowThreadIncludingDescendants):
(WebCore::RenderObject::invalidateFlowThreadContainingBlockIncludingDescendants):
(WebCore::RenderObject::currentRenderNamedFlowFragment):
(WebCore::RenderObject::locateFlowThreadContainingBlock):
(WebCore::RenderObject::locateFlowThreadContainingBlockNoCache): Deleted.
(WebCore::RenderObject::removeFromRenderFlowThreadRecursive): Deleted.

  • rendering/RenderObject.h:

(WebCore::RenderObject::flowThreadContainingBlock):

  • rendering/RenderRegion.cpp:

(WebCore::RenderRegion::computeOverflowFromFlowThread):

  • rendering/RenderView.cpp:

(WebCore::RenderView::pushLayoutStateForCurrentFlowThread):
(WebCore::RenderView::popLayoutStateForCurrentFlowThread):

  • rendering/RenderView.h:

LayoutTests:

A test verifying that positioned elements inside multi-column containers don't
cause assertions or crashes.

  • fast/multicol/multicol-all-positioned-crash-expected.txt: Added.
  • fast/multicol/multicol-all-positioned-crash.html: Added.
  • fast/multicol/multicol-transform-containing-block-expected.txt: Added.
  • fast/multicol/multicol-transform-containing-block.html: Added.
11:45 PM Changeset in webkit [174760] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/Tools

Unreviewed, add myself to CoordinatedGraphics watchers.

  • Scripts/webkitpy/common/config/watchlist:
11:04 PM Changeset in webkit [174759] by Chris Dumez
  • 22 edits in trunk/Source/WebCore

Use is<>() / downcast<>() for list-related render objects
​https://bugs.webkit.org/show_bug.cgi?id=137764

Reviewed by Benjamin Poulain.

Use is<>() / downcast<>() for list-related render objects and clean up
the surrounding code.

No new tests, no behavior change.

  • accessibility/AccessibilityListBox.cpp:

(WebCore::AccessibilityListBox::visibleChildren):
(WebCore::AccessibilityListBox::elementAccessibilityHitTest):

  • accessibility/AccessibilityListBoxOption.cpp:

(WebCore::AccessibilityListBoxOption::elementRect):

  • accessibility/AccessibilityObject.cpp:

(WebCore::renderListItemContainerForNode):

  • accessibility/atk/WebKitAccessibleHyperlink.cpp:

(getRangeLengthForObject):

  • accessibility/atk/WebKitAccessibleInterfaceText.cpp:

(accessibilityObjectLength):
(offsetAdjustmentForListItem):
(webkitAccessibleTextGetText):

  • editing/BreakBlockquoteCommand.cpp:

(WebCore::BreakBlockquoteCommand::doApply):

  • html/HTMLLIElement.cpp:

(WebCore::HTMLLIElement::didAttachRenderers):
(WebCore::HTMLLIElement::parseValue):

  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::nextSelectableListIndexPageAway):
(WebCore::HTMLSelectElement::scrollToSelection):
(WebCore::HTMLSelectElement::setOptionsChangedOnRenderer):
(WebCore::HTMLSelectElement::selectOption):
(WebCore::HTMLSelectElement::platformHandleKeydownEvent):
(WebCore::HTMLSelectElement::menuListDefaultEventHandler):
(WebCore::HTMLSelectElement::listBoxDefaultEventHandler):

  • html/HTMLSelectElementWin.cpp:

(WebCore::HTMLSelectElement::platformHandleKeydownEvent):

  • page/mac/EventHandlerMac.mm:

(WebCore::EventHandler::platformPrepareForWheelEvents):

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::addToLine):
(WebCore::InlineFlowBox::placeBoxRangeInInlineDirection):

  • rendering/RenderCounter.cpp:

(WebCore::planCounter):

  • rendering/RenderListBox.h:
  • rendering/RenderListItem.cpp:

(WebCore::nextListItem):
(WebCore::previousListItem):

  • rendering/RenderListItem.h:
  • rendering/RenderListMarker.h:
  • rendering/RenderMenuList.h:
  • rendering/RenderTreeAsText.cpp:

(WebCore::markerTextForListItem):

  • rendering/TextAutoSizing.cpp:

(WebCore::TextAutoSizingValue::adjustNodeSizes):

  • rendering/line/BreakingContextInlineHeaders.h:

(WebCore::BreakingContext::handleReplaced):
(WebCore::BreakingContext::commitAndUpdateLineBreakIfNeeded):

  • testing/Internals.cpp:

(WebCore::Internals::isSelectPopupVisible):

8:57 PM Changeset in webkit [174758] by gyuyoung.kim@samsung.com
  • 3 edits in trunk/Source/WebCore

Use std::unique_ptr for CachedResource
​https://bugs.webkit.org/show_bug.cgi?id=137736

Reviewed by Darin Adler.

No new tests, no behavior change.

  • loader/cache/CachedResource.cpp: Use std::unique_ptr instead of PassOwnPtr|OwnPtr.

(WebCore::CachedResource::removeClient):

  • loader/cache/CachedResource.h: Set ctor from private to public.

(WebCore::CachedResource::CachedResourceCallback::schedule):

7:50 PM Changeset in webkit [174757] by gyuyoung.kim@samsung.com
  • 15 edits in trunk/Source/WebCore

Move TextCodec classes to std::unique_ptr
​https://bugs.webkit.org/show_bug.cgi?id=137738

Reviewed by Darin Adler.

Replace uses of PassOwnPtr in code under TextCodecFoo class with std::unique_ptr.
To do this, ctor of TextCodecFoo classes is changed from private to public. Besides
related classes follow this change as well.

No new tests, no behavior change.

  • html/parser/HTMLMetaCharsetParser.h:
  • loader/TextResourceDecoder.cpp:

(WebCore::TextResourceDecoder::setEncoding):
(WebCore::TextResourceDecoder::flush):

  • loader/TextResourceDecoder.h:
  • platform/text/TextCodec.h:
  • platform/text/TextCodecICU.cpp:

(WebCore::TextCodecICU::create):

  • platform/text/TextCodecICU.h:
  • platform/text/TextCodecLatin1.cpp:

(WebCore::newStreamingTextDecoderWindowsLatin1):

  • platform/text/TextCodecUTF16.cpp:

(WebCore::newStreamingTextDecoderUTF16LE):
(WebCore::newStreamingTextDecoderUTF16BE):

  • platform/text/TextCodecUTF8.cpp:

(WebCore::TextCodecUTF8::create):

  • platform/text/TextCodecUTF8.h:
  • platform/text/TextCodecUserDefined.cpp:

(WebCore::newStreamingTextDecoderUserDefined):

  • platform/text/TextEncodingRegistry.cpp:

(WebCore::newTextCodec):

  • platform/text/TextEncodingRegistry.h:
  • platform/text/mac/TextCodecMac.cpp:

(WebCore::newTextCodecMac):

7:25 PM Changeset in webkit [174756] by dino@apple.com
  • 3 edits in trunk/Source/WebCore

[Media] Reduce style updates (painting) in controls
​https://bugs.webkit.org/show_bug.cgi?id=137763
<rdar://problem/17833045>

Reviewed by Simon Fraser.

Media controls were causing a lot of repaints they were
constantly updating the style of the widgets, the value
of the forms, or the text in the display.

This is necessary when the controls are visible, but not
necessary when they are hidden. Return immediately in that case.

  • Modules/mediacontrols/mediaControlsApple.js:

(Controller.prototype.createControls): Initialise the slider to a zero value.
(Controller.prototype.handleDurationChange): Force an update even though we might be hidden.
(Controller.prototype.updateProgress): Don't update if we're hidden.
(Controller.prototype.updateTime): Ditto.

  • Modules/mediacontrols/mediaControlsiOS.js:

(ControllerIOS.prototype.updateProgress): Ditto.

6:41 PM Changeset in webkit [174755] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed, rolling out r174753.
​https://bugs.webkit.org/show_bug.cgi?id=137761

caused layout tests to fail. (Requested by zalan on #webkit).

Reverted changeset:

"[Mac] Unreviewed gardening."
​http://trac.webkit.org/changeset/174753

6:16 PM Changeset in webkit [174754] by roger_fong@apple.com
  • 4 edits in trunk

[Windows] Speculative Windows test fix.
Also add some more test logging.

  • DumpRenderTree/win/DumpRenderTree.cpp: Make sure that OLEAUT32.dll doesn't cache BSTRs.
  • WebActionPropertyBag.cpp:

(WebActionPropertyBag::Read): Add logging for testing purposes.

5:56 PM Changeset in webkit [174753] by Alan Bujtas
  • 2 edits in trunk/LayoutTests

[Mac] Unreviewed gardening.

Unskip subpixel border tests.

  • platform/mac/TestExpectations:
5:29 PM Changeset in webkit [174752] by jonowells@apple.com
  • 1 edit
    2 deletes in trunk/Source/WebInspectorUI

Build fix. Rolling back changes in ​http://trac.webkit.org/changeset/174721.

  • Scripts/copy-user-interface-resources.pl:
  • UserInterface/External/ESLint/LICENSE: Removed.
  • UserInterface/External/ESLint/eslint.js: Removed.
5:28 PM Changeset in webkit [174751] by Lucas Forschler
  • 4 edits in branches/safari-600.1-branch/LayoutTests

Merged r173674.

5:17 PM Changeset in webkit [174750] by Alan Bujtas
  • 1 edit
    1 add in trunk/LayoutTests

[Mac] Unreviewed gardening(mountain-lion).

  • platform/mac-mountainlion/fast/text/international/hindi-spacing-expected.txt: Added.
5:14 PM Changeset in webkit [174749] by msaboff@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

REGRESSION(r174025): remote inspector crashes frequently when executing inspector frontend's JavaScript
​https://bugs.webkit.org/show_bug.cgi?id=137758

Rubber stamped by Filip Pizlo.

Reverted r174025 for just PutByOffset Nodes.

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

5:13 PM Changeset in webkit [174748] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

import-w3c-test rewrites relative src paths in ref files incorrectly
​https://bugs.webkit.org/show_bug.cgi?id=137586

This patch fixes a bug in test_converter.py where src paths were getting
rewritten as ../../some-path instead of <script src="../../some-path>".
It also adds support for rewriting src paths in style elements, which was
missing before and it adds tests for this case.

Patch by Rebecca Hauck <​rhauck@adobe.com> on 2014-10-15
Reviewed by Bem Jones-Bey.

  • Scripts/webkitpy/w3c/test_converter.py:

(_W3CTestConverter.convert_attributes_if_needed):

  • Scripts/webkitpy/w3c/test_converter_unittest.py:

(test_convert_attributes_if_needed):
(verify_reference_relative_paths):

5:09 PM Changeset in webkit [174747] by Chris Dumez
  • 2 edits in trunk/Source/WebCore

[Mac] Fix inefficiencies in ResourceResponse::platformLazyInit(InitLevel) - Part 2
​https://bugs.webkit.org/show_bug.cgi?id=137721

Reviewed by Darin Adler.

Follow-up patch to r174717 addressing review comments made after the patch landed:

  • Use modern C++ loop
  • Remove explicit calls to String(NSString*) constructor

No new tests, no new tests.

  • platform/network/mac/ResourceResponseMac.mm:

(WebCore::ResourceResponse::platformLazyInit):

5:05 PM Changeset in webkit [174746] by Chris Dumez
  • 24 edits in trunk/Source/WebCore

Use is<>() / downcast<>() for InlineBox subclasses
​https://bugs.webkit.org/show_bug.cgi?id=137749

Reviewed by Darin Adler.

Use is<>() / downcast<>() for InlineBox subclasses and clean up the
surrounding code.

No new tests, no behavior change.

  • dom/Position.cpp:

(WebCore::Position::upstream):
(WebCore::Position::downstream):

  • editing/VisibleUnits.cpp:

(WebCore::wordBreakIteratorForMinOffsetBoundary):
(WebCore::wordBreakIteratorForMaxOffsetBoundary):
(WebCore::visualWordPosition):
(WebCore::startPositionForLine):
(WebCore::endPositionForLine):

  • rendering/InlineBox.cpp:

(WebCore::InlineBox::root):
(WebCore::InlineBox::nextLeafChild):
(WebCore::InlineBox::prevLeafChild):
(WebCore::InlineBox::nextLeafChildIgnoringLineBreak):

  • rendering/InlineBox.h:
  • rendering/InlineElementBox.h:
  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::getFlowSpacingLogicalWidth):
(WebCore::InlineFlowBox::addToLine):
(WebCore::InlineFlowBox::determineSpacingForFlowBoxes):
(WebCore::InlineFlowBox::placeBoxRangeInInlineDirection):
(WebCore::InlineFlowBox::requiresIdeographicBaseline):
(WebCore::InlineFlowBox::adjustMaxAscentAndDescent):
(WebCore::InlineFlowBox::computeLogicalBoxHeights):
(WebCore::InlineFlowBox::placeBoxesInBlockDirection):
(WebCore::InlineFlowBox::computeMaxLogicalTop):
(WebCore::InlineFlowBox::flipLinesInBlockDirection):
(WebCore::InlineFlowBox::computeOverflow):
(WebCore::InlineFlowBox::firstLeafChild):
(WebCore::InlineFlowBox::lastLeafChild):
(WebCore::InlineFlowBox::computeOverAnnotationAdjustment):
(WebCore::InlineFlowBox::computeUnderAnnotationAdjustment):

  • rendering/InlineFlowBox.h:
  • rendering/InlineTextBox.h:
  • rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::positionForBox):

  • rendering/RenderBlockFlow.h:

(WebCore::RenderBlockFlow::firstRootBox):
(WebCore::RenderBlockFlow::lastRootBox):

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlockFlow::createLineBoxes):
(WebCore::RenderBlockFlow::constructLine):
(WebCore::setLogicalWidthForTextRun):
(WebCore::computeExpansionForJustifiedText):
(WebCore::RenderBlockFlow::computeInlineDirectionPositionsForSegment):
(WebCore::RenderBlockFlow::computeBlockDirectionPositionsForLine):
(WebCore::RenderBlockFlow::createLineBoxesFromBidiRuns):

  • rendering/RenderText.cpp:

(WebCore::RenderText::localCaretRect):

  • rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::isHyphenated):
(WebCore::RootInlineBox::ascentAndDescentForBox):

  • rendering/RootInlineBox.h:

(WebCore::RootInlineBox::nextRootBox):
(WebCore::RootInlineBox::prevRootBox):

  • rendering/svg/RenderSVGInlineText.cpp:

(WebCore::RenderSVGInlineText::localCaretRect):
(WebCore::RenderSVGInlineText::positionForPoint):

  • rendering/svg/RenderSVGText.cpp:

(WebCore::RenderSVGText::positionForPoint):

  • rendering/svg/SVGInlineFlowBox.cpp:

(WebCore::SVGInlineFlowBox::paintSelectionBackground):
(WebCore::SVGInlineFlowBox::paint):
(WebCore::SVGInlineFlowBox::computeTextMatchMarkerRectForRenderer):

  • rendering/svg/SVGInlineFlowBox.h:
  • rendering/svg/SVGInlineTextBox.h:
  • rendering/svg/SVGRenderTreeAsText.cpp:

(WebCore::writeRenderSVGTextBox):
(WebCore::writeSVGInlineTextBoxes):

  • rendering/svg/SVGRootInlineBox.cpp:

(WebCore::SVGRootInlineBox::paint):
(WebCore::SVGRootInlineBox::layoutCharactersInTextBoxes):
(WebCore::SVGRootInlineBox::layoutChildBoxes):
(WebCore::reverseInlineBoxRangeAndValueListsIfNeeded):

  • rendering/svg/SVGRootInlineBox.h:
  • rendering/svg/SVGTextQuery.cpp:

(WebCore::SVGTextQuery::collectTextBoxesInFlowBox):

3:36 PM Changeset in webkit [174745] by Alan Bujtas
  • 17 edits
    2 adds in trunk/LayoutTests

[Mac] Unreviewed gardening.

Rebaselining.

  • platform/mac/TestExpectations:
  • platform/mac/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.txt:
  • platform/mac/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.txt:
  • platform/mac/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.txt:
  • platform/mac/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.txt:
  • platform/mac/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.txt:
  • platform/mac/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.txt:
  • platform/mac/fast/block/float/overhanging-tall-block-expected.txt:
  • platform/mac/fast/events/constructors/mouse-event-constructor-expected.txt: Added.
  • platform/mac/fast/events/constructors/wheel-event-constructor-expected.txt: Added.
  • platform/mac/fast/text/international/hindi-spacing-expected.txt:
  • platform/mac/fast/text/international/vertical-text-glyph-test-expected.txt:
  • platform/mac/fast/text/orientation-sideways-expected.txt:
  • platform/mac/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt:
  • platform/mac/fast/writing-mode/japanese-ruby-vertical-lr-expected.txt:
  • platform/mac/fast/writing-mode/japanese-ruby-vertical-rl-expected.txt:
  • platform/mac/fast/writing-mode/vertical-font-fallback-expected.txt:
  • platform/mac/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt:
2:41 PM Changeset in webkit [174744] by roger_fong@apple.com
  • 3 edits in trunk/Source/WebCore

glReadPixels on NVIDIA cards returns the wrong values for the alpha channel when alpha is off.
​https://bugs.webkit.org/show_bug.cgi?id=137752.
<rdar://problem/15408133>

Reviewed by Brent Fulgham.

This change fixed the 1.0.2 conformance test: context/context-attribute-preserve-drawing-buffer.html

  • platform/graphics/GraphicsContext3D.h:
  • platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:

Manually set the alpha channel to 255 when alpha is off on the rendering context.

1:56 PM Changeset in webkit [174743] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

Add --json flag to test-webkitpy to emit JSON formatted test results
to stdout
​https://bugs.webkit.org/show_bug.cgi?id=137353

Patch by Jake Nielsen <​jacob_nielsen@apple.com> on 2014-10-15
Reviewed by Daniel Bates.

  • Scripts/webkitpy/port/server_process_unittest.py:

Adds the read method to MockFile to allow the stdout of test_webkitpy
to be redirected without causing erroneous test failures.
In particular,
webkitpy.port.server_process_unittest.TestServerProcess.test_broken_pipe
and
webkitpy.port.server_process_unittest.TestServerProcess.test_cleanup
because when redirecting to a file, the
_wait_for_data_and_update_buffers_using_select method in
server_process.py will find that there is a read file descriptor in
its call to select.select, which eventually leads to it calling read()
on the MockFile object.
(MockFile.read):

  • Scripts/webkitpy/test/main.py:

Adds the _print_results_as_json method and the --json flag which
determines whether _print_results_as_json will get called.
(Tester._parse_args):
(Tester._print_results_as_json):
(Tester._print_results_as_json.result_dict_from_tuple):
(Tester._run_tests):

12:39 PM Changeset in webkit [174742] by mitz@apple.com
  • 4 edits
    1 add in trunk/Source/WebKit2

[Cocoa] "Plug-in will handle load" error isn't declared in the modern API
​https://bugs.webkit.org/show_bug.cgi?id=137747

Reviewed by Anders Carlsson.

  • UIProcess/API/Cocoa/WKError.mm: Define _WKLegacyErrorDomain.
  • UIProcess/API/Cocoa/WKErrorInternal.h: Changed to import WKErrorPrivate.h.
  • UIProcess/API/Cocoa/WKErrorPrivate.h: Added. Declares _WKLegacyErrorDomain

and _WKLegacyErrorPlugInWillHandleLoad.

  • WebKit2.xcodeproj/project.pbxproj: Added new private header.
12:35 PM Changeset in webkit [174741] by Chris Fleizach
  • 9 edits in trunk

AX: Going back is broken for VoiceOver
​https://bugs.webkit.org/show_bug.cgi?id=137382

Reviewed by Darin Adler.

Source/WebCore:

There were two issues preventing VoiceOver from navigating when using page history to go back/forward.

1) Existing AXLoadComplete does not get fired when you just move through page history.

There were existing frameLoad notifications used by GTK. I think we should use those which seem more reliable.

2) The AccessibilityScrollView cached its children, but on some history page loads, that cache was never cleared out.

Rather than trying to find those places to clear out the cache, it's easier to just add the elements to the children
array everytime it's asked for. Since there's only ever 3 elements (web area + 2 scroll bars) this should not be a performance hit.

Tests are not possible since they require monitoring notifications across multiple page loads.

  • accessibility/AXObjectCache.h:
  • accessibility/AccessibilityScrollView.cpp:

(WebCore::AccessibilityScrollView::updateChildrenIfNecessary):

  • accessibility/ios/AXObjectCacheIOS.mm:

(WebCore::AXObjectCache::frameLoadingEventPlatformNotification):

  • accessibility/mac/AXObjectCacheMac.mm:

(WebCore::AXObjectCache::frameLoadingEventPlatformNotification):

  • dom/Document.cpp:

(WebCore::Document::implicitClose):

LayoutTests:

Update tests now that AXLoadComplete is sent more reliably.

  • platform/mac/accessibility/aria-expanded-notifications-expected.txt:
  • platform/mac/accessibility/aria-expanded-notifications.html:
12:18 PM Changeset in webkit [174740] by Simon Fraser
  • 3 edits
    3 adds in trunk

Sometimes can't scroll overflow:scroll areas in subframes
​https://bugs.webkit.org/show_bug.cgi?id=137746
rdar://problem/18603560

Reviewed by Tim Horton.

Source/WebCore:

r169733 introduced a regression which caused us to no longer update the non-fast
scrollable region on every layout in subframes, by adding a bogus isMainFrame() check.
Revert to the previous code.

Test: platform/mac-wk2/tiled-drawing/scrolling/frames/scroll-region-after-frame-layout.html

  • page/scrolling/AsyncScrollingCoordinator.cpp:

(WebCore::AsyncScrollingCoordinator::frameViewLayoutUpdated):

LayoutTests:

Test that changes an overflow size in a subframe and then dumps the non-fast scrollable region.

  • platform/mac-wk2/tiled-drawing/scrolling/frames/resources/layouting-frame.html: Added.
  • platform/mac-wk2/tiled-drawing/scrolling/frames/scroll-region-after-frame-layout-expected.txt: Added.
  • platform/mac-wk2/tiled-drawing/scrolling/frames/scroll-region-after-frame-layout.html: Added.
12:15 PM Changeset in webkit [174739] by Chris Dumez
  • 21 edits in trunk/Source

Use is<>() / downcast<>() for TransformOperation subclasses
​https://bugs.webkit.org/show_bug.cgi?id=137731

Reviewed by Darin Adler.

Use is<>() / downcast<>() for TransformOperation subclasses and clean
up the surrounding code.

Source/WebCore:

No new tests, no behavior change.

  • platform/graphics/GraphicsLayer.cpp:

(WebCore::GraphicsLayer::validateTransformOperations):

  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::getTransformFunctionValue):

  • platform/graphics/transforms/IdentityTransformOperation.h:
  • platform/graphics/transforms/Matrix3DTransformOperation.cpp:

(WebCore::Matrix3DTransformOperation::operator==):

  • platform/graphics/transforms/Matrix3DTransformOperation.h:
  • platform/graphics/transforms/MatrixTransformOperation.cpp:

(WebCore::MatrixTransformOperation::operator==):
(WebCore::MatrixTransformOperation::blend):

  • platform/graphics/transforms/MatrixTransformOperation.h:
  • platform/graphics/transforms/PerspectiveTransformOperation.cpp:

(WebCore::PerspectiveTransformOperation::operator==):
(WebCore::PerspectiveTransformOperation::blend):

  • platform/graphics/transforms/PerspectiveTransformOperation.h:
  • platform/graphics/transforms/RotateTransformOperation.cpp:

(WebCore::RotateTransformOperation::operator==):
(WebCore::RotateTransformOperation::blend):

  • platform/graphics/transforms/RotateTransformOperation.h:
  • platform/graphics/transforms/ScaleTransformOperation.cpp:

(WebCore::ScaleTransformOperation::operator==):
(WebCore::ScaleTransformOperation::blend):

  • platform/graphics/transforms/ScaleTransformOperation.h:
  • platform/graphics/transforms/SkewTransformOperation.cpp:

(WebCore::SkewTransformOperation::operator==):
(WebCore::SkewTransformOperation::blend):

  • platform/graphics/transforms/SkewTransformOperation.h:
  • platform/graphics/transforms/TransformOperation.h:
  • platform/graphics/transforms/TranslateTransformOperation.cpp:

(WebCore::TranslateTransformOperation::operator==):
(WebCore::TranslateTransformOperation::blend):

  • platform/graphics/transforms/TranslateTransformOperation.h:

Source/WebKit2:

  • Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp:

(IPC::ArgumentCoder<TransformOperations>::encode):

12:04 PM Changeset in webkit [174738] by Alan Bujtas
  • 2 edits in trunk/LayoutTests

[Mac] Unreviewed gardening.

Rebaselining.

  • css3/flexbox/flex-rounding.html:
11:34 AM Changeset in webkit [174737] by Alan Bujtas
  • 2 edits in trunk/LayoutTests

[Mac] Unreviewed gardening.

Unskip some subpixel related tests.

  • platform/mac/TestExpectations:
11:04 AM Changeset in webkit [174736] by Alan Bujtas
  • 2 edits in trunk/LayoutTests

[Mac] Unreviewed gardening.

css3/flexbox/flex-rounding.html passes now that subpixel is on.

  • platform/mac/TestExpectations:
11:00 AM Changeset in webkit [174735] by ap@apple.com
  • 3 edits in trunk/Source/WebKit2

[Mac] Allow some Kerberos related paths in sandbox
​https://bugs.webkit.org/show_bug.cgi?id=137666
rdar://problem/17965010

Reviewed by Darin Adler.

  • NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in:
  • WebProcess/com.apple.WebProcess.sb.in:
11:00 AM Changeset in webkit [174734] by bshafiei@apple.com
  • 1 copy in tags/Safari-601.1.4

New tag.

10:58 AM Changeset in webkit [174733] by bshafiei@apple.com
  • 5 edits in trunk/Source

Versioning.

10:36 AM Changeset in webkit [174732] by Chris Dumez
  • 12 edits in trunk/Source

Use is<>() / downcast<>() for RenderTextControl / RenderTextControlSingleLine
​https://bugs.webkit.org/show_bug.cgi?id=137727

Reviewed by Darin Adler.

Use is<>() / downcast<>() for RenderTextControl / RenderTextControlSingleLine.

Source/WebCore:

No new tests, no behavior change.

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::selectedText):
(WebCore::AccessibilityRenderObject::selectedTextRange):
(WebCore::AccessibilityRenderObject::setSelectedTextRange):
(WebCore::AccessibilityRenderObject::visiblePositionForIndex):
(WebCore::AccessibilityRenderObject::indexForVisiblePosition):

  • editing/TextIterator.cpp:

(WebCore::TextIterator::handleReplacedElement):

  • html/TextFieldInputType.cpp:

(WebCore::TextFieldInputType::forwardEvent):

  • html/shadow/TextControlInnerElements.cpp:

(WebCore::TextControlInnerElement::customStyleForRenderer):

  • page/EventHandler.cpp:

(WebCore::EventHandler::capsLockStateMayHaveChanged):

  • page/ios/FrameIOS.mm:

(WebCore::ancestorRespondingToScrollWheelEvents):

  • rendering/RenderTextControl.h:
  • rendering/RenderTextControlSingleLine.h:
  • rendering/SimpleLineLayout.cpp:

(WebCore::SimpleLineLayout::canUseFor):

Source/WebKit/ios:

  • WebCoreSupport/WebVisiblePosition.mm:

(-[DOMHTMLInputElement startPosition]):
(-[DOMHTMLInputElement endPosition]):
(-[DOMHTMLTextAreaElement startPosition]):
(-[DOMHTMLTextAreaElement endPosition]):

10:33 AM Changeset in webkit [174731] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

[Mac] Allow plug-ins to read managed preferences
​https://bugs.webkit.org/show_bug.cgi?id=137665
<rdar://problem/18255601>

Reviewed by Darin Adler.

  • Resources/PlugInSandboxProfiles/com.apple.WebKit.plugin-common.sb:
10:21 AM Changeset in webkit [174730] by Alan Bujtas
  • 5 edits in trunk/LayoutTests

Subpixel layout: Unskip fast/sub-pixel directory.
​https://bugs.webkit.org/show_bug.cgi?id=137732

Reviewed by Simon Fraser.

Unskip tests.

  • TestExpectations:
  • fast/sub-pixel/inline-block-with-padding-expected.txt: minor adjustment.
  • fast/sub-pixel/zoomed-em-border-expected.html: minor adjustment.
  • platform/mac/TestExpectations: we still have to skip couple of tests.
10:13 AM Changeset in webkit [174729] by Chris Dumez
  • 7 edits in trunk/Source/WebCore

Use is<>() / downcast<>() for ClipPathOperation subclasses
​https://bugs.webkit.org/show_bug.cgi?id=137733

Reviewed by Mihnea Ovidenie.

Use is<>() / downcast<>() for ClipPathOperation subclasses.

No new tests, no behavior change.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::ComputedStyleExtractor::propertyValue):

  • css/DeprecatedStyleBuilder.cpp:

(WebCore::ApplyPropertyClipPath::applyValue):

  • rendering/ClipPathOperation.h:
  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::nodeAtPoint):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::setupClipPath):

  • rendering/svg/SVGRenderingContext.cpp:

(WebCore::SVGRenderingContext::prepareToRenderSVGContent):

10:01 AM Changeset in webkit [174728] by dfarler@apple.com
  • 2 edits in trunk/Tools

[iOS] LayoutTestRelay: Detect broken pipe when reading simulator app's stdout and stderr.
​https://bugs.webkit.org/show_bug.cgi?id=137662

Reviewed by Darin Adler.

The layout test harness can close LayoutTestRelay's subprocess
stdout and stderr in the case of a timeout or if a run is
cancelled and the FIFOs are cleaned up. If LayoutTestRelay
finds that no one is listening to its stdout/stderr (broken
pipe), then just exit(1), there is nothing to report.

  • LayoutTestRelay/LayoutTestRelay/LTRelayController.m:

(-[LTRelayController didReceiveStdoutData:]):
Add @try/@catch for NSFileHandleOperationException.
(-[LTRelayController didReceiveStderrData:]):
Add @try/@catch for NSFileHandleOperationException.

9:53 AM Changeset in webkit [174727] by Chris Dumez
  • 2 edits in trunk/Source/WebCore

[Mac] Use CFDictionaryContainsKey() in ImageSource::isSizeAvailable()
​https://bugs.webkit.org/show_bug.cgi?id=137723

Reviewed by Simon Fraser.

Use CFDictionaryContainsKey() in ImageSource::isSizeAvailable() instead
of CFDictionaryGetValue() as we are not actually interested in the
value.

No new tests, no behavior change.

  • platform/graphics/cg/ImageSourceCG.cpp:

(WebCore::ImageSource::isSizeAvailable):

6:37 AM Changeset in webkit [174726] by abucur@adobe.com
  • 2 edits
    6 adds in trunk/PerformanceTests

[Multicol] Start adding performance tests for the multi-column implementation
​https://bugs.webkit.org/show_bug.cgi?id=137687

Reviewed by Mihnea Ovidenie.

This patch creates a Multicol folder inside the Layout performance tests suite. It adds only two tests
as described below.

The tests are skipped until the implementation stabilizes.

  • Layout/Multicol/MulticolManyColumns.html: Added.

This test verifies the performance of the multi-column implementation with two nested multi-column
containers, the first having 20 columns and the second 10 columns.

  • Layout/Multicol/MulticolNested.html: Added.

This test verifies the performance of nesting multi-column containers in the presence
of floats.

  • Layout/Multicol/resources/multicol-content-many-columns.html: Added.
  • Layout/Multicol/resources/multicol-content-nested.html: Added.
  • Skipped: Skip the Multicol folder for now.
1:31 AM Changeset in webkit [174725] by mihnea@adobe.com
  • 3 edits in trunk/Source/WebCore

Use modern loops in subtrees selection code
​https://bugs.webkit.org/show_bug.cgi?id=137688

Reviewed by Andreas Kling.

No new tests as no change in functionality.

  • rendering/RenderView.cpp:

(WebCore::RenderView::splitSelectionBetweenSubtrees):
(WebCore::RenderView::updateSelectionForSubtrees):
(WebCore::RenderView::clearSubtreeSelection):
(WebCore::RenderView::applySubtreeSelection):

  • rendering/RenderView.h:
12:33 AM Changeset in webkit [174724] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[GTK] Minibrowser : Add keyboard support for zoom in , zoom out and default zoom in GTK Minibrowser
​https://bugs.webkit.org/show_bug.cgi?id=137060

Patch by Rohit Kumar <​kumar.rohit@samsung.com> on 2014-10-15
Reviewed by Philippe Normand.

Add keyboard support for zoom in , zoom out and default zoom using 'Ctrl' + '+', 'Ctrl' + '-' and 'Ctrl' + '0' respectively.

  • MiniBrowser/gtk/BrowserWindow.c:

(zoomInCallback):
(zoomOutCallback):
(defaultZoomCallback): Callback for default zoom keyboard support.
(browser_window_init):

Note: See TracTimeline for information about the timeline view.