Timeline

Oct 17, 2014:

8:37 PM Changeset in webkit [174858] by gyuyoung.kim@samsung.com

• 6 edits in trunk/Source/WebCore

Apply std::unique_ptr to FooFont classes
​https://bugs.webkit.org/show_bug.cgi?id=137769

Reviewed by Andreas Kling.

As a step to use std::unique_ptr, this patch applies std::unique_ptr to Font classes.

No new tests, no behavior changes.

• platform/graphics/Font.cpp:

(WebCore::retrieveOrAddCachedFontGlyphs):
(WebCore::Font::createLayout):

• platform/graphics/SimpleFontData.cpp:

(WebCore::SimpleFontData::DerivedFontData::create):

• platform/graphics/SimpleFontData.h:

Remove create() factory function because public ctor and std::make_unique<> can replace it.

• platform/graphics/mac/ComplexTextController.cpp:

(WebCore::Font::createLayout):

8:35 PM Changeset in webkit [174857] by gyuyoung.kim@samsung.com

• 8 edits in trunk/Source/WebCore

Use std::unique_ptr in WebCore/bindings
​https://bugs.webkit.org/show_bug.cgi?id=137808

Reviewed by Andreas Kling.

Clean up PassOwnPtr|OwnPtr in WebCore/bindings by using std::unique_ptr, std::make_unique
and WTF::move.

No new tests, no behavior changes.

• bindings/generic/ActiveDOMCallback.h:
• bindings/js/JSMessageEventCustom.cpp:

(WebCore::handleInitMessageEvent):

• bindings/js/SerializedScriptValue.cpp:

(WebCore::SerializedScriptValue::SerializedScriptValue):
(WebCore::SerializedScriptValue::transferArrayBuffers):
(WebCore::SerializedScriptValue::create):

• bindings/js/SerializedScriptValue.h:
• bindings/js/WorkerScriptDebugServer.cpp:

(WebCore::WorkerScriptDebugServer::interruptAndRunTask):

• bindings/js/WorkerScriptDebugServer.h:
• inspector/WorkerDebuggerAgent.cpp:

(WebCore::WorkerDebuggerAgent::interruptAndDispatchInspectorCommands):

6:12 PM Changeset in webkit [174856] by mark.lam@apple.com

• 3 edits in trunk/Source/JavaScriptCore

Web Process crash when starting the web inspector after r174025.
<​https://webkit.org/b/137340>

Reviewed by Filip Pizlo.

After r174025, we can generate a bad graph in the DFG fixup phase like so:

102:<!0:-> StoreBarrier(Check:KnownCell:@19, ..., bc#44)
60:<!0:-> PutStructure(Check:KnownCell:@19, ..., bc#44)
103:<!0:-> Check(Check:NotCell:@54, ..., bc#44)

^{-- PutByOffset's StoreBarrier has been elided and replaced
with a speculation check which can OSR exit.}

61:<!0:-> PutByOffset(Check:KnownCell:@19, ..., bc#44)

As a result, the structure change will get executed even if we end up OSR
exiting before the PutByOffset. In the baseline JIT code, the structure now
erroneously tells the put operation that there is a value in that property
slot when it is actually uninitialized (hence, the crash).

The fix is to insert the Check at the earliest point possible:

1. If the checked node is in the same bytecode as the PutByOffset, then the earliest point where we can insert the Check is right after the checked node.

2. If the checked node is from a preceding bytecode (before the PutByOffset), then the earliest point where we can insert the Check is at the start of the current bytecode.

Also reverted the workaround from r174749: ​https://webkit.org/b/137758.

Benchmark results appear to be a wash on aggregate.

• dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::indexOfNode):
(JSC::DFG::FixupPhase::indexOfFirstNodeOfExitOrigin):
(JSC::DFG::FixupPhase::fixupNode):
(JSC::DFG::FixupPhase::insertCheck):

• dfg/DFGInsertionSet.h:

(JSC::DFG::InsertionSet::insertOutOfOrder):
(JSC::DFG::InsertionSet::insertOutOfOrderNode):

5:25 PM Changeset in webkit [174855] by roger_fong@apple.com

• 2 edits in trunk/Source/WebCore

Calling glReadPixels with BGRA format on an NVIDIA machine with an opaque context returns the wrong alpha values.
​https://bugs.webkit.org/show_bug.cgi?id=137793.
<rdar://problem/15408133>

Reviewed by Dean Jackson.

This fixes conformance test context/context-attribute-preserve-drawing-buffer.html.

• platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:

(WebCore::GraphicsContext3D::readPixelsAndConvertToBGRAIfNecessary):
On an NVIDIA machine, when the context has alpha turned off, call glReadPixels with RGBA format and then convert to RGBA.

5:21 PM Changeset in webkit [174854] by Chris Dumez

• 29 edits in trunk/Source/WebCore

Use is<>() / downcast<>() for all SVG RenderObjects
​https://bugs.webkit.org/show_bug.cgi?id=137840

Reviewed by Benjamin Poulain.

Use is<>() / downcast<>() for all SVG RenderObjects and clean up the
surrounding code.

No new tests, no behaviro change.

• accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::supportsPath):
(WebCore::AccessibilityRenderObject::elementPath):

• page/FrameView.cpp:

(WebCore::FrameView::applyOverflowToViewport):
(WebCore::FrameView::forceLayoutParentViewIfNeeded):

• rendering/RenderLayerFilterInfo.cpp:

(WebCore::RenderLayer::FilterInfo::removeReferenceFilterClients):

• rendering/svg/RenderSVGGradientStop.cpp:

(WebCore::RenderSVGGradientStop::styleDidChange):

• rendering/svg/RenderSVGImage.h:
• rendering/svg/RenderSVGInlineText.h:
• rendering/svg/RenderSVGResourceContainer.cpp:

(WebCore::RenderSVGResourceContainer::markAllClientsForInvalidation):

• rendering/svg/RenderSVGResourceContainer.h:
• rendering/svg/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::addResourceForClientInvalidation):

• rendering/svg/RenderSVGRoot.h:
• rendering/svg/RenderSVGShape.h:
• rendering/svg/RenderSVGText.cpp:

(WebCore::collectLayoutAttributes):
(WebCore::RenderSVGText::subtreeChildWillBeRemoved):
(WebCore::RenderSVGText::subtreeTextDidChange):
(WebCore::updateFontInAllDescendants):

• rendering/svg/RenderSVGText.h:
• rendering/svg/SVGInlineTextBox.h:
• rendering/svg/SVGRenderSupport.cpp:

(WebCore::SVGRenderSupport::mapLocalToContainer):
(WebCore::SVGRenderSupport::pushMappingToContainer):
(WebCore::SVGRenderSupport::computeContainerBoundingBoxes):

• rendering/svg/SVGRenderTreeAsText.cpp:

(WebCore::writeStyle):

• rendering/svg/SVGRenderingContext.cpp:

(WebCore::SVGRenderingContext::bufferForeground):

• rendering/svg/SVGResourcesCycleSolver.cpp:

(WebCore::SVGResourcesCycleSolver::resolveCycles):

• rendering/svg/SVGRootInlineBox.cpp:

(WebCore::SVGRootInlineBox::renderSVGText):
(WebCore::SVGRootInlineBox::computePerCharacterLayoutInformation):

• svg/SVGCircleElement.cpp:

(WebCore::SVGCircleElement::svgAttributeChanged):

• svg/SVGElement.cpp:

(WebCore::SVGElement::svgAttributeChanged):

• svg/SVGEllipseElement.cpp:

(WebCore::SVGEllipseElement::svgAttributeChanged):

• svg/SVGImageElement.cpp:

(WebCore::SVGImageElement::svgAttributeChanged):
(WebCore::SVGImageElement::didAttachRenderers):

• svg/SVGLineElement.cpp:

(WebCore::SVGLineElement::svgAttributeChanged):

• svg/SVGPolyElement.cpp:

(WebCore::SVGPolyElement::svgAttributeChanged):

• svg/SVGRectElement.cpp:

(WebCore::SVGRectElement::svgAttributeChanged):

• svg/SVGSVGElement.cpp:

(WebCore::SVGSVGElement::localCoordinateSpaceTransform):
(WebCore::SVGSVGElement::currentViewBoxRect):

• svg/graphics/SVGImage.cpp:

(WebCore::SVGImage::setContainerSize):
(WebCore::SVGImage::containerSize):

4:59 PM Changeset in webkit [174853] by Chris Dumez

• 3 edits in trunk/Source/WebCore

Avoid unnecessary isSVGFont() check in SimpleFontData::applyTransforms()
​https://bugs.webkit.org/show_bug.cgi?id=137836

Reviewed by Andreas Kling.

Avoid unnecessary isSVGFont() check in SimpleFontData::applyTransforms().
This function is only called from WidthIterator::applyFontTransforms(),
which already makes sure to call applyTransforms() if isSVGFont()
returns false. This patch replaces the check with a simple assertion.

No new tests, no behavior change.

• platform/graphics/SimpleFontData.h:
• svg/SVGFontData.h:

4:50 PM Changeset in webkit [174852] by jonowells@apple.com

• 2 edits
  2 adds in trunk/Source/WebInspectorUI

Web Inspector: Add ESLint open source library to the inspector
​https://bugs.webkit.org/show_bug.cgi?id=137714

Reviewed by Joseph Pecoraro.

This adds back the eslint.js external library with a correction to Scripts/copy-user-interface-resources.pl
to prevent a build failure.

• Scripts/copy-user-interface-resources.pl: Added copy commands for ESLint.js.
• UserInterface/External/ESLint/LICENSE: Added.
• UserInterface/External/ESLint/eslint.js: Added.

4:26 PM Changeset in webkit [174851] by ddkilzer@apple.com

• 1 edit in trunk/Websites/bugs.webkit.org/data/params

Update data/params after Bugzilla 4.2.11 upgrade

• data/params:

(default_search_limit): Bump up the default search limit from
500 to 1000 because Timothy Horton asked nicely.
(maxattachmentsize): Make it an even 20 MB.
(maxlocalattachment): Bump up total amount of local attachments
stored on disk from 10 MB to 1 GB.
(smtp_debug): Let Bugzilla have its way with the config file.
(smtpserver): Fixed to use the correct mail server.
(sslbase): Fix test value that I checked in when I was testing
the update. This caused bug mail to be sent with a URL of
bugs-test.webkit.org instead of bugs.webkit.org until around
11:45 AM PDT on Thursday, October 16, 2014.
(urlbase): Ditto.

4:20 PM Changeset in webkit [174850] by ddkilzer@apple.com

• 1 edit in trunk/Websites/bugs.webkit.org/.htaccess

Prevent access to the /lib/ directory

• .htaccess: Block access to the lib directory. This may be

removed once updated Perl modules are installed on the system.

4:19 PM Changeset in webkit [174849] by ddkilzer@apple.com

• 1 edit in trunk/Websites/bugs.webkit.org/mod_perl.pl

Add lib directory to mod_perl search path

mod_perl.pl: Add lib directory to mod_perl search path. I
accidentally installed updated Perl modules under the Bugzilla
root directory instead of in the system, so this path needed to
be added to make sure up-to-date modules were used. It may be
removed once Perl modules are updated on the system.

4:15 PM Changeset in webkit [174848] by ddkilzer@apple.com

• 1 edit in trunk/Websites/bugs.webkit.org/Bugzilla/User.pm

Disable database handle statement caching to fix Internal Server Errors

• Bugzilla/User.pm:

(Bugzilla::User::visible_bugs): Disable database handle
statement caching. Apparently these statements would go bad
without the DBD module noticing, causing errors on numerous
pages.

3:58 PM Changeset in webkit [174847] by msaboff@apple.com

• 11 edits in trunk

Don't create cached functions that access lexicalGlobalObject()
​https://bugs.webkit.org/show_bug.cgi?id=137839

Reviewed by Geoffrey Garen.

Source/WebCore:

Made it so that all the JSDOMWindow special functions blur(), close(), focus() and postMessage()
are always created as needed for every prototype. Made it so that JSHTMLDocument does
the same for open(). Updated test to account for these methods not being cached

Updated tests accordingly.

• bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::getOwnPropertySlot): Updated to always create cached versions of the
special functions.

• bindings/js/JSHTMLDocumentCustom.cpp:

(WebCore::JSHTMLDocument::getOwnPropertySlot): Added to create an uncached open() method when
it is first accessed.

• html/HTMLDocument.idl: Added CustomGetOwnPropertySlot and implemented it in JSHTMLDocumentCustom.cpp.

LayoutTests:

Updadted test that check for

• fast/dom/wrapper-scope-expected.txt:
• fast/dom/wrapper-scope.html:

Removed "close" and "postMessage" from functions to check for wrapper scope.

• http/tests/security/cross-frame-access-put-expected.txt:
• http/tests/security/resources/cross-frame-iframe-for-put-test.html:

Removed "blur", "close" and "focus" from the functions to test, since this tests that
a parent's and child window's instances are the same. Now they are always different.

• js/dom/global-function-resolve-expected.txt:
• js/dom/script-tests/global-function-resolve.js:

Removed "close" from this lists of functions to check.

3:30 PM Changeset in webkit [174846] by Simon Fraser

• 2 edits in trunk/Source/WebCore

[iOS] Speculative fix for a crash under RenderLayerCompositor::updateScrollCoordinatedLayer()
​https://bugs.webkit.org/show_bug.cgi?id=137837
rdar://problem/18545452

Reviewed by Tim Horton.

Crash logs suggest that an iframe's RenderView's RenderLayer's backing can be null
in a call to updateScrollCoordinatedLayer(), so add an assertion (to help find a reproducible case)
and a null check.

• rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::attachScrollingNode):

3:28 PM Changeset in webkit [174845] by commit-queue@webkit.org

• 1 edit
  1 delete in trunk/Tools

Remove run-inspector-perf-tests.py there is no PerformanceTests/inspector anymore
​https://bugs.webkit.org/show_bug.cgi?id=137835

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-10-17
Reviewed by Andreas Kling.

• Scripts/run-inspector-perf-tests.py: Removed.

This script is stale, as PerformanceTests/inspector no longer exists.

3:12 PM Changeset in webkit [174844] by Simon Fraser

• 2 edits in trunk/Tools

Fix typo: should be ios-simulator-wk2, not ios-simulator_wk2.

• Scripts/webkitpy/port/ios.py:

(IOSSimulatorPort.default_baseline_search_path):

3:10 PM Changeset in webkit [174843] by akling@apple.com

• 2 edits in trunk/Source/WebCore

Re-arrange parentheses for compilation purposes.

• cssjit/SelectorCompiler.cpp:

(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementMatchesSelectorList):

3:05 PM Changeset in webkit [174842] by akling@apple.com

• 2 edits in trunk/Source/WebCore

Unreviewed build fix after r174838.

Use StackAllocator::addressOf() instead of the old way of grabbing at a stack reference.

• cssjit/SelectorCompiler.cpp:

(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementMatchesSelectorList):

2:52 PM Changeset in webkit [174841] by timothy_horton@apple.com

• 2 edits in trunk/Source/WebKit/mac

Build fix for 32-bit Yosemite

• WebCoreSupport/WebContextMenuClient.mm:

(WebContextMenuClient::contextMenuForEvent):
Avoid using NSItemProvider in 32-bit, because it doesn't exist.

2:25 PM Changeset in webkit [174840] by Chris Dumez

• 76 edits in trunk/Source

Use is<>() / downcast<>() for RenderBox
​https://bugs.webkit.org/show_bug.cgi?id=137804

Reviewed by Andreas Kling.

Use is<>() / downcast<>() for RenderBox and clean up the surrounding
code.

Source/WebCore:

No new tests, no behavior change.

• accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::computeAccessibilityIsIgnored):
(WebCore::AccessibilityRenderObject::accessibilityHitTest):
(WebCore::AccessibilityRenderObject::getScrollableAreaIfScrollable):
(WebCore::AccessibilityRenderObject::scrollTo):

• bindings/objc/DOMHTML.mm:

(-[DOMHTMLElement scrollYOffset]):
(-[DOMHTMLElement setScrollXOffset:scrollYOffset:adjustForIOSCaret:]):

• bindings/objc/DOMUIKitExtensions.mm:

(-[DOMNode borderRadii]):

• css/CSSComputedStyleDeclaration.cpp:

(WebCore::sizingBox):
(WebCore::computedTransform):
(WebCore::zoomAdjustedPaddingOrMarginPixelValue):
(WebCore::ComputedStyleExtractor::propertyValue):

• dom/ContainerNode.cpp:

(WebCore::ContainerNode::getLowerRightCorner):

• dom/Document.cpp:

(WebCore::Document::webkitWillEnterFullScreenForElement):

• dom/Element.cpp:

(WebCore::Element::scrollByUnits):

• dom/Node.cpp:

(WebCore::Node::defaultEventHandler):

• dom/Position.cpp:

(WebCore::endsOfNodeAreVisuallyDistinctPositions):

• editing/DeleteButtonController.cpp:

(WebCore::isDeletableElement):

• editing/EditorCommand.cpp:

(WebCore::verticalScrollDistance):

• editing/FrameSelection.cpp:

(WebCore::CaretBase::paintCaret):

• editing/TextIterator.cpp:

(WebCore::fullyClipsContents):
(WebCore::shouldEmitExtraNewlineForNode):

• editing/htmlediting.cpp:

(WebCore::absoluteBoundsForLocalCaretRect):

• html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElement::isFocusable):

• html/HTMLPlugInImageElement.cpp:

(WebCore::HTMLPlugInImageElement::checkSizeChangeForSnapshotting):

• html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::listBoxDefaultEventHandler):

• html/shadow/SliderThumbElement.cpp:

(WebCore::SliderThumbElement::setPositionFromPoint):

• inspector/InspectorOverlay.cpp:

(WebCore::buildObjectForElementInfo):

• page/AutoscrollController.cpp:

(WebCore::AutoscrollController::updateAutoscrollRenderer):

• page/EventHandler.cpp:

(WebCore::EventHandler::startPanScrolling):

• page/FrameView.cpp:

(WebCore::FrameView::embeddedContentBox):

• page/GestureTapHighlighter.cpp:
• page/SpatialNavigation.cpp:

(WebCore::isScrollableNode):

• page/animation/CSSPropertyAnimation.cpp:

(WebCore::blendFunc):

• platform/efl/RenderThemeEfl.cpp:

(WebCore::RenderThemeEfl::baselinePosition):

• plugins/PluginView.cpp:

(WebCore::PluginView::invalidateWindowlessPluginRect):

• rendering/InlineBox.cpp:

(WebCore::InlineBox::logicalHeight):
(WebCore::InlineBox::adjustPosition):

• rendering/InlineElementBox.cpp:

(WebCore::InlineElementBox::deleteLine):
(WebCore::InlineElementBox::extractLine):
(WebCore::InlineElementBox::attachLine):
(WebCore::InlineElementBox::paint):
(WebCore::InlineElementBox::nodeAtPoint):

• rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::addToLine):
(WebCore::InlineFlowBox::addReplacedChildOverflow):

• rendering/LayoutState.cpp:

(WebCore::LayoutState::LayoutState):

• rendering/RenderBlock.cpp:

(WebCore::RenderBlock::simplifiedNormalFlowLayout):
(WebCore::RenderBlock::markFixedPositionObjectForLayoutIfNeeded):
(WebCore::RenderBlock::clearPercentHeightDescendantsFrom):
(WebCore::RenderBlock::computeBlockPreferredLogicalWidths):
(WebCore::RenderBlock::addFocusRingRects):

• rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::rebuildFloatingObjectSetFromIntrudingFloats):
(WebCore::RenderBlockFlow::positionForPointWithInlineChildren):

• rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlockFlow::computeInlineDirectionPositionsForLine):
(WebCore::RenderBlockFlow::layoutLineBoxes):

• rendering/RenderBox.cpp:

(WebCore::RenderBox::findAutoscrollable):
(WebCore::computeBlockStaticDistance):
(WebCore::RenderBox::positionForPoint):
(WebCore::RenderBox::layoutOverflowRectForPropagation):

• rendering/RenderBox.h:

(WebCore::RenderBox::previousSiblingBox):
(WebCore::RenderBox::nextSiblingBox):
(WebCore::RenderBox::parentBox):
(WebCore::RenderBox::firstChildBox):
(WebCore::RenderBox::lastChildBox):

• rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::adjustedPositionRelativeToOffsetParent):
(WebCore::RenderBoxModelObject::computeStickyPositionConstraints):
(WebCore::RenderBoxModelObject::constrainingRectForStickyPosition):
(WebCore::RenderBoxModelObject::paintFillLayerExtended):
(WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry):

• rendering/RenderElement.cpp:

(WebCore::RenderElement::removeChildInternal):
(WebCore::RenderElement::styleWillChange):
(WebCore::RenderElement::repaintAfterLayoutIfNeeded):

• rendering/RenderEmbeddedObject.cpp:

(WebCore::RenderEmbeddedObject::layout):

• rendering/RenderFieldset.cpp:

(WebCore::RenderFieldset::findLegend):

• rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::adjustedPositionRelativeToOffsetParent):
(WebCore::RenderFlowThread::currentActiveRenderBox):

• rendering/RenderFlowThread.h:
• rendering/RenderFullScreen.cpp:

(WebCore::RenderFullScreen::unwrapRenderer):

• rendering/RenderImage.cpp:

(WebCore::RenderImage::layoutShadowControls):
(WebCore::RenderImage::computeIntrinsicRatioInformation):

• rendering/RenderInline.cpp:

(WebCore::RenderInline::absoluteRects):
(WebCore::RenderInline::addFocusRingRects):

• rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateLayerPosition):
(WebCore::RenderLayer::perspectiveTransform):
(WebCore::RenderLayer::perspectiveOrigin):
(WebCore::parentLayerCrossFrame):
(WebCore::RenderLayer::enclosingScrollableLayer):
(WebCore::RenderLayer::resize):
(WebCore::RenderLayer::scrollsOverflow):
(WebCore::computeReferenceBox):
(WebCore::RenderLayer::calculateClipRects):

• rendering/RenderLayer.h:
• rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateTransform):
(WebCore::RenderLayerBacking::updateGeometry):
(WebCore::RenderLayerBacking::resetContentsRect):
(WebCore::RenderLayerBacking::positionOverflowControlsLayers):
(WebCore::RenderLayerBacking::updateDirectlyCompositedBackgroundImage):
(WebCore::RenderLayerBacking::contentsBox):
(WebCore::RenderLayerBacking::backgroundBoxForPainting):
(WebCore::RenderLayerBacking::startAnimation):
(WebCore::RenderLayerBacking::startTransition):

• rendering/RenderLineBoxList.cpp:

(WebCore::RenderLineBoxList::rangeIntersectsRect):

• rendering/RenderMediaControlElements.cpp:

(WebCore::RenderMediaVolumeSliderContainer::layout):

• rendering/RenderMultiColumnFlowThread.cpp:

(WebCore::RenderMultiColumnFlowThread::firstColumnSetOrSpanner):
(WebCore::RenderMultiColumnFlowThread::nextColumnSetOrSpannerSiblingOf):
(WebCore::RenderMultiColumnFlowThread::previousColumnSetOrSpannerSiblingOf):
(WebCore::RenderMultiColumnFlowThread::resolveMovedChild):
(WebCore::isValidColumnSpanner):
(WebCore::RenderMultiColumnFlowThread::handleSpannerRemoval):

• rendering/RenderNamedFlowThread.cpp:

(WebCore::RenderNamedFlowThread::getRanges):

• rendering/RenderObject.cpp:

(WebCore::RenderObject::computeRectForRepaint):
(WebCore::RenderObject::showRegionsInformation):
(WebCore::RenderObject::showRenderObject):
(WebCore::RenderObject::mapLocalToContainer):
(WebCore::RenderObject::pushMappingToContainer):
(WebCore::RenderObject::mapAbsoluteToLocalPoint):
(WebCore::RenderObject::addAnnotatedRegions):

• rendering/RenderTable.cpp:

(WebCore::RenderTable::nodeAtPoint):

• rendering/RenderTextControlMultiLine.cpp:

(WebCore::RenderTextControlMultiLine::layoutSpecialExcludedChild):

• rendering/RenderTheme.cpp:

(WebCore::RenderTheme::baselinePosition):

• rendering/RenderThemeGtk.cpp:

(WebCore::RenderThemeGtk::baselinePosition):
(WebCore::centerRectVerticallyInParentInputElement):

• rendering/RenderThemeIOS.mm:

(WebCore::RenderThemeIOS::baselinePosition):

• rendering/RenderThemeSafari.cpp:

(WebCore::RenderThemeSafari::baselinePosition):

• rendering/RenderThemeWin.cpp:

(WebCore::RenderThemeWin::paintSearchFieldCancelButton):
(WebCore::RenderThemeWin::paintSearchFieldResultsDecorationPart):
(WebCore::RenderThemeWin::paintSearchFieldResultsButton):

• rendering/RenderTreeAsText.cpp:

(WebCore::RenderTreeAsText::writeRenderObject):
(WebCore::externalRepresentation):

• rendering/RenderView.cpp:

(WebCore::RenderView::paintBoxDecorations):

• rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::setLineBreakInfo):

• rendering/line/BreakingContextInlineHeaders.h:

(WebCore::BreakingContext::handleOutOfFlowPositioned):
(WebCore::BreakingContext::handleFloat):
(WebCore::BreakingContext::handleReplaced):

• rendering/line/LineBreaker.cpp:

(WebCore::LineBreaker::skipTrailingWhitespace):
(WebCore::LineBreaker::skipLeadingWhitespace):

• rendering/mathml/RenderMathMLUnderOver.cpp:

(WebCore::RenderMathMLUnderOver::layout):

• svg/graphics/SVGImage.cpp:

(WebCore::SVGImage::embeddedContentBox):

Source/WebKit/mac:

• WebCoreSupport/WebContextMenuClient.mm:

(WebContextMenuClient::clientFloatRectForNode):

• WebView/WebFrame.mm:

(-[WebFrame renderedSizeOfNode:constrainedToWidth:]):

Source/WebKit/win:

• WebView.cpp:

(WebView::gestureNotify):

Source/WebKit2:

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::determinePrimarySnapshottedPlugIn):
(WebKit::WebPage::plugInIsPrimarySize):

• WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::sendTapHighlightForNodeIfNecessary):

2:24 PM Changeset in webkit [174839] by akling@apple.com

• 19 edits in trunk/Source/WebCore

Get rid of wrapperContext() in DOM bindings.
<​https://webkit.org/b/137834>

Reviewed by Chris Dumez.

The "wrapper context" is always the DOMWrapperWorld, and since we're passing that around
already, we don't need a separate mechanism to get at the context.

The context is extra data stored in the DOM object's JSC::Weak (the wrapper GC object.)

• bindings/js/JSDOMBinding.h:

(WebCore::setInlineCachedWrapper):
(WebCore::cacheWrapper):
(WebCore::wrapperContext): Deleted.

• bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):

2:21 PM Changeset in webkit [174838] by benjamin@webkit.org

• 4 edits
  2 adds in trunk

Make a better use of the available registers when compiling nested selector lists
​https://bugs.webkit.org/show_bug.cgi?id=137802

Reviewed by Andreas Kling.

Source/WebCore:

Previously, when compiling a nested selector list, the compiler would start by pushing all
the allocated registers to the stack to free them for the compiled selector list.
While neat to ensure register allocation is correct, this is very inefficient.

This patch brings the first step for reducing the overhead. Instead of pushing everything
to the stack, we just push as many registers as we need for compiling the selector list.

In most cases, we have so many registers that we don't even need to push anything to the stack.

Test: fast/selectors/nth-child-of-register-requirement.html

• cssjit/SelectorCompiler.cpp:

Add an explicit type for SelectorList to keep information aggregated from all
SelectorFragmentList inside it.

SelectorFragmentList is also extended to include its register and stack requirements.
This information is then used to create a SelectorList and to compile the SelectorFragmentList.

(WebCore::SelectorCompiler::hasAnyCombinators):
We only change the elementAddressRegister when moving over combinators. This is used to detect
if a selector list clobber the elementAddressRegister or leave it untouched.

(WebCore::SelectorCompiler::computeBacktrackingMemoryRequirements):
(WebCore::SelectorCompiler::computeBacktrackingInformation):
Instead of returning a BacktrackingMemoryRequirements, update the SelectorFragmentList and SelectorList directly.

(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementMatchesSelectorList):
This is where the fun happen.
First step is keep the input untouched. For now it is simply pushed on the stack. This can be improved later.

Then we find how many allocated registers we need to save to compile the input selector list. We push those registers
to the stack and give them back to the register allocator.

With enough registers we can now compile the nested selector list. The code has changed a bit for efficiency. Instead
of creating a shortcut for success case, the code now exit on error and proceed on success. This is the general pattern
of SelectorCompiler and it is quite a bit more efficient in the common cases.

Finally, we reallocate the registers and get their values back from the stack. The "tail" is duplicated but that's fine
because in the vast majority of cases it is 1 or 2 pop.

(WebCore::SelectorCompiler::SelectorCodeGenerator::generateSelectorChecker):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementIsNthChildOf):

• cssjit/StackAllocator.h:

(WebCore::StackAllocator::push):

LayoutTests:

The register pressure cases are already well covered by fast/selectors/nth-child-of-boundaries-*.
The new test covers the maximum register pressure inside :nth-child(of) and having the selector with
max pressure inside a selector list instead of being alone/first.

• fast/selectors/nth-child-of-register-requirement-expected.txt: Added.
• fast/selectors/nth-child-of-register-requirement.html: Added.

2:12 PM Changeset in webkit [174837] by timothy_horton@apple.com

• 2 edits in trunk/Source/WebKit/mac

Fix the build with the public SDK.

• WebCoreSupport/WebSelectionServiceController.mm:

We should transition all this SPI to real SPI headers as soon as possible.

2:12 PM Changeset in webkit [174836] by Chris Dumez

• 12 edits in trunk/Source/WebCore

Use is<>() / downcast<>() for StyleImage
​https://bugs.webkit.org/show_bug.cgi?id=137824

Reviewed by Andreas Kling.

Use is<>() / downcast<>() for StyleImage and clean up the surrouding
code.

No new tests, no behavior change.

• css/CSSCursorImageValue.cpp:

(WebCore::CSSCursorImageValue::detachPendingImage):
(WebCore::CSSCursorImageValue::cachedImage):
(WebCore::CSSCursorImageValue::cachedImageURL):

• css/CSSImageSetValue.cpp:

(WebCore::CSSImageSetValue::detachPendingImage):
(WebCore::CSSImageSetValue::~CSSImageSetValue):
(WebCore::CSSImageSetValue::cachedImageSet):
(WebCore::CSSImageSetValue::hasFailedOrCanceledSubresources):

• css/CSSImageValue.cpp:

(WebCore::CSSImageValue::detachPendingImage):
(WebCore::CSSImageValue::cachedImage):
(WebCore::CSSImageValue::hasFailedOrCanceledSubresources):

• css/StyleResolver.cpp:

(WebCore::StyleResolver::loadPendingShapeImage):
(WebCore::StyleResolver::loadPendingImages):

• page/PageSerializer.cpp:

(WebCore::PageSerializer::retrieveResourcesForProperties):

• page/animation/CSSPropertyAnimation.cpp:

(WebCore::blendFunc):

• rendering/style/StyleCachedImage.h:
• rendering/style/StyleCachedImageSet.h:
• rendering/style/StyleGeneratedImage.h:
• rendering/style/StyleImage.h:
• rendering/style/StylePendingImage.h:

2:06 PM Changeset in webkit [174835] by Simon Fraser

• 2 edits in trunk/Tools

[iOS] Simplify test fallback paths for iOS Simulator testing
​https://bugs.webkit.org/show_bug.cgi?id=137830

Reviewed by Zalan Bujtas.

Make the fallback paths be:

ios-simulator -> generic
ios-simulator-wk2->ios-simulator -> generic

so don't include mac in the fallback path. Also remove the
version handling for simplicity.

• Scripts/webkitpy/port/ios.py:

(IOSSimulatorPort):
(IOSSimulatorPort.default_baseline_search_path):

2:03 PM Changeset in webkit [174834] by dburkart@apple.com

• 2 edits in trunk/Tools

Fix typos in Dashboard config

1:51 PM Changeset in webkit [174833] by Brent Fulgham

• 2 edits in trunk/LayoutTests

[Win] Unreviewed test gardening. Mark some tests as passing that have benefitted from recent bug fixes.

• platform/win/TestExpectations:

1:35 PM Changeset in webkit [174832] by dino@apple.com

• 2 edits in trunk/Source/WebCore

[Media] Always update controls for <audio> since they are always visible
​https://bugs.webkit.org/show_bug.cgi?id=137829
<rdar://problem/18693987>

Reviewed by Brent Fulgham.

Revision 174756 made a change to only update the display of the controls
while they are visible. However, <audio> elements didn't detect visibility
the same way, since their controls do not auto-hide.

Change controlsAreHidden to check if we're an audio element.

• Modules/mediacontrols/mediaControlsApple.js:

(Controller.prototype.controlsAreHidden): Audio elements do not auto-hide their controls.

1:02 PM Changeset in webkit [174831] by Brent Fulgham

• 6 edits in trunk/Tools

[Win] Allow WinLauncher to specify Custom User Agent strings
​https://bugs.webkit.org/show_bug.cgi?id=137828

Reviewed by Dean Jackson.

• WinLauncher/Common.cpp: Add support for custom user agent strings.
• WinLauncher/WinLauncher.cpp: Add some convenience methods to get

and set the user agent strings.

• WinLauncher/WinLauncher.h:
• WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc: Add new menu

resources and dialog for setting custom User Agent strings.

• WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h:

12:50 PM Changeset in webkit [174830] by commit-queue@webkit.org

• 11 edits
  2 adds in trunk/Source

[WinCairo] Accelerated compositing is not implemented.
​https://bugs.webkit.org/show_bug.cgi?id=137345

Patch by ​peavo@outlook.com <​peavo@outlook.com> on 2014-10-17
Reviewed by Brent Fulgham.

This patch is based on GTK, and the texture mapper graphics layer type.

Source/WebCore:

• WebCore.vcxproj/copyForwardingHeaders.cmd: Copy texmap headers.
• platform/graphics/texmap/GraphicsLayerTextureMapper.cpp: Added method and flag indicating whether animation has started.

(WebCore::GraphicsLayerTextureMapper::GraphicsLayerTextureMapper):
(WebCore::GraphicsLayerTextureMapper::addAnimation):

• platform/graphics/texmap/GraphicsLayerTextureMapper.h: Ditto.

(WebCore::GraphicsLayerTextureMapper::startedAnimation):

• platform/graphics/texmap/TextureMapperShaderProgram.cpp: Use same precision for uniform in vertex shader as in fragment shader.

Otherwise glLinkProgram() will fail, and nothing will be rendered.

Source/WebKit:

• WebKit.vcxproj/WebKit/WebKit.vcxproj: Added new accelerated compositing source files.
• WebKit.vcxproj/WebKit/WebKit.vcxproj.filters: Ditto.

Source/WebKit/win:

• WebCoreSupport/AcceleratedCompositingContext.cpp: Added.

(WebKit::AcceleratedCompositingContext::AcceleratedCompositingContext):
(WebKit::getWebViewSize):
(WebKit::AcceleratedCompositingContext::initialize):
(WebKit::AcceleratedCompositingContext::~AcceleratedCompositingContext):
(WebKit::AcceleratedCompositingContext::stopAnyPendingLayerFlush):
(WebKit::AcceleratedCompositingContext::enabled):
(WebKit::AcceleratedCompositingContext::prepareForRendering):
(WebKit::AcceleratedCompositingContext::startedAnimation):
(WebKit::AcceleratedCompositingContext::compositeLayersToContext):
(WebKit::AcceleratedCompositingContext::setRootCompositingLayer):
(WebKit::AcceleratedCompositingContext::setNonCompositedContentsNeedDisplay):
(WebKit::AcceleratedCompositingContext::setNeedsDisplayInRect):
(WebKit::AcceleratedCompositingContext::resizeRootLayer):
(WebKit::AcceleratedCompositingContext::scrollNonCompositedContents):
(WebKit::AcceleratedCompositingContext::scheduleLayerFlush):
(WebKit::AcceleratedCompositingContext::flushPendingLayerChanges):
(WebKit::AcceleratedCompositingContext::flushPendingLayerChangesSoon):
(WebKit::AcceleratedCompositingContext::flushAndRenderLayers):
(WebKit::AcceleratedCompositingContext::layerFlushTimerFired):
(WebKit::AcceleratedCompositingContext::notifyAnimationStarted):
(WebKit::AcceleratedCompositingContext::notifyFlushRequired):
(WebKit::AcceleratedCompositingContext::paintContents):

• WebCoreSupport/AcceleratedCompositingContext.h: Added.

(WebKit::AcceleratedCompositingContext::LayerFlushTimer::LayerFlushTimer):
(WebKit::AcceleratedCompositingContext::LayerFlushTimer::fired):

• WebView.cpp:

(WebView::WebView):
(WebView::addToDirtyRegion):
(WebView::scrollBackingStore):
(WebView::sizeChanged):
(WebView::paint):
(WebView::setRootChildLayer):
(WebView::flushPendingGraphicsLayerChangesSoon):
(WebView::setAcceleratedCompositing):

• WebView.h:

12:21 PM Changeset in webkit [174829] by dburkart@apple.com

• 2 edits in branches/safari-600.1-branch/LayoutTests

Mark platform/mac/accessibility/select-text.html as Failure since we can't take
​http://trac.webkit.org/changeset/172028 on branch

• platform/mac/TestExpectations:

12:16 PM Changeset in webkit [174828] by akling@apple.com

• 1 edit
  2 adds in trunk/LayoutTests

Add test for innerHTML mutations that yield identical DOM.
<​https://webkit.org/b/137823>

Reviewed by Chris Dumez.

I made this test while working on an optimization, and it seems useful
to have in the tree since it adds additional coverage. The optimization
may come later.

The test works by creating little DOM subtrees like so:

<foo><bar>some text</bar></foo>

It then overwrites that subtree with an identical one by mutating the
containing element's innerHTML property. It then verifies that the DOM
structure is correct and that Node wrappers retain any custom properties
set on them.

• fast/innerHTML/identical-mutations-expected.txt: Added.
• fast/innerHTML/identical-mutations.html: Added.

11:49 AM Changeset in webkit [174827] by ap@apple.com

• 2 edits in trunk/Source/WebCore

[iOS] Crash when load is canceled while waiting for the user to type HTTP authentication credentials
​https://bugs.webkit.org/show_bug.cgi?id=137826
rdar://problem/17329599

Reviewed by Brady Eidson.

No new tests, as we don't have a way to simulate details of user interaction with
an auth dialog.

• platform/network/cf/ResourceHandleCFNet.cpp:

(WebCore::ResourceHandle::receivedCredential):
(WebCore::ResourceHandle::receivedRequestToContinueWithoutCredential):
(WebCore::ResourceHandle::receivedRequestToPerformDefaultHandling):
(WebCore::ResourceHandle::receivedChallengeRejection):
Added null checks before passing m_connection for CFNetwork functions, making this
match what Mac code does when sending a message to a nil receiver.

11:28 AM Changeset in webkit [174826] by dburkart@apple.com

• 3 edits in branches/safari-600.1-branch/LayoutTests

Merge r171344

10:41 AM Changeset in webkit [174825] by Simon Fraser

• 2 edits in trunk/Source/WebCore

Fix the iOS build.

• platform/graphics/avfoundation/AVTrackPrivateAVFObjCImpl.mm:

(WebCore::AVTrackPrivateAVFObjCImpl::languageForAVMediaSelectionOption):

10:30 AM Changeset in webkit [174824] by Simon Fraser

• 8 edits in trunk

[iOS] Turn off font autosizing for iOS WebKitTestRunner
​https://bugs.webkit.org/show_bug.cgi?id=137806

Reviewed by Sam Weinig.
Source/WebKit2:

Confusingly, WKPreferencesSetTextAutosizingEnabled() does nothing on iOS.
Instead, we have to add WKPreferencesSetMinimumZoomFontSize() and set it to 0
to disable font autosizing.

• UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetMinimumZoomFontSize):
(WKPreferencesGetMinimumZoomFontSize):

• UIProcess/API/C/WKPreferencesRefPrivate.h:

Tools:

Confusingly, WKPreferencesSetTextAutosizingEnabled() does nothing on iOS.
Instead, we have to add WKPreferencesSetMinimumZoomFontSize() and set it to 0
to disable font autosizing.

Add platformResetPreferencesToConsistentValues() and implement it in the iOS
test controller to set platform-specific prefs.

• WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetPreferencesToConsistentValues):
(WTR::TestController::platformResetPreferencesToConsistentValues):

• WebKitTestRunner/TestController.h:
• WebKitTestRunner/ios/TestControllerIOS.mm:

(WTR::TestController::platformResetPreferencesToConsistentValues):

• WebKitTestRunner/mac/TestControllerMac.mm:

(WTR::TestController::platformResetPreferencesToConsistentValues):

9:40 AM Changeset in webkit [174823] by jer.noble@apple.com

• 12 edits
  16 adds in trunk

[Mac] Represent AVMediaSelectionOptions as AudioTracks
​https://bugs.webkit.org/show_bug.cgi?id=137474

Reviewed by Brent Fulgham.

Source/WebCore:

Test: http/tests/media/hls/hls-audio-tracks.html

Support selecting audio "tracks" in HLS streams by exposing AVMediaSelectionOptions
as entries in the video's AudioTrackList.

AVMediaSessionGroups and AVPlayerItems don't have KVO or notifications to track when options
are selected and deselected, so wrap AVMediaSessionGroup and AVMediaSessionOption in C++
wrappers. Each AVMediaSelectionGroup can have only one AVMediaSelectionOption selected at a
time, so the wrapper will take care of answering which AVMediaSelectionOption is currently
selected, as without KVO notifications, asking the AVMediaSelectionGroup directly is
inconsistent. Because setting the selected option multiple times in the same run-loop can
cause flakiness, coalesce calls to setSelectedOption() by setting a one-shot timer to do
the actual selection in the next run-loop.

• platform/graphics/avfoundation/MediaSelectionGroupAVFObjC.h: Added.

(WebCore::MediaSelectionOptionAVFObjC::avMediaSelectionOption):
(WebCore::MediaSelectionOptionAVFObjC::clearGroup): Clear backpointer to group from option.
(WebCore::MediaSelectionGroupAVFObjC::selectedOption): Simple accessor.
(WebCore::MediaSelectionGroupAVFObjC::options): Simple accessor.
(WebCore::MediaSelectionGroupAVFObjC::avMediaSelectionGroup): Simple accessor.

• platform/graphics/avfoundation/MediaSelectionGroupAVFObjC.mm: Added.

(WebCore::MediaSelectionOptionAVFObjC::create): Simple factory method.
(WebCore::MediaSelectionOptionAVFObjC::MediaSelectionOptionAVFObjC): Simple constructor.
(WebCore::MediaSelectionOptionAVFObjC::setSelected): Pass through to MediaSelectionGroupAVFObjC.
(WebCore::MediaSelectionOptionAVFObjC::selected): Ditto.
(WebCore::MediaSelectionOptionAVFObjC::index): Return index of this object in the group's object.
(WebCore::MediaSelectionGroupAVFObjC::create):
(WebCore::MediaSelectionGroupAVFObjC::MediaSelectionGroupAVFObjC):
(WebCore::MediaSelectionGroupAVFObjC::~MediaSelectionGroupAVFObjC):
(WebCore::MediaSelectionGroupAVFObjC::updateOptions): Discover added or removed options.
(WebCore::MediaSelectionGroupAVFObjC::setSelectedOption): Set a one shot timer to coalesce multiple calls.
(WebCore::MediaSelectionGroupAVFObjC::selectionTimerFired): Set the selected AVSelectionOption.

Modify AVTrackPrivateAVFObjCImpl to support both AVPlayerItemTracks and these new
MediaSelectionOptionAVFObjC objects.

• platform/graphics/avfoundation/AVTrackPrivateAVFObjCImpl.h:

(WebCore::AVTrackPrivateAVFObjCImpl::mediaSelectionOption): Simple accessor.

• platform/graphics/avfoundation/AVTrackPrivateAVFObjCImpl.mm:

(WebCore::AVTrackPrivateAVFObjCImpl::AVTrackPrivateAVFObjCImpl): Simple constructor.
(WebCore::AVTrackPrivateAVFObjCImpl::~AVTrackPrivateAVFObjCImpl): Simple destructor.
(WebCore::AVTrackPrivateAVFObjCImpl::enabled): Use MediaSelectionOptionAVFObjC, if present.
(WebCore::AVTrackPrivateAVFObjCImpl::setEnabled): Ditto.
(WebCore::AVTrackPrivateAVFObjCImpl::audioKind): Ditto.
(WebCore::AVTrackPrivateAVFObjCImpl::videoKind): Ditto.
(WebCore::AVTrackPrivateAVFObjCImpl::index): Ditto.
(WebCore::AVTrackPrivateAVFObjCImpl::id): Ditto.
(WebCore::AVTrackPrivateAVFObjCImpl::label): Ditto.
(WebCore::AVTrackPrivateAVFObjCImpl::language): Ditto.
(WebCore::AVTrackPrivateAVFObjCImpl::languageForAVMediaSelectionOption): Ditto.
(WebCore::AVTrackPrivateAVFObjCImpl::trackID): Ditto.

Allow AudioTrackPrivateAVFObjC and VideoTrackPrivateAVFObjC to be created with
a MediaSelectionOptionAVFObjC.

• platform/graphics/avfoundation/objc/AudioTrackPrivateAVFObjC.h:

(WebCore::AudioTrackPrivateAVFObjC::create): Takes a MediaSelectionOptionAVFObjC.

• platform/graphics/avfoundation/objc/AudioTrackPrivateAVFObjC.mm:

(WebCore::AudioTrackPrivateAVFObjC::AudioTrackPrivateAVFObjC): Simple constructor.
(WebCore::AudioTrackPrivateAVFObjC::setMediaSelectionOption): Create a new AVTrackPrivateAVFObjCImpl.
(WebCore::AudioTrackPrivateAVFObjC::mediaSelectionOption): Simple accessor.

• platform/graphics/avfoundation/objc/VideoTrackPrivateAVFObjC.cpp:

(WebCore::VideoTrackPrivateAVFObjC::VideoTrackPrivateAVFObjC): Simple constructor.
(WebCore::VideoTrackPrivateAVFObjC::setMediaSelectonOption): Create a new AVTrackPrivateAVFObjCImpl.
(WebCore::VideoTrackPrivateAVFObjC::mediaSelectionOption): Simple accessor.

• platform/graphics/avfoundation/objc/VideoTrackPrivateAVFObjC.h:

Because IDs are not necessarily unique across AVPlayerItemTracks and AVMediaSelectionOptions,
use the index of the track or option instead of it's self-declared ID for ordering for the
trackIndex.

• platform/graphics/avfoundation/objc/AudioTrackPrivateAVFObjC.mm:

(WebCore::AudioTrackPrivateAVFObjC::resetPropertiesFromTrack):

• platform/graphics/avfoundation/objc/VideoTrackPrivateMediaSourceAVFObjC.mm:

(WebCore::VideoTrackPrivateMediaSourceAVFObjC::resetPropertiesFromTrack):

Rather than making allowing the AVPlayerItem to automatically select the "best"
AVMediaSelectionOption, select the automatic options when creating the AVPlayerItem
and thereafter allow the users manual selections "stick".

• platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
• platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::ensureAVPlayer):
(WebCore::MediaPlayerPrivateAVFoundationObjC::ensureAVPlayerItem):

Determine whether any MediaSelectionOptionsAVFObjC have been added or removed and send trackChange events accordingly.

• platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::determineChangedTracksFromNewTracksAndOldItems): Added.
(WebCore::MediaPlayerPrivateAVFoundationObjC::updateAudioTracks): Search for updated selection options.
(WebCore::MediaPlayerPrivateAVFoundationObjC::updateVideoTracks): Ditto.
(WebCore::MediaPlayerPrivateAVFoundationObjC::safeMediaSelectionGroupForAudibleMedia): Return selection group, if available.
(WebCore::MediaPlayerPrivateAVFoundationObjC::safeMediaSelectionGroupForVisualMedia): Ditto.
(WebCore::MediaPlayerPrivateAVFoundationObjC::tracksDidChange): Filter out AVPlayerItemTracks without

AVAssetTracks, as these will be represented by MediaSelectionGroupObjCs instead.

Add new files to project.

• WebCore.xcodeproj/project.pbxproj:

LayoutTests:

• http/tests/media/hls/hls-audio-tracks-expected.txt: Added.
• http/tests/media/hls/hls-audio-tracks.html: Added.
• http/tests/media/resources/hls/audio-tracks.m3u8: Added.
• http/tests/media/resources/hls/bipbop/iframe_index.m3u8: Added.
• http/tests/media/resources/hls/bipbop/main0.ts: Added.
• http/tests/media/resources/hls/bipbop/main1.ts: Added.
• http/tests/media/resources/hls/bipbop/prog_index.m3u8: Added.
• http/tests/media/resources/hls/french/main.aac: Added.
• http/tests/media/resources/hls/french/prog_index.m3u8: Added.
• http/tests/media/resources/hls/spanish/main.aac: Added.
• http/tests/media/resources/hls/spanish/prog_index.m3u8: Added.

9:13 AM Changeset in webkit [174822] by Brent Fulgham

• 1 edit
  6 deletes in trunk/LayoutTests

[Win] Test gardening after r174796.

Now that Windows DRT matches Mac's output, we can get rid of some custom test expecations.

• platform/win/fast/dom/window-load-crash-expected.txt: Removed.
• platform/win/fast/images/crossfade-client-not-removed-crash-expected.txt: Removed.
• platform/win/fast/ruby/before-block-doesnt-crash-expected.txt: Removed.
• platform/win/fast/ruby/before-table-doesnt-crash-expected.txt: Removed.
• platform/win/fast/ruby/generated-before-counter-doesnt-crash-expected.txt: Removed.
• platform/win/loader/image-loader-adoptNode-assert-expected.txt: Removed.

9:07 AM Changeset in webkit [174821] by oliver@apple.com

• 10 edits in trunk/Source/JavaScriptCore

Various arguments optimisations in codegen fail to account for arguments being in lexical record
​https://bugs.webkit.org/show_bug.cgi?id=137617

Reviewed by Michael Saboff.

Rework the way we track |arguments| references so that we don't try
to use the |arguments| reference on the stack if it's not safe.

To do this without nuking performance it was necessary to update
the parser to track modification of the |arguments| reference
itself.

• bytecode/CodeBlock.cpp:
• bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::willResolveToArguments):
(JSC::BytecodeGenerator::uncheckedLocalArgumentsRegister):
(JSC::BytecodeGenerator::emitCall):
(JSC::BytecodeGenerator::emitConstruct):
(JSC::BytecodeGenerator::emitEnumeration):
(JSC::BytecodeGenerator::uncheckedRegisterForArguments): Deleted.

• bytecompiler/BytecodeGenerator.h:

(JSC::BytecodeGenerator::hasSafeLocalArgumentsRegister):

• bytecompiler/NodesCodegen.cpp:

(JSC::BracketAccessorNode::emitBytecode):
(JSC::DotAccessorNode::emitBytecode):
(JSC::getArgumentByVal):
(JSC::CallFunctionCallDotNode::emitBytecode):
(JSC::ApplyFunctionCallDotNode::emitBytecode):
(JSC::ArrayPatternNode::emitDirectBinding):

• interpreter/StackVisitor.cpp:

(JSC::StackVisitor::Frame::existingArguments):

• parser/Nodes.h:

(JSC::ScopeNode::modifiesArguments):

• parser/Parser.cpp:

(JSC::Parser<LexerType>::parseInner):

• parser/Parser.h:

(JSC::Scope::getCapturedVariables):

• parser/ParserModes.h:

3:51 AM Changeset in webkit [174820] by gyuyoung.kim@samsung.com

• 2 edits in trunk/Source/WebKit2

[EFL] REGRESSION(r173929): It broke the Web Inspector
​https://bugs.webkit.org/show_bug.cgi?id=137522

Reviewed by Csaba Osztrogonác.

r173929 let web inspector use a separate web process. Besides it changed that the inspector is shown
as docking mode by default. However EFL port doesn't support to show web inspector as docking window yet.
This patch is to show web inspector on EFL new window as before. Docking mode should be implemented by
upcoming patch.

• UIProcess/efl/WebInspectorProxyEfl.cpp:

(WebKit::WebInspectorProxy::platformAttach):

3:43 AM Changeset in webkit [174819] by g.czajkowski@samsung.com

• 2 edits in trunk/Source/WebCore

[EFL] window.screen.width returns wrong value if more displays are available
​https://bugs.webkit.org/show_bug.cgi?id=137778

Reviewed by Gyuyoung Kim.

ecore_x_screen_size_get() retrieves the size of Ecore_X_Screen, for example,
having two displays of 1680x1050, it will return 3360x1050.

Unlike EFL's MiniBrowser, Firefox and Chrome return screen of the current display.

No new tests. Hardware specific bug including multiple displays.

• platform/efl/PlatformScreenEfl.cpp:

(WebCore::screenRect):
Use ecore's xrandr to determine the screen on which browser window is displayed.

3:10 AM Changeset in webkit [174818] by Carlos Garcia Campos

• 7 edits in trunk/Source

[GLIB] Add API to GMainLoopSource to schedule sources after a delay in microseconds
​https://bugs.webkit.org/show_bug.cgi?id=137782

Reviewed by Sergio Villar Senin.

Source/WebCore:

• platform/gtk/SharedTimerGtk.cpp:

(WebCore::setSharedTimerFireInterval): Use microseconds instead of
milliseconds.

Source/WebKit2:

• WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp:

(WebKit::LayerTreeHostGtk::layerFlushTimerFired): Use microseconds
instead of milliseconds.

Source/WTF:

In some cases when we have a double with the time in seconds, the
conversion to milliseconds ends up truncating the value to 0, and
the source scheduled immediately.

• wtf/gobject/GMainLoopSource.cpp:

(WTF::createMicrosecondsTimeoutSource): Use a custom timeout
source that handles the interval in microseconds instead of milliseconds.
(WTF::GMainLoopSource::scheduleAfterDelay): Use MicrosecondsTimeoutSource.
(WTF::GMainLoopSource::scheduleAfterDelayAndDeleteOnDestroy): Ditto.

• wtf/gobject/GMainLoopSource.h:

3:04 AM Changeset in webkit [174817] by Carlos Garcia Campos

• 8 edits
  2 deletes in trunk/Source

[GTK] Move touch events handling from Platform to WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=137735

Reviewed by Sergio Villar Senin.

Source/WebCore:

Remove GtkTouchContextHelper.

• PlatformGTK.cmake:
• platform/gtk/GtkTouchContextHelper.cpp: Removed.
• platform/gtk/GtkTouchContextHelper.h: Removed.

Source/WebKit2:

GtkTouchContextHelper was only used by WebKitWebViewBase, since
it's the only one that can create touch events. The code has been
simplified by processing the events in the view, and the native
touch events are now created with the native event and touch points.

• Shared/NativeWebTouchEvent.h:

(WebKit::NativeWebTouchEvent::touchContext): Deleted.

• Shared/gtk/NativeWebTouchEventGtk.cpp:

(WebKit::NativeWebTouchEvent::NativeWebTouchEvent): Pass touch
points instead of touch context to WebEventFactory::createWebTouchEvent().

• Shared/gtk/WebEventFactory.cpp:

(WebKit::WebEventFactory::createWebTouchEvent): Create the
WebTouchEvent for the given native event and points.
(WebKit::touchPhaseFromEvents): Deleted.
(WebKit::appendTouchEvent): Deleted.

• Shared/gtk/WebEventFactory.h:
• UIProcess/API/gtk/WebKitWebViewBase.cpp:

(appendTouchEvent): Helper function to create a
WebPlatformTouchPoint for the given native event and add it to the
list of touch points.
(webkitWebViewBaseGetTouchPointForEvent): Build the touch point
list for the event.
(webkitWebViewBaseTouchEvent): Process the touch event.
(webkitWebViewBaseDragDataReceived): Deleted.

3:00 AM Changeset in webkit [174816] by gyuyoung.kim@samsung.com

• 2 edits in trunk/Source/WebCore

Remove unused function in WorkerThreadableLoader.h
​https://bugs.webkit.org/show_bug.cgi?id=137811

Reviewed by Csaba Osztrogonác.

mainThreadCreateLoader() isn't used anywhere. Even there is no implementation.

• loader/WorkerThreadableLoader.h:

2:54 AM Changeset in webkit [174815] by gyuyoung.kim@samsung.com

• 4 edits in trunk/Source/JavaScriptCore

Use WTF::move() instead of std::move() to help ensure move semantics in JavaScriptCore
​https://bugs.webkit.org/show_bug.cgi?id=137809

Reviewed by Csaba Osztrogonác.

Substitution of WTF::move() for std::move(). Clean up std::move() in JavaScriptCore.

• bytecode/GetByIdStatus.cpp:

(JSC::GetByIdStatus::computeForStubInfo):

• bytecode/PutByIdStatus.cpp:

(JSC::PutByIdStatus::computeForStubInfo):

• bytecode/PutByIdVariant.cpp:

(JSC::PutByIdVariant::setter):

1:27 AM Changeset in webkit [174814] by mitz@apple.com

• 2 edits in trunk/Source/WTF

Reverted incorrect build fix attempt.

• wtf/Threading.cpp:

1:23 AM Changeset in webkit [174813] by mitz@apple.com

• 2 edits in trunk/Source/WTF

Tried to fix the Yosemite build.

• wtf/Threading.cpp:

Oct 16, 2014:

11:31 PM Changeset in webkit [174812] by Carlos Garcia Campos

• 2 edits in trunk

REGRESSION(CMake): [GTK] WebKitSettings:enable-smooth-scrolling does nothing
​https://bugs.webkit.org/show_bug.cgi?id=137781

Reviewed by Martin Robinson.

We used to enable smooth scrolling unconditionally in autotools
(via WebKitFeatures.m4), but since the switch to CMake it's
unconditionally disabled, so changing the setting doesn't have any
effect.

• Source/cmake/OptionsGTK.cmake: Enable smooth scrolling.

10:34 PM Changeset in webkit [174811] by Yusuke Suzuki

• 3 edits
  4 adds in trunk

CSS Selectors Level 4: Implement :matches in SelectorChecker
​https://bugs.webkit.org/show_bug.cgi?id=137393

Reviewed by Benjamin Poulain.

Source/WebCore:

In this patch, we introduce initial :matches implementation.
In this current implementation, we don't consider pseudo elements.

Test: fast/selectors/querySelector-matches.html

• css/SelectorChecker.cpp:

(WebCore::SelectorChecker::checkOne):

LayoutTests:

• fast/selectors/matches-selector-list-expected.txt: Added.
• fast/selectors/matches-selector-list.html: Added.
• fast/selectors/querySelector-matches-expected.txt: Added.
• fast/selectors/querySelector-matches.html: Added.

10:17 PM Changeset in webkit [174810] by Yusuke Suzuki

• 3 edits in trunk/Source/WebCore

CSS JIT: Introduce StackAllocator::addressOf
​https://bugs.webkit.org/show_bug.cgi?id=137771

Reviewed by Benjamin Poulain.

Introduce StackAllocator::addressOf and drop offsetToStackReference, it's too primitive.

• cssjit/SelectorCompiler.cpp:

(WebCore::SelectorCompiler::SelectorCodeGenerator::generateSelectorChecker):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateParentElementTreeWalker):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateDirectAdjacentTreeWalker):
(WebCore::SelectorCompiler::SelectorCodeGenerator::loadCheckingContext):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateAdjacentBacktrackingTail):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateDescendantBacktrackingTail):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementIsFirstLink):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateStoreLastVisitedElement):

• cssjit/StackAllocator.h:

(WebCore::StackAllocator::addressOf):
(WebCore::StackAllocator::offsetToStackReference):

10:14 PM Changeset in webkit [174809] by mitz@apple.com

• 4 edits in trunk

OSObjectPtr is missing leakRef()
​https://bugs.webkit.org/show_bug.cgi?id=137798

Reviewed by Sam Weinig.

Source/WTF:

• wtf/OSObjectPtr.h:

Tools:

• TestWebKitAPI/Tests/WTF/darwin/OSObjectPtr.cpp:

(TestWebKitAPI::TEST(OSObjectPtr, LeakRef)): Added.

8:26 PM Changeset in webkit [174808] by Lucas Forschler

• 2 edits in trunk/Tools

Update target platform to remove Leopard, Snow Leopard, Lion.
Add Yosemite.

Unreviewed.

• BuildSlaveSupport/build.webkit.org-config/wkbuild.py:

(_should_file_trigger_build):

7:17 PM Changeset in webkit [174807] by ap@apple.com

• 3 edits
  2 adds in trunk

REGRESSION (r169024): Undetermined text is not displayed in the search field of Adobe Help Website
​https://bugs.webkit.org/show_bug.cgi?id=137679
rdar://problem/18450335

Reviewed by Enrica Casucci.

Source/WebCore:

Test: platform/mac/editing/input/selected-composed-text-painting.html

• rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paint): We do not paint

selection beckground for unconfirmed text with underlines, so we should use a regular
style for text painting, as well.

LayoutTests:

• platform/mac/editing/input/selected-composed-text-painting-expected.html: Added.
• platform/mac/editing/input/selected-composed-text-painting.html: Added.

6:54 PM Changeset in webkit [174806] by dburkart@apple.com

• 3 edits in branches/safari-600.1-branch/LayoutTests

Merge r171301

6:54 PM Changeset in webkit [174805] by Chris Dumez

• 14 edits in trunk/Source/WebCore

Use is<>() / downcast<>() for BasicShape subclasses
​https://bugs.webkit.org/show_bug.cgi?id=137766

Reviewed by Andreas Kling.

Use is<>() / downcast<>() for BasicShape subclasses and clean up the
surrounding code.

No new tests, no behavior change.

• css/BasicShapeFunctions.cpp:

(WebCore::valueForBasicShape):
(WebCore::basicShapeForValue):

• css/BasicShapeFunctions.h:
• css/CSSComputedStyleDeclaration.cpp:

(WebCore::shapePropertyValue):

• page/animation/CSSPropertyAnimation.cpp:

(WebCore::blendFunc):

• rendering/ClipPathOperation.h:

(WebCore::ShapeClipPathOperation::create):
Take a PassRef<BasicShape> in argument to make it obvious it is never
null.

(WebCore::ShapeClipPathOperation::basicShape):
Return a reference instead of a pointer as it can never return null.

(WebCore::ShapeClipPathOperation::windRule):
(WebCore::ShapeClipPathOperation::pathForReferenceRect):
Make it non-const due to the const-correctness of Ref::get().

(WebCore::ShapeClipPathOperation::ShapeClipPathOperation):

• rendering/RenderBlock.cpp:

(WebCore::RenderBlock::nodeAtPoint):

• rendering/RenderLayer.cpp:

(WebCore::RenderLayer::setupClipPath):

• rendering/shapes/Shape.cpp:

(WebCore::Shape::createShape):

• rendering/shapes/Shape.h:
• rendering/shapes/ShapeOutsideInfo.cpp:

(WebCore::ShapeOutsideInfo::computedShape):

• rendering/style/BasicShapes.cpp:

(WebCore::BasicShape::canBlend):
(WebCore::BasicShapeCircle::blend):
(WebCore::BasicShapeEllipse::blend):
(WebCore::BasicShapePolygon::blend):
(WebCore::BasicShapeInset::blend):

• rendering/style/BasicShapes.h:
• rendering/svg/SVGRenderingContext.cpp:

(WebCore::SVGRenderingContext::prepareToRenderSVGContent):

6:53 PM Changeset in webkit [174804] by Chris Dumez

• 9 edits in trunk/Source/WebCore

Leverage the new RenderElement::m_isCSSAnimating flag in more places
​https://bugs.webkit.org/show_bug.cgi?id=137786

Reviewed by Simon Fraser.

Leverage the new RenderElement::m_isCSSAnimating flag that was introduced
in r174703 in more places, for performance. This avoids doing extra work
for renderers on which we are not running animations on. This patch also
updates the API a bit to use more references instead of pointers, making
it clear the RenderElement cannot be null and thus avoiding unnecessary
null checks.

No new tests, no behavior change.

• css/CSSComputedStyleDeclaration.cpp:

(WebCore::computeRenderStyleForProperty):

• page/animation/AnimationController.cpp:

(WebCore::AnimationControllerPrivate::ensureCompositeAnimation):
(WebCore::AnimationControllerPrivate::clear):
(WebCore::AnimationControllerPrivate::updateAnimationTimerForRenderer):
(WebCore::AnimationControllerPrivate::isRunningAnimationOnRenderer):
(WebCore::AnimationControllerPrivate::isRunningAcceleratedAnimationOnRenderer):
(WebCore::AnimationControllerPrivate::pauseAnimationAtTime):
(WebCore::AnimationControllerPrivate::pauseTransitionAtTime):
(WebCore::AnimationControllerPrivate::getAnimatedStyleForRenderer):
(WebCore::AnimationController::cancelAnimations):
(WebCore::AnimationController::updateAnimations):
(WebCore::AnimationController::getAnimatedStyleForRenderer):
(WebCore::AnimationController::notifyAnimationStarted):
(WebCore::AnimationController::isRunningAnimationOnRenderer):
(WebCore::AnimationController::isRunningAcceleratedAnimationOnRenderer):

• page/animation/AnimationController.h:
• page/animation/AnimationControllerPrivate.h:
• rendering/RenderElement.cpp:

(WebCore::RenderElement::willBeDestroyed):

• rendering/RenderLayer.cpp:

(WebCore::RenderLayer::currentTransform):

• rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateGeometry):
(WebCore::RenderLayerBacking::notifyAnimationStarted):

• rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::requiresCompositingForAnimation):
(WebCore::RenderLayerCompositor::isRunningAcceleratedTransformAnimation):

6:14 PM Changeset in webkit [174803] by commit-queue@webkit.org

• 35 edits in trunk

Removing CUSTOM_PROTOCOLS guard
​https://bugs.webkit.org/show_bug.cgi?id=137741

Patch by Pascal Jacquemart <​p.jacquemart@samsung.com> on 2014-10-16
Reviewed by Benjamin Poulain.

.:

• Source/cmake/OptionsEfl.cmake:

Source/WebKit2:

• NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::NetworkProcess):

• Shared/Network/CustomProtocols/Cocoa/CustomProtocolManagerCocoa.mm:
• Shared/Network/CustomProtocols/CustomProtocolManager.h:
• Shared/Network/CustomProtocols/CustomProtocolManager.messages.in:
• Shared/Network/CustomProtocols/soup/CustomProtocolManagerImpl.cpp:
• Shared/Network/CustomProtocols/soup/CustomProtocolManagerImpl.h:
• Shared/Network/CustomProtocols/soup/CustomProtocolManagerSoup.cpp:
• Shared/Network/NetworkProcessCreationParameters.cpp:

(WebKit::NetworkProcessCreationParameters::encode):
(WebKit::NetworkProcessCreationParameters::decode):

• Shared/Network/NetworkProcessCreationParameters.h:
• Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::encode):
(WebKit::WebProcessCreationParameters::decode):

• Shared/WebProcessCreationParameters.h:
• UIProcess/API/C/soup/WKAPICastSoup.h:
• UIProcess/API/C/soup/WKSoupCustomProtocolRequestManager.cpp:

(WKSoupCustomProtocolRequestManagerGetTypeID):
(WKSoupCustomProtocolRequestManagerSetClient):

• UIProcess/Network/CustomProtocols/CustomProtocolManagerProxy.h:
• UIProcess/Network/CustomProtocols/CustomProtocolManagerProxy.messages.in:
• UIProcess/Network/CustomProtocols/mac/CustomProtocolManagerProxyMac.mm:
• UIProcess/Network/CustomProtocols/soup/CustomProtocolManagerProxySoup.cpp:
• UIProcess/Network/CustomProtocols/soup/WebSoupCustomProtocolRequestManager.cpp:
• UIProcess/Network/CustomProtocols/soup/WebSoupCustomProtocolRequestManager.h:
• UIProcess/Network/CustomProtocols/soup/WebSoupCustomProtocolRequestManagerClient.cpp:
• UIProcess/Network/CustomProtocols/soup/WebSoupCustomProtocolRequestManagerClient.h:
• UIProcess/Network/NetworkProcessProxy.cpp:

(WebKit::NetworkProcessProxy::NetworkProcessProxy):

• UIProcess/Network/NetworkProcessProxy.h:
• UIProcess/WebContext.cpp:

(WebKit::WebContext::WebContext):
(WebKit::WebContext::unregisterGlobalURLSchemeAsHavingCustomProtocolHandlers):
(WebKit::WebContext::unregisterSchemeForCustomProtocol):

• UIProcess/WebContext.h:
• UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::WebProcessProxy):

• UIProcess/WebProcessProxy.h:
• UIProcess/mac/WebContextMac.mm:

(WebKit::WebContext::platformInitializeWebProcess):
(WebKit::WebContext::platformInitializeNetworkProcess):

• WebKit2Prefix.h:
• WebProcess/WebProcess.cpp:

(WebKit::WebProcess::WebProcess):

• WebProcess/soup/WebKitSoupRequestGeneric.cpp:

(webkitSoupRequestGenericSendAsync):
(webkitSoupRequestGenericSendFinish):

• WebProcess/soup/WebKitSoupRequestGeneric.h:

6:12 PM Changeset in webkit [174802] by commit-queue@webkit.org

• 3 edits in trunk/Source/WebCore

Missing RefPtr.release() calls in TextureMapper
​https://bugs.webkit.org/show_bug.cgi?id=137777

Patch by Adrien Destugues <​pulkomandy@gmail.com> on 2014-10-16
Reviewed by Chris Dumez.

No new tests: no functional change, cleanup/optimization.

Avoids useless ref/deref cycle when returning from functions.

• platform/graphics/texmap/TextureMapper.cpp:

(WebCore::TextureMapper::acquireTextureFromPool):

• platform/graphics/texmap/TextureMapperLayer.cpp:

(WebCore::TextureMapperLayer::paintIntoSurface):

5:35 PM Changeset in webkit [174801] by Chris Dumez

• 6 edits in trunk/Source/WebCore

Use is<>() / downcast<>() for ContentData subclasses
​https://bugs.webkit.org/show_bug.cgi?id=137768

Reviewed by Andreas Kling.

Use is<>() / downcast<>() for ContentData subclasses.

No new tests, no behavior change.

• css/CSSComputedStyleDeclaration.cpp:

(WebCore::contentToCSSValue):

• css/StyleResolver.cpp:

(WebCore::StyleResolver::loadPendingImages):

• rendering/RenderElement.cpp:

(WebCore::RenderElement::createFor):

• rendering/style/ContentData.h:

(WebCore::operator==):

• rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::setContent):

4:55 PM Changeset in webkit [174800] by ddkilzer@apple.com

• 2 edits in trunk/Tools

commit-queue: fails to replace OO-PS! with reviewer name
<​http://webkit.org/b/137795>

Reviewed by Alexey Proskuryakov.

• Scripts/webkitpy/common/net/bugzilla/bugzilla.py:

(Bugzilla.fetch_bug_dictionary): Bugzilla 4.2.x never gives out
email addresses to unauthenticated page loads, so we must always
authenticate before getting bug data so we get full email
addresses.

4:39 PM Changeset in webkit [174799] by Simon Fraser

• 3 edits in trunk/Source/WebKit2

Crash under RemoteLayerTreeHost::getLayer() when closing a tab
​https://bugs.webkit.org/show_bug.cgi?id=137796
rdar://problem/18547565

Reviewed by Tim Horton.

CA can call our animation delegate after the RemoteLayerTreeHost has been
destroyed. CAAnimation retains its delegate, so it's safe for us to null out
the WKAnimationDelegate's pointer to the RemoteLayerTreeHost when tearing down
the RemoteLayerTreeHost.

• UIProcess/mac/RemoteLayerTreeHost.mm:

(WebKit::RemoteLayerTreeHost::~RemoteLayerTreeHost):
(WebKit::RemoteLayerTreeHost::animationDidEnd):

• WebProcess/WebPage/mac/PlatformCAAnimationRemote.mm:

(-[WKAnimationDelegate invalidate]):
(-[WKAnimationDelegate animationDidStart:]):
(-[WKAnimationDelegate animationDidStop:finished:]):

3:43 PM Changeset in webkit [174798] by Alan Bujtas

• 2 edits in trunk/LayoutTests

[Mac] Unreviewed gardening.

• platform/mac/TestExpectations:

3:43 PM Changeset in webkit [174797] by ddkilzer@apple.com

• 2 edits in trunk/Tools

commit-queue: fails to close bugs after successfully landing patches
<​http://webkit.org/b/137794>

Reviewed by Alexey Proskuryakov.

• Scripts/webkitpy/common/net/bugzilla/bugzilla.py:

(Bugzilla.clear_attachment_flags): Change 'nr=0' to 'nr=1' to
tell Mechanize to use the second <textarea> on the page with
name="comment".

3:08 PM Changeset in webkit [174796] by Brent Fulgham

• 7 edits in trunk/Tools

[Win] Update DRT to match Mac Logic
​https://bugs.webkit.org/show_bug.cgi?id=137787

Reviewed by Dean Jackson.

• DumpRenderTree/win/DumpRenderTree.cpp:

(initialize): 0 -> nullptr
(runTest): Initialize MSG structure before using.
(main): Add CRT debug flags if building DRT with debug malloc on Windows.
Also, cleanly shut down COM when exiting.

• DumpRenderTree/win/FrameLoadDelegate.cpp:

(FrameLoadDelegate::didChangeLocationWithinPageForFrame): Move from
header and add printf to match Mac.
(FrameLoadDelegate::windowScriptObjectAvailable): Ditto.

• DumpRenderTree/win/FrameLoadDelegate.h:

(FrameLoadDelegate::didChangeLocationWithinPageForFrame): Deleted.
(FrameLoadDelegate::windowScriptObjectAvailable): Deleted.

• DumpRenderTree/win/ResourceLoadDelegate.cpp:

(isLocalhost): Added.
(hostIsUsedBySomeTestsToGenerateError): Added.
(ResourceLoadDelegate::willSendRequest): Add logic to mimic Mac's use
of certain error and redirect host names.

• DumpRenderTree/win/UIDelegate.cpp:

(UIDelegate::runJavaScriptAlertPanelWithMessage): Use 'done' flag to decide if
anything should be output to the console. This modifies behavior to match the Mac.
(UIDelegate::runJavaScriptConfirmPanelWithMessage): Ditto.
(UIDelegate::runJavaScriptTextInputPanelWithPrompt): Ditto.
(UIDelegate::runBeforeUnloadConfirmPanelWithMessage): Ditto.
(UIDelegate::webViewAddMessageToConsole): Ditto.

• WinLauncher/PageLoadTestClient.cpp:

(PageLoadTestClient::pageLoadEndedAtTime): Drive-by-fix for an assertion that I
added last week.

3:02 PM Changeset in webkit [174795] by oliver@apple.com

• 9 edits in trunk/Source/JavaScriptCore

Use a single allocation for the Arguments object
​https://bugs.webkit.org/show_bug.cgi?id=137751

Reviewed by Filip Pizlo.

This patch removes the secondary allocation for parameters in the Arguments
object. This is faily simple, but we needed to make it possible for the JIT
to allocate a variable GC object. To do this i've added a new
emitAllocateVariableSizedJSObject function to the JIT that does the work to
find the correct heap for a variable sized allocation and then bump that
allocator.

• dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::emitAllocateArguments):

• dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::emitAllocateVariableSizedJSObject):

• heap/CopyToken.h:
• heap/Heap.h:

(JSC::Heap::subspaceForObjectWithoutDestructor):
(JSC::Heap::subspaceForObjectNormalDestructor):
(JSC::Heap::subspaceForObjectsWithImmortalStructure):

• heap/MarkedSpace.h:

(JSC::MarkedSpace::subspaceForObjectsWithNormalDestructor):
(JSC::MarkedSpace::subspaceForObjectsWithImmortalStructure):
(JSC::MarkedSpace::subspaceForObjectsWithoutDestructor):

• interpreter/StackVisitor.cpp:

(JSC::StackVisitor::Frame::createArguments):

• runtime/Arguments.cpp:

(JSC::Arguments::visitChildren):
(JSC::Arguments::copyBackingStore):
(JSC::Arguments::tearOff):
(JSC::Arguments::allocateRegisterArray): Deleted.

• runtime/Arguments.h:

(JSC::Arguments::create):
(JSC::Arguments::isTornOff):
(JSC::Arguments::offsetOfRegisterArray):
(JSC::Arguments::registerArraySizeInBytes):
(JSC::Arguments::registerArray):
(JSC::Arguments::allocationSize): Deleted.

2:58 PM Changeset in webkit [174794] by commit-queue@webkit.org

• 3 edits in trunk/Source/WebCore

Unreviewed, rolling out r174744.
​https://bugs.webkit.org/show_bug.cgi?id=137790

Caused another WebGL conformance test to fail (Requested by
rfong on #webkit).

Reverted changeset:

"glReadPixels on NVIDIA cards returns the wrong values for the
alpha channel when alpha is off."
​https://bugs.webkit.org/show_bug.cgi?id=137752
​http://trac.webkit.org/changeset/174744

2:57 PM Changeset in webkit [174793] by commit-queue@webkit.org

• 4 edits in trunk

Unreviewed, rolling out r174754.
​https://bugs.webkit.org/show_bug.cgi?id=137789

Speculative fix for Windows test was ineffective. (Requested
by rfong on #webkit).

Reverted changeset:

"[Windows] Add some more logging to debug Windows test
issues."
​http://trac.webkit.org/changeset/174754

2:33 PM Changeset in webkit [174792] by Alan Bujtas

• 2 edits in trunk/LayoutTests

[Mac] Unreviewed gardening.

Unskip more subpixel related tests.

• platform/mac/TestExpectations:

1:13 PM Changeset in webkit [174791] by timothy_horton@apple.com

• 21 edits
  2 adds in trunk/Source

Implement selection services menu for Legacy WebKit
​https://bugs.webkit.org/show_bug.cgi?id=137582
<rdar://problem/18604241>

Reviewed by Brady Eidson.

• WebCore.exp.in:
• editing/Editor.h:
• editing/ios/EditorIOS.mm:

(WebCore::Editor::replaceSelectionWithAttributedString):

• editing/mac/EditorMac.mm:

(WebCore::Editor::replaceSelectionWithAttributedString):
Add replaceSelectionWithAttributedString, which replaces the selection
with the given attributed string (converting to plain text if the destination
is not richly editable).

• WebKit.xcodeproj/project.pbxproj:

• Misc/WebSharingServicePickerController.h:

Move SPI into the header (in the near future it will be moved to a modern-style SPI header).
Add WebSharingServicePickerClient, which other classes can implement
instead of tying WebSharingServicePickerController strongly to WebContextMenuClient.
Make initWithData:... -> initWithItems:... instead, taking an array of NSItemProviders.

• Misc/WebSharingServicePickerController.mm:

Pass in NSSharingServicePickerStyle, so that clients can specify the style.

(-[WebSharingServicePickerController clear]):
(-[WebSharingServicePickerController didShareImageData:confirmDataIsValidTIFFData:]):
(-[WebSharingServicePickerController sharingServicePicker:didChooseSharingService:]):
(-[WebSharingServicePickerController sharingService:sourceFrameOnScreenForShareItem:]):
(-[WebSharingServicePickerController sharingService:transitionImageForShareItem:contentRect:]):
(-[WebSharingServicePickerController sharingService:sourceWindowForShareItems:sharingContentScope:]):
Make use of WebSharingServicePickerClient.

(-[WebSharingServicePickerController sharingService:didShareItems:]):
If we're returned a NSAttributedString, paste it on top of the current selection,
similar to what the WebKit2 implementation currently does.

• WebCoreSupport/WebChromeClient.h:
• WebCoreSupport/WebChromeClient.mm:

(WebChromeClient::handleTelephoneNumberClick):
(WebChromeClient::handleSelectionServiceClick):
(WebChromeClient::hasRelevantSelectionServices):
Override the services-related ChromeClient functions, forward them to WebSelectionServiceController.

• WebCoreSupport/WebContextMenuClient.h:
• WebCoreSupport/WebContextMenuClient.mm:

(WebContextMenuClient::sharingServicePickerWillBeDestroyed):
(WebContextMenuClient::pageForSharingServicePicker):
(WebContextMenuClient::windowForSharingServicePicker):
(WebContextMenuClient::screenRectForCurrentSharingServicePickerItem):
(WebContextMenuClient::imageForCurrentSharingServicePickerItem):
(WebContextMenuClient::contextMenuForEvent):
(WebContextMenuClient::screenRectForHitTestNode): Deleted.
(WebContextMenuClient::renderedImageForControlledImage): Deleted.
(WebContextMenuClient::clearSharingServicePickerController): Deleted.
Have WebContextMenuClient implement WebSharingServicePickerClient to avoid
having WebSharingServicePickerController tightly bound to it.
Make an NSItemProvider array when instantiating WebSharingServicePickerController
instead of handing it data directly.

• WebCoreSupport/WebSelectionServiceController.h: Copied from Source/WebKit/mac/WebCoreSupport/WebContextMenuClient.h.
• WebCoreSupport/WebSelectionServiceController.mm: Added.

(WebSelectionServiceController::WebSelectionServiceController):
Add WebSelectionServiceController, which will act as the WebSharingServicePickerClient
for selection services.

(WebSelectionServiceController::handleSelectionServiceClick):
Create a WebSharingSericePickerController with the selection's attributed string, and show its menu.

(hasCompatibleServicesForItems):
(WebSelectionServiceController::hasRelevantSelectionServices):
Determine whether or not services are available.

(WebSelectionServiceController::sharingServicePickerWillBeDestroyed):
(WebSelectionServiceController::pageForSharingServicePicker):
(WebSelectionServiceController::windowForSharingServicePicker):
Implement the rest of the WebSharingServicePickerClient overrides.

(WebSelectionServiceController::screenRectForCurrentSharingServicePickerItem):
(WebSelectionServiceController::imageForCurrentSharingServicePickerItem):
These are only useful for image sharing services, so we don't need to
implement them (WebContextMenuClient does, on the other hand).

• WebView/WebView.mm:

(-[WebView _selectionServiceController]):

• WebView/WebViewData.h:
• WebView/WebViewData.mm:
• WebView/WebViewInternal.h:

Keep a WebSelectionServiceController.

• UIProcess/mac/WebContextMenuProxyMac.mm:

(-[WKSharingServicePickerDelegate sharingService:didShareItems:]):
Add a note that we should transition to using replaceSelectionWithAttributedString.

• WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::handleSelectionServiceClick):
Allow editor services in editable-but-not-rich-text areas, just like in WebKit1.

12:56 PM Changeset in webkit [174790] by fpizlo@apple.com

• 2 edits
  1 add in trunk/Source/JavaScriptCore

Apparently we've had a hole in arguments capture all along
​https://bugs.webkit.org/show_bug.cgi?id=137767

Reviewed by Oliver Hunt.

• dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::getArgument):

• tests/stress/arguments-captured.js: Added.

(foo):
(bar):

12:55 PM Changeset in webkit [174789] by saambarati1@gmail.com

• 16 edits in trunk/Source/JavaScriptCore

Have the ProfileType node in the DFG convert to a structure check where it can
​https://bugs.webkit.org/show_bug.cgi?id=137596

Reviewed by Filip Pizlo.

TypeSet now keeps track of the live set of Structures it has seen.
It no longer nukes everything during GC. It now only removes unmarked
structures during GC. This modification allows the ProfileType node
to convert into a CheckStructure node safely in the DFG.

This change brings up the conversion rate from ProfileType to Check
or CheckStructrue from ~45% to ~65%. This change also speeds the
type profiler up significantly: consistently between 2x-20x faster.

This patch also does some slight refactoring: a few type profiler
related fields are moved from VM to TypeProfiler.

• bytecode/CodeBlock.cpp:

(JSC::CodeBlock::CodeBlock):

• dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

• dfg/DFGNode.h:

(JSC::DFG::Node::convertToCheckStructure):

• heap/Heap.cpp:

(JSC::Heap::collect):

• runtime/SymbolTable.cpp:

(JSC::SymbolTable::uniqueIDForVariable):

• runtime/SymbolTable.h:
• runtime/TypeLocationCache.cpp:

(JSC::TypeLocationCache::getTypeLocation):

• runtime/TypeProfiler.cpp:

(JSC::TypeProfiler::TypeProfiler):
(JSC::TypeProfiler::nextTypeLocation):
(JSC::TypeProfiler::invalidateTypeSetCache):
(JSC::TypeProfiler::dumpTypeProfilerData):

• runtime/TypeProfiler.h:

(JSC::TypeProfiler::getNextUniqueVariableID):

• runtime/TypeProfilerLog.cpp:

(JSC::TypeProfilerLog::processLogEntries):

• runtime/TypeSet.cpp:

(JSC::TypeSet::addTypeInformation):
(JSC::TypeSet::invalidateCache):

• runtime/TypeSet.h:

(JSC::TypeSet::structureSet):

• runtime/VM.cpp:

(JSC::VM::VM):
(JSC::VM::enableTypeProfiler):
(JSC::VM::disableTypeProfiler):
(JSC::VM::dumpTypeProfilerData):
(JSC::VM::nextTypeLocation): Deleted.
(JSC::VM::invalidateTypeSetCache): Deleted.

• runtime/VM.h:

(JSC::VM::typeProfiler):
(JSC::VM::getNextUniqueVariableID): Deleted.

• tests/typeProfiler/dfg-jit-optimizations.js:

12:53 PM Changeset in webkit [174788] by timothy_horton@apple.com

• 3 edits in trunk/Source/WebKit2

Various crashes in ViewGestureControllerIOS when closing a tab while a swipe gesture is in progress
​https://bugs.webkit.org/show_bug.cgi?id=137770
<rdar://problem/17916459>

Reviewed by Dan Bernstein.

When tearing down a WKWebView in the middle of a swipe gesture, a variety of
UI process crashes were observed. First, two uses of potentially deleted objects
(the WebBackForwardListItem and ViewGestureController), which were fixed by
extending the object's lifetime and checking for its liveness, respectively.
Second, a potential null-deref of DrawingArea if the timing of endSwipeGesture
vs. page teardown was such that DrawingArea was null but everything else was in line.
Lastly, another case of messaging a potentially deleted object (specifically,
the _UIViewControllerTransitionContext's animator) in a callback from CA, which
was fixed by nulling out the animator (and a few other properties) when tearing
down the ViewGestureController.

• UIProcess/ios/ViewGestureControllerIOS.mm:

(-[WKSwipeTransitionController invalidate]):
Clear the soon-to-be-invalid ViewGestureController pointer.

(WebKit::ViewGestureController::~ViewGestureController):
Call [WKSwipeTransitionController invalidate] upon destruction.
Clear our transition context's interactor and animator, and inform it that
the transition is not in flight. This avoids a crash when calling back
to the already-destroyed animator later.

(WebKit::ViewGestureController::beginSwipeGesture):
Keep a reference to the target WebBackForwardListItem; this avoids
it being deleted between here and the transition completion block firing.

Look up the ViewGestureController by pageID, just like we do in endSwipeGesture,
to avoid situations where the callback fires after the WKWebView/ViewGestureController
have gone away.

Hold on to our _UIViewControllerOneToOneTransitionContext, so that we can do the
aforementioned clearing upon deallocation.

(WebKit::ViewGestureController::endSwipeGesture):
Null check the DrawingArea. If it is null, instead of doing our normal delayed logic
for swipe snapshot teardown, just put things back together immediately.

(WebKit::ViewGestureController::removeSwipeSnapshot):
Clear m_swipeTransitionContext.

12:45 PM Changeset in webkit [174787] by ap@apple.com

• 4 edits in trunk/Source/WebCore

Crashes in ResourceHandleCFURLConnectionDelegateWithOperationQueue due to unimplemented retain/release
​https://bugs.webkit.org/show_bug.cgi?id=137779
rdar://problem/18679320

Reviewed by Brady Eidson.

• platform/network/cf/ResourceHandleCFURLConnectionDelegate.cpp:

(WebCore::ResourceHandleCFURLConnectionDelegate::retain):
(WebCore::ResourceHandleCFURLConnectionDelegate::release):
(WebCore::ResourceHandleCFURLConnectionDelegate::makeConnectionClient):

• platform/network/cf/ResourceHandleCFURLConnectionDelegate.h:

Implemented retain/release. They are necessary, as ResourceHandle goes away when
it's canceled, and there is noone else to keep the client object alive but
CFURLConnection itself.

• platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:

(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::willSendRequest):
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::didReceiveResponse):
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::didReceiveData):
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::didFinishLoading):
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::didFail):
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::willCacheResponse):
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::didReceiveChallenge):
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::didSendBodyData):
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::canRespondToProtectionSpace):
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::didReceiveDataArray):
Added a FIXME about potential improvements that I spotted while invsestigating this.

12:14 PM Changeset in webkit [174786] by Alan Bujtas

• 16 edits in trunk/LayoutTests

[Mac] Unreviewed gardening.

Unskip subpixel border tests.

• platform/mac/TestExpectations:
• platform/mac/css1/units/length_units-expected.txt:
• platform/mac/fast/css/bidi-override-in-anonymous-block-expected.txt:
• platform/mac/fast/repaint/repaint-during-scroll-with-zoom-expected.txt:
• platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-initial-value-001-expected.txt:
• platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-style-001-expected.txt:
• platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-style-002-expected.txt:
• platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-style-004-expected.txt:
• platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-with-three-values-001-expected.txt:
• platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-with-two-values-001-expected.txt:
• platform/mac/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-003-expected.txt:
• platform/mac/media/video-zoom-expected.txt:
• platform/mac/svg/custom/svg-fonts-in-html-expected.txt:
• platform/mac/svg/zoom/page/zoom-svg-float-border-padding-expected.txt:
• platform/mac/tables/mozilla_expected_failures/bugs/bug1055-2-expected.txt:

9:01 AM Changeset in webkit [174785] by ddkilzer@apple.com

• 2 edits in trunk/Websites/bugs.webkit.org/template/en/default

Fix JavaScript alert() about missing search terms when submitting patch review

• template/en/default/attachment/reviewform.html.tmpl: Pass

hide_content=1 argument when including global/header.html.tmpl.

• template/en/default/global/header.html.tmpl: Add hide_content argument

that hides header content when including the file.

9:01 AM Changeset in webkit [174784] by ddkilzer@apple.com

• 2 edits in trunk/Websites/bugs.webkit.org

Re-enable WebKit-based user matching

• data/params: Disable Bugzilla's own user matching, which also

requires the JSON::RPC Perl module.

• template/en/default/global/footer.html.tmpl: Include

committers-autocomplete.js everywhere. Every. Where.

9:01 AM Changeset in webkit [174783] by ddkilzer@apple.com

• 1 edit in trunk/Websites/bugs.webkit.org/code-review.js

Fix loading of legacy comments from older Bugzillas

• code-review.js:

(fetchHistory): We must support both the old-style and new-style
formats for attachment comments since the old-style format is
quoted and stored as text in the database forever.

9:01 AM Changeset in webkit [174782] by ddkilzer@apple.com

• 1 edit in trunk/Websites/bugs.webkit.org/data/params

Update proxy URL parameter used by Bugzilla

• data/params: Update proxy URL.

9:01 AM Changeset in webkit [174781] by ddkilzer@apple.com

• 1 edit in trunk/Websites/bugs.webkit.org/mod_perl.pl

Fix maximum unshared memory size of Apache processes

• mod_perl.pl: Set the maximum unshared memory size of Apache

processes to 700 MB. According to the manpage, this is the
correct way to do it in a mod_perl config file.

9:01 AM Changeset in webkit [174780] by ddkilzer@apple.com

• 1 edit in trunk/Websites/bugs.webkit.org/.htaccess

Remove unneeded rule from .htaccess

• .htaccess: Remove an old rule that doesn't match any files.

9:01 AM Changeset in webkit [174779] by ddkilzer@apple.com

• 27 edits
  4 adds in trunk/Websites/bugs.webkit.org

Upgrade to Bugzilla 4.2.11.

9:01 AM Changeset in webkit [174778] by ddkilzer@apple.com

• 14 edits
  3 copies
  1 delete in trunk/Websites/bugs.webkit.org/template/en

Move template/en/custom files onto template/en/default

9:01 AM Changeset in webkit [174777] by ddkilzer@apple.com

• 1 edit in trunk/Websites/bugs.webkit.org/template/en/custom/attachment/edit.html.tmpl

Do not hide details on attachment edit page

• template/en/custom/attachment/edit.html.tmpl: Comment out the

call to toggle_attachment_details_visibility() that initially
hides the details.

9:01 AM Changeset in webkit [174776] by ddkilzer@apple.com

• 1 edit in trunk/Websites/bugs.webkit.org/js/field.js

Re-fix Bug 26950: Make the summary and alias fields support click-to-edit <​https://bugs.webkit.org/show_bug.cgi?id=26950>

• js/field.js: Port the changes from r45538 to Bugzilla 4.2.5.

9:01 AM Changeset in webkit [174775] by ddkilzer@apple.com

• 1 edit in trunk/Websites/bugs.webkit.org/migrate.pl

migrate.pl: remove unnecessary change

9:01 AM Changeset in webkit [174774] by ddkilzer@apple.com

• 2 edits in trunk/Websites/bugs.webkit.org

Fix "View Diff" buttons on edit attachment page

• js/attachment.js:

(viewPrettyPatch): Change code syntax from Perl to JavaScript.
When I moved this method from
template/en/custom/attachment/edit.html.tmpl into
js/attachment.js during the Bugzilla 4.2.1 merge, I wrote some
of the code using Perl syntax.

• template/en/custom/attachment/edit.html.tmpl:
• Fix 120-column truncation of code. (That's what you get for copying and pasting code from 'git diff' in a terminal window.)
• Pass attachment_id into the viewPrettyPatch() method since the method expects it.

9:01 AM Changeset in webkit [174773] by ddkilzer@apple.com

• 4 edits
  2 deletes in trunk/Websites/bugs.webkit.org

Remove references to Rietveld from bugs.webkit.org

Rietveld was an experiment that was added by Google. It was
never enabled for everyone, so it's safe to remove the changes
that reference it.

• Bugzilla/Flag.pm: Remove code that prevented mail messages from

being sent for patches reviewed in Rietveld.

• attachment.cgi: Remove reference to the "rietveldreview"

template.

• template/en/custom/attachment/list.html.tmpl: Remove code

that handled the Rietveld review flag.

• template/en/custom/attachment/reviewform.html.tmpl: Remove code

that handled the "rietveldReview" CGI parameter.

• template/en/custom/attachment/rietveldreview.html.tmpl: Delete.
• template/en/custom/flag/list.html.tmpl: Delete. After

removing the code to handle Rietveld reviews, there were no more
local WebKit changes to the custom template file, so it could be
removed.

9:01 AM Changeset in webkit [174772] by ddkilzer@apple.com

• 3 edits in trunk/Websites/bugs.webkit.org

Display legal text when uploading a patch with a new bug

• js/attachment.js:

(setContentTypeDisabledState): Make this work on the Enter Bug
page so that the "Submit Bug" button changes to
"Agree and Submit Bug" when the "patch" checkbox is checked, and
it changes back to "Submit Bug" when unchecked.

• template/en/custom/attachment/createformcontents.html.tmpl:

Include the attachment/patchlegalese.html.tmpl template when
returning the page so that it will be shown when the "patch"
checkbox is checked. Set the 'product' variable from the CGI
variable of the same name.

• template/en/custom/attachment/patchlegalese.html.tmpl: Add the

'expert_fields' class to the <tr> element so that it gets
shown/hidden when the Show/Hide Advanced Fields links are
clicked.

9:01 AM Changeset in webkit [174771] by ddkilzer@apple.com

• 2 edits in trunk/Websites/bugs.webkit.org

Get rid of large blank area when adding non-patch attachment

• js/attachment.js:
• template/en/custom/attachment/patchlegalese.html.tmpl:
• Use 'display: none;' and 'display: table-row;' instead of 'visibility: collapse;' and 'visibility: visible;' to hide and show the text.

9:01 AM Changeset in webkit [174770] by ddkilzer@apple.com

• 1 edit
  1 add in trunk/Websites/bugs.webkit.org/template/en/custom/attachment

Move patch legalese into its own template file for reuse

• template/en/custom/attachment/create.html.tmpl:
• template/en/custom/attachment/patchlegalese.html.tmpl:
• Extract patch legalese into its own file.

9:01 AM Changeset in webkit [174769] by ddkilzer@apple.com

• 2 edits in trunk/Websites/bugs.webkit.org

Fix review form after Bugzilla 4.2.5 update

• code-review.js:

(fetchHistory):

• Trim author since new format adds a space before the name.
• Update comment_marker to match the text now used by Bugzilla.

• template/en/custom/attachment/reviewform.html.tmpl:
• Add global/header.html.tmpl to make sure we get the standard HTML for including CSS, JavaScript, etc.
  • Remove redundant <link> tags.
  • Add CSS in local <style> to hide the header.
  • Change local <script> to be passed as an argument into global/header.html.tmpl when it is processed.
  • NOTE: local <style> tag should be passed as an argument into global/header.html.tmpl, but that breaks page layout, so it was skipped for now.
• Fix fallout form moving flag_types into the attachment object when processing flag/list.html.tmpl.

9:01 AM Changeset in webkit [174768] by ddkilzer@apple.com

• 1 edit in trunk/Websites/bugs.webkit.org/template/en/custom/global/header.html.tmpl

Add back "WebKit Bugzilla" text in page header

9:01 AM Changeset in webkit [174767] by ddkilzer@apple.com

• 3 adds in trunk/Websites/bugs.webkit.org

Add .htaccess files created by checksetup.pl

9:01 AM Changeset in webkit [174766] by ddkilzer@apple.com

• 1 edit in trunk/Websites/bugs.webkit.org/data/params

data/params: update after running checksetup.pl

9:01 AM Changeset in webkit [174765] by ddkilzer@apple.com

• 101 edits
  1 add in trunk/Websites/bugs.webkit.org

Upgrade to Bugzilla 4.2.7.

Conflicts:

buglist.cgi
report.cgi

9:00 AM Changeset in webkit [174764] by ddkilzer@apple.com

• 408 edits
  41 copies
  5 moves
  371 adds
  77 deletes in trunk/Websites/bugs.webkit.org

Upgrade bugs.webkit.org to Bugzilla 4.2
<​http://webkit.org/b/55882>

Upgrade to Bugzilla 4.2.1.

Conflicts:

.htaccess
Bugzilla.pm
Bugzilla/Auth.pm
Bugzilla/Auth/Login/CGI.pm
Bugzilla/Auth/Persist/Cookie.pm
Bugzilla/Bug.pm
Bugzilla/BugMail.pm
Bugzilla/CGI.pm
Bugzilla/Config/Attachment.pm
Bugzilla/Config/Common.pm
Bugzilla/Config/General.pm
Bugzilla/Constants.pm
Bugzilla/DB/Mysql.pm
Bugzilla/DB/Oracle.pm
Bugzilla/DB/Schema.pm
Bugzilla/DB/Schema/Oracle.pm
Bugzilla/Error.pm
Bugzilla/Flag.pm
Bugzilla/FlagType.pm
Bugzilla/Hook.pm
Bugzilla/Install/DB.pm
Bugzilla/Install/Filesystem.pm
Bugzilla/Install/Localconfig.pm
Bugzilla/Install/Requirements.pm
Bugzilla/Install/Util.pm
Bugzilla/Mailer.pm
Bugzilla/Product.pm
Bugzilla/Search.pm
Bugzilla/Search/Quicksearch.pm
Bugzilla/Search/Saved.pm
Bugzilla/Series.pm
Bugzilla/Template.pm
Bugzilla/Template/Plugin/Hook.pm
Bugzilla/Token.pm
Bugzilla/User.pm
Bugzilla/Util.pm
Bugzilla/WebService.pm
Bugzilla/WebService/Bug.pm
Bugzilla/WebService/Bugzilla.pm
Bugzilla/WebService/Constants.pm
Bugzilla/WebService/Product.pm
Bugzilla/WebService/User.pm
attachment.cgi
buglist.cgi
checksetup.pl
colchange.cgi
collectstats.pl
contrib/bugzilla_ldapsync.rb
contrib/bzdbcopy.pl
contrib/gnats2bz.pl
contrib/recode.pl
contrib/sendbugmail.pl
contrib/yp_nomail.sh
docs/en/xml/Bugzilla-Guide.xml
docs/en/xml/about.xml
docs/en/xml/installation.xml
docs/en/xml/security.xml
docs/en/xml/troubleshooting.xml
editflagtypes.cgi
editparams.cgi
editproducts.cgi
editvalues.cgi
editwhines.cgi
email_in.pl
enter_bug.cgi
extensions/BmpConvert/Config.pm
extensions/OldBugMove/template/en/default/admin/params/oldbugmove.html.tmpl
extensions/Voting/template/en/default/hook/bug/process/header-title.html.tmpl
extensions/Voting/template/en/default/hook/search/search-report-select-rep_fields.html.tmpl
extensions/example/code/webservice-error_codes.pl
extensions/example/version.pl
images/favicon.ico
importxml.pl
index.cgi
install-module.pl
js/field.js
js/util.js
long_list.cgi
mod_perl.pl
post_bug.cgi
process_bug.cgi
quips.cgi
sanitycheck.cgi
show_bug.cgi
showattachment.cgi
sidebar.cgi
skins/contrib/Dusk/global.css
skins/contrib/Dusk/index.css
skins/standard/global.css
skins/standard/show_bug.css
t/008filter.t
template/en/custom/attachment/review.html.tmpl
template/en/default/account/prefs/saved-searches.html.tmpl
template/en/default/admin/classifications/delete.html.tmpl
template/en/default/admin/classifications/edit-common.html.tmpl
template/en/default/admin/classifications/footer.html.tmpl
template/en/default/admin/components/create.html.tmpl
template/en/default/admin/components/edit.html.tmpl
template/en/default/admin/params/attachment.html.tmpl
template/en/default/admin/sanitycheck/messages.html.tmpl
template/en/default/admin/users/confirm-delete.html.tmpl
template/en/default/admin/workflow/edit.html.tmpl
template/en/default/attachment/created.html.tmpl
template/en/default/attachment/diff-header.html.tmpl
template/en/default/attachment/edit.html.tmpl
template/en/default/attachment/list.html.tmpl
template/en/default/attachment/updated.html.tmpl
template/en/default/bug/comments.html.tmpl
template/en/default/bug/create/create-guided.html.tmpl
template/en/default/bug/create/create.html.tmpl
template/en/default/bug/create/created.html.tmpl
template/en/default/bug/edit.html.tmpl
template/en/default/bug/field.html.tmpl
template/en/default/bug/process/header.html.tmpl
template/en/default/bug/show.html.tmpl
template/en/default/bug/show.xml.tmpl
template/en/default/config.rdf.tmpl
template/en/default/email/whine.txt.tmpl
template/en/default/filterexceptions.pl
template/en/default/flag/list.html.tmpl
template/en/default/global/common-links.html.tmpl
template/en/default/global/confirm-action.html.tmpl
template/en/default/global/field-descs.none.tmpl
template/en/default/global/footer.html.tmpl
template/en/default/global/header.html.tmpl
template/en/default/global/user-error.html.tmpl
template/en/default/global/userselect.html.tmpl
template/en/default/list/edit-multiple.html.tmpl
template/en/default/list/list.html.tmpl
template/en/default/pages/fields.html.tmpl
template/en/default/pages/release-notes.html.tmpl
template/en/default/search/boolean-charts.html.tmpl
template/en/default/search/form.html.tmpl
template/en/default/search/search-report-graph.html.tmpl
template/en/default/search/search-report-table.html.tmpl
template/en/default/setup/strings.txt.pl
token.cgi
userprefs.cgi
xml.cgi
xmlrpc.cgi

8:26 AM Changeset in webkit [174763] by Antti Koivisto

• 3 edits in trunk/Source/WebKit2

REGRESSION (r173356): Downloading a disk image appends ".txt" to it
​https://bugs.webkit.org/show_bug.cgi?id=137493
<rdar://problem/18321947>

Reviewed by Alexey Proskuryakov.

• Shared/Downloads/ios/DownloadIOS.mm:

(WebKit::Download::startWithHandle):

• Shared/Downloads/mac/DownloadMac.mm:

(WebKit::Download::startWithHandle):

It appears that the synthesized NS/CFURLResponse fails to serialize the suggested filename correctly
unless it has been accessed first.

6:29 AM Changeset in webkit [174762] by commit-queue@webkit.org

• 2 edits in trunk/Source/JavaScriptCore

Use isnan from std namespace in ProfileGenerator.cpp
​https://bugs.webkit.org/show_bug.cgi?id=137653

Patch by Adrien Destugues <​pulkomandy@gmail.com> on 2014-10-16
Reviewed by Darin Adler.

The C++ isnan() function is in the std namespace. The unprefixed isnan
may be available because of C99 headers leakage in C++, but should not
be used.

No new tests: no functional change, build fix on platforms which don't
export C99 functions in C++.

• profiler/ProfileGenerator.cpp:

(JSC::ProfileGenerator::beginCallEntry):
(JSC::ProfileGenerator::endCallEntry):
(JSC::ProfileGenerator::didPause):
(JSC::ProfileGenerator::didContinue):