Context Navigation

After :link and :-webkit-any-link were fixed, :any-link behaves
exactly like :-webkit-any-link. All I had left to do here was
make them synonyms when evaluating selectors.

Defined here: http://dev.w3.org/csswg/selectors4/#the-any-link-pseudo

After :link and :-webkit-any-link were fixed, :any-link behaves
exactly like :-webkit-any-link. All I had left to do here was
make them synonyms when evaluating selectors.

Tests: fast/selectors/any-link-basics-2.html

fast/selectors/any-link-basics.html
fast/selectors/any-link-styling.html

css/CSSSelector.cpp:

(WebCore::CSSSelector::selectorText):

css/CSSSelector.h:
css/RuleSet.cpp:

(WebCore::RuleSet::addRule):

css/SelectorChecker.cpp:

(WebCore::SelectorChecker::checkOne):

css/SelectorChecker.h:

(WebCore::SelectorChecker::isCommonPseudoClassSelector):

css/SelectorPseudoClassAndCompatibilityElementMap.in:
cssjit/SelectorCompiler.cpp:

(WebCore::SelectorCompiler::addPseudoClassType):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementLinkMatching):

LayoutTests:

Story time: I implement only half of the patch and run
fast/selectors/webkit-any-link.html to make sure it fails...
and the test happily PASS.

I look into it and sure enough, a last minute change in
html-link-type-tests.js made it test nothing but :link.

I update html-link-type-tests.js to actually test the desired selector,
run the test again: PASS.

I debug a bit and I find why my code is not tested: html-link-type-tests.js
uses Element.matches() and that does not use the CSS JIT.

Fair enough, I add a querySelectorAll("#target' + selector + '") to run
through the JIT: PASS.

Since that selector is simple-#id + simple selector, we go through a fast
path for ids and skip the JIT. Arrrrg!

Finally, I added querySelectorAll(".target' + selector + '"), which covers
the CSS JIT.

The nice thing is: all those cases are tested now :)

fast/css/css-selector-text-expected.txt:
fast/css/css-selector-text.html:
fast/css/css-set-selector-text-expected.txt:
fast/css/css-set-selector-text.html:
fast/selectors/any-link-basics-2-expected.txt: Added.
fast/selectors/any-link-basics-2.html: Added.
fast/selectors/any-link-basics-expected.txt: Added.
fast/selectors/any-link-basics.html: Added.
fast/selectors/any-link-styling-expected.html: Added.
fast/selectors/any-link-styling.html: Added.
fast/selectors/images-with-usemap-should-not-match-link-expected.txt:
fast/selectors/images-with-usemap-should-not-match-link.html:
fast/selectors/link-basics-expected.txt:
fast/selectors/link-basics-xhtml-expected.txt:
fast/selectors/resources/html-link-type-tests.js:

(testHTMLElement):
(testHTMLTagsForLink):

fast/selectors/webkit-any-link-basics-expected.txt:

9:11 PM Changeset in webkit [175300] by dburkart@apple.com

7 edits in branches/safari-600.3-branch

Merge r174525. <rdar://problem/18640876>

9:04 PM Changeset in webkit [175299] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit2

Cast std::chrono::duration.count() to int64_t in ArgumentCoder
https://bugs.webkit.org/show_bug.cgi?id=136981

Patch by Ting-Wei Lan <Ting-Wei Lan> on 2014-10-28
Reviewed by Alexey Proskuryakov.

Explicitly cast the return value of std::chrono::duration.count() to
a fixed-size interger type, which prevents compilation error when
the return value type matches neither int32_t nor int64_t.

Platform/IPC/ArgumentCoders.h:

8:39 PM Changeset in webkit [175298] by dburkart@apple.com

2 deletes in branches/safari-600.3-branch/Source/WebKit2/WebProcess/WebPage

Forgot to delete a couple files from merging r174524 (rdar://problem/18640868)

8:34 PM Changeset in webkit [175297] by dburkart@apple.com

21 edits
2 copies in branches/safari-600.3-branch/Source

Merge r174524. <rdar://problem/18640868>

7:26 PM Changeset in webkit [175296] by dburkart@apple.com

54 edits
6 copies
4 deletes in branches/safari-600.3-branch/Source

Merged r174231. rdar://problem/18640833

6:28 PM Changeset in webkit [175295] by dbates@webkit.org

2 edits in trunk/Tools

Unify logic in RunTests.run() to run the Python unit tests
https://bugs.webkit.org/show_bug.cgi?id=138160

Reviewed by Martin Robinson.

Unify the interactive and non-interactive code path for running the Python unit tests
in step RunTests so as to remove duplicate code to compute the the path to the script
test-webkitpy and log an informative message ("Running Python unit tests") to the console.

No new tests since no functionality was changed.

Scripts/webkitpy/port/base.py:

(Port.python_unittest_results_directory):

Scripts/webkitpy/tool/steps/runtests.py:

(RunTests.run):

5:58 PM Changeset in webkit [175294] by commit-queue@webkit.org

3 edits in trunk/Tools

Make runtest.py call test-webkitpy with the --json flag when in
non-interactive mode.
https://bugs.webkit.org/show_bug.cgi?id=137667

Patch by Jake Nielsen <jacob_nielsen@apple.com> on 2014-10-28
Reviewed by Daniel Bates.

Scripts/webkitpy/port/base.py:

Adds the python_unittest_results_directory method.
(Port.python_unittest_results_directory):

Scripts/webkitpy/tool/steps/runtests.py:

Changes RunTests to call test-webkitpy with the --json flag if the
--non-interactive flag is set.
(RunTests):
(RunTests.run):

5:53 PM Changeset in webkit [175293] by dburkart@apple.com

2 edits in branches/safari-600.3-branch/Source/WebCore

Merge r174541. <rdar://problem/18753175>

5:32 PM Changeset in webkit [175292] by dburkart@apple.com

4 edits in branches/safari-600.3-branch/Source/WebCore

Merge r174516. <rdar://problem/18640864>

5:29 PM Changeset in webkit [175291] by dburkart@apple.com

2 edits in branches/safari-600.3-branch/Source/WebCore

Merge r174457. <rdar://problem/18640864>

5:27 PM Changeset in webkit [175290] by dburkart@apple.com

4 edits in branches/safari-600.3-branch/Source/WebCore

Merge r174456. <rdar://problem/18640864>

5:22 PM Changeset in webkit [175289] by dburkart@apple.com

13 edits in branches/safari-600.3-branch/Source/WebKit2

Merge r174369. <rdar://problem/18640842>

5:18 PM Changeset in webkit [175288] by jer.noble@apple.com

22 edits
2 adds in trunk/Source/WebKit2

[EME] Pass location for media key storage through from WebKit/WebKit2.
https://bugs.webkit.org/show_bug.cgi?id=137120

Reviewed by Anders Carlsson.

Allow the location for media key storage to be passed into the WebProcess from the UIProcess
through the WebContextConfiguraiton struct.

Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::encode): Add mediaKeysStorageDirectory.
(WebKit::WebProcessCreationParameters::decode): Ditto.

Shared/WebProcessCreationParameters.h:
UIProcess/API/C/WKContextConfigurationRef.cpp:

(WKContextConfigurationCopyMediaKeysStorageDirectory): Added getter.
(WKContextConfigurationSetMediaKeysStorageDirectory): Added setter.

UIProcess/API/C/WKContextConfigurationRef.h:
UIProcess/API/C/WKOriginDataManager.h:
UIProcess/API/Cocoa/WKProcessPool.mm:

(-[WKProcessPool _initWithConfiguration:]): Provide a default location.

UIProcess/APIContextConfiguration.cpp:

(API::ContextConfiguration::webContextConfiguration): Set mediaKeysStorageDirectory.

UIProcess/APIContextConfiguration.h:

(API::ContextConfiguration::mediaKeysStorageDirectory): Added getter.
(API::ContextConfiguration::setMediaKeysStorageDirectory): Added setter.

UIProcess/WebContext.cpp:

(WebKit::WebContext::applyPlatformSpecificConfigurationDefaults): Apply mediaKeysStorageDirectory.
(WebKit::WebContext::WebContext): Initialize m_mediaKeysStorageDirectory.
(WebKit::WebContext::createNewWebProcess): Create a sandbox extension handle for mediaKeysStorageDirectory.

UIProcess/WebContext.h:
UIProcess/efl/WebContextEfl.cpp:

(WebKit::WebContext::platformDefaultMediaKeysStorageDirectory): Return a default location.

UIProcess/gtk/WebContextGtk.cpp:

(WebKit::WebContext::platformDefaultMediaKeysStorageDirectory): Ditto.

UIProcess/mac/WebContextMac.mm:

(WebKit::WebContext::platformDefaultMediaKeysStorageDirectory): Return an overridable default location.

WebProcess/MediaCache/WebMediaKeyStorageManager.cpp: Added.

(WebKit::WebMediaKeyStorageManager::initialize): Pull the mediaKeysStorageDirectory out of configuration.
(WebKit::WebMediaKeyStorageManager::supplementName): Return a configuration name.
(WebKit::WebMediaKeyStorageManager::mediaKeyStorageDirectoryForOrigin): Return the

correct storage directory based on the SecureOrigin.

(WebKit::WebMediaKeyStorageManager::getMediaKeyOrigins): Return the origins within the

storage directory.

(WebKit::removeAllMediaKeyStorageForOriginPath): Static, remove contents and directory at path.
(WebKit::WebMediaKeyStorageManager::deleteMediaKeyEntriesForOrigin): Use

removeAllMediaKeyStorageForOriginPath to remove origin data.

(WebKit::WebMediaKeyStorageManager::deleteMediaKeyEntriesModifiedBetweenDates): Ditto.
(WebKit::WebMediaKeyStorageManager::deleteAllMediaKeyEntries): Ditto.

WebProcess/MediaCache/WebMediaKeyStorageManager.h: Added.

(WebKit::WebMediaKeyStorageManager::WebMediaKeyStorageManager): Default constructor.
(WebKit::WebMediaKeyStorageManager::~WebMediaKeyStorageManager): Default virtual destructor.
(WebKit::WebMediaKeyStorageManager::mediaKeyStorageDirectory): Simple accessor.

WebProcess/WebProcess.cpp:

(WebKit::WebProcess::WebProcess): Add WebMediaKeyStorageManager as a supplement.

WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::WebProcess::platformInitializeWebProcess): Create a sandbox extension from the sandbox extension handle.

Add new source files to project(s).

PlatformEfl.cmake:
PlatformGTK.cmake:
WebKit2.xcodeproj/project.pbxproj:
WebProcess/MediaCache/WebMediaKeyStorageManager.cpp:

(WebKit::WebMediaKeyStorageManager::getMediaKeyOrigins):
(WebKit::removeAllMediaKeyStorageForOriginPath):

Drive-by fix: references to VoidCallback are ambiguous, since the same name is re-used in multiple namespaces.
Make references to WebCore::VoidCallback explicit where the entire WebCore (and other) namespaces are pulled in.

WebProcess/Notifications/NotificationPermissionRequestManager.cpp:

(WebKit::NotificationPermissionRequestManager::startRequest):
(WebKit::NotificationPermissionRequestManager::didReceiveNotificationPermissionDecision):

WebProcess/WebCoreSupport/WebNotificationClient.cpp:

(WebKit::WebNotificationClient::requestPermission):

5:13 PM Changeset in webkit [175287] by dburkart@apple.com

2 edits in branches/safari-600.3-branch/Source/WebKit

Merge r174368. <rdar://problem/18753175>

4:54 PM Changeset in webkit [175286] by dburkart@apple.com

2 edits in branches/safari-600.3-branch/Source/WebKit

Merge r174321. <rdar://problem/18753175>

4:51 PM Changeset in webkit [175285] by dburkart@apple.com

2 edits in branches/safari-600.3-branch/Source/WebKit

Merge r174320. <rdar://problem/18753175>

4:51 PM Changeset in webkit [175284] by jer.noble@apple.com

4 edits in trunk/Source/WebCore

[EME][Mac] Adopt new AVStreamSession API: pass storageDirectoryAtURL at creation-time
https://bugs.webkit.org/show_bug.cgi?id=138149

Reviewed by Brent Fulgham.

AVStreamSession now requires its storage location at creation-time, rather than post-creation. This requires
us to move storage location code from CDMSessionMediaSourceAVFObjC to MediaPlayerPrivateMediaSourceAVFObjC.

platform/graphics/avfoundation/objc/CDMSessionMediaSourceAVFObjC.mm:

(-[WebAVStreamDataParserListener streamDataParserWillProvideContentKeyRequestInitializationData:forTrackID:]): Renamed.
(WebCore::CDMSessionMediaSourceAVFObjC::update):
(WebCore::sessionStorageDirectory): Deleted.

platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:

(WebCore::sessionStorageDirectory):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::streamSession):

4:50 PM Changeset in webkit [175283] by ggaren@apple.com

2 edits in trunk/Source/WebCore

All networking crashes on Mac 32bit
https://bugs.webkit.org/show_bug.cgi?id=138157

Reviewed by Andy Estes.

NEFilterSource content filtering is not available on 32bit, so
soft-linking fails at runtime. The simplest solution is just to disable
it at compile time.

platform/ContentFilter.h:

4:49 PM Changeset in webkit [175282] by bshafiei@apple.com

5 edits in branches/safari-600.1.4.12-branch/Source

Versioning.

4:38 PM Changeset in webkit [175281] by dburkart@apple.com

2 edits in branches/safari-600.3-branch/Source/WebKit2

Merge r174257. <rdar://problem/18753175>

4:28 PM Changeset in webkit [175280] by bshafiei@apple.com

1 copy in tags/Safari-600.1.4.12.3

New tag.

4:14 PM Changeset in webkit [175279] by commit-queue@webkit.org

26 edits in trunk/Source

Add optimized fullscreen mode.
https://bugs.webkit.org/show_bug.cgi?id=138044

Patch by Jeremy Jones <jeremyj@apple.com> on 2014-10-28
Source/WebCore:

Reviewed by Jer Noble.

Enable different types of fullscreen video behavior.
Add an enum parameter to enterVideoFullscreenForVideoElement for alternate types of fullscreen.
Add gesture for alternate fullscreen.

Modules/mediacontrols/MediaControlsHost.cpp:

(WebCore::MediaControlsHost::enterFullscreenOptimized): added

Modules/mediacontrols/MediaControlsHost.h: added enterFullscreenOptimized
Modules/mediacontrols/MediaControlsHost.idl: added enterFullscreenOptimized
Modules/mediacontrols/mediaControlsiOS.js:

(ControllerIOS.prototype.handleBaseGestureChange): recognize alternate gesture

WebCore.exp.in: added parameter to setupFullscreen
html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::removedFrom) : replace m_isInVideoFullscreen with m_videoFullscreenType
(WebCore::HTMLMediaElement::stop) : ditto
(WebCore::HTMLMediaElement::isFullscreen) : ditto
(WebCore::HTMLMediaElement::enterFullscreen): add parameter to enterVideoFullscreenForVideoElement
(WebCore::HTMLMediaElement::exitFullscreen): replace m_isInVideoFullscreen with m_videoFullscreenType
(WebCore::HTMLMediaElement::enterFullscreenOptimized): added

html/HTMLMediaElement.h: added enterFullscreenOptimized
page/ChromeClient.h:

(WebCore::ChromeClient::enterVideoFullscreenForVideoElement): added parameter

platform/ios/WebVideoFullscreenControllerAVKit.h: add parameter
platform/ios/WebVideoFullscreenControllerAVKit.mm:

(-[WebVideoFullscreenController enterFullscreen:type:]): add parameter
(-[WebVideoFullscreenController enterFullscreen:]): Deleted.

platform/ios/WebVideoFullscreenInterfaceAVKit.h: reorder protected to after public
platform/ios/WebVideoFullscreenInterfaceAVKit.mm:

(-[WebAVPlayerController player]): this stub is now required
(-[WebAVPlayerController layoutSublayersOfLayer:]): this is a better way to update video frames
(WebVideoFullscreenInterfaceAVKit::setupFullscreen): implement optimized fullscreen interface
(WebVideoFullscreenInterfaceAVKit::enterFullscreen): ditto
(WebVideoFullscreenInterfaceAVKit::exitFullscreen): ditto
(WebVideoFullscreenInterfaceAVKit::requestHideAndExitFullscreen): ditto

Source/WebKit/mac:

Reviewed by Jer Noble.

Enable different types of fullscreen video behavior.
Add an enum parameter to enterVideoFullscreenForVideoElement for alternate types of fullscreen.

WebCoreSupport/WebChromeClient.h: Add fullscreenType parameter
WebCoreSupport/WebChromeClient.mm:

(WebChromeClient::enterVideoFullscreenForVideoElement): ditto

WebView/WebView.mm:

(-[WebView _enterVideoFullscreenForVideoElement:type:]): ditto
(-[WebView _enterVideoFullscreenForVideoElement:]): Deleted.

WebView/WebViewInternal.h: ditto

Source/WebKit2:

Reviewed by Anders Carlsson.

Enable different types of fullscreen video behavior.
Add an enum parameter to enterVideoFullscreenForVideoElement for alternate types of fullscreen.

UIProcess/ios/WebVideoFullscreenManagerProxy.h: Add fullscreenType parameter
UIProcess/ios/WebVideoFullscreenManagerProxy.messages.in: ditto
UIProcess/ios/WebVideoFullscreenManagerProxy.mm:

(WebKit::WebVideoFullscreenManagerProxy::setupFullscreenWithID): ditto

WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::enterVideoFullscreenForVideoElement): ditto

WebProcess/WebCoreSupport/WebChromeClient.h: ditto
WebProcess/ios/WebVideoFullscreenManager.h: ditto
WebProcess/ios/WebVideoFullscreenManager.mm:

(WebKit::WebVideoFullscreenManager::enterVideoFullscreenForVideoElement): ditto
(WebKit::WebVideoFullscreenManager::didCleanupFullscreen): ditto

3:42 PM Changeset in webkit [175278] by Chris Dumez

27 edits in trunk/Source/WebCore

Clean up virtual functions in accessibility/
https://bugs.webkit.org/show_bug.cgi?id=138148

Reviewed by Chris Fleizach.

Clean up virtual functions in accessibility/ by:

Marking classes as final when suitable
Marking virtual functions as final when suitable
Dropping final on virtual functions in classes that are already final
Make isXXX() virtual type checking functions in XXX classes to avoid useless type checks

No new tests, no behavior change.

accessibility/AccessibilityARIAGrid.h:
accessibility/AccessibilityARIAGridCell.h:
accessibility/AccessibilityARIAGridRow.h:
accessibility/AccessibilityImageMapLink.h:
accessibility/AccessibilityList.h:
accessibility/AccessibilityListBox.h:
accessibility/AccessibilityListBoxOption.h:
accessibility/AccessibilityMediaControls.h:
accessibility/AccessibilityMenuList.h:
accessibility/AccessibilityMenuListOption.h:
accessibility/AccessibilityMenuListPopup.h:
accessibility/AccessibilityMockObject.h:

(WebCore::AccessibilityMockObject::setParent):

accessibility/AccessibilityNodeObject.h:
accessibility/AccessibilityProgressIndicator.h:
accessibility/AccessibilityRenderObject.h:
accessibility/AccessibilitySVGRoot.h:
accessibility/AccessibilityScrollView.h:
accessibility/AccessibilityScrollbar.h:
accessibility/AccessibilitySearchFieldButtons.h:
accessibility/AccessibilitySlider.h:
accessibility/AccessibilitySpinButton.h:
accessibility/AccessibilityTable.h:
accessibility/AccessibilityTableCell.h:
accessibility/AccessibilityTableColumn.h:
accessibility/AccessibilityTableHeaderContainer.h:
accessibility/AccessibilityTableRow.h:

3:38 PM Changeset in webkit [175277] by jpfau@apple.com

2 edits in trunk/Source/WebCore

FrameProgressTracker expects Page to not have detached
https://bugs.webkit.org/show_bug.cgi?id=138061

Reviewed by Alexey Proskuryakov.

In some cases, a Page may be detached from a Frame before its
FrameLoader is torn down, causing FrameProgressTracker's destructor
to hit a null pointer.

No new tests; it is impossible to reliably simulate the null pointer
case without intrusive code changes.

loader/FrameLoader.cpp:

(WebCore::FrameLoader::FrameProgressTracker::~FrameProgressTracker):

3:36 PM Changeset in webkit [175276] by dburkart@apple.com

8 edits
2 copies in branches/safari-600.3-branch

Merge r174190. <rdar://problem/18640846>

3:15 PM Changeset in webkit [175275] by mitz@apple.com

2 edits in trunk/Source/WebKit2

Added a Radar reference to a comment.

Shared/mac/WebCoreArgumentCodersMac.mm:

(IPC::ArgumentCoder<Credential>::encodePlatformData):

3:14 PM Changeset in webkit [175274] by dburkart@apple.com

3 edits
4 copies in branches/safari-600.3-branch

Merge r173184. <rdar://problem/18428699>

3:00 PM Changeset in webkit [175273] by adachan@apple.com

8 edits
1 add in trunk/Source/WebCore

Introduce a new abstract class called AudioProducer and keep a set of AudioProducers
rather than the active MediaSessions in Document
https://bugs.webkit.org/show_bug.cgi?id=138107

Reviewed by Eric Carlson.

No new tests, no behavior change.

WebCore.xcodeproj/project.pbxproj:

Add AudioProducer.h to the project.

dom/Document.cpp:

(WebCore::Document::addAudioProducer):
(WebCore::Document::removeAudioProducer):
(WebCore::Document::updateIsPlayingAudio):
Go through the set of AudioProducers and see if any is playing audio.
Now that this method no longer refers to MediaSessions directly, this code
does not need to be guarded by #if ENABLE(VIDEO).
(WebCore::Document::registerMediaSession): Deleted.
(WebCore::Document::unregisterMediaSession): Deleted.

dom/Document.h:
html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::registerWithDocument):
(WebCore::HTMLMediaElement::unregisterWithDocument):
(WebCore::HTMLMediaElement::isPlayingAudio):
Return whether this element is playing audio.

html/HTMLMediaElement.h:
page/AudioProducer.h: Added.

(WebCore::AudioProducer::~AudioProducer):

page/Page.cpp:

(WebCore::Page::updateIsPlayingAudio):
This is no longer guarded with #if ENABLE(VIDEO) since the Document methods it calls
are no longer guarded.

page/Page.h:

2:42 PM Changeset in webkit [175272] by dburkart@apple.com

4 edits
2 copies in branches/safari-600.3-branch

Merge r173181. rdar://problem/18428697

1:12 PM Changeset in webkit [175271] by ap@apple.com

2 edits in trunk/LayoutTests

fast/multicol/multicol-crazy-nesting.html sometimes crashes
https://bugs.webkit.org/show_bug.cgi?id=138145

TestExpectations: Skipping for now.

1:01 PM Changeset in webkit [175270] by mitz@apple.com

2 edits in trunk/Source/WebKit2

[Cocoa] REGERESSION (r171801): Client certificate authentication is failing
https://bugs.webkit.org/show_bug.cgi?id=138144

Reviewed by Alexey Proskuryakov.

NSURLCredential’s implementation of NSSecureCoding fails to encode identity-based
credentials properly. Work around that by encoding the identity, certificate, and
persistence individually.

Shared/mac/WebCoreArgumentCodersMac.mm:

(IPC::ArgumentCoder<Credential>::encodePlatformData):
(IPC::ArgumentCoder<Credential>::decodePlatformData):

12:57 PM Changeset in webkit [175269] by Chris Dumez

2 edits in trunk/Source/WebCore

Unreviewed comment fix from r175267.

Fix namespace name in comment.

css/StyleBuilderCustom.h:

12:37 PM Changeset in webkit [175268] by jer.noble@apple.com

39 edits
2 copies in trunk

REGRESSION(r171593) [Mac] Media controls create a large (and unnecessary) backing store
https://bugs.webkit.org/show_bug.cgi?id=137757

Reviewed by Eric Carlson.

Source/WebCore:

In r171593, a <div> was added to the media controls which is only ever used on iOS. Instead
of creating and adding this <div> in mediaControlsApple.js (which is used on OS X), this
<div> should be created and added in mediaControlsiOS.js, which requires overloading
Controller.addControls.

Modules/mediacontrols/mediaControlsApple.css:

(audio::-webkit-media-controls-panel.hidden): Drive-by fix: allow the panel itself to be hidden.
(video::-webkit-media-controls-panel-composited-parent): Deleted.

Modules/mediacontrols/mediaControlsApple.js:

(Controller.prototype.createControls): Remove the composited parent.
(Controller.prototype.addControls): Ditto.

Modules/mediacontrols/mediaControlsiOS.js:

(ControllerIOS.prototype.createControls): Create the composited parent.
(ControllerIOS.prototype.addControls): Copied from (previous) apple.js.

LayoutTests:

platform/mac-mavericks/media/audio-controls-rendering-expected.png:
platform/mac-mavericks/media/audio-controls-rendering-expected.txt:
platform/mac-mavericks/media/controls-strict-expected.txt:
platform/mac-mavericks/media/controls-without-preload-expected.txt: Copied from LayoutTests/platform/mac/media/controls-without-preload-expected.txt.
platform/mac-mavericks/media/video-controls-rendering-expected.txt:
platform/mac-mavericks/media/video-display-toggle-expected.txt:
platform/mac-mavericks/media/video-empty-source-expected.txt: Copied from LayoutTests/platform/mac/media/video-empty-source-expected.txt.
platform/mac-mavericks/media/video-no-audio-expected.png:
platform/mac-mavericks/media/video-no-audio-expected.txt:
platform/mac-mavericks/media/video-volume-slider-expected.txt:
platform/mac-mavericks/media/video-zoom-controls-expected.png:
platform/mac-mavericks/media/video-zoom-controls-expected.txt:
platform/mac/fast/hidpi/video-controls-in-hidpi-expected.txt:
platform/mac/fast/layers/video-layer-expected.txt:
platform/mac/media/audio-controls-rendering-expected.png:
platform/mac/media/audio-controls-rendering-expected.txt:
platform/mac/media/controls-after-reload-expected.png:
platform/mac/media/controls-after-reload-expected.txt:
platform/mac/media/controls-strict-expected.png:
platform/mac/media/controls-strict-expected.txt:
platform/mac/media/controls-without-preload-expected.png:
platform/mac/media/controls-without-preload-expected.txt:
platform/mac/media/media-controls-clone-expected.png:
platform/mac/media/media-controls-clone-expected.txt:
platform/mac/media/video-controls-rendering-expected.png:
platform/mac/media/video-controls-rendering-expected.txt:
platform/mac/media/video-display-toggle-expected.png:
platform/mac/media/video-display-toggle-expected.txt:
platform/mac/media/video-empty-source-expected.png:
platform/mac/media/video-empty-source-expected.txt:
platform/mac/media/video-no-audio-expected.png:
platform/mac/media/video-no-audio-expected.txt:
platform/mac/media/video-volume-slider-expected.png:
platform/mac/media/video-volume-slider-expected.txt:
platform/mac/media/video-zoom-controls-expected.png:
platform/mac/media/video-zoom-controls-expected.txt:

12:12 PM Changeset in webkit [175267] by Chris Dumez

6 edits
1 add in trunk/Source/WebCore

Move "Number" CSS properties to the new StyleBuilder
https://bugs.webkit.org/show_bug.cgi?id=138125

Reviewed by Antti Koivisto.

Move "Number" CSS properties from DeprecatedStyleBuilder to the new
StyleBuilder:
-webkit-hyphenate-limit-after
-webkit-hyphenate-limit-before
-webkit-shape-image-threshold
-webkit-hyphenate-limit-lines

They are now generated from CSSPropertyNames.in

For -webkit-hyphenate-limit-lines, I used custom code instead of
the Number converter as it required special handling for the id
value. This patch thus adds support for [Custom=Value] to
CSSPropertyNames.in and the custom code goes into
css/StyleBuilderCustom.h.

No new tests, no behavior change.

WebCore.xcodeproj/project.pbxproj:
css/CSSPropertyNames.in:
css/DeprecatedStyleBuilder.cpp:

(WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder):
(WebCore::ApplyPropertyNumber::setValue): Deleted.
(WebCore::ApplyPropertyNumber::applyValue): Deleted.
(WebCore::ApplyPropertyNumber::createHandler): Deleted.

css/StyleBuilderConverter.h:

(WebCore::StyleBuilderConverter::convertNumber):

css/StyleBuilderCustom.h: Added.

(WebCore::StyleBuilderFunctions::applyValueWebkitHyphenateLimitLines):

css/makeprop.pl:

12:05 PM Changeset in webkit [175266] by Joseph Pecoraro

2 edits in trunk/Source/WebKit2

[iOS] iPhone should not allow selecting <optgroup> in <select multiple>
https://bugs.webkit.org/show_bug.cgi?id=137991

Reviewed by Darin Adler.

We seem to be getting the delegate when we are not supposed to.
Workaround the issue as best we can by reseting the styles
for the group's content view and not changing selections.

UIProcess/ios/forms/WKFormSelectPicker.mm:

(-[WKMultipleSelectPicker pickerView:row:column:checked:]):

11:46 AM Changeset in webkit [175265] by zandobersek@gmail.com

7 edits in trunk/Source/WebCore

[WebCore] Remove uses of WTF::bind() in the Media Stream module
https://bugs.webkit.org/show_bug.cgi?id=138016

Reviewed by Eric Carlson.

Replace uses of WTF::bind() in the Media Stream module with C++11 lambdas.
Internal helper methods are removed in favor of inlining the code directly
into the lambdas. Range-based for-loops are deployed where appropriate.

Modules/mediastream/MediaStreamTrack.cpp:

(WebCore::MediaStreamTrack::scheduleEventDispatch):
(WebCore::MediaStreamTrack::dispatchQueuedEvents): Deleted.

Modules/mediastream/MediaStreamTrack.h:
Modules/mediastream/MediaStreamTrackSourcesRequest.cpp:

(WebCore::MediaStreamTrackSourcesRequest::didCompleteRequest):
(WebCore::MediaStreamTrackSourcesRequest::callCompletionHandler): Deleted.

Modules/mediastream/MediaStreamTrackSourcesRequest.h:
Modules/mediastream/UserMediaRequest.cpp:

(WebCore::UserMediaRequest::constraintsValidated):
(WebCore::UserMediaRequest::userMediaAccessGranted):
(WebCore::UserMediaRequest::didCreateStream):
(WebCore::UserMediaRequest::failedToCreateStreamWithConstraintsError):
(WebCore::UserMediaRequest::failedToCreateStreamWithPermissionError):
(WebCore::UserMediaRequest::requestPermission): Deleted.
(WebCore::UserMediaRequest::createMediaStream): Deleted.
(WebCore::UserMediaRequest::callSuccessHandler): Deleted.
(WebCore::UserMediaRequest::callErrorHandler): Deleted.

Modules/mediastream/UserMediaRequest.h:

11:35 AM Changeset in webkit [175264] by ap@apple.com

1 edit
2 adds in trunk/LayoutTests

text-combine needs to center glyphs within the vertical area.
https://bugs.webkit.org/show_bug.cgi?id=138056

Adding pre-Yosemite test results.

platform/mac-mavericks/fast/text/tatechuyoko-expected.png: Added.
platform/mac-mavericks/fast/text/tatechuyoko-expected.txt: Added.

11:05 AM Changeset in webkit [175263] by commit-queue@webkit.org

3 edits
2 adds in trunk

Abandoned select option is reselected when shift selecting new options
https://bugs.webkit.org/show_bug.cgi?id=137553

Patch by Pascal Jacquemart <p.jacquemart@samsung.com> on 2014-10-28
Reviewed by Ryosuke Niwa.

Source/WebCore:

Previous active selection is wrongly recorded by HTMLSelectElement after selecting a new item using
typeAhead. Fixed by clearing previously selected options before starting a new active selection.

Test: fast/forms/listbox-selection-after-typeahead.html

html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::selectOption): Code re-ordering

LayoutTests:

Test checking a combination of mouse and keyboard selection events
on select-multiple element

fast/forms/listbox-selection-after-typeahead-expected.txt: Added.
fast/forms/listbox-selection-after-typeahead.html: Added.

11:01 AM Changeset in webkit [175262] by rniwa@webkit.org

4 edits in trunk/Websites/perf.webkit.org

Remove App.PaneController.bugsChangeCount in the new perf dashboard
https://bugs.webkit.org/show_bug.cgi?id=138111

Reviewed by Darin Adler.

public/v2/app.js:

(App.PaneController.bugsChangeCount): Removed.
(App.PaneController.actions.associateBug): Call _updateMarkedPoints instead of incrementing bugsChangeCount.
(App.PaneController._updateMarkedPoints): Extracted from App.InteractiveChartComponent._updateDotsWithBugs.
Finds the list of current run's points that are associated with bugs.
(App.InteractiveChartComponent._updateMarkedDots): Renamed from _updateDotsWithBugs.

public/v2/chart-pane.css:

(.chart .marked): Renamed from .hasBugs.

public/v2/index.html: Specify chartPointRadius and markedPoints.

11:00 AM Changeset in webkit [175261] by commit-queue@webkit.org

6 edits in trunk/Source

Use constants from wtf/MathExtras.h
https://bugs.webkit.org/show_bug.cgi?id=137967

Patch by Milan Crha <mcrha@redhat.com> on 2014-10-28
Reviewed by Darin Adler.

Source/WebCore:

platform/graphics/freetype/FontPlatformDataFreeType.cpp:

(WebCore::rotateCairoMatrixForVerticalOrientation):

rendering/mathml/RenderMathMLMenclose.cpp:

(WebCore::RenderMathMLMenclose::computePreferredLogicalWidths):
(WebCore::RenderMathMLMenclose::updateLogicalHeight):

rendering/mathml/RenderMathMLOperator.cpp:

(WebCore::RenderMathMLOperator::getDisplayStyleLargeOperator):

Source/WTF:

wtf/MathExtras.h:

10:58 AM Changeset in webkit [175260] by hyatt@apple.com

2 edits in trunk/Source/WebCore

Selection gap painting is ugly for ruby bases.
https://bugs.webkit.org/show_bug.cgi?id=138136

Reviewed by Dean Jackson.

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::selectionGaps):
For ruby bases don't fill to the end of the block (in the block direction),
since ideographic baselines push that end below the text baseline.

(WebCore::RenderBlock::blockSelectionGaps):

rendering/RenderBlockFlow.cpp:

Skip ruby bases for block selection gap filling.

10:57 AM Changeset in webkit [175259] by Alan Bujtas

142 edits
4 adds in trunk

Speed up line parsing for simple line layout.
https://bugs.webkit.org/show_bug.cgi?id=137275

Reviewed by Antti Koivisto.
Source/WebCore:

This patch speeds up the line parsing for simple line layout by
reducing the number of text measurement calls.
The parsing logic hasn't changed. We simply walk over
the whitespace/non-whitespace fragments and measure them to
figure out whether they fit.
The performance gain mainly comes from the more efficient line wrapping
so that we don't re-measure the fragment when it is pushed to
the next line.

No change in behaviour. (except the empty line-break run removal.)

rendering/SimpleLineLayout.cpp:

(WebCore::SimpleLineLayout::skipWhitespace):
(WebCore::SimpleLineLayout::computeLineLeft):
(WebCore::SimpleLineLayout::TextFragment::TextFragment):
(WebCore::SimpleLineLayout::TextFragment::isEmpty):
(WebCore::SimpleLineLayout::LineState::LineState):
(WebCore::SimpleLineLayout::LineState::commitAndCreateRun): adds uncommitted text to the line and creates a run out of it.
(WebCore::SimpleLineLayout::LineState::addUncommitted): appends fragment to the uncommitted text.
(WebCore::SimpleLineLayout::LineState::addUncommittedWhitespace): appends whitespace to the uncommitted text.
(WebCore::SimpleLineLayout::LineState::jumpTo): moves line's current position without committing text.
(WebCore::SimpleLineLayout::LineState::width): current width of the line including committed and uncommitted text.
(WebCore::SimpleLineLayout::LineState::fits): checks if committed + uncommitted text fits the line.
(WebCore::SimpleLineLayout::LineState::removeCommittedTrailingWhitespace):
(WebCore::SimpleLineLayout::removeTrailingWhitespace): post processing the trailing whitespace.
(WebCore::SimpleLineLayout::initializeLine):
(WebCore::SimpleLineLayout::splitFragmentToFitLine): breaks the fragments into 2 so that the first (sub)fragment fits the line.
(WebCore::SimpleLineLayout::nextFragment): returns the next valid fragment of the text.
(WebCore::SimpleLineLayout::createLineRuns): creates runs for the current line and returns when we can't fit more text on the line.
(WebCore::SimpleLineLayout::updateLineConstrains): updates left/right constrains for the current line.
(WebCore::SimpleLineLayout::createTextRuns): creates runs for the whole text.
(WebCore::SimpleLineLayout::isWhitespace): Deleted.
(WebCore::SimpleLineLayout::skipWhitespaces): Deleted.
(WebCore::SimpleLineLayout::measureWord): Deleted.
(WebCore::SimpleLineLayout::adjustRunOffsets): Deleted.

rendering/SimpleLineLayout.h:

(WebCore::SimpleLineLayout::Run::Run):

LayoutTests:

This patch removes empty line-break runs. Rebaseline.

platform/mac-mountainlion/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:
platform/mac/css1/basic/containment-expected.txt:
platform/mac/css1/basic/contextual_selectors-expected.txt:
platform/mac/css1/basic/grouping-expected.txt:
platform/mac/css1/basic/id_as_selector-expected.txt:
platform/mac/css1/basic/inheritance-expected.txt:
platform/mac/css1/box_properties/border-expected.txt:
platform/mac/css1/box_properties/border_bottom-expected.txt:
platform/mac/css1/box_properties/border_bottom_inline-expected.txt:
platform/mac/css1/box_properties/border_bottom_width-expected.txt:
platform/mac/css1/box_properties/border_bottom_width_inline-expected.txt:
platform/mac/css1/box_properties/border_color-expected.txt:
platform/mac/css1/box_properties/border_color_inline-expected.txt:
platform/mac/css1/box_properties/border_inline-expected.txt:
platform/mac/css1/box_properties/border_left-expected.txt:
platform/mac/css1/box_properties/border_left_inline-expected.txt:
platform/mac/css1/box_properties/border_left_width-expected.txt:
platform/mac/css1/box_properties/border_left_width_inline-expected.txt:
platform/mac/css1/box_properties/border_right-expected.txt:
platform/mac/css1/box_properties/border_right_inline-expected.txt:
platform/mac/css1/box_properties/border_right_width-expected.txt:
platform/mac/css1/box_properties/border_right_width_inline-expected.txt:
platform/mac/css1/box_properties/border_style-expected.txt:
platform/mac/css1/box_properties/border_style_inline-expected.txt:
platform/mac/css1/box_properties/border_top-expected.txt:
platform/mac/css1/box_properties/border_top_inline-expected.txt:
platform/mac/css1/box_properties/border_top_width-expected.txt:
platform/mac/css1/box_properties/border_top_width_inline-expected.txt:
platform/mac/css1/box_properties/border_width-expected.txt:
platform/mac/css1/box_properties/border_width_inline-expected.txt:
platform/mac/css1/box_properties/clear-expected.txt:
platform/mac/css1/box_properties/clear_float-expected.txt:
platform/mac/css1/box_properties/float-expected.txt:
platform/mac/css1/box_properties/float_elements_in_series-expected.txt:
platform/mac/css1/box_properties/float_margin-expected.txt:
platform/mac/css1/box_properties/height-expected.txt:
platform/mac/css1/box_properties/margin-expected.txt:
platform/mac/css1/box_properties/margin_bottom-expected.txt:
platform/mac/css1/box_properties/margin_bottom_inline-expected.txt:
platform/mac/css1/box_properties/margin_inline-expected.txt:
platform/mac/css1/box_properties/margin_left-expected.txt:
platform/mac/css1/box_properties/margin_left_inline-expected.txt:
platform/mac/css1/box_properties/margin_right-expected.txt:
platform/mac/css1/box_properties/margin_right_inline-expected.txt:
platform/mac/css1/box_properties/margin_top-expected.txt:
platform/mac/css1/box_properties/margin_top_inline-expected.txt:
platform/mac/css1/box_properties/padding-expected.txt:
platform/mac/css1/box_properties/padding_bottom-expected.txt:
platform/mac/css1/box_properties/padding_bottom_inline-expected.txt:
platform/mac/css1/box_properties/padding_inline-expected.txt:
platform/mac/css1/box_properties/padding_left-expected.txt:
platform/mac/css1/box_properties/padding_left_inline-expected.txt:
platform/mac/css1/box_properties/padding_right-expected.txt:
platform/mac/css1/box_properties/padding_right_inline-expected.txt:
platform/mac/css1/box_properties/padding_top-expected.txt:
platform/mac/css1/box_properties/padding_top_inline-expected.txt:
platform/mac/css1/box_properties/width-expected.txt:
platform/mac/css1/cascade/cascade_order-expected.txt:
platform/mac/css1/cascade/important-expected.txt:
platform/mac/css1/classification/display-expected.txt:
platform/mac/css1/classification/list_style-expected.txt:
platform/mac/css1/classification/list_style_image-expected.txt:
platform/mac/css1/classification/list_style_position-expected.txt:
platform/mac/css1/classification/list_style_type-expected.txt:
platform/mac/css1/classification/white_space-expected.txt:
platform/mac/css1/color_and_background/background-expected.txt:
platform/mac/css1/color_and_background/background_attachment-expected.txt:
platform/mac/css1/color_and_background/background_color-expected.txt:
platform/mac/css1/color_and_background/background_image-expected.txt:
platform/mac/css1/color_and_background/background_position-expected.txt:
platform/mac/css1/color_and_background/background_repeat-expected.txt:
platform/mac/css1/color_and_background/color-expected.txt:
platform/mac/css1/conformance/forward_compatible_parsing-expected.txt:
platform/mac/css1/font_properties/font-expected.txt:
platform/mac/css1/font_properties/font_family-expected.txt:
platform/mac/css1/font_properties/font_size-expected.txt:
platform/mac/css1/font_properties/font_style-expected.txt:
platform/mac/css1/font_properties/font_variant-expected.txt:
platform/mac/css1/font_properties/font_weight-expected.txt:
platform/mac/css1/formatting_model/canvas-expected.txt:
platform/mac/css1/formatting_model/floating_elements-expected.txt:
platform/mac/css1/formatting_model/height_of_lines-expected.txt:
platform/mac/css1/formatting_model/inline_elements-expected.txt:
platform/mac/css1/formatting_model/replaced_elements-expected.txt:
platform/mac/css1/formatting_model/vertical_formatting-expected.txt:
platform/mac/css1/pseudo/anchor-expected.txt:
platform/mac/css1/pseudo/firstletter-expected.txt:
platform/mac/css1/pseudo/firstline-expected.txt:
platform/mac/css1/pseudo/multiple_pseudo_elements-expected.txt:
platform/mac/css1/pseudo/pseudo_elements_in_selectors-expected.txt:
platform/mac/css1/text_properties/letter_spacing-expected.txt:
platform/mac/css1/text_properties/line_height-expected.txt:
platform/mac/css1/text_properties/text_align-expected.txt:
platform/mac/css1/text_properties/text_decoration-expected.txt:
platform/mac/css1/text_properties/text_indent-expected.txt:
platform/mac/css1/text_properties/text_transform-expected.txt:
platform/mac/css1/text_properties/vertical_align-expected.txt:
platform/mac/css1/text_properties/word_spacing-expected.txt:
platform/mac/css1/units/color_units-expected.txt:
platform/mac/css1/units/length_units-expected.txt:
platform/mac/css1/units/percentage_units-expected.txt:
platform/mac/css1/units/urls-expected.txt:
platform/mac/css2.1/t100801-c548-ln-ht-00-c-a-expected.txt:
platform/mac/css2.1/t1606-c562-white-sp-00-b-ag-expected.txt:
platform/mac/editing/selection/designmode-no-caret-expected.txt:
platform/mac/fast/css/empty-pseudo-class-expected.txt:
platform/mac/fast/css/first-child-pseudo-class-expected.txt:
platform/mac/fast/css/last-child-pseudo-class-expected.txt:
platform/mac/fast/css/only-child-pseudo-class-expected.txt:
platform/mac/fast/forms/targeted-frame-submission-expected.txt:
platform/mac/fast/frames/onlyCommentInIFrame-expected.txt:
platform/mac/fast/html/listing-expected.txt:
platform/mac/fast/invalid/junk-data-expected.txt:
platform/mac/fast/invalid/missing-end-tag-expected.txt:
platform/mac/fast/loader/text-document-wrapping-expected.txt:
platform/mac/fast/overflow/clip-rects-fixed-ancestor-expected.txt:
platform/mac/fast/parser/xhtml-alternate-entities-expected.txt:
platform/mac/fast/table/border-collapsing/004-expected.txt:
platform/mac/fast/table/border-collapsing/004-vertical-expected.txt:
platform/mac/fast/text/whitespace/001-expected.txt: Added.
platform/mac/fast/text/whitespace/013-expected.txt: Added.
platform/mac/fast/text/whitespace/014-expected.txt: Added.
platform/mac/fast/text/whitespace/022-expected.txt: Added.
platform/mac/fast/text/whitespace/024-expected.txt:
platform/mac/fast/text/whitespace/030-expected.txt:
platform/mac/fast/xsl/xslt-extra-content-at-end-expected.txt:
platform/mac/fast/xsl/xslt-missing-namespace-in-xslt-expected.txt:
platform/mac/http/tests/misc/acid3-expected.txt:
platform/mac/svg/custom/bug45331-expected.txt:
platform/mac/svg/custom/junk-data-expected.txt:
platform/mac/svg/custom/missing-xlink-expected.txt:
platform/mac/svg/custom/path-bad-data-expected.txt:
platform/mac/svg/custom/use-font-face-crash-expected.txt:
platform/mac/svg/hixie/error/012-expected.txt:
platform/mac/tables/mozilla/bugs/45621-expected.txt:
platform/mac/tables/mozilla/bugs/bug139524-2-expected.txt:
platform/mac/tables/mozilla_expected_failures/bugs/bug1055-2-expected.txt:
platform/mac/tables/mozilla_expected_failures/bugs/bug21518-expected.txt:
platform/mac/tables/mozilla_expected_failures/bugs/bug22122-expected.txt:
platform/mac/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:
platform/mac/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.txt:

10:55 AM Changeset in webkit [175258] by commit-queue@webkit.org

2 edits in trunk/Source/JavaScriptCore

Unreviewed, rolling out r175249.
https://bugs.webkit.org/show_bug.cgi?id=138138

Appears to be failing some JS tests (Requested by mlam_ on
#webkit).

Reverted changeset:

"Holes are not copied properly when Arrays change shape to
ArrayStorage type."
https://bugs.webkit.org/show_bug.cgi?id=138118
http://trac.webkit.org/changeset/175249

10:52 AM Changeset in webkit [175257] by commit-queue@webkit.org

2 edits in trunk/Tools

import-w3c-tests should use re.escape() wherever it's handling file paths
https://bugs.webkit.org/show_bug.cgi?id=137934

This patch adds re.escape() to a few places where we're doing string
conversions. This prevents errors when attribute values coincidentally
have character sequences that can be interpreted as regular expressions.

Patch by Rebecca Hauck <rhauck@adobe.com> on 2014-10-28
Reviewed by Bem Jones-Bey.

Scripts/webkitpy/w3c/test_converter.py:

(_W3CTestConverter.convert_attributes_if_needed):

10:37 AM Changeset in webkit [175256] by timothy_horton@apple.com

2 edits in trunk/Source/WebKit2

Remove an inaccurate comment in WKActionMenuController
https://bugs.webkit.org/show_bug.cgi?id=138135

Reviewed by Anders Carlsson.

UIProcess/mac/WKActionMenuController.mm:

(-[WKActionMenuController _defaultMenuItemsForLink]):
The comment is wrong; the separator is there for spacing, not just as a workaround.

10:17 AM Changeset in webkit [175255] by commit-queue@webkit.org

39 edits
1 copy
17 adds in trunk/LayoutTests

Update CSS shapes suite import
https://bugs.webkit.org/show_bug.cgi?id=138045

This patch is a full re-import of the CSS Shapes test suite from the W3C
test repo and an updated TestExpectations file to match the current
results.

Patch by Rebecca Hauck <rhauck@adobe.com> on 2014-10-28
Reviewed by Benjamin Poulain.

TestExpectations:
css3/shapes/shape-outside/shape-box/w3c-import.log:
css3/shapes/shape-outside/shape-image/gradients/w3c-import.log:
css3/shapes/shape-outside/shape-image/shape-image-000-expected.html:
css3/shapes/shape-outside/shape-image/shape-image-001-expected.html:
css3/shapes/shape-outside/shape-image/shape-image-002-expected.html:
css3/shapes/shape-outside/shape-image/shape-image-002.html:
css3/shapes/shape-outside/shape-image/shape-image-003-expected.html:
css3/shapes/shape-outside/shape-image/shape-image-003.html:
css3/shapes/shape-outside/shape-image/shape-image-004-expected.html:
css3/shapes/shape-outside/shape-image/shape-image-005-expected.html:
css3/shapes/shape-outside/shape-image/shape-image-005.html:
css3/shapes/shape-outside/shape-image/shape-image-006-expected.html: Added.
css3/shapes/shape-outside/shape-image/shape-image-006.html: Added.
css3/shapes/shape-outside/shape-image/shape-image-007-expected.html: Added.
css3/shapes/shape-outside/shape-image/shape-image-007.html: Added.
css3/shapes/shape-outside/shape-image/shape-image-008-expected.html: Added.
css3/shapes/shape-outside/shape-image/shape-image-008.html: Added.
css3/shapes/shape-outside/shape-image/shape-image-009-expected.html: Added.
css3/shapes/shape-outside/shape-image/shape-image-009.html: Added.
css3/shapes/shape-outside/shape-image/shape-image-010-expected.html: Added.
css3/shapes/shape-outside/shape-image/shape-image-010.html: Added.
css3/shapes/shape-outside/shape-image/shape-image-011-expected.html: Added.
css3/shapes/shape-outside/shape-image/shape-image-011.html: Added.
css3/shapes/shape-outside/shape-image/shape-image-013-expected.html:
css3/shapes/shape-outside/shape-image/shape-image-013.html:
css3/shapes/shape-outside/shape-image/shape-image-014-expected.html:
css3/shapes/shape-outside/shape-image/shape-image-014.html:
css3/shapes/shape-outside/shape-image/shape-image-015-expected.html:
css3/shapes/shape-outside/shape-image/shape-image-015.html:
css3/shapes/shape-outside/shape-image/shape-image-016-expected.html:
css3/shapes/shape-outside/shape-image/shape-image-016.html:
css3/shapes/shape-outside/shape-image/shape-image-017-expected.html:
css3/shapes/shape-outside/shape-image/shape-image-017.html:
css3/shapes/shape-outside/shape-image/shape-image-024-expected.html: Added.
css3/shapes/shape-outside/shape-image/shape-image-024.html: Added.
css3/shapes/shape-outside/shape-image/shape-image-025-expected.html: Added.
css3/shapes/shape-outside/shape-image/shape-image-025.html: Added.
css3/shapes/shape-outside/shape-image/support/animated.gif: Added.
css3/shapes/shape-outside/shape-image/support/left-half-rectangle-20.png:
css3/shapes/shape-outside/shape-image/support/right-half-rectangle-20.png:
css3/shapes/shape-outside/shape-image/support/w3c-import.log:
css3/shapes/shape-outside/shape-image/w3c-import.log:
css3/shapes/shape-outside/supported-shapes/circle/w3c-import.log:
css3/shapes/shape-outside/supported-shapes/ellipse/w3c-import.log:
css3/shapes/shape-outside/supported-shapes/inset/w3c-import.log:
css3/shapes/shape-outside/supported-shapes/polygon/shape-outside-polygon-012.html:
css3/shapes/shape-outside/supported-shapes/polygon/w3c-import.log:
css3/shapes/shape-outside/supported-shapes/support/w3c-import.log: Copied from LayoutTests/css3/shapes/shape-outside/values/support/w3c-import.log.
css3/shapes/shape-outside/values/shape-image-threshold-001.html:
css3/shapes/shape-outside/values/support/w3c-import.log:
css3/shapes/shape-outside/values/w3c-import.log:
css3/shapes/spec-examples/shape-outside-019-expected.html:
css3/shapes/spec-examples/support/w3c-import.log:
css3/shapes/spec-examples/w3c-import.log:
css3/shapes/w3c-import.log:

9:44 AM Changeset in webkit [175254] by ap@apple.com

2 edits in trunk/Source/WebCore

Windows build fix.

platform/network/cf/NetworkStorageSessionCFNet.cpp:

(WebCore::NetworkStorageSession::switchToNewTestingSession): Use a WTF function
for getting current process ID instead of getpid().

9:30 AM Changeset in webkit [175253] by commit-queue@webkit.org

4 edits in trunk

[EFL] Remove unnecessary defines from OptionsEfl.cmake
https://bugs.webkit.org/show_bug.cgi?id=138132

Patch by Tibor Meszaros <tmeszaros.u-szeged@partner.samsung.com> on 2014-10-28
Reviewed by Csaba Osztrogonác.

Source/cmake/OptionsEfl.cmake:

Source/WTF:

wtf/Platform.h:

9:05 AM Changeset in webkit [175252] by mihnea@adobe.com

6 edits in trunk/Source/WebCore

Clean up subtrees selection code
https://bugs.webkit.org/show_bug.cgi?id=137740

Reviewed by David Hyatt.

Clean up subtrees selection code. Add a new class SelectionSubtreeData
that keeps only the selection data. Have SelectionSubtreeRoot class embed
a SelectionSubtreeData member and keep the business logic methods.
No functionality changed therefore no new layout tests.

rendering/RenderObject.cpp:

(WebCore::RenderObject::selectionStartEnd):

rendering/RenderView.cpp:

(WebCore::RenderView::subtreeSelectionBounds):
(WebCore::RenderView::repaintSubtreeSelection):
(WebCore::RenderView::setSelection):
(WebCore::RenderView::splitSelectionBetweenSubtrees):
(WebCore::RenderView::updateSelectionForSubtrees):
(WebCore::RenderView::clearSubtreeSelection):
(WebCore::RenderView::applySubtreeSelection):

rendering/RenderView.h:
rendering/SelectionSubtreeRoot.cpp:

(WebCore::SelectionSubtreeRoot::SelectionSubtreeRoot):
(WebCore::SelectionSubtreeRoot::adjustForVisibleSelection):

rendering/SelectionSubtreeRoot.h:

(WebCore::SelectionSubtreeRoot::SelectionSubtreeData::SelectionSubtreeData):
(WebCore::SelectionSubtreeRoot::SelectionSubtreeData::selectionStart):
(WebCore::SelectionSubtreeRoot::SelectionSubtreeData::selectionStartPos):
(WebCore::SelectionSubtreeRoot::SelectionSubtreeData::selectionEnd):
(WebCore::SelectionSubtreeRoot::SelectionSubtreeData::selectionEndPos):
(WebCore::SelectionSubtreeRoot::SelectionSubtreeData::selectionClear):
(WebCore::SelectionSubtreeRoot::SelectionSubtreeData::selectionStartEndPositions):
(WebCore::SelectionSubtreeRoot::SelectionSubtreeData::setSelectionStart):
(WebCore::SelectionSubtreeRoot::SelectionSubtreeData::setSelectionStartPos):
(WebCore::SelectionSubtreeRoot::SelectionSubtreeData::setSelectionEnd):
(WebCore::SelectionSubtreeRoot::SelectionSubtreeData::setSelectionEndPos):
(WebCore::SelectionSubtreeRoot::SelectionSubtreeData::clearSelection):
(WebCore::SelectionSubtreeRoot::selectionData):
(WebCore::SelectionSubtreeRoot::setSelectionData):
(WebCore::SelectionSubtreeRoot::selectionStart): Deleted.
(WebCore::SelectionSubtreeRoot::selectionStartPos): Deleted.
(WebCore::SelectionSubtreeRoot::selectionEnd): Deleted.
(WebCore::SelectionSubtreeRoot::selectionEndPos): Deleted.
(WebCore::SelectionSubtreeRoot::selectionStartEndPositions): Deleted.
(WebCore::SelectionSubtreeRoot::selectionClear): Deleted.
(WebCore::SelectionSubtreeRoot::setSelectionStart): Deleted.
(WebCore::SelectionSubtreeRoot::setSelectionStartPos): Deleted.
(WebCore::SelectionSubtreeRoot::setSelectionEnd): Deleted.
(WebCore::SelectionSubtreeRoot::setSelectionEndPos): Deleted.

9:04 AM Changeset in webkit [175251] by jer.noble@apple.com

2 edits in trunk/Source/WebCore

[Mac] The first software paint of a <video> element takes up to 2.5s.
https://bugs.webkit.org/show_bug.cgi?id=137754

Reviewed by Brent Fulgham.

It turns out that, if you pass nil to -[AVPlayerItemVideoOutput initWithPixelBufferAttributes:]
the video output will not attempt to conform the resulting pixel buffers into a particular format.
This means that adding such a video output to a AVPlayerItem should have almost no performance
penalty, since the video output does not even copy the resulting buffers, but rather just retains
and returns the ones from the AVPlayerLayer.

Create and attach an AVPlayerItemVideoOutput after creating the AVPlayerItem, but before attaching
the player item to the AVPlayer. This eliminates the reconfigure step which occurs after attaching
a video output to an already attached AVPlayerItem.

When creating the AVPlayerItemVideoOutput, pass in nil for the pixelBufferAttributes parameter.

Instead of blocking waiting for output from the AVPlayerItemVideoOutput during creating, block and
whait when asked to paint with the video output.

platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::createVideoLayer):
(WebCore::MediaPlayerPrivateAVFoundationObjC::createVideoOutput):
(WebCore::MediaPlayerPrivateAVFoundationObjC::paintWithVideoOutput):

8:35 AM Changeset in webkit [175250] by Chris Dumez

4 edits in trunk/Source/WebCore

Move text decoration CSS properties to the new StyleBuilder
https://bugs.webkit.org/show_bug.cgi?id=138121

Reviewed by Antti Koivisto.

Move text decoration CSS properties from DeprecatedStyleBuilder to the
new StyleBuilder so that they are generated from CSSPropertyNames.in.

No new tests, no behavior change.

css/CSSPropertyNames.in:
css/DeprecatedStyleBuilder.cpp:

(WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder):
(WebCore::ApplyPropertyTextDecoration::applyValue): Deleted.
(WebCore::ApplyPropertyTextDecoration::createHandler): Deleted.

css/StyleBuilderConverter.h:

(WebCore::StyleBuilderConverter::convertTextDecoration):

8:29 AM Changeset in webkit [175249] by mark.lam@apple.com

2 edits in trunk/Source/JavaScriptCore

Holes are not copied properly when Arrays change shape to ArrayStorage type.
<https://webkit.org/b/138118>

Reviewed by Mark Hahnenberg.

When we convert non-ArrayStorage typed arrays into ArrayStorage typed arrays,
we skipped the holes. As a result, the slots in the ArrayStorage vector that
corresponds to those holes are uninitialize. This is now fixed.

runtime/JSObject.cpp:

(JSC::JSObject::convertUndecidedToArrayStorage):
(JSC::JSObject::convertInt32ToArrayStorage):
(JSC::JSObject::convertDoubleToArrayStorage):
(JSC::JSObject::convertContiguousToArrayStorage):

7:14 AM Changeset in webkit [175248] by commit-queue@webkit.org

2 edits in trunk/Tools

[EFL] Remove an unused include from Tools/WebKitTestRunner/efl/PlatformWebViewEfl.cpp
https://bugs.webkit.org/show_bug.cgi?id=138130

Patch by Tibor Meszaros <tmeszaros.u-szeged@partner.samsung.com> on 2014-10-28
Reviewed by Csaba Osztrogonác.

WebKitTestRunner/efl/PlatformWebViewEfl.cpp:

6:53 AM Changeset in webkit [175247] by Carlos Garcia Campos

1 copy in releases/WebKitGTK/webkit-2.7.1

WebKitGTK+ 2.7.1

6:52 AM Changeset in webkit [175246] by Carlos Garcia Campos

4 edits in trunk

Unreviewed. Update OptionsGTK.cmake and NEWS for 2.7.1 release.

Source/cmake/OptionsGTK.cmake: Bump version numbers.

Source/WebKit2:

gtk/NEWS: Add release notes for 2.7.1.

5:49 AM Changeset in webkit [175245] by Carlos Garcia Campos

3 edits in trunk/Source/WebCore

[GTK] Remove GDK dependency from SharedTimerGtk
https://bugs.webkit.org/show_bug.cgi?id=138092

Reviewed by Martin Robinson.

It depends on GDK just to use GDK_PRIORITY_REDRAW constant, we can
use its value directly instead.

PlatformGTK.cmake:
platform/gtk/SharedTimerGtk.cpp:

(WebCore::setSharedTimerFireInterval):

12:05 AM Changeset in webkit [175244] by mitz@apple.com

2 edits in trunk/Source/WebKit2

[Mac] OS X Mavericks build broken with public SDK
https://bugs.webkit.org/show_bug.cgi?id=138108

Reviewed by Mark Rowe.

Shared/API/Cocoa/WKFoundation.h: Only define the NSEventModifierFlags type when using a

version of the OS X SDK that doesn’t define it.

Oct 27, 2014:

10:46 PM Changeset in webkit [175243] by mark.lam@apple.com

3 edits
6 adds in trunk

Crash when attempting to perform array iteration on a non-array with numeric keys not initialized.
<https://webkit.org/b/137814>

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

The arrayIteratorNextThunkGenerator() thunk was not checking for the case where
the butterfly may be NULL. This was the source of the crash, and is now fixed.

In addition, it is also not checking for the case where a property named "length"
may have been set on the iterated object. The thunk only checks the butterfly's
publicLength for its iteration operation. Array objects will work fine with this
because it always updates its butterfly's publicLength when its length changes.
In the case of iterable non-Array objects, the "length" property will require a
look up outside of the scope of this thunk. The fix is simply to limit the fast
case checks in this thunk to Array objects.

jit/ThunkGenerators.cpp:

(JSC::arrayIteratorNextThunkGenerator):

LayoutTests:

js/array-length-shortening-expected.txt: Added.
js/array-length-shortening.html: Added.
js/for-of-crash-expected.txt: Added.
js/for-of-crash.html: Added.
js/script-tests/array-length-shortening.js: Added.

(testLengthShortening):
(denseInt32Elements):
(denseDoubleElements):
(denseObjectElements):
(holeyInt32Elements):
(holeyDoubleElements):
(holeyObjectElements):
(arrayStorageInt32Elements):
(arrayStorageDoubleElements):
(arrayStorageObjectElements):
(sparseInt32Elements):
(sparseDoubleElements):
(sparseObjectElements):

js/script-tests/for-of-crash.js: Added.

(foo):

10:39 PM Changeset in webkit [175242] by akling@apple.com

6 edits in trunk/Source/WebCore

Move RenderBlock::beingDestroyed() to RenderObject.
<https://webkit.org/b/138116>

Reviewed by Antti Koivisto.

Make "is being destroyed" a RenderObject concept instead of restricting
it to RenderBlocks. I'm guessing that this was specific to blocks due to
lack of bitfield space in RenderObject, and that's no longer an issue.

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::RenderBlock):
(WebCore::RenderBlock::willBeDestroyed):

rendering/RenderBlock.h:

(WebCore::RenderBlock::beingDestroyed): Deleted.

rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::willBeDestroyed):

rendering/RenderObject.cpp:

(WebCore::RenderObject::destroy):

rendering/RenderObject.h:

(WebCore::RenderObject::beingDestroyed):
(WebCore::RenderObject::RenderObjectBitfields::RenderObjectBitfields):

10:38 PM Changeset in webkit [175241] by Chris Fleizach

3 edits
2 adds in trunk

AX: input type=hidden is being exposed when aria-hidden=false
https://bugs.webkit.org/show_bug.cgi?id=138106

Reviewed by Benjamin Poulain.

Source/WebCore:

If an input type=hidden was inside an aria-hidden=false, it would appear because
the lack of a RenderObject behind that object was not blocking its adoption into the AX tree.
We should explicity check for whether the type is hidden and then return an appropriate role.

Test: accessibility/input-type-hidden-in-aria-hidden-false.html

accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::determineAccessibilityRole):
(WebCore::AccessibilityNodeObject::computeAccessibilityIsIgnored):

LayoutTests:

accessibility/input-type-hidden-in-aria-hidden-false-expected.txt: Added.
accessibility/input-type-hidden-in-aria-hidden-false.html: Added.

10:05 PM Changeset in webkit [175240] by mark.lam@apple.com

3 edits in trunk/Source/JavaScriptCore

Simplified some JSObject methods for converting arrays to ArrayStorage shape.
<https://webkit.org/b/138119>

Reviewed by Filip Pizlo.

Currently, for each Undecided, Int32, Double, and Contiguous array shapes,
there are 3 JSObject methods to convert them to ArrayStorage shape:

ArrayStorage* convert<shape>ToArrayStorage(VM&, NonPropertyTransition, unsigned neededLength);
ArrayStorage* convert<shape>ToArrayStorage(VM&, NonPropertyTransition);
ArrayStorage* convert<shape>ToArrayStorage(VM&);

However, the neededLength that is passed is always m_butterfly->vectorLength().
Hence, the method that takes a neededLength is really not needed. This patch
removes this unneeded verbosity.

runtime/JSObject.cpp:

(JSC::JSObject::convertUndecidedToArrayStorage):
(JSC::JSObject::convertInt32ToArrayStorage):

Also reordered the placement of the DeferGC statement so this Int32 function will look more similar to the others.

(JSC::JSObject::convertDoubleToArrayStorage):
(JSC::JSObject::convertContiguousToArrayStorage):

runtime/JSObject.h:

8:46 PM Changeset in webkit [175239] by bshafiei@apple.com

2 edits in branches/safari-600.1.4.12-branch/Source/WebKit2

Merged r175235. rdar://problem/18787412

8:05 PM Changeset in webkit [175238] by commit-queue@webkit.org

3 edits in trunk/Source/WebKit2

NSSharingService protocol conformance should be internal to WKActionMenuController
https://bugs.webkit.org/show_bug.cgi?id=138112

Patch by Conrad Shultz <Conrad Shultz> on 2014-10-27
Reviewed by Tim Horton.

UIProcess/mac/WKActionMenuController.h:
UIProcess/mac/WKActionMenuController.mm:

Move protocol conformance from the interface to a class extension.

7:49 PM Changeset in webkit [175237] by ap@apple.com

2 edits in trunk/Source/WebCore

https://trac.webkit.org/changeset/175233 broke many tests, fixing an incorrect '!'.

accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::determineAccessibilityRole):

6:00 PM Changeset in webkit [175236] by hyatt@apple.com

4 edits
3 adds in trunk

text-combine needs to center text within the vertical space using glyph bounds
https://bugs.webkit.org/show_bug.cgi?id=138056
<rdar://problem/15403667>

Reviewed by Dean Jackson.

Source/WebCore:

Added fast/text/tatechuyoko.html

rendering/RenderCombineText.cpp:

(WebCore::RenderCombineText::RenderCombineText):
(WebCore::RenderCombineText::adjustTextOrigin):
(WebCore::RenderCombineText::combineText):

rendering/RenderCombineText.h:

LayoutTests:

fast/text/tatechuyoko.html: Added.
platform/mac/fast/text/tatechuyoko-expected.png: Added.
platform/mac/fast/text/tatechuyoko-expected.txt: Added.

5:36 PM Changeset in webkit [175235] by enrica@apple.com

2 edits in trunk/Source/WebKit2

WebContent crash in WebKit::WebPage::expandedRangeFromHandle.
https://bugs.webkit.org/show_bug.cgi?id=138023
rdar://problem/18787412

Reviewed by Ryosuke Niwa.

We must change that we have a valid currentRange before trying
to expand or contract.

WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::changeBlockSelection):

4:13 PM Changeset in webkit [175234] by rniwa@webkit.org

2 edits in trunk/Websites/perf.webkit.org

REGRESSION: commit logs are not shown sometimes on the new dashboard UI
https://bugs.webkit.org/show_bug.cgi?id=138099

Reviewed by Benjamin Poulain.

The bug was caused by _currentItemChanged not passing the previous point in the list of points and also
_showDetails inverting the order of the current and old measurements.

public/v2/app.js:

(App.PaneController._currentItemChanged): Pass in the previous point to _showDetails when there is one.
(App.PaneController._showDetails): Since points are ordered chronologically, the last point is the
current (latest) measurement and the first point is the oldest measurement.
(App.CommitsViewerComponent.commitsChanged): Don't show a single measurement as a range for clarity.

3:55 PM Changeset in webkit [175233] by benjamin@webkit.org

2 edits in trunk/Source/WebCore

Cleanup after r175213: fastGetAttribute().isNull() should be fastHasAttribute()

accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::determineAccessibilityRole):
Darin spotted this mistake.

2:59 PM Changeset in webkit [175232] by ap@apple.com

7 edits in trunk

http/tests/cookies/third-party-cookie-relaxing.html is flaky on bots
https://bugs.webkit.org/show_bug.cgi?id=138098

Reviewed by Anders Carlsson.

Source/WebCore:

platform/network/cf/NetworkStorageSessionCFNet.cpp:

(WebCore::NetworkStorageSession::switchToNewTestingSession):
Create a separate session for each WKTR/DRT process when testing.

Source/WebKit2:

NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in:
WebProcess/com.apple.WebProcess.sb.in:

Update for the new name of testing session. Memory regions are now of the form
"WebKit Test-<pid>-0".

LayoutTests:

platform/mac-wk1/TestExpectations: Removed the test from expectations. It's still

skipped on WK2, because we don't yet implement the necessary WKTR functionality.

2:08 PM Changeset in webkit [175231] by Chris Dumez

13 edits in trunk/Source

Use separate HashMaps for common and uncommon headers in HTTPHeaderMap
https://bugs.webkit.org/show_bug.cgi?id=138079

Reviewed by Anders Carlsson.

Source/WebCore:

Use separate HashMaps for common and uncommon headers in HTTPHeaderMap:

a (faster) HashMap<HTTPHeaderMap, String> for common HTTP headers
a HashMap<String, String, CaseFoldingHash> for uncommon ones

This avoids having to construct Strings from HTTPHeaderMap values for
storing. This also means we have less isolated String copies to do when
creating cross-thread data. The common headers HashMap should also be
a bit more efficient due to faster hashing and faster key comparison in
case of collision.

Some calls sites can also benefit from having direct access to common
headers of the request in HTTPHeaderName type.

This patch adds a new HTTPHeaderMapConstIterator iterator type for
HTTPHeaderMap so that call sites that do not need / want to distinguish
common / uncommon headers still do not need to. They can keep using
modern C++ loops over HTTPHeaderMap objects and get <String, String>
key/value pairs.

No new tests, no behavior change.

loader/CrossOriginAccessControl.cpp:

(WebCore::isOnAccessControlSimpleRequestHeaderWhitelist):
Have isOnAccessControlSimpleRequestHeaderWhitelist() take a
HTTPHeaderName in argument instead of a String as only common headers
are in the whitelist.

(WebCore::isSimpleCrossOriginAccessRequest):
Call isOnAccessControlSimpleRequestHeaderWhitelist() only for common
HTTP headers.

loader/CrossOriginAccessControl.h:

Have isOnAccessControlSimpleRequestHeaderWhitelist() take a
HTTPHeaderName in argument instead of a String as only common headers
are in the whitelist.

loader/CrossOriginPreflightResultCache.cpp:

(WebCore::CrossOriginPreflightResultCacheItem::allowsCrossOriginHeaders):
Call isOnAccessControlSimpleRequestHeaderWhitelist() only for common
HTTP headers.

loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::responseReceived):
Call httpHeaderFields().commonHeaders().find() instead of
httpHeaderFields().find() as we are looking for a common header.
HTTPHeaderMap::find(HTTPHeaderName) was removed now that we have a
HashMap dedicated to common headers.

loader/cache/CachedRawResource.cpp:

(WebCore::shouldIgnoreHeaderForCacheReuse):
Update argument type to be a HTTPHeaderName instead of a String as
only common HTTP headers can be ignored for cache reuse. The
implementation already dealt with HTTPHeaderName type and had to
call findHTTPHeaderName(). This is no longer needed now that the
call site now has direct access to common headers in HTTPHeaderName
type.

(WebCore::CachedRawResource::canReuse):

Only call shouldIgnoreHeaderForCacheReuse() for common HTTP headers.
Slightly optimize the second loop (the one over oldHeaderMap) to only check that the key is present in newHeaderMap, without actually comparing the String values. If the String values were different, the first loop would have seen it already and we would have returned early.

Source/WebKit2:

Update the WK2 IPC HTTPHeaderMap serialization / deserialization code
to leverage the fact that HTTPHeaderMap now stores common HTTP headers
and uncommon one in separate HashMaps. This speeds up deserialization
as we no longer need to call findHTTPHeaderName() for every decoded
header. We already know if the header is a common one or not, and if
it is then we already have a HTTPHeaderName type instead of a String.

I see that we spend ~40% less time in HTTPHeaderMap decoding when
loading http://flickr.com/explore, while the encoding takes about
the same amount of time as before.

Shared/WebCoreArgumentCoders.cpp:

(IPC::ArgumentCoder<HTTPHeaderMap>::encode):
(IPC::ArgumentCoder<HTTPHeaderMap>::decode):

Source/WTF:

Add HashTraits for C++11 strong enum types. Using integer HashTraits for
strong enums would be inconvenient as it would require casting between
integer and strong enum types.

wtf/HashTraits.h:

(WTF::StrongEnumHashTraits::emptyValue):
(WTF::StrongEnumHashTraits::constructDeletedValue):
(WTF::StrongEnumHashTraits::isDeletedValue):

1:42 PM Changeset in webkit [175230] by akling@apple.com

4 edits in trunk/Source/WebCore

Devirtualize RenderDeprecatedFlexibleBox::isStretchingChildren().
<https://webkit.org/b/138096>

Reviewed by Chris Dumez.

This function is only ever called on a renderer after we've checked
that it's a RenderDeprecatedFlexibleBox, so make it non-virtual.

rendering/RenderBox.cpp:

(WebCore::RenderBox::computeLogicalHeight):

rendering/RenderDeprecatedFlexibleBox.h:
rendering/RenderObject.h:

1:08 PM Changeset in webkit [175229] by Beth Dakin

4 edits in trunk/Source/WebKit/mac

Provide a way for WebKit1 clients to override default action menu items
https://bugs.webkit.org/show_bug.cgi?id=138066
-and corresponding-
rdar://problem/18451638

Reviewed by Anders Carlsson.

WebActionMenuController now has an ivar for the WebActionMenuType so that it can
send that along to clients customizing the menu.

WebView/WebActionMenuController.h:
WebView/WebActionMenuController.mm:

(-[WebActionMenuController prepareForMenu:withEvent:]):
(-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):

New enum and new SPI to customize menus.

WebView/WebUIDelegatePrivate.h:

1:06 PM Changeset in webkit [175228] by Chris Dumez

2 edits in trunk/Source/WebCore

Reintroduce null check removed in r175222
https://bugs.webkit.org/show_bug.cgi?id=138087

Reviewed by Andreas Kling.

Reintroduce null check removed in r175222 as several layout tests are
crashing on the bots without them. At least the Pair pointer can be
null according to the assertion hits on the bots.

css/StyleBuilderConverter.h:

(WebCore::StyleBuilderConverter::convertRadius):

12:43 PM Changeset in webkit [175227] by ap@apple.com

2 edits in trunk/LayoutTests

Add [ Yosemite ] modifier to a couple of tests in section 7.

These two tests fail with PPT, so they are expected to pass on 10.8. Our current
approach is a have separate sections for Mavericks and Yosemite, even for PPT
specific failures that affect both.

platform/mac-wk2/TestExpectations:

12:31 PM Changeset in webkit [175226] by bshafiei@apple.com

2 edits in branches/safari-600.1.4.12-branch/Source/WebCore

Merged r175158. rdar://problem/18571212

12:03 PM Changeset in webkit [175225] by bshafiei@apple.com

2 edits in branches/safari-600.1.4.12-branch/Source/WebKit2

Merged r175157. rdar://problem/18739335

12:01 PM Changeset in webkit [175224] by bshafiei@apple.com

4 edits in branches/safari-600.1.4.12-branch/Source/WebKit2

Merged r175153. rdar://problem/18739335

11:31 AM Changeset in webkit [175223] by Stephanie Lewis

2 edits in trunk/LayoutTests

http/tests/cookies/third-party-cookie-relaxing.html is flaky on bots.
https://bugs.webkit.org/show_bug.cgi?id=138098.

Updated Expectations.

platform/mac-wk1/TestExpectations:

11:26 AM Changeset in webkit [175222] by Chris Dumez

4 edits in trunk/Source/WebCore

Move radius CSS properties to the new StyleBuilder
https://bugs.webkit.org/show_bug.cgi?id=138087

Reviewed by Andreas Kling.

Move radius CSS properties from DeprecatedStyleBuilder to the new
StyleBuilder so that they are now generated from CSSPropertyNames.in.

No new tests, no behavior change.

css/CSSPropertyNames.in:
css/DeprecatedStyleBuilder.cpp:

(WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder):
(WebCore::ApplyPropertyBorderRadius::setValue): Deleted.
(WebCore::ApplyPropertyBorderRadius::applyValue): Deleted.
(WebCore::ApplyPropertyBorderRadius::createHandler): Deleted.

css/StyleBuilderConverter.h:

(WebCore::StyleBuilderConverter::convertRadius):

11:06 AM Changeset in webkit [175221] by zandobersek@gmail.com

3 edits in trunk/Source/WebCore

Shrink MathMLOperatorDictionary::dictionary table
https://bugs.webkit.org/show_bug.cgi?id=137914

Reviewed by Darin Adler.

Improve packing of the Entry structure that's used for elements
of the MathMLOperatorDictionary::dictionary table. This drops the
size of the struct from 16 bytes to just 4 bytes, and shrinks the
size of the dictionary table from rougly 16 kB down to 4 kB.

rendering/mathml/RenderMathMLOperator.cpp:

(WebCore::MathMLOperatorDictionary::ExtractKey):
(WebCore::RenderMathMLOperator::setOperatorProperties):

rendering/mathml/RenderMathMLOperator.h:

10:33 AM Changeset in webkit [175220] by commit-queue@webkit.org

1 edit
54 deletes in trunk/LayoutTests

Some test for multicol were redundant.
https://bugs.webkit.org/show_bug.cgi?id=133084

Patch by Piotr Grad <p.grad@samsung.com> on 2014-10-27
Reviewed by Andreas Kling.

fast/multicol/newmulticol/compare-with-old-impl/anonymous-block-split-crash-expected.txt: Removed.
fast/multicol/newmulticol/compare-with-old-impl/anonymous-block-split-crash.html: Removed.
fast/multicol/newmulticol/compare-with-old-impl/clone-before-after-content-crash-expected.txt: Removed.
fast/multicol/newmulticol/compare-with-old-impl/clone-before-after-content-crash.html: Removed.
fast/multicol/newmulticol/compare-with-old-impl/clone-block-children-inline-mismatch-crash-expected.txt: Removed.
fast/multicol/newmulticol/compare-with-old-impl/clone-block-children-inline-mismatch-crash.html: Removed.
fast/multicol/newmulticol/compare-with-old-impl/clone-flexbox-expected.txt: Removed.
fast/multicol/newmulticol/compare-with-old-impl/clone-flexbox.html: Removed.
fast/multicol/newmulticol/compare-with-old-impl/continuation-crash-expected.txt: Removed.
fast/multicol/newmulticol/compare-with-old-impl/continuation-crash.html: Removed.
fast/multicol/newmulticol/compare-with-old-impl/double-merge-anonymous-block-crash-expected.txt: Removed.
fast/multicol/newmulticol/compare-with-old-impl/double-merge-anonymous-block-crash.html: Removed.
fast/multicol/newmulticol/compare-with-old-impl/empty-anonymous-block-split-crash-expected.txt: Removed.
fast/multicol/newmulticol/compare-with-old-impl/empty-anonymous-block-split-crash.html: Removed.
fast/multicol/newmulticol/compare-with-old-impl/float-not-removed-crash-expected.txt: Removed.
fast/multicol/newmulticol/compare-with-old-impl/float-not-removed-crash.html: Removed.
fast/multicol/newmulticol/compare-with-old-impl/hit-test-above-or-below-expected.txt: Removed.
fast/multicol/newmulticol/compare-with-old-impl/hit-test-above-or-below.html: Removed.
fast/multicol/newmulticol/compare-with-old-impl/hit-test-block-axis-flipped-expected.txt: Removed.
fast/multicol/newmulticol/compare-with-old-impl/hit-test-block-axis-flipped.html: Removed.
fast/multicol/newmulticol/compare-with-old-impl/hit-test-end-of-column-expected.txt: Removed.
fast/multicol/newmulticol/compare-with-old-impl/hit-test-end-of-column.html: Removed.
fast/multicol/newmulticol/compare-with-old-impl/hit-test-float-expected.txt: Removed.
fast/multicol/newmulticol/compare-with-old-impl/hit-test-float.html: Removed.
fast/multicol/newmulticol/compare-with-old-impl/hit-test-gap-between-pages-expected.txt: Removed.
fast/multicol/newmulticol/compare-with-old-impl/hit-test-gap-between-pages-flipped-expected.txt: Removed.
fast/multicol/newmulticol/compare-with-old-impl/hit-test-gap-between-pages-flipped.html: Removed.
fast/multicol/newmulticol/compare-with-old-impl/hit-test-gap-between-pages.html: Removed.
fast/multicol/newmulticol/compare-with-old-impl/hit-test-gap-block-axis-expected.txt: Removed.
fast/multicol/newmulticol/compare-with-old-impl/hit-test-gap-block-axis.html: Removed.
fast/multicol/newmulticol/compare-with-old-impl/list-multi-column-crash-expected.txt: Removed.
fast/multicol/newmulticol/compare-with-old-impl/list-multi-column-crash.html: Removed.
fast/multicol/newmulticol/compare-with-old-impl/multicol-with-child-renderLayer-for-input-expected.html: Removed.
fast/multicol/newmulticol/compare-with-old-impl/multicol-with-child-renderLayer-for-input.html: Removed.
fast/multicol/newmulticol/compare-with-old-impl/positioned-child-not-removed-crash-expected.txt: Removed.
fast/multicol/newmulticol/compare-with-old-impl/positioned-child-not-removed-crash.html: Removed.
fast/multicol/newmulticol/compare-with-old-impl/positioned-objects-not-removed-crash-expected.txt: Removed.
fast/multicol/newmulticol/compare-with-old-impl/positioned-objects-not-removed-crash.html: Removed.
fast/multicol/newmulticol/compare-with-old-impl/recursive-split-flow-crash-expected.txt: Removed.
fast/multicol/newmulticol/compare-with-old-impl/recursive-split-flow-crash.html: Removed.
fast/multicol/newmulticol/compare-with-old-impl/removal-of-multicol-span-crash-expected.txt: Removed.
fast/multicol/newmulticol/compare-with-old-impl/removal-of-multicol-span-crash.html: Removed.
fast/multicol/newmulticol/compare-with-old-impl/remove-child-split-flow-crash-expected.txt: Removed.
fast/multicol/newmulticol/compare-with-old-impl/remove-child-split-flow-crash.html: Removed.
fast/multicol/newmulticol/compare-with-old-impl/split-flow-anonymous-wrapper-crash-expected.txt: Removed.
fast/multicol/newmulticol/compare-with-old-impl/split-flow-anonymous-wrapper-crash.html: Removed.
fast/multicol/newmulticol/compare-with-old-impl/split-inline-wrong-post-block-crash-expected.txt: Removed.
fast/multicol/newmulticol/compare-with-old-impl/split-inline-wrong-post-block-crash.html: Removed.
fast/multicol/newmulticol/compare-with-old-impl/table-multi-column-crash-expected.txt: Removed.
fast/multicol/newmulticol/compare-with-old-impl/table-multi-column-crash.html: Removed.
fast/multicol/newmulticol/compare-with-old-impl/textbox-not-removed-crash-expected.txt: Removed.
fast/multicol/newmulticol/compare-with-old-impl/textbox-not-removed-crash.html: Removed.
fast/multicol/newmulticol/compare-with-old-impl/update-after-content-before-child-crash-expected.txt: Removed.
fast/multicol/newmulticol/compare-with-old-impl/update-after-content-before-child-crash.html: Removed.

10:20 AM Changeset in webkit [175219] by akling@apple.com

3 edits in trunk/Source/WebCore

Move canContainFixedPositionObjects() to RenderElement.
<https://webkit.org/b/138088>

Reviewed by Mihnea Ovidenie.

Only RenderElement can contain other renderers, so it's not really
natural to answer this question on RenderObject anyway.

Moving it to RenderElement lets it access more efficient getters
that don't have to handle the RenderText case.

rendering/RenderElement.h:

(WebCore::RenderElement::canContainFixedPositionObjects):

rendering/RenderObject.h:

(WebCore::RenderObject::canContainFixedPositionObjects): Deleted.

10:08 AM Changeset in webkit [175218] by ap@apple.com

2 edits in trunk/LayoutTests

media/track/audio-track.html is flaky on Yosemite
https://bugs.webkit.org/show_bug.cgi?id=137882

platform/mac/TestExpectations: Marking it as such.

9:31 AM Changeset in webkit [175217] by bshafiei@apple.com

2 edits in branches/safari-600.1.4.12-branch/Source/WebKit2

Merged r175145. rdar://problem/18376333

1:09 AM Changeset in webkit [175216] by bshafiei@apple.com

2 edits in branches/safari-600.1.4.12-branch/Source/WebKit2

Merged r175143. rdar://problem/18692335

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed