Context Navigation

← Previous Period
Next Period →

Timeline

Nov 6, 2014:

11:22 PM Changeset in webkit [175743] by Carlos Garcia Campos

3 edits in trunk/Source/WebCore

Unreviewed. Try to fix GTK build after r175719.

Rename the Timer fired function as requestAnimationTimerFired() to
avoid ambiguity.

platform/ScrollAnimatorNone.cpp:

(WebCore::ScrollAnimatorNone::ScrollAnimatorNone):
(WebCore::ScrollAnimatorNone::requestAnimationTimerFired):
(WebCore::ScrollAnimatorNone::animationTimerFired): Deleted.

platform/ScrollAnimatorNone.h:

9:53 PM Changeset in webkit [175742] by Chris Dumez

2 edits in trunk/Source/WebCore

Remove useless if check in HTMLInputElement::setValue()
https://bugs.webkit.org/show_bug.cgi?id=138485

Reviewed by Daniel Bates.

Remove useless if check in HTMLInputElement::setValue(). It was
inadvertently left in as part of r94836.

html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::setValue):

8:52 PM Changeset in webkit [175741] by Simon Fraser

3 edits in trunk/Source/WebCore

Put names on a couple of video-related CALayers
https://bugs.webkit.org/show_bug.cgi?id=138491

Reviewed by Eric Carlson.

In debug, set layer names on a couple of video-related layers to make
debugging easier.

platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerLayer):

platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:

(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::ensureLayer):

7:16 PM Changeset in webkit [175740] by Darin Adler

5 edits in trunk

REGRESSION (r175549): http/tests/multipart/stop-crash.html failing (assertion failure in CachedResource::setEncodedSize)
https://bugs.webkit.org/show_bug.cgi?id=138358

Reviewed by Alexey Proskuryakov.

Source/WebCore:

loader/cache/CachedResource.cpp:

(WebCore::CachedResource::setEncodedSize): Removed the incorrect assertion here.
The code asserts that resources only get bigger, never smaller. This is incorrect
for a multipart/mixed-replace image, where a later image that is smaller can replace
an earlier one. I don't fully understand why this assertion was not firing before,
but the relevant websites are working fine and the test otherwise passes.

loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::subresourceLoaderFinishedLoadingOnePart): Fix another
incorrect assertion that can fire for any parts after the first one. I ran into
this while testing various websites that use multipart/mixed-replace.

LayoutTests:

TestExpectations: Turn the test back on.

7:04 PM Changeset in webkit [175739] by matthew_hanson@apple.com

5 edits in branches/safari-600.2-branch/Source

Versioning.

6:56 PM Changeset in webkit [175738] by matthew_hanson@apple.com

1 copy in tags/Safari-600.2.1

New Tag.

6:56 PM Changeset in webkit [175737] by matthew_hanson@apple.com

5 edits in branches/safari-600.2-branch/Source

Versioning.

6:51 PM Changeset in webkit [175736] by matthew_hanson@apple.com

2 edits in branches/safari-600.2-branch/Source/JavaScriptCore

Rollout r173238. rdar://problem/18495806

6:27 PM Changeset in webkit [175735] by commit-queue@webkit.org

8 edits in trunk/Tools

Remove duplicate code from PatchAnalysisTask._test_patch and fix bug
regarding incorrect call to PatchAnalysisTask.report_failure
https://bugs.webkit.org/show_bug.cgi?id=138229

Patch by Jake Nielsen <jacob_nielsen@apple.com> on 2014-11-06
Reviewed by Daniel Bates.

Scripts/webkitpy/common/net/layouttestresults.py:

Makes sure test_results returns a list.
(LayoutTestResults.test_results):

Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:

Makes unit tests also check to make sure
task.results_from_patch_test_run() and
task.results_from_test_run_without_patch return instances of
LayoutTestResults.
(CommitQueueTaskTest._run_and_expect_patch_analysis_result):

Scripts/webkitpy/tool/bot/patchanalysistask.py:

Condenses duplicate code into _should_defer_patch_or_throw, and
removes the now-unused _clean_tree_results member.
(PatchAnalysisTask.init):
(PatchAnalysisTask._continue_testing_patch_that_exceeded_failure_limit_on_first_or_second_try):
(PatchAnalysisTask._should_defer_patch_or_throw):
(PatchAnalysisTask._test_patch):
(PatchAnalysisTask.results_from_patch_test_run):
(PatchAnalysisTask.results_from_test_run_without_patch): Deleted.

Scripts/webkitpy/tool/commands/earlywarningsystem.py:

Removes needless call to results_from_test_run_without_patch
(AbstractEarlyWarningSystem._failing_tests_message):

Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:

Changes order of test failure messages to be in the order that they
appear.
(AbstractEarlyWarningSystemTest.test_failing_tests_message):

Scripts/webkitpy/tool/commands/queues.py:

Removes needless call to results_from_test_run_without_patch.
(CommitQueue._failing_tests_message):

Scripts/webkitpy/tool/commands/queues_unittest.py:

(MockCommitQueueTask.results_from_test_run_without_patch): Deleted.

6:26 PM Changeset in webkit [175734] by dburkart@apple.com

5 edits in branches/safari-600.3-branch/Source

Version bump.

6:11 PM Changeset in webkit [175733] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/mac

Wrap the bulk of -[WebView dealloc] with an autorelease pool.
https://bugs.webkit.org/show_bug.cgi?id=138443

Patch by Daniel Jalkut <jalkut@red-sweater.com> on 2014-11-06
Reviewed by Anders Carlsson.

Wrapping the dealloc method in its own autorelease pool avoids the problem of
complex tear-downs leading to the WebView itself being added to an autorelease
pool that is not drained until after the instance has been dealloc'd.

WebView/WebView.mm:

(-[WebView dealloc]):

6:02 PM Changeset in webkit [175732] by commit-queue@webkit.org

4 edits in trunk/Source/WebKit2

Clients should be able to customize the view used for page previews
https://bugs.webkit.org/show_bug.cgi?id=138447

Patch by Conrad Shultz <Conrad Shultz> on 2014-11-06
Reviewed by Tim Horton.

Add SPI to WKView that clients can use to customize the view used in the page preview popover.

UIProcess/API/Cocoa/WKViewPrivate.h:

Declare -_viewForPreviewingURL:initialFrameSize:.

UIProcess/API/mac/WKView.mm:

(-[WKView _viewForPreviewingURL:initialFrameSize:]):
Return nil in the default implementation.

UIProcess/mac/WKActionMenuController.mm:

(-[WKPagePreviewViewController loadView]):
Only spin up a WKWebView if the delegate (and, therefore, the presenting WKView) doesn't supply a custom view.
(-[WKActionMenuController pagePreviewViewController:viewForPreviewingURL:initialFrameSize:]):
WKPagePreviewViewControllerDelegate method; wrap the WKView SPI.

5:14 PM Changeset in webkit [175731] by mark.lam@apple.com

3 edits in trunk/LayoutTests

Refactor the get-by-pname.js test [follow up 2].
<https://webkit.org/b/138483>

Reviewed by Michael Saboff.

Make unique copies of the test functions to ensure that each test case does not
affect the tiering up of other test cases.

js/get-by-pname-expected.txt:
js/script-tests/get-by-pname.js:

(foo): Deleted.
(getByPnameOnConstant): Deleted.
(getByPnameOnVar): Deleted.

4:53 PM Changeset in webkit [175730] by bshafiei@apple.com

2 edits in tags/Safari-601.1.8/Source/WebCore

Merged r175727. rdar://problem/18896362

4:49 PM Changeset in webkit [175729] by mark.lam@apple.com

2 edits in trunk/LayoutTests

Refactor the get-by-pname.js test [follow up].
<https://webkit.org/b/138483>

Reviewed by Michael Saboff.

Used named properties to make the test code more readable.

js/script-tests/get-by-pname.js:

(isTierIteration):
(tierName):
(testExpr): Deleted.
(testExpectedResult): Deleted.

4:34 PM Changeset in webkit [175728] by bshafiei@apple.com

2 edits in tags/Safari-601.1.8/Source/JavaScriptCore

Merged r175724. rdar://problem/18495847

4:27 PM Changeset in webkit [175727] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Fix typo in optimized fullscreen activation.
https://bugs.webkit.org/show_bug.cgi?id=138480

Patch by Jeremy Jones <jeremyj@apple.com> on 2014-11-06
Reviewed by Jer Noble.

Modules/mediacontrols/mediaControlsiOS.js:

(ControllerIOS.prototype.handleWrapperTouchStart): fix typo doubleTouchIntervalThresholdms
(ControllerIOS.prototype.handleOptimizedFullscreenButtonClicked): fix typo isFullScreen

4:24 PM Changeset in webkit [175726] by matthew_hanson@apple.com

3 edits
3 adds in branches/safari-600.2-branch

Merged r174740. rdar://problems/18883729

4:18 PM Changeset in webkit [175725] by ryuan.choi@navercorp.com

2 edits in trunk/Tools

Unreviewed. Reorder my e-mail addresses in contributors.json

Patch by Ryuan Choi <ryuan.choi@navercorp.com> on 2014-11-06

Scripts/webkitpy/common/config/contributors.json:

4:18 PM Changeset in webkit [175724] by mark.lam@apple.com

5 edits in trunk

slow_path_get_direct_pname() needs to be hardened against a constant baseValue.
<https://webkit.org/b/138476>

Reviewed by Michael Saboff.

Source/JavaScriptCore:

slow_path_get_direct_pname() currently assumes that the baseValue is always a
non-constant virtual register. However, this is not always the case like in the
following:

function foo() {

var o = { a:1 };
for (var n in o)

0[n];

}
foo();

This patch fixes it to also check for constant virtual register indexes.

runtime/CommonSlowPaths.cpp:

(JSC::SLOW_PATH_DECL):

LayoutTests:

js/get-by-pname-expected.txt:
js/script-tests/get-by-pname.js:

(getByPnameOnConstant):
(getByPnameOnVar):

Added more test cases.

4:02 PM Changeset in webkit [175723] by matthew_hanson@apple.com

4 edits in branches/safari-600.2-branch/Source/WebCore

Merged r175375. rdar://problems/18883734

3:53 PM Changeset in webkit [175722] by mark.lam@apple.com

3 edits in trunk/LayoutTests

Refactor the get-by-pname.js test.
<https://webkit.org/b/138483>

Reviewed by Geoffrey Garen.

Refactored the test code to:

make it easier to add more test cases.
test each case against different tier JITs.
print only one set of results for each tier being tested.

js/get-by-pname-expected.txt:
js/script-tests/get-by-pname.js:

(getByPnameOnConstant):
(getByPnameOnVar):
(testExpr):
(testExpectedResult):
(isTierIteration):
(tierName):

3:20 PM Changeset in webkit [175721] by Bem Jones-Bey

14 edits
11 adds
10 deletes in trunk/LayoutTests

[CSS Shapes] the spec-examples reftests are off by a few pixels
https://bugs.webkit.org/show_bug.cgi?id=135927

Reviewed by Zoltan Horvath.

Import new versions of the spec example tests that are js tests
instead of ref tests so that they can properly handle the small pixel
differences in rendering between platforms.

TestExpectations:
css3/shapes/spec-examples/shape-outside-010-expected.html: Removed.
css3/shapes/spec-examples/shape-outside-010-expected.txt: Added.
css3/shapes/spec-examples/shape-outside-010.html:
css3/shapes/spec-examples/shape-outside-011-expected.html: Removed.
css3/shapes/spec-examples/shape-outside-011-expected.txt: Added.
css3/shapes/spec-examples/shape-outside-011.html:
css3/shapes/spec-examples/shape-outside-012-expected.html: Removed.
css3/shapes/spec-examples/shape-outside-012-expected.txt: Added.
css3/shapes/spec-examples/shape-outside-012.html:
css3/shapes/spec-examples/shape-outside-013-expected.html: Removed.
css3/shapes/spec-examples/shape-outside-013-expected.txt: Added.
css3/shapes/spec-examples/shape-outside-013.html:
css3/shapes/spec-examples/shape-outside-014-expected.html: Removed.
css3/shapes/spec-examples/shape-outside-014-expected.txt: Added.
css3/shapes/spec-examples/shape-outside-014.html:
css3/shapes/spec-examples/shape-outside-015-expected.html: Removed.
css3/shapes/spec-examples/shape-outside-015-expected.txt: Added.
css3/shapes/spec-examples/shape-outside-015.html:
css3/shapes/spec-examples/shape-outside-016-expected.html: Removed.
css3/shapes/spec-examples/shape-outside-016-expected.txt: Added.
css3/shapes/spec-examples/shape-outside-016.html:
css3/shapes/spec-examples/shape-outside-017-expected.html: Removed.
css3/shapes/spec-examples/shape-outside-017-expected.txt: Added.
css3/shapes/spec-examples/shape-outside-017.html:
css3/shapes/spec-examples/shape-outside-018-expected.html: Removed.
css3/shapes/spec-examples/shape-outside-018-expected.txt: Added.
css3/shapes/spec-examples/shape-outside-018.html:
css3/shapes/spec-examples/shape-outside-019-expected.html: Removed.
css3/shapes/spec-examples/shape-outside-019-expected.txt: Added.
css3/shapes/spec-examples/shape-outside-019.html:
css3/shapes/spec-examples/support/spec-example-utils.js: Added.

(.runTest):
(approxShapeTest):

css3/shapes/spec-examples/support/w3c-import.log:
css3/shapes/spec-examples/w3c-import.log:

3:17 PM Changeset in webkit [175720] by Chris Dumez

8 edits
2 adds in trunk/Source/WebCore

Stop special-casing wbr elements in HTMLElement::createElementRenderer()
https://bugs.webkit.org/show_bug.cgi?id=138474

Reviewed by Ryosuke Niwa.

Stop special-casing wbr elements in HTMLElement::createElementRenderer()
and move the code to a HTMLWBRElement subclass instead, that is
overriding createElementRenderer(). This function is already virtual.

No new tests, no behavior change.

CMakeLists.txt:
WebCore.vcxproj/WebCore.vcxproj:
WebCore.xcodeproj/project.pbxproj:
html/HTMLElement.cpp:

(WebCore::HTMLElement::createElementRenderer):

html/HTMLElementsAllInOne.cpp:
html/HTMLTagNames.in:
html/HTMLWBRElement.cpp: Added.

(WebCore::HTMLWBRElement::create):
(WebCore::HTMLWBRElement::HTMLWBRElement):
(WebCore::HTMLWBRElement::createElementRenderer):

html/HTMLWBRElement.h: Added.
rendering/RenderLineBreak.cpp:

(WebCore::RenderLineBreak::RenderLineBreak):

3:06 PM Changeset in webkit [175719] by jer.noble@apple.com

277 edits in trunk/Source

De-templatize Timer
https://bugs.webkit.org/show_bug.cgi?id=138450

Reviewed by Anders Carlsson.

Source/WebCore:

Timer does not need to be a templated class; only it's constructors need to be templated.
Remove the template specifier from Timer and add same to its two class method
constructors. Replace the function pointer typedefs with using statements. Add a
helper typedef which allows invalid combinations of TimerFiredClass and
TimerFiredFunction to be caught early by the compiler, while still allowing
valid combinations (such as when the caller specifies a function on a subclass of
TimerFiredClass).

Modules/encryptedmedia/MediaKeySession.cpp:

(WebCore::MediaKeySession::keyRequestTimerFired):
(WebCore::MediaKeySession::addKeyTimerFired):

Modules/encryptedmedia/MediaKeySession.h:
Modules/geolocation/Geolocation.cpp:

(WebCore::Geolocation::GeoNotifier::timerFired):
(WebCore::Geolocation::resumeTimerFired):

Modules/geolocation/Geolocation.h:
Modules/indexeddb/IDBTransactionBackend.cpp:

(WebCore::IDBTransactionBackend::taskTimerFired):

Modules/indexeddb/IDBTransactionBackend.h:
Modules/mediasource/SourceBuffer.cpp:

(WebCore::SourceBuffer::appendBufferTimerFired):
(WebCore::SourceBuffer::removeTimerFired):

Modules/mediasource/SourceBuffer.h:
Modules/mediastream/MediaStream.cpp:

(WebCore::MediaStream::scheduledEventTimerFired):

Modules/mediastream/MediaStream.h:
Modules/mediastream/RTCDTMFSender.cpp:

(WebCore::RTCDTMFSender::scheduledEventTimerFired):

Modules/mediastream/RTCDTMFSender.h:
Modules/mediastream/RTCDataChannel.cpp:

(WebCore::RTCDataChannel::scheduledEventTimerFired):

Modules/mediastream/RTCDataChannel.h:
Modules/mediastream/RTCPeerConnection.cpp:

(WebCore::RTCPeerConnection::scheduledEventTimerFired):

Modules/mediastream/RTCPeerConnection.h:
Modules/notifications/Notification.cpp:

(WebCore::Notification::Notification):
(WebCore::Notification::taskTimerFired):

Modules/notifications/Notification.h:
Modules/notifications/NotificationCenter.cpp:

(WebCore::NotificationCenter::NotificationRequestCallback::timerFired):

Modules/notifications/NotificationCenter.h:
Modules/vibration/Vibration.cpp:

(WebCore::Vibration::timerFired):

Modules/vibration/Vibration.h:
Modules/websockets/WebSocketChannel.cpp:

(WebCore::WebSocketChannel::resumeTimerFired):
(WebCore::WebSocketChannel::closingTimerFired):

Modules/websockets/WebSocketChannel.h:
accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::notificationPostTimerFired):

accessibility/AXObjectCache.h:

(WebCore::AXObjectCache::AXObjectCache):

bindings/js/GCController.cpp:

(WebCore::GCController::gcTimerFired):

bindings/js/GCController.h:
css/CSSFontFaceSource.h:
css/CSSFontSelector.cpp:

(WebCore::CSSFontSelector::beginLoadTimerFired):

css/CSSFontSelector.h:
css/StyleResolver.cpp:

(WebCore::StyleResolver::sweepMatchedPropertiesCache):

css/StyleResolver.h:
dom/Document.cpp:

(WebCore::Document::visualUpdatesSuppressionTimerFired):
(WebCore::Document::styleRecalcTimerFired):
(WebCore::Document::optimizedStyleSheetUpdateTimerFired):
(WebCore::Document::sharedObjectPoolClearTimerFired):
(WebCore::Document::updateFocusAppearanceTimerFired):
(WebCore::Document::pendingTasksTimerFired):
(WebCore::Document::fullScreenChangeDelayTimerFired):
(WebCore::Document::loadEventDelayTimerFired):
(WebCore::Document::didAssociateFormControlsTimerFired):
(WebCore::Document::domCookieCacheExpiryTimerFired):

dom/Document.h:
dom/EventSender.h:

(WebCore::EventSender::timerFired):

dom/GenericEventQueue.cpp:

(WebCore::GenericEventQueue::timerFired):

dom/GenericEventQueue.h:
dom/ScriptRunner.cpp:

(WebCore::ScriptRunner::timerFired):

dom/ScriptRunner.h:
dom/ScriptedAnimationController.cpp:

(WebCore::ScriptedAnimationController::animationTimerFired):

dom/ScriptedAnimationController.h:
dom/StyledElement.cpp:

(WebCore::PresentationAttributeCacheCleaner::cleanCache):

editing/AlternativeTextController.cpp:

(WebCore::AlternativeTextController::timerFired):

editing/AlternativeTextController.h:
editing/Editor.cpp:

(WebCore::Editor::scanSelectionForTelephoneNumbers):
(WebCore::Editor::editorUIUpdateTimerFired):

editing/Editor.h:
editing/FrameSelection.cpp:

(WebCore::FrameSelection::caretBlinkTimerFired):

editing/FrameSelection.h:
editing/SpellChecker.cpp:

(WebCore::SpellChecker::timerFiredToProcessQueuedRequest):

editing/SpellChecker.h:
html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::requestAutocompleteTimerFired):

html/HTMLFormElement.h:
html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::parseAttribute):

html/HTMLMediaElement.h:
html/HTMLPlugInElement.cpp:

(WebCore::HTMLPlugInElement::swapRendererTimerFired):

html/HTMLPlugInElement.h:
html/HTMLPlugInImageElement.cpp:

(WebCore::HTMLPlugInImageElement::removeSnapshotTimerFired):

html/HTMLPlugInImageElement.h:
html/HTMLSourceElement.cpp:

(WebCore::HTMLSourceElement::errorEventTimerFired):

html/HTMLSourceElement.h:
html/HTMLTrackElement.cpp:

(WebCore::HTMLTrackElement::loadTimerFired):

html/HTMLTrackElement.h:
html/MediaController.cpp:

(MediaController::asyncEventTimerFired):
(MediaController::clearPositionTimerFired):
(MediaController::timeupdateTimerFired):

html/MediaController.h:
html/MediaDocument.cpp:

(WebCore::MediaDocument::replaceMediaElementTimerFired):

html/MediaDocument.h:
html/SearchInputType.cpp:

(WebCore::SearchInputType::searchEventTimerFired):

html/SearchInputType.h:
html/ValidationMessage.cpp:

(WebCore::ValidationMessage::setMessage):
(WebCore::ValidationMessage::setMessageDOMAndStartTimer):
(WebCore::ValidationMessage::buildBubbleTree):
(WebCore::ValidationMessage::requestToHideMessage):
(WebCore::ValidationMessage::deleteBubbleTree):

html/ValidationMessage.h:
html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::dispatchContextLostEvent):
(WebCore::WebGLRenderingContext::maybeRestoreContext):

html/canvas/WebGLRenderingContext.h:
html/parser/HTMLParserScheduler.cpp:

(WebCore::HTMLParserScheduler::continueNextChunkTimerFired):

html/parser/HTMLParserScheduler.h:
html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlPanelElement::transitionTimerFired):
(WebCore::MediaControlTextTrackContainerElement::updateTimerFired):

html/shadow/MediaControlElements.h:
html/shadow/MediaControls.cpp:

(WebCore::MediaControls::hideFullscreenControlsTimerFired):

html/shadow/MediaControls.h:
html/shadow/SpinButtonElement.cpp:

(WebCore::SpinButtonElement::repeatingTimerFired):

html/shadow/SpinButtonElement.h:
html/track/LoadableTextTrack.cpp:

(WebCore::LoadableTextTrack::loadTimerFired):

html/track/LoadableTextTrack.h:
html/track/VTTRegion.cpp:

(WebCore::VTTRegion::scrollTimerFired):

html/track/VTTRegion.h:
inspector/InspectorCSSAgent.cpp:

(WebCore::ChangeRegionOversetTask::timerFired):

inspector/InspectorDOMAgent.cpp:

(WebCore::RevalidateStyleAttributeTask::timerFired):

inspector/InspectorFrontendClientLocal.cpp:

(WebCore::InspectorBackendDispatchTask::timerFired):

inspector/InspectorOverlay.cpp:

(WebCore::InspectorOverlay::updatePaintRectsTimerFired):

inspector/InspectorOverlay.h:
loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::substituteResourceDeliveryTimerFired):

loader/DocumentLoader.h:
loader/FrameLoader.cpp:

(WebCore::FrameLoader::checkTimerFired):

loader/FrameLoader.h:
loader/ImageLoader.cpp:

(WebCore::ImageLoader::timerFired):

loader/ImageLoader.h:
loader/LinkLoader.cpp:

(WebCore::LinkLoader::linkLoadTimerFired):
(WebCore::LinkLoader::linkLoadingErrorTimerFired):

loader/LinkLoader.h:
loader/NavigationScheduler.cpp:

(WebCore::ScheduledNavigation::didStartTimer):
(WebCore::NavigationScheduler::timerFired):

loader/NavigationScheduler.h:
loader/PingLoader.h:

(WebCore::PingLoader::timeoutTimerFired):

loader/ProgressTracker.cpp:

(WebCore::ProgressTracker::progressHeartbeatTimerFired):

loader/ProgressTracker.h:
loader/ResourceLoadScheduler.cpp:

(WebCore::ResourceLoadScheduler::requestTimerFired):

loader/ResourceLoadScheduler.h:
loader/TextTrackLoader.cpp:

(WebCore::TextTrackLoader::cueLoadTimerFired):

loader/TextTrackLoader.h:
loader/cache/CachedResource.cpp:

(WebCore::CachedResource::Callback::timerFired):

loader/cache/CachedResource.h:
loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::garbageCollectDocumentResourcesTimerFired):

loader/cache/CachedResourceLoader.h:
loader/icon/IconDatabase.cpp:

(WebCore::IconDatabase::syncTimerFired):

loader/icon/IconDatabase.h:
page/AutoscrollController.cpp:

(WebCore::AutoscrollController::autoscrollTimerFired):

page/AutoscrollController.h:
page/CaptionUserPreferences.cpp:

(WebCore::CaptionUserPreferences::timerFired):

page/CaptionUserPreferences.h:
page/CaptionUserPreferencesMediaAF.cpp:

(WebCore::CaptionUserPreferencesMediaAF::updateTimerFired):

page/CaptionUserPreferencesMediaAF.h:
page/DeviceController.cpp:

(WebCore::DeviceController::fireDeviceEvent):

page/DeviceController.h:
page/EventHandler.cpp:

(WebCore::EventHandler::cursorUpdateTimerFired):
(WebCore::EventHandler::autoHideCursorTimerFired):
(WebCore::EventHandler::recognizeLongMousePress):
(WebCore::EventHandler::fakeMouseMoveEventTimerFired):
(WebCore::EventHandler::hoverTimerFired):

page/EventHandler.h:
page/EventSource.cpp:

(WebCore::EventSource::connectTimerFired):

page/EventSource.h:
page/FocusController.cpp:

(WebCore::FocusController::focusRepaintTimerFired):

page/FocusController.h:
page/Frame.cpp:

(WebCore::Frame::overflowAutoScrollTimerFired):

page/Frame.h:
page/FrameView.cpp:

(WebCore::FrameView::delayedScrollEventTimerFired):
(WebCore::FrameView::speculativeTilingEnableTimerFired):
(WebCore::FrameView::layoutTimerFired):
(WebCore::FrameView::updateEmbeddedObjectsTimerFired):
(WebCore::FrameView::postLayoutTimerFired):

page/FrameView.h:
page/PageOverlay.cpp:

(WebCore::PageOverlay::fadeAnimationTimerFired):

page/PageOverlay.h:
page/Settings.cpp:

(WebCore::Settings::imageLoadingSettingsTimerFired):

page/Settings.h:
page/animation/AnimationController.cpp:

(WebCore::AnimationControllerPrivate::updateStyleIfNeededDispatcherFired):
(WebCore::AnimationControllerPrivate::animationTimerFired):

page/animation/AnimationControllerPrivate.h:
page/mac/ServicesOverlayController.h:
page/mac/ServicesOverlayController.mm:

(WebCore::ServicesOverlayController::determineActiveHighlightTimerFired):

page/scrolling/AsyncScrollingCoordinator.cpp:

(WebCore::AsyncScrollingCoordinator::updateScrollPositionAfterAsyncScrollTimerFired):

page/scrolling/AsyncScrollingCoordinator.h:
page/scrolling/ios/ScrollingCoordinatorIOS.h:
page/scrolling/ios/ScrollingCoordinatorIOS.mm:

(WebCore::ScrollingCoordinatorIOS::scrollingStateTreeCommitterTimerFired):

page/scrolling/mac/ScrollingCoordinatorMac.h:
page/scrolling/mac/ScrollingCoordinatorMac.mm:

(WebCore::ScrollingCoordinatorMac::scrollingStateTreeCommitterTimerFired):

platform/HysteresisActivity.h:

(WebCore::HysteresisActivity::hysteresisTimerFired):

platform/ScrollAnimator.cpp:

(WebCore::ScrollAnimator::updateScrollAnimatorsAndTimers):
(WebCore::ScrollAnimator::startScrollSnapTimer):
(WebCore::ScrollAnimator::stopScrollSnapTimer):
(WebCore::ScrollAnimator::horizontalScrollSnapTimerFired):
(WebCore::ScrollAnimator::verticalScrollSnapTimerFired):

platform/ScrollAnimator.h:
platform/ScrollAnimatorNone.cpp:

(WebCore::ScrollAnimatorNone::animationTimerFired):

platform/ScrollAnimatorNone.h:
platform/Scrollbar.cpp:

(WebCore::Scrollbar::autoscrollTimerFired):

platform/Scrollbar.h:
platform/Timer.h:

(WebCore::Timer::Timer):

platform/audio/MediaSession.cpp:

(WebCore::MediaSession::clientDataBufferingTimerFired):

platform/audio/MediaSession.h:
platform/efl/BatteryProviderEfl.cpp:

(WebCore::BatteryProviderEfl::timerFired):

platform/efl/BatteryProviderEfl.h:
platform/graphics/BitmapImage.cpp:

(WebCore::BitmapImage::startAnimation):
(WebCore::BitmapImage::advanceAnimation):

platform/graphics/BitmapImage.h:
platform/graphics/MediaPlayer.cpp:

(WebCore::MediaPlayer::reloadTimerFired):

platform/graphics/MediaPlayer.h:
platform/graphics/ShadowBlur.cpp:

(WebCore::ScratchBuffer::timerFired):

platform/graphics/TiledBackingStore.cpp:

(WebCore::TiledBackingStore::tileBufferUpdateTimerFired):
(WebCore::TiledBackingStore::backingStoreUpdateTimerFired):

platform/graphics/TiledBackingStore.h:
platform/graphics/avfoundation/MediaSelectionGroupAVFObjC.h:
platform/graphics/avfoundation/MediaSelectionGroupAVFObjC.mm:

(WebCore::MediaSelectionGroupAVFObjC::selectionTimerFired):

platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h:
platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:

(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::seekTimerFired):

platform/graphics/ca/LayerPool.cpp:

(WebCore::LayerPool::pruneTimerFired):

platform/graphics/ca/LayerPool.h:
platform/graphics/ca/TileController.cpp:

(WebCore::TileController::tileRevalidationTimerFired):

platform/graphics/ca/TileController.h:
platform/graphics/ca/TileGrid.cpp:

(WebCore::TileGrid::cohortRemovalTimerFired):

platform/graphics/ca/TileGrid.h:
platform/graphics/ca/win/LegacyCACFLayerTreeHost.cpp:

(WebCore::LegacyCACFLayerTreeHost::renderTimerFired):

platform/graphics/ca/win/LegacyCACFLayerTreeHost.h:
platform/graphics/cg/IOSurfacePool.cpp:

(WebCore::IOSurfacePool::collectionTimerFired):

platform/graphics/cg/IOSurfacePool.h:
platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::fillTimerFired):

platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
platform/graphics/mac/MediaPlayerPrivateQTKit.h:
platform/graphics/mac/MediaPlayerPrivateQTKit.mm:

(WebCore::MediaPlayerPrivateQTKit::seekTimerFired):

platform/graphics/texmap/TextureMapper.cpp:

(WebCore::BitmapTexturePool::releaseUnusedTexturesTimerFired):

platform/graphics/texmap/coordinated/CompositingCoordinator.cpp:

(WebCore::CompositingCoordinator::releaseInactiveAtlasesTimerFired):

platform/graphics/texmap/coordinated/CompositingCoordinator.h:
platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:

(WebCore::CoordinatedGraphicsLayer::animationStartedTimerFired):

platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h:
platform/graphics/texmap/coordinated/CoordinatedImageBacking.cpp:

(WebCore::CoordinatedImageBacking::clearContentsTimerFired):

platform/graphics/texmap/coordinated/CoordinatedImageBacking.h:
platform/ios/LegacyTileCache.h:
platform/ios/LegacyTileCache.mm:

(WebCore::LegacyTileCache::tileCreationTimerFired):

platform/mac/HIDGamepadProvider.cpp:

(WebCore::HIDGamepadProvider::connectionDelayTimerFired):
(WebCore::HIDGamepadProvider::inputNotificationTimerFired):

platform/mac/HIDGamepadProvider.h:
platform/mac/ScrollAnimatorMac.h:
platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::snapRubberBandTimerFired):
(WebCore::ScrollAnimatorMac::initialScrollbarPaintTimerFired):
(WebCore::ScrollAnimatorMac::sendContentAreaScrolledTimerFired):

platform/mock/DeviceMotionClientMock.cpp:

(WebCore::DeviceMotionClientMock::timerFired):

platform/mock/DeviceMotionClientMock.h:
platform/mock/DeviceOrientationClientMock.cpp:

(WebCore::DeviceOrientationClientMock::timerFired):

platform/mock/DeviceOrientationClientMock.h:
platform/mock/GeolocationClientMock.cpp:

(WebCore::GeolocationClientMock::permissionTimerFired):
(WebCore::GeolocationClientMock::controllerTimerFired):

platform/mock/GeolocationClientMock.h:
platform/mock/PlatformSpeechSynthesizerMock.cpp:

(WebCore::PlatformSpeechSynthesizerMock::speakingFinished):

platform/mock/PlatformSpeechSynthesizerMock.h:
platform/mock/TimerEventBasedMock.h:

(WebCore::TimerEvent::timerFired):

platform/network/DNSResolveQueue.cpp:

(WebCore::DNSResolveQueue::timerFired):

platform/network/DNSResolveQueue.h:
platform/network/NetworkStateNotifier.h:
platform/network/ResourceHandle.cpp:

(WebCore::ResourceHandle::failureTimerFired):

platform/network/ResourceHandle.h:
platform/network/ResourceHandleInternal.h:
platform/network/curl/ResourceHandleManager.cpp:

(WebCore::ResourceHandleManager::downloadTimerCallback):

platform/network/curl/ResourceHandleManager.h:
platform/network/mac/NetworkStateNotifierMac.cpp:

(WebCore::NetworkStateNotifier::networkStateChangeTimerFired):

platform/network/win/ResourceHandleWin.cpp:

(WebCore::ResourceHandle::fileLoadTimer):

plugins/PluginPackage.cpp:

(WebCore::PluginPackage::freeLibraryTimerFired):

plugins/PluginPackage.h:
plugins/PluginStream.cpp:

(WebCore::PluginStream::delayDeliveryTimerFired):

plugins/PluginStream.h:
plugins/PluginView.cpp:

(WebCore::PluginView::popPopupsStateTimerFired):
(WebCore::PluginView::requestTimerFired):
(WebCore::PluginView::invalidateTimerFired):
(WebCore::PluginView::lifeSupportTimerFired):

plugins/PluginView.h:
plugins/win/PluginMessageThrottlerWin.cpp:

(WebCore::PluginMessageThrottlerWin::messageThrottleTimerFired):

plugins/win/PluginMessageThrottlerWin.h:
rendering/ImageQualityController.cpp:

(WebCore::ImageQualityController::highQualityRepaintTimerFired):

rendering/ImageQualityController.h:
rendering/RenderButton.cpp:

(WebCore::RenderButton::styleDidChange):
(WebCore::RenderButton::timerFired):

rendering/RenderButton.h:
rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::updateCompositingLayersTimerFired):
(WebCore::RenderLayerCompositor::layerFlushTimerFired):
(WebCore::RenderLayerCompositor::paintRelatedMilestonesTimerFired):

rendering/RenderLayerCompositor.h:
rendering/RenderMarquee.cpp:

(WebCore::RenderMarquee::timerFired):

rendering/RenderMarquee.h:
rendering/RenderNamedFlowThread.cpp:

(WebCore::RenderNamedFlowThread::regionOversetChangeEventTimerFired):

rendering/RenderNamedFlowThread.h:
rendering/RenderProgress.cpp:

(WebCore::RenderProgress::animationTimerFired):

rendering/RenderProgress.h:
rendering/RenderView.cpp:

(WebCore::RenderView::lazyRepaintTimerFired):

rendering/RenderView.h:
replay/EventLoopInputDispatcher.cpp:

(WebCore::EventLoopInputDispatcher::timerFired):

replay/EventLoopInputDispatcher.h:
storage/StorageAreaImpl.cpp:

(WebCore::StorageAreaImpl::closeDatabaseTimerFired):

storage/StorageAreaImpl.h:
storage/StorageAreaSync.cpp:

(WebCore::StorageAreaSync::syncTimerFired):

storage/StorageAreaSync.h:
svg/SVGElement.cpp:

(WebCore::SVGElement::svgLoadEventTimerFired):
(WebCore::SVGElement::svgLoadEventTimer):

svg/SVGElement.h:
svg/SVGScriptElement.h:
svg/SVGStyleElement.h:
svg/SVGUseElement.h:
svg/animation/SMILTimeContainer.cpp:

(WebCore::SMILTimeContainer::timerFired):

svg/animation/SMILTimeContainer.h:
xml/XMLHttpRequestProgressEventThrottle.cpp:

(WebCore::XMLHttpRequestProgressEventThrottle::dispatchDeferredEvents):

xml/XMLHttpRequestProgressEventThrottle.h:

Source/WebKit/mac:

Remove template specifiers from Timer.

Plugins/Hosted/NetscapePluginInstanceProxy.h:
Plugins/Hosted/NetscapePluginInstanceProxy.mm:

(WebKit::NetscapePluginInstanceProxy::requestTimerFired):

Plugins/WebNetscapePluginStream.h:
Plugins/WebNetscapePluginStream.mm:

(WebNetscapePluginStream::deliverDataTimerFired):

Source/WebKit/win:

FullscreenVideoController.cpp:

(FullscreenVideoController::timerFired):

FullscreenVideoController.h:

Source/WebKit2:

Remove template specifiers from Timer.

NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::NetworkResourceLoader::bufferingTimerFired):

NetworkProcess/NetworkResourceLoader.h:
Shared/WebMemorySampler.cpp:

(WebKit::WebMemorySampler::sampleTimerFired):
(WebKit::WebMemorySampler::stopTimerFired):

Shared/WebMemorySampler.h:
Shared/mac/RemoteLayerBackingStoreCollection.h:
Shared/mac/RemoteLayerBackingStoreCollection.mm:

(WebKit::RemoteLayerBackingStoreCollection::volatilityTimerFired):

UIProcess/API/efl/EwkView.cpp:

(EwkView::displayTimerFired):

UIProcess/API/efl/EwkView.h:
UIProcess/efl/TextCheckerClientEfl.cpp:

(TextCheckerClientEfl::languagesUpdateTimerFired):
(TextCheckerClientEfl::spellCheckingSettingChangeTimerFired):

UIProcess/efl/TextCheckerClientEfl.h:
WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:

(WebKit::CoordinatedLayerTreeHost::layerFlushTimerFired):

WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h:
WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h:
WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:

(WebKit::RemoteLayerTreeDrawingArea::layerFlushTimerFired):

WebProcess/WebProcess.cpp:

(WebKit::WebProcess::processSuspensionCleanupTimerFired):
(WebKit::WebProcess::nonVisibleProcessCleanupTimerFired):

WebProcess/WebProcess.h:

2:51 PM Changeset in webkit [175718] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Don't send identifierForInitialRequest callback method for request with DoNotSendCallbacks option.
https://bugs.webkit.org/show_bug.cgi?id=138473

The iOS specific code that sets up a valid m_identifier is not needed any more, since this
will be done later in ResourceLoader::willSendRequest. This also matches the behavior that
we don't call assignIdentifierToInitialRequest callback method if the reqeust has
DoNotSendCallbacks option.

Patch by Yongjun Zhang <yongjun_zhang@apple.com> on 2014-11-06
Reviewed by Pratik Solanki.

loader/ResourceLoader.cpp:

(WebCore::ResourceLoader::willSendRequest): Remove iOS specific block for setting up a valid

m_identifier. In iOS, also make sure we still bail out if the resource loader was stopped
in assignIdentifierToInitialRequest callback by a client.

2:41 PM Changeset in webkit [175717] by matthew_hanson@apple.com

2 edits in trunk/Tools

Remove code that prepends a leading 'r' to the first argument of _run_git_svn_find_rev
https://bugs.webkit.org/show_bug.cgi?id=138475

Reviewed by Ryosuke Niwa.

The change in https://trac.webkit.org/175603 introduced broke compatibility with svn_revision_from_git_commit.
This patch reverts the part of that change that broke compatibility. In addition, this patch adds a comment to
explain that SVN revisions require a leading 'r', moves an existing comment to a more appropriate location and
renames the positional argument to better reflect that it can represent either an SVN revision or a Git tree-ish.

Scripts/webkitpy/common/checkout/scm/git.py:

(Git._run_git_svn_find_rev):
Add comment mentioning that svn_revisions need to begin with 'r'.
Move comment (explaining that git svn find-rev exits with code 0 when no match is found) to a more appropriate location.
Rename the argument 'revision' to 'revision_or_treeish' to reflect the dual form that argument can take.
Remove code that coerced the revision/treeish into a string and prepended an 'r'.

2:23 PM Changeset in webkit [175716] by dino@apple.com

34 edits
16 adds in trunk

[filters2] Support for backdrop-filter
https://bugs.webkit.org/show_bug.cgi?id=138384
<rdar://problem/18874494>

Reviewed by Simon Fraser.

Take 2!! Previous patch was rolled out.

Source/WebCore:

Add prototype support for backdrop-filter
http://dev.w3.org/fxtf/filters-2/#BackdropFilterProperty

This adds support for parsing the new CSS property, adding
the value to RenderStyle, noticing that on the layer tree,
and the platform code in GraphicsLayer to render a backdrop
and apply an effect to the result.

Some things are missing:

animation of the backdrop-filter is not yet supported
backdrops will not work in cloned layers yet (e.g. reflections)

Tests: css3/filters/backdrop/backdropfilter-property-computed-style.html

css3/filters/backdrop/backdropfilter-property-parsing-invalid.html
css3/filters/backdrop/backdropfilter-property-parsing.html
css3/filters/backdrop/backdropfilter-property.html
css3/filters/backdrop/effect-hw.html

WebCore.exp.in: Export the setBackdropFilters method so it can

be used from WebKit.

css/CSSComputedStyleDeclaration.cpp: New property name.

(WebCore::isLayoutDependent):
(WebCore::ComputedStyleExtractor::propertyValue): Use the existing valueForFilter method.

css/CSSParser.cpp:

(WebCore::CSSParser::parseValue): Piggyback on the filter parser.

css/CSSPropertyNames.in: Add -webkit-backdrop-filter.

css/StyleResolver.cpp:

(WebCore::StyleResolver::adjustRenderStyle): Add test for backdrop.
(WebCore::StyleResolver::applyProperty): Support new property.

platform/graphics/GraphicsLayer.h:

(WebCore::GraphicsLayer::needsBackdrop): New method to test for existence of values.
(WebCore::GraphicsLayer::backdropFilters): Keeps the list of filters.
(WebCore::GraphicsLayer::setBackdropFilters):
(WebCore::GraphicsLayer::clearBackdropFilters):

platform/graphics/ca/GraphicsLayerCA.cpp: This adds a new m_backdropLayer CALayer

that will sit behind the contents layer and provide the element's backdrop.
(WebCore::GraphicsLayerCA::willBeDestroyed):
(WebCore::GraphicsLayerCA::moveOrCopyAnimations):
(WebCore::GraphicsLayerCA::setBackdropFilters): Set a custom appearance so
remote layer hosts will notice the special layer. Also set the actual
layer properties.
(WebCore::GraphicsLayerCA::addAnimation): Remove whitespace.
(WebCore::GraphicsLayerCA::commitLayerChangesBeforeSublayers): Update backdrop if necessary.
(WebCore::GraphicsLayerCA::updateLayerNames): Give the new layer a name.
(WebCore::GraphicsLayerCA::updateSublayerList):
(WebCore::GraphicsLayerCA::updateGeometry): Make the backdrop layer match the contents
layer geometry.
(WebCore::GraphicsLayerCA::updateBackdropFilters): Create the backdrop layer if necessary,
and copy the filter values to any clones.
(WebCore::GraphicsLayerCA::ensureStructuralLayer): We need a structural layer if we
have backdrop filters.
(WebCore::GraphicsLayerCA::structuralLayerPurpose):
(WebCore::GraphicsLayerCA::createAnimationFromKeyframes):
(WebCore::GraphicsLayerCA::swapFromOrToTiledLayer):

platform/graphics/ca/GraphicsLayerCA.h: New StructuralLayerPurpose, new LayerChangeFlag.

platform/graphics/ca/PlatformCALayer.h: New LayerType.

platform/graphics/ca/mac/PlatformCALayerMac.mm: Define CABackdropLayer.

(PlatformCALayerMac::PlatformCALayerMac): Create the correct CALayer type.

rendering/RenderElement.h:

(WebCore::RenderElement::createsGroup):
(WebCore::RenderElement::hasBackdropFilter): This method is always around, but
only can return true when FILTERS_LEVEL_2 is enabled.

rendering/RenderLayer.cpp:

(WebCore::RenderLayer::paintsWithFilters): Remove an unnecessary comment.
(WebCore::RenderLayer::calculateClipRects):

rendering/RenderLayer.h: Add hasBackdropFilter.

rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::RenderLayerBacking):
(WebCore::RenderLayerBacking::createPrimaryGraphicsLayer): Update the backdrop filters.
(WebCore::RenderLayerBacking::updateBackdropFilters): Set the filters on the GraphicsLayer.
(WebCore::RenderLayerBacking::updateGeometry):

rendering/RenderLayerBacking.h:

rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::requiresOwnBackingStore): Needs backingstore if it has a backdrop filter.
(WebCore::RenderLayerCompositor::reasonsForCompositing):
(WebCore::RenderLayerCompositor::requiresCompositingForFilters): Return early if we have
a backdrop filter, because currently we absolutely require compositing.

rendering/RenderLayerModelObject.cpp:

(WebCore::RenderLayerModelObject::styleWillChange): Add hasBackdropFilter().

rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::changeRequiresLayout): Check backdrops for change.

rendering/style/RenderStyle.h: Add the backdropFilter style stuff.
rendering/style/StyleRareNonInheritedData.cpp:

(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator==):
(WebCore::StyleRareNonInheritedData::hasBackdropFilters):

rendering/style/StyleRareNonInheritedData.h:

Source/WebKit2:

Shared/mac/RemoteLayerBackingStore.mm:

(WebKit::RemoteLayerBackingStore::drawInContext): Handle LayerTypeBackdropLayer in the switch.

Shared/mac/RemoteLayerTreeTransaction.mm:

(WebKit::RemoteLayerTreeTransaction::description): Describe a backdrop layer.

UIProcess/ios/RemoteLayerTreeHostIOS.mm:

(+[WKBackdropView layerClass]): Define CABackdropLayer and use it as the class.
(WebKit::RemoteLayerTreeHost::createLayer):

UIProcess/mac/RemoteLayerTreeHost.mm: Ditto.

(WebKit::RemoteLayerTreeHost::createLayer):

LayoutTests:

Tests for backdrop-filter. These are skipped on non-Apple platforms.

platform/win/TestExpections: Skip these tests.
platform/efl/TestExpections:
platform/gtk/TestExpections:
platform/mac-mavericks/TestExpectations: Yosemite only.

css3/filters/backdrop/backdropfilter-property-computed-style-expected.txt: Added.
css3/filters/backdrop/backdropfilter-property-computed-style.html: Added.
css3/filters/backdrop/backdropfilter-property-expected.txt: Added.
css3/filters/backdrop/backdropfilter-property-parsing-expected.txt: Added.
css3/filters/backdrop/backdropfilter-property-parsing-invalid-expected.txt: Added.
css3/filters/backdrop/backdropfilter-property-parsing-invalid.html: Added.
css3/filters/backdrop/backdropfilter-property-parsing.html: Added.
css3/filters/backdrop/backdropfilter-property.html: Added.
css3/filters/backdrop/effect-hw-expected.html: Added.
css3/filters/backdrop/effect-hw.html: Added.
css3/filters/backdrop/script-tests/backdropfilter-property-computed-style.js: Added.

(testComputedFilterRule):

css3/filters/backdrop/script-tests/backdropfilter-property-parsing-invalid.js: Added.

(testInvalidFilterRule):

css3/filters/backdrop/script-tests/backdropfilter-property-parsing.js: Added.

(jsWrapperClass):
(shouldBeType):
(testFilterRule):

css3/filters/backdrop/script-tests/backdropfilter-property.js: Added.

2:07 PM Changeset in webkit [175715] by benjamin@webkit.org

8 edits
2 adds in trunk

Give pseudo elements the correct specificity
https://bugs.webkit.org/show_bug.cgi?id=138378

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-11-06
Reviewed by Dean Jackson.

Source/WebCore:

WebKit had an old silly bug where pseudo elements were given specificity in the class B
instead of the class C.

Now that the inspector shows the specificity, this bug is much more visible which is why
I fix it now.

Test: fast/css/pseudo-element-specificity.html

css/CSSSelector.cpp:

(WebCore::CSSSelector::specificityForOneSelector):
Give pseudo-elements the right specificity.

Modules/mediacontrols/mediaControlsApple.css:

(video::-webkit-media-controls-volume-slider):
(audio::-webkit-media-controls-volume-slider::-webkit-slider-thumb):
(audio::-webkit-media-controls-volume-slider::-webkit-slider-thumb:active::-webkit-slider-thumb):
(audio::-webkit-media-controls-timeline):
(audio::-webkit-media-controls-timeline::-webkit-slider-thumb):
(audio::-webkit-media-controls-timeline:active::-webkit-slider-thumb,):
(video:-webkit-full-screen::-webkit-media-controls-volume-slider):
(video:-webkit-full-screen::-webkit-media-controls-volume-slider::-webkit-slider-thumb):

Modules/mediacontrols/mediaControlsBase.css:

css/mediaControls.css:

(audio::-webkit-media-controls-volume-slider, video::-webkit-media-controls-volume-slider):
(audio::-webkit-media-controls-volume-slider-mute-button, video::-webkit-media-controls-volume-slider-mute-button):

css/mediaControlsGtk.css:

(audio::-webkit-media-controls-timeline, video::-webkit-media-controls-timeline):
(audio::-webkit-media-controls-timeline[disabled], video::-webkit-media-controls-timeline[disabled]):
(audio::-webkit-media-controls-volume-slider, video::-webkit-media-controls-volume-slider):
The media controls were relying on the bug to override the style of input[type=range].

Ideally we should either:
-Implement some kind of high level style isolation (e.g. CSS Scoping).
-Fix the media control tree to use regular CSS scoped by a shadow pseudo ID.

Until we have one of those, I just fixed the styling by forcing the properties with lower
specificity with !important.

LayoutTests:

fast/css/pseudo-element-specificity-expected.html: Added.
fast/css/pseudo-element-specificity.html: Added.

Given that all selector affecting the pseudo element were offset by one,
it is impossible to use a pseudo element directly to affect the order, making the bug
hard to test.

What I did here for testing is use the stauration at 255 of any specificity field.
With 255 class + 1 pseudo element, the old code would saturate at (0, 255, 0), while
the fixed code would correctly give (0, 255, 1). By comparing that to a non-saturated
selector, I can show the fix is correct.

inspector/css/selector-specificity-expected.txt:

2:04 PM Changeset in webkit [175714] by dburkart@apple.com

1 copy in tags/Safari-600.3.4

Tagging Safari-600.3.4

2:03 PM Changeset in webkit [175713] by dburkart@apple.com

1 delete in tags/Safari-600.3.4

Removing tag to re-tag with another fix.

2:01 PM Changeset in webkit [175712] by dburkart@apple.com

4 edits in branches/safari-600.3-branch/Source

Merged r175710. <rdar://problems/18898712>

1:35 PM Changeset in webkit [175711] by timothy_horton@apple.com

2 edits in trunk/Source/WebKit2

Data detectors popover points at the first line of the detected item
https://bugs.webkit.org/show_bug.cgi?id=138471
<rdar://problem/18893079>

Reviewed by Sam Weinig.

WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::scanForDataDetectedItems):
Determine the bounding box of all quads of the detected item's text.
This way, the popover will point at the border of the item, instead of
right at the very first line.

1:03 PM Changeset in webkit [175710] by Beth Dakin

4 edits in trunk/Source

Preview views often misplaced inside popover
https://bugs.webkit.org/show_bug.cgi?id=138472

Reviewed by Tim Horton.

Source/WebCore:

WebCore.exp.in:

Source/WebKit2:

This patch makes the popover maintain aspect ratio, and it uses the final scale of
that popover to scale the preview view as well.

UIProcess/mac/WKActionMenuController.mm:

(-[WKPagePreviewViewController initWithPageURL:mainViewSize:popoverToViewScale:]):
(-[WKPagePreviewViewController loadView]):
(-[WKActionMenuController _createPreviewPopoverForURL:originRect:]):
(-[WKActionMenuController _targetSize:fitsInAvailableSpace:]):
(-[WKActionMenuController _preferredSizeForPopoverPresentedFromOriginRect:]):
(-[WKPagePreviewViewController initWithPageURL:]): Deleted.

12:37 PM Changeset in webkit [175709] by bshafiei@apple.com

5 edits in tags/Safari-601.1.8/Source

Merged r175706. rdar://problem/18813675

12:03 PM Changeset in webkit [175708] by ap@apple.com

2 edits in trunk/LayoutTests

inspector-protocol/debugger/setPauseOnExceptions-uncaught.html frequently times out on Yosemite
https://bugs.webkit.org/show_bug.cgi?id=138097

platform/mac-wk2/TestExpectations: Marking it as such.

11:57 AM Changeset in webkit [175707] by dburkart@apple.com

1 copy in tags/Safari-600.3.4

Tagging Safari-600.3.4

11:47 AM Changeset in webkit [175706] by msaboff@apple.com

5 edits in trunk/Source

REGRESSION (r174985-174986): Site display disappears
https://bugs.webkit.org/show_bug.cgi?id=138082

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

In support of the change in WebCore, this adds a new functor class to unwind to our
caller's frame possibly skipping of intermediate C++ frames.

interpreter/StackVisitor.h:

(JSC::CallerFunctor::CallerFunctor):
(JSC::CallerFunctor::callerFrame):
(JSC::CallerFunctor::operator()):

Source/WebCore:

This effectively reverts to the behavior before r174985 by using the
lexical global object of the caller's frame to find the active document.
Before r174985, native functions are invoked with the ScopeShain of their
caller. The lexical global object is accessed from the ScopeChain.

bindings/js/JSHTMLDocumentCustom.cpp:

(WebCore::JSHTMLDocument::getOwnPropertySlot):
(WebCore::findOwningDocument):
(WebCore::documentWrite):
(WebCore::JSHTMLDocument::write):
(WebCore::JSHTMLDocument::writeln):

html/HTMLDocument.idl:

11:38 AM Changeset in webkit [175705] by timothy_horton@apple.com

3 edits in trunk/Source/WebKit2

TextIndicatorWindow's bounce animation is lopsided when indicating two short lines of text
https://bugs.webkit.org/show_bug.cgi?id=138458

Reviewed by Simon Fraser.

Previously, the TextIndicator's frame() covered the entire selection highlight bounds.
This was undesirable in cases where the highlight included areas far outside the
bounds of the selected text, as the TextIndicatorWindow's 'bounce' animation
would be misaligned (centered on the highlight instead of on the text).

Shared/TextIndicator.cpp:

Get rid of the many-argument TextIndicator::create, because it was only used
internally, and have createWithSelectionInFrame make a ::Data instead.

(WebKit::TextIndicator::createWithSelectionInFrame):
Compute and store the bounding rect of all of the selected text rects, and store
all of the text rects relative to that bounding rect instead of relative to the
selection highlight bounds. We do this because the selection highlight bounds
often includes area which is far outside of the text bounds (in the case of a
selection that spans multiple lines), and causes the text indicator bounce
animation to bounce in a lopsided manner.

(WebKit::TextIndicator::TextIndicator):
Adjust to the rename of textRectsInSelectionRectCoordinates -> textRectsInBoundingRectCoordinates.

(WebKit::TextIndicator::frameRect):
Instead of the TextIndicator's frame being the selection highlight bounds,
it is now the bounds of all of the text rects.

(WebKit::TextIndicator::draw):
Translate into the image by the difference between the selection highlight bounds
and the text bounding rect. This is necessary because the content image is still generated
covering the entire selection highlight bounds, but the text rects are in text-rect-bounds coordinates.

(WebKit::TextIndicator::Data::encode):
(WebKit::TextIndicator::Data::decode):
Adjust to the rename of textRectsInSelectionRectCoordinates -> textRectsInBoundingRectCoordinates.
Encode/decode textBoundingRectInWindowCoordinates.

Shared/TextIndicator.h:

(WebKit::TextIndicator::contentImage): Deleted.
Get rid of an unnecessary getter and constructor.

11:04 AM Changeset in webkit [175704] by timothy_horton@apple.com

2 edits in trunk/Source/WebKit2

Only provide a single result to the action menu DDActionContext
https://bugs.webkit.org/show_bug.cgi?id=138469
<rdar://problem/18869036>

Reviewed by Anders Carlsson.

WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::scanForDataDetectedItems):
Only provide one result; secondary results can be extremely unrelated to
the primary one and confuse Data Detectors further down the line.

11:02 AM Changeset in webkit [175703] by bshafiei@apple.com

2 edits in tags/Safari-601.1.8/Source/WTF

Merge patch for <rdar://problem/18887867> to disable bmalloc.

10:58 AM Changeset in webkit [175702] by timothy_horton@apple.com

2 edits in trunk/Source/WebKit2

Null deref in rangeForDictionaryLookupAtHitTestResult on occasion
https://bugs.webkit.org/show_bug.cgi?id=138459
<rdar://problem/18872825>

Reviewed by Andreas Kling.

WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::rangeForDictionaryLookupAtHitTestResult):
rangeExpandedAroundPositionByCharacters can return null.

10:57 AM Changeset in webkit [175701] by timothy_horton@apple.com

2 edits in trunk/Source/WebKit2

Prefer link action menus over images
https://bugs.webkit.org/show_bug.cgi?id=138461
<rdar://problem/18768377>

Reviewed by Anders Carlsson.

UIProcess/mac/WKActionMenuController.mm:

(-[WKActionMenuController _defaultMenuItems:]):
Swap the priority of links and images.

10:46 AM Changeset in webkit [175700] by weinig@apple.com

11 edits in trunk/Source

Use std::unique_ptr for TileController
https://bugs.webkit.org/show_bug.cgi?id=138429

Reviewed by Anders Carlsson.

Source/WebCore:

WebCore.exp.in:
platform/graphics/ca/TileController.cpp:

(WebCore::TileController::create): Deleted.

platform/graphics/ca/TileController.h:
platform/graphics/ca/mac/WebTiledBackingLayer.h:
platform/graphics/ca/mac/WebTiledBackingLayer.mm:

(-[WebTiledBackingLayer createTileController:]):

platform/graphics/ca/win/PlatformCALayerWinInternal.cpp:

(PlatformCALayerWinInternal::createTileController):

platform/graphics/ca/win/PlatformCALayerWinInternal.h:

Source/WebKit2:

WebProcess/WebPage/mac/PlatformCALayerRemoteTiledBacking.cpp:

(WebKit::PlatformCALayerRemoteTiledBacking::PlatformCALayerRemoteTiledBacking):

WebProcess/WebPage/mac/PlatformCALayerRemoteTiledBacking.h:

10:05 AM Changeset in webkit [175699] by mitz@apple.com

2 edits in trunk/Source/WebKit2

iOS build fix.

WebProcess/Plugins/PluginController.h:

8:40 AM Changeset in webkit [175698] by dbates@webkit.org

6 edits
2 adds in trunk/Source/WebKit2

[iOS] WebProcess needs to take a background task assertion to prevent being killed
for "suspended with locked system files"
https://bugs.webkit.org/show_bug.cgi?id=138155
<rdar://problem/17939303>

Reviewed by Anders Carlsson.

Mitigates an issue where the WebProcess may be killed when suspended holding locked files
by allowing the WebProcess to notify the UIProcess when it is holding such files so that
both can continue to run for a period of time after the UIProcess transitions to the
background. In particular, the WebProcess notifies the UIProcess that it is holding- or
relinquished- a locked file when it begins and ends a sequence of SQLite transactions,
respectively.

UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::disconnect): Relinquish an existing background task assertion
when the WebProcess disconnects. Among other situations, the WebProcess may disconnect as
a result of being suspended holding locked files even when the UIProcess requested a
background task assertion (i.e. it may have exceeded its background time limit).
(WebKit::WebProcessProxy::setIsHoldingLockedFiles): Added. Either acquires a new background
task assertion or relinquishes an existing one.

UIProcess/WebProcessProxy.h:
UIProcess/WebProcessProxy.messages.in: Added message SetIsHoldingLockedFiles(bool). The WebProcess

dispatches this message to inform the UIProcess that it is holding- or relinquished- a locked file.

WebKit2.xcodeproj/project.pbxproj: Added files WebSQLiteDatabaseTracker.{cpp, h}.
WebProcess/WebCoreSupport/WebSQLiteDatabaseTracker.cpp: Added.

(WebKit::WebSQLiteDatabaseTracker::supplementName): Added.
(WebKit::WebSQLiteDatabaseTracker::WebSQLiteDatabaseTracker): Added.
(WebKit::WebSQLiteDatabaseTracker::initialize): Register to receive SQLiteDatabaseTrackerClient callbacks.
(WebKit::WebSQLiteDatabaseTracker::willBeginFirstTransaction): Inform the HysteresisActivity object on
the main thread that we began a transaction so that it calls WebSQLiteDatabaseTracker::started().
(WebKit::WebSQLiteDatabaseTracker::didFinishLastTransaction): Inform the HysteresisActivity object on
the main thread that we finished a transaction so that it may eventually call WebSQLiteDatabaseTracker::stopped().
(WebKit::WebSQLiteDatabaseTracker::started): Notify the UIProcess that the WebProcess is holding
a locked file.
(WebKit::WebSQLiteDatabaseTracker::stopped): Notify the UIProcess that the WebProcess has
relinquished the locked file.

WebProcess/WebCoreSupport/WebSQLiteDatabaseTracker.h: Added. We use a HysteresisActivity object

to coalesce SetIsHoldingLockedFiles(false) messages as an optimization to minimize the number of
messages exchanged between the UIProcess and WebProcess when a web page performs SQLite transactions
in batches.

WebProcess/WebProcess.cpp:

(WebKit::WebProcess::WebProcess): Instantiate the supplement WebSQLiteDatabaseTracker when building
for iOS.

8:03 AM WebKitGTK/2.6.x edited by Carlos Garcia Campos

(diff)

8:00 AM WebKitGTK/2.4.x edited by Carlos Garcia Campos

(diff)

8:00 AM Changeset in webkit [175697] by Chris Dumez

3 edits in trunk/Source/WebCore

Use lambda functions in DocumentOrderedMap
https://bugs.webkit.org/show_bug.cgi?id=138376

Reviewed by Darin Adler.

Use lambda functions in DocumentOrderedMap instead of separate named
functions.

No new tests, no behavior change.

dom/DocumentOrderedMap.cpp:

(WebCore::DocumentOrderedMap::get):
(WebCore::DocumentOrderedMap::getElementById):
(WebCore::DocumentOrderedMap::getElementByName):
(WebCore::DocumentOrderedMap::getElementByMapName):
(WebCore::DocumentOrderedMap::getElementByLowercasedMapName):
(WebCore::DocumentOrderedMap::getElementByLowercasedUsemap):
(WebCore::DocumentOrderedMap::getElementByLabelForAttribute):
(WebCore::DocumentOrderedMap::getElementByWindowNamedItem):
(WebCore::DocumentOrderedMap::getElementByDocumentNamedItem):
(WebCore::DocumentOrderedMap::getAllElementsById):
(WebCore::keyMatchesId): Deleted.
(WebCore::keyMatchesName): Deleted.
(WebCore::keyMatchesMapName): Deleted.
(WebCore::keyMatchesLowercasedMapName): Deleted.
(WebCore::keyMatchesLowercasedUsemap): Deleted.
(WebCore::keyMatchesLabelForAttribute): Deleted.
(WebCore::keyMatchesWindowNamedItem): Deleted.
(WebCore::keyMatchesDocumentNamedItem): Deleted.

dom/DocumentOrderedMap.h:

7:46 AM Changeset in webkit [175696] by berto@igalia.com

2 edits in trunk/Source/WebKit2

[GTK] [Stable] webkitgtk 2.6.1 fails to load flashplugin
https://bugs.webkit.org/show_bug.cgi?id=137849

Reviewed by Carlos Garcia Campos.

NPPVpluginNeedsXEmbed is a boolean value, so it should normally
use an NPBool (1 byte). However some plugins (the Flash player in
particular) are using an int instead, so we have to do it as well
else we'll end up corrupting the stack.

WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:

(WebKit::NetscapePlugin::platformPostInitialize):

7:22 AM Changeset in webkit [175695] by Bem Jones-Bey

2 edits in trunk/LayoutTests

Update testharness.js to the latest version
https://bugs.webkit.org/show_bug.cgi?id=138446

Reviewed by Ryosuke Niwa.

The only change I've made from upstream is to set output to false by
default.

resources/testharness.js:

7:08 AM Changeset in webkit [175694] by Carlos Garcia Campos

19 edits
3 adds in trunk

[GTK] Add context menu API to Web Process Extensions
https://bugs.webkit.org/show_bug.cgi?id=138311

Reviewed by Gustavo Noronha Silva.

Source/WebKit2:

Add WebKitWebPage::context-menu signal, similar to the
WebKitWebView one, but that receives a WebKitWebHitTestResult, a
class that extends WebKitTestResult to provide the WebKitDOMNode
from the Web Process Extensions API. This makes WebKitContextMenu,
WebKitContextMenuItem and WebKitTestResult classes shared between
UI and Web Extensions APIs. In addition to be able to customize
the context menu, it also provides API to set user data, as a
GVariant, in the Web Process that is sent to the UI Process.

PlatformGTK.cmake: Add new files.
UIProcess/API/gtk/WebKitContextMenu.cpp:

(webkit_context_menu_set_user_data): Add user data to the context
menu as a GVariant.
(webkit_context_menu_get_user_data): Get the user data previously
set with webkit_context_menu_set_user_data() either from the Web
or UI processes.

UIProcess/API/gtk/WebKitContextMenu.h:
UIProcess/API/gtk/WebKitContextMenuActions.h:
UIProcess/API/gtk/WebKitContextMenuClient.cpp:

(getContextMenuFromProposedMenu): Convert the received user data
into a GVariant and pass it to webkitWebViewPopulateContextMenu().

UIProcess/API/gtk/WebKitContextMenuItem.h:
UIProcess/API/gtk/WebKitForwardDeclarations.h:
UIProcess/API/gtk/WebKitHitTestResult.h:
UIProcess/API/gtk/WebKitWebView.cpp:

(webkitWebViewPopulateContextMenu): Set the user data received
from the Web Process to the WebKitContextMenu before emitting
WebKitWebView::context-menu.

UIProcess/API/gtk/WebKitWebViewPrivate.h:
UIProcess/API/gtk/docs/webkit2gtk-docs.sgml: Add new section for WebKitWebHitTestResult.
UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new symbols.
UIProcess/API/gtk/docs/webkit2gtk.types: Add webkit_web_hit_test_result_get_type.
WebProcess/InjectedBundle/API/gtk/WebKitWebHitTestResult.cpp: Added.

(webkitWebHitTestResultGetProperty): Add getter for node property.
(webkitWebHitTestResultSetProperty): Add setter for node property.
(webkit_web_hit_test_result_class_init): Add node property.
(webkitWebHitTestResultCreate): Create a new
WebKitWebHitTestResult for the given InjectedBundleHitTestResult.
(webkit_web_hit_test_result_get_node): Return the WebKitDOMNode.

WebProcess/InjectedBundle/API/gtk/WebKitWebHitTestResult.h: Added.
WebProcess/InjectedBundle/API/gtk/WebKitWebHitTestResultPrivate.h: Added.
WebProcess/InjectedBundle/API/gtk/WebKitWebPage.cpp:

(getContextMenuFromDefaultMenu): Build a WebKitContextMenu and
WebKitWebHitTestResult and emit WebKitWebPage::context-menu signal.
(webkit_web_page_class_init): Add WebKitWebPage::context-menu signal.
(webkitWebPageCreate): Add implementation for getContextMenuFromDefaultMenu.

WebProcess/InjectedBundle/API/gtk/webkit-web-extension.h:

Tools:

Add tests cases for WebKitWebPage::context-menu signal.

TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:

(testContextMenuWebExtensionMenu):
(testContextMenuWebExtensionNode):
(beforeAll):

TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:

(serializeContextMenu):
(serializeNode):
(contextMenuCallback):
(pageCreatedCallback):

2:31 AM Changeset in webkit [175693] by commit-queue@webkit.org

2 edits in trunk/Tools

Unreviewed, rolling out r175690.
https://bugs.webkit.org/show_bug.cgi?id=138460

We are not ready to run layout tests using the network process
yet (Requested by KaL on #webkit).

Reverted changeset:

"[GTK] Run layout tests using the network process"
https://bugs.webkit.org/show_bug.cgi?id=138428
http://trac.webkit.org/changeset/175690

2:08 AM Changeset in webkit [175692] by ryuan.choi@gmail.com

5 edits in trunk/Source/WebKit2

[EFL] Remove m_scrollPosition from CoordinatedGraphicsScene
https://bugs.webkit.org/show_bug.cgi?id=138419

Reviewed by Gyuyoung Kim.

m_scrollPosition of CoordinatedGraphicsScene is only to adjust the position
of fixed element. But this adjustment is only called by paintToCurrentGLContext()
and WebView can pass same information to the parameter of that method.

UIProcess/CoordinatedGraphics/CoordinatedGraphicsScene.cpp:

(WebCore::CoordinatedGraphicsScene::paintToCurrentGLContext):
(WebCore::CoordinatedGraphicsScene::adjustPositionForFixedLayers):
(WebCore::CoordinatedGraphicsScene::setScrollPosition): Deleted.

UIProcess/CoordinatedGraphics/CoordinatedGraphicsScene.h:
UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.cpp:

(WebKit::CoordinatedLayerTreeHostProxy::setVisibleContentsRect):

UIProcess/CoordinatedGraphics/WebView.cpp:

(WebKit::WebView::paintToCurrentGLContext):

12:51 AM WebKitGTK/2.4.x edited by berto@igalia.com

(diff)

12:50 AM Changeset in webkit [175691] by gyuyoung.kim@samsung.com

3 edits in trunk/Source/JavaScriptCore

Use std::unique_ptr in CodeBlock class
https://bugs.webkit.org/show_bug.cgi?id=138395

Reviewed by Darin Adler.

bytecode/CodeBlock.h: Use std::unique_ptr.

(JSC::CodeBlock::setJITCodeMap):

jit/CompactJITCodeMap.h: Use std::unique_ptr instead of OwnPtr|PassOwnPtr.

(JSC::CompactJITCodeMap::CompactJITCodeMap):
(JSC::CompactJITCodeMap::Encoder::finish): Use std::unique_ptr instead of PassOwnPtr.

12:47 AM Changeset in webkit [175690] by Carlos Garcia Campos

2 edits in trunk/Tools

[GTK] Run layout tests using the network process
https://bugs.webkit.org/show_bug.cgi?id=138428

Reviewed by Martin Robinson.

Shared secondary process is the default in the GTK+ port, but we
should run the tests using the network process to ensure
everything works with the network process. In the future, the
shared secondary process model might be a special case of multiple
processes with 1 as maximum number of processes, but always using
the network process.

WebKitTestRunner/TestController.cpp:

(WTR::TestController::initialize):

12:07 AM Changeset in webkit [175689] by Chris Dumez

2 edits in trunk/LayoutTests

Unreviewed, fix nits after r175688.

Just a couple of non-functional fixes to the layout test.

fast/dom/Text/splitText.html:

Nov 5, 2014:

11:53 PM Changeset in webkit [175688] by commit-queue@webkit.org

5 edits
2 adds in trunk

splitText API does not match DOM specification.
https://bugs.webkit.org/show_bug.cgi?id=138405

Patch by Shivakumar JM <shiva.jm@samsung.com> on 2014-11-05
Reviewed by Chris Dumez.
Source/WebCore:

Make the offset argument for splitText API as mandatory (and thus throw if it is omitted) and stop throwing if the offset argument is
negative (and wraps to a valid index) as per specification: https://w3c.github.io/dom/#interface-text. Also This matches the behavior
of both Firefox 33 and Chrome 38.

Test: fast/dom/Text/splitText.html

dom/Text.idl:

LayoutTests:

fast/dom/Text/splitText-expected.txt: Added.
fast/dom/Text/splitText.html: Added.
fast/dom/non-numeric-values-numeric-parameters-expected.txt:
fast/dom/script-tests/non-numeric-values-numeric-parameters.js:

11:43 PM Changeset in webkit [175687] by commit-queue@webkit.org

34 edits
1 delete in trunk

Unreviewed, rolling out r175672.
https://bugs.webkit.org/show_bug.cgi?id=138455

Tries to make backdrop layers on every layer, asserts on
Mavericks (Requested by smfr on #webkit).

Reverted changeset:

"[filters2] Support for backdrop-filter"
https://bugs.webkit.org/show_bug.cgi?id=138384
http://trac.webkit.org/changeset/175672

11:21 PM Changeset in webkit [175686] by adachan@apple.com

15 edits in trunk/Source

Figure out whether a plug-in is playing audio.
https://bugs.webkit.org/show_bug.cgi?id=137219

Reviewed by Anders Carlsson.

Source/WebCore:

Add NPPVpluginIsPlayingAudio. Export some WebCore methods that will be used in WebKit2.

No new tests, but manually tested with an example plugin.

WebCore.exp.in:
plugins/npapi.h:

Source/WebKit2:

Handle the setting of the NPPVpluginIsPlayingAudio variable.

PluginProcess/PluginControllerProxy.cpp:

(WebKit::PluginControllerProxy::setPluginIsPlayingAudio):
Send a SetPluginIsPlayingAudio message to the WebProcess.

PluginProcess/PluginControllerProxy.h:
WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:

(WebKit::NPN_SetValue):
Handle NPPVpluginIsPlayingAudio. Call NetscapePlugin::setIsPlayingAudio().

WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::setIsPlayingAudio):
Call PluginControllerProxy::setPluginIsPlayingAudio().

WebProcess/Plugins/Netscape/NetscapePlugin.h:
WebProcess/Plugins/PluginController.h:
WebProcess/Plugins/PluginProxy.cpp:

(WebKit::PluginProxy::setPluginIsPlayingAudio):
Call PluginView::setPluginIsPlayingAudio().

WebProcess/Plugins/PluginProxy.h:
WebProcess/Plugins/PluginProxy.messages.in:

Add the SetPluginIsPlayingAudio message.

WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::PluginView):
Initialize m_pluginIsPlayingAudio.
(WebKit::PluginView::~PluginView):
Remove itself from the Document's list of AudioProducers.
(WebKit::PluginView::initializePlugin):
Add itself to the Document's list of AudioProducers.
(WebKit::PluginView::pageMutedStateDidChange):
Add a FIXME.
(WebKit::PluginView::setPluginIsPlayingAudio):
If m_pluginIsPlayingAudio has changed, tell the Document to update its audio playing state.

WebProcess/Plugins/PluginView.h:

Now inherits AudioProducer.

10:56 PM Changeset in webkit [175685] by bshafiei@apple.com

2 edits in tags/Safari-601.1.8/Source/WebCore

Merged r175657. rdar://problem/18883681

10:53 PM Changeset in webkit [175684] by bshafiei@apple.com

2 edits in tags/Safari-601.1.8/Source/JavaScriptCore

Merged rr175653. rdar://problem/18801123

10:33 PM Changeset in webkit [175683] by dburkart@apple.com

2 edits in branches/safari-600.3-branch/Source/WebKit2

Merged r175649. <rdar://problems/18887140>

10:32 PM Changeset in webkit [175682] by dburkart@apple.com

2 edits in branches/safari-600.3-branch/Source/WebKit2

Merged r175646. <rdar://problems/18887218>

10:30 PM Changeset in webkit [175681] by dburkart@apple.com

2 edits in branches/safari-600.3-branch/Source/WebKit2

Merged r175645. <rdar://problems/18887140>

10:29 PM Changeset in webkit [175680] by dburkart@apple.com

2 edits in branches/safari-600.3-branch/Source/WebKit2

Merged r175643. <rdar://problems/18885782>

10:07 PM Changeset in webkit [175679] by Simon Fraser

2 edits in trunk/Source/WebCore

Fix crash introduced in r175656
https://bugs.webkit.org/show_bug.cgi?id=138453

Reviewed by Dan Bernstein.

repaintContainer can be null sometimes.

Covered by existing tests.

rendering/RenderLayerCompositor.cpp:

(WebCore::styleChangeRequiresLayerRebuild):

10:03 PM Changeset in webkit [175678] by mitz@apple.com

5 edits in trunk/Source

Source/WebKit:
Removed references to deletion UI resources that have been removed.

WebKit.vcxproj/WebKit/WebKit.vcxproj:
WebKit.vcxproj/WebKit/WebKit.vcxproj.filters:

Source/WebKit2:
Tried to fix the GTK build.

PlatformGTK.cmake: Removed references to deletion UI resources that have been removed.

10:02 PM Changeset in webkit [175677] by dburkart@apple.com

7 edits in branches/safari-600.3-branch/Source/WebKit2

Merged r175637. <rdar://problems/18877675>

9:59 PM Changeset in webkit [175676] by mitz@apple.com

4 edits in trunk/Source/WebCore

Tried to fix the Windows build after removing the deletion UI.

WebCore.vcxproj/WebCore.vcxproj:
WebCore.vcxproj/WebCore.vcxproj.filters:
editing/EditingAllInOne.cpp:

9:56 PM Changeset in webkit [175675] by dburkart@apple.com

4 edits in branches/safari-600.3-branch/Source/WebKit2

Merged r175635. <rdar://problems/18884674>

9:53 PM Changeset in webkit [175674] by dburkart@apple.com

3 edits in branches/safari-600.3-branch/Source/WebKit2

Merged r175632. <rdar://problems/18774264>

9:50 PM Changeset in webkit [175673] by dburkart@apple.com

6 edits in branches/safari-600.3-branch/Source/WebKit2

Merged r175630. <rdar://problems/18876437>

9:50 PM Changeset in webkit [175672] by dino@apple.com

34 edits
16 adds in trunk

[filters2] Support for backdrop-filter
https://bugs.webkit.org/show_bug.cgi?id=138384
<rdar://problem/18874494>

Reviewed by Simon Fraser.

Source/WebCore:

Add prototype support for backdrop-filter
http://dev.w3.org/fxtf/filters-2/#BackdropFilterProperty

Some things are missing:

animation of the backdrop-filter is not yet supported
backdrops will not work in cloned layers yet (e.g. reflections)

Tests: css3/filters/backdrop/backdropfilter-property-computed-style.html

css3/filters/backdrop/backdropfilter-property-parsing-invalid.html
css3/filters/backdrop/backdropfilter-property-parsing.html
css3/filters/backdrop/backdropfilter-property.html
css3/filters/backdrop/effect-hw.html

WebCore.exp.in: Export the setBackdropFilters method so it can

be used from WebKit.

css/CSSComputedStyleDeclaration.cpp: New property name.

(WebCore::isLayoutDependent):
(WebCore::ComputedStyleExtractor::propertyValue): Use the existing valueForFilter method.

css/CSSParser.cpp:

(WebCore::CSSParser::parseValue): Piggyback on the filter parser.

css/CSSPropertyNames.in: Add -webkit-backdrop-filter.

css/StyleResolver.cpp:

(WebCore::StyleResolver::adjustRenderStyle): Add test for backdrop.
(WebCore::StyleResolver::applyProperty): Support new property.

platform/graphics/GraphicsLayer.h:

platform/graphics/ca/GraphicsLayerCA.cpp: This adds a new m_backdropLayer CALayer

platform/graphics/ca/GraphicsLayerCA.h: New StructuralLayerPurpose, new LayerChangeFlag.

platform/graphics/ca/PlatformCALayer.h: New LayerType.

platform/graphics/ca/mac/PlatformCALayerMac.mm: Define CABackdropLayer.

(PlatformCALayerMac::PlatformCALayerMac): Create the correct CALayer type.

rendering/RenderElement.h:

(WebCore::RenderElement::createsGroup):
(WebCore::RenderElement::hasBackdropFilter): This method is always around, but
only can return true when FILTERS_LEVEL_2 is enabled.

rendering/RenderLayer.cpp:

(WebCore::RenderLayer::paintsWithFilters): Remove an unnecessary comment.
(WebCore::RenderLayer::calculateClipRects):

rendering/RenderLayer.h: Add hasBackdropFilter.

rendering/RenderLayerBacking.cpp:

rendering/RenderLayerBacking.h:

rendering/RenderLayerCompositor.cpp:

rendering/RenderLayerModelObject.cpp:

(WebCore::RenderLayerModelObject::styleWillChange): Add hasBackdropFilter().

rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::changeRequiresLayout): Check backdrops for change.

rendering/style/RenderStyle.h: Add the backdropFilter style stuff.
rendering/style/StyleRareNonInheritedData.cpp:

(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator==):
(WebCore::StyleRareNonInheritedData::hasBackdropFilters):

rendering/style/StyleRareNonInheritedData.h:

Source/WebKit2:

Shared/mac/RemoteLayerBackingStore.mm:

(WebKit::RemoteLayerBackingStore::drawInContext): Handle LayerTypeBackdropLayer in the switch.

Shared/mac/RemoteLayerTreeTransaction.mm:

(WebKit::RemoteLayerTreeTransaction::description): Describe a backdrop layer.

UIProcess/ios/RemoteLayerTreeHostIOS.mm:

(+[WKBackdropView layerClass]): Define CABackdropLayer and use it as the class.
(WebKit::RemoteLayerTreeHost::createLayer):

UIProcess/mac/RemoteLayerTreeHost.mm: Ditto.

(WebKit::RemoteLayerTreeHost::createLayer):

LayoutTests:

Tests for backdrop-filter. These are skipped on non-Apple platforms.

platform/win/TestExpections: Skip these tests.
platform/efl/TestExpections:
platform/gtk/TestExpections:
platform/mac-mavericks/TestExpectations: Yosemite only.

css3/filters/backdrop/backdropfilter-property-computed-style-expected.txt: Added.
css3/filters/backdrop/backdropfilter-property-computed-style.html: Added.
css3/filters/backdrop/backdropfilter-property-expected.txt: Added.
css3/filters/backdrop/backdropfilter-property-parsing-expected.txt: Added.
css3/filters/backdrop/backdropfilter-property-parsing-invalid-expected.txt: Added.
css3/filters/backdrop/backdropfilter-property-parsing-invalid.html: Added.
css3/filters/backdrop/backdropfilter-property-parsing.html: Added.
css3/filters/backdrop/backdropfilter-property.html: Added.
css3/filters/backdrop/effect-hw-expected.html: Added.
css3/filters/backdrop/effect-hw.html: Added.
css3/filters/backdrop/script-tests/backdropfilter-property-computed-style.js: Added.

(testComputedFilterRule):

css3/filters/backdrop/script-tests/backdropfilter-property-parsing-invalid.js: Added.

(testInvalidFilterRule):

css3/filters/backdrop/script-tests/backdropfilter-property-parsing.js: Added.

(jsWrapperClass):
(shouldBeType):
(testFilterRule):

css3/filters/backdrop/script-tests/backdropfilter-property.js: Added.

9:47 PM Changeset in webkit [175671] by dburkart@apple.com

2 edits in branches/safari-600.3-branch/Source/WebKit2

Merged r175591. <rdar://problems/18871842>

9:44 PM Changeset in webkit [175670] by dburkart@apple.com

2 edits in branches/safari-600.3-branch/Source/WebKit2

Merged r175589. <rdar://problems/18871842>

9:35 PM Changeset in webkit [175669] by ryuan.choi@gmail.com

7 edits in trunk/Source/WebKit2

[EFL] Improve previous temporary fix against drawing (0,0) position before rendering content of next web page
https://bugs.webkit.org/show_bug.cgi?id=138305

Reviewed by Gyuyoung Kim.

WebKit2 has freezed layer tree until frame load completion since r101838.
In EFL port, we unfreeze it when PageViewportController::pageTransitionViewportReady() is called though,
UIProcess on EFL port updates cairo surface during the freezing time of layer tree.
Thus UIProcess should not update the layer trees until the layerTreeState is unfrozen.

UIProcess/API/efl/EwkView.h: Removed previous workarounds.

(EwkView::setWaitingForNewPage): Deleted.
(EwkView::waitingForNewPage): Deleted.
(EwkView::didCommitNewPage): Deleted.

UIProcess/CoordinatedGraphics/PageViewportController.cpp:

(WebKit::PageViewportController::PageViewportController):
(WebKit::PageViewportController::didCommitLoad):
(WebKit::PageViewportController::didRenderFrame):
(WebKit::PageViewportController::syncVisibleContents):

UIProcess/CoordinatedGraphics/PageViewportController.h:
UIProcess/efl/PageLoadClientEfl.cpp:

(WebKit::PageLoadClientEfl::didCommitLoadForFrame):

UIProcess/efl/PageViewportControllerClientEfl.cpp:

(WebKit::PageViewportControllerClientEfl::didChangeVisibleContents):

UIProcess/efl/ViewClientEfl.cpp:

(WebKit::ViewClientEfl::didRenderFrame):

9:31 PM Changeset in webkit [175668] by dburkart@apple.com

3 edits in branches/safari-600.3-branch/Source/WebKit2

Merged r175610. <rdar://problems/18869345>

9:28 PM Changeset in webkit [175667] by dburkart@apple.com

11 edits in branches/safari-600.3-branch/Source

Merged r175609. <rdar://problems/18869345>

9:24 PM Changeset in webkit [175666] by dburkart@apple.com

8 edits in branches/safari-600.3-branch/Source

Merged r175597. <rdar://problems/18875579>

9:19 PM Changeset in webkit [175665] by dburkart@apple.com

2 edits in branches/safari-600.3-branch/Source/WebKit2

Merged r175568. <rdar://problems/18840102>

9:14 PM Changeset in webkit [175664] by dburkart@apple.com

16 edits
2 moves in branches/safari-600.3-branch/Source

Merged r175564. <rdar://problems/18840102>

9:04 PM Changeset in webkit [175663] by dburkart@apple.com

3 edits in branches/safari-600.3-branch/Source/WebKit2

Merged r175524. <rdar://problems/18861406>

8:52 PM Changeset in webkit [175662] by dburkart@apple.com

3 edits in branches/safari-600.3-branch/Source/WebKit2

Merged r175517. <rdar://problems/18861406>

8:24 PM Changeset in webkit [175661] by dburkart@apple.com

9 edits in branches/safari-600.3-branch/Source/WebKit2

Merge r175498. rdar://problem/18742371

8:12 PM Changeset in webkit [175660] by dburkart@apple.com

4 edits in branches/safari-600.3-branch/Source/WebCore

Merged r175375. <rdar://problems/18883807>

8:09 PM Changeset in webkit [175659] by Chris Dumez

4 edits in trunk/Source/WebCore

Move 'size' CSS property to the new StyleBuilder
https://bugs.webkit.org/show_bug.cgi?id=138337

Reviewed by Andreas Kling.

Move 'size' CSS property from DeprecatedStyleBuilder to the new
StyleBuilder by using custom code as it requires special handling.

No new tests, new behavior change.

css/CSSPropertyNames.in:
css/DeprecatedStyleBuilder.cpp:

(WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder):
(WebCore::ApplyPropertyPageSize::mmLength): Deleted.
(WebCore::ApplyPropertyPageSize::inchLength): Deleted.
(WebCore::ApplyPropertyPageSize::getPageSizeFromName): Deleted.
(WebCore::ApplyPropertyPageSize::applyInheritValue): Deleted.
(WebCore::ApplyPropertyPageSize::applyInitialValue): Deleted.
(WebCore::ApplyPropertyPageSize::applyValue): Deleted.
(WebCore::ApplyPropertyPageSize::createHandler): Deleted.

css/StyleBuilderCustom.h:

(WebCore::StyleBuilderFunctions::mmLength):
(WebCore::StyleBuilderFunctions::inchLength):
(WebCore::StyleBuilderFunctions::getPageSizeFromName):
(WebCore::StyleBuilderFunctions::applyInheritSize):
(WebCore::StyleBuilderFunctions::applyInitialSize):
(WebCore::StyleBuilderFunctions::applyValueSize):

8:06 PM Changeset in webkit [175658] by commit-queue@webkit.org

4 edits
2 deletes in trunk/Source/WebInspectorUI

Unreviewed, rolling out r175628.
https://bugs.webkit.org/show_bug.cgi?id=138451

Totally borked the web inspector (Requested by smfr on
#webkit).

Reverted changeset:

"Web Inspector: Add infrastructure for eslint based static
analyzer"
https://bugs.webkit.org/show_bug.cgi?id=137890
http://trac.webkit.org/changeset/175628

6:37 PM Changeset in webkit [175657] by Chris Dumez

2 edits in trunk/Source/WebCore

Revert r175441 as it seems to be causing intermittent crashes in DOMTimer
https://bugs.webkit.org/show_bug.cgi?id=138449

Unreviewed roll out.

Revert r175441 as it seems to be causing intermittent crashes in DOMTimer due
to the scriptExecutionContext going away. See <rdar://problem/18883681>.

page/DOMTimer.cpp:

(WebCore::DOMTimer::install):
(WebCore::DOMTimer::fired):
(WebCore::NestedTimersVector::NestedTimersVector): Deleted.
(WebCore::NestedTimersVector::~NestedTimersVector): Deleted.
(WebCore::NestedTimersVector::registerTimer): Deleted.
(WebCore::NestedTimersVector::begin): Deleted.
(WebCore::NestedTimersVector::end): Deleted.

6:21 PM Changeset in webkit [175656] by Simon Fraser

5 edits
4 adds in trunk

Avoid backing store for opacity:0 descendant layers
https://bugs.webkit.org/show_bug.cgi?id=138448

Reviewed by Dean Jackson.

Source/WebCore:

If a composited layer has no rendered content but a painting zero-opacity descendant
layer, than we can avoid making backing store.

When the opacity on such a child changes, we need to trigger a tree rebuild
to force the backing store to come back (this could be optimized later).

Tests: compositing/backing/no-backing-for-opacity-0-child.html

compositing/backing/toggle-opacity-0-child.html

rendering/RenderLayer.cpp:

(WebCore::RenderLayer::calculateClipRects):

rendering/RenderLayerCompositor.cpp:

(WebCore::styleChangeRequiresLayerRebuild):

rendering/RenderObject.cpp:

(WebCore::RenderObject::containerForRepaint):

LayoutTests:

Test for no backing store with opacity:0 child, and that we get backing
store when dynamically changing the opacity to non-0.

compositing/backing/no-backing-for-opacity-0-child-expected.txt: Added.
compositing/backing/no-backing-for-opacity-0-child.html: Added.
compositing/backing/toggle-opacity-0-child-expected.txt: Added.
compositing/backing/toggle-opacity-0-child.html: Added.

6:21 PM Changeset in webkit [175655] by Chris Dumez

5 edits in trunk/Source

Assertion hit DOMTimer::updateTimerIntervalIfNecessary()
https://bugs.webkit.org/show_bug.cgi?id=138440

Reviewed by Geoffrey Garen.

Source/WebCore:

We sometimes hit the ASSERT(repeatInterval() == previousInterval)
assertion in DOMTimer::updateTimerIntervalIfNecessary() when visiting
the following pages:
http://lifehacker.com/the-healthiest-foods-for-one-handed-snacking-while-gami-1654728164
http://longform.org/posts/like-something-the-lord-made

After debugging, the issue turned out to be that we are comparing
floating point numbers using ==, and the check sometimes fails even
though the values really close to each other. This patch updates the
DOMTimer code to use WTF::withinEpsilon() instead of operator==()
to compare the floating point intervals.

I confirmed manually that the assertion is no longer hit.

page/DOMTimer.cpp:

(WebCore::DOMTimer::updateTimerIntervalIfNecessary):

platform/graphics/FloatQuad.cpp:

(WebCore::FloatQuad::isRectilinear):
(WebCore::withinEpsilon): Deleted.

Source/WTF:

Move the withinEpsilon() function to WTF to avoid code duplication.

wtf/MathExtras.h:

(WTF::withinEpsilon):

6:16 PM Changeset in webkit [175654] by Chris Fleizach

6 edits
2 adds in trunk

AX: add "alt" as an overriding synonym of "-webkit-alt" (now in the CSS4 spec)
https://bugs.webkit.org/show_bug.cgi?id=138393

Reviewed by Dean Jackson.

Source/WebCore:

Add official "alt" CSS keyword and map -webkit-alt to that.

Test: platform/mac/accessibility/alt-for-css-content.html

css/CSSComputedStyleDeclaration.cpp:

(WebCore::ComputedStyleExtractor::propertyValue):

css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):

css/CSSPropertyNames.in:
css/StyleResolver.cpp:

(WebCore::StyleResolver::applyProperty):

LayoutTests:

platform/mac/accessibility/alt-for-css-content-expected.txt: Added.
platform/mac/accessibility/alt-for-css-content.html: Added.

5:53 PM Changeset in webkit [175653] by mark.lam@apple.com

2 edits in trunk/Source/JavaScriptCore

PutById inline caches should have a store barrier when it triggers a structure transition.
<https://webkit.org/b/138441>

Reviewed by Geoffrey Garen.

After r174025, we no longer insert DFG store barriers when the payload of a
PutById operation is not a cell. However, this can lead to a crash when we have
PutById inline cache code transitioning the structure and re-allocating the
butterfly of an old gen object. The lack of a store barrier in that inline
cache results in the old gen object not being noticed during an eden GC scan.
As a result, its newly allocated butterfly will not be kept alive, which leads
to a stale butterfly pointer and, eventually, a crash.

It is also possible that the new structure can be collected by the eden GC if
(at GC time):

It is in the eden gen.
The inline cache that installed it has been evicted.
There are no live eden gen objects referring to it.

The chances of this should be more rare than the butterfly re-allocation, but
it is still possible. Hence, the fix is to always add a store barrier if the
inline caches performs a structure transition.

jit/Repatch.cpp:

(JSC::emitPutTransitionStub):

Added store barrier code based on SpeculativeJIT::storeToWriteBarrierBuffer()'s implementation.

5:37 PM Changeset in webkit [175652] by gyuyoung.kim@samsung.com

2 edits in trunk/Source/WebCore

Unreviewed, EFL build fix since r175647

CMakeLists.txt: Remove DeleteButton.cpp and DeleteButtonController.cpp.

5:21 PM Changeset in webkit [175651] by gyuyoung.kim@samsung.com

4 edits in trunk/Source/JavaScriptCore

Use std::unique_ptr in JSClassRef and JSCallbackObject
https://bugs.webkit.org/show_bug.cgi?id=138402

Reviewed by Geoffrey Garen.

API/JSCallbackObject.h: Use std::unique_ptr instead of OwnPtr|PassOwnPtr.

(JSC::JSCallbackObjectData::setPrivateProperty): ditto.

API/JSClassRef.cpp: ditto.
API/JSClassRef.h: ditto.

4:53 PM Changeset in webkit [175650] by dburkart@apple.com

3 edits
3 adds in branches/safari-600.3-branch

Merged r174740. <rdar://problems/18883801>

4:18 PM Changeset in webkit [175649] by timothy_horton@apple.com

2 edits in trunk/Source/WebKit2

Fix the build.

UIProcess/mac/WKActionMenuController.mm:

4:16 PM Changeset in webkit [175648] by Chris Dumez

6 edits in trunk/Source

Allow constructing a PassRef from a Ref
https://bugs.webkit.org/show_bug.cgi?id=138389

Reviewed by Andreas Kling.

Source/WebCore:

Remove calls to Ref::get() now that a PassRef can be directly
constructed from a Ref.

No new tests, no behavior change.

css/CSSValuePool.cpp:

(WebCore::CSSValuePool::createColorValue):

css/CSSValuePool.h:

(WebCore::CSSValuePool::createInheritedValue):
(WebCore::CSSValuePool::createImplicitInitialValue):
(WebCore::CSSValuePool::createExplicitInitialValue):

html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::setCSSStyleSheet):

Source/WTF:

Allow constructing a PassRef from a Ref, similarly to PassRefPtr that
can be constructed from a RefPtr already. This avoids having to call
Ref::get() and simplifies the code a bit.

wtf/PassRef.h:

(WTF::PassRef<T>::PassRef):

4:09 PM Changeset in webkit [175647] by mitz@apple.com

31 edits
25 deletes in trunk

Remove the unused deletion UI feature
https://bugs.webkit.org/show_bug.cgi?id=138442

Rubber-stamped by Alexey Proskuryakov.

Source/WebCore:

Resources/deleteButton.png: Removed.
Resources/deleteButton@2x.png: Removed.
Resources/deleteButtonPressed.png: Removed.
Resources/deleteButtonPressed@2x.png: Removed.

WebCore.xcodeproj/project.pbxproj: Removed references to removed files.

dom/ContainerNode.cpp:

(WebCore::ContainerNode::cloneChildNodes): Folded the below helper function into this member
function, after removing the deleteButtonContainerElement parameter.
(WebCore::cloneChildNodesAvoidingDeleteButton): Deleted.

editing/CompositeEditCommand.cpp:

(WebCore::EditCommandComposition::unapply): Removed use of
DeleteButtonControllerDisableScope.
(WebCore::EditCommandComposition::reapply): Ditto.
(WebCore::CompositeEditCommand::apply): Ditto.

editing/DeleteButton.cpp: Removed.
editing/DeleteButton.h: Removed.
editing/DeleteButtonController.cpp: Removed.
editing/DeleteButtonController.h: Removed.

editing/EditCommand.cpp:

(WebCore::EditCommand::EditCommand): Removed use of
Editor::avoidIntersectionWithDeleteButtonController.

editing/Editor.cpp:

(WebCore::Editor::Editor): Removed initialization of m_deleteButtonController.
(WebCore::Editor::rangeForPoint): Removed use of avoidIntersectionWithDeleteButtonController.
(WebCore::Editor::editorUIUpdateTimerFired): Removed call to DeleteButtonController function.
(WebCore::Editor::avoidIntersectionWithDeleteButtonController): Deleted.
(WebCore::Editor::deviceScaleFactorChanged): Deleted.

editing/Editor.h:

(WebCore::Editor::deleteButtonController): Deleted.
(WebCore::Editor::avoidIntersectionWithDeleteButtonController): Deleted.

editing/MarkupAccumulator.cpp:

(WebCore::MarkupAccumulator::serializeNodes): Removed nodeToSkip parameter.
(WebCore::MarkupAccumulator::serializeNodesWithNamespaces): Ditto.

editing/MarkupAccumulator.h:

editing/markup.cpp:

(WebCore::createMarkupInternal): Removed updateRange parameter, which had become identical
to the range parameter, and changed to use the latter everywhere instead.
(WebCore::createMarkup): Don’t compute and pass separate updateRanage parameter.

loader/EmptyClients.h: Removed shouldShowDeleteInterface override.
page/EditorClient.h: Removed shouldShowDeleteInterface.

page/Page.cpp:

(WebCore::Page::setDeviceScaleFactor): Removed call to Editor::deviceScaleFactorChanged.

page/PageSerializer.cpp:

(WebCore::PageSerializer::serializeFrame): Updated for MarkupAccumulator::serializeNodes change.

testing/Internals.cpp:

(WebCore::Internals::findEditingDeleteButton): Deleted.

testing/Internals.h:
testing/Internals.idl:

Source/WebKit/mac:

DefaultDelegates/WebDefaultEditingDelegate.m:

(-[WebDefaultEditingDelegate webView:shouldShowDeleteInterfaceForElement:]): Deleted.

WebCoreSupport/WebEditorClient.h:
WebCoreSupport/WebEditorClient.mm:

(WebEditorClient::shouldShowDeleteInterface): Deleted.

WebView/WebEditingDelegatePrivate.h: Removed declaration of

-webView:shouldShowDeleteInterfaceForElement:.

Source/WebKit2:

WebProcess/WebCoreSupport/WebEditorClient.cpp:

(WebKit::WebEditorClient::shouldShowDeleteInterface): Deleted.

WebProcess/WebCoreSupport/WebEditorClient.h:

Source/WTF:

wtf/FeatureDefines.h: Removed definition of ENABLE_DELETION_UI.

Tools:

DumpRenderTree/mac/EditingDelegate.mm:

(-[EditingDelegate webView:shouldShowDeleteInterfaceForElement:]): Deleted implementation of
delegate method that’s been removed.

LayoutTests:

Removed tests, expected results, and support files for this feature.

platform/mac/editing/deleting/deletionUI-borders-expected.txt: Removed.
platform/mac/editing/deleting/deletionUI-borders.html: Removed.
platform/mac/editing/deleting/deletionUI-click-on-delete-button-expected.txt: Removed.
platform/mac/editing/deleting/deletionUI-click-on-delete-button.html: Removed.
platform/mac/editing/deleting/deletionUI-differing-background-expected.txt: Removed.
platform/mac/editing/deleting/deletionUI-differing-background.html: Removed.
platform/mac/editing/deleting/deletionUI-minimum-size-expected.txt: Removed.
platform/mac/editing/deleting/deletionUI-minimum-size.html: Removed.
platform/mac/editing/deleting/deletionUI-single-instance-expected.png: Removed.
platform/mac/editing/deleting/deletionUI-single-instance-expected.txt: Removed.
platform/mac/editing/deleting/deletionUI-single-instance.html: Removed.
platform/mac/editing/deleting/deletionUI-successful-deletion-expected.txt: Removed.
platform/mac/editing/deleting/deletionUI-successful-deletion.html: Removed.
platform/mac/editing/deleting/id-in-deletebutton-expected.txt: Removed.
platform/mac/editing/deleting/id-in-deletebutton.html: Removed.
platform/mac/editing/deleting/resources: Removed.
platform/mac/editing/deleting/resources/deletionUI-helpers.js: Removed.
platform/wk2/TestExpectations:

3:53 PM Changeset in webkit [175646] by timothy_horton@apple.com

2 edits in trunk/Source/WebKit2

It should be possible to open a page preview by clicking on it
https://bugs.webkit.org/show_bug.cgi?id=138445

Reviewed by Tim Horton.
Patch by Conrad Shultz.

Add a click recognizer to WKPagePreviewViewController and plumb it through to WKActionMenuController.

UIProcess/mac/WKActionMenuController.mm:

Declare <WKPagePreviewViewControllerDelegate>, currently home to just a single method.
(-[WKPagePreviewViewController loadView]):
Configure and add a click gesture recognizer to the WKWebView.
(-[WKPagePreviewViewController _clickRecognized:]):
Gesture recognizer action; send -pagePreviewViewControllerWasClicked: to the delegate.
(-[WKActionMenuController willDestroyView:]):
Extract code to -_clearPreviewPopover.
(-[WKActionMenuController didCloseMenu:withEvent:]):
Ditto.
(-[WKActionMenuController _createPreviewPopoverForURL:]):
Set ourself as the delegate of the page preview controller.
(-[WKActionMenuController _clearPreviewPopover]):
Extracted from various other methods; if appropriate, nil out the preview view controller's delegate.
(-[WKActionMenuController popoverWillClose:]):
Extract code to -_clearPreviewPopover.
(-[WKActionMenuController pagePreviewViewControllerWasClicked:]):
WKPagePreviewViewControllerDelegate method; open the URL of the clicked page.

3:31 PM Changeset in webkit [175645] by Beth Dakin

2 edits in trunk/Source/WebKit2

Page preview popover should show scaled-down web content
https://bugs.webkit.org/show_bug.cgi?id=138444

Reviewed by Anders Carlsson.

Instead of keeping the preferred size in the controller, keep the main view’s
size, and then scale the bounds of the popover’s view using that and the scale
factor as a constant. Set the size of the popover explicitly so that it doesn’t
get the view’s size. This will cause it to scale the WKWebView.

UIProcess/mac/WKActionMenuController.mm:

(-[WKPagePreviewViewController initWithPageURL:]):
(-[WKPagePreviewViewController loadView]):
(-[WKActionMenuController _createPreviewPopoverForURL:originRect:]):
(-[WKActionMenuController _preferredSizeForPopoverPresentedFromOriginRect:]):

3:20 PM Changeset in webkit [175644] by msaboff@apple.com

3 edits in trunk/Source/JavaScriptCore

Disable flakey float32-repeat-out-of-bounds.js and int8-repeat-out-of-bounds.js tests for ARM64
https://bugs.webkit.org/show_bug.cgi?id=138381

Reviewed by Mark Lam.

Disabled these test for ARM64. Will address the failures and then re-enable.

tests/stress/float32-repeat-out-of-bounds.js:
tests/stress/int8-repeat-out-of-bounds.js:

2:52 PM Changeset in webkit [175643] by Beth Dakin

2 edits in trunk/Source/WebKit2

Page preview popovers sometimes cover their originating element
https://bugs.webkit.org/show_bug.cgi?id=138437

Patch by Conrad Shultz <Conrad Shultz> on 2014-11-05
Reviewed by Beth Dakin.

If a popover is sufficiently large, and the originating element is in a particular location, it's
possible that the popover can't be positioned in a manner that doesn't occlude the originating element.
Address this by scaling down the popover content if it can't fit entirely between the originating
element and the screen edge.

UIProcess/mac/WKActionMenuController.mm:

(-[WKActionMenuController _previewURLFromActionMenu:]):
Update to use -_createPreviewPopoverForURL:originRect:.
(-[WKActionMenuController _createPreviewPopoverForURL:originRect:]):
Renamed from -_createPreviewPopoverForURL:; extract code to -_preferredSizeForPopoverPresentedFromOriginRect:.
(-[WKActionMenuController _preferredSizeForPopoverPresentedFromOriginRect:]):
Compute a size that is as large as possible while keeping the popover between the origin rect and screen edge
(with an arbitrary padding applied to keep from directly abutting the screen edge).
(-[WKActionMenuController _createPreviewPopoverForURL:]): Deleted.

2:50 PM Changeset in webkit [175642] by commit-queue@webkit.org

2 edits in trunk/Source/WebInspectorUI

Web Inspector: Specificity not shown for pseudo element styles
https://bugs.webkit.org/show_bug.cgi?id=138436

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-11-05
Reviewed by Benjamin Poulain.

UserInterface/Views/CSSStyleDeclarationSection.js:

(WebInspector.CSSStyleDeclarationSection.prototype.refresh):
Previously we were skipping the pre-selector <span>s when we were
not getting a listing of matched selector indices, and missing out
on the opportunity to give each selector a specificity. Now, always
loop over selectors if we have them.

1:26 PM Changeset in webkit [175641] by hyatt@apple.com

4 edits in trunk

Descendant ends up in wrong flow thread with nested columns and spans.
https://bugs.webkit.org/show_bug.cgi?id=137273

Reviewed by Simon Fraser.

Unskipped the two problematic span tests.

Source/WebCore:

rendering/RenderMultiColumnFlowThread.cpp:

(WebCore::isValidColumnSpanner):
Remove the guard and comment and added the assertion back in.

(WebCore::RenderMultiColumnFlowThread::flowThreadDescendantInserted):
Changed to no longer use handleSpannerRemoval. Because the spanner was removed from the flow thread's map,
handleSpannerRemoval was a no-op. So instead I just removed the placeholder by hand.

The second fix was to stop destroying the placeholder. Since the placeholder can just have been inserted, you
can't delete it, since otherwise code further up the stack will access the deleted object. For now, we just
leak the placeholder.

The third fix is to make sure the subtreeRoot is properly updated to be the new placeholder.

LayoutTests:

TestExpectations:

1:22 PM Changeset in webkit [175640] by akling@apple.com

3 edits in trunk/Source/WebCore

RenderBlock shouldn't need a pre-destructor hook.
<https://webkit.org/b/138430>

Reviewed by Antti Koivisto.

All that was interesting in RenderBlock::willBeDestroyed() has migrated
to RenderBlockFlow. removeFromUpdateScrollInfoAfterLayoutTransaction()
can be called from the plain destructor, so just move it there.

We don't have to worry about destroyLeftoverChildren(), since RenderElement
will take care of that for us.

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::~RenderBlock):
(WebCore::RenderBlock::willBeDestroyed): Deleted.

rendering/RenderBlock.h:

1:21 PM Changeset in webkit [175639] by Chris Dumez

5 edits in trunk/Source/WebCore

Remove 2 unnecessary virtual functions on InputType
https://bugs.webkit.org/show_bug.cgi?id=138433

Reviewed by Andreas Kling.

Remove 2 unused virtual functions on InputType:

valueAttributeChanged()
updateClearButtonVisibility()

No new tests, no behavior change.

html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::parseAttribute):
(WebCore::HTMLInputElement::updateClearButtonVisibility): Deleted.

html/HTMLInputElement.h:
html/InputType.cpp:

(WebCore::InputType::valueAttributeChanged): Deleted.
(WebCore::InputType::updateClearButtonVisibility): Deleted.

html/InputType.h:

1:21 PM Changeset in webkit [175638] by ap@apple.com

5 edits in trunk

fast/dom/remove-body-during-body-replacement2.html fails on WK2
https://bugs.webkit.org/show_bug.cgi?id=138334

Reviewed by Anders Carlsson.

Source/WebKit2:

Added an SPI to focus a frame.

WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:

(WKBundleFrameFocus):

WebProcess/InjectedBundle/API/c/WKBundleFramePrivate.h:
WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::setViewState):

Tools:

Reset focus to main frame between tests. DumpRenderTree does this via -makeFirstResponder
calls, which works because each frame is an NSView in WK1. WK2 makes equivalent
-makeFirstResponder calls, which may or may not be needed for other reasons, but
it also needs to reset internal focus explicitly.

It's not clear if this is the right long-term fix or a workaround for a WebKit bug.
WebKit behavior appears wrong, but it matches Firefox.

WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::resetAfterTest):

1:13 PM Changeset in webkit [175637] by timothy_horton@apple.com

7 edits in trunk/Source/WebKit2

Select Data Detectors results instead of just highlighting them
https://bugs.webkit.org/show_bug.cgi?id=138435
<rdar://problem/18877675>

Reviewed by Beth Dakin.

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::selectLastActionMenuRange):
(WebKit::WebPageProxy::selectLookupTextAtLocation): Deleted.
Rename selectLookupTextAtLocation to selectLastActionMenuRange.

UIProcess/WebPageProxy.h:
UIProcess/mac/WKActionMenuController.mm:

(-[WKActionMenuController willOpenMenu:withEvent:]):
Do a real selection for single-item Data Detector menus; show the yellow highlight otherwise.
Adopt selectLastActionMenuRange for non-detected text.

WebProcess/WebPage/WebPage.h:
WebProcess/WebPage/WebPage.messages.in:
WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::performActionMenuHitTestAtLocation):
(WebKit::WebPage::selectLastActionMenuRange):
(WebKit::WebPage::selectLookupTextAtLocation): Deleted.
Store the last (detected data or Lookup-derived) action menu range.
Select it upon selectLastActionMenuRange.

12:55 PM Changeset in webkit [175636] by jhoneycutt@apple.com

2 edits in trunk/Source/WebKit2

WebContent crash in WebPage::selectWithGesture()

<https://bugs.webkit.org/show_bug.cgi?id=138399>
<rdar://problem/18550631>

This crash occurs when the web process receives a "TapAndAHalf" gesture
with the "Changed" state without having received a "TapAndAHalf"
gesture with the "Began" state.

No test possible.

Reviewed by Simon Fraser.

WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::selectWithGesture):
Null check m_currentWordRange before dereferencing it.

12:48 PM Changeset in webkit [175635] by commit-queue@webkit.org

4 edits in trunk/Source/WebKit2

Disable action menus on page previews
https://bugs.webkit.org/show_bug.cgi?id=138431

Patch by Conrad Shultz <Conrad Shultz> on 2014-11-05
Reviewed by Anders Carlsson.

UIProcess/API/mac/WKView.mm:

(-[WKView _shouldIgnoreMouseEvents]):
Renamed from -shouldIgnoreMouseEvents since this isn't actually public.
(-[WKView swipeWithEvent:]):
(-[WKView mouseMoved:]):
(-[WKView mouseDown:]):
(-[WKView mouseUp:]):
(-[WKView mouseDragged:]):
Updated to reflect method rename.
(-[WKView shouldIgnoreMouseEvents]): Deleted.

UIProcess/API/mac/WKViewInternal.h:

Expose -_shouldIgnoreMouseEvents.

UIProcess/mac/WKActionMenuController.mm:

(-[WKActionMenuController prepareForMenu:withEvent:]):
Cancel the menu if the presenting WKView should ignore mouse events.

12:36 PM Changeset in webkit [175634] by matthew_hanson@apple.com

2 edits in branches/safari-600.3-branch/Source/JavaScriptCore

Merged r175629. <rdar://problems/18883540>

12:28 PM Changeset in webkit [175633] by Bem Jones-Bey

2 edits in trunk/LayoutTests

[CSS Shapes] Positioned polygon reftests failing again
https://bugs.webkit.org/show_bug.cgi?id=138058

Reviewed by Anders Carlsson.

Remove these tests from TestExpectations since they do pass.

TestExpectations:

12:15 PM Changeset in webkit [175632] by Beth Dakin

3 edits in trunk/Source/WebKit2

Action menu URL preview should "peek," i.e. appear when the menu item is
highlighted
https://bugs.webkit.org/show_bug.cgi?id=138432
-and corresponding-
rdar://problem/18774264

Reviewed by Anders Carlsson.

New ivars. Keep a reference to the popover, and a BOOL that indicates whether we
should close the popover when the menu goes away.

UIProcess/mac/WKActionMenuController.h:
UIProcess/mac/WKActionMenuController.mm:

Re-set the preview bool to NO whenever we are about to pop up a new menu.
(-[WKActionMenuController prepareForMenu:withEvent:]):

Close the popover when the menu closes unless _shouldKeepPreviewPopoverOpen has
been set.
(-[WKActionMenuController didCloseMenu:withEvent:]):

Set _shouldKeepPreviewPopoverOpen.
(-[WKActionMenuController _keepPreviewOpen:]):

Re-factored to use ivar.
(-[WKActionMenuController _previewURLFromActionMenu:]):
(-[WKActionMenuController _createPreviewPopoverForURL:]):

Now call _previewURLFromActionMenu on menu item highlight.
(-[WKActionMenuController menu:willHighlightItem:]):

NSPopover delegate method so that we can keep our BOOL and ivar accurate in the
case where the popover is closed by some other mechanism than the action menu
going away.
(-[WKActionMenuController popoverWillClose:]):

New selector for the preview. Now when this item is actually selected, we just
want to set the BOOL _shouldKeepPreviewPopoverOpen to YES so that we keep the
preview open.
(-[WKActionMenuController _createActionMenuItemForTag:]):

12:10 PM Changeset in webkit [175631] by Bem Jones-Bey

6 edits in trunk/LayoutTests

[CSS Shapes] shape-image-threshold parsing tests have a few failures
https://bugs.webkit.org/show_bug.cgi?id=138060

Reviewed by Dirk Schulze.

Remove testing for inline style from the CSSWG test because it isn't
specified and isn't consistent across browsers. This has been updated
upstream as well.

Add inline style tests to the WebKit test suite to make sure that
WebKIt doesn't lose coverage with this change.

TestExpectations:
css3/shapes/shape-outside/values/shape-image-threshold-001-expected.txt:
css3/shapes/shape-outside/values/shape-image-threshold-001.html:
fast/shapes/parsing/parsing-shape-image-threshold-expected.txt:
fast/shapes/parsing/parsing-shape-image-threshold.html:

12:09 PM Changeset in webkit [175630] by commit-queue@webkit.org

6 edits in trunk/Source/WebKit2

Disable interaction with action menu page previews
https://bugs.webkit.org/show_bug.cgi?id=138400

Patch by Conrad Shultz <Conrad Shultz> on 2014-11-05
Reviewed by Tim Horton.

Expand on the existing -[WKView shouldIgnoreMouseEvents] by adding facilities to suppress handling
of all non-wheel events, effectively creating a scroll-only web view. Deploy this in
WKPagePreviewViewController.

UIProcess/API/Cocoa/WKViewPrivate.h:

Declare the OS X-only ignoresNonWheelMouseEvents SPI.

UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _ignoresNonWheelMouseEvents]):
(-[WKWebView _setIgnoresNonWheelMouseEvents:]):
Wrap the underlying WKView methods.

UIProcess/API/Cocoa/WKWebViewInternal.h:

Declare the OS X-only ignoresNonWheelMouseEvents property.

UIProcess/API/mac/WKView.mm:

Add _ignoresNonWheelMouseEvents to WKViewData.
(-[WKView shouldIgnoreMouseEvents]):
Include a check for _ignoresNonWheelMouseEvents.
(-[WKView _setIgnoresNonWheelMouseEvents:]):
Set the ivar in WKViewData.
(-[WKView _ignoresNonWheelMouseEvents]):
Fetch the ivar in WKViewData.
(-[WKView _shouldIgnoreWheelEvents]):
Implement the old -shouldIgnoreMouseEvents behavior.
(-[WKView scrollWheel:]):
-shouldIgnoreMouseEvents -> -_shouldIgnoreWheelEvents.

UIProcess/mac/WKActionMenuController.mm:

(-[WKPagePreviewViewController loadView]):
Configure the WKWebView to ignore non-wheel mouse events; use RetainPtr for the WKWebView.

11:57 AM Changeset in webkit [175629] by ap@apple.com

2 edits in trunk/Source/JavaScriptCore

Incorrect sandbox_check in RemoteInspector.mm
https://bugs.webkit.org/show_bug.cgi?id=138408

Reviewed by Joseph Pecoraro.

inspector/remote/RemoteInspector.mm:

(Inspector::canAccessWebInspectorMachPort):

10:43 AM Changeset in webkit [175628] by jonowells@apple.com

4 edits
2 adds in trunk/Source/WebInspectorUI

Web Inspector: Add infrastructure for eslint based static analyzer
https://bugs.webkit.org/show_bug.cgi?id=137890

Reviewed by Timothy Hatcher.

Adding a manager to analyze source code, return warnings (AnalyzerMessages), and cache warnings.

UserInterface/Base/Main.js: Create analyzerManager singleton.
UserInterface/Controllers/AnalyzerManager.js: Added.

(WebInspector.AnalyzerManager):
(set WebInspector.AnalyzerManager.prototype.getAnalyzerMessagesForSourceCode.):
(set WebInspector.AnalyzerManager.prototype.getAnalyzerMessagesForSourceCode):
(set WebInspector.AnalyzerManager.prototype.set get sourceCodeCanBeAnalyzed):
(set WebInspector.AnalyzerManager.prototype._handleSourceCodeContentDidChange):

UserInterface/Main.html: Add new files.
UserInterface/Models/AnalyzerMessage.js: Added.

(WebInspector.AnalyzerMessage):
(WebInspector.AnalyzerMessage.prototype.get sourceCodeLocation):
(WebInspector.AnalyzerMessage.prototype.get sourceCode):
(WebInspector.AnalyzerMessage.prototype.get text):
(WebInspector.AnalyzerMessage.prototype.get ruleIdentifier):

UserInterface/Models/SourceCode.js: Added call to WebInspector.Object.addConstructorFunctions().

10:43 AM Changeset in webkit [175627] by Chris Dumez

2 edits in trunk/Source/WebCore

Re-evaluate if a repetitive timer should be throttled upon firing
https://bugs.webkit.org/show_bug.cgi?id=138339

Reviewed by Gavin Barraclough.

Re-evaluate if a repetitive timer should be throttled upon firing in
case the plugin observability state has changed:

It used to be visible but now isn't and thus the timer can be throttled
It used to play audio but now doesn't and thus the timer can be throttled

We already stopped throttling if the plugin became observable. However,
we didn't start throttling if the plugin became non-observable.

page/DOMTimer.cpp:

(WebCore::DOMTimer::updateThrottlingStateIfNecessary):

10:27 AM Changeset in webkit [175626] by dino@apple.com

16 edits in trunk

Add ENABLE_FILTERS_LEVEL_2 feature guard.
https://bugs.webkit.org/show_bug.cgi?id=138362

Reviewed by Tim Horton.

Add a new feature define for Level 2 of CSS Filters.
http://dev.w3.org/fxtf/filters-2/

Source/cmake/OptionsEfl.cmake:
Source/cmake/OptionsGTK.cmake:
Source/cmake/OptionsMac.cmake:
Source/cmake/WebKitFeatures.cmake:
Source/cmakeconfig.h.cmake:

Source/JavaScriptCore:

Configurations/FeatureDefines.xcconfig:

Source/WebCore:

Configurations/FeatureDefines.xcconfig:

Source/WebKit/mac:

Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

Configurations/FeatureDefines.xcconfig:

Source/WTF:

wtf/FeatureDefines.h:

10:24 AM Changeset in webkit [175625] by Chris Dumez

4 edits in trunk/Source/WebCore

Move text-align CSS property to the new StyleBuilder
https://bugs.webkit.org/show_bug.cgi?id=138398

Reviewed by Antti Koivisto.

Move text-align CSS property from DeprecatedStyleBuilder to the new
StyleBuilder so that it is now generated from CSSPropertyNames.in.
This patch adds a TextAlign Converter to support this.

No new tests, no behavior change.

css/CSSPropertyNames.in:
css/DeprecatedStyleBuilder.cpp:

(WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder):
(WebCore::ApplyPropertyTextAlign::applyValue): Deleted.
(WebCore::ApplyPropertyTextAlign::createHandler): Deleted.

css/StyleBuilderConverter.h:

(WebCore::StyleBuilderConverter::convertTextAlign):

9:45 AM Changeset in webkit [175624] by Csaba Osztrogonác

2 edits in trunk/Source/WTF

Enable ARMv7 disassembler for all platforms
https://bugs.webkit.org/show_bug.cgi?id=138415

Reviewed by Darin Adler.

wtf/Platform.h:

9:42 AM Changeset in webkit [175623] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Fix build warning in SVGMarkerElement.cpp
https://bugs.webkit.org/show_bug.cgi?id=138407

Patch by Sanghyup Lee <sh53.lee@samsung.com> on 2014-11-05
Reviewed by Darin Adler.

Build warning in debug cause 'comparison of unsigned expression >= 0 is always true [-Wtype-limits]'

svg/SVGMarkerElement.cpp:

(WebCore::SVGMarkerElement::orientType): Removed useless condition in ASSERT.

9:41 AM Changeset in webkit [175622] by Chris Dumez

6 edits
2 adds in trunk

Stop special-casing the empty string in HTMLInputElement.type setter
https://bugs.webkit.org/show_bug.cgi?id=138403

Reviewed by Ryosuke Niwa.

Source/WebCore:

Stop special-casing the empty string in HTMLInputElement.type setter.
Previously, if input.type is set to "", we would remove the type
attribute. This is inconsistent with the specification and the behavior
of other browsers (tested Firefox 33 and Chrome 38). Instead, we should
set the attribute to the empty string.

Also stop treating null as a null string to align with the
specification and other browsers (tested Firefox 33 and Chrome 38).

Finally, update HTMLInputElement::setType() to take an AtomicString in
argument instead of a String as it ends up calling setAttribute(), and
thus needing an AtomicString.

Test: fast/dom/HTMLInputElement/input-type-attribute.html

html/FileInputType.cpp:

(WebCore::UploadButtonElement::UploadButtonElement):

html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::setType):

html/HTMLInputElement.h:
html/HTMLInputElement.idl:

LayoutTests:

Add layout test to check the functionality of the HTMLInputElement.type
getter and setter.

fast/dom/HTMLInputElement/input-type-attribute-expected.txt: Added.
fast/dom/HTMLInputElement/input-type-attribute.html: Added.

9:35 AM Changeset in webkit [175621] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[WinCairo] Compile error, missing guard.
https://bugs.webkit.org/show_bug.cgi?id=138421

Patch by peavo@outlook.com <peavo@outlook.com> on 2014-11-05
Reviewed by Brent Fulgham.

There is missing a guard for CSS_SELECTORS_LEVEL4 in CSSParserValues.cpp.

css/CSSParserValues.cpp:

8:52 AM ASanWebKit edited by Bem Jones-Bey

Update with my learnings (diff)

7:07 AM Changeset in webkit [175620] by Antti Koivisto

2 edits in trunk/Source/WebCore

REGRESSION(r175601): Assertion failures in SimpleLineLayout
https://bugs.webkit.org/show_bug.cgi?id=138422

Check for end.

rendering/SimpleLineLayout.cpp:

(WebCore::SimpleLineLayout::FlowContentIterator::isNewlineCharacter):
(WebCore::SimpleLineLayout::removeTrailingWhitespace):

5:29 AM Changeset in webkit [175619] by berto@igalia.com

2 edits in trunk/Source/WebKit2

NetscapePlugin: NPP_GetValue should receive a pointer to NPBool, not bool
https://bugs.webkit.org/show_bug.cgi?id=138418

Reviewed by Carlos Garcia Campos.

Replace bool with NPBool, which is actually an unsigned char.

WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:

(WebKit::NetscapePlugin::platformPostInitialize):

2:54 AM Changeset in webkit [175618] by Carlos Garcia Campos

6 edits in trunk

[GTK] Add WebKitWebResource::failed-with-tls-errors signal
https://bugs.webkit.org/show_bug.cgi?id=137862

Reviewed by Gustavo Noronha Silva.

Source/WebKit2:

When a resource load fails due to TLS errors emit WebKitWebResource::failed-with-tls-errors
signal instead of WebKitWebResource::failed so that TLS errors information and certificate
are provided.

UIProcess/API/gtk/WebKitInjectedBundleClient.cpp:

(didReceiveWebViewMessageFromInjectedBundle): Check if the error
is a TLS failure to emit failed-with-tls-errors instead of failed.

UIProcess/API/gtk/WebKitWebResource.cpp:

(webkit_web_resource_class_init): Add WebKitWebResource::failed-with-tls-errors signal.
(webkitWebResourceFailedWithTLSErrors): Emit failed-with-tls-errors and finish signals.

UIProcess/API/gtk/WebKitWebResourcePrivate.h:

Tools:

Add a test case to check that WebKitWebResource::failed-with-tls-errors
is emitted when a subresource load fails due to TLS errors.

TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:

(TLSSubresourceTest::resourceLoadStartedCallback):
(TLSSubresourceTest::TLSSubresourceTest):
(TLSSubresourceTest::subresourceFailedCallback):
(TLSSubresourceTest::subresourceFailedWithTLSErrorsCallback):
(TLSSubresourceTest::subresourceLoadStarted):
(TLSSubresourceTest::subresourceFailedWithTLSErrors):
(TLSSubresourceTest::waitUntilSubresourceLoadFail):
(testSubresourceLoadFailedWithTLSErrors):
(httpsServerCallback):
(httpServerCallback):
(beforeAll):

2:12 AM Changeset in webkit [175617] by akling@apple.com

3 edits
2 adds in trunk

Simple line layout: support text-transform: lowercase|uppercase|capitalize
<https://webkit.org/b/138406>

Reviewed by Antti Koivisto.

Source/WebCore:

Expand the simple line layout coverage to include all text-transform values.
Since the property works on the text string level, it's really only a matter
of removing the short-circuit.

Test: fast/text/simple-lines-text-transform.html

rendering/SimpleLineLayout.cpp:

(WebCore::SimpleLineLayout::canUseFor):

LayoutTests:

Add ref test for simple line layout with all text-transform values.

fast/text/simple-lines-text-transform-expected.html: Added.
fast/text/simple-lines-text-transform.html: Added.

2:01 AM Changeset in webkit [175616] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit2

Fix build warning in WebKit2/WebProcess module.
https://bugs.webkit.org/show_bug.cgi?id=138410

Patch by Shivakumar JM <shiva.jm@samsung.com> on 2014-11-05
Reviewed by Alexey Proskuryakov.

Fix build warning by removing parameter name

WebProcess/WebPage/WebPageOverlay.h:

(WebKit::WebPageOverlay::Client::prepareForActionMenu):

1:56 AM Changeset in webkit [175615] by jer.noble@apple.com

4 edits in trunk/Source/WebCore

[EME][Mac] Allow the client to specify FPS protocol versions in the keySystem type field.
https://bugs.webkit.org/show_bug.cgi?id=138380

Reviewed by Eric Carlson.

Parse out the requested FPS protocol version of the keySystem type string and pass it to
AVStreamDataParser as an options dictionary.

platform/graphics/avfoundation/CDMPrivateMediaSourceAVFObjC.mm:

(WebCore::validKeySystemRE): Added, match comma-separated version suffixes.
(WebCore::CDMPrivateMediaSourceAVFObjC::supportsKeySystem): Call above.
(WebCore::CDMPrivateMediaSourceAVFObjC::createSession): Parse out the version numbers

and pass into the session as a vector.

platform/graphics/avfoundation/objc/CDMSessionMediaSourceAVFObjC.h:
platform/graphics/avfoundation/objc/CDMSessionMediaSourceAVFObjC.mm:

(WebCore::CDMSessionMediaSourceAVFObjC::CDMSessionMediaSourceAVFObjC): Take a vector of

protocol version numbers.

(WebCore::CDMSessionMediaSourceAVFObjC::update): Create an NSArray and pass into

the key request creation method in an options dictionary.

1:26 AM Changeset in webkit [175614] by Antti Koivisto

6 edits in trunk/Source

Move HTTPHeaderMap encoding to the class
https://bugs.webkit.org/show_bug.cgi?id=138412

Reviewed by Andreas Kling.

Source/WebCore:

platform/network/HTTPHeaderMap.h:

(WebCore::HTTPHeaderMap::encode):
(WebCore::HTTPHeaderMap::decode):

Use generic encoding for the uncommon header map. Common headers still require custom code due to the enum class.

Source/WebKit2:

PluginProcess/PluginControllerProxy.cpp:
Shared/WebCoreArgumentCoders.cpp:

(IPC::ArgumentCoder<HTTPHeaderMap>::encode): Deleted.
(IPC::ArgumentCoder<HTTPHeaderMap>::decode): Deleted.

Make these HTTPHeaderMap members instead so they can access internals and can be used elsewhere.

Shared/WebCoreArgumentCoders.h:

12:17 AM Changeset in webkit [175613] by ap@apple.com

2 edits in trunk/Tools

Build fix for some compiler versions.

TestWebKitAPI/Tests/mac/TypingStyleCrash.mm: (TestWebKitAPI::TEST): Compiler was

unhappy because this is a getter, and these shouldn't have side effects.

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed