Context Navigation

← Previous Period
Next Period →

Timeline

Nov 7, 2014:

8:25 PM Changeset in webkit [175773] by benjamin@webkit.org

2 edits in trunk/Source/WebCore

Fix the build after r175772

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-11-07

inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::buildArrayForMatchedRuleList):

6:05 PM Changeset in webkit [175772] by benjamin@webkit.org

14 edits in trunk/Source/WebCore

Make the Selector's specificity part of Selector matching
https://bugs.webkit.org/show_bug.cgi?id=138486

Reviewed by Andreas Kling.

In CSS Selectors Level 4, the specificity of selectors is computed dynamically
based on which element is being matched.

For example, a selector:

:matches(#foo, .bar, baz)

has a specificity of

(1, 0, 0) on <baz id=foo class=bar>
(0, 1, 0) on <baz class=bar>
(0, 0, 1) on <baz>

Previously, the specificity of each selector was computed statically when populating
RuleSet. With more recent CSS, this gives us the wrong specificity because we do not know
how the selectors applies to the target.

This patch moves one tiny step in the direction of dynamic specificity. The specificity
is removed from RuleSet and is moved inside Selector Matching.

There is one bit worth keeping static: matching based on rule hash. This path is important
to avoid spending time compiling trivial selectors.
In order to keep rule hash matching working, the RuleData store which specificity class
the rule has in addition to the information about matching/not-matching. When going through
the fast path in ElementCollector, we compute the right specificity based on the type
of rule-hash matching.

css/CSSSelector.cpp:

(WebCore::CSSSelector::specificityForOneSelector):

css/CSSSelector.h:
css/ElementRuleCollector.cpp:

(WebCore::ElementRuleCollector::addMatchedRule):
(WebCore::ElementRuleCollector::sortAndTransferMatchedRules):
(WebCore::ElementRuleCollector::ruleMatches):
(WebCore::ElementRuleCollector::collectMatchingRulesForList):
(WebCore::compareRules):

css/ElementRuleCollector.h:
css/RuleSet.cpp:

(WebCore::computeMatchBasedOnRuleHash):
(WebCore::RuleData::RuleData):
(WebCore::isSelectorMatchingHTMLBasedOnRuleHash): Deleted.

css/RuleSet.h:

(WebCore::RuleData::matchBasedOnRuleHash):
(WebCore::RuleData::hasRightmostSelectorMatchingHTMLBasedOnRuleHash): Deleted.
(WebCore::RuleData::specificity): Deleted.

css/SelectorChecker.cpp:

(WebCore::SelectorChecker::match):

css/SelectorChecker.h:
css/StyleResolver.h:

(WebCore::checkRegionSelector):

cssjit/SelectorCompiler.cpp:

(WebCore::SelectorCompiler::SelectorCodeGenerator::SelectorCodeGenerator):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateSelectorChecker):

cssjit/SelectorCompiler.h:

(WebCore::SelectorCompiler::ruleCollectorSimpleSelectorCheckerFunction):
(WebCore::SelectorCompiler::querySelectorSimpleSelectorCheckerFunction):
(WebCore::SelectorCompiler::ruleCollectorSelectorCheckerFunctionWithCheckingContext):
(WebCore::SelectorCompiler::querySelectorSelectorCheckerFunctionWithCheckingContext):
(WebCore::SelectorCompiler::simpleSelectorCheckerFunction): Deleted.
(WebCore::SelectorCompiler::selectorCheckerFunctionWithCheckingContext): Deleted.

dom/SelectorQuery.cpp:

(WebCore::SelectorDataList::selectorMatches):
(WebCore::SelectorDataList::selectorClosest):
(WebCore::SelectorDataList::executeCompiledSimpleSelectorChecker):
(WebCore::SelectorDataList::executeCompiledSelectorCheckerWithCheckingContext):
(WebCore::SelectorDataList::executeCompiledSingleMultiSelectorData):
(WebCore::SelectorDataList::execute):

dom/SelectorQuery.h:

4:40 PM Changeset in webkit [175771] by ap@apple.com

2 edits in trunk/Source/WebCore

CSP is enforced for eval in report-only mode on first page load
https://bugs.webkit.org/show_bug.cgi?id=138492
rdar://problem/15782525

Reviewed by Daniel Bates.

This is covered by existing tests when running as one test per process invocation.

page/ContentSecurityPolicy.cpp:

(WebCore::CSPDirectiveList::allowEval): Allow when in report only mode. The allowEval
function itself needs to return false, because it's used in checkEvalAndReportViolation().
(WebCore::CSPDirectiveList::allowJavaScriptURLs): Apply the same fix, although it's
not changing the behavior - this function is never called with ContentSecurityPolicy::SuppressReport.
(WebCore::CSPDirectiveList::allowInlineEventHandlers): Ditto.
(WebCore::CSPDirectiveList::allowInlineScript): Ditto.
(WebCore::CSPDirectiveList::allowInlineStyle): Ditto.
(WebCore::CSPDirectiveList::allowPluginType): Ditto.
(WebCore::CSPDirectiveList::allowScriptFromSource): Ditto.
(WebCore::CSPDirectiveList::allowObjectFromSource): Ditto.
(WebCore::CSPDirectiveList::allowChildFrameFromSource): Ditto.
(WebCore::CSPDirectiveList::allowImageFromSource): Ditto.
(WebCore::CSPDirectiveList::allowStyleFromSource): Ditto.
(WebCore::CSPDirectiveList::allowFontFromSource): Ditto.
(WebCore::CSPDirectiveList::allowMediaFromSource): Ditto.
(WebCore::CSPDirectiveList::allowConnectToSource): Ditto.
(WebCore::CSPDirectiveList::allowFormAction): Ditto.
(WebCore::CSPDirectiveList::allowBaseURI): Ditto.
(WebCore::ContentSecurityPolicy::didReceiveHeader): Remove isReportOnly() check,
which is now inside allowEval().

4:06 PM Changeset in webkit [175770] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit2

"Lookup" action menu should read "Look up"
https://bugs.webkit.org/show_bug.cgi?id=138509

Patch by Conrad Shultz <Conrad Shultz> on 2014-11-07
Reviewed by Tim Horton.

UIProcess/mac/WKActionMenuController.mm:

(-[WKActionMenuController _createActionMenuItemForTag:]):

3:51 PM Changeset in webkit [175769] by rniwa@webkit.org

2 edits in trunk/Websites/perf.webkit.org

Fix typos in r175768.

public/v2/app.js:

(App.AnalysisTaskViewModel.roots):

3:47 PM Changeset in webkit [175768] by rniwa@webkit.org

11 edits
4 adds in trunk/Websites/perf.webkit.org

Introduce the concept of analysis task to perf dashboard
https://bugs.webkit.org/show_bug.cgi?id=138517

Reviewed by Andreas Kling.

Introduced the concept of an analysis task, which is created for a range of measurements for a given metric on
a single platform and used to bisect regressions in the range.

Added a new page to see the list of active analysis tasks and a page to view the contents of an analysis task.

init-database.sql: Added a bunch of tables to store information about analysis tasks.

analysis_tasks - Represents each analysis task. Associated with a platform and a metric and possibly with two
test runs. Analysis tasks not associated with test runs are used for try new patches.
analysis_test_groups - A test group in an analysis task represents a bunch of related A/B testing results.
root_sets - A root set represents a set of roots (or packages) installed in each A/B testing.
build_requests - A build request represents a single pending build for A/B testing.

public/api/analysis-tasks.php: Added. Returns the specified analysis task or all analysis tasks in an array.

(main):
(format_task):

public/api/test-groups.php: Added. Returns analysis task groups for the specified analysis task or returns

the specified analysis task group as well as build requests associated with them.
(main):
(fetch_test_groups_for_task):
(fetch_build_requests_for_task):
(fetch_build_requests_for_group):
(format_test_group):
(format_build_request):

public/include/json-header.php:

(remote_user_name): Extracted from compute_token so that we can use it in create-analysis-task.php.
(compute_token):

public/privileged-api/associate-bug.php:

(main): Fixed a typo.

public/privileged-api/create-analysis-task.php: Added. Creates a new analysis task for a given test run range.

(main):
(ensure_row_by_id):
(ensure_config_from_runs):

public/privileged-api/generate-csrf-token.php: Use remote_user_name.

public/v2/analysis.js: Added. Various Ember data store models to represent analysis tasks and related objects.

(App.AnalysisTask):
(App.AnalysisTask.create):
(App.TestGroup):
(App.TestGroupAdapter):
(App.AnalysisTaskSerializer):
(App.TestGroupSerializer):
(App.BuildRequest):

public/v2/app.css: Added style rules for the analysis page.

public/v2/app.js:

(App.Pane._fetch): Use fetchRunsWithPlatformAndMetric, which has been refactored into App.Manifest.

(App.PaneController.actions.toggleBugsPane): Show bugs pane even when there are no bug trackers or there is not
exactly one selected point as we can still create an analysis task.
(App.PaneController.actions.associateBug): Renamed singlySelectedPoint to selectedSinglePoint to be more
grammatical and also alert'ed the error message when there is one.
(App.PaneController.actions.createAnalysisTask): Added. Creates a new analysis task and opens it in a new tab.
Since window.open only works during the click, we open the new "window" preemptively and navigates or closes it
once XHR request has completed.
(App.PaneController._detailsChanged): Changes due to singlySelectedPoint to selectedSinglePoint rename.
(App.PaneController._updateBugs): Fixed a bug that we were showing bugs in the previous point when a single point
is selected in the details pane.

(App.AnalysisRoute): Added.
(App.AnalysisTaskRoute): Added.
(App.AnalysisTaskViewModel): Added.
(App.AnalysisTaskViewModel._taskUpdated): Fetch runs for the associated platform and metric.
(App.AnalysisTaskViewModel._fetchedRuns): Setup the chart data to show.
(App.AnalysisTaskViewModel.testSets): The computed property used to update roots for all repositories/projects.
(App.AnalysisTaskViewModel._rootChangedForTestSet): Updates root selections for all repositories/projects when
the user selects an option for all roots in A or B configuration.
(App.AnalysisTaskViewModel.roots): The computed property used to show root choices for each repository/project.

public/v2/chart-pane.css: Added style rules for details view in the analysis task page.

public/v2/data.js:

(Measurement.prototype._formatRevisionRange): Don't prefix a revision number with "At " when there is no previous
point so that we can use it in App.AnalysisTaskViewModel.roots.
(TimeSeries.prototype.findPointByMeasurementId): Added.
(TimeSeries.prototype.seriesBetweenPoints): Added.

public/v2/index.html: Use Metric.fullName since the same value is needed in the analysis task page. Also added

a button to create an analysis task, and made bugs pane button always enabled since we can an analysis task even
when multiple points are selected. Finally, added a new template for the analysis task page.

public/v2/manifest.js:

(App.Metric.fullName): Added to share code between the charts page and the analysis task page.
(App.Manifest.fetchRunsWithPlatformAndMetric): Extracted from App.Pane._fetch to be reused in
App.AnalysisTaskViewModel._taskUpdated.

3:37 PM Changeset in webkit [175767] by Joseph Pecoraro

16 edits
3 moves in trunk/Source/WebInspectorUI

Web Inspector: Layer summary should be bottom sticky
https://bugs.webkit.org/show_bug.cgi?id=138518

Reviewed by Timothy Hatcher.

Previously only NavigationSidebars had a content view. Now, give all
Sidebars a contentElement section for content.

Update all Details Sidebars to append content to the contentElement
instead of directly to the element. Only two Details sidebars append
to the element:

CSSStyleDetailsSidebarPanel for the navigation bar at the top
LayerTreeDetailsSidebarPanel for the summary view at the bottom

Take this opportunity to fix up some naming and styles as well.

UserInterface/Views/SidebarPanel.js:

(WebInspector.SidebarPanel):
(WebInspector.SidebarPanel.prototype.get contentElement):
Give every SidebarPanel a content element.

UserInterface/Views/DetailsSidebarPanel.css: Removed.

(.sidebar > .panel > .content):

UserInterface/Views/SidebarPanel.css: Added.

(.sidebar > .panel > .content):
And give that content element a default style.

UserInterface/Views/NavigationSidebarPanel.css:

(.sidebar > .panel.navigation > .content):

UserInterface/Views/NavigationSidebarPanel.js:

(WebInspector.NavigationSidebarPanel):
(WebInspector.NavigationSidebarPanel.prototype.createContentTreeOutline):
(WebInspector.NavigationSidebarPanel.prototype._updateContentOverflowShadowVisibility):
(WebInspector.NavigationSidebarPanel.prototype.get contentElement): Deleted.
Navigation sidebar panels now use the parent's contentElement.
Also, carry over their default styles, overriding the base.

UserInterface/Views/LayerTreeDetailsSidebarPanel.js: Renamed from Source/WebInspectorUI/UserInterface/Views/LayerTreeSidebarPanel.js.

(WebInspector.LayerTreeDetailsSidebarPanel.prototype._buildLayerInfoSection):
(WebInspector.LayerTreeDetailsSidebarPanel.prototype._buildDataGridSection):
(WebInspector.LayerTreeDetailsSidebarPanel.prototype._buildBottomBar):
Rename LayerTreeSidebarPanel to make it clear this is a DetailsSidebarPanel.
Add the "bottom bar" to the root element, and sections to the contentElement.

UserInterface/Views/LayerTreeDetailsSidebarPanel.css: Renamed from Source/WebInspectorUI/UserInterface/Views/LayerTreeSidebarPanel.css.

(.sidebar > .layer-tree.panel > .content):
(body.mac-platform.legacy .sidebar > .layer-tree.panel > .content):
Style the bottom bar to pin it to the bottom of the sidebar panel.

(WebInspector.CSSStyleDetailsSidebarPanel):
(WebInspector.CSSStyleDetailsSidebarPanel.prototype.refresh):
(WebInspector.CSSStyleDetailsSidebarPanel.prototype._navigationItemSelected):
Add the navigation bar to the root element, and sections to the contentElement.

UserInterface/Base/Main.js:

(WebInspector.contentLoaded):

UserInterface/Main.html:
WebInspectorUI.vcxproj/WebInspectorUI.vcxproj:
WebInspectorUI.vcxproj/WebInspectorUI.vcxproj.filters:

Update for new names.

UserInterface/Views/ApplicationCacheDetailsSidebarPanel.js:

(WebInspector.ApplicationCacheDetailsSidebarPanel):

UserInterface/Views/CSSStyleDetailsSidebarPanel.js:
UserInterface/Views/DOMDetailsSidebarPanel.js:

(WebInspector.DOMDetailsSidebarPanel):

UserInterface/Views/DOMNodeDetailsSidebarPanel.js:

(WebInspector.DOMNodeDetailsSidebarPanel):

UserInterface/Views/DetailsSidebarPanel.js:

(WebInspector.DetailsSidebarPanel):

UserInterface/Views/ProbeDetailsSidebarPanel.js:
UserInterface/Views/ResourceDetailsSidebarPanel.js:

(WebInspector.ResourceDetailsSidebarPanel):
(WebInspector.ResourceDetailsSidebarPanel.prototype._refreshURL):
(WebInspector.ResourceDetailsSidebarPanel.prototype._refreshImageSizeSection):
(WebInspector.ResourceDetailsSidebarPanel.prototype._refreshRequestDataSection):

UserInterface/Views/ScopeChainDetailsSidebarPanel.js:

(WebInspector.ScopeChainDetailsSidebarPanel.prototype.refresh.delayedWork):
(WebInspector.ScopeChainDetailsSidebarPanel.prototype.refresh):
All details sidebar panels now use the contentElement instead of element for content.

3:36 PM Changeset in webkit [175766] by Dániel Bátyai

3 edits in trunk/Source/JavaScriptCore

Fix an alignment issue with operationPushCatchScope on ARMv7
https://bugs.webkit.org/show_bug.cgi?id=138510

Reviewed by Csaba Osztrogonác.

jit/CCallHelpers.h:

(JSC::CCallHelpers::setupArgumentsWithExecState):

jit/JITInlines.h:

(JSC::JIT::callOperation):

3:10 PM Changeset in webkit [175765] by akling@apple.com

2 edits in trunk/Source/WebCore

[Mac] Avoid repainting scrollbar track when the scrollbar track is transparent.
<https://webkit.org/b/138521>
<rdar://problem/18892090>

Reviewed by Simon Fraser.

Don't bother invalidating the entire WebCore scrollbar when we've opted into
AppKit's special mode to use individual layers for scrollbar components.
NSScrollerImp will invalidate what's necessary below e.g setKnobAlpha.

platform/mac/ScrollAnimatorMac.mm:

(-[WebScrollbarPartAnimation setCurrentProgress:]):

2:14 PM Changeset in webkit [175764] by Chris Dumez

4 edits in trunk/Source/WebCore

Rename HTMLInputElement::imageLoader() to ensureImageLoader()
https://bugs.webkit.org/show_bug.cgi?id=138508

Reviewed by Andreas Kling.

Rename HTMLInputElement::imageLoader() to ensureImageLoader() and have
it return a reference to make it clear that it constructs an
ImageLoader if missing.
Also introduce a lightweight imageLoader() getter which just returns
the imageLoader or null if missing.

No new tests, no behavior change.

html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::ensureImageLoader):
(WebCore::HTMLInputElement::didMoveToNewDocument):
(WebCore::HTMLInputElement::imageLoader): Deleted.

html/HTMLInputElement.h:

(WebCore::HTMLInputElement::imageLoader):
(WebCore::HTMLInputElement::hasImageLoader): Deleted.

html/ImageInputType.cpp:

(WebCore::ImageInputType::srcAttributeChanged):
(WebCore::ImageInputType::attach):
(WebCore::ImageInputType::height):
(WebCore::ImageInputType::width):

2:01 PM Changeset in webkit [175763] by timothy@apple.com

4 edits in trunk/Source/WebInspectorUI

Web Inspector: Cursor and scroll view jumps around when modifying styles
https://bugs.webkit.org/show_bug.cgi?id=137467

This merges commit e2962a5b0df56c8ee5a4482899d308decf3d7677 from CodeMirror.

Reviewed by Joseph Pecoraro.

UserInterface/External/CodeMirror/codemirror.js:

(maybeScrollWindow): Signal the scrollCursorIntoView event.
(signalDOMEvent): Support string events by transforming them to event objects.

UserInterface/Views/CodeMirrorAdditions.js:

(scrollCursorIntoView): Added. Default event listener that provides our own
implementation using WebKit's scrollIntoViewIfNeeded.

UserInterface/Views/RulesStyleDetailsPanel.js:

(WebInspector.RulesStyleDetailsPanel.prototype.refresh): Stop doing an
extra scrollIntoViewIfNeeded call, CodeMirror does this.

1:58 PM Changeset in webkit [175762] by msaboff@apple.com

10 edits in trunk/Source/JavaScriptCore

Update scope related slow path code to use scope register added to opcodes
https://bugs.webkit.org/show_bug.cgi?id=138254

Reviewed by Mark Lam.

Updated slow paths for op_pop_scope, op_push_name_scope and op_push_with_scope.
Added scope register index parameter to the front of the relevant argument lists of the
slow functions. In the case of op_push_name_scope for x86 (32 bit), there aren't enough
registers to accomodate all the parameters. Therefore, added two new JSVALUE32_64 slow
paths called operationPushCatchScope() and operationPushFunctionNameScope() to eliminate
the last "type" argument.

assembler/MacroAssemblerCodeRef.h:

(JSC::FunctionPtr::FunctionPtr): Added a new template to take 6 arguments.

jit/CCallHelpers.h:

(JSC::CCallHelpers::setupArgumentsWithExecState):

jit/JIT.h:
jit/JITInlines.h:

(JSC::JIT::callOperation):
New variants of setupArgumentsWithExecState() and callOperation() to handle the new
combinations of argument types and counts.

jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_push_with_scope):
(JSC::JIT::emit_op_pop_scope):
(JSC::JIT::emit_op_push_name_scope):

jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_push_with_scope):
(JSC::JIT::emit_op_pop_scope):
(JSC::JIT::emit_op_push_name_scope):
Use the new slow paths.

jit/JITOperations.cpp:
jit/JITOperations.h:

Updates to set the scope result using the scope register index. Added operationPushCatchScope()
and operationPushFunctionNameScope().

llint/LLIntSlowPaths.cpp:

(JSC::LLInt::LLINT_SLOW_PATH_DECL):
Updated the scope slow paths to use the scope register index in the instruction to read and
write the register instead of using CallFrame::scope() and CallFrame::setScope().

1:29 PM Changeset in webkit [175761] by Beth Dakin

2 edits in trunk/Source/WebKit2

Null deref performing Lookup on Apple Trailers full screen button
https://bugs.webkit.org/show_bug.cgi?id=138513
-and corresponding-
rdar://problem/18909699

Reviewed by Tim Horton.

WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::performDictionaryLookupForSelection):

1:21 PM Changeset in webkit [175760] by Chris Dumez

5 edits
2 adds in trunk

Move 'webkit-clip-path' CSS property to the new StyleBuilder
https://bugs.webkit.org/show_bug.cgi?id=138452

Reviewed by Andreas Kling.

Source/WebCore:

Move 'webkit-clip-path' CSS property from DeprecatedStyleBuilder to the
new StyleBuilder so that it is now generated from CSSPropertyNames.in.

A ClipPath converter was added to support this. Custom code was avoided
by replacing if checks by assertions, relying on the CSSParser to make
sure the input is valid.

Test: fast/masking/clip-path-bad-value.html

css/CSSPropertyNames.in:
css/DeprecatedStyleBuilder.cpp:

(WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder):
(WebCore::ApplyPropertyClipPath::setValue): Deleted.
(WebCore::ApplyPropertyClipPath::applyValue): Deleted.
(WebCore::ApplyPropertyClipPath::createHandler): Deleted.

css/StyleBuilderConverter.h:

(WebCore::StyleBuilderConverter::convertClipPath):

LayoutTests:

Add layout test to make sure we don't crash in the StyleBuilder when
setting unexpected values to webkit-clip-path property.

fast/masking/clip-path-bad-value-expected.txt: Added.
fast/masking/clip-path-bad-value.html: Added.

12:35 PM Changeset in webkit [175759] by commit-queue@webkit.org

7 edits in trunk/Source/WebKit2

Make it possible to associate snapshots with back/forward list items other than the current item.
https://bugs.webkit.org/show_bug.cgi?id=138490

Patch by Anshu Chimala <anshu@apple.com> on 2014-11-07
Reviewed by Tim Horton.

UIProcess/API/Cocoa/WKViewPrivate.h:

Declare -saveBackForwardSnapshotForItem:, an alternative to -saveBackForwardSnapshotForCurrentItem that accepts a
back/forward list item as an argument.

UIProcess/API/mac/WKView.mm:

(-[WKView saveBackForwardSnapshotForItem:]):
Pass the provided back/forward list item along to WebPageProxy::recordNavigationSnapshot().

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::recordNavigationSnapshot):
Overloaded to optionally take a back/forward list item as an argument. If one isn't provided, default to the current item
as before; otherwise, associate the snapshot with whichever item was provided.

UIProcess/WebPageProxy.h:

Declare the new recordNavigationSnapshot() overload.

UIProcess/mac/ViewSnapshotStore.h:

Make recordSnapshot() take a back/forward list item as an argument.

UIProcess/mac/ViewSnapshotStore.mm:

(WebKit::ViewSnapshotStore::recordSnapshot):
Store the snapshot in the provided back/forward list item instead of in the current item.

12:29 PM Changeset in webkit [175758] by Joseph Pecoraro

5 edits
2 adds in trunk

Web Inspector: Pseudo element matchedCSSRules do not include matching selector info
https://bugs.webkit.org/show_bug.cgi?id=138438

Reviewed by Benjamin Poulain.

Source/WebCore:

Test: inspector/css/psuedo-element-matches.html

Element::matches is not the correct API to use to check selectors with pseudo-elements.
Instead we should use the CSS Selector checking machinary which understands them.

inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::getSupportedCSSProperties):
(WebCore::InspectorCSSAgent::buildArrayForRuleList):
(WebCore::InspectorCSSAgent::buildArrayForRegions):
(WebCore::InspectorCSSAgent::buildObjectForNamedFlow):
Some RefPtr release improvements.

(WebCore::InspectorCSSAgent::buildArrayForMatchedRuleList):
Use a SelectorChecker to check each Selector against the element.
This matches the SelectorChecker used when we collected the rules
for this element.

Source/WebInspectorUI:

UserInterface/Base/Test.js:

(WebInspector.loaded):
Include a global setting for shadow dom used by DOM model classes.
Give it a "test" specific name to not override non-test setting values.

LayoutTests:

inspector/css/pseudo-element-matches-expected.txt: Added.
inspector/css/pseudo-element-matches.html: Added.

Add a test to ensure we get correct selector matches for a pseudo element
inside of an <audio> element. The test is heavily coupled to our UserAgent
stylesheet and Shadow DOM layout, so check for possible failures if
WebCore changes things.

12:25 PM Changeset in webkit [175757] by timothy_horton@apple.com

2 edits in trunk/Source/WebKit2

Popovers do not dismiss when navigating back and forth using gestures
https://bugs.webkit.org/show_bug.cgi?id=138512
<rdar://problem/18900200>

Reviewed by Beth Dakin.

UIProcess/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::navigationGestureDidBegin):
Dismiss action menu related popovers when navigation gestures begin.

12:06 PM Changeset in webkit [175756] by Beth Dakin

9 edits in trunk/Source/WebKit2

Action menu preview popover should dismiss on scroll
https://bugs.webkit.org/show_bug.cgi?id=138511
-and corresponding-
rdar://problem/18901445

Reviewed by Tim Horton.

This patch re-names dismissActionMenuDataDetectorPopovers() to
dismissActionMenuPopovers() and also calls _clearPreviewPopover from that method
as well.

UIProcess/API/mac/WKView.mm:

(-[WKView viewDidMoveToWindow]):
(-[WKView _dismissActionMenuPopovers]):
(-[WKView _dismissActionMenuDataDetectorPopovers]): Deleted.

UIProcess/API/mac/WKViewInternal.h:
UIProcess/PageClient.h:
UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didCommitLoadForFrame):
(WebKit::WebPageProxy::pageDidScroll):
(WebKit::WebPageProxy::resetStateAfterProcessExited):

UIProcess/mac/PageClientImpl.h:
UIProcess/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::dismissActionMenuPopovers):
(WebKit::PageClientImpl::dismissActionMenuDataDetectorPopovers): Deleted.

UIProcess/mac/WKActionMenuController.h:
UIProcess/mac/WKActionMenuController.mm:

(-[WKActionMenuController dismissActionMenuPopovers]):
(-[WKActionMenuController dismissActionMenuDataDetectorPopovers]): Deleted.

12:02 PM Changeset in webkit [175755] by Bem Jones-Bey

8 edits
4 adds
4 deletes in trunk/LayoutTests

[CSS Shapes] the sandbag JS utility code isn't producing the correct expected result in the shape-image gradient tests
https://bugs.webkit.org/show_bug.cgi?id=135923

Reviewed by Dirk Schulze.

Import tests from upstream. They have been modified so that they use
testharness to validate success or failure instead of being reftests,
allowing for fuzziness in matching to get around small variances
between implementations.

TestExpectations:
css3/shapes/shape-outside/shape-image/gradients/shape-outside-radial-gradient-001-expected.html: Removed.
css3/shapes/shape-outside/shape-image/gradients/shape-outside-radial-gradient-001-expected.txt: Added.
css3/shapes/shape-outside/shape-image/gradients/shape-outside-radial-gradient-001.html:
css3/shapes/shape-outside/shape-image/gradients/shape-outside-radial-gradient-002-expected.html: Removed.
css3/shapes/shape-outside/shape-image/gradients/shape-outside-radial-gradient-002-expected.txt: Added.
css3/shapes/shape-outside/shape-image/gradients/shape-outside-radial-gradient-002.html:
css3/shapes/shape-outside/shape-image/gradients/shape-outside-radial-gradient-003-expected.html: Removed.
css3/shapes/shape-outside/shape-image/gradients/shape-outside-radial-gradient-003-expected.txt: Added.
css3/shapes/shape-outside/shape-image/gradients/shape-outside-radial-gradient-003.html:
css3/shapes/shape-outside/shape-image/gradients/shape-outside-radial-gradient-004-expected.html: Removed.
css3/shapes/shape-outside/shape-image/gradients/shape-outside-radial-gradient-004-expected.txt: Added.
css3/shapes/shape-outside/shape-image/gradients/shape-outside-radial-gradient-004.html:
css3/shapes/shape-outside/shape-image/gradients/w3c-import.log:
css3/shapes/shape-outside/supported-shapes/support/test-utils.js:

(verifyTextPoints):

10:58 AM Changeset in webkit [175754] by Beth Dakin

3 edits in trunk/Source/WebKit2

Support action menus for whitespace in editable areas
https://bugs.webkit.org/show_bug.cgi?id=138488
-and corresponding-
rdar://problem/18877717

Reviewed by Tim Horton.

Very simple menu for whitespace in editable areas.

Shared/API/c/WKActionMenuTypes.h:
UIProcess/mac/WKActionMenuController.mm:

(-[WKActionMenuController _defaultMenuItemsForWhitespaceInEditableArea]):
(-[WKActionMenuController _defaultMenuItems:]):

10:54 AM Changeset in webkit [175753] by Beth Dakin

2 edits in trunk/Source/WebKit2

Invoking an action menu should dismiss existing selection
https://bugs.webkit.org/show_bug.cgi?id=138496
-and corresponding-
rdar://problem/18892787

Reviewed by Tim Horton.

UIProcess/mac/WKActionMenuController.mm:

(-[WKActionMenuController willOpenMenu:withEvent:]):

10:28 AM Changeset in webkit [175752] by Chris Dumez

3 edits in trunk/Source/WebCore

Drop useless HTMLElement::isURLAttribute() override
https://bugs.webkit.org/show_bug.cgi?id=138479

Reviewed by Mark Lam.

Drop useless HTMLElement::isURLAttribute() override as it is doing
nothing but calling the parent class' isURLAttribute().

No new tests, no behavior change.

html/HTMLElement.cpp:

(WebCore::HTMLElement::isURLAttribute): Deleted.

html/HTMLElement.h:

10:12 AM Changeset in webkit [175751] by ggaren@apple.com

8 edits in trunk/Source/bmalloc

bmalloc uses 8X more virtual memory than necessary
https://bugs.webkit.org/show_bug.cgi?id=138495

Reviewed by Mark Lam.

iOS has a per-process virtual memory cap around 1GB, so there's some
value to not going totally ham with virtual memory.

We currently use about 8X the necessary amount:

2X to align our VM allocation
4X to reserve small / medium / (2) large chunk VM ranges per superchunk

We can cut that down:

Return the unaligned portion of our VM allocation (-2X)
Use all the chunks in a superchunk, instead of allocating one chunk per superchunk (-4X)

bmalloc/Algorithm.h:

(bmalloc::roundUpToMultipleOf): Added a non-constant version of this
function so we can call it with getpagesize() at runtime.

bmalloc/Chunk.h:
bmalloc/LargeChunk.h:

(bmalloc::LargeChunk::create): Deleted. Instead of each chunk allocating
its own VM, VMHeap allocates the superchunk and all the chunks in it at a time.

bmalloc/VMAllocate.h:

(bmalloc::vmValidate):
(bmalloc::vmAllocate): ASSERT that mmap succeeds to make crashes clearer
if it does not succeed. Allocate precisely, and give back the extra.

bmalloc/VMHeap.cpp:

(bmalloc::VMHeap::allocateSuperChunk):
(bmalloc::VMHeap::allocateSmallChunk): Deleted.
(bmalloc::VMHeap::allocateMediumChunk): Deleted.
(bmalloc::VMHeap::allocateLargeChunk): Deleted. Use all the chunks
in a superchunk, instead of just one.

bmalloc/VMHeap.h:

(bmalloc::VMHeap::allocateSmallPage):
(bmalloc::VMHeap::allocateMediumPage):
(bmalloc::VMHeap::allocateLargeRange):

bmalloc/XLargeChunk.h:

(bmalloc::XLargeChunk::create): Updated to match changes above.

10:10 AM Changeset in webkit [175750] by eric.carlson@apple.com

14 edits in trunk/Source

[iOS] Update optimized fullscreen media controls
https://bugs.webkit.org/show_bug.cgi?id=138493

Reviewed by Brent Fulgham.

Source/WebCore:

Modules/mediacontrols/MediaControlsHost.cpp:

(WebCore::MediaControlsHost::fullscreenMode): New.
(WebCore::MediaControlsHost::mediaUIImageData): New.

Modules/mediacontrols/MediaControlsHost.h:
Modules/mediacontrols/MediaControlsHost.idl:

Modules/mediacontrols/mediaControlsiOS.css:

Renamed -webkit-media-controls-wireless-playback-status to -webkit-media-controls-inline-playback-placeholder

because it is now used for other inline playback status display. Add z-index:0 so the placeholder
renders above captions. Remove the background-image, it is now set from script.

(audio::-webkit-media-controls-inline-playback-placeholder):
(audio::-webkit-media-controls-inline-playback-placeholder.hidden):
(video::-webkit-media-controls-optimized-fullscreen-button):
(audio::-webkit-media-controls-wireless-playback-status): Deleted.
(audio::-webkit-media-controls-wireless-playback-status.hidden): Deleted.
(video::-webkit-media-controls-optimized-fullscreen-button:active): Deleted.

Modules/mediacontrols/mediaControlsiOS.js:

(ControllerIOS): Set doingSetup to true around setup so we don't draw the inline controls

briefly when an element is created as a result of a user gesture.

(ControllerIOS.prototype.shouldHaveStartPlaybackButton): Don't allow inline controls during

initial setup to prevent inline controls from begin drawn briefly when a media element
is created and inserted by a script called from a user gesture.

(ControllerIOS.prototype.updateWirelessPlaybackStatus): wirelessPlaybackStatus -> inlinePlaybackPlaceholder.
(ControllerIOS.prototype.createControls): Ditto. Add style rules for optimized fullscreen button.
(ControllerIOS.prototype.configureInlineControls): Add the inlinePlaybackPlaceholder as a peer of

the inline controls compositing child instead of as a child so it renders correctly.

(ControllerIOS.prototype.addControls):
(ControllerIOS.prototype.updateControls): wirelessPlaybackStatus -> inlinePlaybackPlaceholder.
(ControllerIOS.prototype.handleWrapperTouchStart):
(ControllerIOS.prototype.get pageScaleFactor): Cleanup.
(ControllerIOS.prototype.set pageScaleFactor): Ditto.
(ControllerIOS.prototype.handleFullscreenChange): Show the placeholder.

WebCore.exp.in: Export _wkGetMediaUIImageData.

html/HTMLMediaElement.h:

(WebCore::HTMLMediaElement::fullscreenMode): Expose fullscreen mode.

platform/ios/WebCoreSystemInterfaceIOS.h:
platform/ios/WebCoreSystemInterfaceIOS.mm:

Source/WebKit/mac:

WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface): Initialize GetMediaUIImageData.

Source/WebKit2:

WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:

(InitWebCoreSystemInterface): Initialize GetMediaUIImageData.

3:43 AM Changeset in webkit [175749] by Carlos Garcia Campos

10 edits in releases/WebKitGTK/webkit-2.6

Merge r173857 - Move nodeFromPoint() back to Document where it belongs
https://bugs.webkit.org/show_bug.cgi?id=137012

Reviewed by Zalan Bujtas.
Source/WebCore:

nodeFromPoint() was moved into TreeScope for ShadowDOM work, but now we can move
it back to its logical place.

Make versions of elementFromPoint and caretRangeFromPoint that take LayoutPoints,
and change the current scale/offset code to be in layout units (which results
in a small behavior change).

elementFromPoint(int, int) and caretRangeFromPoint(int, int) are still required
for bindings code.

dom/Document.cpp:

(WebCore::Document::nodeFromPoint):
(WebCore::Document::elementFromPoint):
(WebCore::Document::caretRangeFromPoint):

dom/Document.h:

(WebCore::Document::elementFromPoint): Move logic from TreeScope::elementFromPoint()
here.

dom/TreeScope.cpp:

(WebCore::nodeFromPoint): Deleted.
(WebCore::TreeScope::elementFromPoint): Deleted.

dom/TreeScope.h:

LayoutTests:

All platforms use subpixel layout now, so remove the conditional behavior in this test.
Fix the test to account for scaling now being done in layout units.

fast/dom/Document/CaretRangeFromPoint/hittest-relative-to-viewport-expected.txt:
fast/dom/Document/CaretRangeFromPoint/hittest-relative-to-viewport.html:
platform/mac/fast/dom/Document/CaretRangeFromPoint/hittest-relative-to-viewport-expected.txt:

3:29 AM Changeset in webkit [175748] by Antti Koivisto

2 edits
8 adds in trunk/Source/WebKit2

Add cache coders
https://bugs.webkit.org/show_bug.cgi?id=138413

Reviewed by Anders Carlsson.

Add encoding and decoding support for cache types.

This is largely a copy of the IPC coder classes with some unnecessary features removed.
The coders compute a type-sensitive checksum that can be used to verify the data integrity.

The code is behind ENABLE(NETWORK_CACHE) and not yet used.

NetworkProcess/cache: Added.
NetworkProcess/cache/NetworkCacheCoder.h: Added.
NetworkProcess/cache/NetworkCacheCoders.cpp: Added.
NetworkProcess/cache/NetworkCacheCoders.h: Added.
NetworkProcess/cache/NetworkCacheDecoder.cpp: Added.
NetworkProcess/cache/NetworkCacheDecoder.h: Added.
NetworkProcess/cache/NetworkCacheEncoder.cpp: Added.
NetworkProcess/cache/NetworkCacheEncoder.h: Added.
WebKit2.xcodeproj/project.pbxproj:

3:28 AM Changeset in webkit [175747] by Carlos Garcia Campos

20 edits in releases/WebKitGTK/webkit-2.6/Source

Merge r173765 - Allow DOM methods to return references instead of pointers
https://bugs.webkit.org/show_bug.cgi?id=136931

Source/WebCore:

Reviewed by Sam Weinig.

It is common practice in WebKit to have methods return a reference
instead of a pointer if the pointer can never be null. However, this
unfortunately did not work for DOM methods (functions called by JS
bindings). This prevented further refactoring.

This patch brings support for having DOM methods to return references
instead of pointers when the pointer cannot be null. The generated
bindings were calling WTF::getPtr() on the pointer type returned by
the implementation already (in case it was a smart pointer type).
This patch leverages this by having WTF::getPtr() convert reference
arguments into raw pointers.

This patch also updates a few DOM methods on Document and Element
classes to return a reference instead of a pointer, to test the change.
There are likely more DOM methods that can be updated though.

No new tests, no behavior change.

accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::classList):

bindings/js/JSDOMBinding.h:

(WTF::getPtr): Deleted.

dom/Document.cpp:

(WebCore::Document::implementation):
(WebCore::Document::webkitGetNamedFlows):
(WebCore::Document::namedFlows):
(WebCore::Document::setXMLVersion):
(WebCore::Document::setXMLStandalone):
(WebCore::Document::securityPolicy):
(WebCore::Document::styleSheets):

dom/Document.h:

(WebCore::Document::timing):

dom/Element.cpp:

(WebCore::Element::classList):
(WebCore::Element::dataset):

dom/Element.h:
html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlPanelElement::setPosition):
(WebCore::MediaControlPanelElement::resetPosition):
(WebCore::MediaControlClosedCaptionsTrackListElement::updateDisplay):

html/track/VTTRegion.cpp:

(WebCore::VTTRegion::displayLastTextTrackCueBox):
(WebCore::VTTRegion::willRemoveTextTrackCueBox):

inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::getAllStyleSheets):
(WebCore::InspectorCSSAgent::getNamedFlowCollection):

page/PerformanceTiming.cpp:

(WebCore::PerformanceTiming::documentTiming):

rendering/FlowThreadController.cpp:

(WebCore::FlowThreadController::ensureRenderFlowThreadWithName):

Source/WTF:

Add support for having WTF::getPtr() transform reference arguments
into raw pointers so that DOM methods can now return references when
appropriate and so that the generated bindings code can handle this
via WTF::getPtr().

This patch had to alter the way getPtr() was overloaded for smart
pointer types so that we don't call &p on smart pointers but p.get().
This was needed because the new WTF::getPtr(T&) was being called for
RefPtr<T> arguments instead of the getPtr(const RefPtr<T>&) overload.
This was addressed using traits and template specialization to
distinguish WTF smart pointers from other types.

Reviewed by Sam Weinig.

wtf/GetPtr.h:

(WTF::getPtr):

wtf/OwnPtr.h:

(WTF::getPtr): Deleted.

wtf/PassOwnPtr.h:

(WTF::getPtr): Deleted.

wtf/PassRefPtr.h:

(WTF::getPtr): Deleted.

wtf/Ref.h:
wtf/RefPtr.h:

(WTF::getPtr): Deleted.

wtf/gobject/GRefPtr.h:

(WTF::getPtr): Deleted.

2:07 AM Changeset in webkit [175746] by evab.u-szeged@partner.samsung.com

2 edits in trunk

[EFL] Require at least EFL 1.9 if ENABLE(ACCESSIBILITY) after r175098
https://bugs.webkit.org/show_bug.cgi?id=138465

Reviewed by Gyuyoung Kim.

Source/cmake/OptionsEfl.cmake:

1:21 AM Changeset in webkit [175745] by gyuyoung.kim@samsung.com

6 edits in trunk/Source/JavaScriptCore

Apply std::unique_ptr to slowPathCall()
https://bugs.webkit.org/show_bug.cgi?id=138489

Reviewed by Mark Lam.

As a step to use std::unique_ptr<>, this patch makes slowPathCall() use std::unique_ptr<>,
std::make_unique<>, and WTF::move().

dfg/DFGSlowPathGenerator.h:

(JSC::DFG::slowPathCall):
(JSC::DFG::slowPathMove):

dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::emitAllocateJSArray):
(JSC::DFG::SpeculativeJIT::addSlowPathGenerator):
(JSC::DFG::SpeculativeJIT::arrayify):
(JSC::DFG::SpeculativeJIT::compileIn):
(JSC::DFG::SpeculativeJIT::compileGetByValOnString):

dfg/DFGSpeculativeJIT.h:
dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::cachedGetById):
(JSC::DFG::SpeculativeJIT::cachedPutById):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompare):
(JSC::DFG::SpeculativeJIT::compile):

dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::cachedGetById):
(JSC::DFG::SpeculativeJIT::cachedPutById):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompare):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeStrictEq):
(JSC::DFG::SpeculativeJIT::compile):

12:24 AM Changeset in webkit [175744] by mark.lam@apple.com

2 edits in trunk/LayoutTests

Gardening: get-by-pname.js is failing when run with JSC_useLLINT=false and other special JIT configurations.
<https://webkit.org/b/138497>

Unreviewed.

js/script-tests/get-by-pname.js:
temporarily skipping this from the JSC tests to green the bots until the issue is fixed.

Nov 6, 2014:

11:22 PM Changeset in webkit [175743] by Carlos Garcia Campos

3 edits in trunk/Source/WebCore

Unreviewed. Try to fix GTK build after r175719.

Rename the Timer fired function as requestAnimationTimerFired() to
avoid ambiguity.

platform/ScrollAnimatorNone.cpp:

(WebCore::ScrollAnimatorNone::ScrollAnimatorNone):
(WebCore::ScrollAnimatorNone::requestAnimationTimerFired):
(WebCore::ScrollAnimatorNone::animationTimerFired): Deleted.

platform/ScrollAnimatorNone.h:

9:53 PM Changeset in webkit [175742] by Chris Dumez

2 edits in trunk/Source/WebCore

Remove useless if check in HTMLInputElement::setValue()
https://bugs.webkit.org/show_bug.cgi?id=138485

Reviewed by Daniel Bates.

Remove useless if check in HTMLInputElement::setValue(). It was
inadvertently left in as part of r94836.

html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::setValue):

8:52 PM Changeset in webkit [175741] by Simon Fraser

3 edits in trunk/Source/WebCore

Put names on a couple of video-related CALayers
https://bugs.webkit.org/show_bug.cgi?id=138491

Reviewed by Eric Carlson.

In debug, set layer names on a couple of video-related layers to make
debugging easier.

platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerLayer):

platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:

(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::ensureLayer):

7:16 PM Changeset in webkit [175740] by Darin Adler

5 edits in trunk

REGRESSION (r175549): http/tests/multipart/stop-crash.html failing (assertion failure in CachedResource::setEncodedSize)
https://bugs.webkit.org/show_bug.cgi?id=138358

Reviewed by Alexey Proskuryakov.

Source/WebCore:

loader/cache/CachedResource.cpp:

(WebCore::CachedResource::setEncodedSize): Removed the incorrect assertion here.
The code asserts that resources only get bigger, never smaller. This is incorrect
for a multipart/mixed-replace image, where a later image that is smaller can replace
an earlier one. I don't fully understand why this assertion was not firing before,
but the relevant websites are working fine and the test otherwise passes.

loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::subresourceLoaderFinishedLoadingOnePart): Fix another
incorrect assertion that can fire for any parts after the first one. I ran into
this while testing various websites that use multipart/mixed-replace.

LayoutTests:

TestExpectations: Turn the test back on.

7:04 PM Changeset in webkit [175739] by matthew_hanson@apple.com

5 edits in branches/safari-600.2-branch/Source

Versioning.

6:56 PM Changeset in webkit [175738] by matthew_hanson@apple.com

1 copy in tags/Safari-600.2.1

New Tag.

6:56 PM Changeset in webkit [175737] by matthew_hanson@apple.com

5 edits in branches/safari-600.2-branch/Source

Versioning.

6:51 PM Changeset in webkit [175736] by matthew_hanson@apple.com

2 edits in branches/safari-600.2-branch/Source/JavaScriptCore

Rollout r173238. rdar://problem/18495806

6:27 PM Changeset in webkit [175735] by commit-queue@webkit.org

8 edits in trunk/Tools

Remove duplicate code from PatchAnalysisTask._test_patch and fix bug
regarding incorrect call to PatchAnalysisTask.report_failure
https://bugs.webkit.org/show_bug.cgi?id=138229

Patch by Jake Nielsen <jacob_nielsen@apple.com> on 2014-11-06
Reviewed by Daniel Bates.

Scripts/webkitpy/common/net/layouttestresults.py:

Makes sure test_results returns a list.
(LayoutTestResults.test_results):

Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:

Makes unit tests also check to make sure
task.results_from_patch_test_run() and
task.results_from_test_run_without_patch return instances of
LayoutTestResults.
(CommitQueueTaskTest._run_and_expect_patch_analysis_result):

Scripts/webkitpy/tool/bot/patchanalysistask.py:

Condenses duplicate code into _should_defer_patch_or_throw, and
removes the now-unused _clean_tree_results member.
(PatchAnalysisTask.init):
(PatchAnalysisTask._continue_testing_patch_that_exceeded_failure_limit_on_first_or_second_try):
(PatchAnalysisTask._should_defer_patch_or_throw):
(PatchAnalysisTask._test_patch):
(PatchAnalysisTask.results_from_patch_test_run):
(PatchAnalysisTask.results_from_test_run_without_patch): Deleted.

Scripts/webkitpy/tool/commands/earlywarningsystem.py:

Removes needless call to results_from_test_run_without_patch
(AbstractEarlyWarningSystem._failing_tests_message):

Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:

Changes order of test failure messages to be in the order that they
appear.
(AbstractEarlyWarningSystemTest.test_failing_tests_message):

Scripts/webkitpy/tool/commands/queues.py:

Removes needless call to results_from_test_run_without_patch.
(CommitQueue._failing_tests_message):

Scripts/webkitpy/tool/commands/queues_unittest.py:

(MockCommitQueueTask.results_from_test_run_without_patch): Deleted.

6:26 PM Changeset in webkit [175734] by dburkart@apple.com

5 edits in branches/safari-600.3-branch/Source

Version bump.

6:11 PM Changeset in webkit [175733] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/mac

Wrap the bulk of -[WebView dealloc] with an autorelease pool.
https://bugs.webkit.org/show_bug.cgi?id=138443

Patch by Daniel Jalkut <jalkut@red-sweater.com> on 2014-11-06
Reviewed by Anders Carlsson.

Wrapping the dealloc method in its own autorelease pool avoids the problem of
complex tear-downs leading to the WebView itself being added to an autorelease
pool that is not drained until after the instance has been dealloc'd.

WebView/WebView.mm:

(-[WebView dealloc]):

6:02 PM Changeset in webkit [175732] by commit-queue@webkit.org

4 edits in trunk/Source/WebKit2

Clients should be able to customize the view used for page previews
https://bugs.webkit.org/show_bug.cgi?id=138447

Patch by Conrad Shultz <Conrad Shultz> on 2014-11-06
Reviewed by Tim Horton.

Add SPI to WKView that clients can use to customize the view used in the page preview popover.

UIProcess/API/Cocoa/WKViewPrivate.h:

Declare -_viewForPreviewingURL:initialFrameSize:.

UIProcess/API/mac/WKView.mm:

(-[WKView _viewForPreviewingURL:initialFrameSize:]):
Return nil in the default implementation.

UIProcess/mac/WKActionMenuController.mm:

(-[WKPagePreviewViewController loadView]):
Only spin up a WKWebView if the delegate (and, therefore, the presenting WKView) doesn't supply a custom view.
(-[WKActionMenuController pagePreviewViewController:viewForPreviewingURL:initialFrameSize:]):
WKPagePreviewViewControllerDelegate method; wrap the WKView SPI.

5:14 PM Changeset in webkit [175731] by mark.lam@apple.com

3 edits in trunk/LayoutTests

Refactor the get-by-pname.js test [follow up 2].
<https://webkit.org/b/138483>

Reviewed by Michael Saboff.

Make unique copies of the test functions to ensure that each test case does not
affect the tiering up of other test cases.

js/get-by-pname-expected.txt:
js/script-tests/get-by-pname.js:

(foo): Deleted.
(getByPnameOnConstant): Deleted.
(getByPnameOnVar): Deleted.

4:53 PM Changeset in webkit [175730] by bshafiei@apple.com

2 edits in tags/Safari-601.1.8/Source/WebCore

Merged r175727. rdar://problem/18896362

4:49 PM Changeset in webkit [175729] by mark.lam@apple.com

2 edits in trunk/LayoutTests

Refactor the get-by-pname.js test [follow up].
<https://webkit.org/b/138483>

Reviewed by Michael Saboff.

Used named properties to make the test code more readable.

js/script-tests/get-by-pname.js:

(isTierIteration):
(tierName):
(testExpr): Deleted.
(testExpectedResult): Deleted.

4:34 PM Changeset in webkit [175728] by bshafiei@apple.com

2 edits in tags/Safari-601.1.8/Source/JavaScriptCore

Merged r175724. rdar://problem/18495847

4:27 PM Changeset in webkit [175727] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Fix typo in optimized fullscreen activation.
https://bugs.webkit.org/show_bug.cgi?id=138480

Patch by Jeremy Jones <jeremyj@apple.com> on 2014-11-06
Reviewed by Jer Noble.

Modules/mediacontrols/mediaControlsiOS.js:

(ControllerIOS.prototype.handleWrapperTouchStart): fix typo doubleTouchIntervalThresholdms
(ControllerIOS.prototype.handleOptimizedFullscreenButtonClicked): fix typo isFullScreen

4:24 PM Changeset in webkit [175726] by matthew_hanson@apple.com

3 edits
3 adds in branches/safari-600.2-branch

Merged r174740. rdar://problems/18883729

4:18 PM Changeset in webkit [175725] by ryuan.choi@navercorp.com

2 edits in trunk/Tools

Unreviewed. Reorder my e-mail addresses in contributors.json

Patch by Ryuan Choi <ryuan.choi@navercorp.com> on 2014-11-06

Scripts/webkitpy/common/config/contributors.json:

4:18 PM Changeset in webkit [175724] by mark.lam@apple.com

5 edits in trunk

slow_path_get_direct_pname() needs to be hardened against a constant baseValue.
<https://webkit.org/b/138476>

Reviewed by Michael Saboff.

Source/JavaScriptCore:

slow_path_get_direct_pname() currently assumes that the baseValue is always a
non-constant virtual register. However, this is not always the case like in the
following:

function foo() {

var o = { a:1 };
for (var n in o)

0[n];

}
foo();

This patch fixes it to also check for constant virtual register indexes.

runtime/CommonSlowPaths.cpp:

(JSC::SLOW_PATH_DECL):

LayoutTests:

js/get-by-pname-expected.txt:
js/script-tests/get-by-pname.js:

(getByPnameOnConstant):
(getByPnameOnVar):

Added more test cases.

4:02 PM Changeset in webkit [175723] by matthew_hanson@apple.com

4 edits in branches/safari-600.2-branch/Source/WebCore

Merged r175375. rdar://problems/18883734

3:53 PM Changeset in webkit [175722] by mark.lam@apple.com

3 edits in trunk/LayoutTests

Refactor the get-by-pname.js test.
<https://webkit.org/b/138483>

Reviewed by Geoffrey Garen.

Refactored the test code to:

make it easier to add more test cases.
test each case against different tier JITs.
print only one set of results for each tier being tested.

js/get-by-pname-expected.txt:
js/script-tests/get-by-pname.js:

(getByPnameOnConstant):
(getByPnameOnVar):
(testExpr):
(testExpectedResult):
(isTierIteration):
(tierName):

3:20 PM Changeset in webkit [175721] by Bem Jones-Bey

14 edits
11 adds
10 deletes in trunk/LayoutTests

[CSS Shapes] the spec-examples reftests are off by a few pixels
https://bugs.webkit.org/show_bug.cgi?id=135927

Reviewed by Zoltan Horvath.

Import new versions of the spec example tests that are js tests
instead of ref tests so that they can properly handle the small pixel
differences in rendering between platforms.

TestExpectations:
css3/shapes/spec-examples/shape-outside-010-expected.html: Removed.
css3/shapes/spec-examples/shape-outside-010-expected.txt: Added.
css3/shapes/spec-examples/shape-outside-010.html:
css3/shapes/spec-examples/shape-outside-011-expected.html: Removed.
css3/shapes/spec-examples/shape-outside-011-expected.txt: Added.
css3/shapes/spec-examples/shape-outside-011.html:
css3/shapes/spec-examples/shape-outside-012-expected.html: Removed.
css3/shapes/spec-examples/shape-outside-012-expected.txt: Added.
css3/shapes/spec-examples/shape-outside-012.html:
css3/shapes/spec-examples/shape-outside-013-expected.html: Removed.
css3/shapes/spec-examples/shape-outside-013-expected.txt: Added.
css3/shapes/spec-examples/shape-outside-013.html:
css3/shapes/spec-examples/shape-outside-014-expected.html: Removed.
css3/shapes/spec-examples/shape-outside-014-expected.txt: Added.
css3/shapes/spec-examples/shape-outside-014.html:
css3/shapes/spec-examples/shape-outside-015-expected.html: Removed.
css3/shapes/spec-examples/shape-outside-015-expected.txt: Added.
css3/shapes/spec-examples/shape-outside-015.html:
css3/shapes/spec-examples/shape-outside-016-expected.html: Removed.
css3/shapes/spec-examples/shape-outside-016-expected.txt: Added.
css3/shapes/spec-examples/shape-outside-016.html:
css3/shapes/spec-examples/shape-outside-017-expected.html: Removed.
css3/shapes/spec-examples/shape-outside-017-expected.txt: Added.
css3/shapes/spec-examples/shape-outside-017.html:
css3/shapes/spec-examples/shape-outside-018-expected.html: Removed.
css3/shapes/spec-examples/shape-outside-018-expected.txt: Added.
css3/shapes/spec-examples/shape-outside-018.html:
css3/shapes/spec-examples/shape-outside-019-expected.html: Removed.
css3/shapes/spec-examples/shape-outside-019-expected.txt: Added.
css3/shapes/spec-examples/shape-outside-019.html:
css3/shapes/spec-examples/support/spec-example-utils.js: Added.

(.runTest):
(approxShapeTest):

css3/shapes/spec-examples/support/w3c-import.log:
css3/shapes/spec-examples/w3c-import.log:

3:17 PM Changeset in webkit [175720] by Chris Dumez

8 edits
2 adds in trunk/Source/WebCore

Stop special-casing wbr elements in HTMLElement::createElementRenderer()
https://bugs.webkit.org/show_bug.cgi?id=138474

Reviewed by Ryosuke Niwa.

Stop special-casing wbr elements in HTMLElement::createElementRenderer()
and move the code to a HTMLWBRElement subclass instead, that is
overriding createElementRenderer(). This function is already virtual.

No new tests, no behavior change.

CMakeLists.txt:
WebCore.vcxproj/WebCore.vcxproj:
WebCore.xcodeproj/project.pbxproj:
html/HTMLElement.cpp:

(WebCore::HTMLElement::createElementRenderer):

html/HTMLElementsAllInOne.cpp:
html/HTMLTagNames.in:
html/HTMLWBRElement.cpp: Added.

(WebCore::HTMLWBRElement::create):
(WebCore::HTMLWBRElement::HTMLWBRElement):
(WebCore::HTMLWBRElement::createElementRenderer):

html/HTMLWBRElement.h: Added.
rendering/RenderLineBreak.cpp:

(WebCore::RenderLineBreak::RenderLineBreak):

3:06 PM Changeset in webkit [175719] by jer.noble@apple.com

277 edits in trunk/Source

De-templatize Timer
https://bugs.webkit.org/show_bug.cgi?id=138450

Reviewed by Anders Carlsson.

Source/WebCore:

Timer does not need to be a templated class; only it's constructors need to be templated.
Remove the template specifier from Timer and add same to its two class method
constructors. Replace the function pointer typedefs with using statements. Add a
helper typedef which allows invalid combinations of TimerFiredClass and
TimerFiredFunction to be caught early by the compiler, while still allowing
valid combinations (such as when the caller specifies a function on a subclass of
TimerFiredClass).

Modules/encryptedmedia/MediaKeySession.cpp:

(WebCore::MediaKeySession::keyRequestTimerFired):
(WebCore::MediaKeySession::addKeyTimerFired):

Modules/encryptedmedia/MediaKeySession.h:
Modules/geolocation/Geolocation.cpp:

(WebCore::Geolocation::GeoNotifier::timerFired):
(WebCore::Geolocation::resumeTimerFired):

Modules/geolocation/Geolocation.h:
Modules/indexeddb/IDBTransactionBackend.cpp:

(WebCore::IDBTransactionBackend::taskTimerFired):

Modules/indexeddb/IDBTransactionBackend.h:
Modules/mediasource/SourceBuffer.cpp:

(WebCore::SourceBuffer::appendBufferTimerFired):
(WebCore::SourceBuffer::removeTimerFired):

Modules/mediasource/SourceBuffer.h:
Modules/mediastream/MediaStream.cpp:

(WebCore::MediaStream::scheduledEventTimerFired):

Modules/mediastream/MediaStream.h:
Modules/mediastream/RTCDTMFSender.cpp:

(WebCore::RTCDTMFSender::scheduledEventTimerFired):

Modules/mediastream/RTCDTMFSender.h:
Modules/mediastream/RTCDataChannel.cpp:

(WebCore::RTCDataChannel::scheduledEventTimerFired):

Modules/mediastream/RTCDataChannel.h:
Modules/mediastream/RTCPeerConnection.cpp:

(WebCore::RTCPeerConnection::scheduledEventTimerFired):

Modules/mediastream/RTCPeerConnection.h:
Modules/notifications/Notification.cpp:

(WebCore::Notification::Notification):
(WebCore::Notification::taskTimerFired):

Modules/notifications/Notification.h:
Modules/notifications/NotificationCenter.cpp:

(WebCore::NotificationCenter::NotificationRequestCallback::timerFired):

Modules/notifications/NotificationCenter.h:
Modules/vibration/Vibration.cpp:

(WebCore::Vibration::timerFired):

Modules/vibration/Vibration.h:
Modules/websockets/WebSocketChannel.cpp:

(WebCore::WebSocketChannel::resumeTimerFired):
(WebCore::WebSocketChannel::closingTimerFired):

Modules/websockets/WebSocketChannel.h:
accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::notificationPostTimerFired):

accessibility/AXObjectCache.h:

(WebCore::AXObjectCache::AXObjectCache):

bindings/js/GCController.cpp:

(WebCore::GCController::gcTimerFired):

bindings/js/GCController.h:
css/CSSFontFaceSource.h:
css/CSSFontSelector.cpp:

(WebCore::CSSFontSelector::beginLoadTimerFired):

css/CSSFontSelector.h:
css/StyleResolver.cpp:

(WebCore::StyleResolver::sweepMatchedPropertiesCache):

css/StyleResolver.h:
dom/Document.cpp:

(WebCore::Document::visualUpdatesSuppressionTimerFired):
(WebCore::Document::styleRecalcTimerFired):
(WebCore::Document::optimizedStyleSheetUpdateTimerFired):
(WebCore::Document::sharedObjectPoolClearTimerFired):
(WebCore::Document::updateFocusAppearanceTimerFired):
(WebCore::Document::pendingTasksTimerFired):
(WebCore::Document::fullScreenChangeDelayTimerFired):
(WebCore::Document::loadEventDelayTimerFired):
(WebCore::Document::didAssociateFormControlsTimerFired):
(WebCore::Document::domCookieCacheExpiryTimerFired):

dom/Document.h:
dom/EventSender.h:

(WebCore::EventSender::timerFired):

dom/GenericEventQueue.cpp:

(WebCore::GenericEventQueue::timerFired):

dom/GenericEventQueue.h:
dom/ScriptRunner.cpp:

(WebCore::ScriptRunner::timerFired):

dom/ScriptRunner.h:
dom/ScriptedAnimationController.cpp:

(WebCore::ScriptedAnimationController::animationTimerFired):

dom/ScriptedAnimationController.h:
dom/StyledElement.cpp:

(WebCore::PresentationAttributeCacheCleaner::cleanCache):

editing/AlternativeTextController.cpp:

(WebCore::AlternativeTextController::timerFired):

editing/AlternativeTextController.h:
editing/Editor.cpp:

(WebCore::Editor::scanSelectionForTelephoneNumbers):
(WebCore::Editor::editorUIUpdateTimerFired):

editing/Editor.h:
editing/FrameSelection.cpp:

(WebCore::FrameSelection::caretBlinkTimerFired):

editing/FrameSelection.h:
editing/SpellChecker.cpp:

(WebCore::SpellChecker::timerFiredToProcessQueuedRequest):

editing/SpellChecker.h:
html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::requestAutocompleteTimerFired):

html/HTMLFormElement.h:
html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::parseAttribute):

html/HTMLMediaElement.h:
html/HTMLPlugInElement.cpp:

(WebCore::HTMLPlugInElement::swapRendererTimerFired):

html/HTMLPlugInElement.h:
html/HTMLPlugInImageElement.cpp:

(WebCore::HTMLPlugInImageElement::removeSnapshotTimerFired):

html/HTMLPlugInImageElement.h:
html/HTMLSourceElement.cpp:

(WebCore::HTMLSourceElement::errorEventTimerFired):

html/HTMLSourceElement.h:
html/HTMLTrackElement.cpp:

(WebCore::HTMLTrackElement::loadTimerFired):

html/HTMLTrackElement.h:
html/MediaController.cpp:

(MediaController::asyncEventTimerFired):
(MediaController::clearPositionTimerFired):
(MediaController::timeupdateTimerFired):

html/MediaController.h:
html/MediaDocument.cpp:

(WebCore::MediaDocument::replaceMediaElementTimerFired):

html/MediaDocument.h:
html/SearchInputType.cpp:

(WebCore::SearchInputType::searchEventTimerFired):

html/SearchInputType.h:
html/ValidationMessage.cpp:

(WebCore::ValidationMessage::setMessage):
(WebCore::ValidationMessage::setMessageDOMAndStartTimer):
(WebCore::ValidationMessage::buildBubbleTree):
(WebCore::ValidationMessage::requestToHideMessage):
(WebCore::ValidationMessage::deleteBubbleTree):

html/ValidationMessage.h:
html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::dispatchContextLostEvent):
(WebCore::WebGLRenderingContext::maybeRestoreContext):

html/canvas/WebGLRenderingContext.h:
html/parser/HTMLParserScheduler.cpp:

(WebCore::HTMLParserScheduler::continueNextChunkTimerFired):

html/parser/HTMLParserScheduler.h:
html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlPanelElement::transitionTimerFired):
(WebCore::MediaControlTextTrackContainerElement::updateTimerFired):

html/shadow/MediaControlElements.h:
html/shadow/MediaControls.cpp:

(WebCore::MediaControls::hideFullscreenControlsTimerFired):

html/shadow/MediaControls.h:
html/shadow/SpinButtonElement.cpp:

(WebCore::SpinButtonElement::repeatingTimerFired):

html/shadow/SpinButtonElement.h:
html/track/LoadableTextTrack.cpp:

(WebCore::LoadableTextTrack::loadTimerFired):

html/track/LoadableTextTrack.h:
html/track/VTTRegion.cpp:

(WebCore::VTTRegion::scrollTimerFired):

html/track/VTTRegion.h:
inspector/InspectorCSSAgent.cpp:

(WebCore::ChangeRegionOversetTask::timerFired):

inspector/InspectorDOMAgent.cpp:

(WebCore::RevalidateStyleAttributeTask::timerFired):

inspector/InspectorFrontendClientLocal.cpp:

(WebCore::InspectorBackendDispatchTask::timerFired):

inspector/InspectorOverlay.cpp:

(WebCore::InspectorOverlay::updatePaintRectsTimerFired):

inspector/InspectorOverlay.h:
loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::substituteResourceDeliveryTimerFired):

loader/DocumentLoader.h:
loader/FrameLoader.cpp:

(WebCore::FrameLoader::checkTimerFired):

loader/FrameLoader.h:
loader/ImageLoader.cpp:

(WebCore::ImageLoader::timerFired):

loader/ImageLoader.h:
loader/LinkLoader.cpp:

(WebCore::LinkLoader::linkLoadTimerFired):
(WebCore::LinkLoader::linkLoadingErrorTimerFired):

loader/LinkLoader.h:
loader/NavigationScheduler.cpp:

(WebCore::ScheduledNavigation::didStartTimer):
(WebCore::NavigationScheduler::timerFired):

loader/NavigationScheduler.h:
loader/PingLoader.h:

(WebCore::PingLoader::timeoutTimerFired):

loader/ProgressTracker.cpp:

(WebCore::ProgressTracker::progressHeartbeatTimerFired):

loader/ProgressTracker.h:
loader/ResourceLoadScheduler.cpp:

(WebCore::ResourceLoadScheduler::requestTimerFired):

loader/ResourceLoadScheduler.h:
loader/TextTrackLoader.cpp:

(WebCore::TextTrackLoader::cueLoadTimerFired):

loader/TextTrackLoader.h:
loader/cache/CachedResource.cpp:

(WebCore::CachedResource::Callback::timerFired):

loader/cache/CachedResource.h:
loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::garbageCollectDocumentResourcesTimerFired):

loader/cache/CachedResourceLoader.h:
loader/icon/IconDatabase.cpp:

(WebCore::IconDatabase::syncTimerFired):

loader/icon/IconDatabase.h:
page/AutoscrollController.cpp:

(WebCore::AutoscrollController::autoscrollTimerFired):

page/AutoscrollController.h:
page/CaptionUserPreferences.cpp:

(WebCore::CaptionUserPreferences::timerFired):

page/CaptionUserPreferences.h:
page/CaptionUserPreferencesMediaAF.cpp:

(WebCore::CaptionUserPreferencesMediaAF::updateTimerFired):

page/CaptionUserPreferencesMediaAF.h:
page/DeviceController.cpp:

(WebCore::DeviceController::fireDeviceEvent):

page/DeviceController.h:
page/EventHandler.cpp:

(WebCore::EventHandler::cursorUpdateTimerFired):
(WebCore::EventHandler::autoHideCursorTimerFired):
(WebCore::EventHandler::recognizeLongMousePress):
(WebCore::EventHandler::fakeMouseMoveEventTimerFired):
(WebCore::EventHandler::hoverTimerFired):

page/EventHandler.h:
page/EventSource.cpp:

(WebCore::EventSource::connectTimerFired):

page/EventSource.h:
page/FocusController.cpp:

(WebCore::FocusController::focusRepaintTimerFired):

page/FocusController.h:
page/Frame.cpp:

(WebCore::Frame::overflowAutoScrollTimerFired):

page/Frame.h:
page/FrameView.cpp:

(WebCore::FrameView::delayedScrollEventTimerFired):
(WebCore::FrameView::speculativeTilingEnableTimerFired):
(WebCore::FrameView::layoutTimerFired):
(WebCore::FrameView::updateEmbeddedObjectsTimerFired):
(WebCore::FrameView::postLayoutTimerFired):

page/FrameView.h:
page/PageOverlay.cpp:

(WebCore::PageOverlay::fadeAnimationTimerFired):

page/PageOverlay.h:
page/Settings.cpp:

(WebCore::Settings::imageLoadingSettingsTimerFired):

page/Settings.h:
page/animation/AnimationController.cpp:

(WebCore::AnimationControllerPrivate::updateStyleIfNeededDispatcherFired):
(WebCore::AnimationControllerPrivate::animationTimerFired):

page/animation/AnimationControllerPrivate.h:
page/mac/ServicesOverlayController.h:
page/mac/ServicesOverlayController.mm:

(WebCore::ServicesOverlayController::determineActiveHighlightTimerFired):

page/scrolling/AsyncScrollingCoordinator.cpp:

(WebCore::AsyncScrollingCoordinator::updateScrollPositionAfterAsyncScrollTimerFired):

page/scrolling/AsyncScrollingCoordinator.h:
page/scrolling/ios/ScrollingCoordinatorIOS.h:
page/scrolling/ios/ScrollingCoordinatorIOS.mm:

(WebCore::ScrollingCoordinatorIOS::scrollingStateTreeCommitterTimerFired):

page/scrolling/mac/ScrollingCoordinatorMac.h:
page/scrolling/mac/ScrollingCoordinatorMac.mm:

(WebCore::ScrollingCoordinatorMac::scrollingStateTreeCommitterTimerFired):

platform/HysteresisActivity.h:

(WebCore::HysteresisActivity::hysteresisTimerFired):

platform/ScrollAnimator.cpp:

(WebCore::ScrollAnimator::updateScrollAnimatorsAndTimers):
(WebCore::ScrollAnimator::startScrollSnapTimer):
(WebCore::ScrollAnimator::stopScrollSnapTimer):
(WebCore::ScrollAnimator::horizontalScrollSnapTimerFired):
(WebCore::ScrollAnimator::verticalScrollSnapTimerFired):

platform/ScrollAnimator.h:
platform/ScrollAnimatorNone.cpp:

(WebCore::ScrollAnimatorNone::animationTimerFired):

platform/ScrollAnimatorNone.h:
platform/Scrollbar.cpp:

(WebCore::Scrollbar::autoscrollTimerFired):

platform/Scrollbar.h:
platform/Timer.h:

(WebCore::Timer::Timer):

platform/audio/MediaSession.cpp:

(WebCore::MediaSession::clientDataBufferingTimerFired):

platform/audio/MediaSession.h:
platform/efl/BatteryProviderEfl.cpp:

(WebCore::BatteryProviderEfl::timerFired):

platform/efl/BatteryProviderEfl.h:
platform/graphics/BitmapImage.cpp:

(WebCore::BitmapImage::startAnimation):
(WebCore::BitmapImage::advanceAnimation):

platform/graphics/BitmapImage.h:
platform/graphics/MediaPlayer.cpp:

(WebCore::MediaPlayer::reloadTimerFired):

platform/graphics/MediaPlayer.h:
platform/graphics/ShadowBlur.cpp:

(WebCore::ScratchBuffer::timerFired):

platform/graphics/TiledBackingStore.cpp:

(WebCore::TiledBackingStore::tileBufferUpdateTimerFired):
(WebCore::TiledBackingStore::backingStoreUpdateTimerFired):

platform/graphics/TiledBackingStore.h:
platform/graphics/avfoundation/MediaSelectionGroupAVFObjC.h:
platform/graphics/avfoundation/MediaSelectionGroupAVFObjC.mm:

(WebCore::MediaSelectionGroupAVFObjC::selectionTimerFired):

platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h:
platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:

(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::seekTimerFired):

platform/graphics/ca/LayerPool.cpp:

(WebCore::LayerPool::pruneTimerFired):

platform/graphics/ca/LayerPool.h:
platform/graphics/ca/TileController.cpp:

(WebCore::TileController::tileRevalidationTimerFired):

platform/graphics/ca/TileController.h:
platform/graphics/ca/TileGrid.cpp:

(WebCore::TileGrid::cohortRemovalTimerFired):

platform/graphics/ca/TileGrid.h:
platform/graphics/ca/win/LegacyCACFLayerTreeHost.cpp:

(WebCore::LegacyCACFLayerTreeHost::renderTimerFired):

platform/graphics/ca/win/LegacyCACFLayerTreeHost.h:
platform/graphics/cg/IOSurfacePool.cpp:

(WebCore::IOSurfacePool::collectionTimerFired):

platform/graphics/cg/IOSurfacePool.h:
platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::fillTimerFired):

platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
platform/graphics/mac/MediaPlayerPrivateQTKit.h:
platform/graphics/mac/MediaPlayerPrivateQTKit.mm:

(WebCore::MediaPlayerPrivateQTKit::seekTimerFired):

platform/graphics/texmap/TextureMapper.cpp:

(WebCore::BitmapTexturePool::releaseUnusedTexturesTimerFired):

platform/graphics/texmap/coordinated/CompositingCoordinator.cpp:

(WebCore::CompositingCoordinator::releaseInactiveAtlasesTimerFired):

platform/graphics/texmap/coordinated/CompositingCoordinator.h:
platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:

(WebCore::CoordinatedGraphicsLayer::animationStartedTimerFired):

platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h:
platform/graphics/texmap/coordinated/CoordinatedImageBacking.cpp:

(WebCore::CoordinatedImageBacking::clearContentsTimerFired):

platform/graphics/texmap/coordinated/CoordinatedImageBacking.h:
platform/ios/LegacyTileCache.h:
platform/ios/LegacyTileCache.mm:

(WebCore::LegacyTileCache::tileCreationTimerFired):

platform/mac/HIDGamepadProvider.cpp:

(WebCore::HIDGamepadProvider::connectionDelayTimerFired):
(WebCore::HIDGamepadProvider::inputNotificationTimerFired):

platform/mac/HIDGamepadProvider.h:
platform/mac/ScrollAnimatorMac.h:
platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::snapRubberBandTimerFired):
(WebCore::ScrollAnimatorMac::initialScrollbarPaintTimerFired):
(WebCore::ScrollAnimatorMac::sendContentAreaScrolledTimerFired):

platform/mock/DeviceMotionClientMock.cpp:

(WebCore::DeviceMotionClientMock::timerFired):

platform/mock/DeviceMotionClientMock.h:
platform/mock/DeviceOrientationClientMock.cpp:

(WebCore::DeviceOrientationClientMock::timerFired):

platform/mock/DeviceOrientationClientMock.h:
platform/mock/GeolocationClientMock.cpp:

(WebCore::GeolocationClientMock::permissionTimerFired):
(WebCore::GeolocationClientMock::controllerTimerFired):

platform/mock/GeolocationClientMock.h:
platform/mock/PlatformSpeechSynthesizerMock.cpp:

(WebCore::PlatformSpeechSynthesizerMock::speakingFinished):

platform/mock/PlatformSpeechSynthesizerMock.h:
platform/mock/TimerEventBasedMock.h:

(WebCore::TimerEvent::timerFired):

platform/network/DNSResolveQueue.cpp:

(WebCore::DNSResolveQueue::timerFired):

platform/network/DNSResolveQueue.h:
platform/network/NetworkStateNotifier.h:
platform/network/ResourceHandle.cpp:

(WebCore::ResourceHandle::failureTimerFired):

platform/network/ResourceHandle.h:
platform/network/ResourceHandleInternal.h:
platform/network/curl/ResourceHandleManager.cpp:

(WebCore::ResourceHandleManager::downloadTimerCallback):

platform/network/curl/ResourceHandleManager.h:
platform/network/mac/NetworkStateNotifierMac.cpp:

(WebCore::NetworkStateNotifier::networkStateChangeTimerFired):

platform/network/win/ResourceHandleWin.cpp:

(WebCore::ResourceHandle::fileLoadTimer):

plugins/PluginPackage.cpp:

(WebCore::PluginPackage::freeLibraryTimerFired):

plugins/PluginPackage.h:
plugins/PluginStream.cpp:

(WebCore::PluginStream::delayDeliveryTimerFired):

plugins/PluginStream.h:
plugins/PluginView.cpp:

(WebCore::PluginView::popPopupsStateTimerFired):
(WebCore::PluginView::requestTimerFired):
(WebCore::PluginView::invalidateTimerFired):
(WebCore::PluginView::lifeSupportTimerFired):

plugins/PluginView.h:
plugins/win/PluginMessageThrottlerWin.cpp:

(WebCore::PluginMessageThrottlerWin::messageThrottleTimerFired):

plugins/win/PluginMessageThrottlerWin.h:
rendering/ImageQualityController.cpp:

(WebCore::ImageQualityController::highQualityRepaintTimerFired):

rendering/ImageQualityController.h:
rendering/RenderButton.cpp:

(WebCore::RenderButton::styleDidChange):
(WebCore::RenderButton::timerFired):

rendering/RenderButton.h:
rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::updateCompositingLayersTimerFired):
(WebCore::RenderLayerCompositor::layerFlushTimerFired):
(WebCore::RenderLayerCompositor::paintRelatedMilestonesTimerFired):

rendering/RenderLayerCompositor.h:
rendering/RenderMarquee.cpp:

(WebCore::RenderMarquee::timerFired):

rendering/RenderMarquee.h:
rendering/RenderNamedFlowThread.cpp:

(WebCore::RenderNamedFlowThread::regionOversetChangeEventTimerFired):

rendering/RenderNamedFlowThread.h:
rendering/RenderProgress.cpp:

(WebCore::RenderProgress::animationTimerFired):

rendering/RenderProgress.h:
rendering/RenderView.cpp:

(WebCore::RenderView::lazyRepaintTimerFired):

rendering/RenderView.h:
replay/EventLoopInputDispatcher.cpp:

(WebCore::EventLoopInputDispatcher::timerFired):

replay/EventLoopInputDispatcher.h:
storage/StorageAreaImpl.cpp:

(WebCore::StorageAreaImpl::closeDatabaseTimerFired):

storage/StorageAreaImpl.h:
storage/StorageAreaSync.cpp:

(WebCore::StorageAreaSync::syncTimerFired):

storage/StorageAreaSync.h:
svg/SVGElement.cpp:

(WebCore::SVGElement::svgLoadEventTimerFired):
(WebCore::SVGElement::svgLoadEventTimer):

svg/SVGElement.h:
svg/SVGScriptElement.h:
svg/SVGStyleElement.h:
svg/SVGUseElement.h:
svg/animation/SMILTimeContainer.cpp:

(WebCore::SMILTimeContainer::timerFired):

svg/animation/SMILTimeContainer.h:
xml/XMLHttpRequestProgressEventThrottle.cpp:

(WebCore::XMLHttpRequestProgressEventThrottle::dispatchDeferredEvents):

xml/XMLHttpRequestProgressEventThrottle.h:

Source/WebKit/mac:

Remove template specifiers from Timer.

Plugins/Hosted/NetscapePluginInstanceProxy.h:
Plugins/Hosted/NetscapePluginInstanceProxy.mm:

(WebKit::NetscapePluginInstanceProxy::requestTimerFired):

Plugins/WebNetscapePluginStream.h:
Plugins/WebNetscapePluginStream.mm:

(WebNetscapePluginStream::deliverDataTimerFired):

Source/WebKit/win:

FullscreenVideoController.cpp:

(FullscreenVideoController::timerFired):

FullscreenVideoController.h:

Source/WebKit2:

Remove template specifiers from Timer.

NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::NetworkResourceLoader::bufferingTimerFired):

NetworkProcess/NetworkResourceLoader.h:
Shared/WebMemorySampler.cpp:

(WebKit::WebMemorySampler::sampleTimerFired):
(WebKit::WebMemorySampler::stopTimerFired):

Shared/WebMemorySampler.h:
Shared/mac/RemoteLayerBackingStoreCollection.h:
Shared/mac/RemoteLayerBackingStoreCollection.mm:

(WebKit::RemoteLayerBackingStoreCollection::volatilityTimerFired):

UIProcess/API/efl/EwkView.cpp:

(EwkView::displayTimerFired):

UIProcess/API/efl/EwkView.h:
UIProcess/efl/TextCheckerClientEfl.cpp:

(TextCheckerClientEfl::languagesUpdateTimerFired):
(TextCheckerClientEfl::spellCheckingSettingChangeTimerFired):

UIProcess/efl/TextCheckerClientEfl.h:
WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:

(WebKit::CoordinatedLayerTreeHost::layerFlushTimerFired):

WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h:
WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h:
WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:

(WebKit::RemoteLayerTreeDrawingArea::layerFlushTimerFired):

WebProcess/WebProcess.cpp:

(WebKit::WebProcess::processSuspensionCleanupTimerFired):
(WebKit::WebProcess::nonVisibleProcessCleanupTimerFired):

WebProcess/WebProcess.h:

2:51 PM Changeset in webkit [175718] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Don't send identifierForInitialRequest callback method for request with DoNotSendCallbacks option.
https://bugs.webkit.org/show_bug.cgi?id=138473

The iOS specific code that sets up a valid m_identifier is not needed any more, since this
will be done later in ResourceLoader::willSendRequest. This also matches the behavior that
we don't call assignIdentifierToInitialRequest callback method if the reqeust has
DoNotSendCallbacks option.

Patch by Yongjun Zhang <yongjun_zhang@apple.com> on 2014-11-06
Reviewed by Pratik Solanki.

loader/ResourceLoader.cpp:

(WebCore::ResourceLoader::willSendRequest): Remove iOS specific block for setting up a valid

m_identifier. In iOS, also make sure we still bail out if the resource loader was stopped
in assignIdentifierToInitialRequest callback by a client.

2:41 PM Changeset in webkit [175717] by matthew_hanson@apple.com

2 edits in trunk/Tools

Remove code that prepends a leading 'r' to the first argument of _run_git_svn_find_rev
https://bugs.webkit.org/show_bug.cgi?id=138475

Reviewed by Ryosuke Niwa.

The change in https://trac.webkit.org/175603 introduced broke compatibility with svn_revision_from_git_commit.
This patch reverts the part of that change that broke compatibility. In addition, this patch adds a comment to
explain that SVN revisions require a leading 'r', moves an existing comment to a more appropriate location and
renames the positional argument to better reflect that it can represent either an SVN revision or a Git tree-ish.

Scripts/webkitpy/common/checkout/scm/git.py:

(Git._run_git_svn_find_rev):
Add comment mentioning that svn_revisions need to begin with 'r'.
Move comment (explaining that git svn find-rev exits with code 0 when no match is found) to a more appropriate location.
Rename the argument 'revision' to 'revision_or_treeish' to reflect the dual form that argument can take.
Remove code that coerced the revision/treeish into a string and prepended an 'r'.

2:23 PM Changeset in webkit [175716] by dino@apple.com

34 edits
16 adds in trunk

[filters2] Support for backdrop-filter
https://bugs.webkit.org/show_bug.cgi?id=138384
<rdar://problem/18874494>

Reviewed by Simon Fraser.

Take 2!! Previous patch was rolled out.

Source/WebCore:

Add prototype support for backdrop-filter
http://dev.w3.org/fxtf/filters-2/#BackdropFilterProperty

This adds support for parsing the new CSS property, adding
the value to RenderStyle, noticing that on the layer tree,
and the platform code in GraphicsLayer to render a backdrop
and apply an effect to the result.

Some things are missing:

animation of the backdrop-filter is not yet supported
backdrops will not work in cloned layers yet (e.g. reflections)

Tests: css3/filters/backdrop/backdropfilter-property-computed-style.html

css3/filters/backdrop/backdropfilter-property-parsing-invalid.html
css3/filters/backdrop/backdropfilter-property-parsing.html
css3/filters/backdrop/backdropfilter-property.html
css3/filters/backdrop/effect-hw.html

WebCore.exp.in: Export the setBackdropFilters method so it can

be used from WebKit.

css/CSSComputedStyleDeclaration.cpp: New property name.

(WebCore::isLayoutDependent):
(WebCore::ComputedStyleExtractor::propertyValue): Use the existing valueForFilter method.

css/CSSParser.cpp:

(WebCore::CSSParser::parseValue): Piggyback on the filter parser.

css/CSSPropertyNames.in: Add -webkit-backdrop-filter.

css/StyleResolver.cpp:

(WebCore::StyleResolver::adjustRenderStyle): Add test for backdrop.
(WebCore::StyleResolver::applyProperty): Support new property.

platform/graphics/GraphicsLayer.h:

(WebCore::GraphicsLayer::needsBackdrop): New method to test for existence of values.
(WebCore::GraphicsLayer::backdropFilters): Keeps the list of filters.
(WebCore::GraphicsLayer::setBackdropFilters):
(WebCore::GraphicsLayer::clearBackdropFilters):

platform/graphics/ca/GraphicsLayerCA.cpp: This adds a new m_backdropLayer CALayer

that will sit behind the contents layer and provide the element's backdrop.
(WebCore::GraphicsLayerCA::willBeDestroyed):
(WebCore::GraphicsLayerCA::moveOrCopyAnimations):
(WebCore::GraphicsLayerCA::setBackdropFilters): Set a custom appearance so
remote layer hosts will notice the special layer. Also set the actual
layer properties.
(WebCore::GraphicsLayerCA::addAnimation): Remove whitespace.
(WebCore::GraphicsLayerCA::commitLayerChangesBeforeSublayers): Update backdrop if necessary.
(WebCore::GraphicsLayerCA::updateLayerNames): Give the new layer a name.
(WebCore::GraphicsLayerCA::updateSublayerList):
(WebCore::GraphicsLayerCA::updateGeometry): Make the backdrop layer match the contents
layer geometry.
(WebCore::GraphicsLayerCA::updateBackdropFilters): Create the backdrop layer if necessary,
and copy the filter values to any clones.
(WebCore::GraphicsLayerCA::ensureStructuralLayer): We need a structural layer if we
have backdrop filters.
(WebCore::GraphicsLayerCA::structuralLayerPurpose):
(WebCore::GraphicsLayerCA::createAnimationFromKeyframes):
(WebCore::GraphicsLayerCA::swapFromOrToTiledLayer):

platform/graphics/ca/GraphicsLayerCA.h: New StructuralLayerPurpose, new LayerChangeFlag.

platform/graphics/ca/PlatformCALayer.h: New LayerType.

platform/graphics/ca/mac/PlatformCALayerMac.mm: Define CABackdropLayer.

(PlatformCALayerMac::PlatformCALayerMac): Create the correct CALayer type.

rendering/RenderElement.h:

(WebCore::RenderElement::createsGroup):
(WebCore::RenderElement::hasBackdropFilter): This method is always around, but
only can return true when FILTERS_LEVEL_2 is enabled.

rendering/RenderLayer.cpp:

(WebCore::RenderLayer::paintsWithFilters): Remove an unnecessary comment.
(WebCore::RenderLayer::calculateClipRects):

rendering/RenderLayer.h: Add hasBackdropFilter.

rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::RenderLayerBacking):
(WebCore::RenderLayerBacking::createPrimaryGraphicsLayer): Update the backdrop filters.
(WebCore::RenderLayerBacking::updateBackdropFilters): Set the filters on the GraphicsLayer.
(WebCore::RenderLayerBacking::updateGeometry):

rendering/RenderLayerBacking.h:

rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::requiresOwnBackingStore): Needs backingstore if it has a backdrop filter.
(WebCore::RenderLayerCompositor::reasonsForCompositing):
(WebCore::RenderLayerCompositor::requiresCompositingForFilters): Return early if we have
a backdrop filter, because currently we absolutely require compositing.

rendering/RenderLayerModelObject.cpp:

(WebCore::RenderLayerModelObject::styleWillChange): Add hasBackdropFilter().

rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::changeRequiresLayout): Check backdrops for change.

rendering/style/RenderStyle.h: Add the backdropFilter style stuff.
rendering/style/StyleRareNonInheritedData.cpp:

(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator==):
(WebCore::StyleRareNonInheritedData::hasBackdropFilters):

rendering/style/StyleRareNonInheritedData.h:

Source/WebKit2:

Shared/mac/RemoteLayerBackingStore.mm:

(WebKit::RemoteLayerBackingStore::drawInContext): Handle LayerTypeBackdropLayer in the switch.

Shared/mac/RemoteLayerTreeTransaction.mm:

(WebKit::RemoteLayerTreeTransaction::description): Describe a backdrop layer.

UIProcess/ios/RemoteLayerTreeHostIOS.mm:

(+[WKBackdropView layerClass]): Define CABackdropLayer and use it as the class.
(WebKit::RemoteLayerTreeHost::createLayer):

UIProcess/mac/RemoteLayerTreeHost.mm: Ditto.

(WebKit::RemoteLayerTreeHost::createLayer):

LayoutTests:

Tests for backdrop-filter. These are skipped on non-Apple platforms.

platform/win/TestExpections: Skip these tests.
platform/efl/TestExpections:
platform/gtk/TestExpections:
platform/mac-mavericks/TestExpectations: Yosemite only.

css3/filters/backdrop/backdropfilter-property-computed-style-expected.txt: Added.
css3/filters/backdrop/backdropfilter-property-computed-style.html: Added.
css3/filters/backdrop/backdropfilter-property-expected.txt: Added.
css3/filters/backdrop/backdropfilter-property-parsing-expected.txt: Added.
css3/filters/backdrop/backdropfilter-property-parsing-invalid-expected.txt: Added.
css3/filters/backdrop/backdropfilter-property-parsing-invalid.html: Added.
css3/filters/backdrop/backdropfilter-property-parsing.html: Added.
css3/filters/backdrop/backdropfilter-property.html: Added.
css3/filters/backdrop/effect-hw-expected.html: Added.
css3/filters/backdrop/effect-hw.html: Added.
css3/filters/backdrop/script-tests/backdropfilter-property-computed-style.js: Added.

(testComputedFilterRule):

css3/filters/backdrop/script-tests/backdropfilter-property-parsing-invalid.js: Added.

(testInvalidFilterRule):

css3/filters/backdrop/script-tests/backdropfilter-property-parsing.js: Added.

(jsWrapperClass):
(shouldBeType):
(testFilterRule):

css3/filters/backdrop/script-tests/backdropfilter-property.js: Added.

2:07 PM Changeset in webkit [175715] by benjamin@webkit.org

8 edits
2 adds in trunk

Give pseudo elements the correct specificity
https://bugs.webkit.org/show_bug.cgi?id=138378

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-11-06
Reviewed by Dean Jackson.

Source/WebCore:

WebKit had an old silly bug where pseudo elements were given specificity in the class B
instead of the class C.

Now that the inspector shows the specificity, this bug is much more visible which is why
I fix it now.

Test: fast/css/pseudo-element-specificity.html

css/CSSSelector.cpp:

(WebCore::CSSSelector::specificityForOneSelector):
Give pseudo-elements the right specificity.

Modules/mediacontrols/mediaControlsApple.css:

(video::-webkit-media-controls-volume-slider):
(audio::-webkit-media-controls-volume-slider::-webkit-slider-thumb):
(audio::-webkit-media-controls-volume-slider::-webkit-slider-thumb:active::-webkit-slider-thumb):
(audio::-webkit-media-controls-timeline):
(audio::-webkit-media-controls-timeline::-webkit-slider-thumb):
(audio::-webkit-media-controls-timeline:active::-webkit-slider-thumb,):
(video:-webkit-full-screen::-webkit-media-controls-volume-slider):
(video:-webkit-full-screen::-webkit-media-controls-volume-slider::-webkit-slider-thumb):

Modules/mediacontrols/mediaControlsBase.css:

css/mediaControls.css:

(audio::-webkit-media-controls-volume-slider, video::-webkit-media-controls-volume-slider):
(audio::-webkit-media-controls-volume-slider-mute-button, video::-webkit-media-controls-volume-slider-mute-button):

css/mediaControlsGtk.css:

(audio::-webkit-media-controls-timeline, video::-webkit-media-controls-timeline):
(audio::-webkit-media-controls-timeline[disabled], video::-webkit-media-controls-timeline[disabled]):
(audio::-webkit-media-controls-volume-slider, video::-webkit-media-controls-volume-slider):
The media controls were relying on the bug to override the style of input[type=range].

Ideally we should either:
-Implement some kind of high level style isolation (e.g. CSS Scoping).
-Fix the media control tree to use regular CSS scoped by a shadow pseudo ID.

Until we have one of those, I just fixed the styling by forcing the properties with lower
specificity with !important.

LayoutTests:

fast/css/pseudo-element-specificity-expected.html: Added.
fast/css/pseudo-element-specificity.html: Added.

Given that all selector affecting the pseudo element were offset by one,
it is impossible to use a pseudo element directly to affect the order, making the bug
hard to test.

What I did here for testing is use the stauration at 255 of any specificity field.
With 255 class + 1 pseudo element, the old code would saturate at (0, 255, 0), while
the fixed code would correctly give (0, 255, 1). By comparing that to a non-saturated
selector, I can show the fix is correct.

inspector/css/selector-specificity-expected.txt:

2:04 PM Changeset in webkit [175714] by dburkart@apple.com

1 copy in tags/Safari-600.3.4

Tagging Safari-600.3.4

2:03 PM Changeset in webkit [175713] by dburkart@apple.com

1 delete in tags/Safari-600.3.4

Removing tag to re-tag with another fix.

2:01 PM Changeset in webkit [175712] by dburkart@apple.com

4 edits in branches/safari-600.3-branch/Source

Merged r175710. <rdar://problems/18898712>

1:35 PM Changeset in webkit [175711] by timothy_horton@apple.com

2 edits in trunk/Source/WebKit2

Data detectors popover points at the first line of the detected item
https://bugs.webkit.org/show_bug.cgi?id=138471
<rdar://problem/18893079>

Reviewed by Sam Weinig.

WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::scanForDataDetectedItems):
Determine the bounding box of all quads of the detected item's text.
This way, the popover will point at the border of the item, instead of
right at the very first line.

1:03 PM Changeset in webkit [175710] by Beth Dakin

4 edits in trunk/Source

Preview views often misplaced inside popover
https://bugs.webkit.org/show_bug.cgi?id=138472

Reviewed by Tim Horton.

Source/WebCore:

WebCore.exp.in:

Source/WebKit2:

This patch makes the popover maintain aspect ratio, and it uses the final scale of
that popover to scale the preview view as well.

UIProcess/mac/WKActionMenuController.mm:

(-[WKPagePreviewViewController initWithPageURL:mainViewSize:popoverToViewScale:]):
(-[WKPagePreviewViewController loadView]):
(-[WKActionMenuController _createPreviewPopoverForURL:originRect:]):
(-[WKActionMenuController _targetSize:fitsInAvailableSpace:]):
(-[WKActionMenuController _preferredSizeForPopoverPresentedFromOriginRect:]):
(-[WKPagePreviewViewController initWithPageURL:]): Deleted.

12:37 PM Changeset in webkit [175709] by bshafiei@apple.com

5 edits in tags/Safari-601.1.8/Source

Merged r175706. rdar://problem/18813675

12:03 PM Changeset in webkit [175708] by ap@apple.com

2 edits in trunk/LayoutTests

inspector-protocol/debugger/setPauseOnExceptions-uncaught.html frequently times out on Yosemite
https://bugs.webkit.org/show_bug.cgi?id=138097

platform/mac-wk2/TestExpectations: Marking it as such.

11:57 AM Changeset in webkit [175707] by dburkart@apple.com

1 copy in tags/Safari-600.3.4

Tagging Safari-600.3.4

11:47 AM Changeset in webkit [175706] by msaboff@apple.com

5 edits in trunk/Source

REGRESSION (r174985-174986): Site display disappears
https://bugs.webkit.org/show_bug.cgi?id=138082

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

In support of the change in WebCore, this adds a new functor class to unwind to our
caller's frame possibly skipping of intermediate C++ frames.

interpreter/StackVisitor.h:

(JSC::CallerFunctor::CallerFunctor):
(JSC::CallerFunctor::callerFrame):
(JSC::CallerFunctor::operator()):

Source/WebCore:

This effectively reverts to the behavior before r174985 by using the
lexical global object of the caller's frame to find the active document.
Before r174985, native functions are invoked with the ScopeShain of their
caller. The lexical global object is accessed from the ScopeChain.

bindings/js/JSHTMLDocumentCustom.cpp:

(WebCore::JSHTMLDocument::getOwnPropertySlot):
(WebCore::findOwningDocument):
(WebCore::documentWrite):
(WebCore::JSHTMLDocument::write):
(WebCore::JSHTMLDocument::writeln):

html/HTMLDocument.idl:

11:38 AM Changeset in webkit [175705] by timothy_horton@apple.com

3 edits in trunk/Source/WebKit2

TextIndicatorWindow's bounce animation is lopsided when indicating two short lines of text
https://bugs.webkit.org/show_bug.cgi?id=138458

Reviewed by Simon Fraser.

Previously, the TextIndicator's frame() covered the entire selection highlight bounds.
This was undesirable in cases where the highlight included areas far outside the
bounds of the selected text, as the TextIndicatorWindow's 'bounce' animation
would be misaligned (centered on the highlight instead of on the text).

Shared/TextIndicator.cpp:

Get rid of the many-argument TextIndicator::create, because it was only used
internally, and have createWithSelectionInFrame make a ::Data instead.

(WebKit::TextIndicator::createWithSelectionInFrame):
Compute and store the bounding rect of all of the selected text rects, and store
all of the text rects relative to that bounding rect instead of relative to the
selection highlight bounds. We do this because the selection highlight bounds
often includes area which is far outside of the text bounds (in the case of a
selection that spans multiple lines), and causes the text indicator bounce
animation to bounce in a lopsided manner.

(WebKit::TextIndicator::TextIndicator):
Adjust to the rename of textRectsInSelectionRectCoordinates -> textRectsInBoundingRectCoordinates.

(WebKit::TextIndicator::frameRect):
Instead of the TextIndicator's frame being the selection highlight bounds,
it is now the bounds of all of the text rects.

(WebKit::TextIndicator::draw):
Translate into the image by the difference between the selection highlight bounds
and the text bounding rect. This is necessary because the content image is still generated
covering the entire selection highlight bounds, but the text rects are in text-rect-bounds coordinates.

(WebKit::TextIndicator::Data::encode):
(WebKit::TextIndicator::Data::decode):
Adjust to the rename of textRectsInSelectionRectCoordinates -> textRectsInBoundingRectCoordinates.
Encode/decode textBoundingRectInWindowCoordinates.

Shared/TextIndicator.h:

(WebKit::TextIndicator::contentImage): Deleted.
Get rid of an unnecessary getter and constructor.

11:04 AM Changeset in webkit [175704] by timothy_horton@apple.com

2 edits in trunk/Source/WebKit2

Only provide a single result to the action menu DDActionContext
https://bugs.webkit.org/show_bug.cgi?id=138469
<rdar://problem/18869036>

Reviewed by Anders Carlsson.

WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::scanForDataDetectedItems):
Only provide one result; secondary results can be extremely unrelated to
the primary one and confuse Data Detectors further down the line.

11:02 AM Changeset in webkit [175703] by bshafiei@apple.com

2 edits in tags/Safari-601.1.8/Source/WTF

Merge patch for <rdar://problem/18887867> to disable bmalloc.

10:58 AM Changeset in webkit [175702] by timothy_horton@apple.com

2 edits in trunk/Source/WebKit2

Null deref in rangeForDictionaryLookupAtHitTestResult on occasion
https://bugs.webkit.org/show_bug.cgi?id=138459
<rdar://problem/18872825>

Reviewed by Andreas Kling.

WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::rangeForDictionaryLookupAtHitTestResult):
rangeExpandedAroundPositionByCharacters can return null.

10:57 AM Changeset in webkit [175701] by timothy_horton@apple.com

2 edits in trunk/Source/WebKit2

Prefer link action menus over images
https://bugs.webkit.org/show_bug.cgi?id=138461
<rdar://problem/18768377>

Reviewed by Anders Carlsson.

UIProcess/mac/WKActionMenuController.mm:

(-[WKActionMenuController _defaultMenuItems:]):
Swap the priority of links and images.

10:46 AM Changeset in webkit [175700] by weinig@apple.com

11 edits in trunk/Source

Use std::unique_ptr for TileController
https://bugs.webkit.org/show_bug.cgi?id=138429

Reviewed by Anders Carlsson.

Source/WebCore:

WebCore.exp.in:
platform/graphics/ca/TileController.cpp:

(WebCore::TileController::create): Deleted.

platform/graphics/ca/TileController.h:
platform/graphics/ca/mac/WebTiledBackingLayer.h:
platform/graphics/ca/mac/WebTiledBackingLayer.mm:

(-[WebTiledBackingLayer createTileController:]):

platform/graphics/ca/win/PlatformCALayerWinInternal.cpp:

(PlatformCALayerWinInternal::createTileController):

platform/graphics/ca/win/PlatformCALayerWinInternal.h:

Source/WebKit2:

WebProcess/WebPage/mac/PlatformCALayerRemoteTiledBacking.cpp:

(WebKit::PlatformCALayerRemoteTiledBacking::PlatformCALayerRemoteTiledBacking):

WebProcess/WebPage/mac/PlatformCALayerRemoteTiledBacking.h:

10:05 AM Changeset in webkit [175699] by mitz@apple.com

2 edits in trunk/Source/WebKit2

iOS build fix.

WebProcess/Plugins/PluginController.h:

8:40 AM Changeset in webkit [175698] by dbates@webkit.org

6 edits
2 adds in trunk/Source/WebKit2

[iOS] WebProcess needs to take a background task assertion to prevent being killed
for "suspended with locked system files"
https://bugs.webkit.org/show_bug.cgi?id=138155
<rdar://problem/17939303>

Reviewed by Anders Carlsson.

Mitigates an issue where the WebProcess may be killed when suspended holding locked files
by allowing the WebProcess to notify the UIProcess when it is holding such files so that
both can continue to run for a period of time after the UIProcess transitions to the
background. In particular, the WebProcess notifies the UIProcess that it is holding- or
relinquished- a locked file when it begins and ends a sequence of SQLite transactions,
respectively.

UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::disconnect): Relinquish an existing background task assertion
when the WebProcess disconnects. Among other situations, the WebProcess may disconnect as
a result of being suspended holding locked files even when the UIProcess requested a
background task assertion (i.e. it may have exceeded its background time limit).
(WebKit::WebProcessProxy::setIsHoldingLockedFiles): Added. Either acquires a new background
task assertion or relinquishes an existing one.

UIProcess/WebProcessProxy.h:
UIProcess/WebProcessProxy.messages.in: Added message SetIsHoldingLockedFiles(bool). The WebProcess

dispatches this message to inform the UIProcess that it is holding- or relinquished- a locked file.

WebKit2.xcodeproj/project.pbxproj: Added files WebSQLiteDatabaseTracker.{cpp, h}.
WebProcess/WebCoreSupport/WebSQLiteDatabaseTracker.cpp: Added.

(WebKit::WebSQLiteDatabaseTracker::supplementName): Added.
(WebKit::WebSQLiteDatabaseTracker::WebSQLiteDatabaseTracker): Added.
(WebKit::WebSQLiteDatabaseTracker::initialize): Register to receive SQLiteDatabaseTrackerClient callbacks.
(WebKit::WebSQLiteDatabaseTracker::willBeginFirstTransaction): Inform the HysteresisActivity object on
the main thread that we began a transaction so that it calls WebSQLiteDatabaseTracker::started().
(WebKit::WebSQLiteDatabaseTracker::didFinishLastTransaction): Inform the HysteresisActivity object on
the main thread that we finished a transaction so that it may eventually call WebSQLiteDatabaseTracker::stopped().
(WebKit::WebSQLiteDatabaseTracker::started): Notify the UIProcess that the WebProcess is holding
a locked file.
(WebKit::WebSQLiteDatabaseTracker::stopped): Notify the UIProcess that the WebProcess has
relinquished the locked file.

WebProcess/WebCoreSupport/WebSQLiteDatabaseTracker.h: Added. We use a HysteresisActivity object

to coalesce SetIsHoldingLockedFiles(false) messages as an optimization to minimize the number of
messages exchanged between the UIProcess and WebProcess when a web page performs SQLite transactions
in batches.

WebProcess/WebProcess.cpp:

(WebKit::WebProcess::WebProcess): Instantiate the supplement WebSQLiteDatabaseTracker when building
for iOS.

8:03 AM WebKitGTK/2.6.x edited by Carlos Garcia Campos

(diff)

8:00 AM WebKitGTK/2.4.x edited by Carlos Garcia Campos

(diff)

8:00 AM Changeset in webkit [175697] by Chris Dumez

3 edits in trunk/Source/WebCore

Use lambda functions in DocumentOrderedMap
https://bugs.webkit.org/show_bug.cgi?id=138376

Reviewed by Darin Adler.

Use lambda functions in DocumentOrderedMap instead of separate named
functions.

No new tests, no behavior change.

dom/DocumentOrderedMap.cpp:

(WebCore::DocumentOrderedMap::get):
(WebCore::DocumentOrderedMap::getElementById):
(WebCore::DocumentOrderedMap::getElementByName):
(WebCore::DocumentOrderedMap::getElementByMapName):
(WebCore::DocumentOrderedMap::getElementByLowercasedMapName):
(WebCore::DocumentOrderedMap::getElementByLowercasedUsemap):
(WebCore::DocumentOrderedMap::getElementByLabelForAttribute):
(WebCore::DocumentOrderedMap::getElementByWindowNamedItem):
(WebCore::DocumentOrderedMap::getElementByDocumentNamedItem):
(WebCore::DocumentOrderedMap::getAllElementsById):
(WebCore::keyMatchesId): Deleted.
(WebCore::keyMatchesName): Deleted.
(WebCore::keyMatchesMapName): Deleted.
(WebCore::keyMatchesLowercasedMapName): Deleted.
(WebCore::keyMatchesLowercasedUsemap): Deleted.
(WebCore::keyMatchesLabelForAttribute): Deleted.
(WebCore::keyMatchesWindowNamedItem): Deleted.
(WebCore::keyMatchesDocumentNamedItem): Deleted.

dom/DocumentOrderedMap.h:

7:46 AM Changeset in webkit [175696] by berto@igalia.com

2 edits in trunk/Source/WebKit2

[GTK] [Stable] webkitgtk 2.6.1 fails to load flashplugin
https://bugs.webkit.org/show_bug.cgi?id=137849

Reviewed by Carlos Garcia Campos.

NPPVpluginNeedsXEmbed is a boolean value, so it should normally
use an NPBool (1 byte). However some plugins (the Flash player in
particular) are using an int instead, so we have to do it as well
else we'll end up corrupting the stack.

WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:

(WebKit::NetscapePlugin::platformPostInitialize):

7:22 AM Changeset in webkit [175695] by Bem Jones-Bey

2 edits in trunk/LayoutTests

Update testharness.js to the latest version
https://bugs.webkit.org/show_bug.cgi?id=138446

Reviewed by Ryosuke Niwa.

The only change I've made from upstream is to set output to false by
default.

resources/testharness.js:

7:08 AM Changeset in webkit [175694] by Carlos Garcia Campos

19 edits
3 adds in trunk

[GTK] Add context menu API to Web Process Extensions
https://bugs.webkit.org/show_bug.cgi?id=138311

Reviewed by Gustavo Noronha Silva.

Source/WebKit2:

Add WebKitWebPage::context-menu signal, similar to the
WebKitWebView one, but that receives a WebKitWebHitTestResult, a
class that extends WebKitTestResult to provide the WebKitDOMNode
from the Web Process Extensions API. This makes WebKitContextMenu,
WebKitContextMenuItem and WebKitTestResult classes shared between
UI and Web Extensions APIs. In addition to be able to customize
the context menu, it also provides API to set user data, as a
GVariant, in the Web Process that is sent to the UI Process.

PlatformGTK.cmake: Add new files.
UIProcess/API/gtk/WebKitContextMenu.cpp:

(webkit_context_menu_set_user_data): Add user data to the context
menu as a GVariant.
(webkit_context_menu_get_user_data): Get the user data previously
set with webkit_context_menu_set_user_data() either from the Web
or UI processes.

UIProcess/API/gtk/WebKitContextMenu.h:
UIProcess/API/gtk/WebKitContextMenuActions.h:
UIProcess/API/gtk/WebKitContextMenuClient.cpp:

(getContextMenuFromProposedMenu): Convert the received user data
into a GVariant and pass it to webkitWebViewPopulateContextMenu().

UIProcess/API/gtk/WebKitContextMenuItem.h:
UIProcess/API/gtk/WebKitForwardDeclarations.h:
UIProcess/API/gtk/WebKitHitTestResult.h:
UIProcess/API/gtk/WebKitWebView.cpp:

(webkitWebViewPopulateContextMenu): Set the user data received
from the Web Process to the WebKitContextMenu before emitting
WebKitWebView::context-menu.

UIProcess/API/gtk/WebKitWebViewPrivate.h:
UIProcess/API/gtk/docs/webkit2gtk-docs.sgml: Add new section for WebKitWebHitTestResult.
UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new symbols.
UIProcess/API/gtk/docs/webkit2gtk.types: Add webkit_web_hit_test_result_get_type.
WebProcess/InjectedBundle/API/gtk/WebKitWebHitTestResult.cpp: Added.

(webkitWebHitTestResultGetProperty): Add getter for node property.
(webkitWebHitTestResultSetProperty): Add setter for node property.
(webkit_web_hit_test_result_class_init): Add node property.
(webkitWebHitTestResultCreate): Create a new
WebKitWebHitTestResult for the given InjectedBundleHitTestResult.
(webkit_web_hit_test_result_get_node): Return the WebKitDOMNode.

WebProcess/InjectedBundle/API/gtk/WebKitWebHitTestResult.h: Added.
WebProcess/InjectedBundle/API/gtk/WebKitWebHitTestResultPrivate.h: Added.
WebProcess/InjectedBundle/API/gtk/WebKitWebPage.cpp:

(getContextMenuFromDefaultMenu): Build a WebKitContextMenu and
WebKitWebHitTestResult and emit WebKitWebPage::context-menu signal.
(webkit_web_page_class_init): Add WebKitWebPage::context-menu signal.
(webkitWebPageCreate): Add implementation for getContextMenuFromDefaultMenu.

WebProcess/InjectedBundle/API/gtk/webkit-web-extension.h:

Tools:

Add tests cases for WebKitWebPage::context-menu signal.

TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:

(testContextMenuWebExtensionMenu):
(testContextMenuWebExtensionNode):
(beforeAll):

TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:

(serializeContextMenu):
(serializeNode):
(contextMenuCallback):
(pageCreatedCallback):

2:31 AM Changeset in webkit [175693] by commit-queue@webkit.org

2 edits in trunk/Tools

Unreviewed, rolling out r175690.
https://bugs.webkit.org/show_bug.cgi?id=138460

We are not ready to run layout tests using the network process
yet (Requested by KaL on #webkit).

Reverted changeset:

"[GTK] Run layout tests using the network process"
https://bugs.webkit.org/show_bug.cgi?id=138428
http://trac.webkit.org/changeset/175690

2:08 AM Changeset in webkit [175692] by ryuan.choi@gmail.com

5 edits in trunk/Source/WebKit2

[EFL] Remove m_scrollPosition from CoordinatedGraphicsScene
https://bugs.webkit.org/show_bug.cgi?id=138419

Reviewed by Gyuyoung Kim.

m_scrollPosition of CoordinatedGraphicsScene is only to adjust the position
of fixed element. But this adjustment is only called by paintToCurrentGLContext()
and WebView can pass same information to the parameter of that method.

UIProcess/CoordinatedGraphics/CoordinatedGraphicsScene.cpp:

(WebCore::CoordinatedGraphicsScene::paintToCurrentGLContext):
(WebCore::CoordinatedGraphicsScene::adjustPositionForFixedLayers):
(WebCore::CoordinatedGraphicsScene::setScrollPosition): Deleted.

UIProcess/CoordinatedGraphics/CoordinatedGraphicsScene.h:
UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.cpp:

(WebKit::CoordinatedLayerTreeHostProxy::setVisibleContentsRect):

UIProcess/CoordinatedGraphics/WebView.cpp:

(WebKit::WebView::paintToCurrentGLContext):

12:51 AM WebKitGTK/2.4.x edited by berto@igalia.com

(diff)

12:50 AM Changeset in webkit [175691] by gyuyoung.kim@samsung.com

3 edits in trunk/Source/JavaScriptCore

Use std::unique_ptr in CodeBlock class
https://bugs.webkit.org/show_bug.cgi?id=138395

Reviewed by Darin Adler.

bytecode/CodeBlock.h: Use std::unique_ptr.

(JSC::CodeBlock::setJITCodeMap):

jit/CompactJITCodeMap.h: Use std::unique_ptr instead of OwnPtr|PassOwnPtr.

(JSC::CompactJITCodeMap::CompactJITCodeMap):
(JSC::CompactJITCodeMap::Encoder::finish): Use std::unique_ptr instead of PassOwnPtr.

12:47 AM Changeset in webkit [175690] by Carlos Garcia Campos

2 edits in trunk/Tools

[GTK] Run layout tests using the network process
https://bugs.webkit.org/show_bug.cgi?id=138428

Reviewed by Martin Robinson.

Shared secondary process is the default in the GTK+ port, but we
should run the tests using the network process to ensure
everything works with the network process. In the future, the
shared secondary process model might be a special case of multiple
processes with 1 as maximum number of processes, but always using
the network process.

WebKitTestRunner/TestController.cpp:

(WTR::TestController::initialize):

12:07 AM Changeset in webkit [175689] by Chris Dumez

2 edits in trunk/LayoutTests

Unreviewed, fix nits after r175688.

Just a couple of non-functional fixes to the layout test.

fast/dom/Text/splitText.html:

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed