Timeline



Nov 19, 2014:

11:42 PM Changeset in webkit [176383] by Chris Dumez
  • 4 edits in trunk/Source/WebCore

Move 'clip' CSS property to the new StyleBuilder
​https://bugs.webkit.org/show_bug.cgi?id=138909

Reviewed by Andreas Kling.

Move 'clip' CSS property from DeprecatedStyleBuilder to the new
StyleBuilder by using custom code.

No new tests, no behavior change.

  • css/CSSPropertyNames.in:
  • css/DeprecatedStyleBuilder.cpp:

(WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder):
(WebCore::ApplyPropertyClip::convertToLength): Deleted.
(WebCore::ApplyPropertyClip::applyInheritValue): Deleted.
(WebCore::ApplyPropertyClip::applyInitialValue): Deleted.
(WebCore::ApplyPropertyClip::applyValue): Deleted.
(WebCore::ApplyPropertyClip::createHandler): Deleted.

  • css/StyleBuilderCustom.h:

(WebCore::StyleBuilderFunctions::applyInitialClip):
(WebCore::StyleBuilderFunctions::applyInheritClip):
(WebCore::StyleBuilderFunctions::applyValueClip):

9:45 PM Changeset in webkit [176382] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit2

Don't track sub-resources that are started after main frame progress has completed.
​https://bugs.webkit.org/show_bug.cgi?id=138582

Patch by Yongjun Zhang <​yongjun_zhang@apple.com> on 2014-11-19
Reviewed by Sam Weinig.

After main frame progress has finished, starting loading a sub-resource shouldn't affect
UI process's view of page loading status (i.e., the page has already completed loading
and the progress shouldn't change). To achive that, don't track the subresources that
are started after the main frame has finished, except for those triggered by user interaction.

  • WebProcess/WebCoreSupport/WebProgressTrackerClient.cpp: Notify WebPage that the main frame progress

has started or finished.

(WebKit::WebProgressTrackerClient::progressStarted):
(WebKit::WebProgressTrackerClient::progressFinished):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):
(WebKit::WebPage::addResourceRequest): Don't track the resource request if it is initiated after

the main frame is loaded and it is not triggered by user interaction.

(WebKit::WebPage::removeResourceRequest):

  • WebProcess/WebPage/WebPage.h: Rename m_networkResourceRequestIdentifiers to m_trackedNetworkResourceRequestIdentifiers.

(WebKit::WebPage::setMainFrameProgressCompleted):

9:35 PM Changeset in webkit [176381] by ryuan.choi@navercorp.com
  • 3 edits in trunk/Source/WebCore

Remove dead code from TiledBackingStore
​https://bugs.webkit.org/show_bug.cgi?id=138864

Reviewed by Andreas Kling.

Since r168151, paint() method, m_commitTileUpdatesOnIdleEventLoop and related code are not used.

No new tests, no behavior change.

  • platform/graphics/TiledBackingStore.cpp:

(WebCore::TiledBackingStore::TiledBackingStore):
(WebCore::TiledBackingStore::setTileSize):
(WebCore::TiledBackingStore::invalidate):
(WebCore::TiledBackingStore::createTiles):
(WebCore::TiledBackingStore::paint): Deleted.
(WebCore::TiledBackingStore::startTileBufferUpdateTimer): Deleted.
(WebCore::TiledBackingStore::tileBufferUpdateTimerFired): Deleted.
(WebCore::TiledBackingStore::startBackingStoreUpdateTimer): Deleted.
(WebCore::TiledBackingStore::backingStoreUpdateTimerFired): Deleted.

  • platform/graphics/TiledBackingStore.h:

(WebCore::TiledBackingStore::setCommitTileUpdatesOnIdleEventLoop): Deleted.

8:40 PM Changeset in webkit [176380] by dburkart@apple.com
  • 2 edits in branches/safari-600.3-branch/Source/WebKit2

Merge r176374. rdar://problem/18840128

8:37 PM Changeset in webkit [176379] by dburkart@apple.com
  • 2 edits in branches/safari-600.3-branch/Source/WebKit2

Merge r176374. rdar://problem/18840128

8:28 PM Changeset in webkit [176378] by rniwa@webkit.org
  • 2 edits in trunk/Websites/perf.webkit.org

Fix typos in r176203.

  • public/v2/app.js:

(App.ChartsController.actions.addPaneByMetricAndPlatform):
(App.AnalysisTaskRoute):

8:27 PM Changeset in webkit [176377] by dburkart@apple.com
  • 24 edits
    1 copy in branches/safari-600.3-branch/Source

Merge r176363. rdar://problem/18840128

6:19 PM Changeset in webkit [176376] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebInspectorUI

Web Inspector: LayoutTests/inspector should not have localStorage side effects
​https://bugs.webkit.org/show_bug.cgi?id=138895

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-11-19
Reviewed by Brian Burg.

When running inspector tests, do not restore/save WebInspector.Settings
to localStorage, as that will cause side effects. Instead each Setting
will be initialized with its default value and can be modified during
the run of the test.

  • UserInterface/Base/Test.js:

(WebInspector.loaded):
Name the setting to match the normal setting name now that persistence
is not an issue.

  • UserInterface/Models/Setting.js:

(WebInspector.Setting.prototype.get value):
(WebInspector.Setting.prototype.set value):
Do not restore/save when in tests.

6:03 PM Changeset in webkit [176375] by gyuyoung.kim@samsung.com
  • 3 edits in trunk/Source/WebKit2

[EFL] Fix build failure since r176363.
​https://bugs.webkit.org/show_bug.cgi?id=138903

Patch by Sun-woo Nam <​sunny.nam@samsung.com> on 2014-11-19
Reviewed by Gyuyoung Kim.

The parameter for animation on setTextIndicator() was removed on 'PageClient' class.

  • UIProcess/CoordinatedGraphics/WebView.cpp:

(WebKit::WebView::setTextIndicator):

  • UIProcess/CoordinatedGraphics/WebView.h:
5:55 PM Changeset in webkit [176374] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit2

Try to fix the iOS build

  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::performDictionaryLookupForSelection):
(WebKit::WebPage::performDictionaryLookupForRange):

5:36 PM Changeset in webkit [176373] by akling@apple.com
  • 9 edits in trunk/Source/WebCore

Remove "document has no ::before and/or ::after rules" optimization.
<​https://webkit.org/b/138897>

Reviewed by Antti Koivisto.

This optimization has been dead for a long time, since the default UA
style contains both ::before and ::after rules.

  • css/RuleFeature.cpp:

(WebCore::recursivelyCollectFeaturesFromSelector):
(WebCore::RuleFeatureSet::add):
(WebCore::RuleFeatureSet::clear):

  • css/RuleFeature.h:

(WebCore::RuleFeatureSet::RuleFeatureSet):

  • css/StyleResolver.h:

(WebCore::StyleResolver::usesBeforeAfterRules): Deleted.

  • dom/DocumentStyleSheetCollection.cpp:

(WebCore::DocumentStyleSheetCollection::DocumentStyleSheetCollection):
(WebCore::DocumentStyleSheetCollection::combineCSSFeatureFlags):
(WebCore::DocumentStyleSheetCollection::resetCSSFeatureFlags):

  • dom/DocumentStyleSheetCollection.h:

(WebCore::DocumentStyleSheetCollection::usesBeforeAfterRules): Deleted.
(WebCore::DocumentStyleSheetCollection::setUsesBeforeAfterRulesOverride): Deleted.

  • html/HTMLQuoteElement.cpp:

(WebCore::HTMLQuoteElement::insertedInto): Deleted.

  • html/HTMLQuoteElement.h:
  • style/StyleResolveTree.cpp:

(WebCore::Style::needsPseudoElement):

5:35 PM Changeset in webkit [176372] by mmaxfield@apple.com
  • 4 edits
    3 adds in trunk

[OS X] Upright vertical text is completely broken for multi-code-unit codepoints
​https://bugs.webkit.org/show_bug.cgi?id=138891

Reviewed by Dan Bernstein.

Source/WebCore:

We were assuming that we can use the string index (in UTF-16) as the glyph
index. This falls down when a single codepoint (and glyph) contians
multiple code units.

Test: platform/mac/fast/text/multiple-codeunit-vertical-upright.html

  • platform/graphics/GlyphPage.h:
  • platform/graphics/mac/GlyphPageTreeNodeMac.cpp:

(WebCore::GlyphPage::fill):

LayoutTests:

Make sure a single upright vertical multi-code-unit codepoint is rendered the same as
the same codepoint rendered horizontally.

  • platform/mac/fast/text/multiple-codeunit-vertical-upright-expected.html: Added.
  • platform/mac/fast/text/multiple-codeunit-vertical-upright.html: Added.
  • platform/mac/fast/text/resources/multiple-codeunit-vertical-upright.otf: Added.
5:23 PM Changeset in webkit [176371] by dbates@webkit.org
  • 2 edits in trunk/Source/WebCore

Attempt to fix the Apple Internal Mavericks build after <​https://trac.webkit.org/changeset/176347>
(​https://bugs.webkit.org/show_bug.cgi?id=136863)

Define enumerator NSHTTPCookieAcceptPolicyExclusivelyFromMainDocumentDomain when building without
the Apple Internal SDK or with the Apple Internal SDK on OS X Mavericks or earlier.

  • platform/spi/cf/CFNetworkSPI.h:
5:16 PM Changeset in webkit [176370] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix the 32-bit build

  • UIProcess/mac/TextIndicatorWindow.mm:

(WebKit::TextIndicatorWindow::setTextIndicator):

5:02 PM Changeset in webkit [176369] by weinig@apple.com
  • 7 edits
    1 copy
    1 add in trunk

Move the 'quotes' CSS property to the new StyleBuilder
​https://bugs.webkit.org/show_bug.cgi?id=138788

Reviewed by Chris Dumez.

Source/WebCore:

Test: fast/css/content/content-quotes-07.html

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):
Fix the parser to only accept none as a valid primitive identifier. Tested in
the newly added content-quotes-07.html.

  • css/CSSPropertyNames.in:
  • css/StyleBuilderConverter.h:

(WebCore::StyleBuilderConverter::convertQuotes):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::applyProperty):
Move "quotes" to the new style builder.

  • rendering/style/RenderStyle.h:

Add an initialQuotes() function for use in the auto-generated style builder.

LayoutTests:

Add a test for the behavior of non-valid primitive identifiers being
used with the quotes property.

  • fast/css/content/content-quotes-07-expected.txt: Added.
  • fast/css/content/content-quotes-07.html: Added.
4:59 PM Changeset in webkit [176368] by dino@apple.com
  • 4 edits
    4 adds in trunk

Handle unprefixed @keyframes rule
​https://bugs.webkit.org/show_bug.cgi?id=138899
<rdar://problem/18943117>

Reviewed by Simon Fraser.

Source/WebCore:

Support the parsing of unprefixed @keyframes. In
CSSParser, assign the same token identifier to
the prefixed and unprefixed forms. This will
keep compatibility with older content. If a page
has both forms, then whatever comes last will
win (as it does if you had duplicate names of the same
form).

Tests: animations/unprefixed-keyframes-rule.html

animations/unprefixed-keyframes.html

  • css/CSSGrammar.y.in: Rename the WEBKIT_KEYFRAME_RULE_SYM symbol to

be KEYFRAME_RULE_SYM. Same with KEYFRAMES_SYM.

  • css/CSSParser.cpp:

(WebCore::CSSParser::detectAtToken): Look for the @keyframes style
strings and assign the new token values.

LayoutTests:

Tests for @keyframes, both the OM side and the parsing.

  • animations/unprefixed-keyframes-expected.txt: Added.
  • animations/unprefixed-keyframes-rule-expected.txt: Added.
  • animations/unprefixed-keyframes-rule.html: Added.
  • animations/unprefixed-keyframes.html: Added.
4:34 PM Changeset in webkit [176367] by dburkart@apple.com
  • 4 edits in branches/safari-600.3-branch/Source

Merge r176356. rdar://problem/18996776

4:28 PM Changeset in webkit [176366] by dburkart@apple.com
  • 4 edits in branches/safari-600.3-branch/Source

Merge r176351. rdar://problem/18971616

4:17 PM Changeset in webkit [176365] by akling@apple.com
  • 9 edits in trunk/Source/WebCore

Move pseudo-style code from RenderObject to RenderElement.
<​https://webkit.org/b/138880>

Reviewed by Antti Koivisto.

Migrate get*PseudoStyle() to RenderElement, and the selection color
functions along with them. This gets rid of a DOM ancestor walk in
pseudo style lookup.

Narrow down some argument types to keep things building.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::logicalLeftSelectionGap):
(WebCore::RenderBlock::logicalRightSelectionGap):
(WebCore::styleForFirstLetter):
(WebCore::RenderBlock::updateFirstLetterStyle):
(WebCore::RenderBlock::createFirstLetterRenderer):

  • rendering/RenderBlock.h:
  • rendering/RenderElement.cpp:

(WebCore::RenderElement::getCachedPseudoStyle):
(WebCore::RenderElement::getUncachedPseudoStyle):
(WebCore::RenderElement::selectionColor):
(WebCore::RenderElement::selectionPseudoStyle):
(WebCore::RenderElement::selectionForegroundColor):
(WebCore::RenderElement::selectionEmphasisMarkColor):
(WebCore::RenderElement::selectionBackgroundColor):

  • rendering/RenderElement.h:
  • rendering/RenderObject.cpp:

(WebCore::RenderObject::selectionBackgroundColor): Deleted.
(WebCore::RenderObject::selectionColor): Deleted.
(WebCore::RenderObject::selectionPseudoStyle): Deleted.
(WebCore::RenderObject::selectionForegroundColor): Deleted.
(WebCore::RenderObject::selectionEmphasisMarkColor): Deleted.
(WebCore::RenderObject::getCachedPseudoStyle): Deleted.
(WebCore::RenderObject::getUncachedPseudoStyle): Deleted.

  • rendering/RenderObject.h:
  • rendering/RenderText.h:

(WebCore::RenderText::getCachedPseudoStyle):
(WebCore::RenderText::selectionBackgroundColor):
(WebCore::RenderText::selectionForegroundColor):
(WebCore::RenderText::selectionEmphasisMarkColor):

  • rendering/svg/SVGInlineTextBox.cpp:

(WebCore::SVGInlineTextBox::paintSelectionBackground):
(WebCore::SVGInlineTextBox::paint):

4:14 PM Changeset in webkit [176364] by bshafiei@apple.com
  • 9 edits in tags/Safari-601.1.10/Source/WebKit2

Merged r176337. rdar://problem/18964359

4:10 PM Changeset in webkit [176363] by timothy_horton@apple.com
  • 23 edits in trunk/Source

Add an optional entry transition (from selection highlight) to TextIndicator
​https://bugs.webkit.org/show_bug.cgi?id=138856
<rdar://problem/18840128>

Reviewed by Anders Carlsson.

  • Shared/TextIndicator.cpp:

(WebKit::outsetIndicatorRectIncludingShadow):
(WebKit::TextIndicator::createWithRange):
(WebKit::snapshotSelectionWithHighlight):
(WebKit::TextIndicator::createWithSelectionInFrame):
(WebKit::TextIndicator::frameRect):
(WebKit::TextIndicator::Data::encode):
(WebKit::TextIndicator::Data::decode):
Remove TextIndicator::draw and related functions; drawing is handled entirely
by the TextIndicatorWindow now, and TextIndicator just stores the required data.

Unify outsetIndicatorRectIncludingShadow.

Add an argument to createWithRange/createWithSelectionInFrame to indicate
if the TextIndicator should transition from the selection highlight to
the yellow bubble.

If we're doing the transition, paint the selection into a second bitmap,
without forcing the text to black and without hiding the blue highlight.

Encode/decode the second bitmap.

  • Shared/TextIndicator.h:
  • UIProcess/mac/TextIndicatorWindow.h:
  • UIProcess/mac/TextIndicatorWindow.mm:

(-[WKTextIndicatorView initWithFrame:textIndicator:margin:transitionFromSelectionColor:]):
(-[WKTextIndicatorView presentWithCompletionHandler:]):
(-[WKTextIndicatorView hideWithCompletionHandler:]):
(-[WKTextIndicatorView isFlipped]):
(WebKit::TextIndicatorWindow::TextIndicatorWindow):
(WebKit::TextIndicatorWindow::setTextIndicator):
(WebKit::TextIndicatorWindow::closeWindow):
(WebKit::TextIndicatorWindow::startFadeOutTimerFired):
Re-implement the bounce animation using CoreAnimation instead of
the WKSI-based WKWindowBounceAnimation*.

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::performDictionaryLookupForSelection):
(WebKit::WebPage::performDictionaryLookupOfCurrentSelection):
(WebKit::WebPage::performDictionaryLookupForRange):
(WebKit::WebPage::performActionMenuHitTestAtLocation):

  • WebProcess/WebCoreSupport/mac/WebContextMenuClientMac.mm:

Use the aforementioned transition animation for performDictionaryLookupOfCurrentSelection,
the context menu lookup item, and for Data Detectors.

  • WebCore.exp.in:

Add an export.

  • platform/spi/cocoa/QuartzCoreSPI.h:

Add some SPI.

4:02 PM Changeset in webkit [176362] by andersca@apple.com
  • 5 edits
    1 add in trunk/Source/WebKit2

Add a version of API::Data::createWithoutCopying that takes an NSData
​https://bugs.webkit.org/show_bug.cgi?id=138893

Reviewed by Dan Bernstein.

  • Shared/APIData.h:
  • Shared/Cocoa/APIDataCocoa.mm: Added.

(API::Data::createWithoutCopying):

  • UIProcess/API/Cocoa/WKBrowsingContextController.mm:

(-[WKBrowsingContextController loadData:MIMEType:textEncodingName:baseURL:userData:]):
(releaseNSData): Deleted.

  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm:

(-[WKWebProcessPlugInBrowserContextController _setFormDelegate:]):

3:58 PM Changeset in webkit [176361] by dburkart@apple.com
  • 2 edits in trunk/Tools

Work around the fact that different masters may have different names for their codebases.
​https://bugs.webkit.org/show_bug.cgi?id=138878

Reviewed by Mark Rowe.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:

(parseRevisionProperty): Changed.
Take a "fallback key" in addition to the primary key, so we can deal with inconsistencies in
opensource / internal codebase naming convention.

3:55 PM Changeset in webkit [176360] by bshafiei@apple.com
  • 5 edits in branches/safari-600.2-branch/Source

Versioning.

3:53 PM Changeset in webkit [176359] by Chris Dumez
  • 4 edits in trunk/Source/WebCore

Move 'outline-style' CSS property to the new StyleBuilder
​https://bugs.webkit.org/show_bug.cgi?id=138882

Reviewed by Sam Weinig.

Move 'outline-style' CSS property from DeprecatedStyleBuilder to the
new StyleBuilder by using custom code.

No new tests, no behavior change.

  • css/CSSPropertyNames.in:
  • css/DeprecatedStyleBuilder.cpp:

(WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder):
(WebCore::ApplyPropertyDefault::setValue): Deleted.
(WebCore::ApplyPropertyDefault::applyValue): Deleted.
(WebCore::ApplyPropertyDefault::createHandler): Deleted.
(WebCore::ApplyPropertyOutlineStyle::applyInheritValue): Deleted.
(WebCore::ApplyPropertyOutlineStyle::applyInitialValue): Deleted.
(WebCore::ApplyPropertyOutlineStyle::applyValue): Deleted.
(WebCore::ApplyPropertyOutlineStyle::createHandler): Deleted.

  • css/StyleBuilderCustom.h:

(WebCore::StyleBuilderFunctions::applyInheritOutlineStyle):
(WebCore::StyleBuilderFunctions::applyInitialOutlineStyle):
(WebCore::StyleBuilderFunctions::applyValueOutlineStyle):

3:49 PM Changeset in webkit [176358] by Joseph Pecoraro
  • 14 edits
    1 move
    2 adds in trunk

Web Inspector: JSContext inspection Resource search does not work
​https://bugs.webkit.org/show_bug.cgi?id=131252

Reviewed by Timothy Hatcher.

Source/JavaScriptCore:

  • inspector/agents/InspectorDebuggerAgent.cpp:

(Inspector::InspectorDebuggerAgent::searchInContent):

  • inspector/protocol/Debugger.json:

Do some cleanup of the description and implementation of content searching.

Source/WebCore:

Test: inspector/debugger/search-scripts.html

  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::searchInResources):
A little cleanup.

Source/WebInspectorUI:

  • UserInterface/Views/ResourceSidebarPanel.js:

(WebInspector.ResourceSidebarPanel.prototype.performSearch.resourceCallback):
(WebInspector.ResourceSidebarPanel.prototype.performSearch.resourcesCallback):
Cleanup by reordering things a bit.

(WebInspector.ResourceSidebarPanel.prototype.performSearch.searchScripts.scriptCallback):
(WebInspector.ResourceSidebarPanel.prototype.performSearch.searchScripts):
(WebInspector.ResourceSidebarPanel.prototype.performSearch):
Search non-resource scripts individually.

(WebInspector.ResourceSidebarPanel.prototype._searchTreeElementForScript):
Lazily create a ScriptTreeElement for the search tree outline as needed.

(WebInspector.ResourceSidebarPanel.prototype._scriptsToSearch):
When searching scripts, just perform a shallow walk of the tree outline to find
Script resources that are not also Resources. Scripts are always guarenteed to
be in a folder when inspecting a web resource. For JSContext inspection, scripts
are promoted to the top level.

  • UserInterface/Main.html:
  • UserInterface/Models/SourceCodeSearchMatchObject.js: Renamed from Source/WebInspectorUI/UserInterface/Models/ResourceSearchMatchObject.js.

(WebInspector.SourceCodeSearchMatchObject):

  • UserInterface/Views/SearchIcons.css:

(.source-code-match-icon .icon):
(.resource-match-icon .icon): Deleted.

  • UserInterface/Views/SearchResultTreeElement.js:

(WebInspector.SearchResultTreeElement):
Rename ResourceSearchMatchObject to SourceCodeSearchMatchObject.

LayoutTests:

  • inspector/debugger/search-scripts-expected.txt: Added.
  • inspector/debugger/search-scripts.html: Added.

Tests for Debugger.searchInContent.

3:49 PM Changeset in webkit [176357] by Joseph Pecoraro
  • 19 edits
    5 adds in trunk

Web Inspector: Provide $exception in the console for the thrown exception value
​https://bugs.webkit.org/show_bug.cgi?id=138726

Reviewed by Timothy Hatcher.

Source/JavaScriptCore:

  • debugger/DebuggerScope.cpp:

(JSC::DebuggerScope::caughtValue):

  • debugger/DebuggerScope.h:

Access the caught value if this scope is a catch scope.

  • runtime/JSNameScope.h:

(JSC::JSNameScope::isFunctionNameScope):
(JSC::JSNameScope::isCatchScope):
(JSC::JSNameScope::value):
Provide an accessor for the single value in the JSNameScope (with / catch block).

  • inspector/InjectedScriptSource.js:

Save the exception value and expose it via $exception. Since the command line api
is recreated on each evaluation, $exception is essentially readonly.

  • inspector/ScriptDebugServer.h:
  • inspector/ScriptDebugServer.cpp:

(Inspector::ScriptDebugServer::dispatchDidPause):
(Inspector::ScriptDebugServer::exceptionOrCaughtValue):
When pausing, get the exception or caught value. The exception will be provided
if we are breaking on an explicit exception. When inside of a catch block, we
can get the caught value by walking up the scope chain.

  • inspector/agents/InspectorDebuggerAgent.h:
  • inspector/agents/InspectorDebuggerAgent.cpp:

(Inspector::InspectorDebuggerAgent::InspectorDebuggerAgent):
(Inspector::InspectorDebuggerAgent::resume):
(Inspector::InspectorDebuggerAgent::stepOver):
(Inspector::InspectorDebuggerAgent::stepInto):
(Inspector::InspectorDebuggerAgent::stepOut):
Clearing state can be done in didContinue.

(Inspector::InspectorDebuggerAgent::didPause):
Set the exception value explicitly in the injected script when we have it.

(Inspector::InspectorDebuggerAgent::didContinue):
Clear state saved when we had paused, including clearly an exception value if needed.

(Inspector::InspectorDebuggerAgent::clearDebuggerBreakpointState):
(Inspector::InspectorDebuggerAgent::clearExceptionValue):
Call into the injected script only when needed.

  • inspector/InjectedScript.cpp:

(Inspector::InjectedScript::setExceptionValue):
(Inspector::InjectedScript::clearExceptionValue):

  • inspector/InjectedScript.h:
  • inspector/InjectedScriptManager.cpp:

(Inspector::InjectedScriptManager::clearExceptionValue):

  • inspector/InjectedScriptManager.h:

Clear on all injected scripts.

Source/WebCore:

Tests: inspector/debugger/command-line-api-exception-nested-catch.html

inspector/debugger/command-line-api-exception.html

  • inspector/CommandLineAPIModuleSource.js:

Expose $exception in the more complete command line API.

Source/WebInspectorUI:

  • UserInterface/Base/Test.js:

(WebInspector.loaded):
In order to use RuntimeManager to execute in the global context or on the
active debugger call frame, we need to expose the quickConsole controller.

  • UserInterface/Controllers/JavaScriptRuntimeCompletionProvider.js:

Expose $exception to completion when we paused because of an exception.

LayoutTests:

Provide some tests to ensure $exception is the value we expect at different times,
such as on the exception line, when there is no exception, or when stepping through
catch blocks (it should always be the most recent caught exception).

  • inspector/debugger/command-line-api-exception-expected.txt: Added.
  • inspector/debugger/command-line-api-exception-nested-catch-expected.txt: Added.
  • inspector/debugger/command-line-api-exception-nested-catch.html: Added.
  • inspector/debugger/command-line-api-exception.html: Added.
  • inspector/debugger/resources/exceptions.js: Added.

(triggerUncaughtTypeException):
(triggerUncaughtReferenceException):
(triggerUncaughtSyntaxException):
(triggerUncaughtDOMException):
(throwString):
(throwNumber):
(throwNull):
(throwObject):
(throwNode):
(catcher):
(nestedCatchBlocks):

3:48 PM Changeset in webkit [176356] by Beth Dakin
  • 4 edits in trunk/Source

Invoking an action menu on a selection should result in the text menu
​https://bugs.webkit.org/show_bug.cgi?id=138892
-and corresponding-
rdar://problem/18996776

Reviewed by Tim Horton.

Source/WebKit/mac:

  • WebView/WebActionMenuController.mm:

(-[WebActionMenuController _defaultMenuItems]):

Source/WebKit2:

  • UIProcess/mac/WKActionMenuController.mm:

(-[WKActionMenuController _defaultMenuItems]):

3:43 PM Changeset in webkit [176355] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix iOS build.

  • UIProcess/API/Cocoa/WKWebViewConfiguration.mm:
3:40 PM Changeset in webkit [176354] by hyatt@apple.com
  • 5 edits
    9 adds in trunk

Images/replaced elements that are as tall as a page should be on their own page
​https://bugs.webkit.org/show_bug.cgi?id=138886 - <rdar://problem/18296371>

Reviewed by Dean Jackson.

Source/WebCore:

Added fast/multicol/tall-image-behavior.html (and RL/LR variants)

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::computeReplacedAndTextLineTopAndBottom):

  • rendering/InlineFlowBox.h:

Add a new method that computes the line top and line bottom ignoring all margins,
overflow and line-height. This allows us to see if a line that is taller than a page
can be made to fit if we ignored margins and unused descent.

  • rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::adjustLinePositionForPagination):
Call the new helper function, computeReplacedAndTextLineTopAndBottom and push
to a new page if we see that we can fit on a page by ourselves without blank space
included.

LayoutTests:

  • fast/multicol/tall-image-behavior-lr.html: Added.
  • fast/multicol/tall-image-behavior-rl.html: Added.
  • fast/multicol/tall-image-behavior.html: Added.
  • platform/mac/fast/multicol/tall-image-behavior-expected.png: Added.
  • platform/mac/fast/multicol/tall-image-behavior-expected.txt: Added.
  • platform/mac/fast/multicol/tall-image-behavior-lr-expected.png: Added.
  • platform/mac/fast/multicol/tall-image-behavior-lr-expected.txt: Added.
  • platform/mac/fast/multicol/tall-image-behavior-rl-expected.png: Added.
  • platform/mac/fast/multicol/tall-image-behavior-rl-expected.txt: Added.
3:36 PM Changeset in webkit [176353] by bshafiei@apple.com
  • 1 copy in tags/Safari-600.2.3

New tag.

3:03 PM Changeset in webkit [176352] by andersca@apple.com
  • 2 edits
    2 moves in trunk/Source/WebKit2

Rename two Cocoa-only .cpp files to .mm.

Rubber-stamped by Sam Weinig.

  • Shared/APIWebArchive.mm: Renamed from Source/WebKit2/Shared/APIWebArchive.cpp.
  • Shared/APIWebArchiveResource.mm: Renamed from Source/WebKit2/Shared/APIWebArchiveResource.cpp.
  • WebKit2.xcodeproj/project.pbxproj:
3:00 PM Changeset in webkit [176351] by Beth Dakin
  • 4 edits in trunk/Source

Data detected results with no menu items should not fall through to regular text
action menus
​https://bugs.webkit.org/show_bug.cgi?id=138887
-and corresponding-
rdar://problem/18971616

Reviewed by Tim Horton.

Source/WebKit/mac:

  • WebView/WebActionMenuController.mm:

(-[WebActionMenuController _defaultMenuItems]):

Source/WebKit2:

  • UIProcess/mac/WKActionMenuController.mm:

(-[WKActionMenuController _defaultMenuItems]):

2:58 PM Changeset in webkit [176350] by adachan@apple.com
  • 16 edits
    2 adds in trunk

Take Web Audio into account for the Page::isPlayingAudio() API.
​https://bugs.webkit.org/show_bug.cgi?id=137464

Reviewed by Jer Noble.

Source/WebCore:

Make AudioContext a subclass of AudioProducer. It figures out whether there's
audio playing by checking whether its AudioDestinationNode is playing (and not
silent). It calls Document::updateIsPlayingAudio() whenever its audio playing
state has changed.

Test: webaudio/web-audio-is-playing.html

  • Modules/webaudio/AudioContext.cpp:

(WebCore::AudioContext::lazyInitialize):
Add itself to the Document's list of AudioProducers if it's not an offline
audio context.
(WebCore::AudioContext::uninitialize):
Remove itself from the Document's list of AudioProducers if it's not an offline
audio context.
(WebCore::AudioContext::stop):
Tell the document to update its audio playing state.
(WebCore::AudioContext::isPlayingAudio):
Return true if the audio context hasn't been stopped and its destination node is
playing audio.
(WebCore::AudioContext::pageMutedStateDidChange):
Add a FIXME for now.
(WebCore::AudioContext::isPlayingAudioDidChange):
Call Document::updateIsPlayingAudio().

  • Modules/webaudio/AudioContext.h:
  • Modules/webaudio/AudioDestinationNode.cpp:

(WebCore::AudioDestinationNode::AudioDestinationNode):
Initialize m_isSilent and m_isEffectivelyPlayingAudio.
(WebCore::AudioDestinationNode::render):
Call setIsSilent() with the appropriate value after rendering.
(WebCore::AudioDestinationNode::isPlayingDidChange):
Call updateIsEffectivelyPlayingAudio().
(WebCore::AudioDestinationNode::setIsSilent):
If m_isSilent has changed, call updateIsEffectivelyPlayingAudio().
(WebCore::AudioDestinationNode::updateIsEffectivelyPlayingAudio):
If m_isEffectivelyPlayingAudio has changed, call AudioContext::isPlayingAudioDidChange().

  • Modules/webaudio/AudioDestinationNode.h:

(WebCore::AudioDestinationNode::isPlaying):
(WebCore::AudioDestinationNode::isPlayingAudio):

  • Modules/webaudio/DefaultAudioDestinationNode.cpp:

(WebCore::DefaultAudioDestinationNode::isPlaying):
Return whether the AudioDestination is playing.

  • Modules/webaudio/DefaultAudioDestinationNode.h:
  • platform/audio/AudioIOCallback.h:
  • platform/audio/ios/AudioDestinationIOS.cpp:

(WebCore::AudioDestinationIOS::start):
Call setIsPlaying() instead.
(WebCore::AudioDestinationIOS::stop):
Ditto.
(WebCore::AudioDestinationIOS::setIsPlaying):
If m_isPlaying has changed, call AudioIOCallback::isPlayingDidChange().

  • platform/audio/ios/AudioDestinationIOS.h:
  • platform/audio/mac/AudioDestinationMac.cpp:

(WebCore::AudioDestinationMac::start):
Call setIsPlaying() instead.
(WebCore::AudioDestinationMac::stop):
Ditto.
(WebCore::AudioDestinationMac::setIsPlaying):
If m_isPlaying has changed, call AudioIOCallback::isPlayingDidChange().

  • platform/audio/mac/AudioDestinationMac.h:
  • testing/Internals.cpp:

(WebCore::Internals::isPagePlayingAudio):

  • testing/Internals.h:
  • testing/Internals.idl:

Add internals.isPagePlayingAudio() for testing.

LayoutTests:

This test checks that Page::isPlayingAudio() returns false before an audio context is created
and before the oscillator node makes a sound. It then starts the oscillator node and checks
that Page::isPlayingAudio() later returns true.

  • webaudio/web-audio-is-playing-expected.txt: Added.
  • webaudio/web-audio-is-playing.html: Added.
2:51 PM Changeset in webkit [176349] by dbates@webkit.org
  • 2 edits in trunk/Source/WebCore

Attempt to fix the Apple Internal Mountain Lion build after <​https://trac.webkit.org/changeset/176347>
(​https://bugs.webkit.org/show_bug.cgi?id=136863)

Only import header CFNSURLConnection.h when building for iOS or OS X Yosemite.

  • platform/spi/cf/CFNetworkSPI.h:
2:40 PM Changeset in webkit [176348] by Antti Koivisto
  • 2 edits in trunk/Source/WebCore

Fix TilesAdded bitmask
​https://bugs.webkit.org/show_bug.cgi?id=138883

Reviewed by Simon Fraser.

Simon spotted this.

  • platform/graphics/ca/GraphicsLayerCA.h:

Use 1LLU << 29 instead of 1LLU < 29
This worked before by pure luck as bit 0 is unused.

2:32 PM Changeset in webkit [176347] by dbates@webkit.org
  • 24 edits
    4 adds
    1 delete in trunk/Source

[iOS] Make WebKit build with public iOS SDK
​https://bugs.webkit.org/show_bug.cgi?id=136863

Reviewed by David Kilzer.

Source/WebCore:

  • WebCore.xcodeproj/project.pbxproj: Add private headers CFNetworkSPI.h and

NS{CalendarDate, String, URLDownload}SPI.h.

  • loader/cocoa/DiskCacheMonitorCocoa.mm: Move forward declaration of

CFNetwork data types and functions from here to file CFNetworkSPI.h and
include header CFNetworkSPI.h.

  • platform/network/mac/ResourceHandleMac.mm: Substitute CFNetworkSPI.h for

CFURLRequestSPI.h as the content of the latter was incorporated into the former.

  • platform/spi/cf/CFNetworkSPI.h: Added.
  • platform/spi/cf/CFURLRequestSPI.h: Removed; incorporated its functionality

into CFNetworkSPI.h

  • platform/spi/cocoa/NSCalendarDateSPI.h: Added.
  • platform/spi/cocoa/NSStringSPI.h: Added.
  • platform/spi/cocoa/NSURLDownloadSPI.h: Added.

Source/WebKit/ios:

  • Misc/WebGeolocationCoreLocationProvider.mm: Remove unnecessary include of header <CoreLocation/CoreLocationPriv.h>.
  • Misc/WebNSStringExtrasIOS.m: Substitute header <WebCore/NSStringSPI.h> for <Foundation/NSString_NSURLExtras.h>.
  • Misc/WebUIKitSupport.mm: Remove unnecessary include of header CoreFoundation/CFPriv.h.

Source/WebKit/mac:

  • History/WebHistory.mm: Include header NSCalendarDateSPI.h.
  • History/WebHistoryItemPrivate.h: Remove include of private header Foundation/NSCalendarDate.h.
  • Misc/WebDownload.h: Forward declare NSURLDownload when building without header Foundation/NSURLDownload.h.

We use has_include() instead of WTF_USE_APPLE_INTERNAL_SDK since this header
may be used by Apple internal clients that do not include wtf/Platform.h.

  • Misc/WebDownload.mm: Include header NSURLDownloadSPI.h instead of including

private Foundation headers directly.

  • Misc/WebNSURLExtras.mm: Remove unnecessary include of private Foundation header.
  • WebCoreSupport/WebFrameNetworkingContext.mm: Include header CFNetworkSPI.h

instead of including private CFNetwork headers directly. Also fixed up style and
ordering of header include directives.

  • WebView/WebView.mm: Include header CFNetworkSPI.h instead of including private

CFNetwork headers directly. Also sort the #import directives.

  • WebView/WebViewPrivate.h: Define ENABLE_TOUCH_EVENTS if not otherwise defined

and added ENABLE_TOUCH_EVENTS-guard around -_touchEventRegions.

Source/WebKit2:

  • NetworkProcess/cocoa/NetworkProcessCocoa.mm: Moved CFNetwork forward declarations

from this file to file CFNetworkSPI.h and included header CFNetworkSPI.h.

  • NetworkProcess/mac/NetworkDiskCacheMonitor.mm: Ditto.
  • NetworkProcess/mac/NetworkResourceLoaderMac.mm: Ditto.
  • UIProcess/API/Cocoa/WKProcessPool.mm: Ditto.
  • UIProcess/mac/WebContextMac.mm: Ditto.
  • WebProcess/cocoa/WebProcessCocoa.mm: Ditto.
2:24 PM Changeset in webkit [176346] by dburkart@apple.com
  • 4 edits in branches/safari-600.3-branch/Source/WebKit2

Merge r176299. rdar://problem/19024541

2:20 PM Changeset in webkit [176345] by dburkart@apple.com
  • 2 edits in branches/safari-600.3-branch/Source/WebCore

Merge r176296. rdar://problem/18912505

2:14 PM Changeset in webkit [176344] by dburkart@apple.com
  • 7 edits in branches/safari-600.3-branch/Source

Merge r176288. rdar://problem/18840382

2:12 PM Changeset in webkit [176343] by Chris Fleizach
  • 2 edits in trunk/Tools

AX: Screen braille input doesn't work on forms.
​https://bugs.webkit.org/show_bug.cgi?id=138804

Unreviewed build fix.

  • DumpRenderTree/AccessibilityUIElement.cpp:

(AccessibilityUIElement::setValue):

2:10 PM Changeset in webkit [176342] by dburkart@apple.com
  • 2 edits in branches/safari-600.3-branch/Source/WebKit2

Merge r176238. rdar://problem/18990674

2:07 PM Changeset in webkit [176341] by dburkart@apple.com
  • 2 edits in branches/safari-600.3-branch/Source/WebKit2

Merge r176237. rdar://problem/18900839

2:07 PM Changeset in webkit [176340] by andersca@apple.com
  • 5 edits in trunk/Source/WebKit2

Add APIs for customizing the user agent
​https://bugs.webkit.org/show_bug.cgi?id=138881
rdar://problem/17233981

Reviewed by Dan Bernstein.

  • UIProcess/API/Cocoa/WKWebView.h:
  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView initWithFrame:configuration:]):
(-[WKWebView customUserAgent]):
(-[WKWebView setCustomUserAgent:]):
(-[WKWebView _customUserAgent]):
(-[WKWebView _setCustomUserAgent:]):

  • UIProcess/API/Cocoa/WKWebViewConfiguration.h:
  • UIProcess/API/Cocoa/WKWebViewConfiguration.mm:

(LazyInitialized::set):
(-[WKWebViewConfiguration copyWithZone:]):
(defaultApplicationNameForUserAgent):
(-[WKWebViewConfiguration applicationNameForUserAgent]):
(-[WKWebViewConfiguration setApplicationNameForUserAgent:]):

2:05 PM Changeset in webkit [176339] by Simon Fraser
  • 2 edits in trunk/Source/WebKit2

[WK2 UI-side compositing] Initialize RemoteLayerTreeTransaction properties which are unset on Mac
​https://bugs.webkit.org/show_bug.cgi?id=138877

Reviewed by Tim Horton.

These data members are unused on Mac, but still encoded, so initialize them with
reasonable values.

  • Shared/mac/RemoteLayerTreeTransaction.mm:

(WebKit::RemoteLayerTreeTransaction::RemoteLayerTreeTransaction):

2:03 PM Changeset in webkit [176338] by dburkart@apple.com
  • 9 edits in branches/safari-600.3-branch/Source

Merge r176221. rdar://problem/18991369

1:57 PM Changeset in webkit [176337] by enrica@apple.com
  • 9 edits in trunk/Source/WebKit2

Refactor iOS selection gestures.
​https://bugs.webkit.org/show_bug.cgi?id=138720
rdar://problem/18964359

Reviewed by Benjamin Poulain.

This is a first step towards refactoring the selection gestures code.
It introduces more general selection movement functions that can be used to build
the gestures.

  • UIProcess/WebPageProxy.h:
  • UIProcess/ios/WKContentViewInteraction.h:
  • UIProcess/ios/WKContentViewInteraction.mm:

(toWKTextGranularity):
(toWKSelectionDirection):
(-[WKContentView selectPositionAtPoint:completionHandler:]):
(-[WKContentView selectPositionAtBoundary:inDirection:fromPoint:completionHandler:]):
(-[WKContentView selectTextWithGranularity:atPoint:completionHandler:]):
(-[WKContentView beginSelectionInDirection:completionHandler:]):
(-[WKContentView updateSelectionWithExtentPoint:completionHandler:]):
(-[WKContentView _startAssistingNode:userIsInteracting:blurPreviousNode:userObject:]):

  • UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::selectTextWithGranularityAtPoint):
(WebKit::WebPageProxy::selectPositionAtBoundaryWithDirection):
(WebKit::WebPageProxy::selectPositionAtPoint):
(WebKit::WebPageProxy::beginSelectionInDirection):
(WebKit::WebPageProxy::updateSelectionWithExtentPoint):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:
  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::selectWithGesture):
(WebKit::WebPage::visiblePositionInFocusedNodeForPoint):
(WebKit::WebPage::selectPositionAtPoint):
(WebKit::WebPage::selectPositionAtBoundaryWithDirection):
(WebKit::WebPage::selectTextWithGranularityAtPoint):
(WebKit::WebPage::beginSelectionInDirection):
(WebKit::WebPage::updateSelectionWithExtentPoint):

1:56 PM Changeset in webkit [176336] by dburkart@apple.com
  • 9 edits in branches/safari-600.3-branch/Source

Merged r176220. rdar://problem/18944893

1:39 PM Changeset in webkit [176335] by Joseph Pecoraro
  • 3 edits in trunk/Source/JavaScriptCore

Unreviewed build fixes after r176329.

  • export all of the codegen python files as they are included by the main generator
  • update the imports of the main generator to match init.py
  • remove bundling the python scripts as framework resources, just have them PrivateHeaders
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • inspector/scripts/generate-inspector-protocol-bindings.py:
1:31 PM Changeset in webkit [176334] by Simon Fraser
  • 6 edits in trunk/Source/WebKit2

[WK2 UI-side Compositing] Fix the position and scroll indicator of the UI-side tiled scrolling indicator
​https://bugs.webkit.org/show_bug.cgi?id=138876

Reviewed by Beth Dakin.

Fix the position of the tiled scrolling indicator in MiniBrowser by taking top
content offset into account.

On Mac, pass the current scroll position back to the UI process via the RemoteLayerTreeTransaction
so that we can use it to show the correctly scroll offset in the indicator. This is temporary until
Mac does UI-side scrolling.

  • Shared/mac/RemoteLayerTreeTransaction.h:

(WebKit::RemoteLayerTreeTransaction::scrollPosition):
(WebKit::RemoteLayerTreeTransaction::setScrollPosition):

  • Shared/mac/RemoteLayerTreeTransaction.mm:

(WebKit::RemoteLayerTreeTransaction::encode):
(WebKit::RemoteLayerTreeTransaction::decode):

  • UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.h:
  • UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.mm:

(WebKit::RemoteLayerTreeDrawingAreaProxy::commitLayerTree):
(WebKit::RemoteLayerTreeDrawingAreaProxy::indicatorLocation):
(WebKit::RemoteLayerTreeDrawingAreaProxy::updateDebugIndicator):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::willCommitLayerTree):

1:15 PM Changeset in webkit [176333] by Chris Dumez
  • 1 edit
    4 moves
    2 adds in trunk/LayoutTests

Add layout test for throttling of DOM timer changing the style of visible and invisible elements
​https://bugs.webkit.org/show_bug.cgi?id=138875

Reviewed by Simon Fraser.

Add a layout test to test that a repeating DOM timer changing the style
of both visible and invisible elements does not get throttled.

Also rename existing tests to use "display-none" instead of "invisible"
for clarity.

  • fast/dom/nested-timer-display-none-element-throttling-expected.txt: Renamed from LayoutTests/fast/dom/nested-timer-invisible-element-throttling-expected.txt.
  • fast/dom/nested-timer-display-none-element-throttling.html: Renamed from LayoutTests/fast/dom/nested-timer-invisible-element-throttling.html.
  • fast/dom/repeating-timer-display-none-element-throttling-expected.txt: Renamed from LayoutTests/fast/dom/repeating-timer-invisible-element-throttling-expected.txt.
  • fast/dom/repeating-timer-display-none-element-throttling.html: Renamed from LayoutTests/fast/dom/repeating-timer-invisible-element-throttling.html.
  • fast/dom/repeating-timer-mixed-visible-display-none-elements-throttling-expected.txt: Added.
  • fast/dom/repeating-timer-mixed-visible-display-none-elements-throttling.html: Added.
1:01 PM Changeset in webkit [176332] by dburkart@apple.com
  • 5 edits in branches/safari-600.3-branch/Source

Bump versioning

12:50 PM Changeset in webkit [176331] by benjamin@webkit.org
  • 2 edits in trunk/Source/WebCore

Get rid of AccessibilityObject::setRoleValue()
​https://bugs.webkit.org/show_bug.cgi?id=138861

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2014-11-19
Reviewed by Chris Fleizach.

  • accessibility/AccessibilityObject.h:

(WebCore::AccessibilityObject::setRoleValue): Deleted.

12:46 PM Changeset in webkit [176330] by Chris Dumez
  • 1 edit
    2 adds in trunk/LayoutTests

Add layout test for DOM timer throttling and element moving into view after layout
​https://bugs.webkit.org/show_bug.cgi?id=138874

Reviewed by Simon Fraser.

Add a layout test to make sure we unthrottle a DOM timer changing the
style of an element outside viewport if the element ends up inside
the viewport after layout.

  • fast/dom/timer-unthrottle-on-layout-expected.txt: Added.
  • fast/dom/timer-unthrottle-on-layout.html: Added.
11:16 AM Changeset in webkit [176329] by Brian Burg
  • 10 edits
    1 copy
    18 moves
    2 adds in trunk/Source/JavaScriptCore

Web Inspector: standardize language-specific protocol generator file, class, and method prefixes
​https://bugs.webkit.org/show_bug.cgi?id=138237

Reviewed by Joseph Pecoraro.

Settle on cpp/objc/js file prefixes and Cpp/ObjC/JS class prefixes for generators.
Move C++-specific static methods into CppGenerator and add cpp_ prefixes where relevant.
Split the templates file into language-specific template files.

  • CMakeLists.txt:
  • DerivedSources.make:
  • JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
  • JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • inspector/scripts/codegen/init.py:
  • inspector/scripts/codegen/cpp_generator.py: Copied from Source/JavaScriptCore/inspector/scripts/codegen/generator.py.
  • inspector/scripts/codegen/cpp_generator_templates.py: Copied from Source/JavaScriptCore/inspector/scripts/codegen/generator_templates.py.

(CppGeneratorTemplates):

  • inspector/scripts/codegen/generate_cpp_alternate_backend_dispatcher_header.py: Renamed from Source/JavaScriptCore/inspector/scripts/codegen/generate_alternate_backend_dispatcher_header.py.
  • inspector/scripts/codegen/generate_cpp_backend_dispatcher_header.py: Renamed from Source/JavaScriptCore/inspector/scripts/codegen/generate_backend_dispatcher_header.py.
  • inspector/scripts/codegen/generate_cpp_backend_dispatcher_implementation.py: Renamed from Source/JavaScriptCore/inspector/scripts/codegen/generate_backend_dispatcher_implementation.py.
  • inspector/scripts/codegen/generate_cpp_frontend_dispatcher_header.py: Renamed from Source/JavaScriptCore/inspector/scripts/codegen/generate_frontend_dispatcher_header.py.
  • inspector/scripts/codegen/generate_cpp_frontend_dispatcher_implementation.py: Renamed from Source/JavaScriptCore/inspector/scripts/codegen/generate_frontend_dispatcher_implementation.py.
  • inspector/scripts/codegen/generate_cpp_protocol_types_header.py: Renamed from Source/JavaScriptCore/inspector/scripts/codegen/generate_protocol_types_header.py.
  • inspector/scripts/codegen/generate_cpp_protocol_types_implementation.py: Renamed from Source/JavaScriptCore/inspector/scripts/codegen/generate_protocol_types_implementation.py.
  • inspector/scripts/codegen/generate_js_backend_commands.py: Renamed from Source/JavaScriptCore/inspector/scripts/codegen/generate_backend_commands.py.
  • inspector/scripts/codegen/generate_objc_backend_dispatcher_header.py: Renamed from Source/JavaScriptCore/inspector/scripts/codegen/generate_objective_c_backend_dispatcher_header.py.
  • inspector/scripts/codegen/generate_objc_backend_dispatcher_implementation.py: Renamed from Source/JavaScriptCore/inspector/scripts/codegen/generate_objective_c_backend_dispatcher_implementation.py.
  • inspector/scripts/codegen/generate_objc_configuration_header.py: Renamed from Source/JavaScriptCore/inspector/scripts/codegen/generate_objective_c_configuration_header.py.
  • inspector/scripts/codegen/generate_objc_configuration_implementation.py: Renamed from Source/JavaScriptCore/inspector/scripts/codegen/generate_objective_c_configuration_implementation.py.
  • inspector/scripts/codegen/generate_objc_conversion_helpers.py: Renamed from Source/JavaScriptCore/inspector/scripts/codegen/generate_objective_c_conversion_helpers.py.
  • inspector/scripts/codegen/generate_objc_frontend_dispatcher_implementation.py: Renamed from Source/JavaScriptCore/inspector/scripts/codegen/generate_objective_c_frontend_dispatcher_implementation.py.
  • inspector/scripts/codegen/generate_objc_header.py: Renamed from Source/JavaScriptCore/inspector/scripts/codegen/generate_objective_c_header.py.
  • inspector/scripts/codegen/generate_objc_internal_header.py: Renamed from Source/JavaScriptCore/inspector/scripts/codegen/generate_objective_c_internal_header.py.
  • inspector/scripts/codegen/generate_objc_protocol_types_implementation.py: Renamed from Source/JavaScriptCore/inspector/scripts/codegen/generate_objective_c_types_implementation.py.
  • inspector/scripts/codegen/generator.py:
  • inspector/scripts/codegen/generator_templates.py:
  • inspector/scripts/codegen/objc_generator.py: Renamed from Source/JavaScriptCore/inspector/scripts/codegen/generate_objective_c.py.
  • inspector/scripts/codegen/objc_generator_templates.py: Added.
  • inspector/scripts/generate-inspector-protocol-bindings.py:
11:01 AM Changeset in webkit [176328] by bshafiei@apple.com
  • 1 copy in tags/Safari-601.1.10

New tag.

10:59 AM Changeset in webkit [176327] by bshafiei@apple.com
  • 5 edits in trunk/Source

Versioning.

10:46 AM Changeset in webkit [176326] by commit-queue@webkit.org
  • 4 edits in trunk/Source/JavaScriptCore

Update WebKit to build with LLVM TOT
​https://bugs.webkit.org/show_bug.cgi?id=138519

Patch by Juergen Ributzka <​juergen@apple.com> on 2014-11-19
Reviewed by Alexey Proskuryakov.

  • Configurations/LLVMForJSC.xcconfig:
  • llvm/LLVMAPIFunctions.h:
  • llvm/library/LLVMExports.cpp:

(initializeAndGetJSCLLVMAPI):

10:34 AM Changeset in webkit [176325] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Debugger should not mutate variable when hovering mouse over ++n expression
​https://bugs.webkit.org/show_bug.cgi?id=138839

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-11-19
Reviewed by Timothy Hatcher.

  • UserInterface/Controllers/CodeMirrorTokenTrackingController.js:

(WebInspector.CodeMirrorTokenTrackingController.prototype._processJavaScriptExpression):

10:32 AM Changeset in webkit [176324] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Improve basic JavaScript completion in inline <script>s
​https://bugs.webkit.org/show_bug.cgi?id=138845

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-11-19
Reviewed by Timothy Hatcher.

  • UserInterface/Controllers/CodeMirrorCompletionController.js:

(WebInspector.CodeMirrorCompletionController.prototype._generateJavaScriptCompletions):
Fix up CodeMirror mode handling for JavaScript completion when inside of mixed mode
input (html). Also add completion for CodeMirror's localVars list.

10:27 AM Changeset in webkit [176323] by Chris Dumez
  • 1 edit
    2 adds in trunk/LayoutTests

Add layout test for DOM timers throttling and 0 height element with visible overflowing content
​https://bugs.webkit.org/show_bug.cgi?id=138873

Reviewed by Simon Fraser.

Add a layout test for verify that a DOM timer changing the style of a 0
height element with visible overflowing content does not get throttled.
If the implementation did not properly use the overflow rect to
determine if the element is visible, this test would fail.

This covers the case of the top scrolling banner on huffingtonpost.com.

  • fast/dom/repeating-timer-element-overflow-throttling-expected.txt: Added.
  • fast/dom/repeating-timer-element-overflow-throttling.html: Added.
9:52 AM Changeset in webkit [176322] by Philippe Normand
  • 2 edits in trunk/Source/WebCore

Missing NULL-check in VideoTrack::setLanguage
​https://bugs.webkit.org/show_bug.cgi?id=138867

Reviewed by Jer Noble.

  • html/track/VideoTrack.cpp:

(WebCore::VideoTrack::setLanguage): Prevent change event creation
on an empty video track list.

9:36 AM Changeset in webkit [176321] by Chris Fleizach
  • 3 edits
    2 adds in trunk

AX: Safari fails to load a web page with VoiceOver
​https://bugs.webkit.org/show_bug.cgi?id=138849

Reviewed by Mario Sanchez Prada.

Source/WebCore:

Sometimes an inlineElementContinuation will continue to an inline RenderBlock, so we case this incorrectly and bad things happen.

Test: accessibility/inline-block-assertion.html

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::startOfContinuations):

LayoutTests:

  • accessibility/inline-block-assertion-expected.txt: Added.
  • accessibility/inline-block-assertion.html: Added.
9:26 AM Changeset in webkit [176320] by Alan Bujtas
  • 2 edits in trunk/Source/WebCore

Simple line layout: RenderTreeAsText should use rangeForRenderer() when dumping simple line text.
​https://bugs.webkit.org/show_bug.cgi?id=138847

Reviewed by Antti Koivisto.

This is in preparation to support multiple renderers for simple line layout.
Use rangeForRenderer() to get runs for a particular renderer as opposed to for the entire flow.

Not testable.

  • rendering/RenderTreeAsText.cpp:

(WebCore::write):

9:23 AM Changeset in webkit [176319] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[WinCairo] Compile error when CSS_SELECTORS_LEVEL4 is not enabled.
​https://bugs.webkit.org/show_bug.cgi?id=138870

Patch by ​peavo@outlook.com <​peavo@outlook.com> on 2014-11-19
Reviewed by Alex Christensen.

  • css/CSSSelector.cpp:

(WebCore::simpleSelectorSpecificityInternal):

7:47 AM Changeset in webkit [176318] by Chris Fleizach
  • 8 edits
    4 adds in trunk

AX: Screen braille input doesn't work on forms.
​https://bugs.webkit.org/show_bug.cgi?id=138804

Reviewed by Mario Sanchez Prada.

Source/WebCore:

Allow iOS to set values of text fields through the API.

Test: platform/ios-sim/accessibility/set-value.html

  • accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:

(-[WebAccessibilityObjectWrapper _accessibilitySetValue:]):

Tools:

Add a method to setValue through the AX API in DRT.

  • DumpRenderTree/AccessibilityUIElement.cpp:

(setValueCallback):
(AccessibilityUIElement::getJSClass):

  • DumpRenderTree/AccessibilityUIElement.h:
  • DumpRenderTree/ios/AccessibilityUIElementIOS.mm:

(AccessibilityUIElement::setValue):

  • DumpRenderTree/mac/AccessibilityUIElementMac.mm:

(AccessibilityUIElement::setValue):

LayoutTests:

  • platform/ios-sim: Copied from LayoutTests/platform/ios-sim.
  • platform/ios-sim/accessibility/set-value-expected.txt: Added.
  • platform/ios-sim/accessibility/set-value.html: Added.
7:40 AM Changeset in webkit [176317] by Alan Bujtas
  • 6 edits in trunk/Source/WebCore

Simple line layout: Add renderer based rect collecting to RunResolver.
​https://bugs.webkit.org/show_bug.cgi?id=138818

Reviewed by Antti Koivisto.

This is in preparation to multiple renderers support.
RunResolver should be able to collect rects for a particular renderer
that might overlap multiple runs. (or might just be a subset of a Run)

Covered by existing tests.

  • rendering/SimpleLineLayoutFlowContents.cpp:

(WebCore::SimpleLineLayout::FlowContents::renderer): It operates on a single renderer currently.
(WebCore::SimpleLineLayout::FlowContents::resolveRendererPositions): It operates on a single renderer currently.

  • rendering/SimpleLineLayoutFlowContents.h:
  • rendering/SimpleLineLayoutFunctions.cpp:

(WebCore::SimpleLineLayout::computeTextBoundingBox):
(WebCore::SimpleLineLayout::computeTextFirstRunLocation):
(WebCore::SimpleLineLayout::collectTextAbsoluteRects):
(WebCore::SimpleLineLayout::collectTextAbsoluteQuads):
(WebCore::SimpleLineLayout::showLineLayoutForFlow):

  • rendering/SimpleLineLayoutResolver.cpp:

(WebCore::SimpleLineLayout::baselinePosition):
(WebCore::SimpleLineLayout::linePosition):
(WebCore::SimpleLineLayout::lineSize):
(WebCore::SimpleLineLayout::RunResolver::Run::rect):
(WebCore::SimpleLineLayout::RunResolver::Run::rectForTextRenderer):
(WebCore::SimpleLineLayout::RunResolver::Run::baseline):
(WebCore::SimpleLineLayout::RunResolver::Run::text):
(WebCore::SimpleLineLayout::RunResolver::Run::computeRect):
(WebCore::SimpleLineLayout::RunResolver::RunResolver):

  • rendering/SimpleLineLayoutResolver.h:
6:24 AM Changeset in webkit [176316] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[GTK] Error in documentation of webkit_print_operation_get_page_setup()
​https://bugs.webkit.org/show_bug.cgi?id=138868

Patch by Michael Catanzaro <Michael Catanzaro> on 2014-11-19
Reviewed by Carlos Garcia Campos.

Fix copypaste error in documentation of
webkit_print_operation_get_page_setup().

  • UIProcess/API/gtk/WebKitPrintOperation.cpp:
4:46 AM WebKitGTK/2.6.x edited by jdiggs@igalia.com
(diff)
1:55 AM Changeset in webkit [176315] by mrowe@apple.com
  • 1 edit
    1 delete in trunk/Source/WebKit2

Remove an unused file.

  • version.plist: Removed.
1:06 AM Changeset in webkit [176314] by commit-queue@webkit.org
  • 2 edits in trunk

Fix the detection of toolchain support for Cortex-A53 erratum 835769 workaround
​https://bugs.webkit.org/show_bug.cgi?id=138840

Patch by Akos Kiss <​akiss@inf.u-szeged.hu> on 2014-11-19
Reviewed by Csaba Osztrogonác.

  • Source/cmake/OptionsCommon.cmake:
12:57 AM Changeset in webkit [176313] by commit-queue@webkit.org
  • 5 edits
    4 adds in trunk

Add selector checker for :lang pseudo class in Selectors level 4
​https://bugs.webkit.org/show_bug.cgi?id=138281

Patch by Dhi Aurrahman <​diorahman@rockybars.com> on 2014-11-19
Reviewed by Benjamin Poulain.

Source/WebCore:

Add selector checker for :lang pseudo class in Selectors level 4.

The language tags matching is specified in [1,2].

[1] ​http://www.ietf.org/rfc/rfc4647.txt
[2] ​http://dev.w3.org/csswg/selectors4/#the-lang-pseudo

Tests: fast/selectors/lang-extended-filtering.html

fast/selectors/lang-multiple.html

  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::checkOne):

  • css/SelectorCheckerTestFunctions.h:

(WebCore::containslanguageSubtagMatchingRange):
(WebCore::matchesLangPseudoClass):
(WebCore::matchesLangPseudoClassDeprecated):

  • cssjit/SelectorCompiler.cpp:

(WebCore::SelectorCompiler::addPseudoClassType):

LayoutTests:

Add layout tests for :lang selector checker with multiple arguments and
related behaviors on extended filtering.

  • fast/selectors/lang-extended-filtering-expected.txt: Added.
  • fast/selectors/lang-extended-filtering.html: Added.
  • fast/selectors/lang-multiple-expected.txt: Added.
  • fast/selectors/lang-multiple.html: Added.
12:53 AM Changeset in webkit [176312] by mrowe@apple.com
  • 1 edit
    1 copy in trunk/Source/WebInspectorUI

Roll over WebInspectorUI's ChangeLog.

Nov 18, 2014:

11:49 PM Changeset in webkit [176311] by Philippe Normand
  • 8 edits in trunk

start/stop method for AudioBufferSourceNodes and OscillatorNodes can take no args
​https://bugs.webkit.org/show_bug.cgi?id=138739

Reviewed by Darin Adler.

Source/WebCore:

The patch is inspired by the following Blink revision by
<Raymond Toy>:
<​https://src.chromium.org/viewvc/blink?view=rev&revision=160845>

Test: webaudio/dom-exceptions.html

  • Modules/webaudio/AudioBufferSourceNode.cpp:

(WebCore::AudioBufferSourceNode::start):
(WebCore::AudioBufferSourceNode::startPlaying):
(WebCore::AudioBufferSourceNode::noteGrainOn):
(WebCore::AudioBufferSourceNode::startGrain): Deleted.

  • Modules/webaudio/AudioBufferSourceNode.h:
  • Modules/webaudio/AudioBufferSourceNode.idl:
  • Modules/webaudio/AudioScheduledSourceNode.cpp:

(WebCore::AudioScheduledSourceNode::start):
(WebCore::AudioScheduledSourceNode::stop):

  • Modules/webaudio/AudioScheduledSourceNode.h:
  • Modules/webaudio/OscillatorNode.idl:

LayoutTests:

  • webaudio/dom-exceptions-expected.txt: Added.
  • webaudio/dom-exceptions.html: Added.
10:45 PM Changeset in webkit [176310] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Aad failing test expectations to some tests imported in r176144.

  • platform/win/TestExpectations:
9:41 PM Changeset in webkit [176309] by ap@apple.com
  • 2 edits in trunk/LayoutTests

Use of uninitialized value in string eq in many http tests
​https://bugs.webkit.org/show_bug.cgi?id=138852

Reviewed by Daniel Bates.

  • http/tests/security/xssAuditor/resources/echo-intertag.pl: Don't use it uninitialized.
9:13 PM Changeset in webkit [176308] by benjamin@webkit.org
  • 15 edits in trunk/Source/WebKit2

[WK2] Remove the minimalUI code from the UIProcess
​https://bugs.webkit.org/show_bug.cgi?id=138819

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2014-11-18
Reviewed by Sam Weinig.

It looks like the only interface we have to keep alive is
[WKWebView _overrideLayoutParametersWithMinimumLayoutSize:minimumLayoutSizeForMinimalUI:maximumUnobscuredSizeOverride:].

Clean up everything else, it is a pile of useless code.

  • UIProcess/API/Cocoa/WKUIDelegatePrivate.h:
  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _didCommitLoadForMainFrame]):
(-[WKWebView _didCommitLayerTree:]):
(-[WKWebView _frameOrBoundsChanged]):
(-[WKWebView _didRelaunchProcess]):
(-[WKWebView _beginAnimatedResizeWithUpdates:]):
(-[WKWebView _overrideLayoutParametersWithMinimumLayoutSize:minimumLayoutSizeForMinimalUI:maximumUnobscuredSizeOverride:]):
(-[WKWebView _overrideLayoutParametersWithMinimumLayoutSize:maximumUnobscuredSizeOverride:]):
(-[WKWebView _setUsesMinimalUI:]): Deleted.
(-[WKWebView _usesMinimalUI]): Deleted.
(activeMinimumLayoutSizeForMinimalUI): Deleted.
(-[WKWebView _setMinimumLayoutSizeOverrideForMinimalUI:]): Deleted.

  • UIProcess/API/Cocoa/WKWebViewInternal.h:
  • UIProcess/API/Cocoa/WKWebViewPrivate.h:
  • UIProcess/API/ios/WKViewIOS.mm:

(-[WKView _frameOrBoundsChanged]):

  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/ios/PageClientImplIOS.h:
  • UIProcess/ios/PageClientImplIOS.mm:

(WebKit::PageClientImpl::setUsesMinimalUI): Deleted.

  • UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::dynamicViewportSizeUpdate):
(WebKit::WebPageProxy::setViewportConfigurationMinimumLayoutSizeForMinimalUI): Deleted.
(WebKit::WebPageProxy::setUsesMinimalUI): Deleted.

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:
  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::viewportPropertiesDidChange):
(WebKit::WebPage::dynamicViewportSizeUpdate):
(WebKit::WebPage::setViewportConfigurationMinimumLayoutSizeForMinimalUI): Deleted.

9:12 PM Changeset in webkit [176307] by benjamin@webkit.org
  • 7 edits
    20 adds in trunk

Add the initial implementation of dynamic specificity for :matches()
​https://bugs.webkit.org/show_bug.cgi?id=138822

Reviewed by Andreas Kling.

Source/WebCore:

Previously we completely ignored the selector list of :matches() when computing
the specificity of the selector.

The spec (​http://dev.w3.org/csswg/selectors4/#specificity) says:
"The specificity of a :matches() pseudo-class, however, is the specificity

of the most specific complex selector that matched the given element."

This patch does just that.

In the CSS JIT, we only consider specificities that can be computed statically
for now, this should be extended later.
When the specificity is dynamic, we fall back to SelectorChecker. In that case,
we execute every selector of the selector list and we keep the maximum value
as the specificity for the whole :matches().

Tests: fast/css/matches-specificity-1.html

fast/css/matches-specificity-2.html
fast/css/matches-specificity-3.html
fast/css/matches-specificity-4.html
fast/css/matches-specificity-5.html
fast/css/matches-specificity-6.html
fast/css/matches-specificity-7.html
fast/css/matches-specificity-8.html
fast/css/matches-specificity-9.html
fast/css/matches-specificity-10.html

  • css/CSSSelector.cpp:

(WebCore::selectorSpecificity):
(WebCore::maxSpecificity):
(WebCore::CSSSelector::specificity):
(WebCore::simpleSelectorSpecificityInternal):
(WebCore::CSSSelector::simpleSelectorSpecificity):
:matches() itself should not have any specificity. The specificity of its components
is computed in SelectorChecker.

Since :matches() is no longer accounted as a class B specificity, I had to finish
the specificity of :not() or some test breaks.

  • css/CSSSelector.h:
  • css/PageRuleCollector.cpp:

(WebCore::comparePageRules):

  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::checkOne):
We can no longer shortcut the execution when context.pseudoElementEffective is false.
There is no guarantee that a following selector wouldn't match with a higher specificity.

  • cssjit/SelectorCompiler.cpp:

(WebCore::SelectorCompiler::addPseudoClassType):
(WebCore::SelectorCompiler::SelectorCodeGenerator::SelectorCodeGenerator):
(WebCore::SelectorCompiler::constructFragments):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateSelectorChecker):

LayoutTests:

  • fast/css/matches-specificity-1-expected.html: Added.
  • fast/css/matches-specificity-1.html: Added.
  • fast/css/matches-specificity-2-expected.html: Added.
  • fast/css/matches-specificity-2.html: Added.
  • fast/css/matches-specificity-3-expected.html: Added.
  • fast/css/matches-specificity-3.html: Added.
  • fast/css/matches-specificity-4-expected.html: Added.
  • fast/css/matches-specificity-4.html: Added.
  • fast/css/matches-specificity-5-expected.html: Added.
  • fast/css/matches-specificity-5.html: Added.
  • fast/css/matches-specificity-6-expected.html: Added.
  • fast/css/matches-specificity-6.html: Added.
  • fast/css/matches-specificity-7-expected.html: Added.
  • fast/css/matches-specificity-7.html: Added.
  • fast/css/matches-specificity-8-expected.html: Added.
  • fast/css/matches-specificity-8.html: Added.
  • fast/css/matches-specificity-9-expected.html: Added.
  • fast/css/matches-specificity-9.html: Added.
  • fast/css/matches-specificity-10-expected.html: Added.
  • fast/css/matches-specificity-10.html: Added.
9:08 PM Changeset in webkit [176306] by Conrad Shultz
  • 2 edits in trunk/Source/WebKit2

Unreviewed. Revision to the build fix in r176304.

The guarded method should simply be in the !TARGET_OS_IPHONE block.

  • UIProcess/API/Cocoa/WKViewPrivate.h:
9:06 PM Changeset in webkit [176305] by benjamin@webkit.org
  • 3 edits in trunk/Source/WebKit2

iOS8 new "slow tap" heuristic fires mouse compat events despite preventDefault on touchend
​https://bugs.webkit.org/show_bug.cgi?id=137069
rdar://problem/18481464

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2014-11-18
Reviewed by Simon Fraser.

On WebKit2, we let UIWebTouchEventsGestureRecognizer and _UIWebHighlightLongPressGestureRecognizer
run concurrently. This causes a race with an incorrect behavior:
1) If UIWebTouchEventsGestureRecognizer does not cancel the native gestures on start.
2) _UIWebHighlightLongPressGestureRecognizer starts after highlightDelay.
3) When the finger leaves the screen, both gestures end.
-> If the touch end sent to JavaScript in [3] ask the priority over native events, that no longer stops

the _UIWebHighlightLongPressGestureRecognizer.

The two gesture recognizers can run in any order, there is no guarantee on which one runs first.
To solve the bug, I must make sure the _UIWebHighlightLongPressGestureRecognizer never trigger a click
if the page wants the event.

To solve the order problem, I use the fact that event recognition goes in two phases for
non cancelled events:
1) Update the gesture recognizers.
2) Trigger the actions.

I do not know the order of recognizers in [1], but I know both have run before [2] is executed.
I use that to stop _UIWebHighlightLongPressGestureRecognizer from ending with a click in the case of the bug:
1) When _UIWebHighlightLongPressGestureRecognizer starts, I set _highlightLongPressCanClick signaling

the gesture can end normally. This is done on a timer and not direct input so I don't really have to worry
about a race here.

2) When processing the touch event for UIWebTouchEventsGestureRecognizer, I reset the flag _highlightLongPressCanClick

if the page wants the event.

3) When the actions of _UIWebHighlightLongPressGestureRecognizer are processed, the touch event

has already been processed by the page and the flag has been cleared if needed.

  • UIProcess/ios/WKContentViewInteraction.h:
  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _webTouchEvent:preventsNativeGestures:]):
(-[WKContentView _highlightLongPressRecognized:]):

8:31 PM Changeset in webkit [176304] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebKit2

iOS build fix after r176299. This method is not defined in WKViewIOS.mm.

  • UIProcess/API/Cocoa/WKViewPrivate.h:
6:42 PM Changeset in webkit [176303] by ddkilzer@apple.com
  • 8 edits in trunk/Source

FeatureDefines.xcconfig: Switch from using PLATFORM_NAME to SDK selectors
<​http://webkit.org/b/138813>

Reviewed by Mark Rowe.

  • Configurations/FeatureDefines.xcconfig: Switch to using SDK

selectors.

6:17 PM Changeset in webkit [176302] by rniwa@webkit.org
  • 2 edits in branches/safari-600.2-branch/LayoutTests

nested-multicol-into-region-dynamic.html is flaky on WK1.

  • platform/mac-wk1/TestExpectations:
6:05 PM Changeset in webkit [176301] by Chris Dumez
  • 3 edits
    4 adds in trunk

Crash when setting 'z-index' / 'flex-shrink' CSS properties to a calculated value
​https://bugs.webkit.org/show_bug.cgi?id=138783

Reviewed by Andreas Kling.

Source/WebCore:

Update operators converting CSSPrimitiveValue to integer / floating
point types to properly handle calculated values (e.g. 'calc(2 * 3)').
Previously, this was not working in release builds and we would hit an
ASSERT_NOT_REACHED() in debug builds.

Tests: fast/css/flex-shrink-calculated-value.html

fast/css/z-index-calculated-value.html

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::operator unsigned short):
(WebCore::CSSPrimitiveValue::operator int):
(WebCore::CSSPrimitiveValue::operator unsigned):
(WebCore::CSSPrimitiveValue::operator float):

LayoutTests:

Add layout tests to check that settings 'z-index' / 'flex-shrink' CSS
properties to a calculated value does not crash and behaves as
expected.

  • fast/css/flex-shrink-calculated-value-expected.txt: Added.
  • fast/css/flex-shrink-calculated-value.html: Added.
  • fast/css/z-index-calculated-value-expected.txt: Added.
  • fast/css/z-index-calculated-value.html: Added.
5:57 PM Changeset in webkit [176300] by dburkart@apple.com
  • 1 copy in tags/Safari-600.3.7

Tagging.

5:43 PM Changeset in webkit [176299] by Conrad Shultz
  • 4 edits in trunk/Source/WebKit2

Give clients a way to cancel preview popovers
​https://bugs.webkit.org/show_bug.cgi?id=138855

Reviewed by Tim Horton.

Promote -[WKView _dismissActionMenuPopovers] from internal to private.

  • UIProcess/API/Cocoa/WKViewPrivate.h:
  • UIProcess/API/mac/WKView.mm:

(-[WKView _dismissActionMenuPopovers]):

  • UIProcess/API/mac/WKViewInternal.h:
5:19 PM Changeset in webkit [176298] by mmaxfield@apple.com
  • 14 edits
    2 moves in trunk

Unreviewed, rolling out r176263 and r176273.
​https://bugs.webkit.org/show_bug.cgi?id=138854

Underlines are hideous. (Requested by litherum on #webkit).

Reverted changesets:

"Use underlining metrics from the font file"
​https://bugs.webkit.org/show_bug.cgi?id=138762
​http://trac.webkit.org/changeset/176263

"iOS build fix."
​http://trac.webkit.org/changeset/176273

Patch by Commit Queue <​commit-queue@webkit.org> on 2014-11-18# Please enter the commit message for your changes. Lines starting

4:56 PM Changeset in webkit [176297] by Chris Dumez
  • 14 edits in trunk/Source

Add a setting to toggle DOMTimer throttling support
​https://bugs.webkit.org/show_bug.cgi?id=138844
<rdar://problem/19020874>

Reviewed by Andreas Kling.

Add a setting to disable DOM timers throttling, in order to help
developers determine if a specific issue is caused by timer
throttling.

Source/WebCore:

  • page/DOMTimer.cpp:

(WebCore::DOMTimerFireState::contextDocument):
(WebCore::DOMTimerFireState::scriptMadeUserObservableChanges):
(WebCore::DOMTimer::isDOMTimersThrottlingEnabled):
(WebCore::DOMTimer::updateThrottlingStateIfNecessary):

  • page/DOMTimer.h:
  • page/Settings.in:

Source/WebKit/mac:

  • WebView/WebPreferenceKeysPrivate.h:
  • WebView/WebPreferences.mm:

(+[WebPreferences initialize]):
(-[WebPreferences domTimersThrottlingEnabled]):
(-[WebPreferences setDOMTimersThrottlingEnabled:]):

  • WebView/WebPreferencesPrivate.h:
  • WebView/WebView.mm:

(-[WebView _preferencesChanged:]):

Source/WebKit2:

  • Shared/WebPreferencesDefinitions.h:
  • UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetDOMTimersThrottlingEnabled):
(WKPreferencesGetDOMTimersThrottlingEnabled):

  • UIProcess/API/C/WKPreferencesRefPrivate.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):

4:49 PM Changeset in webkit [176296] by Beth Dakin
  • 2 edits in trunk/Source/WebCore

REGRESSION: Invoking dictionary lookup on text in some search fields searches for
incorrect item
​https://bugs.webkit.org/show_bug.cgi?id=138853
-and corresponding-
rdar://problem/18912505

Reviewed by Tim Horton.

Get the visible position based on the frame, not just the renderer.

  • editing/mac/DictionaryLookup.mm:

(WebCore::rangeForDictionaryLookupAtHitTestResult):

4:37 PM Changeset in webkit [176295] by hyatt@apple.com
  • 3 edits
    2 adds in trunk

REGRESSION (r167210): Invalid cast in WebCore::RenderBlock::blockSelectionGaps
​https://bugs.webkit.org/show_bug.cgi?id=137590

Reviewed by Dean Jackson.

Source/WebCore:

Added fast/block/selection-block-gaps-crash.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::blockSelectionGaps):
Check that we really are a RenderBlock before recurring.

LayoutTests:

  • fast/block/selection-block-gap-crash-expected.txt: Added.
  • fast/block/selection-block-gap-crash.html: Added.
4:20 PM Changeset in webkit [176294] by akling@apple.com
  • 4 edits in trunk

Avoid synchronous style recalc in Document.activeElement
<​https://webkit.org/b/138850>

Reviewed by Ryosuke Niwa.

Source/WebCore:

This subtly changes the behavior of <input autofocus>, which was caught by
a layout test. Auto-focus doesn't happen until the render tree is attached,
although it was possible to force it by accessing document.activeElement.

Now auto-focus is always lazy. This is consistent with other browser engines.

~1% progression on Speedometer locally.

  • dom/Document.cpp:

(WebCore::Document::activeElement):

LayoutTests:

Tweak a test to run once the DOM is loaded instead of during parsing.

  • fast/forms/autofocus-in-sandbox-with-allow-scripts.html:
4:17 PM Changeset in webkit [176293] by Chris Dumez
  • 5 edits in trunk/Source

Have Vector::capacity() return an unsigned instead of a size_t
​https://bugs.webkit.org/show_bug.cgi?id=138842

Reviewed by Andreas Kling.

Source/WebCore:

Update the code base now that Vector::capacity() returns an unsigned
type instead of a size_t.

No new tests, no behavior change.

  • editing/TextIterator.cpp:

(WebCore::SearchBuffer::append):
(WebCore::SearchBuffer::prependContext):
(WebCore::SearchBuffer::search):
(WebCore::SearchBuffer::length):

  • platform/SharedBuffer.cpp:

(WebCore::SharedBuffer::duplicateDataBufferIfNecessary):

Source/WTF:

Have Vector::capacity() return an unsigned instead of a size_t as
capacity is stored as an unsigned internally.

  • wtf/Vector.h:

(WTF::Vector::capacity):
(WTF::OverflowHandler>::expandCapacity):
(WTF::OverflowHandler>::tryExpandCapacity):

3:07 PM Changeset in webkit [176292] by Simon Fraser
  • 2 edits in branches/safari-600.3-branch/Source/WebCore

Merge r175679. rdar://problem/18978404

3:07 PM Changeset in webkit [176291] by Simon Fraser
  • 5 edits
    4 adds in branches/safari-600.3-branch

Merge r175656. rdar://problem/18978402

3:06 PM Changeset in webkit [176290] by ggaren@apple.com
  • 13 edits in trunk/Source

Removed the custom allocator for ListHashSet nodes
​https://bugs.webkit.org/show_bug.cgi?id=138841

Reviewed by Andreas Kling.

Source/WebCore:

Uses of ListHashSet no longer need to declare an inline capacity,
since that was only used to specify the capacity of the custom allocator.

  • dom/DOMNamedFlowCollection.h:
  • dom/DocumentEventQueue.h:
  • dom/DocumentStyleSheetCollection.h:
  • dom/NamedFlowCollection.h:
  • html/FormController.h:
  • rendering/FloatingObjects.h:
  • rendering/RenderBlock.h:

Source/WebKit2:

Uses of ListHashSet no longer need to declare an inline capacity,
since that was only used to specify the capacity of the custom allocator.

  • UIProcess/Plugins/PluginInfoStore.cpp:

(WebKit::PluginInfoStore::loadPluginsIfNecessary):

Source/WTF:

bmalloc is fast, so we don't need a custom allocator.

The MallocBench test for linked list node allocation (list_allocate) is
4.09X faster in bmalloc than TCMalloc. Also, I wrote a stress test to
add/remove link elements, which modify a ListHashSet on insertion and
removal, and it was 1% faster / in the noise with bmalloc enabled.

  • wtf/ListHashSet.h:

(WTF::ListHashSetNode::ListHashSetNode):
(WTF::ListHashSetTranslator::translate):
(WTF::U>::ListHashSet):
(WTF::=):
(WTF::U>::swap):
(WTF::U>::~ListHashSet):
(WTF::U>::size):
(WTF::U>::capacity):
(WTF::U>::isEmpty):
(WTF::U>::first):
(WTF::U>::removeFirst):
(WTF::U>::takeFirst):
(WTF::U>::last):
(WTF::U>::removeLast):
(WTF::U>::takeLast):
(WTF::U>::contains):
(WTF::U>::remove):
(WTF::U>::clear):
(WTF::U>::unlink):
(WTF::U>::unlinkAndDelete):
(WTF::U>::appendNode):
(WTF::U>::prependNode):
(WTF::U>::insertNodeBefore):
(WTF::U>::deleteAllNodes):
(WTF::ListHashSetNodeAllocator::ListHashSetNodeAllocator): Deleted.
(WTF::ListHashSetNodeAllocator::allocate): Deleted.
(WTF::ListHashSetNodeAllocator::deallocate): Deleted.
(WTF::ListHashSetNodeAllocator::pool): Deleted.
(WTF::ListHashSetNodeAllocator::pastPool): Deleted.
(WTF::ListHashSetNodeAllocator::inPool): Deleted.
(WTF::ListHashSetNode::operator new): Deleted.
(WTF::ListHashSetNode::destroy): Deleted.

2:57 PM Changeset in webkit [176289] by eric.carlson@apple.com
  • 2 edits in trunk/Source/WebKit2

Unreviewed build fix after r176283.

  • UIProcess/API/Cocoa/WKWebViewConfiguration.mm:
2:54 PM Changeset in webkit [176288] by timothy_horton@apple.com
  • 7 edits in trunk/Source

Avoid re-encoding action menu image data
​https://bugs.webkit.org/show_bug.cgi?id=138817
<rdar://problem/18840382>

Reviewed by Anders Carlsson.

  • Shared/mac/ActionMenuHitTestResult.h:
  • Shared/mac/ActionMenuHitTestResult.mm:

(WebKit::ActionMenuHitTestResult::encode):
(WebKit::ActionMenuHitTestResult::decode):
Store and encode a SharedMemory with the raw encoded image data,
instead of re-painting the image into a ShareableBitmap.

  • UIProcess/mac/WKActionMenuController.mm:

(-[WKActionMenuController _hitTestResultImage]):
(-[WKActionMenuController _defaultMenuItemsForImage]):
(-[WKActionMenuController _copyImage:]):
(-[WKActionMenuController _addImageToPhotos:]):
(-[WKActionMenuController _defaultMenuItems]):
(-[WKActionMenuController _canAddMediaToPhotos]): Deleted.
Build a temporary filename from a UUID and the image's desired extension.
Use the Image's encoded data instead of re-encoding it with CGImageDestination.
Build an image menu only if we have an image, URL, data, and extension.

  • WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::performActionMenuHitTestAtLocation):

  • WebView/WebActionMenuController.mm:

(-[WebActionMenuController _defaultMenuItemsForImage:]):
(-[WebActionMenuController _addImageToPhotos:]):
Build a temporary filename from a UUID and the image's desired extension.
Use the Image's encoded data instead of re-encoding it with CGImageDestination.
Build an image menu only if we have an image, URL, data, and extension.

2:51 PM Changeset in webkit [176287] by hyatt@apple.com
  • 3 edits
    2 adds in trunk

REGRESSION(r152313): Inline-block element doesn't wrap properly
​https://bugs.webkit.org/show_bug.cgi?id=138846 - <rdar://problem/18838703>

Reviewed by Simon Fraser.

Source/WebCore:

Added fast/inline-block/inline-block-empty-spans.html

  • rendering/line/BreakingContextInlineHeaders.h:

(WebCore::BreakingContext::canBreakAtThisPosition):

LayoutTests:

  • fast/inline-block/inline-block-empty-spans-expected.html: Added.
  • fast/inline-block/inline-block-empty-spans.html: Added.
2:45 PM Changeset in webkit [176286] by rniwa@webkit.org
  • 2 edits in branches/safari-600.2-branch/LayoutTests

Add test expectations.

  • platform/mac/TestExpectations:
2:40 PM Changeset in webkit [176285] by mmaxfield@apple.com
  • 3 edits
    2 adds in trunk

Multicolumn layout with negative line spacing and orphans causes pieces of letters to be shown at the bottom of columns
​https://bugs.webkit.org/show_bug.cgi?id=138204

Source/WebCore:

Reviewed by Dave Hyatt.

This code is responsible for pushing block elements to the next column if
the "orphans" CSS property is triggered. The mechanism by which this is
achieved is to push the block down such that the origin of the block is
at the origin of the next column. However, if there is negative line
spacing, the top portion of the text might actually be on top of the
origin of the block. Therefore, the block wasn't being pushed down enough
to entirely contain its text, so the top pieces were being drawn on the
previous column.

Test: fast/multicol/orphans-negative-line-spacing.html

  • rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::adjustLinePositionForPagination):

LayoutTests:

Patch by Myles C. Maxfield <​litherum@gmail.com> on 2014-11-18
Reviewed by Dave Hyatt.

Create a layout where the "orphans" css property causes a block element to
be pushed to the next column.

  • fast/multicol/orphans-negative-line-spacing-expected.html: Added.
  • fast/multicol/orphans-negative-line-spacing.html: Added.
2:10 PM Changeset in webkit [176284] by dburkart@apple.com
  • 6 edits in branches/safari-600.3-branch/Source

Merge r176166. rdar://problem/18953982

2:10 PM Changeset in webkit [176283] by eric.carlson@apple.com
  • 5 edits in trunk/Source/WebKit2

[iOS] allow host application to opt-out of alternate fullscreen
​https://bugs.webkit.org/show_bug.cgi?id=138787

Reviewed by Sam Weinig.

"allowsAlternateFullscreen" doesn't need to be in the public WKWebView header.

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView initWithFrame:configuration:]): allowsAlternateFullscreen -> _allowsAlternateFullscreen.

  • UIProcess/API/Cocoa/WKWebViewConfiguration.h: Remove allowsAlternateFullscreen.
  • UIProcess/API/Cocoa/WKWebViewConfiguration.mm:

(-[WKWebViewConfiguration _allowsAlternateFullscreen]): New.
(-[WKWebViewConfiguration _setAllowsAlternateFullscreen:]): New.

  • UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h: Declare _allowsAlternateFullscreen.
2:05 PM Changeset in webkit [176282] by Chris Dumez
  • 3 edits
    2 adds in trunk

DOMTimers sometimes don't get unthrottled on scrolling
​https://bugs.webkit.org/show_bug.cgi?id=138838

Reviewed by Antti Koivisto.

Source/WebCore:

DOMTimers sometimes didn't get unthrottled on scrolling. This is
because we stopped listening for viewport changes every time the
timer fires, but we didn't listen for those changes again if we
decided the timer should stay throttled after the timer's action
was executed.

We should listen for viewport changes again after executing the
timer's action, if there are elements outside the viewport causing
the DOMTimer to be throttled, even if the throttleState hasn't
changed (i.e the timer stays throttled).

Test: fast/dom/timer-unthrottle-on-scroll.html

  • page/DOMTimer.cpp:

(WebCore::DOMTimer::updateThrottlingStateIfNecessary):
(WebCore::DOMTimer::updateTimerIntervalIfNecessary):
(WebCore::DOMTimer::updateThrottlingStateAfterViewportChange):

LayoutTests:

Add a layout test to verify that DOMTimers get unthrottled on scroll if
the element whose style they are changing is inside the viewport after
the scroll.

  • fast/dom/timer-unthrottle-on-scroll-expected.txt: Added.
  • fast/dom/timer-unthrottle-on-scroll.html: Added.
1:28 PM Changeset in webkit [176281] by dburkart@apple.com
  • 28 edits
    1 copy in branches/safari-600.3-branch/Source

Merge r176164. rdar://problem/18953982

1:01 PM Changeset in webkit [176280] by dburkart@apple.com
  • 21 edits in branches/safari-600.3-branch/Source

Merge r176108. rdar://problem/19005904

12:59 PM Changeset in webkit [176279] by Csaba Osztrogonác
  • 4 edits in trunk/Tools

Remove the WinCairo buildbot
​https://bugs.webkit.org/show_bug.cgi?id=138805

Reviewed by Alex Christensen.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
  • BuildSlaveSupport/build.webkit.org-config/master.cfg:

(appendCustomBuildFlags):

  • BuildSlaveSupport/test-result-archive:

(archiveTestResults):

12:56 PM Changeset in webkit [176278] by dbates@webkit.org
  • 8 edits in trunk/Source/WebCore

[iOS] Make WebCore build and link with public SDK
​https://bugs.webkit.org/show_bug.cgi?id=136487

Patch by Daniel Bates <​dbates@webkit.org> on 2014-11-18
Reviewed by David Kilzer.

  • bindings/objc/DOMInternal.mm: Include header NSMapTableSPI.h.
  • bindings/objc/WebScriptObject.mm: Ditto; Also fix style nit, substitute

#import for #include when importing header WTFString.h.

  • bridge/objc/objc_instance.mm: Include header NSMapTableSPI.h and remove

#import NSMapTable.h as the former will import the latter.

  • platform/ios/PlatformEventFactoryIOS.mm: Include header wtf/CurrentTime.h

for the declaration of WTF::currentTime().

  • platform/ios/wak/WebCoreThread.mm: Remove unnecessary include of header CoreFoundation/CFPriv.h.
  • platform/spi/ios/AVKitSPI.h: Add more SPI.
  • platform/spi/ios/MPAVRoutingControllerSPI.h: Ditto.
12:12 PM Changeset in webkit [176277] by rniwa@webkit.org
  • 2 edits in trunk/Websites/perf.webkit.org

Unreviewed. Updated the install instruction.

  • Install.md:
12:04 PM Changeset in webkit [176276] by mmaxfield@apple.com
  • 21 edits
    1 copy
    1 add in trunk/Source

Subclass CachedFont for SVG fonts
​https://bugs.webkit.org/show_bug.cgi?id=138686

Reviewed by Simon Fraser.

Re-landing due to flakey bots.

Source/WebCore:

CachedFont had many #if ENABLE(SVG_FONTS) scattered throughout it.
Splitting out this SVG-specific code into a subclass of CachedFont
cleans up the design.

No new tests because there is no behavior change.

  • CMakeLists.txt:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSFontFaceSource.cpp:

(WebCore::CSSFontFaceSource::getFontData): There are two sections
in this function; one for SVG fonts and one for regular fonts.
I've moved these two sections into CachedFont and SVGCachedFont,
thereby simplifying this function.
(WebCore::CSSFontFaceSource::ensureFontData): Ditto.
(WebCore::CSSFontFaceSource::svgFontFaceElement): Moved to header.
(WebCore::CSSFontFaceSource::setSVGFontFaceElement): Ditto.
(WebCore::CSSFontFaceSource::isSVGFontFaceSource): Ditto.

  • css/CSSFontFaceSource.h: Put functions that are simple enough to

be inlined here.

  • css/CSSFontFaceSrcValue.cpp:

(WebCore::CSSFontFaceSrcValue::isSVGFontTarget): Convenience
function.
(WebCore::CSSFontFaceSrcValue::cachedFont): Pass through a boolean
from CSSFontSelector to CachedResourceHandle regarding if we should
be using SVGCachedFont instead of CachedFont.

  • css/CSSFontFaceSrcValue.h: New convenience function.
  • css/CSSFontSelector.cpp:

(WebCore::CSSFontSelector::addFontFaceRule): Pass through a boolean

  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::cachedResourceType): Update for new
CachedResource type
(WebCore::cachedResourcesForFrame): Ditto.

  • loader/cache/CachedFont.cpp:

(WebCore::CachedFont::CachedFont):
(WebCore::CachedFont::ensureCustomFontData): Taken from
CSSFontFaceSource::getFontData()
(WebCore::CachedFont::getFontData): Ditto.
(WebCore::CachedFont::platformDataFromCustomData): Ditto.
(WebCore::CachedFont::ensureSVGFontData): Moved to SVGCachedFont.
(WebCore::CachedFont::getSVGFontById): Ditto.

  • loader/cache/CachedFont.h:
  • loader/cache/CachedResource.cpp:

(WebCore::defaultPriorityForResourceType): Update for new enum
type.

  • loader/cache/CachedResource.h:
  • loader/cache/CachedResourceLoader.cpp:

(WebCore::createResource): Takes new boolean.
(WebCore::CachedResourceLoader::requestFont): Ditto.
(WebCore::CachedResourceLoader::checkInsecureContent): Update for
new enum type
(WebCore::CachedResourceLoader::canRequest): Ditto.

  • loader/cache/CachedResourceLoader.h:
  • loader/cache/CachedSVGFont.cpp: Added.

(WebCore::CachedSVGFont::CachedSVGFont): Moved from
CSSFontFaceSource::getFontData() and CachedFont
(WebCore::CachedSVGFont::getFontData): Ditto.
(WebCore::CachedSVGFont::platformDataFromCustomData): Ditto.
(WebCore::CachedSVGFont::ensureCustomFontData): Ditto.
(WebCore::CachedSVGFont::getSVGFontById): Ditto.
(WebCore::CachedSVGFont::firstFontFace): Ditto.

  • loader/cache/CachedSVGFont.h: Subclass CachedFont.
  • loader/cache/MemoryCache.cpp:

(WebCore::MemoryCache::getStatistics): Update for new enum.

  • svg/SVGFontFaceUriElement.cpp:

(WebCore::isSVGFontTarget): Convenience function.
(WebCore::SVGFontFaceUriElement::loadFont): Update for new
boolean.

Source/WebKit2:

Update for enum type.

  • WebProcess/Network/WebResourceLoadScheduler.cpp:

(WebKit::maximumBufferingTime):

11:56 AM Changeset in webkit [176275] by Chris Dumez
  • 21 edits in trunk/Source

Update the Vector API to deal with unsigned types instead of size_t
​https://bugs.webkit.org/show_bug.cgi?id=138824

Reviewed by Andreas Kling.

Source/JavaScriptCore:

Update code base to fix build errors related to the typing changes
in the Vector API (size_t -> unsigned).

  • bytecode/PreciseJumpTargets.cpp:
  • replay/EncodedValue.h:

Source/WebCore:

Update code base to fix build errors related to the typing changes
in the Vector API (size_t -> unsigned).

No new tests, no behavior change.

  • WebCore.exp.in:
  • bindings/js/JSDOMBinding.h:

(WebCore::jsArray):

  • bindings/js/JSWebGLRenderingContextCustom.cpp:
  • cssjit/SelectorCompiler.cpp:
  • html/HTMLFormElement.cpp:

(WebCore::removeFromVector):

  • html/parser/HTMLParserIdioms.h:
  • html/parser/XSSAuditor.cpp:

Source/WebKit2:

Update code base to fix build errors related to the typing changes
in the Vector API (size_t -> unsigned).

  • Platform/IPC/ArgumentCoders.h:
  • Platform/IPC/DataReference.h:

Source/WTF:

Update part of the Vector API to deal with unsigned types instead of
size_t. The Vector class is already using unsigned type for its
capacity and size data members. However, the Vector API was never
updated accordingly.

The rest of the Vector API will be ported in follow-up patches to
make the change smaller and more easily reviewable.

  • wtf/Forward.h:
  • wtf/Vector.h:

(WTF::VectorTypeOperations::compare):
(WTF::VectorBufferBase::allocateBuffer):
(WTF::VectorBufferBase::tryAllocateBuffer):
(WTF::VectorBufferBase::shouldReallocateBuffer):
(WTF::VectorBufferBase::reallocateBuffer):
(WTF::VectorBufferBase::capacity):
(WTF::VectorBufferBase::VectorBufferBase):
(WTF::VectorBuffer::VectorBuffer):
(WTF::VectorBuffer::allocateBuffer):
(WTF::VectorBuffer::tryAllocateBuffer):
(WTF::VectorBuffer::shouldReallocateBuffer):
(WTF::VectorBuffer::reallocateBuffer):
(WTF::VectorBuffer::swap):
(WTF::VectorBuffer::swapInlineBuffer):
(WTF::VectorBuffer::swapInlineBuffers):
(WTF::Vector::Vector):
(WTF::Vector::at):
(WTF::Vector::operator[]):
(WTF::OverflowHandler>::find):
(WTF::OverflowHandler>::reverseFind):
(WTF::OverflowHandler>::fill):
(WTF::OverflowHandler>::expandCapacity):
(WTF::OverflowHandler>::tryExpandCapacity):
(WTF::OverflowHandler>::resize):
(WTF::OverflowHandler>::resizeToFit):
(WTF::OverflowHandler>::shrink):
(WTF::OverflowHandler>::grow):
(WTF::OverflowHandler>::reserveCapacity):
(WTF::OverflowHandler>::tryReserveCapacity):
(WTF::OverflowHandler>::reserveInitialCapacity):
(WTF::OverflowHandler>::shrinkCapacity):
(WTF::OverflowHandler>::append):
(WTF::OverflowHandler>::tryAppend):
(WTF::OverflowHandler>::insert):
(WTF::OverflowHandler>::insertVector):
(WTF::OverflowHandler>::remove):
(WTF::OverflowHandler>::reverse):
(WTF::OverflowHandler>::checkConsistency):

  • wtf/text/AtomicString.h:
  • wtf/text/StringImpl.h:

(WTF::StringImpl::adopt):
(WTF::equalIgnoringNullity):

  • wtf/text/StringView.h:

(WTF::append):

  • wtf/text/WTFString.h:
11:32 AM Changeset in webkit [176274] by mmaxfield@apple.com
  • 1 edit in trunk/Source/WebCore/ChangeLog

Unreviewed iOS build fix

  • platform/graphics/ios/SimpleFontDataIOS.mm:

(WebCore::SimpleFontData::platformInit):

11:31 AM Changeset in webkit [176273] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

iOS build fix.

  • platform/graphics/ios/SimpleFontDataIOS.mm:

(WebCore::SimpleFontData::platformInit):

11:31 AM Changeset in webkit [176272] by matthew_hanson@apple.com
  • 1 edit
    2 adds in branches/safari-600.2-branch/LayoutTests

Merge missing layout tests which were added to trunk in r175197.
rdar://problem/18976843

  • css3/infinite-word-spacing-expected.txt: Added.
  • css3/infinite-word-spacing.html: Added.
11:24 AM Changeset in webkit [176271] by matthew_hanson@apple.com
  • 1 edit
    2 adds in branches/safari-600.3-branch/LayoutTests

Merge missing layout tests which were added to trunk in r175197.
rdar://problem/18976843

  • css3/infinite-word-spacing-expected.txt: Added.
  • css3/infinite-word-spacing.html: Added.
11:14 AM Changeset in webkit [176270] by dburkart@apple.com
  • 2 edits in branches/safari-600.3-branch/Source/WebCore

Merge r175765. rdar://problem/19005917

11:10 AM Changeset in webkit [176269] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WTF

[WinCairo] Compile errors when GStreamer is enabled.
​https://bugs.webkit.org/show_bug.cgi?id=137000

Patch by ​peavo@outlook.com <​peavo@outlook.com> on 2014-11-18
Reviewed by Philippe Normand.

MSVC does not allow the keyword default on move constructors and move assignment operators.

  • wtf/gobject/GMainLoopSource.cpp:

(WTF::GMainLoopSource::cancel):
(WTF::GMainLoopSource::socketCallback):

  • wtf/gobject/GMainLoopSource.h:

(WTF::GMainLoopSource::Context::operator=):

11:08 AM Changeset in webkit [176268] by dburkart@apple.com
  • 4 edits in branches/safari-600.3-branch/Source/WebInspectorUI

Merge r175763. rdar://problem/19005901

10:52 AM Changeset in webkit [176267] by commit-queue@webkit.org
  • 21 edits
    2 deletes in trunk/Source

Unreviewed, rolling out r176264.
​https://bugs.webkit.org/show_bug.cgi?id=138837

caused many test failures (Requested by litherum on #webkit).

Reverted changeset:

"Subclass CachedFont for SVG fonts"
​https://bugs.webkit.org/show_bug.cgi?id=138686
​http://trac.webkit.org/changeset/176264

10:14 AM Changeset in webkit [176266] by commit-queue@webkit.org
  • 4 edits in trunk/Source/JavaScriptCore

Unreviewed, rolling out r176207.
​https://bugs.webkit.org/show_bug.cgi?id=138836

Not ready yet (Requested by ap on #webkit).

Reverted changeset:

"Update WebKit to build with LLVM TOT"
​https://bugs.webkit.org/show_bug.cgi?id=138519
​http://trac.webkit.org/changeset/176207

10:05 AM Changeset in webkit [176265] by dbates@webkit.org
  • 15 edits
    6 copies in trunk

[iOS] Libdispatch, Dyld, IOKit, Mach, NSPointerFunctions, MobileGestalt
SPI are not available in public SDK
​https://bugs.webkit.org/show_bug.cgi?id=138802

Reviewed by David Kilzer.

Source/WebCore:

Add SPI wrapper headers {Dispatch, DynamicLinker, IOPMLib, MachVM, NSPointerFunctions, MobileGestalt}SPI.h
that forward declare applicable libdispatch, dyld, IOKit, mach, Foundation, MobileGestalt SPI
and use these headers instead of the including private headers corresponding to these libraries/frameworks.

  • WebCore.xcodeproj/project.pbxproj: Add private headers MobileGestaltSPI.h and

MachVMSPI.h, and project headers DynamicLinkerSPI.h, NSPointerFunctionsSPI.h,
DispatchSPI.h and IOPMLibSPI.h. Also, sort files in Xcode project.

  • bindings/objc/DOMInternal.mm: Include header NSPointerFunctionsSPI.h.
  • bridge/objc/objc_instance.mm: Ditto; Also, sort #import directives.
  • platform/cocoa/DisplaySleepDisablerCocoa.cpp: Substitute header IOPMLibSPI.h

for private header IOKit/pwr_mgt/IOPMLib.h.

  • platform/cocoa/MemoryPressureHandlerCocoa.mm: Substitute header DispatchSPI.h

for private header dispatch/private.h.

  • platform/graphics/ios/FontServicesIOS.mm: Substitute header DynamicLinkerSPI.h

for private header mach-o/dyld_priv.h.

  • platform/ios/PlatformScreenIOS.mm: Substitute header MobileGestaltSPI.h for

private header MobileGestalt.h.

  • platform/spi/cocoa/DispatchSPI.h: Added.
  • platform/spi/cocoa/DynamicLinkerSPI.h: Added.
  • platform/spi/cocoa/IOPMLibSPI.h: Added.
  • platform/spi/cocoa/MachVMSPI.h: Added.
  • platform/spi/cocoa/NSPointerFunctionsSPI.h: Added.
  • platform/spi/ios/MobileGestaltSPI.h: Added.

Source/WebKit/mac:

Include headers DispatchSPI.h and MobileGestaltSPI.h instead of including
libdispatch and MobileGestalt headers directly.

  • WebView/WebView.mm:

Source/WebKit2:

Include headers DispatchSPI.h and MachVMSPI.h.h instead of including
libdispatch and Mach headers directly.

  • Platform/mac/SharedMemoryMac.cpp:
  • UIProcess/ios/WebMemoryPressureHandlerIOS.mm:

Tools:

Include header MachVMSPI.h instead of including the private header mach/mach_vm.h.

  • DumpRenderTree/mac/CheckedMalloc.cpp:
10:04 AM Changeset in webkit [176264] by mmaxfield@apple.com
  • 21 edits
    1 copy
    1 add in trunk/Source

Subclass CachedFont for SVG fonts
​https://bugs.webkit.org/show_bug.cgi?id=138686

Reviewed by Simon Fraser.

Source/WebCore:

CachedFont had many #if ENABLE(SVG_FONTS) scattered throughout it.
Splitting out this SVG-specific code into a subclass of CachedFont
cleans up the design.

No new tests because there is no behavior change.

  • CMakeLists.txt:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSFontFaceSource.cpp:

(WebCore::CSSFontFaceSource::getFontData): There are two sections
in this function; one for SVG fonts and one for regular fonts.
I've moved these two sections into CachedFont and SVGCachedFont,
thereby simplifying this function.
(WebCore::CSSFontFaceSource::ensureFontData): Ditto.
(WebCore::CSSFontFaceSource::svgFontFaceElement): Moved to header.
(WebCore::CSSFontFaceSource::setSVGFontFaceElement): Ditto.
(WebCore::CSSFontFaceSource::isSVGFontFaceSource): Ditto.

  • css/CSSFontFaceSource.h: Put functions that are simple enough to

be inlined here.

  • css/CSSFontFaceSrcValue.cpp:

(WebCore::CSSFontFaceSrcValue::isSVGFontTarget): Convenience
function.
(WebCore::CSSFontFaceSrcValue::cachedFont): Pass through a boolean
from CSSFontSelector to CachedResourceHandle regarding if we should
be using SVGCachedFont instead of CachedFont.

  • css/CSSFontFaceSrcValue.h: New convenience function.
  • css/CSSFontSelector.cpp:

(WebCore::CSSFontSelector::addFontFaceRule): Pass through a boolean

  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::cachedResourceType): Update for new
CachedResource type
(WebCore::cachedResourcesForFrame): Ditto.

  • loader/cache/CachedFont.cpp:

(WebCore::CachedFont::CachedFont):
(WebCore::CachedFont::ensureCustomFontData): Taken from
CSSFontFaceSource::getFontData()
(WebCore::CachedFont::getFontData): Ditto.
(WebCore::CachedFont::platformDataFromCustomData): Ditto.
(WebCore::CachedFont::ensureSVGFontData): Moved to SVGCachedFont.
(WebCore::CachedFont::getSVGFontById): Ditto.

  • loader/cache/CachedFont.h:
  • loader/cache/CachedResource.cpp:

(WebCore::defaultPriorityForResourceType): Update for new enum
type.

  • loader/cache/CachedResource.h:
  • loader/cache/CachedResourceLoader.cpp:

(WebCore::createResource): Takes new boolean.
(WebCore::CachedResourceLoader::requestFont): Ditto.
(WebCore::CachedResourceLoader::checkInsecureContent): Update for
new enum type
(WebCore::CachedResourceLoader::canRequest): Ditto.

  • loader/cache/CachedResourceLoader.h:
  • loader/cache/CachedSVGFont.cpp: Added.

(WebCore::CachedSVGFont::CachedSVGFont): Moved from
CSSFontFaceSource::getFontData() and CachedFont
(WebCore::CachedSVGFont::getFontData): Ditto.
(WebCore::CachedSVGFont::platformDataFromCustomData): Ditto.
(WebCore::CachedSVGFont::ensureCustomFontData): Ditto.
(WebCore::CachedSVGFont::getSVGFontById): Ditto.
(WebCore::CachedSVGFont::firstFontFace): Ditto.

  • loader/cache/CachedSVGFont.h: Subclass CachedFont.
  • loader/cache/MemoryCache.cpp:

(WebCore::MemoryCache::getStatistics): Update for new enum.

  • svg/SVGFontFaceUriElement.cpp:

(WebCore::isSVGFontTarget): Convenience function.
(WebCore::SVGFontFaceUriElement::loadFont): Update for new
boolean.

Source/WebKit2:

Update for enum type.

  • WebProcess/Network/WebResourceLoadScheduler.cpp:

(WebKit::maximumBufferingTime):

10:04 AM Changeset in webkit [176263] by mmaxfield@apple.com
  • 14 edits
    2 moves in trunk

Use underlining metrics from the font file
​https://bugs.webkit.org/show_bug.cgi?id=138762

Patch by Myles C. Maxfield <​litherum@gmail.com> on 2014-11-18
Reviewed by Dave Hyatt.

Source/WebCore:

Test: platform/mac/fast/css3-text/css3-text-decoration/text-decoration-thickness.html

  • platform/graphics/FontMetrics.h: Adding variables for text decoration thickness and

underline position.
(WebCore::FontMetrics::FontMetrics):
(WebCore::FontMetrics::decorationThickness):
(WebCore::FontMetrics::setDecorationThickness):
(WebCore::FontMetrics::underlinePosition):
(WebCore::FontMetrics::setUnderlinePosition):

  • platform/graphics/freetype/SimpleFontDataFreeType.cpp:

(WebCore::SimpleFontData::platformInit): Initialize new FontMetrics members.

  • platform/graphics/ios/SimpleFontDataIOS.mm:

(WebCore::SimpleFontData::platformInit): Ditto.

  • platform/graphics/mac/SimpleFontDataMac.mm:

(WebCore::SimpleFontData::platformInit): Ditto.

  • platform/graphics/win/SimpleFontDataCGWin.cpp:

(WebCore::SimpleFontData::platformInit): Ditto.

  • platform/graphics/win/SimpleFontDataCairoWin.cpp:

(WebCore::SimpleFontData::platformInit): Ditto.

  • platform/graphics/win/SimpleFontDataWin.cpp:

(WebCore::SimpleFontData::initGDIFont): Ditto.

  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::paintDecoration): Use FontMetrics data.

  • style/InlineTextBoxStyle.cpp:

(WebCore::computeUnderlineOffset): Ditto.
(WebCore::visualOverflowForDecorations): Ditto.

  • style/InlineTextBoxStyle.h:

(WebCore::textDecorationStrokeThickness): Deleted.

  • svg/SVGFontData.cpp:

(WebCore::SVGFontData::initializeFontData): Initialize new FontMetrics members.

LayoutTests:

This patch makes underline placement platform-dependent.

  • platform/mac/fast/css3-text/css3-text-decoration/text-decoration-thickness-expected.html: Renamed from LayoutTests/fast/css3-text/css3-text-decoration/text-decoration-thickness-expected.html.
  • platform/mac/fast/css3-text/css3-text-decoration/text-decoration-thickness.html: Renamed from LayoutTests/fast/css3-text/css3-text-decoration/text-decoration-thickness.html.
9:54 AM Changeset in webkit [176262] by hyatt@apple.com
  • 8 edits
    2 adds in trunk

Improve Ruby selection (getting rid of overlap and improving gap filling)
​https://bugs.webkit.org/show_bug.cgi?id=138250

Reviewed by Dean Jackson.

Source/WebCore:

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::selectionGaps):
(WebCore::RenderBlock::blockSelectionGaps):
Add Ruby text in along with the Ruby base.

  • rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::inlineSelectionGaps):
Don't let block gaps get filled in here.

  • rendering/RenderRubyBase.h:

Expose accessor to the ruby run.

  • rendering/RenderRubyText.cpp:

(WebCore::RenderRubyText::rubyRun):

  • rendering/RenderRubyText.h:

Add accessor to the ruby run.

  • rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::selectionTop):
(WebCore::RootInlineBox::selectionBottom):
Improve selectionTop and selectionBottom of ruby bases to avoid the
ruby text. Improve the selectionTop and selectionBottom of ruby texts
to fill the gap up to the previous/next line as appropriate.

LayoutTests:

Added fast/repaint/selection-ruby-rl.html

  • fast/repaint/selection-ruby-rl-expected.txt: Added.
  • fast/repaint/selection-ruby-rl.html: Added.
9:45 AM Changeset in webkit [176261] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

crypto: Use sequence<> instead of KeyUsage[] in IDL.
​https://bugs.webkit.org/show_bug.cgi?id=138823

Patch by Shivakumar JM <​shiva.jm@samsung.com> on 2014-11-18
Reviewed by Darin Adler.

Use sequence<KeyUsage> instead of KeyUsage[] in crypto IDL as per spec: ​https://dvcs.w3.org/hg/webcrypto-api/raw-file/tip/spec/
Overview.html#SubtleCrypto-method-generateKey

No new tests, no behavior change.

  • crypto/SubtleCrypto.idl:
9:21 AM Changeset in webkit [176260] by Carlos Garcia Campos
  • 2 edits in trunk/Tools

Unreviewed. Fix after /webkit2/WebKitWebView/default-context r176256.

Forgot to fix this test before landing.

  • TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:

(testWebViewDefaultContext):

8:31 AM Changeset in webkit [176259] by Philippe Normand
  • 10 edits in trunk/Source/WebCore

HRTFDatabaseLoader is not an absolute condition to run audioContext
​https://bugs.webkit.org/show_bug.cgi?id=138829

Reviewed by Jer Noble.

This patch is a port of the following Blink revision by
<​keonho07.kim@samsung.com>:
<​https://src.chromium.org/viewvc/blink?revision=167887&view=revision>

  • Modules/webaudio/AudioContext.cpp:

(WebCore::AudioContext::AudioContext):
(WebCore::AudioContext::isRunnable): Deleted.

  • Modules/webaudio/AudioContext.h:

(WebCore::AudioContext::hrtfDatabaseLoader): Deleted.

  • Modules/webaudio/AudioDestinationNode.cpp:

(WebCore::AudioDestinationNode::render):

  • Modules/webaudio/OfflineAudioDestinationNode.cpp:

(WebCore::OfflineAudioDestinationNode::offlineRender):

  • Modules/webaudio/PannerNode.cpp:

(WebCore::PannerNode::PannerNode):
(WebCore::PannerNode::process):
(WebCore::PannerNode::initialize):
(WebCore::PannerNode::setPanningModel):

  • Modules/webaudio/PannerNode.h:
  • Modules/webaudio/RealtimeAnalyser.cpp:
  • Modules/webaudio/RealtimeAnalyser.h:
  • platform/audio/HRTFDatabaseLoader.cpp:

(WebCore::HRTFDatabaseLoader::createAndLoadAsynchronouslyIfNecessary):

8:09 AM Changeset in webkit [176258] by commit-queue@webkit.org
  • 29 edits
    5 deletes in trunk

Unreviewed, rolling out r176218.
​https://bugs.webkit.org/show_bug.cgi?id=138827

seems to have caused regressions on the perf bots (Requested
by lajava on #webkit).

Reverted changeset:

"[CSS Grid Layout] Upgrade align-self and align-items parsing
to CSS 3"
​https://bugs.webkit.org/show_bug.cgi?id=133359
​http://trac.webkit.org/changeset/176218

7:24 AM Changeset in webkit [176257] by mihnea@adobe.com
  • 5 edits in trunk/LayoutTests

fast/multicol/newmulticol tests use a non-existent resource
​https://bugs.webkit.org/show_bug.cgi?id=138800

Reviewed by Andrei Bucur.

Fix path in tests.

  • fast/multicol/newmulticol/compare-with-old-impl/shrink-to-column-height-for-pagination-expected.html:
  • fast/multicol/newmulticol/compare-with-old-impl/shrink-to-column-height-for-pagination.html:
  • fast/multicol/newmulticol/float-multicol-expected.html:
  • fast/multicol/newmulticol/float-multicol.html:
6:19 AM Changeset in webkit [176256] by Carlos Garcia Campos
  • 31 edits in trunk

[GTK] Add API to create a WebKitWebContext
​https://bugs.webkit.org/show_bug.cgi?id=138826

Reviewed by Gustavo Noronha Silva.

Source/WebKit2:

We have always used a default web context without providing API to
create others. The main reason was that nobody requested it and we
haven't needed it either. The main problem of the default web
context is that you can't configure anything during
construction. This hasn't been a problem so far because all the
web context configuration we expose in the API can be configured
after construction. But now we need to expose API to allow the
user to configure the local storage directory, which is a
construct only configuration. The default web context was also a
problem for our unit tests, because sharing the same context made
it difficult to ensure tests cases are independent to each other.

  • UIProcess/API/gtk/WebKitGeolocationProvider.cpp:

(WebKitGeolocationProvider::~WebKitGeolocationProvider): Reset the
provider to avoid crashes when web context is destroyed and a new
one is created.

  • UIProcess/API/gtk/WebKitWebContext.cpp:

(webkitWebContextConstructed): Add constructed implementation to
create the WebContext and initialize it.
(webkitWebContextDispose): Detach web context clients to avoid
crashes when a client callback is called on a disposed WebKitWebContext.
(webkit_web_context_class_init): Initialize gettext, add
constructed implementation and add the pointer to the vmethods
when creating signals.
(createDefaultWebContext): Simply create a WebKitWebContext.
(webkit_web_context_new): New public method to create a WebKitWebContext.
(injectedBundleFilename): Deleted.

  • UIProcess/API/gtk/WebKitWebContext.h: Add virtual methods for

signals, so that users can inherit from WebKitWebContext and
override the virtual methods.

  • UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new symbol.

Tools:

Use a different WebKitWebContext for every test to ensure test
cases are independent to each other. Tests using DBus to
communicate with the injected bundle extension now use a unique
name for the well known DBus name.

  • TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp:

(beforeAll): Remove comment about the order of the tests and
move the success test before the failed one now that tests don't
depend on each others.

  • TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:

(beforeAll): Remove call to set the web extensions directory,
since this is now done for all test in the Test constructor.

  • TestWebKitAPI/Tests/WebKit2Gtk/TestCookieManager.cpp:

(beforeAll): Do not create a temporary directory, a temporary data
directory is now created for all tests.
(afterAll):

  • TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp:

(testWebKitDOMNodeHierarchyNavigation): Pass the web extension ID
to the web process test runner.
(testWebKitDOMNodeInsertion): Ditto.
(testWebKitDOMNodeTagNames): Ditto.
(beforeAll): Remove call to set the web extensions directory.

  • TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNodeFilter.cpp:

(runTest): Pass the web extension ID to the web process test runner.
(beforeAll): Remove call to set the web extensions directory.

  • TestWebKitAPI/Tests/WebKit2Gtk/TestDOMXPathNSResolver.cpp:

(runTest): Pass the web extension ID to the web process test runner.
(beforeAll): Remove call to set the web extensions directory.

  • TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:

(createFileAtDestination): Use Test::dataDirectory() as base dir
for temporary files.
(beforeAll): Do not create a temporary directory.
(afterAll):

  • TestWebKitAPI/Tests/WebKit2Gtk/TestFrame.cpp:

(webkitFrameTestRun): Pass the web extension ID to the web process
test runner.
(beforeAll): Remove call to set the web extensions directory.

  • TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:

(beforeAll): Remove call to set the web extensions directory.

  • TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp:

(testProcessPerWebView): Use local member instead of global variable.
(testMultiprocessWebViewCreateReadyClose): Ditto.
(beforeAll): Do not connect to initialize-web-extensions, Test now
connects to the signal for all tests and calls a virtual method
that test can override.
(afterAll):
(initializeWebExtensions): Deleted.

  • TestWebKitAPI/Tests/WebKit2Gtk/TestPrinting.cpp:

(testPrintOperationPrint): Use Test::dataDirectory() as base dir
for temporary files.
(beforeAll): Do not create a temporary directory.
(afterAll):

  • TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:

(beforeAll): Remove call to set the web extensions directory.

  • TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:

(beforeAll): Remove comment about the tests order.

  • TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp:

(testWebExtensionGetTitle): Build the DBus service name using the
web extension ID.
(testDocumentLoadedSignal): Ditto.
(testWebKitWebViewProcessCrashed): Ditto.
(testWebExtensionIsolatedWorld): Ditto.
(beforeAll): Remove initialization-user-data test, since now all
tests are passing user data to the web extension.
(testWebExtensionInitializationUserData): Deleted.
(initializeWebExtensions): Deleted.

  • TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp:

(testSetDirectory): Use the web context member inherited from Test.
(testClearDatabase): Ditto.
(testGetFaviconURI): Ditto.
(beforeAll): Do not create a temporary directory.
(afterAll):
(webkitFaviconDatabaseFinalizedCallback): Deleted.

  • TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp:

(UserContentManagerTest::UserContentManagerTest):
(beforeAll): Remove call to set the web extensions directory.

  • TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:

(testWebContextDefault): Check also that a newly create web
context is not the default web context.
(testWebContextSpellChecker): Use the web context member inherited
from Test.
(testWebContextLanguages): Ditto.

  • TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:

(methodCallCallback): Remove GetInitializationUserData method.
(webkit_web_extension_initialize_with_user_data): Always create
the DBus name using the user data provided.
(makeBusName): Deleted.

  • TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:

(webkit_web_extension_initialize_with_user_data): Create the DBus
name using the user data provided.
(webkit_web_extension_initialize): Deleted.

  • TestWebKitAPI/gtk/WebKit2Gtk/TestMain.cpp:

(Test::dataDirectory): Return the temporary data directory.
(removeNonEmptyDirectory): Also remove directories recursively.
(main): Remove the disk cache directory initialization, since this
is now done in the Test constructor.

  • TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:

(Test::initializeWebExtensionsCallback): Call the virtual method
initializeWebExtensions()
(Test::Test): Create a new WebKitWebContext and initialize it.
(Test::~Test): Disconnect initialize-web-extensions signal.
(Test::initializeWebExtensions): Set the web extensions directory
and user data.

  • TestWebKitAPI/gtk/WebKit2Gtk/WebProcessTestRunner.cpp:

(WebProcessTestRunner::~WebProcessTestRunner): Use nullptr.
(WebProcessTestRunner::runTest): Build the DBus proxy using a
unique name created with the Test web extension ID.
(WebProcessTestRunner::proxy): Deleted.

  • TestWebKitAPI/gtk/WebKit2Gtk/WebProcessTestRunner.h:
  • TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:

(WebViewTest::WebViewTest): Create the web view with the Test web
context.

  • TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h: Add optional user

content manager parameter to the constructor.

5:53 AM WebKitGTK/2.6.x edited by Ting-Wei Lan
Add another changeset which fix gtk-doc build problem on FreeBSD (diff)
5:40 AM Changeset in webkit [176255] by ChangSeok Oh
  • 2 edits
    1 add in trunk/Tools

[GTK] Mesa build fails over llvm-3.5
​https://bugs.webkit.org/show_bug.cgi?id=138825

Reviewed by Gustavo Noronha Silva.

OwningPtr.h have been removed in llvm-3.5. Instread we should use std::unique_ptr for mesa build.

  • gtk/jhbuild.modules:
  • gtk/patches/mesa-gallivm-Fix-build-after-LLVM-commit-211259.patch: Added.
4:51 AM Changeset in webkit [176254] by jdiggs@igalia.com
  • 3 edits
    2 adds in trunk

AX: [ATK] Crash getting the orientation of a MenuListOption after the MenuList was removed from the document
​https://bugs.webkit.org/show_bug.cgi?id=138727

Reviewed by Chris Fleizach.

Source/WebCore:

AccessibilityMenuListOption::elementRect() returns the value of the
grandparent MenuList, asserting that the grandparent exists with that
role. But it is possible to have an existing MenuListOption and remove
the element which had been backing that MenuList from the document.
Adding null checks prior to the assertions prevents our crashing if the
parent or grandparent was removed.

Test: platform/gtk/accessibility/combobox-descendants-orientation-crash.html

  • accessibility/AccessibilityMenuListOption.cpp:

(WebCore::AccessibilityMenuListOption::elementRect):

LayoutTests:

  • platform/gtk/accessibility/combobox-descendants-orientation-crash-expected.txt: Added.
  • platform/gtk/accessibility/combobox-descendants-orientation-crash.html: Added.
3:55 AM WebKitGTK/2.6.x edited by Carlos Garcia Campos
(diff)
3:55 AM WebKitGTK/2.6.x edited by clopez@igalia.com
(diff)
3:54 AM WebKitGTK/2.6.x edited by clopez@igalia.com
(diff)
3:49 AM Changeset in webkit [176253] by Carlos Garcia Campos
  • 3 edits in releases/WebKitGTK/webkit-2.6/Source/WebKit2

Merge r176252 - [SOUP] [GnuTLS] Don't use a SSL3.0 record version in client hello.
​https://bugs.webkit.org/show_bug.cgi?id=138794

Reviewed by Sergio Villar Senin.

It seems that following POODLE many sites incorrectly banned SSL 3.0
record packet versions. Since GnuTLS uses a SSL 3.0 record to
advertise TLS 1.2, they are effectively banning it even if it doesn't
advertise SSL 3.0. That is a server issue, but it can be worked around
by using the modifier %LATEST_RECORD_VERSION.

With this modifier, GnuTLS will use the latest TLS version record
in client hello instead of using the default SSL 3.0.

  • NetworkProcess/EntryPoint/unix/NetworkProcessMain.cpp:

(main):

  • WebProcess/EntryPoint/unix/WebProcessMain.cpp:

(main):

2:35 AM WebKitGTK/2.6.x edited by clopez@igalia.com
(diff)
2:32 AM WebKitGTK/2.4.x edited by clopez@igalia.com
(diff)
2:27 AM WebKitGTK/2.6.x edited by clopez@igalia.com
(diff)
2:26 AM WebKitGTK/2.4.x edited by clopez@igalia.com
(diff)
1:32 AM Changeset in webkit [176252] by clopez@igalia.com
  • 3 edits in trunk/Source/WebKit2

[SOUP] [GnuTLS] Don't use a SSL3.0 record version in client hello.
​https://bugs.webkit.org/show_bug.cgi?id=138794

Reviewed by Sergio Villar Senin.

It seems that following POODLE many sites incorrectly banned SSL 3.0
record packet versions. Since GnuTLS uses a SSL 3.0 record to
advertise TLS 1.2, they are effectively banning it even if it doesn't
advertise SSL 3.0. That is a server issue, but it can be worked around
by using the modifier %LATEST_RECORD_VERSION.

With this modifier, GnuTLS will use the latest TLS version record
in client hello instead of using the default SSL 3.0.

  • NetworkProcess/EntryPoint/unix/NetworkProcessMain.cpp:

(main):

  • WebProcess/EntryPoint/unix/WebProcessMain.cpp:

(main):

Note: See TracTimeline for information about the timeline view.