Timeline
Nov 23, 2014:
- 11:24 PM Changeset in webkit [176512] by
-
- 5 edits in trunk
[GTK] Add API to override the default local storage directory
https://bugs.webkit.org/show_bug.cgi?id=138828
Reviewed by Gustavo Noronha Silva.
Source/WebKit2:
Add WebKitWebContext:local-storage-directory construct-only
property. If not provided the default will be used.
- UIProcess/API/gtk/WebKitWebContext.cpp:
(webkitWebContextGetProperty):
(webkitWebContextSetProperty):
(webkitWebContextConstructed):
(webkit_web_context_class_init):
Tools:
Add test to check that the local storage directory is created at
the path given on construction.
- TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
(testWebContextConfiguration):
(beforeAll):
- TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
(Test::Test):
(Test::~Test): Deleted.
- 9:21 PM Changeset in webkit [176511] by
-
- 4 edits in trunk/Source/WebKit2
Page previews should have titles
https://bugs.webkit.org/show_bug.cgi?id=139020
Reviewed by Tim Horton.
- UIProcess/API/Cocoa/WKViewPrivate.h:
Declare -_titleForPreviewOfURL:.
- UIProcess/API/mac/WKView.mm:
(-[WKView _titleForPreviewOfURL:]):
Stub implementation.
- UIProcess/mac/WKActionMenuController.mm:
(+[WKPagePreviewViewController previewPadding]):
Account for the title height.
(-[WKPagePreviewViewController loadView]):
Set correct autoresize masks on some views; create and configure a title view that is
horizontally and vertically centered.
(-[WKActionMenuController pagePreviewViewController:titleForPreviewOfURL:]):
WKPagePreviewViewControllerDelegate method; wrap -[WKView _titleForPreviewOfURL:].
- 10:46 AM Changeset in webkit [176510] by
-
- 5 edits in trunk/Source/WebCore
Use segment vector for FlowContents
https://bugs.webkit.org/show_bug.cgi?id=139015
Reviewed by Zalan Bujtas.
And FlowContents::Segment struct and use it.
- rendering/SimpleLineLayout.cpp:
(WebCore::SimpleLineLayout::removeTrailingWhitespace):
(WebCore::SimpleLineLayout::createLineRuns):
(WebCore::SimpleLineLayout::splitRunsAtRendererBoundary):
Use segments.
If there is only one segment there is nothing to do. Bail out.
- rendering/SimpleLineLayoutFlowContents.cpp:
(WebCore::SimpleLineLayout::initializeSegments):
Move initialization to a function so m_segments can be const.
Don't add empty end segment, handle the end case in code.
(WebCore::SimpleLineLayout::FlowContents::FlowContents):
(WebCore::SimpleLineLayout::FlowContents::textWidth):
Simplify and use segments.
(WebCore::SimpleLineLayout::FlowContents::segmentForPositionSlow):
Replace hand-rolled binary search with std::lower_bounds.
(WebCore::SimpleLineLayout::FlowContents::segmentForRenderer):
(WebCore::SimpleLineLayout::FlowContents::appendNextRendererContentIfNeeded):
(WebCore::SimpleLineLayout::FlowContents::renderer): Deleted.
(WebCore::SimpleLineLayout::FlowContents::resolveRendererPositions): Deleted.
- rendering/SimpleLineLayoutFlowContents.h:
(WebCore::SimpleLineLayout::FlowContents::hasOneSegment):
(WebCore::SimpleLineLayout::FlowContents::length):
(WebCore::SimpleLineLayout::FlowContents::isEnd):
(WebCore::SimpleLineLayout::FlowContents::isEndOfContent): Deleted.
Renamed.
(WebCore::SimpleLineLayout::FlowContents::segmentForPosition):
Inline the fast path.
- rendering/SimpleLineLayoutResolver.cpp:
(WebCore::SimpleLineLayout::RunResolver::Run::text):
(WebCore::SimpleLineLayout::RunResolver::rangeForRenderer):
- 10:00 AM Changeset in webkit [176509] by
-
- 12 edits in trunk/Source
Extend WKRenderObject and WKRenderLayer with some more useful data
https://bugs.webkit.org/show_bug.cgi?id=139006
Reviewed by Sam Weinig.
Source/WebCore:
Export WebCore::RenderLayerBacking::backingStoreMemoryEstimate() const.
- WebCore.exp.in:
Source/WebKit2:
Implement WKRenderLayerGetBackingStoreMemoryEstimate,
WKRenderObjectCopyTextSnippet and WKRenderObjectGetTextLength for improved
RenderLayer and RenderTree display in clients of the C SPI.
- Shared/API/c/WKRenderLayer.cpp:
(WKRenderLayerGetBackingStoreMemoryEstimate):
- Shared/API/c/WKRenderLayer.h:
- Shared/API/c/WKRenderObject.cpp:
(WKRenderObjectCopyTextSnippet):
(WKRenderObjectGetTextLength):
- Shared/API/c/WKRenderObject.h:
- Shared/UserMessageCoders.h:
(WebKit::UserMessageEncoder::baseEncode):
(WebKit::UserMessageDecoder::baseDecode):
- Shared/WebRenderLayer.cpp:
(WebKit::WebRenderLayer::create):
(WebKit::WebRenderLayer::WebRenderLayer):
- Shared/WebRenderLayer.h:
(WebKit::WebRenderLayer::backingStoreMemoryEstimate):
- Shared/WebRenderObject.cpp:
(WebKit::WebRenderObject::create):
(WebKit::WebRenderObject::WebRenderObject):
- Shared/WebRenderObject.h:
(WebKit::WebRenderObject::textSnippet):
(WebKit::WebRenderObject::textLength):
Nov 22, 2014:
- 8:37 PM Changeset in webkit [176508] by
-
- 14 edits in trunk/Source/JavaScriptCore
Clean up OwnPtr and PassOwnPtr in some of JS classes
https://bugs.webkit.org/show_bug.cgi?id=138724
Reviewed by Filip Pizlo.
As a step to use std::unique_ptr<> and std::make_unique<>, this patch replaces
OwnPtr with std::unique_ptr<>. Besides create() factory function is removed as well.
- builtins/BuiltinExecutables.h:
(JSC::BuiltinExecutables::create): Deleted.
- bytecode/CodeBlock.h:
(JSC::CodeBlock::createRareDataIfNecessary):
- bytecode/StructureStubInfo.h:
- bytecode/UnlinkedCodeBlock.h:
(JSC::UnlinkedCodeBlock::hasRareData):
(JSC::UnlinkedCodeBlock::createRareDataIfNecessary):
- runtime/CodeCache.cpp:
(JSC::CodeCache::getGlobalCodeBlock):
- runtime/CodeCache.h:
(JSC::CodeCache::create): Deleted.
- runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::clearRareData):
- runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::createRareDataIfNeeded):
- runtime/RegExpConstructor.h:
- runtime/SmallStrings.cpp:
(JSC::SmallStrings::createSingleCharacterString):
(JSC::SmallStrings::singleCharacterStringRep):
- runtime/SmallStrings.h:
- runtime/VM.cpp:
(JSC::VM::VM):
- runtime/VM.h:
- 11:37 AM Changeset in webkit [176507] by
-
- 3 edits in trunk/Source/WebCore
Make locale part of the SimpleLineLayout::FlowContent::Style
https://bugs.webkit.org/show_bug.cgi?id=139004
Reviewed by Zalan Bujtas.
That's the only part of style not extracted out of RenderStyle in the constructor.
- rendering/SimpleLineLayoutFlowContents.cpp:
(WebCore::SimpleLineLayout::FlowContents::Style::Style):
(WebCore::SimpleLineLayout::FlowContents::FlowContents):
(WebCore::SimpleLineLayout::FlowContents::appendNextRendererContentIfNeeded):
- rendering/SimpleLineLayoutFlowContents.h:
Also remove RenderBlockFlow member since it is now unused.
(WebCore::SimpleLineLayout::FlowContents::Style::Style): Deleted.
Move to cpp.
- 11:07 AM Changeset in webkit [176506] by
-
- 2 edits in trunk/Source/JavaScriptCore
r176455: ASSERT(!m_vector.isEmpty()) in IntendedStructureChain.cpp(143)
https://bugs.webkit.org/show_bug.cgi?id=139000
Reviewed by Darin Adler.
Check that the chainCount is non-zero before using a StructureChain.
- bytecode/ComplexGetStatus.cpp:
(JSC::ComplexGetStatus::computeFor):
- 10:18 AM Changeset in webkit [176505] by
-
- 12 edits6 adds in trunk
AX: [ATK] Accessible names missing for imagemap images and links
https://bugs.webkit.org/show_bug.cgi?id=127288
Source/WebCore:
Reviewed by Chris Fleizach.
Return the alt text, if present, for the accessible name for image maps
and image map links for ATK. Also expose the accessible element with
ATK_ROLE_IMAGE_MAP instead of ATK_ROLE_IMAGE.
Test: accessibility/image-with-alt-and-map.html
- accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::isImageMap):
- accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
(webkitAccessibleGetName):
(atkRole):
LayoutTests:
New and updated tests to reflect the expected role, accessible hierarchy,
and exposure of the alternative text for each platform.
Reviewed by Chris Fleizach.
- accessibility/image-with-alt-and-map.html: Added.
- accessibility/roles-exposed.html: Added some more elements to the test.
- platform/efl/accessibility/image-map1-expected.txt: Added.
- platform/efl/accessibility/image-map2-expected.txt: Updated to reflect fix.
- platform/efl/accessibility/image-with-alt-and-map-expected.txt: Added.
- platform/efl/accessibility/roles-exposed-expected.txt: Updated for added elements.
- platform/gtk/accessibility/image-map1-expected.txt: Added.
- platform/gtk/accessibility/image-map2-expected.txt: Updated to reflect fix.
- platform/gtk/accessibility/image-with-alt-and-map-expected.txt: Added.
- platform/gtk/accessibility/roles-exposed-expected.txt: Updated for added elements.
- platform/mac/accessibility/image-with-alt-and-map-expected.txt: Added.
- platform/mac/accessibility/roles-exposed-expected.txt: Updated for added elements.
- platform/mac-mavericks/accessibility/roles-exposed-expected.txt: Updated for added elements.
- platform/mac-mountainlion/accessibility/roles-exposed-expected.txt: Updated for added elements.
- 2:11 AM Changeset in webkit [176504] by
-
- 4 edits in trunk/Source/WebCore
Remove unused Document::ignoreAutofocus().
<https://webkit.org/b/139002>
Reviewed by Antti Koivisto.
No one ever actually changes this flag, so let's remove it.
- dom/Document.cpp:
(WebCore::Document::Document):
- dom/Document.h:
(WebCore::Document::ignoreAutofocus): Deleted.
(WebCore::Document::setIgnoreAutofocus): Deleted.
- html/HTMLFormControlElement.cpp:
(WebCore::shouldAutofocus):
- 1:44 AM Changeset in webkit [176503] by
-
- 3 edits in trunk/Source/WebCore
URTBF after r176459 to fix GTK build.
- platform/ScrollAnimatorNone.cpp:
(WebCore::ScrollAnimatorNone::ScrollAnimatorNone):
(WebCore::ScrollAnimatorNone::requestAnimationTimerFired):
- platform/ScrollAnimatorNone.h:
- 1:12 AM Changeset in webkit [176502] by
-
- 207 edits in trunk/Source
Convert PassRefPtr return types to RefPtr.
<https://webkit.org/b/138995>
Reviewed by Anders Carlsson.
Convert an assortment of DOM and HTML related functions
to return RefPtr instead of PassRefPtr.
