Context Navigation

← Previous Period
Next Period →

Timeline

Nov 27, 2014:

11:04 PM Changeset in webkit [176555] by ryuan.choi@navercorp.com

10 edits
1 delete in trunk

[EFL] Remove E_Dbus dependency
https://bugs.webkit.org/show_bug.cgi?id=136355

Reviewed by Gyuyoung Kim.

Source/cmake/FindE_DBus.cmake: Removed.
Source/cmake/OptionsEfl.cmake:

Source/WebCore:

E_Dbus is the simple wrapper of Dbus but it has not been maintained since EFL 1.8.
Instead, EFL introduced Eldbus, which is almost similar with E_Dbus but provides more dbus like interface.
This patch replaces E_Dbus implementation to Eldbus.

PlatformEfl.cmake:
platform/efl/BatteryProviderEfl.cpp:

(WebCore::BatteryProviderEfl::BatteryProviderEfl):
(WebCore::BatteryProviderEfl::~BatteryProviderEfl):
(WebCore::BatteryProviderEfl::stopUpdating):
(WebCore::batteryProperties):
(WebCore::batteryPropertiesChanged):
(WebCore::BatteryProviderEfl::deviceTypeCallback):
(WebCore::BatteryProviderEfl::enumerateDevices):
(WebCore::BatteryProviderEfl::startUpdating):
(WebCore::BatteryProviderEfl::setBatteryStatus):
(WebCore::BatteryProviderEfl::timerFired): Deleted.
(WebCore::BatteryProviderEfl::getBatteryStatus): Deleted.
(WebCore::BatteryProviderEfl::setBatteryClient): Deleted.

platform/efl/BatteryProviderEfl.h:

(WebCore::BatteryProviderEfl::connection):
(WebCore::BatteryProviderEfl::setSignalHandler):
(WebCore::BatteryProviderEfl::~BatteryProviderEfl): Deleted.

Source/WebKit2:

UIProcess/API/efl/ewk_main.cpp: Added init/shutdown for eldbus.

(WebKit::EwkMain::initialize):
(WebKit::EwkMain::finalize):
(WebKit::EwkMain::shutdownInitializedEFLModules):

Tools:

MiniBrowser/efl/CMakeLists.txt: Removed E_DBUS includes.

5:40 PM Changeset in webkit [176554] by Antti Koivisto

2 edits in trunk/Source/WebCore

CrashTracer: com.apple.WebKit.WebContent at com.apple.WebCore: WebCore::HTMLPlugInImageElement::updateSnapshot + 108
https://bugs.webkit.org/show_bug.cgi?id=139057

Reviewed by Anders Carlsson.

No test, don't know how to repro.

html/HTMLPlugInImageElement.cpp:

(WebCore::HTMLPlugInImageElement::updateSnapshot): Null check the renderer.

4:51 PM Changeset in webkit [176553] by gyuyoung.kim@samsung.com

11 edits in trunk/Source/JavaScriptCore

Use std::unique_ptr instead of OwnPtr in JSC classes
https://bugs.webkit.org/show_bug.cgi?id=139009

Reviewed by Filip Pizlo.

As a step of using std::unique_ptr<>, this patch replaces OwnPtr with
std::unique_ptr<>|std::make_unique<>.

bytecode/DFGExitProfile.cpp:

(JSC::DFG::ExitProfile::add):

bytecode/DFGExitProfile.h:
bytecode/LazyOperandValueProfile.cpp:

(JSC::CompressedLazyOperandValueProfileHolder::add):

bytecode/LazyOperandValueProfile.h:
heap/MarkedBlock.cpp:

(JSC::MarkedBlock::specializedSweep):
(JSC::MarkedBlock::stopAllocating):

heap/MarkedBlock.h:

(JSC::MarkedBlock::clearNewlyAllocated):

inspector/ContentSearchUtilities.cpp:

(Inspector::ContentSearchUtilities::findMagicComment):

runtime/RegExp.cpp:

(JSC::RegExp::invalidateCode):

runtime/RegExp.h:
yarr/RegularExpression.cpp:

(JSC::Yarr::RegularExpression::Private::compile):
(JSC::Yarr::RegularExpression::isValid):

yarr/YarrInterpreter.cpp:

(JSC::Yarr::ByteCompiler::compile):
(JSC::Yarr::ByteCompiler::regexBegin):
(JSC::Yarr::byteCompile):

yarr/YarrInterpreter.h:

(JSC::Yarr::BytecodePattern::BytecodePattern):

4:24 PM Changeset in webkit [176552] by jdiggs@igalia.com

9 edits in trunk

AX: [ATK] Meter and Option elements do not expose their id attribute
https://bugs.webkit.org/show_bug.cgi?id=139017

Reviewed by Mario Sanchez Prada.

Source/WebCore:

The options in a collapsed select element lack a node, so get the id
attribute from the associated action element. In the case of a meter,
the meter element itself is not exposed; its RenderMeter is instead.
So associate the meter element's id with the exposed RenderMeter.

No new tests. Instead, updated existing expectations to reflect the fix.

accessibility/AccessibilityObject.h:
accessibility/AccessibilityProgressIndicator.cpp:

(WebCore::AccessibilityProgressIndicator::element):

accessibility/AccessibilityProgressIndicator.h:
accessibility/atk/WebKitAccessibleWrapperAtk.cpp:

(webkitAccessibleGetAttributes):

LayoutTests:

accessibility/roles-exposed.html: Unskipped the meter element test.
platform/efl/accessibility/roles-exposed-expected.txt: Updated to reflect fixes.
platform/gtk/accessibility/roles-exposed-expected.txt: Updated to reflect fixes.

10:00 AM Changeset in webkit [176551] by andersca@apple.com

5 edits
2 copies in trunk/Source/WebKit

Add a stubbed out WebVisitedLinkStore to WebViewGroup
https://bugs.webkit.org/show_bug.cgi?id=139066

Reviewed by Antti Koivisto.

Source/WebKit:

WebKit.xcodeproj/project.pbxproj:

Source/WebKit/mac:

WebCoreSupport/WebViewGroup.h:

(WebViewGroup::visitedLinkStore):

WebCoreSupport/WebViewGroup.mm:

(WebViewGroup::WebViewGroup):

WebCoreSupport/WebVisitedLinkStore.h: Copied from Source/WebKit/mac/WebCoreSupport/WebViewGroup.h.
WebCoreSupport/WebVisitedLinkStore.mm: Copied from Source/WebKit/mac/WebCoreSupport/WebViewGroup.h.

(WebVisitedLinkStore::create):
(WebVisitedLinkStore::WebVisitedLinkStore):
(WebVisitedLinkStore::~WebVisitedLinkStore):
(WebVisitedLinkStore::isLinkVisited):
(WebVisitedLinkStore::addVisitedLink):

9:58 AM Changeset in webkit [176550] by andersca@apple.com