Timeline

Nov 30, 2014:

11:36 PM Changeset in webkit [176590] by ljaehun.lim@samsung.com

• 2 edits in trunk/Source/WebKit2

[EFL] Add eldbus to the library list
​https://bugs.webkit.org/show_bug.cgi?id=139120

Reviewed by Gyuyoung Kim.

Fix undefined reference errors for eldbus APIs.

• PlatformEfl.cmake:

7:48 PM Changeset in webkit [176589] by ryuan.choi@navercorp.com

• 4 edits
  9 deletes in trunk

[EFL] Drop support for the EFL 1.7
​https://bugs.webkit.org/show_bug.cgi?id=139114

Reviewed by Gyuyoung Kim.

.:

• Source/cmake/EFLHelpers.cmake: Removed.
• Source/cmake/FindEcore.cmake: Removed.
• Source/cmake/FindEdje.cmake: Removed.
• Source/cmake/FindEet.cmake: Removed.
• Source/cmake/FindEeze.cmake: Removed.
• Source/cmake/FindEfreet.cmake: Removed.
• Source/cmake/FindEina.cmake: Removed.
• Source/cmake/FindElementary.cmake: Removed.
• Source/cmake/FindEvas.cmake: Removed.
• Source/cmake/OptionsEfl.cmake:

Source/WTF:

• wtf/efl/EflTypedefs.h: Removed old definitions which EFL 1.7 used.

4:20 PM Changeset in webkit [176588] by andersca@apple.com

• 3 edits in trunk/Source/WebKit/mac

Fix a test failure.

• History/WebHistory.mm:

(+[WebHistory _setVisitedLinkTrackingEnabled:]):
Call through to the visited link store.

(+[WebHistory _removeAllVisitedLinks]):
Ditto.

• WebCoreSupport/WebVisitedLinkStore.mm:

(WebVisitedLinkStore::isLinkVisited):
Make sure to populate visited links.

2:48 PM Changeset in webkit [176587] by andersca@apple.com

• 2 edits in trunk/Source/WebKit/mac

Switch over to the visited link store from the WebViewGroup
​https://bugs.webkit.org/show_bug.cgi?id=139112

Reviewed by Sam Weinig.

• WebView/WebView.mm:

(-[WebView _commonInitializationWithFrameName:groupName:]):
(-[WebView setGroupName:]):

2:45 PM Changeset in webkit [176586] by andersca@apple.com

• 4 edits in trunk/Source/WebKit/mac

Add WebVisitedLinkStore::removeVisitedLink and use it on iOS
​https://bugs.webkit.org/show_bug.cgi?id=139111

Reviewed by Sam Weinig.

• WebCoreSupport/WebVisitedLinkStore.h:
• WebCoreSupport/WebVisitedLinkStore.mm:

(WebVisitedLinkStore::removeVisitedLink):

• WebView/WebView.mm:

(-[WebView removeVisitedLink:]):

Nov 29, 2014:

6:36 PM Changeset in webkit [176585] by gyuyoung.kim@samsung.com

• 2 edits in trunk/Source/WebCore

Fix a build warning when CSS_SCROLL_SNAP is enabled
​https://bugs.webkit.org/show_bug.cgi?id=139084

Reviewed by Andrei Bucur.

Fix a build warning. Copy constructor of StyleScrollSnapPoints should initialize its base class.

• rendering/style/StyleScrollSnapPoints.cpp:

(WebCore::StyleScrollSnapPoints::StyleScrollSnapPoints): Call RefCounted().

4:39 PM Changeset in webkit [176584] by commit-queue@webkit.org

• 4 edits in trunk/Source/WebCore

Move the '-webkit-locale', '-webkit-text-orientation', '-webkit-writing-mode', '-webkit-justify-self' and '-webkit-perspective' CSS properties to the new StyleBuilder
​https://bugs.webkit.org/show_bug.cgi?id=139104

Patch by Sam Weinig <​sam@webkit.org> on 2014-11-29
Reviewed by Anders Carlsson.

• css/CSSPropertyNames.in:
• css/StyleBuilderCustom.h:

(WebCore::StyleBuilderFunctions::applyValueWebkitLocale):
(WebCore::StyleBuilderFunctions::applyValueWebkitWritingMode):
(WebCore::StyleBuilderFunctions::applyValueWebkitTextOrientation):
(WebCore::StyleBuilderFunctions::applyValueWebkitJustifySelf):
(WebCore::StyleBuilderFunctions::applyValueWebkitPerspective):

• css/StyleResolver.cpp:

(WebCore::StyleResolver::applyProperty):

4:06 PM Changeset in webkit [176583] by akling@apple.com

• 19 edits in trunk/Source/JavaScriptCore

PropertyTable keys should be AtomicStringImpl.
<​https://webkit.org/b/139096>

Reviewed by Sam Weinig.

Since PropertyTable keys are really always Identifiers, switch the key
type from StringImpl* to AtomicStringImpl*.

We have code in the GetByVal opcode implementations that assumes things
about this, so this change adds confidence to those algorithms.

• bytecode/ComplexGetStatus.cpp:

(JSC::ComplexGetStatus::computeFor):

• bytecode/ComplexGetStatus.h:
• bytecode/GetByIdStatus.cpp:

(JSC::GetByIdStatus::computeFromLLInt):
(JSC::GetByIdStatus::computeFor):
(JSC::GetByIdStatus::computeForStubInfo):

• bytecode/GetByIdStatus.h:
• bytecode/PutByIdStatus.cpp:

(JSC::PutByIdStatus::computeFromLLInt):
(JSC::PutByIdStatus::computeFor):
(JSC::PutByIdStatus::computeForStubInfo):

• bytecode/PutByIdStatus.h:
• dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):

• dfg/DFGDesiredIdentifiers.cpp:

(JSC::DFG::DesiredIdentifiers::addLazily):
(JSC::DFG::DesiredIdentifiers::at):

• dfg/DFGDesiredIdentifiers.h:

(JSC::DFG::DesiredIdentifiers::operator[]):

• dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::isStringPrototypeMethodSane):

• runtime/Identifier.h:

(JSC::Identifier::impl):

• runtime/IntendedStructureChain.cpp:

(JSC::IntendedStructureChain::mayInterceptStoreTo):

• runtime/IntendedStructureChain.h:
• runtime/PropertyMapHashTable.h:
• runtime/Structure.cpp:

(JSC::StructureTransitionTable::contains):
(JSC::StructureTransitionTable::get):
(JSC::Structure::addPropertyTransitionToExistingStructureImpl):
(JSC::Structure::addPropertyTransitionToExistingStructureConcurrently):
(JSC::Structure::getConcurrently):
(JSC::Structure::add):
(JSC::Structure::remove):

• runtime/Structure.h:

(JSC::PropertyMapEntry::PropertyMapEntry):

• runtime/StructureInlines.h:

(JSC::Structure::getConcurrently):

• runtime/StructureTransitionTable.h:

(JSC::StructureTransitionTable::Hash::hash):

3:40 PM Changeset in webkit [176582] by andersca@apple.com

• 5 edits in trunk/Source/WebKit/win

Switch over to using WebVisitedLinkStore on Windows
​https://bugs.webkit.org/show_bug.cgi?id=139103

Reviewed by Antti Koivisto.

• WebCoreSupport/WebChromeClient.cpp:

(WebChromeClient::populateVisitedLinks):

• WebHistory.cpp:

(WebHistory::setOptionalSharedHistory):
(WebHistory::removeAllItems):
(WebHistory::setVisitedLinkTrackingEnabled):
(WebHistory::removeAllVisitedLinks):
(WebHistory::removeItemForURLString):
(WebHistory::addVisitedLinksToVisitedLinkStore):
(WebHistory::addVisitedLinksToPageGroup): Deleted.

• WebHistory.h:
• WebView.cpp:

(WebView::initWithFrame):

2:52 PM Changeset in webkit [176581] by andersca@apple.com

• 2 edits in trunk/Source/WebKit/win

Another build fix.

• WebHistory.cpp:

(WebHistory::addVisitedLinksToVisitedLinkStore):

2:48 PM Changeset in webkit [176580] by andersca@apple.com

• 2 edits in trunk/Source/WebKit/win

Another build fix.

• WebHistory.cpp:

(WebHistory::addVisitedLinksToVisitedLinkStore):
(WebHistory::removeAllVisitedLinks): Deleted.
(WebHistory::setHistoryItemLimit): Deleted.

2:43 PM Changeset in webkit [176579] by andersca@apple.com

• 2 edits in trunk/Source/WebKit/win

Try to fix build.

• WebHistory.h:

2:23 PM Changeset in webkit [176578] by andersca@apple.com

• 6 edits in trunk/Source/WebKit/win

Stub out more of WebVisitedLinkStore on Windows
​https://bugs.webkit.org/show_bug.cgi?id=139098

Reviewed by Sam Weinig.

• WebCoreSupport/WebVisitedLinkStore.cpp:

(WebVisitedLinkStore::WebVisitedLinkStore):
Initialize m_visitedLinksPopulated to false.

(WebVisitedLinkStore::setShouldTrackVisitedLinks):
Update s_shouldTrackVisitedLinks and remove all visited links if needed.

(WebVisitedLinkStore::removeAllVisitedLinks):
Remove all hashes from our shared link store.

(WebVisitedLinkStore::addVisitedLink):
Compute the visited link hash and add it to the store.

(WebVisitedLinkStore::isLinkVisited):
Populate visited links and then look up the hash in our hash map.

(WebVisitedLinkStore::populateVisitedLinksIfNeeded):
Call out to the history delegate or populate visited links from shared history.

(WebVisitedLinkStore::addVisitedLinkHash):
Add the hash if we're tracking hashes.

(WebVisitedLinkStore::removeVisitedLinkHashes):
Clear the map.

• WebCoreSupport/WebVisitedLinkStore.h:

Add members.

• WebHistory.cpp:

(WebHistory::addVisitedLinksToVisitedLinkStore):
New function that adds visited links from the history to a given store.

• WebHistory.h:

Add new member.

• WebView.cpp:

(WebView::addVisitedLinks):
Add links to the visited link store as well.

2:17 PM Changeset in webkit [176577] by andersca@apple.com

• 3 edits in trunk/Source/WebCore

Add an EmptyVisitedLinkStore implementation
​https://bugs.webkit.org/show_bug.cgi?id=139102

Reviewed by Sam Weinig.

• loader/EmptyClients.cpp:

(WebCore::fillWithEmptyClients):

• loader/EmptyClients.h:

2:11 PM Changeset in webkit [176576] by andersca@apple.com

• 6 edits in trunk/Source/WebKit/mac

Populate visited links
​https://bugs.webkit.org/show_bug.cgi?id=139101

Reviewed by Sam Weinig.

• History/WebHistory.mm:

(-[WebHistoryPrivate addVisitedLinksToVisitedLinkStore:]):
Helper function that adds all visited link to the given store.

(-[WebHistory _addVisitedLinksToVisitedLinkStore:]):
Call the private method.

• History/WebHistoryInternal.h:
• WebCoreSupport/WebVisitedLinkStore.h:

Add new members.

• WebCoreSupport/WebVisitedLinkStore.mm:

(WebVisitedLinkStore::addVisitedLink):
Get the characters from the URL string and hash them, then call addVisitedLinkHash.

(WebVisitedLinkStore::populateVisitedLinksIfNeeded):
Implement this. First try the delegate, then try the shared history.

(WebVisitedLinkStore::addVisitedLinkHash):
Factor code that adds the link to the hash table into a separate function.

• WebView/WebView.mm:

(-[WebView addVisitedLinks:]):
Add the visited links to the store.

1:49 PM Changeset in webkit [176575] by andersca@apple.com

• 4 edits in trunk/Source/WebKit/mac

More work on the legacy WebKit visited link store
​https://bugs.webkit.org/show_bug.cgi?id=139100

Reviewed by Sam Weinig.

• History/WebHistory.mm:

(+[WebHistory setOptionalSharedHistory:]):
Call WebVisitedLinkStore::setShouldTrackVisitedLinks and WebVisitedLinkStore::removeAllVisitedLinks.

• WebCoreSupport/WebVisitedLinkStore.h:
• WebCoreSupport/WebVisitedLinkStore.mm:

(visitedLinkStores):
(WebVisitedLinkStore::WebVisitedLinkStore):
(WebVisitedLinkStore::~WebVisitedLinkStore):
Keep track of live visited link stores.

(WebVisitedLinkStore::setShouldTrackVisitedLinks):
Update s_shouldTrackVisitedLinks and call removeAllVisitedLinks if necessary.

(WebVisitedLinkStore::removeAllVisitedLinks):
Iterate over all live link stores and remove their links.

(WebVisitedLinkStore::isLinkVisited):
Populate visited links and check if our hash table contains the link.

(WebVisitedLinkStore::addVisitedLink):
Add the link hash to the table.

(WebVisitedLinkStore::populateVisitedLinksIfNeeded):
Add stub.

(WebVisitedLinkStore::removeVisitedLinkHashes):
Clear out the hash table.

1:12 PM Changeset in webkit [176574] by andersca@apple.com

• 6 edits
  2 adds in trunk

Crash when calling WKPageClose on the originated page from within createNewPage callback
​https://bugs.webkit.org/show_bug.cgi?id=139099
<rdar://problem/19052564>

Reviewed by Sam Weinig.

Source/WebKit2:

Null check the namespace ID.

• UIProcess/Storage/StorageManager.cpp:

(WebKit::StorageManager::cloneSessionStorageNamespaceInternal):

Tools:

Add a test.

• TestWebKitAPI/PlatformWebView.h:
• TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
• TestWebKitAPI/Tests/WebKit2/CloseFromWithinCreatePage.cpp: Added.

(TestWebKitAPI::runJavaScriptAlert):
(TestWebKitAPI::createNewPage):
(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/WebKit2/close-from-within-create-page.html: Added.
• TestWebKitAPI/mac/PlatformWebViewMac.mm:

(TestWebKitAPI::PlatformWebView::PlatformWebView):

9:47 AM Changeset in webkit [176573] by andersca@apple.com

• 3 edits
  2 adds in trunk/Source/WebKit

Add a stubbed out WebVisitedLinkStore class on Windows
​https://bugs.webkit.org/show_bug.cgi?id=139078

Reviewed by Sam Weinig.

Source/WebKit:

• WebKit.vcxproj/WebKit/WebKit.vcxproj:

Source/WebKit/win:

• WebCoreSupport/WebVisitedLinkStore.cpp: Added.

(WebVisitedLinkStore::shared):
(WebVisitedLinkStore::WebVisitedLinkStore):
(WebVisitedLinkStore::~WebVisitedLinkStore):
(WebVisitedLinkStore::isLinkVisited):
(WebVisitedLinkStore::addVisitedLink):

• WebCoreSupport/WebVisitedLinkStore.h: Added.