⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Dec 4, 2014:

11:46 PM Changeset in webkit [176838] by mrowe@apple.com
  • 3 edits in trunk/Source/WebCore

Fix pre-Yosemite builds.

The #ifs in two SPI wrapper headers were incorrect, resulting in code being included
prior to Yosemite that required Yosemite to compile.

  • platform/spi/mac/NSSharingServicePickerSPI.h:
  • platform/spi/mac/NSSharingServiceSPI.h:
10:58 PM Changeset in webkit [176837] by mrowe@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Build fix after r176836.

Reviewed by Mark Lam.

  • runtime/VM.h:

(JSC::VM::controlFlowProfiler): Don't try to export an inline function.
Doing so results in a weak external symbol being generated.

9:58 PM Changeset in webkit [176836] by saambarati1@gmail.com
  • 47 edits
    4 adds in trunk/Source/JavaScriptCore

JavaScript Control Flow Profiler
​https://bugs.webkit.org/show_bug.cgi?id=137785

Reviewed by Filip Pizlo.

This patch introduces a mechanism for JavaScriptCore to profile
which basic blocks have executed. This mechanism will then be
used by the Web Inspector to indicate which basic blocks
have and have not executed.

The profiling works by compiling in an op_profile_control_flow
at the start of every basic block. Then, whenever this op code
executes, we know that a particular basic block has executed.

When we tier up a CodeBlock that contains an op_profile_control_flow
that corresponds to an already executed basic block, we don't
have to emit code for that particular op_profile_control_flow
because the internal data structures used to keep track of
basic block locations has already recorded that the corresponding
op_profile_control_flow has executed.

  • CMakeLists.txt:
  • JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
  • JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • bytecode/BytecodeList.json:
  • bytecode/BytecodeUseDef.h:

(JSC::computeUsesForBytecodeOffset):
(JSC::computeDefsForBytecodeOffset):

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dumpBytecode):
(JSC::CodeBlock::CodeBlock):

  • bytecode/Instruction.h:
  • bytecode/UnlinkedCodeBlock.cpp:

(JSC::UnlinkedFunctionExecutable::UnlinkedFunctionExecutable):

  • bytecode/UnlinkedCodeBlock.h:

(JSC::UnlinkedCodeBlock::addOpProfileControlFlowBytecodeOffset):
(JSC::UnlinkedCodeBlock::opProfileControlFlowBytecodeOffsets):

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitProfileControlFlow):

  • bytecompiler/BytecodeGenerator.h:
  • bytecompiler/NodesCodegen.cpp:

(JSC::ConditionalNode::emitBytecode):
(JSC::IfElseNode::emitBytecode):
(JSC::WhileNode::emitBytecode):
(JSC::ForNode::emitBytecode):
(JSC::ContinueNode::emitBytecode):
(JSC::BreakNode::emitBytecode):
(JSC::ReturnNode::emitBytecode):
(JSC::CaseClauseNode::emitBytecode):
(JSC::SwitchNode::emitBytecode):
(JSC::ThrowNode::emitBytecode):
(JSC::TryNode::emitBytecode):
(JSC::ProgramNode::emitBytecode):
(JSC::FunctionNode::emitBytecode):

  • dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGCapabilities.cpp:

(JSC::DFG::capabilityLevel):

  • dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

  • dfg/DFGDoesGC.cpp:

(JSC::DFG::doesGC):

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

  • dfg/DFGNode.h:

(JSC::DFG::Node::basicBlockLocation):

  • dfg/DFGNodeType.h:
  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):

  • dfg/DFGSafeToExecute.h:

(JSC::DFG::safeToExecute):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • inspector/agents/InspectorRuntimeAgent.cpp:

(Inspector::InspectorRuntimeAgent::getRuntimeTypesForVariablesAtOffsets):

  • jit/JIT.cpp:

(JSC::JIT::privateCompileMainPass):

  • jit/JIT.h:
  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_profile_control_flow):

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_profile_control_flow):

  • jsc.cpp:

(GlobalObject::finishCreation):
(functionFindTypeForExpression):
(functionReturnTypeFor):
(functionDumpBasicBlockExecutionRanges):

  • llint/LowLevelInterpreter.asm:
  • parser/ASTBuilder.h:

(JSC::ASTBuilder::createFunctionExpr):
(JSC::ASTBuilder::createGetterOrSetterProperty):
(JSC::ASTBuilder::createFuncDeclStatement):
(JSC::ASTBuilder::endOffset):
(JSC::ASTBuilder::setStartOffset):

  • parser/NodeConstructors.h:

(JSC::Node::Node):

  • parser/Nodes.h:

(JSC::CaseClauseNode::setStartOffset):

  • parser/Parser.cpp:

(JSC::Parser<LexerType>::parseSwitchClauses):
(JSC::Parser<LexerType>::parseSwitchDefaultClause):
(JSC::Parser<LexerType>::parseBlockStatement):
(JSC::Parser<LexerType>::parseStatement):
(JSC::Parser<LexerType>::parseFunctionDeclaration):
(JSC::Parser<LexerType>::parseIfStatement):
(JSC::Parser<LexerType>::parseExpression):
(JSC::Parser<LexerType>::parseConditionalExpression):
(JSC::Parser<LexerType>::parseProperty):
(JSC::Parser<LexerType>::parseMemberExpression):

  • parser/SyntaxChecker.h:

(JSC::SyntaxChecker::createFunctionExpr):
(JSC::SyntaxChecker::createFuncDeclStatement):
(JSC::SyntaxChecker::createGetterOrSetterProperty):
(JSC::SyntaxChecker::operatorStackPop):

  • runtime/BasicBlockLocation.cpp: Added.

(JSC::BasicBlockLocation::BasicBlockLocation):
(JSC::BasicBlockLocation::insertGap):
(JSC::BasicBlockLocation::getExecutedRanges):
(JSC::BasicBlockLocation::dumpData):
(JSC::BasicBlockLocation::emitExecuteCode):

  • runtime/BasicBlockLocation.h: Added.

(JSC::BasicBlockLocation::startOffset):
(JSC::BasicBlockLocation::endOffset):
(JSC::BasicBlockLocation::setStartOffset):
(JSC::BasicBlockLocation::setEndOffset):
(JSC::BasicBlockLocation::hasExecuted):

  • runtime/CodeCache.cpp:

(JSC::CodeCache::getGlobalCodeBlock):

  • runtime/ControlFlowProfiler.cpp: Added.

(JSC::ControlFlowProfiler::~ControlFlowProfiler):
(JSC::ControlFlowProfiler::getBasicBlockLocation):
(JSC::ControlFlowProfiler::dumpData):
(JSC::ControlFlowProfiler::getBasicBlocksForSourceID):

  • runtime/ControlFlowProfiler.h: Added. This class is in

charge of generating BasicBlockLocations and also
providing an interface that the Web Inspector can use to ping
which basic blocks have executed based on the source id of a script.

(JSC::BasicBlockKey::BasicBlockKey):
(JSC::BasicBlockKey::isHashTableDeletedValue):
(JSC::BasicBlockKey::operator==):
(JSC::BasicBlockKey::hash):
(JSC::BasicBlockKeyHash::hash):
(JSC::BasicBlockKeyHash::equal):

  • runtime/Executable.cpp:

(JSC::ProgramExecutable::ProgramExecutable):
(JSC::ProgramExecutable::initializeGlobalProperties):

  • runtime/FunctionHasExecutedCache.cpp:

(JSC::FunctionHasExecutedCache::getUnexecutedFunctionRanges):

  • runtime/FunctionHasExecutedCache.h:
  • runtime/Options.h:
  • runtime/TypeProfiler.cpp:

(JSC::TypeProfiler::logTypesForTypeLocation):
(JSC::TypeProfiler::typeInformationForExpressionAtOffset):
(JSC::TypeProfiler::findLocation):
(JSC::TypeProfiler::dumpTypeProfilerData):

  • runtime/TypeProfiler.h:

(JSC::TypeProfiler::functionHasExecutedCache): Deleted.

  • runtime/VM.cpp:

(JSC::VM::VM):
(JSC::enableProfilerWithRespectToCount):
(JSC::disableProfilerWithRespectToCount):
(JSC::VM::enableTypeProfiler):
(JSC::VM::disableTypeProfiler):
(JSC::VM::enableControlFlowProfiler):
(JSC::VM::disableControlFlowProfiler):
(JSC::VM::dumpTypeProfilerData):

  • runtime/VM.h:

(JSC::VM::functionHasExecutedCache):
(JSC::VM::controlFlowProfiler):

9:31 PM Changeset in webkit [176835] by bshafiei@apple.com
  • 2 edits in tags/Safari-601.1.11.1/Source/WTF

Merged r176832.

9:13 PM Changeset in webkit [176834] by bshafiei@apple.com
  • 5 edits in tags/Safari-601.1.11.1/Source

Versioning.

9:10 PM Changeset in webkit [176833] by bshafiei@apple.com
  • 1 copy in tags/Safari-601.1.11.1

New tag.

8:59 PM Changeset in webkit [176832] by ddkilzer@apple.com
  • 2 edits in trunk/Source/WTF

REGRESSION (r176683): RefCounter.h is installed outside SDKROOT

  • WTF.xcodeproj/project.pbxproj: Don't mark RefCounter.h as a

private header. WTF headers use a special build phase script to
be installed.

5:53 PM Changeset in webkit [176831] by dburkart@apple.com
  • 1 copy in tags/Safari-600.3.10

Tagging.

5:37 PM Changeset in webkit [176830] by ap@apple.com
  • 14 edits in trunk/Tools

Run http tests parallel
​https://bugs.webkit.org/show_bug.cgi?id=138958

Reviewed by Daniel Bates.

Remove the concept of "locked shard". Now http tests are just like any other tests.
We start HTTP and WebSocket servers at the start if we need them, and terminate them
when done with all the tests (not when the last http test runs, which is unnecessarily
unpredictable).

This makes debug tests run in 8 minutes and 12 seconds on my Mac Pro. Without the
patch, they used to take over 15 minutes.

As part of the fix, we no longer pass the number of servers to Apache. I don't
think that these parameters did what we wanted them to do; Apache handles the load
just fine without them.

The change applies to all platforms. I fixed everything I could find on Mac, and
Ossy told me that he's been running http tests in parallel for a long time. If
there is increased instability for some ports, it will need to be fixed - there is
generally nothing special about http tests at this point, and most code is
cross-platform in WebKit2.

  • Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:

(LayoutTestRunner.init):
(LayoutTestRunner.run_tests):
(LayoutTestRunner.start_servers_with_lock):
(LayoutTestRunner._handle_started_test):
(Worker.handle):
(Sharder.init):
(Sharder.shard_tests):
(Sharder._shard_every_file):
(Sharder._shard_by_directory):
(LayoutTestRunner._handle_finished_test_list): Deleted.
(LayoutTestRunner._handle_finished_test_list.find): Deleted.
(Sharder._shard_in_two): Deleted.
(Sharder): Deleted.
(Sharder._resize_shards): Deleted.
(Sharder._resize_shards.divide_and_round_up): Deleted.
(Sharder._resize_shards.extract_and_flatten): Deleted.
(Sharder._resize_shards.split_at): Deleted.

  • Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:

(FakePrinter.print_workers_and_shards):
(LayoutTestRunnerTests.test_servers_started.start_http_server):
(LayoutTestRunnerTests.test_servers_started):
(SharderTests.get_shards):
(SharderTests.test_shard_by_dir):
(SharderTests.test_shard_every_file):
(SharderTests): Deleted.
(SharderTests.test_shard_in_two): Deleted.
(SharderTests.test_shard_in_two_has_no_locked_shards): Deleted.
(SharderTests.test_shard_in_two_has_no_unlocked_shards): Deleted.
(SharderTests.test_multiple_locked_shards): Deleted.

  • Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:

(ManagerTest.test_needs_servers.get_manager):
(ManagerTest.integration_test_needs_servers.get_manager):
(ManagerTest.test_look_for_new_crash_logs.get_manager):
(ManagerTest):

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:

(_set_up_derived_options):

  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:

(RunTest.test_batch_size):
(RunTest.test_max_locked_shards): Deleted.

  • Scripts/webkitpy/layout_tests/servers/apache_http_server.py:

(LayoutTestApacheHttpd.init):

  • Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py:

(TestLayoutTestApacheHttpd.test_start_cmd):

  • Scripts/webkitpy/layout_tests/servers/http_server.py:

(Lighttpd.init):

  • Scripts/webkitpy/layout_tests/servers/http_server_base.py:

(HttpServerBase.init):

  • Scripts/webkitpy/layout_tests/views/printing.py:

(Printer.print_workers_and_shards):

  • Scripts/webkitpy/port/base.py:

(Port.default_child_processes):
(Port.to.start_http_server):
(Port.default_max_locked_shards): Deleted.

  • Scripts/webkitpy/port/port_testcase.py:

(PortTestCase.make_port):
(PortTestCase.test_default_max_locked_shards): Deleted.

  • Scripts/webkitpy/port/test.py:

(TestPort.start_http_server):

5:23 PM Changeset in webkit [176829] by andersca@apple.com
  • 30 edits in trunk/Source/WebKit2

Add missing includes in preparation for making toAPI require that it's passed an API::Object
​https://bugs.webkit.org/show_bug.cgi?id=139278

Reviewed by Tim Horton.

  • UIProcess/API/C/WKAuthenticationChallenge.cpp:
  • UIProcess/API/C/WKAuthenticationDecisionListener.cpp:
  • UIProcess/API/C/WKContext.cpp:
  • UIProcess/API/C/WKDownload.cpp:
  • UIProcess/API/C/WKFrame.cpp:
  • UIProcess/API/C/WKGeolocationManager.cpp:
  • UIProcess/API/C/WKInspector.cpp:
  • UIProcess/API/C/WKPage.cpp:
  • UIProcess/GenericCallback.h:
  • UIProcess/Notifications/WebNotificationProvider.cpp:
  • UIProcess/WebContextConnectionClient.cpp:
  • UIProcess/WebContextInjectedBundleClient.cpp:
  • UIProcess/WebCookieManagerProxyClient.cpp:
  • UIProcess/WebDatabaseManagerProxyClient.cpp:
  • UIProcess/WebFindClient.cpp:
  • UIProcess/WebFormClient.cpp:
  • UIProcess/WebIconDatabaseClient.cpp:
  • UIProcess/WebPageContextMenuClient.cpp:
  • WebProcess/InjectedBundle/API/c/WKBundle.cpp:
  • WebProcess/InjectedBundle/API/c/WKBundleDOMWindowExtension.cpp:
  • WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
  • WebProcess/InjectedBundle/API/c/WKBundleHitTestResult.cpp:
  • WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
  • WebProcess/InjectedBundle/InjectedBundleClient.cpp:
  • WebProcess/InjectedBundle/InjectedBundlePageFormClient.cpp:
  • WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:
  • WebProcess/InjectedBundle/InjectedBundlePagePolicyClient.cpp:
  • WebProcess/InjectedBundle/InjectedBundlePageResourceLoadClient.cpp:
  • WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp:
5:06 PM Changeset in webkit [176828] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

printInternal(PrintStream& out, JSC::JITCode::JITType type) ends up dumping a literal %s
​https://bugs.webkit.org/show_bug.cgi?id=139274

Reviewed by Geoffrey Garen.

  • jit/JITCode.cpp:

(WTF::printInternal):

5:06 PM Changeset in webkit [176827] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit/win

Don't use NeverDestroyed with a RefCounted object.

  • WebCoreSupport/WebVisitedLinkStore.cpp:

(WebVisitedLinkStore::shared):

5:03 PM Changeset in webkit [176826] by andersca@apple.com
  • 6 edits in trunk/Source

Make API::String copy the underlying strings if needed, for thread safety
​https://bugs.webkit.org/show_bug.cgi?id=139261

Reviewed by Sam Weinig.

Source/WebKit2:

  • Shared/API/c/WKString.cpp:

(WKStringCreateWithUTF8CString):
(WKStringCreateWithJSString):
(WKStringCopyJSString):
Move the implementations from API::String and directly into the API functions.

  • Shared/APIString.h:

Add a create overload that takes an rvalue reference. Call it from the create overload
that takes an lvalue reference, but explicitly copy the string.
We call isolatedCopy() again on the string in the rvalue reference overload, but that is a no-op
if the string can be sent to another thread. Add assertions in the String constructor that we can
send the string to another thread.

Source/WTF:

  • wtf/RefPtr.h:

(WTF::RefPtr<T>::leakRef):
Add a leakRef() to RefPtr so we don't have to go through PassRefPtr.

  • wtf/text/WTFString.cpp:

(WTF::String::isSafeToSendToAnotherThread):
Check if the string is empty before checking whether it's in an atomic string table.
It's safe to send empty strings to other threads even if they're in the atomic string table
since they will never be deallocated.

4:59 PM Changeset in webkit [176825] by ggaren@apple.com
  • 13 edits in trunk/Source/JavaScriptCore

Removed the concept of ParserArenaRefCounted
​https://bugs.webkit.org/show_bug.cgi?id=139277

Reviewed by Oliver Hunt.

This is a step toward a parser speedup.

Now that we have a clear root node type for each parse tree, there's no
need to have a concept for "I might be refcounted or arena allocated".
Instead, we can just use unique_ptr to manage the tree as a whole.

  • API/JSScriptRef.cpp:

(parseScript):

  • builtins/BuiltinExecutables.cpp:

(JSC::BuiltinExecutables::createBuiltinExecutable): Updated for type change.

  • bytecode/UnlinkedCodeBlock.cpp:

(JSC::generateFunctionCodeBlock): Use unique_ptr. No need to call
destroyData() explicitly: the unique_ptr destructor will do everything
we need, as Bjarne intended.

  • parser/NodeConstructors.h:

(JSC::ParserArenaRoot::ParserArenaRoot):
(JSC::ParserArenaRefCounted::ParserArenaRefCounted): Deleted.

  • parser/Nodes.cpp:

(JSC::ScopeNode::ScopeNode):
(JSC::ProgramNode::ProgramNode):
(JSC::EvalNode::EvalNode):
(JSC::FunctionNode::FunctionNode):
(JSC::ProgramNode::create): Deleted.
(JSC::EvalNode::create): Deleted.
(JSC::FunctionNode::create): Deleted. All special create semantics can
just go away now that we play by C++ constructor / destructor rules.

  • parser/Nodes.h:

(JSC::ParserArenaRoot::parserArena):
(JSC::ParserArenaRoot::~ParserArenaRoot): Just a normal class now, which
holds onto the whole parse tree by virtue of owning the arena in which
all the parsed nodes (except for itself) were allocated.

(JSC::ProgramNode::closedVariables):
(JSC::ParserArenaRefCounted::~ParserArenaRefCounted): Deleted.

(JSC::ScopeNode::destroyData): Deleted. No need to destroy anything
explicitly anymore -- we can just rely on destructors.

(JSC::ScopeNode::parserArena): Deleted.

  • parser/Parser.h:

(JSC::Parser<LexerType>::parse):
(JSC::parse): unique_ptr all the things.

  • parser/ParserArena.cpp:

(JSC::ParserArena::reset):
(JSC::ParserArena::isEmpty):
(JSC::ParserArena::contains): Deleted.
(JSC::ParserArena::last): Deleted.
(JSC::ParserArena::removeLast): Deleted.
(JSC::ParserArena::derefWithArena): Deleted.

  • parser/ParserArena.h:

(JSC::ParserArena::swap): Much delete. Such wow.

  • runtime/CodeCache.cpp:

(JSC::CodeCache::getGlobalCodeBlock):
(JSC::CodeCache::getFunctionExecutableFromGlobalCode):

  • runtime/Completion.cpp:

(JSC::checkSyntax):

  • runtime/Executable.cpp:

(JSC::ProgramExecutable::checkSyntax): unique_ptr all the things.

4:55 PM Changeset in webkit [176824] by akling@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

REGRESSION(r173188): Text inserted when trying to delete a word from the Twitter message box.
<​https://webkit.org/b/139076>

Reviewed by Geoffrey Garen.

The StringImpl* -> Weak<JSString> cache used by the DOM bindings
had a bug where the key could become a stale pointer if the cached
JSString had its internal StringImpl atomicized.

If a new StringImpl was then later constructed at the exact same
address as the stale key, before the Weak<JSString> got booted out
of the string cache, we'd now have a situation where asking the
string cache for that key would return the old JSString.

Solve this by not allowing JSString::toExistingAtomicString() to
change the JSString's internal StringImpl unless it's resolving a
rope string. (The StringImpl nullity determines rope state.)

This means that calling toExistingAtomicString() may now have to
query the AtomicString table on each call rather than just once.
All clients of this API would be forced to do this regardless,
since they return value will be used to key into containers with
AtomicStringImpl* keys.

No test because this relies on malloc putting two StringImpls
at the same address at different points in time and we have no
mechanism to reliably test that.

  • runtime/JSString.h:

(JSC::JSString::toExistingAtomicString):

3:55 PM Changeset in webkit [176823] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

2014-12-04 Geoffrey Garen <​ggaren@apple.com>

Marked some final things final.

Reviewed by Andreas Kling.

  • parser/Nodes.h:
3:47 PM Changeset in webkit [176822] by ggaren@apple.com
  • 11 edits in trunk/Source/JavaScriptCore

Split out FunctionNode from FunctionBodyNode
​https://bugs.webkit.org/show_bug.cgi?id=139273

Reviewed by Andreas Kling.

This is step toward a parser speedup.

We used to use FunctionBodyNode for two different purposes:

(1) "I am the root function you are currently parsing";

(2) "I am a lazy record of a nested function, which you will parse later".

This made for awkward lifetime semantics and interfaces.

Now, case (1) is handled by FunctionBodyNode, and case (2) is handled by
a new node named FunctionNode.

Since case (1) no longer needs to handle being the root of the parse
tree, FunctionBodyNode can be a normal arena-allocated node.

  • bytecode/UnlinkedCodeBlock.cpp:

(JSC::generateFunctionCodeBlock): Use FunctionNode instead of
FunctionBodyNode, since we are producing the root of the function parse
tree.

(JSC::UnlinkedFunctionExecutable::UnlinkedFunctionExecutable): Removed
some unused data, and default-initialized other data, which isn't filled
in meaningfully until recordParse() is called. (The previous values were
incorrect / meaningless, since the FunctionBodyNode didn't have
meaningful values in this case.)

  • bytecode/UnlinkedCodeBlock.h: Ditto.

(JSC::UnlinkedFunctionExecutable::forceUsesArguments): Deleted.

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::BytecodeGenerator): Use FunctionNode instead of
FunctionBodyNode, since we are generating code starting at the root of
the parse tree.

(JSC::BytecodeGenerator::resolveCallee):
(JSC::BytecodeGenerator::addCallee):

  • bytecompiler/BytecodeGenerator.h: Ditto.
  • bytecompiler/NodesCodegen.cpp:

(JSC::FunctionBodyNode::emitBytecode):
(JSC::FunctionNode::emitBytecode): Moved the emitBytecode implementation
to FunctionNode, since we never generate code for FunctionBodyNode,
since it's just a placeholder in the AST.

  • parser/ASTBuilder.h:

(JSC::ASTBuilder::createFunctionBody):
(JSC::ASTBuilder::setUsesArguments): Deleted. Updated for interface
changes.

  • parser/Nodes.cpp:

(JSC::FunctionBodyNode::FunctionBodyNode):
(JSC::FunctionBodyNode::finishParsing):
(JSC::FunctionBodyNode::setEndPosition):
(JSC::FunctionNode::FunctionNode):
(JSC::FunctionNode::create):
(JSC::FunctionNode::finishParsing):
(JSC::FunctionBodyNode::create): Deleted.

  • parser/Nodes.h:

(JSC::FunctionBodyNode::parameters):
(JSC::FunctionBodyNode::source):
(JSC::FunctionBodyNode::startStartOffset):
(JSC::FunctionBodyNode::isInStrictContext):
(JSC::FunctionNode::parameters):
(JSC::FunctionNode::ident):
(JSC::FunctionNode::functionMode):
(JSC::FunctionNode::startColumn):
(JSC::FunctionNode::endColumn):
(JSC::ScopeNode::setSource): Deleted.
(JSC::FunctionBodyNode::parameterCount): Deleted. Split out the differences
between FunctionNode and FunctionBodyNode.

  • parser/SyntaxChecker.h:

(JSC::SyntaxChecker::createClauseList):
(JSC::SyntaxChecker::setUsesArguments): Deleted. Removed setUsesArguments
since it wasn't used.

  • runtime/Executable.cpp:

(JSC::ProgramExecutable::checkSyntax): Removed a branch that was always
false.

3:26 PM Changeset in webkit [176821] by dino@apple.com
  • 2 edits in trunk/LayoutTests

css3/viewport-percentage-lengths tests are flakey on WK1 Mavericks Debug
​https://bugs.webkit.org/show_bug.cgi?id=139271

Marking as flakey.

  • platform/mac-mavericks/TestExpectations:
2:57 PM Changeset in webkit [176820] by Beth Dakin
  • 2 edits in trunk/Source/WebKit2

Clients disabling action menus sometimes still invoke action menu behaviors
​https://bugs.webkit.org/show_bug.cgi?id=139270
-and corresponding-
rdar://problem/19147218

Reviewed by Tim Horton.

By default, we will keep a single item in the action menu up until the point where
_state == ActionMenuState::Ready. So by checking _state here, we are preventing
clients from opting out of our choice to wait. Ideally we would always still wait
for the Ready state, but this will get the best behavior in the mean time.

  • UIProcess/mac/WKActionMenuController.mm:

(-[WKActionMenuController _updateActionMenuItems]):

2:56 PM Changeset in webkit [176819] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Network Timeline Filter Bar only has "All", missing Resource Type filters
​https://bugs.webkit.org/show_bug.cgi?id=139268

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-12-04
Reviewed by Brian Burg.

  • UserInterface/Views/TimelineDataGrid.js:

(WebInspector.TimelineDataGrid.createColumnScopeBar):
Users of createColumnScopeBar pass a Map object now instead of a dictionary.
Iterate over the map appropriately.

2:48 PM Changeset in webkit [176818] by Antti Koivisto
  • 5 edits in trunk/Source/WebKit2

REGRESSION (r173468): Cannot step in WebInspector
​https://bugs.webkit.org/show_bug.cgi?id=139260

Reviewed by Alexey Proskuryakov.

Inspector defers all loads and starts a nested runloop when it hits a breakpoint. When continuing it undefers the loads.
If the script execution was triggered from the didFinishLoading callback of the main resource then the main resource would
already be in the finished state in the network process side and setDefersLoading(false) message would end up restarting its load.
Since loads are not meant to restart the generated callbacks would assert or crash the web process when handled in the next
nested inspector runloop.

Fix by taking care that cleaned up NetworkResourceLoaders are always removed from the loader map of
the NetworkConnectionToWebProcess and so can't end up handling late messages.

No test, this requires JS debugger to trigger.

  • NetworkProcess/NetworkConnectionToWebProcess.cpp:

(WebKit::NetworkConnectionToWebProcess::didCleanupResourceLoader):

This is now the only way to remove resource loaders.
It is called from NetworkResourceLoader::cleanup only.

(WebKit::NetworkConnectionToWebProcess::didClose):
(WebKit::NetworkConnectionToWebProcess::removeLoadIdentifier):

Calling abort removes the resource loader (since it calls cleanup) so no need to do it explicitly anymore.

  • NetworkProcess/NetworkConnectionToWebProcess.h:
  • NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::NetworkResourceLoader::start):

We are guaranteed to be reffed by NetworkConnectionToWebProcess until cleanup so the explicit ref/deref can be removed.

(WebKit::NetworkResourceLoader::cleanup):

Call to NetworkConnectionToWebProcess::didCleanupResourceLoader to make the loader unreachable.

  • NetworkProcess/NetworkResourceLoader.h:

(WebKit::NetworkResourceLoader::identifier):

2:20 PM Changeset in webkit [176817] by Brian Burg
  • 14 edits in trunk

Web Inspector: timeline probe records have inaccurate per-probe hit counts
​https://bugs.webkit.org/show_bug.cgi?id=138976

Reviewed by Joseph Pecoraro.
Source/JavaScriptCore:

Previously, the DebuggerAgent was responsible for assigning unique ids to samples.
However, this makes it impossible for the frontend's Timeline manager to associate
a Probe Sample timeline record with the corresponding probe sample data. The record
only included the probe batchId (misnamed as hitCount in ScriptDebugServer).

This patch moves both the batchId and sampleId counters into ScriptDebugServer, so
any client of ScriptDebugListener will get the correct sampleId for each sample.

  • inspector/ScriptDebugListener.h:
  • inspector/ScriptDebugServer.cpp:

(Inspector::ScriptDebugServer::ScriptDebugServer):
(Inspector::ScriptDebugServer::dispatchBreakpointActionProbe):
(Inspector::ScriptDebugServer::handleBreakpointHit):

  • inspector/ScriptDebugServer.h:
  • inspector/agents/InspectorDebuggerAgent.cpp:

(Inspector::InspectorDebuggerAgent::InspectorDebuggerAgent):
(Inspector::InspectorDebuggerAgent::breakpointActionProbe):

  • inspector/agents/InspectorDebuggerAgent.h:

Source/WebCore:

Update the signature for breakpointActionProbe to take batchId and sampleId.
Covered by existing test inspector-protocol/debugger/didSampleProbe-multiple-probes.html.

  • inspector/InspectorTimelineAgent.cpp:

(WebCore::InspectorTimelineAgent::breakpointActionProbe):

  • inspector/InspectorTimelineAgent.h:
  • inspector/TimelineRecordFactory.cpp:

(WebCore::TimelineRecordFactory::createProbeSampleData):

  • inspector/TimelineRecordFactory.h:

LayoutTests:

Patch by Katie Madonna <​madonnk@gmail.com>

Update test to also cover expected probe sampleId behavior.

  • inspector-protocol/debugger/didSampleProbe-multiple-probes-expected.txt:
  • inspector-protocol/debugger/didSampleProbe-multiple-probes.html:
2:01 PM Changeset in webkit [176816] by cavalcantii@gmail.com
  • 4 edits
    4 adds in trunk

Groove/inset/outset borders show solid if the color is black
​https://bugs.webkit.org/show_bug.cgi?id=58608

Reviewed by Simon Fraser.

Source/WebCore:

Test: fast/borders/mixed-border-style2.html

This patch will lighten/darken the border side colors, handling
border decoration in a similar way as Firefox does.

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::drawLineForBoxSide):
(WebCore::RenderObject::calculateBorderStyleColor):

  • rendering/RenderObject.h:

LayoutTests:

  • fast/borders/mixed-border-style2.html: Added.
  • platform/mac-mavericks/fast/borders/mixed-border-style2-expected.png: Added.
  • platform/mac-mavericks/fast/borders/mixed-border-style2-expected.txt: Added.
1:56 PM Changeset in webkit [176815] by Joseph Pecoraro
  • 4 edits in trunk

Web Inspector: LayoutTests/inspector tests fail in Production builds due to missing test resources
​https://bugs.webkit.org/show_bug.cgi?id=138898

Reviewed by Mark Rowe.

Source/WebInspectorUI:

In Production builds, if FORCE_TOOL_INSTALL=YES is in the environment
we will copy all resources (for Tests) and still do the combine and
optimize phase for normal Production inspection resources.

  • Scripts/copy-user-interface-resources.pl:

LayoutTests:

  • platform/mac/TestExpectations:
1:49 PM Changeset in webkit [176814] by ap@apple.com
  • 6 edits in trunk/Tools

Don't lock perf tests in run-webkit-tests
​https://bugs.webkit.org/show_bug.cgi?id=139264

Reviewed by Daniel Bates.

  • Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
  • Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
  • Scripts/webkitpy/layout_tests/controllers/manager.py:
  • Scripts/webkitpy/layout_tests/models/test_input.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1:48 PM Changeset in webkit [176813] by Chris Dumez
  • 4 edits in trunk/Source/WebCore

Move 'webkit-aspect-ratio' CSS property to the new StyleBuilder
​https://bugs.webkit.org/show_bug.cgi?id=139250

Reviewed by Sam Weinig.

Move 'aspect-ratio' CSS property to the new StyleBuilder by
using custom code.

No new tests, no behavior change.

  • css/CSSPropertyNames.in:
  • css/DeprecatedStyleBuilder.cpp:

(WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder):
(WebCore::ApplyPropertyAspectRatio::applyInheritValue): Deleted.
(WebCore::ApplyPropertyAspectRatio::applyInitialValue): Deleted.
(WebCore::ApplyPropertyAspectRatio::applyValue): Deleted.
(WebCore::ApplyPropertyAspectRatio::createHandler): Deleted.

  • css/StyleBuilderCustom.h:

(WebCore::StyleBuilderCustom::applyInitialWebkitAspectRatio):
(WebCore::StyleBuilderCustom::applyInheritWebkitAspectRatio):
(WebCore::StyleBuilderCustom::applyValueWebkitAspectRatio):

1:32 PM Changeset in webkit [176812] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebCore

Further fix the 32-bit build.

  • page/mac/TextIndicatorWindow.mm:

(WebCore::TextIndicatorWindow::setTextIndicator):

1:10 PM Changeset in webkit [176811] by timothy_horton@apple.com
  • 7 edits in trunk/Source

Fix the 32-bit build.

  • UIProcess/API/mac/WKView.mm:

(-[WKView _setTextIndicator:fadeOut:animationCompletionHandler:]):

  • WebView/WebView.mm:

(-[WebView _setTextIndicator:fadeOut:animationCompletionHandler:]):

  • page/mac/TextIndicatorWindow.h:
  • page/mac/TextIndicatorWindow.mm:

(WebCore::TextIndicatorWindow::setTextIndicator):

11:58 AM Changeset in webkit [176810] by timothy_horton@apple.com
  • 12 edits in trunk/Source

TextIndicator::createWithSelectionInFrame does synchronous IPC in WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=139252
<rdar://problem/19140827>

Reviewed by Anders Carlsson.

It turns out contentsToScreen requires sync IPC in Mac WebKit2, which we
really don't want to be doing here (especially since the UI process will often
be sitting in waitForAndDispatchImmediately waiting for didPerformActionMenuHitTest).

Go back to keeping TextIndicator rects in "window" coordinates and do the conversion
in each of the WebKits instead of trying to share that code.

  • WebCore.exp.in:
  • page/TextIndicator.cpp:

(WebCore::TextIndicator::createWithSelectionInFrame):
(WebCore::TextIndicator::TextIndicator):

  • page/TextIndicator.h:

(WebCore::TextIndicator::selectionRectInWindowCoordinates):
(WebCore::TextIndicator::textBoundingRectInWindowCoordinates):
(WebCore::TextIndicator::selectionRectInScreenCoordinates): Deleted.
(WebCore::TextIndicator::textBoundingRectInScreenCoordinates): Deleted.
Go back to keeping the rects in "window" coordinates.

  • page/mac/TextIndicatorWindow.h:
  • page/mac/TextIndicatorWindow.mm:

(-[WebTextIndicatorView initWithFrame:textIndicator:margin:]):
(WebCore::TextIndicatorWindow::setTextIndicator):
Let callers pass in the contentRect instead of trying to share the code
to compute it, since it needs to be different for legacy and modern WebKit.

  • WebView/WebView.mm:

(-[WebView _setTextIndicator:fadeOut:animationCompletionHandler:]):
Adjust to the WebCore changes.

  • Shared/WebCoreArgumentCoders.cpp:

(IPC::ArgumentCoder<TextIndicatorData>::encode):
(IPC::ArgumentCoder<TextIndicatorData>::decode):

  • UIProcess/API/mac/WKView.mm:

(-[WKView _setTextIndicator:fadeOut:animationCompletionHandler:]):

  • WebProcess/WebPage/FindController.cpp:

(WebKit::FindController::updateFindIndicator):
(WebKit::FindController::drawRect):
Adjust to the WebCore changes.

11:57 AM Changeset in webkit [176809] by dburkart@apple.com
  • 4 edits in branches/safari-600.3-branch/Source

Merged r176803. rdar://problems/19034499

11:54 AM Changeset in webkit [176808] by dburkart@apple.com
  • 3 edits in branches/safari-600.3-branch/Source/WebCore

Merge r176682. rdar://problems/18903995

11:47 AM Changeset in webkit [176807] by dburkart@apple.com
  • 11 edits in branches/safari-600.3-branch/Source

Merge r176766. rdar://problems/19072083

11:39 AM Changeset in webkit [176806] by andersca@apple.com
  • 4 edits in trunk/Source/WebKit2

Simplify StorageManager callback functions
​https://bugs.webkit.org/show_bug.cgi?id=139257

Reviewed by Antti Koivisto.

  • UIProcess/Storage/StorageManager.cpp:

(WebKit::StorageManager::getOrigins):
(WebKit::StorageManager::getStorageDetailsByOrigin):
(WebKit::callCallbackFunction): Deleted.
(WebKit::StorageManager::getOriginsInternal): Deleted.
(WebKit::StorageManager::getStorageDetailsByOriginInternal): Deleted.

  • UIProcess/Storage/StorageManager.h:
  • UIProcess/WebKeyValueStorageManager.cpp:

(WebKit::WebKeyValueStorageManager::getKeyValueStorageOrigins):
(WebKit::WebKeyValueStorageManager::getStorageDetailsByOrigin):
(WebKit::didGetKeyValueStorageOrigins): Deleted.
(WebKit::didGetStorageDetailsByOrigin): Deleted.

11:22 AM Changeset in webkit [176805] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WTF

Fix cast-align warning in StringImpl.h
​https://bugs.webkit.org/show_bug.cgi?id=139222

Reviewed by Anders Carlsson.

  • wtf/text/StringImpl.h:

(WTF::StringImpl::tailPointer):

11:21 AM Changeset in webkit [176804] by dburkart@apple.com
  • 24 edits in branches/safari-600.3-branch/Source

Merge r173235. rdar://problems/19072083

10:31 AM Changeset in webkit [176803] by ddkilzer@apple.com
  • 4 edits in trunk/Source

Serialization of MapData object provides unsafe access to internal types
​https://bugs.webkit.org/show_bug.cgi?id=138653

Patch by Oliver Hunt <​oliver@apple.com> on 2014-12-04
Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Converting these ASSERTs into RELEASE_ASSERTs, as it is now obvious
that despite trying hard to be safe in all cases it's simply to easy
to use an iterator in an unsafe state.

  • runtime/MapData.h:

(JSC::MapData::const_iterator::key):
(JSC::MapData::const_iterator::value):

Source/WebCore:

We now keep the value portion of the key/value pair in MapData as a
separate stack. This allows us to maintain the spec semantic of
"atomic" serialisation of the key/value pair without retaining the
use of a potentially invalid iterator.

  • bindings/js/SerializedScriptValue.cpp:

(WebCore::CloneSerializer::serialize):

9:41 AM Changeset in webkit [176802] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebKit2

URTBF after r176794.

  • UIProcess/Storage/LocalStorageDatabaseTracker.cpp:

(WebKit::fileCreationTime):
(WebKit::fileModificationTime):

9:40 AM Changeset in webkit [176801] by dburkart@apple.com
  • 2 edits in branches/safari-600.3-branch/Source/WebCore

Merge r176697. rdar://problems/19121822

9:18 AM Changeset in webkit [176800] by ap@apple.com
  • 2 edits in trunk/Tools

http/tests/security/mixedContent/about-blank-iframe-in-main-frame.html fails unless certain other tests run before it
​https://bugs.webkit.org/show_bug.cgi?id=139243

Reviewed by Anders Carlsson.

We didn't get WKPageLoaderClient calls in secondary windows, so we didn't have a
chance to allow untrusted certificates.

  • WebKitTestRunner/TestController.cpp: (WTR::TestController::createOtherPage):

Set up more client objects for secondary windows. We may be able to share some of the
code with main view creation function, but it's not exactly the same (notably, we
do not focus a secondary window when it's done loading).

9:11 AM Changeset in webkit [176799] by dburkart@apple.com
  • 11 edits in branches/safari-600.3-branch/Source

Rollout r176766. rdar://problems/19072083

9:05 AM Changeset in webkit [176798] by stavila@adobe.com
  • 32 edits
    6 adds in trunk/Source/WebCore

[SVG Masking] Add support for referencing <mask> elements from -webkit-mask-image
​https://bugs.webkit.org/show_bug.cgi?id=139092

Reviewed by Simon Fraser.

This patch improves the -webkit-mask-image property by allowing it to reference
a <mask> element defined in an inline or external SVG document.
Up until now, each image to be used as a mask consisted of a FillLayer object
whose m_image member represented the mask. Now, in order to accomodate
<mask> elements referenced by a fragment identifier (e.g. file.svg#mask1)
a new class was created (MaskImageOperation) and added as a member of the
FillLayer. As such, from now on, all FillLayer objects used for masking will
store the masking information in this new member.
When parsing the -webkit-mask-image property (or the -webkit-mask shorthand)
a new MaskImageOperation object is created for each image. If the value represents
an external URL, a pending SVG document will be created which will be loaded
during the phase that loads the pending resources. When the download is complete,
the MaskImageOperation is notified by the CachedSVGDocument class and checks if
the received download is a valid SVG and the requested fragment identifier
actually exists and identifies a <mask> element. If it does, that element's
renderer (of type RenderSVGResourceMasker) will be used when painting the mask layers.
Otherwise, the MaskImageOperation class will use the already downloaded data
buffer to create a CachedImage from it and use that instead, basically emulating
the previous behavior, when only images were accepted. This ensures that all existing
behavior, like painting entire SVGs, painting normal images (e.g. PNG/JPG), painting
generated images (e.g. linear-gradient) works as it did before.

No new tests required, this patch doesn't change any current functionality.
It only adds support for referencing <mask> elements for the -webkit-mask-image
property. This is sub-part 1 of the bigger patch ​https://bugs.webkit.org/show_bug.cgi?id=129682.

  • CMakeLists.txt:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSValue.cpp:

(WebCore::CSSValue::cssText):
(WebCore::CSSValue::destroy):

  • css/CSSValue.h:

(WebCore::CSSValue::isWebKitCSSResourceValue):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::State::clear):
(WebCore::StyleResolver::createMaskImageOperations):

  • css/StyleResolver.h:

(WebCore::StyleResolver::State::maskImagesWithPendingSVGDocuments):

  • css/WebKitCSSResourceValue.cpp: Added.

(WebCore::WebKitCSSResourceValue::WebKitCSSResourceValue):
(WebCore::WebKitCSSResourceValue::customCSSText):
(WebCore::WebKitCSSResourceValue::isCSSValueNone):

  • css/WebKitCSSResourceValue.h: Added.

(WebCore::WebKitCSSResourceValue::create):
(WebCore::WebKitCSSResourceValue::innerValue):

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::addCachedResource):

  • loader/cache/CachedResourceLoader.h:
  • loader/cache/CachedSVGDocument.cpp:

(WebCore::CachedSVGDocument::CachedSVGDocument):
(WebCore::CachedSVGDocument::finishLoading):

  • loader/cache/CachedSVGDocument.h:
  • loader/cache/CachedSVGDocumentReference.cpp:

(WebCore::CachedSVGDocumentReference::CachedSVGDocumentReference):
(WebCore::CachedSVGDocumentReference::~CachedSVGDocumentReference):
(WebCore::CachedSVGDocumentReference::load):

  • loader/cache/CachedSVGDocumentReference.h:
  • page/FrameView.cpp:

(WebCore::FrameView::isSVGDocument):

  • page/FrameView.h:
  • page/Page.cpp:

(WebCore::Page::createPageFromBuffer):

  • page/Page.h:
  • platform/ScrollView.h:

(WebCore::ScrollView::isSVGDocument):

  • platform/graphics/MaskImageOperation.cpp: Added.

(WebCore::MaskImageOperation::create):
(WebCore::MaskImageOperation::MaskImageOperation):
(WebCore::MaskImageOperation::~MaskImageOperation):
(WebCore::MaskImageOperation::isCSSValueNone):
(WebCore::MaskImageOperation::cssValue):
(WebCore::MaskImageOperation::isMaskLoaded):
(WebCore::MaskImageOperation::setRenderLayerImageClient):
(WebCore::MaskImageOperation::addRendererImageClient):
(WebCore::MaskImageOperation::removeRendererImageClient):
(WebCore::MaskImageOperation::getOrCreateCachedSVGDocumentReference):
(WebCore::MaskImageOperation::notifyFinished): This is the method that gets called when the document has finished
downloading and checks if it can find a valid <mask> element.
(WebCore::MaskImageOperation::drawMask):
(WebCore::MaskImageOperation::getSVGMasker):

  • platform/graphics/MaskImageOperation.h: Added.
  • rendering/RenderBoxModelObject.cpp: The BackgroundImageGeometry class was moved out of RenderBoxModelObject in

order to be used as a parameter for other methods. This was necessary to avoid having methods with very many parameters.
(WebCore::BackgroundImageGeometry::setNoRepeatX):
(WebCore::BackgroundImageGeometry::setNoRepeatY):
(WebCore::BackgroundImageGeometry::useFixedAttachment):
(WebCore::BackgroundImageGeometry::clip):
(WebCore::BackgroundImageGeometry::relativePhase):
(WebCore::RenderBoxModelObject::BackgroundImageGeometry::setNoRepeatX): Deleted.
(WebCore::RenderBoxModelObject::BackgroundImageGeometry::setNoRepeatY): Deleted.
(WebCore::RenderBoxModelObject::BackgroundImageGeometry::useFixedAttachment): Deleted.
(WebCore::RenderBoxModelObject::BackgroundImageGeometry::clip): Deleted.
(WebCore::RenderBoxModelObject::BackgroundImageGeometry::relativePhase): Deleted.

  • rendering/RenderBoxModelObject.h:

(WebCore::BackgroundImageGeometry::BackgroundImageGeometry):
(WebCore::BackgroundImageGeometry::destOrigin):
(WebCore::BackgroundImageGeometry::setDestOrigin):
(WebCore::BackgroundImageGeometry::destRect):
(WebCore::BackgroundImageGeometry::setDestRect):
(WebCore::BackgroundImageGeometry::phase):
(WebCore::BackgroundImageGeometry::setPhase):
(WebCore::BackgroundImageGeometry::tileSize):
(WebCore::BackgroundImageGeometry::setTileSize):
(WebCore::BackgroundImageGeometry::spaceSize):
(WebCore::BackgroundImageGeometry::setSpaceSize):
(WebCore::BackgroundImageGeometry::setPhaseX):
(WebCore::BackgroundImageGeometry::setPhaseY):
(WebCore::BackgroundImageGeometry::setHasNonLocalGeometry):
(WebCore::BackgroundImageGeometry::hasNonLocalGeometry):
(WebCore::RenderBoxModelObject::BackgroundImageGeometry::BackgroundImageGeometry): Deleted.
(WebCore::RenderBoxModelObject::BackgroundImageGeometry::destOrigin): Deleted.
(WebCore::RenderBoxModelObject::BackgroundImageGeometry::setDestOrigin): Deleted.
(WebCore::RenderBoxModelObject::BackgroundImageGeometry::destRect): Deleted.
(WebCore::RenderBoxModelObject::BackgroundImageGeometry::setDestRect): Deleted.
(WebCore::RenderBoxModelObject::BackgroundImageGeometry::phase): Deleted.
(WebCore::RenderBoxModelObject::BackgroundImageGeometry::setPhase): Deleted.
(WebCore::RenderBoxModelObject::BackgroundImageGeometry::tileSize): Deleted.
(WebCore::RenderBoxModelObject::BackgroundImageGeometry::setTileSize): Deleted.
(WebCore::RenderBoxModelObject::BackgroundImageGeometry::spaceSize): Deleted.
(WebCore::RenderBoxModelObject::BackgroundImageGeometry::setSpaceSize): Deleted.
(WebCore::RenderBoxModelObject::BackgroundImageGeometry::setPhaseX): Deleted.
(WebCore::RenderBoxModelObject::BackgroundImageGeometry::setPhaseY): Deleted.
(WebCore::RenderBoxModelObject::BackgroundImageGeometry::setHasNonLocalGeometry): Deleted.
(WebCore::RenderBoxModelObject::BackgroundImageGeometry::hasNonLocalGeometry): Deleted.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::RenderLayer):
(WebCore::RenderLayer::~RenderLayer):

  • rendering/RenderLayer.h:
  • rendering/RenderLayerMaskImageInfo.cpp: Added.

(WebCore::RenderLayer::MaskImageInfo::layerToMaskMap): Returns a static map that links MaskImageInfo objects to RenderLayers.
(WebCore::RenderLayer::MaskImageInfo::getIfExists): Returns the MaskImageInfo associated with a specific RenderLayer.
(WebCore::RenderLayer::MaskImageInfo::get): Returns the MaskImageInfo associated with a specific RenderLayer (creates it if necessary).
(WebCore::RenderLayer::MaskImageInfo::remove): Removes the MaskImageInfo associated with a specific RenderLayer.
(WebCore::RenderLayer::MaskImageInfo::MaskImageInfo):
(WebCore::RenderLayer::MaskImageInfo::~MaskImageInfo):
(WebCore::RenderLayer::MaskImageInfo::notifyFinished): Gets called when the SVG document finished loading, triggers repaint.
(WebCore::RenderLayer::MaskImageInfo::imageChanged): Gets called when the image object changed, triggers repaint.
(WebCore::RenderLayer::MaskImageInfo::updateMaskImageClients): Goes through all mask layers and sets image/SVG clients.
Updates list of internal and external SVG references.
(WebCore::RenderLayer::MaskImageInfo::removeMaskImageClients): Removes all image/SVG clients and clears lists of internal and external SVG references.

  • rendering/RenderLayerMaskImageInfo.h: Added.
  • rendering/RenderObject.h:

(WebCore::RenderObject::isRenderSVGResourceMasker):

  • rendering/style/FillLayer.cpp:

(WebCore::FillLayer::FillLayer):
(WebCore::FillLayer::operator=):
(WebCore::FillLayer::operator==):
(WebCore::FillLayer::cullEmptyLayers):
(WebCore::FillLayer::hasNonEmptyMaskImage):
(WebCore::FillLayer::imagesAreLoaded):

  • rendering/style/FillLayer.h:

(WebCore::FillLayer::maskImage):
(WebCore::FillLayer::imageOrMaskImage):
(WebCore::FillLayer::setMaskImage):
(WebCore::FillLayer::clearMaskImage):
(WebCore::FillLayer::hasMaskImage):

  • rendering/svg/RenderSVGResourceMasker.cpp:

(WebCore::RenderSVGResourceMasker::applySVGMask):
(WebCore::RenderSVGResourceMasker::applyResource):
(WebCore::RenderSVGResourceMasker::drawMaskForRenderer):

  • rendering/svg/RenderSVGResourceMasker.h:
  • svg/SVGMaskElement.cpp:

(WebCore::SVGMaskElement::createElementRenderer):
(WebCore::SVGMaskElement::addClientRenderLayer):
(WebCore::SVGMaskElement::removeClientRenderLayer):

  • svg/SVGMaskElement.h:
  • svg/SVGUseElement.cpp:

(WebCore::SVGUseElement::setCachedDocument):

  • svg/graphics/SVGImage.cpp:

(WebCore::SVGImage::dataChanged):

8:36 AM Changeset in webkit [176797] by dburkart@apple.com
  • 2 edits in branches/safari-600.3-branch/Source/WebKit/mac

Merged r176777. rdar://problems/19115662

8:35 AM Changeset in webkit [176796] by dburkart@apple.com
  • 2 edits in branches/safari-600.3-branch/Source/WebKit/mac

Merged r176775. rdar://problems/19115662

8:35 AM Changeset in webkit [176795] by dburkart@apple.com
  • 11 edits in branches/safari-600.3-branch/Source

Merged r176766. rdar://problems/19072083

8:35 AM Changeset in webkit [176794] by andersca@apple.com
  • 7 edits in trunk/Source/WebKit2

Add a way to delete local storage origins modified after a given date
​https://bugs.webkit.org/show_bug.cgi?id=139249

Reviewed by Tim Horton.

Also change LocalStorageDatabaseTracker to hold on to WTF::Optional time_t values
instead of treating missing values as zero.

  • UIProcess/LocalStorageDetails.h:
  • UIProcess/Storage/LocalStorageDatabaseTracker.cpp:

(WebKit::fileCreationTime):
(WebKit::fileModificationTime):
(WebKit::LocalStorageDatabaseTracker::deleteDatabasesModifiedSince):
(WebKit::LocalStorageDatabaseTracker::details):

  • UIProcess/Storage/LocalStorageDatabaseTracker.h:
  • UIProcess/Storage/StorageManager.cpp:

(WebKit::StorageManager::deleteLocalStorageOriginsModifiedSince):

  • UIProcess/Storage/StorageManager.h:
  • UIProcess/WebKeyValueStorageManager.cpp:

(WebKit::didGetStorageDetailsByOrigin):

8:35 AM Changeset in webkit [176793] by dburkart@apple.com
  • 6 edits in branches/safari-600.3-branch/Source

Merged r176763. rdar://problems/19115662

7:54 AM Changeset in webkit [176792] by dburkart@apple.com
  • 18 edits in branches/safari-600.3-branch/Source

Merge r176753. rdar://problems/19052381

7:42 AM Changeset in webkit [176791] by dburkart@apple.com
  • 2 edits in branches/safari-600.3-branch/Source/WebKit2

Merged r176707. rdar://problems/19037590

6:09 AM Changeset in webkit [176790] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

Unreviewed, rolling out r176789.
​https://bugs.webkit.org/show_bug.cgi?id=139255

Broke the non Mac-WK2 builds (Requested by stavila on
#webkit).

Reverted changeset:

"Remove isSpecifiedFont boolean from FontDescription"
​https://bugs.webkit.org/show_bug.cgi?id=139233
​http://trac.webkit.org/changeset/176789

3:50 AM Changeset in webkit [176789] by Antti Koivisto
  • 5 edits in trunk/Source/WebCore

Remove isSpecifiedFont boolean from FontDescription
​https://bugs.webkit.org/show_bug.cgi?id=139233

Reviewed by Andreas Kling.

It is barely used.

  • css/StyleBuilderCustom.h:

(WebCore::StyleBuilderCustom::applyInheritFontFamily):
(WebCore::StyleBuilderCustom::applyValueFontFamily):

  • platform/graphics/FontDescription.cpp:

(WebCore::genericFamiliesSet):
(WebCore::FontDescription::hasGenericFirstFamily):

Add a function to test for generic families.

  • platform/graphics/FontDescription.h:

(WebCore::FontDescription::FontDescription):
(WebCore::FontDescription::setTextRenderingMode):
(WebCore::FontDescription::operator==):
(WebCore::FontDescription::isSpecifiedFont): Deleted.
(WebCore::FontDescription::setIsSpecifiedFont): Deleted.

  • rendering/RenderText.cpp:

(WebCore::RenderText::computeUseBackslashAsYenSymbol):

This is the only client.
Figure out the equivalent information dynamically if needed.

2:18 AM Changeset in webkit [176788] by evab.u-szeged@partner.samsung.com
  • 2 edits in trunk/LayoutTests

[EFL][WebGL] Remove junk webgl layout tests from TestExpectations
​https://bugs.webkit.org/show_bug.cgi?id=139253

Reviewed by Gyuyoung Kim.

  • platform/efl/TestExpectations:
2:10 AM Changeset in webkit [176787] by berto@igalia.com
  • 2 edits in trunk

can not find cairo-gl.h when build webkit with gtk on ubuntu 14.04
​https://bugs.webkit.org/show_bug.cgi?id=136576

Reviewed by Carlos Garcia Campos.

CMake should complain if Accelerated 2D Canvas is explicitly
enabled but cairo-gl is not found.

  • Source/cmake/OptionsGTK.cmake:
1:23 AM Changeset in webkit [176786] by pmolnar.u-szeged@partner.samsung.com
  • 5 edits in trunk/Source/WebKit2

[EFL][WK2] Add ewk API to allow accepting a specific TLS certificate for a specific host
​https://bugs.webkit.org/show_bug.cgi?id=131160

Reviewed by Gyuyoung Kim.

  • UIProcess/API/efl/ewk_context.cpp:

(EwkContext::allowSpecificHTTPSCertificateForHost):
(ewk_context_tls_certificate_for_host_allow):

  • UIProcess/API/efl/ewk_context.h:
  • UIProcess/API/efl/ewk_context_private.h:
  • UIProcess/API/efl/tests/test_ewk2_ssl.cpp:

Dec 3, 2014:

10:42 PM Changeset in webkit [176785] by adachan@apple.com
  • 1 edit
    12 adds in trunk/Examples

Add a sample plugin to demonstrate the mute plugin API.
​https://bugs.webkit.org/show_bug.cgi?id=139231

Reviewed by Anders Carlsson.

  • NetscapeMuteAPIPlugin/AudioPlayer.h: Added.
  • NetscapeMuteAPIPlugin/AudioPlayer.mm: Added.

(-[AudioPlayer initWithURL:]):
(-[AudioPlayer dealloc]):
(-[AudioPlayer isReadyToPlay]):
(-[AudioPlayer isPlaying]):
(-[AudioPlayer setPlaying:]):
(-[AudioPlayer isMuted]):
(-[AudioPlayer setMuted:]):
(-[AudioPlayer observeValueForKeyPath:ofObject:change:context:]):

  • NetscapeMuteAPIPlugin/English.lproj/InfoPlist.strings: Added.
  • NetscapeMuteAPIPlugin/Info.plist: Added.
  • NetscapeMuteAPIPlugin/MenuHandler.h: Added.
  • NetscapeMuteAPIPlugin/MenuHandler.m: Added.

(-[MenuHandler _play:]):
(-[MenuHandler _pause:]):
(-[MenuHandler validateUserInterfaceItem:]):
(-[MenuHandler initWithAudioPlayer:]):
(-[MenuHandler dealloc]):
(-[MenuHandler menu]):

  • NetscapeMuteAPIPlugin/NetscapeMuteAPIPlugin.xcodeproj/project.pbxproj: Added.
  • NetscapeMuteAPIPlugin/main.m: Added.

(-[PluginObject initWithNPP:audioURL:]):
(-[PluginObject dealloc]):
(-[PluginObject menuHandler]):
(-[PluginObject isPlayingAudio]):
(-[PluginObject isMuted]):
(-[PluginObject setMuted:]):
(-[PluginObject readyStateDidChangeForAudioPlayer:]):
(-[PluginObject mutedStateDidChangeForAudioPlayer:]):
(-[PluginObject playStateDidChangeForAudioPlayer:]):
(-[PluginObject _invalidateDisplayString]):
(NP_Initialize):
(NP_GetEntryPoints):
(NP_Shutdown):
(NPP_New):
(NPP_Destroy):
(NPP_SetWindow):
(NPP_NewStream):
(NPP_DestroyStream):
(NPP_WriteReady):
(NPP_Write):
(NPP_StreamAsFile):
(NPP_Print):
(handleDraw):
(invalidatePlugin):
(handleMouseEvent):
(NPP_HandleEvent):
(NPP_URLNotify):
(NPP_GetValue):
(NPP_SetValue):

  • NetscapeMuteAPIPlugin/test.html: Added.
7:12 PM Changeset in webkit [176784] by bshafiei@apple.com
  • 2 edits in tags/Safari-601.1.11/Source/WebKit2

Merged r176769. rdar://problem/19132975

7:10 PM Changeset in webkit [176783] by bshafiei@apple.com
  • 2 edits in tags/Safari-601.1.11/Source/WebKit2

Merged r176764. rdar://problem/19132975

7:08 PM Changeset in webkit [176782] by bshafiei@apple.com
  • 12 edits in tags/Safari-601.1.11/Source/WebKit2

Merged r176762. rdar://problem/19132975

7:05 PM Changeset in webkit [176781] by bshafiei@apple.com
  • 2 edits in tags/Safari-601.1.11/Source/WebKit/mac

Merged r176755. rdar://problem/19132978

7:02 PM Changeset in webkit [176780] by commit-queue@webkit.org
  • 11 edits in trunk/Source/WebCore

Use std::unique_ptr instead of PassOwnPtr|OwnPtr for Pasteboard
​https://bugs.webkit.org/show_bug.cgi?id=139019

Patch by Joonghun Park <​jh718.park@samsung.com> on 2014-12-03
Reviewed by Darin Adler.

No new tests, no behavior changes.

  • dom/DataTransfer.cpp:

(WebCore::DataTransfer::DataTransfer):

  • dom/DataTransfer.h:
  • editing/Editor.cpp:

(WebCore::Editor::dispatchCPPEvent):

  • page/mac/EventHandlerMac.mm:

(WebCore::EventHandler::createDraggingDataTransfer):

  • platform/Pasteboard.h:
  • platform/efl/PasteboardEfl.cpp:

(WebCore::Pasteboard::createForCopyAndPaste):
(WebCore::Pasteboard::createPrivate):
(WebCore::Pasteboard::createForDragAndDrop):

  • platform/gtk/PasteboardGtk.cpp:

(WebCore::Pasteboard::createForCopyAndPaste):
(WebCore::Pasteboard::createForGlobalSelection):
(WebCore::Pasteboard::createPrivate):
(WebCore::Pasteboard::createForDragAndDrop):
(WebCore::Pasteboard::create): Deleted.

  • platform/ios/PasteboardIOS.mm:

(WebCore::Pasteboard::createForCopyAndPaste):
(WebCore::Pasteboard::createPrivate):

  • platform/mac/PasteboardMac.mm:

(WebCore::Pasteboard::createForCopyAndPaste):
(WebCore::Pasteboard::createPrivate):
(WebCore::Pasteboard::createForDragAndDrop):
(WebCore::Pasteboard::create): Deleted.

  • platform/win/PasteboardWin.cpp:

(WebCore::Pasteboard::createForCopyAndPaste):
(WebCore::Pasteboard::createPrivate):
(WebCore::Pasteboard::createForDragAndDrop):

6:52 PM Changeset in webkit [176779] by gyuyoung.kim@samsung.com
  • 10 edits in trunk/Source/JavaScriptCore

Move JavaScriptCore/dfg to std::unique_ptr
​https://bugs.webkit.org/show_bug.cgi?id=139169

Reviewed by Filip Pizlo.

Use std::unique_ptr<>|std::make_unique<> in JavaScriptCore/dfg directory.

  • dfg/DFGBasicBlock.h:
  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::JITCompiler):
(JSC::DFG::JITCompiler::compile):
(JSC::DFG::JITCompiler::link):
(JSC::DFG::JITCompiler::compileFunction):
(JSC::DFG::JITCompiler::linkFunction):

  • dfg/DFGJITCompiler.h:
  • dfg/DFGPlan.cpp:

(JSC::DFG::Plan::compileInThreadImpl):
(JSC::DFG::Plan::cancel):

  • dfg/DFGPlan.h:
  • dfg/DFGSlowPathGenerator.h:
  • dfg/DFGWorklist.h:
  • ftl/FTLFail.cpp:

(JSC::FTL::fail):

  • ftl/FTLState.cpp:

(JSC::FTL::State::State):

6:43 PM Changeset in webkit [176778] by roger_fong@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed. Some webgl conformance tests crash.
<rdar://problem/19136723>

  • platform/mac/TestExpectations:
6:32 PM Changeset in webkit [176777] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit/mac

Implement action menus for tel: URLs
​https://bugs.webkit.org/show_bug.cgi?id=139240
<rdar://problem/19115662>

Reviewed by Anders Carlsson.

  • WebView/WebActionMenuController.mm:

(-[WebActionMenuController _defaultMenuItemsForDataDetectableLink]):
Make sure to use the newly created currentActionContext... everywhere.

6:32 PM Changeset in webkit [176776] by roger_fong@apple.com
  • 3 edits
    2961 adds
    1 delete in trunk/LayoutTests

Unreviewed. Add 1.0.3 conformance tests. Remove unused webgl test resource files.

  • platform/mac/TestExpectations: Skipping 1.0.3 tests until we are at least somewhat conformant.
  • webgl/1.0.3: Added.
  • webgl/resources/webgl_test_files: Removed
6:28 PM Changeset in webkit [176775] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit/mac

Implement action menus for tel: URLs
​https://bugs.webkit.org/show_bug.cgi?id=139240
<rdar://problem/19115662>

Reviewed by Anders Carlsson.

  • WebView/WebActionMenuController.mm:

(-[WebActionMenuController _defaultMenuItemsForDataDetectableLink]):
Make sure to use the newly created currentActionContext.

6:12 PM Changeset in webkit [176774] by bshafiei@apple.com
  • 5 edits in tags/Safari-601.1.11/Source

Versioning.

6:09 PM Changeset in webkit [176773] by bshafiei@apple.com
  • 1 copy in tags/Safari-601.1.11

New tag.

6:06 PM Changeset in webkit [176772] by benjamin@webkit.org
  • 3 edits in trunk/Source/WebCore

Get rid of FrameLoaderClient::dispatchWillRequestResource
​https://bugs.webkit.org/show_bug.cgi?id=139235

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2014-12-03
Reviewed by Alexey Proskuryakov.

It is useless.

  • loader/FrameLoaderClient.h:

(WebCore::FrameLoaderClient::dispatchWillRequestResource): Deleted.

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::requestResource):

5:59 PM Changeset in webkit [176771] by msaboff@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

REGRESSION (r176479): DFG ASSERTION beneath emitOSRExitCall running Kraken/imaging-gaussian-blur.js.ftl-no-cjit-osr-validation and other tests
​https://bugs.webkit.org/show_bug.cgi?id=139246

Reviewed by Geoffrey Garen.

  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::buildExitArguments):
The DFG_ASSERT that checks liveness at exit time doesn't properly
handle the case where the local is not available at OSR exit time,
but the local is live in the bytecode. This now happens with the
allocated scope register when we are compiling for FTLForOSREntryMode
due to DCE done when the control flow was changed and a new entrypoint
was added in the OSR entrypoint creation phase. Therefore we silence
the assert when compiling for FTLForOSREntryMode.

5:40 PM Changeset in webkit [176770] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Missing getter, clients never see DragToAdjustController is enabled
​https://bugs.webkit.org/show_bug.cgi?id=139228

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-12-03
Reviewed by Simon Fraser.

  • UserInterface/Controllers/DragToAdjustController.js:

(WebInspector.DragToAdjustController.prototype.get enabled):

5:31 PM Changeset in webkit [176769] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

Unreviewed, rolling out r176457.
​https://bugs.webkit.org/show_bug.cgi?id=139247

More iOS breakage (Requested by andersca on #webkit).

Reverted changeset:

"Fix iOS build."
​http://trac.webkit.org/changeset/176457

5:30 PM Changeset in webkit [176768] by mmaxfield@apple.com
  • 3 edits
    2 adds in trunk

List markers in RTL languages do not draw the first character.
​https://bugs.webkit.org/show_bug.cgi?id=139244

Reviewed by Simon Fraser.

Source/WebCore:

Off-by-one error when reversing the string (from LTR to RTL)

Test: fast/lists/rtl-marker.html

  • rendering/RenderListMarker.cpp:

(WebCore::RenderListMarker::paint):

LayoutTests:

  • fast/lists/rtl-marker-expected.html: Added.
  • fast/lists/rtl-marker.html: Added.
5:08 PM Changeset in webkit [176767] by bshafiei@apple.com
  • 5 edits in tags/Safari-600.3.8.2/Source

Versioning.

5:06 PM Changeset in webkit [176766] by Beth Dakin
  • 11 edits in trunk/Source

<input> elements get whitespace action menu instead of editable text menu
​https://bugs.webkit.org/show_bug.cgi?id=139241
-and corresponding-
rdar://problem/19072083

Reviewed by Sam Weinig.

Source/WebCore:

Since we will hit test form controls as form controls, we need a new function to
determine if the hit point is over text inside that form control or not.

  • WebCore.exp.in:
  • rendering/HitTestResult.cpp:

(WebCore::HitTestResult::isOverTextInsideFormControlElement):

  • rendering/HitTestResult.h:

Source/WebKit/mac:

We should disallow shadow content in the hit test. This is the default and it is
how context menus behave. We originally wanted to text inside shadow content so
that we could find the text, but the new function I added to HitTestResult will
allow that.

  • WebView/WebActionMenuController.mm:

(-[WebActionMenuController performHitTestAtPoint:]):

Adjust to the fact that we don’t hit test shadow content any more.
(-[WebActionMenuController focusAndSelectHitTestResult]):

Offer the text menus for text inside form controls.
(-[WebActionMenuController _defaultMenuItems]):

Source/WebKit2:

Add isOverTextInsideFormControlElement to WebHitTestResult.

  • Shared/WebHitTestResult.cpp:

(WebKit::WebHitTestResult::Data::Data):
(WebKit::WebHitTestResult::Data::encode):
(WebKit::WebHitTestResult::Data::decode):

  • Shared/WebHitTestResult.h:

(WebKit::WebHitTestResult::isOverTextInsideFormControlElement):

Offer the text menus for text inside form controls.

  • UIProcess/mac/WKActionMenuController.mm:

(-[WKActionMenuController _defaultMenuItems]):

We should disallow shadow content in the hit test. This is the default and it is
how context menus behave. We originally wanted to text inside shadow content so
that we could find the text, but the new function I added to HitTestResult will
allow that.

  • WebProcess/WebPage/mac/WebPageMac.mm:

Adjust to the fact that we don’t hit test shadow content any more.
(WebKit::WebPage::performActionMenuHitTestAtLocation):
(WebKit::WebPage::lookupTextAtLocation):
(WebKit::WebPage::focusAndSelectLastActionMenuHitTestResult):

5:04 PM Changeset in webkit [176765] by bshafiei@apple.com
  • 1 copy in tags/Safari-600.3.8.2

New tag.

4:51 PM Changeset in webkit [176764] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

Unreviewed, rolling out r176489.
​https://bugs.webkit.org/show_bug.cgi?id=139242

More iOS breakage (Requested by andersca on #webkit).

Reverted changeset:

"Unreviewed, iOS build fix after r176452."
​http://trac.webkit.org/changeset/176489

4:33 PM Changeset in webkit [176763] by timothy_horton@apple.com
  • 6 edits in trunk/Source

Implement action menus for tel: URLs
​https://bugs.webkit.org/show_bug.cgi?id=139240
<rdar://problem/19115662>

Reviewed by Anders Carlsson.

  • WebView/WebActionMenuController.mm:

(-[WebActionMenuController _defaultMenuItemsForDataDetectableLink]):
Rename this function as it will work for both mailto and tel URLs.
Adjust it to use contextForView:.

(-[WebActionMenuController webView:willHandleMouseDown:]):
(-[WebActionMenuController prepareForMenu:withEvent:]):
(-[WebActionMenuController didCloseMenu:withEvent:]):
(-[WebActionMenuController _defaultMenuItems]):
Don't check the menu type when going to interact with _currentActionContext.
We'll only have a _currentActionContext if we have a data detected item,
and there are multiple menu types that end up using DDActionContext.

  • WebView/WebUIDelegatePrivate.h:

Add a new type.

  • Shared/API/c/WKActionMenuTypes.h:

Add a new type.

  • UIProcess/mac/WKActionMenuController.mm:

(-[WKActionMenuController _defaultMenuItemsForDataDetectableLink]):
Rename this function as it will work for both mailto and tel URLs.
Adjust it to use contextForView:.

(-[WKActionMenuController _clearActionMenuState]):
(-[WKActionMenuController menuNeedsUpdate:]):
(-[WKActionMenuController _defaultMenuItems]):
Don't check the menu type when going to interact with _currentActionContext.
We'll only have a _currentActionContext if we have a data detected item,
and there are multiple menu types that end up using DDActionContext.

4:16 PM Changeset in webkit [176762] by andersca@apple.com
  • 12 edits in trunk/Source/WebKit2

Unreviewed, rolling out r176452 and r176559.
​https://bugs.webkit.org/show_bug.cgi?id=139239

Broke iOS (Requested by andersca on #webkit).

Reverted changesets:

"Remove alignment code from IPC coders"
​https://bugs.webkit.org/show_bug.cgi?id=138963
​http://trac.webkit.org/changeset/176452

"[WK2] SecComp buildfix after r176452"
​https://bugs.webkit.org/show_bug.cgi?id=139081
​http://trac.webkit.org/changeset/176559

Patch by Commit Queue <​commit-queue@webkit.org> on 2014-12-03

4:00 PM Changeset in webkit [176761] by Chris Dumez
  • 1 edit
    1 add in trunk/LayoutTests

Unreviewed gardening.

Land expected result for fast/dom/timer-throttle-on-scrolling-iframe-away.html
that was missing in r176729.

  • fast/dom/timer-throttle-on-scrolling-iframe-away-expected.txt: Added.
3:53 PM Changeset in webkit [176760] by bshafiei@apple.com
  • 5 edits in tags/Safari-600.3.8.1/Source

Versioning.

3:53 PM Changeset in webkit [176759] by roger_fong@apple.com
  • 2 edits
    2 deletes in trunk/LayoutTests

Unreviewed. Remove 1.0.1 and experimental 1.0.3 WebGL conformance tests to make way for official 1.0.3 tests.

3:50 PM Changeset in webkit [176758] by bshafiei@apple.com
  • 1 copy in tags/Safari-600.3.8.1

New tag.

3:39 PM Changeset in webkit [176757] by ap@apple.com
  • 1 edit
    1 copy
    1 add in trunk/LayoutTests

http/tests/misc/authentication-redirect tests use the same authentication realm
​https://bugs.webkit.org/show_bug.cgi?id=139225

Land custom results for WebKit2, because the format of output is different there.

  • platform/wk2/http/tests/misc/authentication-redirect-3: Added.
  • platform/wk2/http/tests/misc/authentication-redirect-3/authentication-sent-to-redirect-same-origin-with-location-credentials-expected.txt: Copied from LayoutTests/http/tests/misc/authentication-redirect-3/authentication-sent-to-redirect-same-origin-with-location-credentials-expected.txt.
3:23 PM Changeset in webkit [176756] by ggaren@apple.com
  • 12 edits in trunk/Source/JavaScriptCore

Removed the global parser arena
​https://bugs.webkit.org/show_bug.cgi?id=139236

Reviewed by Sam Weinig.

Simplifies parser lifetime logic.

There's no need to keep a global arena. We can create a new arena
each time we parse.

  • bytecompiler/BytecodeGenerator.h: Global replace to pass around a

ParserArena instead of VM*, since the VM no longer owns the arena.
(JSC::BytecodeGenerator::parserArena):

  • bytecompiler/NodesCodegen.cpp: Ditto.

(JSC::ArrayNode::toArgumentList):
(JSC::ApplyFunctionCallDotNode::emitBytecode):

  • parser/ASTBuilder.h: Ditto.

(JSC::ASTBuilder::ASTBuilder):
(JSC::ASTBuilder::createSourceElements):
(JSC::ASTBuilder::createCommaExpr):
(JSC::ASTBuilder::createLogicalNot):
(JSC::ASTBuilder::createUnaryPlus):
(JSC::ASTBuilder::createVoid):
(JSC::ASTBuilder::thisExpr):
(JSC::ASTBuilder::createResolve):
(JSC::ASTBuilder::createObjectLiteral):
(JSC::ASTBuilder::createArray):
(JSC::ASTBuilder::createNumberExpr):
(JSC::ASTBuilder::createString):
(JSC::ASTBuilder::createBoolean):
(JSC::ASTBuilder::createNull):
(JSC::ASTBuilder::createBracketAccess):
(JSC::ASTBuilder::createDotAccess):
(JSC::ASTBuilder::createSpreadExpression):
(JSC::ASTBuilder::createRegExp):
(JSC::ASTBuilder::createNewExpr):
(JSC::ASTBuilder::createConditionalExpr):
(JSC::ASTBuilder::createAssignResolve):
(JSC::ASTBuilder::createFunctionExpr):
(JSC::ASTBuilder::createFunctionBody):
(JSC::ASTBuilder::createGetterOrSetterProperty):
(JSC::ASTBuilder::createArguments):
(JSC::ASTBuilder::createArgumentsList):
(JSC::ASTBuilder::createProperty):
(JSC::ASTBuilder::createPropertyList):
(JSC::ASTBuilder::createElementList):
(JSC::ASTBuilder::createFormalParameterList):
(JSC::ASTBuilder::createClause):
(JSC::ASTBuilder::createClauseList):
(JSC::ASTBuilder::createFuncDeclStatement):
(JSC::ASTBuilder::createBlockStatement):
(JSC::ASTBuilder::createExprStatement):
(JSC::ASTBuilder::createIfStatement):
(JSC::ASTBuilder::createForLoop):
(JSC::ASTBuilder::createForInLoop):
(JSC::ASTBuilder::createForOfLoop):
(JSC::ASTBuilder::createEmptyStatement):
(JSC::ASTBuilder::createVarStatement):
(JSC::ASTBuilder::createEmptyVarExpression):
(JSC::ASTBuilder::createReturnStatement):
(JSC::ASTBuilder::createBreakStatement):
(JSC::ASTBuilder::createContinueStatement):
(JSC::ASTBuilder::createTryStatement):
(JSC::ASTBuilder::createSwitchStatement):
(JSC::ASTBuilder::createWhileStatement):
(JSC::ASTBuilder::createDoWhileStatement):
(JSC::ASTBuilder::createLabelStatement):
(JSC::ASTBuilder::createWithStatement):
(JSC::ASTBuilder::createThrowStatement):
(JSC::ASTBuilder::createDebugger):
(JSC::ASTBuilder::createConstStatement):
(JSC::ASTBuilder::appendConstDecl):
(JSC::ASTBuilder::combineCommaNodes):
(JSC::ASTBuilder::createDeconstructingAssignment):
(JSC::ASTBuilder::Scope::Scope):
(JSC::ASTBuilder::createNumber):
(JSC::ASTBuilder::makeTypeOfNode):
(JSC::ASTBuilder::makeDeleteNode):
(JSC::ASTBuilder::makeNegateNode):
(JSC::ASTBuilder::makeBitwiseNotNode):
(JSC::ASTBuilder::makeMultNode):
(JSC::ASTBuilder::makeDivNode):
(JSC::ASTBuilder::makeModNode):
(JSC::ASTBuilder::makeAddNode):
(JSC::ASTBuilder::makeSubNode):
(JSC::ASTBuilder::makeLeftShiftNode):
(JSC::ASTBuilder::makeRightShiftNode):
(JSC::ASTBuilder::makeURightShiftNode):
(JSC::ASTBuilder::makeBitOrNode):
(JSC::ASTBuilder::makeBitAndNode):
(JSC::ASTBuilder::makeBitXOrNode):
(JSC::ASTBuilder::makeFunctionCallNode):
(JSC::ASTBuilder::makeBinaryNode):
(JSC::ASTBuilder::makeAssignNode):
(JSC::ASTBuilder::makePrefixNode):
(JSC::ASTBuilder::makePostfixNode):

  • parser/NodeConstructors.h: Ditto.

(JSC::ParserArenaFreeable::operator new):
(JSC::ParserArenaDeletable::operator new):
(JSC::ParserArenaRefCounted::ParserArenaRefCounted):

  • parser/Nodes.cpp: Ditto.

(JSC::ScopeNode::ScopeNode):
(JSC::ProgramNode::ProgramNode):
(JSC::ProgramNode::create):
(JSC::EvalNode::EvalNode):
(JSC::EvalNode::create):
(JSC::FunctionBodyNode::FunctionBodyNode):
(JSC::FunctionBodyNode::create):

  • parser/Nodes.h: Ditto.

(JSC::ScopeNode::parserArena):

  • parser/Parser.cpp:

(JSC::Parser<LexerType>::Parser):
(JSC::Parser<LexerType>::parseInner):
(JSC::Parser<LexerType>::parseProperty): The parser now owns its own
arena, and transfers ownership of its contents when invoking the ScopeNode
constructor.

  • parser/Parser.h:

(JSC::Parser<LexerType>::parse): No need to explicitly reset the arena,
since its lifetime is tied to the parser's lifetime now.

  • parser/SyntaxChecker.h:

(JSC::SyntaxChecker::createProperty):
(JSC::SyntaxChecker::createGetterOrSetterProperty):

  • runtime/VM.cpp:

(JSC::VM::VM):

  • runtime/VM.h: The point of the patch: no more global.
3:01 PM Changeset in webkit [176755] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit/mac

Set a visited link store when creating a simple WebView
​https://bugs.webkit.org/show_bug.cgi?id=139234
<rdar://problem/19132978>

Reviewed by Sam Weinig.

  • WebView/WebView.mm:

(-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):

1:54 PM Changeset in webkit [176754] by ggaren@apple.com
  • 6 edits in trunk/Source/JavaScriptCore

The parser should allocate all pieces of the AST
​https://bugs.webkit.org/show_bug.cgi?id=139230

Reviewed by Oliver Hunt.

This is a step toward a 14% parsing speedup.

Previously, allocation was split between the parser and certain node
constructor functions. This made for some duplicated code and circular
dependencies.

  • parser/ASTBuilder.h:

(JSC::ASTBuilder::createGetterOrSetterProperty): No need to pass through
the VM, since our callee no longer needs to allocate anything.

(JSC::ASTBuilder::createProperty): Allocate the identifier for our
callee, since that is simpler than requiring our callee to notice that
we didn't do so, and do it for us.

(JSC::ASTBuilder::createForInLoop): Allocate the DeconstructingAssignmentNode
for our callee, since that is simpler than requiring our callee to notice
that we didn't do so, and do it for us.

Also, reuse some code instead of duplicating it.

(JSC::ASTBuilder::createForOfLoop): Ditto.

(JSC::ASTBuilder::createArrayPattern):
(JSC::ASTBuilder::createObjectPattern):
(JSC::ASTBuilder::createBindingLocation): No need to pass through a VM
pointer, since our callee no longer needs to allocate anything.

(JSC::ASTBuilder::createBreakStatement): Deleted.
(JSC::ASTBuilder::createContinueStatement): Deleted.

  • parser/NodeConstructors.h:

(JSC::PropertyNode::PropertyNode):
(JSC::DeconstructionPatternNode::DeconstructionPatternNode):
(JSC::ArrayPatternNode::ArrayPatternNode):
(JSC::ArrayPatternNode::create):
(JSC::ObjectPatternNode::ObjectPatternNode):
(JSC::ObjectPatternNode::create):
(JSC::BindingNode::create):
(JSC::BindingNode::BindingNode):
(JSC::ContinueNode::ContinueNode): Deleted.
(JSC::BreakNode::BreakNode): Deleted.
(JSC::EnumerationNode::EnumerationNode): Deleted.
(JSC::ForInNode::ForInNode): Deleted.
(JSC::ForOfNode::ForOfNode): Deleted. Deleted a bunch of special cases
that don't exist anymore, now that the parser allocates all pieces of
the AST unconditionally.

  • parser/Nodes.h: Ditto.
  • parser/Parser.cpp:

(JSC::Parser<LexerType>::parseBreakStatement):
(JSC::Parser<LexerType>::parseContinueStatement): Allocate the null
identifier for our callee, since that is simpler than requiring our
callee to notice that we didn't do so, and do it for us.

(JSC::Parser<LexerType>::parseProperty):

  • parser/SyntaxChecker.h:

(JSC::SyntaxChecker::createProperty): No need to pass through a VM
pointer, since our callee no longer needs to allocate anything.

1:53 PM Changeset in webkit [176753] by timothy_horton@apple.com
  • 18 edits in trunk/Source

Keyboard input should be disabled in the preview popover
​https://bugs.webkit.org/show_bug.cgi?id=139219
<rdar://problem/19052381>

Reviewed by Anders Carlsson.

Make sure that keyboard input, Quick Look, etc. are blocked in preview popovers
and WKThumbnailViews. Also block the fake mouseMove events that originate in
the Web process upon scrolling, because we were missing those despite blocking
ordinary mouseMove events.

  • page/ChromeClient.h:

(WebCore::ChromeClient::shouldDispatchFakeMouseMoveEvents):

  • page/EventHandler.cpp:

(WebCore::EventHandler::dispatchFakeMouseMoveEventSoon):
Allow ChromeClient to disable the dispatch of "fake" mouseMove events
that happens during scrolling.

  • UIProcess/API/Cocoa/WKViewPrivate.h:
  • UIProcess/API/mac/WKView.mm:

Rename _ignoresNonWheelMouseEvents to _ignoresNonWheelEvents, because it will
apply not only to mouse events but also key events, Quick Look events, menu
preparation events, swipe events, etc.

Add _ignoresAllEvents, which means the same thing as _ignoresNonWheelEvents
with the addition of ignoring scrollWheel events.

(-[WKView scrollWheel:]):
(-[WKView swipeWithEvent:]):
(-[WKView mouseMoved:]):
(-[WKView mouseDown:]):
(-[WKView mouseUp:]):
(-[WKView mouseDragged:]):
Adjust to the new name.

(-[WKView performKeyEquivalent:]):
(-[WKView keyUp:]):
(-[WKView keyDown:]):
(-[WKView flagsChanged:]):
(-[WKView quickLookWithEvent:]):
(-[WKView prepareForMenu:withEvent:]):
(-[WKView willOpenMenu:withEvent:]):
(-[WKView didCloseMenu:withEvent:]):
Block all of these events as well as those we were previously blocking.

(-[WKView _setIgnoresAllEvents:]):
(-[WKView _setIgnoresNonWheelMouseEvents:]):
(-[WKView _setIgnoresNonWheelEvents:]):
(-[WKView _ignoresNonWheelEvents]):
(-[WKView _ignoresAllEvents]):

  • UIProcess/API/mac/WKViewInternal.h:

Adjust to the new names and the addition of ignoresAllEvents.

  • UIProcess/mac/WKActionMenuController.mm:

(-[WKPagePreviewViewController loadView]):
Adjust to the new name.

(-[WKActionMenuController prepareForMenu:withEvent:]):
Move bailing from prepareForMenu: up to WKView.

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _ignoresNonWheelEvents]):
(-[WKWebView _setIgnoresNonWheelEvents:]):
(-[WKWebView _ignoresNonWheelMouseEvents]): Deleted.
(-[WKWebView _setIgnoresNonWheelMouseEvents:]): Deleted.

  • UIProcess/API/Cocoa/WKWebViewInternal.h:

Adjust to the new name (without "mouse" in it).

  • UIProcess/API/Cocoa/_WKThumbnailView.mm:

(-[_WKThumbnailView _viewWasUnparented]):
(-[_WKThumbnailView _viewWasParented]):
Explicitly tell WKView to disable event handling while thumbnailed,
instead of having WKView special-case thumbnail views internally.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::setShouldDispatchFakeMouseMoveEvents):

  • UIProcess/WebPageProxy.h:
  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::shouldDispatchFakeMouseMoveEvents):

  • WebProcess/WebCoreSupport/WebChromeClient.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):

  • WebProcess/WebPage/WebPage.h:

(WebKit::WebPage::shouldDispatchFakeMouseMoveEvents):
(WebKit::WebPage::setShouldDispatchFakeMouseMoveEvents):

  • WebProcess/WebPage/WebPage.messages.in:

Plumb shouldDispatchFakeMouseMoveEvents from the UI process to the Web process
and through to WebKit2's ChromeClient implementation.

1:45 PM Changeset in webkit [176752] by ap@apple.com
  • 6 edits in trunk/LayoutTests

http/tests/misc/authentication-redirect tests use the same authentication realm
​https://bugs.webkit.org/show_bug.cgi?id=139225

Reviewed by Tim Horton.

  • http/tests/misc/authentication-redirect-1/resources/auth-then-redirect.php:
  • http/tests/misc/authentication-redirect-2/resources/auth-then-redirect.php:
  • http/tests/misc/authentication-redirect-3/resources/auth-then-redirect-with-url-credentials.php:
  • http/tests/misc/authentication-redirect-3/resources/auth-then-redirect.php:

Use different realms.

  • http/tests/misc/authentication-redirect-3/authentication-sent-to-redirect-same-origin-with-location-credentials-expected.txt:

This test's results no longer depend on previous tests.

1:01 PM Changeset in webkit [176751] by Antti Koivisto
  • 15 edits in trunk/Source/WebCore

Remove genericFamily enum from FontDescription
​https://bugs.webkit.org/show_bug.cgi?id=139207

Reviewed by Andreas Kling.

We use predefined AtomicStrings for generic families. The side enum adds no information.

  • css/CSSFontSelector.cpp:

(WebCore::resolveGenericFamily):
(WebCore::CSSFontSelector::getFontData):

Match the existing quirk where the default font can be replaced by @font-face rule but user generic families can't.

(WebCore::CSSFontSelector::resolvesFamilyFor):
(WebCore::fontDataForGenericFamily): Deleted.

  • css/DeprecatedStyleBuilder.cpp:

(WebCore::ApplyPropertyFontFamily::applyInheritValue):
(WebCore::ApplyPropertyFontFamily::applyInitialValue):
(WebCore::ApplyPropertyFontFamily::applyValue):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::checkForGenericFamilyChange):

Remove the explicit monospace check, earlier useFixedDefaultSize check is equivalent.

(WebCore::StyleResolver::initializeFontStyle):

  • platform/graphics/FontDescription.h:

(WebCore::FontDescription::FontDescription):
(WebCore::FontDescription::useFixedDefaultSize):
(WebCore::FontDescription::setWeight):
(WebCore::FontDescription::equalForTextAutoSizing):
(WebCore::FontDescription::operator==):
(WebCore::FontDescription::genericFamily): Deleted.
(WebCore::FontDescription::setGenericFamily): Deleted.

  • platform/mac/ThemeMac.mm:

(WebCore::ThemeMac::controlFont):

  • rendering/RenderTheme.cpp:

(WebCore::RenderTheme::adjustStyle):

Reset the lineheight unconditionally for buttons.
This always happened before because the explicitly set generic family made the font compare false.

  • rendering/RenderThemeIOS.mm:

(WebCore::RenderThemeIOS::systemFont):

  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::systemFont):
(WebCore::RenderThemeMac::setFontFromControlSize):

  • style/StyleResolveForDocument.cpp:

(WebCore::Style::resolveForDocument):

Resolve document style for final value immediately as it can't be affected by @font-face rules.

12:53 PM Changeset in webkit [176750] by Alan Bujtas
  • 3 edits
    2 adds in trunk

ASSERTION: RenderMultiColumnFlowThread::processPossibleSpannerDescendant() when column spanner's parent is not a RenderBlockFlow.
​https://bugs.webkit.org/show_bug.cgi?id=139188
rdar://problem/18502182

Reviewed by David Hyatt.

This patch ensures that the validation check for spanner in isValidColumnSpanner() is in synch
with the expectation in RenderMultiColumnFlowThread::processPossibleSpannerDescendant().
(descendant's parent is expected to be a RenderBlockFlow)

Source/WebCore:

Test: fast/multicol/svg-content-as-column-spanner-crash.html

  • rendering/RenderMultiColumnFlowThread.cpp:

(WebCore::isValidColumnSpanner):

LayoutTests:

  • fast/multicol/svg-content-as-column-spanner-crash-expected.txt: Added.
  • fast/multicol/svg-content-as-column-spanner-crash.html: Added.
12:42 PM Changeset in webkit [176749] by dburkart@apple.com
  • 3 edits in branches/safari-600.3-branch/Source/WebKit/mac

Merged r176695. rdar://problems/19120929

12:37 PM Changeset in webkit [176748] by commit-queue@webkit.org
  • 5 edits in trunk/Source

[TexMap] Redundant method in GraphicsLayerTextureMapper.
​https://bugs.webkit.org/show_bug.cgi?id=138005

Patch by ​peavo@outlook.com <​peavo@outlook.com> on 2014-12-03
Reviewed by Alex Christensen.

The TextureMapperLayer method descendantsOrSelfHaveRunningAnimations() can be used
instead of the GraphicsLayerTextureMapper method startedAnimation().

Source/WebCore:

  • platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:

(WebCore::GraphicsLayerTextureMapper::GraphicsLayerTextureMapper):
(WebCore::GraphicsLayerTextureMapper::addAnimation):

  • platform/graphics/texmap/GraphicsLayerTextureMapper.h:

Source/WebKit/win:

  • WebCoreSupport/AcceleratedCompositingContext.cpp:

(AcceleratedCompositingContext::startedAnimation):

12:36 PM Changeset in webkit [176747] by dburkart@apple.com
  • 2 edits in branches/safari-600.3-branch/Source/WebCore

Merged r176694. rdar://problems/18944696

12:36 PM Changeset in webkit [176746] by dburkart@apple.com
  • 2 edits in branches/safari-600.3-branch/Source/WebKit/mac

Merged r176693. rdar://problems/18944696

12:36 PM Changeset in webkit [176745] by dburkart@apple.com
  • 2 edits in branches/safari-600.3-branch/Source/WebCore

Merged r176692. rdar://problems/18944696

12:36 PM Changeset in webkit [176744] by dburkart@apple.com
  • 4 edits in branches/safari-600.3-branch/Source

Merged r176691. rdar://problems/18944696

12:36 PM Changeset in webkit [176743] by dburkart@apple.com
  • 4 edits in branches/safari-600.3-branch/Source

Merged r176690. rdar://problems/18944696

12:35 PM Changeset in webkit [176742] by dburkart@apple.com
  • 2 edits in branches/safari-600.3-branch/Source/WebCore

Merged r176689. rdar://problems/18944696

12:35 PM Changeset in webkit [176741] by dburkart@apple.com
  • 2 edits in branches/safari-600.3-branch/Source/WebCore

Merged r176688. rdar://problems/18944696

12:35 PM Changeset in webkit [176740] by dburkart@apple.com
  • 8 edits
    2 adds in branches/safari-600.3-branch/Source

Merged r176684. rdar://problems/18944696

12:30 PM Changeset in webkit [176739] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Remove ENABLE_UI_PROCESS_STORAGE define, it's always 1.

Rubber-stamped by Beth Dakin.

  • WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:

(WebKit::WebPlatformStrategies::localStorageNamespace):
(WebKit::WebPlatformStrategies::transientLocalStorageNamespace):
(WebKit::WebPlatformStrategies::sessionStorageNamespace):

12:16 PM Changeset in webkit [176738] by dburkart@apple.com
  • 2 edits in branches/safari-600.3-branch/Source/WebKit/mac

Merged r176681. rdar://problems/19067172

12:15 PM Changeset in webkit [176737] by dburkart@apple.com
  • 7 edits
    1 add in branches/safari-600.3-branch/Source/WebKit

Merged r176680. rdar://problems/19067172

12:13 PM Changeset in webkit [176736] by dburkart@apple.com
  • 2 edits in branches/safari-600.3-branch/Source/WebKit2

Merged r176678. rdar://problems/19072236

12:10 PM Changeset in webkit [176735] by dburkart@apple.com
  • 2 edits in branches/safari-600.3-branch/Source/WebCore

Fix merge-related build failure. rdar://problem/19122588

12:03 PM Changeset in webkit [176734] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Subtitle menu should only appear when useful.
​https://bugs.webkit.org/show_bug.cgi?id=139133

Patch by Jeremy Jones <​jeremyj@apple.com> on 2014-12-03
Reviewed by Eric Carlson.

  • platform/ios/WebVideoFullscreenInterfaceAVKit.mm:

(-[WebAVPlayerController hasLegibleMediaSelectionOptions]): only enable when there are non default options.
(-[WebAVPlayerController hasAudioMediaSelectionOptions]): only enable when there is more than one option.

11:59 AM Changeset in webkit [176733] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Use an @autoreleasepool instead of NSAutoreleasePool.

Rubber-stamped by Tim Horton.

  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::flushLayers):

11:55 AM Changeset in webkit [176732] by dburkart@apple.com
  • 3 edits
    2 adds in branches/safari-600.3-branch

Merged r176295. rdar://problems/19122588

11:51 AM Changeset in webkit [176731] by jdiggs@igalia.com
  • 17 edits in trunk

AX: [ATK] Inline text elements with accessible object attributes and/or event handlers are not exposed
​https://bugs.webkit.org/show_bug.cgi?id=139071

Reviewed by Chris Fleizach.

Source/WebCore:

Adds a new InlineRole accessibility role type for non-focusable inline
elements which have an event handler or attribute suggesting possible
inclusion by the platform. This is mapped to ATK_ROLE_STATIC for GTK and
EFL. On the Mac, it is currently ignored to preserve existing behavior.

Added new test cases to the existing roles-exposed.html test.

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::supportsDatetimeAttribute): Added.

  • accessibility/AccessibilityObject.h: Added InlineRole.
  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::determineAccessibilityRole): Handle InlineRole.

  • accessibility/atk/AccessibilityObjectAtk.cpp:

(WebCore::AccessibilityObject::accessibilityPlatformIncludesObject): Include InlineRole objects.

  • accessibility/atk/WebKitAccessibleWrapperAtk.cpp:

(atkRole):

  • accessibility/mac/AccessibilityObjectMac.mm:

(WebCore::AccessibilityObject::accessibilityPlatformIncludesObject): Ignore InlineRole objects.

  • html/HTMLTagNames.in: Added 'time'.

Tools:

Add string value for ATK_ROLE_STATIC in roleToString.

  • WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:

LayoutTests:

  • accessibility/roles-exposed.html: New test cases added.
  • platform/efl/accessibility/roles-exposed-expected.txt: Updated for new test cases.
  • platform/gtk/accessibility/roles-exposed-expected.txt: Updated for new test cases.
  • platform/mac-mavericks/accessibility/roles-exposed-expected.txt: Updated for new test cases.
  • platform/mac-mountainlion/accessibility/roles-exposed-expected.txt: Updated for new test cases.
  • platform/mac/accessibility/roles-exposed-expected.txt: Updated for new test cases.
11:36 AM Changeset in webkit [176730] by dburkart@apple.com
  • 2 edits in branches/safari-600.3-branch/Source/WebCore

Merged r175974. rdar://problems/19122595

11:16 AM Changeset in webkit [176729] by Chris Dumez
  • 1 edit
    2 adds in trunk/LayoutTests

Add layout test for DOM timer throttling in iframe scrolled out of viewport
​https://bugs.webkit.org/show_bug.cgi?id=138884

Reviewed by Andreas Kling.

Add a layout test to test that a repeating DOM timer inside an iframe
get throttled if the iframe is scrolled out of the viewport.

  • fast/dom/resources/timer-throttling-iframe.html: Added.
  • fast/dom/timer-throttle-on-scrolling-iframe-away.html: Added.
11:08 AM Changeset in webkit [176728] by mitz@apple.com
  • 4 edits in trunk

REGRESSION(r176687): Caused webkit2 test assertion failure crashes in WebKit::WebPage::willStartDrag()
​https://bugs.webkit.org/show_bug.cgi?id=139224

Reviewed by Alexey Proskuryakov.

Source/WebKit2:

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::mouseEventSyncForTesting): Wait for the UI process to start dragging if
needed before handling the event.

LayoutTests:

  • platform/wk2/TestExpectations: Unskip the tests.
10:56 AM Changeset in webkit [176727] by bshafiei@apple.com
  • 5 edits in trunk/Source

Versioning.

10:33 AM Changeset in webkit [176726] by mark.lam@apple.com
  • 2 edits in trunk/LayoutTests

Gardening: updating some tests as skips instead of crashes.
<​https://webkit.org/b/139224>

Not reviewed.

  • platform/wk2/TestExpectations:
10:01 AM Changeset in webkit [176725] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

[Mac] Hang when calling -[AVAsset resolvedURL].
​https://bugs.webkit.org/show_bug.cgi?id=139223

Reviewed by Eric Carlson.

On a particularly slow-loading site, a call to -[AVAsset resolvedURL] can take an arbitrarily long
time. Treat this AVAsset property similar to other "metadata" properties, and check the load status
of the property before requesting it.

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::hasSingleSecurityOrigin): Check the load state of -resolvedURL.
(WebCore::MediaPlayerPrivateAVFoundationObjC::resolvedURL): Ditto.
(WebCore::assetMetadataKeyNames): Add @"resolvedURL".

9:55 AM Changeset in webkit [176724] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[GTK] outdated comment
​https://bugs.webkit.org/show_bug.cgi?id=137801

Patch by Michael Catanzaro <Michael Catanzaro> on 2014-12-03
Reviewed by Carlos Garcia Campos.

Remove a comment that is no longer correct.

  • NetworkProcess/gtk/NetworkProcessMainGtk.cpp:
9:50 AM Changeset in webkit [176723] by mark.lam@apple.com
  • 2 edits in trunk/LayoutTests

Gardening: marking some tests as crashes.
<​https://webkit.org/b/139224>

Not reviewed.

  • platform/wk2/TestExpectations:
7:26 AM Changeset in webkit [176722] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebCore

URTBF after r176721 to fix ENABLE(CSS_DEVICE_ADAPTATION) build.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseViewportProperty):

6:46 AM Changeset in webkit [176721] by Chris Dumez
  • 5 edits in trunk/Source/WebCore

Move 'display' CSS property to the new StyleBuilder
​https://bugs.webkit.org/show_bug.cgi?id=139218

Reviewed by Antti Koivisto.

Move 'display' CSS property to the new StyleBuilder.

No new tests, no behavior change.

  • css/CSSPropertyNames.in:
  • css/DeprecatedStyleBuilder.cpp:

(WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder):
(WebCore::ApplyPropertyDisplay::isValidDisplayValue): Deleted.
(WebCore::ApplyPropertyDisplay::applyInheritValue): Deleted.
(WebCore::ApplyPropertyDisplay::applyInitialValue): Deleted.
(WebCore::ApplyPropertyDisplay::applyValue): Deleted.
(WebCore::ApplyPropertyDisplay::createHandler): Deleted.

  • css/StyleBuilderCustom.h:

(WebCore::StyleBuilderCustom::isValidDisplayValue):
(WebCore::StyleBuilderCustom::applyInheritDisplay):
(WebCore::StyleBuilderCustom::applyValueDisplay):

  • css/makeprop.pl:

Add support for passing multiple values for Custom option, e.g.:
'Custom=Inherit|Value'. This was useful as we did not need custom
code for display's initial value.

6:39 AM Changeset in webkit [176720] by dburkart@apple.com
  • 5 edits in branches/safari-600.3-branch/Source

Bump versioning

6:21 AM Changeset in webkit [176719] by Chris Dumez
  • 5 edits in trunk/Source/WebCore

Modernize the CSSParser code
​https://bugs.webkit.org/show_bug.cgi?id=139209

Reviewed by Antti Koivisto.

Modernize the CSSParser code by:

  • Using more references instead of pointers
  • Using nullptr instead of 0

No new tests, no behavior change.

5:32 AM Changeset in webkit [176718] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

check-webkit-style is confused by ternary expression inside first member initializer
​https://bugs.webkit.org/show_bug.cgi?id=136442

Patch by Renato Nagy <​rnagy@inf.u-szeged.hu> on 2014-12-03
Reviewed by Csaba Osztrogonác.

  • Scripts/webkitpy/style/checkers/cpp.py:

(check_member_initialization_list):

4:20 AM Changeset in webkit [176717] by clopez@igalia.com
  • 2 edits
    1 add in trunk/Tools

[GTK] [JHBuild] gst-plugins-bad fails to build if the GNUStep libraries are installed.
​https://bugs.webkit.org/show_bug.cgi?id=139220

Reviewed by Philippe Normand.

  • gtk/jhbuild.modules:
  • gtk/patches/gst-plugins-bad-remove-gnustep-support.patch: Added.
3:34 AM Changeset in webkit [176716] by Csaba Osztrogonác
  • 4 edits in trunk

Remove unused JSC runtime options
​https://bugs.webkit.org/show_bug.cgi?id=133070

Patch by Zsolt Borbely <​zsborbely.u-szeged@partner.samsung.com> on 2014-12-03
Reviewed by Csaba Osztrogonác.

Source/JavaScriptCore:

  • runtime/Options.h:

Tools:

  • Scripts/run-jsc-stress-tests:
3:12 AM Changeset in webkit [176715] by ddkilzer@apple.com
  • 2 edits in trunk/Source/WebCore

[iOS] REGRESSION (r176622): WebCore fails to link

Speculative fix for the following build failure:

Ld WebCore
Undefined symbols for architecture armv7s:

"ZN3JSC10IdentifierC1EPNS_9ExecStateERKN3WTF12AtomicStringE", referenced from:

ZN7WebCoreL24createAccelerationObjectEPKNS_16DeviceMotionData12AccelerationEPN3JSC9ExecStateE in JSDeviceMotionEventCustom.o

  • bindings/js/JSDeviceMotionEventCustom.cpp: Include

<runtime/IdentifierInlines.h> to define missing symbol.

2:09 AM Changeset in webkit [176714] by dino@apple.com
  • 4 edits
    2 adds in trunk

[Media] Audio content shouldn't have fullscreen buttons, even if in a video element
​https://bugs.webkit.org/show_bug.cgi?id=139200
<rdar://problem/18914506>

Reviewed by Eric Carlson.

Source/WebCore:

An audio-only resource, even if loaded into a <video> element, should not
present the fullscreen or optimised fullscreen controls. This includes a
MediaDocument, which is always a <video> element. We can detect this by
examining the length of the videoTracks property as our content loads.

Test: media/audio-as-video-fullscreen.html

  • Modules/mediacontrols/mediaControlsApple.js:

(Controller): Initialize a hasVisualMedia to false.
(Controller.prototype.handleReadyStateChange): If we see a videoTrack, hasVisualMedia is now true.
(Controller.prototype.updateFullscreenButtons): Merge the updateFullscreenButton and
updateOptimizedFullscreenButton methods into this single spot, and check for
hasVisualMedia.
(Controller.prototype.updateFullscreenButton): Deleted.
(Controller.prototype.updateOptimizedFullscreenButton): Deleted.

  • Modules/mediacontrols/mediaControlsBase.js: Do the same for the other ports.

LayoutTests:

Loads an audio file via the video element and checks if the
fullscreen button is visible.

  • media/audio-as-video-fullscreen-expected.txt: Added.
  • media/audio-as-video-fullscreen.html: Added.
2:08 AM Changeset in webkit [176713] by dino@apple.com
  • 3 edits in trunk/Source/WebCore

Missing support for innerHTML on SVGElement
​https://bugs.webkit.org/show_bug.cgi?id=136903

Unreviewed followup from r176630. Minor style nits that I missed in my review.

  • dom/Element.h: Remove unnecessary parameter name.
  • html/parser/HTMLTreeBuilder.cpp: Whitespace cleanup.

(WebCore::HTMLTreeBuilder::adjustedCurrentStackItem):

1:25 AM Changeset in webkit [176712] by evab.u-szeged@partner.samsung.com
  • 10 edits
    10 copies
    1 add
    1 delete in trunk

[EFL] Add subtle crypto to the build system
​https://bugs.webkit.org/show_bug.cgi?id=138612

Reviewed by Csaba Osztrogonác.

.:

  • Source/cmake/OptionsEfl.cmake:

Source/WebCore:

It is obvious to make Efl use GnuTLS as well,
and since there seems no reason why to separate
Efl and Gtk implementations from each other, I
also propose renaming the gtk directory and file
suffixes to gnutls.

No new tests needed.

  • PlatformEfl.cmake:
  • PlatformGTK.cmake:
  • crypto/gnutls/CryptoAlgorithmAES_CBCGnuTLS.cpp: Renamed from Source/WebCore/crypto/gtk/CryptoAlgorithmAES_CBCGtk.cpp.

(WebCore::CryptoAlgorithmAES_CBC::platformEncrypt):
(WebCore::CryptoAlgorithmAES_CBC::platformDecrypt):

  • crypto/gnutls/CryptoAlgorithmAES_KWGnuTLS.cpp: Renamed from Source/WebCore/crypto/gtk/CryptoAlgorithmAES_KWGtk.cpp.

(WebCore::CryptoAlgorithmAES_KW::platformEncrypt):
(WebCore::CryptoAlgorithmAES_KW::platformDecrypt):

  • crypto/gnutls/CryptoAlgorithmHMACGnuTLS.cpp: Renamed from Source/WebCore/crypto/gtk/CryptoAlgorithmHMACGtk.cpp.

(WebCore::getGnutlsDigestAlgorithm):
(WebCore::calculateSignature):
(WebCore::CryptoAlgorithmHMAC::platformSign):
(WebCore::CryptoAlgorithmHMAC::platformVerify):

  • crypto/gnutls/CryptoAlgorithmRSAES_PKCS1_v1_5GnuTLS.cpp: Renamed from Source/WebCore/crypto/gtk/CryptoAlgorithmRSAES_PKCS1_v1_5Gtk.cpp.

(WebCore::CryptoAlgorithmRSAES_PKCS1_v1_5::platformEncrypt):
(WebCore::CryptoAlgorithmRSAES_PKCS1_v1_5::platformDecrypt):

  • crypto/gnutls/CryptoAlgorithmRSASSA_PKCS1_v1_5GnuTLS.cpp: Renamed from Source/WebCore/crypto/gtk/CryptoAlgorithmRSASSA_PKCS1_v1_5Gtk.cpp.

(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::platformSign):
(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::platformVerify):

  • crypto/gnutls/CryptoAlgorithmRSA_OAEPGnuTLS.cpp: Renamed from Source/WebCore/crypto/gtk/CryptoAlgorithmRSA_OAEPGtk.cpp.

(WebCore::CryptoAlgorithmRSA_OAEP::platformEncrypt):
(WebCore::CryptoAlgorithmRSA_OAEP::platformDecrypt):

  • crypto/gnutls/CryptoAlgorithmRegistryGnuTLS.cpp: Renamed from Source/WebCore/crypto/gtk/CryptoAlgorithmRegistryGtk.cpp.

(WebCore::CryptoAlgorithmRegistry::platformRegisterAlgorithms):

  • crypto/gnutls/CryptoDigestGnuTLS.cpp: Renamed from Source/WebCore/crypto/gtk/CryptoDigestGtk.cpp.

(WebCore::CryptoDigest::CryptoDigest):
(WebCore::CryptoDigest::~CryptoDigest):
(WebCore::CryptoDigest::create):
(WebCore::CryptoDigest::addBytes):
(WebCore::CryptoDigest::computeHash):

  • crypto/gnutls/CryptoKeyRSAGnuTLS.cpp: Renamed from Source/WebCore/crypto/gtk/CryptoKeyRSAGtk.cpp.

(WebCore::CryptoKeyRSA::CryptoKeyRSA):
(WebCore::CryptoKeyRSA::create):
(WebCore::CryptoKeyRSA::~CryptoKeyRSA):
(WebCore::CryptoKeyRSA::restrictToHash):
(WebCore::CryptoKeyRSA::isRestrictedToHash):
(WebCore::CryptoKeyRSA::keySizeInBits):
(WebCore::CryptoKeyRSA::buildAlgorithmDescription):
(WebCore::CryptoKeyRSA::exportData):
(WebCore::CryptoKeyRSA::generatePair):

  • crypto/gnutls/SerializedCryptoKeyWrapGnuTLS.cpp: Renamed from Source/WebCore/crypto/gtk/SerializedCryptoKeyWrapGtk.cpp.

(WebCore::getDefaultWebCryptoMasterKey):
(WebCore::wrapSerializedCryptoKey):
(WebCore::unwrapSerializedCryptoKey):

  • crypto/keys/CryptoKeyRSA.h:

Tools:

  • Scripts/webkitperl/FeatureList.pm:

LayoutTests:

  • platform/efl/TestExpectations:
Note: See TracTimeline for information about the timeline view.