⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Dec 6, 2014:

3:52 PM Changeset in webkit [176917] by ap@apple.com
  • 2 edits in trunk/Tools

[Mac] DumpRenderTree sets storage directory incorrectly
​https://bugs.webkit.org/show_bug.cgi?id=139347

Reviewed by Dan Bernstein.

  • DumpRenderTree/mac/DumpRenderTree.mm: (setDefaultsToConsistentValuesForTesting):

Don't use user defaults to pass per-instance paths, as user defaults are shared
across all instances.

3:35 PM Changeset in webkit [176916] by Csaba Osztrogonác
  • 3 edits in trunk/Source/WebCore

URTBF after r176915.

DisplayRefreshMonitorClient is the parent class of GraphicsLayerUpdater
only if USE(REQUEST_ANIMATION_FRAME_DISPLAY_MONITOR) is true, so override
is incorrect if USE(REQUEST_ANIMATION_FRAME_DISPLAY_MONITOR) is false.

That's why r176915 broke the build on non PLATFORM(COCOA) platforms,
such as GTK, EFL, Apple Windows.

Additionally displayRefreshFired is only used inside USE(REQUEST_ANIMATION_FRAME_DISPLAY_MONITOR)
guard, so there is no reason to define it for non COCOA platforms.

  • platform/graphics/GraphicsLayerUpdater.cpp:
  • platform/graphics/GraphicsLayerUpdater.h:
1:44 PM Changeset in webkit [176915] by andersca@apple.com
  • 33 edits in trunk/Source

Fix build with newer versions of clang.
rdar://problem/18978733

Source/WebCore:

Add a bunch of overrides since we're not disabling the "inconsistent missing override" warning in WebKit.

  • page/scrolling/AsyncScrollingCoordinator.h:
  • page/scrolling/ScrollingStateFixedNode.h:
  • page/scrolling/ScrollingStateFrameScrollingNode.h:
  • page/scrolling/ScrollingStateOverflowScrollingNode.h:
  • page/scrolling/ScrollingStateStickyNode.h:
  • page/scrolling/ScrollingTreeFrameScrollingNode.h:

(WebCore::ScrollingTreeFrameScrollingNode::updateLayersAfterDelegatedScroll): Deleted.

  • page/scrolling/ios/ScrollingTreeFrameScrollingNodeIOS.h:
  • platform/graphics/GraphicsLayerUpdater.h:
  • platform/mac/ScrollbarThemeMac.h:

(WebCore::ScrollbarThemeMac::supportsControlTints): Deleted.
(WebCore::ScrollbarThemeMac::maxOverlapBetweenPages): Deleted.

  • rendering/RenderLayerCompositor.h:
  • rendering/RenderSnapshottedPlugIn.h:

Source/WebKit2:

Add missing overrides and casts.

  • NetworkProcess/NetworkProcess.h:
  • Shared/Downloads/DownloadAuthenticationClient.h:

(WebKit::DownloadAuthenticationClient::refAuthenticationClient): Deleted.
(WebKit::DownloadAuthenticationClient::derefAuthenticationClient): Deleted.

  • UIProcess/API/C/WKPage.cpp:

(WKPageSetPageUIClient):

  • UIProcess/API/Cocoa/WKWebViewConfiguration.mm:

(-[WKWebViewConfiguration copyWithZone:]):

  • UIProcess/API/Cocoa/_WKProcessPoolConfiguration.mm:

(-[_WKProcessPoolConfiguration copyWithZone:]):

  • UIProcess/Cocoa/NavigationState.h:
  • UIProcess/Network/NetworkProcessProxy.h:
  • UIProcess/Scrolling/ios/ScrollingTreeOverflowScrollingNodeIOS.h:

(WebKit::ScrollingTreeOverflowScrollingNodeIOS::updateLayersAfterViewportChange): Deleted.

  • UIProcess/WebPageProxy.h:
  • WebProcess/EntryPoint/mac/LegacyProcess/WebContentProcessMain.mm:

(WebKit::WebContentProcessMainDelegate::doPreInitializationWork): Deleted.
(WebKit::WebContentProcessMainDelegate::getConnectionIdentifier): Deleted.
(WebKit::WebContentProcessMainDelegate::getClientIdentifier): Deleted.
(WebKit::WebContentProcessMainDelegate::getClientProcessName): Deleted.

  • WebProcess/IconDatabase/WebIconDatabaseProxy.h:
  • WebProcess/InjectedBundle/mac/InjectedBundleMac.mm:

(WebKit::InjectedBundle::initialize):

  • WebProcess/WebCoreSupport/WebChromeClient.h:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
  • WebProcess/WebPage/WebBackForwardListProxy.h:
  • WebProcess/WebPage/WebInspector.h:

(WebKit::WebInspector::didClose): Deleted.
(WebKit::WebInspector::didReceiveInvalidMessage): Deleted.

  • WebProcess/WebPage/WebInspectorUI.h:

(WebKit::WebInspectorUI::didClose): Deleted.
(WebKit::WebInspectorUI::didReceiveInvalidMessage): Deleted.

  • WebProcess/WebPage/mac/PlatformCALayerRemoteCustom.h:
  • WebProcess/WebProcess.h:
  • WebProcess/ios/WebVideoFullscreenManager.h:
1:43 PM Changeset in webkit [176914] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Only include TUCallSPI on Mac.

  • Platform/mac/MenuUtilities.mm:
1:27 PM Changeset in webkit [176913] by andersca@apple.com
  • 9 edits
    2 copies
    1 add in trunk/Source

Add a stubbed out version of WebStorageNamespaceProvider
​https://bugs.webkit.org/show_bug.cgi?id=139213

Reviewed by Sam Weinig.

Source/WebKit:

  • Storage/WebStorageNamespaceProvider.cpp: Added.
  • Storage/WebStorageNamespaceProvider.h: Added.
  • WebKit.vcxproj/WebKit/WebKit.vcxproj:
  • WebKit.vcxproj/WebKit/WebKit.vcxproj.filters:
  • WebKit.xcodeproj/project.pbxproj:

Add new files.

Source/WebKit/mac:

  • WebCoreSupport/WebViewGroup.h:

(WebViewGroup::storageNamespaceProvider):

  • WebCoreSupport/WebViewGroup.mm:

(WebViewGroup::getOrCreate):
(WebViewGroup::WebViewGroup):
Give WebViewGroup a storage namespace provider.

1:23 PM Changeset in webkit [176912] by andersca@apple.com
  • 21 edits in trunk/Source

Fix build with newer versions of clang.
rdar://problem/18978687

Source/WebCore:

Add a bunch of overrides since we're not disabling the "inconsistent missing override" warning in WebKit.

  • html/HTMLElement.h:
  • html/HTMLMediaElement.h:
  • html/track/VTTCue.h:
  • loader/FrameNetworkingContext.h:

(WebCore::FrameNetworkingContext::shouldClearReferrerOnHTTPSToHTTPRedirect): Deleted.

  • loader/cache/CachedImage.h:
  • page/SuspendableTimer.h:
  • platform/Scrollbar.h:
  • platform/graphics/InbandTextTrackPrivate.h:
  • rendering/RenderBlockFlow.h:

Source/WebKit/ios:

Cast the result of +alloc to the right type.

  • Misc/WebGeolocationCoreLocationProvider.mm:

(-[WebGeolocationCoreLocationProvider createLocationManager]):

  • WebCoreSupport/WebSelectionRect.m:

(+[WebSelectionRect selectionRect]):

Source/WebKit/mac:

Add missing overrides and missing casts.

  • Storage/WebDatabaseManagerClient.h:
  • Storage/WebStorageTrackerClient.h:
  • WebCoreSupport/WebChromeClient.h:
  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebInspectorClient.h:
  • WebView/WebDataSource.mm:

(-[WebDataSource _makeRepresentation]):

  • WebView/WebFrameView.mm:

(-[WebFrameView _makeDocumentViewForDataSource:]):

1:10 PM Changeset in webkit [176911] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Follow-up build fix.

  • Configurations/Base.xcconfig:
1:04 PM Changeset in webkit [176910] by andersca@apple.com
  • 11 edits in trunk/Source/WebCore

Fix build with newer versions of clang.
rdar://problem/18978689

Disable the "inconsistent missing override" warning due to our use of macros in SVG where it's hard to
know whether we can add an override or not.

Also, cast return values of +alloc to the right type, and add some casts for vector iterator arithmetic.

  • Configurations/Base.xcconfig:
  • Modules/webdatabase/DatabaseBackendBase.cpp:

(WebCore::guidForOriginAndName):

  • accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:

(-[WebAccessibilityObjectWrapper _stringForRange:attributed:]):

  • editing/cocoa/HTMLConverter.mm:

(_shadowForShadowStyle):
(HTMLConverter::_addTableForElement):

  • platform/graphics/SVGGlyph.cpp:

(WebCore::isCompatibleArabicForm):

  • platform/graphics/avfoundation/AudioSourceProviderAVFObjC.mm:

(WebCore::AudioSourceProviderAVFObjC::createMix):

  • platform/graphics/mac/FontMac.mm:

(WebCore::showLetterpressedGlyphsWithAdvances):

  • platform/ios/PlatformSpeechSynthesizerIOS.mm:

(-[WebSpeechSynthesisWrapper speakUtterance:]):

  • platform/ios/WebCoreMotionManager.mm:

(-[WebCoreMotionManager initializeOnMainThread]):

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::spannedRows):
(WebCore::RenderTableSection::spannedColumns):

1:04 PM Changeset in webkit [176909] by andersca@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Fix build with newer versions of clang.
rdar://problem/18978716

  • ftl/FTLJITCode.h:

Add missing overrides.

11:36 AM Changeset in webkit [176908] by mark.lam@apple.com
  • 2 edits in trunk/LayoutTests

Skipping tests due to regression in r176902.
<​https://webkit.org/b/139014>

Not reviewed.

10:26 AM Changeset in webkit [176907] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[WinCairo] Compile error, missing guard.
​https://bugs.webkit.org/show_bug.cgi?id=139338

Patch by ​peavo@outlook.com <​peavo@outlook.com> on 2014-12-06
Reviewed by Alex Christensen.

There is missing a ENABLE(CSS_SELECTORS_LEVEL4) guard in CSSParser.cpp.

  • css/CSSParser.cpp:

(WebCore::CSSParser::realLex):

3:50 AM Changeset in webkit [176906] by commit-queue@webkit.org
  • 3 edits
    2 deletes in trunk

Unreviewed, rolling out r176905.
​https://bugs.webkit.org/show_bug.cgi?id=139337

the test case is failing in bots (Requested by anttik on
#webkit).

Reverted changeset:

"REGRESSION (173394): Support for webcam is broken"
​https://bugs.webkit.org/show_bug.cgi?id=139313
​http://trac.webkit.org/changeset/176905

2:39 AM Changeset in webkit [176905] by Antti Koivisto
  • 3 edits
    2 adds in trunk

REGRESSION (173394): Support for webcam is broken
​https://bugs.webkit.org/show_bug.cgi?id=139313

Reviewed by Alexey Proskuryakov.

Source/WebKit2:

  • NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::NetworkResourceLoader::didReceiveResponseAsync):

Don't buffer when handling multipart/x-mixed-replace. Multiple calls to didReceiveResponseAsync break assumptions.

LayoutTests:

We had no coverage for actually rendering multipart content.

  • http/tests/multipart/multipart-image-expected.html: Added.
  • http/tests/multipart/multipart-image.html: Added.

Dec 5, 2014:

9:44 PM Changeset in webkit [176904] by Chris Fleizach
  • 10 edits
    3 adds in trunk

AX: I cannot activate links on the mobile version of news.google.com
​https://bugs.webkit.org/show_bug.cgi?id=139330

Reviewed by Simon Fraser.

Source/WebCore:

This website only listens for touch events. VoiceOver normally dispatches click and mouse events,
so on iOS this falls and VoiceOver is not able to activate anything.

The solution here is to dispatch simulated touch down/up events.

Test: platform/ios-simulator/ios-accessibility/press-fires-touch-events.html

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::press):
(WebCore::AccessibilityObject::dispatchTouchEvent):

  • accessibility/AccessibilityObject.h:

(WebCore::AccessibilityObject::isDetachedFromParent):

  • page/EventHandler.h:
  • page/ios/EventHandlerIOS.mm:

(WebCore::EventHandler::dispatchSimulatedTouchEvent):

  • platform/ios/PlatformEventFactoryIOS.h:
  • platform/ios/PlatformEventFactoryIOS.mm:

(WebCore::PlatformTouchEventBuilder::PlatformTouchEventBuilder):
(WebCore::PlatformEventFactory::createPlatformSimulatedTouchEvent):

Tools:

Implement press for iOS.

  • DumpRenderTree/ios/AccessibilityUIElementIOS.mm:

(AccessibilityUIElement::press):

LayoutTests:

  • platform/ios-simulator/ios-accessibility: Added.
  • platform/ios-simulator/ios-accessibility/press-fires-touch-events-expected.txt: Added.
  • platform/ios-simulator/ios-accessibility/press-fires-touch-events.html: Added.
9:14 PM Changeset in webkit [176903] by mmaxfield@apple.com
  • 3 edits
    2 adds in trunk

Directional single quotation marks are not rotated in vertical text
​https://bugs.webkit.org/show_bug.cgi?id=138526

Source/WebCore:

Reviewed by Darin Adler.

In vertical text, directional single quotation marks are not rotated along with
the rest of the letters.

Test: fast/text/vertical-quotation-marks.html

  • platform/graphics/FontGlyphs.cpp:

(WebCore::shouldIgnoreRotation):

LayoutTests:

Compare vertical and horizontal renderings.

Reviewed by Darin Adler.

  • fast/text/vertical-quotation-marks-expected.html: Added.
  • fast/text/vertical-quotation-marks.html: Added.
9:09 PM Changeset in webkit [176902] by commit-queue@webkit.org
  • 6 edits
    2 adds in trunk

Implement parser for :lang pseudo class selector arguments that contain wildcard '*' subtags
​https://bugs.webkit.org/show_bug.cgi?id=139014

Patch by Dhi Aurrahman <​diorahman@rockybars.com> on 2014-12-05
Reviewed by Benjamin Poulain.

Source/WebCore:

Consider each language range in :lang() that consists of an asterisk
immediately followed by an identifier beginning with an ASCII hyphen
as a valid input for the selector as specified in [1].

[1] ​http://dev.w3.org/csswg/selectors4/#the-lang-pseudo

Test: fast/css/parsing-css-lang.html

  • css/CSSGrammar.y.in:
  • css/CSSParser.cpp:

(WebCore::CSSParser::realLex):

LayoutTests:

  • fast/css/css-selector-text-expected.txt: Updated for asterisk containing input.
  • fast/css/css-selector-text.html: Updated for asterisk containing input.
  • fast/css/parsing-css-lang-expected.txt: Added.
  • fast/css/parsing-css-lang.html: Added.
6:04 PM Changeset in webkit [176901] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit2

Add a delegate method for didReceiveServerRedirectForProvisionalLoadForFrame.
​https://bugs.webkit.org/show_bug.cgi?id=139325

Add delegate method webProcessPlugInBrowserContextController:didReceiveServerRedirectForProvisionalLoadForFrame: into
WKWebProcessPlugInLoadDelegate to listen to server side redirect in injected bundle.

Patch by Yongjun Zhang <​yongjun_zhang@apple.com> on 2014-12-05
Reviewed by Dan Bernstein.

  • WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInLoadDelegate.h:
  • WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm:

(didReceiveServerRedirectForProvisionalLoadForFrame):
(setUpPageLoaderClient):

5:29 PM Changeset in webkit [176900] by bshafiei@apple.com
  • 1 copy in tags/Safari-600.2.5

New tag.

5:25 PM Changeset in webkit [176899] by Simon Fraser
  • 4 edits
    1 add in trunk

Programmatic scrolling and content changes are not always synchronized
​https://bugs.webkit.org/show_bug.cgi?id=139245
rdar://problem/18833612

Reviewed by Anders Carlsson.

Manual test that tries to sync layout with programmatic scrolling.

  • ManualTests/programmatic-scroll-flicker.html: Added.

Source/WebCore:

For programmatic scrolls, AsyncScrollingCoordinator::requestScrollPositionUpdate()
calls updateScrollPositionAfterAsyncScroll(), then dispatches the requested
scroll position to the scrolling thread.

Once the scrolling thread commits, it calls back to the main thread via
scheduleUpdateScrollPositionAfterAsyncScroll(), which schedules a second
call to updateScrollPositionAfterAsyncScroll() on a timer. That's a problem,
because some other scroll may have happened in the meantime; when the timer
fires, it can sometimes restore a stale scroll position.

Fix by bailing early from scheduleUpdateScrollPositionAfterAsyncScroll()
for programmatic scrolls, since we know that requestScrollPositionUpdate()
already did the updateScrollPositionAfterAsyncScroll().

Test:

ManualTests/programmatic-scroll-flicker.html

  • page/FrameView.cpp:

(WebCore::FrameView::reset): nullptr.
(WebCore::FrameView::setScrollPosition): Ditto.
(WebCore::FrameView::setWasScrolledByUser): Ditto.

  • page/scrolling/AsyncScrollingCoordinator.cpp:

(WebCore::AsyncScrollingCoordinator::requestScrollPositionUpdate): Use a local variable for
isProgrammaticScroll just to make sure we use the same value for the duration of this function.
(WebCore::AsyncScrollingCoordinator::scheduleUpdateScrollPositionAfterAsyncScroll): Do nothing
if this is a programmatic scroll.

5:20 PM Changeset in webkit [176898] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebCore

Build fix.

  • platform/spi/mac/TUCallSPI.h:
5:09 PM Changeset in webkit [176897] by dbates@webkit.org
  • 2 edits in trunk/Tools

[iOS] Query -[WAKWindow screenScale] instead of using WKGetScreenScaleFactor()
​https://bugs.webkit.org/show_bug.cgi?id=139326

Reviewed by Anders Carlsson.

Ask the window for its screen scale factor instead of calling WKGetScreenScaleFactor()
to query the OS for it. This approach will ensure DumpRenderTree takes the snapshot
using the same scale factor as used in WebKit.

  • DumpRenderTree/ios/PixelDumpSupportIOS.mm:

(createBitmapContextFromWebView):

5:09 PM Changeset in webkit [176896] by roger_fong@apple.com
  • 8 edits in trunk/Source

[Win] proj files copying over too many resources..
​https://bugs.webkit.org/show_bug.cgi?id=139315.
<rdar://problem/19148278>

Reviewed by Brent Fulgham.

  • WebCore.vcxproj/WebCore.proj: Don't copy over bin32 build output.
  • WebKit.vcxproj/WebKit.proj: Only copy resource folders and WebKit.dll.
  • JavaScriptCore.vcxproj/JavaScriptCore.proj: Only copy resource folders and JavaScriptCore.dll.
  • WTF.vcxproj/WTF.proj: Only copy WTF.dll.
5:07 PM Changeset in webkit [176895] by timothy_horton@apple.com
  • 1 edit
    1 add in trunk/Source/WebCore

Use the system string for telephone number menu
​https://bugs.webkit.org/show_bug.cgi?id=139324
<rdar://problem/18726471>

  • platform/spi/mac/TUCallSPI.h: Added.

Actually add the SPI header from the last commit.

5:01 PM Changeset in webkit [176894] by timothy_horton@apple.com
  • 4 edits in trunk/Source

Use the system string for telephone number menu
​https://bugs.webkit.org/show_bug.cgi?id=139324
<rdar://problem/18726471>

Reviewed by Anders Carlsson.

  • Platform/mac/MenuUtilities.mm:

(WebKit::menuItemTitleForTelephoneNumberGroup):
Make use of the SPI to retrieve the string if it exists.

  • WebCore.xcodeproj/project.pbxproj:
  • platform/spi/mac/TUCallSPI.h: Added.

Add an SPI header.

4:42 PM Changeset in webkit [176893] by Csaba Osztrogonác
  • 3 edits in trunk/Source/WebKit2

URTBF, EFL is happy now.

  • UIProcess/API/APIWebsiteDataStore.cpp:

(API::WebsiteDataStore::defaultDataStoreConfiguration):

  • UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::createNonPersistent):

4:33 PM Changeset in webkit [176892] by andersca@apple.com
  • 85 edits in trunk/Source/WebKit/win

Get rid of config.h includes and include config.h in the prefix header instead
​https://bugs.webkit.org/show_bug.cgi?id=139323

Reviewed by Brent Fulgham.

This is making it easier to share code between WebKit1 for Mac and WebKit1 for Windows.

  • AccessibleBase.cpp:
  • AccessibleDocument.cpp:
  • AccessibleImage.cpp:
  • AccessibleTextImpl.cpp:
  • CFDictionaryPropertyBag.cpp:
  • DOMCSSClasses.cpp:
  • DOMCoreClasses.cpp:
  • DOMEventsClasses.cpp:
  • DOMHTMLClasses.cpp:
  • DefaultDownloadDelegate.cpp:
  • DefaultPolicyDelegate.cpp:
  • ForEachCoClass.cpp:
  • FullscreenVideoController.cpp:
  • MarshallingHelpers.cpp:
  • MemoryStream.cpp:
  • WebActionPropertyBag.cpp:
  • WebArchive.cpp:
  • WebBackForwardList.cpp:
  • WebCache.cpp:
  • WebCoreStatistics.cpp:
  • WebCoreSupport/AcceleratedCompositingContext.cpp:
  • WebCoreSupport/EmbeddedWidget.cpp:
  • WebCoreSupport/WebChromeClient.cpp:
  • WebCoreSupport/WebContextMenuClient.cpp:
  • WebCoreSupport/WebDesktopNotificationsDelegate.cpp:
  • WebCoreSupport/WebDragClient.cpp:
  • WebCoreSupport/WebEditorClient.cpp:
  • WebCoreSupport/WebFrameLoaderClient.cpp:
  • WebCoreSupport/WebFrameNetworkingContext.cpp:
  • WebCoreSupport/WebGeolocationClient.cpp:
  • WebCoreSupport/WebInspectorClient.cpp:
  • WebCoreSupport/WebInspectorDelegate.cpp:
  • WebCoreSupport/WebPlatformStrategies.cpp:
  • WebCoreSupport/WebVisitedLinkStore.cpp:
  • WebDataSource.cpp:
  • WebDatabaseManager.cpp:
  • WebDocumentLoader.cpp:
  • WebDownload.cpp:
  • WebDownloadCFNet.cpp:
  • WebDownloadCurl.cpp:
  • WebDropSource.cpp:
  • WebElementPropertyBag.cpp:
  • WebError.cpp:
  • WebFrame.cpp:
  • WebFramePolicyListener.cpp:
  • WebGeolocationPolicyListener.cpp:
  • WebGeolocationPosition.cpp:
  • WebHTMLRepresentation.cpp:
  • WebHistory.cpp:
  • WebHistoryItem.cpp:
  • WebIconDatabase.cpp:
  • WebInspector.cpp:
  • WebJavaScriptCollector.cpp:
  • WebKitCOMAPI.cpp:
  • WebKitClassFactory.cpp:
  • WebKitDLL.cpp:
  • WebKitGraphics.cpp:
  • WebKitLogging.cpp:
  • WebKitPrefix.h:
  • WebKitStatistics.cpp:
  • WebKitSystemBits.cpp:
  • WebLocalizableStrings.cpp:
  • WebMutableURLRequest.cpp:
  • WebNavigationData.cpp:
  • WebNodeHighlight.cpp:
  • WebNotification.cpp:
  • WebNotificationCenter.cpp:
  • WebPreferences.cpp:
  • WebResource.cpp:
  • WebScriptObject.cpp:
  • WebScriptWorld.cpp:
  • WebSecurityOrigin.cpp:
  • WebSerializedJSValue.cpp:
  • WebTextRenderer.cpp:
  • WebURLAuthenticationChallenge.cpp:
  • WebURLAuthenticationChallengeSender.cpp:
  • WebURLAuthenticationChallengeSenderCFNet.cpp:
  • WebURLAuthenticationChallengeSenderCurl.cpp:
  • WebURLCredential.cpp:
  • WebURLProtectionSpace.cpp:
  • WebURLResponse.cpp:
  • WebUserContentURLPattern.cpp:
  • WebView.cpp:
  • WebWorkersPrivate.cpp:
4:31 PM Changeset in webkit [176891] by mark.lam@apple.com
  • 2 edits in trunk/Source/WebKit2

Gardening: one more build fix for GTK builds.

  • CMakeLists.txt:
4:29 PM Changeset in webkit [176890] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

[JSC][FTL] Add the data layout to the module and fix the pass order.
​https://bugs.webkit.org/show_bug.cgi?id=138748

Patch by Juergen Ributzka <​juergen@apple.com> on 2014-12-05
Reviewed by Oliver Hunt.

This adds the data layout to the module, so it can be used by all
optimization passes in the LLVM optimizer pipeline. This also allows
FastISel to select more instructions, because less non-legal types are
generated.

Also fix the order of the alias analysis passes in the optimization
pipeline.

  • ftl/FTLCompile.cpp:

(JSC::FTL::mmAllocateDataSection):

4:28 PM Changeset in webkit [176889] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebKit2

URTBF, remove duplicated entry due to parallel buildfixing.

  • CMakeLists.txt:
4:26 PM Changeset in webkit [176888] by bshafiei@apple.com
  • 5 edits in branches/safari-600.2-branch/Source

Versioning.

4:25 PM Changeset in webkit [176887] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebKit2

URTBF after r176849.

  • CMakeLists.txt: Added WebProcess/InjectedBundle/DOM/InjectedBundleCSSStyleDeclarationHandle.cpp.
4:20 PM Changeset in webkit [176886] by mark.lam@apple.com
  • 2 edits in trunk/Source/WebKit2

Gardening: another build fix for GTK builds.

  • CMakeLists.txt:
4:16 PM Changeset in webkit [176885] by andersca@apple.com
  • 2 edits in trunk/Tools

REGRESSION (r176677): All tests crash on Windows
​https://bugs.webkit.org/show_bug.cgi?id=139321

Reviewed by Alexey Proskuryakov.

  • DumpRenderTree/win/DumpRenderTree.cpp:

(runTest):
Don't call CFRelease on the url while we have an outstanding pointer to its string,
and use the right number of bytes when allocating the testURL buffer.

4:10 PM Changeset in webkit [176884] by mark.lam@apple.com
  • 2 edits in trunk/Source/WebKit2

Gardening: more speculative build fix for GTK builds.

  • CMakeLists.txt:
3:59 PM Changeset in webkit [176883] by timothy_horton@apple.com
  • 3 edits in trunk/Source/WebKit2

If the action menu hit test times out, a menu with a single separator appears
​https://bugs.webkit.org/show_bug.cgi?id=139320
<rdar://problem/19158331>

Reviewed by Beth Dakin.

  • UIProcess/mac/WKActionMenuController.h:
  • UIProcess/mac/WKActionMenuController.mm:

(-[WKActionMenuController menuNeedsUpdate:]):
(-[WKActionMenuController _defaultMenuItems]):
Add a new "TimedOut" state, which we get into if the sync wait for
didPerformActionMenuHitTest times out. In this case, we'll drop the
separator item and give up on the menu. This way, the menu will never
have just a single separator item at the end of menuNeedsUpdate:.

3:56 PM Changeset in webkit [176882] by bshafiei@apple.com
  • 1 copy in tags/Safari-600.2.4

New tag.

3:54 PM Changeset in webkit [176881] by mark.lam@apple.com
  • 2 edits in trunk/Source/WebKit2

Gardening: speculative build fix for GTK builds.

  • CMakeLists.txt:
3:33 PM Changeset in webkit [176880] by dbates@webkit.org
  • 3 edits in trunk/Tools

[iOS] DumpRenderTree produces many reference test mismatches
​https://bugs.webkit.org/show_bug.cgi?id=139314

Reviewed by Simon Fraser.

Fixes an issue where the scale factor used to render the snapshot taken by
DumpRenderTree may differ from the device scale factor. In particular, the
scale factor used to render a snapshot of a test may differ from the scale
factor used to render the snapshot of its expected result.

Currently DumpRenderTree uses SPI, -[UIView newSnapshotForRect], on iOS to
snapshot the UIWebBrowserView. This SPI always render using a scale factor
of one when the backing store for the LegacyTileLayer objects were out-of-
date regardless of the device scale factor. Instead we should use UIImage
and CALayer API to perform the snapshot with respect to the device scale
factor.

Additionally write iOS pixel dump support logic in terms of existing
DumpRenderTree abstractions so as to support generating and comparing
pixel dump checksums as well as make the iOS code more consistent with
the logic used by other ports.

  • DumpRenderTree/PixelDumpSupport.cpp:

(dumpWebViewAsPixelsAndCompareWithExpected): Removed !PLATFORM(IOS)-guard.

  • DumpRenderTree/ios/PixelDumpSupportIOS.mm:

(BitmapContext::createFromUIImage): Added.
(BitmapContext::pixelData): Added.
(BitmapContext::BitmapContext): Added.
(computeMD5HashStringForBitmapContext): Added.
(dumpBitmap): Added.
(createBitmapContextFromWebView): Moved logic from dumpWebViewAsPixelsAndCompareWithExpected() to here.
(dumpWebViewAsPixelsAndCompareWithExpected): Deleted.

3:25 PM Changeset in webkit [176879] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

[MSE][Mac] Return absolute value of error code from CDMSessionMediaSourceAVFObjC::update().
​https://bugs.webkit.org/show_bug.cgi?id=139316

Reviewed by Eric Carlson.

Similarly to our asynchronous error reporting, return the absolute value of the error code.

  • platform/graphics/avfoundation/objc/CDMSessionMediaSourceAVFObjC.mm:

(WebCore::systemCodeForError):
(WebCore::CDMSessionMediaSourceAVFObjC::update):

3:11 PM Changeset in webkit [176878] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix build.

  • UIProcess/API/Cocoa/APIWebsiteDataStoreCocoa.mm:

(API::WebsiteDataStore::defaultDataStoreConfiguration):

3:01 PM Changeset in webkit [176877] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Fix build on Windows.

  • page/SessionIDHash.h:
3:00 PM Changeset in webkit [176876] by andersca@apple.com
  • 7 edits in trunk

Give all web pages a website data store
​https://bugs.webkit.org/show_bug.cgi?id=139317

Reviewed by Tim Horton.

Source/WebKit2:

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView initWithFrame:configuration:]):
Set the website data store on the window.

  • UIProcess/WebContext.cpp:

(WebKit::websiteDataStoreConfiguration):
Helper function that will create the default website data store configuration for a context.

(WebKit::WebContext::WebContext):
Create a new, per-context data store.

(WebKit::WebContext::createWebPage):
If we don't have a data store filled in, use the default per-context one.

  • UIProcess/WebContext.h:
  • UIProcess/WebPageProxy.h:

Tools:

  • MiniBrowser/mac/AppDelegate.m:

(-[BrowserAppDelegate newPrivateWindow:]):
Don't release the controller - it's implicitly retained by the window.

2:43 PM Changeset in webkit [176875] by andersca@apple.com
  • 5 edits
    2 copies
    1 add in trunk/Source/WebKit2

Move the website data store code to a new file
​https://bugs.webkit.org/show_bug.cgi?id=139312

Reviewed by Tim Horton.

It's weird to have all the website data code in the API class, so move it to a new file.

  • UIProcess/API/APIWebsiteDataStore.cpp:

(API::WebsiteDataStore::WebsiteDataStore):
(API::WebsiteDataStore::isNonPersistent):
(API::generateNonPersistentSessionID): Deleted.

  • UIProcess/API/APIWebsiteDataStore.h:
  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView initWithFrame:configuration:]):

  • UIProcess/WebsiteData/WebsiteDataStore.cpp: Copied from Source/WebKit2/UIProcess/API/APIWebsiteDataStore.cpp.

(WebKit::generateNonPersistentSessionID):
(WebKit::WebsiteDataStore::createNonPersistent):
(WebKit::WebsiteDataStore::create):
(WebKit::WebsiteDataStore::WebsiteDataStore):
(WebKit::WebsiteDataStore::~WebsiteDataStore):

  • UIProcess/WebsiteData/WebsiteDataStore.h: Copied from Source/WebKit2/UIProcess/API/APIWebsiteDataStore.h.

(WebKit::WebsiteDataStore::isNonPersistent):
(WebKit::WebsiteDataStore::sessionID):

  • WebKit2.xcodeproj/project.pbxproj:
2:22 PM Changeset in webkit [176874] by Alan Bujtas
  • 2 edits in trunk/Source/WebCore

Issue repaint at setUnavailablePluginIndicatorIsHidden() only when embedded object's indicator status changes.
​https://bugs.webkit.org/show_bug.cgi?id=139311

Reviewed by Tim Horton.

Not testable.

  • rendering/RenderEmbeddedObject.cpp:

(WebCore::RenderEmbeddedObject::setUnavailablePluginIndicatorIsHidden):

2:20 PM Changeset in webkit [176873] by akling@apple.com
  • 5 edits in trunk/Source

PassRef should deref on destruction if pointee was not moved.
<​https://webkit.org/b/139309>

Reviewed by Antti Koivisto.

Source/WebCore:

Remove calls to PassRef::dropRef() since it's no longer necessary to manually
notify PassRef that you didn't move the pointee.

  • rendering/RenderElement.cpp:

(WebCore::RenderElement::createFor):
(WebCore::RenderElement::setStyle):

  • style/StyleResolveTree.cpp:

(WebCore::Style::resolveTree):

Source/WTF:

Let PassRef become nullptr internally after having WTF::move()'d the pointee.
This means that PassRef is now essentially a PassRefPtr that can only be
constructed with a non-null pointee.

This should make it possible for all ::create()-style construction helpers to
return PassRef, removing a branch in each case.

  • wtf/PassRef.h:

(WTF::PassRef<T>::PassRef):
(WTF::PassRef<T>::~PassRef):
(WTF::PassRef<T>::get):
(WTF::PassRef<T>::ptr):
(WTF::PassRef<T>::leakRef):
(WTF::PassRef<T>::dropRef): Deleted.

2:13 PM Changeset in webkit [176872] by dbates@webkit.org
  • 2 edits in trunk/Tools

[iOS] DumpRenderTree fails to render every other test when pixel tests are on
​https://bugs.webkit.org/show_bug.cgi?id=137581
<rdar://problem/18642906>

Reviewed by Simon Fraser.

Fixes an issue where the DumpRenderTree snapshot may reflect the rendered content
of the test that proceeded the currently running test.

  • DumpRenderTree/ios/PixelDumpSupportIOS.mm:

(dumpWebViewAsPixelsAndCompareWithExpected): Ensure that UIKit has performed a layout
of the UIWebBrowserView view. Also, remove unnecessary call to -[UIWebDocumentView layoutTilesNow]
as -[UIWebDocumentView newSnapshotWithRect] will layout the tiles.

2:11 PM Changeset in webkit [176871] by ggaren@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

2014-12-05 Geoffrey Garen <​ggaren@apple.com>

Removed an unused function.

Reviewed by Michael Saboff.

Broken out from ​https://bugs.webkit.org/show_bug.cgi?id=139305.

  • parser/ParserArena.h:
1:29 PM Changeset in webkit [176870] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit2

Keyboard input should be disabled in the preview popover
​https://bugs.webkit.org/show_bug.cgi?id=139219
<rdar://problem/19052381>

Reviewed by Anders Carlsson.

  • UIProcess/API/mac/WKView.mm:

(-[WKView performKeyEquivalent:]):
(-[WKView keyUp:]):
(-[WKView keyDown:]):
(-[WKView flagsChanged:]):
There are two implementations of each of these methods in this file.
Adjust the ones that the original patch missed.

1:25 PM Changeset in webkit [176869] by dburkart@apple.com
  • 2 edits in branches/safari-600.3-branch/Source/WebKit2

Merged r176820. rdar://problems/19147218

1:17 PM Changeset in webkit [176868] by dburkart@apple.com
  • 2 edits in branches/safari-600.3-branch/Source/WebCore

Merged r176812. rdar://problems/19140827

1:17 PM Changeset in webkit [176867] by dburkart@apple.com
  • 7 edits in branches/safari-600.3-branch/Source

Merged r176811. rdar://problems/19140827

1:16 PM Changeset in webkit [176866] by dburkart@apple.com
  • 12 edits in branches/safari-600.3-branch/Source

Merged r176810. rdar://problems/19140827

1:10 PM Changeset in webkit [176865] by dburkart@apple.com
  • 4 edits
    1 copy in branches/safari-600.3-branch

Merged r173566. rdar://problems/19150984

12:58 PM Changeset in webkit [176864] by benjamin@webkit.org
  • 4 edits
    42 adds in trunk

Fix style sharing with the "type" and "readonly" attributes
​https://bugs.webkit.org/show_bug.cgi?id=139283

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2014-12-05
Reviewed by Antti Koivisto.

Source/WebCore:

There are two bugs adressed with this patch:
1) The attributes "type" and "readonly" where only handled correctly

for input elements. For everything else, they could incorrectly
be ignored for style sharing.

2) The handling of attributes was incorrect for selector lists, leading

to various bugs (incorrect style sharing in some cases, disabling
style sharing on valid cases).

For [1], the problem was that attribute checking had been limited to
StyleResolver::canShareStyleWithControl(). That function is for handling
the special states of input element. For any other element, the attributes
were simply ignored.

For [2], there were a bunch of small problems. First, containsUncommonAttributeSelector()
was not recursive, which caused it to ignored any nested selector list. This used to be
correct but since we have advanced selectors we can no longer assumed selectors are not nested.

A second issue was that any attribute in a selector list was causing us to fall back
to the slow case. Now that we have the fast :matches(), we really don't want that.

The function containsUncommonAttributeSelector() was transformed into a recursive function
tracking where we are in the selector.

At the entry point, we start with the flag "startsOnRightmostElement" set to true. The flag is then
updated on the stack of each recursive call.

For example, "webkit > is:matches(freaking > awesome)". We evalute "is" with the flag to true, then recurse
into evaluating "freaking > awesome" with the flag still set to true. When we evalute ">", the flag
is set to false to evaluate any following selectors.
After evaluating "freaking > awesome", we go back to our previous stack frame, and the flag
is back to true and we can continue evaluating with the curren top level state.

From some logging, I discovered that the attribute handling is way too aggressive.
This is not a regression and I cannot fix that easily so I left a fixme.

Tests: fast/css/data-attribute-style-sharing-1.html

fast/css/data-attribute-style-sharing-2.html
fast/css/data-attribute-style-sharing-3.html
fast/css/data-attribute-style-sharing-4.html
fast/css/data-attribute-style-sharing-5.html
fast/css/data-attribute-style-sharing-6.html
fast/css/data-attribute-style-sharing-7.html
fast/css/readonly-attribute-style-sharing-1.html
fast/css/readonly-attribute-style-sharing-2.html
fast/css/readonly-attribute-style-sharing-3.html
fast/css/readonly-attribute-style-sharing-4.html
fast/css/readonly-attribute-style-sharing-5.html
fast/css/readonly-attribute-style-sharing-6.html
fast/css/readonly-attribute-style-sharing-7.html
fast/css/type-attribute-style-sharing-1.html
fast/css/type-attribute-style-sharing-2.html
fast/css/type-attribute-style-sharing-3.html
fast/css/type-attribute-style-sharing-4.html
fast/css/type-attribute-style-sharing-5.html
fast/css/type-attribute-style-sharing-6.html
fast/css/type-attribute-style-sharing-7.html

  • css/RuleSet.cpp:

(WebCore::containsUncommonAttributeSelector):
(WebCore::RuleData::RuleData):
(WebCore::selectorListContainsAttributeSelector): Deleted.

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::canShareStyleWithControl):
(WebCore::StyleResolver::canShareStyleWithElement):

LayoutTests:

  • fast/css/data-attribute-style-sharing-1-expected.html: Added.
  • fast/css/data-attribute-style-sharing-1.html: Added.
  • fast/css/data-attribute-style-sharing-2-expected.html: Added.
  • fast/css/data-attribute-style-sharing-2.html: Added.
  • fast/css/data-attribute-style-sharing-3-expected.html: Added.
  • fast/css/data-attribute-style-sharing-3.html: Added.
  • fast/css/data-attribute-style-sharing-4-expected.html: Added.
  • fast/css/data-attribute-style-sharing-4.html: Added.
  • fast/css/data-attribute-style-sharing-5-expected.html: Added.
  • fast/css/data-attribute-style-sharing-5.html: Added.
  • fast/css/data-attribute-style-sharing-6-expected.html: Added.
  • fast/css/data-attribute-style-sharing-6.html: Added.
  • fast/css/data-attribute-style-sharing-7-expected.html: Added.
  • fast/css/data-attribute-style-sharing-7.html: Added.
  • fast/css/readonly-attribute-style-sharing-1-expected.html: Added.
  • fast/css/readonly-attribute-style-sharing-1.html: Added.
  • fast/css/readonly-attribute-style-sharing-2-expected.html: Added.
  • fast/css/readonly-attribute-style-sharing-2.html: Added.
  • fast/css/readonly-attribute-style-sharing-3-expected.html: Added.
  • fast/css/readonly-attribute-style-sharing-3.html: Added.
  • fast/css/readonly-attribute-style-sharing-4-expected.html: Added.
  • fast/css/readonly-attribute-style-sharing-4.html: Added.
  • fast/css/readonly-attribute-style-sharing-5-expected.html: Added.
  • fast/css/readonly-attribute-style-sharing-5.html: Added.
  • fast/css/readonly-attribute-style-sharing-6-expected.html: Added.
  • fast/css/readonly-attribute-style-sharing-6.html: Added.
  • fast/css/readonly-attribute-style-sharing-7-expected.html: Added.
  • fast/css/readonly-attribute-style-sharing-7.html: Added.
  • fast/css/type-attribute-style-sharing-1-expected.html: Added.
  • fast/css/type-attribute-style-sharing-1.html: Added.
  • fast/css/type-attribute-style-sharing-2-expected.html: Added.
  • fast/css/type-attribute-style-sharing-2.html: Added.
  • fast/css/type-attribute-style-sharing-3-expected.html: Added.
  • fast/css/type-attribute-style-sharing-3.html: Added.
  • fast/css/type-attribute-style-sharing-4-expected.html: Added.
  • fast/css/type-attribute-style-sharing-4.html: Added.
  • fast/css/type-attribute-style-sharing-5-expected.html: Added.
  • fast/css/type-attribute-style-sharing-5.html: Added.
  • fast/css/type-attribute-style-sharing-6-expected.html: Added.
  • fast/css/type-attribute-style-sharing-6.html: Added.
  • fast/css/type-attribute-style-sharing-7-expected.html: Added.
  • fast/css/type-attribute-style-sharing-7.html: Added.
12:51 PM Changeset in webkit [176863] by jer.noble@apple.com
  • 9 edits in trunk

[WTF] MediaTime should support round-tripping from and to doubles.
​https://bugs.webkit.org/show_bug.cgi?id=139248

Reviewed by Eric Carlson.

Source/WebCore:

Check whether the MediaTime's underlying data is floating point before converting
to a CMTime or QTTime.

  • platform/graphics/avfoundation/MediaTimeAVFoundation.cpp:

(WebCore::toCMTime):

  • platform/graphics/mac/MediaTimeQTKit.mm:

(WebCore::toQTTime):

Source/WTF:

MediaTimes should be able to return precisely the same double value as was used
when the MediaTime was created, so long as that MediaTime was not modified in a
non-destructive way. This will allow API which accepts floating-point values to
return the exact same value when asked, but still be able to store that value
as a MediaTime.

  • wtf/MediaTime.cpp:

(WTF::MediaTime::createWithFloat): Added; store the floating-point value in a union.
(WTF::MediaTime::createWithDouble): Ditto.
(WTF::MediaTime::toFloat): If the value is a double, just return it.
(WTF::MediaTime::toDouble): Ditto.
(WTF::MediaTime::operator+): Special case when one or both sides are doubles.
(WTF::MediaTime::operator-): Ditto.
(WTF::MediaTime::operator*): Ditto.
(WTF::MediaTime::compare): Ditto.
(WTF::abs): Ditto.
(WTF::MediaTime::setTimeScale): Convert the MediaTime from a double.

Tools:

Add API tests for new features of MediaTime. Update the LLDB python provider to correctly display
the MediaTimes after this change.

  • TestWebKitAPI/Tests/WTF/MediaTime.cpp:

(WTF::operator<<):
(TestWebKitAPI::TEST):

  • lldb/lldb_webkit.py:

(WTFMediaTime_SummaryProvider):
(WTFMediaTimeProvider.timeValueAsDouble):
(WTFMediaTimeProvider.isIndefinite):
(WTFMediaTimeProvider):
(WTFMediaTimeProvider.hasDoubleValue):

12:48 PM Changeset in webkit [176862] by andersca@apple.com
  • 7 edits in trunk

Add a private browsing mode to MiniBrowser
​https://bugs.webkit.org/show_bug.cgi?id=139308

Reviewed by Sam Weinig.

Source/WebCore:

Use -1 instead of -2 for the deleted value.

  • page/SessionIDHash.h:

Tools:

  • MiniBrowser/mac/AppDelegate.m:

(defaultConfiguration):
(-[BrowserAppDelegate newWindow:]):
(-[BrowserAppDelegate newPrivateWindow:]):

  • MiniBrowser/mac/MainMenu.xib:
  • MiniBrowser/mac/WK2BrowserWindowController.h:
  • MiniBrowser/mac/WK2BrowserWindowController.m:

(-[WK2BrowserWindowController awakeFromNib]):
(-[WK2BrowserWindowController initWithConfiguration:]):
(-[WK2BrowserWindowController dealloc]):
(-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]):

12:27 PM Changeset in webkit [176861] by Chris Dumez
  • 4 edits in trunk/Source/WebCore

Move 'text-emphasis-style' CSS property to the new StyleBuilder
​https://bugs.webkit.org/show_bug.cgi?id=139285

Reviewed by Sam Weinig.

Move 'text-emphasis-style' CSS property to the new StyleBuilder by
using custom code.

No new tests, no behavior change.

  • css/CSSPropertyNames.in:
  • css/DeprecatedStyleBuilder.cpp:

(WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder):
(WebCore::ApplyPropertyTextEmphasisStyle::applyInheritValue): Deleted.
(WebCore::ApplyPropertyTextEmphasisStyle::applyInitialValue): Deleted.
(WebCore::ApplyPropertyTextEmphasisStyle::applyValue): Deleted.
(WebCore::ApplyPropertyTextEmphasisStyle::createHandler): Deleted.

  • css/StyleBuilderCustom.h:

(WebCore::StyleBuilderCustom::applyInitialWebkitTextEmphasisStyle):
(WebCore::StyleBuilderCustom::applyInheritWebkitTextEmphasisStyle):
(WebCore::StyleBuilderCustom::applyValueWebkitTextEmphasisStyle):

11:47 AM Changeset in webkit [176860] by bshafiei@apple.com
  • 2 edits in tags/Safari-600.3.10.1/Source/WebCore

Merged r176855. rdar://problem/19159480

11:44 AM Changeset in webkit [176859] by bshafiei@apple.com
  • 2 edits in branches/safari-600.3-branch/Source/WebCore

Merged r176855. <rdar://problem/19159480>

11:43 AM Changeset in webkit [176858] by Antti Koivisto
  • 3 edits in trunk/Source/WebKit2

In NetworkResourceLoader always bail out after abort()
​https://bugs.webkit.org/show_bug.cgi?id=139299

Reviewed by Alexey Proskuryakov.

Invoking abort() may kill the current object. Take care to bail out after it.

  • NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::NetworkResourceLoader::didReceiveResponseAsync):
(WebKit::NetworkResourceLoader::didReceiveBuffer):
(WebKit::NetworkResourceLoader::didFinishLoading):

Either make sure sendAbortingOnFailure() is called last in callbacks or the results is explicitly tested.

(WebKit::NetworkResourceLoader::bufferingTimerFired):
(WebKit::NetworkResourceLoader::sendBufferMaybeAborting):

Rename and return a boolean to indicate if load should continue.

(WebKit::NetworkResourceLoader::sendBuffer): Deleted.

  • NetworkProcess/NetworkResourceLoader.h:
11:31 AM Changeset in webkit [176857] by eric.carlson@apple.com
  • 2 edits in trunk/Source/WebCore

[iOS] remove "enter optimized fullscreen" gesture
​https://bugs.webkit.org/show_bug.cgi?id=139301

Reviewed by Jer Noble.

  • Modules/mediacontrols/mediaControlsiOS.js:

(ControllerIOS.prototype.handleWrapperTouchStart): Remove gesture recognizer.

11:28 AM Changeset in webkit [176856] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit/mac

Legacy WebKit should set deviceScaleFactor in _commonInitializationWithFrameName, not _initWithFrame
​https://bugs.webkit.org/show_bug.cgi?id=139306
<rdar://problem/19157955>

Reviewed by Beth Dakin.

  • WebView/WebView.mm:

(-[WebView _commonInitializationWithFrameName:groupName:]):
(-[WebView _initWithFrame:frameName:groupName:]):
Move setDeviceScaleFactor to the initialization path that is guaranteed to happen.

11:21 AM Changeset in webkit [176855] by Beth Dakin
  • 2 edits in trunk/Source/WebCore

rdar://problem/19156353 Additional build-fixes needed.

Rubber-stamped by Tim Horton.

This is a bit unfortunate, but we need to always forward-declare this for now.

  • platform/spi/mac/QuickLookMacSPI.h:
11:10 AM Changeset in webkit [176854] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

Don't use PLATFORM(IOS) in non-project headers.

  • UIProcess/API/Cocoa/WKWebViewConfiguration.mm:

(-[WKWebViewConfiguration _allowsAlternateFullscreen]):

  • UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h:
10:48 AM Changeset in webkit [176853] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebInspectorUI

Web Inspector: Uncaught Exceptions when attempting to show Content Flow
​https://bugs.webkit.org/show_bug.cgi?id=139276

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-12-05
Reviewed by Brian Burg.

  • UserInterface/Views/ContentView.js:

(WebInspector.ContentView):
(WebInspector.ContentView.isViewable):
LegacyJavaScriptProfileObject no longer exists, these references should be removed.

  • UserInterface/Views/FolderizedTreeElement.js:

(WebInspector.FolderizedTreeElement.prototype._insertChildTreeElement):
This sort function references "this" and needed to be bound.

10:46 AM Changeset in webkit [176852] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WTF

[WinCairo] WTF project is missing a GStreamer source file.
​https://bugs.webkit.org/show_bug.cgi?id=139296

Patch by ​peavo@outlook.com <​peavo@outlook.com> on 2014-12-05
Reviewed by Philippe Normand.

The WTF project file is missing a GStreamer source file,
causing a link error when compiling with GStreamer enabled.

  • WTF.vcxproj/WTF.vcxproj:
  • WTF.vcxproj/WTF.vcxproj.filters:
10:38 AM Changeset in webkit [176851] by bshafiei@apple.com
  • 5 edits in branches/safari-600.1.4.13-branch/Source

Versioning.

10:35 AM Changeset in webkit [176850] by bshafiei@apple.com
  • 1 copy in branches/safari-600.1.4.13-branch

New Branch.

10:30 AM Changeset in webkit [176849] by andersca@apple.com
  • 5 edits
    2 adds in trunk/Source/WebKit2

WKBundleCSSStyleDeclarationRef needs to be a real API::Object
​https://bugs.webkit.org/show_bug.cgi?id=139291

Patch by Sam Weinig <​sam@webkit.org> on 2014-12-05
Reviewed by Dan Bernstein.

Change WKBundleCSSStyleDeclarationRef from being a WebCore::CSSStyleDeclaration, to
being a real API::Object. WKRetain and WKRelease require this.

  • Shared/APIObject.h:
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/InjectedBundle/API/c/WKBundleAPICast.h:
  • WebProcess/InjectedBundle/DOM/InjectedBundleCSSStyleDeclarationHandle.cpp: Added.

(WebKit::domHandleCache):
(WebKit::InjectedBundleCSSStyleDeclarationHandle::getOrCreate):
(WebKit::InjectedBundleCSSStyleDeclarationHandle::InjectedBundleCSSStyleDeclarationHandle):
(WebKit::InjectedBundleCSSStyleDeclarationHandle::~InjectedBundleCSSStyleDeclarationHandle):

  • WebProcess/InjectedBundle/DOM/InjectedBundleCSSStyleDeclarationHandle.h: Added.
  • WebProcess/InjectedBundle/InjectedBundlePageEditorClient.cpp:

(WebKit::InjectedBundlePageEditorClient::shouldApplyStyle):

10:23 AM Changeset in webkit [176848] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Oops, didn't mean to commit this.

  • Shared/API/Cocoa/WKFoundation.h:
10:20 AM Changeset in webkit [176847] by andersca@apple.com
  • 8 edits
    3 copies in trunk/Source/WebKit2

Add an API::WebsiteDataStore object and use it for _WKWebsiteDataStore
​https://bugs.webkit.org/show_bug.cgi?id=139304

Reviewed by Tim Horton.

  • Shared/APIObject.h:
  • Shared/Cocoa/APIObject.mm:

(API::Object::newObject):
Make _WKWebsiteDataStore a wrapper for API::WebsiteDataStore instead of API::Session.

  • UIProcess/API/APIWebsiteDataStore.cpp: Added.

(API::generateNonPersistentSessionID):
(API::WebsiteDataStore::defaultDataStore):
(API::WebsiteDataStore::createNonPersistentDataStore):
(API::WebsiteDataStore::WebsiteDataStore):
(API::WebsiteDataStore::~WebsiteDataStore):
(API::WebsiteDataStore::isNonPersistent):
Add new WebsiteDataStore implementation. Currently it only contains the WebCore Session ID, but more will be
added to it in upcoming commits.

  • UIProcess/API/APIWebsiteDataStore.h:

Add header.

  • UIProcess/API/Cocoa/APIWebsiteDataStoreCocoa.mm: Added.

(API::WebsiteDataStore::defaultDataStoreConfiguration):
Platform specific file that returns the default data store configuration.

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView initWithFrame:configuration:]):
Set the session ID from the website data store.

  • UIProcess/API/Cocoa/_WKWebsiteDataStore.mm:

(+[_WKWebsiteDataStore defaultDataStore]):
(+[_WKWebsiteDataStore nonPersistentDataStore]):
(-[_WKWebsiteDataStore dealloc]):
(-[_WKWebsiteDataStore isNonPersistent]):
(-[_WKWebsiteDataStore _apiObject]):
Update now that we wrap an API::WebsiteDataStore instead.

  • UIProcess/API/Cocoa/_WKWebsiteDataStoreInternal.h:

(WebKit::wrapper):
Update for API::Session -> API::WebsiteDataStore change.

  • WebKit2.xcodeproj/project.pbxproj:

Add new files.

9:55 AM Changeset in webkit [176846] by ddkilzer@apple.com
  • 8 edits in trunk/Source

FeatureDefines.xcconfig: Workaround bug in Xcode 5.1.1 when defining ENABLE_WEB_REPLAY
<​http://webkit.org/b/139286>

Reviewed by Daniel Bates.

  • Configurations/FeatureDefines.xcconfig: Switch back to using

PLATFORM_NAME to workaround a bug in Xcode 5.1.1 on 10.8.

9:33 AM Changeset in webkit [176845] by andersca@apple.com
  • 10 edits in trunk/Source/WebKit2

Make WebPageProxy hold on to a SessionID instead of an API:Session
​https://bugs.webkit.org/show_bug.cgi?id=139302

Reviewed by Sam Weinig.

This is in preparation for adding API::WebsiteDataStore. Currently we have to keep the
Session ID and the WebsiteDataStore separate because we still need to support toggling private browsing.

  • UIProcess/API/C/WKPage.cpp:

(WKPageSetSession):

  • UIProcess/API/C/WKSessionRef.cpp:

(WKSessionCreate):

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView initWithFrame:configuration:]):

  • UIProcess/API/Cocoa/_WKWebsiteDataStore.mm:

(+[_WKWebsiteDataStore nonPersistentDataStore]):

  • UIProcess/APISession.cpp:

(API::generateID):
(API::Session::Session):
(API::Session::createEphemeral):
(API::Session::legacyPrivateSession): Deleted.
(API::Session::create): Deleted.

  • UIProcess/APISession.h:
  • UIProcess/WebContext.cpp:

(WebKit::WebContext::createWebPage):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::setSessionID):
(WebKit::WebPageProxy::creationParameters):
(WebKit::WebPageProxy::setSession): Deleted.

  • UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::sessionID):

9:26 AM Changeset in webkit [176844] by bshafiei@apple.com
  • 5 edits in tags/Safari-600.3.10.1/Source

Versioning.

9:23 AM Changeset in webkit [176843] by bshafiei@apple.com
  • 1 copy in tags/Safari-600.3.10.1

New tag.

8:34 AM Changeset in webkit [176842] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit/win

Follow-up build fix.

  • WebCoreSupport/WebVisitedLinkStore.cpp:

(WebVisitedLinkStore::shared):

5:25 AM Changeset in webkit [176841] by eric.carlson@apple.com
  • 10 edits in trunk/Source

[iOS] allow host application to opt-out of alternate fullscreen pt. 2
​https://bugs.webkit.org/show_bug.cgi?id=139227

Source/WebCore:

Reviewed by Jer Noble and Anders Carlsson

  • WebCore.exp.in: Export HTMLMediaSession::allowsAlternateFullscreen, change the signature of

WebVideoFullscreenInterfaceAVKit::setupFullscreen.

  • platform/ios/WebVideoFullscreenControllerAVKit.mm:

(-[WebVideoFullscreenController enterFullscreen:mode:]): Update for

WebVideoFullscreenInterfaceAVKit::setupFullscreen change.

  • platform/ios/WebVideoFullscreenInterfaceAVKit.h: Add argument to setupFullscreen.
  • platform/ios/WebVideoFullscreenInterfaceAVKit.mm:

(WebVideoFullscreenInterfaceAVKit::setupFullscreen): Ditto.

Source/WebKit2:

Reviewed by Jer Noble and Anders Carlsson.

  • UIProcess/ios/WebVideoFullscreenManagerProxy.h: Add bool param to setupFullscreenWithID.
  • UIProcess/ios/WebVideoFullscreenManagerProxy.messages.in: Ditto.
  • UIProcess/ios/WebVideoFullscreenManagerProxy.mm:

(WebKit::WebVideoFullscreenManagerProxy::setupFullscreenWithID): Ditto.

  • WebProcess/ios/WebVideoFullscreenManager.mm:

(WebKit::WebVideoFullscreenManager::enterVideoFullscreenForVideoElement): Pass new parameter

to SetupFullscreenWithID.

2:29 AM Changeset in webkit [176840] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix build warning in WebCore/platform/graphics module
​https://bugs.webkit.org/show_bug.cgi?id=139290

Patch by Shivakumar JM <​shiva.jm@samsung.com> on 2014-12-05
Reviewed by Carlos Garcia Campos.

Fix a build warning by removing parameter name from function.

No new tests, no behavior change.

  • platform/graphics/freetype/FontCacheFreeType.cpp:

(WebCore::getFamilyNameStringFromFontDescriptionAndFamily):

12:11 AM Changeset in webkit [176839] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

GraphicsLayerTextureMapper: Rename parameter to be more clear
​https://bugs.webkit.org/show_bug.cgi?id=139288

Patch by sungmin cho <​sungmin17.cho@lge.com> on 2014-12-05
Reviewed by Martin Robinson.

Rename 'media' to 'platformLayer'.

No new tests, no change in functionality.

  • platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:

(WebCore::GraphicsLayerTextureMapper::setContentsToPlatformLayer):

Note: See TracTimeline for information about the timeline view.