Timeline



Dec 7, 2014:

7:50 PM Changeset in webkit [176934] by yoon@igalia.com
  • 9 edits in trunk/Source/WebKit2

[CoordinatedGraphics] Change the namespace of CoordinatedBackingStore and CoordinatedGraphicsScene
​https://bugs.webkit.org/show_bug.cgi?id=139372

Reviewed by Gyuyoung Kim.

CoordinatedBackingStore and CoordinatedGraphicsScene should be declared in the WebKit namespace
instead of WebCore namespace.

  • UIProcess/API/CoordinatedGraphics/WKCoordinatedScene.cpp:
  • UIProcess/CoordinatedGraphics/CoordinatedBackingStore.cpp:
  • UIProcess/CoordinatedGraphics/CoordinatedBackingStore.h:

(WebKit::CoordinatedBackingStoreTile::CoordinatedBackingStoreTile):
(WebKit::CoordinatedBackingStore::rect):
(WebCore::CoordinatedBackingStoreTile::CoordinatedBackingStoreTile): Deleted.
(WebCore::CoordinatedBackingStore::rect): Deleted.

  • UIProcess/CoordinatedGraphics/CoordinatedGraphicsScene.cpp:
  • UIProcess/CoordinatedGraphics/CoordinatedGraphicsScene.h:

(WebKit::CoordinatedGraphicsScene::setViewBackgroundColor):
(WebKit::CoordinatedGraphicsScene::viewBackgroundColor):
(WebKit::CoordinatedGraphicsScene::layerByID):
(WebKit::CoordinatedGraphicsScene::rootLayer):
(WebCore::CoordinatedGraphicsScene::setViewBackgroundColor): Deleted.
(WebCore::CoordinatedGraphicsScene::viewBackgroundColor): Deleted.
(WebCore::CoordinatedGraphicsScene::layerByID): Deleted.
(WebCore::CoordinatedGraphicsScene::rootLayer): Deleted.

  • UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.h:

(WebKit::CoordinatedLayerTreeHostProxy::coordinatedGraphicsScene):

  • UIProcess/CoordinatedGraphics/WKCoordinatedSceneAPICast.h:

(WebKit::toImpl):
(WebKit::toAPI):
(toImpl): Deleted.
(toAPI): Deleted.

  • UIProcess/CoordinatedGraphics/WebView.h:
3:25 PM Changeset in webkit [176933] by akling@apple.com
  • 5 edits in trunk/Source

Use more PassRef in AtomicString.
<​https://webkit.org/b/139319>

Reviewed by Antti Koivisto.

Make a pass over AtomicString and convert functions that return PassRefPtr
into returning RefPtr (where it may be null) and PassRef otherwise.
This allows the compiler to skip null checks in many places.

  • wtf/text/AtomicString.cpp:

(WTF::addToStringTable):
(WTF::AtomicString::add):
(WTF::AtomicString::addFromLiteralData):
(WTF::AtomicString::addSlowCase):

  • wtf/text/AtomicString.h:

(WTF::AtomicString::add):
(WTF::AtomicString::addWithStringTableProvider):

  • wtf/text/cf/AtomicStringCF.cpp:

(WTF::AtomicString::add):

2:25 PM Changeset in webkit [176932] by Csaba Osztrogonác
  • 2 edits in trunk/Source/JavaScriptCore

Remove the unused WTF_USE_GCC_COMPUTED_GOTO_WORKAROUND after r129453.
​https://bugs.webkit.org/show_bug.cgi?id=139373

Reviewed by Sam Weinig.

  • interpreter/Interpreter.cpp:
2:00 PM Changeset in webkit [176931] by yoon@igalia.com
  • 2 edits in trunk/Source/WebCore

[TextureMapper] Normalize pattern transform for pattern compositing
​https://bugs.webkit.org/show_bug.cgi?id=139374

Reviewed by Martin Robinson.

In CoordGfx/TexMapGL, pattern compositing (for background image) uses
the patternTransform shader uniform. However, current implementation
miscalculates its transform matrix. It uses simple rectToRect
transformationMatrix which produces unnormalized garbage term.
This causes unexpected behavior at the fragmentation stage in some
mobile GPUs.

It should calculate its scale based on tileSize and contentSize,
and its position based on tilePhase and contentSize.

No new tests because the bug only occurs on some mobile GPUs.

  • platform/graphics/texmap/TextureMapperLayer.cpp:

(WebCore::TextureMapperLayer::computePatternTransformIfNeeded):

12:05 PM Changeset in webkit [176930] by commit-queue@webkit.org
  • 6 edits
    4 adds
    2 deletes in trunk

[Soup][Curl] HTTP header values should be treated as latin1, not UTF-8
​https://bugs.webkit.org/show_bug.cgi?id=128739

Patch by Youenn Fablet <​youenn.fablet@crf.canon.fr> on 2014-12-07
Reviewed by Martin Robinson.
Source/WebCore:

Removed UTF-8 conversion of HTTP header values (SOUP and CURL).
Removed unnecessary UTF-8 conversion of HTTP header names (SOUP).
Changed conversion of HTTP method from UTF-8 to ASCII (SOUP and CURL).
Added explicit UTF-8 conversion of Content-Disposition header to compute download suggested filename.

Test: http/tests/xmlhttprequest/response-special-characters.html

  • platform/network/curl/CurlDownload.cpp:

(WebCore::CurlDownload::headerCallback): Removed header conversion.

  • platform/network/curl/ResourceHandleManager.cpp:

(WebCore::headerCallback): Ditto.
(WebCore::ResourceHandleManager::initializeHandle): Changed HTTP method conversion to ASCI.

  • platform/network/soup/ResourceRequestSoup.cpp:

(WebCore::ResourceRequest::updateFromSoupMessageHeaders): Removed header conversion.
(WebCore::ResourceRequest::updateSoupMessage): Changed HTTP method conversion to ASCII.
(WebCore::ResourceRequest::toSoupMessage): Ditto.
(WebCore::ResourceRequest::updateFromSoupMessage):

  • platform/network/soup/ResourceResponseSoup.cpp:

(WebCore::ResourceResponse::updateFromSoupMessageHeaders): Rmoved header conversion.
(WebCore::ResourceResponse::platformSuggestedFilename): Added explicit conversion of contentDisposition to UTF-8.

LayoutTests:

Tests that non ascii header & reason phrase values are correctly retrieved by the web application.
headers.php script sends a response that includes non ascii header value.
not-ascii-status.php sends a response that includes non ascii reason phrase.
Removed specific gtk/efl expectations as now aligned with regular expectation.

  • http/tests/xmlhttprequest/resources/headers.php: Added.
  • http/tests/xmlhttprequest/resources/not-ascii-status.php: Added.
  • http/tests/xmlhttprequest/response-special-characters-expected.txt: Added.
  • http/tests/xmlhttprequest/response-special-characters.html: Added.
  • platform/efl/http/tests/security/contentSecurityPolicy/source-list-parsing-nonascii-expected.txt: Removed.
  • platform/gtk/http/tests/security/contentSecurityPolicy/source-list-parsing-nonascii-expected.txt: Removed.
11:58 AM Changeset in webkit [176929] by yoon@igalia.com
  • 3 edits in trunk/Tools

Update style checker to deal with "const override"
​https://bugs.webkit.org/show_bug.cgi?id=139371

Reviewed by Csaba Osztrogonác.

check-webkit-style shouldn't complain about an open brace to start a
line after a function definition with const override.

  • Scripts/webkitpy/style/checkers/cpp.py:

(check_braces):

  • Scripts/webkitpy/style/checkers/cpp_unittest.py:

(CppStyleTest.test_brace_at_begin_of_line):

11:24 AM Changeset in webkit [176928] by berto@igalia.com
  • 2 edits in trunk

[GTK] WebKit has a new required dependency on GnuTLS
​https://bugs.webkit.org/show_bug.cgi?id=136158

Reviewed by Martin Robinson.

Detect if GnuTLS is installed and enable or disable subtle crypto
support accordingly.

  • Source/cmake/OptionsGTK.cmake:
10:57 AM Changeset in webkit [176927] by ap@apple.com
  • 1 edit
    1 move in trunk/LayoutTests

fast/borders/mixed-border-style2.html has missing results on Mac Yosemite.

Looking at the bots, Yosemite results are the same as Mavericks, so moving the file.

  • platform/mac-mavericks/fast/borders/mixed-border-style2-expected.txt: Removed.
  • platform/mac/fast/borders/mixed-border-style2-expected.txt: Copied from LayoutTests/platform/mac-mavericks/fast/borders/mixed-border-style2-expected.txt.
10:53 AM Changeset in webkit [176926] by ap@apple.com
  • 2 edits
    1 delete in trunk/LayoutTests

Remove platform/mac-mavericks/TestExpectations file.

We don't need it, we should be using modifiers such as [ Mavericks ].

  1. platform/mac/editing/input/undo-grouping-on-text-insertion.html was already

skipped on all OS versions in platform/mac, so this skip did nothing.

  1. Moved css3/filters/backdrop expectation to platform/mac.
  2. css3/viewport-percentage-lengths tests are now fixed by a configuration change

on a bot.

  • platform/mac-mavericks/TestExpectations: Removed.
  • platform/mac/TestExpectations:
10:11 AM Changeset in webkit [176925] by Carlos Garcia Campos
  • 2 edits in trunk/Tools

[GTK] Fix GObject DOM bindings API break tests after r176920
​https://bugs.webkit.org/show_bug.cgi?id=139368

Reviewed by Gustavo Noronha Silva.

Remove the @version from the symbol name before comparing.

  • gtk/check-for-webkitdom-api-breaks:

(read_expected_api):

10:08 AM WebKitGTK/2.4.x edited by berto@igalia.com
(diff)
9:28 AM Changeset in webkit [176924] by mitz@apple.com
  • 34 edits in trunk/Source

Introduce and deploy a function that allocates and returns an instance of a soft-linked class
​https://bugs.webkit.org/show_bug.cgi?id=139348

Reviewed by Anders Carlsson.

In [[getFooClass() alloc] init*], the type of the result of +alloc is id, so the compiler
picks an arbitrary declaration of init*, not necessarily the Foo one. This can then lead
to warnings or errors if the types or attributes don’t match, or to runtime errors if Foo
doesn’t even have the expected initializer. The new allocFooInstance() returns a Foo *, thus
avoiding the ambiguity.

Source/WebCore:

  • editing/mac/DataDetection.mm:

(WebCore::DataDetection::detectItemAroundHitTestResult):

  • platform/audio/ios/MediaSessionManagerIOS.mm:

(-[WebMediaSessionHelper allocateVolumeView]):
(-[WebMediaSessionHelper startMonitoringAirPlayRoutes]):

  • platform/graphics/avfoundation/AudioSourceProviderAVFObjC.mm:

(WebCore::AudioSourceProviderAVFObjC::createMix):

  • platform/graphics/avfoundation/objc/CDMSessionAVFoundationObjC.mm:
  • platform/graphics/avfoundation/objc/InbandTextTrackPrivateAVFObjC.mm:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerLayer):
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVAssetForURL):
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayer):
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerItem):
(WebCore::MediaPlayerPrivateAVFoundationObjC::createVideoOutput):

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:

(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::MediaPlayerPrivateMediaSourceAVFObjC):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::ensureLayer):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::streamSession):

  • platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:

(WebCore::SourceBufferPrivateAVFObjC::SourceBufferPrivateAVFObjC):
(WebCore::SourceBufferPrivateAVFObjC::abort):
(WebCore::SourceBufferPrivateAVFObjC::trackDidChangeEnabled):

  • platform/graphics/ca/mac/PlatformCALayerMac.mm:

(PlatformCALayerMac::PlatformCALayerMac): Cast the result of +alloc to an instance of the
expected class.

  • platform/graphics/mac/FontMac.mm:

(WebCore::showLetterpressedGlyphsWithAdvances):

  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm:

(WebCore::MediaPlayerPrivateQTKit::createQTMovie):
(WebCore::MediaPlayerPrivateQTKit::createQTMovieLayer):

  • platform/graphics/mac/PDFDocumentImageMac.mm:

(WebCore::PDFDocumentImage::createPDFDocument):

  • platform/ios/PlatformSpeechSynthesizerIOS.mm:

(SOFT_LINK_CONSTANT):
(-[WebSpeechSynthesisWrapper speakUtterance:]):

  • platform/ios/WebCoreMotionManager.mm:

(-[WebCoreMotionManager initializeOnMainThread]):

  • platform/ios/WebVideoFullscreenInterfaceAVKit.mm:

(-[WebAVPlayerController init]):
(WebVideoFullscreenInterfaceAVKit::setupFullscreen):

  • platform/mac/ContentFilterMac.mm:

(WebCore::ContentFilter::ContentFilter):

  • platform/mac/SoftLinking.h: Added alloc##className##instance().
  • platform/mac/WebVideoFullscreenController.mm:

(-[WebVideoFullscreenController setVideoElement:]):

  • platform/mediastream/mac/AVAudioCaptureSource.mm:

(WebCore::AVAudioCaptureSource::setupCaptureSession):

  • platform/mediastream/mac/AVCaptureDeviceManager.mm:

(WebCore::AVCaptureDeviceManager::verifyConstraintsForMediaType):

  • platform/mediastream/mac/AVMediaCaptureSource.mm:

(WebCore::AVMediaCaptureSource::setupSession):

  • platform/mediastream/mac/AVVideoCaptureSource.mm:

(WebCore::AVVideoCaptureSource::setupCaptureSession):

  • platform/network/ios/QuickLook.mm:

(WebCore::registerQLPreviewConverterIfNeeded):
(WebCore::QuickLookHandle::QuickLookHandle):

Source/WebKit/ios:

  • Misc/WebGeolocationCoreLocationProvider.mm:

(-[WebGeolocationCoreLocationProvider createLocationManager]):

Source/WebKit/mac:

  • WebView/WebActionMenuController.mm:

(-[WebActionMenuController _defaultMenuItemsForDataDetectableLink]):

Source/WebKit2:

  • UIProcess/ios/forms/WKAirPlayRoutePicker.mm:

(-[WKAirPlayRoutePicker showAirPlayPickerIPad:fromRect:]):
(-[WKAirPlayRoutePicker showAirPlayPickerIPhone:]):
(-[WKAirPlayRoutePicker show:fromRect:]):

  • UIProcess/ios/forms/WKFileUploadPanel.mm:

(-[_WKVideoFileUploadItem displayImage]):

  • UIProcess/mac/WKActionMenuController.mm:

(-[WKActionMenuController _defaultMenuItemsForDataDetectableLink]):

  • WebProcess/WebPage/mac/PlatformCALayerRemoteCustom.mm:

(WebKit::PlatformCALayerRemoteCustom::clone):

8:23 AM Changeset in webkit [176923] by Carlos Garcia Campos
  • 2 edits in trunk/Tools

Remove the option to automatically update the GObject DOM bindings symbols file
​https://bugs.webkit.org/show_bug.cgi?id=139366

Reviewed by Martin Robinson.

It's currently broken, because symbols now need to be in a
specific order. Now that the symbols file only contains stable
API, it's not a problem to manually update it every time new API
is added.

  • gtk/check-for-webkitdom-api-breaks:

(read_expected_api):
(check_api):
(write_expected_api): Deleted.

8:19 AM WebKitGTK/KeepingTheTreeGreen edited by clopez@igalia.com
(diff)
8:11 AM Changeset in webkit [176922] by clopez@igalia.com
  • 2 edits
    4 adds in trunk/LayoutTests

[GTK] Unreviewed GTK gardening.

  • platform/gtk/TestExpectations: Report and mark new failures.
  • platform/gtk/svg/animations/animate-marker-orienttype-1-expected.txt: Added. Rebaseline after r175525.
  • platform/gtk/svg/animations/animate-marker-orienttype-2-expected.txt: Added. Rebaseline after r175525.
  • platform/gtk/svg/animations/animate-marker-orienttype-3-expected.txt: Added. Rebaseline after r175525.
6:08 AM Changeset in webkit [176921] by Carlos Garcia Campos
  • 4 edits in trunk/Tools

[GTK] Use GMainLoopSource in WebKitTestRunner
​https://bugs.webkit.org/show_bug.cgi?id=138831

Reviewed by Sergio Villar Senin.

  • WebKitTestRunner/InjectedBundle/TestRunner.h:
  • WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:

(WTR::TestRunner::platformInitialize):
(WTR::TestRunner::invalidateWaitToDumpWatchdogTimer):
(WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
(WTR::waitToDumpWatchdogTimerCallback): Deleted.

  • WebKitTestRunner/gtk/TestControllerGtk.cpp:

(WTR::TestController::notifyDone):
(WTR::TestController::platformRunUntil):
(WTR::cancelTimeout): Deleted.

5:40 AM Changeset in webkit [176920] by Carlos Garcia Campos
  • 3 edits in trunk/Source/WebCore

[GTK] Add Since tags to GObject DOM bindings documentation
​https://bugs.webkit.org/show_bug.cgi?id=139356

Reviewed by Gustavo Noronha Silva.

Now that we have a small stable API, and new symbols are added
manually, we can also add the version to the symbols file, that
the code generator can ue to add Since tags to the gtk-doc.

  • bindings/gobject/webkitdom.symbols: Add @2.8 to the new symbols

added for 2.8.

  • bindings/scripts/CodeGeneratorGObject.pm:

(GenerateConstants): Add Since tag to gtk-doc if there's a version
number for the symbol in the .symbols file.
(GenerateFunction): Ditto.
(ReadStableSymbols):

4:00 AM WebKitGTK/2.6.x edited by Ting-Wei Lan
(diff)
3:39 AM WebKitGTK/2.6.x edited by berto@igalia.com
(diff)
2:02 AM Changeset in webkit [176919] by Carlos Garcia Campos
  • 9 edits
    3 adds in trunk

[GTK] Missing API detected in GObject DOM bindings after r176630
​https://bugs.webkit.org/show_bug.cgi?id=139201

Reviewed by Gustavo Noronha Silva.

.:

Change GENERATE_BINDINGS macro to receive a list of optional
additional dependencies, so that we can add more dependecies
without having to change the macro.

  • Source/cmake/WebKitMacros.cmake:

Source/WebCore:

Bring back WebKitDOMDeprecated and add custom versions of the
removed symbols as deprecated in favor of the new ones. Also add
the new ones as stable API.

  • CMakeLists.txt: Pass a list of additional dependencies to GENERATE_BINDINGS.
  • PlatformGTK.cmake: Ditto.
  • PlatformMac.cmake: Ditto.
  • bindings/gobject/WebKitDOMDeprecated.cpp: Added.

(webkit_dom_html_element_get_inner_html):
(webkit_dom_html_element_set_inner_html):
(webkit_dom_html_element_get_outer_html):
(webkit_dom_html_element_set_outer_html):

  • bindings/gobject/WebKitDOMDeprecated.h: Added.
  • bindings/gobject/WebKitDOMDeprecated.symbols: Added.
  • bindings/gobject/webkitdom.symbols:

Tools:

Handle deprecated symbols again when generating the GObject DOM
bindings documentation.

  • gtk/webkitdom.py:

(WebKitDOMDocGenerator):
(WebKitDOMDocGenerator.is_deprecated_symbol_file):
(WebKitDOMDocGenerator.generate):
(WebKitDOMDocGeneratorSections.init):
(WebKitDOMDocGeneratorSections._find_deprecated_symbols):
(WebKitDOMDocGeneratorSections.write_section):

1:17 AM Changeset in webkit [176918] by Csaba Osztrogonác
  • 2 edits
    2 adds in trunk/Tools

[EFL][jhbuild] Fix libsoup build with clang
​https://bugs.webkit.org/show_bug.cgi?id=139088

Reviewed by Gyuyoung Kim.

  • efl/jhbuild.modules:
  • efl/patches/soup-clang-warning-fix1.patch: Added.
  • efl/patches/soup-clang-warning-fix2.patch: Added.
1:15 AM WebKitGTK/KeepingTheTreeGreen edited by clopez@igalia.com
(diff)

Dec 6, 2014:

3:52 PM Changeset in webkit [176917] by ap@apple.com
  • 2 edits in trunk/Tools

[Mac] DumpRenderTree sets storage directory incorrectly
​https://bugs.webkit.org/show_bug.cgi?id=139347

Reviewed by Dan Bernstein.

  • DumpRenderTree/mac/DumpRenderTree.mm: (setDefaultsToConsistentValuesForTesting):

Don't use user defaults to pass per-instance paths, as user defaults are shared
across all instances.

3:35 PM Changeset in webkit [176916] by Csaba Osztrogonác
  • 3 edits in trunk/Source/WebCore

URTBF after r176915.

DisplayRefreshMonitorClient is the parent class of GraphicsLayerUpdater
only if USE(REQUEST_ANIMATION_FRAME_DISPLAY_MONITOR) is true, so override
is incorrect if USE(REQUEST_ANIMATION_FRAME_DISPLAY_MONITOR) is false.

That's why r176915 broke the build on non PLATFORM(COCOA) platforms,
such as GTK, EFL, Apple Windows.

Additionally displayRefreshFired is only used inside USE(REQUEST_ANIMATION_FRAME_DISPLAY_MONITOR)
guard, so there is no reason to define it for non COCOA platforms.

  • platform/graphics/GraphicsLayerUpdater.cpp:
  • platform/graphics/GraphicsLayerUpdater.h:
1:44 PM Changeset in webkit [176915] by andersca@apple.com
  • 33 edits in trunk/Source

Fix build with newer versions of clang.
rdar://problem/18978733

Source/WebCore:

Add a bunch of overrides since we're not disabling the "inconsistent missing override" warning in WebKit.

  • page/scrolling/AsyncScrollingCoordinator.h:
  • page/scrolling/ScrollingStateFixedNode.h:
  • page/scrolling/ScrollingStateFrameScrollingNode.h:
  • page/scrolling/ScrollingStateOverflowScrollingNode.h:
  • page/scrolling/ScrollingStateStickyNode.h:
  • page/scrolling/ScrollingTreeFrameScrollingNode.h:

(WebCore::ScrollingTreeFrameScrollingNode::updateLayersAfterDelegatedScroll): Deleted.

  • page/scrolling/ios/ScrollingTreeFrameScrollingNodeIOS.h:
  • platform/graphics/GraphicsLayerUpdater.h:
  • platform/mac/ScrollbarThemeMac.h:

(WebCore::ScrollbarThemeMac::supportsControlTints): Deleted.
(WebCore::ScrollbarThemeMac::maxOverlapBetweenPages): Deleted.

  • rendering/RenderLayerCompositor.h:
  • rendering/RenderSnapshottedPlugIn.h:

Source/WebKit2:

Add missing overrides and casts.

  • NetworkProcess/NetworkProcess.h:
  • Shared/Downloads/DownloadAuthenticationClient.h:

(WebKit::DownloadAuthenticationClient::refAuthenticationClient): Deleted.
(WebKit::DownloadAuthenticationClient::derefAuthenticationClient): Deleted.

  • UIProcess/API/C/WKPage.cpp:

(WKPageSetPageUIClient):

  • UIProcess/API/Cocoa/WKWebViewConfiguration.mm:

(-[WKWebViewConfiguration copyWithZone:]):

  • UIProcess/API/Cocoa/_WKProcessPoolConfiguration.mm:

(-[_WKProcessPoolConfiguration copyWithZone:]):

  • UIProcess/Cocoa/NavigationState.h:
  • UIProcess/Network/NetworkProcessProxy.h:
  • UIProcess/Scrolling/ios/ScrollingTreeOverflowScrollingNodeIOS.h:

(WebKit::ScrollingTreeOverflowScrollingNodeIOS::updateLayersAfterViewportChange): Deleted.

  • UIProcess/WebPageProxy.h:
  • WebProcess/EntryPoint/mac/LegacyProcess/WebContentProcessMain.mm:

(WebKit::WebContentProcessMainDelegate::doPreInitializationWork): Deleted.
(WebKit::WebContentProcessMainDelegate::getConnectionIdentifier): Deleted.
(WebKit::WebContentProcessMainDelegate::getClientIdentifier): Deleted.
(WebKit::WebContentProcessMainDelegate::getClientProcessName): Deleted.

  • WebProcess/IconDatabase/WebIconDatabaseProxy.h:
  • WebProcess/InjectedBundle/mac/InjectedBundleMac.mm:

(WebKit::InjectedBundle::initialize):

  • WebProcess/WebCoreSupport/WebChromeClient.h:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
  • WebProcess/WebPage/WebBackForwardListProxy.h:
  • WebProcess/WebPage/WebInspector.h:

(WebKit::WebInspector::didClose): Deleted.
(WebKit::WebInspector::didReceiveInvalidMessage): Deleted.

  • WebProcess/WebPage/WebInspectorUI.h:

(WebKit::WebInspectorUI::didClose): Deleted.
(WebKit::WebInspectorUI::didReceiveInvalidMessage): Deleted.

  • WebProcess/WebPage/mac/PlatformCALayerRemoteCustom.h:
  • WebProcess/WebProcess.h:
  • WebProcess/ios/WebVideoFullscreenManager.h:
1:43 PM Changeset in webkit [176914] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Only include TUCallSPI on Mac.

  • Platform/mac/MenuUtilities.mm:
1:27 PM Changeset in webkit [176913] by andersca@apple.com
  • 9 edits
    2 copies
    1 add in trunk/Source

Add a stubbed out version of WebStorageNamespaceProvider
​https://bugs.webkit.org/show_bug.cgi?id=139213

Reviewed by Sam Weinig.

Source/WebKit:

  • Storage/WebStorageNamespaceProvider.cpp: Added.
  • Storage/WebStorageNamespaceProvider.h: Added.
  • WebKit.vcxproj/WebKit/WebKit.vcxproj:
  • WebKit.vcxproj/WebKit/WebKit.vcxproj.filters:
  • WebKit.xcodeproj/project.pbxproj:

Add new files.

Source/WebKit/mac:

  • WebCoreSupport/WebViewGroup.h:

(WebViewGroup::storageNamespaceProvider):

  • WebCoreSupport/WebViewGroup.mm:

(WebViewGroup::getOrCreate):
(WebViewGroup::WebViewGroup):
Give WebViewGroup a storage namespace provider.

1:23 PM Changeset in webkit [176912] by andersca@apple.com
  • 21 edits in trunk/Source

Fix build with newer versions of clang.
rdar://problem/18978687

Source/WebCore:

Add a bunch of overrides since we're not disabling the "inconsistent missing override" warning in WebKit.

  • html/HTMLElement.h:
  • html/HTMLMediaElement.h:
  • html/track/VTTCue.h:
  • loader/FrameNetworkingContext.h:

(WebCore::FrameNetworkingContext::shouldClearReferrerOnHTTPSToHTTPRedirect): Deleted.

  • loader/cache/CachedImage.h:
  • page/SuspendableTimer.h:
  • platform/Scrollbar.h:
  • platform/graphics/InbandTextTrackPrivate.h:
  • rendering/RenderBlockFlow.h:

Source/WebKit/ios:

Cast the result of +alloc to the right type.

  • Misc/WebGeolocationCoreLocationProvider.mm:

(-[WebGeolocationCoreLocationProvider createLocationManager]):

  • WebCoreSupport/WebSelectionRect.m:

(+[WebSelectionRect selectionRect]):

Source/WebKit/mac:

Add missing overrides and missing casts.

  • Storage/WebDatabaseManagerClient.h:
  • Storage/WebStorageTrackerClient.h:
  • WebCoreSupport/WebChromeClient.h:
  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebInspectorClient.h:
  • WebView/WebDataSource.mm:

(-[WebDataSource _makeRepresentation]):

  • WebView/WebFrameView.mm:

(-[WebFrameView _makeDocumentViewForDataSource:]):

1:10 PM Changeset in webkit [176911] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Follow-up build fix.

  • Configurations/Base.xcconfig:
1:04 PM Changeset in webkit [176910] by andersca@apple.com
  • 11 edits in trunk/Source/WebCore

Fix build with newer versions of clang.
rdar://problem/18978689

Disable the "inconsistent missing override" warning due to our use of macros in SVG where it's hard to
know whether we can add an override or not.

Also, cast return values of +alloc to the right type, and add some casts for vector iterator arithmetic.

  • Configurations/Base.xcconfig:
  • Modules/webdatabase/DatabaseBackendBase.cpp:

(WebCore::guidForOriginAndName):

  • accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:

(-[WebAccessibilityObjectWrapper _stringForRange:attributed:]):

  • editing/cocoa/HTMLConverter.mm:

(_shadowForShadowStyle):
(HTMLConverter::_addTableForElement):

  • platform/graphics/SVGGlyph.cpp:

(WebCore::isCompatibleArabicForm):

  • platform/graphics/avfoundation/AudioSourceProviderAVFObjC.mm:

(WebCore::AudioSourceProviderAVFObjC::createMix):

  • platform/graphics/mac/FontMac.mm:

(WebCore::showLetterpressedGlyphsWithAdvances):

  • platform/ios/PlatformSpeechSynthesizerIOS.mm:

(-[WebSpeechSynthesisWrapper speakUtterance:]):

  • platform/ios/WebCoreMotionManager.mm:

(-[WebCoreMotionManager initializeOnMainThread]):

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::spannedRows):
(WebCore::RenderTableSection::spannedColumns):

1:04 PM Changeset in webkit [176909] by andersca@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Fix build with newer versions of clang.
rdar://problem/18978716

  • ftl/FTLJITCode.h:

Add missing overrides.

11:36 AM Changeset in webkit [176908] by mark.lam@apple.com
  • 2 edits in trunk/LayoutTests

Skipping tests due to regression in r176902.
<​https://webkit.org/b/139014>

Not reviewed.

10:26 AM Changeset in webkit [176907] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[WinCairo] Compile error, missing guard.
​https://bugs.webkit.org/show_bug.cgi?id=139338

Patch by ​peavo@outlook.com <​peavo@outlook.com> on 2014-12-06
Reviewed by Alex Christensen.

There is missing a ENABLE(CSS_SELECTORS_LEVEL4) guard in CSSParser.cpp.

  • css/CSSParser.cpp:

(WebCore::CSSParser::realLex):

3:50 AM Changeset in webkit [176906] by commit-queue@webkit.org
  • 3 edits
    2 deletes in trunk

Unreviewed, rolling out r176905.
​https://bugs.webkit.org/show_bug.cgi?id=139337

the test case is failing in bots (Requested by anttik on
#webkit).

Reverted changeset:

"REGRESSION (173394): Support for webcam is broken"
​https://bugs.webkit.org/show_bug.cgi?id=139313
​http://trac.webkit.org/changeset/176905

2:39 AM Changeset in webkit [176905] by Antti Koivisto
  • 3 edits
    2 adds in trunk

REGRESSION (173394): Support for webcam is broken
​https://bugs.webkit.org/show_bug.cgi?id=139313

Reviewed by Alexey Proskuryakov.

Source/WebKit2:

  • NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::NetworkResourceLoader::didReceiveResponseAsync):

Don't buffer when handling multipart/x-mixed-replace. Multiple calls to didReceiveResponseAsync break assumptions.

LayoutTests:

We had no coverage for actually rendering multipart content.

  • http/tests/multipart/multipart-image-expected.html: Added.
  • http/tests/multipart/multipart-image.html: Added.
Note: See TracTimeline for information about the timeline view.