Timeline
Dec 17, 2014:
- 11:14 PM Changeset in webkit [177488] by
-
- 2 edits in trunk/Source/WebCore
URTBF after r177452.
https://bugs.webkit.org/show_bug.cgi?id=139752
- CMakeLists.txt:
- 7:15 PM Changeset in webkit [177487] by
-
- 2 edits in trunk/Websites/perf.webkit.org
Unreviewed build fix.
- public/v2/index.html: Include js files we extracted in r177424.
- 7:06 PM Changeset in webkit [177486] by
-
- 13 edits in trunk/Source
Ref-ify Range::create().
<https://webkit.org/b/139755>
Reviewed by Anders Carlsson.
Source/WebCore:
- dom/Document.cpp:
(WebCore::acceptsEditingFocus):
- dom/Element.cpp:
(WebCore::Element::innerText):
- dom/Range.cpp:
(WebCore::Range::create):
(WebCore::Range::cloneRange):
(WebCore::rangeOfContents):
- dom/Range.h:
- editing/AlternativeTextController.cpp:
(WebCore::AlternativeTextController::applyAlternativeTextToRange):
- editing/CompositeEditCommand.cpp:
(WebCore::CompositeEditCommand::replaceTextInNodePreservingMarkers):
- editing/VisibleUnits.cpp:
(WebCore::charactersAroundPosition):
- editing/markup.cpp:
(WebCore::StyledMarkupAccumulator::renderedText):
- page/FocusController.cpp:
(WebCore::relinquishesEditingFocus):
Source/WebKit/mac:
- WebView/WebHTMLRepresentation.mm:
(-[WebHTMLRepresentation attributedStringFrom:startOffset:to:endOffset:]):
- WebView/WebHTMLView.mm:
(-[WebHTMLView attributedString]):
- 6:12 PM Changeset in webkit [177485] by
-
- 2 edits in trunk/Source/WebKit/mac
Unify -[WebResource description]
https://bugs.webkit.org/show_bug.cgi?id=139762
Reviewed by Dan Bernstein.
- WebView/WebResource.mm:
(-[WebResource description]):
- 6:09 PM Changeset in webkit [177484] by
-
- 11 edits in trunk/Source/WebKit/mac
Get rid of an ugly #define hack in WebFrameLoaderClient
https://bugs.webkit.org/show_bug.cgi?id=139761
Reviewed by Dan Bernstein.
Also replace @private with @package in all public headers, for consistency.
- History/WebBackForwardList.h:
- History/WebHistory.h:
- Misc/WebDownload.h:
- WebCoreSupport/WebFrameLoaderClient.mm:
- WebView/WebArchive.h:
- WebView/WebDataSource.h:
- WebView/WebFrame.h:
- WebView/WebFrameView.h:
- WebView/WebPreferences.h:
- WebView/WebResource.h:
- 6:02 PM Changeset in webkit [177483] by
-
- 6 edits in trunk/Source
<rdar://problem/19282508> WebKitLegacy is unusable due to bad dylib identifier
https://bugs.webkit.org/show_bug.cgi?id=139760
Reviewed by Anders Carlsson.
Source/WebCore:
- Configurations/WebCore.xcconfig:
Source/WebKit/mac:
- Configurations/WebKitLegacy.xcconfig:
Source/WebKit2:
- Configurations/WebKit2.xcconfig:
- 5:56 PM Changeset in webkit [177482] by
-
- 5 edits in trunk/Source
Get rid of FrameLoader::defaultObjectContentType
https://bugs.webkit.org/show_bug.cgi?id=139758
Reviewed by Geoffrey Garen.
Source/WebCore:
Move the FrameLoader::defaultObjectContentType implementation to its only caller in WebKit/win.
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::defaultObjectContentType): Deleted.
- loader/FrameLoader.h:
Source/WebKit/win:
- WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::objectContentType):
- 5:29 PM Changeset in webkit [177481] by
-
- 1 copy in tags/Safari-600.1.4.13.2
New tag.
- 5:25 PM Changeset in webkit [177480] by
-
- 2 edits in branches/safari-600.1.4.13-branch/Source/WebCore
Merged build fix for r177375. rdar://problem/19271256
- 5:05 PM Changeset in webkit [177479] by
-
- 3 edits in branches/safari-600.1.4.13-branch/Source/WebCore
Merged patch for r177375. rdar://problem/19271256
- 4:33 PM Changeset in webkit [177478] by
-
- 2 edits in branches/safari-600.3-branch/Source/WebKit2
Merged r177473. rdar://problems/19286550
- 4:25 PM Changeset in webkit [177477] by
-
- 27 edits in branches/safari-600.3-branch/Source
Merge r177427. rdar://problem/19237945
- 4:25 PM Changeset in webkit [177476] by
-
- 2 edits in branches/safari-600.3-branch/Source/WebKit2
Merged r177411. rdar://problems/19271854
- 4:25 PM Changeset in webkit [177475] by
-
- 4 edits1 add in branches/safari-600.3-branch/Source
Merged r177409. rdar://problems/19271854
- 4:25 PM Changeset in webkit [177474] by
-
- 7 edits in branches/safari-600.3-branch/Source/WebKit2
Merge r177402. rdar://problem/19266297
- 4:15 PM Changeset in webkit [177473] by
-
- 2 edits in trunk/Source/WebKit2
Page previews are sometimes sized much smaller than it seems they should be
https://bugs.webkit.org/show_bug.cgi?id=139754
-and corresponding-
rdar://problem/19286550
Reviewed by Tim Horton.
Increase the minimum size and add in a missing else!!
- UIProcess/mac/WKImmediateActionController.mm:
(-[WKImmediateActionController _preferredPopoverSizeWithPreviewPadding:]):
- 4:00 PM Changeset in webkit [177472] by
-
- 2 edits in trunk/Tools
Move Apple buildbot slaves to their new home.
Reviewed by Roger Fong.
- BuildSlaveSupport/build.webkit.org-config/config.json:
- 3:57 PM Changeset in webkit [177471] by
-
- 7 edits in trunk/Tools
REGRESSION (r177363): Gtk and Efl testing is broken
https://bugs.webkit.org/show_bug.cgi?id=139734
Reviewed by Simon Fraser.
- Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
(SingleTestRunner.init): Remove timeout adjustment from here, because it
affected both script and tool timeout. This is still the right place for this logic,
but it would be a larger refactoring than I can do right now.
- Scripts/webkitpy/port/base.py:
(Port.supports_per_test_timeout): Added a FIXME.
(Port.default_timeout_ms): Now that the effective timeout is longer, change this
to avoid making tests take more time.
- Scripts/webkitpy/port/driver.py:
(Driver.run_test): Adjust script timeout here.
(Driver._check_for_driver_timeout): Fix the timeout detection.
(Driver._read_block): Actually use the timeout detection code.
- WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::beginTesting):
Use TestRunner default timeout when there isn't a timeout passed from command line for the test.
- Scripts/webkitpy/port/port_testcase.py: (PortTestCase.test_default_timeout_ms):
Update results for the new default.
- Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(RunTest.test_hung_thread): Restore a test that I previously deleted, it was
actually a good one.
- 3:45 PM Changeset in webkit [177470] by
-
- 1 move in tags/Safari-600.1.17.5
Correct tag name.
- 3:23 PM Changeset in webkit [177469] by
-
- 6 edits in trunk/Source/WebKit2
Ref-ify WebPageProxy and WebProcessProxy creation functions
https://bugs.webkit.org/show_bug.cgi?id=139751
Reviewed by Andreas Kling.
- UIProcess/WebContext.cpp:
(WebKit::WebContext::createNewWebProcess):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::create):
- UIProcess/WebPageProxy.h:
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::create):
(WebKit::WebProcessProxy::createWebPage):
- UIProcess/WebProcessProxy.h:
- 3:16 PM Changeset in webkit [177468] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed iOS Build Fix after r177459.
- UIProcess/ios/WebInspectorProxyIOS.mm:
(WebKit::WebInspectorProxy::platformInvalidate):
(WebKit::WebInspectorProxy::platformHide):
Add missing WebInspectorProxy platform methods.
- 3:05 PM Changeset in webkit [177467] by
-
- 5 edits in branches/safari-600.1.17-branch/Source
Versioning.
- 2:30 PM Changeset in webkit [177466] by
-
- 1 copy in tags/safari-600.1.17.5
New Tag.
- 2:25 PM Changeset in webkit [177465] by
-
- 6 edits in branches/safari-600.1.17-branch/Source
Merged r177448. rdar://problems/19281928
- 2:24 PM Changeset in webkit [177464] by
-
- 5 edits in trunk/Tools
Unreviewed, rolling out r177456.
https://bugs.webkit.org/show_bug.cgi?id=139749
Broke webkitpy and Mac tests (Requested by ap on #webkit).
Reverted changeset:
"REGRESSION (r177363): Gtk and Efl testing is broken"
https://bugs.webkit.org/show_bug.cgi?id=139734
http://trac.webkit.org/changeset/177456
- 1:56 PM Changeset in webkit [177463] by
-
- 2 edits in trunk/Source/WebKit2
[iOS] Define button and action should respect profile settings.
https://bugs.webkit.org/show_bug.cgi?id=139739
rdar://problem/15461887
Reviewed by Joseph Pecoraro.
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView canPerformAction:withSender:]):
(-[WKContentView _define:]):
- 1:49 PM Changeset in webkit [177462] by
-
- 3 edits304 adds in trunk/LayoutTests
[iOS] More test gardening
- platform/ios-simulator-wk2/TestExpectations:
[...]
- 1:41 PM Changeset in webkit [177461] by
-
- 5 edits in tags/Safari-601.1.12.3/Source
Versioning.
- 1:38 PM Changeset in webkit [177460] by
-
- 4 edits3 adds in trunk
Tests with infinite recursion frequently crash
https://bugs.webkit.org/show_bug.cgi?id=139548
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
While unwinding, if the call frame doesn't have a codeblock, then we
are in native code, handle appropriately.
- interpreter/Interpreter.cpp:
(JSC::unwindCallFrame):
(JSC::UnwindFunctor::operator()):
Added checks for null CodeBlock.
(JSC::Interpreter::unwind): Removed wrong ASSERT.
LayoutTests:
New test that exercises the various places that we do stack overflow checks.
- TestExpectations:
- js/regress-139548-expected.txt: Added.
- js/regress-139548.html: Added.
- js/script-tests/regress-139548.js: Added.
(ToStringObj):
(ToStringObj.prototype.toString):
(makeArgsArray):
(recurseNoDFG):
(recurse):
(probeAndRecurse):
- 1:19 PM Changeset in webkit [177459] by
-
- 7 edits in trunk/Source/WebKit2
Web Inspector: [Mac] Occosional Crashes Closing Inspector
https://bugs.webkit.org/show_bug.cgi?id=139740
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-12-17
Reviewed by Timothy Hatcher.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didReceiveEvent):
The WebPageProxy could have gotten destroyed in handling (e.g. keyboard shortcut
to close the Inspector Window), so protect the object to avoid destruction
during handling.
- UIProcess/WebInspectorProxy.h:
- UIProcess/WebPageProxy.cpp:
Add platformInvalidate opportunity for the platform to do invalidation work.
- UIProcess/efl/WebInspectorProxyEfl.cpp:
(WebKit::WebInspectorProxy::platformInvalidate):
- UIProcess/gtk/WebInspectorProxyGtk.cpp:
(WebKit::WebInspectorProxy::platformInvalidate):
Empty implementations, these ports do not need to do anything.
- UIProcess/WebInspectorProxy.h:
- UIProcess/mac/WebInspectorProxyMac.mm:
(WebKit::WebInspectorProxy::closeTimerFired):
(WebKit::WebInspectorProxy::platformDidClose):
(WebKit::WebInspectorProxy::platformInvalidate):
When closing / invalidating make sure we close the WKView to clear client
for any delayed callbacks.
- 1:15 PM Changeset in webkit [177458] by
-
- 2 edits in trunk/Source/WebCore
[Curl] Compile error, setWasCached method has been removed.
https://bugs.webkit.org/show_bug.cgi?id=139737
Patch by peavo@outlook.com <peavo@outlook.com> on 2014-12-17
Reviewed by Alex Christensen.
The ResourceResponseBase::setWasCached() method has been replaced
with ResourceResponseBase::setSource().
- platform/network/curl/CurlCacheEntry.cpp:
(WebCore::CurlCacheEntry::setResponseFromCachedHeaders):
- 1:08 PM Changeset in webkit [177457] by
-
- 3 edits1 add in tags/Safari-601.1.12.3/Source/JavaScriptCore
Merged r177270. rdar://problems/19245579
- 1:03 PM Changeset in webkit [177456] by
-
- 5 edits in trunk/Tools
REGRESSION (r177363): Gtk and Efl testing is broken
https://bugs.webkit.org/show_bug.cgi?id=139734
Reviewed by Simon Fraser.
- Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
(SingleTestRunner.init): Remove timeout adjustment from here, because it
affected both script and tool timeout. This is still the right place for this logic,
but it would be a larger refactoring than I can do right now.
- Scripts/webkitpy/port/base.py:
(Port.supports_per_test_timeout): Added a FIXME.
(Port.default_timeout_ms): Now that the effective timeout is longer, change this
to avoid making tests take more time.
- Scripts/webkitpy/port/driver.py: (Driver.run_test): Adjust script timeout here.
- WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::beginTesting):
Use TestRunner default timeout when there isn't a timeout passed from command line for the test.
- 1:03 PM Changeset in webkit [177455] by
-
- 22 edits3 moves in trunk/Source
[iOS] Make it possible to toggle FeatureCounter support at runtime
https://bugs.webkit.org/show_bug.cgi?id=139688
<rdar://problem/19266254>
Reviewed by Andreas Kling.
Source/JavaScriptCore:
Stop linking against AppSupport framework as the functionality is no
longer in WTF (it was moved to WebCore).
- Configurations/JavaScriptCore.xcconfig:
Source/WebCore:
Make it possible to toggle FeatureCounter support at runtime by adding
a setting (disabled by default) and moving the API to a new
FeatureCounter class under WebCore/plattorm which only logs if the
setting is enabled. For privacy reasons, FeatureCounter logging is also
disabled for private / ephemeral sessions.
No new tests, no behavior change.
- CMakeLists.txt:
- Configurations/WebCore.xcconfig:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- history/PageCache.cpp:
(WebCore::logCanCacheFrameDecision):
(WebCore::logCanCachePageDecision):
- page/Settings.in:
- platform/FeatureCounter.cpp: Renamed from Source/WTF/wtf/FeatureCounter.cpp.
(WebCore::FeatureCounter::shouldUseForPage):
(WebCore::FeatureCounter::incrementKey):
(WebCore::FeatureCounter::setKey):
- platform/FeatureCounter.h: Renamed from Source/WTF/wtf/FeatureCounter.h.
- platform/FeatureCounterKeys.h:
- platform/ios/FeatureCounter.mm: Renamed from Source/WTF/wtf/ios/FeatureCounter.mm.
(WebCore::FeatureCounter::incrementKey):
(WebCore::FeatureCounter::setKey):
Source/WebKit2:
Add private settings API to toggle FeatureCounter support on Safari and
MobileSafari.
- Shared/WebPreferencesDefinitions.h:
- UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetFeatureCounterEnabled):
(WKPreferencesGetFeatureCounterEnabled):
- UIProcess/API/C/WKPreferencesRefPrivate.h:
- UIProcess/API/Cocoa/WKPreferences.mm:
(-[WKPreferences _featureCounterEnabled]):
(-[WKPreferences _setFeatureCounterEnabled:]):
- UIProcess/API/Cocoa/WKPreferencesPrivate.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):
Source/WTF:
Remove FeatureCounter API from WTF and move it to WebCore/platform
instead so that it can log conditionally based on a WebCore setting.
- WTF.vcxproj/WTF.vcxproj:
- WTF.xcodeproj/project.pbxproj:
- wtf/CMakeLists.txt:
- 12:57 PM Changeset in webkit [177454] by
-
- 1 copy in tags/Safari-601.1.12.3
New Tag.
- 12:32 PM Changeset in webkit [177453] by
-
- 2 edits in trunk/Source/WebKit2
Clean up SQL statement building in SQLiteIDBCursor
https://bugs.webkit.org/show_bug.cgi?id=139741
Reviewed by Andreas Kling.
This vastly simplifies the code and gets rid of the last
uses of DEPRECATED_DEFINE_STATIC_LOCAL in WebKit2.
- DatabaseProcess/IndexedDB/sqlite/SQLiteIDBCursor.cpp:
(WebKit::buildIndexStatement):
(WebKit::buildObjectStoreStatement):
(WebKit::SQLiteIDBCursor::establishStatement):
(WebKit::getIndexStatement): Deleted.
(WebKit::getObjectStoreStatement): Deleted.
- 12:26 PM Ruby edited by
- (diff)
- 12:10 PM Changeset in webkit [177452] by
-
- 5 edits1 delete in trunk/Source/WebCore
Get rid of PluginPackageNone.cpp
https://bugs.webkit.org/show_bug.cgi?id=139735
Reviewed by Andreas Kling.
- CMakeLists.txt:
- PlatformEfl.cmake:
- PlatformGTK.cmake:
- PlatformWin.cmake:
- plugins/PluginPackageNone.cpp: Removed.
- 12:09 PM Changeset in webkit [177451] by
-
- 3 edits in trunk/WebKitLibraries
[Win] Unreviewed build fix (for full build)
- win/tools/vsprops/FeatureDefines.props: Add missing export so the
derived sources are generated properly.
- win/tools/vsprops/FeatureDefinesCairo.props: Ditto.
- 12:07 PM Ruby edited by
- Pictures! (diff)
- 11:39 AM Changeset in webkit [177450] by
-
- 12 edits in trunk/Source
Purge PassRefPtr from Frame.
<https://webkit.org/b/139731>
Reviewed by Anders Carlsson.
Source/WebCore:
Remove all use of PassRefPtr from the Frame class, instead using
Ref or RefPtr as appropriate.
- WebCore.exp.in:
- loader/DocumentWriter.cpp:
(WebCore::DocumentWriter::begin):
- page/Frame.cpp:
(WebCore::Frame::create):
(WebCore::Frame::setView):
(WebCore::Frame::setDocument):
(WebCore::Frame::rangeForPoint):
(WebCore::Frame::createView):
- page/Frame.h:
- xml/XSLTProcessor.cpp:
(WebCore::XSLTProcessor::createDocumentFromSource):
Source/WebKit/mac:
- WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::transitionToCommittedForNewPage):
- WebView/WebFrame.mm:
(+[WebFrame _createFrameWithPage:frameName:frameView:ownerElement:]):
(+[WebFrame _createSubframeWithOwnerElement:frameName:frameView:]):
- WebView/WebFrameInternal.h:
Source/WebKit2:
- WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::createSubframe):
- 11:28 AM Ruby edited by
- (diff)
- 11:23 AM Ruby edited by
- (diff)
- 11:22 AM Ruby created by
- 11:20 AM WikiStart edited by
- (diff)
- 10:56 AM Changeset in webkit [177449] by
-
- 2 edits in trunk/Source/WebCore
Test fix after r177444.
Unreviewed.
- accessibility/AccessibilitySlider.cpp:
(WebCore::AccessibilitySliderThumb::elementRect):
- 10:26 AM Changeset in webkit [177448] by
-
- 6 edits in trunk/Source
[Win] Correct DebugSuffix builds under MSBuild
https://bugs.webkit.org/show_bug.cgi?id=139733
<rdar://problem/19276880>
Reviewed by Simon Fraser.
- JavaScriptCore.vcxproj/JavaScriptCore.proj: Make sure to use the
'_debug' suffix when building the DebugSuffix target.
../WebKit:
- WebKit.vcxproj/WebKit.proj: Make sure to use the '_debug' suffix
when building the DebugSuffix target.
../WTF:
- WTF.vcxproj/WTF.proj: Make sure to use the '_debug' suffix
when building the DebugSuffix target.
- 10:12 AM Changeset in webkit [177447] by
-
- 3 edits in trunk/Source/WebKit2
iOS build fix
- UIProcess/ios/PageClientImplIOS.h:
- UIProcess/ios/PageClientImplIOS.mm:
(WebKit::PageClientImpl::PageClient::setTextIndicatorAnimationProgress):
- 9:46 AM Changeset in webkit [177446] by
-
- 2 edits in trunk/Source/WebKit
[Win] Link errors.
https://bugs.webkit.org/show_bug.cgi?id=139729
Patch by peavo@outlook.com <peavo@outlook.com> on 2014-12-17
Reviewed by Anders Carlsson.
The list of exported symbols needs to be updated.
- WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
- 9:02 AM Changeset in webkit [177445] by
-
- 2 edits in trunk/Source/WTF
Make Ref::copyRef const and ref-qualified
https://bugs.webkit.org/show_bug.cgi?id=139730
Reviewed by Andreas Kling.
- wtf/Ref.h:
- 8:33 AM Changeset in webkit [177444] by
-
- 3 edits in trunk/Source/WebCore
Addressing more post-review comments in r177035
- accessibility/AccessibilitySlider.cpp:
(WebCore::AccessibilitySliderThumb::elementRect):
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::setupDateTimeChooserParameters):
- 4:03 AM Changeset in webkit [177443] by
-
- 2 edits in trunk/Tools
[GTK] Simplify timeout handling in TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded
https://bugs.webkit.org/show_bug.cgi?id=139725
Reviewed by Martin Robinson.
The timeout is already in milliseconds, so we don't need to do any conversion.
- WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
(WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
- 3:44 AM Changeset in webkit [177442] by
-
- 4 edits in trunk/Source/WebCore
[TexMap] Sprinkle range-based for-loops where still possible
https://bugs.webkit.org/show_bug.cgi?id=138752
Reviewed by Chris Dumez.
Apply range-based for-loops where possible in the TextureMapper,
TextureMapperGL and TextureMapperTiledBackingStore classes.
Also prettify the loop in SharedGLData destructor and return
nullptr instead of explicitly constructing the empty PassRefPtr
object in TextureMapperTiledBackingStore::texture().
- platform/graphics/texmap/TextureMapper.cpp:
(WebCore::BitmapTexturePool::acquireTexture):
- platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore::TextureMapperGLData::SharedGLData::~SharedGLData):
(WebCore::TextureMapperGLData::~TextureMapperGLData):
- platform/graphics/texmap/TextureMapperTiledBackingStore.cpp:
(WebCore::TextureMapperTiledBackingStore::paintToTextureMapper):
(WebCore::TextureMapperTiledBackingStore::drawBorder):
(WebCore::TextureMapperTiledBackingStore::drawRepaintCounter):
(WebCore::TextureMapperTiledBackingStore::createOrDestroyTilesIfNeeded):
(WebCore::TextureMapperTiledBackingStore::updateContents):
(WebCore::TextureMapperTiledBackingStore::texture):
- 2:14 AM Changeset in webkit [177441] by
-
- 2 edits in trunk/Source/WebCore
The SVGDocument of an SVGImage should not perform any additional actions when the SVGImage is being destroyed
https://bugs.webkit.org/show_bug.cgi?id=139644
Reviewed by Antti Koivisto.
When an SVGImage is destroyed, having its SVGDocument perform style recalc and dispatching events is not only
useless but can also cause problems, such as re-entrancy in StyleResolver::loadPendingResources.
No new tests required, existing tests cover this change.
- dom/Document.cpp:
(WebCore::Document::Document):
- dom/Document.h:
(WebCore::Document::isBeingDestroyed):
(WebCore::Document::setIsBeingDestroyed):
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::closeURL):
- svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::~SVGImage):
- 1:51 AM Changeset in webkit [177440] by
-
- 3 edits in trunk/Source/WebKit2
Unreviewed. Fix GTK+ build after r177427.
- UIProcess/API/gtk/PageClientImpl.cpp:
(WebKit::PageClientImpl::setTextIndicatorAnimationProgress):
- UIProcess/API/gtk/PageClientImpl.h:
- 12:45 AM Changeset in webkit [177439] by
-
- 2 edits in trunk/Tools
[EFL]Fix build warning in MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=139723
Patch by Hunseop Jeong <Hunseop Jeong> on 2014-12-17
Reviewed by Darin Adler.
The warning is caused by the compiler wanting the first argument to be a
string literal, not a dynamically created string.
- MiniBrowser/efl/main.c:
(quit):
- 12:28 AM Changeset in webkit [177438] by
-
- 3 edits in branches/safari-600.1.4.13-branch/Source/WebKit2
Merged r176996. rdar://problem/19214044
- 12:27 AM Changeset in webkit [177437] by
-
- 3 edits in branches/safari-600.1.4.13-branch/Source/WebKit2
Merged r176133. rdar://problem/19214044
- 12:03 AM Changeset in webkit [177436] by
-
- 4 edits in trunk/Source/WebCore
Drop useless 'clipToContents' argument for windowClipRect()
https://bugs.webkit.org/show_bug.cgi?id=139722
Reviewed by Darin Adler.
Drop useless 'clipToContents' argument for windowClipRect(). This
argument is never used.
No new tests, no behavior change.
- page/FrameView.cpp:
(WebCore::FrameView::windowClipRect):
- page/FrameView.h:
- platform/ScrollView.h:
Dec 16, 2014:
- 9:20 PM Changeset in webkit [177435] by
-
- 3 edits2 adds in trunk
text node should not be created, On setting document.title to the empty string.
https://bugs.webkit.org/show_bug.cgi?id=139121
Patch by Shivakumar JM <shiva.jm@samsung.com> on 2014-12-16
Reviewed by Darin Adler.
Source/WebCore:
Do not create text node, On setting document.title to the empty string as in spec.
I have confirmed this matches the behavior of Firefox and Chrome.
Test: fast/dom/Document/document-set-title-no-child.html
- html/HTMLTitleElement.cpp:
(WebCore::HTMLTitleElement::setText):
LayoutTests:
- fast/dom/Document/document-set-title-no-child-expected.txt: Added.
- fast/dom/Document/document-set-title-no-child.html: Added.
- 8:02 PM Changeset in webkit [177434] by
-
- 3 edits1 add in trunk/Tools
TestWebKitAPI should use a static lib to support both Mac and iOS cleanly
https://bugs.webkit.org/show_bug.cgi?id=139718
Reviewed by Mark Rowe.
Change TestWebKitAPI to be more like DumpRenderTree by moving all the source
files into a static lib which the command line utility can link link against.
This will allow us to create a TestWebKitAPI.app that can run on iOS.
- TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
- TestWebKitAPI/Configurations/TestWebKitAPILibrary.xcconfig: Added.
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- 7:56 PM Changeset in webkit [177433] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: REGRESSION: Dragging undocked web inspector causes mouse to change from pointer to i-bar cursor over window title
https://bugs.webkit.org/show_bug.cgi?id=139720
Patch by Matt Baker <Matt Baker> on 2014-12-16
Reviewed by Timothy Hatcher.
- UserInterface/Base/Main.js:
Prevent default handling of the mouse event when clicking in the titlebar area. WebCore won't continue handling the event,
but docking buttons/context menu still function.
- 7:55 PM Changeset in webkit [177432] by
-
- 3 edits in trunk/Source/WebKit2
Unreviewed, EFL build fix since r177427.
- UIProcess/CoordinatedGraphics/WebView.cpp:
(WebKit::WebView::setTextIndicatorAnimationProgress): Added.
- UIProcess/CoordinatedGraphics/WebView.h:
- 7:31 PM Changeset in webkit [177431] by
-
- 2 edits in trunk/Websites/perf.webkit.org
Unreviewed. Adding the forgotten svnprop.
- tools/pull-svn.py: Added property svn:executable.
- 7:29 PM Changeset in webkit [177430] by
-
- 7 edits7 copies674 moves1384 adds518 deletes in trunk/LayoutTests
[iOS] Update expected results for LayoutTests/fast
- TestExpectations: Added entries fast/parser/document-write-fighting-eof.html and fast/parser/document-write-partial-entity-before-load.html
and removed these entries from the GTK, Mac, and Windows-specific TestExpectation files. These tests are known to fail in debug builds on
all ports. See http://webkit.org/b/110546 for more details.
- platform/gtk/TestExpectations:
- platform/ios-simulator-wk2/TestExpectations:
- platform/ios-simulator/TestExpectations:
[...]
- platform/mac/TestExpectations:
- platform/win/TestExpectations:
- 7:25 PM Changeset in webkit [177429] by
-
- 22 edits in trunk/Source
Move WebCore/platform/graphics/surfaces to std::unique_ptr
https://bugs.webkit.org/show_bug.cgi?id=139641
Reviewed by Andreas Kling.
Source/WebCore:
Replace OwnPtr|PassOwnPtr with std::make_unique<>|std::unique_ptr<>.
- platform/graphics/GLContext.cpp:
(WebCore::GLContext::sharingContext):
(WebCore::GLContext::createContextForWindow):
(WebCore::GLContext::createOffscreenContext):
- platform/graphics/GLContext.h:
- platform/graphics/GraphicsContext3DPrivate.cpp:
(WebCore::GraphicsContext3DPrivate::paintToTextureMapper):
- platform/graphics/GraphicsContext3DPrivate.h:
- platform/graphics/egl/GLContextEGL.cpp:
(WebCore::GLContextEGL::createWindowContext):
(WebCore::GLContextEGL::createPbufferContext):
(WebCore::GLContextEGL::createPixmapContext):
(WebCore::GLContextEGL::createContext):
- platform/graphics/egl/GLContextEGL.h:
- platform/graphics/glx/GLContextGLX.cpp:
(WebCore::GLContextGLX::createWindowContext):
(WebCore::GLContextGLX::createPbufferContext):
(WebCore::GLContextGLX::createPixmapContext):
(WebCore::GLContextGLX::createContext):
- platform/graphics/glx/GLContextGLX.h:
- platform/graphics/surfaces/GLTransportSurface.cpp:
(WebCore::GLTransportSurface::createTransportSurface):
(WebCore::GLTransportSurfaceClient::createTransportSurfaceClient):
- platform/graphics/surfaces/GLTransportSurface.h:
- platform/graphics/surfaces/GraphicsSurface.h:
- platform/graphics/surfaces/GraphicsSurfaceToken.h:
- platform/graphics/surfaces/efl/GraphicsSurfaceCommon.cpp:
- platform/graphics/surfaces/egl/EGLSurface.cpp:
(WebCore::EGLTransportSurface::createTransportSurface):
(WebCore::EGLTransportSurface::createTransportSurfaceClient):
(WebCore::EGLTransportSurface::EGLTransportSurface):
- platform/graphics/surfaces/egl/EGLSurface.h:
- platform/graphics/surfaces/egl/EGLXSurface.cpp:
(WebCore::EGLXTransportSurfaceClient::EGLXTransportSurfaceClient):
- platform/graphics/surfaces/egl/EGLXSurface.h:
- platform/graphics/surfaces/glx/GLXSurface.cpp:
(WebCore::GLXTransportSurface::GLXTransportSurface):
(WebCore::GLXOffScreenSurface::initialize):
- platform/graphics/surfaces/glx/GLXSurface.h:
Source/WebKit2:
- WebProcess/WebPage/gtk/LayerTreeHostGtk.h:
- 7:05 PM Changeset in webkit [177428] by
-
- 3 edits30 adds in trunk/LayoutTests
[iOS] Update expected results for LayoutTests/http
- platform/ios-simulator-wk2/TestExpectations:
- platform/ios-simulator/TestExpectations:
- platform/ios-simulator/http/tests/loading/simple-subframe-expected.txt: Added.
- platform/ios-simulator/http/tests/local/file-url-sent-as-referer-expected.txt: Added.
- platform/ios-simulator/http/tests/misc/acid2-expected.txt: Added.
- platform/ios-simulator/http/tests/misc/acid2-pixel-expected.txt: Added.
- platform/ios-simulator/http/tests/misc/error404-expected.txt: Added.
- platform/ios-simulator/http/tests/misc/favicon-as-image-expected.txt: Added.
- platform/ios-simulator/http/tests/misc/frame-access-during-load-expected.txt: Added.
- platform/ios-simulator/http/tests/misc/generated-content-inside-table-expected.txt: Added.
- platform/ios-simulator/http/tests/misc/iframe404-expected.txt: Added.
- platform/ios-simulator/http/tests/misc/location-replace-crossdomain-expected.txt: Added.
- platform/ios-simulator/http/tests/misc/object-embedding-svg-delayed-size-negotiation-2-expected.txt: Added.
- platform/ios-simulator/http/tests/misc/slow-loading-image-in-pattern-expected.txt: Added.
- platform/ios-simulator/http/tests/misc/slow-loading-mask-expected.txt: Added.
- platform/ios-simulator/http/tests/multipart/invalid-image-data-expected.txt: Added.
- platform/ios-simulator/http/tests/multipart/invalid-image-data-standalone-expected.txt: Added.
- platform/ios-simulator/http/tests/navigation/error404-basic-expected.txt: Added.
- platform/ios-simulator/http/tests/navigation/error404-goback-expected.txt: Added.
- platform/ios-simulator/http/tests/navigation/error404-subframeload-expected.txt: Added.
- platform/ios-simulator/http/tests/navigation/javascriptlink-frames-expected.txt: Added.
- platform/ios-simulator/http/tests/navigation/postredirect-basic-expected.txt: Added.
- platform/ios-simulator/http/tests/navigation/postredirect-goback1-expected.txt: Added.
- platform/ios-simulator/http/tests/uri/css-href-expected.txt: Added.
- 7:02 PM Changeset in webkit [177427] by
-
- 27 edits in trunk/Source
Implement and adopt two new TextIndicator presentation animations
https://bugs.webkit.org/show_bug.cgi?id=139715
<rdar://problem/19237945>
Reviewed by Anders Carlsson.
- WebCore.exp.in:
Adjust one symbol and export another.
- page/TextIndicator.cpp:
(WebCore::TextIndicator::createWithSelectionInFrame):
Take a blue-highlight snapshot if we're doing a crossfade without a bounce.
- page/TextIndicator.h:
(WebCore::TextIndicator::presentationTransition):
Add FadeIn and Crossfade transition types.
- page/mac/TextIndicatorWindow.h:
- page/mac/TextIndicatorWindow.mm:
(-[WebTextIndicatorView initWithFrame:textIndicator:margin:]):
(createBounceAnimation):
(createContentCrossfadeAnimation):
(createShadowFadeAnimation):
(createFadeInAnimation):
(-[WebTextIndicatorView _textIndicatorWantsBounce]):
(-[WebTextIndicatorView _textIndicatorWantsContentCrossfade]):
(-[WebTextIndicatorView _textIndicatorWantsFadeIn]):
Factor out the animation construction.
(-[WebTextIndicatorView _animationDuration]):
Factor out the duration computation.
(-[WebTextIndicatorView present]):
(-[WebTextIndicatorView setAnimationProgress:]):
Implement FadeIn and Crossfade transitions.
They can be driven externally and then continue from where they
left off when the progress reaches 100%.
FadeIn changes the opacity of the whole bubble, Crossfade
crossfades the content (from blue to yellow).
(WebCore::TextIndicatorWindow::TextIndicatorWindow):
(WebCore::TextIndicatorWindow::~TextIndicatorWindow):
Don't immediately destroy the window if it is crossfades or fades in.
Fade it out, instead.
(WebCore::TextIndicatorWindow::setAnimationProgress):
Drive the paused animation manually. If progress hits 100%,
start running it automatically from where it last left off.
(WebCore::TextIndicatorWindow::setTextIndicator):
(WebCore::TextIndicatorWindow::startFadeOut):
(-[WebTextIndicatorView presentWithCompletionHandler:]): Deleted.
(WebCore::TextIndicatorWindow::startFadeOutTimerFired): Deleted.
Remove the completion block from -present.
- platform/spi/mac/NSImmediateActionGestureRecognizerSPI.h:
Add some SPI.
- WebView/WebActionMenuController.mm:
(-[WebActionMenuController _showTextIndicator]):
- WebView/WebHTMLView.mm:
(-[WebHTMLView quickLookWithEvent:]):
Remove the completionHandler from text indicator presentation.
- WebView/WebImmediateActionController.mm:
(-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
(-[WebImmediateActionController immediateActionRecognizerDidUpdateAnimation:]):
(-[WebImmediateActionController immediateActionRecognizerDidCancelAnimation:]):
(-[WebImmediateActionController immediateActionRecognizerDidCompleteAnimation:]):
(-[WebImmediateActionController _menuItemForDataDetectedText]):
(-[WebImmediateActionController _animationControllerForText]):
(-[WebImmediateActionController _showTextIndicator]):
Forward immediate action gesture recognizer animation progress
to TextIndicator. Force us to keep the selection when immediate
action popovers steal first responder status from the WebView.
If the Lookup range is equal to the selection range, use a Crossfade
animation; otherwise, use a FadeIn animation.
- WebView/WebView.mm:
(-[WebView _setMaintainsInactiveSelection:]):
(-[WebView maintainsInactiveSelection]):
(-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
(-[WebView _setTextIndicator:fadeOut:]):
(-[WebView _clearTextIndicator]):
(-[WebView _setTextIndicatorAnimationProgress:]):
(-[WebView _showDictionaryLookupPopup:]):
(-[WebView _dictionaryLookupPopoverWillClose:]):
(-[WebView _setTextIndicator:fadeOut:animationCompletionHandler:]):
Remove the completionHandler from text indicator presentation.
Add a _setMaintainsInactiveSelection, which allows WebKit internals
to change the return value of -maintainsInactiveSelection, allowing
us to keep the selection alive when the WebView loses first responder status.
- WebView/WebViewData.h:
- WebView/WebViewInternal.h:
- UIProcess/API/mac/WKView.mm:
(-[WKView _setTextIndicator:fadeOut:]):
(-[WKView _setTextIndicatorAnimationProgress:]):
(-[WKView _setTextIndicator:fadeOut:animationCompletionHandler:]): Deleted.
- UIProcess/API/mac/WKViewInternal.h:
- UIProcess/PageClient.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::setTextIndicatorAnimationProgress):
(WebKit::WebPageProxy::performActionMenuHitTestAtLocation):
- UIProcess/WebPageProxy.h:
- UIProcess/mac/PageClientImpl.h:
- UIProcess/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::setTextIndicatorAnimationProgress):
(WebKit::PageClientImpl::didPerformDictionaryLookup):
Remove the completion handler block argument from TextIndicator
installation.
Plumb animation progress through PageClient to TextIndicatorWindow.
- UIProcess/mac/WKActionMenuController.mm:
(-[WKActionMenuController prepareForMenu:withEvent:]):
(-[WKActionMenuController _defaultMenuItemsForDataDetectedText]):
- UIProcess/mac/WKImmediateActionController.mm:
(-[WKImmediateActionController _clearImmediateActionState]):
(-[WKImmediateActionController immediateActionRecognizerWillPrepare:]):
(-[WKImmediateActionController immediateActionRecognizerDidUpdateAnimation:]):
(-[WKImmediateActionController immediateActionRecognizerDidCancelAnimation:]):
(-[WKImmediateActionController immediateActionRecognizerDidCompleteAnimation:]):
(-[WKImmediateActionController _menuItemForDataDetectedText]):
(-[WKImmediateActionController _animationControllerForText]):
Forward immediate action gesture recognizer animation progress
to TextIndicator. Force us to keep the selection when immediate
action popovers steal first responder status from the WebView.
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in:
- WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::textIndicatorTransitionForActionMenu):
(WebKit::WebPage::performActionMenuHitTestAtLocation):
Factor out the presentation animation decision code.
For immediate actions, of the Lookup range is equal to the
selection range, use a Crossfade animation; otherwise, use a FadeIn
animation.
Push whether the actionMenuHitTest is for an immediate action
or a menu to the Web process, to make the presentation animation
decision code live entirely in the Web process.
Avoid extracting encoded image data if we know we're doing
an immediate action and will never need it.
- 6:55 PM Changeset in webkit [177426] by
-
- 21 edits in trunk/Source/WebKit2
Fix lambda and std::function formatting
https://bugs.webkit.org/show_bug.cgi?id=139719
Reviewed by Sam Weinig.
- DatabaseProcess/DatabaseProcess.cpp:
(WebKit::DatabaseProcess::getOrigins):
(WebKit::DatabaseProcess::deleteEntriesForOrigin):
(WebKit::DatabaseProcess::deleteEntriesModifiedBetweenDates):
(WebKit::DatabaseProcess::deleteAllEntries):
- DatabaseProcess/DatabaseProcess.h:
- DatabaseProcess/IndexedDB/UniqueIDBDatabase.cpp:
(WebKit::UniqueIDBDatabase::deleteDatabase):
(WebKit::UniqueIDBDatabase::getOrEstablishIDBDatabaseMetadata):
(WebKit::UniqueIDBDatabase::openTransaction):
(WebKit::UniqueIDBDatabase::beginTransaction):
(WebKit::UniqueIDBDatabase::commitTransaction):
(WebKit::UniqueIDBDatabase::resetTransaction):
(WebKit::UniqueIDBDatabase::rollbackTransaction):
(WebKit::UniqueIDBDatabase::postTransactionOperation):
(WebKit::UniqueIDBDatabase::changeDatabaseVersion):
(WebKit::UniqueIDBDatabase::createObjectStore):
(WebKit::UniqueIDBDatabase::deleteObjectStore):
(WebKit::UniqueIDBDatabase::clearObjectStore):
(WebKit::UniqueIDBDatabase::createIndex):
(WebKit::UniqueIDBDatabase::deleteIndex):
(WebKit::UniqueIDBDatabase::putRecord):
(WebKit::UniqueIDBDatabase::getRecord):
(WebKit::UniqueIDBDatabase::openCursor):
(WebKit::UniqueIDBDatabase::cursorAdvance):
(WebKit::UniqueIDBDatabase::cursorIterate):
(WebKit::UniqueIDBDatabase::count):
(WebKit::UniqueIDBDatabase::deleteRange):
- DatabaseProcess/IndexedDB/UniqueIDBDatabase.h:
- NetworkProcess/cache/NetworkCacheStorageCocoa.mm:
(WebKit::NetworkCacheStorage::store):
- Shared/AsyncTask.h:
(WebKit::AsyncTask::AsyncTask):
- Shared/ChildProcess.cpp:
(WebKit::didCloseOnConnectionWorkQueue):
- Shared/WebContextMenuItemData.cpp:
(WebKit::WebContextMenuItemData::WebContextMenuItemData):
- Shared/WebContextMenuItemData.h:
(WebKit::WebContextMenuItemData::selectionHandler):
- Shared/mac/SecItemShim.cpp:
(WebKit::responseMap):
- UIProcess/Plugins/PluginProcessManager.cpp:
(WebKit::PluginProcessManager::PluginProcessManager):
- UIProcess/WebContext.cpp:
(WebKit::WebContext::WebContext):
(WebKit::m_processSuppressionDisabledForPageCounter):
- UIProcess/WebOriginDataManagerProxy.cpp:
(WebKit::CallbackSynchronizer::create):
(WebKit::CallbackSynchronizer::CallbackSynchronizer):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
- UIProcess/mac/WebContextMenuProxyMac.mm:
(-[WKSelectionHandlerWrapper initWithSelectionHandler:]):
(WebKit::nsMenuItemVector):
- WebProcess/Databases/IndexedDB/WebIDBServerConnection.cpp:
(WebKit::WebIDBServerConnection::deleteDatabase):
(WebKit::WebIDBServerConnection::getOrEstablishIDBDatabaseMetadata):
(WebKit::WebIDBServerConnection::openTransaction):
(WebKit::WebIDBServerConnection::beginTransaction):
(WebKit::WebIDBServerConnection::commitTransaction):
(WebKit::WebIDBServerConnection::resetTransaction):
(WebKit::WebIDBServerConnection::rollbackTransaction):
(WebKit::WebIDBServerConnection::setIndexKeys):
(WebKit::WebIDBServerConnection::createObjectStore):
(WebKit::WebIDBServerConnection::createIndex):
(WebKit::WebIDBServerConnection::deleteIndex):
(WebKit::WebIDBServerConnection::get):
(WebKit::WebIDBServerConnection::put):
(WebKit::WebIDBServerConnection::count):
(WebKit::WebIDBServerConnection::deleteRange):
(WebKit::WebIDBServerConnection::clearObjectStore):
(WebKit::WebIDBServerConnection::deleteObjectStore):
(WebKit::WebIDBServerConnection::changeDatabaseVersion):
(WebKit::WebIDBServerConnection::openCursor):
(WebKit::WebIDBServerConnection::cursorAdvance):
(WebKit::WebIDBServerConnection::cursorIterate):
- WebProcess/Databases/IndexedDB/WebIDBServerConnection.h:
- WebProcess/OriginData/WebOriginDataManagerSupplement.h:
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::getOrigins):
(WebKit::WebProcess::deleteEntriesForOrigin):
(WebKit::WebProcess::deleteEntriesModifiedBetweenDates):
(WebKit::WebProcess::deleteAllEntries):
- WebProcess/WebProcess.h:
- 6:50 PM Changeset in webkit [177425] by
-
- 7 edits in trunk/Source/WebKit2
Get rid of a couple of binds in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=139717
Reviewed by Sam Weinig.
- DatabaseProcess/DatabaseProcess.cpp:
(WebKit::DatabaseProcess::postDatabaseTask):
- DatabaseProcess/IndexedDB/UniqueIDBDatabase.cpp:
(WebKit::UniqueIDBDatabase::didShutdownBackingStore):
(WebKit::UniqueIDBDatabase::postMainThreadTask):
(WebKit::UniqueIDBDatabase::performNextMainThreadTask):
(WebKit::UniqueIDBDatabase::postDatabaseTask):
(WebKit::UniqueIDBDatabase::performNextMainThreadTaskWithoutAdoptRef): Deleted.
- DatabaseProcess/IndexedDB/UniqueIDBDatabase.h:
- Platform/IPC/mac/ConnectionMac.mm:
(IPC::Connection::initializeDeadNameSource):
- UIProcess/Launcher/ProcessLauncher.cpp:
(WebKit::processLauncherWorkQueue):
(WebKit::ProcessLauncher::ProcessLauncher):
- WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::unprotectPluginFromDestruction):
(WebKit::derefPluginView): Deleted.
- 6:29 PM Changeset in webkit [177424] by
-
- 2 edits2 adds in trunk/Websites/perf.webkit.org
Split InteractiveChartComponent and CommitsViewerComponent into separate files
https://bugs.webkit.org/show_bug.cgi?id=139716
Rubber-stamped by Benjamin Poulain.
Refactored InteractiveChartComponent and CommitsViewerComponent out of app.js into commits-viewer.js
and interactive-chart.js respectively since app.js has gotten really large.
- public/v2/app.js:
- public/v2/commits-viewer.js: Added.
- public/v2/interactive-chart.js: Added.
- 6:11 PM Changeset in webkit [177423] by
-
- 13 edits in trunk/Source/WebCore
Move WebCore/platform/image-decoders to std::unique_ptr<>
https://bugs.webkit.org/show_bug.cgi?id=139668
Reviewed by Andreas Kling.
As a step to use std::unique_ptr<>, this patch replaces OwnPtr|PassOwnPtr with
std::unique_ptr<> | std::make_unique<>.
- platform/image-decoders/bmp/BMPImageDecoder.cpp:
(WebCore::BMPImageDecoder::setFailed):
(WebCore::BMPImageDecoder::decode):
(WebCore::BMPImageDecoder::decodeHelper):
- platform/image-decoders/bmp/BMPImageDecoder.h:
- platform/image-decoders/gif/GIFImageDecoder.cpp:
(WebCore::GIFImageDecoder::setFailed):
(WebCore::GIFImageDecoder::gifComplete):
(WebCore::GIFImageDecoder::decode):
- platform/image-decoders/gif/GIFImageDecoder.h:
- platform/image-decoders/gif/GIFImageReader.cpp:
(GIFFrameContext::decode):
(GIFImageReader::addFrameIfNecessary):
- platform/image-decoders/gif/GIFImageReader.h:
- platform/image-decoders/ico/ICOImageDecoder.cpp:
(WebCore::ICOImageDecoder::decode):
(WebCore::ICOImageDecoder::decodeAtIndex):
- platform/image-decoders/ico/ICOImageDecoder.h:
- platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
(WebCore::JPEGImageDecoder::setFailed):
(WebCore::JPEGImageDecoder::decode):
- platform/image-decoders/jpeg/JPEGImageDecoder.h:
- platform/image-decoders/png/PNGImageDecoder.cpp:
(WebCore::PNGImageDecoder::setFailed):
(WebCore::PNGImageDecoder::decode):
- platform/image-decoders/png/PNGImageDecoder.h:
- 5:48 PM Changeset in webkit [177422] by
-
- 28 edits in trunk/Source
Use Ref for SecurityOrigin.
<https://webkit.org/b/139710>
Reviewed by Anders Carlsson.
Source/WebCore:
Make SecurityOrigin::create*() return Ref<SecurityOrigin>.
- html/HTMLAnchorElement.cpp:
(WebCore::HTMLAnchorElement::origin):
- loader/DocumentLoadTiming.cpp:
(WebCore::DocumentLoadTiming::addRedirect):
- loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::willSendRequest):
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::commitProvisionalLoad):
- loader/PingLoader.cpp:
(WebCore::PingLoader::sendPing):
- loader/appcache/ApplicationCacheHost.cpp:
(WebCore::ApplicationCacheHost::isApplicationCacheBlockedForRequest):
- loader/appcache/ApplicationCacheStorage.cpp:
(WebCore::ApplicationCacheStorage::getOriginsWithCache):
- page/ContentSecurityPolicy.cpp:
(WebCore::stripURLForUseInReport):
- page/DOMWindow.cpp:
(WebCore::DOMWindow::crossDomainAccessErrorMessage):
- page/SecurityOrigin.cpp:
(WebCore::getCachedOrigin):
(WebCore::SecurityOrigin::create):
(WebCore::SecurityOrigin::createUnique):
(WebCore::SecurityOrigin::isolatedCopy):
(WebCore::SecurityOrigin::canRequest):
(WebCore::SecurityOrigin::createFromString):
(WebCore::SecurityOrigin::maybeCreateFromDatabaseIdentifier):
(WebCore::SecurityOrigin::createFromDatabaseIdentifier):
- page/SecurityOrigin.h:
- page/SecurityPolicy.cpp:
(WebCore::SecurityPolicy::isAccessToURLWhiteListed):
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::hasSingleSecurityOrigin):
- storage/StorageTracker.cpp:
(WebCore::StorageTracker::deleteOriginWithIdentifier):
- workers/DefaultSharedWorkerRepository.cpp:
(WebCore::DefaultSharedWorkerRepository::connectToWorker):
- workers/WorkerThread.cpp:
(WebCore::WorkerThreadStartupData::WorkerThreadStartupData):
Source/WebKit/mac:
- Storage/WebStorageTrackerClient.mm:
(WebStorageTrackerClient::dispatchDidModifyOrigin):
- WebView/WebView.mm:
(+[WebView _addOriginAccessWhitelistEntryWithSourceOrigin:destinationProtocol:destinationHost:allowDestinationSubdomains:]):
(+[WebView _removeOriginAccessWhitelistEntryWithSourceOrigin:destinationProtocol:destinationHost:allowDestinationSubdomains:]):
Source/WebKit/win:
- WebDatabaseManager.cpp:
(WebDatabaseManager::setQuota):
- WebView.cpp:
(WebView::addOriginAccessWhitelistEntry):
(WebView::removeOriginAccessWhitelistEntry):
Source/WebKit2:
- DatabaseProcess/IndexedDB/UniqueIDBDatabase.cpp:
(WebKit::UniqueIDBDatabase::databaseFilenameIdentifier):
- WebProcess/ApplicationCache/WebApplicationCacheManager.cpp:
(WebKit::WebApplicationCacheManager::deleteEntriesForOrigin):
- WebProcess/Databases/IndexedDB/WebIDBServerConnection.cpp:
(WebKit::WebIDBServerConnection::WebIDBServerConnection):
- WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::addOriginAccessWhitelistEntry):
(WebKit::InjectedBundle::removeOriginAccessWhitelistEntry):
- 5:39 PM Changeset in webkit [177421] by
-
- 3 edits in trunk/Source/JavaScriptCore
Fix iOS builders for 8.0
https://bugs.webkit.org/show_bug.cgi?id=139495
Reviewed by Michael Saboff.
- Configurations/LLVMForJSC.xcconfig:
- llvm/library/LLVMExports.cpp:
(initializeAndGetJSCLLVMAPI):
- 5:39 PM Changeset in webkit [177420] by
-
- 3 edits in trunk/Source/WebKit2
Remove deprecated StorageNamespaceImpl overloads
https://bugs.webkit.org/show_bug.cgi?id=139713
Reviewed by Andreas Kling.
- WebProcess/Storage/StorageNamespaceImpl.cpp:
(WebKit::StorageNamespaceImpl::storageArea):
(WebKit::StorageNamespaceImpl::copy):
(WebKit::StorageNamespaceImpl::createSessionStorageNamespace): Deleted.
(WebKit::StorageNamespaceImpl::createLocalStorageNamespace): Deleted.
- WebProcess/Storage/StorageNamespaceImpl.h:
- 5:38 PM Changeset in webkit [177419] by
-
- 5 edits in branches/safari-600.1.17-branch/Source
Versioning.
- 5:33 PM Changeset in webkit [177418] by
-
- 5 edits in branches/safari-600.3-branch/Source
Versioning.
- 5:30 PM Changeset in webkit [177417] by
-
- 1 copy in tags/Safari-600.1.17.4
New tag.
- 5:29 PM Changeset in webkit [177416] by
-
- 1 copy in tags/Safari-600.3.13
New Tag.
- 5:25 PM Changeset in webkit [177415] by
-
- 8 edits in branches/safari-600.1.17-branch/Source
Merged r176896. <rdar://problem/19148278>
- 5:18 PM Changeset in webkit [177414] by
-
- 4 edits in trunk/Source/WebCore
Move 'cursor' CSS property to the new StyleBuilder
https://bugs.webkit.org/show_bug.cgi?id=139660
Reviewed by Benjamin Poulain.
Move 'cursor' CSS property to the new StyleBuilder by using
custom code.
No new tests, no behavior change.
- css/CSSPropertyNames.in:
- css/DeprecatedStyleBuilder.cpp:
(WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder):
(WebCore::ApplyPropertyCursor::applyInheritValue): Deleted.
(WebCore::ApplyPropertyCursor::applyInitialValue): Deleted.
(WebCore::ApplyPropertyCursor::applyValue): Deleted.
(WebCore::ApplyPropertyCursor::createHandler): Deleted.
- css/StyleBuilderCustom.h:
(WebCore::StyleBuilderCustom::applyInitialCursor):
(WebCore::StyleBuilderCustom::applyInheritCursor):
(WebCore::StyleBuilderCustom::applyValueCursor):
- 4:54 PM Changeset in webkit [177413] by
-
- 2 edits in branches/safari-600.3-branch/Source/WebKit/mac
Merged r177410. rdar://problems/19271707
- 4:50 PM Changeset in webkit [177412] by
-
- 5 edits2 adds in trunk
Subpixel rendering: Animating HTML elements leaves trails when embedded to a subpxiel positioned iframe.
https://bugs.webkit.org/show_bug.cgi?id=139691
rdar://problem/19078958
Reviewed by Simon Fraser.
This patch ensures that repaint rect and actual paint coordinate calculations are in sync.
Source/WebCore:
RenderWidget painting still snaps final coordinates to integral positions. We need to
mimic the same snapping behaviour when the repaint rects are being calculated so that
they are in sync with the final repaint rects. This is a workaround until after
widgets get pushed to device pixel positions.
Test: fast/repaint/hidpi-content-inside-iframe-leaves-trails.html
- rendering/RenderBox.cpp:
(WebCore::RenderBox::computeRectForRepaint):
- rendering/RenderView.cpp:
(WebCore::RenderView::repaintViewRectangle):
- rendering/RenderWidget.cpp:
(WebCore::RenderWidget::paintContents):
LayoutTests:
- fast/repaint/hidpi-content-inside-iframe-leaves-trails-expected.txt: Added.
- fast/repaint/hidpi-content-inside-iframe-leaves-trails.html: Added.
- 4:47 PM Changeset in webkit [177411] by
-
- 2 edits in trunk/Source/WebKit2
Speculative build fix.
- UIProcess/mac/WKImmediateActionController.mm:
(-[WKImmediateActionController _animationControllerForCustomPreview]):
- 4:41 PM Changeset in webkit [177410] by
-
- 2 edits in trunk/Source/WebKit/mac
Crash getting default animation controller for some text
https://bugs.webkit.org/show_bug.cgi?id=139712
-and corresponding-
rdar://problem/19271707
Reviewed by Tim Horton.
Must null-check the range.
- WebView/WebImmediateActionController.mm:
(-[WebImmediateActionController _animationControllerForText]):
- 4:33 PM Changeset in webkit [177409] by
-
- 4 edits1 add in trunk/Source
REGRESSION: Preview popovers obscure the link, look wrong
https://bugs.webkit.org/show_bug.cgi?id=139711
-and corresponding-
rdar://problem/19271854
Reviewed by Tim Horton.
Source/WebCore:
New SPI.
- WebCore.xcodeproj/project.pbxproj:
- platform/spi/mac/NSPopoverSPI.h: Added.
Source/WebKit2:
Switch to using NSPopoverAnimationController.
- UIProcess/mac/WKImmediateActionController.mm:
(-[WKImmediateActionController _defaultAnimationController]):
(-[WKImmediateActionController _animationControllerForCustomPreview]):
- 4:02 PM Changeset in webkit [177408] by
-
- 3 edits in trunk/LayoutTests
Rebaseline Mavericks test result after r177398
Unreviewed.
- platform/mac-mavericks/fast/writing-mode/Kusa-Makura-background-canvas-expected.png:
- platform/mac-mavericks/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt:
- 4:00 PM Changeset in webkit [177407] by
-
- 4 edits in branches/safari-600.3-branch/Source
Merged r177406. rdar://problems/19270279
- 3:34 PM Changeset in webkit [177406] by
-
- 4 edits in trunk/Source
Immediate action popovers can get stuck open
https://bugs.webkit.org/show_bug.cgi?id=139709
<rdar://problem/19270279>
Reviewed by Beth Dakin.
- UIProcess/mac/WKImmediateActionController.mm:
(-[WKImmediateActionController _clearImmediateActionState]):
Don't clear the animation controller; it breaks things and was unnecessary.
- WebView/WebImmediateActionController.mm:
(-[WebImmediateActionController _clearImmediateActionState]):
Don't clear the animation controller; it breaks things and was unnecessary.
- 3:30 PM Changeset in webkit [177405] by
-
- 5 edits in branches/safari-600.1.4.13-branch/Source
Versioning.
- 3:25 PM Changeset in webkit [177404] by
-
- 3 edits2 adds in trunk
[iOS] Cherokee language is drawn as boxes
https://bugs.webkit.org/show_bug.cgi?id=139706
Reviewed by Simon Fraser.
Source/WebCore:
Test: platform/ios-simulator/fast/text/cherokee.html
- platform/graphics/ios/FontCacheIOS.mm:
(WebCore::languageSpecificFallbackFont):
LayoutTests:
- platform/ios-simulator/fast/text/cherokee-expected.html: Added.
- platform/ios-simulator/fast/text/cherokee.html: Added.
- 3:24 PM Changeset in webkit [177403] by
-
- 2 edits in trunk/LayoutTests
https://bugs.webkit.org/show_bug.cgi?id=139708
http/tests/media/video-buffered-range-contains-currentTime.html frequently times out
- platform/mac/TestExpectations: Added an expectation.
- 3:14 PM Changeset in webkit [177402] by
-
- 7 edits in trunk/Source/WebKit2
Add a progress indicator to the preview popover
https://bugs.webkit.org/show_bug.cgi?id=139699
Reviewed by Tim Horton.
- UIProcess/API/Cocoa/WKViewPrivate.h:
- UIProcess/API/mac/WKView.mm:
(-[WKView _setPreviewLoading:]):
Wrap -[WKImmediateActionController setPreviewLoading:].
- UIProcess/mac/WKImmediateActionController.h:
- UIProcess/mac/WKImmediateActionController.mm:
(-[WKImmediateActionController _createPreviewPopoverIfNeededForURL:]):
Flag the preview view controller as loading before beginning the load.
(-[WKImmediateActionController setPreviewLoading:]):
Wrap -[WKPagePreviewViewController setLoading:].
- UIProcess/mac/WKPagePreviewViewController.h:
- UIProcess/mac/WKPagePreviewViewController.mm:
(-[WKPagePreviewViewController setLoading:]):
Toggle the progress indicator animation state.
(-[WKPagePreviewViewController isLoading]):
Accessor.
(-[WKPagePreviewViewController loadView]):
Create and center an indeterminate progress indicator that won't scale with the preview content.
- 3:08 PM Changeset in webkit [177401] by
-
- 4 edits1 delete in trunk/Source/JavaScriptCore
Unreviewed, rolling out r177380.
https://bugs.webkit.org/show_bug.cgi?id=139707
"Breaks js/regres/elidable-new-object-* tests" (Requested by
msaboff_ on #webkit).
Reverted changeset:
"Fixes operationPutByIdOptimizes such that they check that the
put didn't"
https://bugs.webkit.org/show_bug.cgi?id=139500
http://trac.webkit.org/changeset/177380
- 3:07 PM Changeset in webkit [177400] by
-
- 3 edits in trunk/LayoutTests
More test gardening.
Fix syntax of one entry, extend two flakiness entries to cover Yosemite, where
these tests recently failed.
- platform/mac-wk2/TestExpectations:
- platform/mac/TestExpectations:
- 3:03 PM Changeset in webkit [177399] by
-
- 8 edits in trunk/Source
Fix iOS builders for 8.0
https://bugs.webkit.org/show_bug.cgi?id=139495
Reviewed by Jer Noble
Source/WebCore:
- WebCore.exp.in:
- platform/ios/WebVideoFullscreenControllerAVKit.mm:
(-[WebVideoFullscreenController enterFullscreen:mode:]):
(-[WebVideoFullscreenController requestHideAndExitFullscreen]):
(-[WebVideoFullscreenController enterFullscreen:]): Deleted.
- platform/ios/WebVideoFullscreenInterfaceAVKit.mm:
Source/WebKit2:
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _mayAutomaticallyShowVideoOptimized]):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::reattachToWebProcess):
- UIProcess/ios/WebVideoFullscreenManagerProxy.mm:
- 2:53 PM Changeset in webkit [177398] by
-
- 38 edits in trunk
Ruby overhang uses ints instead of floats
https://bugs.webkit.org/show_bug.cgi?id=139624
Reviewed by Dave Hyatt.
Source/WebCore:
Simply change the type.
Updated existing tests.
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlockFlow::setMarginsForRubyRun):
- rendering/RenderRubyRun.cpp:
(WebCore::RenderRubyRun::getOverhang):
- rendering/RenderRubyRun.h:
- rendering/line/LineWidth.cpp:
(WebCore::LineWidth::applyOverhang):
LayoutTests:
Updating tests.
- fast/ruby/overhang-horizontal-expected.png:
- fast/ruby/overhang-horizontal-expected.txt:
- fast/ruby/overhang-vertical-expected.png:
- fast/ruby/overhang-vertical-expected.txt:
- platform/mac/fast/ruby/ruby-beforeafter-expected.png:
- platform/mac/fast/ruby/ruby-beforeafter-expected.txt:
- platform/mac/fast/ruby/ruby-length-expected.png:
- platform/mac/fast/ruby/ruby-length-expected.txt:
- platform/mac/fast/ruby/ruby-run-break-expected.png:
- platform/mac/fast/ruby/ruby-run-break-expected.txt:
- platform/mac/fast/ruby/ruby-runs-expected.png:
- platform/mac/fast/ruby/ruby-runs-expected.txt:
- platform/mac/fast/ruby/ruby-runs-spans-expected.png:
- platform/mac/fast/ruby/ruby-runs-spans-expected.txt:
- platform/mac/fast/ruby/ruby-trailing-expected.png:
- platform/mac/fast/ruby/ruby-trailing-expected.txt:
- platform/mac/fast/ruby/rubyDOM-insert-rt-expected.png:
- platform/mac/fast/ruby/rubyDOM-insert-rt-expected.txt:
- platform/mac/fast/ruby/rubyDOM-insert-text1-expected.png:
- platform/mac/fast/ruby/rubyDOM-insert-text1-expected.txt:
- platform/mac/fast/ruby/rubyDOM-insert-text2-expected.png:
- platform/mac/fast/ruby/rubyDOM-insert-text2-expected.txt:
- platform/mac/fast/ruby/rubyDOM-insert-text3-expected.png:
- platform/mac/fast/ruby/rubyDOM-insert-text3-expected.txt:
- platform/mac/fast/ruby/rubyDOM-remove-rt1-expected.png:
- platform/mac/fast/ruby/rubyDOM-remove-rt1-expected.txt:
- platform/mac/fast/ruby/rubyDOM-remove-rt2-expected.png:
- platform/mac/fast/ruby/rubyDOM-remove-rt2-expected.txt:
- platform/mac/fast/ruby/rubyDOM-remove-text1-expected.png:
- platform/mac/fast/ruby/rubyDOM-remove-text1-expected.txt:
- platform/mac/fast/writing-mode/Kusa-Makura-background-canvas-expected.png:
- platform/mac/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt:
- 2:43 PM Changeset in webkit [177397] by
-
- 3 edits1 add31 deletes in trunk/LayoutTests
[iOS] Update expected results for LayoutTest/{inspector-obsolete, inspector-protocol,
media, mhtml, perf, platform, plugins, scrollingcoordinator, userscripts, webarchive}
- platform/ios-simulator-wk2/TestExpectations:
- platform/ios-simulator/TestExpectations:
[...]
- 2:28 PM Changeset in webkit [177396] by
-
- 12 edits in trunk/Source
Move Mac process suppression from WebCore to WebKit2
https://bugs.webkit.org/show_bug.cgi?id=139705
Reviewed by Geoff Garen.
Currently PageThrottler constructs the PageActivityState, holds a copy of the ViewState,
and an optional UserActivity.
Instead, still construct the PageActivityState but just pass this out via the Page to WebPage.
Logic From PageThrottler::updateUserActivity merged into WebPage::updateUserActivity.
Source/WebCore:
- WebCore.exp.in:
- removed createUserActivity.
- page/ChromeClient.h:
(WebCore::ChromeClient::setPageActivityState):
- added to propagate PageActivityState to WebPage.
- page/Page.cpp:
(WebCore::Page::Page):
- PageThrottler constructor now takes a Page&.
(WebCore::Page::setViewState):
- no longer necessary to pass this to PageThrottler.
(WebCore::Page::setPageActivityState):
- added to propagate PageActivityState to WebPage.
(WebCore::Page::enablePageThrottler): Deleted.
- PageThrottler no longer has a UserActivity.
- page/Page.h:
(WebCore::Page::pageThrottler):
- added setPageActivityState, removed enablePageThrottler.
- page/PageThrottler.cpp:
(WebCore::PageThrottler::PageThrottler):
- removed m_viewState, added m_page.
(WebCore::PageThrottler::setActivityFlag):
- propagate PageActivityState via Page to WebPage.
(WebCore::PageThrottler::createUserActivity): Deleted.
(WebCore::PageThrottler::updateUserActivity): Deleted.
(WebCore::PageThrottler::setViewState): Deleted.
- removed; PageThrottler no longer has a PageThrottler or UserActivity.
- page/PageThrottler.h:
- removed createUserActivity, setViewState, m_viewState, m_activity; added m_page.
Source/WebKit2:
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::setPageActivityState):
- added to propagate PageActivityState to WebPage.
- WebProcess/WebCoreSupport/WebChromeClient.h:
- added setPageActivityState to propagate PageActivityState to WebPage.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
- calls to updateUserActivity.
(WebKit::WebPage::setPageActivityState):
- calls to updateUserActivity.
(WebKit::WebPage::updateUserActivity):
- incorporate logic from PageThrottler::updateUserActivity.
(WebKit::WebPage::setViewState):
- calls to updateUserActivity.
(WebKit::WebPage::updatePreferences):
- calls to updateUserActivity.
- WebProcess/WebPage/WebPage.h:
- added setPageActivityState, m_activityState.
- 2:07 PM Changeset in webkit [177395] by
-
- 2 edits in trunk/Source/WebKit2
More StorageManager modernization
https://bugs.webkit.org/show_bug.cgi?id=139704
Reviewed by Andreas Kling.
- UIProcess/Storage/StorageManager.cpp:
(WebKit::StorageManager::LocalStorageNamespace::getOrCreateStorageArea):
(WebKit::StorageManager::SessionStorageNamespace::getOrCreateStorageArea):
(WebKit::StorageManager::createSessionStorageMap):
(WebKit::StorageManager::destroyStorageMap):
(WebKit::StorageManager::findStorageArea):
(WebKit::StorageManager::getOrCreateLocalStorageNamespace):
- 1:47 PM Changeset in webkit [177394] by
-
- 3 edits in trunk/Source/WTF
[iOS] WTF fails to build with public SDK due to missing header CPAggregateDictionary.h
https://bugs.webkit.org/show_bug.cgi?id=139695
Reviewed by Chris Dumez.
Add USE(APPLE_INTERNAL_SDK)-guard around iOS-specific feature counter implementation
as we are only interested in counting features in builds of iOS WebKit that were built
with the Apple Internal SDK.
- wtf/FeatureCounter.cpp:
- wtf/ios/FeatureCounter.mm:
- 1:38 PM Changeset in webkit [177393] by
-
- 2 edits in trunk/Source/WebKit2
Use Ref in another StorageManager function
https://bugs.webkit.org/show_bug.cgi?id=139700
Reviewed by Andreas Kling.
- UIProcess/Storage/StorageManager.cpp:
(WebKit::StorageManager::LocalStorageNamespace::getOrCreateStorageArea):
- 1:26 PM Changeset in webkit [177392] by
-
- 3 edits in trunk/Source/WebKit2
Use Ref in StorageManager
https://bugs.webkit.org/show_bug.cgi?id=139698
Reviewed by Andreas Kling.
- UIProcess/Storage/StorageManager.cpp:
(WebKit::StorageManager::TransientLocalStorageNamespace::create):
(WebKit::StorageManager::TransientLocalStorageNamespace::getOrCreateStorageArea):
(WebKit::StorageManager::StorageArea::create):
(WebKit::StorageManager::StorageArea::clone):
(WebKit::StorageManager::LocalStorageNamespace::create):
(WebKit::StorageManager::SessionStorageNamespace::create):
(WebKit::StorageManager::create):
- UIProcess/Storage/StorageManager.h:
- 1:24 PM Changeset in webkit [177391] by
-
- 4 edits3 adds in branches/safari-600.3-branch
Merge r176399. rdar://problem/19267545
- 1:22 PM Changeset in webkit [177390] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed build fix after r177375; explicitly cast to NSUInteger.
- platform/ios/WebVideoFullscreenInterfaceAVKit.mm:
(WebVideoFullscreenInterfaceAVKit::setAudioMediaSelectionOptions):
(WebVideoFullscreenInterfaceAVKit::setLegibleMediaSelectionOptions):
- 1:14 PM Changeset in webkit [177389] by
-
- 5 edits in tags/Safari-601.1.12.1.1/Source
Versioning.
- 1:12 PM Changeset in webkit [177388] by
-
- 1 copy in tags/Safari-601.1.12.1.1
New tag.
- 1:08 PM Changeset in webkit [177387] by
-
- 2 edits in branches/safari-600.3-branch/Source/WebKit2
Build Fix.
Reviewed by Dana Burkart.
- UIProcess/mac/WKImmediateActionController.h:
Hide the method declaration for setPreviewTitle: into an WK_API_ENABLED ifdef
- 12:59 PM Changeset in webkit [177386] by
-
- 2 edits in trunk/Source/WebCore
[Win] Compiling WebCore fails because of invalid project file.
https://bugs.webkit.org/show_bug.cgi?id=139686
Patch by peavo@outlook.com <peavo@outlook.com> on 2014-12-16
Reviewed by Alex Christensen.
A WebCore project file contains illegal characters.
- WebCore.vcxproj/WebCore.vcxproj.filters:
- 12:45 PM Changeset in webkit [177385] by
-
- 3 edits in trunk/Source/WebKit2
Split UserActivity from disabled flag in WebPage
https://bugs.webkit.org/show_bug.cgi?id=139696
Reviewed by Geoffrey Garen.
In preparation for other things driving the UserActivity.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
- initialize new members.
(WebKit::WebPage::updateUserActivity):
- start/stop the m_userActivity, based on m_processSupressionEnabled
(WebKit::WebPage::updatePreferences):
- call updateUserActivity to account for m_processSupressionEnabled changes.
- WebProcess/WebPage/WebPage.h:
- split m_processSuppressionDisabledByWebPreference -> m_processSupressionEnabled, m_userActivity.
- 12:36 PM Changeset in webkit [177384] by
-
- 3 edits in trunk/Source/WebKit2
Get rid of PassRefPtr inside StorageManager
https://bugs.webkit.org/show_bug.cgi?id=139693
Reviewed by Andreas Kling.
- UIProcess/Storage/StorageManager.cpp:
(WebKit::StorageManager::TransientLocalStorageNamespace::getOrCreateStorageArea):
(WebKit::StorageManager::StorageArea::create):
(WebKit::StorageManager::StorageArea::StorageArea):
(WebKit::StorageManager::StorageArea::clone):
(WebKit::StorageManager::LocalStorageNamespace::create):
(WebKit::StorageManager::LocalStorageNamespace::getOrCreateStorageArea):
(WebKit::StorageManager::SessionStorageNamespace::create):
(WebKit::StorageManager::SessionStorageNamespace::getOrCreateStorageArea):
(WebKit::StorageManager::create):
- UIProcess/Storage/StorageManager.h:
- 12:35 PM Changeset in webkit [177383] by
-
- 2 edits in trunk/Source/WTF
Enable FastMalloc in debug builds
https://bugs.webkit.org/show_bug.cgi?id=139692
Reviewed by Alexey Proskuryakov.
This will give debug builds greater fidelity to the real thing.
FastMalloc now transparently supports all the malloc debugging APIs I
know of by disabling itself at runtime -- and it should be easy to add
support for any APIs I missed -- so there's no need to turn it off in
debug builds.
- wtf/FastMalloc.cpp:
- 12:28 PM Changeset in webkit [177382] by
-
- 3 edits in trunk/LayoutTests
More expectations updated to Timeout.
- platform/mac-wk2/TestExpectations:
- platform/mac/TestExpectations:
- 12:20 PM Changeset in webkit [177381] by
-
- 3 edits in trunk/LayoutTests
More expectations updated to Timeout.
- platform/mac-wk1/TestExpectations:
- platform/mac/TestExpectations:
- 12:11 PM Changeset in webkit [177380] by
-
- 4 edits1 add in trunk/Source/JavaScriptCore
Fixes operationPutByIdOptimizes such that they check that the put didn't
change the structure of the object who's property access is being
cached.
https://bugs.webkit.org/show_bug.cgi?id=139500
Reviewed by Geoffrey Garen.
- jit/JITOperations.cpp:
(JSC::operationPutByIdStrictOptimize): saved the structure before the put.
(JSC::operationPutByIdNonStrictOptimize): ditto.
(JSC::operationPutByIdDirectStrictOptimize): ditto.
(JSC::operationPutByIdDirectNonStrictOptimize): ditto.
- jit/Repatch.cpp:
(JSC::tryCachePutByID): Added argument for the old structure
(JSC::repatchPutByID): Added argument for the old structure
- jit/Repatch.h:
- tests/stress/put-by-id-build-list-order-recurse.js:
Added test that fails without this patch.
- 11:55 AM Changeset in webkit [177379] by
-
- 2 edits in trunk/Source/WTF
RefPtr::copyRef should be const
https://bugs.webkit.org/show_bug.cgi?id=139689
Reviewed by Andreas Kling.
copyRef() doesn't modify the original object so it should be const.
Also, add a && qualified overload and mark it deleted so that calls to copyRef() where
the object is an rvalue will fail to compile.
- wtf/RefPtr.h:
- 11:50 AM Changeset in webkit [177378] by
-
- 3 edits in trunk/Source/WebCore
Introduce PageActivityState
https://bugs.webkit.org/show_bug.cgi?id=139687
Reviewed by Anders Carlsson.
Add a bitfield to track each of the activities on the page separately.
Split the hysteresis & counters so we can track these separately.
- page/PageThrottler.cpp:
(WebCore::PageThrottler::PageThrottler):
- initialze new hysteresis, counters; closures call setActivityFlag.
(WebCore::PageThrottler::mediaActivityToken):
(WebCore::PageThrottler::pageLoadActivityToken):
- split m_pageActivityCounter -> m_mediaActivityCounter, m_pageLoadActivityCounter.
(WebCore::PageThrottler::updateUserActivity):
- use m_activityState to check for activity.
(WebCore::PageThrottler::setActivityFlag):
- helper to clear/set a bit in m_activityState, and call updateUserActivity as necessary.
- page/PageThrottler.h:
(WebCore::PageThrottler::didReceiveUserInput):
(WebCore::PageThrottler::pluginDidEvaluateWhileAudioIsPlaying):
- split m_hysteresis -> m_userInputHysteresis, m_audiblePluginHysteresis
- 11:28 AM Changeset in webkit [177377] by
-
- 14 edits in trunk
Ruby does not preserve expansion opportunities from enclosing context
https://bugs.webkit.org/show_bug.cgi?id=139618
Source/WebCore:
Patch by Myles C. Maxfield <litherum@gmail.com> on 2014-12-16
Reviewed by David Hyatt.
There is currently no sharing of expansion opportunity information between
ruby bases and the text surrounding the ruby. This patch adds a bit on
RenderText, m_contentIsKnownToFollow, which affects how expansion
opportunities are handled at paint-time, as well as a bit on RenderRubyBase,
m_isAfterExpansion, which affects how expansions are calculated when laying
out a line. This patch also adds a field to RenderRubyBase which represents
the base's starting position within a ruby. This field is necessary because
an expansion from a line might occur at the very beginning of a ruby base,
so we have to remember some state from expansion time to RenderRubyBase
layout time.
Added more tests to fast/ruby/ruby-justification.html.
- rendering/InlineBox.h:
(WebCore::InlineBox::setExpansionWithoutGrowing):
(WebCore::InlineBox::expansion):
- rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::removeChild): Keep the bit on InlineTextBox up to
date.
(WebCore::InlineFlowBox::placeBoxRangeInInlineDirection): Set expansion
information in InlineFlowBoxes so the total expansion for a whole line
is held in the RootInlineBox's expansion.
- rendering/InlineTextBox.h:
(WebCore::InlineTextBox::expansionBehavior):
- rendering/RenderBlockFlow.h:
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlockFlow::updateRubyForJustifiedText):
updateRubyForJustifiedText() had a bunch of problems with it. First of all,
it didn't actually set the InlineBoxes as dirty, so the second layout pass
sometimes wouldn't perform any updates. Secondarily, it didn't take
overhangs into account. Thirdly, it didn't mark the ruby base and text as
needing layout so that subsequent layouts would actually traverse into them.
(WebCore::RenderBlockFlow::computeExpansionForJustifiedText):
(WebCore::RenderBlockFlow::computeInlineDirectionPositionsForSegment):
This nested if triangle is super nasty, but I'm not sure of a better way to
write it.
(WebCore::updateRubyForJustifiedText): Deleted.
(WebCore::computeExpansionForJustifiedText): Deleted.
- rendering/RenderRubyBase.cpp:
(WebCore::RenderRubyBase::RenderRubyBase):
(WebCore::RenderRubyBase::adjustInlineDirectionLineBounds):
- rendering/RenderRubyBase.h:
- rendering/RenderRubyRun.cpp:
(WebCore::RenderRubyRun::layout):
- rendering/RenderText.cpp:
(WebCore::RenderText::RenderText):
- rendering/RenderText.h:
(WebCore::RenderText::contentIsKnownToFollow):
(WebCore::RenderText::setContentIsKnownToFollow):
LayoutTests:
Updating test for new expansion logic.
Patch by Myles C. Maxfield <litherum@gmail.com> on 2014-12-16
Reviewed by David Hyatt.
- fast/ruby/ruby-justification-expected.html:
- fast/ruby/ruby-justification.html:
- 11:27 AM Changeset in webkit [177376] by
-
- 3 edits in trunk/LayoutTests
More expectations updated to Timeout.
Also, undone some accidental skips. It may be right to skip tests that always time
out, but let's do that intentionally, and with a review.
- platform/mac-wk2/TestExpectations:
- platform/mac/TestExpectations:
- 11:20 AM Changeset in webkit [177375] by
-
- 3 edits in trunk/Source/WebCore
[iOS] Crash in WebKit::WebPageProxy::dispatchViewStateChange() tapping a link from another app while playing a video
https://bugs.webkit.org/show_bug.cgi?id=139550
Reviewed by Anders Carlsson.
The existing "dispatch to WebThread, then release" model is insufficient and still
can result in RefPtr race conditions between the main thread and the web thread.
Make WebVideoFullscreenInterfaceAVKit a thread-safe ref-counted class, which
eliminates the necessity of disptaching back to the web thread before releasing.
- platform/ios/WebVideoFullscreenInterfaceAVKit.h:
- platform/ios/WebVideoFullscreenInterfaceAVKit.mm:
(WebVideoFullscreenInterfaceAVKit::setDuration): Use a strongThis model.
(WebVideoFullscreenInterfaceAVKit::setCurrentTime): Ditto.
(WebVideoFullscreenInterfaceAVKit::setRate): Ditto.
(WebVideoFullscreenInterfaceAVKit::setVideoDimensions): Ditto.
(WebVideoFullscreenInterfaceAVKit::setSeekableRanges): Ditto.
(mediaSelectionOptions): Return a RetainPtr object.
(WebVideoFullscreenInterfaceAVKit::setAudioMediaSelectionOptions): Use a strongThis model.
(WebVideoFullscreenInterfaceAVKit::setLegibleMediaSelectionOptions): Ditto.
(WebVideoFullscreenInterfaceAVKit::setExternalPlayback): Ditto.
(WebVideoFullscreenInterfaceAVKit::setupFullscreen): Ditto.
(WebVideoFullscreenInterfaceAVKit::enterFullscreen): Ditto.
(WebVideoFullscreenInterfaceAVKit::exitFullscreen): Ditto.
(WebVideoFullscreenInterfaceAVKit::cleanupFullscreen): Ditto.
(WebVideoFullscreenInterfaceAVKit::setupFullscreenInternal): Added utility
function. Lets us use the implied this pointer rather than an explicit
strongThis.
(WebVideoFullscreenInterfaceAVKit::enterFullscreenOptimized): Ditto.
(WebVideoFullscreenInterfaceAVKit::enterFullscreenStandard): Ditto.
(WebVideoFullscreenInterfaceAVKit::exitFullscreenInternal): Ditto.
(WebVideoFullscreenInterfaceAVKit::cleanupFullscreenInternal): Ditto.
(WebVideoFullscreenInterfaceAVKit::requestHideAndExitFullscreen): Use a strongThis model.
- 11:16 AM Changeset in webkit [177374] by
-
- 2 edits in trunk/LayoutTests
Update some test expectations from Failure to Timeout, which is now correctly detected.
- platform/mac/TestExpectations:
- 11:15 AM Changeset in webkit [177373] by
-
- 4 edits in branches/safari-600.3-branch/Source
Merged r177371. rdar://problems/19266902
- 11:08 AM Changeset in webkit [177372] by
-
- 44 edits2 adds in trunk
Nested template contents are not cloned by document.importNode
https://bugs.webkit.org/show_bug.cgi?id=137619
Reviewed by Andreas Kling.
Source/WebCore:
The bug was caused by Document.importNode not cloning HTMLTemplateElement's content.
Fixed the bug by sharing code between Document::importNode and Node::cloneNode by
generalizing Node::cloneNodeInternal, added in r177314, by taking the owner document
as an argument. The most of code changes are the result of adding this argument.
Document::importNode is the only function in which the actual logic changes.
Note that the code to import TEXT_NODE, CDATA_SECTION_NODE, ENTITY_REFERENCE_NODE,
PROCESSING_INSTRUCTION_NODE and COMMENT_NODE nodes are identical to that of cloneNode.
This patch removes the call to hasValidNamespaceForElements in ELEMENT_NODE but this
should not introduce an observable behavior change since all instantiated elements
should have a valid namespace in the first place.
Because DOCUMENT_NODE and DOCUMENT_TYPE_NODE cannot be imported and DOCUMENT_TYPE_NODE
can only appear as a direct child of DOCUMENT_NODE, neither nodes nor unimplemented
XPATH_NAMESPACE_NODE and XPATH_NAMESPACE_NODE can appear inside the recursive calls
for ELEMENT_NODE and DOCUMENT_FRAGMENT_NODE nodes.
While importNode behaves differently from cloneNode for ATTRIBUTE_NODE, namely that
it merges all of its child nodes, this behavior isn't present when recursing inside
ELEMENT_NODE and DOCUMENT_FRAGMENT_NODE since we are using cloneDataFromElement.
Thus there should be no observable behavior changes for DOCUMENT_FRAGMENT_NODE and
ELEMENT_NODE nodes either.
Test: fast/dom/HTMLTemplateElement/importNode-nested-templates.html
- dom/Attr.cpp:
(WebCore::Attr::cloneNodeInternal):
- dom/Attr.h:
- dom/CDATASection.cpp:
(WebCore::CDATASection::cloneNodeInternal):
- dom/CDATASection.h:
- dom/Comment.cpp:
(WebCore::Comment::cloneNodeInternal):
- dom/Comment.h:
- dom/ContainerNode.cpp:
(WebCore::ContainerNode::cloneChildNodes):
- dom/Document.cpp:
(WebCore::Document::importNode):
(WebCore::Document::cloneNodeInternal):
- dom/Document.h:
- dom/DocumentFragment.cpp:
(WebCore::DocumentFragment::cloneNodeInternal):
- dom/DocumentFragment.h:
- dom/DocumentType.cpp:
(WebCore::DocumentType::cloneNodeInternal):
- dom/DocumentType.h:
- dom/Element.cpp:
(WebCore::Element::cloneNodeInternal):
(WebCore::Element::cloneElementWithChildren):
(WebCore::Element::cloneElementWithoutChildren):
(WebCore::Element::cloneElementWithoutAttributesAndChildren):
- dom/Element.h:
- dom/EntityReference.cpp:
(WebCore::EntityReference::cloneNodeInternal):
- dom/EntityReference.h:
- dom/Node.h:
(WebCore::Node::cloneNode):
- dom/ProcessingInstruction.cpp:
(WebCore::ProcessingInstruction::cloneNodeInternal):
- dom/ProcessingInstruction.h:
- dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::cloneNodeInternal):
- dom/ShadowRoot.h:
- dom/Text.cpp:
(WebCore::Text::cloneNodeInternal):
- dom/Text.h:
- editing/ApplyStyleCommand.cpp:
(WebCore::ApplyStyleCommand::pushDownInlineStyleAroundNode):
(WebCore::ApplyStyleCommand::applyInlineStyleChange):
- editing/BreakBlockquoteCommand.cpp:
(WebCore::BreakBlockquoteCommand::doApply):
- editing/InsertParagraphSeparatorCommand.cpp:
(WebCore::InsertParagraphSeparatorCommand::cloneHierarchyUnderNewBlock):
(WebCore::InsertParagraphSeparatorCommand::doApply):
- editing/ModifySelectionListLevel.cpp:
(WebCore::IncreaseSelectionListLevelCommand::doApply):
- editing/SplitElementCommand.cpp:
(WebCore::SplitElementCommand::doApply):
- editing/markup.cpp:
(WebCore::createFragmentFromText):
- html/HTMLKeygenElement.cpp:
- html/HTMLScriptElement.cpp:
(WebCore::HTMLScriptElement::cloneElementWithoutAttributesAndChildren):
- html/HTMLScriptElement.h:
- html/HTMLTemplateElement.cpp:
(WebCore::HTMLTemplateElement::cloneNodeInternal):
- html/HTMLTemplateElement.h:
- html/shadow/SliderThumbElement.cpp:
(WebCore::SliderThumbElement::cloneElementWithoutAttributesAndChildren):
- html/shadow/SliderThumbElement.h:
- html/track/WebVTTElement.cpp:
(WebCore::WebVTTElement::cloneElementWithoutAttributesAndChildren):
- html/track/WebVTTElement.h:
- svg/SVGScriptElement.cpp:
(WebCore::SVGScriptElement::cloneElementWithoutAttributesAndChildren):
- svg/SVGScriptElement.h:
- svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::buildShadowTree):
(WebCore::SVGUseElement::expandUseElementsInShadowTree):
LayoutTests:
Added a regression test.
- fast/dom/HTMLTemplateElement/importNode-nested-templates-expected.txt: Added.
- fast/dom/HTMLTemplateElement/importNode-nested-templates.html: Added.
- 11:07 AM Changeset in webkit [177371] by
-
- 4 edits in trunk/Source
Disable TextIndication for Lookup immediate actions
https://bugs.webkit.org/show_bug.cgi?id=139684
rdar://problem/19266902
Reviewed by Anders Carlsson.
- UIProcess/mac/WKImmediateActionController.mm:
(-[WKImmediateActionController _animationControllerForText]):
- WebView/WebView.mm:
(-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
- 10:59 AM Changeset in webkit [177370] by
-
- 2 edits in trunk/Tools
Sort out timeout implementations in DRT and WKTR
https://bugs.webkit.org/show_bug.cgi?id=139671
Remove an obsolete test that doesn't capture how run-webkit-tests interacts
with the tool.
- Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(RunTest.test_hung_thread):
- 10:56 AM Changeset in webkit [177369] by
-
- 2 edits in branches/safari-600.3-branch/Source/WebKit2
Merged r177230. rdar://problems/19208291
- 10:45 AM Changeset in webkit [177368] by
-
- 2 edits in trunk/LayoutTests
WebKit2 test expectations gardening.
Update syntax, unskip some tests that were skipped before we had expectations.
- platform/wk2/TestExpectations:
- 10:44 AM Changeset in webkit [177367] by
-
- 2 edits in trunk/LayoutTests
media/video-controls-toggling.html always times out
https://bugs.webkit.org/show_bug.cgi?id=116266
Skip it.
- platform/mac/TestExpectations:
- 10:42 AM Changeset in webkit [177366] by
-
- 14 edits26 adds in trunk
Document.contentType implementation
https://bugs.webkit.org/show_bug.cgi?id=132269
Patch by Tibor Meszaros <tmeszaros.u-szeged@partner.samsung.com> on 2014-12-16
Reviewed by Darin Adler.
Chromium merge from https://codereview.chromium.org/151653004
Source/WebCore:
Tests: fast/dom/document-contentType-DOMParser.html
fast/dom/document-contentType-createDocument.html
fast/dom/document-contentType-data-uri.html
fast/xsl/xslt-contentType.html
http/tests/dom/document-contentType-meta.html
http/tests/dom/document-contentType-xhr.html
http/tests/dom/document-contentType.html
- dom/Document.cpp:
(WebCore::Document::overrideMIMEType):
(WebCore::Document::contentType):
(WebCore::Document::cloneDataFromDocument):
- dom/Document.h:
- dom/Document.idl:
- loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::currentContentType):
- loader/DocumentLoader.h:
- xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::responseXML):
- xml/XSLTProcessor.cpp:
(WebCore::XSLTProcessor::createDocumentFromSource):
LayoutTests:
- fast/dom/Document/clone-node-expected.txt:
- fast/dom/Document/clone-node.html:
- fast/dom/HTMLDocument/clone-node-quirks-mode-expected.txt:
- fast/dom/HTMLDocument/clone-node-quirks-mode.html:
- fast/dom/document-contentType-DOMParser-expected.txt: Added.
- fast/dom/document-contentType-DOMParser.html: Added.
- fast/dom/document-contentType-createDocument-expected.txt: Added.
- fast/dom/document-contentType-createDocument.html: Added.
- fast/dom/document-contentType-data-uri-expected.txt: Added.
- fast/dom/document-contentType-data-uri.html: Added.
- fast/xsl/xslt-contentType-expected.txt: Added.
- fast/xsl/xslt-contentType.html: Added.
- http/tests/dom/document-contentType-expected.txt: Added.
- http/tests/dom/document-contentType-meta-expected.txt: Added.
- http/tests/dom/document-contentType-meta.html: Added.
- http/tests/dom/document-contentType-xhr-expected.txt: Added.
- http/tests/dom/document-contentType-xhr.html: Added.
- http/tests/dom/document-contentType.html: Added.
- http/tests/dom/resources/dummy.css: Added.
(body):
- http/tests/dom/resources/dummy.html: Added.
- http/tests/dom/resources/dummy.js: Added.
- http/tests/dom/resources/dummy.txt: Added.
- http/tests/dom/resources/dummy.xml: Added.
- http/tests/dom/resources/send-mime-type.php: Added.
- http/tests/dom/resources/square20.bmp: Added.
- http/tests/dom/resources/square20.gif: Added.
- http/tests/dom/resources/square20.jpg: Added.
- http/tests/dom/resources/square20.png: Added.
- resources/js-test.js:
(shouldBeEqualToNumber):
- 10:39 AM Changeset in webkit [177365] by
-
- 7 edits in trunk/Source/WebCore
Put some common code in StorageNamespaceProvider
https://bugs.webkit.org/show_bug.cgi?id=139682
Reviewed by Tim Horton.
We have code in two places that gets the local storage area from a given document,
choosing either the local storage namespace or the transient local storage namespace.
Move it to StorageNamespaceProvider::localStorageArea.
- bindings/js/ScriptController.cpp:
- inspector/InspectorDOMStorageAgent.cpp:
(WebCore::InspectorDOMStorageAgent::findStorageArea):
- page/DOMWindow.cpp:
(WebCore::DOMWindow::localStorage):
- page/Navigator.cpp:
- storage/StorageNamespaceProvider.cpp:
(WebCore::StorageNamespaceProvider::localStorageArea):
(WebCore::StorageNamespaceProvider::localStorageNamespace):
- storage/StorageNamespaceProvider.h:
- 10:36 AM Changeset in webkit [177364] by
-
- 2 edits in trunk/LayoutTests
media/track/track-language-preference.html and media/track/track-prefer-captions.html time out on Mac
https://bugs.webkit.org/show_bug.cgi?id=112492
Skip these, as they time out every time.
- platform/mac/TestExpectations:
- 10:32 AM Changeset in webkit [177363] by
-
- 19 edits in trunk/Tools
Sort out timeout implementations in DRT and WKTR
https://bugs.webkit.org/show_bug.cgi?id=139671
Reviewed by Simon Fraser.
Test timeout implementation had many deficiencies, please see the bug for details.
Most notably, we shouldn't have the tool confused about timeouts vs. failures, and
[ Slow ] modifiers should work a lot better.
- DumpRenderTree/TestRunner.cpp: (TestRunner::TestRunner):
- DumpRenderTree/TestRunner.h: (TestRunner::setCustomTimeout):
- DumpRenderTree/mac/DumpRenderTree.mm: (runTest):
- DumpRenderTree/mac/TestRunnerMac.mm: (TestRunner::setWaitToDump):
DumpRenderTree already read the --timeout option from command line, and webkitpy
was already configured to pass it on Mac and iOS. Let's actually use it.
TestCommand already had the same 30 second default, so this doesn't change behavior
when DRT is ran manually without the option.
Windows DumpRenderTree will need to be fixed separately (that's easy).
- DumpRenderTree/TestRunner.cpp: (TestRunner::waitToDumpWatchdogTimerFired()):
Don't print the timeout message to stdout to match WebKitTestRunner. It would be
slightly better to use stderr in both, as this is an out of band message, but
that's a larger refactoring, and the difference is minimal in practice.
- Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
(SingleTestRunner.init): Ensure that script and tool timeouts are substantially
different. We want the tool to reliably detect timeouts that can be detected, and
not race with the script for that.
- Scripts/webkitpy/port/base.py: (Port.default_timeout_ms): Don't make WebKit2
timeout longer than WebKit1 one, I doubt that this is necessary. Now that the value
is honored inmore cases, that could make tests run slower.
- Scripts/webkitpy/port/driver.py:
(Driver.init):
(Driver.run_test):
(Driver.cmd_line):
(Driver._check_for_driver_timeout):
Detect tests that have the timeout output, and make these have the proper Timeout result.
- Scripts/webkitpy/port/ios.py: (IOSSimulatorPort.default_timeout_ms): Remove an
incorrect recent change - 80 * 1000 is 80 seconds, not 80 milliseconds.
- WebKitTestRunner/InjectedBundle/TestRunner.cpp:
(WTR::TestRunner::setCustomTimeout): Deleted.
- WebKitTestRunner/InjectedBundle/TestRunner.h:
(WTR::TestRunner::setCustomTimeout):
- WebKitTestRunner/InjectedBundle/efl/TestRunnerEfl.cpp:
(WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
- WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
(WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
- WebKitTestRunner/InjectedBundle/win/TestRunnerWin.cpp:
(WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
- WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
(WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
Updated to use a timeout passed from UI process, which used to be ignored.
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::TestController):
(WTR::TestController::runUntil):
(WTR::TestController::getCustomTimeout): Deleted.
- WebKitTestRunner/TestController.h:
Delete unused m_timeout. First, it was always 0, and second, we don't need it at all.
Changed default message timeouts to match new run-webkit-tests timeout. These don't
affect ports where timeout is passed per test (shouldn't they all be like that?).
- WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::invoke):
(WTR::TestInvocation::setCustomTimeout): Deleted.
- WebKitTestRunner/TestInvocation.h:
(WTR::TestInvocation::setCustomTimeout):
(WTR::TestInvocation::customTimeout):
Ditto.
- 9:45 AM Changeset in webkit [177362] by
-
- 7 edits2 adds in trunk/Source/WebKit2
[Cocoa] WKWebProcessPlugInLoadDelegate can’t tell what type of same-document navigation has happened
https://bugs.webkit.org/show_bug.cgi?id=139669
Reviewed by Anders Carlsson.
- Shared/API/Cocoa/_WKSameDocumentNavigationType.h: Added. Moved the
_WKSameDocumentNavigationType type definition here from WKNavigationDelegatePrivate.h.
- Shared/API/Cocoa/_WKSameDocumentNavigationTypeInternal.h: Added.
(WebKit::toWKSameDocumentNavigationType): Moved from NavigationState.mm.
- Shared/API/c/WKSharedAPICast.h:
(WebKit::toSameDocumentNavigationType): Added this conversion helper.
- UIProcess/API/Cocoa/WKNavigationDelegatePrivate.h: Added #import.
- UIProcess/Cocoa/NavigationState.mm:
(WebKit::toWKSameDocumentNavigationType): Deleted.
- WebKit2.xcodeproj/project.pbxproj: Updated for added headers.
- WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInLoadDelegate.h: Declared new
delegate method that take a navigation type parameter.
- WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm:
(didSameDocumentNavigationForFrame): Changed to call the new delegate method, passing the
navigation type.
- 9:15 AM Changeset in webkit [177361] by
-
- 2 edits in trunk/Source/WebCore
Add FeatureCounterKeys.h to the Xcode project.
- WebCore.xcodeproj/project.pbxproj:
- 8:12 AM Changeset in webkit [177360] by
-
- 3 edits2 adds in trunk
REGRESSION (r163928): Animated GIFs are not resumed when translated into view using -webkit-transform
https://bugs.webkit.org/show_bug.cgi?id=139672
<rdar://problem/19260797>
Reviewed by Antti Koivisto.
Source/WebCore:
After r163928, animated GIFs were not resumed when translated into view
using '-webkit-transform' CSS property.
This broke animated gifs on the mobile version of weibo.com (which is
one of the most popular blogging sites in China) on iPhone. e.g.
http://m.weibo.cn/page/tpl?containerid=1005052150182731_-_WEIBO_SECOND_PROFILE_WEIBO&itemid=&title=全部微博
This patch calls FrameView::resumeVisibleImageAnimationsIncludingSubframes()
after style recalc so that we resume animated images if they become visible
after the style has changed. Doing so after layout wouldn't work because
no layout happens in this case.
Test: fast/images/animated-gif-webkit-transform.html
- dom/Document.cpp:
(WebCore::Document::recalcStyle):
LayoutTests:
Add a layout test to verity that animated images are properly paused /
resumed when translated in and out of view using '-webkit-transform'
CSS property.
- fast/images/animated-gif-webkit-transform-expected.txt: Added.
- fast/images/animated-gif-webkit-transform.html: Added.
- 3:41 AM Changeset in webkit [177359] by
-
- 1 copy in releases/WebKitGTK/webkit-2.7.3
WebKitGTK+ 2.7.3
- 3:37 AM Changeset in webkit [177358] by
-
- 4 edits in trunk
Unreviewed. Update OptionsGTK.cmake and NEWS for 2.7.3 release.
.:
- Source/cmake/OptionsGTK.cmake: Bump version numbers.
Source/WebKit2:
- gtk/NEWS: Add release notes for 2.7.3.
- 2:24 AM Changeset in webkit [177357] by
-
- 2 edits in trunk/Tools
[EFL] Add logging domain for MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=139642
Reviewed by Gyuyoung Kim.
Similarly to EWebKit2, provide logging facility for MiniBrowser
based on Eina Log module to have a convenient way to display
all/subset/none messages for EFL based libraries and MiniBrowser.
Usage:
- Disable all messages: EINA_LOG_LEVEL=0 ./Tools/Scripts/run-launcher --efl
- Enable all messages: EINA_LOG_LEVEL=7 ./Tools/Scripts/run-launcher --efl
- Enable MiniBrowser and EWebkit2 messages only: EINA_LOG_LEVELS="minibrowser:7,ewebkit2:7" ./Tools/Scripts/run-launcher --efl
More information and examples you can find here:
http://docs.enlightenment.org/auto/eet/tutorial_log_page.html
- MiniBrowser/efl/main.c:
(on_mouse_wheel):
(on_window_resize):
(save_page_contents_callback):
(script_execute_callback):
(on_key_down):
(on_download_request):
(on_download_finished):
(on_download_failed):
(quit):
(on_refresh_button_clicked):
(on_stop_button_clicked):
(navigation_button_longpress_process):
(on_popup_menu_item_clicked):
(popup_menu_populate):
(on_popup_menu_show):
(on_window_create):
(context_menu_item_selected_cb):
(context_menu_populate):
(on_context_menu_show):
(on_context_menu_hide):
(on_navigation_policy_decision):
(window_create):
(parse_cookies_policy):
(elm_main):
(has_scheme):
(list_item_label_get):
(on_popup_menu_hide):
(on_window_close):
(on_home_button_clicked):
Replace locally info() macro with newly introduced
one which uses Eina Log module. There is no logic change.
- 2:08 AM Changeset in webkit [177356] by
-
- 5 edits in trunk/Source/WebKit2
WebKit level persistent caching
https://bugs.webkit.org/show_bug.cgi?id=30322
Minor cleanups based on comments by Joseph Pecoraro.
- NetworkProcess/cache/NetworkCache.cpp:
(WebKit::decodeStorageEntry):
- NetworkProcess/cache/NetworkCache.h:
- NetworkProcess/cache/NetworkCacheStorage.h:
- NetworkProcess/cocoa/NetworkProcessCocoa.mm:
(WebKit::NetworkProcess::platformInitializeNetworkProcessCocoa):
- 1:05 AM Changeset in webkit [177355] by
-
- 2 edits in branches/safari-600.3-branch/Source/WebKit/mac
Merged r177327. <rdar://problem/19198414>
- 1:04 AM Changeset in webkit [177354] by
-
- 5 edits in branches/safari-600.3-branch/Source
Merged r177326. <rdar://problem/19198414>
- 1:02 AM Changeset in webkit [177353] by
-
- 2 edits in branches/safari-600.3-branch/Source/WebCore
Merged r177325. <rdar://problem/19198414>
- 1:01 AM Changeset in webkit [177352] by
-
- 16 edits in branches/safari-600.3-branch/Source
Merged r177323. <rdar://problem/19198414>
- 12:57 AM Changeset in webkit [177351] by
-
- 2 edits in branches/safari-600.3-branch/Source/WebKit/mac
Merged r177304. <rdar://problem/19198539>
- 12:53 AM Changeset in webkit [177350] by
-
- 4 edits in branches/safari-600.3-branch/Source
Merged r177303. <rdar://problem/19198539>
- 12:50 AM Changeset in webkit [177349] by
-
- 7 edits in branches/safari-600.3-branch/Source/WebKit/mac
Merged r177300. <rdar://problem/19198539>
- 12:44 AM Changeset in webkit [177348] by
-
- 6 edits in branches/safari-600.3-branch/Source/WebKit2
Merged r177298. <rdar://problem/19198539>
- 12:39 AM Changeset in webkit [177347] by
-
- 9 edits in branches/safari-600.3-branch/Source/WebKit2
Merged r177242. <rdar://problem/19226350>
- 12:34 AM Changeset in webkit [177346] by
-
- 2 edits in branches/safari-600.3-branch/Source/WebKit/mac
Merged r177201. <rdar://problem/19225448>
- 12:31 AM Changeset in webkit [177345] by
-
- 3 edits in branches/safari-600.3-branch/Source/WebKit/mac
Merged r177199. <rdar://problem/19225448>
- 12:27 AM Changeset in webkit [177344] by
-
- 6 edits in branches/safari-600.3-branch/Source/WebKit2
Merged r177192. <rdar://problem/19225448>
- 12:22 AM Changeset in webkit [177343] by
-
- 9 edits in branches/safari-600.3-branch/Source
Merged r177186. <rdar://problem/19208291>
- 12:18 AM Changeset in webkit [177342] by
-
- 8 edits in branches/safari-600.3-branch/Source
Merged r177183. <rdar://problem/19208291>
- 12:17 AM Changeset in webkit [177341] by
-
- 2 edits in trunk/Source/WebCore
[GStreamer] Fix deadlock when shutting down AudioDestination
https://bugs.webkit.org/show_bug.cgi?id=139496
Patch by Sebastian Dröge <sebastian@centricular.com> on 2014-12-16
Reviewed by Philippe Normand.
- platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:
(webKitWebAudioSrcLoop):
(webKitWebAudioSrcChangeState):
Sometimes we would wait forever for the task to shut down. This
was happening because of a bug in GStreamer that caused joining
a paused task to deadlock.
- 12:16 AM Changeset in webkit [177340] by
-
- 2 edits in branches/safari-600.3-branch/Source/WebCore
Merged r177182. <rdar://problem/19208291>
- 12:15 AM Changeset in webkit [177339] by
-
- 10 edits2 copies in branches/safari-600.3-branch/Source
Merged r177180. <rdar://problem/19208291>
- 12:08 AM Changeset in webkit [177338] by
-
- 7 edits2 copies in branches/safari-600.3-branch/Source/WebKit
Merged r177131. <rdar://problem/19198539>
- 12:03 AM Changeset in webkit [177337] by
-
- 2 edits in branches/safari-600.3-branch/Source/WebCore
Merged r177124. <rdar://problem/19198539>
- 12:02 AM Changeset in webkit [177336] by
-
- 2 edits in branches/safari-600.3-branch/Source/WebKit2
Merged r177116. <rdar://problem/19198539>
- 12:01 AM Changeset in webkit [177335] by
-
- 2 edits in branches/safari-600.3-branch/Source/WebKit2
Merged r177114. <rdar://problem/19198539>
