⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Dec 22, 2014:

11:28 PM Changeset in webkit [177681] by Chris Dumez
  • 3 edits in trunk/Source/WebCore

[iOS] Log which type of resources are commonly loaded using FeatureCounter
​https://bugs.webkit.org/show_bug.cgi?id=139890

Reviewed by Darin Adler.

Log which type of resources are commonly loaded using FeatureCounter
(e.g. stylesheets, scripts, fonts, images, ...).

  • loader/SubresourceLoader.cpp:

(WebCore::logResourceLoadedUsingFeatureCounter):
(WebCore::SubresourceLoader::didFinishLoading):

  • platform/FeatureCounterKeys.h:
11:23 PM Changeset in webkit [177680] by Chris Dumez
  • 5 edits in trunk/Source/WebCore

[iOS] Log using FeatureCounter when a PacheCache fails due to memory pressure
​https://bugs.webkit.org/show_bug.cgi?id=139874
<rdar://problem/19255690>

Reviewed by Darin Adler.

Log using FeatureCounter when a PacheCache fails due to memory
pressure. To detect this, a flag is added to HistoryItem to mark
items that are no longer in the page becaused they were pruned
(either because of a low memory handling or because the page cache
reached its maximum capacity).

  • history/HistoryItem.cpp:

(WebCore::HistoryItem::HistoryItem):

  • history/HistoryItem.h:
  • history/PageCache.cpp:

(WebCore::PageCache::add):
(WebCore::PageCache::take):
(WebCore::PageCache::get):
(WebCore::PageCache::prune):

  • platform/FeatureCounterKeys.h:
11:17 PM Changeset in webkit [177679] by ap@apple.com
  • 2 edits in trunk/LayoutTests

platform/mac-wk2/tiled-drawing/scrolling/frames/frameset-frame-scrollability.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=139901

  • platform/mac-wk2/TestExpectations: Mark it as such.
11:15 PM Changeset in webkit [177678] by commit-queue@webkit.org
  • 4 edits
    6 deletes in trunk

Unreviewed, rolling out r177658.
​https://bugs.webkit.org/show_bug.cgi?id=139900

Caused many assertion failures (Requested by ap on #webkit).

Reverted changeset:

"Incorrect dashed and dotted border painting."
​https://bugs.webkit.org/show_bug.cgi?id=139872
​http://trac.webkit.org/changeset/177658

7:24 PM Changeset in webkit [177677] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

Make it possible to transform Objective-C object graphs, replacing certain elements with others
​https://bugs.webkit.org/show_bug.cgi?id=139893

Reviewed by Sam Weinig.

  • Shared/mac/ObjCObjectGraph.h:

(WebKit::ObjCObjectGraph::Transformer::~Transformer):

  • Shared/mac/ObjCObjectGraph.mm:

(WebKit::dynamic_objc_cast):
(WebKit::shouldTransform):
(WebKit::ObjCObjectGraph::transform):

7:21 PM Changeset in webkit [177676] by ljaehun.lim@samsung.com
  • 4 edits in trunk/Source

Unreviewed build fix after r177661 and r177662

Source/WebCore:

  • dom/SecurityOriginPolicy.cpp: Modify #include path.

Source/WebKit2:

  • CMakeLists.txt: Add APIPageGroupHandle.cpp to the source list.
6:48 PM Changeset in webkit [177675] by mark.lam@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Use ctiPatchCallByReturnAddress() in JITOperations.cpp.
<​https://webkit.org/b/139892>

Reviewed by Michael Saboff.

The code in JITOperations.cpp sometimes calls RepatchBuffer::relinkCallerToFunction()
directly, and sometimes uses a helper function, ctiPatchCallByReturnAddress().
This patch changes it to use the helper function consistently.

  • jit/JITOperations.cpp:
6:24 PM Changeset in webkit [177674] by mrowe@apple.com
  • 2 edits in trunk/Source/WebCore

[Mac] Engineering builds of WebCore on OS X 10.8 and 10.9 shouldn't build with -gline-tables-only
<​https://webkit.org/b/139883> / <rdar://problem/19297261>

Reviewed by Alexey Proskuryakov.

  • Configurations/DebugRelease.xcconfig: Override the setting using conditional settings

so that they take precedence over the conditional settings in Base.xcconfig.

5:59 PM Changeset in webkit [177673] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

Convert pages and page groups to their respective handle objects
​https://bugs.webkit.org/show_bug.cgi?id=139891

Reviewed by Tim Horton.

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::apiObjectByConvertingToHandles):

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::apiObjectByConvertingFromHandles):

5:54 PM Changeset in webkit [177672] by Brent Fulgham
  • 2 edits in trunk/Source/WebKit

[Win] Build fix after r177668.

  • WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in: Add missing export definition

for new symbols.

5:32 PM Changeset in webkit [177671] by andersca@apple.com
  • 12 edits in trunk/Source/WebKit2

Add a bunch of missing header includes in preparation for making toImpl require the complete type
​https://bugs.webkit.org/show_bug.cgi?id=139887

Reviewed by Andreas Kling.

  • WebProcess/InjectedBundle/API/c/WKBundle.cpp:
  • WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
  • WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
  • WebProcess/InjectedBundle/API/c/WKBundlePageOverlay.cpp:
  • WebProcess/InjectedBundle/InjectedBundlePageContextMenuClient.cpp:
  • WebProcess/InjectedBundle/InjectedBundlePageDiagnosticLoggingClient.cpp:
  • WebProcess/InjectedBundle/InjectedBundlePageEditorClient.cpp:
  • WebProcess/InjectedBundle/InjectedBundlePageFormClient.cpp:
  • WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:
  • WebProcess/InjectedBundle/InjectedBundlePageResourceLoadClient.cpp:
  • WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp:
5:23 PM Changeset in webkit [177670] by ap@apple.com
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix.

  • WebCore.exp.in: Move SQLiteDatabaseTracker::setClient export out of PLATFORM(IOS) section.
5:22 PM Changeset in webkit [177669] by bshafiei@apple.com
  • 1 copy in tags/Safari-600.1.4.13.3

New tag.

4:54 PM Changeset in webkit [177668] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Remove two functions from SecurityOrigin
​https://bugs.webkit.org/show_bug.cgi?id=139885

Reviewed by Andreas Kling.

  • page/SecurityOrigin.h:

(WebCore::SecurityOrigin::canAccessPasswordManager): Deleted.
(WebCore::SecurityOrigin::canAccessFileSystem): Deleted.

4:50 PM Changeset in webkit [177667] by mark.lam@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Fix some typos in a comment.
<​https://webkit.org/b/139882>

Reviewed by Michael Saboff.

  • jit/JITPropertyAccess.cpp:

(JSC::JIT::emit_op_get_by_val):

4:48 PM Changeset in webkit [177666] by Chris Dumez
  • 7 edits in trunk/Source

[iOS] Log using FeatureCounter user-triggered zooming
​https://bugs.webkit.org/show_bug.cgi?id=139879
<rdar://problem/19329130>

Reviewed by Benjamin Poulain.

Log using FeatureCounter user-triggered zooming on iOS.

Source/WebCore:

  • WebCore.exp.in:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/FeatureCounter.h:
  • platform/FeatureCounterKeys.h:

Source/WebKit2:

  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::willStartUserTriggeredZooming):

4:45 PM Changeset in webkit [177665] by matthew_hanson@apple.com
  • 5 edits in branches/safari-600.3-branch/Source

Versioning.

4:38 PM Changeset in webkit [177664] by benjamin@webkit.org
  • 8 edits
    28 adds in trunk

Form elements should match :valid and :invalid based on their associated elements
​https://bugs.webkit.org/show_bug.cgi?id=139850

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2014-12-22
Reviewed by Darin Adler.

Source/WebCore:

In the latest HTML spec, form elements can match :valid or :invalid based
on their associated element.

The tricky part is that object lifetime is a mess. When elements are associated
with forms by the parser, the form is set by the constructor of HTMLFormControlElement.
At that point, the real object has not been initialized yet which
makes it impossible to find its validity.

To work around the lifetime problem, the code of HTMLFormControlElement::didChangeForm()
uses m_willValidateInitialized and m_willValidate direclty instead
of invoking willValidate(). That way we don't try to validate an incomplete object.

When the object really validates, HTMLFormControlElement::setNeedsWillValidateCheck()
takes care of updating the form.

Tests: fast/css/pseudo-invalid-form-and-fieldset-basics.html

fast/css/pseudo-invalid-form-basics.html
fast/css/pseudo-invalid-form-dynamically-created-basics.html
fast/css/pseudo-invalid-form-invalidation-optimization.html
fast/css/pseudo-valid-form-and-fieldset-basics.html
fast/css/pseudo-valid-form-basics.html
fast/css/pseudo-valid-form-dynamically-created-basics.html
fast/css/pseudo-valid-form-invalidation-optimization.html
fast/selectors/invalid-form-style-update-1.html
fast/selectors/invalid-form-style-update-2.html
fast/selectors/invalid-form-style-update-3.html
fast/selectors/valid-form-style-update-1.html
fast/selectors/valid-form-style-update-2.html
fast/selectors/valid-form-style-update-3.html

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::canShareStyleWithControl):
(WebCore::StyleResolver::canShareStyleWithElement):
HTMLFormElement is not a FormControl, we have to generalize the test
for :valid/:invalid with style sharing.

  • html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElement::~HTMLFormControlElement):
Since we now have willChangeForm(), didChangeForm(), we have to null
the form ourself, as documented by FormAssociatedElement.

(WebCore::HTMLFormControlElement::setNeedsWillValidateCheck):
(WebCore::HTMLFormControlElement::willChangeForm):
(WebCore::HTMLFormControlElement::didChangeForm):
(WebCore::HTMLFormControlElement::updateValidity):
Update the owner form when any of the associated form element changes
to invalid.

  • html/HTMLFormControlElement.h:
  • html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::registerInvalidAssociatedFormControl):
(WebCore::HTMLFormElement::removeInvalidAssociatedFormControlIfNeeded):
(WebCore::HTMLFormElement::matchesValidPseudoClass):
(WebCore::HTMLFormElement::matchesInvalidPseudoClass):
This is very similar to the code of fieldset, but we have much weaker
invariants due to the insane way FormAssociatedElement initializes.

  • html/HTMLFormElement.h:
  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::initializeInputType):
For completeness, we should always validate when changing the type.
The code was only doing that when the element was inserted into the tree,
that was too fragile.

LayoutTests:

The style update tests are largely based on the fieldset test suite.
The other tests are for various aspects of the patch.

  • fast/css/pseudo-invalid-form-and-fieldset-basics-expected.html: Added.
  • fast/css/pseudo-invalid-form-and-fieldset-basics.html: Added.
  • fast/css/pseudo-invalid-form-basics-expected.html: Added.
  • fast/css/pseudo-invalid-form-basics.html: Added.
  • fast/css/pseudo-invalid-form-dynamically-created-basics-expected.html: Added.
  • fast/css/pseudo-invalid-form-dynamically-created-basics.html: Added.
  • fast/css/pseudo-invalid-form-invalidation-optimization-expected.txt: Added.
  • fast/css/pseudo-invalid-form-invalidation-optimization.html: Added.
  • fast/css/pseudo-valid-form-and-fieldset-basics-expected.html: Added.
  • fast/css/pseudo-valid-form-and-fieldset-basics.html: Added.
  • fast/css/pseudo-valid-form-basics-expected.html: Added.
  • fast/css/pseudo-valid-form-basics.html: Added.
  • fast/css/pseudo-valid-form-dynamically-created-basics-expected.html: Added.
  • fast/css/pseudo-valid-form-dynamically-created-basics.html: Added.
  • fast/css/pseudo-valid-form-invalidation-optimization-expected.txt: Added.
  • fast/css/pseudo-valid-form-invalidation-optimization.html: Added.
  • fast/selectors/invalid-form-style-update-1-expected.txt: Added.
  • fast/selectors/invalid-form-style-update-1.html: Added.
  • fast/selectors/invalid-form-style-update-2-expected.txt: Added.
  • fast/selectors/invalid-form-style-update-2.html: Added.
  • fast/selectors/invalid-form-style-update-3-expected.txt: Added.
  • fast/selectors/invalid-form-style-update-3.html: Added.
  • fast/selectors/valid-form-style-update-1-expected.txt: Added.
  • fast/selectors/valid-form-style-update-1.html: Added.
  • fast/selectors/valid-form-style-update-2-expected.txt: Added.
  • fast/selectors/valid-form-style-update-2.html: Added.
  • fast/selectors/valid-form-style-update-3-expected.txt: Added.
  • fast/selectors/valid-form-style-update-3.html: Added.
4:02 PM Changeset in webkit [177663] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Try to fix the Windows build.

  • dom/DOMAllInOne.cpp:
3:56 PM Changeset in webkit [177662] by andersca@apple.com
  • 7 edits
    2 copies in trunk/Source/WebKit2

Add an API::PageGroupHandle object
​https://bugs.webkit.org/show_bug.cgi?id=139881

Reviewed by Sam Weinig.

API::PageGroupHandle won't be exposed to any API, it will only be used to facilitate passing page groups
between the UI and web process inside UserData objects.

  • Shared/API/APIObject.h:
  • Shared/API/APIPageGroupHandle.cpp: Added.

(API::PageGroupHandle::create):
(API::PageGroupHandle::~PageGroupHandle):
(API::PageGroupHandle::PageGroupHandle):

  • Shared/API/APIPageGroupHandle.h: Added.

(API::PageGroupHandle::webPageGroupData):

  • Shared/UserData.cpp:

(WebKit::UserData::UserData):
(WebKit::UserData::encode):
(WebKit::UserData::decode):

  • Shared/UserData.h:
  • UIProcess/WebPageGroup.h:

(WebKit::WebPageGroup::data):

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::apiObjectByConvertingToHandles):

  • WebKit2.xcodeproj/project.pbxproj:
3:42 PM Changeset in webkit [177661] by andersca@apple.com
  • 16 edits
    2 adds in trunk/Source/WebCore

Add a SecurityOriginPolicy class
​https://bugs.webkit.org/show_bug.cgi?id=139875

Reviewed by Sam Weinig.

This is the first step towards making SecurityOrigin immutable. SecurityOriginPolicy will hold a
SecurityOrigin and will handle things that would otherwise mutate SecurityOrigin.

  • CMakeLists.txt:
  • WebCore.exp.in:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/DOMImplementation.cpp:

(WebCore::DOMImplementation::createDocument):
(WebCore::DOMImplementation::createHTMLDocument):

  • dom/Document.cpp:

(WebCore::Document::create):
(WebCore::Document::open):
(WebCore::Document::cloneDataFromDocument):
(WebCore::Document::initSecurityContext):

  • dom/ScriptExecutionContext.h:
  • dom/SecurityContext.cpp:

(WebCore::SecurityContext::setSecurityOriginPolicy):
(WebCore::SecurityContext::securityOrigin):
(WebCore::SecurityContext::isSecureTransitionTo):
(WebCore::SecurityContext::enforceSandboxFlags):
(WebCore::SecurityContext::setSecurityOrigin): Deleted.

  • dom/SecurityContext.h:

(WebCore::SecurityContext::securityOriginPolicy):
(WebCore::SecurityContext::securityOrigin): Deleted.

  • dom/SecurityOriginPolicy.cpp: Added.

(WebCore::SecurityOriginPolicy::create):
(WebCore::SecurityOriginPolicy::SecurityOriginPolicy):
(WebCore::SecurityOriginPolicy::~SecurityOriginPolicy):

  • dom/SecurityOriginPolicy.h: Added.

(WebCore::SecurityOriginPolicy::origin):

  • loader/DocumentWriter.cpp:

(WebCore::DocumentWriter::begin):

  • workers/WorkerGlobalScope.cpp:

(WebCore::WorkerGlobalScope::WorkerGlobalScope):

  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::responseXML):

  • xml/XMLTreeViewer.cpp:

(WebCore::XMLTreeViewer::transformDocumentToTreeView):

  • xml/XSLTProcessor.cpp:

(WebCore::XSLTProcessor::createDocumentFromSource):

3:30 PM Changeset in webkit [177660] by ap@apple.com
  • 2 edits in trunk/LayoutTests

compositing/rtl/rtl-fixed-overflow-scrolled.html had a 1600x1200 expected PNG
accidentally checked in, let's land 800x600 again.

  • platform/mac/compositing/rtl/rtl-fixed-overflow-scrolled-expected.png:
3:27 PM Changeset in webkit [177659] by Simon Fraser
  • 2 edits in trunk/Tools

Sort the Xcode project file.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3:18 PM Changeset in webkit [177658] by Alan Bujtas
  • 4 edits
    6 adds in trunk

Incorrect dashed and dotted border painting.
​https://bugs.webkit.org/show_bug.cgi?id=139872
rdar://problem/18024205

Reviewed by Simon Fraser.

This patch makes dashed/dotted border painting symmetric and consistent.
It also works with subpixel positioning.

Source/WebCore:

Tests: fast/borders/border-painting-correctness-dashed.html

fast/borders/border-painting-correctness-dotted.html

  • platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::GraphicsContext::drawLine):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::drawLineForBoxSide):

LayoutTests:

  • fast/borders/border-painting-correctness-dashed-expected.html: Added.
  • fast/borders/border-painting-correctness-dashed.html: Added.
  • fast/borders/border-painting-correctness-dotted-expected.html: Added.
  • fast/borders/border-painting-correctness-dotted.html: Added.
  • fast/borders/resources/border-painting-correctness-dashed-expected.png: Added.
  • fast/borders/resources/border-painting-correctness-dotted-expected.png: Added.
3:09 PM Changeset in webkit [177657] by mark.lam@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Assert that Array elements not copied when changing shape to ArrayStorage type are indeed holes.
<​https://webkit.org/b/138118>

Reviewed by Michael Saboff.

  • runtime/JSObject.cpp:

(JSC::JSObject::convertInt32ToArrayStorage):
(JSC::JSObject::convertDoubleToArrayStorage):
(JSC::JSObject::convertContiguousToArrayStorage):

2:17 PM Changeset in webkit [177656] by timothy_horton@apple.com
  • 4 edits in trunk/Source/WebCore

TextIndicatorWindow is larger than it needs to be, especially when not bouncing
​https://bugs.webkit.org/show_bug.cgi?id=139876
<rdar://problem/19311017>

Reviewed by Sam Weinig.

  • page/TextIndicator.cpp:

(WebCore::TextIndicator::wantsBounce):
(WebCore::TextIndicator::wantsContentCrossfade):
(WebCore::TextIndicator::wantsFadeIn):

  • page/TextIndicator.h:
  • page/mac/TextIndicatorWindow.mm:

(-[WebTextIndicatorView initWithFrame:textIndicator:margin:]):
(-[WebTextIndicatorView _animationDuration]):
(-[WebTextIndicatorView present]):
(WebCore::TextIndicatorWindow::setTextIndicator):
(-[WebTextIndicatorView _textIndicatorWantsBounce]): Deleted.
(-[WebTextIndicatorView _textIndicatorWantsContentCrossfade]): Deleted.
(-[WebTextIndicatorView _textIndicatorWantsFadeIn]): Deleted.
Move the various switches over TextIndicatorPresentationTransition into TextIndicator.
Adjust the margin; only inflate by the shadow if we're not bouncing.
If we are bouncing, fix the math to more tightly fit the bounce.
Previously we were inflating by way too much, and even when we didn't need to.

1:45 PM Changeset in webkit [177655] by Lucas Forschler
  • 2 edits in trunk/Tools

Update apple-mac-114 to bot629.

Unreviewed.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
1:37 PM Changeset in webkit [177654] by Lucas Forschler
  • 2 edits in trunk/Tools

Replace Apple bot104 with bot124.

Unreviewed.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
1:20 PM Changeset in webkit [177653] by ap@apple.com
  • 2 edits in trunk/LayoutTests

REGRESSION: fast/xmlhttprequest/xmlhttprequest-recursive-sync-event.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=139840

1:12 PM Changeset in webkit [177652] by dbates@webkit.org
  • 2 edits in trunk/Source/WebKit2

Fix the iOS build after <​https://trac.webkit.org/changeset/177639>
(​https://bugs.webkit.org/show_bug.cgi?id=139866)

Substitute APISecurityOrigin.h for WebSecurityOrigin.h as the latter was renamed to the former.

  • UIProcess/ios/WKGeolocationProviderIOS.mm:
12:55 PM Changeset in webkit [177651] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebKit2

URTBF after r177649.

  • CMakeLists.txt:
12:48 PM Changeset in webkit [177650] by Csaba Osztrogonác
  • 7 edits in trunk/Source/WebKit2

Last URTBF after r177639, GTK builds now.

  • UIProcess/API/gtk/WebKitJavascriptResult.cpp:
  • UIProcess/API/gtk/WebKitUIClient.cpp:
  • UIProcess/API/gtk/WebKitUserContentManager.cpp:
  • UIProcess/API/gtk/WebKitUserMediaPermissionRequest.cpp:

(webkitUserMediaPermissionRequestCreate):

  • UIProcess/API/gtk/WebKitUserMediaPermissionRequestPrivate.h:
  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkitWebViewRunJavaScriptCallback):
(webkit_web_view_run_javascript):
(resourcesStreamReadCallback):

12:39 PM Changeset in webkit [177649] by andersca@apple.com
  • 2 edits
    22 moves in trunk/Source/WebKit2

Move more API classes from Shared to Shared/API.

Rubber-stamped by Sam Weinig.

  • Shared/API/APIArray.cpp: Renamed from Source/WebKit2/Shared/APIArray.cpp.
  • Shared/API/APIArray.h: Renamed from Source/WebKit2/Shared/APIArray.h.
  • Shared/API/APIClient.h: Renamed from Source/WebKit2/Shared/APIClient.h.
  • Shared/API/APIData.cpp: Renamed from Source/WebKit2/Shared/APIData.cpp.
  • Shared/API/APIData.h: Renamed from Source/WebKit2/Shared/APIData.h.
  • Shared/API/APIError.cpp: Renamed from Source/WebKit2/Shared/APIError.cpp.
  • Shared/API/APIError.h: Renamed from Source/WebKit2/Shared/APIError.h.
  • Shared/API/APIFrameHandle.cpp: Renamed from Source/WebKit2/Shared/APIFrameHandle.cpp.
  • Shared/API/APIFrameHandle.h: Renamed from Source/WebKit2/Shared/APIFrameHandle.h.
  • Shared/API/APIGeometry.cpp: Renamed from Source/WebKit2/Shared/APIGeometry.cpp.
  • Shared/API/APIGeometry.h: Renamed from Source/WebKit2/Shared/APIGeometry.h.
  • Shared/API/APINumber.h: Renamed from Source/WebKit2/Shared/APINumber.h.
  • Shared/API/APIObject.cpp: Renamed from Source/WebKit2/Shared/APIObject.cpp.
  • Shared/API/APIObject.h: Renamed from Source/WebKit2/Shared/APIObject.h.
  • Shared/API/APIPageHandle.cpp: Renamed from Source/WebKit2/Shared/APIPageHandle.cpp.
  • Shared/API/APIPageHandle.h: Renamed from Source/WebKit2/Shared/APIPageHandle.h.
  • Shared/API/APIString.h: Renamed from Source/WebKit2/Shared/APIString.h.
  • Shared/API/APIURL.h: Renamed from Source/WebKit2/Shared/APIURL.h.
  • Shared/API/APIURLRequest.cpp: Renamed from Source/WebKit2/Shared/APIURLRequest.cpp.
  • Shared/API/APIURLRequest.h: Renamed from Source/WebKit2/Shared/APIURLRequest.h.
  • Shared/API/APIURLResponse.cpp: Renamed from Source/WebKit2/Shared/APIURLResponse.cpp.
  • Shared/API/APIURLResponse.h: Renamed from Source/WebKit2/Shared/APIURLResponse.h.
12:13 PM Changeset in webkit [177648] by ap@apple.com
  • 2 edits in trunk/LayoutTests

Update some inspector test expectations for the new timeout detection.
Also, unmarked some tests that appear stable on bots now.

  • platform/mac/TestExpectations:
12:13 PM Changeset in webkit [177647] by Chris Dumez
  • 6 edits in trunk/Source/WebCore

[iOS] Log using FeatureCounter when a PacheCache entry is not reused because it expired
​https://bugs.webkit.org/show_bug.cgi?id=139869
<rdar://problem/19255690>

Reviewed by Darin Adler.

Log using FeatureCounter when a PacheCache entry is not reused because
it expired.

  • history/PageCache.cpp:

(WebCore::PageCache::take):
(WebCore::PageCache::get):

  • history/PageCache.h:
  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::commitProvisionalLoad):
(WebCore::FrameLoader::loadDifferentDocumentItem):

  • loader/HistoryController.cpp:

(WebCore::HistoryController::invalidateCurrentItemCachedPage):

  • platform/FeatureCounterKeys.h:
12:13 PM Changeset in webkit [177646] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebKit2

One more URTBF after r177639 to try to make GTK happy.

  • UIProcess/API/gtk/WebKitUserContentManager.cpp:
12:10 PM Changeset in webkit [177645] by bshafiei@apple.com
  • 2 edits in branches/safari-600.1.4.13-branch/Source/WebKit2

Merged r177463. rdar://problem/19327421

12:08 PM Changeset in webkit [177644] by bshafiei@apple.com
  • 2 edits in branches/safari-600.1.4.13-branch/Source/WebKit2

Merged r173973. rdar://problem/19327404

12:08 PM Changeset in webkit [177643] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebKit2

URTBF after r177639 to try to make GTK happy.

  • UIProcess/API/gtk/WebKitJavascriptResult.cpp:
12:05 PM Changeset in webkit [177642] by Antti Koivisto
  • 2 edits in trunk/Source/WebCore

Try to fix the windows build.

  • platform/graphics/win/SimpleFontDataCGWin.cpp:
11:56 AM Changeset in webkit [177641] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebCore

Adjust TextIndicator shadow parameters
​https://bugs.webkit.org/show_bug.cgi?id=139871
<rdar://problem/19283300>

Reviewed by Sam Weinig.

  • page/mac/TextIndicatorWindow.mm:

(-[WebTextIndicatorView initWithFrame:textIndicator:margin:]):
Slightly adjust the shadow and bounce size.

11:47 AM Changeset in webkit [177640] by Csaba Osztrogonác
  • 2 edits in trunk/Tools

URTBF after r177639.

  • TestWebKitAPI/CMakeLists.txt:
11:27 AM Changeset in webkit [177639] by andersca@apple.com
  • 47 edits
    3 moves in trunk/Source/WebKit2

Rename a bunch of API classes and move them to Shared/API
​https://bugs.webkit.org/show_bug.cgi?id=139866

Reviewed by Sam Weinig.

  • Shared/API/APISecurityOrigin.h: Renamed from Source/WebKit2/Shared/WebSecurityOrigin.h.

(API::SecurityOrigin::createFromString):
(API::SecurityOrigin::create):
(API::SecurityOrigin::securityOrigin):
(API::SecurityOrigin::SecurityOrigin):

  • Shared/API/APISerializedScriptValue.h: Renamed from Source/WebKit2/Shared/WebSerializedScriptValue.h.

(API::SerializedScriptValue::create):
(API::SerializedScriptValue::adopt):
(API::SerializedScriptValue::deserialize):
(API::SerializedScriptValue::dataReference):
(API::SerializedScriptValue::internalRepresentation):
(API::SerializedScriptValue::SerializedScriptValue):

  • Shared/API/APIUserContentURLPattern.h: Renamed from Source/WebKit2/Shared/WebUserContentURLPattern.h.

(API::UserContentURLPattern::create):
(API::UserContentURLPattern::host):
(API::UserContentURLPattern::scheme):
(API::UserContentURLPattern::isValid):
(API::UserContentURLPattern::matchesURL):
(API::UserContentURLPattern::matchesSubdomains):
(API::UserContentURLPattern::patternString):
(API::UserContentURLPattern::UserContentURLPattern):

  • Shared/API/c/WKSecurityOrigin.cpp:

(WKSecurityOriginGetTypeID):
(WKSecurityOriginCreateFromString):
(WKSecurityOriginCreateFromDatabaseIdentifier):
(WKSecurityOriginCreate):

  • Shared/API/c/WKSerializedScriptValue.cpp:

(WKSerializedScriptValueGetTypeID):
(WKSerializedScriptValueCreate):
(WKSerializedScriptValueCreateWithInternalRepresentation):

  • Shared/API/c/WKSharedAPICast.h:

(WebKit::toCopiedAPI):

  • Shared/API/c/WKUserContentURLPattern.cpp:

(WKUserContentURLPatternGetTypeID):
(WKUserContentURLPatternCreate):

  • Shared/SecurityOriginData.cpp:

(WebKit::performAPICallbackWithSecurityOriginDataVector):

  • Shared/UserData.cpp:

(WebKit::UserData::encode):
(WebKit::UserData::decode):

  • Shared/UserMessageCoders.h:

(WebKit::UserMessageEncoder::baseEncode):
(WebKit::UserMessageDecoder::baseDecode):

  • UIProcess/API/APIUIClient.h:

(API::UIClient::exceededDatabaseQuota):
(API::UIClient::decidePolicyForGeolocationPermissionRequest):
(API::UIClient::decidePolicyForUserMediaPermissionRequest):
(API::UIClient::decidePolicyForNotificationPermissionRequest):

  • UIProcess/API/C/WKNotification.cpp:
  • UIProcess/API/C/WKPage.cpp:

(WKPageSetPageUIClient):

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView evaluateJavaScript:completionHandler:]):

  • UIProcess/Cocoa/UIDelegate.h:
  • UIProcess/Cocoa/UIDelegate.mm:

(WebKit::UIDelegate::UIClient::exceededDatabaseQuota):

  • UIProcess/GenericCallback.h:
  • UIProcess/Notifications/WebNotification.cpp:

(WebKit::WebNotification::WebNotification):

  • UIProcess/Notifications/WebNotification.h:

(WebKit::WebNotification::origin):

  • UIProcess/Notifications/WebNotificationManagerProxy.cpp:

(WebKit::WebNotificationManagerProxy::providerDidUpdateNotificationPolicy):
(WebKit::WebNotificationManagerProxy::providerDidRemoveNotificationPolicies):

  • UIProcess/Notifications/WebNotificationManagerProxy.h:
  • UIProcess/Notifications/WebNotificationProvider.cpp:
  • UIProcess/Notifications/WebNotificationProvider.h:
  • UIProcess/PageClient.h:

(WebKit::PageClient::decidePolicyForGeolocationPermissionRequest):

  • UIProcess/WebApplicationCacheManagerProxy.cpp:

(WebKit::WebApplicationCacheManagerProxy::deleteEntriesForOrigin):

  • UIProcess/WebApplicationCacheManagerProxy.h:
  • UIProcess/WebCookieManagerProxy.cpp:
  • UIProcess/WebDatabaseManagerProxy.cpp:

(WebKit::WebDatabaseManagerProxy::didGetDatabasesByOrigin):
(WebKit::WebDatabaseManagerProxy::didGetDatabaseOrigins):
(WebKit::WebDatabaseManagerProxy::deleteDatabaseWithNameForOrigin):
(WebKit::WebDatabaseManagerProxy::deleteDatabasesForOrigin):
(WebKit::WebDatabaseManagerProxy::setQuotaForOrigin):
(WebKit::WebDatabaseManagerProxy::didModifyOrigin):
(WebKit::WebDatabaseManagerProxy::didModifyDatabase):

  • UIProcess/WebDatabaseManagerProxy.h:
  • UIProcess/WebDatabaseManagerProxyClient.cpp:

(WebKit::WebDatabaseManagerProxyClient::didModifyOrigin):
(WebKit::WebDatabaseManagerProxyClient::didModifyDatabase):

  • UIProcess/WebDatabaseManagerProxyClient.h:
  • UIProcess/WebKeyValueStorageManager.cpp:

(WebKit::WebKeyValueStorageManager::getKeyValueStorageOrigins):
(WebKit::WebKeyValueStorageManager::getStorageDetailsByOrigin):
(WebKit::WebKeyValueStorageManager::deleteEntriesForOrigin):

  • UIProcess/WebKeyValueStorageManager.h:
  • UIProcess/WebMediaCacheManagerProxy.cpp:
  • UIProcess/WebOriginDataManagerProxy.cpp:

(WebKit::WebOriginDataManagerProxy::didGetOrigins):
(WebKit::WebOriginDataManagerProxy::deleteEntriesForOrigin):

  • UIProcess/WebOriginDataManagerProxy.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::runJavaScriptInMainFrame):
(WebKit::WebPageProxy::scriptValueCallback):
(WebKit::WebPageProxy::exceededDatabaseQuota):
(WebKit::WebPageProxy::requestGeolocationPermissionForFrame):
(WebKit::WebPageProxy::requestUserMediaPermissionForFrame):
(WebKit::WebPageProxy::requestNotificationPermission):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebResourceCacheManagerProxy.cpp:

(WebKit::WebResourceCacheManagerProxy::clearCacheForOrigin):

  • UIProcess/WebResourceCacheManagerProxy.h:
  • UIProcess/ios/PageClientImplIOS.h:
  • UIProcess/ios/PageClientImplIOS.mm:

(WebKit::PageClientImpl::decidePolicyForGeolocationPermissionRequest):

  • UIProcess/ios/WKContentView.h:
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/InjectedBundle/API/APIInjectedBundlePageUIClient.h:

(API::InjectedBundle::PageUIClient::didReachApplicationCacheOriginQuota):
(API::InjectedBundle::PageUIClient::didExceedDatabaseQuota):

  • WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
  • WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp:

(WebKit::InjectedBundlePageUIClient::didReachApplicationCacheOriginQuota):
(WebKit::InjectedBundlePageUIClient::didExceedDatabaseQuota):

  • WebProcess/InjectedBundle/InjectedBundlePageUIClient.h:
  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::exceededDatabaseQuota):
(WebKit::WebChromeClient::reachedApplicationCacheOriginQuota):

11:21 AM Changeset in webkit [177638] by Chris Dumez
  • 3 edits in trunk/Source/WebCore

Consistently use "FeatureCounter*Key" naming for FeatureCounter keys
​https://bugs.webkit.org/show_bug.cgi?id=139867

Reviewed by Darin Adler.

Consistently use "FeatureCounter*Key" naming for FeatureCounter keys.

  • loader/FrameLoader.cpp:

(WebCore::logNavigationWithFeatureCounter):

  • platform/FeatureCounterKeys.h:
11:14 AM Changeset in webkit [177637] by Antti Koivisto
  • 10 edits in trunk/Source/WebCore

Generic font code should not know about SVG font missing glyph
​https://bugs.webkit.org/show_bug.cgi?id=139864

Reviewed by Andreas Kling and Myles Maxfield.

The defined missing glyph is an SVG font concept and should be handled in SVG code.

  • platform/graphics/FontGlyphs.cpp:

(WebCore::FontGlyphs::glyphDataForSystemFallback):
(WebCore::FontGlyphs::glyphDataForVariant):

Return null glyph instead of the missing glyph (the missing glyph was already a null glyph in all non-svg-font cases).
Use early return style.

  • platform/graphics/FontGlyphs.h:
  • platform/graphics/SegmentedFontData.cpp:
  • platform/graphics/SimpleFontData.cpp:

(WebCore::SimpleFontData::platformGlyphInit):

  • platform/graphics/SimpleFontData.h:

Remove the missingGlyph member.

  • platform/graphics/WidthIterator.cpp:

(WebCore::WidthIterator::advanceInternal):

Explicitly skip over null glyphs. Before they had non-null fontData and would get skipped implicitly.

  • platform/graphics/mac/SimpleFontDataMac.mm:
  • rendering/svg/SVGTextRunRenderingContext.cpp:

(WebCore::missingGlyphForFont):

Get the missing glyph from the SVG font element.

(WebCore::SVGTextRunRenderingContext::glyphDataForCharacter):

Return the missing glyph if the normal lookup didn't produce results.

  • svg/SVGFontData.cpp:

(WebCore::SVGFontData::initializeFontData):

11:04 AM Changeset in webkit [177636] by weinig@apple.com
  • 17 edits
    1 move
    2 deletes in trunk/Source/WebKit2

Allow the WebContext's history client to coexist with WKWebView's history delegate
​https://bugs.webkit.org/show_bug.cgi?id=139857

Reviewed by Anders Carlsson.

  • Renames API::HistoryClient to API::LegacyContextHistoryClient to make it clear what it is for.
  • Re-routes the history client functions from the WebProcessProxy to the WebPageProxy.
  • Add history client functions to API::LoaderClient and implement them for NavigationState's LoaderClient subclass. Removes the need for WKProcessPool to have to setup a history client and forward to the NavigationState.
  • UIProcess/API/APIHistoryClient.h: Removed.
  • UIProcess/API/APILegacyContextHistoryClient.h: Copied from Source/WebKit2/UIProcess/API/APIHistoryClient.h.

(API::LegacyContextHistoryClient::~LegacyContextHistoryClient):
(API::LegacyContextHistoryClient::didNavigateWithNavigationData):
(API::LegacyContextHistoryClient::didPerformClientRedirect):
(API::LegacyContextHistoryClient::didPerformServerRedirect):
(API::LegacyContextHistoryClient::didUpdateHistoryTitle):
(API::LegacyContextHistoryClient::populateVisitedLinks):
(API::HistoryClient::~HistoryClient): Deleted.
(API::HistoryClient::didNavigateWithNavigationData): Deleted.
(API::HistoryClient::didPerformClientRedirect): Deleted.
(API::HistoryClient::didPerformServerRedirect): Deleted.
(API::HistoryClient::didUpdateHistoryTitle): Deleted.
(API::HistoryClient::populateVisitedLinks): Deleted.

  • UIProcess/API/APILoaderClient.h:

(API::LoaderClient::didNavigateWithNavigationData):
(API::LoaderClient::didPerformClientRedirect):
(API::LoaderClient::didPerformServerRedirect):
(API::LoaderClient::didUpdateHistoryTitle):

  • UIProcess/API/C/WKContext.cpp:

(WKContextSetHistoryClient):

  • UIProcess/API/Cocoa/WKProcessPool.mm:

(-[WKProcessPool _initWithConfiguration:]):

  • UIProcess/API/mac/WKView.mm:
  • UIProcess/Cocoa/HistoryClient.h: Removed.
  • UIProcess/Cocoa/HistoryClient.mm: Removed.
  • UIProcess/Cocoa/NavigationState.h:
  • UIProcess/Cocoa/NavigationState.mm:

(WebKit::NavigationState::LoaderClient::didNavigateWithNavigationData):
(WebKit::NavigationState::LoaderClient::didPerformClientRedirect):
(WebKit::NavigationState::LoaderClient::didPerformServerRedirect):
(WebKit::NavigationState::LoaderClient::didUpdateHistoryTitle):
(WebKit::NavigationState::didNavigateWithNavigationData): Deleted.
(WebKit::NavigationState::didPerformClientRedirect): Deleted.
(WebKit::NavigationState::didPerformServerRedirect): Deleted.
(WebKit::NavigationState::didUpdateHistoryTitle): Deleted.

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::WebContext):
(WebKit::WebContext::setHistoryClient):
(WebKit::WebContext::populateVisitedLinks):

  • UIProcess/WebContext.h:

(WebKit::WebContext::historyClient):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didNavigateWithNavigationData):
(WebKit::WebPageProxy::didPerformClientRedirect):
(WebKit::WebPageProxy::didPerformServerRedirect):
(WebKit::WebPageProxy::didUpdateHistoryTitle):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::didNavigateWithNavigationData): Deleted.
(WebKit::WebProcessProxy::didPerformClientRedirect): Deleted.
(WebKit::WebProcessProxy::didPerformServerRedirect): Deleted.
(WebKit::WebProcessProxy::didUpdateHistoryTitle): Deleted.

  • UIProcess/WebProcessProxy.h:
  • UIProcess/WebProcessProxy.messages.in:
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::updateGlobalHistory):
(WebKit::WebFrameLoaderClient::updateGlobalHistoryRedirectLinks):
(WebKit::WebFrameLoaderClient::setTitle):

10:40 AM Changeset in webkit [177635] by ap@apple.com
  • 2 edits in trunk/LayoutTests

Remove a Slow expectation for js/promises-tests/promises-tests-2-3-3.html,
as we now skip the test.

10:15 AM Changeset in webkit [177634] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[GTK] another outdated comment
​https://bugs.webkit.org/show_bug.cgi?id=139863

Patch by Michael Catanzaro <Michael Catanzaro> on 2014-12-22
Reviewed by Darin Adler.

Remove outdated comment. We nowadays block untrusted connections by
default.

  • WebProcess/gtk/WebProcessMainGtk.cpp:
9:39 AM Changeset in webkit [177633] by ap@apple.com
  • 2 edits in trunk/LayoutTests

js/promises-tests/promises-tests-2-3-3.html sometimes crashes under DFG::SpeculativeJIT::compile
​https://bugs.webkit.org/show_bug.cgi?id=139865
rdar://problem/19326058

7:30 AM Changeset in webkit [177632] by g.czajkowski@samsung.com
  • 2 edits in trunk/Tools

[EFL] MiniBrowser steals web view's focus
​https://bugs.webkit.org/show_bug.cgi?id=139482

Reviewed by Gyuyoung Kim.

Although we set focus on ewk_view while MiniBrowser initialization
Ecore steals it in a favor of main window. As a result
focused element on web page is unable to receive events.

  • MiniBrowser/efl/main.c:

(window_create):
Prevent window from stealing web view's focus on start up.

3:31 AM Changeset in webkit [177631] by Manuel Rego Casasnovas
  • 6 edits in trunk/LayoutTests

[CSS Grid Layout] Get rid of legacy WebKitCSSGridLayoutEnabled
​https://bugs.webkit.org/show_bug.cgi?id=139860

Reviewed by Sergio Villar Senin.

Remove the missing bits regarding WebKitCSSGridLayoutEnabled.
Most of it was already removed in r168416.

  • fast/css-grid-layout/grid-item-margin-auto-columns-rows-horizontal-ltr.html:
  • fast/css-grid-layout/grid-item-margin-auto-columns-rows-horizontal-rtl.html:
  • fast/css-grid-layout/grid-item-margin-auto-columns-rows-vertical-ltr.html:
  • fast/css-grid-layout/grid-item-margin-auto-columns-rows-vertical-rtl.html:
  • fast/css-grid-layout/grid-shorthand-get-set.html:
2:38 AM Changeset in webkit [177630] by Chris Dumez
  • 5 edits in trunk/Source/WebCore

Move "Auto" CSS properties to the new StyleBuilder
​https://bugs.webkit.org/show_bug.cgi?id=139858

Reviewed by Antti Koivisto.

Move "Auto" CSS properties from DeprecatedStyleBuilder to the new
StyleBuilder, by adding support in the generator for using hasAutoXXX()
/ setHasAutoXXX() methods on RenderStyle.

No new tests, no web-exposed behavior change.

  • css/CSSPropertyNames.in:
  • css/DeprecatedStyleBuilder.cpp:

(WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder):
(WebCore::ApplyPropertyAuto::setValue): Deleted.
(WebCore::ApplyPropertyAuto::value): Deleted.
(WebCore::ApplyPropertyAuto::hasAuto): Deleted.
(WebCore::ApplyPropertyAuto::setAuto): Deleted.
(WebCore::ApplyPropertyAuto::applyInheritValue): Deleted.
(WebCore::ApplyPropertyAuto::applyInitialValue): Deleted.
(WebCore::ApplyPropertyAuto::applyValue): Deleted.
(WebCore::ApplyPropertyAuto::createHandler): Deleted.

  • css/StyleBuilderCustom.h:

(WebCore::StyleBuilderCustom::applyInitialColumnGap):
(WebCore::StyleBuilderCustom::applyInheritColumnGap):
(WebCore::StyleBuilderCustom::applyValueColumnGap):

  • css/makeprop.pl:

(getNameForMethods):
(getAutoGetter):
(getAutoSetter):
(generateInitialValueSetter):
(generateInheritValueSetter):
(generateValueSetter):

Dec 21, 2014:

6:00 PM Changeset in webkit [177629] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

HTMLSelectElement add() should support adding group of options element (HTMLOptGroupElement).
​https://bugs.webkit.org/show_bug.cgi?id=139806

Patch by Shivakumar JM <​shiva.jm@samsung.com> on 2014-12-21
Reviewed by Darin Adler.

Source/WebCore:

HTMLSelectElement add() should support adding group of options (optgroup) element.

Test: fast/dom/HTMLSelectElement/select-add-optgroup.html

  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::add):

LayoutTests:

  • fast/dom/HTMLSelectElement/select-add-optgroup-expected.txt: Added.
  • fast/dom/HTMLSelectElement/select-add-optgroup.html: Added.
5:52 PM Changeset in webkit [177628] by Chris Dumez
  • 2 edits in trunk/Source/WebCore

Fix missing assertion in r177623.
​https://bugs.webkit.org/show_bug.cgi?id=139334

Reviewed by Darin Adler.

ValueWithCalculation::setCalculation() was meant to include an
"isCalculation()" assertion but I inadvertently omitted the
ASSERT() around the statement.

  • css/CSSParser.h:

(WebCore::CSSParser::ValueWithCalculation::setCalculation):

3:56 PM Changeset in webkit [177627] by rgabor@webkit.org
  • 3 edits
    2 adds in trunk

AX: Hidden aria table crash
​https://bugs.webkit.org/show_bug.cgi?id=139856

Reviewed by Chris Fleizach.

Source/WebCore:

Change axCaption to pointer and check it's value because
AXObjectCache::getOrCreate() can return with nullptr.

Test: accessibility/aria-hidden-crash.html

  • accessibility/AccessibilityTable.cpp:

(WebCore::AccessibilityTable::addChildren):

LayoutTests:

Add layout test to cover this crash.

  • accessibility/aria-hidden-crash-expected.txt: Added.
  • accessibility/aria-hidden-crash.html: Added.
2:11 PM Changeset in webkit [177626] by ap@apple.com
  • 2 edits in trunk/LayoutTests

Update expectations for two WebGL tests to match what bots see.

  • platform/mac/TestExpectations:
9:01 AM Changeset in webkit [177625] by eric.carlson@apple.com
  • 2 edits in trunk/Source/WebKit2

[iOS] avoid WebVideoFullscreenManager crash
​https://bugs.webkit.org/show_bug.cgi?id=139852
<rdar://problem/19319302>

Reviewed by Darin Adler.

  • WebProcess/ios/WebVideoFullscreenManager.mm:

(WebKit::WebVideoFullscreenManager::didExitFullscreen): NULL-check m_layerHostingContext and m_page.
(WebKit::WebVideoFullscreenManager::setVideoLayerFrameFenced): NULL-check m_layerHostingContext.

2:49 AM Changeset in webkit [177624] by ddkilzer@apple.com
  • 3 edits in trunk/Source/WebKit2

Fix WebKit2 build with newer clang compiler

Fixes the following build error:

In file included from DerivedSources/WebKit2/WebVideoFullscreenManagerProxyMessageReceiver.cpp:32:
Source/WebKit2/Platform/IPC/HandleMessage.h:16:25: error: non-const lvalue reference to type 'Vector<[3 * ...]>' cannot bind to a temporary of type 'Vector<[3 * ...]>'

(object->*function)(std::get<ArgsIndex>(std::forward<ArgsTuple>(args))...);

~

Source/WebKit2/Platform/IPC/HandleMessage.h:22:5: note: in instantiation of function template specialization 'IPC::callMemberFunctionImpl<WebKit::WebVideoFullscreenManagerProxy, void (WebKit::WebVideoFullscreenManagerProxy::*)(WTF::Vector<std::__1::pair<double, double>, 0, WTF::CrashOnOverflow> &), std::1::tuple<WTF::Vector<std::__1::pair<double, double>, 0, WTF::CrashOnOverflow> >, 0>' requested here

callMemberFunctionImpl(object, function, std::forward<ArgsTuple>(args), ArgsIndicies());

Source/WebKit2/Platform/IPC/HandleMessage.h:120:5: note: in instantiation of function template specialization 'IPC::callMemberFunction<WebKit::WebVideoFullscreenManagerProxy, void (WebKit::WebVideoFullscreenManagerProxy::*)(WTF::Vector<std::__1::pair<double, double>, 0, WTF::CrashOnOverflow> &), std::1::tuple<WTF::Vector<std::__1::pair<double, double>, 0, WTF::CrashOnOverflow> >, std::make_index_sequence<1> >' requested here

callMemberFunction(WTF::move(arguments), object, function);

DerivedSources/WebKit2/WebVideoFullscreenManagerProxyMessageReceiver.cpp:55:14: note: in instantiation of function template specialization 'IPC::handleMessage<Messages::WebVideoFullscreenManagerProxy::SetSeekableRangesVector, WebKit::WebVideoFullscreenManagerProxy, void (WebKit::WebVideoFullscreenManagerProxy::*)(WTF::Vector<std::__1::pair<double, double>, 0, WTF::CrashOnOverflow> &)>' requested here

IPC::handleMessage<Messages::WebVideoFullscreenManagerProxy::SetSeekableRangesVector>(decoder, this, &WebVideoFullscreenManagerProxy::setSeekableRangesVector);


  • UIProcess/ios/WebVideoFullscreenManagerProxy.h:
  • UIProcess/ios/WebVideoFullscreenManagerProxy.mm:

(WebKit::WebVideoFullscreenManagerProxy::setSeekableRangesVector):
Make Vector<std::pair<double, double>>& argument const because a
temporary is not allowed to bind to a non-const reference.

Note: See TracTimeline for information about the timeline view.