Timeline



Dec 23, 2014:

9:34 PM Changeset in webkit [177721] by ChangSeok Oh
  • 19 edits
    2 moves in trunk/Source/WebKit2

[GTK] Build fix after r177692
​https://bugs.webkit.org/show_bug.cgi?id=139919

Reviewed by Gyuyoung Kim.

This change addresses build failures introduced after r177692.

  • PlatformEfl.cmake: Renamed WebContextSoup to WebProcessPoolSoup.cpp
  • PlatformGTK.cmake: ditto.
  • UIProcess/API/gtk/PageClientImpl.cpp:
  • UIProcess/API/gtk/WebKitDownloadClient.cpp:
  • UIProcess/API/gtk/WebKitFormSubmissionRequest.cpp:

(webkitFormSubmissionRequestCreate):
(webkit_form_submission_request_get_text_fields):

  • UIProcess/API/gtk/WebKitFormSubmissionRequestPrivate.h:
  • UIProcess/API/gtk/WebKitInjectedBundleClient.cpp:

(didReceiveWebViewMessageFromInjectedBundle):
(didReceiveMessageFromInjectedBundle):

  • UIProcess/API/gtk/WebKitSecurityManager.cpp:

(registerSecurityPolicyForURIScheme):

  • UIProcess/API/gtk/WebKitWebContext.cpp:

(webkitWebContextConstructed):
(webkit_web_context_prefetch_dns):
(webkitWebContextGetContext):

  • UIProcess/API/gtk/WebKitWebContextPrivate.h:
  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkit_web_view_get_snapshot):

  • UIProcess/API/gtk/WebKitWebViewBase.cpp:

(webkitWebViewBaseCreate):
(webkitWebViewBaseCreateWebPage):

  • UIProcess/API/gtk/WebKitWebViewBasePrivate.h:
  • UIProcess/API/gtk/WebKitWindowProperties.cpp:
  • UIProcess/gtk/WebInspectorProxyGtk.cpp:

(WebKit::WebInspectorProxy::platformCreateInspectorPage):

  • UIProcess/gtk/WebProcessPoolGtk.cpp: Renamed from Source/WebKit2/UIProcess/gtk/WebContextGtk.cpp.

(WebKit::initInspectorServer):
(WebKit::WebProcessPool::platformDefaultApplicationCacheDirectory):
(WebKit::WebProcessPool::platformInitializeWebProcess):
(WebKit::WebProcessPool::platformInvalidateContext):
(WebKit::WebProcessPool::platformDefaultWebSQLDatabaseDirectory):
(WebKit::WebProcessPool::platformDefaultIndexedDBDatabaseDirectory):
(WebKit::WebProcessPool::platformDefaultIconDatabasePath):
(WebKit::WebProcessPool::platformDefaultLocalStorageDirectory):
(WebKit::WebProcessPool::platformDefaultMediaKeysStorageDirectory):
(WebKit::WebProcessPool::platformDefaultDiskCacheDirectory):
(WebKit::WebProcessPool::platformDefaultCookieStorageDirectory):
(WebKit::WebProcessPool::setIgnoreTLSErrors):

  • UIProcess/soup/WebProcessPoolSoup.cpp: Renamed from Source/WebKit2/UIProcess/soup/WebContextSoup.cpp.

(WebKit::WebProcessPool::platformInitializeNetworkProcess):

  • WebProcess/InjectedBundle/API/gtk/WebKitWebExtension.cpp:

(webkitWebExtensionDidReceiveMessage):

  • WebProcess/InjectedBundle/API/gtk/WebKitWebPage.cpp:

(didInitiateLoadForResource):
(willSendRequestForFrame):
(didReceiveResponseForResource):
(didReceiveContentLengthForResource):
(didFinishLoadForResource):
(didFailLoadForResource):
(webkitWebPageDidReceiveMessage):

  • WebProcess/InjectedBundle/API/gtk/WebKitWebPagePrivate.h:
8:58 PM Changeset in webkit [177720] by Chris Dumez
  • 2 edits in trunk/Source/WebCore

Simplify RenderStyle::invalidColor() function
​https://bugs.webkit.org/show_bug.cgi?id=139898

Reviewed by Andreas Kling.

Simplify RenderStyle::invalidColor() function by getting rid of the
static variable. The default constructor for Color is very cheap
anyway.

  • rendering/style/RenderStyle.h:
8:50 PM Changeset in webkit [177719] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit2

iOS build fix

  • UIProcess/API/Cocoa/WKProcessGroup.mm:

(-[WKProcessGroup _geolocationProvider]):

8:43 PM Changeset in webkit [177718] by ap@apple.com
  • 2 edits in trunk/Tools

Don't force -O1 for debug ASan builds
​https://bugs.webkit.org/show_bug.cgi?id=139926

Reviewed by Darin Adler.

  • asan/asan.xcconfig:
8:33 PM Changeset in webkit [177717] by ljaehun.lim@samsung.com
  • 2 edits in trunk/Source/WebCore

Unreviewed, fix build warning after r177712

../../Source/WebCore/history/PageCache.cpp: In function ‘const char* WebCore::pruningReasonToFeatureCounterKey(WebCore::PruningReason)’:
../../Source/WebCore/history/PageCache.cpp:449:1: error: control reaches end of non-void function [-Werror=return-type]

No new tests, no behavior changes.

  • history/PageCache.cpp:

(WebCore::pruningReasonToFeatureCounterKey):

8:09 PM Changeset in webkit [177716] by gyuyoung.kim@samsung.com
  • 22 edits in trunk/Source/WebKit2

[EFL][WK2] Fix a lot of build break since r177692
​https://bugs.webkit.org/show_bug.cgi?id=139932

Unreviewed EFL build fix.

Rename WebContext with WebProcessPool in EFL port files.

  • CMakeLists.txt:
  • UIProcess/API/efl/EwkView.cpp:
  • UIProcess/API/efl/ewk_context.cpp:
  • UIProcess/API/efl/tests/test_ewk2_context.cpp:

(TEST_F):

  • UIProcess/CoordinatedGraphics/WebView.cpp:

(WebKit::WebView::WebView):

  • UIProcess/CoordinatedGraphics/WebView.h:
  • UIProcess/Network/CustomProtocols/soup/CustomProtocolManagerProxySoup.cpp:

(WebKit::CustomProtocolManagerProxy::CustomProtocolManagerProxy):
(WebKit::CustomProtocolManagerProxy::startLoading):
(WebKit::CustomProtocolManagerProxy::stopLoading):

  • UIProcess/Network/CustomProtocols/soup/WebSoupCustomProtocolRequestManager.cpp:

(WebKit::WebSoupCustomProtocolRequestManager::create):
(WebKit::WebSoupCustomProtocolRequestManager::WebSoupCustomProtocolRequestManager):
(WebKit::WebSoupCustomProtocolRequestManager::registerSchemeForCustomProtocol):
(WebKit::WebSoupCustomProtocolRequestManager::unregisterSchemeForCustomProtocol):
(WebKit::WebSoupCustomProtocolRequestManager::didReceiveResponse):
(WebKit::WebSoupCustomProtocolRequestManager::didLoadData):
(WebKit::WebSoupCustomProtocolRequestManager::didFailWithError):
(WebKit::WebSoupCustomProtocolRequestManager::didFinishLoading):

  • UIProcess/Network/CustomProtocols/soup/WebSoupCustomProtocolRequestManager.h:
  • UIProcess/WebBatteryManagerProxy.cpp:

(WebKit::WebBatteryManagerProxy::create):
(WebKit::WebBatteryManagerProxy::WebBatteryManagerProxy):
(WebKit::WebBatteryManagerProxy::providerDidChangeBatteryStatus):
(WebKit::WebBatteryManagerProxy::providerUpdateBatteryStatus):

  • UIProcess/WebBatteryManagerProxy.h:
  • UIProcess/WebTextChecker.cpp:

(WebKit::updateStateForAllContexts):

  • UIProcess/WebVibrationProxy.cpp:

(WebKit::WebVibrationProxy::WebVibrationProxy):
(WebKit::WebVibrationProxy::~WebVibrationProxy):

  • UIProcess/efl/RequestManagerClientEfl.h:
  • UIProcess/efl/WebContextEfl.cpp:

(WebKit::WebProcessPool::platformDefaultApplicationCacheDirectory):
(WebKit::WebProcessPool::platformInitializeWebProcess):
(WebKit::WebProcessPool::platformInvalidateContext):
(WebKit::WebProcessPool::platformDefaultWebSQLDatabaseDirectory):
(WebKit::WebProcessPool::platformDefaultIndexedDBDatabaseDirectory):
(WebKit::WebProcessPool::platformDefaultIconDatabasePath):
(WebKit::WebProcessPool::platformDefaultLocalStorageDirectory):
(WebKit::WebProcessPool::platformDefaultMediaKeysStorageDirectory):
(WebKit::WebProcessPool::platformDefaultDiskCacheDirectory):
(WebKit::WebProcessPool::platformDefaultCookieStorageDirectory):
(WebKit::WebProcessPool::setIgnoreTLSErrors):
(WebKit::WebContext::platformDefaultApplicationCacheDirectory): Deleted.
(WebKit::WebContext::platformInitializeWebProcess): Deleted.
(WebKit::WebContext::platformInvalidateContext): Deleted.
(WebKit::WebContext::platformDefaultWebSQLDatabaseDirectory): Deleted.
(WebKit::WebContext::platformDefaultIndexedDBDatabaseDirectory): Deleted.
(WebKit::WebContext::platformDefaultIconDatabasePath): Deleted.
(WebKit::WebContext::platformDefaultLocalStorageDirectory): Deleted.
(WebKit::WebContext::platformDefaultMediaKeysStorageDirectory): Deleted.
(WebKit::WebContext::platformDefaultDiskCacheDirectory): Deleted.
(WebKit::WebContext::platformDefaultCookieStorageDirectory): Deleted.
(WebKit::WebContext::setIgnoreTLSErrors): Deleted.

  • UIProcess/efl/WebInspectorProxyEfl.cpp:

(WebKit::WebInspectorProxy::platformCreateInspectorPage):

  • UIProcess/efl/WebViewEfl.cpp:

(WebKit::WebView::create):
(WebKit::WebViewEfl::WebViewEfl):

  • UIProcess/efl/WebViewEfl.h:
  • UIProcess/soup/WebContextSoup.cpp:

(WebKit::WebProcessPool::platformInitializeNetworkProcess):
(WebKit::WebContext::platformInitializeNetworkProcess): Deleted.

  • UIProcess/soup/WebCookieManagerProxySoup.cpp:

(WebKit::WebCookieManagerProxy::setCookiePersistentStorage):

  • UIProcess/soup/WebSoupRequestManagerProxy.h:
7:09 PM Changeset in webkit [177715] by weinig@apple.com
  • 4 edits in trunk/Source/WebKit2

Remove telephone number context support from ContextMenuContextData, it is unused
​https://bugs.webkit.org/show_bug.cgi?id=139931

Reviewed by Alexey Proskuryakov.

m_isTelephoneNumberContext was only ever set to true in the ContextMenuContextData
constructor that took a TelephoneNumberContextTag, which never got called. Remove it
all.

  • Shared/ContextMenuContextData.cpp:

(WebKit::ContextMenuContextData::ContextMenuContextData):
(WebKit::ContextMenuContextData::encode):
(WebKit::ContextMenuContextData::decode):

  • Shared/ContextMenuContextData.h:

(WebKit::ContextMenuContextData::ContextMenuContextData):
(WebKit::ContextMenuContextData::isTelephoneNumberContext): Deleted.

  • UIProcess/mac/WebContextMenuProxyMac.mm:

(WebKit::WebContextMenuProxyMac::showContextMenu):

6:51 PM Changeset in webkit [177714] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

Attempt to fix the Mountain Lion build.

  • Shared/ContextMenuContextData.h:

(WebKit::ContextMenuContextData::isTelephoneNumberContext):

5:20 PM Changeset in webkit [177713] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

Handle WKTypeRefWrapper when converting object graphs
​https://bugs.webkit.org/show_bug.cgi?id=139927

Reviewed by Tim Horton.

  • UIProcess/Cocoa/WebProcessProxyCocoa.mm:

(WebKit::WebProcessProxy::transformHandlesToObjects):
(WebKit::WebProcessProxy::transformObjectsToHandles):

  • WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::WebProcess::transformHandlesToObjects):
(WebKit::WebProcess::transformObjectsToHandles):

5:14 PM Changeset in webkit [177712] by Chris Dumez
  • 11 edits in trunk/Source

[iOS] Log better using FeatureCounter why PageCache is failing due to pruned resources
​https://bugs.webkit.org/show_bug.cgi?id=139921
<rdar://problem/19255690>

Reviewed by Gavin Barraclough.

Source/WebCore:

Log better using FeatureCounter why PageCache is failing due to pruned
resources. In particular, we now distinguish if the resource was pruned
due to:

  • Memory pressure
  • Page cache capacity reached
  • WebProcess suspended (WK2)
  • WebCore.exp.in:
  • history/HistoryItem.cpp:

(WebCore::HistoryItem::HistoryItem):

  • history/HistoryItem.h:
  • history/PageCache.cpp:

(WebCore::PageCache::pruneToCapacityNow):
(WebCore::PageCache::setCapacity):
(WebCore::pruningReasonToFeatureCounterKey):
(WebCore::PageCache::add):
(WebCore::PageCache::take):
(WebCore::PageCache::get):
(WebCore::PageCache::prune):

  • history/PageCache.h:
  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::commitProvisionalLoad):

  • platform/FeatureCounterKeys.h:
  • platform/MemoryPressureHandler.cpp:

(WebCore::MemoryPressureHandler::releaseCriticalMemory):

Source/WebKit2:

Call PageCache::pruneToCapacityNow() instead of multiple calls to
setCapacity() as it does exactly what we want. Also pass the new
PrunedReason argument so help us do better logging.

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::releasePageCache):

5:11 PM Changeset in webkit [177711] by akling@apple.com
  • 2 edits in trunk/Source/WebCore

[Mac] Fix nullptr dereference in EventHandler::platformPrepareForWheelEvents().
<​https://webkit.org/b/139923>
<rdar://problem/19182531>

Reviewed by Chris Dumez.

Don't dereference 'wheelEventTarget' until we know it's non-null.
This manifested as a crash in Node::renderBox() with some versions of LLVM.

The compiler was free to assume that the ContainerNode* 'candidate' in
findEnclosingScrollableContainer() would always be non-null on the first
iteration of the loop.

I suspect that we can get here with a null 'wheelEventTarget' during the
rubberbanding phase of a wheel scroll; if the cursor is sitting over the
exposed "gutter" area.

  • page/mac/EventHandlerMac.mm:

(WebCore::findEnclosingScrollableContainer):
(WebCore::EventHandler::platformPrepareForWheelEvents):

5:09 PM Changeset in webkit [177710] by weinig@apple.com
  • 3 edits in trunk/Source/WebKit2

Attempt to fix the iOS build.

  • UIProcess/API/Cocoa/WKProcessGroup.mm:

(-[WKProcessGroup _geolocationProvider]):

  • UIProcess/API/ios/WKViewIOS.mm:

(-[WKView _commonInitializationWithContextRef:pageGroupRef:relatedToPage:]):

5:01 PM Changeset in webkit [177709] by andersca@apple.com
  • 6 edits
    1 add in trunk/Source/WebKit2

Handle coding object graphs in the UI process
​https://bugs.webkit.org/show_bug.cgi?id=139925

Reviewed by Sam Weinig.

  • UIProcess/Cocoa/WebProcessProxyCocoa.mm: Added.

(WebKit::WebProcessProxy::transformHandlesToObjects):
(WebKit::WebProcessProxy::transformObjectsToHandles):

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::transformHandlesToObjects):
(WebKit::WebProcessProxy::transformObjectsToHandles):

  • UIProcess/WebProcessProxy.h:
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::transformObjectsToHandles):

  • WebProcess/WebProcess.h:
5:00 PM Changeset in webkit [177708] by weinig@apple.com
  • 5 edits in trunk/Source/WebKit2

ContextMenuContextData should store a ShareableBitmap not a ShareableBitmap::Handle
​https://bugs.webkit.org/show_bug.cgi?id=139924

Reviewed by Anders Carlsson.

Replaces the ShareableBitmap::Handle in ContextMenuContextData with a RefPtr<ShareableBitmap>.
Removes the now unnecessary override copy-constructor and assignment-operator.

  • Shared/ContextMenuContextData.cpp:

(WebKit::ContextMenuContextData::ContextMenuContextData):
(WebKit::ContextMenuContextData::encode):
(WebKit::ContextMenuContextData::decode):
(WebKit::ContextMenuContextData::controlledDataIsEditable):
(WebKit::ContextMenuContextData::operator=): Deleted.

  • Shared/ContextMenuContextData.h:

(WebKit::ContextMenuContextData::ContextMenuContextData):
(WebKit::ContextMenuContextData::controlledImage):
(WebKit::ContextMenuContextData::needsServicesMenu):
(WebKit::ContextMenuContextData::controlledImageHandle): Deleted.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::internalShowContextMenu):

  • UIProcess/mac/WebContextMenuProxyMac.mm:

(WebKit::WebContextMenuProxyMac::setupServicesMenu):

4:46 PM Changeset in webkit [177707] by Chris Dumez
  • 2 edits in trunk/Source/WebKit2

Unreviewed iOS build fix after 177692.

Missing WebKit:: namespace.

  • UIProcess/ios/WKContentView.h:
4:37 PM Changeset in webkit [177706] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix 32-build.

  • WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::WebProcess::transformHandlesToObjects):
(WebKit::WebProcess::transformObjectsToHandles):

4:14 PM Changeset in webkit [177705] by timothy_horton@apple.com
  • 7 edits in trunk/Source

Install a TextIndicator for link immediate actions
​https://bugs.webkit.org/show_bug.cgi?id=139897
<rdar://problem/19333076>

Reviewed by Anders Carlsson.

  • UIProcess/mac/WKImmediateActionController.mm:

(-[WKImmediateActionController _defaultAnimationController]):
Install the link's TextIndicator.

(-[WKImmediateActionController menuItemDidClose:]):
Dismiss the TextIndicator and clean up when the item closes.

  • WebView/WebImmediateActionController.h:
  • WebView/WebImmediateActionController.mm:

(-[WebImmediateActionController _clearImmediateActionState]):
Tear down the TextIndicator, just like WebKit2.

(-[WebImmediateActionController _defaultAnimationController]):
Install a TextIndicator for links.

(-[WebImmediateActionController menuItemDidClose:]):
Tear down the TextIndicator when the QL preview closes.

(-[WebImmediateActionController _menuItemForDataDetectedText]):
Directly install and uninstall the TextIndicator for DataDetectors.

(-[WebImmediateActionController _showTextIndicator]): Deleted.
(-[WebImmediateActionController _hideTextIndicator]): Deleted.
Remove the isShowingTextIndicator mechanism, just like it was removed from WebKit2.

  • platform/spi/mac/QuickLookMacSPI.h:

Add a new piece of SPI.

4:13 PM Changeset in webkit [177704] by timothy_horton@apple.com
  • 3 edits in trunk/Source/WebKit2

Expose ElementBoundingBox on WKHitTestResult
​https://bugs.webkit.org/show_bug.cgi?id=139895
<rdar://problem/19333075>

Reviewed by Dan Bernstein.

  • UIProcess/API/C/WKHitTestResult.cpp:

(WKHitTestResultGetElementBoundingBox):

  • UIProcess/API/C/WKHitTestResult.h:

Expose the rect.

4:13 PM Changeset in webkit [177703] by ap@apple.com
  • 6 edits in trunk

Simplify building with ASan
​https://bugs.webkit.org/show_bug.cgi?id=139916

Reviewed by Mark Rowe.

.:

  • Makefile.shared: Invoke set-webkit-configuration to store ASan choice as appropriate.

Tools:

  • Scripts/set-webkit-configuration: Store ASan state into a new configuration file.

We could also update Configuration file format, but that's a little scary because
of how many places in code read it.

  • Scripts/webkitdirs.pm:

(determineASanIsEnabled): Read it from ASan configuration file.
(argumentsForConfiguration): Added a FIXME.
(asanIsEnabled): A caching wrapper similar to what we have for other configuration options.
(XcodeOptions): Pass the options needed for ASan.

  • asan/asan.xcconfig: Use the right toolchains. Made warnings fatal again, as there

no warnings to avoid. Removed explicit linking options, as -fsanitize=address does
that automatically.

4:13 PM Changeset in webkit [177702] by timothy_horton@apple.com
  • 6 edits
    4 deletes in trunk/Source/WebKit2

Remove the custom web page preview code
​https://bugs.webkit.org/show_bug.cgi?id=139894
<rdar://problem/19333074>

Reviewed by Dan Bernstein.

  • UIProcess/API/Cocoa/WKViewPrivate.h:
  • UIProcess/API/mac/WKView.mm:

(-[WKView _dismissContentRelativeChildWindows]):
(-[WKView _viewForPreviewingURL:initialFrameSize:]): Deleted.
(-[WKView _titleForPreviewOfURL:]): Deleted.
(-[WKView _setPreviewTitle:]): Deleted.
(-[WKView _setPreviewLoading:]): Deleted.
(-[WKView _setPreviewOverrideImage:]): Deleted.
(-[WKView _finishPreviewingURL:withPreviewView:]): Deleted.
(-[WKView _handleClickInPreviewView:URL:]): Deleted.
(-[WKView _shouldUseStandardQuickLookPreview]): Deleted.

  • UIProcess/mac/WKImmediateActionController.h:
  • UIProcess/mac/WKImmediateActionController.mm:

(-[WKImmediateActionController willDestroyView:]):
(-[WKImmediateActionController _clearImmediateActionState]):
(-[WKImmediateActionController immediateActionRecognizerWillPrepare:]):
(-[WKImmediateActionController _defaultAnimationController]):
(-[WKImmediateActionController hidePreview]): Deleted.
(-[WKImmediateActionController setPreviewTitle:]): Deleted.
(-[WKImmediateActionController setPreviewLoading:]): Deleted.
(-[WKImmediateActionController setPreviewOverrideImage:]): Deleted.
(-[WKImmediateActionController _animationControllerForCustomPreview]): Deleted.

  • UIProcess/mac/WKPagePreviewViewController.h: Removed.
  • UIProcess/mac/WKPagePreviewViewController.mm: Removed.
  • UIProcess/mac/WKPreviewPopoverAnimationController.h: Removed.
  • UIProcess/mac/WKPreviewPopoverAnimationController.mm: Removed.
  • WebKit2.xcodeproj/project.pbxproj:

Remove all of the custom web page preview code. Clients that want the custom
preview can implement it by overriding the immediate action.

3:58 PM Changeset in webkit [177701] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

Add WebProcessProxy::transformHandlesToObjects
​https://bugs.webkit.org/show_bug.cgi?id=139922

Reviewed by Tim Horton.

This will be used to convert between the handles and their respective UI side objects.

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::transformHandlesToObjects):
(WebKit::WebProcessProxy::transformObjectsToHandles):
(WebKit::WebProcessProxy::apiObjectByConvertingToHandles): Deleted.

  • UIProcess/WebProcessProxy.h:
3:35 PM Changeset in webkit [177700] by andersca@apple.com
  • 6 edits in trunk/Source/WebKit2

Add handle transform functions to WebConnection
​https://bugs.webkit.org/show_bug.cgi?id=139920

Reviewed by Sam Weinig.

This will be used by the web connection code to convert between objects and their respective handles.

  • Shared/WebConnection.h:
  • UIProcess/WebConnectionToWebProcess.cpp:

(WebKit::WebConnectionToWebProcess::transformHandlesToObjects):
(WebKit::WebConnectionToWebProcess::transformObjectsToHandles):

  • UIProcess/WebConnectionToWebProcess.h:
  • WebProcess/WebConnectionToUIProcess.cpp:

(WebKit::WebConnectionToUIProcess::transformHandlesToObjects):
(WebKit::WebConnectionToUIProcess::transformObjectsToHandles):

  • WebProcess/WebConnectionToUIProcess.h:
3:07 PM Changeset in webkit [177699] by weinig@apple.com
  • 35 edits
    2 moves
    2 deletes in trunk/Source/WebKit2

Rename ImmutableDictionary to API::Dictionary and merge MutableDictionary into it
​https://bugs.webkit.org/show_bug.cgi?id=139917

Reviewed by Anders Carlsson.

  • Renames ImmutableDictionary -> API::Dictionary
  • Merges MutableDictionary into the new API::Dictionary

(as a result WKDictionaryIsMutable() now always returns true)

  • File list elided *
3:06 PM Changeset in webkit [177698] by andersca@apple.com
  • 4 edits in trunk/Source/WebKit2

Add WebProcess::transformObjectsToHandles
​https://bugs.webkit.org/show_bug.cgi?id=139918

Reviewed by Tim Horton.

This function will be used for transforming bundle objects to their respective handle types
when sending messages to the UI process.

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::transformHandlesToObjects):
(WebKit::WebProcess::transformObjectsToHandles):

  • WebProcess/WebProcess.h:
  • WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::WebProcess::transformHandlesToObjects):
(WebKit::WebProcess::transformObjectsToHandles):

2:27 PM Changeset in webkit [177697] by andersca@apple.com
  • 4 edits in trunk/Source

Move dynamic_objc_cast to RetainPtr.h
​https://bugs.webkit.org/show_bug.cgi?id=139915

Reviewed by Sam Weinig.

Source/WebKit2:

  • Shared/mac/ObjCObjectGraph.mm:

(WebKit::dynamic_objc_cast): Deleted.

Source/WTF:

  • wtf/RetainPtr.h:

(WTF::dynamic_objc_cast):

2:16 PM Changeset in webkit [177696] by andersca@apple.com
  • 3 edits in trunk/Source/WTF

Re-indent RefPtr.h and RetainPtr.h.

Rubber-stamped by Sam Weinig.

  • wtf/RefPtr.h:
  • wtf/RetainPtr.h:
2:14 PM Changeset in webkit [177695] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

Add WebProcess::transformHandlesToObjects
​https://bugs.webkit.org/show_bug.cgi?id=139913

Reviewed by Tim Horton.

Rename objectGraphByTransformingObjectsToHandles to transformObjectsToHandles and add
transformHandlesToObjects that will try to convert handles to the actual bundle type objects.

  • WebProcess/WebProcess.h:
  • WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::WebProcess::transformHandlesToObjects):
(WebKit::WebProcess::transformObjectsToHandles):
(WebKit::WebProcess::objectGraphByTransformingObjectsToHandles): Deleted.

1:53 PM Changeset in webkit [177694] by andersca@apple.com
  • 4 edits in trunk/Source/WebKit2

Add WebProcess::objectGraphByTransformingObjectsToHandles
​https://bugs.webkit.org/show_bug.cgi?id=139912

Reviewed by Tim Horton.

This will be used to convert Objective-C object graphs containing bundle types to their handle counterparts.

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::transformHandlesToObjects):
(WebKit::WebProcess::apiObjectByConvertingFromHandles): Deleted.
Rename apiObjectByConvertingFromHandles to transformHandlesToObjects.

  • WebProcess/WebProcess.h:
  • WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::WebProcess::objectGraphByTransformingObjectsToHandles):

12:44 PM Changeset in webkit [177693] by andersca@apple.com
  • 4 edits in trunk/Source/WebKit2

Fix UserMessage::transform to only call shouldTransform once
​https://bugs.webkit.org/show_bug.cgi?id=139911

Reviewed by Sam Weinig.

Also, make it possible for transformers to return null objects and change the transformers
to return the passed in object when there's no need to do a transform.

  • Shared/UserData.cpp:

(WebKit::transformGraph):
(WebKit::UserData::transform):
(WebKit::UserData::encode): Deleted.
(WebKit::UserData::decode): Deleted.

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::apiObjectByConvertingToHandles):

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::apiObjectByConvertingFromHandles):

12:29 PM Changeset in webkit [177692] by weinig@apple.com
  • 107 edits
    6 moves
    1 delete in trunk/Source

Rename WebContext to WebProcessPool
​https://bugs.webkit.org/show_bug.cgi?id=139909

Rubber-stamped by Anders Carlsson.

Source/WebCore:

Merge SessionID and SessionIDHash into one file to make auto-generation of
HashMaps with SessionIDs easier.

  • WebCore.xcodeproj/project.pbxproj:
  • loader/cache/MemoryCache.h:
  • page/SessionID.h:

(WTF::SessionIDHash::hash):
(WTF::SessionIDHash::equal):
(WTF::HashTraits<WebCore::SessionID>::emptyValue):
(WTF::HashTraits<WebCore::SessionID>::constructDeletedValue):
(WTF::HashTraits<WebCore::SessionID>::isDeletedValue):

  • page/SessionIDHash.h: Removed.

Source/WebKit2:

  • Major renames:

WebContext -> WebProcessPool
WebContextConfiguration -> WebProcessPoolConfiguration
API::ContextConfiguration -> API::ProcessPoolConfiguration

  • File list elided *
12:15 PM Changeset in webkit [177691] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

Only call shouldTransformGraph once per graph
​https://bugs.webkit.org/show_bug.cgi?id=139910

Reviewed by Sam Weinig.

Don't call shouldTransformGraph for each node in the object graph. Instead, call it once
and then transform the entire graph if needed.

  • Shared/mac/ObjCObjectGraph.h:
  • Shared/mac/ObjCObjectGraph.mm:

(WebKit::shouldTransformGraph):
(WebKit::transformGraph):
(WebKit::ObjCObjectGraph::transform):
(WebKit::shouldTransform): Deleted.

12:01 PM Changeset in webkit [177690] by ap@apple.com
  • 3 edits in trunk/Tools

TestWebKitAPI build is broken when ASan is enabled
​https://bugs.webkit.org/show_bug.cgi?id=139902

Reviewed by Darin Adler.

  • TestWebKitAPI/Configurations/InjectedBundle.xcconfig:
  • TestWebKitAPI/Configurations/TestWebKitAPILibrary.xcconfig:

Inherit linker flags from DebugRelease, which respects ASAN.

11:23 AM Changeset in webkit [177689] by mmaxfield@apple.com
  • 7 edits in trunk/Source/WebCore

platform/mac/editing/input/devanagari-ligature.html is flaky on Yosemite, ligature fails to form
​https://bugs.webkit.org/show_bug.cgi?id=138683

Reviewed by Darin Adler.

This patch changes how we check fonts for equality. In particular, this patch adds a
objectForEqualityCheck() to Cocoa's FontPlatformData, and callers should pass this object
to CFEqual() to determine if two platform fonts are equal. This patch also migrates all
call sites to using this function.

I don't want to implement operator==() because there are many cases where the same font
is compared against many others, and this solution is cleaner than caching a comparison
object inside the font object itself.

No new tests because this is covered by platform/mac/editing/input/devanagari-ligature.html.

  • platform/graphics/FontPlatformData.h:
  • platform/graphics/cocoa/FontPlatformDataCocoa.mm:

(WebCore::FontPlatformData::objectForEqualityCheck):

  • platform/graphics/mac/ComplexTextControllerCoreText.mm:

(WebCore::ComplexTextController::collectComplexTextRunsForCharacters):

  • platform/graphics/mac/GlyphPageTreeNodeMac.cpp:

(WebCore::GlyphPage::fill):

  • platform/graphics/mac/SimpleFontDataMac.mm:

(WebCore::SimpleFontData::canRenderCombiningCharacterSequence):

  • platform/spi/cocoa/CoreTextSPI.h:
10:45 AM Changeset in webkit [177688] by mmaxfield@apple.com
  • 2 edits in trunk/Source/WebCore

[SVG -> OTF Converter] Make Placeholder a move-only type
​https://bugs.webkit.org/show_bug.cgi?id=139870

Reviewed by Anders Carlsson.

No new tests because there is no behavior change.

  • svg/SVGToOTFFontConversion.cpp:

(WebCore::SVGToOTFFontConverter::Placeholder::Placeholder):
(WebCore::SVGToOTFFontConverter::Placeholder::populate):
(WebCore::SVGToOTFFontConverter::Placeholder::~Placeholder):

10:37 AM Changeset in webkit [177687] by Chris Dumez
  • 5 edits in trunk/Source/WebCore

Move color CSS properties to the new StyleBuilder
​https://bugs.webkit.org/show_bug.cgi?id=139898

Reviewed by Antti Koivisto.

Move color CSS properties to the new StyleBuilder by teaching the
StyleBuilder generator how to handle them.

  • css/CSSPropertyNames.in:
  • Move color properties to the new StyleBuilder.
  • css/DeprecatedStyleBuilder.cpp:

(WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder):
(WebCore::defaultInitialColor): Deleted.
(WebCore::ApplyPropertyColor::applyInheritValue): Deleted.
(WebCore::ApplyPropertyColor::applyInitialValue): Deleted.
(WebCore::ApplyPropertyColor::applyValue): Deleted.
(WebCore::ApplyPropertyColor::applyColorValue): Deleted.
(WebCore::ApplyPropertyColor::createHandler): Deleted.

  • Drop color properties support from the DeprecatedStyleBuilder.
  • css/makeprop.pl:
  • Teach the StyleBuilder generator how to handle color properties.
  • Use a class for StyleBuilderFunctions instead of a namespace so that it can be made a friend of RenderStyle class.
  • rendering/style/RenderStyle.h:
  • Mark StyleBuilderFunctions class as friend as its functions can set RenderStyle members directly. This is similar to what is already done for StyleBuilderCustom class. The new color properties handling calls private methods on RenderStyle.
  • Mark invalidColor() method as static as it does not require an instance.
10:04 AM Changeset in webkit [177686] by Alan Bujtas
  • 4 edits
    6 adds in trunk

Incorrect dashed and dotted border painting.
​https://bugs.webkit.org/show_bug.cgi?id=139872
rdar://problem/18024205

Reviewed by Simon Fraser.

This patch makes dashed/dotted border painting symmetric and consistent.
It also works with subpixel positioning.

Source/WebCore:

Tests: fast/borders/border-painting-correctness-dashed.html

fast/borders/border-painting-correctness-dotted.html

  • platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::GraphicsContext::drawLine):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::drawLineForBoxSide):

LayoutTests:

  • fast/borders/border-painting-correctness-dashed-expected.html: Added.
  • fast/borders/border-painting-correctness-dashed.html: Added.
  • fast/borders/border-painting-correctness-dotted-expected.html: Added.
  • fast/borders/border-painting-correctness-dotted.html: Added.
  • fast/borders/resources/border-painting-correctness-dashed-expected.png: Added.
  • fast/borders/resources/border-painting-correctness-dotted-expected.png: Added.
8:52 AM Changeset in webkit [177685] by andersca@apple.com
  • 5 edits in trunk/Source/WebKit2

Use a Transformer for UserData as well, to avoid always copying arrays and dictionaries
​https://bugs.webkit.org/show_bug.cgi?id=139896

Reviewed by Darin Adler.

  • Shared/UserData.cpp:

(WebKit::shouldTransform):
(WebKit::UserData::transform):

  • Shared/UserData.h:

(WebKit::UserData::Transformer::~Transformer):

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::apiObjectByConvertingToHandles):

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::apiObjectByConvertingFromHandles):

2:29 AM Changeset in webkit [177684] by g.czajkowski@samsung.com
  • 2 edits in trunk/LayoutTests

editing/spelling/grammar-paste.html is flaky in debug after r177682
​https://bugs.webkit.org/show_bug.cgi?id=139903

Unreviewed gardening.

Mark it as flaky.

1:36 AM Changeset in webkit [177683] by g.czajkowski@samsung.com
  • 2 edits in trunk/LayoutTests

Add proper expectations for two spelling/ tests after r177682

Unreviewed gardening.

12:26 AM Changeset in webkit [177682] by g.czajkowski@samsung.com
  • 4 edits in trunk/LayoutTests

shouldBecomeEqual() behaves as shouldBe() if the testing expression returns the expected value
​https://bugs.webkit.org/show_bug.cgi?id=133939

Reviewed by Darin Adler.

First call of eval(expression) inside shouldBecomeEqual was always
made synchronously. If the testing expression returns the same value
as expected one then shouldBecomeEqual() will immediately report PASS,
for example,

shouldBecomeEqual(internals.hasSpellingMarker("wellcome"), false);

in consequence, assuming asynchronous path of spellchecking, spelling markers
may appear after a while.

The bug was caused by checking a condition at the beginning of shouldBecomeEqual(),
before calling a timer. As a result, queued asynchronous events doesn't effect
this checking.

This fix reveals new bugs in execDeleteCommand() behaviour, two tests need
to marked as failure now.

  • resources/js-test-pre.js:

(.condition):
(shouldBecomeEqual):
(shouldBecomeDifferent):

  • resources/js-test.js:

(.condition):
(shouldBecomeEqual):
(shouldBecomeDifferent):
Always check a condition on timer.

Dec 22, 2014:

11:28 PM Changeset in webkit [177681] by Chris Dumez
  • 3 edits in trunk/Source/WebCore

[iOS] Log which type of resources are commonly loaded using FeatureCounter
​https://bugs.webkit.org/show_bug.cgi?id=139890

Reviewed by Darin Adler.

Log which type of resources are commonly loaded using FeatureCounter
(e.g. stylesheets, scripts, fonts, images, ...).

  • loader/SubresourceLoader.cpp:

(WebCore::logResourceLoadedUsingFeatureCounter):
(WebCore::SubresourceLoader::didFinishLoading):

  • platform/FeatureCounterKeys.h:
11:23 PM Changeset in webkit [177680] by Chris Dumez
  • 5 edits in trunk/Source/WebCore

[iOS] Log using FeatureCounter when a PacheCache fails due to memory pressure
​https://bugs.webkit.org/show_bug.cgi?id=139874
<rdar://problem/19255690>

Reviewed by Darin Adler.

Log using FeatureCounter when a PacheCache fails due to memory
pressure. To detect this, a flag is added to HistoryItem to mark
items that are no longer in the page becaused they were pruned
(either because of a low memory handling or because the page cache
reached its maximum capacity).

  • history/HistoryItem.cpp:

(WebCore::HistoryItem::HistoryItem):

  • history/HistoryItem.h:
  • history/PageCache.cpp:

(WebCore::PageCache::add):
(WebCore::PageCache::take):
(WebCore::PageCache::get):
(WebCore::PageCache::prune):

  • platform/FeatureCounterKeys.h:
11:17 PM Changeset in webkit [177679] by ap@apple.com
  • 2 edits in trunk/LayoutTests

platform/mac-wk2/tiled-drawing/scrolling/frames/frameset-frame-scrollability.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=139901

  • platform/mac-wk2/TestExpectations: Mark it as such.
11:15 PM Changeset in webkit [177678] by commit-queue@webkit.org
  • 4 edits
    6 deletes in trunk

Unreviewed, rolling out r177658.
​https://bugs.webkit.org/show_bug.cgi?id=139900

Caused many assertion failures (Requested by ap on #webkit).

Reverted changeset:

"Incorrect dashed and dotted border painting."
​https://bugs.webkit.org/show_bug.cgi?id=139872
​http://trac.webkit.org/changeset/177658

7:24 PM Changeset in webkit [177677] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

Make it possible to transform Objective-C object graphs, replacing certain elements with others
​https://bugs.webkit.org/show_bug.cgi?id=139893

Reviewed by Sam Weinig.

  • Shared/mac/ObjCObjectGraph.h:

(WebKit::ObjCObjectGraph::Transformer::~Transformer):

  • Shared/mac/ObjCObjectGraph.mm:

(WebKit::dynamic_objc_cast):
(WebKit::shouldTransform):
(WebKit::ObjCObjectGraph::transform):

7:21 PM Changeset in webkit [177676] by ljaehun.lim@samsung.com
  • 4 edits in trunk/Source

Unreviewed build fix after r177661 and r177662

Source/WebCore:

  • dom/SecurityOriginPolicy.cpp: Modify #include path.

Source/WebKit2:

  • CMakeLists.txt: Add APIPageGroupHandle.cpp to the source list.
6:48 PM Changeset in webkit [177675] by mark.lam@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Use ctiPatchCallByReturnAddress() in JITOperations.cpp.
<​https://webkit.org/b/139892>

Reviewed by Michael Saboff.

The code in JITOperations.cpp sometimes calls RepatchBuffer::relinkCallerToFunction()
directly, and sometimes uses a helper function, ctiPatchCallByReturnAddress().
This patch changes it to use the helper function consistently.

  • jit/JITOperations.cpp:
6:24 PM Changeset in webkit [177674] by mrowe@apple.com
  • 2 edits in trunk/Source/WebCore

[Mac] Engineering builds of WebCore on OS X 10.8 and 10.9 shouldn't build with -gline-tables-only
<​https://webkit.org/b/139883> / <rdar://problem/19297261>

Reviewed by Alexey Proskuryakov.

  • Configurations/DebugRelease.xcconfig: Override the setting using conditional settings

so that they take precedence over the conditional settings in Base.xcconfig.

5:59 PM Changeset in webkit [177673] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

Convert pages and page groups to their respective handle objects
​https://bugs.webkit.org/show_bug.cgi?id=139891

Reviewed by Tim Horton.

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::apiObjectByConvertingToHandles):

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::apiObjectByConvertingFromHandles):

5:54 PM Changeset in webkit [177672] by Brent Fulgham
  • 2 edits in trunk/Source/WebKit

[Win] Build fix after r177668.

  • WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in: Add missing export definition

for new symbols.

5:32 PM Changeset in webkit [177671] by andersca@apple.com
  • 12 edits in trunk/Source/WebKit2

Add a bunch of missing header includes in preparation for making toImpl require the complete type
​https://bugs.webkit.org/show_bug.cgi?id=139887

Reviewed by Andreas Kling.

  • WebProcess/InjectedBundle/API/c/WKBundle.cpp:
  • WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
  • WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
  • WebProcess/InjectedBundle/API/c/WKBundlePageOverlay.cpp:
  • WebProcess/InjectedBundle/InjectedBundlePageContextMenuClient.cpp:
  • WebProcess/InjectedBundle/InjectedBundlePageDiagnosticLoggingClient.cpp:
  • WebProcess/InjectedBundle/InjectedBundlePageEditorClient.cpp:
  • WebProcess/InjectedBundle/InjectedBundlePageFormClient.cpp:
  • WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:
  • WebProcess/InjectedBundle/InjectedBundlePageResourceLoadClient.cpp:
  • WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp:
5:23 PM Changeset in webkit [177670] by ap@apple.com
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix.

  • WebCore.exp.in: Move SQLiteDatabaseTracker::setClient export out of PLATFORM(IOS) section.
5:22 PM Changeset in webkit [177669] by bshafiei@apple.com
  • 1 copy in tags/Safari-600.1.4.13.3

New tag.

4:54 PM Changeset in webkit [177668] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Remove two functions from SecurityOrigin
​https://bugs.webkit.org/show_bug.cgi?id=139885

Reviewed by Andreas Kling.

  • page/SecurityOrigin.h:

(WebCore::SecurityOrigin::canAccessPasswordManager): Deleted.
(WebCore::SecurityOrigin::canAccessFileSystem): Deleted.

4:50 PM Changeset in webkit [177667] by mark.lam@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Fix some typos in a comment.
<​https://webkit.org/b/139882>

Reviewed by Michael Saboff.

  • jit/JITPropertyAccess.cpp:

(JSC::JIT::emit_op_get_by_val):

4:48 PM Changeset in webkit [177666] by Chris Dumez
  • 7 edits in trunk/Source

[iOS] Log using FeatureCounter user-triggered zooming
​https://bugs.webkit.org/show_bug.cgi?id=139879
<rdar://problem/19329130>

Reviewed by Benjamin Poulain.

Log using FeatureCounter user-triggered zooming on iOS.

Source/WebCore:

  • WebCore.exp.in:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/FeatureCounter.h:
  • platform/FeatureCounterKeys.h:

Source/WebKit2:

  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::willStartUserTriggeredZooming):

4:45 PM Changeset in webkit [177665] by matthew_hanson@apple.com
  • 5 edits in branches/safari-600.3-branch/Source

Versioning.

4:38 PM Changeset in webkit [177664] by benjamin@webkit.org
  • 8 edits
    28 adds in trunk

Form elements should match :valid and :invalid based on their associated elements
​https://bugs.webkit.org/show_bug.cgi?id=139850

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2014-12-22
Reviewed by Darin Adler.

Source/WebCore:

In the latest HTML spec, form elements can match :valid or :invalid based
on their associated element.

The tricky part is that object lifetime is a mess. When elements are associated
with forms by the parser, the form is set by the constructor of HTMLFormControlElement.
At that point, the real object has not been initialized yet which
makes it impossible to find its validity.

To work around the lifetime problem, the code of HTMLFormControlElement::didChangeForm()
uses m_willValidateInitialized and m_willValidate direclty instead
of invoking willValidate(). That way we don't try to validate an incomplete object.

When the object really validates, HTMLFormControlElement::setNeedsWillValidateCheck()
takes care of updating the form.

Tests: fast/css/pseudo-invalid-form-and-fieldset-basics.html

fast/css/pseudo-invalid-form-basics.html
fast/css/pseudo-invalid-form-dynamically-created-basics.html
fast/css/pseudo-invalid-form-invalidation-optimization.html
fast/css/pseudo-valid-form-and-fieldset-basics.html
fast/css/pseudo-valid-form-basics.html
fast/css/pseudo-valid-form-dynamically-created-basics.html
fast/css/pseudo-valid-form-invalidation-optimization.html
fast/selectors/invalid-form-style-update-1.html
fast/selectors/invalid-form-style-update-2.html
fast/selectors/invalid-form-style-update-3.html
fast/selectors/valid-form-style-update-1.html
fast/selectors/valid-form-style-update-2.html
fast/selectors/valid-form-style-update-3.html

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::canShareStyleWithControl):
(WebCore::StyleResolver::canShareStyleWithElement):
HTMLFormElement is not a FormControl, we have to generalize the test
for :valid/:invalid with style sharing.

  • html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElement::~HTMLFormControlElement):
Since we now have willChangeForm(), didChangeForm(), we have to null
the form ourself, as documented by FormAssociatedElement.

(WebCore::HTMLFormControlElement::setNeedsWillValidateCheck):
(WebCore::HTMLFormControlElement::willChangeForm):
(WebCore::HTMLFormControlElement::didChangeForm):
(WebCore::HTMLFormControlElement::updateValidity):
Update the owner form when any of the associated form element changes
to invalid.

  • html/HTMLFormControlElement.h:
  • html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::registerInvalidAssociatedFormControl):
(WebCore::HTMLFormElement::removeInvalidAssociatedFormControlIfNeeded):
(WebCore::HTMLFormElement::matchesValidPseudoClass):
(WebCore::HTMLFormElement::matchesInvalidPseudoClass):
This is very similar to the code of fieldset, but we have much weaker
invariants due to the insane way FormAssociatedElement initializes.

  • html/HTMLFormElement.h:
  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::initializeInputType):
For completeness, we should always validate when changing the type.
The code was only doing that when the element was inserted into the tree,
that was too fragile.

LayoutTests:

The style update tests are largely based on the fieldset test suite.
The other tests are for various aspects of the patch.

  • fast/css/pseudo-invalid-form-and-fieldset-basics-expected.html: Added.
  • fast/css/pseudo-invalid-form-and-fieldset-basics.html: Added.
  • fast/css/pseudo-invalid-form-basics-expected.html: Added.
  • fast/css/pseudo-invalid-form-basics.html: Added.
  • fast/css/pseudo-invalid-form-dynamically-created-basics-expected.html: Added.
  • fast/css/pseudo-invalid-form-dynamically-created-basics.html: Added.
  • fast/css/pseudo-invalid-form-invalidation-optimization-expected.txt: Added.
  • fast/css/pseudo-invalid-form-invalidation-optimization.html: Added.
  • fast/css/pseudo-valid-form-and-fieldset-basics-expected.html: Added.
  • fast/css/pseudo-valid-form-and-fieldset-basics.html: Added.
  • fast/css/pseudo-valid-form-basics-expected.html: Added.
  • fast/css/pseudo-valid-form-basics.html: Added.
  • fast/css/pseudo-valid-form-dynamically-created-basics-expected.html: Added.
  • fast/css/pseudo-valid-form-dynamically-created-basics.html: Added.
  • fast/css/pseudo-valid-form-invalidation-optimization-expected.txt: Added.
  • fast/css/pseudo-valid-form-invalidation-optimization.html: Added.
  • fast/selectors/invalid-form-style-update-1-expected.txt: Added.
  • fast/selectors/invalid-form-style-update-1.html: Added.
  • fast/selectors/invalid-form-style-update-2-expected.txt: Added.
  • fast/selectors/invalid-form-style-update-2.html: Added.
  • fast/selectors/invalid-form-style-update-3-expected.txt: Added.
  • fast/selectors/invalid-form-style-update-3.html: Added.
  • fast/selectors/valid-form-style-update-1-expected.txt: Added.
  • fast/selectors/valid-form-style-update-1.html: Added.
  • fast/selectors/valid-form-style-update-2-expected.txt: Added.
  • fast/selectors/valid-form-style-update-2.html: Added.
  • fast/selectors/valid-form-style-update-3-expected.txt: Added.
  • fast/selectors/valid-form-style-update-3.html: Added.
4:02 PM Changeset in webkit [177663] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Try to fix the Windows build.

  • dom/DOMAllInOne.cpp:
3:56 PM Changeset in webkit [177662] by andersca@apple.com
  • 7 edits
    2 copies in trunk/Source/WebKit2

Add an API::PageGroupHandle object
​https://bugs.webkit.org/show_bug.cgi?id=139881

Reviewed by Sam Weinig.

API::PageGroupHandle won't be exposed to any API, it will only be used to facilitate passing page groups
between the UI and web process inside UserData objects.

  • Shared/API/APIObject.h:
  • Shared/API/APIPageGroupHandle.cpp: Added.

(API::PageGroupHandle::create):
(API::PageGroupHandle::~PageGroupHandle):
(API::PageGroupHandle::PageGroupHandle):

  • Shared/API/APIPageGroupHandle.h: Added.

(API::PageGroupHandle::webPageGroupData):

  • Shared/UserData.cpp:

(WebKit::UserData::UserData):
(WebKit::UserData::encode):
(WebKit::UserData::decode):

  • Shared/UserData.h:
  • UIProcess/WebPageGroup.h:

(WebKit::WebPageGroup::data):

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::apiObjectByConvertingToHandles):

  • WebKit2.xcodeproj/project.pbxproj:
3:42 PM Changeset in webkit [177661] by andersca@apple.com
  • 16 edits
    2 adds in trunk/Source/WebCore

Add a SecurityOriginPolicy class
​https://bugs.webkit.org/show_bug.cgi?id=139875

Reviewed by Sam Weinig.

This is the first step towards making SecurityOrigin immutable. SecurityOriginPolicy will hold a
SecurityOrigin and will handle things that would otherwise mutate SecurityOrigin.

  • CMakeLists.txt:
  • WebCore.exp.in:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/DOMImplementation.cpp:

(WebCore::DOMImplementation::createDocument):
(WebCore::DOMImplementation::createHTMLDocument):

  • dom/Document.cpp:

(WebCore::Document::create):
(WebCore::Document::open):
(WebCore::Document::cloneDataFromDocument):
(WebCore::Document::initSecurityContext):

  • dom/ScriptExecutionContext.h:
  • dom/SecurityContext.cpp:

(WebCore::SecurityContext::setSecurityOriginPolicy):
(WebCore::SecurityContext::securityOrigin):
(WebCore::SecurityContext::isSecureTransitionTo):
(WebCore::SecurityContext::enforceSandboxFlags):
(WebCore::SecurityContext::setSecurityOrigin): Deleted.

  • dom/SecurityContext.h:

(WebCore::SecurityContext::securityOriginPolicy):
(WebCore::SecurityContext::securityOrigin): Deleted.

  • dom/SecurityOriginPolicy.cpp: Added.

(WebCore::SecurityOriginPolicy::create):
(WebCore::SecurityOriginPolicy::SecurityOriginPolicy):
(WebCore::SecurityOriginPolicy::~SecurityOriginPolicy):

  • dom/SecurityOriginPolicy.h: Added.

(WebCore::SecurityOriginPolicy::origin):

  • loader/DocumentWriter.cpp:

(WebCore::DocumentWriter::begin):

  • workers/WorkerGlobalScope.cpp:

(WebCore::WorkerGlobalScope::WorkerGlobalScope):

  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::responseXML):

  • xml/XMLTreeViewer.cpp:

(WebCore::XMLTreeViewer::transformDocumentToTreeView):

  • xml/XSLTProcessor.cpp:

(WebCore::XSLTProcessor::createDocumentFromSource):

3:30 PM Changeset in webkit [177660] by ap@apple.com
  • 2 edits in trunk/LayoutTests

compositing/rtl/rtl-fixed-overflow-scrolled.html had a 1600x1200 expected PNG
accidentally checked in, let's land 800x600 again.

  • platform/mac/compositing/rtl/rtl-fixed-overflow-scrolled-expected.png:
3:27 PM Changeset in webkit [177659] by Simon Fraser
  • 2 edits in trunk/Tools

Sort the Xcode project file.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3:18 PM Changeset in webkit [177658] by Alan Bujtas
  • 4 edits
    6 adds in trunk

Incorrect dashed and dotted border painting.
​https://bugs.webkit.org/show_bug.cgi?id=139872
rdar://problem/18024205

Reviewed by Simon Fraser.

This patch makes dashed/dotted border painting symmetric and consistent.
It also works with subpixel positioning.

Source/WebCore:

Tests: fast/borders/border-painting-correctness-dashed.html

fast/borders/border-painting-correctness-dotted.html

  • platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::GraphicsContext::drawLine):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::drawLineForBoxSide):

LayoutTests:

  • fast/borders/border-painting-correctness-dashed-expected.html: Added.
  • fast/borders/border-painting-correctness-dashed.html: Added.
  • fast/borders/border-painting-correctness-dotted-expected.html: Added.
  • fast/borders/border-painting-correctness-dotted.html: Added.
  • fast/borders/resources/border-painting-correctness-dashed-expected.png: Added.
  • fast/borders/resources/border-painting-correctness-dotted-expected.png: Added.
3:09 PM Changeset in webkit [177657] by mark.lam@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Assert that Array elements not copied when changing shape to ArrayStorage type are indeed holes.
<​https://webkit.org/b/138118>

Reviewed by Michael Saboff.

  • runtime/JSObject.cpp:

(JSC::JSObject::convertInt32ToArrayStorage):
(JSC::JSObject::convertDoubleToArrayStorage):
(JSC::JSObject::convertContiguousToArrayStorage):

2:17 PM Changeset in webkit [177656] by timothy_horton@apple.com
  • 4 edits in trunk/Source/WebCore

TextIndicatorWindow is larger than it needs to be, especially when not bouncing
​https://bugs.webkit.org/show_bug.cgi?id=139876
<rdar://problem/19311017>

Reviewed by Sam Weinig.

  • page/TextIndicator.cpp:

(WebCore::TextIndicator::wantsBounce):
(WebCore::TextIndicator::wantsContentCrossfade):
(WebCore::TextIndicator::wantsFadeIn):

  • page/TextIndicator.h:
  • page/mac/TextIndicatorWindow.mm:

(-[WebTextIndicatorView initWithFrame:textIndicator:margin:]):
(-[WebTextIndicatorView _animationDuration]):
(-[WebTextIndicatorView present]):
(WebCore::TextIndicatorWindow::setTextIndicator):
(-[WebTextIndicatorView _textIndicatorWantsBounce]): Deleted.
(-[WebTextIndicatorView _textIndicatorWantsContentCrossfade]): Deleted.
(-[WebTextIndicatorView _textIndicatorWantsFadeIn]): Deleted.
Move the various switches over TextIndicatorPresentationTransition into TextIndicator.
Adjust the margin; only inflate by the shadow if we're not bouncing.
If we are bouncing, fix the math to more tightly fit the bounce.
Previously we were inflating by way too much, and even when we didn't need to.

1:45 PM Changeset in webkit [177655] by Lucas Forschler
  • 2 edits in trunk/Tools

Update apple-mac-114 to bot629.

Unreviewed.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
1:37 PM Changeset in webkit [177654] by Lucas Forschler
  • 2 edits in trunk/Tools

Replace Apple bot104 with bot124.

Unreviewed.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
1:20 PM Changeset in webkit [177653] by ap@apple.com
  • 2 edits in trunk/LayoutTests

REGRESSION: fast/xmlhttprequest/xmlhttprequest-recursive-sync-event.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=139840

1:12 PM Changeset in webkit [177652] by dbates@webkit.org
  • 2 edits in trunk/Source/WebKit2

Fix the iOS build after <​https://trac.webkit.org/changeset/177639>
(​https://bugs.webkit.org/show_bug.cgi?id=139866)

Substitute APISecurityOrigin.h for WebSecurityOrigin.h as the latter was renamed to the former.

  • UIProcess/ios/WKGeolocationProviderIOS.mm:
12:55 PM Changeset in webkit [177651] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebKit2

URTBF after r177649.

  • CMakeLists.txt:
12:48 PM Changeset in webkit [177650] by Csaba Osztrogonác
  • 7 edits in trunk/Source/WebKit2

Last URTBF after r177639, GTK builds now.

  • UIProcess/API/gtk/WebKitJavascriptResult.cpp:
  • UIProcess/API/gtk/WebKitUIClient.cpp:
  • UIProcess/API/gtk/WebKitUserContentManager.cpp:
  • UIProcess/API/gtk/WebKitUserMediaPermissionRequest.cpp:

(webkitUserMediaPermissionRequestCreate):

  • UIProcess/API/gtk/WebKitUserMediaPermissionRequestPrivate.h:
  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkitWebViewRunJavaScriptCallback):
(webkit_web_view_run_javascript):
(resourcesStreamReadCallback):

12:39 PM Changeset in webkit [177649] by andersca@apple.com
  • 2 edits
    22 moves in trunk/Source/WebKit2

Move more API classes from Shared to Shared/API.

Rubber-stamped by Sam Weinig.

  • Shared/API/APIArray.cpp: Renamed from Source/WebKit2/Shared/APIArray.cpp.
  • Shared/API/APIArray.h: Renamed from Source/WebKit2/Shared/APIArray.h.
  • Shared/API/APIClient.h: Renamed from Source/WebKit2/Shared/APIClient.h.
  • Shared/API/APIData.cpp: Renamed from Source/WebKit2/Shared/APIData.cpp.
  • Shared/API/APIData.h: Renamed from Source/WebKit2/Shared/APIData.h.
  • Shared/API/APIError.cpp: Renamed from Source/WebKit2/Shared/APIError.cpp.
  • Shared/API/APIError.h: Renamed from Source/WebKit2/Shared/APIError.h.
  • Shared/API/APIFrameHandle.cpp: Renamed from Source/WebKit2/Shared/APIFrameHandle.cpp.
  • Shared/API/APIFrameHandle.h: Renamed from Source/WebKit2/Shared/APIFrameHandle.h.
  • Shared/API/APIGeometry.cpp: Renamed from Source/WebKit2/Shared/APIGeometry.cpp.
  • Shared/API/APIGeometry.h: Renamed from Source/WebKit2/Shared/APIGeometry.h.
  • Shared/API/APINumber.h: Renamed from Source/WebKit2/Shared/APINumber.h.
  • Shared/API/APIObject.cpp: Renamed from Source/WebKit2/Shared/APIObject.cpp.
  • Shared/API/APIObject.h: Renamed from Source/WebKit2/Shared/APIObject.h.
  • Shared/API/APIPageHandle.cpp: Renamed from Source/WebKit2/Shared/APIPageHandle.cpp.
  • Shared/API/APIPageHandle.h: Renamed from Source/WebKit2/Shared/APIPageHandle.h.
  • Shared/API/APIString.h: Renamed from Source/WebKit2/Shared/APIString.h.
  • Shared/API/APIURL.h: Renamed from Source/WebKit2/Shared/APIURL.h.
  • Shared/API/APIURLRequest.cpp: Renamed from Source/WebKit2/Shared/APIURLRequest.cpp.
  • Shared/API/APIURLRequest.h: Renamed from Source/WebKit2/Shared/APIURLRequest.h.
  • Shared/API/APIURLResponse.cpp: Renamed from Source/WebKit2/Shared/APIURLResponse.cpp.
  • Shared/API/APIURLResponse.h: Renamed from Source/WebKit2/Shared/APIURLResponse.h.
12:13 PM Changeset in webkit [177648] by ap@apple.com
  • 2 edits in trunk/LayoutTests

Update some inspector test expectations for the new timeout detection.
Also, unmarked some tests that appear stable on bots now.

  • platform/mac/TestExpectations:
12:13 PM Changeset in webkit [177647] by Chris Dumez
  • 6 edits in trunk/Source/WebCore

[iOS] Log using FeatureCounter when a PacheCache entry is not reused because it expired
​https://bugs.webkit.org/show_bug.cgi?id=139869
<rdar://problem/19255690>

Reviewed by Darin Adler.

Log using FeatureCounter when a PacheCache entry is not reused because
it expired.

  • history/PageCache.cpp:

(WebCore::PageCache::take):
(WebCore::PageCache::get):

  • history/PageCache.h:
  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::commitProvisionalLoad):
(WebCore::FrameLoader::loadDifferentDocumentItem):

  • loader/HistoryController.cpp:

(WebCore::HistoryController::invalidateCurrentItemCachedPage):

  • platform/FeatureCounterKeys.h:
12:13 PM Changeset in webkit [177646] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebKit2

One more URTBF after r177639 to try to make GTK happy.

  • UIProcess/API/gtk/WebKitUserContentManager.cpp:
12:10 PM Changeset in webkit [177645] by bshafiei@apple.com
  • 2 edits in branches/safari-600.1.4.13-branch/Source/WebKit2

Merged r177463. rdar://problem/19327421

12:08 PM Changeset in webkit [177644] by bshafiei@apple.com
  • 2 edits in branches/safari-600.1.4.13-branch/Source/WebKit2

Merged r173973. rdar://problem/19327404

12:08 PM Changeset in webkit [177643] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebKit2

URTBF after r177639 to try to make GTK happy.

  • UIProcess/API/gtk/WebKitJavascriptResult.cpp:
12:05 PM Changeset in webkit [177642] by Antti Koivisto
  • 2 edits in trunk/Source/WebCore

Try to fix the windows build.

  • platform/graphics/win/SimpleFontDataCGWin.cpp:
11:56 AM Changeset in webkit [177641] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebCore

Adjust TextIndicator shadow parameters
​https://bugs.webkit.org/show_bug.cgi?id=139871
<rdar://problem/19283300>

Reviewed by Sam Weinig.

  • page/mac/TextIndicatorWindow.mm:

(-[WebTextIndicatorView initWithFrame:textIndicator:margin:]):
Slightly adjust the shadow and bounce size.

11:47 AM Changeset in webkit [177640] by Csaba Osztrogonác
  • 2 edits in trunk/Tools

URTBF after r177639.

  • TestWebKitAPI/CMakeLists.txt:
11:27 AM Changeset in webkit [177639] by andersca@apple.com
  • 47 edits
    3 moves in trunk/Source/WebKit2

Rename a bunch of API classes and move them to Shared/API
​https://bugs.webkit.org/show_bug.cgi?id=139866

Reviewed by Sam Weinig.

  • Shared/API/APISecurityOrigin.h: Renamed from Source/WebKit2/Shared/WebSecurityOrigin.h.

(API::SecurityOrigin::createFromString):
(API::SecurityOrigin::create):
(API::SecurityOrigin::securityOrigin):
(API::SecurityOrigin::SecurityOrigin):

  • Shared/API/APISerializedScriptValue.h: Renamed from Source/WebKit2/Shared/WebSerializedScriptValue.h.

(API::SerializedScriptValue::create):
(API::SerializedScriptValue::adopt):
(API::SerializedScriptValue::deserialize):
(API::SerializedScriptValue::dataReference):
(API::SerializedScriptValue::internalRepresentation):
(API::SerializedScriptValue::SerializedScriptValue):

  • Shared/API/APIUserContentURLPattern.h: Renamed from Source/WebKit2/Shared/WebUserContentURLPattern.h.

(API::UserContentURLPattern::create):
(API::UserContentURLPattern::host):
(API::UserContentURLPattern::scheme):
(API::UserContentURLPattern::isValid):
(API::UserContentURLPattern::matchesURL):
(API::UserContentURLPattern::matchesSubdomains):
(API::UserContentURLPattern::patternString):
(API::UserContentURLPattern::UserContentURLPattern):

  • Shared/API/c/WKSecurityOrigin.cpp:

(WKSecurityOriginGetTypeID):
(WKSecurityOriginCreateFromString):
(WKSecurityOriginCreateFromDatabaseIdentifier):
(WKSecurityOriginCreate):

  • Shared/API/c/WKSerializedScriptValue.cpp:

(WKSerializedScriptValueGetTypeID):
(WKSerializedScriptValueCreate):
(WKSerializedScriptValueCreateWithInternalRepresentation):

  • Shared/API/c/WKSharedAPICast.h:

(WebKit::toCopiedAPI):

  • Shared/API/c/WKUserContentURLPattern.cpp:

(WKUserContentURLPatternGetTypeID):
(WKUserContentURLPatternCreate):

  • Shared/SecurityOriginData.cpp:

(WebKit::performAPICallbackWithSecurityOriginDataVector):

  • Shared/UserData.cpp:

(WebKit::UserData::encode):
(WebKit::UserData::decode):

  • Shared/UserMessageCoders.h:

(WebKit::UserMessageEncoder::baseEncode):
(WebKit::UserMessageDecoder::baseDecode):

  • UIProcess/API/APIUIClient.h:

(API::UIClient::exceededDatabaseQuota):
(API::UIClient::decidePolicyForGeolocationPermissionRequest):
(API::UIClient::decidePolicyForUserMediaPermissionRequest):
(API::UIClient::decidePolicyForNotificationPermissionRequest):

  • UIProcess/API/C/WKNotification.cpp:
  • UIProcess/API/C/WKPage.cpp:

(WKPageSetPageUIClient):

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView evaluateJavaScript:completionHandler:]):

  • UIProcess/Cocoa/UIDelegate.h:
  • UIProcess/Cocoa/UIDelegate.mm:

(WebKit::UIDelegate::UIClient::exceededDatabaseQuota):

  • UIProcess/GenericCallback.h:
  • UIProcess/Notifications/WebNotification.cpp:

(WebKit::WebNotification::WebNotification):

  • UIProcess/Notifications/WebNotification.h:

(WebKit::WebNotification::origin):

  • UIProcess/Notifications/WebNotificationManagerProxy.cpp:

(WebKit::WebNotificationManagerProxy::providerDidUpdateNotificationPolicy):
(WebKit::WebNotificationManagerProxy::providerDidRemoveNotificationPolicies):

  • UIProcess/Notifications/WebNotificationManagerProxy.h:
  • UIProcess/Notifications/WebNotificationProvider.cpp:
  • UIProcess/Notifications/WebNotificationProvider.h:
  • UIProcess/PageClient.h:

(WebKit::PageClient::decidePolicyForGeolocationPermissionRequest):

  • UIProcess/WebApplicationCacheManagerProxy.cpp:

(WebKit::WebApplicationCacheManagerProxy::deleteEntriesForOrigin):

  • UIProcess/WebApplicationCacheManagerProxy.h:
  • UIProcess/WebCookieManagerProxy.cpp:
  • UIProcess/WebDatabaseManagerProxy.cpp:

(WebKit::WebDatabaseManagerProxy::didGetDatabasesByOrigin):
(WebKit::WebDatabaseManagerProxy::didGetDatabaseOrigins):
(WebKit::WebDatabaseManagerProxy::deleteDatabaseWithNameForOrigin):
(WebKit::WebDatabaseManagerProxy::deleteDatabasesForOrigin):
(WebKit::WebDatabaseManagerProxy::setQuotaForOrigin):
(WebKit::WebDatabaseManagerProxy::didModifyOrigin):
(WebKit::WebDatabaseManagerProxy::didModifyDatabase):

  • UIProcess/WebDatabaseManagerProxy.h:
  • UIProcess/WebDatabaseManagerProxyClient.cpp:

(WebKit::WebDatabaseManagerProxyClient::didModifyOrigin):
(WebKit::WebDatabaseManagerProxyClient::didModifyDatabase):

  • UIProcess/WebDatabaseManagerProxyClient.h:
  • UIProcess/WebKeyValueStorageManager.cpp:

(WebKit::WebKeyValueStorageManager::getKeyValueStorageOrigins):
(WebKit::WebKeyValueStorageManager::getStorageDetailsByOrigin):
(WebKit::WebKeyValueStorageManager::deleteEntriesForOrigin):

  • UIProcess/WebKeyValueStorageManager.h:
  • UIProcess/WebMediaCacheManagerProxy.cpp:
  • UIProcess/WebOriginDataManagerProxy.cpp:

(WebKit::WebOriginDataManagerProxy::didGetOrigins):
(WebKit::WebOriginDataManagerProxy::deleteEntriesForOrigin):

  • UIProcess/WebOriginDataManagerProxy.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::runJavaScriptInMainFrame):
(WebKit::WebPageProxy::scriptValueCallback):
(WebKit::WebPageProxy::exceededDatabaseQuota):
(WebKit::WebPageProxy::requestGeolocationPermissionForFrame):
(WebKit::WebPageProxy::requestUserMediaPermissionForFrame):
(WebKit::WebPageProxy::requestNotificationPermission):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebResourceCacheManagerProxy.cpp:

(WebKit::WebResourceCacheManagerProxy::clearCacheForOrigin):

  • UIProcess/WebResourceCacheManagerProxy.h:
  • UIProcess/ios/PageClientImplIOS.h:
  • UIProcess/ios/PageClientImplIOS.mm:

(WebKit::PageClientImpl::decidePolicyForGeolocationPermissionRequest):

  • UIProcess/ios/WKContentView.h:
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/InjectedBundle/API/APIInjectedBundlePageUIClient.h:

(API::InjectedBundle::PageUIClient::didReachApplicationCacheOriginQuota):
(API::InjectedBundle::PageUIClient::didExceedDatabaseQuota):

  • WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
  • WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp:

(WebKit::InjectedBundlePageUIClient::didReachApplicationCacheOriginQuota):
(WebKit::InjectedBundlePageUIClient::didExceedDatabaseQuota):

  • WebProcess/InjectedBundle/InjectedBundlePageUIClient.h:
  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::exceededDatabaseQuota):
(WebKit::WebChromeClient::reachedApplicationCacheOriginQuota):

11:21 AM Changeset in webkit [177638] by Chris Dumez
  • 3 edits in trunk/Source/WebCore

Consistently use "FeatureCounter*Key" naming for FeatureCounter keys
​https://bugs.webkit.org/show_bug.cgi?id=139867

Reviewed by Darin Adler.

Consistently use "FeatureCounter*Key" naming for FeatureCounter keys.

  • loader/FrameLoader.cpp:

(WebCore::logNavigationWithFeatureCounter):

  • platform/FeatureCounterKeys.h:
11:14 AM Changeset in webkit [177637] by Antti Koivisto
  • 10 edits in trunk/Source/WebCore

Generic font code should not know about SVG font missing glyph
​https://bugs.webkit.org/show_bug.cgi?id=139864

Reviewed by Andreas Kling and Myles Maxfield.

The defined missing glyph is an SVG font concept and should be handled in SVG code.

  • platform/graphics/FontGlyphs.cpp:

(WebCore::FontGlyphs::glyphDataForSystemFallback):
(WebCore::FontGlyphs::glyphDataForVariant):

Return null glyph instead of the missing glyph (the missing glyph was already a null glyph in all non-svg-font cases).
Use early return style.

  • platform/graphics/FontGlyphs.h:
  • platform/graphics/SegmentedFontData.cpp:
  • platform/graphics/SimpleFontData.cpp:

(WebCore::SimpleFontData::platformGlyphInit):

  • platform/graphics/SimpleFontData.h:

Remove the missingGlyph member.

  • platform/graphics/WidthIterator.cpp:

(WebCore::WidthIterator::advanceInternal):

Explicitly skip over null glyphs. Before they had non-null fontData and would get skipped implicitly.

  • platform/graphics/mac/SimpleFontDataMac.mm:
  • rendering/svg/SVGTextRunRenderingContext.cpp:

(WebCore::missingGlyphForFont):

Get the missing glyph from the SVG font element.

(WebCore::SVGTextRunRenderingContext::glyphDataForCharacter):

Return the missing glyph if the normal lookup didn't produce results.

  • svg/SVGFontData.cpp:

(WebCore::SVGFontData::initializeFontData):

11:04 AM Changeset in webkit [177636] by weinig@apple.com
  • 17 edits
    1 move
    2 deletes in trunk/Source/WebKit2

Allow the WebContext's history client to coexist with WKWebView's history delegate
​https://bugs.webkit.org/show_bug.cgi?id=139857

Reviewed by Anders Carlsson.

  • Renames API::HistoryClient to API::LegacyContextHistoryClient to make it clear what it is for.
  • Re-routes the history client functions from the WebProcessProxy to the WebPageProxy.
  • Add history client functions to API::LoaderClient and implement them for NavigationState's LoaderClient subclass. Removes the need for WKProcessPool to have to setup a history client and forward to the NavigationState.
  • UIProcess/API/APIHistoryClient.h: Removed.
  • UIProcess/API/APILegacyContextHistoryClient.h: Copied from Source/WebKit2/UIProcess/API/APIHistoryClient.h.

(API::LegacyContextHistoryClient::~LegacyContextHistoryClient):
(API::LegacyContextHistoryClient::didNavigateWithNavigationData):
(API::LegacyContextHistoryClient::didPerformClientRedirect):
(API::LegacyContextHistoryClient::didPerformServerRedirect):
(API::LegacyContextHistoryClient::didUpdateHistoryTitle):
(API::LegacyContextHistoryClient::populateVisitedLinks):
(API::HistoryClient::~HistoryClient): Deleted.
(API::HistoryClient::didNavigateWithNavigationData): Deleted.
(API::HistoryClient::didPerformClientRedirect): Deleted.
(API::HistoryClient::didPerformServerRedirect): Deleted.
(API::HistoryClient::didUpdateHistoryTitle): Deleted.
(API::HistoryClient::populateVisitedLinks): Deleted.

  • UIProcess/API/APILoaderClient.h:

(API::LoaderClient::didNavigateWithNavigationData):
(API::LoaderClient::didPerformClientRedirect):
(API::LoaderClient::didPerformServerRedirect):
(API::LoaderClient::didUpdateHistoryTitle):

  • UIProcess/API/C/WKContext.cpp:

(WKContextSetHistoryClient):

  • UIProcess/API/Cocoa/WKProcessPool.mm:

(-[WKProcessPool _initWithConfiguration:]):

  • UIProcess/API/mac/WKView.mm:
  • UIProcess/Cocoa/HistoryClient.h: Removed.
  • UIProcess/Cocoa/HistoryClient.mm: Removed.
  • UIProcess/Cocoa/NavigationState.h:
  • UIProcess/Cocoa/NavigationState.mm:

(WebKit::NavigationState::LoaderClient::didNavigateWithNavigationData):
(WebKit::NavigationState::LoaderClient::didPerformClientRedirect):
(WebKit::NavigationState::LoaderClient::didPerformServerRedirect):
(WebKit::NavigationState::LoaderClient::didUpdateHistoryTitle):
(WebKit::NavigationState::didNavigateWithNavigationData): Deleted.
(WebKit::NavigationState::didPerformClientRedirect): Deleted.
(WebKit::NavigationState::didPerformServerRedirect): Deleted.
(WebKit::NavigationState::didUpdateHistoryTitle): Deleted.

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::WebContext):
(WebKit::WebContext::setHistoryClient):
(WebKit::WebContext::populateVisitedLinks):

  • UIProcess/WebContext.h:

(WebKit::WebContext::historyClient):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didNavigateWithNavigationData):
(WebKit::WebPageProxy::didPerformClientRedirect):
(WebKit::WebPageProxy::didPerformServerRedirect):
(WebKit::WebPageProxy::didUpdateHistoryTitle):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::didNavigateWithNavigationData): Deleted.
(WebKit::WebProcessProxy::didPerformClientRedirect): Deleted.
(WebKit::WebProcessProxy::didPerformServerRedirect): Deleted.
(WebKit::WebProcessProxy::didUpdateHistoryTitle): Deleted.

  • UIProcess/WebProcessProxy.h:
  • UIProcess/WebProcessProxy.messages.in:
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::updateGlobalHistory):
(WebKit::WebFrameLoaderClient::updateGlobalHistoryRedirectLinks):
(WebKit::WebFrameLoaderClient::setTitle):

10:40 AM Changeset in webkit [177635] by ap@apple.com
  • 2 edits in trunk/LayoutTests

Remove a Slow expectation for js/promises-tests/promises-tests-2-3-3.html,
as we now skip the test.

10:15 AM Changeset in webkit [177634] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[GTK] another outdated comment
​https://bugs.webkit.org/show_bug.cgi?id=139863

Patch by Michael Catanzaro <Michael Catanzaro> on 2014-12-22
Reviewed by Darin Adler.

Remove outdated comment. We nowadays block untrusted connections by
default.

  • WebProcess/gtk/WebProcessMainGtk.cpp:
9:39 AM Changeset in webkit [177633] by ap@apple.com
  • 2 edits in trunk/LayoutTests

js/promises-tests/promises-tests-2-3-3.html sometimes crashes under DFG::SpeculativeJIT::compile
​https://bugs.webkit.org/show_bug.cgi?id=139865
rdar://problem/19326058

7:30 AM Changeset in webkit [177632] by g.czajkowski@samsung.com
  • 2 edits in trunk/Tools

[EFL] MiniBrowser steals web view's focus
​https://bugs.webkit.org/show_bug.cgi?id=139482

Reviewed by Gyuyoung Kim.

Although we set focus on ewk_view while MiniBrowser initialization
Ecore steals it in a favor of main window. As a result
focused element on web page is unable to receive events.

  • MiniBrowser/efl/main.c:

(window_create):
Prevent window from stealing web view's focus on start up.

3:31 AM Changeset in webkit [177631] by Manuel Rego Casasnovas
  • 6 edits in trunk/LayoutTests

[CSS Grid Layout] Get rid of legacy WebKitCSSGridLayoutEnabled
​https://bugs.webkit.org/show_bug.cgi?id=139860

Reviewed by Sergio Villar Senin.

Remove the missing bits regarding WebKitCSSGridLayoutEnabled.
Most of it was already removed in r168416.

  • fast/css-grid-layout/grid-item-margin-auto-columns-rows-horizontal-ltr.html:
  • fast/css-grid-layout/grid-item-margin-auto-columns-rows-horizontal-rtl.html:
  • fast/css-grid-layout/grid-item-margin-auto-columns-rows-vertical-ltr.html:
  • fast/css-grid-layout/grid-item-margin-auto-columns-rows-vertical-rtl.html:
  • fast/css-grid-layout/grid-shorthand-get-set.html:
2:38 AM Changeset in webkit [177630] by Chris Dumez
  • 5 edits in trunk/Source/WebCore

Move "Auto" CSS properties to the new StyleBuilder
​https://bugs.webkit.org/show_bug.cgi?id=139858

Reviewed by Antti Koivisto.

Move "Auto" CSS properties from DeprecatedStyleBuilder to the new
StyleBuilder, by adding support in the generator for using hasAutoXXX()
/ setHasAutoXXX() methods on RenderStyle.

No new tests, no web-exposed behavior change.

  • css/CSSPropertyNames.in:
  • css/DeprecatedStyleBuilder.cpp:

(WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder):
(WebCore::ApplyPropertyAuto::setValue): Deleted.
(WebCore::ApplyPropertyAuto::value): Deleted.
(WebCore::ApplyPropertyAuto::hasAuto): Deleted.
(WebCore::ApplyPropertyAuto::setAuto): Deleted.
(WebCore::ApplyPropertyAuto::applyInheritValue): Deleted.
(WebCore::ApplyPropertyAuto::applyInitialValue): Deleted.
(WebCore::ApplyPropertyAuto::applyValue): Deleted.
(WebCore::ApplyPropertyAuto::createHandler): Deleted.

  • css/StyleBuilderCustom.h:

(WebCore::StyleBuilderCustom::applyInitialColumnGap):
(WebCore::StyleBuilderCustom::applyInheritColumnGap):
(WebCore::StyleBuilderCustom::applyValueColumnGap):

  • css/makeprop.pl:

(getNameForMethods):
(getAutoGetter):
(getAutoSetter):
(generateInitialValueSetter):
(generateInheritValueSetter):
(generateValueSetter):

Note: See TracTimeline for information about the timeline view.