⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Dec 24, 2014:

11:50 PM Changeset in webkit [177733] by akling@apple.com
  • 304 edits in trunk/Source/WebCore

Convert more creator functions to return Ref instead of PassRefPtr.
<​https://webkit.org/b/139939>

Reviewed by Darin Adler.

Convert a slew of functions to return Ref<T> instead of PassRefPtr<T>
where the result is guaranteed to never be null.

  • Modules/geolocation/Coordinates.h:

(WebCore::Coordinates::create):
(WebCore::Coordinates::isolatedCopy):

  • Modules/plugins/QuickTimePluginReplacement.mm:

(WebCore::QuickTimePluginReplacement::isolatedWorld):

  • Modules/webaudio/AnalyserNode.h:

(WebCore::AnalyserNode::create):

  • Modules/webaudio/AudioBuffer.cpp:

(WebCore::AudioBuffer::create):
(WebCore::AudioBuffer::createFromAudioFileData):

  • Modules/webaudio/AudioBuffer.h:
  • Modules/webaudio/AudioBufferSourceNode.cpp:

(WebCore::AudioBufferSourceNode::create):

  • Modules/webaudio/AudioBufferSourceNode.h:
  • Modules/webaudio/AudioContext.cpp:

(WebCore::AudioContext::create):

  • Modules/webaudio/AudioContext.h:
  • Modules/webaudio/AudioListener.h:

(WebCore::AudioListener::create):

  • Modules/webaudio/AudioParam.h:

(WebCore::AudioParam::create):

  • Modules/webaudio/BiquadFilterNode.h:

(WebCore::BiquadFilterNode::create):

  • Modules/webaudio/ConvolverNode.h:

(WebCore::ConvolverNode::create):

  • Modules/webaudio/DelayNode.h:

(WebCore::DelayNode::create):

  • Modules/webaudio/DynamicsCompressorNode.h:

(WebCore::DynamicsCompressorNode::create):

  • Modules/webdatabase/ChangeVersionWrapper.h:

(WebCore::ChangeVersionWrapper::create):

  • Modules/webdatabase/DatabaseAuthorizer.cpp:

(WebCore::DatabaseAuthorizer::create):

  • Modules/webdatabase/DatabaseAuthorizer.h:
  • Modules/webdatabase/DatabaseThread.h:

(WebCore::DatabaseThread::create):

  • Modules/websockets/WorkerThreadableWebSocketChannel.cpp:

(WebCore::WorkerThreadableWebSocketChannel::Bridge::send):

  • accessibility/AXObjectCache.cpp:

(WebCore::createFromRenderer):
(WebCore::createFromNode):

  • accessibility/AccessibilityARIAGrid.cpp:

(WebCore::AccessibilityARIAGrid::create):

  • accessibility/AccessibilityARIAGrid.h:
  • accessibility/AccessibilityARIAGridCell.cpp:

(WebCore::AccessibilityARIAGridCell::create):

  • accessibility/AccessibilityARIAGridCell.h:
  • accessibility/AccessibilityARIAGridRow.cpp:

(WebCore::AccessibilityARIAGridRow::create):

  • accessibility/AccessibilityARIAGridRow.h:
  • accessibility/AccessibilityImageMapLink.cpp:

(WebCore::AccessibilityImageMapLink::create):

  • accessibility/AccessibilityImageMapLink.h:
  • accessibility/AccessibilityList.cpp:

(WebCore::AccessibilityList::create):

  • accessibility/AccessibilityList.h:
  • accessibility/AccessibilityListBox.cpp:

(WebCore::AccessibilityListBox::create):

  • accessibility/AccessibilityListBox.h:
  • accessibility/AccessibilityListBoxOption.cpp:

(WebCore::AccessibilityListBoxOption::create):

  • accessibility/AccessibilityListBoxOption.h:
  • accessibility/AccessibilityMediaControls.cpp:

(WebCore::AccessibilityMediaControl::create):
(WebCore::AccessibilityMediaControlsContainer::create):
(WebCore::AccessibilityMediaTimeline::create):
(WebCore::AccessibilityMediaTimeDisplay::create):

  • accessibility/AccessibilityMediaControls.h:
  • accessibility/AccessibilityMenuList.cpp:

(WebCore::AccessibilityMenuList::create):

  • accessibility/AccessibilityMenuList.h:
  • accessibility/AccessibilityMenuListOption.h:
  • accessibility/AccessibilityMenuListPopup.h:
  • accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::create):

  • accessibility/AccessibilityNodeObject.h:
  • accessibility/AccessibilityProgressIndicator.cpp:

(WebCore::AccessibilityProgressIndicator::create):

  • accessibility/AccessibilityProgressIndicator.h:
  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::create):

  • accessibility/AccessibilityRenderObject.h:
  • accessibility/AccessibilitySVGRoot.cpp:

(WebCore::AccessibilitySVGRoot::create):

  • accessibility/AccessibilitySVGRoot.h:
  • accessibility/AccessibilityScrollView.cpp:

(WebCore::AccessibilityScrollView::create):

  • accessibility/AccessibilityScrollView.h:
  • accessibility/AccessibilityScrollbar.cpp:

(WebCore::AccessibilityScrollbar::create):

  • accessibility/AccessibilityScrollbar.h:
  • accessibility/AccessibilitySearchFieldButtons.cpp:

(WebCore::AccessibilitySearchFieldCancelButton::create):

  • accessibility/AccessibilitySearchFieldButtons.h:
  • accessibility/AccessibilitySlider.cpp:

(WebCore::AccessibilitySlider::create):
(WebCore::AccessibilitySliderThumb::create):

  • accessibility/AccessibilitySlider.h:
  • accessibility/AccessibilitySpinButton.cpp:

(WebCore::AccessibilitySpinButton::create):
(WebCore::AccessibilitySpinButtonPart::create):

  • accessibility/AccessibilitySpinButton.h:
  • accessibility/AccessibilityTable.cpp:

(WebCore::AccessibilityTable::create):

  • accessibility/AccessibilityTable.h:
  • accessibility/AccessibilityTableCell.cpp:

(WebCore::AccessibilityTableCell::create):

  • accessibility/AccessibilityTableCell.h:
  • accessibility/AccessibilityTableColumn.cpp:

(WebCore::AccessibilityTableColumn::create):

  • accessibility/AccessibilityTableColumn.h:
  • accessibility/AccessibilityTableHeaderContainer.cpp:

(WebCore::AccessibilityTableHeaderContainer::create):

  • accessibility/AccessibilityTableHeaderContainer.h:
  • accessibility/AccessibilityTableRow.cpp:

(WebCore::AccessibilityTableRow::create):

  • accessibility/AccessibilityTableRow.h:
  • bindings/js/CachedScriptSourceProvider.h:

(WebCore::CachedScriptSourceProvider::create):

  • bindings/js/DOMWrapperWorld.h:

(WebCore::DOMWrapperWorld::create):

  • bindings/js/SerializedScriptValue.cpp:

(WebCore::CloneDeserializer::getJSValue):

  • bindings/objc/DOMCustomXPathNSResolver.h:

(WebCore::DOMCustomXPathNSResolver::create):

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateCallbackHeader):

  • bridge/c/c_instance.h:

(JSC::Bindings::CInstance::create):

  • crypto/CryptoKeyPair.h:

(WebCore::CryptoKeyPair::create):

  • crypto/keys/CryptoKeyAES.h:
  • crypto/keys/CryptoKeyHMAC.h:
  • crypto/keys/CryptoKeyRSA.h:
  • crypto/mac/CryptoKeyRSAMac.cpp:

(WebCore::CryptoKeyRSA::generatePair):

  • css/DOMWindowCSS.cpp:

(WebCore::DOMWindowCSS::create):

  • css/DOMWindowCSS.h:
  • css/DashboardRegion.h:

(WebCore::DashboardRegion::create):

  • css/FontLoader.h:
  • dom/DOMError.h:

(WebCore::DOMError::create):

  • dom/DOMStringList.h:

(WebCore::DOMStringList::create):

  • dom/DataTransfer.cpp:

(WebCore::DataTransfer::createForCopyAndPaste):
(WebCore::DataTransfer::createForDragAndDrop):

  • dom/DataTransfer.h:
  • dom/DeviceMotionData.cpp:

(WebCore::DeviceMotionData::Acceleration::create):
(WebCore::DeviceMotionData::RotationRate::create):
(WebCore::DeviceMotionData::create):

  • dom/DeviceMotionData.h:
  • dom/DeviceOrientationData.cpp:

(WebCore::DeviceOrientationData::create):

  • dom/DeviceOrientationData.h:
  • dom/DocumentMarker.cpp:

(WebCore::DocumentMarkerDescription::create):

  • editing/AlternativeTextController.cpp:

(WebCore::AutocorrectionAlternativeDetails::create):
(WebCore::DictationAlternativeDetails::create):

  • editing/AlternativeTextController.h:

(WebCore::DictationMarkerDetails::create):

  • editing/AppendNodeCommand.h:

(WebCore::AppendNodeCommand::create):

  • editing/ApplyStyleCommand.h:

(WebCore::ApplyStyleCommand::create):

  • editing/BreakBlockquoteCommand.h:

(WebCore::BreakBlockquoteCommand::create):

  • editing/CompositeEditCommand.cpp:

(WebCore::EditCommandComposition::create):

  • editing/CompositeEditCommand.h:
  • editing/CreateLinkCommand.h:

(WebCore::CreateLinkCommand::create):

  • editing/DeleteFromTextNodeCommand.h:

(WebCore::DeleteFromTextNodeCommand::create):

  • editing/DeleteSelectionCommand.h:

(WebCore::DeleteSelectionCommand::create):

  • editing/DictationCommand.cpp:

(WebCore::DictationMarkerSupplier::create):

  • editing/DictationCommand.h:

(WebCore::DictationCommand::create):

  • editing/EditingStyle.h:

(WebCore::EditingStyle::create):

  • editing/Editor.cpp:

(WebCore::Editor::applyStyle):
(WebCore::Editor::applyParagraphStyle):

  • editing/FormatBlockCommand.h:

(WebCore::FormatBlockCommand::create):

  • editing/IndentOutdentCommand.h:

(WebCore::IndentOutdentCommand::create):

  • editing/InsertIntoTextNodeCommand.h:

(WebCore::InsertIntoTextNodeCommand::create):

  • editing/InsertLineBreakCommand.h:

(WebCore::InsertLineBreakCommand::create):

  • editing/InsertNodeBeforeCommand.h:

(WebCore::InsertNodeBeforeCommand::create):

  • editing/InsertParagraphSeparatorCommand.h:

(WebCore::InsertParagraphSeparatorCommand::create):

  • editing/InsertTextCommand.h:

(WebCore::InsertTextCommand::create):
(WebCore::InsertTextCommand::createWithMarkerSupplier):

  • editing/MergeIdenticalElementsCommand.h:

(WebCore::MergeIdenticalElementsCommand::create):

  • editing/ModifySelectionListLevel.h:

(WebCore::IncreaseSelectionListLevelCommand::create):
(WebCore::DecreaseSelectionListLevelCommand::create):

  • editing/MoveSelectionCommand.h:

(WebCore::MoveSelectionCommand::create):

  • editing/RemoveCSSPropertyCommand.h:

(WebCore::RemoveCSSPropertyCommand::create):

  • editing/RemoveFormatCommand.h:

(WebCore::RemoveFormatCommand::create):

  • editing/RemoveNodeCommand.h:

(WebCore::RemoveNodeCommand::create):

  • editing/RemoveNodePreservingChildrenCommand.h:

(WebCore::RemoveNodePreservingChildrenCommand::create):

  • editing/ReplaceNodeWithSpanCommand.h:

(WebCore::ReplaceNodeWithSpanCommand::create):

  • editing/ReplaceSelectionCommand.h:

(WebCore::ReplaceSelectionCommand::create):

  • editing/SetNodeAttributeCommand.h:

(WebCore::SetNodeAttributeCommand::create):

  • editing/SetSelectionCommand.h:

(WebCore::SetSelectionCommand::create):

  • editing/SimplifyMarkupCommand.h:

(WebCore::SimplifyMarkupCommand::create):

  • editing/SpellChecker.cpp:

(WebCore::SpellCheckRequest::create):

  • editing/SpellChecker.h:
  • editing/SpellingCorrectionCommand.cpp:

(WebCore::SpellingCorrectionRecordUndoCommand::create):

  • editing/SpellingCorrectionCommand.h:

(WebCore::SpellingCorrectionCommand::create):

  • editing/SplitElementCommand.h:

(WebCore::SplitElementCommand::create):

  • editing/SplitTextNodeCommand.h:

(WebCore::SplitTextNodeCommand::create):

  • editing/SplitTextNodeContainingElementCommand.h:

(WebCore::SplitTextNodeContainingElementCommand::create):

  • editing/TypingCommand.h:

(WebCore::TypingCommand::create):

  • editing/UnlinkCommand.h:

(WebCore::UnlinkCommand::create):

  • editing/WrapContentsInDummySpanCommand.h:

(WebCore::WrapContentsInDummySpanCommand::create):

  • editing/ios/DictationCommandIOS.h:

(WebCore::DictationCommandIOS::create):

  • fileapi/Blob.h:

(WebCore::Blob::create):
(WebCore::Blob::deserialize):
(WebCore::Blob::slice):

  • fileapi/File.h:
  • fileapi/FileList.h:

(WebCore::FileList::create):

  • fileapi/FileReader.cpp:

(WebCore::FileReader::create):

  • fileapi/FileReader.h:
  • fileapi/FileReaderSync.h:

(WebCore::FileReaderSync::create):

  • history/BackForwardList.h:

(WebCore::BackForwardList::create):

  • history/HistoryItem.h:

(WebCore::HistoryItem::create):

  • html/DOMURL.cpp:

(WebCore::DOMURL::create):

  • html/DOMURL.h:
  • html/HTMLPlugInImageElement.cpp:

(WebCore::plugInImageElementIsolatedWorld):

  • html/canvas/CanvasGradient.h:

(WebCore::CanvasGradient::create):

  • html/canvas/CanvasPattern.cpp:

(WebCore::CanvasPattern::create):

  • html/canvas/CanvasPattern.h:
  • html/canvas/DOMPath.h:
  • html/shadow/DetailsMarkerControl.cpp:

(WebCore::DetailsMarkerControl::create):

  • html/shadow/DetailsMarkerControl.h:
  • html/track/AudioTrack.h:
  • html/track/AudioTrackList.h:
  • html/track/DataCue.h:
  • inspector/CommandLineAPIHost.cpp:

(WebCore::CommandLineAPIHost::create):

  • inspector/CommandLineAPIHost.h:
  • loader/DocumentLoader.h:

(WebCore::DocumentLoader::create):

  • loader/FormState.cpp:

(WebCore::FormState::create):

  • loader/FormState.h:
  • loader/FormSubmission.cpp:

(WebCore::FormSubmission::create):

  • loader/FormSubmission.h:
  • loader/TextResourceDecoder.h:

(WebCore::TextResourceDecoder::create):

  • loader/ThreadableLoaderClientWrapper.h:

(WebCore::ThreadableLoaderClientWrapper::create):

  • loader/WorkerThreadableLoader.h:

(WebCore::WorkerThreadableLoader::create):

  • loader/appcache/ApplicationCache.h:

(WebCore::ApplicationCache::create):

  • loader/appcache/ApplicationCacheResource.h:

(WebCore::ApplicationCacheResource::create):

  • loader/appcache/DOMApplicationCache.h:
  • loader/archive/ArchiveResource.cpp:

(WebCore::ArchiveResource::create):

  • loader/archive/ArchiveResource.h:
  • loader/icon/IconDatabaseBase.h:

(WebCore::EnumCallback::create):
(WebCore::ObjectCallback::create):

  • loader/icon/IconRecord.h:

(WebCore::IconRecord::create):

  • mathml/MathMLInlineContainerElement.cpp:

(WebCore::MathMLInlineContainerElement::create):

  • mathml/MathMLInlineContainerElement.h:
  • mathml/MathMLMathElement.cpp:

(WebCore::MathMLMathElement::create):

  • mathml/MathMLMathElement.h:
  • mathml/MathMLMencloseElement.cpp:

(WebCore::MathMLMencloseElement::create):

  • mathml/MathMLMencloseElement.h:
  • mathml/MathMLSelectElement.cpp:

(WebCore::MathMLSelectElement::create):

  • mathml/MathMLSelectElement.h:
  • mathml/MathMLTextElement.cpp:

(WebCore::MathMLTextElement::create):

  • mathml/MathMLTextElement.h:
  • page/BarProp.h:

(WebCore::BarProp::create):

  • page/Crypto.h:

(WebCore::Crypto::create):

  • page/DOMSecurityPolicy.h:

(WebCore::DOMSecurityPolicy::create):

  • page/DOMSelection.h:

(WebCore::DOMSelection::create):

  • page/DOMWindow.h:
  • page/DOMWindowExtension.h:

(WebCore::DOMWindowExtension::create):

  • page/FrameView.cpp:

(WebCore::FrameView::create):

  • page/FrameView.h:
  • page/animation/CompositeAnimation.h:

(WebCore::CompositeAnimation::create):

  • page/scrolling/AsyncScrollingCoordinator.h:
  • platform/Cursor.h:

(WebCore::SharedCursor::create):

  • platform/FileChooser.cpp:

(WebCore::FileChooser::create):

  • platform/FileChooser.h:
  • platform/animation/Animation.h:

(WebCore::Animation::create):

  • platform/audio/AudioBus.cpp:

(WebCore::AudioBus::create):
(WebCore::AudioBus::createBufferFromRange):
(WebCore::AudioBus::createBySampleRateConverting):
(WebCore::AudioBus::createByMixingToMono):

  • platform/audio/AudioBus.h:
  • platform/audio/AudioHardwareListener.cpp:

(WebCore::AudioHardwareListener::create):

  • platform/audio/AudioHardwareListener.h:
  • platform/audio/mac/AudioHardwareListenerMac.cpp:

(WebCore::AudioHardwareListener::create):
(WebCore::AudioHardwareListenerMac::create):

  • platform/audio/mac/AudioHardwareListenerMac.h:
  • platform/graphics/AudioTrackPrivate.h:

(WebCore::AudioTrackPrivate::create):

  • platform/graphics/BitmapImage.h:
  • platform/graphics/CrossfadeGeneratedImage.h:
  • platform/graphics/FontFeatureSettings.h:

(WebCore::FontFeatureSettings::create):

  • platform/graphics/Image.cpp:

(WebCore::Image::nullImage):

  • platform/graphics/avfoundation/AudioSourceProviderAVFObjC.h:
  • platform/graphics/avfoundation/AudioSourceProviderAVFObjC.mm:

(WebCore::AudioSourceProviderAVFObjC::create):

  • platform/graphics/filters/DistantLightSource.h:

(WebCore::DistantLightSource::create):

  • platform/graphics/filters/FEBlend.cpp:

(WebCore::FEBlend::create):

  • platform/graphics/filters/FEBlend.h:
  • platform/graphics/filters/FEColorMatrix.cpp:

(WebCore::FEColorMatrix::create):

  • platform/graphics/filters/FEColorMatrix.h:
  • platform/graphics/filters/FEComponentTransfer.cpp:

(WebCore::FEComponentTransfer::create):

  • platform/graphics/filters/FEComponentTransfer.h:
  • platform/graphics/filters/FEComposite.cpp:

(WebCore::FEComposite::create):

  • platform/graphics/filters/FEComposite.h:
  • platform/graphics/filters/FEConvolveMatrix.cpp:

(WebCore::FEConvolveMatrix::create):

  • platform/graphics/filters/FEConvolveMatrix.h:
  • platform/graphics/filters/FEDiffuseLighting.cpp:

(WebCore::FEDiffuseLighting::create):

  • platform/graphics/filters/FEDiffuseLighting.h:
  • platform/graphics/filters/FEDisplacementMap.cpp:

(WebCore::FEDisplacementMap::create):

  • platform/graphics/filters/FEDisplacementMap.h:
  • platform/graphics/filters/FEDropShadow.cpp:

(WebCore::FEDropShadow::create):

  • platform/graphics/filters/FEDropShadow.h:
  • platform/graphics/filters/FEFlood.cpp:

(WebCore::FEFlood::create):

  • platform/graphics/filters/FEFlood.h:
  • platform/graphics/filters/FEGaussianBlur.cpp:

(WebCore::FEGaussianBlur::create):

  • platform/graphics/filters/FEGaussianBlur.h:
  • platform/graphics/filters/FEMerge.cpp:

(WebCore::FEMerge::create):

  • platform/graphics/filters/FEMerge.h:
  • platform/graphics/filters/FEMorphology.cpp:

(WebCore::FEMorphology::create):

  • platform/graphics/filters/FEMorphology.h:
  • platform/graphics/filters/FEOffset.cpp:

(WebCore::FEOffset::create):

  • platform/graphics/filters/FEOffset.h:
  • platform/graphics/filters/FESpecularLighting.cpp:

(WebCore::FESpecularLighting::create):

  • platform/graphics/filters/FESpecularLighting.h:
  • platform/graphics/filters/FETile.cpp:

(WebCore::FETile::create):

  • platform/graphics/filters/FETile.h:
  • platform/graphics/filters/FETurbulence.cpp:

(WebCore::FETurbulence::create):

  • platform/graphics/filters/FETurbulence.h:
  • platform/graphics/ios/DisplayRefreshMonitorIOS.h:

(WebCore::DisplayRefreshMonitorIOS::create):

  • platform/graphics/mac/ComplexTextController.h:

(WebCore::ComplexTextController::ComplexTextRun::create):

  • platform/network/BlobData.h:

(WebCore::RawData::create):
(WebCore::BlobData::create):

  • platform/network/BlobDataFileReference.h:

(WebCore::BlobDataFileReference::create):

  • platform/network/cf/FormDataStreamCFNet.cpp:
  • platform/text/BidiContext.cpp:

(WebCore::BidiContext::createUncached):
(WebCore::BidiContext::create):

  • platform/text/BidiContext.h:
  • plugins/DOMMimeType.h:

(WebCore::DOMMimeType::create):

  • plugins/DOMMimeTypeArray.cpp:

(WebCore::DOMMimeTypeArray::item):
(WebCore::DOMMimeTypeArray::namedItem):

  • plugins/DOMMimeTypeArray.h:

(WebCore::DOMMimeTypeArray::create):

  • plugins/DOMPlugin.cpp:

(WebCore::DOMPlugin::item):
(WebCore::DOMPlugin::namedItem):

  • plugins/DOMPlugin.h:

(WebCore::DOMPlugin::create):

  • plugins/DOMPluginArray.cpp:

(WebCore::DOMPluginArray::item):
(WebCore::DOMPluginArray::namedItem):

  • plugins/DOMPluginArray.h:

(WebCore::DOMPluginArray::create):

  • plugins/PluginData.h:

(WebCore::PluginData::create):

  • rendering/ClipPathOperation.h:
  • rendering/CounterNode.cpp:

(WebCore::CounterNode::create):

  • rendering/CounterNode.h:
  • rendering/style/BasicShapes.h:
  • rendering/style/CursorList.h:

(WebCore::CursorList::create):

  • replay/CapturingInputCursor.cpp:

(WebCore::CapturingInputCursor::create):

  • replay/CapturingInputCursor.h:
  • storage/Storage.cpp:

(WebCore::Storage::create):

  • storage/Storage.h:
  • storage/StorageAreaImpl.cpp:

(WebCore::StorageAreaImpl::create):

  • storage/StorageAreaImpl.h:
  • storage/StorageAreaSync.cpp:

(WebCore::StorageAreaSync::create):

  • storage/StorageAreaSync.h:
  • storage/StorageMap.cpp:

(WebCore::StorageMap::create):

  • storage/StorageMap.h:
  • storage/StorageSyncManager.cpp:

(WebCore::StorageSyncManager::create):

  • storage/StorageSyncManager.h:
  • workers/DedicatedWorkerGlobalScope.cpp:

(WebCore::DedicatedWorkerGlobalScope::create):

  • workers/DedicatedWorkerGlobalScope.h:
  • workers/DedicatedWorkerThread.cpp:

(WebCore::DedicatedWorkerThread::create):
(WebCore::DedicatedWorkerThread::createWorkerGlobalScope):

  • workers/DedicatedWorkerThread.h:
  • workers/DefaultSharedWorkerRepository.cpp:
  • workers/SharedWorkerGlobalScope.cpp:

(WebCore::SharedWorkerGlobalScope::create):

  • workers/SharedWorkerGlobalScope.h:
  • workers/SharedWorkerThread.cpp:

(WebCore::SharedWorkerThread::create):
(WebCore::SharedWorkerThread::createWorkerGlobalScope):

  • workers/SharedWorkerThread.h:
  • workers/WorkerGlobalScope.cpp:

(WebCore::WorkerGlobalScope::importScripts):

  • workers/WorkerLocation.h:

(WebCore::WorkerLocation::create):

  • workers/WorkerScriptLoader.h:

(WebCore::WorkerScriptLoader::create):

  • workers/WorkerThread.h:
  • xml/DOMParser.h:

(WebCore::DOMParser::create):

  • xml/NativeXPathNSResolver.h:

(WebCore::NativeXPathNSResolver::create):

  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::create):

  • xml/XMLHttpRequest.h:
  • xml/XMLHttpRequestProgressEventThrottle.cpp:

(WebCore::XMLHttpRequestProgressEventThrottle::flushProgressEvent):

  • xml/XMLSerializer.h:

(WebCore::XMLSerializer::create):

  • xml/XPathEvaluator.h:

(WebCore::XPathEvaluator::create):

  • xml/XPathResult.h:

(WebCore::XPathResult::create):

  • xml/XSLStyleSheet.h:
  • xml/XSLTProcessor.h:

(WebCore::XSLTProcessor::create):

10:28 PM Changeset in webkit [177732] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit2

[Cocoa] WebKit private headers shouldn’t contain “inappropriate” macros
​https://bugs.webkit.org/show_bug.cgi?id=139942

Reviewed by Darin Adler.

  • WebKit2.xcodeproj/project.pbxproj: In the Check For Inappropriate Macros in External

Headers script build phase, check the PrivateHeaders directory as well.

10:26 PM Changeset in webkit [177731] by mitz@apple.com
  • 4 edits in trunk/Tools

Engineering builds of MiniBrowser ignore deprecated declaration warnings
​https://bugs.webkit.org/show_bug.cgi?id=139941

Reviewed by Darin Adler.

  • MiniBrowser/Configurations/Base.xcconfig: Added semicolon.
  • MiniBrowser/Configurations/DebugRelease.xcconfig: Set GCC_WARN_ABOUT_DEPRECATED_FUNCTIONS

to YES.

  • MiniBrowser/mac/AppDelegate.m:

(-[BrowserAppDelegate openDocument:]): Use NSFileHandlingPanelOKButton instead of
deprecated NSOKButton.

6:48 PM Changeset in webkit [177730] by benjamin@webkit.org
  • 2 edits in trunk/Source/WebCore

Small cleanup of RenderBlock::paint()
​https://bugs.webkit.org/show_bug.cgi?id=139849

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2014-12-24
Reviewed by Daniel Bates.

Remove a couple of instructions by putting variable in the right scope.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::paint):

6:46 PM Changeset in webkit [177729] by benjamin@webkit.org
  • 3 edits in trunk/Source/WTF

Simplify saturated integer add/sub
​https://bugs.webkit.org/show_bug.cgi?id=139854

Reviewed by Darin Adler.

  • wtf/Compiler.h:

Make a wrapper for has_builtin for compilers that do not support it.

  • wtf/SaturatedArithmetic.h:

(saturatedAddition):
(saturatedSubtraction):
Use the builtins when possible instead of reinventing the wheel.
On ARMv7, use the saturated math instructions.

6:31 PM Changeset in webkit [177728] by benjamin@webkit.org
  • 1 edit
    4 adds in trunk/LayoutTests

Import the tests for :valid/:invalid on form/fieldset from blink
​https://bugs.webkit.org/show_bug.cgi?id=139899

Reviewed by Darin Adler.

blink's tests are incredibly basic but it is better to include them
for completeness.

  • fast/forms/fieldset-pseudo-valid-style-expected.txt: Added.
  • fast/forms/fieldset-pseudo-valid-style.html: Added.
  • fast/forms/form-pseudo-valid-style-expected.txt: Added.
  • fast/forms/form-pseudo-valid-style.html: Added.

Both tests are from Bartek Nowierski.

4:54 PM Changeset in webkit [177727] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

W3C test importer should have an option to disable testharness.js/testharnessreport.js link conversion
​https://bugs.webkit.org/show_bug.cgi?id=134763

Patch by Youenn Fablet <​youenn.fablet@crf.canon.fr> on 2014-12-24
Reviewed by Ryosuke Niwa.

Adding an option to disable test harness link conversion.

  • Scripts/webkitpy/w3c/test_converter.py:

(convert_for_webkit):
(_W3CTestConverter.init):
(_W3CTestConverter.convert_attributes_if_needed):

  • Scripts/webkitpy/w3c/test_importer.py:

(parse_args):
(TestImporter.import_tests):

4:21 PM Changeset in webkit [177726] by mitz@apple.com
  • 5 edits in trunk/Source/WebCore

[Cocoa] WebCoreSystemInterface.h declares two unused symbols
​https://bugs.webkit.org/show_bug.cgi?id=139937

Reviewed by Tim Horton.

  • platform/graphics/FontPlatformData.h: Removed unused typedefs.
  • platform/graphics/mac/FontCustomPlatformData.cpp:

(WebCore::createFontCustomPlatformData): Stop passing always-zero containerRef parameter to
FontCustomPlatformData constructor.

  • platform/graphics/mac/FontCustomPlatformData.h: Removed unused typedefs.

(WebCore::FontCustomPlatformData::FontCustomPlatformData): Removed unused container
parameter and m_atsContainer member variable.

  • platform/mac/WebCoreSystemInterface.h: Removed unused typedefs and symbols.
3:21 PM Changeset in webkit [177725] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit2

Addressed a linker warning about the definition of a method in a category overridng a method from the class.

  • UIProcess/API/mac/WKView.mm:

(-[WKView(Private) _targetWindowForMovePreparation]): Deleted. This was identical to the
definition in the main WKView implementation above.

3:10 PM Changeset in webkit [177724] by mitz@apple.com
  • 2 edits in trunk/Source/ThirdParty/ANGLE

ANGLE extern symbols are not hidden by default, but should be
​https://bugs.webkit.org/show_bug.cgi?id=139936

Reviewed by Mark Rowe.

  • Configurations/Base.xcconfig: Changed GCC_SYMBOLS_PRIVATE_EXTERN to YES.
2:39 PM Changeset in webkit [177723] by mitz@apple.com
  • 2 edits in trunk/Source/ThirdParty/ANGLE

Removed the Derived Sources target.

It has been empty since r159533.

  • ANGLE.xcodeproj/project.pbxproj:
12:34 AM Changeset in webkit [177722] by ap@apple.com
  • 3 edits in trunk/Tools

DumpRenderTree crashes are mis-reported as timeouts on Yosemite
​https://bugs.webkit.org/show_bug.cgi?id=139933

Reviewed by Daniel Bates.

Crash logs take a very long time to be generated on Yosemite (rdar://problem/18701447),
and there is no way for run-webkit-tests to tell a crashed process from a frozen one
until ReportCrash lets it go.

Reuse existing machinery that tells run-webkit-tests about crashes. The script may
even get the actual crash log eventually - even when it times out waiting for the log, it
makes a second lookup at the very end, after all tests finish. There may be further
improvements needed here, but this small fix addresses most cases that happen in practice.

  • DumpRenderTree/mac/DumpRenderTree.mm:

(writeCrashedMessageOnFatalError):
(dumpRenderTree):
Removed PLATFORM(IOS) ifdefs, this code is just as helpful on Mac.

  • Scripts/webkitpy/port/driver.py: (Driver._check_for_driver_crash): Removed an

unhelpful comment.

Dec 23, 2014:

9:34 PM Changeset in webkit [177721] by ChangSeok Oh
  • 19 edits
    2 moves in trunk/Source/WebKit2

[GTK] Build fix after r177692
​https://bugs.webkit.org/show_bug.cgi?id=139919

Reviewed by Gyuyoung Kim.

This change addresses build failures introduced after r177692.

  • PlatformEfl.cmake: Renamed WebContextSoup to WebProcessPoolSoup.cpp
  • PlatformGTK.cmake: ditto.
  • UIProcess/API/gtk/PageClientImpl.cpp:
  • UIProcess/API/gtk/WebKitDownloadClient.cpp:
  • UIProcess/API/gtk/WebKitFormSubmissionRequest.cpp:

(webkitFormSubmissionRequestCreate):
(webkit_form_submission_request_get_text_fields):

  • UIProcess/API/gtk/WebKitFormSubmissionRequestPrivate.h:
  • UIProcess/API/gtk/WebKitInjectedBundleClient.cpp:

(didReceiveWebViewMessageFromInjectedBundle):
(didReceiveMessageFromInjectedBundle):

  • UIProcess/API/gtk/WebKitSecurityManager.cpp:

(registerSecurityPolicyForURIScheme):

  • UIProcess/API/gtk/WebKitWebContext.cpp:

(webkitWebContextConstructed):
(webkit_web_context_prefetch_dns):
(webkitWebContextGetContext):

  • UIProcess/API/gtk/WebKitWebContextPrivate.h:
  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkit_web_view_get_snapshot):

  • UIProcess/API/gtk/WebKitWebViewBase.cpp:

(webkitWebViewBaseCreate):
(webkitWebViewBaseCreateWebPage):

  • UIProcess/API/gtk/WebKitWebViewBasePrivate.h:
  • UIProcess/API/gtk/WebKitWindowProperties.cpp:
  • UIProcess/gtk/WebInspectorProxyGtk.cpp:

(WebKit::WebInspectorProxy::platformCreateInspectorPage):

  • UIProcess/gtk/WebProcessPoolGtk.cpp: Renamed from Source/WebKit2/UIProcess/gtk/WebContextGtk.cpp.

(WebKit::initInspectorServer):
(WebKit::WebProcessPool::platformDefaultApplicationCacheDirectory):
(WebKit::WebProcessPool::platformInitializeWebProcess):
(WebKit::WebProcessPool::platformInvalidateContext):
(WebKit::WebProcessPool::platformDefaultWebSQLDatabaseDirectory):
(WebKit::WebProcessPool::platformDefaultIndexedDBDatabaseDirectory):
(WebKit::WebProcessPool::platformDefaultIconDatabasePath):
(WebKit::WebProcessPool::platformDefaultLocalStorageDirectory):
(WebKit::WebProcessPool::platformDefaultMediaKeysStorageDirectory):
(WebKit::WebProcessPool::platformDefaultDiskCacheDirectory):
(WebKit::WebProcessPool::platformDefaultCookieStorageDirectory):
(WebKit::WebProcessPool::setIgnoreTLSErrors):

  • UIProcess/soup/WebProcessPoolSoup.cpp: Renamed from Source/WebKit2/UIProcess/soup/WebContextSoup.cpp.

(WebKit::WebProcessPool::platformInitializeNetworkProcess):

  • WebProcess/InjectedBundle/API/gtk/WebKitWebExtension.cpp:

(webkitWebExtensionDidReceiveMessage):

  • WebProcess/InjectedBundle/API/gtk/WebKitWebPage.cpp:

(didInitiateLoadForResource):
(willSendRequestForFrame):
(didReceiveResponseForResource):
(didReceiveContentLengthForResource):
(didFinishLoadForResource):
(didFailLoadForResource):
(webkitWebPageDidReceiveMessage):

  • WebProcess/InjectedBundle/API/gtk/WebKitWebPagePrivate.h:
8:58 PM Changeset in webkit [177720] by Chris Dumez
  • 2 edits in trunk/Source/WebCore

Simplify RenderStyle::invalidColor() function
​https://bugs.webkit.org/show_bug.cgi?id=139898

Reviewed by Andreas Kling.

Simplify RenderStyle::invalidColor() function by getting rid of the
static variable. The default constructor for Color is very cheap
anyway.

  • rendering/style/RenderStyle.h:
8:50 PM Changeset in webkit [177719] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit2

iOS build fix

  • UIProcess/API/Cocoa/WKProcessGroup.mm:

(-[WKProcessGroup _geolocationProvider]):

8:43 PM Changeset in webkit [177718] by ap@apple.com
  • 2 edits in trunk/Tools

Don't force -O1 for debug ASan builds
​https://bugs.webkit.org/show_bug.cgi?id=139926

Reviewed by Darin Adler.

  • asan/asan.xcconfig:
8:33 PM Changeset in webkit [177717] by ljaehun.lim@samsung.com
  • 2 edits in trunk/Source/WebCore

Unreviewed, fix build warning after r177712

../../Source/WebCore/history/PageCache.cpp: In function ‘const char* WebCore::pruningReasonToFeatureCounterKey(WebCore::PruningReason)’:
../../Source/WebCore/history/PageCache.cpp:449:1: error: control reaches end of non-void function [-Werror=return-type]

No new tests, no behavior changes.

  • history/PageCache.cpp:

(WebCore::pruningReasonToFeatureCounterKey):

8:09 PM Changeset in webkit [177716] by gyuyoung.kim@samsung.com
  • 22 edits in trunk/Source/WebKit2

[EFL][WK2] Fix a lot of build break since r177692
​https://bugs.webkit.org/show_bug.cgi?id=139932

Unreviewed EFL build fix.

Rename WebContext with WebProcessPool in EFL port files.

  • CMakeLists.txt:
  • UIProcess/API/efl/EwkView.cpp:
  • UIProcess/API/efl/ewk_context.cpp:
  • UIProcess/API/efl/tests/test_ewk2_context.cpp:

(TEST_F):

  • UIProcess/CoordinatedGraphics/WebView.cpp:

(WebKit::WebView::WebView):

  • UIProcess/CoordinatedGraphics/WebView.h:
  • UIProcess/Network/CustomProtocols/soup/CustomProtocolManagerProxySoup.cpp:

(WebKit::CustomProtocolManagerProxy::CustomProtocolManagerProxy):
(WebKit::CustomProtocolManagerProxy::startLoading):
(WebKit::CustomProtocolManagerProxy::stopLoading):

  • UIProcess/Network/CustomProtocols/soup/WebSoupCustomProtocolRequestManager.cpp:

(WebKit::WebSoupCustomProtocolRequestManager::create):
(WebKit::WebSoupCustomProtocolRequestManager::WebSoupCustomProtocolRequestManager):
(WebKit::WebSoupCustomProtocolRequestManager::registerSchemeForCustomProtocol):
(WebKit::WebSoupCustomProtocolRequestManager::unregisterSchemeForCustomProtocol):
(WebKit::WebSoupCustomProtocolRequestManager::didReceiveResponse):
(WebKit::WebSoupCustomProtocolRequestManager::didLoadData):
(WebKit::WebSoupCustomProtocolRequestManager::didFailWithError):
(WebKit::WebSoupCustomProtocolRequestManager::didFinishLoading):

  • UIProcess/Network/CustomProtocols/soup/WebSoupCustomProtocolRequestManager.h:
  • UIProcess/WebBatteryManagerProxy.cpp:

(WebKit::WebBatteryManagerProxy::create):
(WebKit::WebBatteryManagerProxy::WebBatteryManagerProxy):
(WebKit::WebBatteryManagerProxy::providerDidChangeBatteryStatus):
(WebKit::WebBatteryManagerProxy::providerUpdateBatteryStatus):

  • UIProcess/WebBatteryManagerProxy.h:
  • UIProcess/WebTextChecker.cpp:

(WebKit::updateStateForAllContexts):

  • UIProcess/WebVibrationProxy.cpp:

(WebKit::WebVibrationProxy::WebVibrationProxy):
(WebKit::WebVibrationProxy::~WebVibrationProxy):

  • UIProcess/efl/RequestManagerClientEfl.h:
  • UIProcess/efl/WebContextEfl.cpp:

(WebKit::WebProcessPool::platformDefaultApplicationCacheDirectory):
(WebKit::WebProcessPool::platformInitializeWebProcess):
(WebKit::WebProcessPool::platformInvalidateContext):
(WebKit::WebProcessPool::platformDefaultWebSQLDatabaseDirectory):
(WebKit::WebProcessPool::platformDefaultIndexedDBDatabaseDirectory):
(WebKit::WebProcessPool::platformDefaultIconDatabasePath):
(WebKit::WebProcessPool::platformDefaultLocalStorageDirectory):
(WebKit::WebProcessPool::platformDefaultMediaKeysStorageDirectory):
(WebKit::WebProcessPool::platformDefaultDiskCacheDirectory):
(WebKit::WebProcessPool::platformDefaultCookieStorageDirectory):
(WebKit::WebProcessPool::setIgnoreTLSErrors):
(WebKit::WebContext::platformDefaultApplicationCacheDirectory): Deleted.
(WebKit::WebContext::platformInitializeWebProcess): Deleted.
(WebKit::WebContext::platformInvalidateContext): Deleted.
(WebKit::WebContext::platformDefaultWebSQLDatabaseDirectory): Deleted.
(WebKit::WebContext::platformDefaultIndexedDBDatabaseDirectory): Deleted.
(WebKit::WebContext::platformDefaultIconDatabasePath): Deleted.
(WebKit::WebContext::platformDefaultLocalStorageDirectory): Deleted.
(WebKit::WebContext::platformDefaultMediaKeysStorageDirectory): Deleted.
(WebKit::WebContext::platformDefaultDiskCacheDirectory): Deleted.
(WebKit::WebContext::platformDefaultCookieStorageDirectory): Deleted.
(WebKit::WebContext::setIgnoreTLSErrors): Deleted.

  • UIProcess/efl/WebInspectorProxyEfl.cpp:

(WebKit::WebInspectorProxy::platformCreateInspectorPage):

  • UIProcess/efl/WebViewEfl.cpp:

(WebKit::WebView::create):
(WebKit::WebViewEfl::WebViewEfl):

  • UIProcess/efl/WebViewEfl.h:
  • UIProcess/soup/WebContextSoup.cpp:

(WebKit::WebProcessPool::platformInitializeNetworkProcess):
(WebKit::WebContext::platformInitializeNetworkProcess): Deleted.

  • UIProcess/soup/WebCookieManagerProxySoup.cpp:

(WebKit::WebCookieManagerProxy::setCookiePersistentStorage):

  • UIProcess/soup/WebSoupRequestManagerProxy.h:
7:09 PM Changeset in webkit [177715] by weinig@apple.com
  • 4 edits in trunk/Source/WebKit2

Remove telephone number context support from ContextMenuContextData, it is unused
​https://bugs.webkit.org/show_bug.cgi?id=139931

Reviewed by Alexey Proskuryakov.

m_isTelephoneNumberContext was only ever set to true in the ContextMenuContextData
constructor that took a TelephoneNumberContextTag, which never got called. Remove it
all.

  • Shared/ContextMenuContextData.cpp:

(WebKit::ContextMenuContextData::ContextMenuContextData):
(WebKit::ContextMenuContextData::encode):
(WebKit::ContextMenuContextData::decode):

  • Shared/ContextMenuContextData.h:

(WebKit::ContextMenuContextData::ContextMenuContextData):
(WebKit::ContextMenuContextData::isTelephoneNumberContext): Deleted.

  • UIProcess/mac/WebContextMenuProxyMac.mm:

(WebKit::WebContextMenuProxyMac::showContextMenu):

6:51 PM Changeset in webkit [177714] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

Attempt to fix the Mountain Lion build.

  • Shared/ContextMenuContextData.h:

(WebKit::ContextMenuContextData::isTelephoneNumberContext):

5:20 PM Changeset in webkit [177713] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

Handle WKTypeRefWrapper when converting object graphs
​https://bugs.webkit.org/show_bug.cgi?id=139927

Reviewed by Tim Horton.

  • UIProcess/Cocoa/WebProcessProxyCocoa.mm:

(WebKit::WebProcessProxy::transformHandlesToObjects):
(WebKit::WebProcessProxy::transformObjectsToHandles):

  • WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::WebProcess::transformHandlesToObjects):
(WebKit::WebProcess::transformObjectsToHandles):

5:14 PM Changeset in webkit [177712] by Chris Dumez
  • 11 edits in trunk/Source

[iOS] Log better using FeatureCounter why PageCache is failing due to pruned resources
​https://bugs.webkit.org/show_bug.cgi?id=139921
<rdar://problem/19255690>

Reviewed by Gavin Barraclough.

Source/WebCore:

Log better using FeatureCounter why PageCache is failing due to pruned
resources. In particular, we now distinguish if the resource was pruned
due to:

  • Memory pressure
  • Page cache capacity reached
  • WebProcess suspended (WK2)
  • WebCore.exp.in:
  • history/HistoryItem.cpp:

(WebCore::HistoryItem::HistoryItem):

  • history/HistoryItem.h:
  • history/PageCache.cpp:

(WebCore::PageCache::pruneToCapacityNow):
(WebCore::PageCache::setCapacity):
(WebCore::pruningReasonToFeatureCounterKey):
(WebCore::PageCache::add):
(WebCore::PageCache::take):
(WebCore::PageCache::get):
(WebCore::PageCache::prune):

  • history/PageCache.h:
  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::commitProvisionalLoad):

  • platform/FeatureCounterKeys.h:
  • platform/MemoryPressureHandler.cpp:

(WebCore::MemoryPressureHandler::releaseCriticalMemory):

Source/WebKit2:

Call PageCache::pruneToCapacityNow() instead of multiple calls to
setCapacity() as it does exactly what we want. Also pass the new
PrunedReason argument so help us do better logging.

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::releasePageCache):

5:11 PM Changeset in webkit [177711] by akling@apple.com
  • 2 edits in trunk/Source/WebCore

[Mac] Fix nullptr dereference in EventHandler::platformPrepareForWheelEvents().
<​https://webkit.org/b/139923>
<rdar://problem/19182531>

Reviewed by Chris Dumez.

Don't dereference 'wheelEventTarget' until we know it's non-null.
This manifested as a crash in Node::renderBox() with some versions of LLVM.

The compiler was free to assume that the ContainerNode* 'candidate' in
findEnclosingScrollableContainer() would always be non-null on the first
iteration of the loop.

I suspect that we can get here with a null 'wheelEventTarget' during the
rubberbanding phase of a wheel scroll; if the cursor is sitting over the
exposed "gutter" area.

  • page/mac/EventHandlerMac.mm:

(WebCore::findEnclosingScrollableContainer):
(WebCore::EventHandler::platformPrepareForWheelEvents):

5:09 PM Changeset in webkit [177710] by weinig@apple.com
  • 3 edits in trunk/Source/WebKit2

Attempt to fix the iOS build.

  • UIProcess/API/Cocoa/WKProcessGroup.mm:

(-[WKProcessGroup _geolocationProvider]):

  • UIProcess/API/ios/WKViewIOS.mm:

(-[WKView _commonInitializationWithContextRef:pageGroupRef:relatedToPage:]):

5:01 PM Changeset in webkit [177709] by andersca@apple.com
  • 6 edits
    1 add in trunk/Source/WebKit2

Handle coding object graphs in the UI process
​https://bugs.webkit.org/show_bug.cgi?id=139925

Reviewed by Sam Weinig.

  • UIProcess/Cocoa/WebProcessProxyCocoa.mm: Added.

(WebKit::WebProcessProxy::transformHandlesToObjects):
(WebKit::WebProcessProxy::transformObjectsToHandles):

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::transformHandlesToObjects):
(WebKit::WebProcessProxy::transformObjectsToHandles):

  • UIProcess/WebProcessProxy.h:
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::transformObjectsToHandles):

  • WebProcess/WebProcess.h:
5:00 PM Changeset in webkit [177708] by weinig@apple.com
  • 5 edits in trunk/Source/WebKit2

ContextMenuContextData should store a ShareableBitmap not a ShareableBitmap::Handle
​https://bugs.webkit.org/show_bug.cgi?id=139924

Reviewed by Anders Carlsson.

Replaces the ShareableBitmap::Handle in ContextMenuContextData with a RefPtr<ShareableBitmap>.
Removes the now unnecessary override copy-constructor and assignment-operator.

  • Shared/ContextMenuContextData.cpp:

(WebKit::ContextMenuContextData::ContextMenuContextData):
(WebKit::ContextMenuContextData::encode):
(WebKit::ContextMenuContextData::decode):
(WebKit::ContextMenuContextData::controlledDataIsEditable):
(WebKit::ContextMenuContextData::operator=): Deleted.

  • Shared/ContextMenuContextData.h:

(WebKit::ContextMenuContextData::ContextMenuContextData):
(WebKit::ContextMenuContextData::controlledImage):
(WebKit::ContextMenuContextData::needsServicesMenu):
(WebKit::ContextMenuContextData::controlledImageHandle): Deleted.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::internalShowContextMenu):

  • UIProcess/mac/WebContextMenuProxyMac.mm:

(WebKit::WebContextMenuProxyMac::setupServicesMenu):

4:46 PM Changeset in webkit [177707] by Chris Dumez
  • 2 edits in trunk/Source/WebKit2

Unreviewed iOS build fix after 177692.

Missing WebKit:: namespace.

  • UIProcess/ios/WKContentView.h:
4:37 PM Changeset in webkit [177706] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix 32-build.

  • WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::WebProcess::transformHandlesToObjects):
(WebKit::WebProcess::transformObjectsToHandles):

4:14 PM Changeset in webkit [177705] by timothy_horton@apple.com
  • 7 edits in trunk/Source

Install a TextIndicator for link immediate actions
​https://bugs.webkit.org/show_bug.cgi?id=139897
<rdar://problem/19333076>

Reviewed by Anders Carlsson.

  • UIProcess/mac/WKImmediateActionController.mm:

(-[WKImmediateActionController _defaultAnimationController]):
Install the link's TextIndicator.

(-[WKImmediateActionController menuItemDidClose:]):
Dismiss the TextIndicator and clean up when the item closes.

  • WebView/WebImmediateActionController.h:
  • WebView/WebImmediateActionController.mm:

(-[WebImmediateActionController _clearImmediateActionState]):
Tear down the TextIndicator, just like WebKit2.

(-[WebImmediateActionController _defaultAnimationController]):
Install a TextIndicator for links.

(-[WebImmediateActionController menuItemDidClose:]):
Tear down the TextIndicator when the QL preview closes.

(-[WebImmediateActionController _menuItemForDataDetectedText]):
Directly install and uninstall the TextIndicator for DataDetectors.

(-[WebImmediateActionController _showTextIndicator]): Deleted.
(-[WebImmediateActionController _hideTextIndicator]): Deleted.
Remove the isShowingTextIndicator mechanism, just like it was removed from WebKit2.

  • platform/spi/mac/QuickLookMacSPI.h:

Add a new piece of SPI.

4:13 PM Changeset in webkit [177704] by timothy_horton@apple.com
  • 3 edits in trunk/Source/WebKit2

Expose ElementBoundingBox on WKHitTestResult
​https://bugs.webkit.org/show_bug.cgi?id=139895
<rdar://problem/19333075>

Reviewed by Dan Bernstein.

  • UIProcess/API/C/WKHitTestResult.cpp:

(WKHitTestResultGetElementBoundingBox):

  • UIProcess/API/C/WKHitTestResult.h:

Expose the rect.

4:13 PM Changeset in webkit [177703] by ap@apple.com
  • 6 edits in trunk

Simplify building with ASan
​https://bugs.webkit.org/show_bug.cgi?id=139916

Reviewed by Mark Rowe.

.:

  • Makefile.shared: Invoke set-webkit-configuration to store ASan choice as appropriate.

Tools:

  • Scripts/set-webkit-configuration: Store ASan state into a new configuration file.

We could also update Configuration file format, but that's a little scary because
of how many places in code read it.

  • Scripts/webkitdirs.pm:

(determineASanIsEnabled): Read it from ASan configuration file.
(argumentsForConfiguration): Added a FIXME.
(asanIsEnabled): A caching wrapper similar to what we have for other configuration options.
(XcodeOptions): Pass the options needed for ASan.

  • asan/asan.xcconfig: Use the right toolchains. Made warnings fatal again, as there

no warnings to avoid. Removed explicit linking options, as -fsanitize=address does
that automatically.

4:13 PM Changeset in webkit [177702] by timothy_horton@apple.com
  • 6 edits
    4 deletes in trunk/Source/WebKit2

Remove the custom web page preview code
​https://bugs.webkit.org/show_bug.cgi?id=139894
<rdar://problem/19333074>

Reviewed by Dan Bernstein.

  • UIProcess/API/Cocoa/WKViewPrivate.h:
  • UIProcess/API/mac/WKView.mm:

(-[WKView _dismissContentRelativeChildWindows]):
(-[WKView _viewForPreviewingURL:initialFrameSize:]): Deleted.
(-[WKView _titleForPreviewOfURL:]): Deleted.
(-[WKView _setPreviewTitle:]): Deleted.
(-[WKView _setPreviewLoading:]): Deleted.
(-[WKView _setPreviewOverrideImage:]): Deleted.
(-[WKView _finishPreviewingURL:withPreviewView:]): Deleted.
(-[WKView _handleClickInPreviewView:URL:]): Deleted.
(-[WKView _shouldUseStandardQuickLookPreview]): Deleted.

  • UIProcess/mac/WKImmediateActionController.h:
  • UIProcess/mac/WKImmediateActionController.mm:

(-[WKImmediateActionController willDestroyView:]):
(-[WKImmediateActionController _clearImmediateActionState]):
(-[WKImmediateActionController immediateActionRecognizerWillPrepare:]):
(-[WKImmediateActionController _defaultAnimationController]):
(-[WKImmediateActionController hidePreview]): Deleted.
(-[WKImmediateActionController setPreviewTitle:]): Deleted.
(-[WKImmediateActionController setPreviewLoading:]): Deleted.
(-[WKImmediateActionController setPreviewOverrideImage:]): Deleted.
(-[WKImmediateActionController _animationControllerForCustomPreview]): Deleted.

  • UIProcess/mac/WKPagePreviewViewController.h: Removed.
  • UIProcess/mac/WKPagePreviewViewController.mm: Removed.
  • UIProcess/mac/WKPreviewPopoverAnimationController.h: Removed.
  • UIProcess/mac/WKPreviewPopoverAnimationController.mm: Removed.
  • WebKit2.xcodeproj/project.pbxproj:

Remove all of the custom web page preview code. Clients that want the custom
preview can implement it by overriding the immediate action.

3:58 PM Changeset in webkit [177701] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

Add WebProcessProxy::transformHandlesToObjects
​https://bugs.webkit.org/show_bug.cgi?id=139922

Reviewed by Tim Horton.

This will be used to convert between the handles and their respective UI side objects.

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::transformHandlesToObjects):
(WebKit::WebProcessProxy::transformObjectsToHandles):
(WebKit::WebProcessProxy::apiObjectByConvertingToHandles): Deleted.

  • UIProcess/WebProcessProxy.h:
3:35 PM Changeset in webkit [177700] by andersca@apple.com
  • 6 edits in trunk/Source/WebKit2

Add handle transform functions to WebConnection
​https://bugs.webkit.org/show_bug.cgi?id=139920

Reviewed by Sam Weinig.

This will be used by the web connection code to convert between objects and their respective handles.

  • Shared/WebConnection.h:
  • UIProcess/WebConnectionToWebProcess.cpp:

(WebKit::WebConnectionToWebProcess::transformHandlesToObjects):
(WebKit::WebConnectionToWebProcess::transformObjectsToHandles):

  • UIProcess/WebConnectionToWebProcess.h:
  • WebProcess/WebConnectionToUIProcess.cpp:

(WebKit::WebConnectionToUIProcess::transformHandlesToObjects):
(WebKit::WebConnectionToUIProcess::transformObjectsToHandles):

  • WebProcess/WebConnectionToUIProcess.h:
3:07 PM Changeset in webkit [177699] by weinig@apple.com
  • 35 edits
    2 moves
    2 deletes in trunk/Source/WebKit2

Rename ImmutableDictionary to API::Dictionary and merge MutableDictionary into it
​https://bugs.webkit.org/show_bug.cgi?id=139917

Reviewed by Anders Carlsson.

  • Renames ImmutableDictionary -> API::Dictionary
  • Merges MutableDictionary into the new API::Dictionary

(as a result WKDictionaryIsMutable() now always returns true)

  • File list elided *
3:06 PM Changeset in webkit [177698] by andersca@apple.com
  • 4 edits in trunk/Source/WebKit2

Add WebProcess::transformObjectsToHandles
​https://bugs.webkit.org/show_bug.cgi?id=139918

Reviewed by Tim Horton.

This function will be used for transforming bundle objects to their respective handle types
when sending messages to the UI process.

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::transformHandlesToObjects):
(WebKit::WebProcess::transformObjectsToHandles):

  • WebProcess/WebProcess.h:
  • WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::WebProcess::transformHandlesToObjects):
(WebKit::WebProcess::transformObjectsToHandles):

2:27 PM Changeset in webkit [177697] by andersca@apple.com
  • 4 edits in trunk/Source

Move dynamic_objc_cast to RetainPtr.h
​https://bugs.webkit.org/show_bug.cgi?id=139915

Reviewed by Sam Weinig.

Source/WebKit2:

  • Shared/mac/ObjCObjectGraph.mm:

(WebKit::dynamic_objc_cast): Deleted.

Source/WTF:

  • wtf/RetainPtr.h:

(WTF::dynamic_objc_cast):

2:16 PM Changeset in webkit [177696] by andersca@apple.com
  • 3 edits in trunk/Source/WTF

Re-indent RefPtr.h and RetainPtr.h.

Rubber-stamped by Sam Weinig.

  • wtf/RefPtr.h:
  • wtf/RetainPtr.h:
2:14 PM Changeset in webkit [177695] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

Add WebProcess::transformHandlesToObjects
​https://bugs.webkit.org/show_bug.cgi?id=139913

Reviewed by Tim Horton.

Rename objectGraphByTransformingObjectsToHandles to transformObjectsToHandles and add
transformHandlesToObjects that will try to convert handles to the actual bundle type objects.

  • WebProcess/WebProcess.h:
  • WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::WebProcess::transformHandlesToObjects):
(WebKit::WebProcess::transformObjectsToHandles):
(WebKit::WebProcess::objectGraphByTransformingObjectsToHandles): Deleted.

1:53 PM Changeset in webkit [177694] by andersca@apple.com
  • 4 edits in trunk/Source/WebKit2

Add WebProcess::objectGraphByTransformingObjectsToHandles
​https://bugs.webkit.org/show_bug.cgi?id=139912

Reviewed by Tim Horton.

This will be used to convert Objective-C object graphs containing bundle types to their handle counterparts.

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::transformHandlesToObjects):
(WebKit::WebProcess::apiObjectByConvertingFromHandles): Deleted.
Rename apiObjectByConvertingFromHandles to transformHandlesToObjects.

  • WebProcess/WebProcess.h:
  • WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::WebProcess::objectGraphByTransformingObjectsToHandles):

12:44 PM Changeset in webkit [177693] by andersca@apple.com
  • 4 edits in trunk/Source/WebKit2

Fix UserMessage::transform to only call shouldTransform once
​https://bugs.webkit.org/show_bug.cgi?id=139911

Reviewed by Sam Weinig.

Also, make it possible for transformers to return null objects and change the transformers
to return the passed in object when there's no need to do a transform.

  • Shared/UserData.cpp:

(WebKit::transformGraph):
(WebKit::UserData::transform):
(WebKit::UserData::encode): Deleted.
(WebKit::UserData::decode): Deleted.

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::apiObjectByConvertingToHandles):

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::apiObjectByConvertingFromHandles):

12:29 PM Changeset in webkit [177692] by weinig@apple.com
  • 107 edits
    6 moves
    1 delete in trunk/Source

Rename WebContext to WebProcessPool
​https://bugs.webkit.org/show_bug.cgi?id=139909

Rubber-stamped by Anders Carlsson.

Source/WebCore:

Merge SessionID and SessionIDHash into one file to make auto-generation of
HashMaps with SessionIDs easier.

  • WebCore.xcodeproj/project.pbxproj:
  • loader/cache/MemoryCache.h:
  • page/SessionID.h:

(WTF::SessionIDHash::hash):
(WTF::SessionIDHash::equal):
(WTF::HashTraits<WebCore::SessionID>::emptyValue):
(WTF::HashTraits<WebCore::SessionID>::constructDeletedValue):
(WTF::HashTraits<WebCore::SessionID>::isDeletedValue):

  • page/SessionIDHash.h: Removed.

Source/WebKit2:

  • Major renames:

WebContext -> WebProcessPool
WebContextConfiguration -> WebProcessPoolConfiguration
API::ContextConfiguration -> API::ProcessPoolConfiguration

  • File list elided *
12:15 PM Changeset in webkit [177691] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

Only call shouldTransformGraph once per graph
​https://bugs.webkit.org/show_bug.cgi?id=139910

Reviewed by Sam Weinig.

Don't call shouldTransformGraph for each node in the object graph. Instead, call it once
and then transform the entire graph if needed.

  • Shared/mac/ObjCObjectGraph.h:
  • Shared/mac/ObjCObjectGraph.mm:

(WebKit::shouldTransformGraph):
(WebKit::transformGraph):
(WebKit::ObjCObjectGraph::transform):
(WebKit::shouldTransform): Deleted.

12:01 PM Changeset in webkit [177690] by ap@apple.com
  • 3 edits in trunk/Tools

TestWebKitAPI build is broken when ASan is enabled
​https://bugs.webkit.org/show_bug.cgi?id=139902

Reviewed by Darin Adler.

  • TestWebKitAPI/Configurations/InjectedBundle.xcconfig:
  • TestWebKitAPI/Configurations/TestWebKitAPILibrary.xcconfig:

Inherit linker flags from DebugRelease, which respects ASAN.

11:23 AM Changeset in webkit [177689] by mmaxfield@apple.com
  • 7 edits in trunk/Source/WebCore

platform/mac/editing/input/devanagari-ligature.html is flaky on Yosemite, ligature fails to form
​https://bugs.webkit.org/show_bug.cgi?id=138683

Reviewed by Darin Adler.

This patch changes how we check fonts for equality. In particular, this patch adds a
objectForEqualityCheck() to Cocoa's FontPlatformData, and callers should pass this object
to CFEqual() to determine if two platform fonts are equal. This patch also migrates all
call sites to using this function.

I don't want to implement operator==() because there are many cases where the same font
is compared against many others, and this solution is cleaner than caching a comparison
object inside the font object itself.

No new tests because this is covered by platform/mac/editing/input/devanagari-ligature.html.

  • platform/graphics/FontPlatformData.h:
  • platform/graphics/cocoa/FontPlatformDataCocoa.mm:

(WebCore::FontPlatformData::objectForEqualityCheck):

  • platform/graphics/mac/ComplexTextControllerCoreText.mm:

(WebCore::ComplexTextController::collectComplexTextRunsForCharacters):

  • platform/graphics/mac/GlyphPageTreeNodeMac.cpp:

(WebCore::GlyphPage::fill):

  • platform/graphics/mac/SimpleFontDataMac.mm:

(WebCore::SimpleFontData::canRenderCombiningCharacterSequence):

  • platform/spi/cocoa/CoreTextSPI.h:
10:45 AM Changeset in webkit [177688] by mmaxfield@apple.com
  • 2 edits in trunk/Source/WebCore

[SVG -> OTF Converter] Make Placeholder a move-only type
​https://bugs.webkit.org/show_bug.cgi?id=139870

Reviewed by Anders Carlsson.

No new tests because there is no behavior change.

  • svg/SVGToOTFFontConversion.cpp:

(WebCore::SVGToOTFFontConverter::Placeholder::Placeholder):
(WebCore::SVGToOTFFontConverter::Placeholder::populate):
(WebCore::SVGToOTFFontConverter::Placeholder::~Placeholder):

10:37 AM Changeset in webkit [177687] by Chris Dumez
  • 5 edits in trunk/Source/WebCore

Move color CSS properties to the new StyleBuilder
​https://bugs.webkit.org/show_bug.cgi?id=139898

Reviewed by Antti Koivisto.

Move color CSS properties to the new StyleBuilder by teaching the
StyleBuilder generator how to handle them.

  • css/CSSPropertyNames.in:
  • Move color properties to the new StyleBuilder.
  • css/DeprecatedStyleBuilder.cpp:

(WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder):
(WebCore::defaultInitialColor): Deleted.
(WebCore::ApplyPropertyColor::applyInheritValue): Deleted.
(WebCore::ApplyPropertyColor::applyInitialValue): Deleted.
(WebCore::ApplyPropertyColor::applyValue): Deleted.
(WebCore::ApplyPropertyColor::applyColorValue): Deleted.
(WebCore::ApplyPropertyColor::createHandler): Deleted.

  • Drop color properties support from the DeprecatedStyleBuilder.
  • css/makeprop.pl:
  • Teach the StyleBuilder generator how to handle color properties.
  • Use a class for StyleBuilderFunctions instead of a namespace so that it can be made a friend of RenderStyle class.
  • rendering/style/RenderStyle.h:
  • Mark StyleBuilderFunctions class as friend as its functions can set RenderStyle members directly. This is similar to what is already done for StyleBuilderCustom class. The new color properties handling calls private methods on RenderStyle.
  • Mark invalidColor() method as static as it does not require an instance.
10:04 AM Changeset in webkit [177686] by Alan Bujtas
  • 4 edits
    6 adds in trunk

Incorrect dashed and dotted border painting.
​https://bugs.webkit.org/show_bug.cgi?id=139872
rdar://problem/18024205

Reviewed by Simon Fraser.

This patch makes dashed/dotted border painting symmetric and consistent.
It also works with subpixel positioning.

Source/WebCore:

Tests: fast/borders/border-painting-correctness-dashed.html

fast/borders/border-painting-correctness-dotted.html

  • platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::GraphicsContext::drawLine):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::drawLineForBoxSide):

LayoutTests:

  • fast/borders/border-painting-correctness-dashed-expected.html: Added.
  • fast/borders/border-painting-correctness-dashed.html: Added.
  • fast/borders/border-painting-correctness-dotted-expected.html: Added.
  • fast/borders/border-painting-correctness-dotted.html: Added.
  • fast/borders/resources/border-painting-correctness-dashed-expected.png: Added.
  • fast/borders/resources/border-painting-correctness-dotted-expected.png: Added.
8:52 AM Changeset in webkit [177685] by andersca@apple.com
  • 5 edits in trunk/Source/WebKit2

Use a Transformer for UserData as well, to avoid always copying arrays and dictionaries
​https://bugs.webkit.org/show_bug.cgi?id=139896

Reviewed by Darin Adler.

  • Shared/UserData.cpp:

(WebKit::shouldTransform):
(WebKit::UserData::transform):

  • Shared/UserData.h:

(WebKit::UserData::Transformer::~Transformer):

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::apiObjectByConvertingToHandles):

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::apiObjectByConvertingFromHandles):

2:29 AM Changeset in webkit [177684] by g.czajkowski@samsung.com
  • 2 edits in trunk/LayoutTests

editing/spelling/grammar-paste.html is flaky in debug after r177682
​https://bugs.webkit.org/show_bug.cgi?id=139903

Unreviewed gardening.

Mark it as flaky.

1:36 AM Changeset in webkit [177683] by g.czajkowski@samsung.com
  • 2 edits in trunk/LayoutTests

Add proper expectations for two spelling/ tests after r177682

Unreviewed gardening.

12:26 AM Changeset in webkit [177682] by g.czajkowski@samsung.com
  • 4 edits in trunk/LayoutTests

shouldBecomeEqual() behaves as shouldBe() if the testing expression returns the expected value
​https://bugs.webkit.org/show_bug.cgi?id=133939

Reviewed by Darin Adler.

First call of eval(expression) inside shouldBecomeEqual was always
made synchronously. If the testing expression returns the same value
as expected one then shouldBecomeEqual() will immediately report PASS,
for example,

shouldBecomeEqual(internals.hasSpellingMarker("wellcome"), false);

in consequence, assuming asynchronous path of spellchecking, spelling markers
may appear after a while.

The bug was caused by checking a condition at the beginning of shouldBecomeEqual(),
before calling a timer. As a result, queued asynchronous events doesn't effect
this checking.

This fix reveals new bugs in execDeleteCommand() behaviour, two tests need
to marked as failure now.

  • resources/js-test-pre.js:

(.condition):
(shouldBecomeEqual):
(shouldBecomeDifferent):

  • resources/js-test.js:

(.condition):
(shouldBecomeEqual):
(shouldBecomeDifferent):
Always check a condition on timer.

Note: See TracTimeline for information about the timeline view.