Timeline



Dec 25, 2014:

11:34 PM Changeset in webkit [177745] by commit-queue@webkit.org
  • 4 edits
    4 adds in trunk

Source/WebCore:
Allow strings as argument to :lang()
https://bugs.webkit.org/show_bug.cgi?id=139678

Patch by Dhi Aurrahman <diorahman@rockybars.com> on 2014-12-25
Reviewed by Benjamin Poulain.

Allow strings as argument to :lang()[1]. The selector with empty string argument (e.g. :lang(""))
is handled as never matching.

[1] http://www.w3.org/blog/CSS/2014/12/11/minutes-telecon-231/

Test: fast/css/css-lang-selector-with-string-arguments-text.html

fast/selectors/lang-extended-filtering-with-string-arguments.html

  • css/CSSGrammar.y.in:
  • css/SelectorCheckerTestFunctions.h:

(WebCore::matchesLangPseudoClass):

LayoutTests:
Extend :lang() with string arguments
https://bugs.webkit.org/show_bug.cgi?id=139678

Patch by Dhi Aurrahman <diorahman@rockybars.com> on 2014-12-25
Reviewed by Benjamin Poulain.

  • fast/css/css-lang-selector-with-string-arguments-text-expected.txt: Added.
  • fast/css/css-lang-selector-with-string-arguments-text.html: Added.
  • fast/selectors/lang-extended-filtering-with-string-arguments-expected.txt: Added.
  • fast/selectors/lang-extended-filtering-with-string-arguments.html: Added.
8:23 PM Changeset in webkit [177744] by akling@apple.com
  • 27 edits in trunk/Source/WebCore

DOM exception creator functions should return Ref.
<https://webkit.org/b/139947>

Reviewed by Chris Dumez.

Tweak all the FooException::create() to return Ref instead of
PassRefPtr since construction always succeeds.

Also add a toJS() overload for ImplType& to keep bindings building.

  • Modules/indexeddb/IDBDatabaseException.h:

(WebCore::IDBDatabaseException::create):

  • Modules/webdatabase/SQLException.h:

(WebCore::SQLException::create):

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):

  • dom/DOMCoreException.h:

(WebCore::DOMCoreException::create):

  • dom/EventException.h:

(WebCore::EventException::create):

  • dom/RangeException.h:

(WebCore::RangeException::create):

  • fileapi/FileException.h:

(WebCore::FileException::create):

  • svg/SVGException.h:

(WebCore::SVGException::create):

  • xml/XMLHttpRequestException.h:

(WebCore::XMLHttpRequestException::create):

  • xml/XPathException.h:

(WebCore::XPathException::create):

7:51 PM Changeset in webkit [177743] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

Fix build warning after r177700
https://bugs.webkit.org/show_bug.cgi?id=139948

Patch by Hunseop Jeong <Hunseop Jeong> on 2014-12-25
Reviewed by Alexey Proskuryakov.

  • UIProcess/WebConnectionToWebProcess.cpp:

(WebKit::WebConnectionToWebProcess::transformHandlesToObjects):
(WebKit::WebConnectionToWebProcess::transformObjectsToHandles):

7:31 PM Changeset in webkit [177742] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/Source/WebCore

Unreviewed, fix build break on win debug build since r177737.

Partial revert some code in r177737 because it causes build error on win debug buildbot.

  • dom/ElementIteratorAssertions.h:

(WebCore::ElementIteratorAssertions::ElementIteratorAssertions):

2:45 PM Changeset in webkit [177741] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

Give extract-localizable-strings an option to treat warnings as errors
https://bugs.webkit.org/show_bug.cgi?id=139943

Reviewed by Darin Adler.

Add a --treat-warnings-as-errors option, which makes the script emit its warnings as errors
and exit with a non-0 return code if it emitted any warnings.

  • extract-localizable-strings.pl:

Added $treatWarningsAsErrors variable, set to true if the option is passed in.

(emitWarning): Added. If $treatWarningsAsErrors is true, omits the "warning: " token from
the message, which makes it appear as an error in Xcode, and sets $sawError to 1.

Replaced all print statements that printed warnings with calls to emitWarning.

2:01 PM Changeset in webkit [177740] by mitz@apple.com
  • 2 edits in trunk/Source/WTF

Try to fix the Windows build after r177733.

  • wtf/Ref.h:
1:25 PM Changeset in webkit [177739] by mitz@apple.com
  • 55 edits in trunk/Source/WebCore

Bring the state of WEBCORE_EXPORT annotations closer to what the exports file specifies.
https://bugs.webkit.org/show_bug.cgi?id=136172

Reviewed by Darin Adler.

  • bridge/NP_jsobject.cpp: Give functions from npruntime_impl.h defined in this file default

using a compiler pragma, in lieu of introducing WebCore-specific macros into that header.

  • bridge/npruntime.cpp: Ditto.
  • platform/mac/WebCoreSystemInterface.mm: Similarly for WebCoreSystemInterface.h.

Added or removed WEBCORE_EXPORT in these files as necessary to match what is currently in
the exports file:

  • Modules/mediasource/SourceBuffer.h:
  • bindings/js/JSDOMBinding.h:
  • css/CSSComputedStyleDeclaration.h:
  • dom/ContainerNode.h:
  • dom/Document.h:
  • dom/MouseEvent.h:
  • dom/Range.h:
  • dom/SecurityContext.h:
  • editing/Editor.h:
  • editing/mac/DictionaryLookup.h:
  • loader/FrameLoaderClient.h:
  • loader/LoaderStrategy.h:
  • loader/icon/IconDatabaseBase.h:
  • page/ChromeClient.h:
  • page/EventHandler.h:
  • page/FrameSnapshotting.h:
  • page/Page.h:
  • page/PageOverlay.h:
  • page/PageOverlayController.h:
  • page/TextIndicator.h:
  • page/UserContentController.h:
  • page/WheelEventDeltaTracker.h:
  • page/mac/TextIndicatorWindow.h:
  • platform/DatabaseStrategy.h:
  • platform/ScrollableArea.h:
  • platform/SuddenTermination.h:
  • platform/URL.h:
  • platform/animation/Animation.h:
  • platform/cocoa/MachSendRight.h:
  • platform/graphics/FloatRoundedRect.h:
  • platform/graphics/GraphicsContext.h:
  • platform/graphics/GraphicsLayer.h:
  • platform/graphics/Path.h:
  • platform/graphics/TextRun.h:
  • platform/graphics/ca/TileController.h:
  • platform/graphics/cocoa/IOSurface.h:
  • platform/graphics/mac/ColorMac.h:
  • platform/mac/SoftLinking.h:
  • platform/mac/WebCoreNSStringExtras.h:
  • platform/mock/mediasource/MockMediaPlayerMediaSource.h:
  • platform/network/BlobRegistry.h:
  • platform/network/ResourceRequestBase.h:
  • platform/network/ResourceResponseBase.h:
  • rendering/HitTestResult.h:
  • rendering/RenderInline.h:
  • rendering/RenderLayerBacking.h:
  • rendering/RenderLayerCompositor.cpp:
  • rendering/RenderView.h:
  • storage/StorageNamespaceImpl.h:
  • storage/StorageNamespaceProvider.h:
  • testing/Internals.h:
1:09 PM Changeset in webkit [177738] by Chris Dumez
  • 11 edits in trunk/Source

[iOS] Log better using FeatureCounter why PageCache is failing due to pruned resources
https://bugs.webkit.org/show_bug.cgi?id=139921

Reviewed by Gavin Barraclough and Alexey Proskuryakov.

Source/WebCore:

Log better using FeatureCounter why PageCache is failing due to pruned
resources. In particular, we now distinguish if the resource was pruned
due to:

  • Memory pressure
  • Page cache capacity reached
  • WebProcess suspended (WK2)
  • WebCore.exp.in:
  • history/HistoryItem.cpp:

(WebCore::HistoryItem::HistoryItem):

  • history/HistoryItem.h:
  • history/PageCache.cpp:

(WebCore::PageCache::pruneToCapacityNow):
(WebCore::PageCache::setCapacity):
(WebCore::pruningReasonToFeatureCounterKey):
(WebCore::PageCache::add):
(WebCore::PageCache::take):
(WebCore::PageCache::get):
(WebCore::PageCache::prune):

  • history/PageCache.h:
  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::commitProvisionalLoad):

  • platform/FeatureCounterKeys.h:
  • platform/MemoryPressureHandler.cpp:

(WebCore::MemoryPressureHandler::releaseCriticalMemory):

Source/WebKit2:

Call PageCache::pruneToCapacityNow() instead of multiple calls to
setCapacity() as it does exactly what we want. Also pass the new
PrunedReason argument so help us do better logging.

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::releasePageCache):

12:06 PM Performance Tests edited by rniwa@webkit.org
Deleted the section about replay tests since they are no longer supported. (diff)
12:04 PM Performance Tests edited by rniwa@webkit.org
Updated Writing a Performance Test Using runner.js. (diff)
10:55 AM Changeset in webkit [177737] by gyuyoung.kim@samsung.com
  • 10 edits in trunk/Source/WebCore

Use std::unique_ptr<> in WebCore/dom, plugin, and graphics
https://bugs.webkit.org/show_bug.cgi?id=139938

Reviewed by Darin Adler.

Replace OwnPtr with std::unique_ptr<> and std::make_unique<>.

  • dom/ElementIteratorAssertions.h:

(WebCore::ElementIteratorAssertions::ElementIteratorAssertions):

  • dom/MutationObserverRegistration.cpp:

(WebCore::MutationObserverRegistration::observedSubtreeNodeWillDetach):
(WebCore::MutationObserverRegistration::clearTransientRegistrations):

  • dom/MutationObserverRegistration.h:
  • dom/StyledElement.cpp:

(WebCore::StyledElement::rebuildPresentationAttributeStyle):

  • platform/graphics/SimpleFontData.h:

(WebCore::SimpleFontData::boundsForGlyph):

  • platform/graphics/freetype/SimpleFontDataFreeType.cpp:

(WebCore::SimpleFontData::canRenderCombiningCharacterSequence):

  • platform/graphics/mac/SimpleFontDataMac.mm:

(WebCore::SimpleFontData::canRenderCombiningCharacterSequence):

  • plugins/PluginStream.cpp:

(WebCore::PluginStream::didReceiveData):

  • plugins/PluginStream.h:
10:48 AM Changeset in webkit [177736] by ap@apple.com
  • 2 edits in trunk/Source/WTF

Simplify saturated integer add/sub
https://bugs.webkit.org/show_bug.cgi?id=139854

Address Darin's post-commit feedback to fix API tests.

  • wtf/SaturatedArithmetic.h: (saturatedSubtraction):
8:23 AM Changeset in webkit [177735] by commit-queue@webkit.org
  • 11 edits in trunk/Source

Unreviewed, rolling out r177712 and r177717.
https://bugs.webkit.org/show_bug.cgi?id=139944

Caused flaky assertion failures (Requested by ap on #webkit).

Reverted changesets:

"[iOS] Log better using FeatureCounter why PageCache is
failing due to pruned resources"
https://bugs.webkit.org/show_bug.cgi?id=139921
http://trac.webkit.org/changeset/177712

"Unreviewed, fix build warning after r177712"
http://trac.webkit.org/changeset/177717

2:03 AM Changeset in webkit [177734] by akling@apple.com
  • 2 edits in trunk/Source/WebCore

Rebaseline bindings tests after r177733.

  • bindings/scripts/test/JS/JSTestCallback.h:

(WebCore::JSTestCallback::create):

Dec 24, 2014:

11:50 PM Changeset in webkit [177733] by akling@apple.com
  • 304 edits in trunk/Source/WebCore

Convert more creator functions to return Ref instead of PassRefPtr.
<https://webkit.org/b/139939>

Reviewed by Darin Adler.

Convert a slew of functions to return Ref<T> instead of PassRefPtr<T>
where the result is guaranteed to never be null.

  • Modules/geolocation/Coordinates.h:

(WebCore::Coordinates::create):
(WebCore::Coordinates::isolatedCopy):

  • Modules/plugins/QuickTimePluginReplacement.mm:

(WebCore::QuickTimePluginReplacement::isolatedWorld):

  • Modules/webaudio/AnalyserNode.h:

(WebCore::AnalyserNode::create):

  • Modules/webaudio/AudioBuffer.cpp:

(WebCore::AudioBuffer::create):
(WebCore::AudioBuffer::createFromAudioFileData):

  • Modules/webaudio/AudioBuffer.h:
  • Modules/webaudio/AudioBufferSourceNode.cpp:

(WebCore::AudioBufferSourceNode::create):

  • Modules/webaudio/AudioBufferSourceNode.h:
  • Modules/webaudio/AudioContext.cpp:

(WebCore::AudioContext::create):

  • Modules/webaudio/AudioContext.h:
  • Modules/webaudio/AudioListener.h:

(WebCore::AudioListener::create):

  • Modules/webaudio/AudioParam.h:

(WebCore::AudioParam::create):

  • Modules/webaudio/BiquadFilterNode.h:

(WebCore::BiquadFilterNode::create):

  • Modules/webaudio/ConvolverNode.h:

(WebCore::ConvolverNode::create):

  • Modules/webaudio/DelayNode.h:

(WebCore::DelayNode::create):

  • Modules/webaudio/DynamicsCompressorNode.h:

(WebCore::DynamicsCompressorNode::create):

  • Modules/webdatabase/ChangeVersionWrapper.h:

(WebCore::ChangeVersionWrapper::create):

  • Modules/webdatabase/DatabaseAuthorizer.cpp:

(WebCore::DatabaseAuthorizer::create):

  • Modules/webdatabase/DatabaseAuthorizer.h:
  • Modules/webdatabase/DatabaseThread.h:

(WebCore::DatabaseThread::create):

  • Modules/websockets/WorkerThreadableWebSocketChannel.cpp:

(WebCore::WorkerThreadableWebSocketChannel::Bridge::send):

  • accessibility/AXObjectCache.cpp:

(WebCore::createFromRenderer):
(WebCore::createFromNode):

  • accessibility/AccessibilityARIAGrid.cpp:

(WebCore::AccessibilityARIAGrid::create):

  • accessibility/AccessibilityARIAGrid.h:
  • accessibility/AccessibilityARIAGridCell.cpp:

(WebCore::AccessibilityARIAGridCell::create):

  • accessibility/AccessibilityARIAGridCell.h:
  • accessibility/AccessibilityARIAGridRow.cpp:

(WebCore::AccessibilityARIAGridRow::create):

  • accessibility/AccessibilityARIAGridRow.h:
  • accessibility/AccessibilityImageMapLink.cpp:

(WebCore::AccessibilityImageMapLink::create):

  • accessibility/AccessibilityImageMapLink.h:
  • accessibility/AccessibilityList.cpp:

(WebCore::AccessibilityList::create):

  • accessibility/AccessibilityList.h:
  • accessibility/AccessibilityListBox.cpp:

(WebCore::AccessibilityListBox::create):

  • accessibility/AccessibilityListBox.h:
  • accessibility/AccessibilityListBoxOption.cpp:

(WebCore::AccessibilityListBoxOption::create):

  • accessibility/AccessibilityListBoxOption.h:
  • accessibility/AccessibilityMediaControls.cpp:

(WebCore::AccessibilityMediaControl::create):
(WebCore::AccessibilityMediaControlsContainer::create):
(WebCore::AccessibilityMediaTimeline::create):
(WebCore::AccessibilityMediaTimeDisplay::create):

  • accessibility/AccessibilityMediaControls.h:
  • accessibility/AccessibilityMenuList.cpp:

(WebCore::AccessibilityMenuList::create):

  • accessibility/AccessibilityMenuList.h:
  • accessibility/AccessibilityMenuListOption.h:
  • accessibility/AccessibilityMenuListPopup.h:
  • accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::create):

  • accessibility/AccessibilityNodeObject.h:
  • accessibility/AccessibilityProgressIndicator.cpp:

(WebCore::AccessibilityProgressIndicator::create):

  • accessibility/AccessibilityProgressIndicator.h:
  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::create):

  • accessibility/AccessibilityRenderObject.h:
  • accessibility/AccessibilitySVGRoot.cpp:

(WebCore::AccessibilitySVGRoot::create):

  • accessibility/AccessibilitySVGRoot.h:
  • accessibility/AccessibilityScrollView.cpp:

(WebCore::AccessibilityScrollView::create):

  • accessibility/AccessibilityScrollView.h:
  • accessibility/AccessibilityScrollbar.cpp:

(WebCore::AccessibilityScrollbar::create):

  • accessibility/AccessibilityScrollbar.h:
  • accessibility/AccessibilitySearchFieldButtons.cpp:

(WebCore::AccessibilitySearchFieldCancelButton::create):

  • accessibility/AccessibilitySearchFieldButtons.h:
  • accessibility/AccessibilitySlider.cpp:

(WebCore::AccessibilitySlider::create):
(WebCore::AccessibilitySliderThumb::create):

  • accessibility/AccessibilitySlider.h:
  • accessibility/AccessibilitySpinButton.cpp:

(WebCore::AccessibilitySpinButton::create):
(WebCore::AccessibilitySpinButtonPart::create):

  • accessibility/AccessibilitySpinButton.h:
  • accessibility/AccessibilityTable.cpp:

(WebCore::AccessibilityTable::create):

  • accessibility/AccessibilityTable.h:
  • accessibility/AccessibilityTableCell.cpp:

(WebCore::AccessibilityTableCell::create):

  • accessibility/AccessibilityTableCell.h:
  • accessibility/AccessibilityTableColumn.cpp:

(WebCore::AccessibilityTableColumn::create):

  • accessibility/AccessibilityTableColumn.h:
  • accessibility/AccessibilityTableHeaderContainer.cpp:

(WebCore::AccessibilityTableHeaderContainer::create):

  • accessibility/AccessibilityTableHeaderContainer.h:
  • accessibility/AccessibilityTableRow.cpp:

(WebCore::AccessibilityTableRow::create):

  • accessibility/AccessibilityTableRow.h:
  • bindings/js/CachedScriptSourceProvider.h:

(WebCore::CachedScriptSourceProvider::create):

  • bindings/js/DOMWrapperWorld.h:

(WebCore::DOMWrapperWorld::create):

  • bindings/js/SerializedScriptValue.cpp:

(WebCore::CloneDeserializer::getJSValue):

  • bindings/objc/DOMCustomXPathNSResolver.h:

(WebCore::DOMCustomXPathNSResolver::create):

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateCallbackHeader):

  • bridge/c/c_instance.h:

(JSC::Bindings::CInstance::create):

  • crypto/CryptoKeyPair.h:

(WebCore::CryptoKeyPair::create):

  • crypto/keys/CryptoKeyAES.h:
  • crypto/keys/CryptoKeyHMAC.h:
  • crypto/keys/CryptoKeyRSA.h:
  • crypto/mac/CryptoKeyRSAMac.cpp:

(WebCore::CryptoKeyRSA::generatePair):

  • css/DOMWindowCSS.cpp:

(WebCore::DOMWindowCSS::create):

  • css/DOMWindowCSS.h:
  • css/DashboardRegion.h:

(WebCore::DashboardRegion::create):

  • css/FontLoader.h:
  • dom/DOMError.h:

(WebCore::DOMError::create):

  • dom/DOMStringList.h:

(WebCore::DOMStringList::create):

  • dom/DataTransfer.cpp:

(WebCore::DataTransfer::createForCopyAndPaste):
(WebCore::DataTransfer::createForDragAndDrop):

  • dom/DataTransfer.h:
  • dom/DeviceMotionData.cpp:

(WebCore::DeviceMotionData::Acceleration::create):
(WebCore::DeviceMotionData::RotationRate::create):
(WebCore::DeviceMotionData::create):

  • dom/DeviceMotionData.h:
  • dom/DeviceOrientationData.cpp:

(WebCore::DeviceOrientationData::create):

  • dom/DeviceOrientationData.h:
  • dom/DocumentMarker.cpp:

(WebCore::DocumentMarkerDescription::create):

  • editing/AlternativeTextController.cpp:

(WebCore::AutocorrectionAlternativeDetails::create):
(WebCore::DictationAlternativeDetails::create):

  • editing/AlternativeTextController.h:

(WebCore::DictationMarkerDetails::create):

  • editing/AppendNodeCommand.h:

(WebCore::AppendNodeCommand::create):

  • editing/ApplyStyleCommand.h:

(WebCore::ApplyStyleCommand::create):

  • editing/BreakBlockquoteCommand.h:

(WebCore::BreakBlockquoteCommand::create):

  • editing/CompositeEditCommand.cpp:

(WebCore::EditCommandComposition::create):

  • editing/CompositeEditCommand.h:
  • editing/CreateLinkCommand.h:

(WebCore::CreateLinkCommand::create):

  • editing/DeleteFromTextNodeCommand.h:

(WebCore::DeleteFromTextNodeCommand::create):

  • editing/DeleteSelectionCommand.h:

(WebCore::DeleteSelectionCommand::create):

  • editing/DictationCommand.cpp:

(WebCore::DictationMarkerSupplier::create):

  • editing/DictationCommand.h:

(WebCore::DictationCommand::create):

  • editing/EditingStyle.h:

(WebCore::EditingStyle::create):

  • editing/Editor.cpp:

(WebCore::Editor::applyStyle):
(WebCore::Editor::applyParagraphStyle):

  • editing/FormatBlockCommand.h:

(WebCore::FormatBlockCommand::create):

  • editing/IndentOutdentCommand.h:

(WebCore::IndentOutdentCommand::create):

  • editing/InsertIntoTextNodeCommand.h:

(WebCore::InsertIntoTextNodeCommand::create):

  • editing/InsertLineBreakCommand.h:

(WebCore::InsertLineBreakCommand::create):

  • editing/InsertNodeBeforeCommand.h:

(WebCore::InsertNodeBeforeCommand::create):

  • editing/InsertParagraphSeparatorCommand.h:

(WebCore::InsertParagraphSeparatorCommand::create):

  • editing/InsertTextCommand.h:

(WebCore::InsertTextCommand::create):
(WebCore::InsertTextCommand::createWithMarkerSupplier):

  • editing/MergeIdenticalElementsCommand.h:

(WebCore::MergeIdenticalElementsCommand::create):

  • editing/ModifySelectionListLevel.h:

(WebCore::IncreaseSelectionListLevelCommand::create):
(WebCore::DecreaseSelectionListLevelCommand::create):

  • editing/MoveSelectionCommand.h:

(WebCore::MoveSelectionCommand::create):

  • editing/RemoveCSSPropertyCommand.h:

(WebCore::RemoveCSSPropertyCommand::create):

  • editing/RemoveFormatCommand.h:

(WebCore::RemoveFormatCommand::create):

  • editing/RemoveNodeCommand.h:

(WebCore::RemoveNodeCommand::create):

  • editing/RemoveNodePreservingChildrenCommand.h:

(WebCore::RemoveNodePreservingChildrenCommand::create):

  • editing/ReplaceNodeWithSpanCommand.h:

(WebCore::ReplaceNodeWithSpanCommand::create):

  • editing/ReplaceSelectionCommand.h:

(WebCore::ReplaceSelectionCommand::create):

  • editing/SetNodeAttributeCommand.h:

(WebCore::SetNodeAttributeCommand::create):

  • editing/SetSelectionCommand.h:

(WebCore::SetSelectionCommand::create):

  • editing/SimplifyMarkupCommand.h:

(WebCore::SimplifyMarkupCommand::create):

  • editing/SpellChecker.cpp:

(WebCore::SpellCheckRequest::create):

  • editing/SpellChecker.h:
  • editing/SpellingCorrectionCommand.cpp:

(WebCore::SpellingCorrectionRecordUndoCommand::create):

  • editing/SpellingCorrectionCommand.h:

(WebCore::SpellingCorrectionCommand::create):

  • editing/SplitElementCommand.h:

(WebCore::SplitElementCommand::create):

  • editing/SplitTextNodeCommand.h:

(WebCore::SplitTextNodeCommand::create):

  • editing/SplitTextNodeContainingElementCommand.h:

(WebCore::SplitTextNodeContainingElementCommand::create):

  • editing/TypingCommand.h:

(WebCore::TypingCommand::create):

  • editing/UnlinkCommand.h:

(WebCore::UnlinkCommand::create):

  • editing/WrapContentsInDummySpanCommand.h:

(WebCore::WrapContentsInDummySpanCommand::create):

  • editing/ios/DictationCommandIOS.h:

(WebCore::DictationCommandIOS::create):

  • fileapi/Blob.h:

(WebCore::Blob::create):
(WebCore::Blob::deserialize):
(WebCore::Blob::slice):

  • fileapi/File.h:
  • fileapi/FileList.h:

(WebCore::FileList::create):

  • fileapi/FileReader.cpp:

(WebCore::FileReader::create):

  • fileapi/FileReader.h:
  • fileapi/FileReaderSync.h:

(WebCore::FileReaderSync::create):

  • history/BackForwardList.h:

(WebCore::BackForwardList::create):

  • history/HistoryItem.h:

(WebCore::HistoryItem::create):

  • html/DOMURL.cpp:

(WebCore::DOMURL::create):

  • html/DOMURL.h:
  • html/HTMLPlugInImageElement.cpp:

(WebCore::plugInImageElementIsolatedWorld):

  • html/canvas/CanvasGradient.h:

(WebCore::CanvasGradient::create):

  • html/canvas/CanvasPattern.cpp:

(WebCore::CanvasPattern::create):

  • html/canvas/CanvasPattern.h:
  • html/canvas/DOMPath.h:
  • html/shadow/DetailsMarkerControl.cpp:

(WebCore::DetailsMarkerControl::create):

  • html/shadow/DetailsMarkerControl.h:
  • html/track/AudioTrack.h:
  • html/track/AudioTrackList.h:
  • html/track/DataCue.h:
  • inspector/CommandLineAPIHost.cpp:

(WebCore::CommandLineAPIHost::create):

  • inspector/CommandLineAPIHost.h:
  • loader/DocumentLoader.h:

(WebCore::DocumentLoader::create):

  • loader/FormState.cpp:

(WebCore::FormState::create):

  • loader/FormState.h:
  • loader/FormSubmission.cpp:

(WebCore::FormSubmission::create):

  • loader/FormSubmission.h:
  • loader/TextResourceDecoder.h:

(WebCore::TextResourceDecoder::create):

  • loader/ThreadableLoaderClientWrapper.h:

(WebCore::ThreadableLoaderClientWrapper::create):

  • loader/WorkerThreadableLoader.h:

(WebCore::WorkerThreadableLoader::create):

  • loader/appcache/ApplicationCache.h:

(WebCore::ApplicationCache::create):

  • loader/appcache/ApplicationCacheResource.h:

(WebCore::ApplicationCacheResource::create):

  • loader/appcache/DOMApplicationCache.h:
  • loader/archive/ArchiveResource.cpp:

(WebCore::ArchiveResource::create):

  • loader/archive/ArchiveResource.h:
  • loader/icon/IconDatabaseBase.h:

(WebCore::EnumCallback::create):
(WebCore::ObjectCallback::create):

  • loader/icon/IconRecord.h:

(WebCore::IconRecord::create):

  • mathml/MathMLInlineContainerElement.cpp:

(WebCore::MathMLInlineContainerElement::create):

  • mathml/MathMLInlineContainerElement.h:
  • mathml/MathMLMathElement.cpp:

(WebCore::MathMLMathElement::create):

  • mathml/MathMLMathElement.h:
  • mathml/MathMLMencloseElement.cpp:

(WebCore::MathMLMencloseElement::create):

  • mathml/MathMLMencloseElement.h:
  • mathml/MathMLSelectElement.cpp:

(WebCore::MathMLSelectElement::create):

  • mathml/MathMLSelectElement.h:
  • mathml/MathMLTextElement.cpp:

(WebCore::MathMLTextElement::create):

  • mathml/MathMLTextElement.h:
  • page/BarProp.h:

(WebCore::BarProp::create):

  • page/Crypto.h:

(WebCore::Crypto::create):

  • page/DOMSecurityPolicy.h:

(WebCore::DOMSecurityPolicy::create):

  • page/DOMSelection.h:

(WebCore::DOMSelection::create):

  • page/DOMWindow.h:
  • page/DOMWindowExtension.h:

(WebCore::DOMWindowExtension::create):

  • page/FrameView.cpp:

(WebCore::FrameView::create):

  • page/FrameView.h:
  • page/animation/CompositeAnimation.h:

(WebCore::CompositeAnimation::create):

  • page/scrolling/AsyncScrollingCoordinator.h:
  • platform/Cursor.h:

(WebCore::SharedCursor::create):

  • platform/FileChooser.cpp:

(WebCore::FileChooser::create):

  • platform/FileChooser.h:
  • platform/animation/Animation.h:

(WebCore::Animation::create):

  • platform/audio/AudioBus.cpp:

(WebCore::AudioBus::create):
(WebCore::AudioBus::createBufferFromRange):
(WebCore::AudioBus::createBySampleRateConverting):
(WebCore::AudioBus::createByMixingToMono):

  • platform/audio/AudioBus.h:
  • platform/audio/AudioHardwareListener.cpp:

(WebCore::AudioHardwareListener::create):

  • platform/audio/AudioHardwareListener.h:
  • platform/audio/mac/AudioHardwareListenerMac.cpp:

(WebCore::AudioHardwareListener::create):
(WebCore::AudioHardwareListenerMac::create):

  • platform/audio/mac/AudioHardwareListenerMac.h:
  • platform/graphics/AudioTrackPrivate.h:

(WebCore::AudioTrackPrivate::create):

  • platform/graphics/BitmapImage.h:
  • platform/graphics/CrossfadeGeneratedImage.h:
  • platform/graphics/FontFeatureSettings.h:

(WebCore::FontFeatureSettings::create):

  • platform/graphics/Image.cpp:

(WebCore::Image::nullImage):

  • platform/graphics/avfoundation/AudioSourceProviderAVFObjC.h:
  • platform/graphics/avfoundation/AudioSourceProviderAVFObjC.mm:

(WebCore::AudioSourceProviderAVFObjC::create):

  • platform/graphics/filters/DistantLightSource.h:

(WebCore::DistantLightSource::create):

  • platform/graphics/filters/FEBlend.cpp:

(WebCore::FEBlend::create):

  • platform/graphics/filters/FEBlend.h:
  • platform/graphics/filters/FEColorMatrix.cpp:

(WebCore::FEColorMatrix::create):

  • platform/graphics/filters/FEColorMatrix.h:
  • platform/graphics/filters/FEComponentTransfer.cpp:

(WebCore::FEComponentTransfer::create):

  • platform/graphics/filters/FEComponentTransfer.h:
  • platform/graphics/filters/FEComposite.cpp:

(WebCore::FEComposite::create):

  • platform/graphics/filters/FEComposite.h:
  • platform/graphics/filters/FEConvolveMatrix.cpp:

(WebCore::FEConvolveMatrix::create):

  • platform/graphics/filters/FEConvolveMatrix.h:
  • platform/graphics/filters/FEDiffuseLighting.cpp:

(WebCore::FEDiffuseLighting::create):

  • platform/graphics/filters/FEDiffuseLighting.h:
  • platform/graphics/filters/FEDisplacementMap.cpp:

(WebCore::FEDisplacementMap::create):

  • platform/graphics/filters/FEDisplacementMap.h:
  • platform/graphics/filters/FEDropShadow.cpp:

(WebCore::FEDropShadow::create):

  • platform/graphics/filters/FEDropShadow.h:
  • platform/graphics/filters/FEFlood.cpp:

(WebCore::FEFlood::create):

  • platform/graphics/filters/FEFlood.h:
  • platform/graphics/filters/FEGaussianBlur.cpp:

(WebCore::FEGaussianBlur::create):

  • platform/graphics/filters/FEGaussianBlur.h:
  • platform/graphics/filters/FEMerge.cpp:

(WebCore::FEMerge::create):

  • platform/graphics/filters/FEMerge.h:
  • platform/graphics/filters/FEMorphology.cpp:

(WebCore::FEMorphology::create):

  • platform/graphics/filters/FEMorphology.h:
  • platform/graphics/filters/FEOffset.cpp:

(WebCore::FEOffset::create):

  • platform/graphics/filters/FEOffset.h:
  • platform/graphics/filters/FESpecularLighting.cpp:

(WebCore::FESpecularLighting::create):

  • platform/graphics/filters/FESpecularLighting.h:
  • platform/graphics/filters/FETile.cpp:

(WebCore::FETile::create):

  • platform/graphics/filters/FETile.h:
  • platform/graphics/filters/FETurbulence.cpp:

(WebCore::FETurbulence::create):

  • platform/graphics/filters/FETurbulence.h:
  • platform/graphics/ios/DisplayRefreshMonitorIOS.h:

(WebCore::DisplayRefreshMonitorIOS::create):

  • platform/graphics/mac/ComplexTextController.h:

(WebCore::ComplexTextController::ComplexTextRun::create):

  • platform/network/BlobData.h:

(WebCore::RawData::create):
(WebCore::BlobData::create):

  • platform/network/BlobDataFileReference.h:

(WebCore::BlobDataFileReference::create):

  • platform/network/cf/FormDataStreamCFNet.cpp:
  • platform/text/BidiContext.cpp:

(WebCore::BidiContext::createUncached):
(WebCore::BidiContext::create):

  • platform/text/BidiContext.h:
  • plugins/DOMMimeType.h:

(WebCore::DOMMimeType::create):

  • plugins/DOMMimeTypeArray.cpp:

(WebCore::DOMMimeTypeArray::item):
(WebCore::DOMMimeTypeArray::namedItem):

  • plugins/DOMMimeTypeArray.h:

(WebCore::DOMMimeTypeArray::create):

  • plugins/DOMPlugin.cpp:

(WebCore::DOMPlugin::item):
(WebCore::DOMPlugin::namedItem):

  • plugins/DOMPlugin.h:

(WebCore::DOMPlugin::create):

  • plugins/DOMPluginArray.cpp:

(WebCore::DOMPluginArray::item):
(WebCore::DOMPluginArray::namedItem):

  • plugins/DOMPluginArray.h:

(WebCore::DOMPluginArray::create):

  • plugins/PluginData.h:

(WebCore::PluginData::create):

  • rendering/ClipPathOperation.h:
  • rendering/CounterNode.cpp:

(WebCore::CounterNode::create):

  • rendering/CounterNode.h:
  • rendering/style/BasicShapes.h:
  • rendering/style/CursorList.h:

(WebCore::CursorList::create):

  • replay/CapturingInputCursor.cpp:

(WebCore::CapturingInputCursor::create):

  • replay/CapturingInputCursor.h:
  • storage/Storage.cpp:

(WebCore::Storage::create):

  • storage/Storage.h:
  • storage/StorageAreaImpl.cpp:

(WebCore::StorageAreaImpl::create):

  • storage/StorageAreaImpl.h:
  • storage/StorageAreaSync.cpp:

(WebCore::StorageAreaSync::create):

  • storage/StorageAreaSync.h:
  • storage/StorageMap.cpp:

(WebCore::StorageMap::create):

  • storage/StorageMap.h:
  • storage/StorageSyncManager.cpp:

(WebCore::StorageSyncManager::create):

  • storage/StorageSyncManager.h:
  • workers/DedicatedWorkerGlobalScope.cpp:

(WebCore::DedicatedWorkerGlobalScope::create):

  • workers/DedicatedWorkerGlobalScope.h:
  • workers/DedicatedWorkerThread.cpp:

(WebCore::DedicatedWorkerThread::create):
(WebCore::DedicatedWorkerThread::createWorkerGlobalScope):

  • workers/DedicatedWorkerThread.h:
  • workers/DefaultSharedWorkerRepository.cpp:
  • workers/SharedWorkerGlobalScope.cpp:

(WebCore::SharedWorkerGlobalScope::create):

  • workers/SharedWorkerGlobalScope.h:
  • workers/SharedWorkerThread.cpp:

(WebCore::SharedWorkerThread::create):
(WebCore::SharedWorkerThread::createWorkerGlobalScope):

  • workers/SharedWorkerThread.h:
  • workers/WorkerGlobalScope.cpp:

(WebCore::WorkerGlobalScope::importScripts):

  • workers/WorkerLocation.h:

(WebCore::WorkerLocation::create):

  • workers/WorkerScriptLoader.h:

(WebCore::WorkerScriptLoader::create):

  • workers/WorkerThread.h:
  • xml/DOMParser.h:

(WebCore::DOMParser::create):

  • xml/NativeXPathNSResolver.h:

(WebCore::NativeXPathNSResolver::create):

  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::create):

  • xml/XMLHttpRequest.h:
  • xml/XMLHttpRequestProgressEventThrottle.cpp:

(WebCore::XMLHttpRequestProgressEventThrottle::flushProgressEvent):

  • xml/XMLSerializer.h:

(WebCore::XMLSerializer::create):

  • xml/XPathEvaluator.h:

(WebCore::XPathEvaluator::create):

  • xml/XPathResult.h:

(WebCore::XPathResult::create):

  • xml/XSLStyleSheet.h:
  • xml/XSLTProcessor.h:

(WebCore::XSLTProcessor::create):

10:28 PM Changeset in webkit [177732] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit2

[Cocoa] WebKit private headers shouldn’t contain “inappropriate” macros
https://bugs.webkit.org/show_bug.cgi?id=139942

Reviewed by Darin Adler.

  • WebKit2.xcodeproj/project.pbxproj: In the Check For Inappropriate Macros in External

Headers script build phase, check the PrivateHeaders directory as well.

10:26 PM Changeset in webkit [177731] by mitz@apple.com
  • 4 edits in trunk/Tools

Engineering builds of MiniBrowser ignore deprecated declaration warnings
https://bugs.webkit.org/show_bug.cgi?id=139941

Reviewed by Darin Adler.

  • MiniBrowser/Configurations/Base.xcconfig: Added semicolon.
  • MiniBrowser/Configurations/DebugRelease.xcconfig: Set GCC_WARN_ABOUT_DEPRECATED_FUNCTIONS

to YES.

  • MiniBrowser/mac/AppDelegate.m:

(-[BrowserAppDelegate openDocument:]): Use NSFileHandlingPanelOKButton instead of
deprecated NSOKButton.

6:48 PM Changeset in webkit [177730] by benjamin@webkit.org
  • 2 edits in trunk/Source/WebCore

Small cleanup of RenderBlock::paint()
https://bugs.webkit.org/show_bug.cgi?id=139849

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-12-24
Reviewed by Daniel Bates.

Remove a couple of instructions by putting variable in the right scope.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::paint):

6:46 PM Changeset in webkit [177729] by benjamin@webkit.org
  • 3 edits in trunk/Source/WTF

Simplify saturated integer add/sub
https://bugs.webkit.org/show_bug.cgi?id=139854

Reviewed by Darin Adler.

  • wtf/Compiler.h:

Make a wrapper for has_builtin for compilers that do not support it.

  • wtf/SaturatedArithmetic.h:

(saturatedAddition):
(saturatedSubtraction):
Use the builtins when possible instead of reinventing the wheel.
On ARMv7, use the saturated math instructions.

6:31 PM Changeset in webkit [177728] by benjamin@webkit.org
  • 1 edit
    4 adds in trunk/LayoutTests

Import the tests for :valid/:invalid on form/fieldset from blink
https://bugs.webkit.org/show_bug.cgi?id=139899

Reviewed by Darin Adler.

blink's tests are incredibly basic but it is better to include them
for completeness.

  • fast/forms/fieldset-pseudo-valid-style-expected.txt: Added.
  • fast/forms/fieldset-pseudo-valid-style.html: Added.
  • fast/forms/form-pseudo-valid-style-expected.txt: Added.
  • fast/forms/form-pseudo-valid-style.html: Added.

Both tests are from Bartek Nowierski.

4:54 PM Changeset in webkit [177727] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

W3C test importer should have an option to disable testharness.js/testharnessreport.js link conversion
https://bugs.webkit.org/show_bug.cgi?id=134763

Patch by Youenn Fablet <youenn.fablet@crf.canon.fr> on 2014-12-24
Reviewed by Ryosuke Niwa.

Adding an option to disable test harness link conversion.

  • Scripts/webkitpy/w3c/test_converter.py:

(convert_for_webkit):
(_W3CTestConverter.init):
(_W3CTestConverter.convert_attributes_if_needed):

  • Scripts/webkitpy/w3c/test_importer.py:

(parse_args):
(TestImporter.import_tests):

4:21 PM Changeset in webkit [177726] by mitz@apple.com
  • 5 edits in trunk/Source/WebCore

[Cocoa] WebCoreSystemInterface.h declares two unused symbols
https://bugs.webkit.org/show_bug.cgi?id=139937

Reviewed by Tim Horton.

  • platform/graphics/FontPlatformData.h: Removed unused typedefs.
  • platform/graphics/mac/FontCustomPlatformData.cpp:

(WebCore::createFontCustomPlatformData): Stop passing always-zero containerRef parameter to
FontCustomPlatformData constructor.

  • platform/graphics/mac/FontCustomPlatformData.h: Removed unused typedefs.

(WebCore::FontCustomPlatformData::FontCustomPlatformData): Removed unused container
parameter and m_atsContainer member variable.

  • platform/mac/WebCoreSystemInterface.h: Removed unused typedefs and symbols.
3:21 PM Changeset in webkit [177725] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit2

Addressed a linker warning about the definition of a method in a category overridng a method from the class.

  • UIProcess/API/mac/WKView.mm:

(-[WKView(Private) _targetWindowForMovePreparation]): Deleted. This was identical to the
definition in the main WKView implementation above.

3:10 PM Changeset in webkit [177724] by mitz@apple.com
  • 2 edits in trunk/Source/ThirdParty/ANGLE

ANGLE extern symbols are not hidden by default, but should be
https://bugs.webkit.org/show_bug.cgi?id=139936

Reviewed by Mark Rowe.

  • Configurations/Base.xcconfig: Changed GCC_SYMBOLS_PRIVATE_EXTERN to YES.
2:39 PM Changeset in webkit [177723] by mitz@apple.com
  • 2 edits in trunk/Source/ThirdParty/ANGLE

Removed the Derived Sources target.

It has been empty since r159533.

  • ANGLE.xcodeproj/project.pbxproj:
12:34 AM Changeset in webkit [177722] by ap@apple.com
  • 3 edits in trunk/Tools

DumpRenderTree crashes are mis-reported as timeouts on Yosemite
https://bugs.webkit.org/show_bug.cgi?id=139933

Reviewed by Daniel Bates.

Crash logs take a very long time to be generated on Yosemite (rdar://problem/18701447),
and there is no way for run-webkit-tests to tell a crashed process from a frozen one
until ReportCrash lets it go.

Reuse existing machinery that tells run-webkit-tests about crashes. The script may
even get the actual crash log eventually - even when it times out waiting for the log, it
makes a second lookup at the very end, after all tests finish. There may be further
improvements needed here, but this small fix addresses most cases that happen in practice.

  • DumpRenderTree/mac/DumpRenderTree.mm:

(writeCrashedMessageOnFatalError):
(dumpRenderTree):
Removed PLATFORM(IOS) ifdefs, this code is just as helpful on Mac.

  • Scripts/webkitpy/port/driver.py: (Driver._check_for_driver_crash): Removed an

unhelpful comment.

Note: See TracTimeline for information about the timeline view.