Timeline
Dec 26, 2014:
- 9:46 PM Changeset in webkit [177754] by
-
- 2 edits in trunk/Source/WebKit2
Safari build crashes when "zooming into"/choosing a tab from tab view
https://bugs.webkit.org/show_bug.cgi?id=139934
Reviewed by Dan Bernstein.
- UIProcess/API/mac/WKView.mm:
(-[WKView _setIgnoresNonWheelEvents:]):
Trying to add a nil gesture recognizer raises an exception. Stop assuming that a
gesture recognizer is non-nil.
- 5:17 PM Changeset in webkit [177753] by
-
- 2 edits in trunk/Source/WTF
Build fix.
Removed use of builtin_s{add,sub}_overflow introduced in r177729 that was causing a compiler used at Apple to crash because of <rdar://problem/19347133>.
- wtf/SaturatedArithmetic.h:
(signedAddOverflows):
(signedSubtractOverflows):
- 4:29 PM Changeset in webkit [177752] by
-
- 2 edits in trunk/LayoutTests
fast/text/international/hindi-spacing.html and transforms/2d/hindi-rotated.html are flaky on Yosemite
https://bugs.webkit.org/show_bug.cgi?id=138075
This was fixed via bug 138683, a fix for another text rendering test being flaky.
- platform/mac/TestExpectations: Remove the expectations.
- 3:00 PM Changeset in webkit [177751] by
-
- 7 edits in trunk/Source/WebCore
Purge PassRefPtr from Element and ElementRareData.
<https://webkit.org/b/139949>
Reviewed by Anders Carlsson.
Make functions that used to take PassRefPtr now take Ref&& or RefPtr&&
instead depending on possible nullity of incoming values.
- dom/Element.cpp:
(WebCore::Element::addShadowRoot):
(WebCore::Element::setBeforePseudoElement):
(WebCore::Element::setAfterPseudoElement):
- dom/Element.h:
- dom/ElementRareData.h:
(WebCore::ElementRareData::setShadowRoot):
(WebCore::ElementRareData::setBeforePseudoElement):
(WebCore::ElementRareData::setAfterPseudoElement):
- dom/PseudoElement.h:
- dom/ShadowRoot.h:
- style/StyleResolveTree.cpp:
(WebCore::Style::setBeforeOrAfterPseudoElement):
(WebCore::Style::attachBeforeOrAfterPseudoElementIfNeeded):
- 2:16 PM Changeset in webkit [177750] by
-
- 2 edits in trunk/Source/WebKit2
Handle more types in the UserData encode/decode functions
https://bugs.webkit.org/show_bug.cgi?id=139959
Reviewed by Dan Bernstein.
- Shared/UserData.cpp:
(WebKit::UserData::encode):
(WebKit::UserData::decode):
- 12:24 PM Changeset in webkit [177749] by
-
- 8 edits in trunk/Source/WebKit2
Move handle encoding functions to their respective implementation files
https://bugs.webkit.org/show_bug.cgi?id=139957
Reviewed by Dan Bernstein.
- Shared/API/APIFrameHandle.cpp:
(API::FrameHandle::encode):
(API::FrameHandle::decode):
- Shared/API/APIFrameHandle.h:
- Shared/API/APIPageGroupHandle.cpp:
(API::PageGroupHandle::PageGroupHandle):
(API::PageGroupHandle::encode):
(API::PageGroupHandle::decode):
- Shared/API/APIPageGroupHandle.h:
- Shared/API/APIPageHandle.cpp:
(API::PageHandle::encode):
(API::PageHandle::decode):
- Shared/API/APIPageHandle.h:
- Shared/UserData.cpp:
(WebKit::UserData::encode):
(WebKit::UserData::decode):
- 11:26 AM Changeset in webkit [177748] by
-
- 12 edits in trunk/Source/WebKit2
Add the notion of auto-converting page and frame handles
https://bugs.webkit.org/show_bug.cgi?id=139954
Reviewed by Dan Bernstein.
This makes it possible to tell the difference between page and frame handles that
should be converted to their respective UI or web process object representations
and handles that should stay the same (for the modern API for example).
- Shared/API/APIFrameHandle.cpp:
(API::FrameHandle::create):
(API::FrameHandle::createAutoconverting):
(API::FrameHandle::FrameHandle):
- Shared/API/APIFrameHandle.h:
(API::FrameHandle::isAutoconverting):
- Shared/API/APIPageHandle.cpp:
(API::PageHandle::create):
(API::PageHandle::createAutoconverting):
(API::PageHandle::PageHandle):
- Shared/API/APIPageHandle.h:
(API::PageHandle::isAutoconverting):
- Shared/API/Cocoa/_WKFrameHandle.mm:
(-[_WKFrameHandle initWithCoder:]):
- Shared/UserData.cpp:
(WebKit::shouldTransform):
- Shared/UserData.h:
- UIProcess/Cocoa/UIDelegate.mm:
(WebKit::UIDelegate::UIClient::printFrame):
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::transformHandlesToObjects):
(WebKit::WebProcessProxy::transformObjectsToHandles):
- WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFrame.mm:
(-[WKWebProcessPlugInFrame handle]):
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::transformHandlesToObjects):
(WebKit::WebProcess::transformObjectsToHandles):
- 11:18 AM Changeset in webkit [177747] by
-
- 38 edits in trunk/Source/WebKit2
[Cocoa] Some modern SPI changes have missing or incorrect availability annotations
https://bugs.webkit.org/show_bug.cgi?id=139940
Reviewed by Darin Adler.
- Shared/API/c/WKDeclarationSpecifiers.h: Renamed WK_DEPRECATED to WK_C_DEPRECATED.
- Shared/API/Cocoa/WKFoundation.h: Define WK_DEPRECATED when API availability is not enabled
to mean that the declaration is currently deprecated.
- Shared/API/c/WKConnectionRef.h: Updated for the renaming of the existing WK_DEPRECATED to
WK_C_DEPRECATED.
- UIProcess/API/C/WKContext.h: Ditto.
- UIProcess/API/C/WKContextConnectionClient.h: Ditto.
- UIProcess/API/C/WKContextDownloadClient.h: Ditto.
- UIProcess/API/C/WKContextHistoryClient.h: Ditto.
- UIProcess/API/C/WKContextInjectedBundleClient.h: Ditto.
- UIProcess/API/C/WKCookieManager.h: Ditto.
- UIProcess/API/C/WKDatabaseManager.h: Ditto.
- UIProcess/API/C/WKGeolocationManager.h: Ditto.
- UIProcess/API/C/WKIconDatabase.h: Ditto.
- UIProcess/API/C/WKNotificationProvider.h: Ditto.
- UIProcess/API/C/WKPageContextMenuClient.h: Ditto.
- UIProcess/API/C/WKPageFindClient.h: Ditto.
- UIProcess/API/C/WKPageFindMatchesClient.h: Ditto.
- UIProcess/API/C/WKPageFormClient.h: Ditto.
- UIProcess/API/C/WKPageUIClient.h: Ditto.
- WebProcess/InjectedBundle/API/c/WKBundle.h: Ditto.
- WebProcess/InjectedBundle/API/c/WKBundlePageBanner.h: Ditto.
- WebProcess/InjectedBundle/API/c/WKBundlePageContextMenuClient.h: Ditto.
- WebProcess/InjectedBundle/API/c/WKBundlePageDiagnosticLoggingClient.h: Ditto.
- WebProcess/InjectedBundle/API/c/WKBundlePageEditorClient.h: Ditto.
- WebProcess/InjectedBundle/API/c/WKBundlePageFormClient.h: Ditto.
- WebProcess/InjectedBundle/API/c/WKBundlePageFullScreenClient.h: Ditto.
- WebProcess/InjectedBundle/API/c/WKBundlePageLoaderClient.h: Ditto.
- WebProcess/InjectedBundle/API/c/WKBundlePageOverlay.h: Ditto.
- WebProcess/InjectedBundle/API/c/WKBundlePagePolicyClient.h: Ditto.
- WebProcess/InjectedBundle/API/c/WKBundlePageResourceLoadClient.h: Ditto.
- WebProcess/InjectedBundle/API/c/WKBundlePageUIClient.h: Ditto.
- Shared/API/Cocoa/WKRenderingProgressEvents.h: Added missing availability annotation.
- UIProcess/API/Cocoa/WKPreferencesPrivate.h: Changed to use WK_MAC_TBA and WK_IOS_TBA for
_WKDebugOverlayRegions enum. Added availability annotations to new properties.
- UIProcess/API/Cocoa/WKProcessPoolPrivate.h: Added availability annotation to new method.
- UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h: Annotated new method, changed Mac
availability of iOS-only method to NA.
- UIProcess/API/Cocoa/WKWebViewPrivate.h: Added availability annotation to new enum value,
new property, and new method. Added deprecation annotation to one method.
- UIProcess/API/Cocoa/_WKWebsiteDataStore.h: Annotated new method.
- mac/rewrite-availability-macros.sh: Rewrite WK_DEPRECATED to NS_DEPRECATED.
- 7:45 AM Changeset in webkit [177746] by
-
- 20 edits in trunk
<rdar://problem/19348208> REGRESSION (r177027): iOS builds use the wrong toolchain
https://bugs.webkit.org/show_bug.cgi?id=139950
Reviewed by David Kilzer.
Source/bmalloc:
- Configurations/Base.xcconfig: Only define TOOLCHAINS when building for OS X, doing so
in a manner that works with Xcode 5.1.1.
Source/JavaScriptCore:
- Configurations/Base.xcconfig: Only define TOOLCHAINS when building for OS X, doing so
in a manner that works with Xcode 5.1.1.
Source/ThirdParty:
- gtest/xcode/Config/General.xcconfig: Only define TOOLCHAINS when building for OS X, doing so
in a manner that works with Xcode 5.1.1.
Source/ThirdParty/ANGLE:
- Configurations/Base.xcconfig: Only define TOOLCHAINS when building for OS X, doing so
in a manner that works with Xcode 5.1.1.
Source/WebCore:
- Configurations/Base.xcconfig: Only define TOOLCHAINS when building for OS X, doing so
in a manner that works with Xcode 5.1.1.
Source/WebInspectorUI:
- Configurations/Base.xcconfig: Only define TOOLCHAINS when building for OS X, doing so
in a manner that works with Xcode 5.1.1.
Source/WebKit/mac:
- Configurations/Base.xcconfig: Only define TOOLCHAINS when building for OS X, doing so
in a manner that works with Xcode 5.1.1.
Source/WebKit2:
- Configurations/Base.xcconfig: Only define TOOLCHAINS when building for OS X, doing so
in a manner that works with Xcode 5.1.1.
Source/WTF:
- Configurations/Base.xcconfig: Only define TOOLCHAINS when building for OS X, doing so
in a manner that works with Xcode 5.1.1.
Tools:
- asan/asan.xcconfig: Only define TOOLCHAINS when building for OS X, doing so
in a manner that works with Xcode 5.1.1.
Dec 25, 2014:
- 11:34 PM Changeset in webkit [177745] by
-
- 4 edits4 adds in trunk
Source/WebCore:
Allow strings as argument to :lang()
https://bugs.webkit.org/show_bug.cgi?id=139678
Patch by Dhi Aurrahman <diorahman@rockybars.com> on 2014-12-25
Reviewed by Benjamin Poulain.
Allow strings as argument to :lang()[1]. The selector with empty string argument (e.g. :lang(""))
is handled as never matching.
[1] http://www.w3.org/blog/CSS/2014/12/11/minutes-telecon-231/
Test: fast/css/css-lang-selector-with-string-arguments-text.html
fast/selectors/lang-extended-filtering-with-string-arguments.html
- css/CSSGrammar.y.in:
- css/SelectorCheckerTestFunctions.h:
(WebCore::matchesLangPseudoClass):
LayoutTests:
Extend :lang() with string arguments
https://bugs.webkit.org/show_bug.cgi?id=139678
Patch by Dhi Aurrahman <diorahman@rockybars.com> on 2014-12-25
Reviewed by Benjamin Poulain.
- fast/css/css-lang-selector-with-string-arguments-text-expected.txt: Added.
- fast/css/css-lang-selector-with-string-arguments-text.html: Added.
- fast/selectors/lang-extended-filtering-with-string-arguments-expected.txt: Added.
- fast/selectors/lang-extended-filtering-with-string-arguments.html: Added.
- 8:23 PM Changeset in webkit [177744] by
-
- 27 edits in trunk/Source/WebCore
DOM exception creator functions should return Ref.
<https://webkit.org/b/139947>
Reviewed by Chris Dumez.
Tweak all the FooException::create() to return Ref instead of
PassRefPtr since construction always succeeds.
Also add a toJS() overload for ImplType& to keep bindings building.
- Modules/indexeddb/IDBDatabaseException.h:
(WebCore::IDBDatabaseException::create):
- Modules/webdatabase/SQLException.h:
(WebCore::SQLException::create):
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
- dom/DOMCoreException.h:
(WebCore::DOMCoreException::create):
- dom/EventException.h:
(WebCore::EventException::create):
- dom/RangeException.h:
(WebCore::RangeException::create):
- fileapi/FileException.h:
(WebCore::FileException::create):
- svg/SVGException.h:
(WebCore::SVGException::create):
- xml/XMLHttpRequestException.h:
(WebCore::XMLHttpRequestException::create):
- xml/XPathException.h:
(WebCore::XPathException::create):
- 7:51 PM Changeset in webkit [177743] by
-
- 2 edits in trunk/Source/WebKit2
Fix build warning after r177700
https://bugs.webkit.org/show_bug.cgi?id=139948
Patch by Hunseop Jeong <Hunseop Jeong> on 2014-12-25
Reviewed by Alexey Proskuryakov.
- UIProcess/WebConnectionToWebProcess.cpp:
(WebKit::WebConnectionToWebProcess::transformHandlesToObjects):
(WebKit::WebConnectionToWebProcess::transformObjectsToHandles):
- 7:31 PM Changeset in webkit [177742] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, fix build break on win debug build since r177737.
Partial revert some code in r177737 because it causes build error on win debug buildbot.
- dom/ElementIteratorAssertions.h:
(WebCore::ElementIteratorAssertions::ElementIteratorAssertions):
- 2:45 PM Changeset in webkit [177741] by
-
- 2 edits in trunk/Source/WebCore
Give extract-localizable-strings an option to treat warnings as errors
https://bugs.webkit.org/show_bug.cgi?id=139943
Reviewed by Darin Adler.
Add a --treat-warnings-as-errors option, which makes the script emit its warnings as errors
and exit with a non-0 return code if it emitted any warnings.
- extract-localizable-strings.pl:
Added $treatWarningsAsErrors variable, set to true if the option is passed in.
(emitWarning): Added. If $treatWarningsAsErrors is true, omits the "warning: " token from
the message, which makes it appear as an error in Xcode, and sets $sawError to 1.
Replaced all print statements that printed warnings with calls to emitWarning.
- 2:01 PM Changeset in webkit [177740] by
-
- 2 edits in trunk/Source/WTF
Try to fix the Windows build after r177733.
- wtf/Ref.h:
- 1:25 PM Changeset in webkit [177739] by
-
- 55 edits in trunk/Source/WebCore
Bring the state of WEBCORE_EXPORT annotations closer to what the exports file specifies.
https://bugs.webkit.org/show_bug.cgi?id=136172
Reviewed by Darin Adler.
- bridge/NP_jsobject.cpp: Give functions from npruntime_impl.h defined in this file default
using a compiler pragma, in lieu of introducing WebCore-specific macros into that header.
- bridge/npruntime.cpp: Ditto.
- platform/mac/WebCoreSystemInterface.mm: Similarly for WebCoreSystemInterface.h.
Added or removed WEBCORE_EXPORT in these files as necessary to match what is currently in
the exports file:
- Modules/mediasource/SourceBuffer.h:
- bindings/js/JSDOMBinding.h:
- css/CSSComputedStyleDeclaration.h:
- dom/ContainerNode.h:
- dom/Document.h:
- dom/MouseEvent.h:
- dom/Range.h:
- dom/SecurityContext.h:
- editing/Editor.h:
- editing/mac/DictionaryLookup.h:
- loader/FrameLoaderClient.h:
- loader/LoaderStrategy.h:
- loader/icon/IconDatabaseBase.h:
- page/ChromeClient.h:
- page/EventHandler.h:
- page/FrameSnapshotting.h:
- page/Page.h:
- page/PageOverlay.h:
- page/PageOverlayController.h:
- page/TextIndicator.h:
- page/UserContentController.h:
- page/WheelEventDeltaTracker.h:
- page/mac/TextIndicatorWindow.h:
- platform/DatabaseStrategy.h:
- platform/ScrollableArea.h:
- platform/SuddenTermination.h:
- platform/URL.h:
- platform/animation/Animation.h:
- platform/cocoa/MachSendRight.h:
- platform/graphics/FloatRoundedRect.h:
- platform/graphics/GraphicsContext.h:
- platform/graphics/GraphicsLayer.h:
- platform/graphics/Path.h:
- platform/graphics/TextRun.h:
- platform/graphics/ca/TileController.h:
- platform/graphics/cocoa/IOSurface.h:
- platform/graphics/mac/ColorMac.h:
- platform/mac/SoftLinking.h:
- platform/mac/WebCoreNSStringExtras.h:
- platform/mock/mediasource/MockMediaPlayerMediaSource.h:
- platform/network/BlobRegistry.h:
- platform/network/ResourceRequestBase.h:
- platform/network/ResourceResponseBase.h:
- rendering/HitTestResult.h:
- rendering/RenderInline.h:
- rendering/RenderLayerBacking.h:
- rendering/RenderLayerCompositor.cpp:
- rendering/RenderView.h:
- storage/StorageNamespaceImpl.h:
- storage/StorageNamespaceProvider.h:
- testing/Internals.h:
- 1:09 PM Changeset in webkit [177738] by
-
- 11 edits in trunk/Source
[iOS] Log better using FeatureCounter why PageCache is failing due to pruned resources
https://bugs.webkit.org/show_bug.cgi?id=139921
Reviewed by Gavin Barraclough and Alexey Proskuryakov.
Source/WebCore:
Log better using FeatureCounter why PageCache is failing due to pruned
resources. In particular, we now distinguish if the resource was pruned
due to:
- Memory pressure
- Page cache capacity reached
- WebProcess suspended (WK2)
- WebCore.exp.in:
- history/HistoryItem.cpp:
(WebCore::HistoryItem::HistoryItem):
- history/HistoryItem.h:
- history/PageCache.cpp:
(WebCore::PageCache::pruneToCapacityNow):
(WebCore::PageCache::setCapacity):
(WebCore::pruningReasonToFeatureCounterKey):
(WebCore::PageCache::add):
(WebCore::PageCache::take):
(WebCore::PageCache::get):
(WebCore::PageCache::prune):
- history/PageCache.h:
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::commitProvisionalLoad):
- platform/FeatureCounterKeys.h:
- platform/MemoryPressureHandler.cpp:
(WebCore::MemoryPressureHandler::releaseCriticalMemory):
Source/WebKit2:
Call PageCache::pruneToCapacityNow() instead of multiple calls to
setCapacity() as it does exactly what we want. Also pass the new
PrunedReason argument so help us do better logging.
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::releasePageCache):
- 12:06 PM Performance Tests edited by
- Deleted the section about replay tests since they are no longer supported. (diff)
- 12:04 PM Performance Tests edited by
- Updated Writing a Performance Test Using runner.js. (diff)
- 10:55 AM Changeset in webkit [177737] by
-
- 10 edits in trunk/Source/WebCore
Use std::unique_ptr<> in WebCore/dom, plugin, and graphics
https://bugs.webkit.org/show_bug.cgi?id=139938
Reviewed by Darin Adler.
Replace OwnPtr with std::unique_ptr<> and std::make_unique<>.
- dom/ElementIteratorAssertions.h:
(WebCore::ElementIteratorAssertions::ElementIteratorAssertions):
- dom/MutationObserverRegistration.cpp:
(WebCore::MutationObserverRegistration::observedSubtreeNodeWillDetach):
(WebCore::MutationObserverRegistration::clearTransientRegistrations):
- dom/MutationObserverRegistration.h:
- dom/StyledElement.cpp:
(WebCore::StyledElement::rebuildPresentationAttributeStyle):
- platform/graphics/SimpleFontData.h:
(WebCore::SimpleFontData::boundsForGlyph):
- platform/graphics/freetype/SimpleFontDataFreeType.cpp:
(WebCore::SimpleFontData::canRenderCombiningCharacterSequence):
- platform/graphics/mac/SimpleFontDataMac.mm:
(WebCore::SimpleFontData::canRenderCombiningCharacterSequence):
- plugins/PluginStream.cpp:
(WebCore::PluginStream::didReceiveData):
- plugins/PluginStream.h:
- 10:48 AM Changeset in webkit [177736] by
-
- 2 edits in trunk/Source/WTF
Simplify saturated integer add/sub
https://bugs.webkit.org/show_bug.cgi?id=139854
Address Darin's post-commit feedback to fix API tests.
- wtf/SaturatedArithmetic.h: (saturatedSubtraction):
- 8:23 AM Changeset in webkit [177735] by
-
- 11 edits in trunk/Source
Unreviewed, rolling out r177712 and r177717.
https://bugs.webkit.org/show_bug.cgi?id=139944
Caused flaky assertion failures (Requested by ap on #webkit).
Reverted changesets:
"[iOS] Log better using FeatureCounter why PageCache is
failing due to pruned resources"
https://bugs.webkit.org/show_bug.cgi?id=139921
http://trac.webkit.org/changeset/177712
"Unreviewed, fix build warning after r177712"
http://trac.webkit.org/changeset/177717
- 2:03 AM Changeset in webkit [177734] by
-
- 2 edits in trunk/Source/WebCore
Rebaseline bindings tests after r177733.
- bindings/scripts/test/JS/JSTestCallback.h:
(WebCore::JSTestCallback::create):
