Timeline



Dec 31, 2014:

5:25 PM Changeset in webkit [177841] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

Fixed the iOS build.

  • page/scrolling/ios/ScrollingCoordinatorIOS.mm:

(WebCore::ScrollingCoordinatorIOS::commitTreeState):

5:03 PM Changeset in webkit [177840] by Csaba Osztrogonác
  • 3 edits in trunk/Source/WebCore

URTBF after r177835.

  • page/scrolling/coordinatedgraphics/ScrollingCoordinatorCoordinatedGraphics.cpp:

(WebCore::ScrollingCoordinatorCoordinatedGraphics::ScrollingCoordinatorCoordinatedGraphics):

  • page/scrolling/coordinatedgraphics/ScrollingCoordinatorCoordinatedGraphics.h:
3:30 PM Changeset in webkit [177839] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Unreviewed, rolling out r176476.
https://bugs.webkit.org/show_bug.cgi?id=140021

Sadly, this didn't reduce media test crashiness (Requested by
ap on #webkit).

Reverted changeset:

"[Mac] Random crashes inside media libraries when creating
then destroying media quickly."
https://bugs.webkit.org/show_bug.cgi?id=138980
http://trac.webkit.org/changeset/176476

1:34 PM Changeset in webkit [177838] by Yusuke Suzuki
  • 2 edits in trunk/Source/WebKit2

[GTK] Suppress unused parameter warnings in ui clients
https://bugs.webkit.org/show_bug.cgi?id=140012

Drop the parameter name of WebKitUIClient::isPlayingAudioDidChange
to suppress warnings.

Reviewed by Benjamin Poulain.

  • UIProcess/API/gtk/WebKitUIClient.cpp:
1:21 PM Changeset in webkit [177837] by ap@apple.com
  • 3 edits in trunk/LayoutTests

execDeleteCommand() does not update spellchecker sometimes
https://bugs.webkit.org/show_bug.cgi?id=139862

Updated test expectation for a test that always crashes on WK1 (it was already
skipped on mac-wk2, efl and gtk).

1:16 PM Changeset in webkit [177836] by ap@apple.com
  • 3 edits in trunk/LayoutTests

Test expectation gardening.

Add expectations for test that became flaky after enabling kerning and ligatures,
plus a few more that were mis-characterized.

  • platform/efl/TestExpectations:
  • platform/mac/TestExpectations:
12:01 PM Changeset in webkit [177835] by weinig@apple.com
  • 23 edits in trunk/Source

Remove the remaining uses of OwnPtr from WebKit2
https://bugs.webkit.org/show_bug.cgi?id=140017

Reviewed by Dan Bernstein.

Source/WebCore:

  • WebCore.exp.in:
  • page/scrolling/AsyncScrollingCoordinator.cpp:

(WebCore::AsyncScrollingCoordinator::AsyncScrollingCoordinator):

  • page/scrolling/AsyncScrollingCoordinator.h:
  • page/scrolling/ScrollingStateTree.cpp:

(WebCore::ScrollingStateTree::commit):
(WebCore::ScrollingStateTree::create): Deleted.

  • page/scrolling/ScrollingStateTree.h:
  • page/scrolling/ScrollingTree.cpp:

(WebCore::ScrollingTree::commitNewTreeState):

  • page/scrolling/ScrollingTree.h:
  • page/scrolling/ThreadedScrollingTree.cpp:

(WebCore::ThreadedScrollingTree::commitNewTreeState):

  • page/scrolling/ThreadedScrollingTree.h:
  • page/scrolling/ios/ScrollingTreeIOS.cpp:

(WebCore::ScrollingTreeIOS::commitNewTreeState):

  • page/scrolling/ios/ScrollingTreeIOS.h:
  • page/scrolling/mac/ScrollingCoordinatorMac.mm:

(WebCore::ScrollingCoordinatorMac::commitTreeState):

Source/WebKit2:

  • Shared/Scrolling/RemoteScrollingCoordinatorTransaction.cpp:

(WebKit::RemoteScrollingCoordinatorTransaction::decode):

  • Shared/Scrolling/RemoteScrollingCoordinatorTransaction.h:

(WebKit::RemoteScrollingCoordinatorTransaction::setStateTreeToEncode):
(WebKit::RemoteScrollingCoordinatorTransaction::scrollingStateTree):

  • UIProcess/Launcher/mac/DynamicLinkerEnvironmentExtractor.mm:
  • UIProcess/Scrolling/RemoteScrollingCoordinatorProxy.cpp:

(WebKit::RemoteScrollingCoordinatorProxy::updateScrollingTree):

  • UIProcess/mac/PageClientImpl.h:
  • UIProcess/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::PageClientImpl):

  • UIProcess/mac/WKFullScreenWindowController.h:
  • UIProcess/mac/WKPrintingView.mm:

(-[WKPrintingView _preparePDFDataForPrintingOnSecondaryThread]):
(-[WKPrintingView _askPageToComputePageRects]):
(-[WKPrintingView _drawPreview:]):

  • WebProcess/InjectedBundle/API/c/mac/WKBundlePageBannerMac.mm:
11:03 AM Changeset in webkit [177834] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

Don’t use AccessibilityAllInOne when building with Xcode
https://bugs.webkit.org/show_bug.cgi?id=139974

Reviewed by Darin Adler.

  • WebCore.xcodeproj/project.pbxproj: Added all files included by AccessibilityAllInOne.cpp

to the WebCore target, and removed AccessibilityAllInOne.cpp from the project.

9:16 AM Changeset in webkit [177833] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

Fix build warnings after r177792.
https://bugs.webkit.org/show_bug.cgi?id=140005.

Patch by Bartlomiej Gajda <b.gajda@samsung.com> on 2014-12-31
Reviewed by Anders Carlsson.

Add UNUSED_PARAM(connection) for async messages.

  • Scripts/webkit/messages.py:

(generate_message_handler):

3:33 AM Changeset in webkit [177832] by zandobersek@gmail.com
  • 3 edits in trunk/Source/WebKit2

Unreviewed build fix for the GTK port.

Move the ArgumentCodersGtk.h inclusion from WebPageProxy.cpp to
WebPageProxy.h. This makes GTK-specific IPC coders available to
WebPageProxyMessageReceiver, fixing a build error due to missing
ArgumentCoder template specializations for WebCore::DragData type
that is used in the GTK-specific StartDrag message.

  • UIProcess/WebPageProxy.cpp:
  • UIProcess/WebPageProxy.h:
12:44 AM Changeset in webkit [177831] by commit-queue@webkit.org
  • 3 edits
    2 deletes in trunk

Unreviewed, rolling out r177824 and r177826.
https://bugs.webkit.org/show_bug.cgi?id=140011

The new test crashes (Requested by ap on #webkit).

Reverted changesets:

"Too large plugins are crashing."
https://bugs.webkit.org/show_bug.cgi?id=139856
http://trac.webkit.org/changeset/177824

"Fix bug number typo in the previous commit."
http://trac.webkit.org/changeset/177826

12:36 AM Changeset in webkit [177830] by ap@apple.com
  • 2 edits in trunk/LayoutTests

Update storage tracker test expectations after r177814.

  • platform/mac/TestExpectations:
12:26 AM Changeset in webkit [177829] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Win] Unreviewed gardening, mark more timeouting tests.

  • platform/win/TestExpectations:

Dec 30, 2014:

4:53 PM Changeset in webkit [177828] by Chris Dumez
  • 5 edits in trunk/Source/WebCore

Move font-related CSS properties to the new StyleBuilder
https://bugs.webkit.org/show_bug.cgi?id=140008

Reviewed by Darin Adler.

Move font-related CSS properties to the new StyleBuilder
by teaching makeprop.pl how to generate them.

  • css/CSSPropertyNames.in:
  • css/DeprecatedStyleBuilder.cpp:

(WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder):
(WebCore::ApplyPropertyFont::applyInheritValue): Deleted.
(WebCore::ApplyPropertyFont::applyInitialValue): Deleted.
(WebCore::ApplyPropertyFont::applyValue): Deleted.
(WebCore::ApplyPropertyFont::createHandler): Deleted.

  • css/makeprop.pl:

(generateInitialValueSetter):
(generateInheritValueSetter):
(generateValueSetter):

  • platform/graphics/FontDescription.h:

(WebCore::FontDescription::initialItalic):
(WebCore::FontDescription::initialSmallCaps):
(WebCore::FontDescription::initialKerning):
(WebCore::FontDescription::initialFontSmoothing):
(WebCore::FontDescription::initialTextRenderingMode):

2:25 PM Changeset in webkit [177827] by Chris Dumez
  • 4 edits in trunk/Source/WebCore

Move '-webkit-font-variant-ligature' CSS property to the new StyleBuilder
https://bugs.webkit.org/show_bug.cgi?id=140007

Reviewed by Darin Adler.

Move '-webkit-font-variant-ligature' CSS property to the new StyleBuilder
by using custom code.

  • css/CSSPropertyNames.in:
  • css/DeprecatedStyleBuilder.cpp:

(WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder):
(WebCore::ApplyPropertyFontVariantLigatures::applyInheritValue): Deleted.
(WebCore::ApplyPropertyFontVariantLigatures::applyInitialValue): Deleted.
(WebCore::ApplyPropertyFontVariantLigatures::applyValue): Deleted.
(WebCore::ApplyPropertyFontVariantLigatures::createHandler): Deleted.

  • css/StyleBuilderCustom.h:

(WebCore::StyleBuilderCustom::applyInitialWebkitFontVariantLigatures):
(WebCore::StyleBuilderCustom::applyInheritWebkitFontVariantLigatures):
(WebCore::StyleBuilderCustom::applyValueWebkitFontVariantLigatures):

2:09 PM Changeset in webkit [177826] by rgabor@webkit.org
  • 4 edits in trunk

Source/WebKit2:
Too large plugins are crashing.
https://bugs.webkit.org/show_bug.cgi?id=139868

Reviewed by Darin Adler.

  • WebProcess/Plugins/PluginProxy.cpp:

(WebKit::PluginProxy::updateBackingStore): Return false if backingStore cannot be allocated.

LayoutTests:
Fix bug number typo in the previous commit.

  • plugins/large-plugin-crash-expected.txt:
  • plugins/large-plugin-crash.html:
12:43 PM Changeset in webkit [177825] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit/mac

[Cocoa] Enable the compiler to check format strings specified with UI_STRING and UI_STRING_KEY
https://bugs.webkit.org/show_bug.cgi?id=140003

Reviewed by Darin Adler.

  • Misc/WebLocalizableStrings.h: Made UI_STRING and UI_STRING_KEY call a new helper function

that takes their "string" parameter as a "value" "parameter and has an attribute telling
the compiler that if the "value" parameter is a format string then the function returns a
modified version of it. The result is that if UI_STRING is used as a format string parameter
to some function or method, the compiler will check the format specifiers in the string
against the other parameters.

10:40 AM Changeset in webkit [177824] by rgabor@webkit.org
  • 3 edits
    2 adds in trunk

Too large plugins are crashing.
https://bugs.webkit.org/show_bug.cgi?id=139856

Reviewed by Darin Adler.

Source/WebKit2:

  • WebProcess/Plugins/PluginProxy.cpp:

(WebKit::PluginProxy::updateBackingStore): Return false if backingStore cannot be allocated.

LayoutTests:

Add layout test to cover this crash.

  • plugins/large-plugin-crash-expected.txt: Added.
  • plugins/large-plugin-crash.html: Added.
9:41 AM Changeset in webkit [177823] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Transient local storage namespaces need to ref their storage areas
https://bugs.webkit.org/show_bug.cgi?id=140006
<rdar://problem/19225389>

Reviewed by Sam Weinig.

We need to keep transient storage areas around even if they have no active connections,
so use a RefPtr instead of a raw pointer. This matches what we do for session storage namespaces.

  • UIProcess/Storage/StorageManager.cpp:
4:29 AM Changeset in webkit [177822] by k.czech@samsung.com
  • 2 edits in trunk/Tools

[EFL] Bump version of ATK used by jhbuild to 2.15.2
https://bugs.webkit.org/show_bug.cgi?id=139816

Reviewed by Gyuyoung Kim.

Bump version of ATK used by jhbuild to 2.15.2

  • efl/jhbuild.modules:
Note: See TracTimeline for information about the timeline view.