Timeline



Jan 2, 2015:

2:49 PM Changeset in webkit [177870] by ap@apple.com
  • 8 edits in trunk/Tools

Simplify WebKitTestRunner timeout tracking
​https://bugs.webkit.org/show_bug.cgi?id=140036

Reviewed by Darin Adler.

The code for configuring timeouts was mostly dead, because run-webkit-tests never
passes the --timeout option to WebKitTestRunner.

  • WebKitTestRunner/Options.h:
  • WebKitTestRunner/Options.cpp:

(WTR::Options::Options):
(WTR::OptionsHandler::OptionsHandler):
(WTR::handleOptionTimeout): Deleted.
Removed support for --timeout. Timeouts are passed for each test individually,
and defaults are good enough for the rare cases where WebKitTestRunner is run
manually without run-webkit-tests.

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::TestController):
(WTR::TestController::initialize):
(WTR::TestController::resetStateToConsistentValues):
(WTR::TestController::reattachPageToWebProcess):
(WTR::TestController::runUntil):

  • WebKitTestRunner/TestController.h:

Simplified runUntil by passing the actual timeout, not an enum.
Increased short timeout for ASan enabled builds, as WebProcess launching takes
quite a while.

  • WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::invoke): Removed dead code that handled a timeout from NoTimeout.

  • WebKitTestRunner/efl/TestControllerEfl.cpp:

(WTR::TestController::platformRunUntil):

  • WebKitTestRunner/gtk/TestControllerGtk.cpp:

(WTR::TestController::platformRunUntil):
Build fixes.

2:40 PM Changeset in webkit [177869] by Chris Dumez
  • 14 edits
    2 deletes in trunk/Source/WebCore

Kill the DeprecatedStyleBuilder
​https://bugs.webkit.org/show_bug.cgi?id=140034

Reviewed by Darin Adler.

Move FillLayer properties to the new StyleBuilder and get rid of the
DeprecatedStyleBuilder now that all its CSS properties have been ported
to the new StyleBuilder.

12:07 PM Changeset in webkit [177868] by andersca@apple.com
  • 8 edits
    2 deletes in trunk/Tools

Remove now unused storage tracker glue from DumpRenderTree
​https://bugs.webkit.org/show_bug.cgi?id=140045

Reviewed by Darin Adler.

  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  • DumpRenderTree/StorageTrackerDelegate.h: Removed.
  • DumpRenderTree/StorageTrackerDelegate.mm: Removed.
  • DumpRenderTree/TestRunner.cpp:

(TestRunner::staticFunctions):
(syncLocalStorageCallback): Deleted.
(observeStorageTrackerNotificationsCallback): Deleted.
(deleteAllLocalStorageCallback): Deleted.
(deleteLocalStorageForOriginCallback): Deleted.
(localStorageDiskUsageForOriginCallback): Deleted.
(originsWithLocalStorageCallback): Deleted.

  • DumpRenderTree/TestRunner.h:
  • DumpRenderTree/mac/DumpRenderTree.mm:

(allocateGlobalControllers):
(releaseGlobalControllers):

  • DumpRenderTree/mac/DumpRenderTreeMac.h:
  • DumpRenderTree/mac/TestRunnerMac.mm:

(TestRunner::syncLocalStorage): Deleted.
(TestRunner::localStorageDiskUsageForOrigin): Deleted.
(TestRunner::observeStorageTrackerNotifications): Deleted.
(TestRunner::deleteAllLocalStorage): Deleted.
(TestRunner::originsWithLocalStorage): Deleted.
(TestRunner::deleteLocalStorageForOrigin): Deleted.

  • DumpRenderTree/win/TestRunnerWin.cpp:

(TestRunner::syncLocalStorage): Deleted.
(TestRunner::localStorageDiskUsageForOrigin): Deleted.
(TestRunner::observeStorageTrackerNotifications): Deleted.
(TestRunner::deleteAllLocalStorage): Deleted.
(TestRunner::originsWithLocalStorage): Deleted.
(TestRunner::deleteLocalStorageForOrigin): Deleted.

11:57 AM Changeset in webkit [177867] by andersca@apple.com
  • 8 edits
    1 delete in trunk/LayoutTests

Get rid of storage tracker layout tests
​https://bugs.webkit.org/show_bug.cgi?id=140044

Reviewed by Darin Adler.

These tests are very flaky since they expect to be run in order. Furthermore, they were testing a WebKit Mac SPI
that is pretty hard to test reliably, due to its "design". It's not worth trying to make these tests work
or to rewrite them in Objective-C (which would be the right thing to do), so just get rid of them.

  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/ios-simulator-wk2/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/win/TestExpectations:
  • platform/wincairo/TestExpectations:
  • platform/wk2/TestExpectations:
  • storage/domstorage/localstorage/storagetracker/storage-tracker-1-prepare-expected.txt: Removed.
  • storage/domstorage/localstorage/storagetracker/storage-tracker-1-prepare.html: Removed.
  • storage/domstorage/localstorage/storagetracker/storage-tracker-2-create-expected.txt: Removed.
  • storage/domstorage/localstorage/storagetracker/storage-tracker-2-create.html: Removed.
  • storage/domstorage/localstorage/storagetracker/storage-tracker-3-delete-all-expected.txt: Removed.
  • storage/domstorage/localstorage/storagetracker/storage-tracker-3-delete-all.html: Removed.
  • storage/domstorage/localstorage/storagetracker/storage-tracker-4-create-expected.txt: Removed.
  • storage/domstorage/localstorage/storagetracker/storage-tracker-4-create.html: Removed.
  • storage/domstorage/localstorage/storagetracker/storage-tracker-5-delete-one-expected.txt: Removed.
  • storage/domstorage/localstorage/storagetracker/storage-tracker-5-delete-one.html: Removed.
  • storage/domstorage/localstorage/storagetracker/storage-tracker-6-create-expected.txt: Removed.
  • storage/domstorage/localstorage/storagetracker/storage-tracker-6-create.html: Removed.
  • storage/domstorage/localstorage/storagetracker/storage-tracker-7-usage-expected.txt: Removed.
  • storage/domstorage/localstorage/storagetracker/storage-tracker-7-usage.html: Removed.
11:53 AM Changeset in webkit [177866] by Chris Dumez
  • 8 edits in trunk/Source/WebCore

Move 'font-size' CSS property to the new StyleBuilder
​https://bugs.webkit.org/show_bug.cgi?id=140010

Reviewed by Darin Adler.

Move 'font-size' CSS property to the new StyleBuilder by using custom
code.

10:32 AM Changeset in webkit [177865] by ap@apple.com
  • 2 edits in trunk/LayoutTests

js/dom/Promise.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=140043

10:18 AM Changeset in webkit [177864] by Darin Adler
  • 18 edits in trunk/Source/WebCore

Pass Document instead of ScriptExecutionContext to non-worker constructors
​https://bugs.webkit.org/show_bug.cgi?id=140040

Reviewed by Sam Weinig.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateConstructorDefinition):
Generate code passing the document when ConstructorCallWith=Document is used.
Later, we could base this on whether the constructor is exposed to workers
or not, instead, but for now this seems a clean way to do it.

  • bindings/scripts/IDLAttributes.txt: Allow ConstructorCallWith=Document.
  • Modules/notifications/Notification.cpp:

(WebCore::Notification::create):

  • Modules/notifications/Notification.h:
  • Modules/notifications/Notification.idl:
  • dom/Comment.cpp:
  • dom/Comment.h:
  • dom/Comment.idl:
  • dom/DocumentFragment.cpp:

(WebCore::DocumentFragment::nodeName): Use ASCIILiteral (just something
I noticed in passing).

  • dom/DocumentFragment.h:
  • dom/DocumentFragment.idl:
  • dom/Range.cpp:
  • dom/Range.h:
  • dom/Range.idl:
  • dom/Text.cpp:
  • dom/Text.h:
  • dom/Text.idl:

Change from ScriptExecutionContext to Document, and remove unneeded
overloads that were just casting. It's better to have the bindings
layer, which knows these are not ScriptExecutionContext, do the cast
than to have create functions that cast that are not in any position
to know the cast is safe.

10:17 AM Changeset in webkit [177863] by Darin Adler
  • 5 edits in trunk/Source/WebCore

Re-land the HTMLTreeBuilder change with the assertion fixed.
​https://bugs.webkit.org/show_bug.cgi?id=140032

Reviewed by Andreas Kling.

10:07 AM Changeset in webkit [177862] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

Unreviewed, rolling out r177859 and r177861.
​https://bugs.webkit.org/show_bug.cgi?id=140042

Caused many assertion failures (Requested by ap on #webkit).

Reverted changesets:

"Modernize coding style of HTMLTreeBuilder"
​https://bugs.webkit.org/show_bug.cgi?id=140032
​http://trac.webkit.org/changeset/177859

"Tried to fix the iOS build."
​http://trac.webkit.org/changeset/177861

9:45 AM Changeset in webkit [177861] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

Tried to fix the iOS build.

  • html/parser/HTMLTreeBuilder.cpp:
8:33 AM Changeset in webkit [177860] by Darin Adler
  • 8 edits in trunk/Source

Rework code that hides characters in password fields to streamline a little
​https://bugs.webkit.org/show_bug.cgi?id=140035

Reviewed by Sam Weinig.

Source/WebCore:

  • editing/InsertIntoTextNodeCommand.cpp:

(WebCore::InsertIntoTextNodeCommand::doApply): Pass the offset after the character
we want to reveal instead of the offset before. This is more future proof if we
ever want to handling surrogate pairs or combining marks, rather than hard
coding the likely incorrect rule of "go back by one code unit". Also got rid of
the isSecure check here, since RenderText can do that check inside the
momentarilyRevealLastTypedCharacter instead.

  • rendering/RenderText.cpp: Tweaked the SecureTextTimer class: Marked it final

and made it derive from TimerBase privately. Made the constructor explicit and
made it take a reference rather than a pointer. Use initialization in the class
to set up the variable, and use 0 as the special value instead of -1 since we
now store the offset *after* the character to be revealed.
(WebCore::secureTextTimers): Use this function and NeverDestroyed rather than
a global variable gSecureTextTimers. Also use unique_ptr for the map so we
don't have to delete explicitly any more.
(WebCore::SecureTextTimer::SecureTextTimer): Moved out of the class definition
so the class ia a little easier to read.
(WebCore::SecureTextTimer::restart): Renamed since the function name doesn't
have to describe its argument; the function is only called in one place.
(WebCore::SecureTextTimer::takeOffsetAfterLastTypedCharacter): Changed name
and made this a one-shot that always zeroes the offset.
(WebCore::SecureTextTimer::fired): Moved out of line and tweaked as above.
(WebCore::RenderText::willBeDestroyed): Simplified now that the function
secureTextTimers() always returns a map and we can just remove since the
values in the map are unique_ptr, so take care of deletion.
(WebCore::RenderText::setRenderedText): Tweaked the code that calls secureText
to make the iOS case clearer.
(WebCore::RenderText::secureText): Rewrote the function. New version no
longer relies on a special String::fill function; it's kind of strange that
String had a built in concept of replacing a string with one that has the
same length but all with a masking character. This new approach is cleaner.
I had written a version that handles surrogate pairs and combining marks,
but then instead wrote a comment explaining why that's not needed/helpful.
(WebCore::RenderText::momentarilyRevealLastTypedCharacter): Added a check so
this does nothing if we are not securing the text. Also updated logic so that
this doesn't double hash any more and updated for other changes like using
a reference instead of a pointer.

  • rendering/RenderText.h: Removed the unneeded isSecure function and updated

the argument name in momentarilyRevealLastTypedCharacter since it's now the
offset after the character, not before the character.

Source/WTF:

  • wtf/text/StringImpl.cpp:

(WTF::StringImpl::fill): Deleted.

  • wtf/text/StringImpl.h: Deleted StringImpl::fill.
  • wtf/text/WTFString.h:

(WTF::String::fill): Deleted.

8:31 AM Changeset in webkit [177859] by Darin Adler
  • 5 edits in trunk/Source/WebCore

Modernize coding style of HTMLTreeBuilder
​https://bugs.webkit.org/show_bug.cgi?id=140032

Reviewed by Andreas Kling.

Changes include:

  • Use references rather than pointers.
  • Mark data members const that are fully set up in the constructor.
  • Remove many unneeded includes and forward declarations.
  • Fix conditionals to be consistent and correct.
  • Merge some multi-line constructs into a single line.
  • Update whatwg.org URLs; not sure we should keep these, though.
  • Cut down on use of WTF_MAKE_NONCOPYABLE since for many classes it's impossible to copy anyway due to references, or harmless to copy.
  • Made more things private.
  • Initialize scalars in the class definition rather than each constructor.
  • Use Ref/RefPtr instead of PassRefPtr.
  • html/parser/HTMLDocumentParser.cpp:

(WebCore::HTMLDocumentParser::HTMLDocumentParser): Pass reference rather than pointer to
the context element.
(WebCore::HTMLDocumentParser::detach): Removed call to HTMLTreeBuilder::detach. This work
is instead done when the tree builder is destroyed.
(WebCore::HTMLDocumentParser::constructTreeFromHTMLToken): Pass reference rather than pointer.

  • html/parser/HTMLTreeBuilder.cpp:

(WebCore::uninitializedPositionValue1): Marked this inline because it's trivial. It was
probably getting inlined already.
(WebCore::isCaptionColOrColgroupTag): Format on a single line.
(WebCore::isTableBodyContextTag): Ditto.
(WebCore::isNonAnchorFormattingTag): Ditto.
(WebCore::HTMLTreeBuilder::ExternalCharacterTokenBuffer::ExternalCharacterTokenBuffer):
Take reference instead of pointer.
(WebCore::HTMLTreeBuilder::ExternalCharacterTokenBuffer::takeRemaining): Use makeString helper.
(WebCore::HTMLTreeBuilder::ExternalCharacterTokenBuffer::skipLeading): Tweak formatting.
(WebCore::HTMLTreeBuilder::ExternalCharacterTokenBuffer::takeLeading): Both of the above.
(WebCore::HTMLTreeBuilder::ExternalCharacterTokenBuffer::makeString): Added.
(WebCore::HTMLTreeBuilder::isParsingTemplateContents): Moved the body of this function here,
since it's only used inside the class.
(WebCore::HTMLTreeBuilder::isParsingFragmentOrTemplateContents): Ditto.
(WebCore::HTMLTreeBuilder::HTMLTreeBuilder): Get rid of dead code that handles a null context
element. The FIXME mentions a bug that is obsolete. Also reorder the data members to be a bit
more logical and set the new m_destructionProhibited to false at the end of the constructor,
to check if we accidentally destroy the tree builder while constructing it.
(WebCore::HTMLTreeBuilder::FragmentParsingContext::FragmentParsingContext): Updated to take
a reference and to let m_fragment get initialized in the class definition.
(WebCore::HTMLTreeBuilder::FragmentParsingContext::fragment): Moved this here since it's only
used inside the class.
(WebCore::HTMLTreeBuilder::FragmentParsingContext::contextElement): Ditto.
(WebCore::HTMLTreeBuilder::FragmentParsingContext::contextElementStackItem): Ditto.
(WebCore::HTMLTreeBuilder::takeScriptToProcess): Changed return type to RefPtr instead of
PassRefPtr. Added code to handle m_scriptToProcess of null, since reading the code at the
single call site makes it clear that it's not guaranteed to be non-null! Added destruction-
related assertions since this is a public function.
(WebCore::HTMLTreeBuilder::constructTree): Updated for reference rather than pointer. Also
added destruction-related assertions since this is a public function.
(WebCore::HTMLTreeBuilder::processToken): Updated to take a reference.
(WebCore::HTMLTreeBuilder::processDoctypeToken): Ditto.
(WebCore::HTMLTreeBuilder::processFakeStartTag): Ditto. Also take an rvalue reference for
the vector of attributes that we will put into the token.
(WebCore::HTMLTreeBuilder::processFakeEndTag): Ditto.
(WebCore::HTMLTreeBuilder::processFakePEndTagIfPInButtonScope): Ditto.
(WebCore::HTMLTreeBuilder::attributesForIsindexInput): Ditto.
(WebCore::HTMLTreeBuilder::processIsindexStartTagForInBody): Ditto.
(WebCore::isLi): Ditto.
(WebCore::isDdOrDt): Ditto.
(WebCore::HTMLTreeBuilder::processCloseWhenNestedTag): Changed loop to use reference
rather than pointer for never-null stackItem. Also use auto and a for loop to make the
loop easier to read.
(WebCore::createCaseMap): Tweaked formatting.
(WebCore::adjustAttributes): Ditto.
(WebCore::HTMLTreeBuilder::processStartTagForInBody): Use reference instead of pointer.
Set insertion mode directly instead of using a setInsertionMode function.
(WebCore::HTMLTreeBuilder::processTemplateStartTag): Ditto.
(WebCore::HTMLTreeBuilder::processTemplateEndTag): Ditto.
(WebCore::HTMLTreeBuilder::processEndOfFileForInTemplateContents): Ditto.
(WebCore::HTMLTreeBuilder::processColgroupEndTagForInColumnGroup): Ditto.
(WebCore::HTMLTreeBuilder::closeTheCell): Ditto.
(WebCore::HTMLTreeBuilder::processStartTagForInTable): Ditto.
(WebCore::HTMLTreeBuilder::processStartTag): Ditto. Tweaked assertions, so that we
assert what state we are in before we fall through to each case, rather than asserting
inside each case. The per-case assertions were sort of excessive and repetitive and
even a bit hard to understand.
(WebCore::HTMLTreeBuilder::processHtmlStartTagForInBody): Ditto.
(WebCore::HTMLTreeBuilder::processBodyEndTagForInBody): Ditto.
(WebCore::HTMLTreeBuilder::processAnyOtherEndTagForInBody): Ditto.
(WebCore::HTMLTreeBuilder::callTheAdoptionAgency): Ditto.
(WebCore::HTMLTreeBuilder::resetInsertionModeAppropriately): Ditto.
(WebCore::HTMLTreeBuilder::processEndTagForInTableBody): Ditto.
(WebCore::HTMLTreeBuilder::processEndTagForInRow): Ditto.
(WebCore::HTMLTreeBuilder::processEndTagForInCell): Ditto.
(WebCore::HTMLTreeBuilder::processEndTagForInBody): Ditto.
(WebCore::HTMLTreeBuilder::processCaptionEndTagForInCaption): Ditto.
(WebCore::HTMLTreeBuilder::processTrEndTagForInRow): Ditto.
(WebCore::HTMLTreeBuilder::processTableEndTagForInTable): Ditto.
(WebCore::HTMLTreeBuilder::processEndTagForInTable): Ditto.
(WebCore::HTMLTreeBuilder::processEndTag): Ditto.
(WebCore::HTMLTreeBuilder::processComment): Ditto.
(WebCore::HTMLTreeBuilder::processCharacter): Ditto.
(WebCore::HTMLTreeBuilder::insertPhoneNumberLink): Ditto.
(WebCore::HTMLTreeBuilder::processCharacterBuffer): Ditto.
(WebCore::HTMLTreeBuilder::processCharacterBufferForInBody): Ditto.
(WebCore::HTMLTreeBuilder::processEndOfFile): Ditto.
(WebCore::HTMLTreeBuilder::defaultForInitial): Ditto.
(WebCore::HTMLTreeBuilder::defaultForBeforeHTML): Ditto.
(WebCore::HTMLTreeBuilder::defaultForBeforeHead): Ditto.
(WebCore::HTMLTreeBuilder::defaultForInHead): Ditto.
(WebCore::HTMLTreeBuilder::defaultForInHeadNoscript): Ditto.
(WebCore::HTMLTreeBuilder::defaultForAfterHead): Ditto.
(WebCore::HTMLTreeBuilder::defaultForInTableText): Ditto.
(WebCore::HTMLTreeBuilder::processStartTagForInHead): Ditto.
(WebCore::HTMLTreeBuilder::processGenericRCDATAStartTag): Ditto.
(WebCore::HTMLTreeBuilder::processGenericRawTextStartTag): Ditto.
(WebCore::HTMLTreeBuilder::processScriptStartTag): Ditto.
(WebCore::HTMLTreeBuilder::adjustedCurrentStackItem): Made this return a reference.
(WebCore::HTMLTreeBuilder::shouldProcessTokenInForeignContent): More of the same.
(WebCore::HTMLTreeBuilder::processTokenInForeignContent): Ditto.
(WebCore::HTMLTreeBuilder::finished): Changed m_isAttached assertion to !m_destroyed.
Also updated the comment.
(WebCore::HTMLTreeBuilder::parseError): Marked this empty function inline.

  • html/parser/HTMLTreeBuilder.h: Removed most includes and forward declarations.

Changed the phone number functions conditional to be correct. Removed a non-helpful
FIXME about assertions we really don't need. Removed unneeded use of the inline keyword,
changed types to references rather than pointer. Removed unneeded public insertionMode
and setInsertionMode functions. Both are things that are only done inside this class and
m_insertionMode can be accessed directly instead. Added a destructor that implements
the destruction assertions. Asserted !m_destroyed at the start of all the public functions.

  • html/parser/TextDocumentParser.cpp:

(WebCore::TextDocumentParser::insertFakePreElement): Use reference rather than pointer.

2:01 AM Changeset in webkit [177858] by Manuel Rego Casasnovas
  • 23 edits in trunk

[CSS Grid Layout] Remove stack from grid-auto-flow syntax
​https://bugs.webkit.org/show_bug.cgi?id=134842

Reviewed by Sergio Villar Senin.

Source/WebCore:

"stack" mode for grid-auto-flow property has been removed from the grid
layout spec. New syntax is:

[ row | column ]
dense

Modified parsing in order to adapt it to the new syntax.

Also the current behavior relying on "stack" has been updated following
the spec. Now it won't be possible to mimic the old "none" (or "stack")
unless you specify manually the grid-placement properties.

No new tests needed, updated current tests to adapt them to the new
behavior.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::ComputedStyleExtractor::propertyValue): Adapt to new syntax.

  • css/CSSParser.cpp:

(WebCore::isValidGridAutoFlowId): Remove "stack" from valid ids.
(WebCore::CSSParser::parseGridAutoFlow): Adapt to new syntax.

  • css/CSSValueKeywords.in: Remove "stack".
  • css/StyleResolver.cpp:

(WebCore::StyleResolver::applyProperty): Adapt to new syntax.

  • rendering/RenderGrid.cpp:

(WebCore::RenderGrid::placeItemsOnGrid): Remove old "stack" code.

  • rendering/style/GridResolvedPosition.cpp:

(WebCore::GridResolvedPosition::resolveGridPositionsFromStyle): If we
cannot resolve positions, we have to run the auto-placement algorithm.

  • rendering/style/RenderStyle.h: Remove "stack".
  • rendering/style/RenderStyleConstants.h: Ditto.

LayoutTests:

Update layout tests in order to adapt the results to the new behavior.

  • fast/css-grid-layout/grid-auto-flow-get-set-expected.txt:
  • fast/css-grid-layout/grid-auto-flow-get-set.html:
  • fast/css-grid-layout/grid-auto-flow-update.html:
  • fast/css-grid-layout/grid-item-named-grid-area-resolution.html:
  • fast/css-grid-layout/grid-item-z-index-change-repaint.html:
  • fast/css-grid-layout/grid-item-z-index-stacking-context.html:
  • fast/css-grid-layout/grid-shorthand-get-set-expected.txt:
  • fast/css-grid-layout/grid-shorthand-get-set.html:
  • fast/css-grid-layout/named-grid-lines-with-named-grid-areas-dynamic-get-set.html:
  • fast/css-grid-layout/named-grid-lines-with-named-grid-areas-resolution.html:
  • ietestcenter/css3/grid/grid-column-001.htm:
  • ietestcenter/css3/grid/grid-column-002.htm:
  • ietestcenter/css3/grid/grid-column-003.htm:

Jan 1, 2015:

9:26 PM Changeset in webkit [177857] by commit-queue@webkit.org
  • 41 edits
    2 deletes in trunk/Source

Remove GroupSettings
​https://bugs.webkit.org/show_bug.cgi?id=140037

Patch by Sam Weinig <​sam@webkit.org> on 2015-01-01
Reviewed by Dan Bernstein.

Source/WebCore:

Nothing sets the values in GroupSettings and nothing uses them.

  • The indexedDBDatabasePath is accessed and sent to the IndexedDB backend, but the backend then proceeds to not use it.
  • CMakeLists.txt:
  • Modules/indexeddb/IDBFactory.cpp:

(WebCore::IDBFactory::getDatabaseNames):
(WebCore::IDBFactory::deleteDatabase):

  • Modules/indexeddb/IDBFactoryBackendInterface.cpp:

(WebCore::IDBFactoryBackendInterface::create):

  • Modules/indexeddb/IDBFactoryBackendInterface.h:
  • Modules/indexeddb/PageGroupIndexedDatabase.cpp:

(WebCore::PageGroupIndexedDatabase::PageGroupIndexedDatabase):
(WebCore::PageGroupIndexedDatabase::from):
(WebCore::PageGroupIndexedDatabase::factoryBackend):

  • Modules/indexeddb/PageGroupIndexedDatabase.h:
  • Modules/indexeddb/WorkerGlobalScopeIndexedDatabase.cpp:

(WebCore::WorkerGlobalScopeIndexedDatabase::WorkerGlobalScopeIndexedDatabase):
(WebCore::WorkerGlobalScopeIndexedDatabase::from):
(WebCore::WorkerGlobalScopeIndexedDatabase::indexedDB):

  • Modules/indexeddb/WorkerGlobalScopeIndexedDatabase.h:
  • WebCore.exp.in:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/DocumentStyleSheetCollection.cpp:
  • page/CaptionUserPreferences.cpp:
  • page/Frame.cpp:
  • page/GroupSettings.cpp: Removed.
  • page/GroupSettings.h: Removed.
  • page/PageGroup.cpp:

(WebCore::PageGroup::PageGroup):

  • page/PageGroup.h:

(WebCore::PageGroup::groupSettings): Deleted.

  • platform/DatabaseStrategy.cpp:

(WebCore::DatabaseStrategy::createIDBFactoryBackend):

  • platform/DatabaseStrategy.h:
  • workers/DedicatedWorkerGlobalScope.cpp:

(WebCore::DedicatedWorkerGlobalScope::create):
(WebCore::DedicatedWorkerGlobalScope::DedicatedWorkerGlobalScope):

  • workers/DedicatedWorkerGlobalScope.h:
  • workers/DedicatedWorkerThread.cpp:

(WebCore::DedicatedWorkerThread::create):
(WebCore::DedicatedWorkerThread::DedicatedWorkerThread):
(WebCore::DedicatedWorkerThread::createWorkerGlobalScope):

  • workers/DedicatedWorkerThread.h:
  • workers/DefaultSharedWorkerRepository.cpp:

(WebCore::DefaultSharedWorkerRepository::workerScriptLoaded):
(WebCore::SharedWorkerProxy::groupSettings): Deleted.

  • workers/SharedWorkerGlobalScope.cpp:

(WebCore::SharedWorkerGlobalScope::create):
(WebCore::SharedWorkerGlobalScope::SharedWorkerGlobalScope):

  • workers/SharedWorkerGlobalScope.h:
  • workers/SharedWorkerThread.cpp:

(WebCore::SharedWorkerThread::create):
(WebCore::SharedWorkerThread::SharedWorkerThread):
(WebCore::SharedWorkerThread::createWorkerGlobalScope):

  • workers/SharedWorkerThread.h:
  • workers/WorkerGlobalScope.cpp:

(WebCore::WorkerGlobalScope::WorkerGlobalScope):

  • workers/WorkerGlobalScope.h:

(WebCore::WorkerGlobalScope::groupSettings): Deleted.

  • workers/WorkerMessagingProxy.cpp:

(WebCore::WorkerMessagingProxy::startWorkerGlobalScope):

  • workers/WorkerThread.cpp:

(WebCore::WorkerThreadStartupData::WorkerThreadStartupData):
(WebCore::WorkerThread::WorkerThread):
(WebCore::WorkerThread::workerThread):

  • workers/WorkerThread.h:

Source/WebKit2:

Remove unused databaseDirectoryIdentifier parameters.

  • WebProcess/Databases/IndexedDB/WebIDBFactoryBackend.cpp:

(WebKit::WebIDBFactoryBackend::WebIDBFactoryBackend):
(WebKit::WebIDBFactoryBackend::getDatabaseNames):
(WebKit::WebIDBFactoryBackend::deleteDatabase):

  • WebProcess/Databases/IndexedDB/WebIDBFactoryBackend.h:
  • WebProcess/Storage/StorageNamespaceImpl.cpp:
  • WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:

(WebKit::WebPlatformStrategies::createIDBFactoryBackend):

  • WebProcess/WebCoreSupport/WebPlatformStrategies.h:
8:41 PM Changeset in webkit [177856] by Yusuke Suzuki
  • 5 edits in trunk

Source/JavaScriptCore:
String includes methods perform toString on searchString before toInt32 on a offset
​https://bugs.webkit.org/show_bug.cgi?id=140031

Reviewed by Darin Adler.

  • runtime/StringPrototype.cpp:

(JSC::stringProtoFuncStartsWith):
(JSC::stringProtoFuncEndsWith):
(JSC::stringProtoFuncIncludes):

LayoutTests:
String includes methods perform toString on searchString before toInteger on a offset
​https://bugs.webkit.org/show_bug.cgi?id=140031

Reviewed by Darin Adler.

As per the latest ES6 draft, String.prototype.{startsWith, endsWith, includes}
perform toString on searchString (argument 0) before performing toInteger on offset (argument 1).

  • js/script-tests/string-includes.js:

(searchString.toString):
(startOffset.valueOf):
(endOffset.valueOf):
(matchString.toString): Deleted.

  • js/string-includes-expected.txt:
6:05 PM Changeset in webkit [177855] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

Tried to fix the iOS build.

  • page/scrolling/ios/ScrollingTreeIOS.cpp:

(WebCore::ScrollingTreeIOS::scrollingTreeNodeDidScroll):

5:13 PM Changeset in webkit [177854] by gyuyoung.kim@samsung.com
  • 3 edits in trunk/Source/JavaScriptCore

Change to return std::unique_ptr<> in fooCreate()
​https://bugs.webkit.org/show_bug.cgi?id=139983

Reviewed by Darin Adler.

To avoid unnecessary std::unique_ptr<> casting, fooCreate() returns std::unique_ptr<> directly.

  • create_regex_tables:
  • yarr/YarrPattern.h:

(JSC::Yarr::YarrPattern::reset):
(JSC::Yarr::YarrPattern::newlineCharacterClass):
(JSC::Yarr::YarrPattern::digitsCharacterClass):
(JSC::Yarr::YarrPattern::spacesCharacterClass):
(JSC::Yarr::YarrPattern::wordcharCharacterClass):
(JSC::Yarr::YarrPattern::nondigitsCharacterClass):
(JSC::Yarr::YarrPattern::nonspacesCharacterClass):
(JSC::Yarr::YarrPattern::nonwordcharCharacterClass):

4:57 PM Changeset in webkit [177853] by Darin Adler
  • 2 edits in trunk/Source/WebCore

Fix itearator typo
​https://bugs.webkit.org/show_bug.cgi?id=140027

Reviewed by Csaba Osztrogonác.

  • rendering/SimpleLineLayoutFlowContents.cpp:

(WebCore::SimpleLineLayout::nextBreakablePosition): Spelling mistake.

4:29 PM Changeset in webkit [177852] by ap@apple.com
  • 2 edits in trunk/Source/WebCore

Don't dereference end() in SimpleLineLayout::RunResolver::rangeForRenderer
​https://bugs.webkit.org/show_bug.cgi?id=139951
rdar://problem/19339881

Reviewed by Darin Adler.

  • rendering/SimpleLineLayoutResolver.cpp:

(WebCore::SimpleLineLayout::RunResolver::rangeForRenderer):

3:53 PM Changeset in webkit [177851] by Chris Dumez
  • 3 edits in trunk/Source/WebCore

ASSERT that a null key is never used with FeatureCounter
​https://bugs.webkit.org/show_bug.cgi?id=140030

Reviewed by Darin Adler.

  • platform/FeatureCounter.cpp:

(WebCore::FeatureCounter::incrementKey):
(WebCore::FeatureCounter::setKey):

  • platform/ios/FeatureCounter.mm:

(WebCore::FeatureCounter::incrementKey):
(WebCore::FeatureCounter::setKey):

2:35 PM Changeset in webkit [177850] by Chris Dumez
  • 2 edits in trunk/Source/WebCore

[iOS] Fix memory leak in FeatureCounter
​https://bugs.webkit.org/show_bug.cgi?id=140029
<rdar://problem/19255690>

Reviewed by Darin Adler.

Fix memory leak in FeatureCounter. The NSString for the counter key
was allocated but never released. The patch switches to using a
RetainPtr instead of a raw pointer to avoid the issue.

  • platform/ios/FeatureCounter.mm:

(WebCore::FeatureCounter::incrementKey):
(WebCore::FeatureCounter::setKey):

2:21 PM Changeset in webkit [177849] by jeffm@apple.com
  • 27 edits in trunk

Update user-visible copyright strings to include 2015
​https://bugs.webkit.org/show_bug.cgi?id=139880

Reviewed by Darin Adler.

Source/JavaScriptCore:

  • Info.plist:

Source/WebCore:

  • Info.plist:

Source/WebKit/mac:

  • Info.plist:

Source/WebKit2:

  • DatabaseProcess/EntryPoint/mac/LegacyProcess/Info.plist:
  • DatabaseProcess/EntryPoint/mac/XPCService/DatabaseService.Development/Info.plist:
  • DatabaseProcess/EntryPoint/mac/XPCService/DatabaseService/Info.plist:
  • Info.plist:
  • NetworkProcess/EntryPoint/mac/LegacyProcess/Info.plist:
  • NetworkProcess/EntryPoint/mac/XPCService/NetworkService.Development/Info-OSX.plist:
  • NetworkProcess/EntryPoint/mac/XPCService/NetworkService.Development/Info-iOS.plist:
  • NetworkProcess/EntryPoint/mac/XPCService/NetworkService/Info-OSX.plist:
  • NetworkProcess/EntryPoint/mac/XPCService/NetworkService/Info-iOS.plist:
  • PluginProcess/EntryPoint/mac/LegacyProcess/Info.plist:
  • PluginProcess/EntryPoint/mac/XPCService/PluginService.32-64.Info.plist:
  • PluginProcess/EntryPoint/mac/XPCService/PluginService.Development/Info.plist:
  • WebProcess/EntryPoint/mac/LegacyProcess/Info.plist:
  • WebProcess/EntryPoint/mac/XPCService/WebContentService.Development/Info-OSX.plist:
  • WebProcess/EntryPoint/mac/XPCService/WebContentService.Development/Info-iOS.plist:
  • WebProcess/EntryPoint/mac/XPCService/WebContentService/Info-OSX.plist:
  • WebProcess/EntryPoint/mac/XPCService/WebContentService/Info-iOS.plist:
  • mac/Info-WebKit2.plist:

WebKitLibraries:

  • win/tools/scripts/COPYRIGHT-END-YEAR:
1:20 PM Changeset in webkit [177848] by weinig@apple.com
  • 9 edits in trunk/Source

Move scrolling code off of WTF::bind
​https://bugs.webkit.org/show_bug.cgi?id=140019

Reviewed by Darin Adler.

Source/WebCore:

  • page/scrolling/ThreadedScrollingTree.cpp:

(WebCore::ThreadedScrollingTree::tryToHandleWheelEvent):
(WebCore::ThreadedScrollingTree::invalidate):
(WebCore::ThreadedScrollingTree::scrollingTreeNodeDidScroll):
(WebCore::ThreadedScrollingTree::handleWheelEventPhase):
(WebCore::derefScrollingCoordinator): Deleted.

  • page/scrolling/ios/ScrollingTreeIOS.cpp:

(WebCore::ScrollingTreeIOS::invalidate):
(WebCore::ScrollingTreeIOS::scrollingTreeNodeDidScroll):
(WebCore::derefScrollingCoordinator): Deleted.

  • page/scrolling/mac/ScrollingCoordinatorMac.mm:

(WebCore::ScrollingCoordinatorMac::pageDestroyed):
(WebCore::ScrollingCoordinatorMac::handleWheelEvent):

  • platform/MemoryPressureHandler.cpp:

(WebCore::MemoryPressureHandler::releaseMemory):

  • workers/WorkerThread.cpp:

(WebCore::WorkerThread::releaseFastMallocFreeMemoryInAllThreads):

Source/WebKit2:

  • WebProcess/WebPage/EventDispatcher.cpp:

(WebKit::EventDispatcher::wheelEvent):
(WebKit::EventDispatcher::touchEvent):

  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::updatePreferences):

12:49 PM Changeset in webkit [177847] by Antti Koivisto
  • 9 edits in trunk/Source/WebCore

Remove FontData::containsCharacters
​https://bugs.webkit.org/show_bug.cgi?id=140026

Reviewed by Dan Bernstein.

This virtual function has no clients.

  • platform/graphics/FontData.h:
  • platform/graphics/SegmentedFontData.cpp:

(WebCore::SegmentedFontData::containsCharacter): Deleted.
(WebCore::SegmentedFontData::containsCharacters): Deleted.

  • platform/graphics/SegmentedFontData.h:
  • platform/graphics/SimpleFontData.h:
  • platform/graphics/freetype/SimpleFontDataFreeType.cpp:

(WebCore::SimpleFontData::containsCharacters): Deleted.

  • platform/graphics/ios/SimpleFontDataIOS.mm:

(WebCore::SimpleFontData::containsCharacters): Deleted.

  • platform/graphics/mac/SimpleFontDataMac.mm:

(WebCore::SimpleFontData::containsCharacters): Deleted.

  • platform/graphics/win/SimpleFontDataWin.cpp:

(WebCore::SimpleFontData::containsCharacters): Deleted.

11:56 AM Changeset in webkit [177846] by Darin Adler
  • 22 edits in trunk

We often misspell identifier as "identifer"
​https://bugs.webkit.org/show_bug.cgi?id=140025

Reviewed by Michael Saboff.

Source/JavaScriptCore:

  • runtime/ArrayConventions.h: Fix it.

Source/WebCore:

  • html/MediaFragmentURIParser.cpp:

(WebCore::MediaFragmentURIParser::parseNPTFragment):

  • html/parser/AtomicHTMLToken.h:
  • html/parser/HTMLToken.h:
  • html/shadow/SliderThumbElement.h:
  • platform/graphics/ISOVTTCue.cpp:

(WebCore::ISOWebVTTCue::ISOWebVTTCue):

  • platform/graphics/ISOVTTCue.h:

(WebCore::ISOWebVTTCue::id):
Fix mispellings.

Source/WebInspectorUI:

  • UserInterface/Base/Main.js:

(WebInspector._updateNavigationSidebarForCurrentContentView):
(WebInspector._contentBrowserCurrentContentViewDidChange):
Fix misspellings.

Source/WebKit2:

  • Shared/WebPageGroupData.cpp:

(WebKit::WebPageGroupData::encode):
(WebKit::WebPageGroupData::decode):

  • Shared/WebPageGroupData.h:
  • UIProcess/WebPageGroup.cpp:

(WebKit::pageGroupData):
(WebKit::WebPageGroup::WebPageGroup):

  • UIProcess/WebPageGroup.h:

(WebKit::WebPageGroup::identifier):

  • WebProcess/WebPage/WebInspector.cpp:

(WebKit::WebInspector::createInspectorPage):

  • WebProcess/WebPage/WebPageGroupProxy.cpp:

(WebKit::WebPageGroupProxy::WebPageGroupProxy):

  • WebProcess/WebPage/WebPageGroupProxy.h:

(WebKit::WebPageGroupProxy::identifier):
Fix misspellings.

Tools:

  • LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
  • Scripts/webkitdirs.pm:

(appIdentifierFromBundle):
(installAndLaunchIOSWebKitAppInSimulator):
Fix misspellings

5:59 AM WebKitGTK/StartHacking edited by Michael Catanzaro
fixup (diff)
5:58 AM WebKitGTK/StartHacking edited by Michael Catanzaro
Don't recommend old unsupported distro releases (diff)
5:54 AM WebKitGTK/StartHacking edited by Michael Catanzaro
fix path to MiniBrowser (diff)
5:48 AM WebKitGTK/TrackingMemoryErrors edited by Michael Catanzaro
fix path to MiniBrowser (diff)
12:32 AM Changeset in webkit [177845] by Alan Bujtas
  • 4 edits in trunk

Saturated arithmetics: Incorrect float/double clamping.
​https://bugs.webkit.org/show_bug.cgi?id=139888
rdar://problem/19330885

Reviewed by Simon Fraser.

Clamp float and double values correctly when applying saturated arithmetics.

Source/WebCore:

Test: LayoutUnit test for float overflow.

  • platform/LayoutUnit.h:

(WebCore::LayoutUnit::LayoutUnit):

Tools:

  • TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp:

(TestWebKitAPI::TEST):

12:06 AM Changeset in webkit [177844] by ap@apple.com
  • 2 edits in trunk/LayoutTests

http/tests/xmlhttprequest/send-on-abort.html is flaky in debug builds
​https://bugs.webkit.org/show_bug.cgi?id=140020

Reviewed by Darin Adler.

  1. XHR loads are aborted when a page load starts, not when it's committed (which

is a known bug in WebKit). This gave the failure timer an opportunity to fire between
these events. Fixed by extending the delay.

  1. Starting the test while parsing had a potential for a race with loading - we

could run it before all data was loaded. While this probably didn't happen in
practice here, it's better to run navigation tests under 100% reproducible conditions,
like during onload.

  • http/tests/xmlhttprequest/send-on-abort.html:
12:05 AM Changeset in webkit [177843] by ap@apple.com
  • 12 edits in trunk/LayoutTests

http/tests/notifications/legacy/show.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=140023

http/tests/notifications/window-show-on-click.html is failing
​https://bugs.webkit.org/show_bug.cgi?id=112499

Reviewed by Darin Adler.

Remove 100 ms timeouts from notification tests. If they become broken, it will
be detected as timeout.

  • http/tests/notifications/events-in-dictionary.html:
  • http/tests/notifications/events.html:
  • http/tests/notifications/legacy/double-show.html:
  • http/tests/notifications/legacy/events.html:
  • http/tests/notifications/legacy/request-no-callback.html:
  • http/tests/notifications/legacy/request.html:
  • http/tests/notifications/legacy/show.html:
  • http/tests/notifications/legacy/window-show-on-click.html:
  • http/tests/notifications/request.html:
  • http/tests/notifications/window-show-on-click.html:
  • platform/mac/TestExpectations: window-show-on-click.html should pass now.
12:04 AM Changeset in webkit [177842] by ap@apple.com
  • 3 edits in trunk/LayoutTests

fast/ruby/ruby-svg-crash.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=135610

Reviewed by Darin Adler.

  • fast/ruby/ruby-svg-crash.html: Streamline the test to avoid timer races. I

verified that it still crashes without the original fix (it gets an
ASSERT_WITH_SECURITY_IMPILICATIONS).

  • platform/mac/TestExpectations: Removed the expectation.
Note: See TracTimeline for information about the timeline view.