⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jan 17, 2015:

5:41 PM Changeset in webkit [178630] by Chris Dumez
  • 9 edits
    3 copies
    1 add in trunk/Source/WebKit2

[WK2][iOS] Add Cocoa delegate for logging diagnostic messages
​https://bugs.webkit.org/show_bug.cgi?id=140410

Reviewed by Sam Weinig.

Add Cocoa delegate for logging diagnostic messages.

  • UIProcess/API/APIDiagnosticLoggingClient.h: Copied from Source/WebKit2/UIProcess/WebPageDiagnosticLoggingClient.h.

(API::DiagnosticLoggingClient::~DiagnosticLoggingClient):
(API::DiagnosticLoggingClient::logDiagnosticMessage):
(API::DiagnosticLoggingClient::logDiagnosticMessageWithResult):
(API::DiagnosticLoggingClient::logDiagnosticMessageWithValue):

  • UIProcess/API/C/WKPage.cpp:

(WKPageSetPageDiagnosticLoggingClient):

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView initWithFrame:configuration:]):
(-[WKWebView _diagnosticLoggingDelegate]):
(-[WKWebView _setDiagnosticLoggingDelegate:]):

  • UIProcess/API/Cocoa/WKWebViewPrivate.h:
  • UIProcess/API/Cocoa/_WKDiagnosticLoggingDelegate.h: Copied from Source/WebKit2/UIProcess/WebPageDiagnosticLoggingClient.h.
  • UIProcess/Cocoa/DiagnosticLoggingClient.h: Copied from Source/WebKit2/UIProcess/WebPageDiagnosticLoggingClient.h.
  • UIProcess/Cocoa/DiagnosticLoggingClient.mm: Added.

(WebKit::DiagnosticLoggingClient::DiagnosticLoggingClient):
(WebKit::DiagnosticLoggingClient::delegate):
(WebKit::DiagnosticLoggingClient::setDelegate):
(WebKit::DiagnosticLoggingClient::logDiagnosticMessage):
(WebKit::DiagnosticLoggingClient::logDiagnosticMessageWithResult):
(WebKit::DiagnosticLoggingClient::logDiagnosticMessageWithValue):

  • UIProcess/WebPageDiagnosticLoggingClient.cpp:

(WebKit::WebPageDiagnosticLoggingClient::WebPageDiagnosticLoggingClient):

  • UIProcess/WebPageDiagnosticLoggingClient.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::setDiagnosticLoggingClient):
(WebKit::WebPageProxy::close):
(WebKit::WebPageProxy::logDiagnosticMessage):
(WebKit::WebPageProxy::logDiagnosticMessageWithResult):
(WebKit::WebPageProxy::logDiagnosticMessageWithValue):
(WebKit::WebPageProxy::initializeDiagnosticLoggingClient): Deleted.

  • UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::diagnosticLoggingClient):

  • WebKit2.xcodeproj/project.pbxproj:
4:20 PM Changeset in webkit [178629] by msaboff@apple.com
  • 3 edits
    3 adds in trunk

Crash in JSScope::resolve() on tools.ups.com
​https://bugs.webkit.org/show_bug.cgi?id=140579

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

For op_resolve_scope of a global property or variable that needs to check for the var
injection check watchpoint, we need to keep the scope around with a Phantom. The
baseline JIT slowpath for op_resolve_scope needs the scope value if the watchpoint
fired.

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

LayoutTests:

New regression test.

  • js/regress-140579-expected.txt: Added.
  • js/regress-140579.html: Added.
  • js/script-tests/regress-140579.js: Added.

(Test.this.isString):
(Test.this.test):
(Test):

2:51 PM Changeset in webkit [178628] by mmaxfield@apple.com
  • 5 edits in trunk/Source/WebCore

[SVG -> OTF Converter] Crashes when SVG font is invalid
​https://bugs.webkit.org/show_bug.cgi?id=140378

Reviewed by Antti Koivisto.

Because CachedSVGFonts are cached, they have to be able to be used
in subsequent documents regardless how the first document left it.

Tests: fast/css/font-face-svg-decoding-error.html

svg/custom/svg-fonts-in-html.html
svg/text/text-overflow-ellipsis-svgfont-kerning-ligatures.html

  • loader/cache/CachedFont.cpp:

(WebCore::CachedFont::ensureCustomFontData):

  • loader/cache/CachedFont.h:
  • loader/cache/CachedSVGFont.cpp:

(WebCore::CachedSVGFont::getFontData):
(WebCore::CachedSVGFont::ensureCustomFontData):
(WebCore::CachedSVGFont::maybeInitializeExternalSVGFontElement):

  • loader/cache/CachedSVGFont.h:
9:18 AM Changeset in webkit [178627] by Chris Dumez
  • 6 edits in trunk

Converting time, angle and frequency units in CSS calc() function
​https://bugs.webkit.org/show_bug.cgi?id=138356

Reviewed by Darin Adler.

Source/WebCore:

Update CSSPrimitiveValue::primitiveType() to actually query the
primitiveType of the CSSCalcValue instead of assuming a given
type based on its category (e.g. If category is CalcTime, then
assume type is CSS_MS, even though it would be CSS_S as well).

This would like to calculation errors such as:
calc(4s + 1s) -> 5ms

Because we would assume the unit is CSS_MS without actually
checking.

This patch is inspired by the following Blink revision
by <​rhodovan.u-szeged@partner.samsung.com> and initial WebKit
patch from <​tmeszaros.u-szeged@partner.samsung.com>:
​https://src.chromium.org/viewvc/blink?view=rev&revision=179101

Test: fast/css/calc-with-angle-time-frequency.html

  • css/CSSCalculationValue.h:

(WebCore::CSSCalcValue::primitiveType):

  • css/CSSPrimitiveValue.cpp:

(WebCore::CSSPrimitiveValue::primitiveType):

LayoutTests:

Update fast/css/calc-with-angle-time-frequency.html to include more
test cases and actually validate the result of the calculation,
instead of merely setting the CSS property and being happy if we don't
crash.

  • fast/css/calc-with-angle-time-frequency-expected.txt:
  • fast/css/calc-with-angle-time-frequency.html:
8:54 AM Changeset in webkit [178626] by Chris Dumez
  • 4 edits in trunk/Source/WebCore

Generate shorthandForProperty() implementation from CSSPropertyNames.in
​https://bugs.webkit.org/show_bug.cgi?id=140556

Reviewed by Darin Adler.

Generate shorthandForProperty() implementation from CSSPropertyNames.in.
This is just a big switch() statement calling the right
StylePropertyShorthand factory function for a given CSSPropertyID.

  • css/StylePropertyShorthand.cpp:

(WebCore::shorthandForProperty): Deleted.

  • css/StylePropertyShorthand.h:
  • css/makeprop.pl:
8:49 AM Changeset in webkit [178625] by ddkilzer@apple.com
  • 2 edits in trunk/Source/WebKit2

REGRESSION (r178618): Change to WKWebViewConfiguration broke iOS build
<​https://bugs.webkit.org/show_bug.cgi?id=140559>

Blind fix to address the following build failure:

Source/WebKit2/UIProcess/API/Cocoa/WKWebViewConfiguration.mm:79:7: error: interface type cannot be statically allocated

T m_value;


*

Source/WebKit2/UIProcess/API/Cocoa/WKWebViewConfiguration.mm:94:55: note: in instantiation of template class 'LazyInitialized<WKWebViewContentProviderRegistry>' requested here

LazyInitialized<WKWebViewContentProviderRegistry> _contentProviderRegistry;


Source/WebKit2/UIProcess/API/Cocoa/WKWebViewConfiguration.mm:53:21: error: assigning to 'WKWebViewContentProviderRegistry *' from incompatible type 'RetainPtr<WKWebViewContentProviderRegistry *>'

m_value = f();

~

Source/WebKit2/UIProcess/API/Cocoa/WKWebViewConfiguration.mm:222:37: note: in instantiation of function template specialization 'LazyInitialized<WKWebViewContentProviderRegistry>::get<(lambda at Source/WebKit2/UIProcess/API/Cocoa/WKWebViewConfiguration.mm:222:41)>' requested here

return _contentProviderRegistry.get([] { return adoptNS([[WKWebViewContentProviderRegistry alloc] init]); });


Source/WebKit2/UIProcess/API/Cocoa/WKWebViewConfiguration.mm:57:24: error: property 'get' not found on object of type 'WKWebViewContentProviderRegistry *'

return m_value.get();


3 errors generated.

  • UIProcess/API/Cocoa/WKWebViewConfiguration.mm: Change

_contentProviderRegistry to be a LazyInitialized<RetainPtr<>> to
match other instance variables.

8:08 AM WebKitGTK/2.4.x edited by berto@igalia.com
(diff)
7:55 AM WebKitGTK/2.4.x edited by berto@igalia.com
(diff)
2:48 AM Changeset in webkit [178624] by ddkilzer@apple.com
  • 2 edits in trunk/Tools

Attempt to fix webkitpy tests on Mountain Lion, Mavericks bots

  • Scripts/webkitpy/port/ios.py:

(IOSPort): Add 'ios-device-7' to VERSION_FALLBACK_ORDER so that
test-webkitpy doesn't fail since iOS 7.x SDKs are installed on
the Mountain Lion and Mavericks bots.

2:08 AM Changeset in webkit [178623] by ddkilzer@apple.com
  • 2 edits in trunk/Tools

Attempt to fix webkitpy tests on GTK Linux ports

  • Scripts/webkitpy/port/ios.py:

(IOSPort.determine_full_port_name): Set a sensible default if
not running on a Mac platform or if no iOS SDK is installed.

12:42 AM Changeset in webkit [178622] by ddkilzer@apple.com
  • 14 edits in trunk/Tools

Create iOS-EWS client queue
​https://bugs.webkit.org/show_bug.cgi?id=140476

Patch by Jake Nielsen <​jacob_nielsen@apple.com> on 2015-01-17
Reviewed by Alexey Proskuryakov.

  • EWSTools/start-queue-mac.sh:

Adds call to configure-xcode-for-ios-development for iOS EWS.

  • Scripts/webkitpy/common/config/ews.json:

Adds the iOS EWS config entry.

  • Scripts/webkitpy/common/config/ports.py:

(DeprecatedPort.port):
Adds IOSPort to the port map.
(IOSPort):
(IOSPort.build_webkit_command):
Adds --sdk=iphoneos to the webkit build command.

  • Scripts/webkitpy/port/base.py:

(Port.architecture):
Adds an accessor for the architecture member variable.

  • Scripts/webkitpy/port/factory.py:

(PortFactory):
Adds IOSPort to the port class list.

  • Scripts/webkitpy/port/ios.py:

Adds the IOSPort to encapsulate iOS-specific things.
(IOSPort):
(IOSPort.determine_full_port_name):
(IOSPort.init):
(IOSPort._build_driver_flags):
(IOSPort.operating_system):

  • Scripts/webkitpy/tool/commands/download_unittest.py:

Adds the archetecture option to the mock options.
(DownloadCommandsTest._default_options):

  • Scripts/webkitpy/tool/commands/earlywarningsystem.py:

Appends the archetecture option into calls to webkit-patch.
(AbstractEarlyWarningSystem.review_patch):
(AbstractEarlyWarningSystem.run_command):
(AbstractEarlyWarningSystem.load_ews_classes):

  • Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:

Adds logic to soothe the unittest now that --architecture is being
thrown around everywhere.
(EarlyWarningSystemTest._default_expected_logs):

  • Scripts/webkitpy/tool/commands/queues.py:

Adds glue code to ferry the --architecture option around.
(AbstractQueue.init):
(PatchProcessingQueue.begin_work_queue):

  • Scripts/webkitpy/tool/steps/abstractstep.py:

Adds the archetecture option to all AbstractSteps so that
EarlyWarningSystem doesn't start shoving --architecture into
unsuspecting commands.
(AbstractStep.options):

  • Scripts/webkitpy/tool/steps/build.py:

Translates the --architecture option into an ARCHS= format to pass to
build-webkit.
(Build.build):

  • Scripts/webkitpy/tool/steps/options.py:

Adds a definition for the --architecture option.
(Options):

Jan 16, 2015:

6:53 PM Changeset in webkit [178621] by ggaren@apple.com
  • 12 edits
    1 delete in trunk/Source/bmalloc

bmalloc: refactored XLarge allocation for better alignment
​https://bugs.webkit.org/show_bug.cgi?id=140582

Reviewed by Andreas Kling.

XLarge objects used to be Large objects with an extra bit of metadata
that said "actually, I'm not large -- I'm extra large".

The metadata header in an XLarge allocation made it impossible for the
XLarge object to honor a very large alignment request.

The solution is to stop using a metadata header for XLarge objects, and
instead to store explicit metadata on the side.

This is a bit less astonishing, which is also nice.

Finding XLarge metadata is now a linear search. That's probably OK, since
it was always so in TCMalloc, and the usual number of XLarge allocations
in a process is 0.

This design makes it possible for the heap to cache XLarge allocations
with and/or without physical pages. I haven't actually done that yet
because the tradeoffs are subtle, so I don't want to do anything without
a motivating test case.

  • bmalloc.xcodeproj/project.pbxproj:
  • bmalloc/Allocator.cpp:

(bmalloc::Allocator::reallocate): Removed the concept of an XLargeChunk,
since an XLarge allocation is now just a naked buffer without a header.

(bmalloc::Allocator::allocateXLarge): Added an explicit qualifier for
XLarge alignment, since XLargeChunk won't give this to us implicitly
anymore.

  • bmalloc/BoundaryTag.h:

(bmalloc::BoundaryTag::setRange):
(bmalloc::BoundaryTag::isXLarge): Deleted.
(bmalloc::BoundaryTag::setXLarge): Deleted.

  • bmalloc/BoundaryTagInlines.h:

(bmalloc::validate):
(bmalloc::BoundaryTag::deallocate): Removed the XLarge hacks from Large allocations.

  • bmalloc/Deallocator.cpp:

(bmalloc::Deallocator::deallocateXLarge):
(bmalloc::Deallocator::deallocateSlowCase):

  • bmalloc/Heap.cpp:

(bmalloc::Heap::findXLarge):
(bmalloc::Heap::allocateXLarge):
(bmalloc::Heap::deallocateXLarge):

  • bmalloc/Heap.h: Updated for interface changes.
  • bmalloc/ObjectType.cpp:

(bmalloc::objectType):

  • bmalloc/ObjectType.h:

(bmalloc::isXLarge): We can now tell if a pointer is XLarge just by
examining its bit pattern -- just like we do for other kinds of
allocations -- which is nice.

  • bmalloc/Sizes.h:
  • bmalloc/VMHeap.h:

(bmalloc::VMHeap::allocateXLarge):
(bmalloc::VMHeap::findXLarge):
(bmalloc::VMHeap::deallocateXLarge): Keep an explicit vector of metadata
for XLarge allocations.

  • bmalloc/XLargeChunk.h: Removed.
6:26 PM Changeset in webkit [178620] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebInspectorUI

Web Inspector: Make message selection in the console more readable
​https://bugs.webkit.org/show_bug.cgi?id=140385

Patch by Nikita Vasilyev <Nikita Vasilyev> on 2015-01-16
Reviewed by Timothy Hatcher.

  • UserInterface/Views/LogContentView.css:

(.console-item.selected):
(.console-messages:focus .console-item.selected):
(.console-item.selected .console-message::after):
(.console-messages:focus .console-item.selected .console-message::after):
(.console-messages:focus .console-item.selected .go-to-link):

  • UserInterface/Views/Main.css:

(.go-to-link):
!important statements seem to be unnecessary, remove them.

6:12 PM Changeset in webkit [178619] by dbates@webkit.org
  • 121 edits in trunk/LayoutTests

Update some expected results for iOS

  • platform/ios-simulator-wk2/css2.1/t100801-c548-ln-ht-00-c-a-expected.txt:
  • platform/ios-simulator-wk2/css2.1/t1606-c562-white-sp-00-b-ag-expected.txt:
  • platform/ios-simulator/TestExpectations:

[...]

6:07 PM Changeset in webkit [178618] by weinig@apple.com
  • 19 edits
    10 adds in trunk

Add a basic configuration object for WKView
​https://bugs.webkit.org/show_bug.cgi?id=140559

Reviewed by Anders Carlsson.

Source/WebKit2:

  • Adds WKPageConfigurationRef (backed by API::PageConfiguration). WKWebView configuration is not yet bridged to this, but that will happen soon. For now, it has a few basic configuration options.
  • Adds WKUserContentControllerRef as C-SPI version of WKUserContentController.
  • Adds WKUserScriptRef as C-SPI version of WKUserScript.
  • Shared/API/APIObject.h:
  • Shared/API/c/WKBase.h:
  • Shared/API/c/WKSharedAPICast.h:

(WebKit::toWKUserScriptInjectionTime):

  • UIProcess/API/APIPageConfiguration.cpp: Added.

(API::PageConfiguration::PageConfiguration):
(API::PageConfiguration::~PageConfiguration):
(API::PageConfiguration::processPool):
(API::PageConfiguration::setProcessPool):
(API::PageConfiguration::userContentController):
(API::PageConfiguration::setUserContentController):
(API::PageConfiguration::pageGroup):
(API::PageConfiguration::setPageGroup):
(API::PageConfiguration::preferences):
(API::PageConfiguration::setPreferences):
(API::PageConfiguration::relatedPage):
(API::PageConfiguration::setRelatedPage):
(API::PageConfiguration::webPageConfiguration):

  • UIProcess/API/APIPageConfiguration.h: Added.

(API::PageConfiguration::create):

  • UIProcess/API/APIUserScript.cpp: Added.

(API::generateIdentifier):
(API::UserScript::generateUniqueURL):

  • UIProcess/API/APIUserScript.h:
  • UIProcess/API/C/WKAPICast.h:
  • UIProcess/API/C/WKPageConfigurationRef.cpp: Added.

(WKPageConfigurationGetTypeID):
(WKPageConfigurationCreate):
(WKPageConfigurationGetContext):
(WKPageConfigurationSetContext):
(WKPageConfigurationGetPageGroup):
(WKPageConfigurationSetPageGroup):
(WKPageConfigurationGetUserContentController):
(WKPageConfigurationSetUserContentController):
(WKPageConfigurationGetPreferences):
(WKPageConfigurationSetPreferences):
(WKPageConfigurationGetRelatedPage):
(WKPageConfigurationSetRelatedPage):

  • UIProcess/API/C/WKPageConfigurationRef.h: Added.
  • UIProcess/API/C/WKUserContentControllerRef.cpp: Added.

(WKUserContentControllerGetTypeID):
(WKUserContentControllerCreate):
(WKUserContentControllerCopyUserScripts):
(WKUserContentControllerAddUserScript):
(WKUserContentControllerRemoveAllUserScripts):

  • UIProcess/API/C/WKUserContentControllerRef.h: Added.
  • UIProcess/API/C/WKUserScriptRef.cpp: Added.

(WKUserScriptGetTypeID):
(WKUserScriptCreateWithSource):
(WKUserScriptCopySource):
(WKUserScriptGetInjectionTime):
(WKUserScriptGetMainFrameOnly):

  • UIProcess/API/C/WKUserScriptRef.h: Added.
  • UIProcess/API/C/WebKit2_C.h:
  • UIProcess/API/Cocoa/WKUserScript.mm:

(-[WKUserScript initWithSource:injectionTime:forMainFrameOnly:]):
(generateIdentifier): Deleted.

  • UIProcess/API/Cocoa/WKViewPrivate.h:
  • UIProcess/API/Cocoa/WKWebViewConfiguration.mm:

(LazyInitialized::get):
(LazyInitialized::set):
(LazyInitialized::peek):

  • UIProcess/API/mac/WKView.mm:

(-[WKView initWithFrame:configurationRef:]):

  • UIProcess/UserContent/WebUserContentControllerProxy.h:

(WebKit::WebUserContentControllerProxy::create):

  • WebKit2.xcodeproj/project.pbxproj:

Tools:

Add tests for WKPageConfigurationRef.

  • TestWebKitAPI/PlatformWebView.h:
  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKit2/WKPageConfiguration.cpp: Added.

(TestWebKitAPI::TEST):
(TestWebKitAPI::didFinishLoadForFrame):
(TestWebKitAPI::setPageLoaderClient):

  • TestWebKitAPI/mac/PlatformWebViewMac.mm:

(TestWebKitAPI::PlatformWebView::initialize):
(TestWebKitAPI::PlatformWebView::PlatformWebView):

5:49 PM Changeset in webkit [178617] by Brent Fulgham
  • 2 edits in trunk/Source/WebCore

[Mac] Correct infinite loop in Wheel Handler code in EventHandlerMac
​https://bugs.webkit.org/show_bug.cgi?id=140564
<rdar://problem/19386426.

Reviewed by Dean Jackson.

  • page/mac/EventHandlerMac.mm:

(WebCore::latchingIsLockedToAncestorOfThisFrame): Put missing assignment
back into the loop!

5:15 PM Changeset in webkit [178616] by bshafiei@apple.com
  • 1 copy in tags/Safari-600.5.2

New tag.

4:39 PM Changeset in webkit [178615] by mmaxfield@apple.com
  • 6 edits
    1 add in trunk

WeakPtr functions crash when created with default constructor
​https://bugs.webkit.org/show_bug.cgi?id=140479

Reviewed by Andreas Kling.

Source/WTF:

This patch rearranges how WeakPtr works, and has the following ideas behind it:

  1. WeakPtr should use Ref internally. This solves the crash by always having a

valid WeakReference.

  1. Clients should not be able to construct WeakReferences directly. Instead,

only WeakPtrFactory (and WeakPtr's default constructor) should be able to
construct them. They are considered an implementation detail of WeakPtr.

  1. Except for the default constructor, clients should not be able to construct

WeakPtrs directly. Instead, the WeakPtrFactory must construct them. This
guarantees that the WeakPtrs all reference the same WeakReference.

  1. Clients can construct a WeakPtr using its default constructor, and then

use the assignment operator to make it non-null. (Or they could use
WeakPtrFactory to make it non-null at creation-time.)

  1. No one was using WeakReference::bindTo(), and it doesn't seem useful, so I

removed it.

Tests: WTF_WeakPtr API tests

  • wtf/Ref.h:

(WTF::Ref::Ref): Added extra ASSERT()s, and explicitly deleted copy
constructors with a comment.
(WTF::Ref::operator=): Added extra ASSERT()s, and explicitly deleted copy
assignment operators with a comment.

  • wtf/WeakPtr.h:

(WTF::WeakReference::clear): Used nullptr.
(WTF::WeakReference::create): Moved to private:
(WTF::WeakPtr::WeakPtr): For the default constructor, initialized the Ref with
a new WeakReference. For the other constructor, moved it to private:. Also added
copy constructors and copy assignment operators (since Ref doesn't have them but
RefPtr does). These constructors/operators are relied upon in various places
throughout WebCore.
(WTF::WeakPtr::operator bool): Made non-explicit.
(WTF::WeakReference::createUnbound): Deleted.
(WTF::WeakReference::bindTo): Deleted.
(WTF::WeakReference::WeakReference): Deleted.
(WTF::WeakPtrFactory::WeakPtrFactory): Deleted.

Tools:

Add WeakPtr API tests.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WTF/WeakPtr.cpp: Added.
  • TestWebKitAPI/Tests/WTF/Ref.cpp: Update to not use copy constructor.
4:37 PM Changeset in webkit [178614] by msaboff@apple.com
  • 3 edits in trunk/LayoutTests

REGRESSION(178591): js/slow-stress/call-spread.html & js/slow-stress/new-spread.html
​https://bugs.webkit.org/show_bug.cgi?id=140574

Rubber stamped by Oliver Hunt.

Changed the loop counts in the test to lower values to speed up the tests.

  • js/slow-stress/script-tests/call-spread.js:

(test2):
(test3):

  • js/slow-stress/script-tests/new-spread.js:

(test2):
(test3):

4:35 PM Changeset in webkit [178613] by Alan Bujtas
  • 5 edits
    2 adds in trunk

When border-radius is present, inset/outset/groove/ridge border color changes.
​https://bugs.webkit.org/show_bug.cgi?id=140551

Reviewed by Simon Fraser.

This patch applies the same color lighten/darken adjustment on the radius borders
that we use for non-radius border.

Source/WebCore:

Test: fast/borders/wrong-border-color-when-radius-is-present.html

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::drawBoxSideFromPath):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::calculateBorderStyleColor):

  • rendering/RenderObject.h:

LayoutTests:

  • fast/borders/wrong-border-color-when-radius-is-present-expected.html: Added.
  • fast/borders/wrong-border-color-when-radius-is-present.html: Added.
4:12 PM Changeset in webkit [178612] by dbates@webkit.org
  • 2 edits in trunk/Source/WebCore

Web pages fail to load using public iOS WebKit; ASSERT(!isMainThread()) in
-[WebCoreResourceHandleAsOperationQueueDelegate connection:willSendRequest:redirectResponse:]
​https://bugs.webkit.org/show_bug.cgi?id=140470

Patch by Pratik Solanki <​psolanki@apple.com> on 2015-01-16
Reviewed by Alexey Proskuryakov.

Fixes an issue where a web page would fail to load in iOS WebKit2 built with the public iOS SDK
because NSURLConnection callbacks were always being scheduled on the main thread.

Currently we always schedule NSURLConnection callbacks to occur on the WebThread or the main
thread depending on whether the WebThread was started. In iOS WebKit2, the callbacks were
always being scheduled on the main thread regardless of whether we were using the NetworkProcess
(since the WebThread is only started when using WebKit1). This led to an assertion failure.
Instead we want to schedule callbacks to an NSOperationsQueue queue when using WebKit2 with the
NetworkProcess (i.e. ResourceHandleClient::usesAsyncCallbacks() is true), on the main thread when
using WebKit2 without the NetworkProcess and on the WebThread when using WebKit1.

  • platform/network/mac/ResourceHandleMac.mm:

(WebCore::operationQueueForAsyncClients): Remove PLATFORM(IOS)-guards as we want to make use
of this code for iOS WebKit2 with the NetworkProcess.
(WebCore::ResourceHandle::start): Modified to use the existing Mac code path to conditionally
schedule NSURLConnection callbacks to an operation queue when ResourceHandleClient::usesAsyncCallbacks()
is true. Otherwise, schedule the callbacks on the run loop returned by WebThreadNSRunLoop(),
which is either the WebThread or the main thread run loop when using WebKit1 and WebKit2 without
the NetworkProcess, respectively.

4:10 PM Changeset in webkit [178611] by ggaren@apple.com
  • 5 edits
    2 adds in trunk/PerformanceTests

bmalloc: added the tiniest bit of testing for aligned allocation
​https://bugs.webkit.org/show_bug.cgi?id=140573

Reviewed by Andreas Kling.

Just good enoug to catch two bugs in a preliminary implementation.

  • MallocBench/MallocBench.xcodeproj/project.pbxproj:
  • MallocBench/MallocBench/Benchmark.cpp:
  • MallocBench/MallocBench/mbmalloc.cpp:
  • MallocBench/MallocBench/mbmalloc.h:
  • MallocBench/MallocBench/memalign.cpp: Added.

(benchmark_memalign):

  • MallocBench/MallocBench/memalign.h: Added.
4:10 PM Changeset in webkit [178610] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Remove unused WebInspector.LocalJSONObject
​https://bugs.webkit.org/show_bug.cgi?id=140570

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-01-16
Reviewed by Timothy Hatcher.

  • UserInterface/Protocol/RemoteObject.js:

(WebInspector.RemoteObject.fromLocalObject): Deleted.
(WebInspector.LocalJSONObject): Deleted.
(WebInspector.LocalJSONObject.prototype.get description.switch.case.string_appeared_here): Deleted.
(WebInspector.LocalJSONObject.prototype.get description.switch.default): Deleted.
(WebInspector.LocalJSONObject.prototype.get description): Deleted.
(WebInspector.LocalJSONObject.prototype._concatenate): Deleted.
(WebInspector.LocalJSONObject.prototype.get type): Deleted.
(WebInspector.LocalJSONObject.prototype.get subtype): Deleted.
(WebInspector.LocalJSONObject.prototype.get hasChildren): Deleted.
(WebInspector.LocalJSONObject.prototype.getOwnProperties): Deleted.
(WebInspector.LocalJSONObject.prototype.getAllProperties): Deleted.
(WebInspector.LocalJSONObject.prototype._children.buildProperty): Deleted.
(WebInspector.LocalJSONObject.prototype._children): Deleted.
(WebInspector.LocalJSONObject.prototype.isError): Deleted.

4:01 PM Changeset in webkit [178609] by ggaren@apple.com
  • 8 edits in trunk/Source/bmalloc

bmalloc: added some infrastructure for aligned allocation
​https://bugs.webkit.org/show_bug.cgi?id=140572

Reviewed by Andreas Kling.

  • bmalloc/Algorithm.h:

(bmalloc::isPowerOfTwo):
(bmalloc::roundUpToMultipleOf):
(bmalloc::roundDownToMultipleOf): Refactored some duplicate code to use our
isPowerOfTwo helper function.

  • bmalloc/Allocator.cpp:

(bmalloc::Allocator::allocate):

  • bmalloc/Allocator.h: Stubbed out an implementation of aligned allocation.

Doesn't do anything yet, but does correctly forward to system malloc
when bmalloc is disabled.

  • bmalloc/Cache.cpp:

(bmalloc::Cache::allocateSlowCaseNullCache):

  • bmalloc/Cache.h:

(bmalloc::Cache::allocate):

  • bmalloc/bmalloc.h:

(bmalloc::api::memalign):

  • bmalloc/mbmalloc.cpp: Stubbed out an API for aligned allocation.
3:41 PM Changeset in webkit [178608] by andersca@apple.com
  • 4 edits in trunk/Source/WebKit2

Pass the connection along to WebProcessLifetimeTracker
​https://bugs.webkit.org/show_bug.cgi?id=140569

Reviewed by Andreas Kling.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::connectionWillOpen):
(WebKit::WebPageProxy::connectionDidClose):

  • UIProcess/WebProcessLifetimeTracker.cpp:

(WebKit::WebProcessLifetimeTracker::connectionWillOpen):
(WebKit::WebProcessLifetimeTracker::connectionDidClose):
(WebKit::WebProcessLifetimeTracker::connectionWillClose): Deleted.

  • UIProcess/WebProcessLifetimeTracker.h:
3:32 PM Changeset in webkit [178607] by Chris Dumez
  • 2 edits in trunk/Tools

Regression(r178586): Caused webkitpy.w3c.test_converter_unittest.W3CTestConverterTest.test_convert_prefixed_properties to fail
​https://bugs.webkit.org/show_bug.cgi?id=140568

Reviewed by Alexey Proskuryakov.

Fix the script parsing CSSPropertyNames.in to stop splitting lines
on '=' sign. The '=' sign is also used in StyleBuilder parameters:
e.g. "Longhands=background-position-x|background-position-y".
This would confuse the script and treat this as a CSS property:
"background-position-x|background-position-y".

We now split on white space and treat the first string on the line
to be the property name (this is the syntax in this file).

  • Scripts/webkitpy/w3c/test_converter.py:

(_W3CTestConverter.init):
(_W3CTestConverter.read_webkit_prefixed_css_property_list):

3:17 PM Changeset in webkit [178606] by Brian Burg
  • 16 edits in trunk/Source/JavaScriptCore

Web Inspector: code generator should introduce typedefs for protocol types that are arrays
​https://bugs.webkit.org/show_bug.cgi?id=140557

Reviewed by Joseph Pecoraro.

Currently, there is no generated type name for "array" type declarations such as Console.CallStack.
This makes it longwinded and confusing to use the type in C++ code.

This patch adds a typedef for array type declarations, so types such as Console::CallStack
can be referred to directly, rather than using Inspector::Protocol::Array<Console::CallFrame>.

Some tests were updated to cover array type declarations used as parameters and type members.

  • inspector/ScriptCallStack.cpp: Use the new typedef.

(Inspector::ScriptCallStack::buildInspectorArray):

  • inspector/ScriptCallStack.h:
  • inspector/scripts/codegen/cpp_generator.py:

(CppGenerator.cpp_protocol_type_for_type): If an ArrayType is nominal, use the typedef'd name instead.

  • inspector/scripts/codegen/generate_cpp_protocol_types_header.py:

(_generate_typedefs_for_domain): Also generate typedefs for array type declarations.
(_generate_typedefs_for_domain.Inspector):

  • inspector/scripts/codegen/models.py: Save the name of an ArrayType when it is a type declaration.

(ArrayType.init):
(Protocol.resolve_types):
(Protocol.lookup_type_reference):

  • inspector/scripts/tests/commands-with-async-attribute.json:
  • inspector/scripts/tests/commands-with-optional-call-return-parameters.json:
  • inspector/scripts/tests/events-with-optional-parameters.json:
  • inspector/scripts/tests/expected/commands-with-async-attribute.json-result:
  • inspector/scripts/tests/expected/commands-with-optional-call-return-parameters.json-result:
  • inspector/scripts/tests/expected/events-with-optional-parameters.json-result:
  • inspector/scripts/tests/expected/type-declaration-array-type.json-result:
  • inspector/scripts/tests/expected/type-declaration-object-type.json-result:
  • inspector/scripts/tests/expected/type-requiring-runtime-casts.json-result:
  • inspector/scripts/tests/type-declaration-object-type.json:
2:51 PM Changeset in webkit [178605] by Beth Dakin
  • 2 edits in trunk/Source/WebKit/mac

Make sure early cancellation of immediate action actually does that in WK1
​https://bugs.webkit.org/show_bug.cgi?id=140566
-and corresponding-
rdar://problem/19490114

Reviewed by Tim Horton.

Work around an AppKit bug by dispatching the call to _cancelImmediateAction
asynchronously.

  • WebView/WebImmediateActionController.mm:

(-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):

2:22 PM Changeset in webkit [178604] by andersca@apple.com
  • 4 edits in trunk/Source/WebKit2

More WebPageProxy CTTE
​https://bugs.webkit.org/show_bug.cgi?id=140565

Reviewed by Andreas Kling.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::connectionWillOpen):
(WebKit::WebPageProxy::connectionDidClose):
(WebKit::WebPageProxy::connectionWillClose): Deleted.

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::connectionWillOpen):
(WebKit::WebProcessProxy::connectionDidClose):

2:13 PM Changeset in webkit [178603] by Brian Burg
  • 21 edits in trunk/Source

Web Replay: purge remaining PassRefPtr uses and minor cleanup
​https://bugs.webkit.org/show_bug.cgi?id=140456

Reviewed by Andreas Kling.

Source/JavaScriptCore:

Get rid of PassRefPtr. Introduce default initializers where it makes sense.
Remove mistaken uses of AtomicString that were not removed as part of r174113.

  • replay/EmptyInputCursor.h:
  • replay/InputCursor.h:

(JSC::InputCursor::InputCursor):

Source/WebCore:

Get rid of PassRefPtr. Introduce default initializers where it makes sense. Change
uses of ASSERT to ASSERT_ARG when the assert is a precondition on an argument.

Remove mistaken uses of AtomicString that were not removed as part of r174113.

No new tests, no behavior changed.

  • inspector/InspectorReplayAgent.cpp:

(WebCore::SerializeInputToJSONFunctor::operator()):
(WebCore::SerializeInputToJSONFunctor::returnValue):
(WebCore::InspectorReplayAgent::sessionCreated):
(WebCore::InspectorReplayAgent::sessionModified):
(WebCore::InspectorReplayAgent::sessionLoaded):
(WebCore::InspectorReplayAgent::segmentCreated):
(WebCore::InspectorReplayAgent::segmentCompleted):
(WebCore::InspectorReplayAgent::segmentLoaded):
(WebCore::InspectorReplayAgent::switchSession):
(WebCore::InspectorReplayAgent::insertSessionSegment):
(WebCore::InspectorReplayAgent::removeSessionSegment):
(WebCore::InspectorReplayAgent::findSession):
(WebCore::InspectorReplayAgent::findSegment):

  • inspector/InspectorReplayAgent.h:
  • replay/CapturingInputCursor.cpp:

(WebCore::CapturingInputCursor::CapturingInputCursor):
(WebCore::CapturingInputCursor::create):
(WebCore::CapturingInputCursor::loadInput):

  • replay/CapturingInputCursor.h:
  • replay/EventLoopInputDispatcher.cpp:

(WebCore::EventLoopInputDispatcher::EventLoopInputDispatcher):

  • replay/EventLoopInputDispatcher.h:
  • replay/FunctorInputCursor.h:

(WebCore::FunctorInputCursor::FunctorInputCursor):
(WebCore::FunctorInputCursor::loadInput):

  • replay/ReplayController.cpp:

(WebCore::ReplayController::ReplayController):
(WebCore::ReplayController::setForceDeterministicSettings):
(WebCore::ReplayController::setSessionState):
(WebCore::ReplayController::setSegmentState):
(WebCore::ReplayController::switchSession):
(WebCore::ReplayController::createSegment):
(WebCore::ReplayController::completeSegment):
(WebCore::ReplayController::loadSegmentAtIndex):
(WebCore::ReplayController::unloadSegment):
(WebCore::ReplayController::frameNavigated):
(WebCore::ReplayController::loadedSession):
(WebCore::ReplayController::loadedSegment):
(WebCore::ReplayController::activeInputCursor):
(WebCore::ReplayController::dispatcher):

  • replay/ReplayController.h:
  • replay/ReplaySession.cpp:

(WebCore::ReplaySession::create):
(WebCore::ReplaySession::at):
(WebCore::ReplaySession::appendSegment):
(WebCore::ReplaySession::insertSegment):
(WebCore::ReplaySession::removeSegment):

  • replay/ReplaySession.h:
  • replay/ReplaySessionSegment.cpp:

(WebCore::ReplaySessionSegment::create):
(WebCore::ReplaySessionSegment::ReplaySessionSegment):

  • replay/ReplaySessionSegment.h:
  • replay/ReplayingInputCursor.cpp:

(WebCore::ReplayingInputCursor::ReplayingInputCursor):
(WebCore::ReplayingInputCursor::create):
(WebCore::ReplayingInputCursor::loadInput):

  • replay/ReplayingInputCursor.h:
  • replay/SegmentedInputStorage.cpp:

(WebCore::SegmentedInputStorage::store):
(WebCore::SegmentedInputStorage::queue):
(WebCore::SegmentedInputStorage::SegmentedInputStorage): Deleted.

  • replay/SegmentedInputStorage.h:
2:05 PM Changeset in webkit [178602] by andersca@apple.com
  • 4 edits in trunk/Source/WebKit2

Remove dead code
​https://bugs.webkit.org/show_bug.cgi?id=140563

Reviewed by Geoffrey Garen.

  • UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::processWillOpenConnection): Deleted.
(WebKit::WebProcessPool::processWillCloseConnection): Deleted.

  • UIProcess/WebProcessPool.h:
  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::connectionWillOpen):
(WebKit::WebProcessProxy::connectionDidClose):

1:58 PM Changeset in webkit [178601] by dbates@webkit.org
  • 2 edits in trunk/Tools

REGRESSION (r171968): run-safari --simulator fails to launch Safari on iOS
​https://bugs.webkit.org/show_bug.cgi?id=135589

Reviewed by David Kilzer.

Derived from a patch by David Farler.

Following the removal IPhoneSimulatorNotification.pm in <​http://trac.webkit.org/changeset/171968>
run-safari --simulator fails to launch Safari on iOS. We need to implement run-safari
in terms of the simctl command line utility.

  • Scripts/webkitdirs.pm: Added constant SIMULATOR_DEVICE_STATE_BOOTED.

(eraseIOSSimulatorDevice): Added.
(bootedIOSSimulatorDevice): Added.
(iosSimulatorApplicationsPath): Added.
(installedMobileSafariBundle): Implemented in terms of iosSimulatorApplicationsPath().
(openIOSSimulator): Modified to launch iOS Simulator using OPEN(1).
(quitIOSSimulator): Added.
(iosSimulatorDeviceByName): Modified to find the first simulator device that matches
the specified name and currently selected iOS runtime.
(isIOSSimulatorSystemInstalledApp): Added.
(runIOSWebKitAppInSimulator): Modified to use simctl launch to launch an app in the simulator.
(deleteiOSSimulatorDevice): Deleted.
(loadIPhoneSimulatorNotificationIfNeeded): Deleted.
(installAndLaunchIOSWebKitAppInSimulator): Deleted.

1:42 PM Changeset in webkit [178600] by akling@apple.com
  • 2 edits in trunk/Source/WebCore

Remove assertion that Page::m_editorClient is non-null.

Unreviewed debug build fix. (It's a reference, it won't be null.)

  • page/Page.cpp:

(WebCore::Page::Page):

1:40 PM Changeset in webkit [178599] by Brian Burg
  • 2 edits
    8 adds in trunk/Source/JavaScriptCore

Web Inspector: code generator should fail on duplicate parameter and member names
​https://bugs.webkit.org/show_bug.cgi?id=140555

Reviewed by Timothy Hatcher.

  • inspector/scripts/codegen/models.py:

(find_duplicates): Add a helper function to find duplicates in a list.
(Protocol.parse_type_declaration):
(Protocol.parse_command):
(Protocol.parse_event):

  • inspector/scripts/tests/expected/fail-on-duplicate-command-call-parameter-names.json-error: Added.
  • inspector/scripts/tests/expected/fail-on-duplicate-command-return-parameter-names.json-error: Added.
  • inspector/scripts/tests/expected/fail-on-duplicate-event-parameter-names.json-error: Added.
  • inspector/scripts/tests/expected/fail-on-duplicate-type-member-names.json-error: Added.
  • inspector/scripts/tests/fail-on-duplicate-command-call-parameter-names.json: Added.
  • inspector/scripts/tests/fail-on-duplicate-command-return-parameter-names.json: Added.
  • inspector/scripts/tests/fail-on-duplicate-event-parameter-names.json: Added.
  • inspector/scripts/tests/fail-on-duplicate-type-member-names.json: Added.
1:37 PM Changeset in webkit [178598] by andersca@apple.com
  • 11 edits in trunk/Source/WebKit2

Sprinkle some CTTE in ChildProcessProxy member functions
​https://bugs.webkit.org/show_bug.cgi?id=140562

Reviewed by Andreas Kling.

  • Shared/ChildProcessProxy.cpp:

(WebKit::ChildProcessProxy::didFinishLaunching):
(WebKit::ChildProcessProxy::clearConnection):
(WebKit::ChildProcessProxy::connectionWillOpen):
(WebKit::ChildProcessProxy::connectionDidClose):
(WebKit::ChildProcessProxy::connectionWillClose): Deleted.

  • Shared/ChildProcessProxy.h:
  • UIProcess/Databases/DatabaseProcessProxy.cpp:

(WebKit::DatabaseProcessProxy::connectionWillOpen): Deleted.
(WebKit::DatabaseProcessProxy::connectionWillClose): Deleted.

  • UIProcess/Databases/DatabaseProcessProxy.h:
  • UIProcess/Network/NetworkProcessProxy.cpp:

(WebKit::NetworkProcessProxy::connectionWillOpen):
(WebKit::NetworkProcessProxy::connectionWillClose): Deleted.

  • UIProcess/Network/NetworkProcessProxy.h:
  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::connectionWillOpen):
(WebKit::WebProcessProxy::connectionDidClose):
(WebKit::WebProcessProxy::connectionWillClose): Deleted.

  • UIProcess/WebProcessProxy.h:
  • UIProcess/mac/SecItemShimProxy.cpp:

(WebKit::SecItemShimProxy::initializeConnection):

  • UIProcess/mac/SecItemShimProxy.h:
1:33 PM Changeset in webkit [178597] by akling@apple.com
  • 8 edits in trunk/Source/WebCore

Page::editorClient() should return a reference.
<​https://webkit.org/b/140552>

Reviewed by Chris Dumez.

Page always has an EditorClient, so make editorClient() return a reference.

  • editing/AlternativeTextController.cpp:

(WebCore::AlternativeTextController::editorClient):
(WebCore::AlternativeTextController::textChecker):

  • editing/Editor.cpp:

(WebCore::Editor::client):

  • editing/SpellChecker.cpp:

(WebCore::SpellChecker::client):

  • page/FocusController.cpp:

(WebCore::FocusController::setFocusedElement):

  • page/Page.cpp:

(WebCore::Page::Page):
(WebCore::Page::~Page):
(WebCore::Page::clearUndoRedoOperations):

  • page/Page.h:

(WebCore::Page::editorClient):

  • page/scrolling/AsyncScrollingCoordinator.cpp:

(WebCore::AsyncScrollingCoordinator::updateScrollPositionAfterAsyncScroll):

1:25 PM Changeset in webkit [178596] by alex.christensen@flexsim.com
  • 4 edits in trunk/Tools

Resurrect the WinCairo bot.
​https://bugs.webkit.org/show_bug.cgi?id=139908

Patch by Alex Christensen <​alex.christensen@flexsim.com> on 2015-01-16
Reviewed by Csaba Osztrogonác.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
  • BuildSlaveSupport/build.webkit.org-config/master.cfg:

(appendCustomBuildFlags):

  • BuildSlaveSupport/test-result-archive:

(archiveTestResults):
Add WinCairo buildbot.

1:11 PM Changeset in webkit [178595] by Beth Dakin
  • 2 edits in trunk/Source/WebKit2

Should cancel immediate action sooner in WK2
​https://bugs.webkit.org/show_bug.cgi?id=140561
-and corresponding-
rdar://problem/19490114

Reviewed by Tim Horton.

_cancelImmediateActionIfNeeded will cancel the immediate action if there is no
animation controller or if the DDActionContext doesn’t want to use its actions.

  • UIProcess/mac/WKImmediateActionController.mm:

(-[WKImmediateActionController _cancelImmediateActionIfNeeded]):

Call _cancelImmediateActionIfNeeded to cancel earlier.
(-[WKImmediateActionController didPerformActionMenuHitTest:userData:]):

Re-factor this code to use the newly-added method _cancelImmediateActionIfNeeded
(-[WKImmediateActionController immediateActionRecognizerWillBeginAnimation:]):

1:04 PM Changeset in webkit [178594] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Don't try to send SetSession messages before the web page has been constructed in the web process
​https://bugs.webkit.org/show_bug.cgi?id=140558

Reviewed by Andreas Kling.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy):
We already send the session ID along in the page creation parameters so just message the network process
if we need to create an ephemeral session.

(WebKit::WebPageProxy::setSessionID):
Add an isValid call for good measure.

1:01 PM Changeset in webkit [178593] by benjamin@webkit.org
  • 6 edits in trunk/Source/WebCore

Make URL filters case-insensitive by default
​https://bugs.webkit.org/show_bug.cgi?id=140531

Reviewed by Andreas Kling.

Safari's filters were case-insensitive. Adopt that convention in the engine,
and add a flag in case someone ever need a case-sensitive filter.

  • contentextensions/ContentExtensionRule.h:
  • contentextensions/ContentExtensionsBackend.cpp:

(WebCore::ContentExtensions::ContentExtensionsBackend::setRuleList):

  • contentextensions/ContentExtensionsManager.cpp:

(WebCore::ContentExtensions::ExtensionsManager::loadTrigger):

  • contentextensions/URLFilterParser.cpp:

(WebCore::ContentExtensions::trivialAtomFromASCIICharacter):
(WebCore::ContentExtensions::GraphBuilder::GraphBuilder):
(WebCore::ContentExtensions::GraphBuilder::atomPatternCharacter):
(WebCore::ContentExtensions::GraphBuilder::generateTransition):
(WebCore::ContentExtensions::URLFilterParser::addPattern):

  • contentextensions/URLFilterParser.h:
12:57 PM Changeset in webkit [178592] by benjamin@webkit.org
  • 11 edits
    10 adds in trunk

Add the alternative syntax for CSS Selector's descendant combinator (">>")
​https://bugs.webkit.org/show_bug.cgi?id=140525

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2015-01-16
Reviewed by Antti Koivisto.

Source/WebCore:

The latest Selector spec introduces the combinator ">>" as an alias for the descendant
relation: ​http://dev.w3.org/csswg/selectors-4/#descendant-combinators

This patch implements that combinator as an alias of the existing one. For CSSOM's selector
serialization, I use one bit of CSSSelector to store if that alternative syntax was used.

Tests: fast/css/descendant-combinator-doubled-child-syntax-styling.html

fast/css/parsing-css-descendant-combinator-doubled-child-syntax.html
fast/selectors/element-closest-descendant-combinator-doubled-child-syntax.html
fast/selectors/element-matches-descendant-combinator-doubled-child-syntax.html
fast/selectors/querySelector-descendant-combinator-doubled-child-syntax.html

  • css/CSSGrammar.y.in:
  • css/CSSParserValues.cpp:

(WebCore::CSSParserSelector::appendTagHistory):

  • css/CSSParserValues.h:

(WebCore::CSSParserSelector::setDescendantUseDoubleChildSyntax):

  • css/CSSSelector.cpp:

(WebCore::CSSSelector::selectorText):

  • css/CSSSelector.h:

(WebCore::CSSSelector::setDescendantUseDoubleChildSyntax):
(WebCore::CSSSelector::CSSSelector):

LayoutTests:

  • fast/css/css-selector-text-expected.txt:
  • fast/css/css-selector-text.html:
  • fast/css/css-set-selector-text-expected.txt:
  • fast/css/css-set-selector-text.html:
  • fast/css/descendant-combinator-doubled-child-syntax-styling-expected.html: Added.
  • fast/css/descendant-combinator-doubled-child-syntax-styling.html: Added.
  • fast/css/parsing-css-descendant-combinator-doubled-child-syntax-expected.txt: Added.
  • fast/css/parsing-css-descendant-combinator-doubled-child-syntax.html: Added.
  • fast/selectors/element-closest-descendant-combinator-doubled-child-syntax-expected.txt: Added.
  • fast/selectors/element-closest-descendant-combinator-doubled-child-syntax.html: Added.
  • fast/selectors/element-matches-descendant-combinator-doubled-child-syntax-expected.txt: Added.
  • fast/selectors/element-matches-descendant-combinator-doubled-child-syntax.html: Added.
  • fast/selectors/querySelector-descendant-combinator-doubled-child-syntax-expected.txt: Added.
  • fast/selectors/querySelector-descendant-combinator-doubled-child-syntax.html: Added.
12:40 PM Changeset in webkit [178591] by msaboff@apple.com
  • 10 edits
    3 adds in trunk

REGRESSION (r174226): Header on huffingtonpost.com is too large
​https://bugs.webkit.org/show_bug.cgi?id=140306

Reviewed by Filip Pizlo.

Source/JavaScriptCore:

BytecodeGenerator::willResolveToArguments() is used to check to see if we can use the
arguments register or whether we need to resolve "arguments". If the arguments have
been captured, then they are stored in the lexical environment and the arguments
register is not used.

Changed BytecodeGenerator::willResolveToArguments() to also check to see if the arguments
register is captured. Renamed the function to willResolveToArgumentsRegister() to
better indicate what we are checking.

Aligned 32 and 64 bit paths in ArgumentsRecoveryGenerator::generateFor() for creating
an arguments object that was optimized out of an inlined callFrame. The 32 bit path
incorrectly calculated the location of the reified callee frame. This alignment resulted
in the removal of operationCreateInlinedArgumentsDuringOSRExit()

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::willResolveToArgumentsRegister):
(JSC::BytecodeGenerator::uncheckedLocalArgumentsRegister):
(JSC::BytecodeGenerator::emitCall):
(JSC::BytecodeGenerator::emitConstruct):
(JSC::BytecodeGenerator::emitEnumeration):
(JSC::BytecodeGenerator::willResolveToArguments): Deleted.

  • bytecompiler/BytecodeGenerator.h:
  • bytecompiler/NodesCodegen.cpp:

(JSC::BracketAccessorNode::emitBytecode):
(JSC::DotAccessorNode::emitBytecode):
(JSC::getArgumentByVal):
(JSC::ApplyFunctionCallDotNode::emitBytecode):
(JSC::ArrayPatternNode::emitDirectBinding):

  • dfg/DFGOSRExitCompilerCommon.cpp:

(JSC::DFG::ArgumentsRecoveryGenerator::generateFor):

  • dfg/DFGOperations.cpp:

(JSC::operationCreateInlinedArgumentsDuringOSRExit): Deleted.

  • dfg/DFGOperations.h:

(JSC::operationCreateInlinedArgumentsDuringOSRExit): Deleted.

LayoutTests:

Updated js/arguments-iterator to test changing argument to array values.
Removed tests that changed arguments to a string and an object as they were
bogus and didn't test what the appeared to test.
for .. of works on iterable objects only.

Added new regression test, js/regress-140306.

  • js/arguments-iterator-expected.txt:
  • js/regress-140306-expected.txt: Added.
  • js/regress-140306.html: Added.
  • js/script-tests/arguments-iterator.js:

(testEmptyArrayArguments):
(testArrayArguments):
(testOverwrittenArguments): Deleted.
(testNullArguments): Deleted.
(testNonArrayLikeArguments): Deleted.

  • js/script-tests/regress-140306.js: Added.

(checkArgs):
(applyToArgs):

12:22 PM Changeset in webkit [178590] by Brent Fulgham
  • 5 edits in branches/safari-600.5-branch/Source/WebCore

Merge r174295. rdar://problem/19501151

2014-09-09 Roger Fong <​roger_fong@apple.com>

Unreviewed build fix for Windows.

  • platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp:
  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
  • platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:
12:06 PM Changeset in webkit [178589] by Chris Dumez
  • 3 edits in trunk/Tools

webkit-patch should auto-install the keyring python module
​https://bugs.webkit.org/show_bug.cgi?id=140547

Reviewed by David Kilzer.

Auto-install the keyring python module. This is the module that
webkit-patch uses for cross-platform access to the keyring
service.

Without this module, if the password if not in the keychain,
webkit-patch will keep asking for your username / password and
never remember them.

  • Scripts/webkitpy/common/net/credentials.py:
  • Scripts/webkitpy/thirdparty/init.py:

(AutoinstallImportHook.find_module):
(AutoinstallImportHook._install_keyring):

12:05 PM Changeset in webkit [178588] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

[mac] Fix test expectations after r178310.
​https://bugs.webkit.org/show_bug.cgi?id=140503

Patch by Jeremy Jones <​jeremyj@apple.com> on 2015-01-16
Reviewed by Alexey Proskuryakov.

Remove references to removed tests.

  • platform/mac-wk2/TestExpectations: removed reference to storage/indexeddb/basics-shared-workers.html removed reference to js/dom/global-constructors-attributes-shared-worker.html
  • platform/mac/TestExpectations: removed reference to fast/workers/shared-worker-storagequota-query-usage.html
12:01 PM Changeset in webkit [178587] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Log unhandled messages in the web process
​https://bugs.webkit.org/show_bug.cgi?id=140549

Reviewed by Andreas Kling.

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::didReceiveSyncMessage):
(WebKit::WebProcess::didReceiveMessage):

11:39 AM Changeset in webkit [178586] by Chris Dumez
  • 14 edits in trunk/Source/WebCore

Generate StylePropertyShorthand.* from CSSPropertyNames.in
​https://bugs.webkit.org/show_bug.cgi?id=140501

Reviewed by Darin Adler.

Add initial support for having makeprop.pl generate most of
StylePropertyShorthand.* from CSSPropertyNames.in.

This patch replaces [Shorthand] parameter in CSSPropertyNames.in by a
more descriptive [Longhands=property1|property2|...] parameter. With
this information, makeprop.pl is now able to generate the
StylePropertyShorthand factories for all CSS shorthand properties
in a new StylePropertyShorthandFunctions.h header.

The switches in StylePropertyShorthand.cpp could also be generated
but this will be taken care of in follow-up patches to reduce patch
size.

  • CMakeLists.txt:
  • DerivedSources.make:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::ComputedStyleExtractor::propertyValue):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):

  • css/CSSPropertyNames.in:
  • css/StyleProperties.cpp:

(WebCore::StyleProperties::getPropertyValue):

  • css/StylePropertyShorthand.cpp:

(WebCore::shorthandForProperty):
(WebCore::matchingShorthandsForLonghand):
(WebCore::backgroundShorthand): Deleted.
(WebCore::backgroundPositionShorthand): Deleted.
(WebCore::backgroundRepeatShorthand): Deleted.
(WebCore::borderShorthand): Deleted.
(WebCore::borderBottomShorthand): Deleted.
(WebCore::borderColorShorthand): Deleted.
(WebCore::borderImageShorthand): Deleted.
(WebCore::borderLeftShorthand): Deleted.
(WebCore::borderRadiusShorthand): Deleted.
(WebCore::webkitBorderRadiusShorthand): Deleted.
(WebCore::borderRightShorthand): Deleted.
(WebCore::borderSpacingShorthand): Deleted.
(WebCore::borderStyleShorthand): Deleted.
(WebCore::borderTopShorthand): Deleted.
(WebCore::borderWidthShorthand): Deleted.
(WebCore::listStyleShorthand): Deleted.
(WebCore::marginShorthand): Deleted.
(WebCore::markerShorthand): Deleted.
(WebCore::outlineShorthand): Deleted.
(WebCore::overflowShorthand): Deleted.
(WebCore::paddingShorthand): Deleted.
(WebCore::transitionShorthand): Deleted.
(WebCore::animationShorthand): Deleted.
(WebCore::webkitAnimationShorthand): Deleted.
(WebCore::webkitBorderAfterShorthand): Deleted.
(WebCore::webkitBorderBeforeShorthand): Deleted.
(WebCore::webkitBorderEndShorthand): Deleted.
(WebCore::webkitBorderStartShorthand): Deleted.
(WebCore::webkitColumnsShorthand): Deleted.
(WebCore::webkitColumnRuleShorthand): Deleted.
(WebCore::flexFlowShorthand): Deleted.
(WebCore::flexShorthand): Deleted.
(WebCore::webkitMarginCollapseShorthand): Deleted.
(WebCore::webkitGridShorthand): Deleted.
(WebCore::webkitGridTemplateShorthand): Deleted.
(WebCore::webkitGridAreaShorthand): Deleted.
(WebCore::webkitGridColumnShorthand): Deleted.
(WebCore::webkitGridRowShorthand): Deleted.
(WebCore::webkitMarqueeShorthand): Deleted.
(WebCore::webkitMaskShorthand): Deleted.
(WebCore::webkitMaskPositionShorthand): Deleted.
(WebCore::webkitMaskRepeatShorthand): Deleted.
(WebCore::webkitTextDecorationShorthand): Deleted.
(WebCore::webkitTextEmphasisShorthand): Deleted.
(WebCore::webkitTextStrokeShorthand): Deleted.
(WebCore::webkitTransitionShorthand): Deleted.
(WebCore::webkitPerspectiveOriginShorthand): Deleted.
(WebCore::webkitTransformOriginShorthand): Deleted.

  • css/StylePropertyShorthand.h:
  • css/makeprop.pl:
11:38 AM Changeset in webkit [178585] by Brent Fulgham
  • 3 edits in branches/safari-600.5-branch/Source/WebCore

Merge r174295. rdar://problem/19501151

2014-10-03 Brent Fulgham <Brent Fulgham>

[Win] Unreviewed build fix for MSVC 2013 SP 3.

The std::array initializer is not fully implemented in SP3 and causes a
build error.

  • platform/graphics/transforms/AffineTransform.cpp: Use old style assignment initialization for MSVC builds until this bug is fixed.
11:33 AM Changeset in webkit [178584] by Brent Fulgham
  • 3 edits in branches/safari-600.5-branch/Source/WebCore

Merge r173391. rdar://problem/19501151

2014-09-08 ​peavo@outlook.com <​peavo@outlook.com>

[WinCairo] Compile error.
​https://bugs.webkit.org/show_bug.cgi?id=136633

Reviewed by Darin Adler.

Enum name has already been defined.

  • platform/audio/AudioHardwareListener.h:

Patch by Brent Fulgham <​bfulgham@webkit.org> on 2015-01-16

10:50 AM Changeset in webkit [178583] by commit-queue@webkit.org
  • 11 edits in trunk

Unreviewed, rolling out r178532.
​https://bugs.webkit.org/show_bug.cgi?id=140548

Broke fast/css/parsing-css-lang.html on some bots (Requested
by ap on #webkit).

Reverted changeset:

"Canonicalization of :lang() should preserve the :lang()'s
arguments representations"
​https://bugs.webkit.org/show_bug.cgi?id=139928
​http://trac.webkit.org/changeset/178532

10:36 AM Changeset in webkit [178582] by commit-queue@webkit.org
  • 12 edits
    2 deletes in trunk

Unreviewed, rolling out r178577.
​https://bugs.webkit.org/show_bug.cgi?id=140546

Broke fast/css-grid-layout/grid-content-sized-columns-
resolution.html (Requested by ap on #webkit).

Reverted changeset:

"[CSS Grid Layout] Tracks shrink sometimes with indefinite
remaining space"
​https://bugs.webkit.org/show_bug.cgi?id=139059
​http://trac.webkit.org/changeset/178577

10:15 AM Changeset in webkit [178581] by Yusuke Suzuki
  • 2 edits in trunk/Source/WTF

std::all_of requires complete C++ iterators in GCC 4.8
​https://bugs.webkit.org/show_bug.cgi?id=140530

Reviewed by Darin Adler.

In the WebKit2/UIProcess/WebProcessLifetimeObserver.cpp, std::all_of
is used for HashIterators. However, std::all_of requires the complete
C++ iterator interface including iterator_category typedef member and
it raises compile error in GCC 4.8 (and libstdc++) environment.

This patch inherits std::iterator with appropriate type parameters.
It automatically defines required typedefs including iterator_category.

  • wtf/HashIterators.h:
9:50 AM Changeset in webkit [178580] by akling@apple.com
  • 7 edits in trunk/Source/WebCore

Some improvements to RuleSet shrinking.
<​https://webkit.org/b/140534>

Reviewed by Antti Koivisto.

Give an inline capacity (1) to the RuleData Vectors in RuleSet.
The vast majority of Vectors have only a single entry, and this
avoids having to allocate a separate Vector backing store for them.

Also make sure to shrink some Vectors that we weren't already,
like those in RuleFeatureSet.

  • css/ElementRuleCollector.cpp:

(WebCore::ElementRuleCollector::collectMatchingRulesForList):

  • css/ElementRuleCollector.h:
  • css/RuleFeature.cpp:

(WebCore::RuleFeatureSet::shrinkToFit):

  • css/RuleFeature.h:
  • css/RuleSet.cpp:

(WebCore::RuleSet::addToRuleSet):
(WebCore::rulesCountForName):
(WebCore::shrinkMapVectorsToFit):
(WebCore::RuleSet::shrinkToFit):

  • css/RuleSet.h:

(WebCore::RuleSet::idRules):
(WebCore::RuleSet::classRules):
(WebCore::RuleSet::tagRules):
(WebCore::RuleSet::shadowPseudoElementRules):
(WebCore::RuleSet::linkPseudoClassRules):
(WebCore::RuleSet::cuePseudoRules):
(WebCore::RuleSet::focusPseudoClassRules):
(WebCore::RuleSet::universalRules):

9:13 AM Changeset in webkit [178579] by dbates@webkit.org
  • 2 edits in trunk/Source/WebKit/mac

Fix the public iOS SDK build after <​http://trac.webkit.org/changeset/178285>
(​https://bugs.webkit.org/show_bug.cgi?id=140360)

Forward declare protocol NSURLDownloadDelegate as it is SPI on iOS.

  • Misc/WebDownload.h:
8:07 AM Changeset in webkit [178578] by Antti Koivisto
  • 5 edits
    1 move
    2 deletes in trunk/Source/WebCore

Correct naming for FontCascade implementation files
​https://bugs.webkit.org/show_bug.cgi?id=140544

Reviewed by Zalan Bujtas.

Also reduce their number.

Merge FontFastPath.cpp into FontCascade.cpp
Merge FontMac.mm and FontComplexTextMac.cpp into FontCascadeCocoa.mm

  • CMakeLists.txt:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/FontCascade.cpp:

(WebCore::FontCascade::getEmphasisMarkGlyphData):
(WebCore::FontCascade::emphasisMarkAscent):
(WebCore::FontCascade::emphasisMarkDescent):
(WebCore::FontCascade::emphasisMarkHeight):
(WebCore::FontCascade::getGlyphsAndAdvancesForSimpleText):
(WebCore::FontCascade::drawSimpleText):
(WebCore::FontCascade::drawEmphasisMarksForSimpleText):
(WebCore::FontCascade::drawGlyphBuffer):
(WebCore::offsetToMiddleOfGlyph):
(WebCore::offsetToMiddleOfGlyphAtIndex):
(WebCore::FontCascade::drawEmphasisMarks):
(WebCore::FontCascade::floatWidthForSimpleText):
(WebCore::FontCascade::adjustSelectionRectForSimpleText):
(WebCore::FontCascade::offsetForPositionForSimpleText):

  • platform/graphics/FontFastPath.cpp: Removed.
  • platform/graphics/cocoa/FontCascadeCocoa.mm: Copied from Source/WebCore/platform/graphics/mac/FontMac.mm.

(WebCore::FontCascade::drawGlyphs):
(WebCore::FontCascade::adjustSelectionRectForComplexText):
(WebCore::FontCascade::getGlyphsAndAdvancesForComplexText):
(WebCore::FontCascade::drawComplexText):
(WebCore::FontCascade::drawEmphasisMarksForComplexText):
(WebCore::FontCascade::floatWidthForComplexText):
(WebCore::FontCascade::offsetForPositionForComplexText):
(WebCore::FontCascade::fontDataForCombiningCharacterSequence):

  • platform/graphics/mac/FontComplexTextMac.cpp: Removed.
  • platform/graphics/mac/FontMac.mm: Removed.
2:22 AM Changeset in webkit [178577] by svillar@igalia.com
  • 12 edits
    2 adds in trunk

[CSS Grid Layout] Tracks shrink sometimes with indefinite remaining space
​https://bugs.webkit.org/show_bug.cgi?id=139059

Reviewed by David Hyatt.

Source/WebCore:

Test: fast/css-grid-layout/grid-grow-tracks-to-their-max.html

  • rendering/RenderGrid.cpp:

(WebCore::RenderGrid::computeUsedBreadthOfGridTracks):

LayoutTests:

The third step of the grid track sizing algorithm (method
ComputeUsedBreadthOfGridTracks in the old specs version of the
algorithm) tries to grow all grid tracks until the remaining space
is exhausted. Should the remaining space is undefined we should fill
the tracks up to their limits. This is specified in pseudocode like
this:

For each Grid track t in GridTracks

t.UsedBreadth = t.MaxBreadth

That's correct for most of the cases, but it becomes
wrong whenever t.UsedBreadth > t.MaxBreadth something that is not
incorrect. What we actually want to do is to grow the track to its
maximum if and only if the used breadth is smaller than the maximum.

due to another bug (wkb.ug/139058).

  • fast/css-grid-layout/grid-auto-columns-rows-update.html:
  • fast/css-grid-layout/grid-content-sized-columns-resolution-expected.txt:
  • fast/css-grid-layout/grid-content-sized-columns-resolution.html:
  • fast/css-grid-layout/grid-grow-tracks-to-their-max-expected.txt: Added.
  • fast/css-grid-layout/grid-grow-tracks-to-their-max.html: Added.
  • fast/css-grid-layout/grid-item-removal-track-breadth-update.html:
  • fast/css-grid-layout/minmax-max-content-resolution-rows.html:
  • fast/css-grid-layout/minmax-min-content-column-resolution-rows.html:
  • fast/css-grid-layout/percent-of-indefinite-track-size-in-auto.html:
  • fast/css-grid-layout/percent-of-indefinite-track-size.html:
12:12 AM Changeset in webkit [178576] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit2

Fix build warning in WebKit2/UIProcess module.
​https://bugs.webkit.org/show_bug.cgi?id=140538

Patch by Shivakumar JM <​shiva.jm@samsung.com> on 2015-01-16
Reviewed by Csaba Osztrogonác.

Fix build warnings by removing parameter name from functions

  • UIProcess/Storage/StorageManager.cpp:

(WebKit::StorageManager::processWillOpenConnection):
(WebKit::StorageManager::processDidCloseConnection):

  • UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::processWillOpenConnection):
(WebKit::WebProcessPool::processWillCloseConnection):

12:05 AM Changeset in webkit [178575] by Csaba Osztrogonác
  • 162 edits in trunk

Remove ENABLE(SQL_DATABASE) guards
​https://bugs.webkit.org/show_bug.cgi?id=140434

Reviewed by Darin Adler.

.:

  • Source/cmake/OptionsMac.cmake:
  • Source/cmake/WebKitFeatures.cmake:
  • Source/cmakeconfig.h.cmake:

Source/JavaScriptCore:

  • CMakeLists.txt:
  • Configurations/FeatureDefines.xcconfig:
  • DerivedSources.make:
  • inspector/protocol/Database.json:

Source/WebCore:

  • Configurations/FeatureDefines.xcconfig:
  • Modules/webdatabase/AbstractDatabaseServer.h:
  • Modules/webdatabase/ChangeVersionData.h:
  • Modules/webdatabase/ChangeVersionWrapper.cpp:
  • Modules/webdatabase/ChangeVersionWrapper.h:
  • Modules/webdatabase/DOMWindowWebDatabase.cpp:
  • Modules/webdatabase/DOMWindowWebDatabase.h:
  • Modules/webdatabase/DOMWindowWebDatabase.idl:
  • Modules/webdatabase/Database.cpp:
  • Modules/webdatabase/Database.h:
  • Modules/webdatabase/Database.idl:
  • Modules/webdatabase/DatabaseBackend.cpp:
  • Modules/webdatabase/DatabaseBackend.h:
  • Modules/webdatabase/DatabaseBackendBase.cpp:
  • Modules/webdatabase/DatabaseBackendBase.h:
  • Modules/webdatabase/DatabaseBasicTypes.h:
  • Modules/webdatabase/DatabaseCallback.h:
  • Modules/webdatabase/DatabaseCallback.idl:
  • Modules/webdatabase/DatabaseContext.cpp:
  • Modules/webdatabase/DatabaseContext.h:
  • Modules/webdatabase/DatabaseDetails.h:
  • Modules/webdatabase/DatabaseError.h:
  • Modules/webdatabase/DatabaseManager.cpp:
  • Modules/webdatabase/DatabaseManager.h:
  • Modules/webdatabase/DatabaseManagerClient.h:
  • Modules/webdatabase/DatabaseServer.cpp:
  • Modules/webdatabase/DatabaseServer.h:
  • Modules/webdatabase/DatabaseTask.cpp:
  • Modules/webdatabase/DatabaseTask.h:
  • Modules/webdatabase/DatabaseThread.cpp:
  • Modules/webdatabase/DatabaseThread.h:
  • Modules/webdatabase/DatabaseTracker.cpp:
  • Modules/webdatabase/DatabaseTracker.h:
  • Modules/webdatabase/OriginLock.cpp:
  • Modules/webdatabase/OriginLock.h:
  • Modules/webdatabase/SQLCallbackWrapper.h:
  • Modules/webdatabase/SQLError.h:
  • Modules/webdatabase/SQLError.idl:
  • Modules/webdatabase/SQLException.cpp:
  • Modules/webdatabase/SQLException.h:
  • Modules/webdatabase/SQLException.idl:
  • Modules/webdatabase/SQLResultSet.cpp:
  • Modules/webdatabase/SQLResultSet.h:
  • Modules/webdatabase/SQLResultSet.idl:
  • Modules/webdatabase/SQLResultSetRowList.cpp:
  • Modules/webdatabase/SQLResultSetRowList.h:
  • Modules/webdatabase/SQLResultSetRowList.idl:
  • Modules/webdatabase/SQLStatement.cpp:
  • Modules/webdatabase/SQLStatement.h:
  • Modules/webdatabase/SQLStatementBackend.cpp:
  • Modules/webdatabase/SQLStatementBackend.h:
  • Modules/webdatabase/SQLStatementCallback.h:
  • Modules/webdatabase/SQLStatementCallback.idl:
  • Modules/webdatabase/SQLStatementErrorCallback.h:
  • Modules/webdatabase/SQLStatementErrorCallback.idl:
  • Modules/webdatabase/SQLTransaction.cpp:
  • Modules/webdatabase/SQLTransaction.h:
  • Modules/webdatabase/SQLTransaction.idl:
  • Modules/webdatabase/SQLTransactionBackend.cpp:
  • Modules/webdatabase/SQLTransactionBackend.h:
  • Modules/webdatabase/SQLTransactionCallback.h:
  • Modules/webdatabase/SQLTransactionCallback.idl:
  • Modules/webdatabase/SQLTransactionClient.cpp:
  • Modules/webdatabase/SQLTransactionClient.h:
  • Modules/webdatabase/SQLTransactionCoordinator.cpp:
  • Modules/webdatabase/SQLTransactionCoordinator.h:
  • Modules/webdatabase/SQLTransactionErrorCallback.h:
  • Modules/webdatabase/SQLTransactionErrorCallback.idl:
  • Modules/webdatabase/SQLTransactionState.h:
  • Modules/webdatabase/SQLTransactionStateMachine.cpp:
  • Modules/webdatabase/SQLTransactionStateMachine.h:
  • bindings/js/JSCommandLineAPIHostCustom.cpp:

(WebCore::JSCommandLineAPIHost::databaseId):

  • bindings/js/JSCustomSQLStatementErrorCallback.cpp:
  • bindings/js/JSExceptionBase.cpp:

(WebCore::toExceptionBase):

  • bindings/js/JSSQLResultSetRowListCustom.cpp:
  • bindings/js/JSSQLTransactionCustom.cpp:
  • bindings/scripts/test/GObject/WebKitDOMTestCallback.cpp:

(webkit_dom_test_callback_finalize):
(webkit_dom_test_callback_constructor):
(webkit_dom_test_callback_callback_with_no_param):
(webkit_dom_test_callback_callback_with_array_param):
(webkit_dom_test_callback_callback_with_serialized_script_value_param):
(webkit_dom_test_callback_callback_with_non_bool_return_type):
(webkit_dom_test_callback_callback_with_string_list):
(webkit_dom_test_callback_callback_with_boolean):
(webkit_dom_test_callback_callback_requires_this_to_pass):

  • bindings/scripts/test/GObject/WebKitDOMTestCallbackPrivate.h:
  • bindings/scripts/test/JS/JSTestCallback.cpp:
  • bindings/scripts/test/JS/JSTestCallback.h:
  • bindings/scripts/test/ObjC/DOMTestCallback.mm:
  • bindings/scripts/test/TestCallback.idl:
  • dom/DOMExceptions.in:
  • dom/ScriptExecutionContext.cpp:

(WebCore::ScriptExecutionContext::setDatabaseContext):

  • dom/ScriptExecutionContext.h:
  • history/PageCache.cpp:

(WebCore::logCanCacheFrameDecision):
(WebCore::PageCache::canCachePageContainingThisFrame):

  • inspector/CommandLineAPIHost.cpp:

(WebCore::CommandLineAPIHost::CommandLineAPIHost):
(WebCore::CommandLineAPIHost::disconnect):
(WebCore::CommandLineAPIHost::databaseIdImpl):

  • inspector/CommandLineAPIHost.h:

(WebCore::CommandLineAPIHost::init):

  • inspector/InspectorController.cpp:

(WebCore::InspectorController::InspectorController):

  • inspector/InspectorDatabaseAgent.cpp:
  • inspector/InspectorDatabaseAgent.h:
  • inspector/InspectorDatabaseInstrumentation.h:

(WebCore::InspectorInstrumentation::didOpenDatabase):

  • inspector/InspectorDatabaseResource.cpp:
  • inspector/InspectorDatabaseResource.h:
  • inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::didCommitLoadImpl):
(WebCore::InspectorInstrumentation::didOpenDatabaseImpl):

  • inspector/InspectorInstrumentation.h:
  • inspector/InstrumentingAgents.cpp:

(WebCore::InstrumentingAgents::InstrumentingAgents):
(WebCore::InstrumentingAgents::reset):

  • inspector/InstrumentingAgents.h:
  • inspector/WorkerInspectorController.cpp:

(WebCore::WorkerInspectorController::WorkerInspectorController):

  • loader/EmptyClients.h:
  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::stopLoading):

  • page/ChromeClient.h:
  • platform/FeatureCounterKeys.h:

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:
  • Storage/WebDatabaseManager.mm:

(databasesDirectoryPath):

  • Storage/WebDatabaseManagerClient.h:
  • Storage/WebDatabaseManagerClient.mm:
  • Storage/WebDatabaseManagerInternal.h:
  • Storage/WebDatabaseManagerPrivate.h:
  • Storage/WebDatabaseQuotaManager.mm:

(-[WebDatabaseQuotaManager usage]):
(-[WebDatabaseQuotaManager quota]):
(-[WebDatabaseQuotaManager setQuota:]):

  • WebCoreSupport/WebChromeClient.h:
  • WebCoreSupport/WebChromeClient.mm:
  • WebCoreSupport/WebSecurityOrigin.mm:

(-[WebSecurityOrigin usage]):
(-[WebSecurityOrigin quota]):
(-[WebSecurityOrigin setQuota:]):

  • WebView/WebFrame.mm:

(-[WebFrame _cacheabilityDictionary]):

  • WebView/WebView.mm:

(-[WebView _commonInitializationWithFrameName:groupName:]):
(-[WebView _preferencesChanged:]):

Source/WebKit/win:

  • ForEachCoClass.h:
  • WebCoreSupport/WebChromeClient.cpp:

(WebChromeClient::exceededDatabaseQuota):

  • WebCoreSupport/WebChromeClient.h:
  • WebDatabaseManager.cpp:

(WebKitInitializeWebDatabasesIfNecessary):

  • WebDatabaseManager.h:
  • WebSecurityOrigin.cpp:

(WebSecurityOrigin::usage):
(WebSecurityOrigin::quota):
(WebSecurityOrigin::setQuota):

  • WebView.cpp:

(WebView::initWithFrame):
(WebView::notifyPreferencesChanged):

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:
  • Shared/OriginAndDatabases.cpp:
  • Shared/OriginAndDatabases.h:
  • Shared/WebCoreArgumentCoders.cpp:
  • UIProcess/API/C/WKContext.cpp:

(WKContextGetDatabaseManager):

  • UIProcess/API/C/WKDatabaseManager.cpp:

(WKDatabaseManagerGetTypeID):
(WKDatabaseManagerGetOriginKey):
(WKDatabaseManagerGetOriginQuotaKey):
(WKDatabaseManagerGetOriginUsageKey):
(WKDatabaseManagerGetDatabaseDetailsKey):
(WKDatabaseManagerGetDatabaseDetailsNameKey):
(WKDatabaseManagerGetDatabaseDetailsDisplayNameKey):
(WKDatabaseManagerGetDatabaseDetailsExpectedUsageKey):
(WKDatabaseManagerGetDatabaseDetailsCurrentUsageKey):
(WKDatabaseManagerGetDatabaseDetailsCreationTimeKey):
(WKDatabaseManagerGetDatabaseDetailsModificationTimeKey):
(WKDatabaseManagerSetClient):
(WKDatabaseManagerGetDatabasesByOrigin):
(WKDatabaseManagerGetDatabaseOrigins):
(WKDatabaseManagerDeleteDatabasesWithNameForOrigin):
(WKDatabaseManagerDeleteDatabasesForOrigin):
(WKDatabaseManagerDeleteAllDatabases):
(WKDatabaseManagerSetQuotaForOrigin):

  • UIProcess/API/efl/EwkView.cpp:

(EwkView::informDatabaseQuotaReached):

  • UIProcess/WebDatabaseManagerProxy.cpp:
  • UIProcess/WebDatabaseManagerProxy.h:
  • UIProcess/WebDatabaseManagerProxy.messages.in:
  • UIProcess/WebProcessPool.cpp:
  • UIProcess/efl/PageUIClientEfl.cpp:

(WebKit::PageUIClientEfl::PageUIClientEfl):
(WebKit::PageUIClientEfl::exceededDatabaseQuota):

  • UIProcess/efl/PageUIClientEfl.h:
  • WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::clearAllDatabases):
(WebKit::InjectedBundle::setDatabaseQuota):

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::exceededDatabaseQuota):

  • WebProcess/WebCoreSupport/WebChromeClient.h:
  • WebProcess/WebCoreSupport/WebDatabaseManager.cpp:
  • WebProcess/WebCoreSupport/WebDatabaseManager.h:
  • WebProcess/WebCoreSupport/WebDatabaseManager.messages.in:
  • WebProcess/WebCoreSupport/WebSQLiteDatabaseTracker.cpp:
  • WebProcess/WebCoreSupport/WebSQLiteDatabaseTracker.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::WebProcess):

Source/WTF:

  • wtf/FeatureDefines.h:

Tools:

  • Scripts/webkitperl/FeatureList.pm:
Note: See TracTimeline for information about the timeline view.