⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jan 23, 2015:

11:05 PM Changeset in webkit [179060] by Brent Fulgham
  • 1 edit
    1 add in trunk/LayoutTests

[Win] Unreviewed gardening. Add Windows baseline for
mouse-cursor-image-set.

  • platform/win/fast/events/mouse-cursor-image-set-expected.txt: Added.
11:04 PM Changeset in webkit [179059] by Brent Fulgham
  • 2 edits in trunk/Source/WebCore

[Win] Cursor assignment operator is skipping scale factor
​https://bugs.webkit.org/show_bug.cgi?id=140852

Reviewed by Chris Dumez.

Found by fast/events/mouse-cursor-image-set.html

  • platform/win/CursorWin.cpp:

(WebCore::Cursor::operator=): Make sure to also assign the
scale factor.

9:36 PM Changeset in webkit [179058] by ddkilzer@apple.com
  • 2 edits in trunk/Source/WebCore

[iOS] Attempt to fix the build after AVValueTiming.h moved

  • platform/spi/ios/AVKitSPI.h: The AVValueTiming.h header moved

to an unexpected location, so work around it by using local SPI
declarations.

9:33 PM Changeset in webkit [179057] by ap@apple.com
  • 2 edits in trunk/Source/WebCore

Try to fix the build after r179056.

  • platform/Cursor.h: (WebCore::Cursor::Cursor): Initialize dadat members in correct order.
9:26 PM Changeset in webkit [179056] by Brent Fulgham
  • 3 edits in trunk/Source/WebCore

[Win] Cursor copy constructor does not initialize scale factor
​https://bugs.webkit.org/show_bug.cgi?id=140849

Reviewed by Antti Koivisto.

Found by fast/events/mouse-cursor-image-set.html

Make sure the scale factor is captured during copy construction. Also make sure
it is properly initialized in the default constructor, since it it used in the
Windows port for some default cursors.

  • platform/CursorWin.h:
  • platform/win/CursorWin.cpp:

(WebCore::Cursor::Cursor): Make sure copy constructor captures
the scale factor.

8:15 PM Changeset in webkit [179055] by benjamin@webkit.org
  • 10 edits
    42 adds in trunk

Add pointer/hover media queries
​https://bugs.webkit.org/show_bug.cgi?id=134822

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2015-01-23
Reviewed by Antti Koivisto.

Source/WebCore:

Media Queries Level 4 introduces two types of Interaction Media Features:
"pointer" and "hover". Those media features are useful for adapting the design
to the type of input:

​http://dev.w3.org/csswg/mediaqueries-4/#mf-interaction

This implementation is trivial: just #ifdef the return value depending on
the support for touch events.
In the future we should move that to a client interface but let's start easy
for now.

Tests: fast/media/mq-any-hover-cssom.html

fast/media/mq-any-hover-invalid.html
fast/media/mq-any-hover-matchMedia.html
fast/media/mq-any-hover-styling.html
fast/media/mq-any-pointer-cssom.html
fast/media/mq-any-pointer-invalid.html
fast/media/mq-any-pointer-matchMedia.html
fast/media/mq-any-pointer-styling.html
fast/media/mq-hover-cssom.html
fast/media/mq-hover-invalid.html
fast/media/mq-hover-matchMedia.html
fast/media/mq-hover-styling.html
fast/media/mq-pointer-cssom.html
fast/media/mq-pointer-invalid.html
fast/media/mq-pointer-matchMedia.html
fast/media/mq-pointer-styling.html

  • css/CSSValueKeywords.in:
  • css/MediaFeatureNames.h:
  • css/MediaQueryEvaluator.cpp:

(WebCore::hoverMediaFeatureEval):
(WebCore::any_hoverMediaFeatureEval):
(WebCore::pointerMediaFeatureEval):
(WebCore::any_pointerMediaFeatureEval):
(WebCore::leastCapablePrimaryPointerDeviceType): Deleted.

  • css/MediaQueryExp.cpp:

(WebCore::featureWithCSSValueID):
(WebCore::featureWithZeroOrOne):
(WebCore::featureWithoutValue):

  • page/EventHandler.cpp:

(WebCore::EventHandler::dispatchFakeMouseMoveEventSoon):
(WebCore::EventHandler::fakeMouseMoveEventTimerFired):

  • page/Settings.in:

LayoutTests:

  • fast/media/mq-any-hover-cssom-expected.txt: Added.
  • fast/media/mq-any-hover-cssom.html: Added.
  • fast/media/mq-any-hover-invalid-expected.txt: Added.
  • fast/media/mq-any-hover-invalid.html: Added.
  • fast/media/mq-any-hover-matchMedia-expected.txt: Added.
  • fast/media/mq-any-hover-matchMedia.html: Added.
  • fast/media/mq-any-hover-styling-expected.txt: Added.
  • fast/media/mq-any-hover-styling.html: Added.
  • fast/media/mq-any-pointer-cssom-expected.txt: Added.
  • fast/media/mq-any-pointer-cssom.html: Added.
  • fast/media/mq-any-pointer-invalid-expected.txt: Added.
  • fast/media/mq-any-pointer-invalid.html: Added.
  • fast/media/mq-any-pointer-matchMedia-expected.txt: Added.
  • fast/media/mq-any-pointer-matchMedia.html: Added.
  • fast/media/mq-any-pointer-styling-expected.txt: Added.
  • fast/media/mq-any-pointer-styling.html: Added.
  • fast/media/mq-hover-cssom-expected.txt: Added.
  • fast/media/mq-hover-cssom.html: Added.
  • fast/media/mq-hover-invalid-expected.txt: Added.
  • fast/media/mq-hover-invalid.html: Added.
  • fast/media/mq-hover-matchMedia-expected.txt: Added.
  • fast/media/mq-hover-matchMedia.html: Added.
  • fast/media/mq-hover-styling-expected.txt: Added.
  • fast/media/mq-hover-styling.html: Added.
  • fast/media/mq-pointer-cssom-expected.txt: Added.
  • fast/media/mq-pointer-cssom.html: Added.
  • fast/media/mq-pointer-expected.txt:
  • fast/media/mq-pointer-invalid-expected.txt: Added.
  • fast/media/mq-pointer-invalid.html: Added.
  • fast/media/mq-pointer-matchMedia-expected.txt: Added.
  • fast/media/mq-pointer-matchMedia.html: Added.
  • fast/media/mq-pointer-styling-expected.txt: Added.
  • fast/media/mq-pointer-styling.html: Added.
  • fast/media/mq-pointer.html:
  • platform/ios-simulator/fast/media/mq-any-hover-matchMedia-expected.txt: Added.
  • platform/ios-simulator/fast/media/mq-any-hover-styling-expected.txt: Added.
  • platform/ios-simulator/fast/media/mq-any-pointer-matchMedia-expected.txt: Added.
  • platform/ios-simulator/fast/media/mq-any-pointer-styling-expected.txt: Added.
  • platform/ios-simulator/fast/media/mq-hover-matchMedia-expected.txt: Added.
  • platform/ios-simulator/fast/media/mq-hover-styling-expected.txt: Added.
  • platform/ios-simulator/fast/media/mq-pointer-expected.txt: Added.
  • platform/ios-simulator/fast/media/mq-pointer-matchMedia-expected.txt: Added.
  • platform/ios-simulator/fast/media/mq-pointer-styling-expected.txt: Added.
7:05 PM Changeset in webkit [179054] by commit-queue@webkit.org
  • 20 edits
    6 deletes in trunk

Unreviewed, rolling out r179051.
​https://bugs.webkit.org/show_bug.cgi?id=140850

broke the 32-bit build (Requested by thorton on #webkit).

Reverted changeset:

"[Mac][EME] Support ClearKey encryption with AES128-encrypted
HLS"
​https://bugs.webkit.org/show_bug.cgi?id=140825
​http://trac.webkit.org/changeset/179051

6:34 PM Changeset in webkit [179053] by commit-queue@webkit.org
  • 9 edits in trunk/Source

Web Inspector: Rename InjectedScriptHost::type to subtype
​https://bugs.webkit.org/show_bug.cgi?id=140841

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-01-23
Reviewed by Timothy Hatcher.

Source/JavaScriptCore:

We were using this to set the subtype of an "object" type RemoteObject
so we should clean up the name and call it subtype.

  • inspector/InjectedScriptHost.h:
  • inspector/InjectedScriptSource.js:
  • inspector/JSInjectedScriptHost.cpp:

(Inspector::JSInjectedScriptHost::subtype):
(Inspector::JSInjectedScriptHost::type): Deleted.

  • inspector/JSInjectedScriptHost.h:
  • inspector/JSInjectedScriptHostPrototype.cpp:

(Inspector::JSInjectedScriptHostPrototype::finishCreation):
(Inspector::jsInjectedScriptHostPrototypeFunctionSubtype):
(Inspector::jsInjectedScriptHostPrototypeFunctionType): Deleted.

Source/WebCore:

  • inspector/WebInjectedScriptHost.cpp:

(WebCore::WebInjectedScriptHost::subtype):
(WebCore::WebInjectedScriptHost::type): Deleted.

  • inspector/WebInjectedScriptHost.h:
6:27 PM Changeset in webkit [179052] by Antti Koivisto
  • 3 edits in trunk/Source/WebKit2

Implement cache size limit
​https://bugs.webkit.org/show_bug.cgi?id=140844

Reviewed by Andreas Kling.

Prevent the cache from growing without bounds. The simple scheme implemented here
estimates the cache size from number of entries. When the estimated size exceeds
the maximum size we randomly clear 1/4 of the entries.

  • NetworkProcess/cache/NetworkCacheStorage.h:
  • NetworkProcess/cache/NetworkCacheStorageCocoa.mm:

(WebKit::NetworkCacheStorage::NetworkCacheStorage):
(WebKit::NetworkCacheStorage::initialize):
(WebKit::NetworkCacheStorage::removeEntry):
(WebKit::NetworkCacheStorage::store):
(WebKit::NetworkCacheStorage::setMaximumSize):
(WebKit::NetworkCacheStorage::clear):
(WebKit::NetworkCacheStorage::shrinkIfNeeded):
(WebKit::NetworkCacheStorage::initializeKeyFilter): Deleted.

6:20 PM Changeset in webkit [179051] by jer.noble@apple.com
  • 20 edits
    3 copies
    10 adds in trunk

[Mac][EME] Support ClearKey encryption with AES128-encrypted HLS
​https://bugs.webkit.org/show_bug.cgi?id=140825

Reviewed by Eric Carlson.

Source/WebCore:

Test: http/tests/media/clearkey/clear-key-hls-aes128.html

Add support for ClearKey encryption when used with an AES-128 encrypted HLS stream.

  • Modules/encryptedmedia/CDM.cpp:

(WebCore::installedCDMFactories): Add the CDMPrivateClearKey factory.

  • Modules/encryptedmedia/CDMPrivateClearKey.cpp:

(WebCore::CDMPrivateClearKey::supportsKeySystem): Support the "org.w3c.clearkey" key system.
(WebCore::CDMPrivateClearKey::supportsKeySystemAndMimeType): Ditto.
(WebCore::CDMPrivateClearKey::supportsMIMEType): Ditto.
(WebCore::CDMPrivateClearKey::createSession): Create a CDMSessionClearKey.

  • Modules/encryptedmedia/CDMPrivateClearKey.h:

(WebCore::CDMPrivateClearKey::create): Simple factory.
(WebCore::CDMPrivateClearKey::~CDMPrivateClearKey): Virtual destructor.
(WebCore::CDMPrivateClearKey::CDMPrivateClearKey): Simple destructor.

  • Modules/encryptedmedia/CDMSessionClearKey.cpp: Added.

(WebCore::clearKeyVM): Static method returning the VM to be used by JSON parsing.
(WebCore::CDMSessionClearKey::CDMSessionClearKey): Simple constructor.
(WebCore::CDMSessionClearKey::~CDMSessionClearKey): Simple destructor.
(WebCore::CDMSessionClearKey::generateKeyRequest): Store the initData, ensure that it consists of a UTF8-encoded key

URI, and return same.

(WebCore::CDMSessionClearKey::releaseKeys): Purged all cached keys.
(WebCore::CDMSessionClearKey::update): Parse raw JSON-encoded JWK keys, rejecting non-AES, non-oct keys.
(WebCore::CDMSessionClearKey::cachedKeyForKeyID): Return cached keys.

  • Modules/encryptedmedia/CDMSessionClearKey.h:

Add support for the "org.w3c.clearkey" CDM to MediaPlayerPrivateAVFoundationObjC, and do so in a platform-agnostic
way by simply asking for raw key data from MediaPlayerClient when notified that a key has been added.

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::keySystemIsSupported):
(WebCore::MediaPlayerPrivateAVFoundationObjC::supportsType):
(WebCore::MediaPlayerPrivateAVFoundationObjC::supportsKeySystem):
(WebCore::fulfillRequestWithKeyData): Added utility method.
(WebCore::MediaPlayerPrivateAVFoundationObjC::shouldWaitForLoadingOfResource):
(WebCore::MediaPlayerPrivateAVFoundationObjC::keyAdded):

Pipe a keyAdded() notification down to MediaPlayer and a cachedKeyForKeyId() request up to CDMSessionClearKey:

  • Modules/encryptedmedia/MediaKeySession.cpp:

(WebCore::MediaKeySession::cachedKeyForKeyId):
(WebCore::MediaKeySession::addKeyTimerFired):

  • Modules/encryptedmedia/MediaKeySession.h:
  • Modules/encryptedmedia/MediaKeys.cpp:

(WebCore::MediaKeys::keyAdded):
(WebCore::MediaKeys::cachedKeyForKeyId):

  • Modules/encryptedmedia/MediaKeys.h:
  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::keyAdded):

  • html/HTMLMediaElement.h:
  • platform/graphics/CDMSession.h:

(WebCore::CDMSession::cachedKeyForKeyID):

  • platform/graphics/MediaPlayer.cpp:

(WebCore::MediaPlayer::keyAdded):
(WebCore::MediaPlayer::cachedKeyForKeyId):

  • platform/graphics/MediaPlayer.h:

(WebCore::MediaPlayerClient::mediaPlayerCachedKeyForKeyId):

  • platform/graphics/MediaPlayerPrivate.h:

(WebCore::MediaPlayerPrivateInterface::keyAdded):

Add new files to project:

  • WebCore.xcodeproj/project.pbxproj:
  • CMakeLists.txt:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:

LayoutTests:

  • http/tests/media/clearkey/clear-key-hls-aes128-expected.txt: Added.
  • http/tests/media/clearkey/clear-key-hls-aes128.html: Added.
  • http/tests/media/clearkey/support.js: Added.

(stringToUInt8Array):
(uInt8ArrayToString):
(base64EncodeUint8Array):

  • http/tests/media/resources/hls/clearkey/crypt0.key: Added.
  • http/tests/media/resources/hls/clearkey/iframe_index.m3u8: Added.
  • http/tests/media/resources/hls/clearkey/main0.ts: Added.
  • http/tests/media/resources/hls/clearkey/prog_index.m3u8: Added.
  • media/video-test.js:

(waitForEventOnceOn):

5:41 PM Changeset in webkit [179050] by Chris Dumez
  • 15 edits in trunk/Source/WebCore

Implement system fonts FontDescription caching at RenderTheme level
​https://bugs.webkit.org/show_bug.cgi?id=140840

Reviewed by Andreas Kling.

Implement system fonts FontDescription caching at RenderTheme level
instead of duplicating the logic in its subclasses for each platform.
This reduces code / logic duplication and reduces the amount of
platform-specific code. This will also make the refactoring at
Bug 140577 a lot easier.

The caching logic remains in RenderThemeIOS class for iOS because:

  • It supports different system font values than all other platforms
  • It requires cache invalidation in some cases while other platforms do not.

This patch is inspired by the following Blink revision:
​https://src.chromium.org/viewvc/blink?view=rev&revision=184449

Test: fast/css/css2-system-fonts.html

5:38 PM Changeset in webkit [179049] by Brent Fulgham
  • 2 edits in trunk/LayoutTests

[Win] Unreviewed gardening: Correct some typos in Failure entries.

  • platform/win/TestExpectations:
5:13 PM Changeset in webkit [179048] by Alan Bujtas
  • 2 edits in trunk/Source/WebCore

Simple line layout: Refactor line wrapping logic.
​https://bugs.webkit.org/show_bug.cgi?id=140834

Reviewed by Antti Koivisto.

Use a more readable structure to deal with wrapping logic.

No change in functionality.

  • rendering/SimpleLineLayout.cpp:

(WebCore::SimpleLineLayout::createLineRuns):

5:12 PM Changeset in webkit [179047] by Alan Bujtas
  • 3 edits in trunk/Source/WebCore

Simple line layout: Use only FlowContents::nextTextFragment() to read fragments from the text flow.
​https://bugs.webkit.org/show_bug.cgi?id=140842

Reviewed by Antti Koivisto.

This is in preparation to make FlowContents a content iterator class.

No change in functionality.

  • rendering/SimpleLineLayout.cpp:

(WebCore::SimpleLineLayout::initializeNewLine):

  • rendering/SimpleLineLayoutFlowContents.h:
5:05 PM Changeset in webkit [179046] by ddkilzer@apple.com
  • 2 edits in trunk/Tools

test-webkitpy: webkitpy.tool.commands.earlywarningsystem_unittest.EarlyWarningSystemTest.test_ewses fails on EFL, GTK, Win ports
<​http://webkit.org/b/140787>

Reviewed by Daniel Bates.

  • Scripts/webkitpy/port/ios.py:

(IOSPort.determine_full_port_name): Instead of checking the type
of the current host, test if /usr/bin/xcrun exists before trying
to use it.

5:03 PM Changeset in webkit [179045] by Lucas Forschler
  • 4 edits in branches/safari-600.1.4.15-branch/Source/WebCore

Build fix after r179028, r179030, r179031, r179032.

Reviewed by Dana Burkart.

  • platform/graphics/WidthIterator.cpp:

(WebCore::WidthIterator::WidthIterator):

  • platform/graphics/mac/ComplexTextController.cpp:

(WebCore::ComplexTextController::ComplexTextController):

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlockFlow::computeInlineDirectionPositionsForSegment):

4:52 PM Changeset in webkit [179044] by commit-queue@webkit.org
  • 5 edits
    2 adds in trunk

[MSE] Implement Range Removal algorithm.
​https://bugs.webkit.org/show_bug.cgi?id=140622.

Patch by Bartlomiej Gajda <​b.gajda@samsung.com> on 2015-01-23
Reviewed by Jer Noble.

Source/WebCore:

This extract Range Removal algorithm (Editor's Draft version, bug:26316) from remove(),
to separate function to deal with old FIXME since bug in spec was resolved.
This should both guarantee good order of events, and prevent from switching to 'open' state
during end of stream.

Test: media/media-source/media-source-end-of-stream-readyState.html

  • Modules/mediasource/MediaSource.cpp:

(WebCore::MediaSource::setDurationInternal): update to use rangeRemoval(), not remove()
(WebCore::MediaSource::streamEndedWithError): remove FIXME, brigning back correct order of events.

  • Modules/mediasource/SourceBuffer.cpp:

(WebCore::SourceBuffer::remove): comments up to spec, extract rangeRemoval algorithm.
(WebCore::SourceBuffer::rangeRemoval):
(WebCore::SourceBuffer::removeTimerFired): comments up to spec.

  • Modules/mediasource/SourceBuffer.h:

LayoutTests:

Added short test to check whether endOfStream incorrectly switches back
to 'open' state.

  • media/media-source/media-source-end-of-stream-readyState.html: Added.
  • media/media-source/media-source-end-of-stream-readyState-expected.txt: Added.
4:49 PM Changeset in webkit [179043] by Csaba Osztrogonác
  • 2 edits in trunk/Tools

Fix the false positive build failures on the Windows buildbots
​https://bugs.webkit.org/show_bug.cgi?id=140819

Reviewed by Brent Fulgham.

Increase the build timeout (without producing output) to 2 hours for Windows bots,
the default 20 minutes is enough for others since they produce output during the build.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:

(BuildFactory.init):

4:48 PM Changeset in webkit [179042] by dburkart@apple.com
  • 20 edits
    5 deletes in tags/Safari-600.5.3

Rollout r178466

4:45 PM Changeset in webkit [179041] by dburkart@apple.com
  • 12 edits
    8 deletes in tags/Safari-600.5.3

Rollout r178467

4:43 PM Changeset in webkit [179040] by dburkart@apple.com
  • 20 edits
    5 deletes in branches/safari-600.5-branch

Rollout r178466

4:38 PM Changeset in webkit [179039] by Brent Fulgham
  • 4 edits
    2 adds in trunk/LayoutTests

[Win] Test gardening. Mark a few failures after filing bugs.

Also rebaseline a few tests.

  • platform/win/TestExpectations:
  • platform/win/accessibility/parent-element-expected.txt:
  • platform/win/editing/input/caret-at-the-edge-of-input-expected.png: Added.
  • platform/win/editing/input/caret-at-the-edge-of-input-expected.txt: Added.
  • platform/win/js/dom/global-constructors-attributes-expected.txt:
4:32 PM Changeset in webkit [179038] by dburkart@apple.com
  • 12 edits
    8 deletes in branches/safari-600.5-branch

Rollout r178467

4:24 PM Changeset in webkit [179037] by rniwa@webkit.org
  • 2 edits in trunk/Websites/perf.webkit.org

Perf dashboard always assigns the result of A/B testing with build request 1
​https://bugs.webkit.org/show_bug.cgi?id=140382

Reviewed by Darin Adler.

The bug was caused by the expression array_get($report, 'jobId') or array_get($report, 'buildRequest')
which always evaluated to 1 when the report contained jobId. Fixed the bug by cascading array_get instead.

Also fixed a typo as well as a bug that reports were never associated with builds.

  • public/include/report-processor.php:

(ReportProcessor::process): Don't use "or" to find the non-null value since that always evaluates to 1
instead of the first non-null value.
(ReportProcessor::resolve_build_id): Fixed the typo by adding the missing "$this->".
(ReportProcessor::commit): Associate the report with the corresponding build as intended.

4:21 PM Changeset in webkit [179036] by rniwa@webkit.org
  • 2 edits in trunk/Websites/perf.webkit.org

Unreviewed typo fix. The prefix in triggerable_configurations is "trigconfig", not "trigrepo".

  • public/admin/tests.php:
3:48 PM Changeset in webkit [179035] by msaboff@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

LayoutTests/js/script-tests/reentrant-caching.js crashing on 32 bit builds
​https://bugs.webkit.org/show_bug.cgi?id=140843

Reviewed by Oliver Hunt.

When we are in vmEntryToJavaScript, we keep the stack pointer at an
alignment sutiable for pointing to a call frame header, which is the
alignment post making a call. We adjust the sp when calling to JS code,
but don't adjust it before calling the out of stack handler.

  • llint/LowLevelInterpreter32_64.asm:

Moved stack point down 8 bytes to get it aligned.

3:37 PM Changeset in webkit [179034] by dburkart@apple.com
  • 5 edits
    9 copies in branches/safari-600.5-branch

Merged r176354. <rdar://19451336>

3:34 PM Changeset in webkit [179033] by Brent Fulgham
  • 4 edits in trunk

Source/WebKit/win:
[Win] Teach WebKit to provide IAccessible2 'get_language'
​https://bugs.webkit.org/show_bug.cgi?id=140839

Reviewed by Dean Jackson.

  • AccessibleBase.cpp:

(AccessibleBase::get_locale): Wrap the Webore::AccessibleObject::language
result in an IA2Locale structure to statisfy the IAccessible2 specification.

Tools:
[Win] Teach WebKit to provide IAccessible2 'get_language' and access AXLanguage
​https://bugs.webkit.org/show_bug.cgi?id=140839

Reviewed by Dean Jackson.

  • DumpRenderTree/win/AccessibilityUIElementWin.cpp:

(AccessibilityUIElement::language): Retrieve the 'language' BSTR
from the IA2Locale structure and pass it to DRT.

3:09 PM Changeset in webkit [179032] by Lucas Forschler
  • 11 edits
    4 copies in branches/safari-600.1.4.15-branch

Merged r174489. rdar://problem/19434944

3:06 PM Changeset in webkit [179031] by Lucas Forschler
  • 2 edits in branches/safari-600.1.4.15-branch/Source/WebCore

Merged r174373. rdar://problem/19434944

3:05 PM Changeset in webkit [179030] by Lucas Forschler
  • 8 edits in branches/safari-600.1.4.15-branch/Source/WebCore

Merged r174297. rdar://problem/19434944

3:04 PM Changeset in webkit [179029] by dburkart@apple.com
  • 9 edits
    4 copies in branches/safari-600.5-branch

Merged r174489. <rdar://problem/19452129>

3:03 PM Changeset in webkit [179028] by Lucas Forschler
  • 42 edits
    1 copy in branches/safari-600.1.4.15-branch

Merged r174233. rdar://problem/19434944

2:16 PM Changeset in webkit [179027] by enrica@apple.com
  • 3 edits
    4 adds in trunk

Hit test returns incorrect results when performed in paginated content over the page gaps.
​https://bugs.webkit.org/show_bug.cgi?id=140837
rdar://problem/17494390

Reviewed by Dave Hyatt.

Source/WebCore:

Tests: fast/multicol/pagination/LeftToRight-tb-hittest.html

fast/multicol/pagination/RightToLeft-rl-hittest.html

When hittesting reaches the RenderView we need to check if we are
in paginated content and use the correct class to compute hittest results.

  • rendering/RenderView.cpp:

(WebCore::RenderView::updateHitTestResult):

LayoutTests:

  • fast/multicol/pagination/LeftToRight-tb-hittest-expected.txt: Added.
  • fast/multicol/pagination/LeftToRight-tb-hittest.html: Added.
  • fast/multicol/pagination/RightToLeft-rl-hittest-expected.txt: Added.
  • fast/multicol/pagination/RightToLeft-rl-hittest.html: Added.
1:57 PM Changeset in webkit [179026] by Brent Fulgham
  • 40 edits
    5 adds
    12 deletes in trunk/LayoutTests

[Win] Unreviewed gardening after landing r179024.

Update Windows-specific accessibility tests and test expectations after making Windows AX output match Mac.
This allows us to share more Mac results.

  • platform/win/TestExpectations:
  • platform/win/accessibility/adjacent-continuations-cause-assertion-failure-expected.txt:
  • platform/win/accessibility/aria-checkbox-text-expected.txt: Removed.
  • platform/win/accessibility/aria-combobox-expected.txt:
  • platform/win/accessibility/aria-fallback-roles-expected.txt: Removed.
  • platform/win/accessibility/aria-hidden-expected.txt: Removed.
  • platform/win/accessibility/aria-labelledby-on-input-expected.txt: Removed.
  • platform/win/accessibility/aria-labelledby-overrides-aria-label-expected.txt:
  • platform/win/accessibility/aria-labelledby-overrides-label-expected.txt: Removed.
  • platform/win/accessibility/aria-list-and-listitem-expected.txt:
  • platform/win/accessibility/aria-mappings-expected.txt: Added.
  • platform/win/accessibility/aria-menubar-menuitems-expected.txt:
  • platform/win/accessibility/aria-option-role-expected.txt:
  • platform/win/accessibility/aria-presentational-role-expected.txt: Removed.
  • platform/win/accessibility/aria-roles-expected.txt:
  • platform/win/accessibility/aria-tab-role-on-buttons-expected.txt:
  • platform/win/accessibility/aria-tab-roles-expected.txt:
  • platform/win/accessibility/aria-toggle-button-with-title-expected.txt: Removed.
  • platform/win/accessibility/canvas-description-and-role-expected.txt:
  • platform/win/accessibility/canvas-fallback-content-expected.txt:
  • platform/win/accessibility/css-content-attribute-expected.txt: Added.
  • platform/win/accessibility/deleting-iframe-destroys-axcache-expected.txt:
  • platform/win/accessibility/div-within-anchors-causes-crash-expected.txt:
  • platform/win/accessibility/document-enabled-state-expected.txt:
  • platform/win/accessibility/document-enabled-state.html:
  • platform/win/accessibility/document-role-expected.txt:
  • platform/win/accessibility/heading-elements-expected.txt:
  • platform/win/accessibility/heading-elements.html:
  • platform/win/accessibility/image-map1-expected.txt: Added.
  • platform/win/accessibility/image-with-alt-and-map-expected.txt: Added.
  • platform/win/accessibility/img-alt-attribute-expected.txt:
  • platform/win/accessibility/img-alt-attribute.html:
  • platform/win/accessibility/img-alt-tag-only-whitespace-expected.txt: Removed.
  • platform/win/accessibility/img-aria-button-alt-tag-expected.txt: Removed.
  • platform/win/accessibility/img-fallsback-to-title-expected.txt: Removed.
  • platform/win/accessibility/input-image-alt-expected.txt: Removed.
  • platform/win/accessibility/linked-elements-expected.txt:
  • platform/win/accessibility/linked-elements.html:
  • platform/win/accessibility/list-item-role-expected.txt:
  • platform/win/accessibility/list-item-role.html:
  • platform/win/accessibility/list-marker-role-expected.txt:
  • platform/win/accessibility/list-marker-role.html:
  • platform/win/accessibility/list-role-expected.txt:
  • platform/win/accessibility/list-role.html:
  • platform/win/accessibility/multiple-select-element-role-expected.txt:
  • platform/win/accessibility/multiple-select-element-role.html:
  • platform/win/accessibility/parent-element-expected.txt:
  • platform/win/accessibility/parent-element.html:
  • platform/win/accessibility/select-element-role-expected.txt:
  • platform/win/accessibility/select-element-role.html:
  • platform/win/accessibility/selection-and-focus-expected.txt:
  • platform/win/accessibility/selection-and-focus.html:
  • platform/win/accessibility/single-select-children.html:
  • platform/win/accessibility/svg-image-expected.txt: Removed.
  • platform/win/accessibility/text-role-expected.txt:
  • platform/win/aria-labelledby-overrides-aria-label-actual.txt: Added.
1:39 PM Changeset in webkit [179025] by akling@apple.com
  • 4 edits in trunk/Source/WebCore

Document should be a FontSelectorClient.
<​https://webkit.org/b/140833>

Reviewed by Antti Koivisto.

Make Document a FontSelectorClient so it can listen to the invalidation
callbacks from FontSelector instead of having code in FontSelector that
calls out to Document on invalidation.

  • css/CSSFontSelector.cpp:

(WebCore::CSSFontSelector::dispatchInvalidationCallbacks):

  • dom/Document.cpp:

(WebCore::Document::fontsNeedUpdate):
(WebCore::Document::fontSelector):
(WebCore::Document::clearStyleResolver):

  • dom/Document.h:
1:31 PM Changeset in webkit [179024] by Brent Fulgham
  • 2 edits in trunk/Tools

[Win] Update DRT Accessibility implementation to better match Mac.
​https://bugs.webkit.org/show_bug.cgi?id=140830

Reviewed by Dean Jackson.

  • DumpRenderTree/win/AccessibilityUIElementWin.cpp:

(AccessibilityUIElement::titleUIElement):
(AccessibilityUIElement::parentElement):
(convertToDRTLabel):
(AccessibilityUIElement::role):
(AccessibilityUIElement::title):
(AccessibilityUIElement::description):
(AccessibilityUIElement::stringValue):
(AccessibilityUIElement::helpText):
(AccessibilityUIElement::isFocused):

12:53 PM Changeset in webkit [179023] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix the pre-Yosemite build.

  • UIProcess/API/mac/WKView.mm:

(-[WKView _dismissContentRelativeChildWindows]):

12:12 PM Changeset in webkit [179022] by bshafiei@apple.com
  • 1 copy in tags/Safari-600.1.4.15.2

New tag.

12:10 PM Changeset in webkit [179021] by bshafiei@apple.com
  • 1 copy in tags/Safari-600.5.3

New tag.

12:05 PM Changeset in webkit [179020] by bshafiei@apple.com
  • 5 edits in branches/safari-600.1.4.15-branch/Source

Versioning.

12:05 PM Changeset in webkit [179019] by Joseph Pecoraro
  • 15 edits
    2 adds in trunk

Web Inspector: Object Previews in the Console
​https://bugs.webkit.org/show_bug.cgi?id=129204

Reviewed by Timothy Hatcher.

Source/JavaScriptCore:

Update the very old, unused object preview code. Part of this comes from
the earlier WebKit legacy implementation, and the Blink implementation.

A RemoteObject may include a preview, if it is asked for, and if the
RemoteObject is an object. Previews are a shallow (single level) list
of a limited number of properties on the object. The previewed
properties are always stringified (even if primatives). Previews are
limited to just 5 properties or 100 indices. Previews are marked
as lossless if they are a complete snapshot of the object.

There is a path to make previews two levels deep, that is currently
unused but should soon be used for tables (e.g. IndexedDB).

  • inspector/InjectedScriptSource.js:
  • Move some code off of InjectedScript to be generic functions

usable by RemoteObject as well.

  • Update preview generation to use
  • inspector/protocol/Runtime.json:
  • Add a new type, "accessor" for preview objects. This represents

a getter / setter. We currently don't get the value.

Source/WebInspectorUI:

  • UserInterface/Controllers/JavaScriptLogViewController.js:

(WebInspector.JavaScriptLogViewController.prototype.consolePromptTextCommitted):

  • UserInterface/Controllers/JavaScriptRuntimeCompletionProvider.js:

(get WebInspector.JavaScriptRuntimeCompletionProvider.prototype.):
Update RuntimeManager callsites that do not need object previews.

  • UserInterface/Controllers/RuntimeManager.js:

(WebInspector.RuntimeManager.prototype.evalCallback):
(WebInspector.RuntimeManager.prototype.evaluateInInspectedWindow):
Update the main evaluate method to include a boolean parameter for
object previews. Most callers do not need them. Also, since previews
were not available on iOS 6, switch to invoke, to conditionally
include the command parameter.

  • UserInterface/Protocol/RemoteObject.js:

(WebInspector.RemoteObject):
(WebInspector.RemoteObject.fromPayload):
(WebInspector.RemoteObject.prototype.get preview):
Store the preview from the payload.

  • UserInterface/Views/ConsoleMessageImpl.js:

(WebInspector.ConsoleMessageImpl.prototype._format):
(WebInspector.ConsoleMessageImpl.prototype._formatParameter):
(WebInspector.ConsoleMessageImpl.prototype._formatParameterAsNode):
(WebInspector.ConsoleMessageImpl.prototype._formatParameterAsString):
(WebInspector.ConsoleMessageImpl.prototype._formatAsArrayEntry):
Pass an explicit false for most formatters to not use a preview if available.

(WebInspector.ConsoleMessageImpl.prototype._formatParameterAsArray):
(WebInspector.ConsoleMessageImpl.prototype._formatParameterAsObject):
Currently only object types are previewed. Though we request previews
for arrays, we don't use the preview because we show a better preview
by just immediately requesting for a full non-preview property list.

(WebInspector.ConsoleMessageImpl.prototype._appendObjectPreview):
Quickly output an object preview into the title element. The format
is "ClassName {prop: value...}". Elide the class name if it is "Object".
Also skip over certain preview properties that may not be useful
at a glance (like constructor, or accessors without values).

  • UserInterface/Views/LogContentView.css:

(.console-object-preview):
(.console-formatted-array .console-object-preview):
(.console-object-preview-lossless):
(.expanded .console-object-preview):
Show lossy previews in italics.
Show lossless previews and array previews without italics.
Do not show the class name in the preview in italics when expanded.

(.console-object-preview .name):
Give preview property names the same color as ObjectPropertiesSection property names.

(.expanded .console-object-preview > .console-object-preview-body):
When expanding an object, hide the preview.

(.console-object-preview > .console-object-preview-name.console-object-preview-name-Object):
(.expanded .console-object-preview > .console-object-preview-name.console-object-preview-name-Object):
For "Object" previews, hide the name "Object" when not expanded, and show it when expanded.

LayoutTests:

  • inspector/debugger/command-line-api-exception-nested-catch.html:
  • inspector/debugger/command-line-api-exception.html:
  • inspector/model/remote-object-get-properties.html:

Update RuntimeManager callsites to not ask for previews when evaluating.

  • inspector/model/remote-object-expected.txt: Added.
  • inspector/model/remote-object.html: Added.

Add a test specifically for Remote Object. This test can also be
opened in a browser. It attempts to run the gamut of all different
types of objects and shows the RemoteObject constructed for it.

12:03 PM Changeset in webkit [179018] by bshafiei@apple.com
  • 5 edits in branches/safari-600.5-branch/Source

Versioning.

12:01 PM Changeset in webkit [179017] by Chris Dumez
  • 2 edits in trunk/Source/WebCore

Leverage CSSValuePool's font family cache in CSSComputedStyleDeclaration
​https://bugs.webkit.org/show_bug.cgi?id=140829

Reviewed by Andreas Kling.

Leverage CSSValuePool's font family cache in CSSComputedStyleDeclaration
by calling CSSValuePool::createFontFamilyValue() to create the font
family CSSPrimitiveValue instead of cssValuePool().createValue().

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::valueForFamily):

11:57 AM Changeset in webkit [179016] by saambarati1@gmail.com
  • 3 edits in trunk/Source/WebInspectorUI

Web Inspector: Disable *Annotators on minified files that aren't pretty printed
​https://bugs.webkit.org/show_bug.cgi?id=140550

Reviewed by Timothy Hatcher.

When SourceCodeTextEditor speculates that a file is minified it
sets a flag on itself that the Annotators will notice when pretty
printing and turning on type profiling.

SourceCodeTextEditor enforces the following two behaviors:

  1. Always pretty print a file if we think it's minified while

viewing type annotations. So, while viewing a minified file,
if you press the type profiling button, the pretty printer will
first reformat the file, then the type profiler will insert type annotations.

  1. If the type profiler is enabled and we're viewing a pretty

printed file that we think originally was minified, and the
pretty printer is disabled via pressing the button, then the
type profiler will also be disabled.

These two behaviors maintain a good user experience because
it prevents a bad visual representation of profiler data and
also prevents bad performance.

  • UserInterface/Controllers/TypeTokenAnnotator.js:

(WebInspector.TypeTokenAnnotator.prototype.toggleTypeAnnotations): Deleted.

  • UserInterface/Views/SourceCodeTextEditor.js:

(WebInspector.SourceCodeTextEditor):
(WebInspector.SourceCodeTextEditor.prototype.shown):
(WebInspector.SourceCodeTextEditor.prototype.contentDidChange):
(WebInspector.SourceCodeTextEditor.prototype.toggleTypeAnnotations):
(WebInspector.SourceCodeTextEditor.prototype.prettyPrint):
(WebInspector.SourceCodeTextEditor.prototype._contentWillPopulate):
(WebInspector.SourceCodeTextEditor.prototype._populateWithContent):
(WebInspector.SourceCodeTextEditor.prototype._setTypeTokenAnnotatorEnabledState):

11:52 AM Changeset in webkit [179015] by msaboff@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Immediate crash when setting JS breakpoint
​https://bugs.webkit.org/show_bug.cgi?id=140811

Reviewed by Mark Lam.

When the DFG stack layout phase doesn't allocate a register for the scope register,
it incorrectly sets the scope register in the code block to a bad value, one with
an offset of 0. Changed it so that we set the code block's scope register to the
invalid VirtualRegister instead.

No tests needed as adding the ASSERT in setScopeRegister() was used to find the bug.
We crash with that ASSERT in testapi and likely many other tests as well.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::CodeBlock):

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::setScopeRegister):
(JSC::CodeBlock::scopeRegister):
Added ASSERTs to catch any future improper setting of the code block's scope register.

  • dfg/DFGStackLayoutPhase.cpp:

(JSC::DFG::StackLayoutPhase::run):

11:43 AM Changeset in webkit [179014] by timothy_horton@apple.com
  • 10 edits in trunk/Source

QLPreviewMenuItem popovers don't close when the page scrolls
​https://bugs.webkit.org/show_bug.cgi?id=140806
<rdar://problem/19555618>

Reviewed by Beth Dakin.

Now that QLPreviewMenuItem's popover doesn't eat scrolls, we need to dismiss it if the page scrolls.

  • WebView/WebHTMLView.mm:

(-[WebHTMLView scrollWheel:scrollWheel:]):
Send scrollWheel along to WebImmediateActionController.

  • WebView/WebImmediateActionController.h:
  • WebView/WebImmediateActionController.mm:

(-[WebImmediateActionController webView:didHandleScrollWheel:]):
(-[WebImmediateActionController _clearImmediateActionState]):
(-[WebImmediateActionController _defaultAnimationController]):
Keep track of the active QLPreviewMenuItem, and close it upon scroll.

  • UIProcess/API/mac/WKView.mm:

(-[WKView _dismissContentRelativeChildWindows]):
Send _dismissContentRelativeChildWindows on to WKImmediateActionController.

  • UIProcess/mac/WKImmediateActionController.h:
  • UIProcess/mac/WKImmediateActionController.mm:

(-[WKImmediateActionController _clearImmediateActionState]):
(-[WKImmediateActionController dismissContentRelativeChildWindows]):
(-[WKImmediateActionController _defaultAnimationController]):
Keep track of the active QLPreviewMenuItem, and close it upon scroll.

  • platform/spi/mac/QuickLookMacSPI.h:

Add some SPI.

11:42 AM Changeset in webkit [179013] by timothy_horton@apple.com
  • 4 edits in trunk/Source

Infinite recursion in _clearImmediateActionState
​https://bugs.webkit.org/show_bug.cgi?id=140807
<rdar://problem/19571601>

Reviewed by Anders Carlsson.

  • UIProcess/mac/WKImmediateActionController.mm:

(-[WKImmediateActionController _clearImmediateActionState]):
Clear _hasActivatedActionContext before calling didUseActions, because
didUseActions can call _clearImmediateActionState.

  • WebView/WebImmediateActionController.mm:

(-[WebImmediateActionController _clearImmediateActionState]):
Use this opportunity to bring identical code to WebKit1, to avoid
getting DataDetectors stuck when an immediate action is canceled.

10:44 AM Changeset in webkit [179012] by akling@apple.com
  • 18 edits in trunk/Source/WebCore

Hang CSSFontSelector off Document instead of StyleResolver.
<​https://webkit.org/b/140820>

Reviewed by Antti Koivisto.

Move the CSSFontSelector from StyleResolver to Document. This is the first
step towards making the CSSFontSelector be able to survive full style recalc.

Clearing a Document's StyleResolver will still nuke the CSSFontSelector,
though that is done in Document::clearStyleResolver() now.

  • css/CSSFontSelector.cpp:

(WebCore::CSSFontSelector::CSSFontSelector):

  • css/CSSFontSelector.h:

Modernize CSSFontSelector construction a bit by having create() return
a Ref and the constructor take a Document& instead of a Document*.
Also made the constructor explicit.

(WebCore::StyleResolver::~StyleResolver):

  • dom/Document.cpp:

(WebCore::Document::clearStyleResolver):

Nuke the current CSSFontSelector in clearStyleResolver() instead of
in ~StyleResolver. It's a minor change, but shows the way forward.
Added a FIXME about how CSSFontSelector should eventually survive
this operation.

(WebCore::Document::fontSelector):

  • css/FontLoader.cpp:

(WebCore::FontLoader::loadFont):
(WebCore::FontLoader::checkFont):
(WebCore::FontLoader::resolveFontStyle):

  • css/RuleSet.cpp:

(WebCore::RuleSet::addChildRules):

  • css/StyleResolver.h:

(WebCore::StyleResolver::fontSelector): Deleted.

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::StyleResolver):
(WebCore::StyleResolver::appendAuthorStyleSheets):
(WebCore::StyleResolver::styleForElement):
(WebCore::StyleResolver::defaultStyleForElement):
(WebCore::StyleResolver::updateFont):

  • dom/Document.h:
  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::setFont):

  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::updateFromElement):
(WebCore::RenderListBox::paintItemForeground):

  • rendering/RenderMenuList.cpp:

(RenderMenuList::fontSelector):

  • rendering/RenderSearchField.cpp:

(WebCore::RenderSearchField::fontSelector):

  • rendering/TextAutoSizing.cpp:

(WebCore::TextAutoSizingValue::adjustNodeSizes):
(WebCore::TextAutoSizingValue::reset):

  • rendering/svg/RenderSVGInlineText.cpp:

(WebCore::RenderSVGInlineText::computeNewScaledFontForStyle):

  • style/StyleResolveForDocument.cpp:

(WebCore::Style::resolveForDocument):

  • style/StyleResolveTree.cpp:

(WebCore::Style::resolveTree):

Move CSSFontSelector ownership from StyleResolver to Document.

10:28 AM Changeset in webkit [179011] by eric.carlson@apple.com
  • 2 edits in trunk/LayoutTests

Create a "load and stall" cgi that support byte ranges.
​https://bugs.webkit.org/show_bug.cgi?id=140628

Reviewed by Jer Noble.

  • http/tests/media/resources/serve-video.php: Add support for "stallOffset", "stallDuration",

and "chunkSize" parameters.

10:27 AM Changeset in webkit [179010] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

Layout Test http/tests/media/track-in-band-hls-metadata.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=140827

Reviewed by Eric Carlson.

Create the m_metadataTrack by calling prepareMetadataTrack() before deref-ing it.

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::metadataDidArrive):

8:33 AM Changeset in webkit [179009] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WTF

[GTK] Add missing null check in some derefGPtr implementations
​https://bugs.webkit.org/show_bug.cgi?id=140822

Reviewed by Sergio Villar Senin.

It's missing in GHashTable and GVariant implementations.

  • wtf/gobject/GRefPtr.cpp:

(WTF::derefGPtr):

6:56 AM Changeset in webkit [179008] by svillar@igalia.com
  • 3 edits in trunk/Tools

REGRESSION: run-perf-tests --profiler= seems to have broken
​https://bugs.webkit.org/show_bug.cgi?id=113528

Reviewed by Daniel Bates.

The problem is that "perf --record" (or the equivalent call for
other profilers) is never called whenever there is a wrapper
option in the port. We should inject the profiler call first
(should it exists) and then use the port wrapper.

  • Scripts/webkitpy/port/driver.py:

(Driver._command_wrapper):

  • Scripts/webkitpy/port/driver_unittest.py:

(DriverTest.test_profiler_and_wrapper): New unit test.

6:30 AM Changeset in webkit [179007] by Carlos Garcia Campos
  • 19 edits
    12 adds in trunk

[GTK] Add initial database process support
​https://bugs.webkit.org/show_bug.cgi?id=139491

Reviewed by Sergio Villar Senin.

.:

  • Source/cmake/OptionsGTK.cmake: Set WebKit2_DatabaseProcess_OUTPUT_NAME.

Source/WebCore:

  • platform/sql/SQLiteFileSystem.cpp:

(WebCore::SQLiteFileSystem::openDatabase): Use
WebCore::fileSystemRepresentation() for the database filename,
otherwise sqlite3_open() fails when the filename contains "%2E".

Source/WebKit2:

Add initial support for DatabaseProcess, disabled by default for
now.

  • CMakeLists.txt: Add required files to compilation.
  • DatabaseProcess/DatabaseProcess.cpp:

(WebKit::DatabaseProcess::createDatabaseToWebProcessConnection):
Add the unix domain sockets implementation.

  • DatabaseProcess/EntryPoint/unix/DatabaseProcessMain.cpp: Added.

(main):

  • DatabaseProcess/gtk/DatabaseProcessMainGtk.cpp: Added.

(WebKit::DatabaseProcessMainUnix):

  • DatabaseProcess/unix/DatabaseProcessMainUnix.h: Added.
  • PlatformGTK.cmake: Add required files to compilation.
  • Shared/ProcessExecutablePath.h:
  • Shared/gtk/KeyedDecoder.cpp: Added.

(WebKit::KeyedDecoder::KeyedDecoder):
(WebKit::KeyedDecoder::~KeyedDecoder):
(WebKit::KeyedDecoder::buildDictionaryFromGVariant):
(WebKit::KeyedDecoder::decodeBytes):
(WebKit::KeyedDecoder::decodeBool):
(WebKit::KeyedDecoder::decodeUInt32):
(WebKit::KeyedDecoder::decodeInt32):
(WebKit::KeyedDecoder::decodeInt64):
(WebKit::KeyedDecoder::decodeFloat):
(WebKit::KeyedDecoder::decodeDouble):
(WebKit::KeyedDecoder::decodeString):
(WebKit::KeyedDecoder::beginObject):
(WebKit::KeyedDecoder::endObject):
(WebKit::KeyedDecoder::beginArray):
(WebKit::KeyedDecoder::beginArrayElement):
(WebKit::KeyedDecoder::endArrayElement):
(WebKit::KeyedDecoder::endArray):

  • Shared/gtk/KeyedDecoder.h: Added.
  • Shared/gtk/KeyedEncoder.cpp: Added.

(WebKit::KeyedEncoder::KeyedEncoder):
(WebKit::KeyedEncoder::~KeyedEncoder):
(WebKit::KeyedEncoder::encodeBytes):
(WebKit::KeyedEncoder::encodeBool):
(WebKit::KeyedEncoder::encodeUInt32):
(WebKit::KeyedEncoder::encodeInt32):
(WebKit::KeyedEncoder::encodeInt64):
(WebKit::KeyedEncoder::encodeFloat):
(WebKit::KeyedEncoder::encodeDouble):
(WebKit::KeyedEncoder::encodeString):
(WebKit::KeyedEncoder::beginObject):
(WebKit::KeyedEncoder::endObject):
(WebKit::KeyedEncoder::beginArray):
(WebKit::KeyedEncoder::beginArrayElement):
(WebKit::KeyedEncoder::endArrayElement):
(WebKit::KeyedEncoder::endArray):
(WebKit::KeyedEncoder::finishEncoding):

  • Shared/gtk/KeyedEncoder.h: Added.
  • Shared/gtk/ProcessExecutablePathGtk.cpp:

(WebKit::executablePathOfDatabaseProcess):

  • UIProcess/Databases/DatabaseProcessProxy.cpp:

(WebKit::DatabaseProcessProxy::didCreateDatabaseToWebProcessConnection):
Add the unix domain sockets implementation.

  • UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp:

(WebKit::ProcessLauncher::launchProcess): Handle the
DatabaseProcess too.

  • UIProcess/gtk/WebContextGtk.cpp:

(WebKit::WebContext::platformDefaultIndexedDBDatabaseDirectory):

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::ensureWebToDatabaseProcessConnection): Add
the unix domain sockets implementation.

Source/WTF:

Add support for using GRefPtr with GVariantBuilder.

  • wtf/gobject/GRefPtr.cpp:

(WTF::refGPtr):
(WTF::derefGPtr):

  • wtf/gobject/GRefPtr.h:
  • wtf/gobject/GTypedefs.h:
2:33 AM Changeset in webkit [179006] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Initialization for some member variable of FontPlatformData
​https://bugs.webkit.org/show_bug.cgi?id=136327

Patch by Byeongha Cho <​byeongha.cho@samsung.com> on 2015-01-23
Reviewed by Myles C. Maxfield.

No new tests. There's no functional change.

  • platform/graphics/freetype/FontPlatformDataFreeType.cpp:

(WebCore::FontPlatformData::FontPlatformData):
(WebCore::FontPlatformData::operator=):
(WebCore::FontPlatformData::~FontPlatformData):

2:05 AM Changeset in webkit [179005] by ddkilzer@apple.com
  • 2 edits in branches/safari-600.1.4.15-branch/Source/WebKit2

Merged r175608. rdar://problem/19395075

2:05 AM Changeset in webkit [179004] by ddkilzer@apple.com
  • 2 edits in branches/safari-600.1.4.15-branch/Source/WebKit2

Merged r175607. rdar://problem/19395075

2:05 AM Changeset in webkit [179003] by ddkilzer@apple.com
  • 5 edits in branches/safari-600.1.4.15-branch/Source/WebKit2

Merged r175595. rdar://problem/19395075

2:04 AM Changeset in webkit [179002] by ddkilzer@apple.com
  • 6 edits in branches/safari-600.1.4.15-branch/Source/WebKit2

Merged r175577. rdar://problem/19395075

2:04 AM Changeset in webkit [179001] by ddkilzer@apple.com
  • 9 edits in branches/safari-600.1.4.15-branch/Source/WebKit2

Merged r174885. rdar://problem/19395075

2:04 AM Changeset in webkit [179000] by ddkilzer@apple.com
  • 2 edits in branches/safari-600.1.4.15-branch/Source/WebKit2

Merged r174286. rdar://problem/19395075

2:04 AM Changeset in webkit [178999] by ddkilzer@apple.com
  • 4 edits
    3 adds in branches/safari-600.1.4.15-branch/Source

Merged r174250. rdar://problem/19395075

2:04 AM Changeset in webkit [178998] by ddkilzer@apple.com
  • 9 edits in branches/safari-600.1.4.15-branch/Source/WebKit2

Merged r174232. rdar://problem/19395075

2:04 AM Changeset in webkit [178997] by ddkilzer@apple.com
  • 8 edits in branches/safari-600.1.4.15-branch/Source/WebKit2

Merged r174072. rdar://problem/19395075

2:04 AM Changeset in webkit [178996] by ddkilzer@apple.com
  • 9 edits in branches/safari-600.1.4.15-branch/Source/WebKit2

Merged r172966. rdar://problem/19395075

2:04 AM Changeset in webkit [178995] by ddkilzer@apple.com
  • 3 edits in branches/safari-600.1.4.15-branch/Source/WebKit2

Merged r173762. rdar://problem/19420088

2:04 AM Changeset in webkit [178994] by ddkilzer@apple.com
  • 10 edits in branches/safari-600.1.4.15-branch/Source

Merged r173741. rdar://problem/19420088

1:18 AM Changeset in webkit [178993] by bshafiei@apple.com
  • 2 edits in branches/safari-600.5-branch/Source/WebKit/mac

Merged r178680. rdar://problem/19489593

1:17 AM Changeset in webkit [178992] by bshafiei@apple.com
  • 2 edits in branches/safari-600.5-branch/Source/WebKit/mac

Merged r178676. rdar://problem/19489593

1:16 AM Changeset in webkit [178991] by bshafiei@apple.com
  • 2 edits in branches/safari-600.5-branch/Source/WebKit/mac

Merged r178605. rdar://problem/19490114

1:14 AM Changeset in webkit [178990] by bshafiei@apple.com
  • 2 edits in branches/safari-600.5-branch/Source/WebKit2

Merged r178595. rdar://problem/19490114

12:52 AM Changeset in webkit [178989] by ap@apple.com
  • 2 edits in trunk/LayoutTests

svg-resource-fragment-identifier-img-src.html is a hidpi reftest, but its -expected.html
counterpart isn't hidpi
​https://bugs.webkit.org/show_bug.cgi?id=140815

Reviewed by Simon Fraser.

  • svg/css/svg-resource-fragment-identifier-img-src-expected.html: Make the expectation

match its test.

12:49 AM Changeset in webkit [178988] by g.czajkowski@samsung.com
  • 2 edits in trunk/Source/WebCore

Rename ChildNodeRemovalNotifier::m_insertionPoint to m_removalPoint
​https://bugs.webkit.org/show_bug.cgi?id=140766

Reviewed by Andreas Kling.

ChildNodeRemovalNotifier::ChildNodeRemovalNotifier(...) should take
a node as removal point.
It's probably Copy/Paste from ChildNodeInsertionNotifier::m_insertionPoint.

No new tests. No behavior change.

  • dom/ContainerNodeAlgorithms.h:

(WebCore::ChildNodeRemovalNotifier::ChildNodeRemovalNotifier):
(WebCore::ChildNodeRemovalNotifier::notifyNodeRemovedFromDocument):
(WebCore::ChildNodeRemovalNotifier::notifyNodeRemovedFromTree):

12:25 AM Changeset in webkit [178987] by Chris Dumez
  • 5 edits
    7 deletes in trunk/LayoutTests

Rewrite the fast/css/css2-system-fonts.html test to be more useful on all platforms
​https://bugs.webkit.org/show_bug.cgi?id=140810

Reviewed by Andreas Kling.

Make the fast/css/css2-system-fonts.html explicit about the font styles
expected on each platform instead of just Mac.

It also converts the test to be text only as the style information is
now displayed in text format.

This change is in preparation for a refactor of system font handling.

This change is based on the following Blink revision by
<​alancutter@chromium.org>:
​http://src.chromium.org/viewvc/blink?view=revision&revision=169612

  • fast/css/css2-system-fonts.html:
  • platform/efl/fast/css/css2-system-fonts-expected.png: Removed.
  • platform/efl/fast/css/css2-system-fonts-expected.txt: Removed.
  • platform/gtk/fast/css/css2-system-fonts-expected.png: Removed.
  • platform/gtk/fast/css/css2-system-fonts-expected.txt: Removed.
  • platform/ios-simulator-wk2/fast/css/css2-system-fonts-expected.txt:
  • platform/mac-mavericks/fast/css/css2-system-fonts-expected.png: Removed.
  • platform/mac-mavericks/fast/css/css2-system-fonts-expected.txt:
  • platform/mac-mountainlion/fast/css/css2-system-fonts-expected.txt: Removed.
  • platform/mac/fast/css/css2-system-fonts-expected.png: Removed.
  • platform/mac/fast/css/css2-system-fonts-expected.txt:
12:19 AM Changeset in webkit [178986] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[GTK] Fix debug build after r178940
​https://bugs.webkit.org/show_bug.cgi?id=140814

Patch by Hunseop Jeong <Hunseop Jeong> on 2015-01-23
Reviewed by Carlos Garcia Campos.

  • platform/graphics/opentype/OpenTypeVerticalData.cpp:

(WebCore::OpenTypeVerticalData::substituteWithVerticalGlyphs):

Jan 22, 2015:

11:31 PM Changeset in webkit [178985] by bshafiei@apple.com
  • 5 edits in branches/safari-600.4-branch/Source

Versioning.

11:04 PM Changeset in webkit [178984] by mhahnenb@gmail.com
  • 4 edits in trunk/Source/JavaScriptCore

EdenCollections unnecessarily visit SmallStrings
​https://bugs.webkit.org/show_bug.cgi?id=140762

Reviewed by Geoffrey Garen.

  • heap/Heap.cpp:

(JSC::Heap::copyBackingStores): Also added a GCPhase for copying
backing stores, which is a significant portion of garbage collection.
(JSC::Heap::visitSmallStrings): Check to see if we need to visit
SmallStrings based on the collection type.

  • runtime/SmallStrings.cpp:

(JSC::SmallStrings::SmallStrings):
(JSC::SmallStrings::visitStrongReferences): Set the fact that we have
visited the SmallStrings since the last modification.

  • runtime/SmallStrings.h:

(JSC::SmallStrings::needsToBeVisited): If we're doing a
FullCollection, we need to visit. Otherwise, it depends on whether
we've been visited since the last modification/allocation.

10:26 PM Changeset in webkit [178983] by Alan Bujtas
  • 3 edits in trunk/Source/WebCore

Simple line layout: Move leading whitespace handling from removeTrailingWhitespace() to initializeNewLine().
​https://bugs.webkit.org/show_bug.cgi?id=140757

Reviewed by Antti Koivisto.

Checking if overflowed pre-wrap whitespace needs to be ignored should not be part of the trailing whitespace handling.
Move it to initializeNewLine().

No change in functionality.

  • rendering/SimpleLineLayout.cpp:

(WebCore::SimpleLineLayout::preWrap):
(WebCore::SimpleLineLayout::removeTrailingWhitespace):
(WebCore::SimpleLineLayout::initializeNewLine):

  • rendering/SimpleLineLayoutFlowContents.h:

(WebCore::SimpleLineLayout::FlowContents::isLineBreak):

9:38 PM Changeset in webkit [178982] by matthew_hanson@apple.com
  • 6 edits in branches/safari-600.5-branch/Source

Merge r174708. rdar://problem/19451256

9:38 PM Changeset in webkit [178981] by matthew_hanson@apple.com
  • 1 edit
    3 adds in branches/safari-600.5-branch/LayoutTests

Merge r175264. rdar://problem/19451378

8:17 PM Changeset in webkit [178980] by benjamin@webkit.org
  • 10 edits in trunk/Source/WebKit2

[iOS][WK2] Ignore synthetic click initiated on a previous page
​https://bugs.webkit.org/show_bug.cgi?id=139556
rdar://problem/18586008

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2015-01-22
Reviewed by David Kilzer.

Under the right accumulation of bad luck, a synthetic click could be generated
on a page that never asked for it.

What happened was:
1) Page Foo listen to touch event.
2) In response to touch events, Foo decides to navigate to page Bar

*but* it does not cancel the native gesture recognizers with preventDefault().

3) Page Bar loads.
4) The native gesture recognizer ask us to click, we forward that to the WebProcess

and generate a synthetic mouse event.

-> Bar receives a click.
If you are unlucky enough, it looks like a single tap does a double click.

There are two ways this patch avoids the problem:

First, in the UIProcess, we just cancel the HighlightLongPressGestureRecognizer
on didCommitLoadForMainFrame. This prevents "fast clicks" from accidentally going through.
This is not bullet proof because we get didCommitLoadForMainFrame asynchronously but
killing the timer and gesture seems like a good idea.

Second, we skip any tap command at the WebProcess level when it was issued for
the previous page. This is using the same principle we used for VisibleContentRect:
any input generated before the current layer tree commit is useless for the current page.

We track the commit ID in the UIProcess when we decide to do the tracking or not.
Note that we keep the ID regardless of the tracking state, it does not matter if we have sent
touch events, what matters is what content was on screen when the touch events were handled.

If the user interaction result in a tap, we send the commit ID along the tap commands.
In the WebProcess, we know the actual layer tree commit associated with the current page.
If the tap was generated with a layer ID preceding the current page, we fail the command.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::handleTouchEventSynchronously):
(WebKit::WebPageProxy::resetState):

  • UIProcess/WebPageProxy.h:
  • UIProcess/ios/WKContentView.mm:

(-[WKContentView _didCommitLoadForMainFrame]):

  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _attemptClickAtLocation:]):

  • UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::commitPotentialTap):
(WebKit::WebPageProxy::handleTap):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::didCommitLoad):

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:
  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::handleTap):
(WebKit::WebPage::commitPotentialTap):

8:06 PM Changeset in webkit [178979] by ddkilzer@apple.com
  • 2 edits in trunk/Tools

configure-xcode-for-ios-development needs to import webkitdirs.pm
<​http://webkit.org/b/140704>

Fixes the following runtime error:

Undefined subroutine &main::exitStatus called at ./Tools/Scripts/configure-xcode-for-ios-development line 167.

  • Scripts/configure-xcode-for-ios-development: Add back code to

import webkitdirs.pm for the exitStatus() method. Not sure why
I removed it before patch review.

7:32 PM Changeset in webkit [178978] by akling@apple.com
  • 3 edits
    2 deletes in trunk/Source/WebKit

Remove unused class EmojiFallbackFontSelector.
<​https://webkit.org/b/140809>

Reviewed by Antti Koivisto.

Source/WebKit:

  • WebKit.xcodeproj/project.pbxproj:

Source/WebKit/ios:

This class no longer has any clients.

  • Misc/EmojiFallbackFontSelector.cpp: Removed.
  • Misc/EmojiFallbackFontSelector.h: Removed.
6:21 PM Changeset in webkit [178977] by dburkart@apple.com
  • 6 edits in branches/safari-600.5-branch/Source/WebCore

Merged r178967. <rdar://19572776>

6:17 PM Changeset in webkit [178976] by Chris Dumez
  • 1 edit
    2 adds in trunk/LayoutTests

Import fast/css/font-shorthand-line-height.html layout test from Blink
​https://bugs.webkit.org/show_bug.cgi?id=140801

Reviewed by Andreas Kling.

Import fast/css/font-shorthand-line-height.html layout test from Blink
to get better test coverage for 'line-height' font shorthands cascades:
​https://src.chromium.org/viewvc/blink?view=rev&revision=184346

I am working on expanding the font shorthand at parsing time (like
other shorthands) via Bug 140577 and I want to make sure I don't break
line-height in the process.

  • fast/css/font-shorthand-line-height-expected.txt: Added.
  • fast/css/font-shorthand-line-height.html: Added.
5:57 PM Changeset in webkit [178975] by Chris Dumez
  • 3 edits in trunk/Source/WebKit2

[WK2][Cocoa] Drop WKWebViewConfiguration._featureCounterEnabled SPI.
​https://bugs.webkit.org/show_bug.cgi?id=140799

Reviewed by Dan Bernstein.

Drop WKWebViewConfiguration._featureCounterEnabled SPI now that the
client-side has been updated.

  • UIProcess/API/Cocoa/WKWebViewConfiguration.mm:

(-[WKWebViewConfiguration _setAllowsAlternateFullscreen:]):
(-[WKWebViewConfiguration _featureCounterEnabled]): Deleted.
(-[WKWebViewConfiguration _setFeatureCounterEnabled:]): Deleted.

  • UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h:
5:28 PM Changeset in webkit [178974] by bshafiei@apple.com
  • 1 copy in tags/Safari-600.4.3

New tag.

5:19 PM Changeset in webkit [178973] by Antti Koivisto
  • 2 edits in trunk/Source/WebKit2

Fix ENABLE(NETWORK_CACHE) build

  • NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::NetworkResourceLoader::didFinishLoading):

5:16 PM Changeset in webkit [178972] by Brent Fulgham
  • 2 edits in trunk/Source/WebKit/win

[Win] Unreviewed test fix after r178965.

  • WebView.cpp: Supply missing implementation of 'setEditable'. It

currently asserts, causing all debug tests to fail.

4:47 PM Changeset in webkit [178971] by timothy_horton@apple.com
  • 2 edits in trunk/Tools

REGRESSION (r178847): Yosemite 32-bit bot isn't doing any work
​https://bugs.webkit.org/show_bug.cgi?id=140795

Reviewed by Jon Honeycutt.

  • BuildSlaveSupport/build.webkit.org-config/config.json:

r178847 accidentally remove the scheduler for this bot. Re-add it to the
Yosemite scheduler.

4:44 PM Changeset in webkit [178970] by jonowells@apple.com
  • 7 edits in trunk/Source/WebInspectorUI

Web Inspector: ResourceContentView.js incorrectly contains call to WebInspector.UIString with a variable parameter
​https://bugs.webkit.org/show_bug.cgi?id=140268

Reviewed by Timothy Hatcher.

UIString no longer incorrectly used around variables. Drive-by fixes to prototype inheritance style.
Use of Promises corrected such that requesting content for a resource resolves rather than rejects if
a resource can't be found or has another error that isn't a web inspector error.

  • Localizations/en.lproj/localizedStrings.js: Updated.
  • UserInterface/Models/Resource.js: Change reject to resolve.
  • UserInterface/Models/Script.js:

(WebInspector.Script.prototype.requestContentFromBackend): Proper use of Error object.

  • UserInterface/Models/SourceCode.js: Use correct inheritance style.
  • UserInterface/Views/ResourceContentView.js:

(WebInspector.ResourceContentView.prototype._contentAvailable): Handle error now that promise resolves.
(WebInspector.ResourceContentView.prototype._contentError): Remove incorrect use of UIString.

  • UserInterface/Views/SourceCodeTextEditor.js:

(WebInspector.SourceCodeTextEditor.prototype._contentAvailable): Handle error now that promise resolves.

4:31 PM Changeset in webkit [178969] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

[iOS] Media controls disappear when loading a HLS live stream
​https://bugs.webkit.org/show_bug.cgi?id=140792
rdar://problem/19491658

Reviewed by Dean Jackson.

Overload reconnectControls to reconnect the "start playback" button
if the control type has been set to "StartPlaybackButton".

  • Modules/mediacontrols/mediaControlsiOS.js:

(ControllerIOS.prototype.reconnectControls):

4:18 PM Changeset in webkit [178968] by commit-queue@webkit.org
  • 5 edits in trunk/Source

[Win] No plugin content on some sites.
​https://bugs.webkit.org/show_bug.cgi?id=140780

Patch by ​peavo@outlook.com <​peavo@outlook.com> on 2015-01-22
Reviewed by Anders Carlsson.

Source/WebCore:

Return script instance from ScriptController::createScriptInstanceForWidget(),
instead of always returning null.

  • bindings/js/ScriptController.cpp:

(WebCore::ScriptController::createScriptInstanceForWidget):

  • plugins/PluginViewBase.h:

(WebCore::PluginViewBase::bindingInstance):

Source/WebKit/win:

Add override modifier to bindingInstance method.

  • Plugins/PluginView.h:
4:17 PM Changeset in webkit [178967] by jer.noble@apple.com
  • 6 edits in trunk/Source/WebCore

[Mac][EME] Adopt changes to AVStreamSession class methods
​https://bugs.webkit.org/show_bug.cgi?id=140778
rdar://problem/19458200

Reviewed by Eric Carlson.

AVStreamSession class methods have added a "storageDirectoryAtURL:" parameter so as to be able to
read and modify records stored at non-default storage locations.

  • Modules/encryptedmedia/MediaKeySession.cpp:

(WebCore::MediaKeySession::mediaKeysStorageDirectory): Implement client method by querying document and settings.

  • Modules/encryptedmedia/MediaKeySession.h:
  • platform/graphics/CDMSession.h:
  • platform/graphics/avfoundation/objc/CDMSessionMediaSourceAVFObjC.h:
  • platform/graphics/avfoundation/objc/CDMSessionMediaSourceAVFObjC.mm:

(WebCore::CDMSessionMediaSourceAVFObjC::releaseKeys): Check whether the AVStreamSession class responds to new selector before calling.
(WebCore::CDMSessionMediaSourceAVFObjC::update): Ditto.
(WebCore::CDMSessionMediaSourceAVFObjC::generateKeyReleaseMessage): Ditto.
(WebCore::CDMSessionMediaSourceAVFObjC::storagePath): Fetch the storage path from the client.

4:15 PM Changeset in webkit [178966] by msaboff@apple.com
  • 3 edits
    2 adds in trunk

REGRESSION (174847): can't view NHK(Japan's national public broadcasting organization)’s news pages
​https://bugs.webkit.org/show_bug.cgi?id=140794

Reviewed by Anders Carlsson.

Source/WebCore:

If a document.open has been set, return it instead of always returning a new,
non-cached instance of jsHTMLDocumentPrototypeFunctionOpen.

Test: js/dom/document-overwrite-open.html

  • bindings/js/JSHTMLDocumentCustom.cpp:

(WebCore::JSHTMLDocument::getOwnPropertySlot):

LayoutTests:

  • js/dom/document-overwrite-open-expected.txt: Added.
  • js/dom/document-overwrite-open.html: Added.
3:46 PM Changeset in webkit [178965] by Brent Fulgham
  • 11 edits in trunk

[Win] Expose missing editing features through WebView interface
​https://bugs.webkit.org/show_bug.cgi?id=140773
<rdar://problem/19565421>

Reviewed by Dean Jackson.

Connect the various WebView editing delegate methods to our
test infrastructure. Also prefer _bstr_t to raw BSTR types
to simplify life cycle management.

Source/WebKit/win:

  • DOMCoreClasses.cpp: Flesh out the DOMRange object.

(DOMElement::createInstance):
(DOMRange::QueryInterface):
(DOMRange::DOMRange):
(DOMRange::~DOMRange):
(DOMRange::createInstance):
(DOMRange::startContainer):
(DOMRange::startOffset):
(DOMRange::endContainer):
(DOMRange::endOffset):
(DOMRange::collapsed):
(DOMRange::commonAncestorContainer):
(DOMRange::setStart):
(DOMRange::setEnd):
(DOMRange::setStartBefore):
(DOMRange::setStartAfter):
(DOMRange::setEndBefore):
(DOMRange::setEndAfter):
(DOMRange::collapse):
(DOMRange::selectNode):
(DOMRange::selectNodeContents):
(DOMRange::compareBoundaryPoints):
(DOMRange::deleteContents):
(DOMRange::extractContents):
(DOMRange::cloneContents):
(DOMRange::insertNode):
(DOMRange::surroundContents):
(DOMRange::cloneRange):
(DOMRange::toString):
(DOMRange::detach):

  • DOMCoreClasses.h:

(DOMRange::AddRef):
(DOMRange::Release):
(DOMRange::throwException):
(DOMRange::callWebScriptMethod):
(DOMRange::evaluateWebScript):
(DOMRange::removeWebScriptKey):
(DOMRange::stringRepresentation):
(DOMRange::webScriptValueAtIndex):
(DOMRange::setWebScriptValueAtIndex):
(DOMRange::setException):

  • Interfaces/IWebEditingDelegate.idl:
  • Interfaces/IWebView.idl:
  • WebCoreSupport/WebEditorClient.cpp: Connect more methods

to actual editing features in WebCore.
(WebEditorClient::shouldBeginEditing):
(WebEditorClient::shouldEndEditing):
(WebEditorClient::didBeginEditing):
(WebEditorClient::respondToChangedContents):
(WebEditorClient::respondToChangedSelection):
(WebEditorClient::didEndEditing):
(WebEditorClient::shouldDeleteRange):
(WebEditorClient::shouldInsertNode):
(WebEditorClient::shouldInsertText):
(WebEditorClient::shouldChangeSelectedRange):
(WebEditorClient::webViewDidChangeTypingStyle):
(WebEditorClient::webViewDidChangeSelection):
(WebEditorClient::isSelectTrailingWhitespaceEnabled):

  • WebView.cpp:

(WebView::setEditingDelegate): Added.

Tools:

  • DumpRenderTree/win/DumpRenderTree.cpp:

(resetWebViewToConsistentStateBeforeTesting):

  • DumpRenderTree/win/EditingDelegate.cpp:

(EditingDelegate::QueryInterface):
(dumpPath):
(dump):
(EditingDelegate::shouldBeginEditingInDOMRange):
(EditingDelegate::shouldEndEditingInDOMRange):
(EditingDelegate::shouldInsertNode):
(EditingDelegate::shouldInsertText):
(EditingDelegate::shouldDeleteDOMRange):
(EditingDelegate::shouldChangeSelectedDOMRange):
(EditingDelegate::shouldApplyStyle):
(EditingDelegate::shouldChangeTypingStyle):
(EditingDelegate::doPlatformCommand):
(EditingDelegate::webViewDidBeginEditing):
(EditingDelegate::webViewDidChange):
(EditingDelegate::webViewDidEndEditing):
(EditingDelegate::webViewDidChangeTypingStyle):
(EditingDelegate::webViewDidChangeSelection):
(EditingDelegate::checkSpellingOfString):
(EditingDelegate::onNotify):

  • DumpRenderTree/win/EditingDelegate.h:
3:42 PM Changeset in webkit [178964] by Alan Bujtas
  • 2 edits in trunk/Source/WebCore

Simple line layout: Reset LineState when starting a new line.
​https://bugs.webkit.org/show_bug.cgi?id=140789

Reviewed by Antti Koivisto.

Reset LineState when starting a new line to ensure we always
start with a clean state.

No change in functionality.

  • rendering/SimpleLineLayout.cpp:

(WebCore::SimpleLineLayout::updateLineConstrains):
(WebCore::SimpleLineLayout::initializeNewLine):
(WebCore::SimpleLineLayout::splitFragmentToFitLine):
(WebCore::SimpleLineLayout::createTextRuns):

3:35 PM Changeset in webkit [178963] by roger_fong@apple.com
  • 12 edits
    15 adds in trunk

[WebGL2] Create empty interface files for new WebGL2 objects.
​https://bugs.webkit.org/show_bug.cgi?id=140779.
<rdar://problem/15002288>

Reviewed by Dean Jackson.

  • CMakeLists.txt:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
  • html/canvas/WebGLQuery.cpp: Added.

(WebCore::WebGLQuery::create):
(WebCore::WebGLQuery::~WebGLQuery):
(WebCore::WebGLQuery::WebGLQuery):
(WebCore::WebGLQuery::deleteObjectImpl):

  • html/canvas/WebGLQuery.h: Added.
  • html/canvas/WebGLQuery.idl: Added.
  • html/canvas/WebGLSampler.cpp: Added.

(WebCore::WebGLSampler::create):
(WebCore::WebGLSampler::~WebGLSampler):
(WebCore::WebGLSampler::WebGLSampler):
(WebCore::WebGLSampler::deleteObjectImpl):

  • html/canvas/WebGLSampler.h: Added.
  • html/canvas/WebGLSampler.idl: Added.
  • html/canvas/WebGLSharedObject.h:

(WebCore::WebGLSharedObject::isQuery):
(WebCore::WebGLSharedObject::isSampler):
(WebCore::WebGLSharedObject::isSync):
(WebCore::WebGLSharedObject::isTransformFeedback):
(WebCore::WebGLSharedObject::isVertexArrayObject):

  • html/canvas/WebGLSync.cpp: Added.

(WebCore::WebGLSync::create):
(WebCore::WebGLSync::~WebGLSync):
(WebCore::WebGLSync::WebGLSync):
(WebCore::WebGLSync::deleteObjectImpl):

  • html/canvas/WebGLSync.h: Added.
  • html/canvas/WebGLSync.idl: Added.
  • html/canvas/WebGLTransformFeedback.cpp: Added.

(WebCore::WebGLTransformFeedback::create):
(WebCore::WebGLTransformFeedback::~WebGLTransformFeedback):
(WebCore::WebGLTransformFeedback::WebGLTransformFeedback):
(WebCore::WebGLTransformFeedback::deleteObjectImpl):

  • html/canvas/WebGLTransformFeedback.h: Added.
  • html/canvas/WebGLTransformFeedback.idl: Added.
  • html/canvas/WebGLVertexArrayObject.cpp: Added.

(WebCore::WebGLVertexArrayObject::create):
(WebCore::WebGLVertexArrayObject::~WebGLVertexArrayObject):
(WebCore::WebGLVertexArrayObject::WebGLVertexArrayObject):
(WebCore::WebGLVertexArrayObject::deleteObjectImpl):

  • html/canvas/WebGLVertexArrayObject.h: Added.
  • html/canvas/WebGLVertexArrayObject.idl: Added.
  • platform/mac-mavericks/js/dom/global-constructors-attributes-expected.txt:
  • platform/mac-mountainlion/js/dom/global-constructors-attributes-expected.txt:
  • platform/mac/js/dom/global-constructors-attributes-expected.txt:
3:35 PM Changeset in webkit [178962] by bshafiei@apple.com
  • 2 edits in tags/Safari-601.1.15.1/Source/WebKit2

Merged r178958. rdar://problem/19438402

3:34 PM Changeset in webkit [178961] by ddkilzer@apple.com
  • 2 edits in trunk/WebKitLibraries

[iOS] Fix build for external iphoneos SDK

Reviewed by Daniel Bates.

  • WebKitSystemInterface.h: Remove import of the

<IOSurface/IOSurface.h> header, and add a typedef for
IOSurfaceRef in its place.

3:32 PM Changeset in webkit [178960] by bshafiei@apple.com
  • 5 edits in tags/Safari-601.1.15.1/Source

Versioning.

3:30 PM Changeset in webkit [178959] by bshafiei@apple.com
  • 1 copy in tags/Safari-601.1.15.1

New tag.

3:21 PM Changeset in webkit [178958] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit2

UserData decoding of WKTypeRefWrapper always fails
​https://bugs.webkit.org/show_bug.cgi?id=140791
<rdar://problem/19438402>

Reviewed by Anders Carlsson.

  • Shared/mac/ObjCObjectGraph.mm:

(WebKit::ObjCObjectGraph::decode):
Add a missing break.

3:20 PM Changeset in webkit [178957] by ap@apple.com
  • 2 edits in trunk/LayoutTests

Skip another copy of oes-vertex-array-object test, because it has the same problems
as the old one.

  • platform/mac/TestExpectations:
3:16 PM Changeset in webkit [178956] by Brent Fulgham
  • 18 edits
    12 adds
    1 delete in trunk/LayoutTests

[Win] Unreviewed test gardening.

Clean up editing-related tests and rebaseline some output.

  • platform/win/TestExpectations:
  • platform/win/editing/input/reveal-caret-of-multiline-contenteditable-expected.txt:
  • platform/win/editing/input/reveal-caret-of-multiline-input-expected.txt:
  • platform/win/editing/inserting/4960120-1-expected.txt:
  • platform/win/editing/inserting/break-blockquote-after-delete-expected.txt:
  • platform/win/editing/inserting/insert-3907422-fix-expected.txt: Removed.
  • platform/win/editing/pasteboard/4641033-expected.txt: Added.
  • platform/win/editing/pasteboard/4944770-1-expected.txt: Added.
  • platform/win/editing/pasteboard/4944770-2-expected.txt: Added.
  • platform/win/editing/pasteboard/drop-text-without-selection-expected.txt: Added.
  • platform/win/editing/selection/3690703-2-expected.txt:
  • platform/win/editing/selection/3690703-expected.txt:
  • platform/win/editing/selection/3690719-expected.txt:
  • platform/win/editing/selection/4975120-expected.txt: Added.
  • platform/win/editing/selection/5240265-expected.txt:
  • platform/win/editing/selection/caret-before-select-expected.txt: Added.
  • platform/win/editing/selection/caret-rtl-2-expected.txt: Added.
  • platform/win/editing/selection/caret-rtl-2-left-expected.txt:
  • platform/win/editing/selection/caret-rtl-expected.txt: Added.
  • platform/win/editing/selection/caret-rtl-right-expected.txt:
  • platform/win/editing/selection/drag-select-1-expected.txt: Added.
  • platform/win/editing/selection/mixed-editability-10-expected.txt:
  • platform/win/editing/selection/replaced-boundaries-3-expected.txt: Added.
  • platform/win/editing/selection/select-box-expected.txt: Added.
  • platform/win/editing/selection/select-element-paragraph-boundary-expected.txt: Added.
  • platform/win/editing/selection/select-from-textfield-outwards-expected.txt:
  • platform/win/editing/selection/selection-button-text-expected.txt:
  • platform/win/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.txt:
  • platform/win/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.txt:
  • platform/win/editing/selection/vertical-rl-rtl-extend-line-backward-br-expected.txt:
3:13 PM Changeset in webkit [178955] by Chris Dumez
  • 2 edits in trunk/Source/WebCore

Fix remaining multiple targets per rule issues in DerivedSources.make
​https://bugs.webkit.org/show_bug.cgi?id=140790

Reviewed by David Kilzer.

Fix remaining multiple target per rule issues in DerivedSources.make,
similarly to Bug 140784 and Bug 140756.

This was causing us to run scripts several times to generate the same
files and may lead to malformed files in case of concurrency.

  • DerivedSources.make:
3:12 PM Changeset in webkit [178954] by rniwa@webkit.org
  • 17 edits in trunk

Add a build flag for ES6 class syntax
​https://bugs.webkit.org/show_bug.cgi?id=140760

Reviewed by Michael Saboff.

.:

  • Source/cmake/WebKitFeatures.cmake:
  • Source/cmakeconfig.h.cmake:

Source/JavaScriptCore:

Added ES6_CLASS_SYNTAX build flag and used it in tokenizer to recognize
"class", "extends", "static" and "super" keywords.

  • Configurations/FeatureDefines.xcconfig:
  • parser/Keywords.table:
  • parser/ParserTokens.h:

Source/WebCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:

Source/WTF:

  • wtf/FeatureDefines.h:

Tools:

  • Scripts/webkitperl/FeatureList.pm:
3:09 PM Changeset in webkit [178953] by Joseph Pecoraro
  • 2 edits in trunk/LayoutTests

Unreviewed, skip flakey inspector test.

2:23 PM Changeset in webkit [178952] by Chris Dumez
  • 2 edits in trunk/Source/WebCore

SVGNames.cpp and HTMLNames.cpp are sometimes malformed
​https://bugs.webkit.org/show_bug.cgi?id=140784
<rdar://problem/17701233>

Reviewed by David Kilzer.

Due to bad rules in DerivedSources.make, make_names.pl was called
several times with the same arguments during build. This is because
SVG/HTML/MathML each had several targets associated to the same
command. This would cause the command (make_names.pl) to be called
once per target. However, make_names.pl only needs to be executed
once to generate all of the files currently marked as target.

Calling make_names.pl several times for the same files is not only
wasteful, but it can also lead to malformed generated files if the
scripts instances are executed in parallel as they will read / write
from / to the same files.

This patch uses INTERMEDIATE targets instead so that we can still
indicate which files are generated by make_names.pl but only run
the script once.

This is a similar fix as for Bug 140756. There may several other
similar issues in DerivedSources.make but this patch focuses on
make_names.pl. I will take care of other in follow-ups if needed.

  • DerivedSources.make:
2:21 PM Changeset in webkit [178951] by Chris Dumez
  • 4 edits in trunk/Source/WebCore

Have Counter::create() return a Ref<Counter>
​https://bugs.webkit.org/show_bug.cgi?id=140777

Reviewed by Andreas Kling.

Have Counter::create() return a Ref<Counter> instead of a PassRefPtr.

The CSSPrimitiveValue class needed some updates as well to support
constructing a CSSPrimitiveValue object from a Ref<>.

  • css/CSSPrimitiveValue.cpp:

(WebCore::CSSPrimitiveValue::init):

  • css/CSSPrimitiveValue.h:

(WebCore::CSSPrimitiveValue::create):
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):

  • css/Counter.h:

(WebCore::Counter::create):
(WebCore::Counter::cloneForCSSOM):

2:20 PM Changeset in webkit [178950] by matthew_hanson@apple.com
  • 3 edits
    2 adds in branches/safari-600.5-branch

Merge r178426. rdar://problem/19526069

2:19 PM Changeset in webkit [178949] by Chris Dumez
  • 21 edits
    4 deletes in trunk/Source

Drop the legacy FeatureCounter class
​https://bugs.webkit.org/show_bug.cgi?id=140749

Reviewed by Andreas Kling.

Drop the legacy FeatureCounter class and use DiagnosticLoggingClient
instead.

Source/WebCore:

  • CMakeLists.txt:
  • Configurations/WebCore.xcconfig:
  • WebCore.exp.in:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::parseAttribute):

  • loader/SubresourceLoader.cpp:

(WebCore::SubresourceLoader::willSendRequest):
(WebCore::SubresourceLoader::didReceiveResponse):

  • loader/cache/CachedResource.cpp:

(WebCore::CachedResource::mustRevalidateDueToCacheHeaders):

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::logMemoryCacheResourceRequest):
(WebCore::CachedResourceLoader::requestResource):
(WebCore::CachedResourceLoader::determineRevalidationPolicy):

  • page/DiagnosticLoggingKeys.cpp:

(WebCore::DiagnosticLoggingKeys::mustRevalidateIsExpiredKey):
(WebCore::DiagnosticLoggingKeys::playedKey):
(WebCore::DiagnosticLoggingKeys::noCacheKey):
(WebCore::DiagnosticLoggingKeys::noStoreKey):
(WebCore::DiagnosticLoggingKeys::notInMemoryCacheKey):
(WebCore::DiagnosticLoggingKeys::mediaKey):
(WebCore::DiagnosticLoggingKeys::isExpiredKey):
(WebCore::DiagnosticLoggingKeys::loadingKey):
(WebCore::DiagnosticLoggingKeys::inMemoryCacheKey):
(WebCore::DiagnosticLoggingKeys::reasonKey):
(WebCore::DiagnosticLoggingKeys::audioKey):
(WebCore::DiagnosticLoggingKeys::cachedResourceRevalidationKey):
(WebCore::DiagnosticLoggingKeys::resourceRequestKey):
(WebCore::DiagnosticLoggingKeys::revalidatingKey):
(WebCore::DiagnosticLoggingKeys::unusedKey):
(WebCore::DiagnosticLoggingKeys::unusedReasonCredentialSettingsKey):
(WebCore::DiagnosticLoggingKeys::unusedReasonErrorKey):
(WebCore::DiagnosticLoggingKeys::unusedReasonMustRevalidateNoValidatorKey):
(WebCore::DiagnosticLoggingKeys::unusedReasonNoStoreKey):
(WebCore::DiagnosticLoggingKeys::unusedReasonRedirectChainKey):
(WebCore::DiagnosticLoggingKeys::unusedReasonReloadKey):
(WebCore::DiagnosticLoggingKeys::unusedReasonTypeMismatchKey):
(WebCore::DiagnosticLoggingKeys::usedKey):
(WebCore::DiagnosticLoggingKeys::userKey):
(WebCore::DiagnosticLoggingKeys::videoKey):
(WebCore::DiagnosticLoggingKeys::webViewKey):
(WebCore::DiagnosticLoggingKeys::zoomedKey):

  • page/DiagnosticLoggingKeys.h:
  • page/Settings.in:
  • platform/FeatureCounter.cpp: Removed.
  • platform/FeatureCounter.h: Removed.
  • platform/FeatureCounterKeys.h: Removed.
  • platform/ios/FeatureCounter.mm: Removed.

Source/WebKit2:

  • Shared/WebPreferencesDefinitions.h:
  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView initWithFrame:configuration:]):

  • UIProcess/API/Cocoa/WKWebViewConfiguration.mm:

(-[WKWebViewConfiguration init]):
(-[WKWebViewConfiguration copyWithZone:]):
(-[WKWebViewConfiguration _featureCounterEnabled]):
(-[WKWebViewConfiguration _setFeatureCounterEnabled:]):

  • UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):

  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::willStartUserTriggeredZooming):

2:17 PM Changeset in webkit [178948] by benjamin@webkit.org
  • 2 edits in trunk/Source/WebCore

When extending the fallback transitions with their closure, we are modifying the Set while iterating it
​https://bugs.webkit.org/show_bug.cgi?id=140785

Reviewed by Andreas Kling.

  • contentextensions/NFAToDFA.cpp:

(WebCore::ContentExtensions::populateTransitions):
Make that in two steps: accumulate the fallback transitions then add the closure
of every element.

2:16 PM Changeset in webkit [178947] by matthew_hanson@apple.com
  • 5 edits
    5 adds in branches/safari-600.5-branch

Merge r178038. rdar://problem/19451263

2:16 PM Changeset in webkit [178946] by matthew_hanson@apple.com
  • 2 edits in branches/safari-600.5-branch/Source/WebKit/mac

Merge r177611. rdar://problem/19451361

2:16 PM Changeset in webkit [178945] by matthew_hanson@apple.com
  • 1 edit
    5 adds in branches/safari-600.5-branch/LayoutTests

Merge r177408. rdar://problem/19451330

2:16 PM Changeset in webkit [178944] by matthew_hanson@apple.com
  • 3 edits
    2 adds in branches/safari-600.5-branch

Merge r177360. rdar://problem/19451319

2:13 PM Changeset in webkit [178943] by ap@apple.com
  • 2 edits in trunk/LayoutTests

​https://bugs.webkit.org/show_bug.cgi?id=140755
rdar://problem/7881290

  • http/tests/appcache/404-resource-with-slow-main-resource.php: Try updating the

tiemout, as it's not sufficient for appcache load to fail on some bots.

  • http/tests/appcache/404-resource-with-slow-main-resource.php:
2:02 PM Changeset in webkit [178942] by matthew_hanson@apple.com
  • 3 edits
    5 adds in branches/safari-600.5-branch

Merge r177292. rdar://problem/19452139

2:02 PM Changeset in webkit [178941] by matthew_hanson@apple.com
  • 18 edits in branches/safari-600.5-branch/Source

Merge r177152. rdar://problem/19451288

1:57 PM Changeset in webkit [178940] by Antti Koivisto
  • 118 edits
    2 moves in trunk/Source

Rename SimpleFontData to Font
​https://bugs.webkit.org/show_bug.cgi?id=140496

Reviewed by Zalan Bujtas.

The fallback supporting Font type was renamed FontCascade.
We can now rename SimpleFontData to Font matching the usual definition.

1:54 PM Changeset in webkit [178939] by Alan Bujtas
  • 2 edits in trunk/Source/WebCore

Simple line layout: Make trailing whitespace handling more explicit.
​https://bugs.webkit.org/show_bug.cgi?id=140776

Reviewed by Antti Koivisto.

Differentiate between committed and uncommitted trailing whitespace.
This enables further cleanup in removeTrailingWhitespace().

No change in functionality.

  • rendering/SimpleLineLayout.cpp:

(WebCore::SimpleLineLayout::LineState::commitAndCreateRun):
(WebCore::SimpleLineLayout::LineState::addUncommitted):
(WebCore::SimpleLineLayout::LineState::hasWhitespaceOnly):
(WebCore::SimpleLineLayout::LineState::removeTrailingWhitespace):
(WebCore::SimpleLineLayout::removeTrailingWhitespace):
(WebCore::SimpleLineLayout::LineState::LineState): Deleted.
(WebCore::SimpleLineLayout::LineState::removeCommittedTrailingWhitespace): Deleted.
(WebCore::SimpleLineLayout::LineState::resetTrailingWhitespace): Deleted.

1:40 PM Changeset in webkit [178938] by Beth Dakin
  • 6 edits in trunk/Source

ibtoold crash below -[WebView close]
​https://bugs.webkit.org/show_bug.cgi?id=140782
-and corresponding-
rdar://problem/19558472

Reviewed by Tim Horton.

Retain the NSImmediateActionGestureRecognizer. This should not be necessary, but
Source/WebKit/mac:

it is because interface builder is messing with our views.

  • WebView/WebImmediateActionController.h:
  • WebView/WebImmediateActionController.mm:

(-[WebImmediateActionController webViewClosed]):
(-[WebImmediateActionController _cancelImmediateAction]):
(-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
(-[WebImmediateActionController _updateImmediateActionItem]):

Source/WebKit2:

it is because interface builder can mess with our views.

  • UIProcess/mac/WKImmediateActionController.h:
  • UIProcess/mac/WKImmediateActionController.mm:

(-[WKImmediateActionController willDestroyView:]):
(-[WKImmediateActionController _cancelImmediateAction]):
(-[WKImmediateActionController _cancelImmediateActionIfNeeded]):
(-[WKImmediateActionController _updateImmediateActionItem]):

1:04 PM Changeset in webkit [178937] by ap@apple.com
  • 6 edits
    2 adds in trunk

Crash in URL::protocol() after appcache load fails
​https://bugs.webkit.org/show_bug.cgi?id=140755
rdar://problem/7881290

Reviewed by Dan Bates.

Source/WebCore:

Test: http/tests/appcache/404-resource-with-slow-main-resource.php

Not every cache that isn't being updated is complete. It could also be in a zombie
state after failing to load. We get rid of the cache once the main resource finishes
loading, but while it's being loaded, the zombie still looks like a regular
candidate application cache.

  • loader/appcache/ApplicationCache.cpp: (WebCore::ApplicationCache::isComplete):
  • loader/appcache/ApplicationCache.h:

Removed const from isComplete(), because otherwise we couldn't use ApplicationCacheGroup::m_caches.contains().
Constness doesn't make a lot of sense for these objects anyway.

  • loader/appcache/ApplicationCacheGroup.cpp:

(WebCore::ApplicationCacheGroup::failedLoadingMainResource): Toned down an assertion.
We can fail a main resource load when the document has a zombie appcache, too.

  • loader/appcache/ApplicationCacheGroup.h:

(WebCore::ApplicationCacheGroup::cacheIsComplete):
(WebCore::ApplicationCacheGroup::cacheIsBeingUpdated): Deleted.
These functions are only used in ApplicationCache::isComplete().

LayoutTests:

  • http/tests/appcache/404-resource-with-slow-main-resource-expected.txt: Added.
  • http/tests/appcache/404-resource-with-slow-main-resource.php: Added.
12:35 PM Changeset in webkit [178936] by matthew_hanson@apple.com
  • 3 edits
    5 adds in branches/safari-600.5-branch

Merge r177033. rdar://problem/19451244

12:34 PM Changeset in webkit [178935] by matthew_hanson@apple.com
  • 2 edits in branches/safari-600.5-branch/Source/WebKit/mac

Merge r177011. rdar://problem/19451253

12:34 PM Changeset in webkit [178934] by matthew_hanson@apple.com
  • 2 edits in branches/safari-600.5-branch/Source/WTF

Merge r176982. rdar://problem/19452174

12:34 PM Changeset in webkit [178933] by matthew_hanson@apple.com
  • 3 edits
    2 adds in branches/safari-600.5-branch

Merge r176971. rdar://problem/19452174

12:34 PM Changeset in webkit [178932] by matthew_hanson@apple.com
  • 3 edits
    2 adds in branches/safari-600.5-branch

Merge r176768. rdar://problem/19451369

12:03 PM Changeset in webkit [178931] by matthew_hanson@apple.com
  • 3 edits
    2 adds in branches/safari-600.5-branch

Merge r176285. rdar://problem/19452164

12:01 PM Changeset in webkit [178930] by g.czajkowski@samsung.com
  • 2 edits in trunk/Source/WebCore

Avoid defining always empty Vector<TextCheckingResult>
​https://bugs.webkit.org/show_bug.cgi?id=140765

Reviewed by Alexey Proskuryakov.

Pass an empty vector direclty instead.

No new tests. No behavior change.

  • editing/SpellChecker.cpp:

(WebCore::SpellChecker::didCheckCancel):

11:38 AM Changeset in webkit [178929] by Chris Dumez
  • 2 edits in trunk/Source/WebCore

makeprop.pl script is called too many times during build
​https://bugs.webkit.org/show_bug.cgi?id=140756
<rdar://problem/19467942>

Reviewed by David Kilzer.

The makeprop.pl script was called 4 times (instead of once) during
build due to a bad Makefile rule in DerivedSources.make. makeprop.pl
had 4 associated targets and thus was called 4 times (with the same
parameter). Calling it once is sufficient to generate all 4 files
that were marked as target. This patch uses an INTERMEDIATE target
instead so that we can indicate that several files are generated
by the same command.

I believe this may be the reason for the sporatic build failures
that look like:
"""
CSSPropertyNames.gperf: No keywords in input file!
calling gperf failed: 256 at WebCore/css/makeprop.pl line 1036.
"""
The makeprop.pl script is generating gperf's input file and calling the
gperf executable on this file. If the script is executed several times
in parallel, it would explain the build failures as several instances
of makeprop.pl may be writing / reading from the same
CSSPropertyNames.gperf file.

  • DerivedSources.make:
11:34 AM Changeset in webkit [178928] by commit-queue@webkit.org
  • 31 edits
    3 deletes in trunk

Unreviewed, rolling out r178894.
​https://bugs.webkit.org/show_bug.cgi?id=140775

Broke JSC and bindings tests (Requested by ap_ on #webkit).

Reverted changeset:

"put_by_val_direct need to check the property is index or not
for using putDirect / putDirectIndex"
​https://bugs.webkit.org/show_bug.cgi?id=140426
​http://trac.webkit.org/changeset/178894

11:27 AM Changeset in webkit [178927] by ddkilzer@apple.com
  • 9 edits
    2 copies
    1 add in trunk/Source

[iOS] Fix iphoneos SDK builds for ios-ews queue
<​http://webkit.org/b/140748>

Reviewed by Daniel Bates.

Source/WebCore:

  • WebCore.xcodeproj/project.pbxproj: Add new SPI headers.
  • platform/graphics/cg/ImageBufferCG.cpp: Switch to using

"IOSurfaceSPI.h" from <IOSurface/IOSurface.h>.

  • platform/graphics/cg/ImageBufferDataCG.cpp: Ditto.
  • platform/graphics/cocoa/IOSurface.mm: Ditto. Move definitions

in <IOSurface/IOSurfacePrivate.h> into "IOSurfaceSPI.h".

  • platform/spi/cg/CoreGraphicsSPI.h: Switch to

WTF_EXTERN_C_{BEGIN,END}. Add
CGContextGetFontAntialiasingStyle() and
CGContextSetFontAntialiasingStyle().

  • platform/spi/cocoa/IOPMLibSPI.h: Switch to use IOReturnSPI.h.
  • platform/spi/cocoa/IOReturnSPI.h: Add.
  • platform/spi/cocoa/IOSurfaceSPI.h: Add.
  • platform/spi/cocoa/IOTypesSPI.h: Add.

Source/WebKit2:

  • Platform/spi/ios/BKSProcessAssertionSPI.h: Add -invalidate

definition. Sort @property to the top of BKSProcessAssertion.

11:05 AM Changeset in webkit [178926] by mark.lam@apple.com
  • 5 edits
    3 adds in trunk

BytecodeGenerator::initializeCapturedVariable() sets a misleading value for the 5th operand of op_put_to_scope.
<​https://webkit.org/b/140743>

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

BytecodeGenerator::initializeCapturedVariable() was setting the 5th operand to
op_put_to_scope to an inappropriate value (i.e. 0). As a result, the execution
of put_to_scope could store a wrong inferred value into the VariableWatchpointSet
for which ever captured variable is at local index 0. In practice, this turns
out to be the local for the Arguments object. In this reproduction case in the
bug, the wrong inferred value written there is the boolean true.

Subsequently, DFG compilation occurs and CreateArguments is emitted to first do
a check of the local for the Arguments object. But because that local has a
wrong inferred value, the check always discovers a non-null value and we never
actually create the Arguments object. Immediately after this, an OSR exit
occurs leaving the Arguments object local uninitialized. Later on at arguments
tear off, we run into a boolean true where we had expected to find an Arguments
object, which in turn, leads to the crash.

The fix is to:

  1. In the case where the resolveModeType is LocalClosureVar, change the 5th operand of op_put_to_scope to be a boolean. True means that the local var is watchable. False means it is not watchable. We no longer pass the local index (instead of true) and UINT_MAX (instead of false).

This allows us to express more clearer in the code what that value means,
as well as remove the redundant way of getting the local's identifier.
The identifier is always the one passed in the 2nd operand.

  1. Previously, though intuitively, we know that the watchable variable identifier should be the same as the one that is passed in operand 2, this relationship was not clear in the code. By code analysis, I confirmed that the callers of BytecodeGenerator::emitPutToScope() always use the same identifier for operand 2 and for filling out the ResolveScopeInfo from which we get the watchable variable identifier later. I've changed the code to make this clear now by always using the identifier passed in operand 2.
  1. In the case where the resolveModeType is LocalClosureVar, initializeCapturedVariable() and emitPutToScope() will now query hasWatchableVariable() to determine if the local is watchable or not. Accordingly, we pass the boolean result of hasWatchableVariable() as operand 5 of op_put_to_scope.

Also added some assertions.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::CodeBlock):

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::initializeCapturedVariable):
(JSC::BytecodeGenerator::hasConstant):
(JSC::BytecodeGenerator::emitPutToScope):

  • bytecompiler/BytecodeGenerator.h:

(JSC::BytecodeGenerator::hasWatchableVariable):
(JSC::BytecodeGenerator::watchableVariableIdentifier):
(JSC::BytecodeGenerator::watchableVariable): Deleted.

LayoutTests:

  • js/dfg-osr-exit-between-create-and-tearoff-arguments-expected.txt: Added.
  • js/dfg-osr-exit-between-create-and-tearoff-arguments.html: Added.
  • js/script-tests/dfg-osr-exit-between-create-and-tearoff-arguments.js: Added.

(foo):

10:51 AM Changeset in webkit [178925] by dbates@webkit.org
  • 2 edits in trunk/Tools

[iOS] run-webkit-tests --ios-sim dies with an error; fails to parse Apple Internal
runtime in simctl output
​https://bugs.webkit.org/show_bug.cgi?id=140751

Reviewed by David Kilzer.

Following the fix for <rdar://problem/19444383>, run-webkit-tests --ios-sim dies
with an error because it does not know how to parse the output of the simctl tool
to identify an Apple Internal runtime.

  • Scripts/webkitpy/xcode/simulator.py:

(Runtime.init): Add parameter is_internal_runtime (defaults to False).
(Runtime.eq): Take is_internal_runtime when comparing two Runtime objects for equality.
(Runtime.repr): Update printable representation of Runtime object to indicate whether
the runtime is an internal runtime.
(Simulator): Update regular expressions runtime_re and version_re to match an internal runtime.
(Simulator._parse_runtimes): Pass is_internal_runtime to the Runtime constructor with the
appropriate value.
(Simulator._parse_devices): Pass argument is_internal_runtime to Simulator.runtime() so that
it updates the appropriate Runtime object.
(Simulator.runtime): Added optional parameter, is_internal_runtime. Modified to support
looking up a Runtime object for an internal runtime.

10:47 AM Changeset in webkit [178924] by matthew_hanson@apple.com
  • 2 edits in branches/safari-600.5-branch/Source/WebCore

Merge r175771. rdar://problem/19451238

10:47 AM Changeset in webkit [178923] by matthew_hanson@apple.com
  • 7 edits in branches/safari-600.5-branch/Source/WebKit2

Merge r175759. rdar://problem/19450899

10:47 AM Changeset in webkit [178922] by matthew_hanson@apple.com
  • 4 edits
    2 adds in branches/safari-600.5-branch

Merge r175131. rdar://problem/19452187

10:46 AM Changeset in webkit [178921] by matthew_hanson@apple.com
  • 3 edits
    2 adds in branches/safari-600.5-branch

Merge r174716. rdar://problem/19451273

10:46 AM Changeset in webkit [178920] by matthew_hanson@apple.com
  • 3 edits in branches/safari-600.5-branch

Merge r174698. rdar://problem/19451342

10:25 AM Changeset in webkit [178919] by Brent Fulgham
  • 8 edits
    5 adds in trunk/LayoutTests

[Win] More unskips and rebaselines.

  • platform/win/TestExpectations:
  • platform/win/fast/repaint/repaint-across-writing-mode-boundary-expected.png:
  • platform/win/fast/repaint/repaint-across-writing-mode-boundary-expected.txt:
  • platform/win/inspector-protocol: Added.
  • platform/win/inspector-protocol/debugger: Added.
  • platform/win/inspector-protocol/debugger/breakpoint-eval-with-exception-expected.txt: Added.
  • platform/win/inspector-protocol/debugger/setBreakpoint-actions-expected.txt: Added.
  • platform/win/inspector-protocol/debugger/setBreakpoint-dfg-callee-and-examine-dfg-local-expected.txt: Added.
  • platform/win/svg/text/kerning-expected.txt:
  • platform/win/svg/text/multichar-glyph-expected.txt:
  • platform/win/svg/transforms/text-with-mask-with-svg-transform-expected.png:
  • platform/win/svg/transforms/text-with-mask-with-svg-transform-expected.txt:
10:07 AM Changeset in webkit [178918] by rniwa@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

PropertyListNode::emitNode duplicates the code to put a constant property
​https://bugs.webkit.org/show_bug.cgi?id=140761

Reviewed by Geoffrey Garen.

Extracted PropertyListNode::emitPutConstantProperty to share the code.

Also made PropertyListNode::emitBytecode private since nobody is calling this function directly.

  • bytecompiler/NodesCodegen.cpp:

(JSC::PropertyListNode::emitBytecode):
(JSC::PropertyListNode::emitPutConstantProperty): Added.

  • parser/Nodes.h:
9:59 AM Changeset in webkit [178917] by ap@apple.com
  • 2 edits in trunk/Tools

LeaksViewer doesn't show recent builds if there are less than 10
​https://bugs.webkit.org/show_bug.cgi?id=140716

Reviewed by Tim Horton.

  • BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
9:21 AM Changeset in webkit [178916] by Brent Fulgham
  • 3 edits in trunk/WebKitLibraries

[Win] Unreviewed gardening.

Activate ENABLE(MOUSE_CURSOR_SCALE). This works on Windows and causes more tests to pass.

  • win/tools/vsprops/FeatureDefines.props:
  • win/tools/vsprops/FeatureDefinesCairo.props:
5:46 AM Changeset in webkit [178915] by Lucas Forschler
  • 1 edit in trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json

Fix up slave distribution for Apple bots.

5:14 AM Changeset in webkit [178914] by Lucas Forschler
  • 1 edit in trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json

Fix json.

5:12 AM Changeset in webkit [178913] by Lucas Forschler
  • 2 edits in trunk/Tools

Add Apple build slaves.
Fixed text alignment for slave list.

Unreviewed.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
4:22 AM Changeset in webkit [178912] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk/LayoutTests

AX: [ATK] Mark accessibility/list-detection.html as a suitable test for EFL and GTK.
​https://bugs.webkit.org/show_bug.cgi?id=140721

Patch by Andrzej Badowski <​a.badowski@samsung.com> on 2015-01-22
Reviewed by Chris Fleizach.

The test checks the heuristic to determine if a 'list' is really a list.
In the area of ATK a role for description list has been separated from the role AXList.
This made the test stopped giving positive results for ports EFL and GTK.
The proposed amendment restores test for these ports.

  • accessibility/list-detection.html:
  • platform/efl/TestExpectations:
  • platform/efl/accessibility/list-detection-expected.txt: Added.
  • platform/gtk/TestExpectations:
  • platform/gtk/accessibility/list-detection-expected.txt: Added.
2:35 AM WebKitGTK/Roadmap edited by Carlos Garcia Campos
(diff)
2:23 AM Changeset in webkit [178911] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Expected gutter highlight when selecting console input line, just like output line
​https://bugs.webkit.org/show_bug.cgi?id=140696

Patch by Nikita Vasilyev <Nikita Vasilyev> on 2015-01-22
Reviewed by Timothy Hatcher.

  • UserInterface/Views/LogContentView.css:
2:21 AM Changeset in webkit [178910] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebKit2

Fix build warning in WebKit2/UIProcess module
​https://bugs.webkit.org/show_bug.cgi?id=140758

Patch by Shivakumar JM <​shiva.jm@samsung.com> on 2015-01-22
Reviewed by Csaba Osztrogonác.

Fix build warnings by using UNUSED_PARAM macro

  • UIProcess/API/C/WKPageGroup.cpp:

(WKPageGroupAddUserContentFilter):
(WKPageGroupRemoveAllUserContentFilters):

2:18 AM WebKitGTK/Roadmap edited by Carlos Garcia Campos
(diff)
2:09 AM Changeset in webkit [178909] by matthew_hanson@apple.com
  • 2 edits in branches/safari-600.5-branch/Source/JavaScriptCore

Merge r174381. rdar://problem/19450841

2:08 AM Changeset in webkit [178908] by matthew_hanson@apple.com
  • 2 edits in branches/safari-600.5-branch/Source/WTF

Merge r174377. rdar://problem/19451247

2:08 AM Changeset in webkit [178907] by matthew_hanson@apple.com
  • 8 edits in branches/safari-600.5-branch/Source/JavaScriptCore

Merge r174371. rdar://problem/19450845

2:08 AM Changeset in webkit [178906] by matthew_hanson@apple.com
  • 3 edits in branches/safari-600.5-branch/Source/WebCore

Merge r174345. rdar://problem/19451258

2:08 AM Changeset in webkit [178905] by matthew_hanson@apple.com
  • 3 edits in branches/safari-600.5-branch/Source/WebCore

Merge r173790. rdar://problem/19451354

2:04 AM WebKitGTK/Roadmap edited by philn@igalia.com
(diff)
1:32 AM Changeset in webkit [178904] by matthew_hanson@apple.com
  • 3 edits
    2 adds in branches/safari-600.5-branch

Merge r173688. rdar://problem/19451277

1:31 AM Changeset in webkit [178903] by matthew_hanson@apple.com
  • 4 edits
    32 adds in branches/safari-600.5-branch

Merge r172797. rdar://problem/19451324

1:31 AM Changeset in webkit [178902] by matthew_hanson@apple.com
  • 2 edits in branches/safari-600.5-branch/Source/WebKit

Merge r172509. rdar://problem/19451367

1:31 AM Changeset in webkit [178901] by matthew_hanson@apple.com
  • 6 edits
    2 adds in branches/safari-600.5-branch

Merge r172504. rdar://problem/19451367

1:31 AM Changeset in webkit [178900] by matthew_hanson@apple.com
  • 3 edits
    2 adds in branches/safari-600.5-branch

Merge r172326. rdar://problem/19452126

1:11 AM Changeset in webkit [178899] by matthew_hanson@apple.com
  • 2 edits in branches/safari-600.5-branch/Source/WebCore

Merge r171404. rdar://problem/19451349

1:11 AM Changeset in webkit [178898] by matthew_hanson@apple.com
  • 2 edits in branches/safari-600.5-branch/Source/WebCore

Merge r171392. rdar://problem/19451349

1:11 AM Changeset in webkit [178897] by matthew_hanson@apple.com
  • 2 edits in branches/safari-600.5-branch/Source/WebCore

Merge r171388. rdar://problem/19451349

1:11 AM Changeset in webkit [178896] by matthew_hanson@apple.com
  • 2 edits in branches/safari-600.5-branch/Source/WebCore

Merge r171385. rdar://problem/19451349

12:56 AM Changeset in webkit [178895] by svillar@igalia.com
  • 4 edits
    2 adds in trunk

[CSS Grid Layout] Skip items spanning flex tracks when sizing content based tracks
​https://bugs.webkit.org/show_bug.cgi?id=140720

Reviewed by David Hyatt.

Source/WebCore:

Section "11.5. Resolve Intrinsic Track Sizes" of the specs forces
us to ignore items spanning tracks with flex sizing functions when
resolving the content-based track sizing functions. Items with
span < 2 are not affected by this rule (as they will belong to a
single track). This way the algorithm ensures that min-content and
max-content restrictions are fulfilled before distributing the
extra space.

Test: fast/css-grid-layout/flex-and-content-sized-resolution-columns.html

  • rendering/RenderGrid.cpp:

(WebCore::RenderGrid::spanningItemCrossesFlexibleSizedTracks):
(WebCore::integerSpanForDirection):
(WebCore::RenderGrid::resolveContentBasedTrackSizingFunctions):

  • rendering/RenderGrid.h:

LayoutTests:

  • fast/css-grid-layout/flex-and-content-sized-resolution-columns-expected.txt: Added.
  • fast/css-grid-layout/flex-and-content-sized-resolution-columns.html: Added.
12:54 AM Changeset in webkit [178894] by Yusuke Suzuki
  • 31 edits
    3 adds in trunk

put_by_val_direct need to check the property is index or not for using putDirect / putDirectIndex
​https://bugs.webkit.org/show_bug.cgi?id=140426

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

In the put_by_val_direct operation, we use JSObject::putDirect.
However, it only accepts non-index property. For index property, we need to use JSObject::putDirectIndex.
This patch changes Identifier::asIndex() to return Optional<uint32_t>.
It forces callers to check the value is index or not explicitly.
Additionally, it checks toString-ed Identifier is index or not to choose putDirect / putDirectIndex.

  • bytecode/GetByIdStatus.cpp:

(JSC::GetByIdStatus::computeFor):

  • bytecode/PutByIdStatus.cpp:

(JSC::PutByIdStatus::computeFor):

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitDirectPutById):

  • dfg/DFGOperations.cpp:

(JSC::DFG::operationPutByValInternal):

  • jit/JITOperations.cpp:
  • jit/Repatch.cpp:

(JSC::emitPutTransitionStubAndGetOldStructure):

  • jsc.cpp:
  • llint/LLIntSlowPaths.cpp:

(JSC::LLInt::LLINT_SLOW_PATH_DECL):

  • runtime/Arguments.cpp:

(JSC::Arguments::getOwnPropertySlot):
(JSC::Arguments::put):
(JSC::Arguments::deleteProperty):
(JSC::Arguments::defineOwnProperty):

  • runtime/ArrayPrototype.cpp:

(JSC::arrayProtoFuncSort):

  • runtime/JSArray.cpp:

(JSC::JSArray::defineOwnProperty):

  • runtime/JSCJSValue.cpp:

(JSC::JSValue::putToPrimitive):

  • runtime/JSGenericTypedArrayViewInlines.h:

(JSC::JSGenericTypedArrayView<Adaptor>::getOwnPropertySlot):
(JSC::JSGenericTypedArrayView<Adaptor>::put):
(JSC::JSGenericTypedArrayView<Adaptor>::defineOwnProperty):
(JSC::JSGenericTypedArrayView<Adaptor>::deleteProperty):

  • runtime/JSObject.cpp:

(JSC::JSObject::put):
(JSC::JSObject::putDirectAccessor):
(JSC::JSObject::putDirectCustomAccessor):
(JSC::JSObject::deleteProperty):
(JSC::JSObject::putDirectMayBeIndex):
(JSC::JSObject::defineOwnProperty):

  • runtime/JSObject.h:

(JSC::JSObject::getOwnPropertySlot):
(JSC::JSObject::getPropertySlot):
(JSC::JSObject::putDirectInternal):

  • runtime/JSString.cpp:

(JSC::JSString::getStringPropertyDescriptor):

  • runtime/JSString.h:

(JSC::JSString::getStringPropertySlot):

  • runtime/LiteralParser.cpp:

(JSC::LiteralParser<CharType>::parse):

  • runtime/PropertyName.h:

(JSC::toUInt32FromCharacters):
(JSC::toUInt32FromStringImpl):
(JSC::PropertyName::asIndex):

  • runtime/PropertyNameArray.cpp:

(JSC::PropertyNameArray::add):

  • runtime/StringObject.cpp:

(JSC::StringObject::deleteProperty):

  • runtime/Structure.cpp:

(JSC::Structure::prototypeChainMayInterceptStoreTo):

Source/WebCore:

Test: js/dfg-put-by-val-direct-with-edge-numbers.html

  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::getOwnPropertySlot):

  • bindings/js/JSHTMLAllCollectionCustom.cpp:

(WebCore::callHTMLAllCollection):
(WebCore::JSHTMLAllCollection::item):

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateGetOwnPropertySlotBody):
(GenerateImplementation):

  • bindings/scripts/test/JS/JSFloat64Array.cpp:

(WebCore::JSFloat64Array::getOwnPropertySlot):
(WebCore::JSFloat64Array::getOwnPropertyDescriptor):
(WebCore::JSFloat64Array::put):

  • bindings/scripts/test/JS/JSTestEventTarget.cpp:

(WebCore::JSTestEventTarget::getOwnPropertySlot):

  • bridge/runtime_array.cpp:

(JSC::RuntimeArray::getOwnPropertySlot):
(JSC::RuntimeArray::put):

LayoutTests:

  • js/dfg-put-by-val-direct-with-edge-numbers-expected.txt: Added.
  • js/dfg-put-by-val-direct-with-edge-numbers.html: Added.
  • js/script-tests/dfg-put-by-val-direct-with-edge-numbers.js: Added.

(lookupWithKey):
(dfgShouldThrow):
(lookupWithKey2):
(toStringThrowsError.toString):

12:36 AM Changeset in webkit [178893] by svillar@igalia.com
  • 6 edits in trunk

[CSS Grid Layout] Size tracks using a list of all items sorted by span
​https://bugs.webkit.org/show_bug.cgi?id=140615

Reviewed by Andreas Kling.

Source/WebCore:

In r173620 we fixed
RenderGrid::resolveContentBasedTrackSizingFunctions() so that it
now collects all items spanning content-sized tracks and process
them one by one after sorting them by ascending span.

The problem is that it was incorrectly implemented, it has two
important bugs. First one is that the hash table that collects
items is regenerated after processing each track, so it's actually
doing nothing. Secondly we're only sorting the items on each
track, instead of all the items in the grid.

  • rendering/RenderGrid.cpp:

(WebCore::RenderGrid::resolveContentBasedTrackSizingFunctions):

LayoutTests:

  • fast/css-grid-layout/grid-content-sized-columns-resolution-expected.txt:

Added tons of new test cases.

  • fast/css-grid-layout/grid-content-sized-columns-resolution.html: Ditto.
  • fast/css-grid-layout/grid-preferred-logical-widths.html:

Adjusted results.

12:30 AM Changeset in webkit [178892] by Carlos Garcia Campos
  • 11 edits in trunk/Source/WebKit2

[GTK] Use API::ContextMenuClient and API::InjectedBundle::PageContextMenuClient classes
​https://bugs.webkit.org/show_bug.cgi?id=138467

Reviewed by Gustavo Noronha Silva.

  • UIProcess/API/gtk/WebKitContextMenu.cpp:

(webkitContextMenuPopulate): Add a version that receives a Vector<WebContextMenuItemData>&.
(webkitContextMenuCreate): Change it to receive a const
Vector<WebContextMenuItemData>& instead of a API::Array* and also
add a another version that receives const Vector<ContextMenuItem>&.

  • UIProcess/API/gtk/WebKitContextMenuClient.cpp:

(attachContextMenuClientToView): Use a class derived from
API::ContextMenuClient to implement the context menu client.
(getContextMenuFromProposedMenu): Deleted.

  • UIProcess/API/gtk/WebKitContextMenuItem.cpp:

(webkitContextMenuItemCreate): Change it to receive a const
WebContextMenuItemData& and added another version that receives a
const ContextMenuItem&.

  • UIProcess/API/gtk/WebKitContextMenuItemPrivate.h:
  • UIProcess/API/gtk/WebKitContextMenuPrivate.h:
  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkitWebViewPopulateContextMenu): Remove the creation of a
WebHitTestResult::Data, since it receives it now as parameter.

  • UIProcess/API/gtk/WebKitWebViewPrivate.h:
  • WebProcess/InjectedBundle/API/gtk/WebKitWebHitTestResult.cpp:

(webkitWebHitTestResultCreate): Change it to receive a const
HitTestResult& instead of const InjectedBundleHitTestResult&.

  • WebProcess/InjectedBundle/API/gtk/WebKitWebHitTestResultPrivate.h:
  • WebProcess/InjectedBundle/API/gtk/WebKitWebPage.cpp:

(webkitWebPageCreate): Use a class derived from
API::InjectedBundle::PageContextMenuClient to implement the
context menu client.
(getContextMenuFromDefaultMenu): Deleted.

12:05 AM Changeset in webkit [178891] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit2

Unreviewed. Try to fix Debug build after r178889.

  • UIProcess/API/C/WKPage.cpp: Include Logging.h.
12:02 AM Changeset in webkit [178890] by matthew_hanson@apple.com
  • 3 edits in branches/safari-600.5-branch/Source/WebCore

Merge r171357. rdar://problem/19451349

Note: See TracTimeline for information about the timeline view.