Context Navigation

← Previous Period
Next Period →

Timeline

Jan 24, 2015:

11:35 PM Changeset in webkit [179084] by Brent Fulgham

16 edits
13 adds in trunk/LayoutTests

[Win] More rebaselines. (Tables)

platform/win/tables/mozilla/bugs/bug1188-expected.png: Added.
platform/win/tables/mozilla/bugs/bug1188-expected.txt:
platform/win/tables/mozilla/bugs/bug18359-expected.png: Added.
platform/win/tables/mozilla/bugs/bug18359-expected.txt:
platform/win/tables/mozilla/bugs/bug2479-3-expected.png: Added.
platform/win/tables/mozilla/bugs/bug2479-3-expected.txt:
platform/win/tables/mozilla/bugs/bug2479-4-expected.png: Added.
platform/win/tables/mozilla/bugs/bug2479-4-expected.txt:
platform/win/tables/mozilla/bugs/bug29326-expected.png: Added.
platform/win/tables/mozilla/bugs/bug29326-expected.txt:
platform/win/tables/mozilla/bugs/bug33855-expected.png: Added.
platform/win/tables/mozilla/bugs/bug33855-expected.txt:
platform/win/tables/mozilla/bugs/bug4382-expected.png: Added.
platform/win/tables/mozilla/bugs/bug4382-expected.txt:
platform/win/tables/mozilla/bugs/bug4527-expected.txt:
platform/win/tables/mozilla/bugs/bug96334-expected.png: Added.
platform/win/tables/mozilla/bugs/bug96334-expected.txt:
platform/win/tables/mozilla/core/margins-expected.png: Added.
platform/win/tables/mozilla/core/margins-expected.txt:
platform/win/tables/mozilla/dom/tableDom-expected.png: Added.
platform/win/tables/mozilla/dom/tableDom-expected.txt:
platform/win/tables/mozilla/other/move_row-expected.txt:
platform/win/tables/mozilla_expected_failures/bugs/bug2479-5-expected.png: Added.
platform/win/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:
platform/win/tables/mozilla_expected_failures/core/captions1-expected.png: Added.
platform/win/tables/mozilla_expected_failures/core/captions1-expected.txt:
platform/win/tables/mozilla_expected_failures/core/captions2-expected.png: Added.
platform/win/tables/mozilla_expected_failures/core/captions2-expected.txt:

11:14 PM Changeset in webkit [179083] by Brent Fulgham

67 edits
43 adds in trunk/LayoutTests

[Win] Unreviewed rebaselining.

Second batch: Fast

platform/win/fast/block/float/float-avoidance-expected.png: Added.
platform/win/fast/block/margin-collapse/103-expected.png: Added.
platform/win/fast/canvas/fallback-content-expected.txt:
platform/win/fast/css/non-standard-checkbox-size-expected.png: Added.
platform/win/fast/css/non-standard-checkbox-size-expected.txt:
platform/win/fast/dom/HTMLInputElement/input-slider-update-expected.txt:
platform/win/fast/forms/001-expected.png:
platform/win/fast/forms/001-expected.txt:
platform/win/fast/forms/003-expected.png: Added.
platform/win/fast/forms/003-expected.txt:
platform/win/fast/forms/004-expected.png: Added.
platform/win/fast/forms/004-expected.txt:
platform/win/fast/forms/HTMLOptionElement_label01-expected.png: Added.
platform/win/fast/forms/HTMLOptionElement_label01-expected.txt:
platform/win/fast/forms/HTMLOptionElement_label02-expected.png: Added.
platform/win/fast/forms/HTMLOptionElement_label02-expected.txt:
platform/win/fast/forms/HTMLOptionElement_label03-expected.png: Added.
platform/win/fast/forms/HTMLOptionElement_label03-expected.txt:
platform/win/fast/forms/HTMLOptionElement_label04-expected.png: Added.
platform/win/fast/forms/HTMLOptionElement_label04-expected.txt:
platform/win/fast/forms/HTMLOptionElement_label06-expected.txt:
platform/win/fast/forms/HTMLOptionElement_label07-expected.txt:
platform/win/fast/forms/basic-inputs-expected.png:
platform/win/fast/forms/basic-inputs-expected.txt:
platform/win/fast/forms/basic-selects-expected.png:
platform/win/fast/forms/basic-selects-expected.txt:
platform/win/fast/forms/basic-textareas-quirks-expected.png: Added.
platform/win/fast/forms/box-shadow-override-expected.png:
platform/win/fast/forms/box-shadow-override-expected.txt:
platform/win/fast/forms/control-clip-overflow-expected.png: Added.
platform/win/fast/forms/control-clip-overflow-expected.txt:
platform/win/fast/forms/control-restrict-line-height-expected.png: Added.
platform/win/fast/forms/control-restrict-line-height-expected.txt:
platform/win/fast/forms/disabled-select-change-index-expected.png: Added.
platform/win/fast/forms/disabled-select-change-index-expected.txt:
platform/win/fast/forms/file/file-input-disabled-expected.png:
platform/win/fast/forms/file/file-input-disabled-expected.txt:
platform/win/fast/forms/form-element-geometry-expected.png: Added.
platform/win/fast/forms/form-element-geometry-expected.txt:
platform/win/fast/forms/formmove-expected.png: Added.
platform/win/fast/forms/formmove-expected.txt:
platform/win/fast/forms/indeterminate-expected.png: Added.
platform/win/fast/forms/indeterminate-expected.txt:
platform/win/fast/forms/input-appearance-height-expected.png: Added.
platform/win/fast/forms/input-appearance-height-expected.txt:
platform/win/fast/forms/input-appearance-selection-expected.png: Added.
platform/win/fast/forms/input-appearance-selection-expected.txt: Added.
platform/win/fast/forms/menulist-deselect-update-expected.txt:
platform/win/fast/forms/menulist-no-overflow-expected.png: Added.
platform/win/fast/forms/menulist-no-overflow-expected.txt:
platform/win/fast/forms/menulist-restrict-line-height-expected.png: Added.
platform/win/fast/forms/menulist-restrict-line-height-expected.txt:
platform/win/fast/forms/menulist-separator-painting-expected.txt:
platform/win/fast/forms/menulist-style-color-expected.png:
platform/win/fast/forms/menulist-style-color-expected.txt:
platform/win/fast/forms/menulist-width-change-expected.txt:
platform/win/fast/forms/option-script-expected.txt:
platform/win/fast/forms/option-strip-whitespace-expected.png: Added.
platform/win/fast/forms/option-strip-whitespace-expected.txt:
platform/win/fast/forms/option-text-clip-expected.png:
platform/win/fast/forms/option-text-clip-expected.txt:
platform/win/fast/forms/range/input-appearance-range-expected.png: Added.
platform/win/fast/forms/range/input-appearance-range-expected.txt:
platform/win/fast/forms/range/slider-delete-while-dragging-thumb-expected.txt: Added.
platform/win/fast/forms/range/slider-mouse-events-expected.txt:
platform/win/fast/forms/range/slider-onchange-event-expected.txt: Added.
platform/win/fast/forms/range/slider-padding-expected.txt:
platform/win/fast/forms/range/slider-thumb-shared-style-expected.png: Added.
platform/win/fast/forms/range/slider-thumb-shared-style-expected.txt:
platform/win/fast/forms/range/slider-zoomed-expected.txt: Added.
platform/win/fast/forms/select-align-expected.png: Added.
platform/win/fast/forms/select-align-expected.txt:
platform/win/fast/forms/select-background-none-expected.txt:
platform/win/fast/forms/select-baseline-expected.png: Added.
platform/win/fast/forms/select-baseline-expected.txt:
platform/win/fast/forms/select-change-listbox-to-popup-expected.png: Added.
platform/win/fast/forms/select-change-listbox-to-popup-expected.txt:
platform/win/fast/forms/select-change-popup-to-listbox-expected.png: Added.
platform/win/fast/forms/select-change-popup-to-listbox-expected.txt: Added.
platform/win/fast/forms/select-disabled-appearance-expected.png: Added.
platform/win/fast/forms/select-disabled-appearance-expected.txt:
platform/win/fast/forms/select-initial-position-expected.png: Added.
platform/win/fast/forms/select-initial-position-expected.txt:
platform/win/fast/forms/select-selected-expected.png: Added.
platform/win/fast/forms/select-selected-expected.txt:
platform/win/fast/forms/select-size-expected.txt:
platform/win/fast/forms/select-style-expected.png: Added.
platform/win/fast/forms/select-style-expected.txt:
platform/win/fast/forms/select-visual-hebrew-expected.txt:
platform/win/fast/forms/select-writing-direction-natural-expected.png:
platform/win/fast/forms/select-writing-direction-natural-expected.txt:
platform/win/fast/forms/select/optgroup-rendering-expected.png:
platform/win/fast/forms/select/optgroup-rendering-expected.txt:
platform/win/fast/forms/selectlist-minsize-expected.txt:
platform/win/fast/forms/stuff-on-my-optgroup-expected.png: Added.
platform/win/fast/forms/stuff-on-my-optgroup-expected.txt:
platform/win/fast/invalid: Added.
platform/win/fast/invalid/014-expected.txt: Added.
platform/win/fast/multicol/pagination/RightToLeft-rl-hittest-expected.txt:
platform/win/fast/parser: Added.
platform/win/fast/parser/entity-comment-in-textarea-expected.txt: Added.
platform/win/fast/parser/open-comment-in-textarea-expected.txt: Added.
platform/win/fast/repaint/slider-thumb-drag-release-expected.txt:
platform/win/fast/replaced/three-selects-break-expected.txt:
platform/win/fast/text/international/bidi-menulist-expected.txt:
platform/win/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt:
platform/win/fast/text/textIteratorNilRenderer-expected.txt:

9:46 PM Changeset in webkit [179082] by Brent Fulgham

22 edits in trunk/LayoutTests

[Win] Unreviewed baseline update.

First batch: CSS updates.

platform/win/css2.1/t09-c5526c-display-00-e-expected.txt:
platform/win/css3/selectors3/html/css3-modsel-161-expected.png:
platform/win/css3/selectors3/html/css3-modsel-161-expected.txt:
platform/win/css3/selectors3/html/css3-modsel-25-expected.png:
platform/win/css3/selectors3/html/css3-modsel-25-expected.txt:
platform/win/css3/selectors3/html/css3-modsel-70-expected.png:
platform/win/css3/selectors3/html/css3-modsel-70-expected.txt:
platform/win/css3/selectors3/xhtml/css3-modsel-161-expected.png:
platform/win/css3/selectors3/xhtml/css3-modsel-161-expected.txt:
platform/win/css3/selectors3/xhtml/css3-modsel-25-expected.png:
platform/win/css3/selectors3/xhtml/css3-modsel-25-expected.txt:
platform/win/css3/selectors3/xhtml/css3-modsel-70-expected.png:
platform/win/css3/selectors3/xhtml/css3-modsel-70-expected.txt:
platform/win/css3/selectors3/xml/css3-modsel-161-expected.png:
platform/win/css3/selectors3/xml/css3-modsel-161-expected.txt:
platform/win/css3/selectors3/xml/css3-modsel-25-expected.png:
platform/win/css3/selectors3/xml/css3-modsel-25-expected.txt:
platform/win/css3/selectors3/xml/css3-modsel-70-expected.png:
platform/win/css3/selectors3/xml/css3-modsel-70-expected.txt:
platform/win/fast/block/float/float-avoidance-expected.txt:
platform/win/fast/block/margin-collapse/103-expected.txt:

8:36 PM Changeset in webkit [179081] by mitz@apple.com

2 edits in trunk/Tools

update-webkit’s --internal option is unused
https://bugs.webkit.org/show_bug.cgi?id=140861

Reviewed by Anders Carlsson.

Scripts/update-webkit: Removed the option.

7:02 PM Changeset in webkit [179080] by Chris Dumez

2 edits in trunk/Source/WebKit2

[WK2][Cocoa] Drop WKDiagnosticLoggingResultType defines
https://bugs.webkit.org/show_bug.cgi?id=140838

Reviewed by Sam Weinig.

Drop WKDiagnosticLoggingResultType defines in _WKDiagnosticLoggingDelegate.h
header now that the client-side is correctly using
_WKDiagnosticLoggingResultType instead.

UIProcess/API/Cocoa/_WKDiagnosticLoggingDelegate.h:

6:55 PM Changeset in webkit [179079] by Brent Fulgham

26 edits
81 adds in trunk/LayoutTests

[Win] Unreviewed gardening. Reactivating tests.

Re-enable a series of tests that work properly on Windows. New baselines will be needed.

platform/win/TestExpectations:
platform/win/css1/box_properties/acid_test-expected.png: Added.
platform/win/css1/box_properties/acid_test-expected.txt:
platform/win/editing/input/caret-at-the-edge-of-input-expected.txt:
platform/win/fast/block/float/float-avoidance-expected.txt:
platform/win/fast/block/margin-collapse/103-expected.txt:
platform/win/fast/css/box-shadow-and-border-radius-expected.png:
platform/win/fast/dynamic/008-expected.txt: Added.
platform/win/fast/forms/001-expected.png: Added.
platform/win/fast/forms/001-expected.txt:
platform/win/fast/forms/003-expected.txt:
platform/win/fast/forms/004-expected.txt:
platform/win/fast/forms/006-expected.png: Added.
platform/win/fast/forms/007-expected.png: Added.
platform/win/fast/forms/HTMLOptionElement_label01-expected.txt: Added.
platform/win/fast/forms/HTMLOptionElement_label02-expected.txt: Added.
platform/win/fast/forms/HTMLOptionElement_label03-expected.txt: Added.
platform/win/fast/forms/HTMLOptionElement_label04-expected.txt: Added.
platform/win/fast/forms/HTMLOptionElement_label05-expected.txt: Added.
platform/win/fast/forms/HTMLOptionElement_label06-expected.txt: Removed property svn:executable.
platform/win/fast/forms/HTMLOptionElement_label07-expected.txt: Added.
platform/win/fast/forms/basic-buttons-expected.png: Added.
platform/win/fast/forms/basic-buttons-expected.txt: Added.
platform/win/fast/forms/basic-inputs-expected.png: Added.
platform/win/fast/forms/basic-selects-expected.txt:
platform/win/fast/forms/basic-textareas-expected.png: Added.
platform/win/fast/forms/box-shadow-override-expected.png: Added.
platform/win/fast/forms/box-shadow-override-expected.txt: Added.
platform/win/fast/forms/button-positioned-expected.txt: Added.
platform/win/fast/forms/button-sizes-expected.txt: Added.
platform/win/fast/forms/button-style-color-expected.txt: Added.
platform/win/fast/forms/button-text-transform-expected.txt: Added.
platform/win/fast/forms/control-clip-overflow-expected.txt: Added.
platform/win/fast/forms/control-restrict-line-height-expected.txt:
platform/win/fast/forms/disabled-select-change-index-expected.txt: Added.
platform/win/fast/forms/form-element-geometry-expected.txt: Added.
platform/win/fast/forms/hidden-listbox-expected.txt: Added.
platform/win/fast/forms/input-appearance-focus-expected.txt: Added.
platform/win/fast/forms/input-double-click-selection-gap-bug-expected.txt: Added.
platform/win/fast/forms/input-readonly-autoscroll-expected.txt: Added.
platform/win/fast/forms/input-text-double-click-expected.txt: Added.
platform/win/fast/forms/listbox-hit-test-zoomed-expected.txt: Added.
platform/win/fast/forms/listbox-scrollbar-incremental-load-expected.txt: Added.
platform/win/fast/forms/listbox-width-change-expected.txt: Added.
platform/win/fast/forms/menulist-deselect-update-expected.txt:
platform/win/fast/forms/menulist-no-overflow-expected.txt: Added.
platform/win/fast/forms/number/number-appearance-rtl-expected.txt: Added.
platform/win/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.txt: Added.
platform/win/fast/forms/number/number-appearance-spinbutton-layer-expected.txt: Added.
platform/win/fast/forms/option-strip-whitespace-expected.txt: Added.
platform/win/fast/forms/plaintext-mode-2-expected.txt: Added.
platform/win/fast/forms/search: Added.
platform/win/fast/forms/search/search-size-with-decorations-expected.txt: Added.
platform/win/fast/forms/select-align-expected.txt: Added.
platform/win/fast/forms/select-baseline-expected.txt: Added.
platform/win/fast/forms/select-block-background-expected.txt: Added.
platform/win/fast/forms/select-change-listbox-size-expected.txt: Added.
platform/win/fast/forms/select-change-listbox-to-popup-expected.txt: Added.
platform/win/fast/forms/select-dirty-parent-pref-widths-expected.txt: Added.
platform/win/fast/forms/select-disabled-appearance-expected.txt: Added.
platform/win/fast/forms/select-initial-position-expected.txt: Added.
platform/win/fast/forms/select-item-background-clip-expected.txt: Added.
platform/win/fast/forms/select-list-box-with-height-expected.txt: Added.
platform/win/fast/forms/select-selected-expected.txt: Added.
platform/win/fast/forms/select/optgroup-rendering-expected.txt:
platform/win/fast/forms/tabbing-input-iframe-expected.txt: Added.
platform/win/fast/frames: Added.
platform/win/fast/frames/take-focus-from-iframe-expected.txt: Added.
platform/win/fast/multicol/pagination: Added.
platform/win/fast/multicol/pagination/LeftToRight-tb-hittest-expected.txt: Added.
platform/win/fast/multicol/pagination/RightToLeft-rl-hittest-expected.txt: Added.
platform/win/fast/overflow/entity-comment-in-textarea-expected.txt: Added.
platform/win/fast/overflow/open-comment-in-textarea-expected.txt: Added.
platform/win/fast/overflow/overflow-x-y-expected.txt: Added.
platform/win/fast/table/003-expected.txt: Added.
platform/win/fast/table/colspanMinWidth-expected.txt: Added.
platform/win/fast/table/colspanMinWidth-vertical-expected.txt: Added.
platform/win/tables/mozilla/bugs/bug103533-expected.txt: Added.
platform/win/tables/mozilla/bugs/bug1188-expected.txt: Added.
platform/win/tables/mozilla/bugs/bug12384-expected.txt: Added.
platform/win/tables/mozilla/bugs/bug1318-expected.txt: Added.
platform/win/tables/mozilla/bugs/bug18359-expected.txt:
platform/win/tables/mozilla/bugs/bug2479-2-expected.txt: Added.
platform/win/tables/mozilla/bugs/bug26178-expected.txt:
platform/win/tables/mozilla/bugs/bug28928-expected.txt:
platform/win/tables/mozilla/bugs/bug29326-expected.txt: Added.
platform/win/tables/mozilla/bugs/bug30559-expected.txt:
platform/win/tables/mozilla/bugs/bug30692-expected.txt: Added.
platform/win/tables/mozilla/bugs/bug33855-expected.txt:
platform/win/tables/mozilla/bugs/bug4382-expected.txt: Added.
platform/win/tables/mozilla/bugs/bug4429-expected.txt:
platform/win/tables/mozilla/bugs/bug44505-expected.txt: Added.
platform/win/tables/mozilla/bugs/bug51037-expected.txt:
platform/win/tables/mozilla/bugs/bug55545-expected.txt: Added.
platform/win/tables/mozilla/bugs/bug92647-2-expected.txt: Added.
platform/win/tables/mozilla/bugs/bug96334-expected.txt: Added.
platform/win/tables/mozilla/bugs/bug99948-expected.txt: Added.
platform/win/tables/mozilla/core: Added.
platform/win/tables/mozilla/core/bloomberg-expected.txt: Added.
platform/win/tables/mozilla/core/margins-expected.txt: Added.
platform/win/tables/mozilla/dom/tableDom-expected.txt:
platform/win/tables/mozilla/marvin/x_col_align_justify-expected.png: Added.
platform/win/tables/mozilla_expected_failures/bugs/bug1725-expected.txt:
platform/win/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:
platform/win/tables/mozilla_expected_failures/bugs/bug45621-expected.txt: Added.
platform/win/tables/mozilla_expected_failures/bugs/bug58402-2-expected.txt:

5:28 PM Changeset in webkit [179078] by ddkilzer@apple.com

2 edits in branches/safari-600.1.4.15-branch/Source/WebCore

Merged r176725. rdar://problem/19432746

5:28 PM Changeset in webkit [179077] by ddkilzer@apple.com

5 edits in branches/safari-600.1.4.15-branch/Source/WebCore

Merged 'resolvedURL' changes from r176108. rdar://problem/19432746

4:54 PM Changeset in webkit [179076] by ddkilzer@apple.com

2 edits in branches/safari-600.1.4.15-branch/Source/WebCore

Merged r176475. rdar://problem/19450119

4:54 PM Changeset in webkit [179075] by ddkilzer@apple.com

2 edits in branches/safari-600.1.4.15-branch/Source/WebCore

Merged r175251. rdar://problem/19450119

4:08 PM Changeset in webkit [179074] by Brent Fulgham

2 edits in trunk/Tools

DumpRenderTree needs to run with Windows native controls on Windows
https://bugs.webkit.org/show_bug.cgi?id=25592

Reviewed by Anders Carlsson.

DumpRenderTree/win/DumpRenderTree.cpp:

(resetWebPreferencesToConsistentValues): Tell DRT to use native controls.
(prepareConsistentTestingEnvironment): Ditto.

12:36 PM Changeset in webkit [179073] by ddkilzer@apple.com

4 edits in branches/safari-600.1.4.15-branch/Source/WebKit2

Merged r176382. rdar://problem/19419810

12:30 PM Changeset in webkit [179072] by ddkilzer@apple.com

3 edits
2 adds in branches/safari-600.1.4.15-branch

Merged r176321. rdar://problem/19369495

12:16 PM Changeset in webkit [179071] by ddkilzer@apple.com

8 edits
2 adds in branches/safari-600.1.4.15-branch

Merged r176262. rdar://problem/19432679

12:16 PM Changeset in webkit [179070] by ddkilzer@apple.com

2 edits in branches/safari-600.1.4.15-branch/Source/WebCore

Merged r175260. rdar://problem/19432679

11:55 AM Changeset in webkit [179069] by Darin Adler

7 edits
6 adds in trunk

Move height/width implementation for use element from RenderSVGViewportContainer to SVGUseElement
https://bugs.webkit.org/show_bug.cgi?id=140826

Reviewed by Anders Carlsson.

Source/WebCore:

Tests: svg/animations/use-animate-width-and-height.html

svg/custom/use-attribute-invalidations.html
svg/custom/use-dynamic-attribute-setting.html

This is an adaptation of work Rob Buis did in Blink:

http://src.chromium.org/viewvc/blink?view=revision&revision=173258

The goal here is to reduce use of SVGElementInstance since we are going to
remove it. The tests Rob added to Blink (which I believe I improved a bit here)
meant we had to fix quite a few bugs in the implementation of the width/height
logic rather than just moving it. Even so, this could use even more test coverage
since there is separate logic for <symbol> and <svg>, three different code paths
(animation/attribute setting, initial creation, and one other), and also
distinct issues for attributes not set at all, attributes set to values that
can't be parsed, and attributes set with different units.

rendering/svg/RenderSVGViewportContainer.cpp:

(WebCore::RenderSVGViewportContainer::calcViewport): Removed the old logic.

svg/SVGSVGElement.cpp:

(WebCore::SVGSVGElement::SVGSVGElement): Use ASCIILiteral to more efficiently
create strings from ASCII literals here.
(WebCore::SVGSVGElement::parseAttribute): Default to 100%, not 0, when the
width or height property are either not set or not successfully parsed. Without
this change, one of the SVG tests starts failing.

svg/SVGUseElement.cpp:

(WebCore::updateWidthAndHeight): Added. The tricky part here is that we have
to copy width and height attributes only if they were successfully parsed, and
also we need to copy the current animating values, not the original attribute
strings. Kind of messy, but I wanted to adapt Rob's solution for the time being,
rather than inventing something new.
(WebCore::SVGUseElement::svgAttributeChanged): Call updateWidthAndHeight.
This is used both when actual attribute changes occur and also when animation
changes the current value.
(WebCore::SVGUseElement::buildShadowAndInstanceTree): Call updateWidthAndHeight.
This is used when the shadow elements are first created.
(WebCore::SVGUseElement::expandUseElementsInShadowTree): Call updateWidthAndHeight.
This was in Rob's patch, but I am not sure we have sufficient test coverage.

LayoutTests:

platform/mac/svg/custom/relative-sized-shadow-tree-content-with-symbol-expected.png: Old test

result was expecting failure. New one expects success.

platform/mac/svg/custom/relative-sized-shadow-tree-content-with-symbol-expected.txt: Ditto.
svg/animations/use-animate-width-and-height-expected.txt: Added.
svg/animations/use-animate-width-and-height.html: Added.
svg/custom/use-attribute-invalidations-expected.html: Added.
svg/custom/use-attribute-invalidations.html: Added.
svg/custom/use-dynamic-attribute-setting-expected.html: Added.
svg/custom/use-dynamic-attribute-setting.html: Added.

11:14 AM Changeset in webkit [179068] by ddkilzer@apple.com

3 edits in branches/safari-600.1.4.15-branch/Source/WebCore

Merged r175976. rdar://problem/19420064

10:57 AM Changeset in webkit [179067] by ddkilzer@apple.com

3 edits in branches/safari-600.1.4.15-branch/Source/WebCore

Merged r175585. rdar://problem/19419818

10:30 AM Changeset in webkit [179066] by ddkilzer@apple.com

2 edits in branches/safari-600.1.4.15-branch/Source/WebKit2

Merged small change from r175549. rdar://problem/19433134

9:27 AM Changeset in webkit [179065] by ddkilzer@apple.com

3 edits
2 adds in branches/safari-600.1.4.15-branch

Merged r174860. rdar://problem/19419859

9:00 AM Changeset in webkit [179064] by ddkilzer@apple.com

3 edits
7 adds in branches/safari-600.1.4.15-branch

Merged r175085. rdar://problem/19419853

9:00 AM Changeset in webkit [179063] by ddkilzer@apple.com

5 edits in branches/safari-600.1.4.15-branch/Source/WebCore

Merged r174356. rdar://problem/19419853

9:00 AM Changeset in webkit [179062] by ddkilzer@apple.com

3 edits in branches/safari-600.1.4.15-branch/Source/WebCore

Merged branch-only patch (r0). rdar://problem/19564738

8:28 AM Changeset in webkit [179061] by Chris Dumez

4 edits in trunk/Source

Provide implementation for WTF::DefaultHash<bool>
https://bugs.webkit.org/show_bug.cgi?id=140848

Reviewed by Anders Carlsson.

Source/WebCore:

Use HashMap<std::pair<UChar32, bool>> type in Font.cpp for
CharacterFallbackMap instead of HashMap<std::pair<UChar32, unsigned>>.
It builds now that WTF::DefaultHash<bool> is defined in WTF.

platform/graphics/Font.cpp:

(WebCore::Font::removeFromSystemFallbackCache):

Source/WTF:

Provide implementation for WTF::DefaultHash<bool> so that we can use
HashMap<std::pair<XXX, bool>> in the code base. Right now, we need to
use some integer type to work around the issue.

wtf/HashFunctions.h:

Jan 23, 2015:

11:05 PM Changeset in webkit [179060] by Brent Fulgham

1 edit
1 add in trunk/LayoutTests

[Win] Unreviewed gardening. Add Windows baseline for
mouse-cursor-image-set.

platform/win/fast/events/mouse-cursor-image-set-expected.txt: Added.

11:04 PM Changeset in webkit [179059] by Brent Fulgham

2 edits in trunk/Source/WebCore

[Win] Cursor assignment operator is skipping scale factor
https://bugs.webkit.org/show_bug.cgi?id=140852

Reviewed by Chris Dumez.

Found by fast/events/mouse-cursor-image-set.html

platform/win/CursorWin.cpp:

(WebCore::Cursor::operator=): Make sure to also assign the
scale factor.

9:36 PM Changeset in webkit [179058] by ddkilzer@apple.com

2 edits in trunk/Source/WebCore

[iOS] Attempt to fix the build after AVValueTiming.h moved

platform/spi/ios/AVKitSPI.h: The AVValueTiming.h header moved

to an unexpected location, so work around it by using local SPI
declarations.

9:33 PM Changeset in webkit [179057] by ap@apple.com

2 edits in trunk/Source/WebCore

Try to fix the build after r179056.

platform/Cursor.h: (WebCore::Cursor::Cursor): Initialize dadat members in correct order.

9:26 PM Changeset in webkit [179056] by Brent Fulgham

3 edits in trunk/Source/WebCore

[Win] Cursor copy constructor does not initialize scale factor
https://bugs.webkit.org/show_bug.cgi?id=140849

Reviewed by Antti Koivisto.

Found by fast/events/mouse-cursor-image-set.html

Make sure the scale factor is captured during copy construction. Also make sure
it is properly initialized in the default constructor, since it it used in the
Windows port for some default cursors.

platform/CursorWin.h:
platform/win/CursorWin.cpp:

(WebCore::Cursor::Cursor): Make sure copy constructor captures
the scale factor.

8:15 PM Changeset in webkit [179055] by benjamin@webkit.org

10 edits
42 adds in trunk

Add pointer/hover media queries
https://bugs.webkit.org/show_bug.cgi?id=134822

Patch by Benjamin Poulain <bpoulain@apple.com> on 2015-01-23
Reviewed by Antti Koivisto.

Source/WebCore:

Media Queries Level 4 introduces two types of Interaction Media Features:
"pointer" and "hover". Those media features are useful for adapting the design
to the type of input:

http://dev.w3.org/csswg/mediaqueries-4/#mf-interaction

This implementation is trivial: just #ifdef the return value depending on
the support for touch events.
In the future we should move that to a client interface but let's start easy
for now.

Tests: fast/media/mq-any-hover-cssom.html

fast/media/mq-any-hover-invalid.html
fast/media/mq-any-hover-matchMedia.html
fast/media/mq-any-hover-styling.html
fast/media/mq-any-pointer-cssom.html
fast/media/mq-any-pointer-invalid.html
fast/media/mq-any-pointer-matchMedia.html
fast/media/mq-any-pointer-styling.html
fast/media/mq-hover-cssom.html
fast/media/mq-hover-invalid.html
fast/media/mq-hover-matchMedia.html
fast/media/mq-hover-styling.html
fast/media/mq-pointer-cssom.html
fast/media/mq-pointer-invalid.html
fast/media/mq-pointer-matchMedia.html
fast/media/mq-pointer-styling.html

css/CSSValueKeywords.in:
css/MediaFeatureNames.h:
css/MediaQueryEvaluator.cpp:

(WebCore::hoverMediaFeatureEval):
(WebCore::any_hoverMediaFeatureEval):
(WebCore::pointerMediaFeatureEval):
(WebCore::any_pointerMediaFeatureEval):
(WebCore::leastCapablePrimaryPointerDeviceType): Deleted.

css/MediaQueryExp.cpp:

(WebCore::featureWithCSSValueID):
(WebCore::featureWithZeroOrOne):
(WebCore::featureWithoutValue):

page/EventHandler.cpp:

(WebCore::EventHandler::dispatchFakeMouseMoveEventSoon):
(WebCore::EventHandler::fakeMouseMoveEventTimerFired):

page/Settings.in:

LayoutTests:

fast/media/mq-any-hover-cssom-expected.txt: Added.
fast/media/mq-any-hover-cssom.html: Added.
fast/media/mq-any-hover-invalid-expected.txt: Added.
fast/media/mq-any-hover-invalid.html: Added.
fast/media/mq-any-hover-matchMedia-expected.txt: Added.
fast/media/mq-any-hover-matchMedia.html: Added.
fast/media/mq-any-hover-styling-expected.txt: Added.
fast/media/mq-any-hover-styling.html: Added.
fast/media/mq-any-pointer-cssom-expected.txt: Added.
fast/media/mq-any-pointer-cssom.html: Added.
fast/media/mq-any-pointer-invalid-expected.txt: Added.
fast/media/mq-any-pointer-invalid.html: Added.
fast/media/mq-any-pointer-matchMedia-expected.txt: Added.
fast/media/mq-any-pointer-matchMedia.html: Added.
fast/media/mq-any-pointer-styling-expected.txt: Added.
fast/media/mq-any-pointer-styling.html: Added.
fast/media/mq-hover-cssom-expected.txt: Added.
fast/media/mq-hover-cssom.html: Added.
fast/media/mq-hover-invalid-expected.txt: Added.
fast/media/mq-hover-invalid.html: Added.
fast/media/mq-hover-matchMedia-expected.txt: Added.
fast/media/mq-hover-matchMedia.html: Added.
fast/media/mq-hover-styling-expected.txt: Added.
fast/media/mq-hover-styling.html: Added.
fast/media/mq-pointer-cssom-expected.txt: Added.
fast/media/mq-pointer-cssom.html: Added.
fast/media/mq-pointer-expected.txt:
fast/media/mq-pointer-invalid-expected.txt: Added.
fast/media/mq-pointer-invalid.html: Added.
fast/media/mq-pointer-matchMedia-expected.txt: Added.
fast/media/mq-pointer-matchMedia.html: Added.
fast/media/mq-pointer-styling-expected.txt: Added.
fast/media/mq-pointer-styling.html: Added.
fast/media/mq-pointer.html:
platform/ios-simulator/fast/media/mq-any-hover-matchMedia-expected.txt: Added.
platform/ios-simulator/fast/media/mq-any-hover-styling-expected.txt: Added.
platform/ios-simulator/fast/media/mq-any-pointer-matchMedia-expected.txt: Added.
platform/ios-simulator/fast/media/mq-any-pointer-styling-expected.txt: Added.
platform/ios-simulator/fast/media/mq-hover-matchMedia-expected.txt: Added.
platform/ios-simulator/fast/media/mq-hover-styling-expected.txt: Added.
platform/ios-simulator/fast/media/mq-pointer-expected.txt: Added.
platform/ios-simulator/fast/media/mq-pointer-matchMedia-expected.txt: Added.
platform/ios-simulator/fast/media/mq-pointer-styling-expected.txt: Added.

7:05 PM Changeset in webkit [179054] by commit-queue@webkit.org

20 edits
6 deletes in trunk

Unreviewed, rolling out r179051.
https://bugs.webkit.org/show_bug.cgi?id=140850

broke the 32-bit build (Requested by thorton on #webkit).

Reverted changeset:

"[Mac][EME] Support ClearKey encryption with AES128-encrypted
HLS"
https://bugs.webkit.org/show_bug.cgi?id=140825
http://trac.webkit.org/changeset/179051

6:34 PM Changeset in webkit [179053] by commit-queue@webkit.org

9 edits in trunk/Source

Web Inspector: Rename InjectedScriptHost::type to subtype
https://bugs.webkit.org/show_bug.cgi?id=140841

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-01-23
Reviewed by Timothy Hatcher.

Source/JavaScriptCore:

We were using this to set the subtype of an "object" type RemoteObject
so we should clean up the name and call it subtype.

inspector/InjectedScriptHost.h:
inspector/InjectedScriptSource.js:
inspector/JSInjectedScriptHost.cpp:

(Inspector::JSInjectedScriptHost::subtype):
(Inspector::JSInjectedScriptHost::type): Deleted.

inspector/JSInjectedScriptHost.h:
inspector/JSInjectedScriptHostPrototype.cpp:

(Inspector::JSInjectedScriptHostPrototype::finishCreation):
(Inspector::jsInjectedScriptHostPrototypeFunctionSubtype):
(Inspector::jsInjectedScriptHostPrototypeFunctionType): Deleted.

Source/WebCore:

inspector/WebInjectedScriptHost.cpp:

(WebCore::WebInjectedScriptHost::subtype):
(WebCore::WebInjectedScriptHost::type): Deleted.

inspector/WebInjectedScriptHost.h:

6:27 PM Changeset in webkit [179052] by Antti Koivisto

3 edits in trunk/Source/WebKit2

Implement cache size limit
https://bugs.webkit.org/show_bug.cgi?id=140844

Reviewed by Andreas Kling.

Prevent the cache from growing without bounds. The simple scheme implemented here
estimates the cache size from number of entries. When the estimated size exceeds
the maximum size we randomly clear 1/4 of the entries.

NetworkProcess/cache/NetworkCacheStorage.h:
NetworkProcess/cache/NetworkCacheStorageCocoa.mm:

(WebKit::NetworkCacheStorage::NetworkCacheStorage):
(WebKit::NetworkCacheStorage::initialize):
(WebKit::NetworkCacheStorage::removeEntry):
(WebKit::NetworkCacheStorage::store):
(WebKit::NetworkCacheStorage::setMaximumSize):
(WebKit::NetworkCacheStorage::clear):
(WebKit::NetworkCacheStorage::shrinkIfNeeded):
(WebKit::NetworkCacheStorage::initializeKeyFilter): Deleted.

6:20 PM Changeset in webkit [179051] by jer.noble@apple.com

20 edits
3 copies
10 adds in trunk

[Mac][EME] Support ClearKey encryption with AES128-encrypted HLS
https://bugs.webkit.org/show_bug.cgi?id=140825

Reviewed by Eric Carlson.

Source/WebCore:

Test: http/tests/media/clearkey/clear-key-hls-aes128.html

Add support for ClearKey encryption when used with an AES-128 encrypted HLS stream.

Modules/encryptedmedia/CDM.cpp:

(WebCore::installedCDMFactories): Add the CDMPrivateClearKey factory.

Modules/encryptedmedia/CDMPrivateClearKey.cpp:

(WebCore::CDMPrivateClearKey::supportsKeySystem): Support the "org.w3c.clearkey" key system.
(WebCore::CDMPrivateClearKey::supportsKeySystemAndMimeType): Ditto.
(WebCore::CDMPrivateClearKey::supportsMIMEType): Ditto.
(WebCore::CDMPrivateClearKey::createSession): Create a CDMSessionClearKey.

Modules/encryptedmedia/CDMPrivateClearKey.h:

(WebCore::CDMPrivateClearKey::create): Simple factory.
(WebCore::CDMPrivateClearKey::~CDMPrivateClearKey): Virtual destructor.
(WebCore::CDMPrivateClearKey::CDMPrivateClearKey): Simple destructor.

Modules/encryptedmedia/CDMSessionClearKey.cpp: Added.

(WebCore::clearKeyVM): Static method returning the VM to be used by JSON parsing.
(WebCore::CDMSessionClearKey::CDMSessionClearKey): Simple constructor.
(WebCore::CDMSessionClearKey::~CDMSessionClearKey): Simple destructor.
(WebCore::CDMSessionClearKey::generateKeyRequest): Store the initData, ensure that it consists of a UTF8-encoded key

URI, and return same.

(WebCore::CDMSessionClearKey::releaseKeys): Purged all cached keys.
(WebCore::CDMSessionClearKey::update): Parse raw JSON-encoded JWK keys, rejecting non-AES, non-oct keys.
(WebCore::CDMSessionClearKey::cachedKeyForKeyID): Return cached keys.

Modules/encryptedmedia/CDMSessionClearKey.h:

Add support for the "org.w3c.clearkey" CDM to MediaPlayerPrivateAVFoundationObjC, and do so in a platform-agnostic
way by simply asking for raw key data from MediaPlayerClient when notified that a key has been added.

platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::keySystemIsSupported):
(WebCore::MediaPlayerPrivateAVFoundationObjC::supportsType):
(WebCore::MediaPlayerPrivateAVFoundationObjC::supportsKeySystem):
(WebCore::fulfillRequestWithKeyData): Added utility method.
(WebCore::MediaPlayerPrivateAVFoundationObjC::shouldWaitForLoadingOfResource):
(WebCore::MediaPlayerPrivateAVFoundationObjC::keyAdded):

Pipe a keyAdded() notification down to MediaPlayer and a cachedKeyForKeyId() request up to CDMSessionClearKey:

Modules/encryptedmedia/MediaKeySession.cpp:

(WebCore::MediaKeySession::cachedKeyForKeyId):
(WebCore::MediaKeySession::addKeyTimerFired):

Modules/encryptedmedia/MediaKeySession.h:
Modules/encryptedmedia/MediaKeys.cpp:

(WebCore::MediaKeys::keyAdded):
(WebCore::MediaKeys::cachedKeyForKeyId):

Modules/encryptedmedia/MediaKeys.h:
html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::keyAdded):

html/HTMLMediaElement.h:
platform/graphics/CDMSession.h:

(WebCore::CDMSession::cachedKeyForKeyID):

platform/graphics/MediaPlayer.cpp:

(WebCore::MediaPlayer::keyAdded):
(WebCore::MediaPlayer::cachedKeyForKeyId):

platform/graphics/MediaPlayer.h:

(WebCore::MediaPlayerClient::mediaPlayerCachedKeyForKeyId):

platform/graphics/MediaPlayerPrivate.h:

(WebCore::MediaPlayerPrivateInterface::keyAdded):

Add new files to project:

WebCore.xcodeproj/project.pbxproj:
CMakeLists.txt:
WebCore.vcxproj/WebCore.vcxproj:
WebCore.vcxproj/WebCore.vcxproj.filters:

LayoutTests:

http/tests/media/clearkey/clear-key-hls-aes128-expected.txt: Added.
http/tests/media/clearkey/clear-key-hls-aes128.html: Added.
http/tests/media/clearkey/support.js: Added.

(stringToUInt8Array):
(uInt8ArrayToString):
(base64EncodeUint8Array):

http/tests/media/resources/hls/clearkey/crypt0.key: Added.
http/tests/media/resources/hls/clearkey/iframe_index.m3u8: Added.
http/tests/media/resources/hls/clearkey/main0.ts: Added.
http/tests/media/resources/hls/clearkey/prog_index.m3u8: Added.
media/video-test.js:

(waitForEventOnceOn):

5:41 PM Changeset in webkit [179050] by Chris Dumez

15 edits in trunk/Source/WebCore

Implement system fonts FontDescription caching at RenderTheme level
https://bugs.webkit.org/show_bug.cgi?id=140840

Reviewed by Andreas Kling.

Implement system fonts FontDescription caching at RenderTheme level
instead of duplicating the logic in its subclasses for each platform.
This reduces code / logic duplication and reduces the amount of
platform-specific code. This will also make the refactoring at
Bug 140577 a lot easier.

The caching logic remains in RenderThemeIOS class for iOS because:

It supports different system font values than all other platforms
It requires cache invalidation in some cases while other platforms do not.

This patch is inspired by the following Blink revision:
https://src.chromium.org/viewvc/blink?view=rev&revision=184449

Test: fast/css/css2-system-fonts.html

5:38 PM Changeset in webkit [179049] by Brent Fulgham

2 edits in trunk/LayoutTests

[Win] Unreviewed gardening: Correct some typos in Failure entries.

platform/win/TestExpectations:

5:13 PM Changeset in webkit [179048] by Alan Bujtas

2 edits in trunk/Source/WebCore

Simple line layout: Refactor line wrapping logic.
https://bugs.webkit.org/show_bug.cgi?id=140834

Reviewed by Antti Koivisto.

Use a more readable structure to deal with wrapping logic.

No change in functionality.

rendering/SimpleLineLayout.cpp:

(WebCore::SimpleLineLayout::createLineRuns):

5:12 PM Changeset in webkit [179047] by Alan Bujtas

3 edits in trunk/Source/WebCore

Simple line layout: Use only FlowContents::nextTextFragment() to read fragments from the text flow.
https://bugs.webkit.org/show_bug.cgi?id=140842

Reviewed by Antti Koivisto.

This is in preparation to make FlowContents a content iterator class.

No change in functionality.

rendering/SimpleLineLayout.cpp:

(WebCore::SimpleLineLayout::initializeNewLine):

rendering/SimpleLineLayoutFlowContents.h:

5:05 PM Changeset in webkit [179046] by ddkilzer@apple.com

2 edits in trunk/Tools

test-webkitpy: webkitpy.tool.commands.earlywarningsystem_unittest.EarlyWarningSystemTest.test_ewses fails on EFL, GTK, Win ports
<http://webkit.org/b/140787>

Reviewed by Daniel Bates.

Scripts/webkitpy/port/ios.py:

(IOSPort.determine_full_port_name): Instead of checking the type
of the current host, test if /usr/bin/xcrun exists before trying
to use it.

5:03 PM Changeset in webkit [179045] by Lucas Forschler

4 edits in branches/safari-600.1.4.15-branch/Source/WebCore

Build fix after r179028, r179030, r179031, r179032.

Reviewed by Dana Burkart.

platform/graphics/WidthIterator.cpp:

(WebCore::WidthIterator::WidthIterator):

platform/graphics/mac/ComplexTextController.cpp:

(WebCore::ComplexTextController::ComplexTextController):

rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlockFlow::computeInlineDirectionPositionsForSegment):

4:52 PM Changeset in webkit [179044] by commit-queue@webkit.org

5 edits
2 adds in trunk

[MSE] Implement Range Removal algorithm.
https://bugs.webkit.org/show_bug.cgi?id=140622.

Patch by Bartlomiej Gajda <b.gajda@samsung.com> on 2015-01-23
Reviewed by Jer Noble.

Source/WebCore:

This extract Range Removal algorithm (Editor's Draft version, bug:26316) from remove(),
to separate function to deal with old FIXME since bug in spec was resolved.
This should both guarantee good order of events, and prevent from switching to 'open' state
during end of stream.

Test: media/media-source/media-source-end-of-stream-readyState.html

Modules/mediasource/MediaSource.cpp:

(WebCore::MediaSource::setDurationInternal): update to use rangeRemoval(), not remove()
(WebCore::MediaSource::streamEndedWithError): remove FIXME, brigning back correct order of events.

Modules/mediasource/SourceBuffer.cpp:

(WebCore::SourceBuffer::remove): comments up to spec, extract rangeRemoval algorithm.
(WebCore::SourceBuffer::rangeRemoval):
(WebCore::SourceBuffer::removeTimerFired): comments up to spec.

Modules/mediasource/SourceBuffer.h:

LayoutTests:

Added short test to check whether endOfStream incorrectly switches back
to 'open' state.

media/media-source/media-source-end-of-stream-readyState.html: Added.
media/media-source/media-source-end-of-stream-readyState-expected.txt: Added.

4:49 PM Changeset in webkit [179043] by Csaba Osztrogonác

2 edits in trunk/Tools

Fix the false positive build failures on the Windows buildbots
https://bugs.webkit.org/show_bug.cgi?id=140819

Reviewed by Brent Fulgham.

Increase the build timeout (without producing output) to 2 hours for Windows bots,
the default 20 minutes is enough for others since they produce output during the build.

BuildSlaveSupport/build.webkit.org-config/master.cfg:

(BuildFactory.init):

4:48 PM Changeset in webkit [179042] by dburkart@apple.com

20 edits
5 deletes in tags/Safari-600.5.3

Rollout r178466

4:45 PM Changeset in webkit [179041] by dburkart@apple.com

12 edits
8 deletes in tags/Safari-600.5.3

Rollout r178467

4:43 PM Changeset in webkit [179040] by dburkart@apple.com

20 edits
5 deletes in branches/safari-600.5-branch

Rollout r178466

4:38 PM Changeset in webkit [179039] by Brent Fulgham

4 edits
2 adds in trunk/LayoutTests

[Win] Test gardening. Mark a few failures after filing bugs.

Also rebaseline a few tests.

platform/win/TestExpectations:
platform/win/accessibility/parent-element-expected.txt:
platform/win/editing/input/caret-at-the-edge-of-input-expected.png: Added.
platform/win/editing/input/caret-at-the-edge-of-input-expected.txt: Added.
platform/win/js/dom/global-constructors-attributes-expected.txt:

4:32 PM Changeset in webkit [179038] by dburkart@apple.com

12 edits
8 deletes in branches/safari-600.5-branch

Rollout r178467

4:24 PM Changeset in webkit [179037] by rniwa@webkit.org

2 edits in trunk/Websites/perf.webkit.org

Perf dashboard always assigns the result of A/B testing with build request 1
https://bugs.webkit.org/show_bug.cgi?id=140382

Reviewed by Darin Adler.

The bug was caused by the expression array_get($report, 'jobId') or array_get($report, 'buildRequest')
which always evaluated to 1 when the report contained jobId. Fixed the bug by cascading array_get instead.

Also fixed a typo as well as a bug that reports were never associated with builds.

public/include/report-processor.php:

(ReportProcessor::process): Don't use "or" to find the non-null value since that always evaluates to 1
instead of the first non-null value.
(ReportProcessor::resolve_build_id): Fixed the typo by adding the missing "$this->".
(ReportProcessor::commit): Associate the report with the corresponding build as intended.

4:21 PM Changeset in webkit [179036] by rniwa@webkit.org

2 edits in trunk/Websites/perf.webkit.org

Unreviewed typo fix. The prefix in triggerable_configurations is "trigconfig", not "trigrepo".

public/admin/tests.php:

3:48 PM Changeset in webkit [179035] by msaboff@apple.com

2 edits in trunk/Source/JavaScriptCore

LayoutTests/js/script-tests/reentrant-caching.js crashing on 32 bit builds
https://bugs.webkit.org/show_bug.cgi?id=140843

Reviewed by Oliver Hunt.

When we are in vmEntryToJavaScript, we keep the stack pointer at an
alignment sutiable for pointing to a call frame header, which is the
alignment post making a call. We adjust the sp when calling to JS code,
but don't adjust it before calling the out of stack handler.

llint/LowLevelInterpreter32_64.asm:

Moved stack point down 8 bytes to get it aligned.

3:37 PM Changeset in webkit [179034] by dburkart@apple.com

5 edits
9 copies in branches/safari-600.5-branch

Merged r176354. <rdar://19451336>

3:34 PM Changeset in webkit [179033] by Brent Fulgham

4 edits in trunk

Source/WebKit/win:
[Win] Teach WebKit to provide IAccessible2 'get_language'
https://bugs.webkit.org/show_bug.cgi?id=140839

Reviewed by Dean Jackson.

AccessibleBase.cpp:

(AccessibleBase::get_locale): Wrap the Webore::AccessibleObject::language
result in an IA2Locale structure to statisfy the IAccessible2 specification.

Tools:
[Win] Teach WebKit to provide IAccessible2 'get_language' and access AXLanguage
https://bugs.webkit.org/show_bug.cgi?id=140839

Reviewed by Dean Jackson.

DumpRenderTree/win/AccessibilityUIElementWin.cpp:

(AccessibilityUIElement::language): Retrieve the 'language' BSTR
from the IA2Locale structure and pass it to DRT.

3:09 PM Changeset in webkit [179032] by Lucas Forschler

11 edits
4 copies in branches/safari-600.1.4.15-branch

Merged r174489. rdar://problem/19434944

3:06 PM Changeset in webkit [179031] by Lucas Forschler

2 edits in branches/safari-600.1.4.15-branch/Source/WebCore

Merged r174373. rdar://problem/19434944

3:05 PM Changeset in webkit [179030] by Lucas Forschler

8 edits in branches/safari-600.1.4.15-branch/Source/WebCore

Merged r174297. rdar://problem/19434944

3:04 PM Changeset in webkit [179029] by dburkart@apple.com

9 edits
4 copies in branches/safari-600.5-branch

Merged r174489. <rdar://problem/19452129>

3:03 PM Changeset in webkit [179028] by Lucas Forschler

42 edits
1 copy in branches/safari-600.1.4.15-branch

Merged r174233. rdar://problem/19434944

2:16 PM Changeset in webkit [179027] by enrica@apple.com

3 edits
4 adds in trunk

Hit test returns incorrect results when performed in paginated content over the page gaps.
https://bugs.webkit.org/show_bug.cgi?id=140837
rdar://problem/17494390

Reviewed by Dave Hyatt.

Source/WebCore:

Tests: fast/multicol/pagination/LeftToRight-tb-hittest.html

fast/multicol/pagination/RightToLeft-rl-hittest.html

When hittesting reaches the RenderView we need to check if we are
in paginated content and use the correct class to compute hittest results.

rendering/RenderView.cpp:

(WebCore::RenderView::updateHitTestResult):

LayoutTests:

fast/multicol/pagination/LeftToRight-tb-hittest-expected.txt: Added.
fast/multicol/pagination/LeftToRight-tb-hittest.html: Added.
fast/multicol/pagination/RightToLeft-rl-hittest-expected.txt: Added.
fast/multicol/pagination/RightToLeft-rl-hittest.html: Added.

1:57 PM Changeset in webkit [179026] by Brent Fulgham

40 edits
5 adds
12 deletes in trunk/LayoutTests

[Win] Unreviewed gardening after landing r179024.

Update Windows-specific accessibility tests and test expectations after making Windows AX output match Mac.
This allows us to share more Mac results.

platform/win/TestExpectations:
platform/win/accessibility/adjacent-continuations-cause-assertion-failure-expected.txt:
platform/win/accessibility/aria-checkbox-text-expected.txt: Removed.
platform/win/accessibility/aria-combobox-expected.txt:
platform/win/accessibility/aria-fallback-roles-expected.txt: Removed.
platform/win/accessibility/aria-hidden-expected.txt: Removed.
platform/win/accessibility/aria-labelledby-on-input-expected.txt: Removed.
platform/win/accessibility/aria-labelledby-overrides-aria-label-expected.txt:
platform/win/accessibility/aria-labelledby-overrides-label-expected.txt: Removed.
platform/win/accessibility/aria-list-and-listitem-expected.txt:
platform/win/accessibility/aria-mappings-expected.txt: Added.
platform/win/accessibility/aria-menubar-menuitems-expected.txt:
platform/win/accessibility/aria-option-role-expected.txt:
platform/win/accessibility/aria-presentational-role-expected.txt: Removed.
platform/win/accessibility/aria-roles-expected.txt:
platform/win/accessibility/aria-tab-role-on-buttons-expected.txt:
platform/win/accessibility/aria-tab-roles-expected.txt:
platform/win/accessibility/aria-toggle-button-with-title-expected.txt: Removed.
platform/win/accessibility/canvas-description-and-role-expected.txt:
platform/win/accessibility/canvas-fallback-content-expected.txt:
platform/win/accessibility/css-content-attribute-expected.txt: Added.
platform/win/accessibility/deleting-iframe-destroys-axcache-expected.txt:
platform/win/accessibility/div-within-anchors-causes-crash-expected.txt:
platform/win/accessibility/document-enabled-state-expected.txt:
platform/win/accessibility/document-enabled-state.html:
platform/win/accessibility/document-role-expected.txt:
platform/win/accessibility/heading-elements-expected.txt:
platform/win/accessibility/heading-elements.html:
platform/win/accessibility/image-map1-expected.txt: Added.
platform/win/accessibility/image-with-alt-and-map-expected.txt: Added.
platform/win/accessibility/img-alt-attribute-expected.txt:
platform/win/accessibility/img-alt-attribute.html:
platform/win/accessibility/img-alt-tag-only-whitespace-expected.txt: Removed.
platform/win/accessibility/img-aria-button-alt-tag-expected.txt: Removed.
platform/win/accessibility/img-fallsback-to-title-expected.txt: Removed.
platform/win/accessibility/input-image-alt-expected.txt: Removed.
platform/win/accessibility/linked-elements-expected.txt:
platform/win/accessibility/linked-elements.html:
platform/win/accessibility/list-item-role-expected.txt:
platform/win/accessibility/list-item-role.html:
platform/win/accessibility/list-marker-role-expected.txt:
platform/win/accessibility/list-marker-role.html:
platform/win/accessibility/list-role-expected.txt:
platform/win/accessibility/list-role.html:
platform/win/accessibility/multiple-select-element-role-expected.txt:
platform/win/accessibility/multiple-select-element-role.html:
platform/win/accessibility/parent-element-expected.txt:
platform/win/accessibility/parent-element.html:
platform/win/accessibility/select-element-role-expected.txt:
platform/win/accessibility/select-element-role.html:
platform/win/accessibility/selection-and-focus-expected.txt:
platform/win/accessibility/selection-and-focus.html:
platform/win/accessibility/single-select-children.html:
platform/win/accessibility/svg-image-expected.txt: Removed.
platform/win/accessibility/text-role-expected.txt:
platform/win/aria-labelledby-overrides-aria-label-actual.txt: Added.

1:39 PM Changeset in webkit [179025] by akling@apple.com

4 edits in trunk/Source/WebCore

Document should be a FontSelectorClient.
<https://webkit.org/b/140833>

Reviewed by Antti Koivisto.

Make Document a FontSelectorClient so it can listen to the invalidation
callbacks from FontSelector instead of having code in FontSelector that
calls out to Document on invalidation.

css/CSSFontSelector.cpp:

(WebCore::CSSFontSelector::dispatchInvalidationCallbacks):

dom/Document.cpp:

(WebCore::Document::fontsNeedUpdate):
(WebCore::Document::fontSelector):
(WebCore::Document::clearStyleResolver):

dom/Document.h:

1:31 PM Changeset in webkit [179024] by Brent Fulgham

2 edits in trunk/Tools

[Win] Update DRT Accessibility implementation to better match Mac.
https://bugs.webkit.org/show_bug.cgi?id=140830

Reviewed by Dean Jackson.

DumpRenderTree/win/AccessibilityUIElementWin.cpp:

(AccessibilityUIElement::titleUIElement):
(AccessibilityUIElement::parentElement):
(convertToDRTLabel):
(AccessibilityUIElement::role):
(AccessibilityUIElement::title):
(AccessibilityUIElement::description):
(AccessibilityUIElement::stringValue):
(AccessibilityUIElement::helpText):
(AccessibilityUIElement::isFocused):

12:53 PM Changeset in webkit [179023] by timothy_horton@apple.com

2 edits in trunk/Source/WebKit2

Fix the pre-Yosemite build.

UIProcess/API/mac/WKView.mm:

(-[WKView _dismissContentRelativeChildWindows]):

12:12 PM Changeset in webkit [179022] by bshafiei@apple.com

1 copy in tags/Safari-600.1.4.15.2

New tag.

12:10 PM Changeset in webkit [179021] by bshafiei@apple.com

1 copy in tags/Safari-600.5.3

New tag.

12:05 PM Changeset in webkit [179020] by bshafiei@apple.com

5 edits in branches/safari-600.1.4.15-branch/Source

Versioning.

12:05 PM Changeset in webkit [179019] by Joseph Pecoraro

15 edits
2 adds in trunk

Web Inspector: Object Previews in the Console
https://bugs.webkit.org/show_bug.cgi?id=129204

Reviewed by Timothy Hatcher.

Source/JavaScriptCore:

Update the very old, unused object preview code. Part of this comes from
the earlier WebKit legacy implementation, and the Blink implementation.

A RemoteObject may include a preview, if it is asked for, and if the
RemoteObject is an object. Previews are a shallow (single level) list
of a limited number of properties on the object. The previewed
properties are always stringified (even if primatives). Previews are
limited to just 5 properties or 100 indices. Previews are marked
as lossless if they are a complete snapshot of the object.

There is a path to make previews two levels deep, that is currently
unused but should soon be used for tables (e.g. IndexedDB).

inspector/InjectedScriptSource.js:
Move some code off of InjectedScript to be generic functions

usable by RemoteObject as well.

Update preview generation to use

inspector/protocol/Runtime.json:
Add a new type, "accessor" for preview objects. This represents

a getter / setter. We currently don't get the value.

Source/WebInspectorUI:

UserInterface/Controllers/JavaScriptLogViewController.js:

(WebInspector.JavaScriptLogViewController.prototype.consolePromptTextCommitted):

UserInterface/Controllers/JavaScriptRuntimeCompletionProvider.js:

(get WebInspector.JavaScriptRuntimeCompletionProvider.prototype.):
Update RuntimeManager callsites that do not need object previews.

UserInterface/Controllers/RuntimeManager.js:

(WebInspector.RuntimeManager.prototype.evalCallback):
(WebInspector.RuntimeManager.prototype.evaluateInInspectedWindow):
Update the main evaluate method to include a boolean parameter for
object previews. Most callers do not need them. Also, since previews
were not available on iOS 6, switch to invoke, to conditionally
include the command parameter.

UserInterface/Protocol/RemoteObject.js:

(WebInspector.RemoteObject):
(WebInspector.RemoteObject.fromPayload):
(WebInspector.RemoteObject.prototype.get preview):
Store the preview from the payload.

UserInterface/Views/ConsoleMessageImpl.js:

(WebInspector.ConsoleMessageImpl.prototype._format):
(WebInspector.ConsoleMessageImpl.prototype._formatParameter):
(WebInspector.ConsoleMessageImpl.prototype._formatParameterAsNode):
(WebInspector.ConsoleMessageImpl.prototype._formatParameterAsString):
(WebInspector.ConsoleMessageImpl.prototype._formatAsArrayEntry):
Pass an explicit false for most formatters to not use a preview if available.

(WebInspector.ConsoleMessageImpl.prototype._formatParameterAsArray):
(WebInspector.ConsoleMessageImpl.prototype._formatParameterAsObject):
Currently only object types are previewed. Though we request previews
for arrays, we don't use the preview because we show a better preview
by just immediately requesting for a full non-preview property list.

(WebInspector.ConsoleMessageImpl.prototype._appendObjectPreview):
Quickly output an object preview into the title element. The format
is "ClassName {prop: value...}". Elide the class name if it is "Object".
Also skip over certain preview properties that may not be useful
at a glance (like constructor, or accessors without values).

UserInterface/Views/LogContentView.css:

(.console-object-preview):
(.console-formatted-array .console-object-preview):
(.console-object-preview-lossless):
(.expanded .console-object-preview):
Show lossy previews in italics.
Show lossless previews and array previews without italics.
Do not show the class name in the preview in italics when expanded.

(.console-object-preview .name):
Give preview property names the same color as ObjectPropertiesSection property names.

(.expanded .console-object-preview > .console-object-preview-body):
When expanding an object, hide the preview.

(.console-object-preview > .console-object-preview-name.console-object-preview-name-Object):
(.expanded .console-object-preview > .console-object-preview-name.console-object-preview-name-Object):
For "Object" previews, hide the name "Object" when not expanded, and show it when expanded.

LayoutTests:

inspector/debugger/command-line-api-exception-nested-catch.html:
inspector/debugger/command-line-api-exception.html:
inspector/model/remote-object-get-properties.html:

Update RuntimeManager callsites to not ask for previews when evaluating.

inspector/model/remote-object-expected.txt: Added.
inspector/model/remote-object.html: Added.

Add a test specifically for Remote Object. This test can also be
opened in a browser. It attempts to run the gamut of all different
types of objects and shows the RemoteObject constructed for it.

12:03 PM Changeset in webkit [179018] by bshafiei@apple.com

5 edits in branches/safari-600.5-branch/Source

Versioning.

12:01 PM Changeset in webkit [179017] by Chris Dumez

2 edits in trunk/Source/WebCore

Leverage CSSValuePool's font family cache in CSSComputedStyleDeclaration
https://bugs.webkit.org/show_bug.cgi?id=140829

Reviewed by Andreas Kling.

Leverage CSSValuePool's font family cache in CSSComputedStyleDeclaration
by calling CSSValuePool::createFontFamilyValue() to create the font
family CSSPrimitiveValue instead of cssValuePool().createValue().

css/CSSComputedStyleDeclaration.cpp:

(WebCore::valueForFamily):

11:57 AM Changeset in webkit [179016] by saambarati1@gmail.com

3 edits in trunk/Source/WebInspectorUI

Web Inspector: Disable *Annotators on minified files that aren't pretty printed
https://bugs.webkit.org/show_bug.cgi?id=140550

Reviewed by Timothy Hatcher.

When SourceCodeTextEditor speculates that a file is minified it
sets a flag on itself that the Annotators will notice when pretty
printing and turning on type profiling.

SourceCodeTextEditor enforces the following two behaviors:

Always pretty print a file if we think it's minified while

viewing type annotations. So, while viewing a minified file,
if you press the type profiling button, the pretty printer will
first reformat the file, then the type profiler will insert type annotations.

If the type profiler is enabled and we're viewing a pretty

printed file that we think originally was minified, and the
pretty printer is disabled via pressing the button, then the
type profiler will also be disabled.

These two behaviors maintain a good user experience because
it prevents a bad visual representation of profiler data and
also prevents bad performance.

UserInterface/Controllers/TypeTokenAnnotator.js:

(WebInspector.TypeTokenAnnotator.prototype.toggleTypeAnnotations): Deleted.

UserInterface/Views/SourceCodeTextEditor.js:

(WebInspector.SourceCodeTextEditor):
(WebInspector.SourceCodeTextEditor.prototype.shown):
(WebInspector.SourceCodeTextEditor.prototype.contentDidChange):
(WebInspector.SourceCodeTextEditor.prototype.toggleTypeAnnotations):
(WebInspector.SourceCodeTextEditor.prototype.prettyPrint):
(WebInspector.SourceCodeTextEditor.prototype._contentWillPopulate):
(WebInspector.SourceCodeTextEditor.prototype._populateWithContent):
(WebInspector.SourceCodeTextEditor.prototype._setTypeTokenAnnotatorEnabledState):

11:52 AM Changeset in webkit [179015] by msaboff@apple.com

4 edits in trunk/Source/JavaScriptCore

Immediate crash when setting JS breakpoint
https://bugs.webkit.org/show_bug.cgi?id=140811

Reviewed by Mark Lam.

When the DFG stack layout phase doesn't allocate a register for the scope register,
it incorrectly sets the scope register in the code block to a bad value, one with
an offset of 0. Changed it so that we set the code block's scope register to the
invalid VirtualRegister instead.

No tests needed as adding the ASSERT in setScopeRegister() was used to find the bug.
We crash with that ASSERT in testapi and likely many other tests as well.

bytecode/CodeBlock.cpp:

(JSC::CodeBlock::CodeBlock):

bytecode/CodeBlock.h:

(JSC::CodeBlock::setScopeRegister):
(JSC::CodeBlock::scopeRegister):
Added ASSERTs to catch any future improper setting of the code block's scope register.

dfg/DFGStackLayoutPhase.cpp:

(JSC::DFG::StackLayoutPhase::run):

11:43 AM Changeset in webkit [179014] by timothy_horton@apple.com

10 edits in trunk/Source

QLPreviewMenuItem popovers don't close when the page scrolls
https://bugs.webkit.org/show_bug.cgi?id=140806
<rdar://problem/19555618>

Reviewed by Beth Dakin.

Now that QLPreviewMenuItem's popover doesn't eat scrolls, we need to dismiss it if the page scrolls.

WebView/WebHTMLView.mm:

(-[WebHTMLView scrollWheel:scrollWheel:]):
Send scrollWheel along to WebImmediateActionController.

WebView/WebImmediateActionController.h:
WebView/WebImmediateActionController.mm:

(-[WebImmediateActionController webView:didHandleScrollWheel:]):
(-[WebImmediateActionController _clearImmediateActionState]):
(-[WebImmediateActionController _defaultAnimationController]):
Keep track of the active QLPreviewMenuItem, and close it upon scroll.

UIProcess/API/mac/WKView.mm:

(-[WKView _dismissContentRelativeChildWindows]):
Send _dismissContentRelativeChildWindows on to WKImmediateActionController.

UIProcess/mac/WKImmediateActionController.h:
UIProcess/mac/WKImmediateActionController.mm:

(-[WKImmediateActionController _clearImmediateActionState]):
(-[WKImmediateActionController dismissContentRelativeChildWindows]):
(-[WKImmediateActionController _defaultAnimationController]):
Keep track of the active QLPreviewMenuItem, and close it upon scroll.

platform/spi/mac/QuickLookMacSPI.h:

Add some SPI.

11:42 AM Changeset in webkit [179013] by timothy_horton@apple.com

4 edits in trunk/Source

Infinite recursion in _clearImmediateActionState
https://bugs.webkit.org/show_bug.cgi?id=140807
<rdar://problem/19571601>

Reviewed by Anders Carlsson.

UIProcess/mac/WKImmediateActionController.mm:

(-[WKImmediateActionController _clearImmediateActionState]):
Clear _hasActivatedActionContext before calling didUseActions, because
didUseActions can call _clearImmediateActionState.

WebView/WebImmediateActionController.mm:

(-[WebImmediateActionController _clearImmediateActionState]):
Use this opportunity to bring identical code to WebKit1, to avoid
getting DataDetectors stuck when an immediate action is canceled.

10:44 AM Changeset in webkit [179012] by akling@apple.com

18 edits in trunk/Source/WebCore

Hang CSSFontSelector off Document instead of StyleResolver.
<https://webkit.org/b/140820>

Reviewed by Antti Koivisto.

Move the CSSFontSelector from StyleResolver to Document. This is the first
step towards making the CSSFontSelector be able to survive full style recalc.

Clearing a Document's StyleResolver will still nuke the CSSFontSelector,
though that is done in Document::clearStyleResolver() now.

css/CSSFontSelector.cpp:

(WebCore::CSSFontSelector::CSSFontSelector):

css/CSSFontSelector.h:

Modernize CSSFontSelector construction a bit by having create() return
a Ref and the constructor take a Document& instead of a Document*.
Also made the constructor explicit.

(WebCore::StyleResolver::~StyleResolver):

dom/Document.cpp:

(WebCore::Document::clearStyleResolver):

Nuke the current CSSFontSelector in clearStyleResolver() instead of
in ~StyleResolver. It's a minor change, but shows the way forward.
Added a FIXME about how CSSFontSelector should eventually survive
this operation.

(WebCore::Document::fontSelector):

css/FontLoader.cpp:

(WebCore::FontLoader::loadFont):
(WebCore::FontLoader::checkFont):
(WebCore::FontLoader::resolveFontStyle):

css/RuleSet.cpp:

(WebCore::RuleSet::addChildRules):

css/StyleResolver.h:

(WebCore::StyleResolver::fontSelector): Deleted.

css/StyleResolver.cpp:

(WebCore::StyleResolver::StyleResolver):
(WebCore::StyleResolver::appendAuthorStyleSheets):
(WebCore::StyleResolver::styleForElement):
(WebCore::StyleResolver::defaultStyleForElement):
(WebCore::StyleResolver::updateFont):

dom/Document.h:
html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::setFont):

rendering/RenderListBox.cpp:

(WebCore::RenderListBox::updateFromElement):
(WebCore::RenderListBox::paintItemForeground):

rendering/RenderMenuList.cpp:

(RenderMenuList::fontSelector):

rendering/RenderSearchField.cpp:

(WebCore::RenderSearchField::fontSelector):

rendering/TextAutoSizing.cpp:

(WebCore::TextAutoSizingValue::adjustNodeSizes):
(WebCore::TextAutoSizingValue::reset):

rendering/svg/RenderSVGInlineText.cpp:

(WebCore::RenderSVGInlineText::computeNewScaledFontForStyle):

style/StyleResolveForDocument.cpp:

(WebCore::Style::resolveForDocument):

style/StyleResolveTree.cpp:

(WebCore::Style::resolveTree):

Move CSSFontSelector ownership from StyleResolver to Document.

10:28 AM Changeset in webkit [179011] by eric.carlson@apple.com

2 edits in trunk/LayoutTests

Create a "load and stall" cgi that support byte ranges.
https://bugs.webkit.org/show_bug.cgi?id=140628

Reviewed by Jer Noble.

http/tests/media/resources/serve-video.php: Add support for "stallOffset", "stallDuration",

and "chunkSize" parameters.

10:27 AM Changeset in webkit [179010] by jer.noble@apple.com

2 edits in trunk/Source/WebCore

Layout Test http/tests/media/track-in-band-hls-metadata.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=140827

Reviewed by Eric Carlson.

Create the m_metadataTrack by calling prepareMetadataTrack() before deref-ing it.

platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::metadataDidArrive):

8:33 AM Changeset in webkit [179009] by Carlos Garcia Campos

2 edits in trunk/Source/WTF

[GTK] Add missing null check in some derefGPtr implementations
https://bugs.webkit.org/show_bug.cgi?id=140822

Reviewed by Sergio Villar Senin.

It's missing in GHashTable and GVariant implementations.

wtf/gobject/GRefPtr.cpp:

(WTF::derefGPtr):

6:56 AM Changeset in webkit [179008] by svillar@igalia.com

3 edits in trunk/Tools

REGRESSION: run-perf-tests --profiler= seems to have broken
https://bugs.webkit.org/show_bug.cgi?id=113528

Reviewed by Daniel Bates.

The problem is that "perf --record" (or the equivalent call for
other profilers) is never called whenever there is a wrapper
option in the port. We should inject the profiler call first
(should it exists) and then use the port wrapper.

Scripts/webkitpy/port/driver.py:

(Driver._command_wrapper):

Scripts/webkitpy/port/driver_unittest.py:

(DriverTest.test_profiler_and_wrapper): New unit test.

6:30 AM Changeset in webkit [179007] by Carlos Garcia Campos

19 edits
12 adds in trunk

[GTK] Add initial database process support
https://bugs.webkit.org/show_bug.cgi?id=139491

Reviewed by Sergio Villar Senin.

Source/cmake/OptionsGTK.cmake: Set WebKit2_DatabaseProcess_OUTPUT_NAME.

Source/WebCore:

platform/sql/SQLiteFileSystem.cpp:

(WebCore::SQLiteFileSystem::openDatabase): Use
WebCore::fileSystemRepresentation() for the database filename,
otherwise sqlite3_open() fails when the filename contains "%2E".

Source/WebKit2:

Add initial support for DatabaseProcess, disabled by default for
now.

CMakeLists.txt: Add required files to compilation.
DatabaseProcess/DatabaseProcess.cpp:

(WebKit::DatabaseProcess::createDatabaseToWebProcessConnection):
Add the unix domain sockets implementation.

DatabaseProcess/EntryPoint/unix/DatabaseProcessMain.cpp: Added.

(main):

DatabaseProcess/gtk/DatabaseProcessMainGtk.cpp: Added.

(WebKit::DatabaseProcessMainUnix):

DatabaseProcess/unix/DatabaseProcessMainUnix.h: Added.
PlatformGTK.cmake: Add required files to compilation.
Shared/ProcessExecutablePath.h:
Shared/gtk/KeyedDecoder.cpp: Added.

(WebKit::KeyedDecoder::KeyedDecoder):
(WebKit::KeyedDecoder::~KeyedDecoder):
(WebKit::KeyedDecoder::buildDictionaryFromGVariant):
(WebKit::KeyedDecoder::decodeBytes):
(WebKit::KeyedDecoder::decodeBool):
(WebKit::KeyedDecoder::decodeUInt32):
(WebKit::KeyedDecoder::decodeInt32):
(WebKit::KeyedDecoder::decodeInt64):
(WebKit::KeyedDecoder::decodeFloat):
(WebKit::KeyedDecoder::decodeDouble):
(WebKit::KeyedDecoder::decodeString):
(WebKit::KeyedDecoder::beginObject):
(WebKit::KeyedDecoder::endObject):
(WebKit::KeyedDecoder::beginArray):
(WebKit::KeyedDecoder::beginArrayElement):
(WebKit::KeyedDecoder::endArrayElement):
(WebKit::KeyedDecoder::endArray):

Shared/gtk/KeyedDecoder.h: Added.
Shared/gtk/KeyedEncoder.cpp: Added.

(WebKit::KeyedEncoder::KeyedEncoder):
(WebKit::KeyedEncoder::~KeyedEncoder):
(WebKit::KeyedEncoder::encodeBytes):
(WebKit::KeyedEncoder::encodeBool):
(WebKit::KeyedEncoder::encodeUInt32):
(WebKit::KeyedEncoder::encodeInt32):
(WebKit::KeyedEncoder::encodeInt64):
(WebKit::KeyedEncoder::encodeFloat):
(WebKit::KeyedEncoder::encodeDouble):
(WebKit::KeyedEncoder::encodeString):
(WebKit::KeyedEncoder::beginObject):
(WebKit::KeyedEncoder::endObject):
(WebKit::KeyedEncoder::beginArray):
(WebKit::KeyedEncoder::beginArrayElement):
(WebKit::KeyedEncoder::endArrayElement):
(WebKit::KeyedEncoder::endArray):
(WebKit::KeyedEncoder::finishEncoding):

Shared/gtk/KeyedEncoder.h: Added.
Shared/gtk/ProcessExecutablePathGtk.cpp:

(WebKit::executablePathOfDatabaseProcess):

UIProcess/Databases/DatabaseProcessProxy.cpp:

(WebKit::DatabaseProcessProxy::didCreateDatabaseToWebProcessConnection):
Add the unix domain sockets implementation.

UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp:

(WebKit::ProcessLauncher::launchProcess): Handle the
DatabaseProcess too.

UIProcess/gtk/WebContextGtk.cpp:

(WebKit::WebContext::platformDefaultIndexedDBDatabaseDirectory):

WebProcess/WebProcess.cpp:

(WebKit::WebProcess::ensureWebToDatabaseProcessConnection): Add
the unix domain sockets implementation.

Source/WTF:

Add support for using GRefPtr with GVariantBuilder.

wtf/gobject/GRefPtr.cpp:

(WTF::refGPtr):
(WTF::derefGPtr):

wtf/gobject/GRefPtr.h:
wtf/gobject/GTypedefs.h:

2:33 AM Changeset in webkit [179006] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Initialization for some member variable of FontPlatformData
https://bugs.webkit.org/show_bug.cgi?id=136327

Patch by Byeongha Cho <byeongha.cho@samsung.com> on 2015-01-23
Reviewed by Myles C. Maxfield.

No new tests. There's no functional change.

platform/graphics/freetype/FontPlatformDataFreeType.cpp:

(WebCore::FontPlatformData::FontPlatformData):
(WebCore::FontPlatformData::operator=):
(WebCore::FontPlatformData::~FontPlatformData):

2:05 AM Changeset in webkit [179005] by ddkilzer@apple.com

2 edits in branches/safari-600.1.4.15-branch/Source/WebKit2

Merged r175608. rdar://problem/19395075

2:05 AM Changeset in webkit [179004] by ddkilzer@apple.com

2 edits in branches/safari-600.1.4.15-branch/Source/WebKit2

Merged r175607. rdar://problem/19395075

2:05 AM Changeset in webkit [179003] by ddkilzer@apple.com

5 edits in branches/safari-600.1.4.15-branch/Source/WebKit2

Merged r175595. rdar://problem/19395075

2:04 AM Changeset in webkit [179002] by ddkilzer@apple.com

6 edits in branches/safari-600.1.4.15-branch/Source/WebKit2

Merged r175577. rdar://problem/19395075

2:04 AM Changeset in webkit [179001] by ddkilzer@apple.com

9 edits in branches/safari-600.1.4.15-branch/Source/WebKit2

Merged r174885. rdar://problem/19395075

2:04 AM Changeset in webkit [179000] by ddkilzer@apple.com

2 edits in branches/safari-600.1.4.15-branch/Source/WebKit2

Merged r174286. rdar://problem/19395075

2:04 AM Changeset in webkit [178999] by ddkilzer@apple.com

4 edits
3 adds in branches/safari-600.1.4.15-branch/Source

Merged r174250. rdar://problem/19395075

2:04 AM Changeset in webkit [178998] by ddkilzer@apple.com

9 edits in branches/safari-600.1.4.15-branch/Source/WebKit2

Merged r174232. rdar://problem/19395075

2:04 AM Changeset in webkit [178997] by ddkilzer@apple.com

8 edits in branches/safari-600.1.4.15-branch/Source/WebKit2

Merged r174072. rdar://problem/19395075

2:04 AM Changeset in webkit [178996] by ddkilzer@apple.com

9 edits in branches/safari-600.1.4.15-branch/Source/WebKit2

Merged r172966. rdar://problem/19395075

2:04 AM Changeset in webkit [178995] by ddkilzer@apple.com

3 edits in branches/safari-600.1.4.15-branch/Source/WebKit2

Merged r173762. rdar://problem/19420088

2:04 AM Changeset in webkit [178994] by ddkilzer@apple.com

10 edits in branches/safari-600.1.4.15-branch/Source

Merged r173741. rdar://problem/19420088

1:18 AM Changeset in webkit [178993] by bshafiei@apple.com

2 edits in branches/safari-600.5-branch/Source/WebKit/mac

Merged r178680. rdar://problem/19489593

1:17 AM Changeset in webkit [178992] by bshafiei@apple.com

2 edits in branches/safari-600.5-branch/Source/WebKit/mac

Merged r178676. rdar://problem/19489593

1:16 AM Changeset in webkit [178991] by bshafiei@apple.com

2 edits in branches/safari-600.5-branch/Source/WebKit/mac

Merged r178605. rdar://problem/19490114

1:14 AM Changeset in webkit [178990] by bshafiei@apple.com

2 edits in branches/safari-600.5-branch/Source/WebKit2

Merged r178595. rdar://problem/19490114

12:52 AM Changeset in webkit [178989] by ap@apple.com

2 edits in trunk/LayoutTests

svg-resource-fragment-identifier-img-src.html is a hidpi reftest, but its -expected.html
counterpart isn't hidpi
https://bugs.webkit.org/show_bug.cgi?id=140815

Reviewed by Simon Fraser.

svg/css/svg-resource-fragment-identifier-img-src-expected.html: Make the expectation

match its test.

12:49 AM Changeset in webkit [178988] by g.czajkowski@samsung.com

2 edits in trunk/Source/WebCore

Rename ChildNodeRemovalNotifier::m_insertionPoint to m_removalPoint
https://bugs.webkit.org/show_bug.cgi?id=140766

Reviewed by Andreas Kling.

ChildNodeRemovalNotifier::ChildNodeRemovalNotifier(...) should take
a node as removal point.
It's probably Copy/Paste from ChildNodeInsertionNotifier::m_insertionPoint.

No new tests. No behavior change.

dom/ContainerNodeAlgorithms.h:

(WebCore::ChildNodeRemovalNotifier::ChildNodeRemovalNotifier):
(WebCore::ChildNodeRemovalNotifier::notifyNodeRemovedFromDocument):
(WebCore::ChildNodeRemovalNotifier::notifyNodeRemovedFromTree):

12:25 AM Changeset in webkit [178987] by Chris Dumez

5 edits
7 deletes in trunk/LayoutTests

Rewrite the fast/css/css2-system-fonts.html test to be more useful on all platforms
https://bugs.webkit.org/show_bug.cgi?id=140810

Reviewed by Andreas Kling.

Make the fast/css/css2-system-fonts.html explicit about the font styles
expected on each platform instead of just Mac.

It also converts the test to be text only as the style information is
now displayed in text format.

This change is in preparation for a refactor of system font handling.

This change is based on the following Blink revision by
<alancutter@chromium.org>:
http://src.chromium.org/viewvc/blink?view=revision&revision=169612

fast/css/css2-system-fonts.html:
platform/efl/fast/css/css2-system-fonts-expected.png: Removed.
platform/efl/fast/css/css2-system-fonts-expected.txt: Removed.
platform/gtk/fast/css/css2-system-fonts-expected.png: Removed.
platform/gtk/fast/css/css2-system-fonts-expected.txt: Removed.
platform/ios-simulator-wk2/fast/css/css2-system-fonts-expected.txt:
platform/mac-mavericks/fast/css/css2-system-fonts-expected.png: Removed.
platform/mac-mavericks/fast/css/css2-system-fonts-expected.txt:
platform/mac-mountainlion/fast/css/css2-system-fonts-expected.txt: Removed.
platform/mac/fast/css/css2-system-fonts-expected.png: Removed.
platform/mac/fast/css/css2-system-fonts-expected.txt:

12:19 AM Changeset in webkit [178986] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[GTK] Fix debug build after r178940
https://bugs.webkit.org/show_bug.cgi?id=140814

Patch by Hunseop Jeong <Hunseop Jeong> on 2015-01-23
Reviewed by Carlos Garcia Campos.

Context Navigation

Timeline

Jan 24, 2015:

Jan 23, 2015:

Download in other formats: