⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jan 25, 2015:

11:59 PM Changeset in webkit [179106] by ap@apple.com
  • 8 edits
    1 add in trunk/Tools

Would like leaks bot results at build.webkit.org/dashboard
​https://bugs.webkit.org/show_bug.cgi?id=122657

Reviewed by Darin Adler.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:

Record links provided by buildbot steps. Currently, the dashboard hardcodes more links
than necessary, could use the ones from buildbot in more places.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:

(BuildbotQueue): Reflect configuration option for leaks queues.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:

Add leaks queues to performance column. First, leaks are about performance indeed,
and second, this is where we have some space to spare.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:

(WebKitBuildbot): Added Yosemite Leaks queue, which was sitting neglected for at
least a year.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:

(table.queue-grid td): Moved height from queue-view - we can now have more than one
queue view per cell. The heigt is needed to avoid ugly overlapping while loading
results - once the results are loaded, all rows are currently higher than that.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:

(.leaks-popover): Added.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotLeaksQueueView.js:

Added.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html:

Load BuildbotLeaksQueueView.js.

11:10 PM Changeset in webkit [179105] by Chris Dumez
  • 2 edits in trunk/Source/WebCore

Remove 'font' shorthand property special casing
​https://bugs.webkit.org/show_bug.cgi?id=140577

Reviewed by Darin Adler.

Mark CSSPrimitiveValue::m_value.fontFamily as const as it is not
supposed to change. This also makes sure that m_value.fontFamily
gets copied instead of moved when constructing a clone in
CSSPrimitiveValue::cloneForCSSOM(). This was causing several tests
to fail on the bots.

  • css/CSSPrimitiveValue.h:
10:29 PM Changeset in webkit [179104] by dbates@webkit.org
  • 4 edits
    115 moves
    2518 adds in trunk/LayoutTests

[iOS] Update expected results and test expectations

  • platform/ios-simulator-wk1/TestExpectations:
  • platform/ios-simulator-wk2/TestExpectations:
  • platform/ios-simulator/TestExpectations:

[...]

9:01 PM Changeset in webkit [179103] by ap@apple.com
  • 6 edits in trunk/LayoutTests

fast/html/marquee-scrollamount.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=140851

Reviewed by Darin Adler.

Updated the test to not have a zero delay timer race. Added many comments, because
what is being tested here is quite subtle.

  • fast/html/marquee-scrollamount.html:
  • platform/efl/fast/html/marquee-scrollamount-expected.txt:
  • platform/gtk/fast/html/marquee-scrollamount-expected.txt:
  • platform/ios-simulator-wk2/fast/html/marquee-scrollamount-expected.txt:
  • platform/mac/fast/html/marquee-scrollamount-expected.txt:

The DOM changed slightly, because we now insert the marquee after load event.

8:04 PM Changeset in webkit [179102] by ap@apple.com
  • 3 edits
    2 adds in trunk

Setting HTMLMarqueeElement.trueSpeed doesn't work
​https://bugs.webkit.org/show_bug.cgi?id=140863

Reviewed by Darin Adler.

Source/WebCore:

Test: fast/html/marquee-set-truespeed.html

  • html/HTMLMarqueeElement.cpp: (WebCore::HTMLMarqueeElement::minimumDelay):

Check the boolean attribute properly - an empty value is true.

LayoutTests:

Verify that setting scrollDelay to a value under 60 actually works when trueSpeed is set.

  • fast/html/marquee-set-truespeed-expected.html: Added.
  • fast/html/marquee-set-truespeed.html: Added.
7:22 PM Changeset in webkit [179101] by Darin Adler
  • 7 edits in trunk/Source/WebCore

Streamline SVGUseElement shadow tree handling and make it use SVGElementInstance less
​https://bugs.webkit.org/show_bug.cgi?id=140875

Reviewed by Anders Carlsson.

Refactoring of code that is pretty well covered by existing tests, so
not adding new tests.

Inspired by work Rob Buis did in Blink:

​http://src.chromium.org/viewvc/blink?view=revision&revision=173273

Althgouh that is less than half of what ended up in this patch.

  • dom/ContainerNode.h: Fixed NoEventDispatchAssertion so it can be

copied without causing an underflow of NoEventDispatchAssertion::s_count.
Made the copy constructor call the default constructor. Also changed it
to be based on ASSERT_DISABLED rather than NDEBUG and tweaked it a bit.

  • dom/ElementIteratorAssertions.h: Removed an unnecessary include and

an unnecessary default constructor. Changed to use WTF::Optional instead
of WTF::OwnPtr to handle NoEventDispatchAssertion, which makes this class
copyable and assignable, which in turn makes the iterators based on this
copyable and assignable, which is what I needed in SVGUseElement code.
Also simplified code in a couple places.

  • dom/TypedElementDescendantIterator.h:

(WebCore::TypedElementDescendantIteratorAdapter<ElementType>::from):
Fixed an error where the arguments to Traversal::next were passed backwards.
This led to incomplete iteration in SVGUseElement code, and an immediate
assertion failure. Probably could use some unit test coverage, too.
(WebCore::TypedElementDescendantConstIteratorAdapter<ElementType>::from):
Ditto.

  • svg/SVGUseElement.cpp:

(WebCore::SVGUseElement::animatedInstanceRoot): Deleted.
(WebCore::SVGUseElement::transferSizeAttributesToShadowTreeTargetClone):
Removed the originalElement argument, since we can use the correspondingElement
to get back to it. Removed the useElement argument and changed this into a
member function.
(WebCore::SVGUseElement::svgAttributeChanged): Updated for above changes.
(WebCore::subtreeContainsDisallowedElement): Deleted this function, because
it was only used to optimize by not calling removeDisallowedElementsFromSubtree,
but that function is already similarly efficient when called to do nothing, so
the preflight was not useful.
(WebCore::SVGUseElement::clearResourceReferences): Call userAgentShadowRoot
instead of shadowRoot for clarity.
(WebCore::SVGUseElement::buildPendingResource): Pass a reference instead of
a pointer to buildShadowAndInstanceTree, since it's guaranteed to not be null.
(WebCore::SVGUseElement::shadowTreeTargetClone): Added. Returns the SVG element
inside the shadow tree that corresponds to the use element's target.
(WebCore::SVGUseElement::buildShadowAndInstanceTree): Changed argument type
to a reference instead of a pointer. Removed comments explaining why we have
an instance tree, since soon we will not have one. Removed many comments that
simply state the names of the functions they are commenting on and perhaps a tiny
bit more. Changed to not use m_targetElementInstance as much, dealing with the
shadow tree directly instead of through the instance tree.
(WebCore::SVGUseElement::toClipPath): Use shadowTreeTargetClone instead of
getting at the element through m_targetElementInstance.
(WebCore::SVGUseElement::rendererClipChild): Ditto.
(WebCore::removeDisallowedElementsFromSubtree): Removed the inline keyword,
since there's no good reason to inline thif function's body. Improved local
variable names and used a modern for loop. Also moved the comment about why
this function is used here inside the function instead of repeating it at
each call site.
(WebCore::SVGUseElement::buildShadowTree): Changed to take a reference
instead of a pointer. Moved the check to see if the target is disallowed
out of this function and into buildShadowAndInstanceTree, which needs to
handle that failure explicitly. Tightened up the code a bit, using Ref instead
of RefPtr, putting the comment about removeDisallowedElementsFromSubtree into
that function itself, and removing the unneeded subtreeContainsDisallowedElement
check entirely.
(WebCore::SVGUseElement::expandUseElementsInShadowTree): Removed the argument,
getting the shadow tree from the shadowTree function instead. Walk the tree
iteratively instead of recursively, using the descendantsOfType function.
Rearranged and streamlined the logic.
(WebCore::SVGUseElement::expandSymbolElementsInShadowTree): Ditto.
(WebCore::SVGUseElement::transferEventListenersToShadowTree): Ditto.
(WebCore::SVGUseElement::transferAttributesToShadowTreeReplacement): Renamed
this to avoid the term "replaced element", which is not a reasonable way to
refer to the <g> element in the shadow tree that replaces the <use> element.
Changed the argument type to SVGGElement to make it harder to misuse this
function by accident, and made the use element be "this" instead of passing
it as an argument.
(WebCore::SVGUseElement::selfHasRelativeLengths): Call hasRelativeLengths
on the target inside the shadow tree rather than the original target, which
makes more sense anyway, and is straightforward now that we have the
shadowTreeTargetClone function. Removes use of m_targetElementInstance here.

  • svg/SVGUseElement.h: Updated for above changes.
  • svg/SVGUseElement.idl: Removed animatedInstanceRoot and tweaked formatting.
6:11 PM Changeset in webkit [179100] by Chris Dumez
  • 22 edits
    5 adds in trunk

Remove 'font' shorthand property special casing
​https://bugs.webkit.org/show_bug.cgi?id=140577

Reviewed by Darin Adler.

Source/WebCore:

Expand system font values during 'font' property parsing. The 'font'
CSS property was the only shorthand that wasn't always expanded in
the CSS parser, so it needed a lot of special handling that we can
now get rid of.

This patch is inspired from the following Blink revision:
​https://src.chromium.org/viewvc/blink?view=rev&revision=184449

Tests:

  • fast/css/css2-system-fonts.html (existing)
  • fast/css/CSSPrimitiveValue-font-family-primitiveType.html (new)
  • fast/css/font-systemFontID-parsing.html (new)
  • fast/css/font-shorthand-line-height.html (rebased)
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSCalculationValue.cpp:

(WebCore::hasDoubleValue):
Handle CSS_FONT_FAMILY similarly to CSS_STRING in the switch.

  • css/CSSFontFamily.h: Added.

Introduce new CSSFontFamily class to store font families inside
CSSPrimitive, instead of using a simple String as previously. We need
an additional 'fromSystemFontID' flag in addition to the font family
name now that system font ID are expanded during parsing. This
information is needed later on by the StyleBuilder (see comment below).

  • css/CSSFontSelector.cpp:

(WebCore::CSSFontSelector::addFontFaceRule):
Update code dealing with font family CSSPrimitiveValues now that they
hold a CSSFontFamily internally instead of a String.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseSystemFont):
Expand system font values for the 'font' property by asking the
RenderTheme for the system font and using it to set the 'font'
longhand properties.

  • css/CSSParserValues.cpp:

(WebCore::CSSParserValue::createCSSValue):
Handle CSS_FONT_FAMILY value in the switch.

  • css/CSSPrimitiveValue.cpp:

(WebCore::CSSPrimitiveValue::primitiveType):
Make sure we still expose font family CSSPrimitiveValues to the Web as
CSS_STRING, even though we are using a slightly different representation
internally. This is so that we don't change web-exposed behavior and I
added a new layout test to cover this.

(WebCore::isValidCSSUnitTypeForDoubleConversion):
(WebCore::CSSPrimitiveValue::cleanup):
(WebCore::CSSPrimitiveValue::getStringValue):
(WebCore::CSSPrimitiveValue::formatNumberForCustomCSSText):
(WebCore::CSSPrimitiveValue::cloneForCSSOM):
(WebCore::CSSPrimitiveValue::equals):
Handle CSS_FONT_FAMILY type in switches.

  • css/CSSPrimitiveValue.h:

(WebCore::CSSPrimitiveValue::isFontFamily):
Add method to test if a CSSPrimitiveValue holds a CSSFontFamily
internally.

(WebCore::CSSPrimitiveValue::fontFamily):
Add a getter to retrieve the internal CSSFontFamily object if the
primitive type is CSS_FONT_FAMILY.

  • css/CSSPropertyNames.in:

Treat 'font' as a regular shorthand property. Specify its longhand
properties so that makeprop.pl can generate the shorthand code for
us. Also demote 'font' to being a low-priority property as it is
now always expanded during parsing.

  • css/CSSValuePool.cpp:

(WebCore::CSSValuePool::createFontFamilyValue):

  • css/CSSValuePool.h:
  • css/StyleBuilderCustom.h:

(WebCore::StyleBuilderCustom::applyValueFontFamily):

  • Update the 'font-family' value setter in the StyleBuilder to reflect

the changes in the CSS parser. The CSSPrimitiveValues in the list now
have CSS_FONT_FAMILY type instead of CSS_STRING.

  • We also set the 'isGenericFamily' flag if the font-family was expanded from a system font ID (e.g. caption). The 'isGenericFamily' flag is used later on to property set the 'isSpecifiedFont' flag on the FontDescription object. If we don't do this, system font values will be treated as specified fonts, which means that we will no longer use the 'use backslash as Yen sign' hack for those. This is covered by the following layout tests:
    • fast/text/backslash-to-yen-sign-euc.html
    • editing/selection/find-yensign-and-backslash.html

(WebCore::StyleBuilderCustom::applyInitialFont): Deleted.
(WebCore::StyleBuilderCustom::applyInheritFont): Deleted.
(WebCore::StyleBuilderCustom::applyValueFont): Deleted.
Remove StyleBuilder code dealing with the 'font' property. Now that
the 'font' property is always expanded during parsing, this code can
never be reached.

  • css/StylePropertyShorthand.cpp:

(WebCore::isExpandedShorthand):
Stop returning false for 'font' as it is now expanded during parsing
as well. We should probably consider renaming this method to something
else now that all shorthands are expanded, maybe isCSSShorthand() or
isShorthandProperty().

(WebCore::fontShorthand): Deleted.

  • css/StylePropertyShorthand.h:

(WebCore::matchingCustomShorthandsForLonghand): Deleted.
Remove custom shorthand code for the 'font' property as it is now
generated by makeprop.pl, like other shorthands.

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::applyFont): Deleted.
This is unused now that the StyleBuilder code for 'font' has been
removed.

  • css/makeprop.pl:

Remove custom shorthand code for 'font' as it no longer requires any
special handling.

LayoutTests:

  • fast/css/CSSPrimitiveValue-font-family-primitiveType-expected.txt: Added.
  • fast/css/CSSPrimitiveValue-font-family-primitiveType.html: Added.

Add layout test to make sure that the font-family is still exposed to the
Web as a CSSValueList of CSSPrimitiveValues whose primitiveType is
CSS_STRING. This is useful because we now use a slightly different
representation internally.

  • fast/css/font-shorthand-line-height-expected.txt:
  • fast/css/font-shorthand-line-height.html:

Rebaseline the test. This is a progression. Setting the 'font' property
to a system font ID is supposed to reset the line-height property to
'normal'. It previously did not because system font IDs were not
expanded at parsing time. The new behavior is consistent with Chrome and
Firefox as well.

  • fast/css/font-systemFontID-parsing-expected.txt: Added.
  • fast/css/font-systemFontID-parsing.html: Added.

Add a layout test to make sure that the CSS parser is rejecting a 'font'
property with more than one system font id.

4:14 PM Changeset in webkit [179099] by ddkilzer@apple.com
  • 2 edits in branches/safari-600.1.4.15-branch/Source/WebCore

Merged r177449. rdar://problem/19419933

4:14 PM Changeset in webkit [179098] by ddkilzer@apple.com
  • 3 edits in branches/safari-600.1.4.15-branch/Source/WebCore

Merged r177444. rdar://problem/19419933

4:14 PM Changeset in webkit [179097] by ddkilzer@apple.com
  • 2 edits in branches/safari-600.1.4.15-branch/Source/WebKit2

Merged r177332. rdar://problem/19419933

4:14 PM Changeset in webkit [179096] by ddkilzer@apple.com
  • 2 edits in branches/safari-600.1.4.15-branch/Source/WebCore

Merged r177306. rdar://problem/19419933

4:14 PM Changeset in webkit [179095] by ddkilzer@apple.com
  • 18 edits in branches/safari-600.1.4.15-branch/Source

Merged r177301. rdar://problem/19419933

4:14 PM Changeset in webkit [179094] by ddkilzer@apple.com
  • 5 edits
    8 adds in branches/safari-600.1.4.15-branch

Merged r177050. rdar://problem/19419933

4:14 PM Changeset in webkit [179093] by ddkilzer@apple.com
  • 1 edit in branches/safari-600.1.4.15-branch/Source/WebCore/ChangeLog

Merged r177041. rdar://problem/19419933

4:14 PM Changeset in webkit [179092] by ddkilzer@apple.com
  • 29 edits in branches/safari-600.1.4.15-branch

Merged r177035. rdar://problem/19419933

11:40 AM Changeset in webkit [179091] by Brent Fulgham
  • 2 edits in trunk/LayoutTests

[Win] Unreviewed gardening.

Document a few more failures in the expectations file.

  • platform/win/TestExpectations:
11:28 AM Changeset in webkit [179090] by Brent Fulgham
  • 2 edits in trunk/LayoutTests

[Win] Document some Debug crashes in Accessibility code.

  • platform/win/TestExpectations:
10:37 AM Changeset in webkit [179089] by Brent Fulgham
  • 2 edits in trunk/LayoutTests

[Win] Unreviewed gardening.

Skip crashes and timeouts to speed up test runs.

  • platform/win/TestExpectations:
10:01 AM Changeset in webkit [179088] by commit-queue@webkit.org
  • 9 edits
    3 adds in trunk

[Win] Add WebKit message loop interface.
​https://bugs.webkit.org/show_bug.cgi?id=140857

Patch by ​peavo@outlook.com <​peavo@outlook.com> on 2015-01-25
Reviewed by Brent Fulgham.

Added message loop interface which will run the message loop,
and perform required tasks (like calling CFRunLoopRunInMode)
on each iteration of the loop.

Source/WebKit:

  • WebKit.vcxproj/WebKit/WebKit.vcxproj: Added new files to project.
  • WebKit.vcxproj/WebKit/WebKit.vcxproj.filters: Ditto.

Source/WebKit/win:

  • ForEachCoClass.h:
  • Interfaces/WebKit.idl:
  • Interfaces/WebKitMessageLoop.idl: Added.
  • WebKitClassFactory.cpp:
  • WebKitMessageLoop.cpp: Added.

(WebKitMessageLoop::WebKitMessageLoop):
(WebKitMessageLoop::~WebKitMessageLoop):
(WebKitMessageLoop::createInstance):
(WebKitMessageLoop::QueryInterface):
(WebKitMessageLoop::AddRef):
(WebKitMessageLoop::Release):
(WebKitMessageLoop::run):
(WebKitMessageLoop::performMessageLoopTasks):

  • WebKitMessageLoop.h: Added.

Tools:

  • WinLauncher/WinMain.cpp:

(wWinMain): Use new message loop interface.

12:20 AM Changeset in webkit [179087] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit2

Unresponsive Web processes sometimes throw ObjC exceptions under didPerformActionMenuHitTest:
​https://bugs.webkit.org/show_bug.cgi?id=140859
<rdar://problem/19571057>

Reviewed by Darin Adler.

  • UIProcess/mac/WKImmediateActionController.mm:

(-[WKImmediateActionController didPerformActionMenuHitTest:userData:]):
If we've already given up on this gesture (either because it was canceled or the
willBeginAnimation timeout expired), we shouldn't build a new animationController for it.
This is true both because it wouldn't look good to swap animationControllers out
from under the gesture, but also because AppKit throws an exception when you do this
and that breaks a lot of things.

12:17 AM Changeset in webkit [179086] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebCore

Long spins under Frame::rangeForPoint when doing Lookup on feedly.com
​https://bugs.webkit.org/show_bug.cgi?id=140862
<rdar://problem/19566089>

Reviewed by Dan Bernstein.

  • page/Frame.cpp:

(WebCore::Frame::rangeForPoint):
If there isn't a selectable text node at the given point, rangeForPoint
will eventually return null. However, we can make it fail much faster
by checking the initial position's text-ness and selectability.

12:02 AM Changeset in webkit [179085] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/LayoutTests

Unreviewed, gardening for EFL port.

  • platform/efl/TestExpectations: media/media-fullscreen-inline.html has been passed since r19100.

Jan 24, 2015:

11:35 PM Changeset in webkit [179084] by Brent Fulgham
  • 16 edits
    13 adds in trunk/LayoutTests

[Win] More rebaselines. (Tables)

  • platform/win/tables/mozilla/bugs/bug1188-expected.png: Added.
  • platform/win/tables/mozilla/bugs/bug1188-expected.txt:
  • platform/win/tables/mozilla/bugs/bug18359-expected.png: Added.
  • platform/win/tables/mozilla/bugs/bug18359-expected.txt:
  • platform/win/tables/mozilla/bugs/bug2479-3-expected.png: Added.
  • platform/win/tables/mozilla/bugs/bug2479-3-expected.txt:
  • platform/win/tables/mozilla/bugs/bug2479-4-expected.png: Added.
  • platform/win/tables/mozilla/bugs/bug2479-4-expected.txt:
  • platform/win/tables/mozilla/bugs/bug29326-expected.png: Added.
  • platform/win/tables/mozilla/bugs/bug29326-expected.txt:
  • platform/win/tables/mozilla/bugs/bug33855-expected.png: Added.
  • platform/win/tables/mozilla/bugs/bug33855-expected.txt:
  • platform/win/tables/mozilla/bugs/bug4382-expected.png: Added.
  • platform/win/tables/mozilla/bugs/bug4382-expected.txt:
  • platform/win/tables/mozilla/bugs/bug4527-expected.txt:
  • platform/win/tables/mozilla/bugs/bug96334-expected.png: Added.
  • platform/win/tables/mozilla/bugs/bug96334-expected.txt:
  • platform/win/tables/mozilla/core/margins-expected.png: Added.
  • platform/win/tables/mozilla/core/margins-expected.txt:
  • platform/win/tables/mozilla/dom/tableDom-expected.png: Added.
  • platform/win/tables/mozilla/dom/tableDom-expected.txt:
  • platform/win/tables/mozilla/other/move_row-expected.txt:
  • platform/win/tables/mozilla_expected_failures/bugs/bug2479-5-expected.png: Added.
  • platform/win/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:
  • platform/win/tables/mozilla_expected_failures/core/captions1-expected.png: Added.
  • platform/win/tables/mozilla_expected_failures/core/captions1-expected.txt:
  • platform/win/tables/mozilla_expected_failures/core/captions2-expected.png: Added.
  • platform/win/tables/mozilla_expected_failures/core/captions2-expected.txt:
11:14 PM Changeset in webkit [179083] by Brent Fulgham
  • 67 edits
    43 adds in trunk/LayoutTests

[Win] Unreviewed rebaselining.

Second batch: Fast

  • platform/win/fast/block/float/float-avoidance-expected.png: Added.
  • platform/win/fast/block/margin-collapse/103-expected.png: Added.
  • platform/win/fast/canvas/fallback-content-expected.txt:
  • platform/win/fast/css/non-standard-checkbox-size-expected.png: Added.
  • platform/win/fast/css/non-standard-checkbox-size-expected.txt:
  • platform/win/fast/dom/HTMLInputElement/input-slider-update-expected.txt:
  • platform/win/fast/forms/001-expected.png:
  • platform/win/fast/forms/001-expected.txt:
  • platform/win/fast/forms/003-expected.png: Added.
  • platform/win/fast/forms/003-expected.txt:
  • platform/win/fast/forms/004-expected.png: Added.
  • platform/win/fast/forms/004-expected.txt:
  • platform/win/fast/forms/HTMLOptionElement_label01-expected.png: Added.
  • platform/win/fast/forms/HTMLOptionElement_label01-expected.txt:
  • platform/win/fast/forms/HTMLOptionElement_label02-expected.png: Added.
  • platform/win/fast/forms/HTMLOptionElement_label02-expected.txt:
  • platform/win/fast/forms/HTMLOptionElement_label03-expected.png: Added.
  • platform/win/fast/forms/HTMLOptionElement_label03-expected.txt:
  • platform/win/fast/forms/HTMLOptionElement_label04-expected.png: Added.
  • platform/win/fast/forms/HTMLOptionElement_label04-expected.txt:
  • platform/win/fast/forms/HTMLOptionElement_label06-expected.txt:
  • platform/win/fast/forms/HTMLOptionElement_label07-expected.txt:
  • platform/win/fast/forms/basic-inputs-expected.png:
  • platform/win/fast/forms/basic-inputs-expected.txt:
  • platform/win/fast/forms/basic-selects-expected.png:
  • platform/win/fast/forms/basic-selects-expected.txt:
  • platform/win/fast/forms/basic-textareas-quirks-expected.png: Added.
  • platform/win/fast/forms/box-shadow-override-expected.png:
  • platform/win/fast/forms/box-shadow-override-expected.txt:
  • platform/win/fast/forms/control-clip-overflow-expected.png: Added.
  • platform/win/fast/forms/control-clip-overflow-expected.txt:
  • platform/win/fast/forms/control-restrict-line-height-expected.png: Added.
  • platform/win/fast/forms/control-restrict-line-height-expected.txt:
  • platform/win/fast/forms/disabled-select-change-index-expected.png: Added.
  • platform/win/fast/forms/disabled-select-change-index-expected.txt:
  • platform/win/fast/forms/file/file-input-disabled-expected.png:
  • platform/win/fast/forms/file/file-input-disabled-expected.txt:
  • platform/win/fast/forms/form-element-geometry-expected.png: Added.
  • platform/win/fast/forms/form-element-geometry-expected.txt:
  • platform/win/fast/forms/formmove-expected.png: Added.
  • platform/win/fast/forms/formmove-expected.txt:
  • platform/win/fast/forms/indeterminate-expected.png: Added.
  • platform/win/fast/forms/indeterminate-expected.txt:
  • platform/win/fast/forms/input-appearance-height-expected.png: Added.
  • platform/win/fast/forms/input-appearance-height-expected.txt:
  • platform/win/fast/forms/input-appearance-selection-expected.png: Added.
  • platform/win/fast/forms/input-appearance-selection-expected.txt: Added.
  • platform/win/fast/forms/menulist-deselect-update-expected.txt:
  • platform/win/fast/forms/menulist-no-overflow-expected.png: Added.
  • platform/win/fast/forms/menulist-no-overflow-expected.txt:
  • platform/win/fast/forms/menulist-restrict-line-height-expected.png: Added.
  • platform/win/fast/forms/menulist-restrict-line-height-expected.txt:
  • platform/win/fast/forms/menulist-separator-painting-expected.txt:
  • platform/win/fast/forms/menulist-style-color-expected.png:
  • platform/win/fast/forms/menulist-style-color-expected.txt:
  • platform/win/fast/forms/menulist-width-change-expected.txt:
  • platform/win/fast/forms/option-script-expected.txt:
  • platform/win/fast/forms/option-strip-whitespace-expected.png: Added.
  • platform/win/fast/forms/option-strip-whitespace-expected.txt:
  • platform/win/fast/forms/option-text-clip-expected.png:
  • platform/win/fast/forms/option-text-clip-expected.txt:
  • platform/win/fast/forms/range/input-appearance-range-expected.png: Added.
  • platform/win/fast/forms/range/input-appearance-range-expected.txt:
  • platform/win/fast/forms/range/slider-delete-while-dragging-thumb-expected.txt: Added.
  • platform/win/fast/forms/range/slider-mouse-events-expected.txt:
  • platform/win/fast/forms/range/slider-onchange-event-expected.txt: Added.
  • platform/win/fast/forms/range/slider-padding-expected.txt:
  • platform/win/fast/forms/range/slider-thumb-shared-style-expected.png: Added.
  • platform/win/fast/forms/range/slider-thumb-shared-style-expected.txt:
  • platform/win/fast/forms/range/slider-zoomed-expected.txt: Added.
  • platform/win/fast/forms/select-align-expected.png: Added.
  • platform/win/fast/forms/select-align-expected.txt:
  • platform/win/fast/forms/select-background-none-expected.txt:
  • platform/win/fast/forms/select-baseline-expected.png: Added.
  • platform/win/fast/forms/select-baseline-expected.txt:
  • platform/win/fast/forms/select-change-listbox-to-popup-expected.png: Added.
  • platform/win/fast/forms/select-change-listbox-to-popup-expected.txt:
  • platform/win/fast/forms/select-change-popup-to-listbox-expected.png: Added.
  • platform/win/fast/forms/select-change-popup-to-listbox-expected.txt: Added.
  • platform/win/fast/forms/select-disabled-appearance-expected.png: Added.
  • platform/win/fast/forms/select-disabled-appearance-expected.txt:
  • platform/win/fast/forms/select-initial-position-expected.png: Added.
  • platform/win/fast/forms/select-initial-position-expected.txt:
  • platform/win/fast/forms/select-selected-expected.png: Added.
  • platform/win/fast/forms/select-selected-expected.txt:
  • platform/win/fast/forms/select-size-expected.txt:
  • platform/win/fast/forms/select-style-expected.png: Added.
  • platform/win/fast/forms/select-style-expected.txt:
  • platform/win/fast/forms/select-visual-hebrew-expected.txt:
  • platform/win/fast/forms/select-writing-direction-natural-expected.png:
  • platform/win/fast/forms/select-writing-direction-natural-expected.txt:
  • platform/win/fast/forms/select/optgroup-rendering-expected.png:
  • platform/win/fast/forms/select/optgroup-rendering-expected.txt:
  • platform/win/fast/forms/selectlist-minsize-expected.txt:
  • platform/win/fast/forms/stuff-on-my-optgroup-expected.png: Added.
  • platform/win/fast/forms/stuff-on-my-optgroup-expected.txt:
  • platform/win/fast/invalid: Added.
  • platform/win/fast/invalid/014-expected.txt: Added.
  • platform/win/fast/multicol/pagination/RightToLeft-rl-hittest-expected.txt:
  • platform/win/fast/parser: Added.
  • platform/win/fast/parser/entity-comment-in-textarea-expected.txt: Added.
  • platform/win/fast/parser/open-comment-in-textarea-expected.txt: Added.
  • platform/win/fast/repaint/slider-thumb-drag-release-expected.txt:
  • platform/win/fast/replaced/three-selects-break-expected.txt:
  • platform/win/fast/text/international/bidi-menulist-expected.txt:
  • platform/win/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt:
  • platform/win/fast/text/textIteratorNilRenderer-expected.txt:
9:46 PM Changeset in webkit [179082] by Brent Fulgham
  • 22 edits in trunk/LayoutTests

[Win] Unreviewed baseline update.

First batch: CSS updates.

  • platform/win/css2.1/t09-c5526c-display-00-e-expected.txt:
  • platform/win/css3/selectors3/html/css3-modsel-161-expected.png:
  • platform/win/css3/selectors3/html/css3-modsel-161-expected.txt:
  • platform/win/css3/selectors3/html/css3-modsel-25-expected.png:
  • platform/win/css3/selectors3/html/css3-modsel-25-expected.txt:
  • platform/win/css3/selectors3/html/css3-modsel-70-expected.png:
  • platform/win/css3/selectors3/html/css3-modsel-70-expected.txt:
  • platform/win/css3/selectors3/xhtml/css3-modsel-161-expected.png:
  • platform/win/css3/selectors3/xhtml/css3-modsel-161-expected.txt:
  • platform/win/css3/selectors3/xhtml/css3-modsel-25-expected.png:
  • platform/win/css3/selectors3/xhtml/css3-modsel-25-expected.txt:
  • platform/win/css3/selectors3/xhtml/css3-modsel-70-expected.png:
  • platform/win/css3/selectors3/xhtml/css3-modsel-70-expected.txt:
  • platform/win/css3/selectors3/xml/css3-modsel-161-expected.png:
  • platform/win/css3/selectors3/xml/css3-modsel-161-expected.txt:
  • platform/win/css3/selectors3/xml/css3-modsel-25-expected.png:
  • platform/win/css3/selectors3/xml/css3-modsel-25-expected.txt:
  • platform/win/css3/selectors3/xml/css3-modsel-70-expected.png:
  • platform/win/css3/selectors3/xml/css3-modsel-70-expected.txt:
  • platform/win/fast/block/float/float-avoidance-expected.txt:
  • platform/win/fast/block/margin-collapse/103-expected.txt:
8:36 PM Changeset in webkit [179081] by mitz@apple.com
  • 2 edits in trunk/Tools

update-webkit’s --internal option is unused
​https://bugs.webkit.org/show_bug.cgi?id=140861

Reviewed by Anders Carlsson.

  • Scripts/update-webkit: Removed the option.
7:02 PM Changeset in webkit [179080] by Chris Dumez
  • 2 edits in trunk/Source/WebKit2

[WK2][Cocoa] Drop WKDiagnosticLoggingResultType defines
​https://bugs.webkit.org/show_bug.cgi?id=140838

Reviewed by Sam Weinig.

Drop WKDiagnosticLoggingResultType defines in _WKDiagnosticLoggingDelegate.h
header now that the client-side is correctly using
_WKDiagnosticLoggingResultType instead.

  • UIProcess/API/Cocoa/_WKDiagnosticLoggingDelegate.h:
6:55 PM Changeset in webkit [179079] by Brent Fulgham
  • 26 edits
    81 adds in trunk/LayoutTests

[Win] Unreviewed gardening. Reactivating tests.

Re-enable a series of tests that work properly on Windows. New baselines will be needed.

  • platform/win/TestExpectations:
  • platform/win/css1/box_properties/acid_test-expected.png: Added.
  • platform/win/css1/box_properties/acid_test-expected.txt:
  • platform/win/editing/input/caret-at-the-edge-of-input-expected.txt:
  • platform/win/fast/block/float/float-avoidance-expected.txt:
  • platform/win/fast/block/margin-collapse/103-expected.txt:
  • platform/win/fast/css/box-shadow-and-border-radius-expected.png:
  • platform/win/fast/dynamic/008-expected.txt: Added.
  • platform/win/fast/forms/001-expected.png: Added.
  • platform/win/fast/forms/001-expected.txt:
  • platform/win/fast/forms/003-expected.txt:
  • platform/win/fast/forms/004-expected.txt:
  • platform/win/fast/forms/006-expected.png: Added.
  • platform/win/fast/forms/007-expected.png: Added.
  • platform/win/fast/forms/HTMLOptionElement_label01-expected.txt: Added.
  • platform/win/fast/forms/HTMLOptionElement_label02-expected.txt: Added.
  • platform/win/fast/forms/HTMLOptionElement_label03-expected.txt: Added.
  • platform/win/fast/forms/HTMLOptionElement_label04-expected.txt: Added.
  • platform/win/fast/forms/HTMLOptionElement_label05-expected.txt: Added.
  • platform/win/fast/forms/HTMLOptionElement_label06-expected.txt: Removed property svn:executable.
  • platform/win/fast/forms/HTMLOptionElement_label07-expected.txt: Added.
  • platform/win/fast/forms/basic-buttons-expected.png: Added.
  • platform/win/fast/forms/basic-buttons-expected.txt: Added.
  • platform/win/fast/forms/basic-inputs-expected.png: Added.
  • platform/win/fast/forms/basic-selects-expected.txt:
  • platform/win/fast/forms/basic-textareas-expected.png: Added.
  • platform/win/fast/forms/box-shadow-override-expected.png: Added.
  • platform/win/fast/forms/box-shadow-override-expected.txt: Added.
  • platform/win/fast/forms/button-positioned-expected.txt: Added.
  • platform/win/fast/forms/button-sizes-expected.txt: Added.
  • platform/win/fast/forms/button-style-color-expected.txt: Added.
  • platform/win/fast/forms/button-text-transform-expected.txt: Added.
  • platform/win/fast/forms/control-clip-overflow-expected.txt: Added.
  • platform/win/fast/forms/control-restrict-line-height-expected.txt:
  • platform/win/fast/forms/disabled-select-change-index-expected.txt: Added.
  • platform/win/fast/forms/form-element-geometry-expected.txt: Added.
  • platform/win/fast/forms/hidden-listbox-expected.txt: Added.
  • platform/win/fast/forms/input-appearance-focus-expected.txt: Added.
  • platform/win/fast/forms/input-double-click-selection-gap-bug-expected.txt: Added.
  • platform/win/fast/forms/input-readonly-autoscroll-expected.txt: Added.
  • platform/win/fast/forms/input-text-double-click-expected.txt: Added.
  • platform/win/fast/forms/listbox-hit-test-zoomed-expected.txt: Added.
  • platform/win/fast/forms/listbox-scrollbar-incremental-load-expected.txt: Added.
  • platform/win/fast/forms/listbox-width-change-expected.txt: Added.
  • platform/win/fast/forms/menulist-deselect-update-expected.txt:
  • platform/win/fast/forms/menulist-no-overflow-expected.txt: Added.
  • platform/win/fast/forms/number/number-appearance-rtl-expected.txt: Added.
  • platform/win/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.txt: Added.
  • platform/win/fast/forms/number/number-appearance-spinbutton-layer-expected.txt: Added.
  • platform/win/fast/forms/option-strip-whitespace-expected.txt: Added.
  • platform/win/fast/forms/plaintext-mode-2-expected.txt: Added.
  • platform/win/fast/forms/search: Added.
  • platform/win/fast/forms/search/search-size-with-decorations-expected.txt: Added.
  • platform/win/fast/forms/select-align-expected.txt: Added.
  • platform/win/fast/forms/select-baseline-expected.txt: Added.
  • platform/win/fast/forms/select-block-background-expected.txt: Added.
  • platform/win/fast/forms/select-change-listbox-size-expected.txt: Added.
  • platform/win/fast/forms/select-change-listbox-to-popup-expected.txt: Added.
  • platform/win/fast/forms/select-dirty-parent-pref-widths-expected.txt: Added.
  • platform/win/fast/forms/select-disabled-appearance-expected.txt: Added.
  • platform/win/fast/forms/select-initial-position-expected.txt: Added.
  • platform/win/fast/forms/select-item-background-clip-expected.txt: Added.
  • platform/win/fast/forms/select-list-box-with-height-expected.txt: Added.
  • platform/win/fast/forms/select-selected-expected.txt: Added.
  • platform/win/fast/forms/select/optgroup-rendering-expected.txt:
  • platform/win/fast/forms/tabbing-input-iframe-expected.txt: Added.
  • platform/win/fast/frames: Added.
  • platform/win/fast/frames/take-focus-from-iframe-expected.txt: Added.
  • platform/win/fast/multicol/pagination: Added.
  • platform/win/fast/multicol/pagination/LeftToRight-tb-hittest-expected.txt: Added.
  • platform/win/fast/multicol/pagination/RightToLeft-rl-hittest-expected.txt: Added.
  • platform/win/fast/overflow/entity-comment-in-textarea-expected.txt: Added.
  • platform/win/fast/overflow/open-comment-in-textarea-expected.txt: Added.
  • platform/win/fast/overflow/overflow-x-y-expected.txt: Added.
  • platform/win/fast/table/003-expected.txt: Added.
  • platform/win/fast/table/colspanMinWidth-expected.txt: Added.
  • platform/win/fast/table/colspanMinWidth-vertical-expected.txt: Added.
  • platform/win/tables/mozilla/bugs/bug103533-expected.txt: Added.
  • platform/win/tables/mozilla/bugs/bug1188-expected.txt: Added.
  • platform/win/tables/mozilla/bugs/bug12384-expected.txt: Added.
  • platform/win/tables/mozilla/bugs/bug1318-expected.txt: Added.
  • platform/win/tables/mozilla/bugs/bug18359-expected.txt:
  • platform/win/tables/mozilla/bugs/bug2479-2-expected.txt: Added.
  • platform/win/tables/mozilla/bugs/bug26178-expected.txt:
  • platform/win/tables/mozilla/bugs/bug28928-expected.txt:
  • platform/win/tables/mozilla/bugs/bug29326-expected.txt: Added.
  • platform/win/tables/mozilla/bugs/bug30559-expected.txt:
  • platform/win/tables/mozilla/bugs/bug30692-expected.txt: Added.
  • platform/win/tables/mozilla/bugs/bug33855-expected.txt:
  • platform/win/tables/mozilla/bugs/bug4382-expected.txt: Added.
  • platform/win/tables/mozilla/bugs/bug4429-expected.txt:
  • platform/win/tables/mozilla/bugs/bug44505-expected.txt: Added.
  • platform/win/tables/mozilla/bugs/bug51037-expected.txt:
  • platform/win/tables/mozilla/bugs/bug55545-expected.txt: Added.
  • platform/win/tables/mozilla/bugs/bug92647-2-expected.txt: Added.
  • platform/win/tables/mozilla/bugs/bug96334-expected.txt: Added.
  • platform/win/tables/mozilla/bugs/bug99948-expected.txt: Added.
  • platform/win/tables/mozilla/core: Added.
  • platform/win/tables/mozilla/core/bloomberg-expected.txt: Added.
  • platform/win/tables/mozilla/core/margins-expected.txt: Added.
  • platform/win/tables/mozilla/dom/tableDom-expected.txt:
  • platform/win/tables/mozilla/marvin/x_col_align_justify-expected.png: Added.
  • platform/win/tables/mozilla_expected_failures/bugs/bug1725-expected.txt:
  • platform/win/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:
  • platform/win/tables/mozilla_expected_failures/bugs/bug45621-expected.txt: Added.
  • platform/win/tables/mozilla_expected_failures/bugs/bug58402-2-expected.txt:
5:28 PM Changeset in webkit [179078] by ddkilzer@apple.com
  • 2 edits in branches/safari-600.1.4.15-branch/Source/WebCore

Merged r176725. rdar://problem/19432746

5:28 PM Changeset in webkit [179077] by ddkilzer@apple.com
  • 5 edits in branches/safari-600.1.4.15-branch/Source/WebCore

Merged 'resolvedURL' changes from r176108. rdar://problem/19432746

4:54 PM Changeset in webkit [179076] by ddkilzer@apple.com
  • 2 edits in branches/safari-600.1.4.15-branch/Source/WebCore

Merged r176475. rdar://problem/19450119

4:54 PM Changeset in webkit [179075] by ddkilzer@apple.com
  • 2 edits in branches/safari-600.1.4.15-branch/Source/WebCore

Merged r175251. rdar://problem/19450119

4:08 PM Changeset in webkit [179074] by Brent Fulgham
  • 2 edits in trunk/Tools

DumpRenderTree needs to run with Windows native controls on Windows
​https://bugs.webkit.org/show_bug.cgi?id=25592

Reviewed by Anders Carlsson.

  • DumpRenderTree/win/DumpRenderTree.cpp:

(resetWebPreferencesToConsistentValues): Tell DRT to use native controls.
(prepareConsistentTestingEnvironment): Ditto.

12:36 PM Changeset in webkit [179073] by ddkilzer@apple.com
  • 4 edits in branches/safari-600.1.4.15-branch/Source/WebKit2

Merged r176382. rdar://problem/19419810

12:30 PM Changeset in webkit [179072] by ddkilzer@apple.com
  • 3 edits
    2 adds in branches/safari-600.1.4.15-branch

Merged r176321. rdar://problem/19369495

12:16 PM Changeset in webkit [179071] by ddkilzer@apple.com
  • 8 edits
    2 adds in branches/safari-600.1.4.15-branch

Merged r176262. rdar://problem/19432679

12:16 PM Changeset in webkit [179070] by ddkilzer@apple.com
  • 2 edits in branches/safari-600.1.4.15-branch/Source/WebCore

Merged r175260. rdar://problem/19432679

11:55 AM Changeset in webkit [179069] by Darin Adler
  • 7 edits
    6 adds in trunk

Move height/width implementation for use element from RenderSVGViewportContainer to SVGUseElement
​https://bugs.webkit.org/show_bug.cgi?id=140826

Reviewed by Anders Carlsson.

Source/WebCore:

Tests: svg/animations/use-animate-width-and-height.html

svg/custom/use-attribute-invalidations.html
svg/custom/use-dynamic-attribute-setting.html

This is an adaptation of work Rob Buis did in Blink:

​http://src.chromium.org/viewvc/blink?view=revision&revision=173258

The goal here is to reduce use of SVGElementInstance since we are going to
remove it. The tests Rob added to Blink (which I believe I improved a bit here)
meant we had to fix quite a few bugs in the implementation of the width/height
logic rather than just moving it. Even so, this could use even more test coverage
since there is separate logic for <symbol> and <svg>, three different code paths
(animation/attribute setting, initial creation, and one other), and also
distinct issues for attributes not set at all, attributes set to values that
can't be parsed, and attributes set with different units.

  • rendering/svg/RenderSVGViewportContainer.cpp:

(WebCore::RenderSVGViewportContainer::calcViewport): Removed the old logic.

  • svg/SVGSVGElement.cpp:

(WebCore::SVGSVGElement::SVGSVGElement): Use ASCIILiteral to more efficiently
create strings from ASCII literals here.
(WebCore::SVGSVGElement::parseAttribute): Default to 100%, not 0, when the
width or height property are either not set or not successfully parsed. Without
this change, one of the SVG tests starts failing.

  • svg/SVGUseElement.cpp:

(WebCore::updateWidthAndHeight): Added. The tricky part here is that we have
to copy width and height attributes only if they were successfully parsed, and
also we need to copy the current animating values, not the original attribute
strings. Kind of messy, but I wanted to adapt Rob's solution for the time being,
rather than inventing something new.
(WebCore::SVGUseElement::svgAttributeChanged): Call updateWidthAndHeight.
This is used both when actual attribute changes occur and also when animation
changes the current value.
(WebCore::SVGUseElement::buildShadowAndInstanceTree): Call updateWidthAndHeight.
This is used when the shadow elements are first created.
(WebCore::SVGUseElement::expandUseElementsInShadowTree): Call updateWidthAndHeight.
This was in Rob's patch, but I am not sure we have sufficient test coverage.

LayoutTests:

  • platform/mac/svg/custom/relative-sized-shadow-tree-content-with-symbol-expected.png: Old test

result was expecting failure. New one expects success.

  • platform/mac/svg/custom/relative-sized-shadow-tree-content-with-symbol-expected.txt: Ditto.
  • svg/animations/use-animate-width-and-height-expected.txt: Added.
  • svg/animations/use-animate-width-and-height.html: Added.
  • svg/custom/use-attribute-invalidations-expected.html: Added.
  • svg/custom/use-attribute-invalidations.html: Added.
  • svg/custom/use-dynamic-attribute-setting-expected.html: Added.
  • svg/custom/use-dynamic-attribute-setting.html: Added.
11:14 AM Changeset in webkit [179068] by ddkilzer@apple.com
  • 3 edits in branches/safari-600.1.4.15-branch/Source/WebCore

Merged r175976. rdar://problem/19420064

10:57 AM Changeset in webkit [179067] by ddkilzer@apple.com
  • 3 edits in branches/safari-600.1.4.15-branch/Source/WebCore

Merged r175585. rdar://problem/19419818

10:30 AM Changeset in webkit [179066] by ddkilzer@apple.com
  • 2 edits in branches/safari-600.1.4.15-branch/Source/WebKit2

Merged small change from r175549. rdar://problem/19433134

9:27 AM Changeset in webkit [179065] by ddkilzer@apple.com
  • 3 edits
    2 adds in branches/safari-600.1.4.15-branch

Merged r174860. rdar://problem/19419859

9:00 AM Changeset in webkit [179064] by ddkilzer@apple.com
  • 3 edits
    7 adds in branches/safari-600.1.4.15-branch

Merged r175085. rdar://problem/19419853

9:00 AM Changeset in webkit [179063] by ddkilzer@apple.com
  • 5 edits in branches/safari-600.1.4.15-branch/Source/WebCore

Merged r174356. rdar://problem/19419853

9:00 AM Changeset in webkit [179062] by ddkilzer@apple.com
  • 3 edits in branches/safari-600.1.4.15-branch/Source/WebCore

Merged branch-only patch (r0). rdar://problem/19564738

8:28 AM Changeset in webkit [179061] by Chris Dumez
  • 4 edits in trunk/Source

Provide implementation for WTF::DefaultHash<bool>
​https://bugs.webkit.org/show_bug.cgi?id=140848

Reviewed by Anders Carlsson.

Source/WebCore:

Use HashMap<std::pair<UChar32, bool>> type in Font.cpp for
CharacterFallbackMap instead of HashMap<std::pair<UChar32, unsigned>>.
It builds now that WTF::DefaultHash<bool> is defined in WTF.

  • platform/graphics/Font.cpp:

(WebCore::Font::removeFromSystemFallbackCache):

Source/WTF:

Provide implementation for WTF::DefaultHash<bool> so that we can use
HashMap<std::pair<XXX, bool>> in the code base. Right now, we need to
use some integer type to work around the issue.

  • wtf/HashFunctions.h:
Note: See TracTimeline for information about the timeline view.